Project

General

Profile

Activity

From 11/17/2017 to 12/16/2017

12/16/2017

11:07 PM Bug #3381: Sub-menu drawing issues
Task branch @3394a@ has been updated for review to revision @11272@.
This is the fix for menu regressions/issues/n...
Eugenie Lyzenko

12/15/2017

06:24 PM Feature #3394: generic drawing improvements: repaint and other misc code
3394a rev 11269 was rebased with trunk rev 11210. 3394a new rev is 11271. Constantin Asofiei
01:18 PM Feature #3394: generic drawing improvements: repaint and other misc code
This implementation of @WindowGuiImpl.this.isDesktopMinimized()@ is confusing ... Sergey Ivanovskiy
01:00 PM Feature #3394: generic drawing improvements: repaint and other misc code
I think that this implementation @WindowGuiImpl.iconify(postEvent)@ to iconify window is incorrect... Sergey Ivanovskiy
10:24 AM Feature #3394: generic drawing improvements: repaint and other misc code
Constantin Asofiei wrote:
>.. I ask because I have some more generic fixes related to focus window (which affect Swi...
Sergey Ivanovskiy
05:57 PM Bug #3381: Sub-menu drawing issues
Hynek Cihlar wrote:
> Eugenie, I think there is another regression in the menu bar. The delayed submenu hiding doesn...
Eugenie Lyzenko
04:52 PM Bug #3381: Sub-menu drawing issues
Task branch @3394a@ has been updated for review to revision @11268@.
Undo for menu show/hide delay implementation....
Eugenie Lyzenko
03:48 PM Bug #3381: Sub-menu drawing issues
Greg Shah wrote:
> Please comment out the delay code to disable it. I want to ensure it can be added later if neede...
Eugenie Lyzenko
03:30 PM Bug #3381: Sub-menu drawing issues
Please comment out the delay code to disable it. I want to ensure it can be added later if needed, but for now I pre... Greg Shah
03:23 PM Bug #3381: Sub-menu drawing issues
Greg Shah wrote:
> Code Review Task Branch 3394a Revision 11267
> ...
> 1. Does the delay implementation improve t...
Eugenie Lyzenko
11:58 AM Bug #3381: Sub-menu drawing issues
Hynek Cihlar wrote:
> Another exception when menu bar menu item is mouse-highlighted and arrow keys pressed.
>
> ...
Sergey Ivanovskiy
06:39 AM Bug #3381: Sub-menu drawing issues
Eugenie, I think there is another regression in the menu bar. The delayed submenu hiding doesn't seem to apply there ... Hynek Cihlar
06:37 AM Bug #3381: Sub-menu drawing issues
Another exception when menu bar menu item is mouse-highlighted and arrow keys pressed.... Hynek Cihlar
06:22 AM Bug #3381: Sub-menu drawing issues
Code Review Task Branch 3394a Revision 11267
The delay implementation seems good. I'm still not sure I like havin...
Greg Shah
06:12 AM Bug #3381: Sub-menu drawing issues
Eugenie Lyzenko wrote:
> We used message box for testing and issue resolution purpose, isn't it? It is not a part of...
Hynek Cihlar
11:19 PM Bug #3381: Sub-menu drawing issues
Task branch @3394a@ has been updated for review to revision @11267@.
Greg,
This is the approach I suggest to us...
Eugenie Lyzenko

12/14/2017

06:50 PM Bug #3381: Sub-menu drawing issues
Task branch @3394a@ has been updated for review to revision @11266@.
The review notes resolution. The code in @Ove...
Eugenie Lyzenko
06:35 PM Bug #3381: Sub-menu drawing issues
Hynek Cihlar wrote:
> Code review the #3381 changes in task branch 3394a.
> ...
> The body of @onKeyPressed()@ is ...
Eugenie Lyzenko
04:09 PM Bug #3381: Sub-menu drawing issues
Greg Shah wrote:
> > The only thing left in this area is to implement the delay between menu status change and mouse...
Eugenie Lyzenko
09:17 AM Bug #3381: Sub-menu drawing issues
Eugenie Lyzenko wrote:
> Please rebuild all. I still unable to recreate this. Pressing title bar caused the menu to ...
Hynek Cihlar
08:59 AM Bug #3381: Sub-menu drawing issues
Hynek Cihlar wrote:
> Eugenie Lyzenko wrote:
> > What is your testing environment? Swing client, Web client or both...
Eugenie Lyzenko
08:56 AM Bug #3381: Sub-menu drawing issues
Hynek Cihlar wrote:
> Code review the #3381 changes in task branch 3394a.
> [...]
> In the code above, shouldn't t...
Eugenie Lyzenko
07:58 AM Bug #3381: Sub-menu drawing issues
Another regression with the window menu bar. Run the @uast/menu/Menubar.p@ try to navigate the menu, an exception bel... Hynek Cihlar
07:53 AM Bug #3381: Sub-menu drawing issues
Another problem is that the popup menu cannot be navigated by keyboard. However this probably exists in trunk, too. Hynek Cihlar
07:52 AM Bug #3381: Sub-menu drawing issues
Eugenie Lyzenko wrote:
> What is your testing environment? Swing client, Web client or both?
I can see this only ...
Hynek Cihlar
07:43 AM Bug #3381: Sub-menu drawing issues
Hynek Cihlar wrote:
> Eugenie Lyzenko wrote:
> > Hynek Cihlar wrote:
> > > There is a regression caused by the cha...
Eugenie Lyzenko
07:39 AM Bug #3381: Sub-menu drawing issues
Code review the #3381 changes in task branch 3394a.
MenuItemGuiImpl.selectMenuItem...
Hynek Cihlar
07:06 AM Bug #3381: Sub-menu drawing issues
Eugenie Lyzenko wrote:
> Hynek Cihlar wrote:
> > There is a regression caused by the changes. When the popup is dis...
Hynek Cihlar
07:04 AM Bug #3381: Sub-menu drawing issues
Hynek Cihlar wrote:
> There is a regression caused by the changes. When the popup is displayed and another window (o...
Eugenie Lyzenko
06:04 AM Bug #3381: Sub-menu drawing issues
There is a regression caused by the changes. When the popup is displayed and another window (or the title bar of the ... Hynek Cihlar
05:20 AM Bug #3381: Sub-menu drawing issues
> The only thing left in this area is to implement the delay between menu status change and mouse enter/leave the sub... Greg Shah
10:09 PM Bug #3381: Sub-menu drawing issues
Task branch @3394a@ has been updated for review to revision @11265@.
This update adds hover base show/hide pop-up ...
Eugenie Lyzenko

12/13/2017

03:44 PM Bug #3381: Sub-menu drawing issues
Task branch @3394a@ has been updated for review to revision @11264@.
Added fix for sub menu hiding issues as react...
Eugenie Lyzenko
09:31 PM Bug #3381: Sub-menu drawing issues
Task branch @3394a@ has been updated for review to revision @11259@.
This is the fix for @"Export" item doesn't di...
Eugenie Lyzenko
09:35 AM Feature #3394: generic drawing improvements: repaint and other misc code
Constantin Asofiei wrote:
> Does the same bug happen on the Web client, too? I ask because I have some more generic...
Sergey Ivanovskiy
09:22 AM Feature #3394: generic drawing improvements: repaint and other misc code
Sergey Ivanovskiy wrote:
> Sergey Ivanovskiy wrote:
> > It seems that the root cause of the combo box issue is the ...
Constantin Asofiei
09:03 AM Feature #3394: generic drawing improvements: repaint and other misc code
Sergey Ivanovskiy wrote:
> It seems that the root cause of the combo box issue is the current focus window is still ...
Sergey Ivanovskiy
08:35 AM Feature #3394: generic drawing improvements: repaint and other misc code
It seems that the root cause of the combo box issue is the current focus window is still a drop down overlay when the... Sergey Ivanovskiy

12/12/2017

09:42 AM Feature #3394: generic drawing improvements: repaint and other misc code
OK. Related to the Hotel GUI I didn't detect artifacts except the focus traversal chain started from the opened dropd... Sergey Ivanovskiy
09:26 AM Feature #3394: generic drawing improvements: repaint and other misc code
> > In the current version of 3394a (rev 11256) there is at least one known regression related to the combo box dropd... Greg Shah
08:44 AM Feature #3394: generic drawing improvements: repaint and other misc code
Sergey Ivanovskiy wrote:
> In the current version of 3394a (rev 11256) there is at least one known regression relate...
Sergey Ivanovskiy
07:30 AM Feature #3394: generic drawing improvements: repaint and other misc code
OK, thank you. Sergey Ivanovskiy
07:28 AM Feature #3394: generic drawing improvements: repaint and other misc code
Quantity of radio buttons should match the maximum number of guests for the selected room type. So far I see no issues. Stanislav Lomany
07:24 AM Feature #3394: generic drawing improvements: repaint and other misc code
I am just looking into it but if we open Update Reservation for rooms with 3 and 4 guests, then this dialog displays ... Sergey Ivanovskiy
07:15 AM Feature #3394: generic drawing improvements: repaint and other misc code
Sergey Ivanovskiy wrote:
> There is an issue with radio buttons.
> !RadioButtonsGroup.png!
Please describe it.
...
Constantin Asofiei
07:02 AM Feature #3394: generic drawing improvements: repaint and other misc code
There is an issue with radio buttons.
!RadioButtonsGroup.png!
Sergey Ivanovskiy
06:05 AM Feature #3394: generic drawing improvements: repaint and other misc code
Please review these minor changes in the committed revision 11257 that discarded PainEvents with empty update rectang... Sergey Ivanovskiy
05:14 AM Feature #3394: generic drawing improvements: repaint and other misc code
Constantin, empty rectangles are generated from size or another updates on @widget.repaint()@. Please look at this lo... Sergey Ivanovskiy
04:48 AM Feature #3394: generic drawing improvements: repaint and other misc code
In the current version of 3394a (rev 11256) there is at least one known regression related to the combo box dropdown ... Sergey Ivanovskiy
09:08 PM Bug #3381: Sub-menu drawing issues
Task branch @3394a@ has been updated for review to revision @11256@.
The fix for @Windows10@ selected menu item ba...
Eugenie Lyzenko
07:46 PM Bug #3381: Sub-menu drawing issues
Task branch @3394a@ has been updated for review to revision @11255@.
This update include several painting issues i...
Eugenie Lyzenko

12/11/2017

02:56 PM Feature #3394: generic drawing improvements: repaint and other misc code
Constantin, your changes fixed the tree control and all date picker issues. Thank you for help. There are only visibl... Sergey Ivanovskiy
02:37 PM Feature #3394: generic drawing improvements: repaint and other misc code
Sergey Ivanovskiy wrote:
> OK. Did you try to draw sequence diagrams related to drawings? It seems there are differe...
Constantin Asofiei
02:32 PM Feature #3394: generic drawing improvements: repaint and other misc code
OK. Did you try to draw sequence diagrams related to drawings? It seems there are different scenarios that can invoke... Sergey Ivanovskiy
02:23 PM Feature #3394: generic drawing improvements: repaint and other misc code
Sergey, when you mentioned the @afterConfigUpdateBase@, it got me thinking... we need to post physical boundaries and... Constantin Asofiei
09:23 AM Feature #3394: generic drawing improvements: repaint and other misc code
This trace should be discussed too... Sergey Ivanovskiy
08:44 AM Feature #3394: generic drawing improvements: repaint and other misc code
Constantin, you are correct that @AbstractWidget.afterConfigUpdateBase@ (trunc version) looks incorrect because of @p... Sergey Ivanovskiy
05:16 AM Feature #3394: generic drawing improvements: repaint and other misc code
It looks like a bug that for a date picker button defined by... Sergey Ivanovskiy
04:51 AM Feature #3394: generic drawing improvements: repaint and other misc code
This function of @OutputManager@... Sergey Ivanovskiy
02:17 PM Bug #3381: Sub-menu drawing issues
> No there is no such line in @FWD@. Can you remember when you saw it last time?
I guess somewhere between revisio...
Stanislav Lomany
12:07 PM Bug #3381: Sub-menu drawing issues
Stanislav,
From your picture I can see vertical line in @Windows10@ theme:
!missing_vert_win10.jpg!
No there...
Eugenie Lyzenko

12/09/2017

07:43 AM Bug #3382: Client-side popup menus abend
Hynek Cihlar wrote:
> Eugenie Lyzenko wrote:
> > Guys,
> >
> > I'm just trying to run browse pop-up test in my W...
Eugenie Lyzenko
04:19 AM Bug #3382: Client-side popup menus abend
Eugenie Lyzenko wrote:
> Guys,
>
> I'm just trying to run browse pop-up test in my Windows devbox. And has abend ...
Hynek Cihlar
08:06 PM Bug #3382: Client-side popup menus abend
Guys,
I'm just trying to run browse pop-up test in my Windows devbox. And has abend from inability to open temp t...
Eugenie Lyzenko
10:01 PM Bug #3381: Sub-menu drawing issues
4GL level1 menu opening:
!sub_menu1_level1.jpg!
4GL level2 menu opening:
!sub_menu1_level2.jpg!
Eugenie Lyzenko

12/08/2017

04:25 PM Feature #3394: generic drawing improvements: repaint and other misc code
Constantin, no, updates for combo boxes and tree and another widgets are different issues. I didn't solve them. This ... Sergey Ivanovskiy
04:20 PM Feature #3394: generic drawing improvements: repaint and other misc code
Sergey Ivanovskiy wrote:
> Please review committed revision 11249 (3394a) that should discard empty rectangles from ...
Constantin Asofiei
03:22 PM Feature #3394: generic drawing improvements: repaint and other misc code
Please review committed revision 11249 (3394a) that should discard empty rectangles from @SceenBitmap@. It seems that... Sergey Ivanovskiy
12:11 PM Feature #3394: generic drawing improvements: repaint and other misc code
Please clarify what is incorrect in setNewSelection?
I traced @ScrenBitmap.this.setState@ and found many cases wit...
Sergey Ivanovskiy
08:50 AM Feature #3394: generic drawing improvements: repaint and other misc code
Sergey Ivanovskiy wrote:
> The following changes can help to fix combo box updates
> [...]
> but I found another p...
Constantin Asofiei
08:39 AM Feature #3394: generic drawing improvements: repaint and other misc code
But it is possible that these empty clipping rectangles have been incorrectly added to @ScreenBitmap@. It needs to fi... Sergey Ivanovskiy
05:27 AM Feature #3394: generic drawing improvements: repaint and other misc code
Sergey Ivanovskiy wrote:
> I changed coordinates in #3394-41. The rectangle is empty and is invalid but if it is pas...
Constantin Asofiei
05:26 AM Feature #3394: generic drawing improvements: repaint and other misc code
Constantin Asofiei wrote:
> Sergey Ivanovskiy wrote:
> > I meant the existing definition of @NativeRectangle.this.e...
Sergey Ivanovskiy
05:22 AM Feature #3394: generic drawing improvements: repaint and other misc code
Sergey Ivanovskiy wrote:
> Constantin Asofiei wrote:
> > See @CombobBox.setValue@ and other @setValue@ for i.e. sel...
Constantin Asofiei
05:21 AM Feature #3394: generic drawing improvements: repaint and other misc code
Constantin Asofiei wrote:
> See @CombobBox.setValue@ and other @setValue@ for i.e. selection-list and other widgets ...
Sergey Ivanovskiy
05:16 AM Feature #3394: generic drawing improvements: repaint and other misc code
Sergey Ivanovskiy wrote:
> I meant the existing definition of @NativeRectangle.this.empty()@ which is correct.
I do...
Constantin Asofiei
05:13 AM Feature #3394: generic drawing improvements: repaint and other misc code
I meant the existing definition of @NativeRectangle.this.empty()@ which is correct. Sergey Ivanovskiy
05:10 AM Feature #3394: generic drawing improvements: repaint and other misc code
Yes I mean @NativeRectangle@, but @Rectangle@ has the same issue. To clarify this bug with empty rectangles let us co... Sergey Ivanovskiy
05:07 AM Feature #3394: generic drawing improvements: repaint and other misc code
Sergey Ivanovskiy wrote:
> Yes, and the fact that the month combo box is not repainted with actual value.
See @Comb...
Constantin Asofiei
04:58 AM Feature #3394: generic drawing improvements: repaint and other misc code
Yes, and the fact that the month combo box is not repainted with actual value.
It seems that the @NativeRectangle....
Sergey Ivanovskiy
04:56 AM Feature #3394: generic drawing improvements: repaint and other misc code
Sergey Ivanovskiy wrote:
> Please look at this picture date_picker.mkv.
You refer to the border artefacts around th...
Constantin Asofiei
04:43 AM Feature #3394: generic drawing improvements: repaint and other misc code
Please look at this picture date_picker.mkv. Sergey Ivanovskiy
03:02 PM Bug #3382: Client-side popup menus abend
Hynek Cihlar wrote:
>
> In your last change you used the menu popup location passed to @Menu.showPopup()@, which a...
Eugenie Lyzenko
12:40 PM Bug #3382: Client-side popup menus abend
Eugenie Lyzenko wrote:
> Hynek Cihlar wrote:
> > Yes, the coordinates must be taken from the mouse event causing th...
Hynek Cihlar
10:42 AM Bug #3382: Client-side popup menus abend
Hynek Cihlar wrote:
> Yes, the coordinates must be taken from the mouse event causing the popup to come up and not f...
Eugenie Lyzenko
06:57 AM Bug #3382: Client-side popup menus abend
Eugenie Lyzenko wrote:
> Hynek Cihlar wrote:
> > Eugenie, why not to get the location from the mouse event? What if...
Hynek Cihlar
04:47 AM Bug #3382: Client-side popup menus abend
Hynek Cihlar wrote:
> Eugenie, why not to get the location from the mouse event? What if the popup isn't actually di...
Eugenie Lyzenko
02:57 AM Bug #3382: Client-side popup menus abend
Eugenie Lyzenko wrote:
> Task branch @3394a@ has been updated for review to revision @11247@.
>
> Fixed the bar s...
Hynek Cihlar
08:10 PM Bug #3382: Client-side popup menus abend
Task branch @3394a@ has been updated for review to revision @11247@.
Fixed the bar scrolling initiated from pop-up...
Eugenie Lyzenko

12/07/2017

03:32 PM Feature #3394: generic drawing improvements: repaint and other misc code
Sergey Ivanovskiy wrote:
> OK, I lost the conception of redrawing if the business methods change some widget (its po...
Constantin Asofiei
03:32 PM Feature #3394: generic drawing improvements: repaint and other misc code
Constantin Asofiei wrote:
> Sergey Ivanovskiy wrote:
> > This resize rectangle is displayed forever after its appea...
Eugenie Lyzenko
03:25 PM Feature #3394: generic drawing improvements: repaint and other misc code
OK, I lost the conception of redrawing if the business methods change some widget (its position, its size, its conten... Sergey Ivanovskiy
03:18 PM Feature #3394: generic drawing improvements: repaint and other misc code
Sergey Ivanovskiy wrote:
> This resize rectangle is displayed forever after its appearance on double click at the fr...
Constantin Asofiei
03:17 PM Feature #3394: generic drawing improvements: repaint and other misc code
Sergey Ivanovskiy wrote:
> Please answer to this conceptual question. What is the meaning of this flag and when it c...
Constantin Asofiei
02:53 PM Feature #3394: generic drawing improvements: repaint and other misc code
Please answer to this conceptual question. What is the meaning of this flag and when it can be used (@BaseConfig@)? C... Sergey Ivanovskiy
02:50 PM Feature #3394: generic drawing improvements: repaint and other misc code
This resize rectangle is displayed forever after its appearance on double click at the frame space right to the last ... Sergey Ivanovskiy
02:47 PM Feature #3394: generic drawing improvements: repaint and other misc code
Don't know it is an answer. The frame is @folder-frm 27 Dimension[126.0,16.43] Point[0.0,1.0] visible true can false;... Sergey Ivanovskiy
02:33 PM Feature #3394: generic drawing improvements: repaint and other misc code
Sergey Ivanovskiy wrote:
> With the current version the main tab frame can be resizable and resize or editor grid is...
Constantin Asofiei
02:22 PM Feature #3394: generic drawing improvements: repaint and other misc code
With the current version the main tab frame can be resizable and resize or editor grid is displayed. It wasn't observ... Sergey Ivanovskiy
09:54 AM Feature #3394: generic drawing improvements: repaint and other misc code
Don't mind, I answered by myself. Sergey Ivanovskiy
09:44 AM Feature #3394: generic drawing improvements: repaint and other misc code
Please help to answer why in this code adatesd0.w for the date picker the x and y coordinates for the selected date r... Sergey Ivanovskiy
01:29 PM Bug #3382: Client-side popup menus abend
Hynek Cihlar wrote:
>When you are at the changes can you make sure the key input works correctly? I am getting an ex...
Eugenie Lyzenko
04:00 AM Bug #3382: Client-side popup menus abend
Eugenie Lyzenko wrote:
> Well, looks like I have found alternative approach. So the set of changes:
I like that. ...
Hynek Cihlar
11:52 PM Bug #3382: Client-side popup menus abend
Well, looks like I have found alternative approach. So the set of changes:
1. No using @invokeLater()@ to avoid chan...
Eugenie Lyzenko

12/06/2017

05:12 PM Bug #3382: Client-side popup menus abend
Eugenie Lyzenko wrote:
> If adapter @adapter.mouseClicked(e)@ calls body that has @invokeLater@ wrapper the result w...
Hynek Cihlar
05:06 PM Bug #3382: Client-side popup menus abend
Eugenie Lyzenko wrote:
> Hynek Cihlar wrote:
> >
> > (2) Enqueue only the call to @TC.messageBox()@ in the mouse ...
Hynek Cihlar
05:05 PM Bug #3382: Client-side popup menus abend
Hynek Cihlar wrote:
> Eugenie Lyzenko wrote:
> > This is exactly how it is currently implemented. Pop-up @ScrollPop...
Eugenie Lyzenko
04:57 PM Bug #3382: Client-side popup menus abend
Hynek Cihlar wrote:
>
> (2) Enqueue only the call to @TC.messageBox()@ in the mouse adapter body. Less impact on t...
Eugenie Lyzenko
04:50 PM Bug #3382: Client-side popup menus abend
Eugenie Lyzenko wrote:
> This is exactly how it is currently implemented. Pop-up @ScrollPopupGuiImpl.mouseClicked()@...
Hynek Cihlar
04:39 PM Bug #3382: Client-side popup menus abend
Hynek Cihlar wrote:
> > In this case we have null parent again because @invokeLater()@ defer click handler to the mo...
Eugenie Lyzenko
04:36 PM Bug #3382: Client-side popup menus abend
Eugenie Lyzenko wrote:
> Yes, at least scrolling down by pop-up menu does not work.
I think there are two options...
Hynek Cihlar
04:30 PM Bug #3382: Client-side popup menus abend
Hynek Cihlar wrote:
> Eugenie Lyzenko wrote:
> > But if we postpone click processing to the end - we have dismissed...
Eugenie Lyzenko
04:27 PM Bug #3382: Client-side popup menus abend
Eugenie Lyzenko wrote:
> But if we postpone click processing to the end - we have dismissed menu when it should exis...
Hynek Cihlar
04:17 PM Bug #3382: Client-side popup menus abend
Eugenie Lyzenko wrote:
> Hynek Cihlar wrote:
> > Hynek Cihlar wrote:
> >
> > In fact I don't see any reason the ...
Hynek Cihlar
03:32 PM Bug #3382: Client-side popup menus abend
Hynek Cihlar wrote:
> Hynek Cihlar wrote:
>
> In fact I don't see any reason the ordering should not be enforced ...
Eugenie Lyzenko
01:55 PM Bug #3382: Client-side popup menus abend
Hynek Cihlar wrote:
> > Another word you mean every possible code (we will remove @ThinClient.messageBox()@ from fin...
Hynek Cihlar
01:31 PM Bug #3382: Client-side popup menus abend
Eugenie Lyzenko wrote:
> What I do not understand here is why we are committed to @ThinClient.messageBox()@? This is...
Hynek Cihlar
12:20 PM Bug #3382: Client-side popup menus abend
Hynek Cihlar wrote:
>
> The call to @ThinClient.messageBox()@ must be executed in @ThinClient.invokeLater@ so that...
Eugenie Lyzenko
12:04 PM Bug #3382: Client-side popup menus abend
Eugenie Lyzenko wrote:
> Unfortunately this is not enough to fix the issue. Moving @MenuItemGuiImpl.selectMenuItem()...
Hynek Cihlar
09:49 PM Bug #3382: Client-side popup menus abend
Unfortunately this is not enough to fix the issue. Moving @MenuItemGuiImpl.selectMenuItem()@ before @ScrollPopupGuiIm... Eugenie Lyzenko
03:25 PM Feature #3394: generic drawing improvements: repaint and other misc code
Sergey Ivanovskiy wrote:
> With the current 3394a the Hotel GUI Check-in date picker doesn't repaint items correctly...
Constantin Asofiei
03:24 PM Feature #3394: generic drawing improvements: repaint and other misc code
With the current 3394a the Hotel GUI Check-in date picker doesn't repaint items correctly if the current month (year)... Sergey Ivanovskiy

12/05/2017

02:34 PM Bug #3382: Client-side popup menus abend
Eugenie Lyzenko wrote:
> You mean execution @selectMenuItem()@ first, then mouse adapters?
Exactly so.
Hynek Cihlar
05:55 AM Bug #3382: Client-side popup menus abend
Hynek Cihlar wrote:
> Please try to move the execution of mouse adapters in @MenuItemGuiImpl.mouseClicked@ before @s...
Eugenie Lyzenko
04:29 AM Bug #3382: Client-side popup menus abend
Eugenie Lyzenko wrote:
> So the suggested fix approach can be the following change in @ThinClient.invokeTriggers(......
Hynek Cihlar
09:35 PM Bug #3382: Client-side popup menus abend
So the suggested fix approach can be the following change in @ThinClient.invokeTriggers(...)@, line starting at @1822... Eugenie Lyzenko

12/04/2017

06:36 PM Bug #3382: Client-side popup menus abend
Debugging result. The current events data flow:
1. After the user clicks on @Scroll here@ pop up menu from scrollb...
Eugenie Lyzenko
04:00 PM Feature #3394: generic drawing improvements: repaint and other misc code
Sergey Ivanovskiy wrote:
> The order of repaints can be the root cause?
No, as they just determine which widgets wi...
Constantin Asofiei
03:27 PM Feature #3394: generic drawing improvements: repaint and other misc code
The order of repaints can be the root cause? Sergey Ivanovskiy
03:25 PM Feature #3394: generic drawing improvements: repaint and other misc code
Updated #3394-18 with correct logs. Yes, they are 121 and 124. Sergey Ivanovskiy
03:10 PM Feature #3394: generic drawing improvements: repaint and other misc code
Sergey Ivanovskiy wrote:
> Finally, the last two nodes: "Twin" and "Luxury Suite " were not repainted.
Do you now t...
Constantin Asofiei
03:08 PM Feature #3394: generic drawing improvements: repaint and other misc code
Yes, I tested Hotel GUI Add Room Dialog and opened the first node and then opened the second node. Finally, the last ... Sergey Ivanovskiy
01:38 PM Feature #3394: generic drawing improvements: repaint and other misc code
Sergey Ivanovskiy wrote:
> Interesting note if setup conditional breakpoints for the tree control widgets in @Abstra...
Constantin Asofiei
01:35 PM Feature #3394: generic drawing improvements: repaint and other misc code
Interesting note if setup conditional breakpoints for the tree control widgets in @AbstractWidget.afterConfigUpdateBa... Sergey Ivanovskiy
03:57 PM Bug #2766: implement a text metrics server process
Code Review Task Branch 3394a Revisions 11232/11233
I'm good with the changes.
Greg Shah
02:36 PM Bug #2766: implement a text metrics server process
Greg, please review 3394a rev 11232/11233. Constantin Asofiei
01:27 PM Bug #2766: implement a text metrics server process
Greg Shah wrote:
> You recently added the captured @text-metrics.xml@ to the project. Was there a problem that drov...
Constantin Asofiei
01:21 PM Bug #2766: implement a text metrics server process
> Another note: currently FontManager reads the entire font-table (~46k strings) into the client-side's memory. In th... Greg Shah
01:18 PM Bug #2766: implement a text metrics server process
I was not using the properly derived font (as Swing was doing) when computing the metrics. With current changes, the... Constantin Asofiei
10:52 AM Bug #2766: implement a text metrics server process
Some quick and dirty changes in web code allow AWT Font and FontMetrics to be used. But I think I'm not using the co... Constantin Asofiei
08:02 AM Bug #2766: implement a text metrics server process
Agreed. Greg Shah
06:26 AM Bug #2766: implement a text metrics server process
Greg Shah wrote:
> Another approach might be to use caching for the calculated metrics. This would have to be done ...
Constantin Asofiei
06:14 AM Bug #2766: implement a text metrics server process
I agree we should resolve this.
If we can calculate suitable metrics in the Java client, I would be fine with that...
Greg Shah
06:05 AM Bug #2766: implement a text metrics server process
In addition to the functional issues we see from deviations from the Windows metrics when encountering dynamic text, ... Greg Shah

12/02/2017

11:44 AM Bug #3382: Client-side popup menus abend
Eugenie Lyzenko wrote:
>
> This also eliminates the exception for widgets that detached from parent, like pop-up m...
Hynek Cihlar

12/01/2017

05:46 PM Bug #3382: Client-side popup menus abend
Hynek Cihlar wrote:
> Eugenie Lyzenko wrote:
>
> If in the menu-item it is expected that the top-level window may...
Eugenie Lyzenko
04:56 PM Bug #3382: Client-side popup menus abend
Eugenie Lyzenko wrote:
> This change resolve the issue. Any objections or notes?
The exception thrown from @topLe...
Hynek Cihlar
04:38 PM Bug #3382: Client-side popup menus abend
The root cause for this issue is the code in pop up menu item:... Eugenie Lyzenko
04:42 PM Bug #3401: clarifications for windows related methods in Widget and GuiDriver classes
Patch committed to 3394a as revision 11221. Ovidiu Maxiniuc
03:07 PM Bug #3401: clarifications for windows related methods in Widget and GuiDriver classes
Recently I used the @window()@ method to pass the window id of a @EditorGuiImpl@ in the @GuiDriver@ for accessing som... Ovidiu Maxiniuc
02:42 PM Bug #3401 (Closed): clarifications for windows related methods in Widget and GuiDriver classes
Ovidiu Maxiniuc
10:27 AM Feature #3394: generic drawing improvements: repaint and other misc code
3394a was rebased from trunk rev 11208 - new rev 11219. Constantin Asofiei
09:55 AM Feature #3394: generic drawing improvements: repaint and other misc code
Constantin Asofiei wrote:
> I'm rebasing 3394a rev 11217 in 15 minutes if nobody objects.
Constantin Asofiei
09:40 AM Feature #3394: generic drawing improvements: repaint and other misc code
I'm rebasing 3394a rev 11217 in 15 minutes if nobody objects. Constantin Asofiei

11/29/2017

05:58 AM Feature #3394: generic drawing improvements: repaint and other misc code
3394a 11213 passed main runtime testing. Constantin Asofiei

11/28/2017

04:11 PM Feature #3394: generic drawing improvements: repaint and other misc code
Greg Shah wrote:
> 1. In @Button.setText()@ and @ToggleBox.setText()@ why is it safe to only repaint in @autoResize@...
Constantin Asofiei
04:08 PM Feature #3394: generic drawing improvements: repaint and other misc code
Code Review Task Branch 3394a Revision 11211
1. In @Button.setText()@ and @ToggleBox.setText()@ why is it safe to ...
Greg Shah
01:15 PM Feature #3394: generic drawing improvements: repaint and other misc code
> I think the improvements I made to postpone the drawing should be done only in GUI; ChUI has the PUT SCREEN stuff w... Greg Shah
11:43 AM Feature #3394: generic drawing improvements: repaint and other misc code
Greg Shah wrote:
> Do you want to make 3394a the next "accumulate the fixes" branch? Or would you prefer to keep it...
Constantin Asofiei
10:57 AM Feature #3394: generic drawing improvements: repaint and other misc code
Do you want to make 3394a the next "accumulate the fixes" branch? Or would you prefer to keep it separate? Greg Shah
02:26 PM Bug #3390 (Closed): Eliminate unnecessary frame redraws due to inconsistent calculated height
Greg Shah
02:15 PM Bug #3390: Eliminate unnecessary frame redraws due to inconsistent calculated height
3390a was merged to trunk as revision 11207 and archived. Hynek Cihlar
02:10 PM Bug #3390: Eliminate unnecessary frame redraws due to inconsistent calculated height
Please merge to trunk. Greg Shah
01:53 PM Bug #3390: Eliminate unnecessary frame redraws due to inconsistent calculated height
3390a passed regression tests and was rebased against trunk 11206. No more changes are expected in the branch. Hynek Cihlar
01:11 PM Bug #3373: incremental scroll in non-full Browse page
It is OK to call @UnimplementedFeature@ on the client. It will be logged there and that is OK.
Since 3369a is merg...
Greg Shah
07:29 AM Bug #3395: rectangle:edge-chars is not working in GUI
The @RECTANGLE:EDGE-CHARS@ is not working in GUI clients. We need to be able for @EDGE-PIXELS@ and @EDGE-CHARS@ to w... Constantin Asofiei
07:28 AM Bug #3395 (Closed): rectangle:edge-chars is not working in GUI
Constantin Asofiei

11/27/2017

06:49 PM Feature #3394: generic drawing improvements: repaint and other misc code
3394a rev 11208 adds this:
* Batch the MSG_REGISTER_HOVERABLE_WIDGET messages.
* Avoid gd.setCurrentSelection(null)...
Constantin Asofiei
05:38 PM Feature #3394: generic drawing improvements: repaint and other misc code
I've been looking into the JS code and there are some findings:
# we can reduce the @MSG_REGISTER_HOVERABLE_WIDGET@ ...
Constantin Asofiei
04:40 PM Feature #3394: generic drawing improvements: repaint and other misc code
For #3394-3, the changes are in 3394a rev 11207. Constantin Asofiei
03:22 PM Feature #3394: generic drawing improvements: repaint and other misc code
Another issue to improve is described by this email chain:
-------
Constantin,
according to win32 api docs...
Constantin Asofiei
03:20 PM Feature #3394: generic drawing improvements: repaint and other misc code
An issue to try to improve is described by this email chain:
-------------
I agree that Hynek's idea of two que...
Constantin Asofiei
03:19 PM Feature #3394: generic drawing improvements: repaint and other misc code
In branch 3369a (trunk rev 11206), there are some fixes which remove some aggressive @repaint()@ calls when i.e. fram... Constantin Asofiei
03:18 PM Feature #3394 (Closed): generic drawing improvements: repaint and other misc code
Constantin Asofiei
03:56 PM Bug #3390: Eliminate unnecessary frame redraws due to inconsistent calculated height
Hynek Cihlar wrote:
> A fix checked in to 3390a revision 11206. Please review.
I'm OK with the changes.
Constantin Asofiei
03:47 PM Bug #3374 (Closed): NPE in ConfigManager
Branch 3369a was merged to trunk as revision 11206. Greg Shah
03:46 PM Bug #3371 (Closed): NPE in AbstractGuiDriver in client log
Branch 3369a was merged to trunk as revision 11206. Greg Shah
03:44 PM Feature #3369 (Closed): add support for BGCOLOR-RGB and FGCOLOR-RGB, FWD extension widget attributes
Greg Shah
03:11 PM Feature #3369 (WIP): add support for BGCOLOR-RGB and FGCOLOR-RGB, FWD extension widget attributes
3369a Was merged to trunk rev 11206 and archived. Constantin Asofiei
02:29 PM Feature #3369: add support for BGCOLOR-RGB and FGCOLOR-RGB, FWD extension widget attributes
No problem. I am un-committing 3369a/ right now. Ovidiu Maxiniuc
01:30 PM Feature #3369: add support for BGCOLOR-RGB and FGCOLOR-RGB, FWD extension widget attributes
No, I want to get the 3369a into the trunk.
Ovidiu: Would you please move the changes 11248 into a separate branch?
Greg Shah
01:15 PM Feature #3369: add support for BGCOLOR-RGB and FGCOLOR-RGB, FWD extension widget attributes
Constantin Asofiei wrote:
> Another regression fixed, 3369a rev 11247 is in testing.
Rev 11247 passed main part of ...
Constantin Asofiei
08:56 AM Feature #3369: add support for BGCOLOR-RGB and FGCOLOR-RGB, FWD extension widget attributes
Another regression fixed, 3369a rev 11247 is in testing. Constantin Asofiei
03:33 AM Feature #3369: add support for BGCOLOR-RGB and FGCOLOR-RGB, FWD extension widget attributes
Don't mind it works now, after external jconsole has been accessed to the client process. It is not a bug probably. Sergey Ivanovskiy
03:29 AM Feature #3369: add support for BGCOLOR-RGB and FGCOLOR-RGB, FWD extension widget attributes
I am using 3369a to work on #3385 and it seems that the Login screen (Swing client) doesn't accept keys input. Sergey Ivanovskiy
09:29 AM Bug #3373: incremental scroll in non-full Browse page
> I thing we should log the event instead (@UnimplementedFeature.TODO@) as a reminder and return @false@ because no r... Stanislav Lomany

11/26/2017

02:56 PM Bug #3390: Eliminate unnecessary frame redraws due to inconsistent calculated height
A fix checked in to 3390a revision 11206. Please review. Hynek Cihlar
02:28 PM Bug #3390: Eliminate unnecessary frame redraws due to inconsistent calculated height
On 11/25/2017 09:37 PM, Hynek Cihlar wrote:
> Constantin,
>
> the problem is caused by the char->pixel->char round...
Hynek Cihlar
02:28 PM Bug #3390 (Closed): Eliminate unnecessary frame redraws due to inconsistent calculated height
Hynek Cihlar

11/25/2017

10:34 AM Bug #3375 (Closed): Stack overflow kills the client
Greg Shah
10:32 AM Bug #3375: Stack overflow kills the client
3375a passed regression tests, rebased, merged to trunk as revision 11205 and archived. Hynek Cihlar
09:07 AM Feature #3369: add support for BGCOLOR-RGB and FGCOLOR-RGB, FWD extension widget attributes
Eric Faulhaber wrote:
> There are some issues with repainting in the ADM screens: e.g., an old tab remains "selecte...
Constantin Asofiei
07:40 AM Feature #3369: add support for BGCOLOR-RGB and FGCOLOR-RGB, FWD extension widget attributes
Eric Faulhaber wrote:
> Also, I don't notice the same issue with buttons from one screen being painted incorrectly i...
Eric Faulhaber
07:33 AM Feature #3369: add support for BGCOLOR-RGB and FGCOLOR-RGB, FWD extension widget attributes
An observation: I've noticed that the embedded mode drawing seems much more "crisp" than virtual desktop mode or the ... Eric Faulhaber
07:20 AM Feature #3369: add support for BGCOLOR-RGB and FGCOLOR-RGB, FWD extension widget attributes
Eric Faulhaber wrote:
> There are some issues with repainting in the ADM screens: e.g., an old tab remains "selecte...
Constantin Asofiei
07:20 AM Feature #3369: add support for BGCOLOR-RGB and FGCOLOR-RGB, FWD extension widget attributes
I did some testing with the large app in Swing mode and in virtual desktop mode (converted with 3369a rev. 11237). It... Eric Faulhaber
09:56 PM Feature #3369: add support for BGCOLOR-RGB and FGCOLOR-RGB, FWD extension widget attributes
Constantin Asofiei wrote:
> Constantin Asofiei wrote:
> > Constantin Asofiei wrote:
> > > 3369a rev 11231 contains...
Eric Faulhaber
07:50 PM Feature #3369: add support for BGCOLOR-RGB and FGCOLOR-RGB, FWD extension widget attributes
Constantin Asofiei wrote:
> Constantin Asofiei wrote:
> > 3369a rev 11231 contains some performance fixes:
> > # a...
Constantin Asofiei
07:38 PM Feature #3369: add support for BGCOLOR-RGB and FGCOLOR-RGB, FWD extension widget attributes
Branch 3369a rebased from trunk rev 11204. The latest revision is 11236.
This will require a full reconversion of...
Greg Shah
07:13 PM Feature #3369: add support for BGCOLOR-RGB and FGCOLOR-RGB, FWD extension widget attributes
I'm rebasing now. Greg Shah

11/24/2017

06:52 PM Feature #3369: add support for BGCOLOR-RGB and FGCOLOR-RGB, FWD extension widget attributes
Can I rebase 3369a? I know the 3375a change is not yet available, but I think it is best to go ahead and pick up the... Greg Shah
06:34 PM Feature #3369: add support for BGCOLOR-RGB and FGCOLOR-RGB, FWD extension widget attributes
Constantin Asofiei wrote:
> 3369a rev 11231 contains some performance fixes:
> # avoid unnecessary repaints
There ...
Constantin Asofiei
05:10 PM Feature #3369: add support for BGCOLOR-RGB and FGCOLOR-RGB, FWD extension widget attributes
3369a rev 11231 contains some performance fixes:
# avoid logging overhead in the EmulatedWindowState and SwingEmulat...
Constantin Asofiei
04:56 PM Feature #3369: add support for BGCOLOR-RGB and FGCOLOR-RGB, FWD extension widget attributes
Hynek Cihlar wrote:
> 3369a 11220 improves performance of coordinate values rounding.
There are still these cases w...
Constantin Asofiei
04:29 PM Feature #3369: add support for BGCOLOR-RGB and FGCOLOR-RGB, FWD extension widget attributes
Yes, but I want to wait for Hynek's update first. Constantin Asofiei
04:28 PM Feature #3369: add support for BGCOLOR-RGB and FGCOLOR-RGB, FWD extension widget attributes
Does it need to rebase 3369a? Sergey Ivanovskiy
09:19 AM Feature #3369: add support for BGCOLOR-RGB and FGCOLOR-RGB, FWD extension widget attributes
Greg Shah wrote:
> Code Review Task Branch 3369a Revision 11226
I fixed a regression in 11227, I was not considerin...
Constantin Asofiei
08:55 AM Feature #3369: add support for BGCOLOR-RGB and FGCOLOR-RGB, FWD extension widget attributes
Code Review Task Branch 3369a Revision 11226
I think the code is correct from a logical standpoint.
If we had...
Greg Shah
07:25 AM Feature #3369: add support for BGCOLOR-RGB and FGCOLOR-RGB, FWD extension widget attributes
3369a rev 11225/11226 fixes class name collisions for converted external program names. Full conversion is required.... Constantin Asofiei
05:40 PM Bug #3375: Stack overflow kills the client
Greg Shah wrote:
> Code Review Task Branch 3375a Revision 11204
>
> The changes are fine. The difference now is ...
Hynek Cihlar
12:40 PM Bug #3375: Stack overflow kills the client
Code Review Task Branch 3375a Revision 11204
The changes are fine. The difference now is very slight.
If it pa...
Greg Shah
12:04 PM Bug #3375: Stack overflow kills the client
Hynek Cihlar wrote:
> It finished with one regression, I am currently fixing the issue. I don't expect the fix to ta...
Hynek Cihlar
11:01 AM Bug #3375: Stack overflow kills the client
Greg Shah wrote:
> Code Review Task Branch 3375a Revision 11203
>
> I'm fine with the changes. Did ChUI regressi...
Hynek Cihlar
08:09 AM Bug #3375: Stack overflow kills the client
Code Review Task Branch 3375a Revision 11203
I'm fine with the changes. Did ChUI regression testing finish?
Greg Shah
02:37 PM Bug #3370 (Closed): READ-ONLY attribute error in server log
Greg Shah
02:26 PM Bug #3370: READ-ONLY attribute error in server log
Committed revision 11204.
Branch was archived. Notification email was sent to team.
Ovidiu Maxiniuc
02:00 PM Bug #3370: READ-ONLY attribute error in server log
Please merge 3370a to trunk. Greg Shah
01:13 PM Bug #3370: READ-ONLY attribute error in server log
The conversion test on devsrv01 ended with success. The generated code by 3370a/11203 is unchanged.
Ovidiu Maxiniuc
08:58 AM Bug #3370: READ-ONLY attribute error in server log
Indeed, we should have an interface for each P4GL attribute / method. Some of them can be grouped together if they ar... Ovidiu Maxiniuc
08:41 AM Bug #3370: READ-ONLY attribute error in server log
Code Review Task branch 3370a Revision 11203
The changes look good.
I think you have found a more widespread fl...
Greg Shah
06:49 AM Bug #3373: incremental scroll in non-full Browse page
Agreed.
Stanislav: Please put that change in 3369a. Then you can fix this issue later.
Greg Shah
06:42 AM Bug #3373: incremental scroll in non-full Browse page
I noticed that in the log, but throwing exceptions in this manner is dangerous. This time the @incrementalScroll()@ w... Ovidiu Maxiniuc
06:30 AM Bug #3373: incremental scroll in non-full Browse page
Ovidiu: Does this affect a user or is it just a report in the log? Greg Shah

11/23/2017

12:09 PM Bug #3382: Client-side popup menus abend
I've created a client-side popup menu for browse (using the same approach used as in @ScrollPopupGuiImpl@) and called... Stanislav Lomany
12:01 PM Bug #3382: Client-side popup menus abend
Stanislav, do you remember the actual case when the exception happened? I would rather have a real recreate for this. Hynek Cihlar
11:45 AM Bug #3382 (WIP): Client-side popup menus abend
Hynek Cihlar
11:33 AM Bug #3373: incremental scroll in non-full Browse page
Greg, I'll fix it, but considering the amount of work for #3261 I'm not sure if I should fix it before or after Nov 30. Stanislav Lomany
11:30 AM Bug #3373 (WIP): incremental scroll in non-full Browse page
Stanislav,
I understand you are working on this issue so I am assigning it to you.
Ovidiu Maxiniuc
11:33 AM Bug #3375 (WIP): Stack overflow kills the client
Ovidiu Maxiniuc
10:22 AM Bug #3375: Stack overflow kills the client
Created task branch 3375a and checked in the fix. The changes passed GUI regression tests, ChUI regression testing is... Hynek Cihlar
11:32 AM Bug #3374 (WIP): NPE in ConfigManager
I committed the fix for this issue was committed to 3369a with revision 11211. Ovidiu Maxiniuc
11:26 AM Bug #3371: NPE in AbstractGuiDriver in client log
The revision 11212 of 3369a makes sure the window is selected in @EditorGuiImpl.computeLineWidths()@. The exceptions ... Ovidiu Maxiniuc
11:22 AM Bug #3370: READ-ONLY attribute error in server log
I created 3370a created and committed a patch for this issue. Current revision is 11203. Please review. Ovidiu Maxiniuc

11/22/2017

04:02 PM Feature #3369: add support for BGCOLOR-RGB and FGCOLOR-RGB, FWD extension widget attributes
3369a 11220 improves performance of coordinate values rounding. Hynek Cihlar
03:57 PM Feature #3369: add support for BGCOLOR-RGB and FGCOLOR-RGB, FWD extension widget attributes
Code Review Task Branch 3369a Revision 11219
I'm good with the change.
Greg Shah
02:43 PM Feature #3369: add support for BGCOLOR-RGB and FGCOLOR-RGB, FWD extension widget attributes
Revision 11219 contains a fix for unresponsive message boxes. Somebody please review. Hynek Cihlar
02:25 PM Feature #3369: add support for BGCOLOR-RGB and FGCOLOR-RGB, FWD extension widget attributes
Committed revision 11218 removed waste code due to the web client profiling done by Eric. Sergey Ivanovskiy
09:41 AM Bug #3382: Client-side popup menus abend
The problem with popup menus created at client side is that they can cause abend under a certain circumstances, e.g. ... Stanislav Lomany
09:18 AM Bug #3382 (Closed): Client-side popup menus abend
Stanislav Lomany
08:33 AM Bug #3368 (Closed): dialog-box frame height is not set correctly
Greg Shah
08:20 AM Bug #3368: dialog-box frame height is not set correctly
3368a was merged in trunk as revision 11202 and archived. Hynek Cihlar
06:23 AM Bug #3368: dialog-box frame height is not set correctly
Code Review Task Branch 3368a Revision 11205
The changes are good. You can merge to trunk.
Greg Shah
05:22 AM Bug #3368: dialog-box frame height is not set correctly
3368a revision 11205 contains a small change that resolves a regression found during ChUI testing. The revision has ... Hynek Cihlar
08:12 AM Bug #3381: Sub-menu drawing issues
Testcase attached (@sub-menus.p@). The following scenarios have issues:
# Right-click on the button: in swing the ri...
Stanislav Lomany
05:43 AM Bug #3381 (Closed): Sub-menu drawing issues
Stanislav Lomany
06:57 AM Bug #3370: READ-ONLY attribute error in server log
I think this needs to be separate from 3369a, so that we don't introduce a delay in getting the most critical changes... Greg Shah
05:23 AM Bug #3370 (WIP): READ-ONLY attribute error in server log
Ovidiu Maxiniuc
05:22 AM Bug #3370: READ-ONLY attribute error in server log
Greg,
I finished moving the READ-ONLY attribute to a new interface.
Because the introduction of the new interface @...
Ovidiu Maxiniuc
05:10 AM Bug #3370: READ-ONLY attribute error in server log
I found that @CommonHandle.readOnlyError(String)@ is annotated with @@LegacyAttribute(name = "READ-ONLY")@.
I cons...
Ovidiu Maxiniuc
02:48 AM Bug #3373: incremental scroll in non-full Browse page
The issue occurs because the browse is not yet initialized at the point when "END" event is applied. So we must figur... Stanislav Lomany

11/21/2017

04:03 PM Feature #3369: add support for BGCOLOR-RGB and FGCOLOR-RGB, FWD extension widget attributes
3355a was merged into 3369a rev. 11213. Sergey Ivanovskiy
12:37 PM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...
> As far as I understand file choose dialog (for choosing report output file) is in WIP state, so it works to a cert... Greg Shah
09:01 AM Bug #3371: NPE in AbstractGuiDriver in client log
Constantin Asofiei wrote:
> Ovidiu, please try something: is @EditorGuiImpl.processScrollPane@ called when i.e. the ...
Ovidiu Maxiniuc
08:41 AM Bug #3371: NPE in AbstractGuiDriver in client log
Ovidiu, please try something: is @EditorGuiImpl.processScrollPane@ called when i.e. the editor is drawn? I wonder if... Constantin Asofiei
08:33 AM Bug #3371: NPE in AbstractGuiDriver in client log
I tried to move the code in a @withSelectedWindow()@, but the widget is not fully reconstructed so the parent is not ... Ovidiu Maxiniuc
06:42 AM Bug #3368: dialog-box frame height is not set correctly
Code Review Task Branch 3368a Revision 11204
I'm fine with the code. If it passes regression testing, you can mer...
Greg Shah
06:21 AM Bug #3368: dialog-box frame height is not set correctly
Greg Shah wrote:
> except it is not clear why the null check was removed from @FrameGuiImpl@.
The null check was ...
Hynek Cihlar
07:01 PM Bug #3368: dialog-box frame height is not set correctly
Code Review Task Branch 3368a Revision 11203
I'm fine with the changes, except it is not clear why the null check ...
Greg Shah

11/20/2017

05:35 PM Bug #3371: NPE in AbstractGuiDriver in client log
Ovidiu, I would rather ensure that @EditorGuiImpl.computeLineWidths@ has a window selected (i.e. is bracketed in @gd.... Constantin Asofiei
03:11 PM Bug #3371: NPE in AbstractGuiDriver in client log
Code Review Task Branch 3369a Revision 11211
I generally OK with the changes. The one thing that is not clear to ...
Greg Shah
04:46 PM Bug #3368: dialog-box frame height is not set correctly
The incorrect size turned to be a problem in the frame layout itself. The frame height is not calculated correctly wh... Hynek Cihlar
01:28 PM Feature #3369: add support for BGCOLOR-RGB and FGCOLOR-RGB, FWD extension widget attributes
Code Review Task Branch 3369a Revision 11209
I'm fine with the changes. I checked in some minor changes to make i...
Greg Shah
01:08 PM Feature #3369: add support for BGCOLOR-RGB and FGCOLOR-RGB, FWD extension widget attributes
Constantin Asofiei wrote:
> Eric, I couldn't reproduce the iframe issue you've reported with 3369a. If you have any...
Eric Faulhaber
01:02 PM Feature #3369: add support for BGCOLOR-RGB and FGCOLOR-RGB, FWD extension widget attributes
Constantin Asofiei wrote:
> Eric: Persistence.java needs a history entry.
Done.
Eric Faulhaber
12:58 PM Feature #3369: add support for BGCOLOR-RGB and FGCOLOR-RGB, FWD extension widget attributes
Eric, I couldn't reproduce the iframe issue you've reported with 3369a. If you have any other details I can use to d... Constantin Asofiei
12:46 PM Feature #3369: add support for BGCOLOR-RGB and FGCOLOR-RGB, FWD extension widget attributes
Greg, 3369a rev 11208 is ready for review.
Eric: Persistence.java needs a history entry.
Constantin Asofiei
10:30 AM Feature #3369: add support for BGCOLOR-RGB and FGCOLOR-RGB, FWD extension widget attributes
3369a rebased from trunk 11201. new rev is 11207. Constantin Asofiei
10:26 AM Bug #2799: browse widget doesn't execute validation expressions in P2J (both chui and gui)
Stanislav Lomany wrote:
> > And now the BROWSE version is also fully supported, right?
> Right.
Please update th...
Greg Shah
10:12 AM Bug #2799: browse widget doesn't execute validation expressions in P2J (both chui and gui)
> And now the BROWSE version is also fully supported, right?
Right.
Stanislav Lomany
09:50 AM Bug #2799: browse widget doesn't execute validation expressions in P2J (both chui and gui)
> @FRAME:NO-AUTO-VALIDATE@ option is mentioned here and I didn't deal with it. Otherwise it can be closed.
I belie...
Greg Shah
09:53 AM Bug #3373: incremental scroll in non-full Browse page
Stanislav Lomany wrote:
> I'm not sure.
> Ovidiu, how did you managed to create a @0 DOWN@ browse? (normally you ca...
Ovidiu Maxiniuc
09:46 AM Bug #3373: incremental scroll in non-full Browse page
I'm not sure.
Ovidiu, how did you managed to create a @0 DOWN@ browse? (normally you can't create a browse with less...
Stanislav Lomany
09:40 AM Bug #3373: incremental scroll in non-full Browse page
How much work is it to fix? Greg Shah
09:38 AM Bug #3373: incremental scroll in non-full Browse page
Yes. Stanislav Lomany
09:36 AM Bug #3373: incremental scroll in non-full Browse page
> No, it's internal P2J error.
@recordOrShowError()@ is only for "real" 4GL errors.
Is this a P2J bug?
Greg Shah
09:01 AM Bug #3373: incremental scroll in non-full Browse page
No, it's internal P2J error. Stanislav Lomany
08:59 AM Bug #3373: incremental scroll in non-full Browse page
Is there an error in the 4GL? Greg Shah
08:49 AM Bug #3373: incremental scroll in non-full Browse page
Let me know if I should fix it (before/after deadline?). Stanislav Lomany
08:46 AM Bug #3373: incremental scroll in non-full Browse page
That is the event which represents a programming error. The text can be changed to "Incremental scroll cannot be used... Stanislav Lomany
08:06 AM Bug #3373: incremental scroll in non-full Browse page
The call to @incrementalScroll@ is caused by an... Ovidiu Maxiniuc
09:39 AM Bug #3370: READ-ONLY attribute error in server log
I agree with the solution. Greg Shah
09:06 AM Bug #3370: READ-ONLY attribute error in server log
I investigated this issue. The root cause of this error is the fact that the @READ-ONLY@ attribute is declared in @Co... Ovidiu Maxiniuc

11/19/2017

05:31 PM Bug #3306: Improve intermediate state in ROW-DISPLAY trigger.
That is still an amount of unplesant work which IMO we don't need to touch until customer meets a real problem with i... Stanislav Lomany
05:19 PM Bug #2799: browse widget doesn't execute validation expressions in P2J (both chui and gui)
@FRAME:NO-AUTO-VALIDATE@ option is mentioned here and I didn't deal with it. Otherwise it can be closed. Stanislav Lomany
05:11 PM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...
I was creating pop-up menu from a browse and met some issues:
1. As far as I understand file choose dialog (for choo...
Stanislav Lomany
07:28 PM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...
Stanislav Lomany wrote:
> We need to have the switch for enhanced browse features, so I created this container, sear...
Greg Shah

11/18/2017

06:46 PM Bug #3306: Improve intermediate state in ROW-DISPLAY trigger.
What is the status of this? Greg Shah
06:45 PM Bug #2799: browse widget doesn't execute validation expressions in P2J (both chui and gui)
Can this be closed? Greg Shah
06:43 PM Feature #3275 (Closed): improve browse support
Greg Shah

11/17/2017

02:30 PM Bug #3374: NPE in ConfigManager
Ovidiu Maxiniuc wrote:
> Also, the location (@ConfigManager.java@:350) does not make sense: the @dirtyConfigs@ is in...
Ovidiu Maxiniuc
01:54 PM Bug #3374: NPE in ConfigManager
The client is reset (back to login screen) when clicking various widgets. I found this is client log:... Ovidiu Maxiniuc
01:48 PM Bug #3374 (Closed): NPE in ConfigManager
Ovidiu Maxiniuc
02:09 PM Bug #3375: Stack overflow kills the client
The client got killed (not reset). Just before that the two shown windows started blinking alternatively. This is pro... Ovidiu Maxiniuc
02:06 PM Bug #3375 (Closed): Stack overflow kills the client
Ovidiu Maxiniuc
01:43 PM Bug #3373: incremental scroll in non-full Browse page
I found the following stack trace in client log:... Ovidiu Maxiniuc
01:38 PM Bug #3373 (Closed): incremental scroll in non-full Browse page
Ovidiu Maxiniuc
11:45 AM Bug #3371 (WIP): NPE in AbstractGuiDriver in client log
Found following exception in client log:... Ovidiu Maxiniuc
11:36 AM Bug #3371 (Closed): NPE in AbstractGuiDriver in client log
Ovidiu Maxiniuc
 

Also available in: Atom