FWD » Core Development » User Interface

05/15/2019

11:55 AM Bug #4078: cannot login in Hotel demo in Swing mode

Code review 4078a revision 11311.
Alexei, the check for @ps.text == null@ and assigning @"NULL"@ doesn't solve the... Hynek Cihlar

11:10 AM Bug #4078: cannot login in Hotel demo in Swing mode

Hynek, please do a code review. Greg Shah

10:29 AM Bug #4078: cannot login in Hotel demo in Swing mode

Please code review task branch secure/code/p2j_repo/p2j/active/4078a revision 11311.
Alexei Kaigorodov

05/14/2019

07:57 AM Bug #4078: cannot login in Hotel demo in Swing mode

attached are the files with what I see when breakpoint in ThinClient.pushScreenDefinition is hit.
The ButtonConfig w... Alexei Kaigorodov

06:39 AM Bug #4078: cannot login in Hotel demo in Swing mode

This is OK for temporarily making things work, but this isn't a fix to the root cause of the problem. The issue must... Greg Shah

05:38 AM Bug #4078: cannot login in Hotel demo in Swing mode

made a fix to avoid NPE in file ui/client/gui/driver/swing/SwingEmulatedWindow.java:1747:
if (text == null)
{... Alexei Kaigorodov

05:26 AM Bug #3691: literal $ character in format appears on the right side of the fill-in

I made a fix to hotel_gui/abl/update-rate-dialog.w and commited it (rev. 198).
*GES: The following notes are moved... Alexei Kaigorodov

05/13/2019

01:58 PM Feature #3908: implement browse column VIEW-AS COMBO-BOX

Rebased task branch 3908a from P2J trunk revision 11309.
3908a has been merged into the trunk as bzr revision 11310. Stanislav Lomany

01:13 PM Feature #3908: implement browse column VIEW-AS COMBO-BOX

OK, go ahead and merge once you've rebased. Greg Shah

12:39 PM Feature #3908: implement browse column VIEW-AS COMBO-BOX

Greg Shah wrote:
> Constantin: Do you have an objection to this being merged to trunk?
I'm OK with being merged to ... Constantin Asofiei

12:34 PM Feature #3908: implement browse column VIEW-AS COMBO-BOX

Please rebase from 11309.
Constantin: Do you have an objection to this being merged to trunk? Greg Shah

11:53 AM Feature #3908: implement browse column VIEW-AS COMBO-BOX

Missing conversion:
@[ MAX-CHARS characters ] [ AUTO-COMPLETION [ UNIQUE-MATCH ] ]@
Missing attributes:
@AUTO-CO... Stanislav Lomany

09:29 AM Feature #3908: implement browse column VIEW-AS COMBO-BOX

> I'll mark runtime support as partial.
I thought only the quirks where missing. Please post a detailed list of a... Greg Shah

09:02 AM Feature #3908: implement browse column VIEW-AS COMBO-BOX

> It passed ChUI conversion regression testing?
Yes.

> Also: the gap marking changes is not there. Please add... Stanislav Lomany

08:49 AM Feature #3908: implement browse column VIEW-AS COMBO-BOX

It passed ChUI conversion regression testing?
Also: the gap marking changes is not there. Please add those to 4069a. Greg Shah

08:41 AM Bug #4078: cannot login in Hotel demo in Swing mode

No, it does not look like a race condition. I clicked on different list items in different tabs and always got an NPE... Alexei Kaigorodov

08:11 AM Bug #3691: literal $ character in format appears on the right side of the fill-in

> Do I need to investigate the reason of this incompatibility?
Yes, please do. Greg Shah

04:57 AM Bug #3691: literal $ character in format appears on the right side of the fill-in

So the correction is to remove drawing of the "$" sign as separate string and replacing the format string ">>>,>>9.99... Alexei Kaigorodov

02:06 AM Bug #3691: literal $ character in format appears on the right side of the fill-in

I created a test program which runs on OpenEdge. Its visualization is exactly the same as on FWD. See the attached fi... Alexei Kaigorodov

05/12/2019

01:00 PM Feature #3908: implement browse column VIEW-AS COMBO-BOX

Rebased task branch 3908a from P2J trunk revision 11308.
Passed regression testing basing on trunk revision 11306. S... Stanislav Lomany

05/10/2019

09:31 AM Bug #4078: cannot login in Hotel demo in Swing mode

> 1. make drawButton method more robust and do not issue NPE for any malformed buttons.
Agreed.
> 2. find out w... Greg Shah

08:09 AM Bug #4078: cannot login in Hotel demo in Swing mode

What I found so far.
The main window of the Hotel Demo has several tabs. Each tab contains a scrollable list of item... Alexei Kaigorodov

02:05 AM Bug #4078: cannot login in Hotel demo in Swing mode

You could, but that would wipe out the current conversion results and database and start the full conversion and data... Eric Faulhaber

01:36 AM Bug #4078: cannot login in Hotel demo in Swing mode

No, I did not. Should I also run *ant clean* and *ant deploy.all*? Alexei Kaigorodov

01:32 AM Bug #4078: cannot login in Hotel demo in Swing mode

I backed out the workaround and it still fails the same way for me. Did you run @ant deploy.prepare@ in @hotel_gui@ a... Eric Faulhaber

01:19 AM Bug #4078: cannot login in Hotel demo in Swing mode

Eric,
I made similar workaround - but conditional statement, not expression, to be able to set breakpoint when text=... Alexei Kaigorodov

01:08 AM Bug #4078: cannot login in Hotel demo in Swing mode

FWIW, here is a simple workaround I used to get past the NPE so I could log in and test the widget browser with Hotel... Eric Faulhaber

07:37 AM Bug #3691: literal $ character in format appears on the right side of the fill-in

This does suggest there *may not* be a FWD bug here.
Before we consider any 4GL code changes, I want to *make sure... Greg Shah

07:05 AM Bug #3691: literal $ character in format appears on the right side of the fill-in

Greg, you are right. The source file update-rate-dialog.w has lines:... Alexei Kaigorodov

05:57 AM Bug #3691: literal $ character in format appears on the right side of the fill-in

Eric Faulhaber wrote:
> Hynek, Constantin, this is the first time I've run the widget browser, so modifying the @cli... Hynek Cihlar

01:00 AM Bug #3691: literal $ character in format appears on the right side of the fill-in

Alexei Kaigorodov wrote:
> Constantin, https://proj.goldencode.com/projects/internal-documentation/wiki/Getting_Star... Eric Faulhaber

10:54 PM Bug #3691: literal $ character in format appears on the right side of the fill-in

Constantin, https://proj.goldencode.com/projects/internal-documentation/wiki/Getting_Started_with_FWD_Development
... Alexei Kaigorodov

01:10 AM Bug #4072 (Rejected): NPE logging into Hotel GUI with Swing client

Fix will be worked in #4078. Eric Faulhaber

05/09/2019

11:52 AM Bug #3691: literal $ character in format appears on the right side of the fill-in

Alexei, if you compile FWD with a @-Dwidget.browser=true@ at the @ant@ command, then you will have a widget browser w... Constantin Asofiei

11:45 AM Bug #3691: literal $ character in format appears on the right side of the fill-in

Focus on this one: @"$" VIEW-AS TEXT@. Perhaps the problem is that it is being placed in the wrong location? Greg Shah

11:29 AM Bug #3691: literal $ character in format appears on the right side of the fill-in

There any many use of the $ character .cache files, but not in update-rate-dialog.w.cache (no changes there compared ... Alexei Kaigorodov

10:45 AM Bug #3691: literal $ character in format appears on the right side of the fill-in

Is there any use of the @$@ character in that program (check the .cache file which has been fully preprocessed)? Greg Shah

09:14 AM Bug #3691: literal $ character in format appears on the right side of the fill-in

the original code is in file update-rate-dialog.w:
DEFINE VARIABLE roomRate AS DECIMAL FORMAT ">>>,>>9.99":U INITIAL... Alexei Kaigorodov

09:06 AM Bug #3691: literal $ character in format appears on the right side of the fill-in

> the format string is not changed (and does not contain any dollar sign)
What is the 4GL code that has been conve... Greg Shah

08:55 AM Bug #3691: literal $ character in format appears on the right side of the fill-in

I saw in debugger that the format string is not changed (and does not contain any dollar sign).
There can be 2 ... Alexei Kaigorodov

08:43 AM Bug #4078 (WIP): cannot login in Hotel demo in Swing mode

Alexei Kaigorodov

07:31 AM Bug #4078: cannot login in Hotel demo in Swing mode

1. run deploy/server/server.sh
2. run deploy/client/client.sh
3. window appear; enter credentials hotel/hotel
4. t... Alexei Kaigorodov

07:21 AM Bug #4078 (Closed): cannot login in Hotel demo in Swing mode

Alexei Kaigorodov

08:40 AM Bug #3630 (Closed): SYSTEM-DIALOG GET-FILE abends with an NPE when INITIAL-DIR not specified

Greg Shah

08:37 AM Bug #3630: SYSTEM-DIALOG GET-FILE abends with an NPE when INITIAL-DIR not specified

Greg Shah wrote:
> Hynek: Can we close this issue?
Yes, I believe so. I checked the test case and it works OK wit... Hynek Cihlar

08:32 AM Bug #3630: SYSTEM-DIALOG GET-FILE abends with an NPE when INITIAL-DIR not specified

Hynek: Can we close this issue? Greg Shah

08:30 AM Bug #3631: SYSTEM-DIALOG FONT won't accept keyboard input in the selection lists

Please work on the initial focus issue. The dialog is implemented in @com/goldencode/p2j/ui/client/gui/FontChooserGu... Greg Shah

08:19 AM Bug #3631: SYSTEM-DIALOG FONT won't accept keyboard input in the selection lists

If focus manually is pointed into the selection list, keyboard input is possible. Alexei Kaigorodov

08:15 AM Bug #3631: SYSTEM-DIALOG FONT won't accept keyboard input in the selection lists

If you manually put focus into a selection list, does it accept keyboard input? Greg Shah

05/08/2019

01:54 PM Feature #3908: implement browse column VIEW-AS COMBO-BOX

> Greg, should I run regression testing?
Yes, go ahead. Greg Shah

01:45 PM Feature #3908: implement browse column VIEW-AS COMBO-BOX

Stanislav Lomany wrote:
> > * ComboBoxGuiImpl.setValue - the condition @config.mode == Mode.DROP_DOWN || config.mode... Hynek Cihlar

01:43 PM Feature #3908: implement browse column VIEW-AS COMBO-BOX

The issues are addressed in 3908a rev 11313
> * setViewAsComboBox(boolean) - the boolean parameter is redundant an... Stanislav Lomany

01:47 PM Feature #4077: add option to OPEN-MIME-RESOURCE to delete the original source file when the send ...

@OPEN-MIME-RESOURCE@ is often used when 4GL code generates some output and wants to get it to the user. There is a c... Greg Shah

01:39 PM Feature #4077 (Closed): add option to OPEN-MIME-RESOURCE to delete the original source file when ...

Greg Shah

09:00 AM Bug #3691: literal $ character in format appears on the right side of the fill-in

From Alexei:
> Installed the Hotel demo and made sure the bug exists, Now thinking how to find the place where th... Greg Shah

08:35 AM Bug #4075: Combo-box columns 4GL quirks

In 4GL combo box columns are not implemented well: they have a many quirks. The list below describes the differences ... Stanislav Lomany

05:27 AM Bug #4075 (New): Combo-box columns 4GL quirks

Stanislav Lomany

04:07 AM Bug #3631: SYSTEM-DIALOG FONT won't accept keyboard input in the selection lists

A test file (attached) runs successfully under FWD (revision 11304).
Keyboard input is accepted, though after moving... Alexei Kaigorodov

02:43 AM Bug #3630: SYSTEM-DIALOG GET-FILE abends with an NPE when INITIAL-DIR not specified

Cannot reproduce. Created a test file (attached), it runs successfully on FWD (revision 11304). Alexei Kaigorodov

05/07/2019

06:07 PM Bug #4074: Mismatching ROW-ENTRY/LEAVE events

Also, this code in @Browse.goUp@ doesn't seem valid:... Stanislav Lomany

06:02 PM Bug #4074: Mismatching ROW-ENTRY/LEAVE events

The issue is that in FWD @ROW-ENTRY@ and @ROW-LEAVE@ events are generated when user leaves or enters a row in editing... Stanislav Lomany

04:27 PM Bug #4074 (Closed): Mismatching ROW-ENTRY/LEAVE events

Stanislav Lomany

12:23 AM Bug #4072: NPE logging into Hotel GUI with Swing client

Found with 4045a/11311 and fresh checkout of hotel_gui rev 197. Probably in trunk 11306 as well. To recreate, just st... Eric Faulhaber

12:19 AM Bug #4072 (Rejected): NPE logging into Hotel GUI with Swing client

Eric Faulhaber

05/06/2019

03:30 PM Feature #3908: implement browse column VIEW-AS COMBO-BOX

Code review 3908a.
* setViewAsComboBox(boolean) - the boolean parameter is redundant and should be removed (false ... Hynek Cihlar

05/03/2019

04:49 PM Feature #3908: implement browse column VIEW-AS COMBO-BOX

Please review 3908a rev 11312, especially the changes for standalone combos. Stanislav Lomany

05/01/2019

05:37 PM Feature #3908: implement browse column VIEW-AS COMBO-BOX

Rebased task branch 3908a from P2J trunk revision 11306. Stanislav Lomany

01:25 PM Support #4062: getChanges() performance improvements

From Eric (see #3992-162):
> In @LT.getChanges()@, we iterate the entire @frameRegistry@ map on each call, which i... Greg Shah

01:24 PM Support #4062 (New): getChanges() performance improvements

Greg Shah

11:25 AM Support #4059: UI performance improvements (master task)

This task is a master index of planned/proposed UI performance work:
* #4912 move UI portions of the web client to... Greg Shah

11:18 AM Support #4059 (New): UI performance improvements (master task)

Greg Shah

11:13 AM Feature #3684 (Closed): implement a web theme inspired by material design

Greg Shah

10:17 AM Bug #2921 (Closed): fix vertical placement of FILL-IN (editable or not)/LABEL/EDITOR text

Branch 3811a was merged to trunk as revision 11303. Greg Shah

04/23/2019

06:35 PM Feature #3908: implement browse column VIEW-AS COMBO-BOX

Side issue: a regular combo in FWD with decimals should round decimals according to the format prescision before cmpa... Stanislav Lomany

09:57 AM Feature #3908: implement browse column VIEW-AS COMBO-BOX

> It is interesting than for integer columns
For decimal columns too.
Stanislav Lomany

09:54 AM Feature #3908: implement browse column VIEW-AS COMBO-BOX

It is interesting than for integer columns spaces are taken into cosideration for comparision. So... Stanislav Lomany

03:53 PM Feature #3876: add support for "direct font control" at the widget level

This issue is resolved with revision 11306 in 3767a. Please review. Hynek Cihlar

07:34 AM Feature #1795: implement printing support (real GUI printing not the child process stuff used in ...

> I added it to a Possenet zip file which later on became the initial revision of the repository.
Ahh. That expla... Greg Shah

02:39 AM Feature #1795: implement printing support (real GUI printing not the child process stuff used in ...

Greg Shah wrote:
> Hynek Cihlar wrote:
> > The attached file is the modified @_osprint.p@ with the native code remo... Hynek Cihlar

04/22/2019

06:32 PM Feature #4049: implement mouse wheel for combo-boxes

It affects drop-down mode. But in the attached testcase I can observe scrolling issues in simple mode, but the scroll... Stanislav Lomany

06:13 PM Feature #4049: implement mouse wheel for combo-boxes

Stanislav: Is this for the drop down mode or simple mode or both? Greg Shah

06:12 PM Feature #4049 (New): implement mouse wheel for combo-boxes

Greg Shah

06:09 PM Feature #3908: implement browse column VIEW-AS COMBO-BOX

Correction: 4GL behaves correctly for non-character columns regarding cell rendering and item selection when a cell g... Stanislav Lomany

01:12 PM Feature #3908: implement browse column VIEW-AS COMBO-BOX

BTW scrolling with mouse wheel is not implemented for regular combo-boxes. Stanislav Lomany

09:32 AM Feature #3908: implement browse column VIEW-AS COMBO-BOX

> The issue described in #3908-10 is questionable. Personally, I would like to implement a normal behavior. Because s... Greg Shah

08:31 AM Feature #3908: implement browse column VIEW-AS COMBO-BOX

> Can we do something simple to allow non-character fields to be functional without breaking compatibility?
Charac... Stanislav Lomany

07:37 AM Feature #3908: implement browse column VIEW-AS COMBO-BOX

Stanislav Lomany wrote:
> > If there is no corresponding value in combo box-list, it displays the last used combo-bo... Greg Shah

04:28 AM Feature #3908: implement browse column VIEW-AS COMBO-BOX

> If there is no corresponding value in combo box-list, it displays the last used combo-box value for this column. So... Stanislav Lomany

01:07 PM Feature #3281: implement some frame options

Greg Shah wrote:
> The gap marking for the color phrase seems wrong (from @rules/gaps/user_interface.rules@):
>
>... Constantin Asofiei

10:21 AM Feature #3281: implement some frame options

The gap marking for the color phrase seems wrong (from @rules/gaps/user_interface.rules@):... Greg Shah

11:42 AM Bug #3686 (Closed): PSTimer threads must be cleaned up when the client session terminates

Branch 3750b was merged to trunk as revision 11302. Greg Shah

10:24 AM Bug #3686: PSTimer threads must be cleaned up when the client session terminates

Greg Shah wrote:
> Did branch 3750b resolve this issue?
Yes. Constantin Asofiei

10:12 AM Bug #3686: PSTimer threads must be cleaned up when the client session terminates

Did branch 3750b resolve this issue? Greg Shah

04/19/2019

05:59 PM Feature #3940: CREATE-RESULT-LIST-ENTRY() method support

Addition: 10. We may also want to test @EACH, FIRST/LAST/UNIQUE@ cases. Really not sure about cases where @FIRST/LAST... Stanislav Lomany

09:14 AM Feature #3940: CREATE-RESULT-LIST-ENTRY() method support

> Testcases should be for all FWD query types: PreselectQuery, AdaptiveQuery, CompoundQuery etc. (we need to provide ... Greg Shah

07:57 AM Feature #3940: CREATE-RESULT-LIST-ENTRY() method support

> What aspects of the problem still need testcases? We will have external resources write these.
Testcases for @Q... Stanislav Lomany

01:51 PM Feature #1795: implement printing support (real GUI printing not the child process stuff used in ...

Hynek Cihlar wrote:
> The attached file is the modified @_osprint.p@ with the native code removed using the implemen... Greg Shah

04/18/2019

04:02 PM Feature #3908: implement browse column VIEW-AS COMBO-BOX

Strange, but only @character@ combo columns display the item description instead of the item value in a cell. However... Stanislav Lomany

09:29 AM Feature #3908: implement browse column VIEW-AS COMBO-BOX

> I assume that @value@ means the raw data in the backing lvalue (variable or database field). Correct?
Yes.

>... Stanislav Lomany

09:01 AM Feature #3908: implement browse column VIEW-AS COMBO-BOX

I'm trying to understand your syntax in the last note.
I assume that @value@ means the raw data in the backing lva... Greg Shah

04/17/2019

07:58 PM Feature #3908: implement browse column VIEW-AS COMBO-BOX

Currently browse cells are rendered at the server side: @value --srv--> screen-value@. Combo columns add a new layer ... Stanislav Lomany

03:46 AM Feature #3908: implement browse column VIEW-AS COMBO-BOX

> I'm trying to imagine the insane code inside the 4GL that causes this. It makes no sense at all.
I guess that's... Stanislav Lomany

08:04 PM Feature #3908: implement browse column VIEW-AS COMBO-BOX

> So, from a user's perspective if a cell has no corresponding value in the combo-box, a random value will be display... Greg Shah

04/16/2019

04:27 PM Feature #3908: implement browse column VIEW-AS COMBO-BOX

FYI. When a combo-box cell gains focus, it displays the value which corresponds the cell value. If there is no corres... Stanislav Lomany

10:24 AM Feature #3908: implement browse column VIEW-AS COMBO-BOX

> Please summarize status here.
I'm working on rendering/screen-value part. Because combo-box cells behavior diffe... Stanislav Lomany

08:49 AM Feature #3908: implement browse column VIEW-AS COMBO-BOX

Please summarize status here.
When will this be complete and stable? Greg Shah

09:08 AM Feature #3811 (Pending): more misc UI features

The rest of the implementation work is deferred until the @MANUAL-HIGHLIGHT@ 4GL testcases are ready. Greg Shah

09:07 AM Feature #3811: more misc UI features

Greg Shah wrote:
> Please confirm that everything is complete except for @MANUAL-HIGHLIGHT@, for which we need 4GL t... Eugenie Lyzenko

08:44 AM Feature #3811: more misc UI features

For the @MANUAL-HIGHLIGHT@ 4GL testcases:
* We understand that some widgets do not honor @MANUAL-HIGHLIGHT@. The ... Greg Shah

08:38 AM Feature #3811: more misc UI features

Please confirm that everything is complete except for @MANUAL-HIGHLIGHT@, for which we need 4GL testcases. Greg Shah

07:31 AM Feature #3811: more misc UI features

Branch @3811a@ was merged to trunk as revno @11303@ then it was archived. Eugenie Lyzenko

07:14 AM Feature #3811: more misc UI features

Greg Shah wrote:
> Yes, go ahead.
Testing completed. The results: @3811a_11326_32748a0_20190416_evl.zip@.
No r... Eugenie Lyzenko

06:49 AM Feature #3811: more misc UI features

Yes, go ahead. Greg Shah

03:38 AM Feature #3811: more misc UI features

The main regression part completed without regressions. Waiting for @CTRL-C@ to be done.
Can I merge @3811a@ into ... Eugenie Lyzenko

08:46 AM Feature #3762 (Closed): misc UI features

Branch 3811a was merged to trunk as revision 11303. This finishes the work in this task. Greg Shah