FWD » Core Development » User Interface

05/25/2019

02:11 PM Bug #4078: cannot login in Hotel demo in Swing mode

Code review 4078b revision 11311. The changes are OK. Just add the file history entries at the top of each file. Hynek Cihlar

05/24/2019

12:35 PM Bug #4078: cannot login in Hotel demo in Swing mode

Hynek Cihlar wrote:
> It should be safe to set the label in @ButtonConfig.init()@ for both dynamically and staticall... Alexei Kaigorodov

01:52 AM Bug #4078: cannot login in Hotel demo in Swing mode

Alexei Kaigorodov wrote:
> Hynek Cihlar wrote:
> > Alexei, the button label must be initialized to empty string.
>... Hynek Cihlar

11:57 PM Bug #4078: cannot login in Hotel demo in Swing mode

Hynek Cihlar wrote:
> Alexei, the button label must be initialized to empty string.
label is declared in ControlCon... Alexei Kaigorodov

05/23/2019

12:46 PM Bug #4078: cannot login in Hotel demo in Swing mode

Alexei, the button label must be initialized to empty string. Look at the following test case.... Hynek Cihlar

12:23 PM Bug #4078: cannot login in Hotel demo in Swing mode

The diff attached as patch11311.txt. Alexei Kaigorodov

09:44 AM Bug #4078: cannot login in Hotel demo in Swing mode

If you have one, please post the proposed diff for your solution. Greg Shah

09:33 AM Bug #4078: cannot login in Hotel demo in Swing mode

I tested, the bug occurs on MaterialTheme, Windows10Theme, Windows8Theme and ClassicTheme. Alexei Kaigorodov

09:33 AM Bug #4078: cannot login in Hotel demo in Swing mode

the bug occur on MaterialTheme, Windows10Theme, Windows8Theme and ClassicTheme. Alexei Kaigorodov

09:18 AM Bug #4078: cannot login in Hotel demo in Swing mode

Did you test this? A change in the directory and server restart is all that is needed to test. Greg Shah

09:05 AM Bug #4078: cannot login in Hotel demo in Swing mode

Greg Shah wrote:
> A related question: if you change the theme (search for it in the directory to see how), does the... Alexei Kaigorodov

08:46 AM Bug #4078: cannot login in Hotel demo in Swing mode

> If I have to investigate why preprocessor did so, I need to know where the documentation on preprocessor reside.
... Greg Shah

08:14 AM Bug #4078: cannot login in Hotel demo in Swing mode

Alexei Kaigorodov wrote:
> I found that malformed button is created in file hotel_gui/src/com/goldencode/hotel/commo... Hynek Cihlar

06:59 AM Bug #4078: cannot login in Hotel demo in Swing mode

I found that malformed button is created in file hotel_gui/src/com/goldencode/hotel/common/Afoldfr0.java:
@ 67: ha... Alexei Kaigorodov

05/22/2019

08:46 AM Bug #4078: cannot login in Hotel demo in Swing mode

The main business logic will be emitted as a class which has an @execute()@ method (for the external procedure) and o... Greg Shah

08:43 AM Bug #4078: cannot login in Hotel demo in Swing mode

Alexei Kaigorodov wrote:
> that is, @afoldrfr0.w.cached@ is converted in two .jast files? Where can I read how FWD c... Hynek Cihlar

07:35 AM Bug #4078: cannot login in Hotel demo in Swing mode

that is, @afoldrfr0.w.cached@ is converted in two .jast files? Where can I read how FWD chooses to convert one source... Alexei Kaigorodov

07:11 AM Bug #4078: cannot login in Hotel demo in Swing mode

Alexei Kaigorodov wrote:
> the change in MaterialTheme.java which causes NPE is at line 529, call to @gd.drawStringW... Hynek Cihlar

06:58 AM Bug #4078: cannot login in Hotel demo in Swing mode

the change in MaterialTheme.java which causes NPE is at line 529, call to @gd.drawStringWithMnemonic()@ changed to ... Alexei Kaigorodov

10:44 PM Bug #4078: cannot login in Hotel demo in Swing mode

The file with changes from rev 11299 to 11300 attached. Alexei Kaigorodov

05/21/2019

08:43 AM Bug #4078: cannot login in Hotel demo in Swing mode

@One simple thing you can do is to try trunk 11301 (convert and run Hotel GUI) to see if the problem can be reproduce... Alexei Kaigorodov

05/20/2019

12:16 PM Bug #4078: cannot login in Hotel demo in Swing mode

>> the null text is passed to the method when the client tries to draw a button which configuration was sent by the ... Greg Shah

12:10 PM Bug #4078: cannot login in Hotel demo in Swing mode

> The question remains, where in hotel_gui application buttons with not initialized labels are created. But these but... Greg Shah

08:21 AM Bug #4078: cannot login in Hotel demo in Swing mode

Alexei Kaigorodov wrote:
> Hynek Cihlar wrote:
> > Alexei, the check for @ps.text == null@ and assigning @"NULL"@ d... Hynek Cihlar

06:43 AM Bug #4078: cannot login in Hotel demo in Swing mode

Hynek Cihlar wrote:
> Alexei, the check for @ps.text == null@ and assigning @"NULL"@ doesn't solve the issue. Instea... Alexei Kaigorodov

05/17/2019

04:26 AM Bug #4078: cannot login in Hotel demo in Swing mode

Alexei Kaigorodov wrote:
> Hynek,
>
> testcases/simple/client/client-swing.sh is your own script? can you please ... Hynek Cihlar

04:20 AM Bug #4078: cannot login in Hotel demo in Swing mode

Hynek,
testcases/simple/client/client-swing.sh is your own script? can you please share it with me? Alexei Kaigorodov

02:37 AM Bug #4078: cannot login in Hotel demo in Swing mode

Alexei Kaigorodov wrote:
> Hynek,
>
> command
> 4. Run the server with cd testcases/simple/server && ./server.sh... Hynek Cihlar

02:21 AM Bug #4078: cannot login in Hotel demo in Swing mode

Hynek,
command
4. Run the server with cd testcases/simple/server && ./server.sh
caused an error saved in serv... Alexei Kaigorodov

01:17 AM Bug #4078: cannot login in Hotel demo in Swing mode

Hynek Cihlar wrote:
> Alexei Kaigorodov wrote:
> > Hynek,
> > yes there are another changes but they should not af... Hynek Cihlar

01:16 AM Bug #4078: cannot login in Hotel demo in Swing mode

Alexei Kaigorodov wrote:
> Hynek,
> yes there are another changes but they should not affect the execution. Can you... Hynek Cihlar

12:28 AM Bug #4078: cannot login in Hotel demo in Swing mode

Hynek,
yes there are another changes but they should not affect the execution. Can you please tell me how you prepar... Alexei Kaigorodov

05/16/2019

09:37 AM Bug #4078: cannot login in Hotel demo in Swing mode

Alexei Kaigorodov wrote:
> Hynek,
> the proposed abl test works fine both on openEdge and FWD/Swing. The problem I ... Hynek Cihlar

06:57 AM Bug #4078: cannot login in Hotel demo in Swing mode

Hynek,
the proposed abl test works fine both on openEdge and FWD/Swing. The problem I guess is that the malformed bu... Alexei Kaigorodov

05:38 AM Bug #4078: cannot login in Hotel demo in Swing mode

Alexei Kaigorodov wrote:
> I examined the call stack and found that the null text is passed to the method when the c... Hynek Cihlar

04:40 AM Bug #4078: cannot login in Hotel demo in Swing mode

client stack attached Alexei Kaigorodov

04:04 AM Bug #4078: cannot login in Hotel demo in Swing mode

Alexei Kaigorodov wrote:
> I examined the call stack and found that the null text is passed to the method when the c... Hynek Cihlar

01:59 AM Bug #4078: cannot login in Hotel demo in Swing mode

I examined the call stack and found that the null text is passed to the method when the client tries to draw a button... Alexei Kaigorodov

04:12 AM Bug #3631: SYSTEM-DIALOG FONT won't accept keyboard input in the selection lists

Alexei Kaigorodov wrote:
> The font chooser is implemented in the class FontChooserGuiImpl, field ComboBoxGuiImpl fo... Hynek Cihlar

02:02 AM Bug #3631: SYSTEM-DIALOG FONT won't accept keyboard input in the selection lists

The font chooser is implemented in the class FontChooserGuiImpl, field ComboBoxGuiImpl fontFaceCbx. But ComboBoxGuiI... Alexei Kaigorodov

05/15/2019

11:55 AM Bug #4078: cannot login in Hotel demo in Swing mode

Code review 4078a revision 11311.
Alexei, the check for @ps.text == null@ and assigning @"NULL"@ doesn't solve the... Hynek Cihlar

11:10 AM Bug #4078: cannot login in Hotel demo in Swing mode

Hynek, please do a code review. Greg Shah

10:29 AM Bug #4078: cannot login in Hotel demo in Swing mode

Please code review task branch secure/code/p2j_repo/p2j/active/4078a revision 11311.
Alexei Kaigorodov

05/14/2019

07:57 AM Bug #4078: cannot login in Hotel demo in Swing mode

attached are the files with what I see when breakpoint in ThinClient.pushScreenDefinition is hit.
The ButtonConfig w... Alexei Kaigorodov

06:39 AM Bug #4078: cannot login in Hotel demo in Swing mode

This is OK for temporarily making things work, but this isn't a fix to the root cause of the problem. The issue must... Greg Shah

05:38 AM Bug #4078: cannot login in Hotel demo in Swing mode

made a fix to avoid NPE in file ui/client/gui/driver/swing/SwingEmulatedWindow.java:1747:
if (text == null)
{... Alexei Kaigorodov

05:26 AM Bug #3691: literal $ character in format appears on the right side of the fill-in

I made a fix to hotel_gui/abl/update-rate-dialog.w and commited it (rev. 198).
*GES: The following notes are moved... Alexei Kaigorodov

05/13/2019

01:58 PM Feature #3908: implement browse column VIEW-AS COMBO-BOX

Rebased task branch 3908a from P2J trunk revision 11309.
3908a has been merged into the trunk as bzr revision 11310. Stanislav Lomany

01:13 PM Feature #3908: implement browse column VIEW-AS COMBO-BOX

OK, go ahead and merge once you've rebased. Greg Shah

12:39 PM Feature #3908: implement browse column VIEW-AS COMBO-BOX

Greg Shah wrote:
> Constantin: Do you have an objection to this being merged to trunk?
I'm OK with being merged to ... Constantin Asofiei

12:34 PM Feature #3908: implement browse column VIEW-AS COMBO-BOX

Please rebase from 11309.
Constantin: Do you have an objection to this being merged to trunk? Greg Shah

11:53 AM Feature #3908: implement browse column VIEW-AS COMBO-BOX

Missing conversion:
@[ MAX-CHARS characters ] [ AUTO-COMPLETION [ UNIQUE-MATCH ] ]@
Missing attributes:
@AUTO-CO... Stanislav Lomany

09:29 AM Feature #3908: implement browse column VIEW-AS COMBO-BOX

> I'll mark runtime support as partial.
I thought only the quirks where missing. Please post a detailed list of a... Greg Shah

09:02 AM Feature #3908: implement browse column VIEW-AS COMBO-BOX

> It passed ChUI conversion regression testing?
Yes.

> Also: the gap marking changes is not there. Please add... Stanislav Lomany

08:49 AM Feature #3908: implement browse column VIEW-AS COMBO-BOX

It passed ChUI conversion regression testing?
Also: the gap marking changes is not there. Please add those to 4069a. Greg Shah

08:41 AM Bug #4078: cannot login in Hotel demo in Swing mode

No, it does not look like a race condition. I clicked on different list items in different tabs and always got an NPE... Alexei Kaigorodov

08:11 AM Bug #3691: literal $ character in format appears on the right side of the fill-in

> Do I need to investigate the reason of this incompatibility?
Yes, please do. Greg Shah

04:57 AM Bug #3691: literal $ character in format appears on the right side of the fill-in

So the correction is to remove drawing of the "$" sign as separate string and replacing the format string ">>>,>>9.99... Alexei Kaigorodov

02:06 AM Bug #3691: literal $ character in format appears on the right side of the fill-in

I created a test program which runs on OpenEdge. Its visualization is exactly the same as on FWD. See the attached fi... Alexei Kaigorodov

05/12/2019

01:00 PM Feature #3908: implement browse column VIEW-AS COMBO-BOX

Rebased task branch 3908a from P2J trunk revision 11308.
Passed regression testing basing on trunk revision 11306. S... Stanislav Lomany

05/10/2019

09:31 AM Bug #4078: cannot login in Hotel demo in Swing mode

> 1. make drawButton method more robust and do not issue NPE for any malformed buttons.
Agreed.
> 2. find out w... Greg Shah

08:09 AM Bug #4078: cannot login in Hotel demo in Swing mode

What I found so far.
The main window of the Hotel Demo has several tabs. Each tab contains a scrollable list of item... Alexei Kaigorodov

02:05 AM Bug #4078: cannot login in Hotel demo in Swing mode

You could, but that would wipe out the current conversion results and database and start the full conversion and data... Eric Faulhaber

01:36 AM Bug #4078: cannot login in Hotel demo in Swing mode

No, I did not. Should I also run *ant clean* and *ant deploy.all*? Alexei Kaigorodov

01:32 AM Bug #4078: cannot login in Hotel demo in Swing mode

I backed out the workaround and it still fails the same way for me. Did you run @ant deploy.prepare@ in @hotel_gui@ a... Eric Faulhaber

01:19 AM Bug #4078: cannot login in Hotel demo in Swing mode

Eric,
I made similar workaround - but conditional statement, not expression, to be able to set breakpoint when text=... Alexei Kaigorodov

01:08 AM Bug #4078: cannot login in Hotel demo in Swing mode

FWIW, here is a simple workaround I used to get past the NPE so I could log in and test the widget browser with Hotel... Eric Faulhaber

07:37 AM Bug #3691: literal $ character in format appears on the right side of the fill-in

This does suggest there *may not* be a FWD bug here.
Before we consider any 4GL code changes, I want to *make sure... Greg Shah

07:05 AM Bug #3691: literal $ character in format appears on the right side of the fill-in

Greg, you are right. The source file update-rate-dialog.w has lines:... Alexei Kaigorodov

05:57 AM Bug #3691: literal $ character in format appears on the right side of the fill-in

Eric Faulhaber wrote:
> Hynek, Constantin, this is the first time I've run the widget browser, so modifying the @cli... Hynek Cihlar

01:00 AM Bug #3691: literal $ character in format appears on the right side of the fill-in

Alexei Kaigorodov wrote:
> Constantin, https://proj.goldencode.com/projects/internal-documentation/wiki/Getting_Star... Eric Faulhaber

10:54 PM Bug #3691: literal $ character in format appears on the right side of the fill-in

Constantin, https://proj.goldencode.com/projects/internal-documentation/wiki/Getting_Started_with_FWD_Development
... Alexei Kaigorodov

01:10 AM Bug #4072 (Rejected): NPE logging into Hotel GUI with Swing client

Fix will be worked in #4078. Eric Faulhaber

05/09/2019

11:52 AM Bug #3691: literal $ character in format appears on the right side of the fill-in

Alexei, if you compile FWD with a @-Dwidget.browser=true@ at the @ant@ command, then you will have a widget browser w... Constantin Asofiei

11:45 AM Bug #3691: literal $ character in format appears on the right side of the fill-in

Focus on this one: @"$" VIEW-AS TEXT@. Perhaps the problem is that it is being placed in the wrong location? Greg Shah

11:29 AM Bug #3691: literal $ character in format appears on the right side of the fill-in

There any many use of the $ character .cache files, but not in update-rate-dialog.w.cache (no changes there compared ... Alexei Kaigorodov

10:45 AM Bug #3691: literal $ character in format appears on the right side of the fill-in

Is there any use of the @$@ character in that program (check the .cache file which has been fully preprocessed)? Greg Shah

09:14 AM Bug #3691: literal $ character in format appears on the right side of the fill-in

the original code is in file update-rate-dialog.w:
DEFINE VARIABLE roomRate AS DECIMAL FORMAT ">>>,>>9.99":U INITIAL... Alexei Kaigorodov

09:06 AM Bug #3691: literal $ character in format appears on the right side of the fill-in

> the format string is not changed (and does not contain any dollar sign)
What is the 4GL code that has been conve... Greg Shah

08:55 AM Bug #3691: literal $ character in format appears on the right side of the fill-in

I saw in debugger that the format string is not changed (and does not contain any dollar sign).
There can be 2 ... Alexei Kaigorodov

08:43 AM Bug #4078 (WIP): cannot login in Hotel demo in Swing mode

Alexei Kaigorodov

07:31 AM Bug #4078: cannot login in Hotel demo in Swing mode

1. run deploy/server/server.sh
2. run deploy/client/client.sh
3. window appear; enter credentials hotel/hotel
4. t... Alexei Kaigorodov

07:21 AM Bug #4078 (Closed): cannot login in Hotel demo in Swing mode

Alexei Kaigorodov

08:40 AM Bug #3630 (Closed): SYSTEM-DIALOG GET-FILE abends with an NPE when INITIAL-DIR not specified

Greg Shah

08:37 AM Bug #3630: SYSTEM-DIALOG GET-FILE abends with an NPE when INITIAL-DIR not specified

Greg Shah wrote:
> Hynek: Can we close this issue?
Yes, I believe so. I checked the test case and it works OK wit... Hynek Cihlar

08:32 AM Bug #3630: SYSTEM-DIALOG GET-FILE abends with an NPE when INITIAL-DIR not specified

Hynek: Can we close this issue? Greg Shah

08:30 AM Bug #3631: SYSTEM-DIALOG FONT won't accept keyboard input in the selection lists

Please work on the initial focus issue. The dialog is implemented in @com/goldencode/p2j/ui/client/gui/FontChooserGu... Greg Shah

08:19 AM Bug #3631: SYSTEM-DIALOG FONT won't accept keyboard input in the selection lists

If focus manually is pointed into the selection list, keyboard input is possible. Alexei Kaigorodov

08:15 AM Bug #3631: SYSTEM-DIALOG FONT won't accept keyboard input in the selection lists

If you manually put focus into a selection list, does it accept keyboard input? Greg Shah

05/08/2019

01:54 PM Feature #3908: implement browse column VIEW-AS COMBO-BOX

> Greg, should I run regression testing?
Yes, go ahead. Greg Shah

01:45 PM Feature #3908: implement browse column VIEW-AS COMBO-BOX

Stanislav Lomany wrote:
> > * ComboBoxGuiImpl.setValue - the condition @config.mode == Mode.DROP_DOWN || config.mode... Hynek Cihlar

01:43 PM Feature #3908: implement browse column VIEW-AS COMBO-BOX

The issues are addressed in 3908a rev 11313
> * setViewAsComboBox(boolean) - the boolean parameter is redundant an... Stanislav Lomany

01:47 PM Feature #4077: add option to OPEN-MIME-RESOURCE to delete the original source file when the send ...

@OPEN-MIME-RESOURCE@ is often used when 4GL code generates some output and wants to get it to the user. There is a c... Greg Shah

01:39 PM Feature #4077 (Closed): add option to OPEN-MIME-RESOURCE to delete the original source file when ...

Greg Shah

09:00 AM Bug #3691: literal $ character in format appears on the right side of the fill-in

From Alexei:
> Installed the Hotel demo and made sure the bug exists, Now thinking how to find the place where th... Greg Shah

08:35 AM Bug #4075: Combo-box columns 4GL quirks

In 4GL combo box columns are not implemented well: they have a many quirks. The list below describes the differences ... Stanislav Lomany

05:27 AM Bug #4075 (New): Combo-box columns 4GL quirks

Stanislav Lomany

04:07 AM Bug #3631: SYSTEM-DIALOG FONT won't accept keyboard input in the selection lists

A test file (attached) runs successfully under FWD (revision 11304).
Keyboard input is accepted, though after moving... Alexei Kaigorodov

02:43 AM Bug #3630: SYSTEM-DIALOG GET-FILE abends with an NPE when INITIAL-DIR not specified

Cannot reproduce. Created a test file (attached), it runs successfully on FWD (revision 11304). Alexei Kaigorodov

05/07/2019

06:07 PM Bug #4074: Mismatching ROW-ENTRY/LEAVE events

Also, this code in @Browse.goUp@ doesn't seem valid:... Stanislav Lomany

06:02 PM Bug #4074: Mismatching ROW-ENTRY/LEAVE events

The issue is that in FWD @ROW-ENTRY@ and @ROW-LEAVE@ events are generated when user leaves or enters a row in editing... Stanislav Lomany

04:27 PM Bug #4074 (Closed): Mismatching ROW-ENTRY/LEAVE events

Stanislav Lomany

12:23 AM Bug #4072: NPE logging into Hotel GUI with Swing client

Found with 4045a/11311 and fresh checkout of hotel_gui rev 197. Probably in trunk 11306 as well. To recreate, just st... Eric Faulhaber

12:19 AM Bug #4072 (Rejected): NPE logging into Hotel GUI with Swing client

Eric Faulhaber

05/06/2019

03:30 PM Feature #3908: implement browse column VIEW-AS COMBO-BOX

Code review 3908a.
* setViewAsComboBox(boolean) - the boolean parameter is redundant and should be removed (false ... Hynek Cihlar

05/03/2019

04:49 PM Feature #3908: implement browse column VIEW-AS COMBO-BOX

Please review 3908a rev 11312, especially the changes for standalone combos. Stanislav Lomany

05/01/2019

05:37 PM Feature #3908: implement browse column VIEW-AS COMBO-BOX

Rebased task branch 3908a from P2J trunk revision 11306. Stanislav Lomany

01:25 PM Support #4062: getChanges() performance improvements

From Eric (see #3992-162):
> In @LT.getChanges()@, we iterate the entire @frameRegistry@ map on each call, which i... Greg Shah

01:24 PM Support #4062 (New): getChanges() performance improvements

Greg Shah

11:25 AM Support #4059: UI performance improvements (master task)

This task is a master index of planned/proposed UI performance work:
* #4912 move UI portions of the web client to... Greg Shah

11:18 AM Support #4059 (New): UI performance improvements (master task)

Greg Shah

11:13 AM Feature #3684 (Closed): implement a web theme inspired by material design

Greg Shah

10:17 AM Bug #2921 (Closed): fix vertical placement of FILL-IN (editable or not)/LABEL/EDITOR text

Branch 3811a was merged to trunk as revision 11303. Greg Shah