Project

General

Profile

Activity

From 06/26/2025 to 07/25/2025

07/24/2025

09:48 AM Bug #9918: tilde doesn't duplicate semicolon in alternative codings
Tests that cover this:
* alternative_coding_quirk_01
* alternative_coding_quirk_01_analyze
* alternative_coding_qu...
Stefan Vieru
09:48 AM Bug #6308: post string literal alternative coding quirk in 4GL preprocessor
Tests that cover this:
* alternative_coding_quirk_01
* alternative_coding_quirk_01_analyze
* alternative_coding_qu...
Stefan Vieru
09:47 AM Bug #9886: Double slashes should produce a new line during preprocessing
Testcases that cover this:
* comments
And the other tests have this checking for @SLASH_SLASH@ creating a NL, but...
Stefan Vieru
09:46 AM Bug #9903: alternative codings with ' (quote) don't convert to ` (backtick)
Testcases that cover this:
* alternative_coding_quirk_04
Stefan Vieru
09:45 AM Bug #10099: Tilde consumes the octals/follow-up characters, when in OE this doesn't happen
Testcases that cover this:
* alternative_coding_quirk_06
Stefan Vieru

07/22/2025

09:09 AM Bug #9917: Fileset not ignoring case
Greg Shah wrote:
> I wonder if Octavian's work in #3211 is related?
I'll discuss with Octavian. My changes make t...
Dănuț Filimon
07:48 AM Bug #9917: Fileset not ignoring case
I wonder if Octavian's work in #3211 is related? Greg Shah
02:44 AM Bug #9917: Fileset not ignoring case
The problem appears during the @Generate Java Source Data Model Objects (DMOs)@ phase. The differences are like this ... Dănuț Filimon
02:17 AM Bug #9917 (WIP): Fileset not ignoring case
There's definitely an issue with the 9917a changes, I got the sources/logs for the 9917a and trunk conversions. The p... Dănuț Filimon

07/18/2025

06:06 AM Bug #9917: Fileset not ignoring case
Dănuț Filimon wrote:
> The customer application converted, but the build failed. Some temp-table dmos were missing a...
Dănuț Filimon

07/17/2025

03:19 AM Bug #9917: Fileset not ignoring case
--- deleted, the comment was for another issue Dănuț Filimon
02:28 AM Bug #9917: Fileset not ignoring case
The customer application converted, but the build failed. Some temp-table dmos were missing and might be caused by so... Dănuț Filimon

07/16/2025

05:58 AM Bug #10235 (Test): Wrong variable used on CATCH block
Branch 10235a was merged to trunk revision 16049 and archived. Teodor Gorghe
05:46 AM Bug #10235 (Merge Pending): Wrong variable used on CATCH block
Please merge 10235a now. Constantin Asofiei
03:12 AM Bug #9917: Fileset not ignoring case
There's a single customer application left to test to get 9917a into the merge queue and tomorrow I expect to get the... Dănuț Filimon

07/15/2025

07:43 AM Bug #10099: Tilde consumes the octals/follow-up characters, when in OE this doesn't happen
The above is only a bit, there's more at the end where we use @nextCharTemp@. Stefan Vieru
07:42 AM Bug #10099: Tilde consumes the octals/follow-up characters, when in OE this doesn't happen
r16040... Stefan Vieru
07:41 AM Bug #10099: Tilde consumes the octals/follow-up characters, when in OE this doesn't happen
What revision of 6859b has the fix? Greg Shah
07:16 AM Bug #10099 (Review): Tilde consumes the octals/follow-up characters, when in OE this doesn't happen
Fixed in @6859b@ #6859.
To have @\@ escaped, the @Preprocessor@ should be run with @-windowsescapes@.
Stefan Vieru

07/10/2025

11:20 AM Feature #3881: output actual file and line/column for all outputs in conversion/analytics
Florin Eugen Rotaru wrote:
> I have implemented a first working method which computes the original line/column (curr...
Florin Eugen Rotaru
08:08 AM Feature #6256: improved profile support
> I think we should modify the profile to do one of the following:
> # Make the namespaces global and remove the pro...
Greg Shah
02:14 AM Feature #6256: improved profile support
Greg Shah wrote:
> > I got a message from Razvan that he converted the ChUI project, but the "convert" command was s...
Dănuț Filimon

07/09/2025

11:25 AM Feature #6256: improved profile support
> I got a message from Razvan that he converted the ChUI project, but the "convert" command was skipped. This is beca... Greg Shah
07:16 AM Feature #6256: improved profile support
Greg Shah wrote:
> > and there are different ways to get the file-set?
>
> What do you mean?
ChUI project uses...
Dănuț Filimon
06:21 AM Feature #6256: improved profile support
> and there are different ways to get the file-set?
What do you mean?
Greg Shah
03:21 AM Feature #6256: improved profile support
I got a message from Razvan that he converted the ChUI project, but the "convert" command was skipped. This is becaus... Dănuț Filimon
10:57 AM Feature #3881: output actual file and line/column for all outputs in conversion/analytics
I have implemented a first working method which computes the original line/column (currently taking into consideratio... Florin Eugen Rotaru

07/08/2025

09:44 AM Feature #10190: Prototype the changes to the build to add ANTLR v4
Florin Eugen Rotaru wrote:
> Building with Java 1.8 fails because the currently ANTLR4 version needs at least Java 1...
Greg Shah
08:59 AM Feature #10190: Prototype the changes to the build to add ANTLR v4
I have committed the needed change to *10190a/16002* Florin Eugen Rotaru
08:56 AM Feature #10190: Prototype the changes to the build to add ANTLR v4
Building with Java 1.8 fails because the currently ANTLR4 version needs at least Java 11.
To ensure compatibility ...
Florin Eugen Rotaru

07/07/2025

04:51 PM Feature #10265: schema-only conversion
As of trunk rev 16028, one cannot convert schemata without including at least one program. In #9455-25, this techniq... Greg Shah
04:41 PM Feature #10265 (Closed): schema-only conversion
Greg Shah
10:21 AM Feature #3881: output actual file and line/column for all outputs in conversion/analytics
I continued extending the @pphints@ format by adding a child tag for @includes@ and @references@. Basically, the pare... Florin Eugen Rotaru
07:48 AM Bug #9886 (Review): Double slashes should produce a new line during preprocessing
I updated this so I will need an review on @6859b@ regarding my changes:
I've added ...
Stefan Vieru
06:57 AM Bug #9886: Double slashes should produce a new line during preprocessing
All changes have been moved to @6859b@. Stefan Vieru
07:43 AM Bug #9903 (Review): alternative codings with ' (quote) don't convert to ` (backtick)
This has been solved in @6859b@ Stefan Vieru
07:42 AM Bug #9903 (WIP): alternative codings with ' (quote) don't convert to ` (backtick)
Stefan Vieru
07:20 AM Bug #6308 (Review): post string literal alternative coding quirk in 4GL preprocessor
Stefan Vieru
04:43 AM Bug #6308: post string literal alternative coding quirk in 4GL preprocessor
All changes have been moved to @6859b@. Stefan Vieru
06:58 AM Bug #9905: EOF file is not matched during preprocessing
All changes have been moved to @6859b@. Stefan Vieru
06:56 AM Bug #9918: tilde doesn't duplicate semicolon in alternative codings
All changes have been moved to @6859b@. Stefan Vieru
06:44 AM Bug #10208: do not convert the schema in incremental mode if it hasn't changed
I committed *10208a/16007*. Added IncrementalCvtRunMode and used to skip most of the phases that involve the database... Dănuț Filimon

07/04/2025

10:42 AM Feature #3881: output actual file and line/column for all outputs in conversion/analytics
Florin Eugen Rotaru wrote:
> The next steps should be I think storing the multi-line @scoped@ and @global@ defines...
Florin Eugen Rotaru
02:20 AM Bug #10208: do not convert the schema in incremental mode if it hasn't changed
In our weekly meeting, I mentioned that I would not modify how the M0, M1, F2 and F3 modes are used. I decided to tak... Dănuț Filimon

07/03/2025

10:32 AM Feature #3881: output actual file and line/column for all outputs in conversion/analytics
I added some logic to implement the idea above, so the @symbols@ are described with more details in @pphints@ file, f... Florin Eugen Rotaru
09:52 AM Bug #6308: post string literal alternative coding quirk in 4GL preprocessor
Decided on the following change:... Stefan Vieru

07/02/2025

01:04 PM Feature #6256 (Internal Test): improved profile support
OK, it looks good. Greg Shah
08:56 AM Feature #6256: improved profile support
Greg Shah wrote:
> My only question is why would the metadata schema be bypassed in profile mode. I understand it w...
Dănuț Filimon
08:49 AM Feature #6256: improved profile support
Code Review Task Branch 6256a Revision 16022
My only question is why would the metadata schema be bypassed in prof...
Greg Shah
06:41 AM Feature #6256 (Review): improved profile support
Committed *6256a/15946* for review, the branch contains:
* The NPE fix for the issue mentioned in #6256-97 - reintro...
Dănuț Filimon
11:08 AM Feature #3881 (WIP): output actual file and line/column for all outputs in conversion/analytics
When we have several @&SCOPED-DEFINE@ directives, the @cache@ file seems to not have any knowledge of the original li... Florin Eugen Rotaru
09:14 AM Bug #10235 (Internal Test): Wrong variable used on CATCH block
Thanks, we need to conversion-test this. Constantin Asofiei
08:18 AM Bug #10235: Wrong variable used on CATCH block
Committed revision *16015* on task branch *10235a*:
- moved the condition into @common-progress.rules@
Committed ...
Teodor Gorghe
07:44 AM Bug #10235: Wrong variable used on CATCH block
Please move this code into a function in @common-progress.rules@... Constantin Asofiei
07:38 AM Bug #10235 (Review): Wrong variable used on CATCH block
Created task branch *10235a*.
Committed revision *16014* on task branch *10235a*:
- CATCH variable scoping fixups f...
Teodor Gorghe
05:56 AM Bug #10235: Wrong variable used on CATCH block
Constantin Asofiei wrote:
> Change it like this:
> [...]
This passes on FWD and 4GL. It is used the same -variab...
Teodor Gorghe
05:52 AM Bug #10235: Wrong variable used on CATCH block
Change it like this:... Constantin Asofiei
05:51 AM Bug #10235: Wrong variable used on CATCH block
Constantin Asofiei wrote:
> Please check what @anotherError@ contains in the method. I think 4GL defines a single v...
Teodor Gorghe
05:22 AM Bug #10235: Wrong variable used on CATCH block
Please check what @anotherError@ contains in the method. I think 4GL defines a single var per top-level block, not m... Constantin Asofiei
05:19 AM Bug #10235 (WIP): Wrong variable used on CATCH block
When using a @DO ON CATCH@ block on a method, this issue does *not* occur.
* {{Collapse(ABL code)...
Teodor Gorghe
04:26 AM Bug #10099 (WIP): Tilde consumes the octals/follow-up characters, when in OE this doesn't happen
Stefan Vieru
04:25 AM Bug #10215 (Test): ant rpt fails when running only conversion.front
Branch 10215a was merged into trunk as rev. 16017 and archived. Paul Bodale
04:07 AM Bug #10215 (Merge Pending): ant rpt fails when running only conversion.front
Please merge now. Constantin Asofiei
04:06 AM Bug #10215: ant rpt fails when running only conversion.front
Committed rev. 16015 on branch 10215a that addresses the feedback received. Paul Bodale
04:00 AM Bug #10215: ant rpt fails when running only conversion.front
Paul, please add history entry and update copyright year. Constantin Asofiei
02:05 AM Bug #10215: ant rpt fails when running only conversion.front
Greg Shah wrote:
> Is #6490-29 still fixed with the 10125a? If so, this seems pretty low risk to merge.
Yes, the...
Paul Bodale
02:40 AM Bug #10185 (Test): ADE conversion and runtime
Branch 10185a was merged to trunk rev 16016 and archived. Teodor Gorghe
02:16 AM Bug #10185 (Merge Pending): ADE conversion and runtime
Conversion testing passed. Please merge 10185a after 9550a. Constantin Asofiei

07/01/2025

06:00 PM Bug #10215 (Internal Test): ant rpt fails when running only conversion.front
Greg Shah
06:00 PM Bug #10215: ant rpt fails when running only conversion.front
Is #6490-29 still fixed with the 10125a? If so, this seems pretty low risk to merge. Greg Shah
10:09 AM Bug #10215: ant rpt fails when running only conversion.front
Tested @ant rpt@ with and without #5586 on top of 10215a on hotel_gui and both passed.
Also looked through analytics...
Stefan Vieru
08:37 AM Bug #10215: ant rpt fails when running only conversion.front
Committed rev. 16014 on branch 10125a that introduces the fix made by Constantin above:... Paul Bodale
07:35 AM Bug #10215: ant rpt fails when running only conversion.front
Paul, previously @is_extent_lvalue_ref@ was not matching on fields (the @descedent(prog.lbracket, 1)@ was wrong, firs... Constantin Asofiei
05:56 PM Feature #10190 (Internal Test): Prototype the changes to the build to add ANTLR v4
Greg Shah
05:56 PM Feature #10190: Prototype the changes to the build to add ANTLR v4
Code Review Task Branch 10190a Revision 16001
The changes are good.
Greg Shah
11:10 AM Feature #10190 (Review): Prototype the changes to the build to add ANTLR v4
Greg Shah wrote:
> Code Review Task Branch 10190a Revisions 15999 and 16000
>
> The @registerGrammarTask()@ isn't...
Florin Eugen Rotaru
08:57 AM Feature #10190 (WIP): Prototype the changes to the build to add ANTLR v4
Code Review Task Branch 10190a Revisions 15999 and 16000
The @registerGrammarTask()@ isn't quite right. Not all g...
Greg Shah
09:36 AM Bug #10237: keepTildes is keeping tilde when preprocessor directive contains tilde and curly brace
Having the following testcase:... Stefan Vieru
09:29 AM Bug #10237 (New): keepTildes is keeping tilde when preprocessor directive contains tilde and curl...
Stefan Vieru
09:12 AM Feature #7180 (WIP): create a centralized manager for the conversion list and per-file/project st...
I'll put this into WIP until 5586a (#5586) is merged, the purpose is to get 7180a rebased to latest trunk which conta... Dănuț Filimon
08:21 AM Feature #6256: improved profile support
Anything at the global level should be assumed to be present for all profiles. Anything in a profile should be *adde... Greg Shah
08:04 AM Feature #6256: improved profile support
The issue with the database is actually related to how the default profile in SchemaCOnfig is set, the root cause is ... Dănuț Filimon
06:05 AM Feature #6256: improved profile support
The global schema should be used by a profile only when none of the active profiles have a schema defined, this is th... Dănuț Filimon
02:43 AM Feature #6256 (WIP): improved profile support
Dănuț Filimon
02:43 AM Feature #6256: improved profile support
Dănuț Filimon wrote:
> Greg Shah wrote:
> > If a profile contains any schema at all, then the top-level namespaces ...
Dănuț Filimon
05:22 AM Bug #10235: Wrong variable used on CATCH block
There is a issue when there are multiple @CATCH@ blocks. On FWD, the variable reference for the first block is from t... Teodor Gorghe
05:14 AM Bug #10235 (Test): Wrong variable used on CATCH block
Teodor Gorghe

06/30/2025

03:15 PM Support #10231: Document the code style guidelines for ANTLR grammars, based on progress.g
The core rules have these forms:... Greg Shah
10:08 AM Support #10231: Document the code style guidelines for ANTLR grammars, based on progress.g
The wiki is the [[p2j:ANTLR Grammar Coding Standards]]. Florin Eugen Rotaru
10:07 AM Support #10231 (WIP): Document the code style guidelines for ANTLR grammars, based on progress.g
Florin Eugen Rotaru
10:26 AM Bug #10215: ant rpt fails when running only conversion.front
Why not just put some protection code in @describe_extent_lvalue@? Better yet, make sure that @describe_extent_lvalu... Greg Shah
03:28 AM Bug #10215 (Review): ant rpt fails when running only conversion.front
The problem comes from one modified function located in @rules/include/common-progress.rules@, precisely the *is_exte... Paul Bodale
03:26 AM Bug #10215 (WIP): ant rpt fails when running only conversion.front
Paul Bodale
09:12 AM Bug #10208: do not convert the schema in incremental mode if it hasn't changed
Dănuț Filimon wrote:
> Greg, the skipDBSchema is quite old. I suggest removing it and using the @schema@ flag to do ...
Greg Shah
07:29 AM Bug #10208: do not convert the schema in incremental mode if it hasn't changed
Greg, the skipDBSchema is quite old. I suggest removing it and using the @schema@ flag to do the job. Dănuț Filimon
06:24 AM Bug #10208: do not convert the schema in incremental mode if it hasn't changed
#10208-13 can be achieved by correctly setting CvtRunMode.skipDBSchema, I made it protected and did the following for... Dănuț Filimon
05:34 AM Bug #10208: do not convert the schema in incremental mode if it hasn't changed
I created *10208a* from *trunk/16005* and committed an initial version in *10208a/16006*. The changes are for #10208-9. Dănuț Filimon
03:54 AM Bug #10208: do not convert the schema in incremental mode if it hasn't changed
I've made a few changes as mentioned in #10208-9, but I am wondering if there are any other conversion steps I should... Dănuț Filimon
09:09 AM Feature #10190: Prototype the changes to the build to add ANTLR v4
OK, I made the two changes and committed to *10190a/16000*. Florin Eugen Rotaru
07:47 AM Feature #10190: Prototype the changes to the build to add ANTLR v4
Florin Eugen Rotaru wrote:
> Greg Shah wrote:
> > Code Review Task Branch 10190a Revisions 15996 through 15998
> >...
Greg Shah
03:17 AM Feature #10190: Prototype the changes to the build to add ANTLR v4
Greg Shah wrote:
> Code Review Task Branch 10190a Revisions 15996 through 15998
>
> The overall approach looks go...
Florin Eugen Rotaru
02:14 AM Feature #6256: improved profile support
Greg Shah wrote:
> If a profile contains any schema at all, then the top-level namespaces are ignored. I think that...
Dănuț Filimon

06/27/2025

01:32 PM Feature #6256: improved profile support
Code Review Task Branch 6256a Revisions 15944 and 15945
If a profile contains any schema at all, then the top-leve...
Greg Shah
12:29 PM Feature #10190: Prototype the changes to the build to add ANTLR v4
Code Review Task Branch 10190a Revisions 15996 through 15998
The overall approach looks good.
1. We will have s...
Greg Shah
10:04 AM Feature #10190 (Review): Prototype the changes to the build to add ANTLR v4
I have committed the changes to *10190/15998*. I added the @antlr4All@ registered in @gradle@ into the @ant-antrl@ ta... Florin Eugen Rotaru
09:56 AM Bug #10208: do not convert the schema in incremental mode if it hasn't changed
Greg Shah wrote:
> Constantin: Do we already detect that UAST @.hints@ file changes are a cause to reconvert the ass...
Constantin Asofiei
09:47 AM Bug #10208: do not convert the schema in incremental mode if it hasn't changed
The approach seems correct to me.
> I am not sure if there are any hint files for schema?
Yes, there are schema...
Greg Shah
09:12 AM Bug #10208 (WIP): do not convert the schema in incremental mode if it hasn't changed
Dănuț Filimon
09:12 AM Bug #10208: do not convert the schema in incremental mode if it hasn't changed
My current implementation works like this:
# @SchemaLoader.importSchema()@ should call @ConversionData.saveFileHash(...
Dănuț Filimon
03:29 AM Bug #10208: do not convert the schema in incremental mode if it hasn't changed
Greg Shah wrote:
> I don't object, but can we just add the schemata to the FILE_SIGNATURE table?
Yes, I will do t...
Dănuț Filimon
09:37 AM Feature #3971: add support for unicode escape sequences in the preprocessor
Octavian, is #8027 fixing already this task? Alexandru Lungu
05:56 AM Bug #10185: ADE conversion and runtime
Committed revision *15998* on task branch *10185a*:
- history entry fix on NameConverter.java, java_templates.tpl, B...
Teodor Gorghe

06/26/2025

11:40 AM Feature #10190: Prototype the changes to the build to add ANTLR v4
> Instead of using the bundled AntlrTask from gradle(which was introducing the dependency conflict), we can manually ... Greg Shah
10:51 AM Feature #10190: Prototype the changes to the build to add ANTLR v4
Florin Eugen Rotaru wrote:
> * Added logic to exclude @org.ow2.asm@ dependency when running antlr4All.
>
> * Im...
Florin Eugen Rotaru
10:09 AM Bug #10208: do not convert the schema in incremental mode if it hasn't changed
I don't object, but can we just add the schemata to the FILE_SIGNATURE table? Greg Shah
09:06 AM Bug #10208: do not convert the schema in incremental mode if it hasn't changed
As far as I can tell, there doesn't seem to be any information (e.g. hash) for the schema file in the cvtdb database.... Dănuț Filimon
07:23 AM Bug #10215: ant rpt fails when running only conversion.front
While testing @rpt@ I've found the following behavior: (clean hotel and clean trunk r16001)
* @ant rpt@ fails
* @an...
Stefan Vieru
07:22 AM Bug #10215: ant rpt fails when running only conversion.front
Regression when running @ant rpt@:
Tested with trunk 15918, no issues here.
With trunk 15960 and onward the followi...
Stefan Vieru
07:21 AM Bug #10215 (Test): ant rpt fails when running only conversion.front
Stefan Vieru
02:12 AM Bug #10185: ADE conversion and runtime
Committed revision *15997* on task branch *10185a*:
- Fixed compilation issues of @BROWSE:NO-EMPTY-SPACE@. The inter...
Teodor Gorghe
 

Also available in: Atom