Project

General

Profile

Activity

From 07/16/2012 to 08/14/2012

08/14/2012

12:01 PM Bug #1443: output and input-output parameters with functions
Here is the implementation. I could not fully replace the @isTopLevel@ with the new function, as @toplvl@ scope was u... Ovidiu Maxiniuc

08/13/2012

09:58 AM Bug #1461 (WIP): selection list initialization error
Stanislav Lomany

08/01/2012

03:48 AM Bug #1462 (Review): hidden persistence error on server startup
During server startup, DirtyTempTableHelper.getIndexes will hide any persistence errors, as the terminal is not confi... Constantin Asofiei
03:48 AM Bug #1462 (Closed): hidden persistence error on server startup
Constantin Asofiei

07/31/2012

03:12 PM Bug #1455: P2J server virtual session deadlock
The staging has passed regression testing (both standard and CTRL-C sets). Constantin Asofiei
11:58 AM Bug #1461: selection list initialization error
At this point SELECTION-LIST does not work at all. It fails to initialize. Affects MAJIC. Example of stacktrace:
C...
Stanislav Lomany
11:57 AM Bug #1461 (Closed): selection list initialization error
Stanislav Lomany

07/30/2012

10:23 AM Bug #1455 (Test): P2J server virtual session deadlock
I approve the latest proposed code changes. Please apply the changes to lightning staging and run regression testing... Greg Shah
08:13 AM Bug #1455: P2J server virtual session deadlock
OK, I understand about the inability to synchronize that method. Please place comments there describing the problem.... Greg Shah
06:15 AM Bug #1455: P2J server virtual session deadlock
For #2 - we can't make the method synchronized, for the same reason why SecurityManager.endContext can't sync on the ... Constantin Asofiei

07/27/2012

11:48 AM Bug #1455: P2J server virtual session deadlock
1. Please update the SecurityManager.endContext() code with an explanation of the deadlock (including your example) w... Greg Shah
11:28 AM Bug #1455: P2J server virtual session deadlock
Greg, good notes.
> Question: the simpler approach seems to be synchronizing on the SecurityContext instance itsel...
Constantin Asofiei
10:33 AM Bug #1455 (WIP): P2J server virtual session deadlock
I have 1 question and 1 concern:
Question: the simpler approach seems to be synchronizing on the SecurityContext i...
Greg Shah
08:37 AM Bug #1455 (Review): P2J server virtual session deadlock
Constantin Asofiei
08:33 AM Bug #1455: P2J server virtual session deadlock
The following files in com.goldencode.p2j.security have been changed for this issue:
# SecurityManager.endContext ...
Constantin Asofiei
11:00 AM Bug #1450: comment conversion fail
I believe my described solution takes this issue into account. The parmCounter would never be incremented for commen... Greg Shah
10:27 AM Bug #1450: comment conversion fail
That was my first approach to fix this bug. However, I discovered that (see note 16) the code can have mode than one ... Ovidiu Maxiniuc
10:58 AM Bug #1443: output and input-output parameters with functions
Good. You have found the root cause.
The first solution will not work in all cases. The reason the stack managem...
Greg Shah
10:01 AM Bug #1443: output and input-output parameters with functions
There is a small problem there. The ast looks something like:... Ovidiu Maxiniuc

07/26/2012

06:03 PM Bug #1450: comment conversion fail
I have reviewed the proposed solution. I believe all the looping code is unnecessary. You are making things more di... Greg Shah
06:21 AM Bug #1450: comment conversion fail
To fix the issue, add the following in @convert/brew.xml@,
line 117:...
Ovidiu Maxiniuc
04:16 PM Bug #1443: output and input-output parameters with functions
OK, I think you are getting close. But I am not sure you have gotten the root cause identified yet. Consider this:
...
Greg Shah
11:12 AM Bug #1443: output and input-output parameters with functions
After investigations I localized the issue when converting @.p.ast@ to @.jast@ (this is where the variables start lea... Ovidiu Maxiniuc
04:01 PM Bug #1455 (WIP): P2J server virtual session deadlock
... Greg Shah
10:44 AM Bug #1455: P2J server virtual session deadlock
Looking at the ConcurrentModificationException above, at the deadlock in the attached thread dump and at the deadlock... Constantin Asofiei
02:29 PM Bug #1452 (Closed): virtual session dealock
Replaced by #1455. Eric Faulhaber
10:22 AM Bug #1452 (Feedback): virtual session dealock
Needs to be closed, #1455 duplicates it and provides more details. Constantin Asofiei

07/25/2012

05:26 PM Bug #1455: P2J server virtual session deadlock
Thanks for the instructions; I have been able to recreate the lockup using your scenario. But, I'm pretty sure an a... Eric Faulhaber
05:18 PM Bug #1455: P2J server virtual session deadlock
h1. Further Email Discussion
Eric,
I've managed to duplicate your error ... while in the "SPECIAL QA SCREEN" sc...
Eric Faulhaber
05:06 PM Bug #1455: P2J server virtual session deadlock
h1. Email Discussion from 2012-07-03
Eric,
The Reader/Writer threads for the remote database connection don't have ...
Eric Faulhaber
05:03 PM Bug #1455 (Closed): P2J server virtual session deadlock
P2J server cannot create new virtual session due to a deadlock within RouterSessionManager. Eric Faulhaber
12:20 PM Bug #1450: comment conversion fail
Please post the snippets of code (inline in the history) that you wrote for the solution. Greg Shah
11:49 AM Bug #1450: comment conversion fail
Back with your answers of #note-15:
@a /*zero*/ = 0.@...
Ovidiu Maxiniuc
11:43 AM Bug #1450: comment conversion fail
After further testing I realized that double star-comment weren't handled correctly, ie. code like:... Ovidiu Maxiniuc
08:47 AM Bug #1450: comment conversion fail
Good. Please add the relevant snippets of the .jast file to the history. I need to review those to understand how s... Greg Shah
06:28 AM Bug #1450: comment conversion fail
1. Here is the ast for 1st issue:... Ovidiu Maxiniuc
06:40 AM Bug #1449: ProtocolViolation error
I've attached the converted sources which generated the error. The run scenario is (note that the server and clients... Constantin Asofiei

07/24/2012

05:19 PM Bug #1443 (WIP): output and input-output parameters with functions
Greg Shah
05:18 PM Bug #1449: ProtocolViolation error
Can you attach a more specific recreate (the specific programs you used and instructions for running the test)? Greg Shah
10:11 AM Bug #1454: progress lexer fails to parse comments without space before
Can you narrow down the part of the SYMBOL rule that is the problem? If so, please provide a snippet in PRE tags her... Greg Shah
09:33 AM Bug #1454: progress lexer fails to parse comments without space before
After investigating the @src/com/goldencode/p2j/uast/progress.g@ source I realized that when defining SYMBOL (line 28... Ovidiu Maxiniuc
09:09 AM Bug #1450: comment conversion fail
In order to evaluate the correctness of your solution, please do the following:
1. For each failing case above, pl...
Greg Shah

07/23/2012

11:23 AM Bug #1450: comment conversion fail
I managed to convert simple test codes into java, both above cases.
I encountered difficulties when adding extra r...
Ovidiu Maxiniuc

07/20/2012

12:00 PM Bug #1450: comment conversion fail
Even though I though this is more complicated (even related to included files), the cases in which this bug occurs ar... Ovidiu Maxiniuc
11:28 AM Bug #1454: progress lexer fails to parse comments without space before
Note from GES:
Progress 4GL lexing and parsing is quite complex. Their design included many ambiguities and conflict...
Ovidiu Maxiniuc
11:26 AM Bug #1454: progress lexer fails to parse comments without space before
antlr fails to parse correctly progress code if the inline comment is not separated by a space. ... Ovidiu Maxiniuc
11:17 AM Bug #1454 (New): progress lexer fails to parse comments without space before
Ovidiu Maxiniuc

07/19/2012

11:21 AM Bug #1450: comment conversion fail
Please post the simplified 4GL source that you are working with. You can just put the code into the history entry us... Greg Shah
11:19 AM Bug #1450: comment conversion fail
This is in regard to your history entry #5 above, looking for ideas on debugging TRPL.
1. A quick and dirty way to g...
Greg Shah
10:50 AM Bug #1450: comment conversion fail
This is in regard to history record #4 above about the extra @DOT@ added to the end of a file.
The additional @DOT@ ...
Greg Shah
10:47 AM Bug #1450: comment conversion fail
This is in regard to the problem:
@b = "a" + b./* comment failure without whitespace */@
Progress 4GL lexing an...
Greg Shah
10:41 AM Bug #1450: comment conversion fail
At this time I believe that the bug is somewhere at the later steps, at "convert/brew" iteration. Ovidiu Maxiniuc
10:37 AM Bug #1450: comment conversion fail
Can you give me some ideas about how can I analyze/debug dynamic loaded classes from rules ?
At the moment I do it m...
Ovidiu Maxiniuc
10:24 AM Bug #1450: comment conversion fail
If a comment is written on the last line of @.p@ file (I am not sure if this is the cause, must double-check) the ant... Ovidiu Maxiniuc
10:21 AM Bug #1450: comment conversion fail
I observed that (sometimes) the antlr fails to parse correctly progress code if the inline comment is not separated b... Ovidiu Maxiniuc
 

Also available in: Atom