FWD » Core Development

09/21/2013

12:02 PM Database Feature #2141: generate SQL Server schema

Does this come into play anywhere other than in generate_ddl.xml? The @if exists@ prefix is a nice safety feature, bu... Eric Faulhaber

09/20/2013

07:59 PM Database Bug #2164: Server fails to start a Progress app when persistence disabled

The changes passed regression test, see shared\clients\timco\majic_test_results\10382_9c2ae9a_20130920_hc.zip.
Fixed... Hynek Cihlar

05:12 PM Base Language Feature #1631: implement support for LANDSCAPE/PORTRAIT in I/O statements

Code Review 0918b
1. The name of this update should have been vig_upd20130920a.zip since you completed your change... Greg Shah

04:21 PM Base Language Feature #1631: implement support for LANDSCAPE/PORTRAIT in I/O statements

I'm uploading next update. I made described corrections.
About slashes, it seems that Progress removes it itself. I ... Vadim Gindin

04:04 PM Database Feature #2141: generate SQL Server schema

Another problem I have found out that for MS SQL Server both supportsIfExistsBeforeTableName() and supportsIfExistsAf... Vadim Nebogatov

03:57 PM Database Feature #2141: generate SQL Server schema

Yes, I also already understood that it does not depend on dialect. Vadim Nebogatov

03:54 PM Database Feature #2141: generate SQL Server schema

Vadim Nebogatov wrote:
> 11. Table creation
>
> Maximum MS SQL Server NUMERIC column precision is 38.
The more y... Eric Faulhaber

04:19 AM Database Feature #2141: generate SQL Server schema

I have added item 11 about table creation to note 11. Vadim Nebogatov

03:07 PM Database Feature #2137 (New): runtime support for FIELDS/EXCEPT record phrase options

This feature is an optimization, but is not necessary for the runtime to function properly. Moving target version acc... Eric Faulhaber

03:03 PM Database Feature #1580 (Closed): upgrade Hibernate to latest level

Eric Faulhaber

07:13 AM Database Feature #1580: upgrade Hibernate to latest level

I've uploaded original Hibernate sources to @shared/projects/p2j/hibernate/hibernate-4.1.8.Final-original.zip@ and th... Stanislav Lomany

01:22 PM Base Language Feature #1621 (Closed): implement dynamic/unspecified EXTENT support

Greg Shah

01:02 PM Base Language Feature #1621: implement dynamic/unspecified EXTENT support

Yes, it can be closed. Constantin Asofiei

09:50 AM Base Language Feature #1621: implement dynamic/unspecified EXTENT support

This can be closed, right? Greg Shah

09:53 AM Base Language Feature #1640: implement DOM XML support

Evgeny: please merge your code with latest revision 10385. This is the version that needs final review and full regr... Greg Shah

08:53 AM Base Language Feature #1640: implement DOM XML support

> The changes are good. The changes are probably safe enough to avoid separate regression testing. What do you thin... Constantin Asofiei

08:22 AM Base Language Feature #1640: implement DOM XML support

Code Review ca_upd20130920b.zip
The changes are good. The changes are probably safe enough to avoid separate regr... Greg Shah

05:14 AM Base Language Feature #1640: implement DOM XML support

This update solves the ErrorManager.recordOrShowError, when the "isError" flag is false and the NO-ERROR clause is pr... Constantin Asofiei

09:18 AM Base Language Feature #1792 (Closed): implement widget-pool support

Greg Shah

09:16 AM Base Language Feature #1792: implement widget-pool support

ca_upd20130920c.zip was committed to bzr revision 10385.
Final Notes:
1. A bug was fixed for CREATE BUFFER ... IN... Constantin Asofiei

08:53 AM Base Language Feature #1792: implement widget-pool support

The changes are really good. The class javadoc improvements are excellent!
> The exception is thrown because this... Greg Shah

04:32 AM Base Language Feature #1792: implement widget-pool support

> 1. Why throw IllegalStateException in WidgetPool.addResource()?
The exception is thrown because this method must a... Constantin Asofiei

09:17 AM Base Language Feature #1983 (Closed): runtime support for widget pools

Greg Shah

04:33 AM Base Language Feature #1983 (Review): runtime support for widget pools

Constantin Asofiei

09/19/2013

02:55 PM Base Language Feature #1792: implement widget-pool support

Code Review 0919a
Overall, it looks very good.
1. Why throw IllegalStateException in WidgetPool.addResource()?
... Greg Shah

12:53 PM Base Language Feature #1792: implement widget-pool support

The attached update adds runtime support for widget pools. Still need to perform regression testing on it. Constantin Asofiei

01:48 PM Database Feature #2116: add runtime support for _user metadata table

Ovidiu Maxiniuc wrote:
> I altered the conversion so that the _user AST is copied from meta to each processed databa... Eric Faulhaber

01:37 PM Database Feature #2116: add runtime support for _user metadata table

I altered the conversion so that the _user AST is copied from meta to each processed database if configured in p2j.cf... Ovidiu Maxiniuc

01:37 PM Database Feature #2175 (Closed): add support for -rereadnolock startup parameter

Eric Faulhaber

03:56 AM Database Feature #2175: add support for -rereadnolock startup parameter

The update "om_upd20130912e.zip":https://proj.goldencode.com/redmine/attachments/1285/om_upd20130912e.zip added in #1... Ovidiu Maxiniuc

01:36 PM Database Feature #1594 (Closed): add conversion and runtime support for CURRENT-CHANGED() built-in function

Eric Faulhaber

03:39 AM Database Feature #1594: add conversion and runtime support for CURRENT-CHANGED() built-in function

The update was committed to bzr as revision 10381 and distributed by email. Ovidiu Maxiniuc

09:34 AM Base Language Feature #2074: add CAN-QUERY() and CAN-SET() support

The changes look good. When you get back, you can merge up with the latest code, implement the DOM/SAX attributes/me... Greg Shah

08:00 PM Base Language Feature #2074: add CAN-QUERY() and CAN-SET() support

This update with new 6 getters in CommonSession class. The static classes SessionUtils, NumberType, ProcedureManager ... Eugenie Lyzenko

09:09 AM Base Language Feature #1638 (Closed): implement Java access to converted appserver code (must be a simple repla...

Greg Shah

07:53 AM Base Language Feature #1638: implement Java access to converted appserver code (must be a simple replacement fo...

At this time, no. Constantin Asofiei

02:03 AM Base Language Feature #1640: implement DOM XML support

Evgeny, please merge your @handle.java@ file, discard the @ErrorManager@ changes you made and put the update through ... Constantin Asofiei

09/18/2013

07:09 PM Base Language Feature #1781 (WIP): add missing support for the WIDGET-HANDLE builtin function

Hynek Cihlar

07:05 PM Base Language Feature #2074: add CAN-QUERY() and CAN-SET() support

OK, I think I understand now. If we have the backing implementations for the missing attributes, please do add the 6... Greg Shah

07:01 PM Base Language Feature #2074: add CAN-QUERY() and CAN-SET() support

> Are they defined in some other interface?
The following attributes are not defined at all:
FIRST-SERVER r
LAST... Eugenie Lyzenko

06:51 PM Base Language Feature #2074: add CAN-QUERY() and CAN-SET() support

Are they defined in some other interface? Greg Shah

06:50 PM Base Language Feature #2074: add CAN-QUERY() and CAN-SET() support

> I assume you still have these attributes annotated in their CommonSession interface?
No, there are no such attri... Eugenie Lyzenko

06:40 PM Base Language Feature #2074: add CAN-QUERY() and CAN-SET() support

I assume you still have these attributes annotated in their CommonSession interface? Greg Shah

06:35 PM Base Language Feature #2074: add CAN-QUERY() and CAN-SET() support

> These 3 classes are statically implementing the proxy defined by the CommonSession interface - so you are correct, ... Eugenie Lyzenko

04:24 PM Base Language Feature #2074: add CAN-QUERY() and CAN-SET() support

Eugenie Lyzenko wrote:
> > NumberType shouldn't have been annotated. The proper interface for the SESSION resource i... Constantin Asofiei

04:05 PM Base Language Feature #2074: add CAN-QUERY() and CAN-SET() support

> NumberType shouldn't have been annotated. The proper interface for the SESSION resource is the CommonSession interf... Eugenie Lyzenko

03:46 PM Base Language Feature #2074: add CAN-QUERY() and CAN-SET() support

> 1. Since NumberType isn't a WrappedResource, it won't ever be referenced via a handle. Instead, we use static meth... Constantin Asofiei

03:34 PM Base Language Feature #2074: add CAN-QUERY() and CAN-SET() support

> 2. You have some major merging to do with the recent sockets code.
Done.
> And there are massive changes to t... Eugenie Lyzenko

03:10 PM Base Language Feature #2074: add CAN-QUERY() and CAN-SET() support

Code Review 0917b
Generally it looks really good. Some feedback:
1. Since NumberType isn't a WrappedResource, ... Greg Shah

09:28 PM Base Language Feature #2074: add CAN-QUERY() and CAN-SET() support

Added missing ERROR related attributes and methods. It is found the setter for READ-ONLY attribute is not found. Eugenie Lyzenko

06:49 PM Base Language Feature #1640: implement DOM XML support

1) fixed issues in note 123 - 130
2) in @XmlFactory@ class methods @createXNodeReference@ now set new node into reso... Evgeny Kiselev

02:49 PM Base Language Feature #1640: implement DOM XML support

Can you get your update ready for review today? If not, when can it be ready? Greg Shah

05:46 PM Database Feature #2141: generate SQL Server schema

Vadim Nebogatov wrote:
> 10. getAlterComputedColumnString()
> ...
> MS SQL Server ALTER TABLE does not allow alter... Eric Faulhaber

05:18 PM Database Feature #2141: generate SQL Server schema

Items 9, 10 about rtrim and getAlterComputedColumnString added to note 9. Vadim Nebogatov

01:40 PM Database Feature #2141: generate SQL Server schema

I have added item 8 about collation to note 9. Vadim Nebogatov

05:35 PM Database Feature #2116: add runtime support for _user metadata table

Ovidiu Maxiniuc wrote:
> ...the @_User@ table has changed; the .d /.df pair I extracted today have a different numbe... Eric Faulhaber

05:16 PM Database Feature #2116: add runtime support for _user metadata table

Ovidiu Maxiniuc wrote:
> I also start adding import support for _User meta-table.
> I understand that this is a ta... Eric Faulhaber

02:07 PM Database Feature #2116: add runtime support for _user metadata table

Ovidiu Maxiniuc wrote:
> > * I am a bit confused by the use of the @Database@ class to hold the userid.
> Indeed, ... Eric Faulhaber

12:52 PM Database Feature #2116: add runtime support for _user metadata table

I also start adding import support for _User meta-table.
I understand that this is a table like others from the dat... Ovidiu Maxiniuc

12:35 PM Database Feature #2116: add runtime support for _user metadata table

> * I am a bit confused by the use of the @Database@ class to hold the userid.
Indeed, I was a little confused abou... Ovidiu Maxiniuc

12:14 PM Base Language Feature #1631: implement support for LANDSCAPE/PORTRAIT in I/O statements

Code Review 0918a
This is pretty good work. Some changes to make:
1. The name of the update should be vig_upd2... Greg Shah

09:43 AM Base Language Bug #2183: fix resource save/restoration when used with string/handle functions

Work this along with the work in #1781. They are closely related. Greg Shah

09:30 AM Base Language Feature #1608 (Closed): implement full appserver support (from 4GL clients only)

Greg Shah

09:30 AM Base Language Feature #1991 (Closed): runtime support for appserver

Greg Shah

09:29 AM Base Language Feature #2184 (Closed): create and populate the temp-table on the remote side, based on the recei...

Greg Shah

08:49 AM Base Language Feature #1606 (Closed): implement persistent procedures/super procedures

Greg Shah

08:46 AM Base Language Feature #1884 (Closed): add some of the v10 data types and core built-ins

Greg Shah

08:38 AM Base Language Feature #1964 (Closed): finish runtime support for MEMPTR/RAW

Greg Shah

08:33 AM Base Language Feature #1638: implement Java access to converted appserver code (must be a simple replacement fo...

Is there anything left to do on this or can we close the task? Greg Shah

08:27 AM Base Language Feature #1958 (Closed): implement the runtime support for sockets

Greg Shah

08:26 AM Base Language Feature #2129 (Closed): final runtime work on sockets

Greg Shah

08:26 AM Base Language Feature #1639 (Closed): implement socket support

Greg Shah

03:10 AM Base Language Feature #1639: implement socket support

>I assume all the socket testcases (other than SSL) are working now?
yes.
This version was committed to rev 10382... Constantin Asofiei

09/17/2013

06:54 PM Base Language Feature #1631: implement support for LANDSCAPE/PORTRAIT in I/O statements

Here is an archive with my changes. Please review. What to do further? Vadim Gindin

12:21 PM Base Language Feature #1631: implement support for LANDSCAPE/PORTRAIT in I/O statements

> The rule uses a parentid variable as a parent node pointer(as other IO_OPTIONS do) and this var is correctly set as... Greg Shah

03:45 AM Base Language Feature #1631: implement support for LANDSCAPE/PORTRAIT in I/O statements

At this moment these statements can correctly be converted:
output to printer
output to printer printerName
outp... Vadim Gindin

04:11 PM Database Feature #2175 (WIP): add support for -rereadnolock startup parameter

Eric Faulhaber

04:09 PM Database Feature #2116: add runtime support for _user metadata table

Eliminating the Apache logging dependency:
1. Replace:... Eric Faulhaber

04:08 PM Database Feature #2116: add runtime support for _user metadata table

Code review 20130917a:
I realize this is only an intermediate update, but I had a quick look to get an idea of you... Eric Faulhaber

02:41 PM Database Feature #2116: add runtime support for _user metadata table

An intermediate version.
From my tests, @userid@ and @setuserid@ forms of the function without ldbname use indeed the... Ovidiu Maxiniuc

01:40 PM Base Language Feature #2074: add CAN-QUERY() and CAN-SET() support

This is the first candidate for implementation. While you are reviewing I'll check for possible missed annotations be... Eugenie Lyzenko

08:20 AM Base Language Feature #2074: add CAN-QUERY() and CAN-SET() support

>> Moving to the static calls(SessionUtils, ProcedureManager, etc.)
>
> For these too, you will need to annotate t... Eugenie Lyzenko

07:47 AM Base Language Feature #2074: add CAN-QUERY() and CAN-SET() support

Eugenie Lyzenko wrote:
> Moving to the static calls(SessionUtils, ProcedureManager, etc.)
For these too, you will ... Constantin Asofiei

08:54 PM Base Language Feature #2074: add CAN-QUERY() and CAN-SET() support

Moving to the static calls(SessionUtils, ProcedureManager, etc.) The new notes found for CommonWidget:
The attribute... Eugenie Lyzenko

12:53 PM Base Language Feature #1640: implement DOM XML support

Constantin's ErrorManager change will be checked in before your changes. So you don't have to include this file in y... Greg Shah

12:28 PM Base Language Feature #1640: implement DOM XML support

Evgeny, please use the attached ErrorManager class. You will need to call @recordOrShowError(code, msg, false, false,... Constantin Asofiei

10:29 AM Base Language Feature #1640: implement DOM XML support

> we need to add yet another parameter isError, to the ErrorManager.recordOrShowError, so that the pending flag will ... Greg Shah

07:30 AM Base Language Feature #1640: implement DOM XML support

About @HANDLE@ attribute: please add this code in @methods_attributes.rules@:... Constantin Asofiei

09:41 PM Base Language Feature #1640: implement DOM XML support

Constantin Asofiei wrote:
> > You are right. I'll try to look how I can manage it inside rules.
> Please provide th... Evgeny Kiselev

12:51 PM Base Language Feature #1639: implement socket support

I'm OK with the changes. I assume all the socket testcases (other than SSL) are working now?
If all the socket te... Greg Shah

12:25 PM Base Language Feature #1639: implement socket support

> Please increase this size to at least 4096.
I've set it to 4096 for now. I wonder if it should not be set to SO_RC... Constantin Asofiei

10:54 AM Base Language Feature #1639: implement socket support

> - for read, I chose an arbitrary chunk size of 512 bytes (although I think a larger size would work too).
Please... Greg Shah

06:56 AM Base Language Feature #1639: implement socket support

> 1. We should not be using Apache Commons logging. Eric's use of it was unsanctioned and should not be extended. We ... Constantin Asofiei

12:24 PM Base Language Bug #2183: fix resource save/restoration when used with string/handle functions

Notes from #1639:
[GES]
> 3. Is it safe to use the hash code for the ID to resource mapping in handle? It seems lik... Constantin Asofiei

12:22 PM Base Language Bug #2183 (Closed): fix resource save/restoration when used with string/handle functions

Constantin Asofiei

07:47 AM Base Language Feature #1983 (WIP): runtime support for widget pools

Constantin Asofiei

07:33 AM Base Language Bug #2182: HANDLE attribute doesn't convert properly in "h:handle:<attr/method>" cases

There is a problem in converting @h:handle:attribute@ or @h:handle:method()@ chain calls, as the inner @HANDLE@ attri... Constantin Asofiei

07:32 AM Base Language Bug #2182 (New): HANDLE attribute doesn't convert properly in "h:handle:<attr/method>" cases

Constantin Asofiei

09/16/2013

06:30 PM Base Language Feature #2074: add CAN-QUERY() and CAN-SET() support

> Greg, any idea why we have both KEEP-Z-ORDER and KEEP-FRAME-Z-ORDER? IMO, only KEEP-FRAME-Z-ORDER is correct, as th... Greg Shah

04:04 PM Base Language Feature #2074: add CAN-QUERY() and CAN-SET() support

> I see. The problem is we have the methods for both:
> KEEP-Z-ORDER:
> isKeepZOrder();
> setKeepZOrder(logical lo... Constantin Asofiei

02:28 PM Base Language Feature #2074: add CAN-QUERY() and CAN-SET() support

> > The attribute PERSISTENT has described in Progress docs as readable/writable. But in P2J conversion we have only ... Eugenie Lyzenko

06:26 PM Base Language Feature #1639: implement socket support

Code Review 0916c
General: very good work. The multithreaded read part is especially hard to get one's mind aroun... Greg Shah

04:12 PM Base Language Feature #1639: implement socket support

I'm regression testing this update now (conersion passed, runtime is in progress); please review. The only issue is a... Constantin Asofiei

04:41 PM Database Feature #2141: generate SQL Server schema

Please bear in mind that the scope of this task is to generate a SQL Server schema, not to implement all functionalit... Eric Faulhaber

04:34 PM Database Feature #2141: generate SQL Server schema

Sorry, I missed this earlier. Yes, we need to support both (and only those) versions (2008 and 2012). We do not need ... Eric Faulhaber

04:28 PM Database Feature #2141: generate SQL Server schema

Eric, what do you think about my last question in note 9 ("Will we create separate P2JSQLServer2008Dialect and P2JSQL... Vadim Nebogatov

04:25 PM Database Feature #2141: generate SQL Server schema

MS SQL Server allows double quoted column names and I meant we need support this too... But it seems I understood now... Vadim Nebogatov

10:22 AM Database Feature #2141: generate SQL Server schema

I'm not sure what use case would make this necessary. We control the conversion of all names, and we don't allow doub... Eric Faulhaber

04:54 AM Database Feature #2141: generate SQL Server schema

I think all usages of dialect.getComputedColumnPrefix() should be corrected for the case when prefix could be meet in... Vadim Nebogatov

04:17 PM Base Language Feature #1638 (WIP): implement Java access to converted appserver code (must be a simple replacem...

Constantin Asofiei

04:12 PM Database Feature #2116: add runtime support for _user metadata table

Ovidiu Maxiniuc wrote:
> In P2J terms, we need to have an "default" database defined in the directory, that will be ... Eric Faulhaber

03:53 PM Database Feature #2116: add runtime support for _user metadata table

If the @_user@ table of "default" database is populated (is not empty) and the -U -P command line parameters are not ... Ovidiu Maxiniuc

03:46 PM Database Feature #2116: add runtime support for _user metadata table

From my researches I found out some interesting things about @userid@ and @setuserid@ which are not very explicit in ... Ovidiu Maxiniuc

02:10 PM Database Feature #1594: add conversion and runtime support for CURRENT-CHANGED() built-in function

OK, thanks. Please commit and distribute the update. Eric Faulhaber

11:42 AM Database Feature #1594: add conversion and runtime support for CURRENT-CHANGED() built-in function

The @crtRecBuffCount == 1@ means that the respective record is referred by one buffer. In this case, there are two ca... Ovidiu Maxiniuc

11:49 PM Database Feature #1594: add conversion and runtime support for CURRENT-CHANGED() built-in function

Code review 20130911b/20130912e:
Changes look good, but please help me understand why the refresh code in the 2 ma... Eric Faulhaber

12:31 PM Base Language Feature #2129 (WIP): final runtime work on sockets

Constantin Asofiei

12:30 PM Base Language Feature #1640: implement DOM XML support

> You are right. I'll try to look how I can manage it inside rules.
Please provide the test you which uses the gener... Constantin Asofiei

12:18 PM Base Language Feature #1640: implement DOM XML support

Constantin Asofiei wrote:
> methods_attributes.rules:
> - getHandle - please explain why you still need to convert ... Evgeny Kiselev

06:56 AM Base Language Feature #1640: implement DOM XML support

Evgeny, a lot better, only a few issues left:
methods_attributes.rules:
- getHandle - please explain why you stil... Constantin Asofiei

10:16 PM Base Language Feature #1640: implement DOM XML support

1) now all assignments works inside WrapperResource and check type of handle.
2) load/save now works properly
3) merg... Evgeny Kiselev

12:20 PM Base Language Feature #2181: implement SSL support for sockets

@LowLevelSocketImpl.connectSSL@ is not yet implemented. Following are some findings/implementation notes:
* nosessio... Constantin Asofiei

12:16 PM Base Language Feature #2181 (Closed): implement SSL support for sockets

Constantin Asofiei

09/14/2013

07:20 AM Base Language Feature #2074: add CAN-QUERY() and CAN-SET() support

> The attribute PERSISTENT has described in Progress docs as readable/writable. But in P2J conversion we have only ge... Constantin Asofiei

09/13/2013

07:01 PM Base Language Feature #2074: add CAN-QUERY() and CAN-SET() support

The additional notes at this time:
NUM-BUFFERS r P2JQuery - (Changed javadoc, bacause it is attribute, not a metho... Eugenie Lyzenko

03:08 PM Base Language Feature #2074: add CAN-QUERY() and CAN-SET() support

Another question.
The attribute PERSISTENT has described in Progress docs as readable/writable. But in P2J convers... Eugenie Lyzenko

03:33 AM Base Language Feature #2074: add CAN-QUERY() and CAN-SET() support

Eugenie Lyzenko wrote:
> Another point:
> [...]
>
> The Buffer.java does not have @defaultBufferHandle@ method. ... Constantin Asofiei

01:45 PM Base Language Feature #1631: implement support for LANDSCAPE/PORTRAIT in I/O statements

OK, there are multiple things to discuss here.
1. First, the code you have posted is nested inside this "top level... Greg Shah

01:26 PM Base Language Feature #1631: implement support for LANDSCAPE/PORTRAIT in I/O statements

Here is the rule, that creates openPrinterStream()... Vadim Gindin

11:48 AM Base Language Feature #1631: implement support for LANDSCAPE/PORTRAIT in I/O statements

> Here is my rule for the FILENAME type:
Actually, I don't think this code is needed. The FILENAME node should co... Greg Shah

10:24 AM Base Language Feature #1631: implement support for LANDSCAPE/PORTRAIT in I/O statements

Greg Shah wrote:
> > Don't see at the type FILENAME here.
>
> What do you mean by this? The FILENAME node is the... Vadim Gindin

10:14 AM Base Language Feature #1631: implement support for LANDSCAPE/PORTRAIT in I/O statements

> Don't see at the type FILENAME here.
What do you mean by this? The FILENAME node is there.
> After I'll fix ... Greg Shah

10:03 AM Base Language Feature #1631: implement support for LANDSCAPE/PORTRAIT in I/O statements

Here is 4GL tree part corresponding to that statement:... Vadim Gindin

09:44 AM Base Language Feature #1631: implement support for LANDSCAPE/PORTRAIT in I/O statements

You are on the right track by looking at the tree itself to understand what is generated. But the problem here is li... Greg Shah

09:09 AM Base Language Feature #1631: implement support for LANDSCAPE/PORTRAIT in I/O statements

I'll explain.
Let's assume, that we are converting the statement OUTPUT TO PRINTER "printerName". At this moment re... Vadim Gindin

08:28 AM Base Language Feature #1631: implement support for LANDSCAPE/PORTRAIT in I/O statements

Your question is too broad. Are you asking for information on how to code TRPL programs? Do you have some specific ... Greg Shah

08:26 AM Base Language Feature #1631: implement support for LANDSCAPE/PORTRAIT in I/O statements

Could you tell me please how to specify the rules to convert OUTPUT TO PRINTER printerName statement to correct Java ... Vadim Gindin

04:26 AM Database Feature #1594: add conversion and runtime support for CURRENT-CHANGED() built-in function

Yesterday my work was focused on fixing the queries for failing tests. Because of the large amounts of sql queries ne... Ovidiu Maxiniuc

09/12/2013

05:51 PM Base Language Feature #2074: add CAN-QUERY() and CAN-SET() support

Another point:... Eugenie Lyzenko

04:48 AM Base Language Feature #2074: add CAN-QUERY() and CAN-SET() support

> No, please don't change the @hwrap@ values in methods attributes. To identify the interface defining the attribute/... Eugenie Lyzenko

03:48 AM Base Language Feature #2074: add CAN-QUERY() and CAN-SET() support

Eugenie Lyzenko wrote:
> Need another clarification. Consider the following rule:
> [...]
> There are no BufferFie... Constantin Asofiei

05:28 PM Base Language Feature #1631: implement support for LANDSCAPE/PORTRAIT in I/O statements

OK, interesting results. The progress.g will need to be fixed and most everything else from a conversion perspective... Greg Shah

04:56 PM Base Language Feature #1631: implement support for LANDSCAPE/PORTRAIT in I/O statements

> Finally, note this comment from the 4GL docs: @On UNIX, the printer spooling facilities (lp or lpr) are used automa... Vadim Gindin

04:34 PM Base Language Feature #1631: implement support for LANDSCAPE/PORTRAIT in I/O statements

It seems I really missed this circumstance. See the results of my testing below.
> Some questions:
>
> # Does t... Vadim Gindin

02:56 PM Base Language Feature #1631: implement support for LANDSCAPE/PORTRAIT in I/O statements

> OUTPUT TO PRINTER "somePrinter"
Interesting. Please note that the Progress 4GL Language reference states this:... Greg Shah

02:29 PM Base Language Feature #1631: implement support for LANDSCAPE/PORTRAIT in I/O statements

During the testing step I faced with a problem. When a printer name is specified in the progress OUTPUT TO PRINTER st... Vadim Gindin

04:35 PM Database Feature #2141: generate SQL Server schema

I have added item 7 about sequences to note 9 and question. Vadim Nebogatov

03:22 PM Database Feature #1594: add conversion and runtime support for CURRENT-CHANGED() built-in function

The initial tests had some unimportant fails in CTRL+C and quite a lot of fails in the main part:
* 7 in gso_tests ... Ovidiu Maxiniuc

09/11/2013

07:51 PM Base Language Feature #2074: add CAN-QUERY() and CAN-SET() support

Need another clarification. Consider the following rule:... Eugenie Lyzenko

06:15 PM Base Language Feature #2074: add CAN-QUERY() and CAN-SET() support

Yes, except the javadoc should read like this:... Greg Shah

06:13 PM Base Language Feature #2074: add CAN-QUERY() and CAN-SET() support

And the annotation for method should be:... Eugenie Lyzenko

06:08 PM Base Language Feature #2074: add CAN-QUERY() and CAN-SET() support

> 1. I would leave resource() field untouched. This will contain additional info we probably will able to use to sepa... Greg Shah

06:00 PM Base Language Feature #2074: add CAN-QUERY() and CAN-SET() support

And one more question:
For example consider the following attribute:... Eugenie Lyzenko

02:30 PM Base Language Feature #2074: add CAN-QUERY() and CAN-SET() support

Some additional thoughts about annotation:
1. I would leave resource() field untouched. This will contain addition... Eugenie Lyzenko

12:02 PM Base Language Feature #2074: add CAN-QUERY() and CAN-SET() support

Greg Shah wrote:
> Constantin: are you suggesting putting all the annotations on interface method definitions instea... Constantin Asofiei

11:57 AM Base Language Feature #2074: add CAN-QUERY() and CAN-SET() support

Constantin: are you suggesting putting all the annotations on interface method definitions instead of on the implemen... Greg Shah

11:57 AM Base Language Feature #2074: add CAN-QUERY() and CAN-SET() support

Thoughts:
1. The code @Method[] methods = h.get().getClass().getMethods();@ is not safe to chain this way. h.get(... Greg Shah

11:31 AM Base Language Feature #2074: add CAN-QUERY() and CAN-SET() support

While I'm modifying the attribute related classes you can review canQuery/canSet implementation proposal(HandleOps.ja... Eugenie Lyzenko

11:18 AM Base Language Feature #2074: add CAN-QUERY() and CAN-SET() support

> Do you mean that we should remove the "resource" field of LegacyAttribute/LegacyMethod?
Yes, as it will only confu... Constantin Asofiei

11:16 AM Base Language Feature #2074: add CAN-QUERY() and CAN-SET() support

OK, so we don't need to add the writable flag to the annotation.
> And I keep forgetting but fortunately I reminde... Greg Shah

11:06 AM Base Language Feature #2074: add CAN-QUERY() and CAN-SET() support

How the @LegacyAttribute@ annotation should look:... Constantin Asofiei

10:46 AM Base Language Feature #2074: add CAN-QUERY() and CAN-SET() support

Please document the change you propose (show the LegacyAttribute annotation definition and examples of use). Greg Shah

10:44 AM Base Language Feature #2074: add CAN-QUERY() and CAN-SET() support

Greg Shah wrote:
> Constantin: If I understand correctly, no changes are needed to the annotations design to support... Constantin Asofiei

10:38 AM Base Language Feature #2074: add CAN-QUERY() and CAN-SET() support

Constantin: If I understand correctly, no changes are needed to the annotations design to support these other use cas... Greg Shah

10:36 AM Base Language Feature #2074: add CAN-QUERY() and CAN-SET() support

Greg Shah wrote:
> > For each attribute/method we will specify its interface too, beside the associated method name ... Constantin Asofiei

10:31 AM Base Language Feature #2074: add CAN-QUERY() and CAN-SET() support

> For each attribute/method we will specify its interface too, beside the associated method name (sometimes the hwrap... Greg Shah

10:21 AM Base Language Feature #2074: add CAN-QUERY() and CAN-SET() support

> Constantin: is this design sufficient to support the needs of #2123 and the LIST-QUERY-ATTRS/LIST-SET-ATTRS?
Yes... Constantin Asofiei

10:03 AM Base Language Feature #2074: add CAN-QUERY() and CAN-SET() support

Please implement the annotations for all currently supported methods and attributes. This way, it will just be a sta... Greg Shah

09:51 AM Base Language Feature #2074: add CAN-QUERY() and CAN-SET() support

OK understood. Do we have the list of attributes we need to implement this way for now? Only "FRAME" and "FILE-TYPE" ... Eugenie Lyzenko

03:33 PM Database Feature #2141: generate SQL Server schema

*XXXXP2JDialect implementation (will be extended)*
1. extractColumnName(String expr) , needsComputedColumns() and i... Vadim Nebogatov

02:10 PM Base Language Feature #1631: implement support for LANDSCAPE/PORTRAIT in I/O statements

The ProcessDaemon actually already has a reference to StreamDaemon. When we instantiate both in ThinClient, we alrea... Greg Shah

01:47 PM Base Language Feature #1631: implement support for LANDSCAPE/PORTRAIT in I/O statements

As I understand StreamDaemon and ProcessDaemon are executed on the Client (on the same node). How can I obtain Proces... Vadim Gindin

11:49 AM Base Language Feature #1631: implement support for LANDSCAPE/PORTRAIT in I/O statements

I don't want to mix Linux PRINTER output device support in with generic process launching. In addition, Windows PRIN... Greg Shah

11:33 AM Base Language Feature #1631: implement support for LANDSCAPE/PORTRAIT in I/O statements

I didn't find the reason to write a separate stream class such PrinterStream, but I find the other way. We can add ne... Vadim Gindin

09/10/2013

07:20 PM Base Language Feature #2074: add CAN-QUERY() and CAN-SET() support

> The question I have is what will be the cost of this solution in term of application performance?
Yes, it is slo... Greg Shah

06:29 PM Base Language Feature #2074: add CAN-QUERY() and CAN-SET() support

OK. This is very clean approach and we can implement incrementally only what we currently need. The question I have i... Eugenie Lyzenko

10:09 AM Base Language Feature #2074: add CAN-QUERY() and CAN-SET() support

After some additional thought, I have come up with a 3rd option that I think is even better. Consider these annotati... Greg Shah

05:49 AM Base Language Feature #2074: add CAN-QUERY() and CAN-SET() support

Suggestion at this time.
Yes the approach #2 above looks preferable. However I see the discussion points here. The... Eugenie Lyzenko

09:48 PM Base Language Feature #1640: implement DOM XML support

Constantin Asofiei wrote:
> Evgeny, please provide the list of methods which, like @get-attribute-node@, require a v... Evgeny Kiselev

09/09/2013

04:52 PM User Interface Bug #2179: Focus issues in combo-box

The screenshots have been added to demonstrate the original 4GL behavior and what we have in P2J to see the differenc... Eugenie Lyzenko

10:43 AM User Interface Bug #2179: Focus issues in combo-box

4GL Linux:
Drop-down opened - cursor blinking inside the list. Drop-down closed and focus moved to next widget - cur... Eugenie Lyzenko

10:42 AM User Interface Bug #2179 (New): Focus issues in combo-box

Eugenie Lyzenko

03:38 PM Base Language Feature #1640: implement DOM XML support

Evgeny, please provide the list of methods which, like @get-attribute-node@, require a valid x-noderef resource and c... Constantin Asofiei

01:45 PM Base Language Feature #1640: implement DOM XML support

> I did not remove @XComonImpl.readOnlyError@ because I'm waiting @ErrorManager.displayAndAddError@ method.
I missed... Constantin Asofiei

11:48 PM Base Language Feature #1640: implement DOM XML support

issues from note 114:
1) I need @getHandle()@ for code like this @hRoot:handle:subtype@. Is it possible for @someHan... Evgeny Kiselev

03:16 PM Base Language Feature #1631: implement support for LANDSCAPE/PORTRAIT in I/O statements

> I've made a rule which converts OUTPUT TO PRINTER to this code:
>
>> UnnamedStreams.assingOut(StreamFactory.creat... Greg Shah

02:49 PM Base Language Feature #1631: implement support for LANDSCAPE/PORTRAIT in I/O statements

I need some help.
1. Rules.
I've made a rule which converts OUTPUT TO PRINTER to this code:
... Vadim Gindin

12:43 PM Base Language Feature #1639: implement socket support

> about SSL connections:
For Milestone 7, we don't need SSL support ("-ssl" never appears in any CONNECT() string ... Greg Shah

10:52 AM Base Language Feature #2074 (WIP): add CAN-QUERY() and CAN-SET() support

Greg Shah

10:49 AM User Interface Feature #2131 (Closed): implement the Windows equivalent to the NCURSES/terminal support

Greg Shah

10:30 AM User Interface Feature #2131: implement the Windows equivalent to the NCURSES/terminal support

I'm going to document one more issue related to the focus handling in combo-box. Part of it affects only Windows P2J ... Eugenie Lyzenko

09:32 AM User Interface Feature #2131: implement the Windows equivalent to the NCURSES/terminal support

> Great! Please check in your update and distribute it.
OK. Committed in bzr as 10380.
Eugenie Lyzenko

08:20 AM User Interface Feature #2131: implement the Windows equivalent to the NCURSES/terminal support

Great! Please check in your update and distribute it. Greg Shah

01:21 AM Database Feature #2141: generate SQL Server schema

Vadim Nebogatov wrote:
> One more question concerning mapping varchar to TEXT in PostgreSQL.
Progress @character@ f... Eric Faulhaber

09/08/2013

04:03 PM Base Language Feature #1639: implement socket support

A few issues to discuss/mention:
# about SSL connections:
a. OpenEdge keeps the private keys in a global store. Als... Constantin Asofiei

07:51 AM Base Language Feature #1640: implement DOM XML support

Evgeny, I missed something from your tests; your cases are mostly something like this:... Constantin Asofiei

09/07/2013

05:21 PM Database Feature #2141: generate SQL Server schema

Vadim Nebogatov wrote:
> I have noticed in import_util.rules that PostgreSQL connection string is configured only fo... Vadim Nebogatov

03:39 AM Database Feature #2141: generate SQL Server schema

One more question concerning mapping varchar to TEXT in PostgreSQL. Vadim Nebogatov

05:43 AM User Interface Feature #2131: implement the Windows equivalent to the NCURSES/terminal support

> Please go ahead and get the 0905a update regression tested using devsrv01
The runtime regression tests all passe... Eugenie Lyzenko

09/06/2013

04:46 PM Database Feature #2141: generate SQL Server schema

I have noticed in import_util.rules that PostgreSQL connection string is configured only for default port (5432). Is ... Vadim Nebogatov

02:39 PM Base Language Feature #1631: implement support for LANDSCAPE/PORTRAIT in I/O statements

Your plan is almost exactly right.
> add new method for the StreamFactory called openPrinterStream
Yes.
> im... Greg Shah

01:16 PM Base Language Feature #1631: implement support for LANDSCAPE/PORTRAIT in I/O statements

I reviewed the input-output rules and the code in classes /goldencode/p2j/util/Stream*.java
I'm going to do the fol... Vadim Gindin

12:35 PM Base Language Feature #1631: implement support for LANDSCAPE/PORTRAIT in I/O statements

The UI layout manager will do this when the columns won't fit into the width available. It is actually quite a compl... Greg Shah

12:27 PM Base Language Feature #1631: implement support for LANDSCAPE/PORTRAIT in I/O statements

Here is the resulting file for surprising test. Vadim Gindin

11:45 AM Base Language Feature #1631 (WIP): implement support for LANDSCAPE/PORTRAIT in I/O statements

> I expected that the result pdf will content one line. But the actual result really surprised me (see output_to_prin... Greg Shah

11:08 AM Base Language Feature #1631: implement support for LANDSCAPE/PORTRAIT in I/O statements

I ran all tests on windev01 and made additional test. The common results are:
# LANDSCAPE/PORTRAIT options are not a... Vadim Gindin

07:24 AM Base Language Feature #1631: implement support for LANDSCAPE/PORTRAIT in I/O statements

Interesting. OK, this means that on Linux the options are silently ignored. Our runtime implementation will have to... Greg Shah

07:16 AM Base Language Feature #1631: implement support for LANDSCAPE/PORTRAIT in I/O statements

Greg Shah wrote:
> The key questions here are:
>
> # What are the parameters passed to lp by Progress for these d... Vadim Gindin

12:23 PM Database Bug #2178: Asymmetric sequence behavior

Sequences in Progress are somewhat asymmetric relatively to their increment:
- An ascending sequence will allow any ... Ovidiu Maxiniuc

12:02 PM Database Bug #2178 (New): Asymmetric sequence behavior

Ovidiu Maxiniuc

11:29 AM User Interface Feature #1898 (Closed): write a replacement for the CHARVA libTerminal.so as an NCURSES-based Lin...

Greg Shah

10:13 AM User Interface Feature #2131: implement the Windows equivalent to the NCURSES/terminal support

>
> Please go ahead and get the 0905a update regression tested using devsrv01.
OK. Eugenie Lyzenko

10:02 AM User Interface Feature #2131: implement the Windows equivalent to the NCURSES/terminal support

Yes, defer it.
Please go ahead and get the 0905a update regression tested using devsrv01. Greg Shah

09:50 AM User Interface Feature #2131: implement the Windows equivalent to the NCURSES/terminal support

>
> > But the vertical scrollbar is missing in P2J CHUI while it exists in Windows and Linux 4GL systems.
>
> Is... Eugenie Lyzenko

06:59 AM User Interface Feature #2131: implement the Windows equivalent to the NCURSES/terminal support

> But the vertical scrollbar is missing in P2J CHUI while it exists in Windows and Linux 4GL systems.
Is it missin... Greg Shah

07:28 AM Base Language Feature #1625 (WIP): implement OUTPUT TO PRINTER on Windows

Please see #1631 for details on how the PRINTER option works for Linux/UNIX. When used on Linux, the PRINTER destina... Greg Shah

09/05/2013

07:28 PM User Interface Feature #2131: implement the Windows equivalent to the NCURSES/terminal support

> Are you going to work on this:
>
> > 15. In regard to the avoiding of drawing the horizontal scrollbar in select... Eugenie Lyzenko

06:46 PM User Interface Feature #2131: implement the Windows equivalent to the NCURSES/terminal support

Code Review 0905a
I am OK with these changes.
Are you going to work on this:
> 15. In regard to the avoiding... Greg Shah

06:42 PM User Interface Feature #2131: implement the Windows equivalent to the NCURSES/terminal support

The today drop includes:
1. Improving readability of the terminal_win.c code.
2. Refactoring the initConsole() func... Eugenie Lyzenko

08:50 PM User Interface Feature #2131: implement the Windows equivalent to the NCURSES/terminal support

0. Merged with the recent P2J code base.
1. Reworked process_win.c to separate path calculation function.
2. Added ... Eugenie Lyzenko

05:14 PM Database Feature #2141: generate SQL Server schema

I have checked in SQL Server 2005 (I think the same for SQL Server 2008 and 2012): the following column names are cor... Vadim Nebogatov

09:28 AM Database Feature #2141: generate SQL Server schema

Your understanding is correct (assuming that prefix generates a legal name in SQL Server). Eric Faulhaber

03:15 AM Database Feature #2141: generate SQL Server schema

Could the same prefix @CC_PREFIX = "__"@ be used for any database supporting computed columns? As far as I understood... Vadim Nebogatov

04:53 PM Base Language Feature #1631: implement support for LANDSCAPE/PORTRAIT in I/O statements

> The Progress documentation says that landscape/portrait options should be supported by printer driver, i.e. real be... Greg Shah

03:36 PM Base Language Feature #1631: implement support for LANDSCAPE/PORTRAIT in I/O statements

The next script is:... Vadim Gindin

02:32 PM Database Feature #2175: add support for -rereadnolock startup parameter

The runtime test failed.
Some CTRL+C test failed and 3 reports show results different than expected.
I started disc... Ovidiu Maxiniuc

10:37 AM Base Language Feature #1640: implement DOM XML support

> Greg: there are some common attributes (like INSTANTIATING-PROCEDURE and UNIQUE-ID) for which the implementation ca... Greg Shah

10:20 AM Base Language Feature #1640: implement DOM XML support

> Widget Pool is not implemented in @com.goldencode.p2j.xml.XmlFactory.createSaxAttributes()@ because I didn't find a... Constantin Asofiei

10:19 AM Base Language Feature #1640: implement DOM XML support

As a side-note, in some files there are lots of whitespace changes. Please change the settings to your editor so that... Constantin Asofiei

10:14 PM Base Language Feature #1640: implement DOM XML support

from note 107:
1-11 is done.
from note 109:
1. done
2. done
3. in the update it's implemented incorrect. Because need... Evgeny Kiselev

10:53 PM Database Feature #2116 (WIP): add runtime support for _user metadata table

See #2177, which describes some background research to be done in preparation for this task.
The P2J implementatio... Eric Faulhaber

09/04/2013

04:56 PM Base Language Feature #1631: implement support for LANDSCAPE/PORTRAIT in I/O statements

> 1. Greg, you wroted in the task 1631: "You will have to test with wider than 132 and narrower than 132 terminals to... Greg Shah

04:53 PM Base Language Feature #1631: implement support for LANDSCAPE/PORTRAIT in I/O statements

> 4. Attributes paged and page-size. Default page-size is 56. LANDSCAPE, PORTRAIT options do not affect page size - d... Greg Shah

04:32 PM Base Language Feature #1631: implement support for LANDSCAPE/PORTRAIT in I/O statements

1. While starting progress in terminal width = 60. Message: "Unable to use your terminal. Check your PROTERMCAP file.... Vadim Gindin

12:13 PM User Interface Feature #2131: implement the Windows equivalent to the NCURSES/terminal support

> Is this approach acceptable?
Yes, that is much better than using 850 directly. Go with it. Greg Shah

12:05 PM User Interface Feature #2131: implement the Windows equivalent to the NCURSES/terminal support

> 4. I am worried about hard coding terminal_win.c to the 850 codepage. I wonder if there is any option to query the ... Eugenie Lyzenko

09:32 AM User Interface Feature #2131: implement the Windows equivalent to the NCURSES/terminal support

I would probably choose this:... Greg Shah

09:14 AM User Interface Feature #2131: implement the Windows equivalent to the NCURSES/terminal support

> ...but please use whitespace and formatting to make the code easier to read. Your code in general lacks whitespace ... Eugenie Lyzenko

08:01 AM User Interface Feature #2131: implement the Windows equivalent to the NCURSES/terminal support

> Do you mean to have the single function to allocate and free memory? Something like createDestroyFullPath(char *, j... Greg Shah

10:53 AM Database Feature #2175: add support for -rereadnolock startup parameter

Update merged with latest bzr sources and changes from review. I already re-tested it with my sample tests.
I am run... Ovidiu Maxiniuc

07:57 AM Database Bug #2176: exceptions to rereadnolock

This looks like an optimization of some kind that Progress uses to reduce accesses to db.
When the search for a re... Ovidiu Maxiniuc

07:53 AM Database Bug #2176 (New): exceptions to rereadnolock

Ovidiu Maxiniuc

03:23 AM Database Bug #2164: Server fails to start a Progress app when persistence disabled

The code changes look good, though please remove the left margin space that was inserted on every line after the firs... Eric Faulhaber

09/03/2013

06:23 PM User Interface Feature #2131: implement the Windows equivalent to the NCURSES/terminal support

> 12. Please put the cmd.exe full path calculation code into a separate function to make the code more readable.
>
... Eugenie Lyzenko

04:19 PM User Interface Feature #2131: implement the Windows equivalent to the NCURSES/terminal support

> 3. Please review the TODOs in terminal_win.c and report on the status of each one. If the TODO is no longer needed,... Eugenie Lyzenko

04:06 PM User Interface Feature #2131: implement the Windows equivalent to the NCURSES/terminal support

Code Review 0902a
1. About terminal_win.c errorProcessing() function:
* Change the name to generateException().... Greg Shah

06:15 PM Database Bug #2164: Server fails to start a Progress app when persistence disabled

Also, the code changes don't include automated tests. Should tests be part of the solution for this particular issue? Hynek Cihlar

06:13 PM Database Bug #2164 (Review): Server fails to start a Progress app when persistence disabled

Please review the changes. The submitted files are based to bzr revision number 10379. Hynek Cihlar

05:27 PM Database Feature #2141 (WIP): generate SQL Server schema

This will require the addition of a @P2JSQLServerDialect@ which extends Hibernate's @SQLServer2008Dialect@. If I reca... Eric Faulhaber

05:06 PM Database Feature #2126: add support for table-level locking (share and exclusive) for runtime internal use

Update vmn_upd20130903a.zip committed to bzr revision 10379. Vadim Nebogatov

04:13 PM Database Feature #2126: add support for table-level locking (share and exclusive) for runtime internal use

Please don't commit MetaSchemaImpl and comment out its usage for now, adding a TODO to fix it later. Eric Faulhaber

04:11 PM Database Feature #2126: add support for table-level locking (share and exclusive) for runtime internal use

Eric, should I commit also MetaSchemaImpl?
Or simply comment current MetaSchemaImpl method call and write P2JIndex ... Vadim Nebogatov

12:29 PM Database Feature #2126 (WIP): add support for table-level locking (share and exclusive) for runtime intern...

Eric Faulhaber

11:48 AM Database Feature #2126: add support for table-level locking (share and exclusive) for runtime internal use

Since my requested changes do not affect the code itself, no need for another round of testing. Assuming it still com... Eric Faulhaber

11:37 AM Database Feature #2126: add support for table-level locking (share and exclusive) for runtime internal use

The changes look good. Please add a header entry to @LockManagerMultiplexer.java@. As @MetaSchemaImpl@ is a temporary... Eric Faulhaber

04:41 PM Base Language Feature #1631: implement support for LANDSCAPE/PORTRAIT in I/O statements

> It creates 3 identical files with textwidth=132 symbols. So in this case our options also do not affect the page wi... Greg Shah

04:25 PM Base Language Feature #1631: implement support for LANDSCAPE/PORTRAIT in I/O statements

The first test is for default terminal wich is xterm (80x24) on lindev01:... Vadim Gindin

10:48 AM Base Language Feature #1631: implement support for LANDSCAPE/PORTRAIT in I/O statements

Questions/Answers:
1. Why are you using the STREAM-IO in your tests? Unless it is needed, you generally should el... Greg Shah

04:36 PM User Interface Bug #2172: Editor widget vertical scrollbar issue

The vertical scrollbar thumb position is different from 4GL. This can not be detected in test system because in Linux... Eugenie Lyzenko

04:35 PM User Interface Bug #2171: Focused radio-button attribute mismatch

Radio-button has a bit different look as in 4GL form the attributes point of view. The focused button character betwe... Eugenie Lyzenko

04:34 PM User Interface Bug #2170: Selection list does not show the vertical scrollbar

When creating the selection list widget with more items than can fit the display window the vertical scrollbar is not... Eugenie Lyzenko

04:33 PM User Interface Bug #2169: Scrollbars issue in combo-box and selection-list

When scrolling combo-box drop-down list the vertical scrollbar does not change the thumb position as it should. Howev... Eugenie Lyzenko

04:32 PM User Interface Bug #2168: Combo-box initial shape attribute mismatch

Another attribute drawing mismatch has been found for combo-box widget. This is the runtime issue. There must be one ... Eugenie Lyzenko

04:23 PM User Interface Bug #2166: Alert box layout mismatch

Consider the following code:... Eugenie Lyzenko

01:54 PM Database Feature #2175: add support for -rereadnolock startup parameter

<sigh> I can't make any sense of the "logic" that must be behind these results. Looks like a quirk/bug of their parse... Eric Faulhaber

01:20 PM Database Feature #2175: add support for -rereadnolock startup parameter

I found another issue. When the search for a record is done using the ROWID or RECID, the record is not re-fetched fr... Ovidiu Maxiniuc

12:13 PM Database Feature #2175: add support for -rereadnolock startup parameter

Eric Faulhaber wrote:
> @rereadNoLock()@ to @getRereadNoLock()@.
Sorry, for consistency, I guess that should be @is... Eric Faulhaber

11:23 AM Database Feature #2175: add support for -rereadnolock startup parameter

One more thing: please use proper logging in your @RecordBuffer@ changes instead of @System.err.println@. Eric Faulhaber

11:06 AM Database Feature #2175: add support for -rereadnolock startup parameter

OK, thanks for the explanation. The implementation looks good to me, just minor change requests:
* For consistency o... Eric Faulhaber

09:48 AM Database Feature #2175: add support for -rereadnolock startup parameter

From my researches on 4GL and docs, there is nothing to indicate that Progress looks into other user's buffers to see... Ovidiu Maxiniuc

01:42 AM Database Feature #2175: add support for -rereadnolock startup parameter

I haven't finished a detailed review yet, but I have a basic question on your approach: are you trying to determine ... Eric Faulhaber

01:17 PM User Interface Bug #2174: Toggle-box widget implementation abnormal end issue

The toggle box widget can not be used for now. Consider the following sample:
...... Greg Shah

01:16 PM User Interface Bug #2173 (Rejected): Support for slider widget

This is a known issue. We will add this support at a later date. Greg Shah

01:16 PM User Interface Bug #2173: Support for slider widget

Currently we do not have the support for slider widget. The GenericWidget class is generated while conversion.
The... Greg Shah

12:30 PM Database Feature #2043 (WIP): add runtime support for some embedded SQL features

Eric Faulhaber

12:27 PM Database Feature #1668: add support for additional (non-dynamic) database attributes

Interesting temp-table result for DBNAME, too. Suggests that internally, Progress uses a distinct database for temp-t... Eric Faulhaber

12:11 PM Base Language Feature #2108 (Closed): event model rationalization

Greg Shah

12:10 PM Base Language Feature #2108: event model rationalization

Attached update is committed to bzr revision 10378. Constantin Asofiei

09/02/2013

07:30 PM User Interface Feature #2131: implement the Windows equivalent to the NCURSES/terminal support

The today drop includes small addition for restoring the cursor status that was before executing the console applicat... Eugenie Lyzenko

05:43 PM Database Feature #2126: add support for table-level locking (share and exclusive) for runtime internal use

Regressions (note 24-25) were executed for vmn_upd20130831a.zip. Vadim Nebogatov

05:41 PM Database Feature #2126: add support for table-level locking (share and exclusive) for runtime internal use

I have uploaded update vmn_upd20130831a.zip replacing vmn_upd20130814a.zip with fixes according to note 23. Vadim Nebogatov

04:54 PM Database Feature #2126: add support for table-level locking (share and exclusive) for runtime internal use

Regression 20130902_061345, 3 FAILED tests:
1. tc_job_002 FAILED failure in step 40: 'Unexpected EOF in actual at ... Vadim Nebogatov

04:36 AM Database Feature #2126: add support for table-level locking (share and exclusive) for runtime internal use

I have executed regression two times.
Regression 20130831_172455, 4 FAILED tests:
1. gso221_session1 FAILED f... Vadim Nebogatov

05:31 PM Database Feature #1668: add support for additional (non-dynamic) database attributes

The following test case for note 124:... Vadim Nebogatov

05:15 PM Database Feature #1668: add support for additional (non-dynamic) database attributes

From docs: "For ... Buffer object handle, the ERROR attribute indicates whether an error occurred during a FILL or S... Vadim Nebogatov

05:21 PM Base Language Feature #2108: event model rationalization

Code Review 0829a
Everything looks good.
1. Please add javadoc to explain the details in note 14 answers 1, 3, ... Greg Shah

11:37 AM Database Feature #2175: add support for -rereadnolock startup parameter

Update pack for review. This update is built over the om_upd20130829a.zip of #1594.
The implementation looks into @B... Ovidiu Maxiniuc

10:07 AM Base Language Feature #1631: implement support for LANDSCAPE/PORTRAIT in I/O statements

I've made a script for testing conditions about width of text in the outut file. Here it is:... Vadim Gindin

08/31/2013

08:13 PM User Interface Feature #2131: implement the Windows equivalent to the NCURSES/terminal support

The today drop includes:
1. Minor changing to clean up from old comments in terminal_win.c module and adding clear s... Eugenie Lyzenko

08/30/2013

05:57 PM Base Language Feature #1631: implement support for LANDSCAPE/PORTRAIT in I/O statements

> 1. lindev01. I ran different test. See below.
Please try both test programs on both lindev01 and windev01. In p... Greg Shah

04:31 PM Base Language Feature #1631: implement support for LANDSCAPE/PORTRAIT in I/O statements

I tried to run simple test with these options on lindev01 and windev01.
1. lindev01. I ran different test. See belo... Vadim Gindin

09:46 AM Base Language Feature #1631: implement support for LANDSCAPE/PORTRAIT in I/O statements

The work above was all done to support the proper conversion of these options. But the runtime behavior has not yet ... Greg Shah

03:07 PM Database Feature #2175: add support for -rereadnolock startup parameter

My first instinct was to put this flag somewhere in the database branch which was a little cumbersome to extract. I f... Ovidiu Maxiniuc

12:35 PM Database Feature #2175: add support for -rereadnolock startup parameter

Ovidiu Maxiniuc wrote:
> This is a command-line parameter for the client, it's proper location is not the @directory... Eric Faulhaber

11:57 AM Database Feature #2175: add support for -rereadnolock startup parameter

This is a command-line parameter for the client, it's proper location is not the @directory.xml@.
In 4GL I can have ... Ovidiu Maxiniuc

02:22 PM Database Feature #2115: add runtime support for _file and _field metadata tables

I asked only to understand tables structures. Vadim Nebogatov

02:16 PM Database Feature #2115: add runtime support for _file and _field metadata tables

No reasons, I also think they could be hidden behind MetaSchema API. Vadim Nebogatov

02:11 PM Database Feature #2115: add runtime support for _file and _field metadata tables

Sorry I missed this earlier. Yes, these tables have a RECID field, generally of the form @{table_name}-recid@. But, I... Eric Faulhaber

01:57 PM Database Feature #1652: add conversion and runtime support for dynamically prepared temp-tables

Stanislav Lomany wrote:
> And what about index information - list of indexes with attributes: primary, word (if we n... Eric Faulhaber

01:46 PM Database Feature #1652: add conversion and runtime support for dynamically prepared temp-tables

And what about index information - list of indexes with attributes: primary, word (if we need it), unique?
> We wi... Stanislav Lomany

01:34 PM Database Feature #1652: add conversion and runtime support for dynamically prepared temp-tables

All of these will be available via the @MetaSchema@ API, though the actual metadata tables (e.g., _file, _field, etc.... Eric Faulhaber

01:26 PM Database Feature #1652: add conversion and runtime support for dynamically prepared temp-tables

> These names will available via an API. The code will look something like this:
>
> MetaSchema meta = persistence... Stanislav Lomany

01:40 PM Base Language Feature #2108: event model rationalization

ca_upd20130829a.zip has passed regression testing. Constantin Asofiei

11:58 AM Database Feature #1668: add support for additional (non-dynamic) database attributes

For all the buffer-related attributes in note 113, please determine with test cases that these all work the same way ... Eric Faulhaber

11:15 AM Database Feature #2126: add support for table-level locking (share and exclusive) for runtime internal use

Code review 20130814a:
I think the implementation of table locking in @InMemoryLockManager@ generally is OK, but s... Eric Faulhaber

04:31 AM Base Language Feature #1640: implement DOM XML support

Evgeny Kiselev wrote:
> in *1* instance is created. In my case I'm understand this state as unknown, but there is so... Constantin Asofiei

08/29/2013

06:32 PM Base Language Feature #1640: implement DOM XML support

Constantin Asofiei wrote:
> 3. @XEntityImpl.invalidNodeError@
> - I don't like how the @XEntityImpl.invalidNodeErro... Evgeny Kiselev

05:59 PM Database Feature #1668: add support for additional (non-dynamic) database attributes

Update vmn_upd20130829a.zip/vmn_upd20130829b.zip is attached.
Test case corresponds to 4GL behavior for tablehand... Vadim Nebogatov

04:04 PM User Interface Feature #2131: implement the Windows equivalent to the NCURSES/terminal support

The drop includes code checked for suspend/resume compatibility. The only usage foe these functions I have found is t... Eugenie Lyzenko

02:37 PM Database Feature #1594: add conversion and runtime support for CURRENT-CHANGED() built-in function

Update for review.
We need to update the current-changed each time @P2JQuery.current()@ is called. Other first/next/... Ovidiu Maxiniuc

11:38 AM Database Feature #1594: add conversion and runtime support for CURRENT-CHANGED() built-in function

The @-rereadnolock@ is not activated and in 4GL this case is not taken into consideration.
In fact this is the sec... Ovidiu Maxiniuc

10:04 AM Database Feature #2175: add support for -rereadnolock startup parameter

Testing environment. The article is not very explicit so I will explain the testcase.
Suppose we have a table @perso... Ovidiu Maxiniuc

09:13 AM Base Language Feature #2108: event model rationalization

The attached fix solved some bugs found during regression testing and addresses the issues in the review.
# I coul... Constantin Asofiei

08/28/2013

05:59 PM Base Language Feature #2108: event model rationalization

OK, I have completed my code review (to the 0827a level). Overall: it is really good! The code is now also insanely... Greg Shah

04:41 PM Base Language Feature #2108: event model rationalization

More questions:
4. In regard to your assumption in note 9:
> From my testing, I think is reasonbly to think a d... Greg Shah

04:33 PM Base Language Feature #2108: event model rationalization

I am in the middle of the code review. So far I have finished the ui and net package code. I have these initial que... Greg Shah

03:46 PM Database Feature #2175: add support for -rereadnolock startup parameter

The current persistence implementation does not support the feature provided by the @-rereadnolock@ startup parameter... Eric Faulhaber

03:44 PM Database Feature #2175 (Closed): add support for -rereadnolock startup parameter

Eric Faulhaber

03:42 PM Database Feature #1594: add conversion and runtime support for CURRENT-CHANGED() built-in function

The @-rereadnolock@ parameter is indeed in use in the server project. We will need to support this as a configurable ... Eric Faulhaber

03:29 PM Database Feature #1594: add conversion and runtime support for CURRENT-CHANGED() built-in function

Oops, I misread your test case. This is not a dirty share issue, as I was thinking. Session B actually commits its ch... Eric Faulhaber

03:01 PM Database Feature #1594: add conversion and runtime support for CURRENT-CHANGED() built-in function

Just re-checked with @customer@ and @person@ tables.
There is definitely a bug, in P2J the A client displays the sa... Ovidiu Maxiniuc

02:35 PM Database Feature #1594: add conversion and runtime support for CURRENT-CHANGED() built-in function

How does this test case behave in the 4GL?
The @customer@ table is a bit unusual in our @p2j_test@ database in tha... Eric Faulhaber

02:19 PM Database Feature #1594: add conversion and runtime support for CURRENT-CHANGED() built-in function

I know.
The important issue is that if you have 2 clients on the same P2J server and
Client A:... Ovidiu Maxiniuc

02:11 PM Database Feature #1594: add conversion and runtime support for CURRENT-CHANGED() built-in function

Ovidiu Maxiniuc wrote:
> There is no second level cache in Hibernate. The @directory.xml@ explicitly say: @hibernate... Eric Faulhaber

01:05 PM Database Feature #1594: add conversion and runtime support for CURRENT-CHANGED() built-in function

I am forced to do the implementation as you suggested.
I really do not understand why my session of hibernate cannot... Ovidiu Maxiniuc

08/27/2013

06:51 PM Database Feature #1594: add conversion and runtime support for CURRENT-CHANGED() built-in function

I don't know if the caching behavior changed with the Hibernate upgrade. Regardless, I want to keep the calls to @Ses... Eric Faulhaber

03:01 PM Database Feature #1594: add conversion and runtime support for CURRENT-CHANGED() built-in function

You were right about the implementation. I changed a little, I'm doing the check for changed field in a bracket in @R... Ovidiu Maxiniuc

02:43 PM Base Language Feature #1640: implement DOM XML support

Constantin Asofiei wrote:
> 7. @XentityImpl.invalidArgumentError@
> - if you need access to the @HandleResource.t... Evgeny Kiselev

04:50 AM Base Language Feature #1640: implement DOM XML support

When you post an update, please summarize the changes (as compared to the previous update) and what issues were fixed... Constantin Asofiei

12:12 PM Base Language Feature #2108: event model rationalization

The most important change here is related to the fact that when Session-free is used and a external procedure is invo... Constantin Asofiei

08/26/2013

04:35 PM User Interface Feature #2131: implement the Windows equivalent to the NCURSES/terminal support

The drop includes the get/set terminal type implementation. The real 4gL Windows shows the terminal type is constant ... Eugenie Lyzenko

03:54 PM Database Feature #1652: add conversion and runtime support for dynamically prepared temp-tables

> Stas, could some conflict between ids happen with using shared buffers?
UniqueIdGenerator only hands out new ids... Stanislav Lomany

02:33 PM Database Feature #1652: add conversion and runtime support for dynamically prepared temp-tables

Stas, could some conflict between ids happen with using shared buffers? Vadim Nebogatov

09:26 AM Database Feature #1652: add conversion and runtime support for dynamically prepared temp-tables

Constantin, you can check com.goldencode.p2j.util.UniqueIdGenerator. Vadim, generator presumes that id's are unique a... Stanislav Lomany

08:57 AM Database Feature #1652: add conversion and runtime support for dynamically prepared temp-tables

Vadim Nebogatov wrote:
> I understand for TEMP_TABLE, but why unique id for BUFFER is also ContextLocal?
I don't th... Constantin Asofiei

05:32 AM Database Feature #1652: add conversion and runtime support for dynamically prepared temp-tables

I understand for TEMP_TABLE, but why unique id for BUFFER is also ContextLocal? Vadim Nebogatov

08:20 PM Base Language Feature #1640: implement DOM XML support

I have upload last version of code. This code doesn't fix all issues from note 107 by Constantin.
Also in second ar... Evgeny Kiselev

08/25/2013

10:36 AM Database Feature #1652: add conversion and runtime support for dynamically prepared temp-tables

Hibernate sources update. Stanislav Lomany

08/24/2013

08:47 AM User Interface Bug #2174 (Rejected): Toggle-box widget implementation abnormal end issue

Eugenie Lyzenko

08:29 AM User Interface Bug #2173 (Rejected): Support for slider widget

Eugenie Lyzenko

08:20 AM User Interface Bug #2172 (New): Editor widget vertical scrollbar issue

Eugenie Lyzenko

08:13 AM User Interface Bug #2171 (New): Focused radio-button attribute mismatch

Eugenie Lyzenko

08:11 AM User Interface Bug #2170 (New): Selection list does not show the vertical scrollbar

Eugenie Lyzenko

08:04 AM User Interface Bug #2169 (New): Scrollbars issue in combo-box and selection-list

Eugenie Lyzenko

08/23/2013

07:15 PM Database Feature #2080: add runtime support for database methods

I have attached preliminary update vmn_upd20130824a including BUFFER-FIELD and GET-BUFFER-HANDLE support and MetaSche... Vadim Nebogatov

05:49 PM Database Feature #2080: add runtime support for database methods

Support of methods added in issue #1947:
@BUFFER-FIELD (KW_BUF_FLD)@
Implemented with MetaShemaImpl (stub with... Vadim Nebogatov

06:47 PM User Interface Feature #2131: implement the Windows equivalent to the NCURSES/terminal support

The today drop includes error processing code approach for terminal_win.c module for you to review. The gathering inf... Eugenie Lyzenko

12:59 PM Database Feature #1652: add conversion and runtime support for dynamically prepared temp-tables

Update with new functionality for review. Stanislav Lomany

09:34 AM Base Language Feature #1640: implement DOM XML support

Evgeny, this the review for your 0707a.zip update. Please let me know if you see anything wrong with my reasoning.
... Constantin Asofiei

05:29 AM Base Language Feature #1640: implement DOM XML support

> 3) I have found strange case:
> @hRoot:GET-PARENT(hWork).@ if @hRoot@ is unknown and @hWork@ is valid and known w... Constantin Asofiei