Activity
From 09/12/2013 to 10/11/2013
10/11/2013
- 05:16 PM User Interface Feature #1782: implement LAST-EVENT system handle and associated attributes
- Constantin: what are your thoughts on what we need to investigate?
- 05:15 PM User Interface Feature #1782: implement LAST-EVENT system handle and associated attributes
- For now all we need to focus on is the LAST-EVENT:LABEL runtime support.
- 05:10 PM Base Language Feature #1646: implement BASE64-ENCODE/BASE64-DECODE built-in functions
- > For this function the converted code is DynamicOps.length(str) and during execution it goes to TextOps.length(Text...
- 03:50 PM Base Language Feature #1646: implement BASE64-ENCODE/BASE64-DECODE built-in functions
- Greg Shah wrote:
> Code Review 1010a
> [...]
> 4. In LogicalTerminal, why do this:
>
> [...]
>
> As far as I... - 12:41 PM Base Language Feature #1646: implement BASE64-ENCODE/BASE64-DECODE built-in functions
- Interesting... I'll try.
Here is the progress procedure I wroted about.... - 12:34 PM Base Language Feature #1646: implement BASE64-ENCODE/BASE64-DECODE built-in functions
- OK, do implement the support for your current findings.
> There is no error, mentioned in the old comment.
I th... - 11:42 AM Base Language Feature #1646: implement BASE64-ENCODE/BASE64-DECODE built-in functions
- There is the old comment in the @SecurityOps.base64Encode@ method: ...
- 10:12 AM Base Language Feature #1646: implement BASE64-ENCODE/BASE64-DECODE built-in functions
- > How to create memptr with negative size?
Search for REAL_LOWER_BOUND in memptr.java. The short story: in Progre... - 09:30 AM Base Language Feature #1646: implement BASE64-ENCODE/BASE64-DECODE built-in functions
- How to create memptr with negative size? I tried to call @set-size(..)=-100@ but it didn't work. After this call the ...
- 04:21 PM Database Feature #2116: add runtime support for _user metadata table
- Meanwhile I tried to connect to different database servers using different dialects (one PSQL, one H2).
I was expect... - 03:40 PM Database Feature #1654: add conversion and runtime support for dynamic buffer creation and cleanup
- OK, please let me know if you see some obvious flaws in the rest of the plan.
- 03:07 PM Database Feature #1654: add conversion and runtime support for dynamic buffer creation and cleanup
- Sorry I missed that detail in my review. This is a good question, and after speaking with Greg, I am shifting my opin...
- 01:42 PM Database Feature #1654: add conversion and runtime support for dynamic buffer creation and cleanup
- > I am a bit confused by this comment. @MetaSchema@ will have schema information, basically the equivalent for temp-t...
- 12:37 PM Database Feature #1654: add conversion and runtime support for dynamic buffer creation and cleanup
- Stanislav Lomany wrote:
> Determination of the outermost scope for a temp-table is the task for MetaSchema, it canno... - 08:12 AM Database Feature #1654: add conversion and runtime support for dynamic buffer creation and cleanup
- Let's forget for a second about persistent procedures and widget pools. For normal processing, as I said earlier, a d...
- 10:39 AM User Interface Bug #2192: built-in functions without parameters are displayed only once
- I don't know if this bug is manifested in the current project or not, but I'm setting a target version, so we don't l...
- 09:56 PM Database Feature #2141: generate SQL Server schema
- Code review 20131006:
Nice work.
I'm just curious: what is the @SelectedMethod=Cursor@ parameter in the databas...
10/10/2013
- 04:02 PM Base Language Feature #1646: implement BASE64-ENCODE/BASE64-DECODE built-in functions
- I will make additional testing to answer these questions.
- 02:09 PM Base Language Feature #1646: implement BASE64-ENCODE/BASE64-DECODE built-in functions
- Code Review 1010a
1. Is this todo in base64Encode() still valid?... - 01:37 PM Base Language Feature #1646: implement BASE64-ENCODE/BASE64-DECODE built-in functions
- I switched to java7, implemented "skip" operator support for a message statement including message truncating. By the...
- 03:43 PM User Interface Feature #1787: implement batch mode support
- > interactive 4GL feature - You mean for example the data field that updated by the user interaction in usual process...
- 02:48 PM User Interface Feature #1787: implement batch mode support
- > The purpose of this task is to duplicate those features of the 4GL that are enabled when the 4GL client is started ...
- 11:53 AM User Interface Bug #2192: built-in functions without parameters are displayed only once
- When P2J displays the expressions formed by only one no-args built-in functions multiple times within the same frame ...
- 11:40 AM User Interface Bug #2192 (New): built-in functions without parameters are displayed only once
- 11:41 AM Base Language Feature #2074 (Closed): add CAN-QUERY() and CAN-SET() support
- 11:39 AM Base Language Feature #2074: add CAN-QUERY() and CAN-SET() support
- The testcases update. Committed in bzr as 1035.
- 11:14 AM Base Language Feature #2074: add CAN-QUERY() and CAN-SET() support
- 1010b has been committed as 10398.
- 10:54 AM Base Language Feature #2074: add CAN-QUERY() and CAN-SET() support
- It looks good. Check it in and distribute it.
- 10:27 AM Base Language Feature #2074: add CAN-QUERY() and CAN-SET() support
- > This should be the last change for this task.
The new drop fixes the HANDLE attribute issue. The approach does n... - 09:30 AM Base Language Feature #2074: add CAN-QUERY() and CAN-SET() support
- Code Review 1010a
I am OK with the changes.
> OK. I'll work on solution.
This should be the last change for ... - 09:11 AM Base Language Feature #2074: add CAN-QUERY() and CAN-SET() support
- This update includes additional fix for ERROR attribute in temp-table. The TempTable.java class has been modified ins...
- 07:52 AM Base Language Feature #2074: add CAN-QUERY() and CAN-SET() support
- Code Review 1009d
I am fine with all the changes. - 07:46 AM Base Language Feature #2074: add CAN-QUERY() and CAN-SET() support
- > 2. TEMP-TABLE resource should be Errorable. Otherwise we have no support for ERROR rw attribute.
Yes, please fix... - 08:03 PM Base Language Feature #2074: add CAN-QUERY() and CAN-SET() support
- > 2. TEMP-TABLE resource should be Errorable. Otherwise we have no support for ERROR rw attribute.
This issue can ... - 10:49 AM Base Language Feature #1631: implement support for LANDSCAPE/PORTRAIT in I/O statements
- I've committed the missed file PrinterStream. New rev is 10397.
- 10:15 AM Base Language Feature #1631 (Closed): implement support for LANDSCAPE/PORTRAIT in I/O statements
- The update did pass regression testing.
- 09:54 AM Base Language Feature #1631: implement support for LANDSCAPE/PORTRAIT in I/O statements
- I've checked in the last update (vig_upd20130924b.zip). Revision number is 10396.
- 10:16 AM Base Language Feature #2010 (Closed): runtime support for LANDSCAPE/PORTRAIT I/O options
- 09:03 AM Database Feature #2116: add runtime support for _user metadata table
- Another difference I thought of is that when we connect to multiple databases in regression testing, both have the sa...
- 08:49 AM Database Feature #2116: add runtime support for _user metadata table
- Thanks for the clarification. So, are you saying the above stack trace was generated from the query running against @...
- 03:41 AM Database Feature #2116: add runtime support for _user metadata table
- I will investigate the @JdbcKeyRetriever@, I did not see any flaw in @DatabaseManager.getDatabaseTables(Database)@.
...
10/09/2013
- 04:20 PM Database Feature #2116: add runtime support for _user metadata table
- This query doesn't look correct. Why are we accessing tables from different databases in the same query? Perhaps a bu...
- 02:25 PM Database Feature #2116: add runtime support for _user metadata table
- The customer is using simultaneous connection to databases "common" and "<db_name>".
I have done today some research... - 02:58 PM Base Language Feature #2074: add CAN-QUERY() and CAN-SET() support
- The uploaded drop also fixes the issue with missed annotations for SCHEMA-LOCATION and SCHEMA-PATH in x-document reso...
- 12:20 PM Base Language Feature #2074: add CAN-QUERY() and CAN-SET() support
- The new update for your review. It fixes almost all deviations in getting annotation. The root cause was the getLegac...
- 10:48 AM Base Language Feature #2074: add CAN-QUERY() and CAN-SET() support
- The update evl_upd20131009b.zip has been committed in bzr as 10395.
- 10:13 AM Base Language Feature #2074: add CAN-QUERY() and CAN-SET() support
- > 1. Please add javadoc for the name and setter members of LegacyAttribute.java.
>
> 2. Please add javadoc for the... - 08:44 AM Base Language Feature #2074: add CAN-QUERY() and CAN-SET() support
- Eugenie, be aware there is a known case to convert badly in P2J: @h = temp-table tt1:handle@ (getting the handle of a...
- 08:42 AM Base Language Feature #2074: add CAN-QUERY() and CAN-SET() support
- After you have checked in your changes, you can continue the debugging. Since these changes affect so many files, I ...
- 08:39 AM Base Language Feature #2074: add CAN-QUERY() and CAN-SET() support
- Code Review 1009a
1. Please add javadoc for the name and setter members of LegacyAttribute.java.
2. Please add ... - 08:27 AM Base Language Feature #2074: add CAN-QUERY() and CAN-SET() support
- OK, please work your way through the debugging and report your findings here.
> It can be both CAN-SET/CAN-QUERY i... - 08:12 AM Base Language Feature #2074: add CAN-QUERY() and CAN-SET() support
- > There are many deviations. Are these problems with our CAN-SET/CAN-QUERY implementation or is it some other issue?
...
10/08/2013
- 07:19 PM Base Language Feature #1641: implement SAX XML support
- Greg Shah wrote:
> When do you expect to have a first version for review?
First version for review will be availabl... - 05:37 AM Base Language Feature #1641: implement SAX XML support
- When do you expect to have a first version for review?
- 05:52 PM Base Language Feature #2074: add CAN-QUERY() and CAN-SET() support
- > I don't understand what SetExp of yes and no mean.
SetExp is Setter Expected
yes - means the attribute should... - 05:30 PM Base Language Feature #2074: add CAN-QUERY() and CAN-SET() support
- Please do merge and then re-run the tests.
> Also note in INI file some resources has "?" as SetExp value. This m... - 04:31 PM Base Language Feature #2074: add CAN-QUERY() and CAN-SET() support
- The testcases refresh contains change for can_qset_test1.p to be able to run on 4GL Linux/Windows. For some reasons I...
- 02:10 PM Database Feature #2120: add runtime support for dynamically prepared queries
- Don't know why I forgot the SymbolResolver is backed by the SchemaDictionary for temp-table stuff; with this in mind,...
- 01:53 PM Database Feature #2120: add runtime support for dynamically prepared queries
- Interesting results. These are good limitations as they greatly reduce the possible functionality.
> temp-table d... - 01:41 PM Database Feature #2120: add runtime support for dynamically prepared queries
- Some initial thoughts on this: the documentation (and practice) shows that for a prepared query string:
# it follows ... - 08:29 AM Database Feature #2120: add runtime support for dynamically prepared queries
- I wrote:
> optimization of conversion resources into a queued service (i.e., to prevent one instance of SchemaDictio... - 08:57 AM Database Feature #2116: add runtime support for _user metadata table
- >> 2. Why is there a <node class="container" name="bogus"> container in your example directory structure?
>
> Yes, ... - 08:46 AM Database Feature #1651: add support for dynamic database features
- To clarify:
# We are not going to use a binary implementation of TRPL for our first implementation.
# We don't wa... - 08:34 AM Database Feature #1651: add support for dynamic database features
- Note that any use of conversion features at runtime will require the use of existing or new conversion rule-sets and ...
- 05:36 AM Base Language Feature #1646: implement BASE64-ENCODE/BASE64-DECODE built-in functions
- This command can be used to display and change the default JDK:...
- 04:52 AM Database Feature #1654: add conversion and runtime support for dynamic buffer creation and cleanup
- About @CREATE BUFFER@ and implicit resource deletion in general. I've tested using these two programs:
# a program wh... - 02:25 AM Database Feature #1654 (WIP): add conversion and runtime support for dynamic buffer creation and cleanup
10/07/2013
- 06:12 PM Database Feature #1654: add conversion and runtime support for dynamic buffer creation and cleanup
- Stas, while you're in this code, please move all the @public static@ variants of @RecordBuffer.create@ where they bel...
- 02:16 PM Database Feature #1654: add conversion and runtime support for dynamic buffer creation and cleanup
- > Right now I'm trying to figure out how a dynamic buffer should be handled in the scopes outer to the point where th...
- 06:08 PM Base Language Feature #1646: implement BASE64-ENCODE/BASE64-DECODE built-in functions
- I got the compile error after update: Category cannot be resolved or is not a field ...
- 03:44 PM Base Language Feature #1646: implement BASE64-ENCODE/BASE64-DECODE built-in functions
- Please make sure your p2j project is updated to the latest version in bzr. In my version of ErrorManager, the method...
- 03:30 PM Base Language Feature #1646: implement BASE64-ENCODE/BASE64-DECODE built-in functions
- Greg Shah wrote:
..
>
> Have you tried the version as @ErrorManager.recordOrShowError(12119, ERROR_12119, false, ... - 09:17 AM Base Language Feature #1646: implement BASE64-ENCODE/BASE64-DECODE built-in functions
- > what the method BDT.generateUnknown() needed for?
It is used when you have an instance of a BDT and it can be an... - 09:14 AM Base Language Feature #1646: implement BASE64-ENCODE/BASE64-DECODE built-in functions
- Greg Shah wrote:
> Code Review 1003a
..
> 3. As far as I know, @new longchar()@ does already yield an unknown long... - 03:49 PM Database Feature #2116: add runtime support for _user metadata table
- Greg Shah wrote:
> 1. Your "implements UserSecurityOps" needs to be on its own line (in 2 files).
I believe this is... - 01:37 PM Database Feature #2141: generate SQL Server schema
- I guess the 2-character difference in the "usable" portion of the key is attributable to extra overhead caused by the...
- 12:29 PM Database Feature #2141: generate SQL Server schema
- Test: ...
- 09:32 AM Database Feature #2141: generate SQL Server schema
- If I understand correctly, this is good news. I was not aware of this limit in Progress.
Vadim, please put togethe... - 06:59 AM Database Feature #2141: generate SQL Server schema
- It's very possible that I'm misunderstanding the issue, but isn't the MS SQL server limit less restrictive than the c...
- 04:37 AM Database Feature #2141: generate SQL Server schema
- Corrected vmn_upd20131006a and added vmn_upd20131006b with uast (p2j.cfg.xml and all generated ddls).
- 08:25 AM Base Language Feature #2074: add CAN-QUERY() and CAN-SET() support
- > The INI file and captured 4GL log should also be committed in bzr. Correct?
Yes. - 05:25 AM Base Language Feature #1612: finish SESSION system handle support
- Attached testcases for the high-priority attributes/methods.
10/06/2013
- 05:21 PM Database Feature #2141: generate SQL Server schema
- I have attached update vmn_upd20131006a.zip and corresponding tested dll files. Update corresponds to latest bzr revi...
- 04:55 PM Base Language Feature #2074: add CAN-QUERY() and CAN-SET() support
- >... When it is working in the 4GL, go ahead and check it in to the testcases project.
The INI file and captured 4... - 03:35 PM Base Language Feature #2074: add CAN-QUERY() and CAN-SET() support
- Good work. I like the approach. When it is working in the 4GL, go ahead and check it in to the testcases project.
... - 03:29 PM Base Language Feature #2074: add CAN-QUERY() and CAN-SET() support
- The testcases has been added. Consider the test can_qset_test1.p. It takes the data from file, create respective reso...
- 09:52 AM Base Language Feature #1612: finish SESSION system handle support
- The remaining work for this task is not needed until M12 so it has been re-assigned to that milestone. A sub-task to...
- 09:50 AM Base Language Feature #2004 (Closed): runtime support for SESSION handle
10/05/2013
- 09:15 AM Base Language Feature #1612: finish SESSION system handle support
- 1004d.zip was comitted to bzr revision 10394.
10/04/2013
- 06:29 PM Database Feature #2141: generate SQL Server schema
- Eric, Greg,
Yes, this expression is wrong because second parameter in @replace()@ is the substring to be found, not... - 08:34 AM Database Feature #2141: generate SQL Server schema
- > We want to right-trim ANY whitespace character (i.e., '\t', '\n', '\r') which appears after the last non-whitespace...
- 07:45 AM Database Feature #2141: generate SQL Server schema
- Please clarify something for me. I should have asked this earlier, but I just noticed it now:...
- 05:26 AM Database Feature #2141: generate SQL Server schema
- Attached updated ddl files.
- 05:07 AM Database Feature #2141: generate SQL Server schema
- Eric Faulhaber wrote:
> Does this mean a row will not be inserted into the table if it exceeds these limitations of ... - 04:27 PM Database Feature #2116: add runtime support for _user metadata table
- Code Review 1004a
I'm only reviewing the util/ and security/ changes. Eric will handle the persistence stuff (run... - 02:47 PM Database Feature #2116: add runtime support for _user metadata table
- When importing the _User table, the implementation searches for the @_User.d@ and @pwds.txt@ files at the same locati...
- 01:43 PM Database Feature #2116: add runtime support for _user metadata table
- I attached the latest sources. I hope the above note and comments from code will help understand the implementation. ...
- 03:53 PM Base Language Feature #1646: implement BASE64-ENCODE/BASE64-DECODE built-in functions
- Code Review 1003a
1. The SecurityOps.ERROR_12119 and SecurityOps.PAD members need javadoc.
2. There should be... - 03:44 PM Base Language Feature #1646: implement BASE64-ENCODE/BASE64-DECODE built-in functions
- > Progress docs says that '\' is not escape symbol for Progress. It's only escape symbol for Unix and it's a path sep...
- 02:08 PM Base Language Feature #1612: finish SESSION system handle support
- Code Review 1004d
I'm OK with this. Check it in if it passes testing. - 11:54 AM Base Language Feature #1612: finish SESSION system handle support
- > 1. ClientParameters copyright date should be 2013 instead of 2005-2013.
Fixed
>
> 2. The javadoc in ClientParam... - 11:28 AM Base Language Feature #1612: finish SESSION system handle support
- Code Review 1004c
1. ClientParameters copyright date should be 2013 instead of 2005-2013.
2. The javadoc in Cli... - 10:14 AM Base Language Feature #1612: finish SESSION system handle support
- This is built on top of rev 10393 and on top of 1002d. Adds support for these attributes:...
- 09:59 AM Base Language Feature #1612: finish SESSION system handle support
- > If the client is running a GUI driver, it should set the most common value (I'm not sure what it is). We can check...
- 09:28 AM Base Language Feature #1612: finish SESSION system handle support
- > We should relax this, and allow it to be configured via a "client:driver:window-system" setting.
I'm OK with thi... - 09:22 AM Base Language Feature #1612: finish SESSION system handle support
- Greg Shah wrote:
> > from where does the client initially read the WINDOW-SYSTEM value?
>
> At startup, the clie... - 07:40 AM Base Language Feature #1612: finish SESSION system handle support
- This version was committed to bzr revision 10393. Contains a change related to @unknown()@ API which still needs to b...
- 10:13 AM Database Feature #2125: add runtime support for dynamic buffer creation and cleanup
- Stanislav: please double-check the FIRST-BUFFER parameter (I will release an update for it soon), to make sure is imp...
- 07:14 AM User Interface Feature #2191: complete support for determining resource type for BROWSE columns
- The 4GL documentation states that @LegacyResource.BROWSE_COLUMN@ type is used only when "-browcoltype" parameter is u...
- 07:11 AM User Interface Feature #2191 (New): complete support for determining resource type for BROWSE columns
10/03/2013
- 07:43 PM Database Feature #2141: generate SQL Server schema
- Does this mean a row will not be inserted into the table if it exceeds these limitations of the index, or that the in...
- 04:45 PM Database Feature #2141: generate SQL Server schema
- Series of warnings if map to varchar(8000) ...
- 02:37 PM Base Language Feature #1646: implement BASE64-ENCODE/BASE64-DECODE built-in functions
- Here are results of additional testing and the first code for review.
1. Slashes.
Progress docs says that '\' is ... - 11:51 AM Base Language Feature #1612: finish SESSION system handle support
- Code Review 1003c
Really good! The only feedback I have is that I would like you to add a Redmine task to describ... - 10:47 AM Base Language Feature #1612: finish SESSION system handle support
- This is for the LegacyResource and ControlTextWidget related changes (is merged with latest rev, 10392); also, it add...
- 08:54 AM Base Language Feature #2074: add CAN-QUERY() and CAN-SET() support
- Code Review 1003a
I am fine with the code. Please do add the following text to the javadoc for the HandleOps.getL... - 06:48 AM Base Language Feature #2074: add CAN-QUERY() and CAN-SET() support
- > The new question. We have separate interface for frame widget - CommonFrame. This means the similar methods in this...
- 06:44 AM Base Language Feature #2074: add CAN-QUERY() and CAN-SET() support
- The changes look good in 1003a.
About the tests: note that @CREATE VALUE(...)@ can't be used with non-widget reso... - 06:31 AM Base Language Feature #2074: add CAN-QUERY() and CAN-SET() support
- This is the universal testcase from Progress docs(with little modifications and improvement). Possible to check each ...
- 05:48 AM Base Language Feature #2074: add CAN-QUERY() and CAN-SET() support
- > The changes in HandleOps.getLegacyAttribute() look fine. Remember I was mentioning attributes which are read-only f...
- 03:46 AM Base Language Feature #2074: add CAN-QUERY() and CAN-SET() support
- The changes in HandleOps.getLegacyAttribute() look fine. Remember I was mentioning attributes which are read-only for...
10/02/2013
- 07:32 PM Base Language Feature #2074: add CAN-QUERY() and CAN-SET() support
- The second update includes fix for END-ELEMENT method error, some missed attributes/methods additions and rule file f...
- 06:11 PM Base Language Feature #2074: add CAN-QUERY() and CAN-SET() support
- Code Review 1002a
Everything looks OK to me except that the SaxWriter.endElement() methods are marked as END-DOCUM... - 03:50 PM Base Language Feature #2074: add CAN-QUERY() and CAN-SET() support
- Greg Shah wrote:
> > Yes, it's a bug, but it's affects only methods_attributes.rule, changes in the code is not need... - 03:44 PM Base Language Feature #2074: add CAN-QUERY() and CAN-SET() support
- > Yes, it's a bug, but it's affects only methods_attributes.rule, changes in the code is not needed. Do I need to fix...
- 03:43 PM Base Language Feature #2074: add CAN-QUERY() and CAN-SET() support
- Eugenie Lyzenko wrote:
> The question about recent rule changes. According to the methods_attributes.rule the attrib... - 01:43 PM Base Language Feature #2074: add CAN-QUERY() and CAN-SET() support
- This is update for recent code changes and suggested getLegacyAttribute() modification for you to review.
Now I ne... - 01:21 PM Base Language Feature #2074: add CAN-QUERY() and CAN-SET() support
- Evgeny Kiselev: Please respond to the question in note 64.
- 01:20 PM Base Language Feature #2074: add CAN-QUERY() and CAN-SET() support
- The question about recent rule changes. According to the methods_attributes.rule the attribute PUBLIC-ID is rw and ha...
- 07:05 PM Database Feature #2141: generate SQL Server schema
- *About using Hibernate SQL Functions and stored procedures (functions) for new rtrim*.
It is possible Hibernate SQL... - 04:25 PM Base Language Feature #1646: implement BASE64-ENCODE/BASE64-DECODE built-in functions
- > How about "For the source string +\/+\/ in Progress procedure the converted class contains +\\/+\\/ string and I'm ...
- 04:20 PM Base Language Feature #1646: implement BASE64-ENCODE/BASE64-DECODE built-in functions
- Here are some conversion results of other base64 tests.
1. The command @copy-lob from file "/home/vig/testencode" ... - 03:46 PM Base Language Feature #1646: implement BASE64-ENCODE/BASE64-DECODE built-in functions
- 2 remarks:
* How about "For the source string @+\/+\/@ in Progress procedure the converted class contains @+\\/+\\/@... - 02:47 PM Base Language Feature #1646: implement BASE64-ENCODE/BASE64-DECODE built-in functions
- Interesting! And this is great news!
Please put comments in the code to explain that the Apache commons base64 li... - 02:43 PM Base Language Feature #1646: implement BASE64-ENCODE/BASE64-DECODE built-in functions
- I used the old Base64.java class. In company with my check it produces no deviations from Progress behavior on our te...
- 01:36 PM Base Language Feature #1646: implement BASE64-ENCODE/BASE64-DECODE built-in functions
- Before we go too far with the Apache commons base64 support, perhaps it makes sense to try base64 encode/decode that ...
- 01:25 PM Base Language Feature #1646: implement BASE64-ENCODE/BASE64-DECODE built-in functions
- Here are results of testing new base64Decode method with new check.
Behaviour of Base64.decode() method differs from... - 04:08 PM Base Language Feature #1781: add missing support for the WIDGET-HANDLE builtin function
- > (1) I am not sure I completely understand the above,
Sadly, I don't either. I wonder if a "handle value" is jus... - 04:02 PM Base Language Feature #1781: add missing support for the WIDGET-HANDLE builtin function
- Greg Shah wrote:
> > Do we still want the randomized resource IDs?
>
> Yes, I think it still makes sense. We may... - 03:42 PM Base Language Feature #1781: add missing support for the WIDGET-HANDLE builtin function
- I found the following paragraph on the VALID-HANDLE function reference page:
_If a handle is valid, it can still p... - 03:38 PM Base Language Feature #1781: add missing support for the WIDGET-HANDLE builtin function
- > Do we still want the randomized resource IDs?
Yes, I think it still makes sense. We may find some 4GL code that... - 03:28 PM Base Language Feature #1781: add missing support for the WIDGET-HANDLE builtin function
- Greg Shah wrote:
> Also, for security purposes, we should not make the resource ID algorithm a simple sequence. It ... - 03:18 PM Base Language Feature #1781: add missing support for the WIDGET-HANDLE builtin function
- Greg Shah wrote:
> This is a useful set of findings.
>
> Don't forget to test out uninitialized handles and zero ... - 10:46 AM Base Language Feature #1612: finish SESSION system handle support
- > from where does the client initially read the WINDOW-SYSTEM value?
At startup, the client must already know wha... - 10:35 AM Base Language Feature #1612: finish SESSION system handle support
- > 2. Add a redmine task to the UI project to implement the backing support for GET-/SET-WAIT-STATE(). Assign it to m...
- 10:28 AM Base Language Feature #1612: finish SESSION system handle support
- Code Review 1002d
1. LT.getClientType() returns "4GLCLIENT" but the javadoc states it would return "CLIENT" instea... - 10:15 AM Base Language Feature #1612: finish SESSION system handle support
- This update adds runtime for the following:...
- 08:09 AM Base Language Feature #1612: finish SESSION system handle support
- Looking back at my example, I don't think I showed exactly what I was intending to show.
The key point that I reca... - 01:59 AM Base Language Feature #1612: finish SESSION system handle support
- Attached update adds runtime support for these numeric-format related attributes and methods:...
- 10:32 AM User Interface Feature #2189: implement SET-/GET-WAIT-STATE for GUI mode
- Add proper runtime support for the SESSION's SET-/GET-WAIT-STATE methods, in GUI mode.
- 10:31 AM User Interface Feature #2189 (Closed): implement SET-/GET-WAIT-STATE for GUI mode
- 09:29 AM Database Feature #1652: add conversion and runtime support for dynamically prepared temp-tables
- 20131002a changes look good. Please commit and distribute if testing passes.
- 07:46 AM Database Feature #1652: add conversion and runtime support for dynamically prepared temp-tables
- And @get4GLTableName@ functions too.
- 06:56 AM Database Feature #1652: add conversion and runtime support for dynamically prepared temp-tables
- > OK, please run it through another round of regression testing after you've made the above changes. Since they are p...
- 02:10 AM Base Language Bug #2188: fix runtime for SCREEN-VALUE attribute
- From #1612 note 27: @SCREEN-VALUE@ attribute doesn't seem to be fixed properly. See the @GenericFrame.getScreenValue@...
- 02:03 AM Base Language Bug #2188 (New): fix runtime for SCREEN-VALUE attribute
10/01/2013
- 07:33 PM Base Language Feature #1612: finish SESSION system handle support
- Code Review 1001b
I am fine with the changes. It pains me to see how I got the initial group/decimal separator us... - 01:16 PM Base Language Feature #1612: finish SESSION system handle support
- This update is only for SESSION's format-related attributes/methods. I'm putting it through regression testing, but I...
- 11:06 AM Base Language Feature #1612: finish SESSION system handle support
- I've started working on the format-related stuff: @NUMERIC-SEPARATOR, @NUMERIC-DECIMAL-POINT@, @NUMERIC-FORMAT@, and ...
- 06:41 PM Database Feature #2141: generate SQL Server schema
- Eric Faulhaber wrote:
> I'm familiar. It's an absolute necessity to have updated statistics to get the query planner... - 06:22 PM Database Feature #2141: generate SQL Server schema
- Vadim Nebogatov wrote:
> Eric Faulhaber wrote:
> > Vadim Nebogatov wrote:
> > > @[substring(expr, 0, len(replace(e... - 04:17 PM Database Feature #2141: generate SQL Server schema
- Eric Faulhaber wrote:
> Vadim Nebogatov wrote:
> > @[substring(expr, 0, len(replace(expr, CHAR(9)+CHAR(10)+CHAR(13), ... - 06:26 PM Database Feature #1652: add conversion and runtime support for dynamically prepared temp-tables
- OK, please run it through another round of regression testing after you've made the above changes. Since they are pre...
- 05:00 PM Database Feature #1652: add conversion and runtime support for dynamically prepared temp-tables
- > I would like to see your test cases. Are these checked into the testcases project? Please provide a list of names, ...
- 06:08 PM Base Language Feature #2074: add CAN-QUERY() and CAN-SET() support
- >But we need to keep in mind that IIRC there are some attributes which are settable for some resources, and not read-...
- 02:41 PM Base Language Feature #2074: add CAN-QUERY() and CAN-SET() support
- > Your assumption is incorrect. object.getClass().getInterfaces() will always return the directly implemented interfa...
- 02:23 PM Base Language Feature #2074: add CAN-QUERY() and CAN-SET() support
- > Does not the call @objFromHandle.getClass().getInterfaces()@ retrieve ALL interfaces implementing in the current cl...
- 02:08 PM Base Language Feature #2074: add CAN-QUERY() and CAN-SET() support
- > Eugenie: there are some cases when the interface defining the resource is not directly implemented by the P2J class...
- 06:05 PM Base Language Feature #1781: add missing support for the WIDGET-HANDLE builtin function
- Also, for security purposes, we should not make the resource ID algorithm a simple sequence. It should be randomized...
- 06:03 PM Base Language Feature #1781: add missing support for the WIDGET-HANDLE builtin function
- This is a useful set of findings.
Don't forget to test out uninitialized handles and zero handles compared to hand... - 05:59 PM Base Language Feature #1781: add missing support for the WIDGET-HANDLE builtin function
- Ad 2
handle method is already recognized and parsed. Only emitting of handle.toString seems to be missing.
Ad 3
... - 03:10 PM Base Language Feature #1646: implement BASE64-ENCODE/BASE64-DECODE built-in functions
- Good work! Make sure that the javadoc for the method has this algorithm included.
- 02:40 PM Base Language Feature #1646: implement BASE64-ENCODE/BASE64-DECODE built-in functions
- Here is an updated full set of tests for base64-decode function:...
- 02:32 PM Base Language Feature #1646: implement BASE64-ENCODE/BASE64-DECODE built-in functions
- I added more tests and find out several things:
1. Source string can contain any number of pad symbols ('=') at the e... - 08:33 AM Database Feature #2116: add runtime support for _user metadata table
- The implementation I am debugging now works like this:
* I added a new type of authentication (@AUTH_MODE_METADATA =... - 08:10 AM Database Feature #2116: add runtime support for _user metadata table
- > If for one of the databases the authentication fails all three times, the client process is closed, even if for a p...
- 08:08 AM Database Feature #2116: add runtime support for _user metadata table
- I'm moving this discussion here from email, because it is important to record it as part of the task.
-------- Ori...
09/30/2013
- 05:14 PM Database Feature #2141: generate SQL Server schema
- Vadim Nebogatov wrote:
> @[substring(expr, 0, len(replace(expr, CHAR(9)+CHAR(10)+CHAR(13), ' ')))]@
I appreciate ... - 05:06 PM Database Feature #2141: generate SQL Server schema
- Vadim Nebogatov wrote:
> It seems it is a problem in MSSQL: varchar(MAX) cannot be used in indexes.
[...]
OK, le... - 04:54 PM Database Feature #2141: generate SQL Server schema
- Or even simpler:...
- 04:47 PM Database Feature #2141: generate SQL Server schema
- Eric Faulhaber wrote:
> My only other concern is the rtrim function. The SQL Server version simply doesn't do what w... - 04:14 PM Database Feature #2141: generate SQL Server schema
- varchar is equivalent to varchar(1)
- 08:34 AM Database Feature #2141: generate SQL Server schema
- And N=8000 is restriction for varchar(N) . BTW @varchar(MAX)@ in MSSQL - special type name.
- 08:32 AM Database Feature #2141: generate SQL Server schema
- It seems it is a problem in MSSQL: varchar(MAX) cannot be used in indexes. The maximum amount of bytes on a index is ...
- 08:19 AM Database Feature #2141: generate SQL Server schema
- > Greg: what was the rule again? AFAIR, the whole record can be no larger than 32K, but any individual field can clai...
- 07:21 AM Database Feature #2141: generate SQL Server schema
- and to varbinary(MAX). BTW SQLServer2005Dialect also maps to these types when size is not known....
- 07:16 AM Database Feature #2141: generate SQL Server schema
- Eric Faulhaber wrote:
> But I think 4GL @character@ fields can be larger than 8,000.
>
> Greg: what was the rule ... - 07:03 AM Database Feature #2141: generate SQL Server schema
- But I think 4GL @character@ fields can be larger than 8,000.
Greg: what was the rule again? AFAIR, the whole recor... - 06:44 AM Database Feature #2141: generate SQL Server schema
- Eric Faulhaber wrote:
> Where did the choice of 8,000 as a limit come from?
It is private constant from SQLServer2005... - 03:48 PM Base Language Feature #1646: implement BASE64-ENCODE/BASE64-DECODE built-in functions
- Great work! Hopefully you will find the final part of the rule soon.
- 03:22 PM Base Language Feature #1646: implement BASE64-ENCODE/BASE64-DECODE built-in functions
- I added more tests, as you adviced. Here is a results....
- 01:12 PM Database Feature #2116: add runtime support for _user metadata table
- Yes, the above directory paths are relative, not absolute. The question was: should I add p2j-user collections with (...
- 01:04 PM Database Feature #2116: add runtime support for _user metadata table
- ...
- 12:55 PM Database Feature #2116: add runtime support for _user metadata table
- Progress client allows multiple database connection at startup, the following command line is correct:...
- 12:47 PM Database Feature #1652: add conversion and runtime support for dynamically prepared temp-tables
- OK, let's leave the synchronization as is.
Code review 20130924a:
Wow, this is an exciting update and a hugely ... - 09:13 AM Base Language Feature #1640 (Closed): implement DOM XML support
- 09:01 AM Base Language Feature #1640: implement DOM XML support
- Committed to bzr revision 10390
- 03:11 AM Base Language Feature #1640: implement DOM XML support
- I've taken a look at the 20130926 and 20103929 harness results in your folder and I think we can say that testing has...
- 09:09 PM Base Language Feature #1640: implement DOM XML support
- Regression testing for evk_20130923a.zip is finished (20130926_220122):
There are some errors with @timeout errors@ ... - 09:12 AM Base Language Feature #1980 (Closed): runtime support for DOM XML processing
- 02:55 AM Base Language Feature #2074: add CAN-QUERY() and CAN-SET() support
- Eugenie: there are some cases when the interface defining the resource is not directly implemented by the P2J class, ...
09/29/2013
- 05:50 PM Database Feature #2141: generate SQL Server schema
- The output looks good. I would like to review the code. Please upload an update when ready.
Where did the choice o... - 05:14 PM Database Feature #2141: generate SQL Server schema
- Attached updated and tested dll files for sql server 2012.
I have added private constant from 2005 dialect...
09/27/2013
- 06:34 PM Database Feature #2141: generate SQL Server schema
- Eric Faulhaber wrote:
> Is it necessary to create the placeholder computed columns in the CREATE TABLE statements, if... - 03:54 PM Database Feature #2141: generate SQL Server schema
- Is it necessary to create the placeholder computed columns in the CREATE TABLE statements, if we are just going to dr...
- 03:45 PM Database Feature #2141: generate SQL Server schema
- Sequences seems implemented, I have attached ddl files for sql server 2012.
Both are tested on sql server 2012.
- 03:41 PM Database Feature #2141: generate SQL Server schema
- Eric Faulhaber wrote:
> It seems like these methods would be necessary at runtime. Are any of them necessary for the... - 02:30 PM Database Feature #2141: generate SQL Server schema
- It seems like these methods would be necessary at runtime. Are any of them necessary for the generation of a feature-...
- 01:09 PM Database Feature #2141: generate SQL Server schema
- TODO after sequences:
isQueryRangeParameterInlined(),
inlineLimit(),
requiresExplicitCastInsideTernary,
use... - 09:54 AM Database Feature #2141: generate SQL Server schema
- Please prioritize finishing support for 2012 over 2008. Hopefully, getting sequences to emit in the DDL is easier for...
- 05:03 AM Database Feature #2141: generate SQL Server schema
- Created 2 different targetDb: mssql2008 and mssql2012.
schema_table_p2j_test_mssql2008.sql, schema_index_p2j_test_ms... - 05:15 PM Base Language Feature #1646: implement BASE64-ENCODE/BASE64-DECODE built-in functions
- > 1. Am I on the right way or I didn't understood your last comment?
Yes.
> 2. Is the simple rule suits to the ... - 04:30 PM Base Language Feature #1646: implement BASE64-ENCODE/BASE64-DECODE built-in functions
- The error is not displayed when NO-ERROR is specified. error-status:error is not set. only error-status:get-number(1)...
- 02:37 PM Database Feature #2156: datetime-tz and hibernate
- h3. Record of e-mail discussion
Eric,
If I remember correctly, I already managed to get DDLs well generated, so... - 08:34 AM Base Language Feature #1607 (Closed): implement full named events support
- 04:09 AM Base Language Feature #1607: implement full named events support
- ca_upd20130926d.zip was committed to revision 10388.
- 08:33 AM Base Language Feature #1977 (Closed): implement the runtime support for named events
- 08:25 AM Base Language Feature #1612: finish SESSION system handle support
- Good job. This makes sense and it results in a cleaner, more understandable set of frame definitions.
- 08:00 AM Base Language Feature #1612: finish SESSION system handle support
- I think I've got it how 4GL interprets string literals in DISPLAY and FORM statements. See this test:...
- 05:44 AM Base Language Feature #1612: finish SESSION system handle support
- > Is this just a quirk of Progress? In the DISPLAY case, can you actually use the field for editing? There is no lv...
- 06:19 AM Base Language Feature #1584: add conversion and runtime support for INT64 and DATETIME data types
- Conversion test ended with success.
Committed revision 10389 and distributed by mail. - 05:22 AM Base Language Feature #2013: implement the SELF system handle
- @NullWidget@ usage should be removed and SELF handle (for widgets) tested carefully - see notes 21/22 in #1612.
- 05:22 AM User Interface Feature #1779: complete FOCUS handle support
- @NullWidget@ usage should be removed and FOCUS handle tested carefully - see notes 21/22 in #1612, as FOCUS handle ha...
09/26/2013
- 04:29 PM Base Language Feature #1646: implement BASE64-ENCODE/BASE64-DECODE built-in functions
- > I did it. It don't change the ERROR-STATUS:ERROR handle. It remains false. However it add the error number 12119. I...
- 04:04 PM Base Language Feature #1646: implement BASE64-ENCODE/BASE64-DECODE built-in functions
- Greg Shah wrote:
> I assume the error is occurring in the decode function but it is important to confirm that. Just... - 01:22 PM Base Language Feature #1646: implement BASE64-ENCODE/BASE64-DECODE built-in functions
- I assume the error is occurring in the decode function but it is important to confirm that. Just put a "pause." into...
- 01:05 PM Base Language Feature #1646: implement BASE64-ENCODE/BASE64-DECODE built-in functions
- Question 2. I converted and ran test 2. Recalling, that it is the same test as 1 but with wrong "base64" string "abra...
- 12:21 PM Base Language Feature #1646: implement BASE64-ENCODE/BASE64-DECODE built-in functions
- The null check is just for safety purposes. It should never get used by converted code that was automatically genera...
- 12:13 PM Base Language Feature #1646: implement BASE64-ENCODE/BASE64-DECODE built-in functions
- I have a question. Lets see at the method com.goldencode.p2j.util.SecurityOps.base64Encode(BinaryData). There is a nu...
- 10:46 AM Base Language Feature #1646: implement BASE64-ENCODE/BASE64-DECODE built-in functions
- I'm not exactly sure what you mean by this question. But I suggest you try this code to see how multiple message stm...
- 10:43 AM Base Language Feature #1646: implement BASE64-ENCODE/BASE64-DECODE built-in functions
- Thank you, but will the MESSAGE command override it's previous output?
- 10:41 AM Base Language Feature #1646: implement BASE64-ENCODE/BASE64-DECODE built-in functions
- OK, good. One thing to change: don't use DISPLAY for just printing a line of text. It creates an entire frame which...
- 10:35 AM Base Language Feature #1646: implement BASE64-ENCODE/BASE64-DECODE built-in functions
- You're right. My mistake.
Here is updated error test.... - 04:01 PM Database Feature #2141: generate SQL Server schema
- No, there is no need to set the precision differently by conversion project. The value of 50 was chosen to match Prog...
- 01:09 AM Database Feature #2141: generate SQL Server schema
- So, precision could be set as @dialect && conversion specific@ in p2j.cfg.xml:...
- 02:48 PM Database Feature #2116: add runtime support for _user metadata table
- > So each user/group defined in directory.xml can have a [user/password] combination that will be used like -U -P par...
- 02:10 PM Database Feature #2116: add runtime support for _user metadata table
- Greg Shah wrote:
> > _Should we emulate these parameters by adding equivalent items in the directory?
>
> Yes, t... - 11:45 AM Database Feature #2116: add runtime support for _user metadata table
- I don't see any difference between the behaviors of @pro@ and @mpro@ executables.
I looked into launch scripts and ... - 02:08 PM Base Language Feature #1584: add conversion and runtime support for INT64 and DATETIME data types
- Just noticed that Constantin has committed some changes in the same file, in a very close area (consecutive line numb...
- 12:42 PM Base Language Feature #1584: add conversion and runtime support for INT64 and DATETIME data types
- Good. You can check it in and distribute it.
- 12:38 PM Base Language Feature #1584: add conversion and runtime support for INT64 and DATETIME data types
- The attached update passed the conversion test (no differences detected for both src and ddl). There is no need for r...
- 01:37 PM Base Language Feature #1612: finish SESSION system handle support
- OK, I'm fine with your approach to all of this. Make some notes in #1779 (FOCUS) and also #2015 (SELF), so that we d...
- 01:25 PM Base Language Feature #1612: finish SESSION system handle support
- > > But, there are widgets implementations (like ControlTextWidget and BrowseColumnWidget classes) which can represen...
- 12:18 PM Base Language Feature #1612: finish SESSION system handle support
- > for widgets, the resource type can't be set at the interface, because they all grow from CommonWidget. In this case...
- 11:50 AM Base Language Feature #1612: finish SESSION system handle support
- There are some more issues:
# for widgets, the resource type can't be set at the interface, because they all grow fr... - 10:09 AM Base Language Feature #1612: finish SESSION system handle support
- I like it. Two things:
1.
> system handle implementations (like SessionUtils.getResourceType()) still need to ... - 10:02 AM Base Language Feature #1612: finish SESSION system handle support
- > Can we change the getResourceType() implementation to use the LegacyResource annotation as its source of TYPE info?...
- 09:50 AM Base Language Feature #1612: finish SESSION system handle support
- > To solve this, we could have a LegacyResource annotation to annotate the interface associated with the resource def...
- 09:43 AM Base Language Feature #1612: finish SESSION system handle support
- I've been looking at the FIRST-QUERY attribute, and I think we need to change something in the FIRST/LAST-resource im...
- 08:23 AM Base Language Feature #1612: finish SESSION system handle support
- For now, just implement it in the runtime section of the directory. Use the Directory interface with ID_RELATIVE whi...
- 06:46 AM Base Language Feature #1612: finish SESSION system handle support
- Greg, how do you suggest to implement the @PARAMETER@ attribute? The @SESSION:PARAMETER@ attribute holds the value of...
- 05:46 AM Base Language Feature #1612: finish SESSION system handle support
- Following attributes will be added first
* client-type
* parameter
* first-buffer - 01:33 PM Database Feature #1652: add conversion and runtime support for dynamically prepared temp-tables
- > * Also in @MutableSessionFactoryImpl@, there are several TODOs. What needs to be done for these, and what is the im...
- 01:31 PM Base Language Feature #1607: implement full named events support
- The runtime testing seems OK, but I want to do another run, to clean some failures.
- 09:47 AM Base Language Feature #1607: implement full named events support
- Attached version contains the comment changes at note 29. Runtime testing is still in progress - conversion testing h...
- 08:31 AM Base Language Feature #1607: implement full named events support
- Code Review 0926b
I'm fine with the code. Before checking in, please make these comment changes:
1. This comm... - 04:47 AM Base Language Feature #1607: implement full named events support
- Attached update is going through regression testing now.
Beside other fixes, I've renamed PersistentProc to Proce... - 04:48 AM Base Language Feature #1977 (Review): implement the runtime support for named events
- 04:03 AM Base Language Feature #2004 (WIP): runtime support for SESSION handle
09/25/2013
- 07:35 PM Database Feature #2116: add runtime support for _user metadata table
- I will let Eric reply in regard to the code. I will try to answer some questions.
> _Should we emulate these para... - 02:26 PM Database Feature #2116: add runtime support for _user metadata table
- Are these results based on using a single-user (pro) or multi-user (mpro) database process?
- 01:17 PM Database Feature #2116: add runtime support for _user metadata table
- The P2J "permanent databases" concept seems like starting the the Progress client with database location as startup p...
- 07:12 PM Base Language Feature #1646: implement BASE64-ENCODE/BASE64-DECODE built-in functions
- > returns empty file
Instead of using copy-lob in these cases, it is cleaner to just check if the length/size of ... - 04:53 PM Base Language Feature #1646: implement BASE64-ENCODE/BASE64-DECODE built-in functions
- Greg Shah wrote:
> Also: please add a testcase showing how these functions respond to the following:
>
> # unknow... - 02:23 PM Base Language Feature #1646: implement BASE64-ENCODE/BASE64-DECODE built-in functions
- > Should I only check and probably test them?
You can check them, but I can guarantee that they don't properly imp... - 02:15 PM Base Language Feature #1646: implement BASE64-ENCODE/BASE64-DECODE built-in functions
- Here is additional testing.
6. Empty input.... - 09:52 AM Base Language Feature #1646: implement BASE64-ENCODE/BASE64-DECODE built-in functions
- To be clear: memptr and raw are BaseDataTypes that can be compared for equality, inequality, less than...
- 09:51 AM Base Language Feature #1646: implement BASE64-ENCODE/BASE64-DECODE built-in functions
- See BinaryData.compareTo() and CompareOps.equals(BDT, BDT).
- 09:48 AM Base Language Feature #1646: implement BASE64-ENCODE/BASE64-DECODE built-in functions
- Greg Shah wrote:
> ..
> Create a test like number 1 above, but first do the encode on a text string and then decode... - 07:07 PM Database Feature #2141: generate SQL Server schema
- Eric Faulhaber wrote:
> Vadim Nebogatov wrote:
> > [...]
> > P2J sets precision, scale in hibernate.xml. Workarou... - 06:38 PM Database Feature #2141: generate SQL Server schema
- Eric Faulhaber wrote:
> Ah, TRPL cannot deal with static references. What error messages do you get?
>
> Try:
> ... - 03:35 PM Database Feature #2141: generate SQL Server schema
- Ah, TRPL cannot deal with static references. What error messages do you get?
Try:... - 03:19 PM Database Feature #2141: generate SQL Server schema
- Eric Faulhaber wrote:
> Vadim Nebogatov wrote:
> > If "if exists" is not important we could avoid it on schema export... - 11:42 AM Database Feature #2141: generate SQL Server schema
- Vadim Nebogatov wrote:
> [...]
> P2J sets precision, scale in hibernate.xml. Workaround for MSSQL is using in P2J... - 11:28 AM Database Feature #2141: generate SQL Server schema
- Vadim Nebogatov wrote:
> If "if exists" is not important we could avoid it on schema export using in generate_ddl.xm... - 05:34 PM Database Feature #2122 (Review): add runtime support for dynamically prepared temp-tables
- 05:34 PM Database Feature #2128 (Review): generate and load DMO interface and implementation classes for dynamic te...
- 05:31 PM Database Bug #2164 (Closed): Server fails to start a Progress app when persistence disabled
- 05:23 PM Database Bug #2164: Server fails to start a Progress app when persistence disabled
- Committed revision 10387.
- 04:48 PM Database Feature #1652: add conversion and runtime support for dynamically prepared temp-tables
- Eric Faulhaber wrote:
> Code review 20130924b:
> * Please add a simple javadoc comment for the @MutableSessionFacto... - 04:45 PM Database Feature #1652: add conversion and runtime support for dynamically prepared temp-tables
- Code review 20130924b:
* Please add a simple javadoc comment for the @MutableSessionFactoryImpl@ constructor, and ad... - 02:36 PM Database Feature #1652: add conversion and runtime support for dynamically prepared temp-tables
- Have you run this update through regression testing yet? If not, please do. I will review in parallel, but I don't wa...
- 11:48 AM Base Language Feature #1607: implement full named events support
- > In ProcedureManager, all procedures are saved in the ppMap and deleted, via WorkArea's Scopeable implementation. If...
- 11:15 AM Base Language Feature #1607: implement full named events support
- > 1. Why are only persistent procedures checked for subscriptions? The ProcedureManager code uses PersistentProc and...
- 11:09 AM Base Language Feature #1607: implement full named events support
- Code Review 0925a
1. Why are only persistent procedures checked for subscriptions? The ProcedureManager code uses... - 10:46 AM Base Language Feature #1607: implement full named events support
- Greg Shah wrote:
> > When the procedure code is executed, the NO-ERROR clause doesn't look like is in effect any mor... - 10:44 AM Base Language Feature #1607: implement full named events support
- > When the procedure code is executed, the NO-ERROR clause doesn't look like is in effect any more, as the ERROR cond...
- 10:36 AM Base Language Feature #1607: implement full named events support
- A first version of the runtime for named events. I've also added support for the PUBLISHED-EVENTS attribute for proce...
- 09:08 AM Base Language Feature #1607: implement full named events support
- It seems that every new feature, even straightforward ones, will always have some significant divergence from the Pro...
- 08:19 AM Base Language Feature #1607: implement full named events support
- The publish/subscribe/unsubscribe rules from the documentation are simple, but practice proves to be more complex.
... - 09:25 AM Base Language Feature #1584: add conversion and runtime support for INT64 and DATETIME data types
- My intention was to identify nodes of this type: @(E)@, ie. an expression formed by another one (@E@) between unneede...
- 09:13 AM Base Language Feature #1584: add conversion and runtime support for INT64 and DATETIME data types
- I'm fine with the change. My only question: what is the purpose of the @nodeRef.numImmediateChildren == 1@ test as p...
- 08:55 AM Base Language Feature #1584: add conversion and runtime support for INT64 and DATETIME data types
- Fixed issue by moving 'chp_wrapper' annotation to first operator in if it is enclosed into one or more superfluous pa...
- 07:56 AM Base Language Feature #1640: implement DOM XML support
- I want to clarify something. Phase 2 (build) and 3 (runtime-regression) of your list above are needed. Phase 4 (ful...
- 01:41 AM Base Language Feature #1640: implement DOM XML support
- > How long is "normal" time for regression test running ?
Depending on which task you are running, the times are the... - 09:33 PM Base Language Feature #1640: implement DOM XML support
- Constantin Asofiei wrote:
> Next step is to run regression testing; let me know if you encounter any problems.
I'...
09/24/2013
- 06:36 PM Database Feature #2141: generate SQL Server schema
- As I understood Hibernate doesn't worry about real column precision in table and takes column
precision from htm fi... - 05:42 PM Database Feature #1652: add conversion and runtime support for dynamically prepared temp-tables
- Hibernate part.
- 09:14 AM Database Feature #1652: add conversion and runtime support for dynamically prepared temp-tables
- Update with runtime support for dynamic tables except MetaSchema and COPY-TEMP-TABLE.
- 04:43 PM Base Language Feature #1646: implement BASE64-ENCODE/BASE64-DECODE built-in functions
- > Can't read data from source file and shows error: "Error -26 in file to longchar". Strange error. It looks like a b...
- 04:08 PM Base Language Feature #1646: implement BASE64-ENCODE/BASE64-DECODE built-in functions
- base64-decode(expr) - where expr - character or longchar. Resulting MEMPTR contains binary data
base64-encode(expr) ... - 04:37 PM Base Language Feature #1631: implement support for LANDSCAPE/PORTRAIT in I/O statements
- It looks good. Thanks!
- 04:23 PM Base Language Feature #1631: implement support for LANDSCAPE/PORTRAIT in I/O statements
- Sure, I understand an importance of such rules. I just wanted to make a final step to remember goals of that rules. I...
- 11:08 AM Base Language Feature #1631: implement support for LANDSCAPE/PORTRAIT in I/O statements
- OK, this is fine.
> In addition, please apply the same cleanup items I mentioned in note 67 above to the PrinterSt... - 08:58 AM Base Language Feature #1631: implement support for LANDSCAPE/PORTRAIT in I/O statements
- I corrected progress.g and PrinterStream
- 02:36 PM Base Language Feature #2041: implement runtime support for "shared" attributes that are just stubbed
- Greg Shah wrote:
> It looks like we have a PRIVATE-DATA implementation in both BaseEntity and QueryWrapper that need... - 02:06 PM Base Language Feature #2041: implement runtime support for "shared" attributes that are just stubbed
- It looks like we have a PRIVATE-DATA implementation in both BaseEntity and QueryWrapper that needs to be deleted. Bo...
- 01:22 PM Base Language Feature #2041: implement runtime support for "shared" attributes that are just stubbed
- Implemented by some resources:
- local-name: x-noderef (pending to be released), soap-header-entryref
- namespace-u... - 11:44 AM Base Language Feature #2041: implement runtime support for "shared" attributes that are just stubbed
- Constantin: I have looked at #2002 to see the runtime implementation status of these attributes. It is not clear fro...
- 02:10 PM User Interface Feature #2185: ROW attribute error handling is incomplete
- The setter for ROW (BaseEntity.setRow()) has this todo:...
- 02:08 PM User Interface Feature #2185 (New): ROW attribute error handling is incomplete
- 01:11 PM Base Language Feature #1584: add conversion and runtime support for INT64 and DATETIME data types
- Seems like the wrapping annotation is put on the wrong node that is later removed.
I will dig into this tomorrow in ... - 12:50 PM Base Language Feature #1584: add conversion and runtime support for INT64 and DATETIME data types
- Ovidiu, name_map.xml was removed before the build. Anyway, I've isolate the problem to calls like:...
- 12:40 PM Base Language Feature #1584: add conversion and runtime support for INT64 and DATETIME data types
- Constantin,
please remove the xml that caches the functions signature.
You probably had an f1 function with int64 ... - 12:32 PM Base Language Feature #1584: add conversion and runtime support for INT64 and DATETIME data types
- Greg/Ovidiu,
With revision 10385, there is a case which doesn't convert properly. It looks something like this:
<... - 08:19 AM Base Language Feature #1977 (WIP): implement the runtime support for named events
- 08:34 PM Database Bug #2164: Server fails to start a Progress app when persistence disabled
- The update looks good to me. Please commit and distribute it, and record the revision number here.
09/23/2013
- 05:38 PM Base Language Feature #1631: implement support for LANDSCAPE/PORTRAIT in I/O statements
- Oops. I spoke too soon. Your P2J build is not clean:
antlr_progress:
[antlr] ANTLR Parser Generator Versi... - 05:13 PM Base Language Feature #1631: implement support for LANDSCAPE/PORTRAIT in I/O statements
- OK, this is ready for testing.
- 04:38 PM Base Language Feature #1631: implement support for LANDSCAPE/PORTRAIT in I/O statements
- I made described corrections
- 03:37 PM Base Language Feature #1631: implement support for LANDSCAPE/PORTRAIT in I/O statements
- Code Review 0923b
OK. Functionally the code is good. The last issues are about the code formatting/naming...
... - 01:26 PM Base Language Feature #1631: implement support for LANDSCAPE/PORTRAIT in I/O statements
- corrected archive
- 12:24 PM Base Language Feature #1631: implement support for LANDSCAPE/PORTRAIT in I/O statements
- Then just do the call to SD.store() from inside PrinterStream.createPrinterStream(). Hiding the printer-specific stu...
- 12:18 PM Base Language Feature #1631: implement support for LANDSCAPE/PORTRAIT in I/O statements
- Greg Shah wrote:
> Code Review 0923a
>
> 1. There is no PrinterStream class in this update. I think you accident... - 11:15 AM Base Language Feature #1631: implement support for LANDSCAPE/PORTRAIT in I/O statements
- Code Review 0923a
1. There is no PrinterStream class in this update. I think you accidentally included ProcessStr... - 09:22 AM Base Language Feature #1631: implement support for LANDSCAPE/PORTRAIT in I/O statements
- Next update
- 05:18 PM Database Feature #2141: generate SQL Server schema
- Eric Faulhaber wrote:
> The @if exists@ prefix is a nice safety feature, but in practice we rarely will run the DDL ... - 02:27 AM Base Language Feature #1640: implement DOM XML support
- Evgeny: the attached version contains just some format related changes, plus I've removed the @XEntity[Impl].getHandl...
- 11:05 PM Base Language Feature #1640: implement DOM XML support
- last update for regression testing. merged with 10385 revision
09/22/2013
- 04:32 PM Database Feature #2141: generate SQL Server schema
- Eric Faulhaber wrote:
> Does this come into play anywhere other than in generate_ddl.xml?
Hibernate has only two usa...
09/21/2013
- 12:02 PM Database Feature #2141: generate SQL Server schema
- Does this come into play anywhere other than in generate_ddl.xml? The @if exists@ prefix is a nice safety feature, bu...
09/20/2013
- 07:59 PM Database Bug #2164: Server fails to start a Progress app when persistence disabled
- The changes passed regression test, see shared\clients\timco\majic_test_results\10382_9c2ae9a_20130920_hc.zip.
Fixed... - 05:12 PM Base Language Feature #1631: implement support for LANDSCAPE/PORTRAIT in I/O statements
- Code Review 0918b
1. The name of this update should have been vig_upd20130920a.zip since you completed your change... - 04:21 PM Base Language Feature #1631: implement support for LANDSCAPE/PORTRAIT in I/O statements
- I'm uploading next update. I made described corrections.
About slashes, it seems that Progress removes it itself. I ... - 04:04 PM Database Feature #2141: generate SQL Server schema
- Another problem I have found out that for MS SQL Server both supportsIfExistsBeforeTableName() and supportsIfExistsAf...
- 03:57 PM Database Feature #2141: generate SQL Server schema
- Yes, I also already understood that it does not depend on dialect.
- 03:54 PM Database Feature #2141: generate SQL Server schema
- Vadim Nebogatov wrote:
> 11. Table creation
>
> Maximum MS SQL Server NUMERIC column precision is 38.
The more y... - 04:19 AM Database Feature #2141: generate SQL Server schema
- I have added item 11 about table creation to note 11.
- 03:07 PM Database Feature #2137 (New): runtime support for FIELDS/EXCEPT record phrase options
- This feature is an optimization, but is not necessary for the runtime to function properly. Moving target version acc...
- 03:03 PM Database Feature #1580 (Closed): upgrade Hibernate to latest level
- 07:13 AM Database Feature #1580: upgrade Hibernate to latest level
- I've uploaded original Hibernate sources to @shared/projects/p2j/hibernate/hibernate-4.1.8.Final-original.zip@ and th...
- 01:22 PM Base Language Feature #1621 (Closed): implement dynamic/unspecified EXTENT support
- 01:02 PM Base Language Feature #1621: implement dynamic/unspecified EXTENT support
- Yes, it can be closed.
- 09:50 AM Base Language Feature #1621: implement dynamic/unspecified EXTENT support
- This can be closed, right?
- 09:53 AM Base Language Feature #1640: implement DOM XML support
- Evgeny: please merge your code with latest revision 10385. This is the version that needs final review and full regr...
- 08:53 AM Base Language Feature #1640: implement DOM XML support
- > The changes are good. The changes are probably safe enough to avoid separate regression testing. What do you thin...
- 08:22 AM Base Language Feature #1640: implement DOM XML support
- Code Review ca_upd20130920b.zip
The changes are good. The changes are probably safe enough to avoid separate regr... - 05:14 AM Base Language Feature #1640: implement DOM XML support
- This update solves the ErrorManager.recordOrShowError, when the "isError" flag is false and the NO-ERROR clause is pr...
- 09:18 AM Base Language Feature #1792 (Closed): implement widget-pool support
- 09:16 AM Base Language Feature #1792: implement widget-pool support
- ca_upd20130920c.zip was committed to bzr revision 10385.
Final Notes:
1. A bug was fixed for CREATE BUFFER ... IN... - 08:53 AM Base Language Feature #1792: implement widget-pool support
- The changes are really good. The class javadoc improvements are excellent!
> The exception is thrown because this... - 04:32 AM Base Language Feature #1792: implement widget-pool support
- > 1. Why throw IllegalStateException in WidgetPool.addResource()?
The exception is thrown because this method must a... - 09:17 AM Base Language Feature #1983 (Closed): runtime support for widget pools
- 04:33 AM Base Language Feature #1983 (Review): runtime support for widget pools
09/19/2013
- 02:55 PM Base Language Feature #1792: implement widget-pool support
- Code Review 0919a
Overall, it looks very good.
1. Why throw IllegalStateException in WidgetPool.addResource()?
... - 12:53 PM Base Language Feature #1792: implement widget-pool support
- The attached update adds runtime support for widget pools. Still need to perform regression testing on it.
- 01:48 PM Database Feature #2116: add runtime support for _user metadata table
- Ovidiu Maxiniuc wrote:
> I altered the conversion so that the _user AST is copied from meta to each processed databa... - 01:37 PM Database Feature #2116: add runtime support for _user metadata table
- I altered the conversion so that the _user AST is copied from meta to each processed database if configured in p2j.cf...
- 01:37 PM Database Feature #2175 (Closed): add support for -rereadnolock startup parameter
- 03:56 AM Database Feature #2175: add support for -rereadnolock startup parameter
- The update "om_upd20130912e.zip":https://proj.goldencode.com/redmine/attachments/1285/om_upd20130912e.zip added in #1...
- 01:36 PM Database Feature #1594 (Closed): add conversion and runtime support for CURRENT-CHANGED() built-in function
- 03:39 AM Database Feature #1594: add conversion and runtime support for CURRENT-CHANGED() built-in function
- The update was committed to bzr as revision 10381 and distributed by email.
- 09:34 AM Base Language Feature #2074: add CAN-QUERY() and CAN-SET() support
- The changes look good. When you get back, you can merge up with the latest code, implement the DOM/SAX attributes/me...
- 08:00 PM Base Language Feature #2074: add CAN-QUERY() and CAN-SET() support
- This update with new 6 getters in CommonSession class. The static classes SessionUtils, NumberType, ProcedureManager ...
- 09:09 AM Base Language Feature #1638 (Closed): implement Java access to converted appserver code (must be a simple repla...
- 07:53 AM Base Language Feature #1638: implement Java access to converted appserver code (must be a simple replacement fo...
- At this time, no.
- 02:03 AM Base Language Feature #1640: implement DOM XML support
- Evgeny, please merge your @handle.java@ file, discard the @ErrorManager@ changes you made and put the update through ...
09/18/2013
- 07:09 PM Base Language Feature #1781 (WIP): add missing support for the WIDGET-HANDLE builtin function
- 07:05 PM Base Language Feature #2074: add CAN-QUERY() and CAN-SET() support
- OK, I think I understand now. If we have the backing implementations for the missing attributes, please do add the 6...
- 07:01 PM Base Language Feature #2074: add CAN-QUERY() and CAN-SET() support
- > Are they defined in some other interface?
The following attributes are not defined at all:
FIRST-SERVER r
LAST... - 06:51 PM Base Language Feature #2074: add CAN-QUERY() and CAN-SET() support
- Are they defined in some other interface?
- 06:50 PM Base Language Feature #2074: add CAN-QUERY() and CAN-SET() support
- > I assume you still have these attributes annotated in their CommonSession interface?
No, there are no such attri... - 06:40 PM Base Language Feature #2074: add CAN-QUERY() and CAN-SET() support
- I assume you still have these attributes annotated in their CommonSession interface?
- 06:35 PM Base Language Feature #2074: add CAN-QUERY() and CAN-SET() support
- > These 3 classes are statically implementing the proxy defined by the CommonSession interface - so you are correct, ...
- 04:24 PM Base Language Feature #2074: add CAN-QUERY() and CAN-SET() support
- Eugenie Lyzenko wrote:
> > NumberType shouldn't have been annotated. The proper interface for the SESSION resource i... - 04:05 PM Base Language Feature #2074: add CAN-QUERY() and CAN-SET() support
- > NumberType shouldn't have been annotated. The proper interface for the SESSION resource is the CommonSession interf...
- 03:46 PM Base Language Feature #2074: add CAN-QUERY() and CAN-SET() support
- > 1. Since NumberType isn't a WrappedResource, it won't ever be referenced via a handle. Instead, we use static meth...
- 03:34 PM Base Language Feature #2074: add CAN-QUERY() and CAN-SET() support
- > 2. You have some major merging to do with the recent sockets code.
Done.
> And there are massive changes to t... - 03:10 PM Base Language Feature #2074: add CAN-QUERY() and CAN-SET() support
- Code Review 0917b
Generally it looks really good. Some feedback:
1. Since NumberType isn't a WrappedResource, ... - 09:28 PM Base Language Feature #2074: add CAN-QUERY() and CAN-SET() support
- Added missing ERROR related attributes and methods. It is found the setter for READ-ONLY attribute is not found.
- 06:49 PM Base Language Feature #1640: implement DOM XML support
- 1) fixed issues in note 123 - 130
2) in @XmlFactory@ class methods @createXNodeReference@ now set new node into reso... - 02:49 PM Base Language Feature #1640: implement DOM XML support
- Can you get your update ready for review today? If not, when can it be ready?
- 05:46 PM Database Feature #2141: generate SQL Server schema
- Vadim Nebogatov wrote:
> 10. getAlterComputedColumnString()
> ...
> MS SQL Server ALTER TABLE does not allow alter... - 05:18 PM Database Feature #2141: generate SQL Server schema
- Items 9, 10 about rtrim and getAlterComputedColumnString added to note 9.
- 01:40 PM Database Feature #2141: generate SQL Server schema
- I have added item 8 about collation to note 9.
- 05:35 PM Database Feature #2116: add runtime support for _user metadata table
- Ovidiu Maxiniuc wrote:
> ...the @_User@ table has changed; the .d /.df pair I extracted today have a different numbe... - 05:16 PM Database Feature #2116: add runtime support for _user metadata table
- Ovidiu Maxiniuc wrote:
> I also start adding import support for _User meta-table.
> I understand that this is a ta... - 02:07 PM Database Feature #2116: add runtime support for _user metadata table
- Ovidiu Maxiniuc wrote:
> > * I am a bit confused by the use of the @Database@ class to hold the userid.
> Indeed, ... - 12:52 PM Database Feature #2116: add runtime support for _user metadata table
- I also start adding import support for _User meta-table.
I understand that this is a table like others from the dat... - 12:35 PM Database Feature #2116: add runtime support for _user metadata table
- > * I am a bit confused by the use of the @Database@ class to hold the userid.
Indeed, I was a little confused abou... - 12:14 PM Base Language Feature #1631: implement support for LANDSCAPE/PORTRAIT in I/O statements
- Code Review 0918a
This is pretty good work. Some changes to make:
1. The name of the update should be vig_upd2... - 09:43 AM Base Language Bug #2183: fix resource save/restoration when used with string/handle functions
- Work this along with the work in #1781. They are closely related.
- 09:30 AM Base Language Feature #1608 (Closed): implement full appserver support (from 4GL clients only)
- 09:30 AM Base Language Feature #1991 (Closed): runtime support for appserver
- 09:29 AM Base Language Feature #2184 (Closed): create and populate the temp-table on the remote side, based on the recei...
- 08:49 AM Base Language Feature #1606 (Closed): implement persistent procedures/super procedures
- 08:46 AM Base Language Feature #1884 (Closed): add some of the v10 data types and core built-ins
- 08:38 AM Base Language Feature #1964 (Closed): finish runtime support for MEMPTR/RAW
- 08:33 AM Base Language Feature #1638: implement Java access to converted appserver code (must be a simple replacement fo...
- Is there anything left to do on this or can we close the task?
- 08:27 AM Base Language Feature #1958 (Closed): implement the runtime support for sockets
- 08:26 AM Base Language Feature #2129 (Closed): final runtime work on sockets
- 08:26 AM Base Language Feature #1639 (Closed): implement socket support
- 03:10 AM Base Language Feature #1639: implement socket support
- >I assume all the socket testcases (other than SSL) are working now?
yes.
This version was committed to rev 10382...
09/17/2013
- 06:54 PM Base Language Feature #1631: implement support for LANDSCAPE/PORTRAIT in I/O statements
- Here is an archive with my changes. Please review. What to do further?
- 12:21 PM Base Language Feature #1631: implement support for LANDSCAPE/PORTRAIT in I/O statements
- > The rule uses a parentid variable as a parent node pointer(as other IO_OPTIONS do) and this var is correctly set as...
- 03:45 AM Base Language Feature #1631: implement support for LANDSCAPE/PORTRAIT in I/O statements
- At this moment these statements can correctly be converted:
output to printer
output to printer printerName
outp... - 04:11 PM Database Feature #2175 (WIP): add support for -rereadnolock startup parameter
- 04:09 PM Database Feature #2116: add runtime support for _user metadata table
- Eliminating the Apache logging dependency:
1. Replace:... - 04:08 PM Database Feature #2116: add runtime support for _user metadata table
- Code review 20130917a:
I realize this is only an intermediate update, but I had a quick look to get an idea of you... - 02:41 PM Database Feature #2116: add runtime support for _user metadata table
- An intermediate version.
From my tests, @userid@ and @setuserid@ forms of the function without ldbname use indeed the... - 01:40 PM Base Language Feature #2074: add CAN-QUERY() and CAN-SET() support
- This is the first candidate for implementation. While you are reviewing I'll check for possible missed annotations be...
- 08:20 AM Base Language Feature #2074: add CAN-QUERY() and CAN-SET() support
- >> Moving to the static calls(SessionUtils, ProcedureManager, etc.)
>
> For these too, you will need to annotate t... - 07:47 AM Base Language Feature #2074: add CAN-QUERY() and CAN-SET() support
- Eugenie Lyzenko wrote:
> Moving to the static calls(SessionUtils, ProcedureManager, etc.)
For these too, you will ... - 08:54 PM Base Language Feature #2074: add CAN-QUERY() and CAN-SET() support
- Moving to the static calls(SessionUtils, ProcedureManager, etc.) The new notes found for CommonWidget:
The attribute... - 12:53 PM Base Language Feature #1640: implement DOM XML support
- Constantin's ErrorManager change will be checked in before your changes. So you don't have to include this file in y...
- 12:28 PM Base Language Feature #1640: implement DOM XML support
- Evgeny, please use the attached ErrorManager class. You will need to call @recordOrShowError(code, msg, false, false,...
- 10:29 AM Base Language Feature #1640: implement DOM XML support
- > we need to add yet another parameter isError, to the ErrorManager.recordOrShowError, so that the pending flag will ...
- 07:30 AM Base Language Feature #1640: implement DOM XML support
- About @HANDLE@ attribute: please add this code in @methods_attributes.rules@:...
- 09:41 PM Base Language Feature #1640: implement DOM XML support
- Constantin Asofiei wrote:
> > You are right. I'll try to look how I can manage it inside rules.
> Please provide th... - 12:51 PM Base Language Feature #1639: implement socket support
- I'm OK with the changes. I assume all the socket testcases (other than SSL) are working now?
If all the socket te... - 12:25 PM Base Language Feature #1639: implement socket support
- > Please increase this size to at least 4096.
I've set it to 4096 for now. I wonder if it should not be set to SO_RC... - 10:54 AM Base Language Feature #1639: implement socket support
- > - for read, I chose an arbitrary chunk size of 512 bytes (although I think a larger size would work too).
Please... - 06:56 AM Base Language Feature #1639: implement socket support
- > 1. We should not be using Apache Commons logging. Eric's use of it was unsanctioned and should not be extended. We ...
- 12:24 PM Base Language Bug #2183: fix resource save/restoration when used with string/handle functions
- Notes from #1639:
[GES]
> 3. Is it safe to use the hash code for the ID to resource mapping in handle? It seems lik... - 12:22 PM Base Language Bug #2183 (Closed): fix resource save/restoration when used with string/handle functions
- 07:47 AM Base Language Feature #1983 (WIP): runtime support for widget pools
- 07:33 AM Base Language Bug #2182: HANDLE attribute doesn't convert properly in "h:handle:<attr/method>" cases
- There is a problem in converting @h:handle:attribute@ or @h:handle:method()@ chain calls, as the inner @HANDLE@ attri...
- 07:32 AM Base Language Bug #2182 (New): HANDLE attribute doesn't convert properly in "h:handle:<attr/method>" cases
09/16/2013
- 06:30 PM Base Language Feature #2074: add CAN-QUERY() and CAN-SET() support
- > Greg, any idea why we have both KEEP-Z-ORDER and KEEP-FRAME-Z-ORDER? IMO, only KEEP-FRAME-Z-ORDER is correct, as th...
- 04:04 PM Base Language Feature #2074: add CAN-QUERY() and CAN-SET() support
- > I see. The problem is we have the methods for both:
> KEEP-Z-ORDER:
> isKeepZOrder();
> setKeepZOrder(logical lo... - 02:28 PM Base Language Feature #2074: add CAN-QUERY() and CAN-SET() support
- > > The attribute PERSISTENT has described in Progress docs as readable/writable. But in P2J conversion we have only ...
- 06:26 PM Base Language Feature #1639: implement socket support
- Code Review 0916c
General: very good work. The multithreaded read part is especially hard to get one's mind aroun... - 04:12 PM Base Language Feature #1639: implement socket support
- I'm regression testing this update now (conersion passed, runtime is in progress); please review. The only issue is a...
- 04:41 PM Database Feature #2141: generate SQL Server schema
- Please bear in mind that the scope of this task is to generate a SQL Server schema, not to implement all functionalit...
- 04:34 PM Database Feature #2141: generate SQL Server schema
- Sorry, I missed this earlier. Yes, we need to support both (and only those) versions (2008 and 2012). We do not need ...
- 04:28 PM Database Feature #2141: generate SQL Server schema
- Eric, what do you think about my last question in note 9 ("Will we create separate P2JSQLServer2008Dialect and P2JSQL...
- 04:25 PM Database Feature #2141: generate SQL Server schema
- MS SQL Server allows double quoted column names and I meant we need support this too... But it seems I understood now...
- 10:22 AM Database Feature #2141: generate SQL Server schema
- I'm not sure what use case would make this necessary. We control the conversion of all names, and we don't allow doub...
- 04:54 AM Database Feature #2141: generate SQL Server schema
- I think all usages of dialect.getComputedColumnPrefix() should be corrected for the case when prefix could be meet in...
- 04:17 PM Base Language Feature #1638 (WIP): implement Java access to converted appserver code (must be a simple replacem...
- 04:12 PM Database Feature #2116: add runtime support for _user metadata table
- Ovidiu Maxiniuc wrote:
> In P2J terms, we need to have an "default" database defined in the directory, that will be ... - 03:53 PM Database Feature #2116: add runtime support for _user metadata table
- If the @_user@ table of "default" database is populated (is not empty) and the -U -P command line parameters are not ...
- 03:46 PM Database Feature #2116: add runtime support for _user metadata table
- From my researches I found out some interesting things about @userid@ and @setuserid@ which are not very explicit in ...
- 02:10 PM Database Feature #1594: add conversion and runtime support for CURRENT-CHANGED() built-in function
- OK, thanks. Please commit and distribute the update.
- 11:42 AM Database Feature #1594: add conversion and runtime support for CURRENT-CHANGED() built-in function
- The @crtRecBuffCount == 1@ means that the respective record is referred by one buffer. In this case, there are two ca...
- 11:49 PM Database Feature #1594: add conversion and runtime support for CURRENT-CHANGED() built-in function
- Code review 20130911b/20130912e:
Changes look good, but please help me understand why the refresh code in the 2 ma... - 12:31 PM Base Language Feature #2129 (WIP): final runtime work on sockets
- 12:30 PM Base Language Feature #1640: implement DOM XML support
- > You are right. I'll try to look how I can manage it inside rules.
Please provide the test you which uses the gener... - 12:18 PM Base Language Feature #1640: implement DOM XML support
- Constantin Asofiei wrote:
> methods_attributes.rules:
> - getHandle - please explain why you still need to convert ... - 06:56 AM Base Language Feature #1640: implement DOM XML support
- Evgeny, a lot better, only a few issues left:
methods_attributes.rules:
- getHandle - please explain why you stil... - 10:16 PM Base Language Feature #1640: implement DOM XML support
- 1) now all assignments works inside WrapperResource and check type of handle.
2) load/save now works properly
3) merg... - 12:20 PM Base Language Feature #2181: implement SSL support for sockets
- @LowLevelSocketImpl.connectSSL@ is not yet implemented. Following are some findings/implementation notes:
* nosessio... - 12:16 PM Base Language Feature #2181 (Closed): implement SSL support for sockets
09/14/2013
- 07:20 AM Base Language Feature #2074: add CAN-QUERY() and CAN-SET() support
- > The attribute PERSISTENT has described in Progress docs as readable/writable. But in P2J conversion we have only ge...
09/13/2013
- 07:01 PM Base Language Feature #2074: add CAN-QUERY() and CAN-SET() support
- The additional notes at this time:
NUM-BUFFERS r P2JQuery - (Changed javadoc, bacause it is attribute, not a metho... - 03:08 PM Base Language Feature #2074: add CAN-QUERY() and CAN-SET() support
- Another question.
The attribute PERSISTENT has described in Progress docs as readable/writable. But in P2J convers... - 03:33 AM Base Language Feature #2074: add CAN-QUERY() and CAN-SET() support
- Eugenie Lyzenko wrote:
> Another point:
> [...]
>
> The Buffer.java does not have @defaultBufferHandle@ method. ... - 01:45 PM Base Language Feature #1631: implement support for LANDSCAPE/PORTRAIT in I/O statements
- OK, there are multiple things to discuss here.
1. First, the code you have posted is nested inside this "top level... - 01:26 PM Base Language Feature #1631: implement support for LANDSCAPE/PORTRAIT in I/O statements
- Here is the rule, that creates openPrinterStream()...
- 11:48 AM Base Language Feature #1631: implement support for LANDSCAPE/PORTRAIT in I/O statements
- > Here is my rule for the FILENAME type:
Actually, I don't think this code is needed. The FILENAME node should co... - 10:24 AM Base Language Feature #1631: implement support for LANDSCAPE/PORTRAIT in I/O statements
- Greg Shah wrote:
> > Don't see at the type FILENAME here.
>
> What do you mean by this? The FILENAME node is the... - 10:14 AM Base Language Feature #1631: implement support for LANDSCAPE/PORTRAIT in I/O statements
- > Don't see at the type FILENAME here.
What do you mean by this? The FILENAME node is there.
> After I'll fix ... - 10:03 AM Base Language Feature #1631: implement support for LANDSCAPE/PORTRAIT in I/O statements
- Here is 4GL tree part corresponding to that statement:...
- 09:44 AM Base Language Feature #1631: implement support for LANDSCAPE/PORTRAIT in I/O statements
- You are on the right track by looking at the tree itself to understand what is generated. But the problem here is li...
- 09:09 AM Base Language Feature #1631: implement support for LANDSCAPE/PORTRAIT in I/O statements
- I'll explain.
Let's assume, that we are converting the statement OUTPUT TO PRINTER "printerName". At this moment re... - 08:28 AM Base Language Feature #1631: implement support for LANDSCAPE/PORTRAIT in I/O statements
- Your question is too broad. Are you asking for information on how to code TRPL programs? Do you have some specific ...
- 08:26 AM Base Language Feature #1631: implement support for LANDSCAPE/PORTRAIT in I/O statements
- Could you tell me please how to specify the rules to convert OUTPUT TO PRINTER printerName statement to correct Java ...
- 04:26 AM Database Feature #1594: add conversion and runtime support for CURRENT-CHANGED() built-in function
- Yesterday my work was focused on fixing the queries for failing tests. Because of the large amounts of sql queries ne...
09/12/2013
- 05:51 PM Base Language Feature #2074: add CAN-QUERY() and CAN-SET() support
- Another point:...
- 04:48 AM Base Language Feature #2074: add CAN-QUERY() and CAN-SET() support
- > No, please don't change the @hwrap@ values in methods attributes. To identify the interface defining the attribute/...
- 03:48 AM Base Language Feature #2074: add CAN-QUERY() and CAN-SET() support
- Eugenie Lyzenko wrote:
> Need another clarification. Consider the following rule:
> [...]
> There are no BufferFie... - 05:28 PM Base Language Feature #1631: implement support for LANDSCAPE/PORTRAIT in I/O statements
- OK, interesting results. The progress.g will need to be fixed and most everything else from a conversion perspective...
- 04:56 PM Base Language Feature #1631: implement support for LANDSCAPE/PORTRAIT in I/O statements
- > Finally, note this comment from the 4GL docs: @On UNIX, the printer spooling facilities (lp or lpr) are used automa...
- 04:34 PM Base Language Feature #1631: implement support for LANDSCAPE/PORTRAIT in I/O statements
- It seems I really missed this circumstance. See the results of my testing below.
> Some questions:
>
> # Does t... - 02:56 PM Base Language Feature #1631: implement support for LANDSCAPE/PORTRAIT in I/O statements
- > OUTPUT TO PRINTER "somePrinter"
Interesting. Please note that the Progress 4GL Language reference states this:... - 02:29 PM Base Language Feature #1631: implement support for LANDSCAPE/PORTRAIT in I/O statements
- During the testing step I faced with a problem. When a printer name is specified in the progress OUTPUT TO PRINTER st...
- 04:35 PM Database Feature #2141: generate SQL Server schema
- I have added item 7 about sequences to note 9 and question.
- 03:22 PM Database Feature #1594: add conversion and runtime support for CURRENT-CHANGED() built-in function
- The initial tests had some unimportant fails in CTRL+C and quite a lot of fails in the main part:
* 7 in gso_tests ...
Also available in: Atom