Project

General

Profile

Activity

From 03/23/2014 to 04/21/2014

04/22/2014

10:06 PM Base Language Bug #2288: incorrect conversion and results for unknown value comparisons
Regression testing again showed an unwanted change with the 0420a update. Previously,... Eric Faulhaber

04/21/2014

04:06 PM Database Feature #2281: enhance schema name conversion to support literal replacements
Processed formats: @"%s_timestamp"@, @"%s_offset"@, @"alter table %s alter column %s %s as %s;"@
Actually only tw...
Vadim Nebogatov
03:35 AM Database Feature #2281: enhance schema name conversion to support literal replacements
Some more changes implemented: ... Vadim Nebogatov
01:37 PM Database Bug #18: issues with ne/equal and true/false conversion in WHERE clauses
The non-WHERE clause related conversion errors are being managed in #2288. The scope of this task is now just the WHE... Eric Faulhaber
01:31 PM Base Language Bug #2288: incorrect conversion and results for unknown value comparisons
It probably makes sense to note the status of this task in #18 and to move that task into the Database project. It ma... Greg Shah
01:13 PM Base Language Bug #2288: incorrect conversion and results for unknown value comparisons
Greg Shah wrote:
> Not that you were asking, but I am fine with the changes.
OK, the feedback is helpful, particula...
Eric Faulhaber
12:49 PM Base Language Bug #2288: incorrect conversion and results for unknown value comparisons
Code Review 0420a
Not that you were asking, but I am fine with the changes.
Are the remaining portions of #18 o...
Greg Shah
11:20 AM Base Language Bug #2288: incorrect conversion and results for unknown value comparisons
Regression testing indicated that this change had the useful side effect of fixing some queries that were selecting t... Eric Faulhaber
12:07 PM Database Bug #2219: problematic dynamic query test cases
The issue is caused by an unclosed implicit transaction opened by a query. It doesn't cause an error for static queri... Stanislav Lomany
11:38 AM User Interface Feature #1811: implement the AJAX client driver
Code Review 0417a
1. Java_com_goldencode_terminal_NativePty_shell() in shell.c has some possible resource leaks:
...
Greg Shah

04/20/2014

12:21 PM Database Feature #1661: support case-sensitive fields in indexes
Eric Faulhaber wrote:
> * DynamicQueryHelper: why have you added back the @WorkArea.permSchemasLoaded@ flag? Perhaps...
Eric Faulhaber
10:17 AM Database Feature #2281: enhance schema name conversion to support literal replacements
Eric, no problems, it is not an issue already.
It seems approach with using Hybernate's backticks is good and I a...
Vadim Nebogatov

04/19/2014

02:46 PM Database Feature #2281: enhance schema name conversion to support literal replacements
Vadim Nebogatov wrote:
> The question concerning using @escape@ attribute.
>
> Should it be done on the level of...
Eric Faulhaber
09:24 PM Database Feature #2281: enhance schema name conversion to support literal replacements
The reason for this feature is that some customers (as for the current project) want to use names where case is relev... Eric Faulhaber
02:43 PM Database Bug #2285 (Closed): Regression when converting the server sources: null annotation
Eric Faulhaber
09:51 AM Database Bug #2285: Regression when converting the server sources: null annotation
Update vmn_upd20140416a.zip committed to bzr rev.10512 and distributed. Vadim Nebogatov
10:19 PM Database Bug #2285: Regression when converting the server sources: null annotation
With this fix, the NullPointerException (the 1st problem in note 1 above) no longer occurs. I don't see the other pro... Eric Faulhaber
02:32 PM Database Feature #2258 (Closed): retrofit BUFFER-COPY and BUFFER-COMPARE language statement runtime suppor...
Eric Faulhaber
01:38 PM Database Feature #2220: dynamic query methods which require implementation
Guys, about @deleteResultListEntry@ - how it should be implemented? My idea is to make query-specific list of recids ... Stanislav Lomany
10:27 PM Base Language Bug #2288: incorrect conversion and results for unknown value comparisons
The attached update, based on some of Vadim's findings documented in #18 (note 9), resolves the issue. Eric Faulhaber

04/18/2014

07:21 PM Database Feature #2281: enhance schema name conversion to support literal replacements
I am trying to implement @escape@ support using Hybernate's backticks @`@ for columns with escape hint. In this case ... Vadim Nebogatov
06:15 PM Database Feature #2258: retrofit BUFFER-COPY and BUFFER-COMPARE language statement runtime support to use ...
Update vmn_upd20140409a.zip passed regression and distributed. Bzr revision is 10511. Vadim Nebogatov
05:52 PM Database Feature #1661: support case-sensitive fields in indexes
Code review 20140416b:
Nice functional update (and a lot of code cleanup as well). Some issues/questions:
* Why...
Eric Faulhaber
01:26 PM Database Feature #1661: support case-sensitive fields in indexes
I believe the current update passed the test. The only issues were:
* ctrlc_01_session5: Expected '' (0x0000 at rela...
Ovidiu Maxiniuc
04:23 PM Database Bug #2285: Regression when converting the server sources: null annotation
Code review 20140416a:
The changes look OK to me. Please do a regular conversion regression test.
I will run a ...
Eric Faulhaber
02:28 PM Base Language Bug #2288: incorrect conversion and results for unknown value comparisons
Seems it started off that way, though in the history, #18 only describes the inequality comparisons with true/false, ... Eric Faulhaber
02:10 PM Base Language Bug #2288: incorrect conversion and results for unknown value comparisons
Is this the same as #18? Greg Shah
12:57 AM Base Language Bug #2288: incorrect conversion and results for unknown value comparisons
Consider the following 4GL test (testcases/uast/unknown-comparison2.p):... Eric Faulhaber
12:30 AM Base Language Bug #2288 (Closed): incorrect conversion and results for unknown value comparisons
Eric Faulhaber
11:48 AM Database Feature #2220: dynamic query methods which require implementation
Constantin, yes, for static query it for some reason requires explicit fields specifications while works fine for dyn... Stanislav Lomany
11:21 AM Database Feature #2220: dynamic query methods which require implementation
Stanislav, if I'm putting your example into a @OPEN QUERY@ case, the code can not compile in 4GL - it says that @f2@ ... Constantin Asofiei
09:15 AM Database Feature #2220 (WIP): dynamic query methods which require implementation
Eric, some issues about @indexInformation@:
1. There may be some differences in index selection rules with 4GL, e.g....
Stanislav Lomany
03:06 AM Base Language Bug #2284: Fix parameter initialization
Hynek Cihlar wrote:
> Attached is the fix for the above two initialization issues, *please review*. Regression test ...
Constantin Asofiei

04/17/2014

05:22 PM Database Feature #1661: support case-sensitive fields in indexes
The update almost passed the full-regression testing, 3 tests failed:
* ctrlc_11_session1/3/4: because some semaphor...
Ovidiu Maxiniuc
04:05 PM Base Language Bug #2284: Fix parameter initialization
It turns out I was running the P2J conversion without the proper version defined, i.e. with the default 9.0C as Const... Hynek Cihlar
10:15 AM Base Language Support #2234 (Closed): test and fix native API support on Windows
Greg Shah
08:48 AM Base Language Feature #2287: implement missing type conversion for POLY cases in data type wrapper assign method
There are polymorphic functions (FUNC_POLY), attributes (ATTR_POLY) and methods (METH_POLY) in the 4GL. These are bu... Greg Shah
07:53 AM User Interface Feature #1811: implement the AJAX client driver
1. Use ansi STARTUPINFO on shell_win.c
2. Merge changes on build.xml.
Marius Gligor
03:47 AM User Interface Feature #2286 (WIP): design and implement basic GUI window widget support
Marius Gligor

04/16/2014

06:59 PM Base Language Feature #2287: implement missing type conversion for POLY cases in data type wrapper assign method
Several data type wrapper implementations have TODOs in @assign(BaseDataType value, boolean force)@, as in the follow... Eric Faulhaber
06:47 PM Base Language Feature #2287 (Closed): implement missing type conversion for POLY cases in data type wrapper ass...
Eric Faulhaber
02:39 PM User Interface Feature #2252: implement GUI client support
The first step in creating GUI support is to implement #2286, which is support for the creation and display of a GUI ... Greg Shah
02:35 PM Database Bug #2285: Regression when converting the server sources: null annotation
Attached @vmn_upd20140416a.zip@ fixes first exception. It is possible some more errors also will be fixed. Attached @... Vadim Nebogatov
02:24 PM User Interface Feature #2286: design and implement basic GUI window widget support
Put all details in the parent task #2252. Greg Shah
02:23 PM User Interface Feature #2286 (Closed): design and implement basic GUI window widget support
Greg Shah
01:51 PM User Interface Feature #1788 (Review): implement define rectangle and rectangle widget support
Final RECTANGLE implementation code. Marius Gligor
03:26 AM Database Feature #2258: retrofit BUFFER-COPY and BUFFER-COMPARE language statement runtime support to use ...
Regression 20140415_154604 completed. 3 tests failed:
1. tc_job_002 FAILED failure in step 40: 'Unexpected EOF in ...
Vadim Nebogatov

04/15/2014

09:36 AM Base Language Feature #2184: create and populate the temp-table on the remote side, based on the received metad...
Update for review. Stanislav Lomany
07:22 AM User Interface Feature #1788: implement define rectangle and rectangle widget support
An uast test having dynamic color assignments. Marius Gligor
05:19 AM User Interface Feature #1788: implement define rectangle and rectangle widget support
1. Add new options for DEFINE RECTANGLE like DCOLOR, PFCOLOR, BGCOLOR, FGCOLOR, TOOLTIP.
BGCOLOR, FGCOLOR and TOO...
Marius Gligor

04/14/2014

03:18 PM Database Bug #2285 (WIP): Regression when converting the server sources: null annotation
-------- Original Message --------
Subject: regression when converting the server sources
Date: Mon, 14 Apr 2014 ...
Vadim Nebogatov
03:17 PM Database Bug #2285 (Closed): Regression when converting the server sources: null annotation
Vadim Nebogatov
03:15 PM Base Language Bug #2284: Fix parameter initialization
The original source suggests that Progress 9.0C version behaves differently in respect to the parameter initializatio... Hynek Cihlar
01:41 AM Base Language Bug #2284: Fix parameter initialization
Hynek Cihlar wrote:
> Note that the file @variable_definitions.rules@ contained logic of Progress V9.0C. I removed t...
Constantin Asofiei
02:50 PM User Interface Feature #1788: implement define rectangle and rectangle widget support
I fixed a bug related to colours drawing on RECTANGLE widget according to my latest tests. Marius Gligor
01:23 PM User Interface Feature #1788: implement define rectangle and rectangle widget support
Here is the RECTANGLE widget implementation for character interface and some remarks.
1. The implemented options f...
Marius Gligor
05:12 AM Base Language Feature #2184: create and populate the temp-table on the remote side, based on the received metad...
Stanislav Lomany wrote:
> Constantin, is there a simple way do determine that the specific context is run using an a...
Constantin Asofiei
04:59 AM Base Language Feature #2184: create and populate the temp-table on the remote side, based on the received metad...
Constantin, is there a simple way do determine that the specific context is run using an agent? Stanislav Lomany
02:20 AM Base Language Bug #2283: Appserver persistence-related abend on subsequent connect
Stanislav, if you look into the @TM.resettables@ list, there are two @BufferManager@ instances, when it should have b... Constantin Asofiei

04/13/2014

05:35 PM Base Language Bug #2284: Fix parameter initialization
Attached is the fix resolving the found parameter initialization issues.
Note that the file @variable_definitions...
Hynek Cihlar
04:23 PM Base Language Bug #2284 (WIP): Fix parameter initialization
Hynek Cihlar
04:04 PM Base Language Bug #2284: Fix parameter initialization
The following are the cases where the variable initialization fails.
* Components of an indeterminate unfixed extent...
Hynek Cihlar
03:29 PM Base Language Bug #2284 (Closed): Fix parameter initialization
Hynek Cihlar
05:22 PM Database Feature #2258: retrofit BUFFER-COPY and BUFFER-COMPARE language statement runtime support to use ...
tc_job_clock_002 test fails each time because of timeout error:
failure in step 20: 'timeout before the specific s...
Vadim Nebogatov
02:49 PM Database Feature #2258: retrofit BUFFER-COPY and BUFFER-COMPARE language statement runtime support to use ...
Since tc_job_clock_002 has failed each time, have you checked the server.log to see if there is a real regression? Ha... Eric Faulhaber
01:47 PM Database Feature #2258: retrofit BUFFER-COPY and BUFFER-COMPARE language statement runtime support to use ...
Regression 20140413_095429 completed. 6 tests failed, including
tc_job_002
tc_job_clock_002
Will start regre...
Vadim Nebogatov
04:21 PM Base Language Bug #2133: fix precision for decimal, dynamic-extent variables
Because the problem of parameter initialization goes beyond the extents, I created a separate issue for it. See #2284. Hynek Cihlar
02:40 PM Database Feature #2281: enhance schema name conversion to support literal replacements
The question concerning using @escape@ attribute.
Should it be done on the level of overriding normalizer.normalize...
Vadim Nebogatov

04/12/2014

04:44 AM Base Language Bug #2283: Appserver persistence-related abend on subsequent connect
Testcase (@called.p@):... Stanislav Lomany
04:38 AM Base Language Bug #2283 (Closed): Appserver persistence-related abend on subsequent connect
Stanislav Lomany
08:47 PM Database Feature #2282 (Hold): make number of pattern engine instances per conversion profile configurable
Currently, we create one pattern engine instance per conversion profile (e.g., schema/p2o, annotations/annotations, e... Eric Faulhaber
08:25 PM Database Feature #2282 (Hold): make number of pattern engine instances per conversion profile configurable
Eric Faulhaber
08:23 PM Database Feature #2276 (Closed): create a work queue of PatternEngine instances for runtime conversion tasks
The attached update has passed regression testing and is committed to bzr rev. 10510. Eric Faulhaber

04/11/2014

05:09 PM Database Feature #1661: support case-sensitive fields in indexes
Intermediary update, not fully tested.
Changes:
Added case-sensitive attribute in @P2JField@.
Added @caseSensitive...
Ovidiu Maxiniuc
02:43 PM Database Feature #2258: retrofit BUFFER-COPY and BUFFER-COMPARE language statement runtime support to use ...
Regression 20140411_102011 completed. 3 tests failed:
1. tc_job_002 FAILED failure in step 40: 'Unexpected EOF in ...
Vadim Nebogatov
02:25 PM Database Feature #2148: enhance prototype to compile p2jpl.jar file with IKVMC into .NET assembly and load...
Using the attached om_upd20140314a.zip, almost all methods and functions have full support for MSSQL (the fully imple... Ovidiu Maxiniuc

04/10/2014

03:26 PM Database Feature #2258: retrofit BUFFER-COPY and BUFFER-COMPARE language statement runtime support to use ...
Regression 20140410_105536 completed. 3 tests failed:
1. tc_job_002 FAILED failure in step 40: 'Unexpected EOF in ...
Vadim Nebogatov
12:50 AM Database Feature #2258 (Test): retrofit BUFFER-COPY and BUFFER-COMPARE language statement runtime support ...
Eric Faulhaber
12:46 AM Database Feature #2258: retrofit BUFFER-COPY and BUFFER-COMPARE language statement runtime support to use ...
Code review 20140409a:
The update looks good. Please regression test.
Eric Faulhaber
03:18 PM Base Language Feature #2184: create and populate the temp-table on the remote side, based on the received metad...
Stanislav Lomany wrote:
> Where should we "keep" the values - in the global scopes (should we add them?) of scoped d...
Constantin Asofiei
12:49 PM Base Language Feature #2184: create and populate the temp-table on the remote side, based on the received metad...
> I think the problem is here. When an appserver procedure is ran persistent and its topmost scope is finished, I thi... Stanislav Lomany
09:44 AM Base Language Feature #2184: create and populate the temp-table on the remote side, based on the received metad...
Stanislav Lomany wrote:
> Note that topmost scope for the external procedure is also deleted.
I think the problem i...
Constantin Asofiei
08:39 AM Base Language Feature #2184: create and populate the temp-table on the remote side, based on the received metad...
Guys, consider an external persistent procedure and a buffer scoped to that procedure. When we call an internal proce... Stanislav Lomany
02:51 PM Database Feature #2281: enhance schema name conversion to support literal replacements
Yes and yes. Eric Faulhaber
01:41 PM Database Feature #2281: enhance schema name conversion to support literal replacements
The question concerning fields with extent.
Would be possible using denormalization hints along with literal replac...
Vadim Nebogatov
10:55 AM Database Feature #2281 (WIP): enhance schema name conversion to support literal replacements
Vadim Nebogatov
12:39 AM Database Feature #2281: enhance schema name conversion to support literal replacements
We need to enhance the schema hint syntax to allow the name conversion algorithms to be bypassed entirely, such that ... Eric Faulhaber
12:14 AM Database Feature #2281 (Closed): enhance schema name conversion to support literal replacements
Eric Faulhaber
01:31 PM Base Language Feature #1634: implement full native library (.so or DLL) support
The @evl_upd20140403b.zip@ has been committed into bzr as 10509. Eugenie Lyzenko
01:00 PM Base Language Feature #1634: implement full native library (.so or DLL) support
Today I have got completely passed CTRL-C session tests(2-way and 3-way in single passed run). So I have started the ... Eugenie Lyzenko

04/09/2014

05:48 PM Database Feature #2258: retrofit BUFFER-COPY and BUFFER-COMPARE language statement runtime support to use ...
I have attached update vmn_upd20140409a.zip and tests used vmn_upd20140409b.zip for review.
Vadim Nebogatov
05:30 PM Base Language Feature #1634: implement full native library (.so or DLL) support
I have finished regression testing. The results have been uploaded to share. So I can start uploading changes:
1. ...
Eugenie Lyzenko
11:32 AM Base Language Feature #1634: implement full native library (.so or DLL) support
Eugenie Lyzenko wrote:
> 1. I have to commit the @majic@ changes first, into the @staging@ branch, correct?
Yes, ...
Constantin Asofiei
11:09 AM Base Language Feature #1634: implement full native library (.so or DLL) support
Looks like I'm finishing with regression testing. Wait for finished CTRL-C results to arrive. And before committing P... Eugenie Lyzenko
05:23 PM Database Bug #2280: Error with FIND-FIRST() method
Test case:... Vadim Nebogatov
05:02 PM Database Bug #2280 (Closed): Error with FIND-FIRST() method
Vadim Nebogatov
04:42 PM Database Feature #1661: support case-sensitive fields in indexes
There is as chance that the proposed solution might not be implemented because at some points the indexes are dropped... Ovidiu Maxiniuc
01:01 PM User Interface Feature #1788: implement define rectangle and rectangle widget support
Doing more test cases conversions I think that I found a bug in conversion process. Let me explain:
Trying to conver...
Marius Gligor
03:31 AM Conversion Tools Feature #2251: improve the call graph generation
Greg Shah wrote:
> You can check in and distribute the update.
Committed to bzr rev 10507.
Constantin Asofiei
03:31 AM Runtime Infrastructure Feature #2124: improve/simplify the startup of server-side batch processes and appserver "agent" ...
Greg Shah wrote:
> Code Review 0404a
>
> I am fine with the changes.
Committed to bzr rev 10508.
Constantin Asofiei

04/08/2014

07:16 PM Base Language Feature #1634: implement full native library (.so or DLL) support
The main part of the runtime testing has passed without any regression. One time cycle, clean run(except known tc-job... Eugenie Lyzenko
01:57 PM Base Language Feature #1634: implement full native library (.so or DLL) support
> Eugenie, have you added the ACL I mentioned at note 209?
For unknown reasons I have not got the e-mail with this...
Eugenie Lyzenko
01:31 PM Base Language Feature #1634: implement full native library (.so or DLL) support
Eugenie, have you added the ACL I mentioned at note 209? Because after adding this ACL, your update worked fine for m... Constantin Asofiei
01:24 PM Base Language Feature #1634: implement full native library (.so or DLL) support
Greg, Constantin,
After a lot of debugging(including remote session to @devbox01@ P2J server and client) I need on...
Eugenie Lyzenko
03:58 PM Database Feature #1661: support case-sensitive fields in indexes
Eric Faulhaber wrote:
> What do you propose to correct this? You can modify the dialect API as needed.
To fix this is...
Ovidiu Maxiniuc
03:42 PM Runtime Infrastructure Feature #2124: improve/simplify the startup of server-side batch processes and appserver "agent" ...
Code Review 0404a
I am fine with the changes.
Greg Shah
03:32 PM Conversion Tools Feature #2251: improve the call graph generation
You can check in and distribute the update. Greg Shah
02:42 PM Conversion Tools Feature #2251: improve the call graph generation
This fixes the incompatibility when running the callgraph on a machine with different case-sensitivity than the one f... Constantin Asofiei
02:43 PM User Interface Feature #1788: implement define rectangle and rectangle widget support
Today I tried to convert some small RECTANGLE test cases using the current implementation for RectangleWidget and the... Marius Gligor
02:18 PM Database Feature #2273: address remaining limitations of SQL Server needed to support legacy 4GL behavior
Reuploaded the update after merging with latest bzr revision (10506). Ovidiu Maxiniuc
06:27 AM Database Feature #2258: retrofit BUFFER-COPY and BUFFER-COMPARE language statement runtime support to use ...
Fixed with replacement in @database_access.rules@:... Vadim Nebogatov
03:16 AM User Interface Feature #1805: add missing UI method support
Vadim Gindin wrote:
> There is no stacktrace.. I just pressed down-arrow right after start and got the error. I also...
Constantin Asofiei
03:15 AM User Interface Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects)
Vadim, about 0403a.zip:
* after merging, the history entry numbers for changes which are in bzr can't be changed. T...
Constantin Asofiei

04/07/2014

05:07 PM User Interface Feature #1805: add missing UI method support
There is no stacktrace.. I just pressed down-arrow right after start and got the error. I also have the last revision... Vadim Gindin
03:50 PM Database Feature #2273: address remaining limitations of SQL Server needed to support legacy 4GL behavior
Added update for review.
The implementation allows specifying @sql-size@ attribute for all datatypes. However, only ...
Ovidiu Maxiniuc
02:36 PM User Interface Feature #1788: implement define rectangle and rectangle widget support
Here is the RECTANGLE widget description extracted form P4GL manuals and some remarks:
- Some attributes are used by...
Marius Gligor
08:10 AM User Interface Feature #1788: implement define rectangle and rectangle widget support
I think this is generally correct. Since we will be implementing the GUI as well, please do plan to support the mous... Greg Shah
02:15 PM Database Feature #2258: retrofit BUFFER-COPY and BUFFER-COMPARE language statement runtime support to use ...
One more not related bug found with compare with BINARY both for statement (method works properly):... Vadim Nebogatov
03:30 AM Base Language Feature #2184: create and populate the temp-table on the remote side, based on the received metad...
Stanislav, you are correct: the @loadedBuffers.size() > 0@ check is needed in @scopeDeleted()@. The problem here is ... Constantin Asofiei

04/05/2014

12:28 PM Database Feature #2276: create a work queue of PatternEngine instances for runtime conversion tasks
Missed a few files, so I'm re-uploading this update. Eric Faulhaber
12:21 PM Database Feature #2276: create a work queue of PatternEngine instances for runtime conversion tasks
Interim update. I am uploading it as a safety backup, but it still needs a lot of work and cleanup. Eric Faulhaber
08:33 AM Database Feature #2258: retrofit BUFFER-COPY and BUFFER-COMPARE language statement runtime support to use ...
Please include the fix with your update for this issue. Eric Faulhaber
06:42 AM Database Feature #2258: retrofit BUFFER-COPY and BUFFER-COMPARE language statement runtime support to use ...
During testing I have found one bug not related directly with issue.
RecordBuffer, line 4032:...
Vadim Nebogatov
05:03 AM Base Language Feature #2184: create and populate the temp-table on the remote side, based on the received metad...
Guys, there is an issue with scoping on app server. Consider a simple testcase: ... Stanislav Lomany

04/04/2014

04:31 PM Database Feature #2273: address remaining limitations of SQL Server needed to support legacy 4GL behavior
For the hint syntax, we generally follow the rule of thumb that if there can be only one value, the information is st... Eric Faulhaber
04:25 PM Database Feature #2273: address remaining limitations of SQL Server needed to support legacy 4GL behavior
I started adding hint support for table fields. I added parsing and processing in TableHints.java, p2o.xml, hibernate... Ovidiu Maxiniuc
04:08 PM Database Feature #2273: address remaining limitations of SQL Server needed to support legacy 4GL behavior
Based on your findings of the longer index limit on their development systems, we have asked the customer to confirm ... Eric Faulhaber
04:01 PM Database Feature #2273: address remaining limitations of SQL Server needed to support legacy 4GL behavior
My previous test cases were too complicated.
Thanks to Greg's suggestion, I used the other condition guards for the...
Ovidiu Maxiniuc
01:37 PM Base Language Feature #1634: implement full native library (.so or DLL) support
> For this, I expected that copying the entire contents of the @x86_64-w64-mingw32.zip@ archive in my mingw64 folder ... Eugenie Lyzenko
11:33 AM Base Language Feature #1634: implement full native library (.so or DLL) support
Eugenie Lyzenko wrote:
> > Eugenie, is it correct for the x86_64-w64-mingw32.zip to contain this path: @x86_64-w64-m...
Constantin Asofiei
10:59 AM Base Language Feature #1634: implement full native library (.so or DLL) support
> Eugenie, is it correct for the x86_64-w64-mingw32.zip to contain this path: @x86_64-w64-mingw32/libs/@, instead of ... Eugenie Lyzenko
07:38 AM Base Language Feature #1634: implement full native library (.so or DLL) support
Eugenie, is it correct for the x86_64-w64-mingw32.zip to contain this path: @x86_64-w64-mingw32/libs/@, instead of @x... Constantin Asofiei
06:29 AM Base Language Feature #1634: implement full native library (.so or DLL) support
Eugenie Lyzenko wrote:
> Found the runtime regression. When the client starts, after enter username and login the fo...
Constantin Asofiei
12:12 PM Base Language Bug #2133: fix precision for decimal, dynamic-extent variables
Hynek Cihlar wrote:
> Hynek Cihlar wrote:
> > Yes, of course, sorry for that. The attached file is the correct exam...
Constantin Asofiei
12:03 PM Base Language Bug #2133: fix precision for decimal, dynamic-extent variables
Regression test of 0329a.zip passed. Fixed the indent in 0329a.zip (see the attached 0404a.zip) and committed to revi... Hynek Cihlar
11:37 AM Base Language Bug #2133: fix precision for decimal, dynamic-extent variables
Hynek Cihlar wrote:
> Yes, of course, sorry for that. The attached file is the correct example.
Constantin, is th...
Hynek Cihlar
05:00 AM Base Language Bug #2133: fix precision for decimal, dynamic-extent variables
Hynek Cihlar wrote:
> I think you reviewed the wrong file.
Yes, it was the wrong file. What confused me was that I...
Constantin Asofiei
11:09 AM Database Feature #2276: create a work queue of PatternEngine instances for runtime conversion tasks
Constantin, I implemented it this way because I was trying to mimic how we use the pattern engine during static conve... Eric Faulhaber
05:13 AM Database Feature #2276: create a work queue of PatternEngine instances for runtime conversion tasks
Eric,
> running the global init-rules once per PatternEngine instance
I'm a little concerned about this, as it will...
Constantin Asofiei
11:48 PM Database Feature #2276 (WIP): create a work queue of PatternEngine instances for runtime conversion tasks
To prove that this idea has merit, I've hacked up the dynamic conversion code and made some changes to @PatternEngine... Eric Faulhaber
11:08 AM User Interface Feature #1788: implement define rectangle and rectangle widget support
Today I did a lot of RECTANGLE tests using the customer's P4GL environment.
Also I converted a small procedure worki...
Marius Gligor
09:52 AM Database Feature #2134 (Closed): configurable denormalization of extent fields into individual fields in s...
Eric Faulhaber
06:44 AM User Interface Feature #1805: add missing UI method support
PS: my test was with the latest P2J from bzr, without your #2162 changes. Constantin Asofiei
06:39 AM User Interface Feature #1805: add missing UI method support
Vadim Gindin wrote:
> Sorry, I thought that it is already committed. Now I've committed it (the file _browse_ui_test...
Constantin Asofiei
06:09 AM Runtime Infrastructure Feature #2124: improve/simplify the startup of server-side batch processes and appserver "agent" ...
Changed to allow postbuild.sh to install the spawn tool and associated files in a specified location. The command loo... Constantin Asofiei

04/03/2014

06:30 PM Database Feature #2273: address remaining limitations of SQL Server needed to support legacy 4GL behavior
> This looks like a fatal error, I was not able to catch it with no-error clause added to assign statement, and also ... Greg Shah
03:26 PM Database Feature #2273: address remaining limitations of SQL Server needed to support legacy 4GL behavior
h3. Write test cases which violate the Progress index size limit to determine error conditions we need to handle.
...
Ovidiu Maxiniuc
06:27 PM User Interface Feature #1788: implement define rectangle and rectangle widget support
> Also I looked over P2J project code in order to understand how to implements P4 widgets on P2J and I found a class ... Greg Shah
02:32 AM User Interface Feature #1788 (WIP): implement define rectangle and rectangle widget support
Marius Gligor
06:02 PM Base Language Feature #1634: implement full native library (.so or DLL) support
Found the runtime regression. When the client starts, after enter username and login the following exception occurs:
...
Eugenie Lyzenko
03:09 PM Base Language Feature #1634: implement full native library (.so or DLL) support
The conversion testing completed without regressions. The @src/aero/timco/majic@ directory with converted files is id... Eugenie Lyzenko
12:33 PM Base Language Feature #1634: implement full native library (.so or DLL) support
> With these changes, do the native library calls all work as expected on Windows?
The converted code and output f...
Eugenie Lyzenko
12:01 PM Base Language Feature #1634: implement full native library (.so or DLL) support
> The only issue I see is that the class javadoc for @ServerPropertiesDaemon@ is incorrect (due to copy/paste). Pleas... Eugenie Lyzenko
11:29 AM Base Language Feature #1634: implement full native library (.so or DLL) support
Code Review 0403a
The only issue I see is that the class javadoc for ServerPropertiesDaemon is incorrect (due to c...
Greg Shah
07:06 AM Base Language Feature #1634: implement full native library (.so or DLL) support
> I'm refering to the @EnvironmentOps.propathOverride@ field defined at line 151 (which has no javadoc, btw, and was ... Eugenie Lyzenko
06:42 AM Base Language Feature #1634: implement full native library (.so or DLL) support
Eugenie Lyzenko wrote:
> The fixed update for review.
>
> > the @EnvironmentOps.propathOverride@ is not used, it ...
Constantin Asofiei
06:35 AM Base Language Feature #1634: implement full native library (.so or DLL) support
The fixed update for review.
> the @EnvironmentOps.propathOverride@ is not used, it needs to be removed.
This c...
Eugenie Lyzenko
02:10 AM Base Language Feature #1634: implement full native library (.so or DLL) support
Eugenie, about 0328a.zip:
# the @EnvironmentOps.propathOverride@ is not used, it needs to be removed.
# there is on...
Constantin Asofiei
05:47 PM User Interface Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects)
1. I forgot about LITERAL field-group. Added this implementation.
2. I also found one bug during the work on TODO...
Vadim Gindin
03:02 AM User Interface Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects)
Vadim Gindin wrote:
> I'm thinking about virtual copies of widgets on the server side. I need some advice. I'm plann...
Constantin Asofiei
01:23 PM Base Language Bug #2133: fix precision for decimal, dynamic-extent variables
Constantin Asofiei wrote:
> Hynek Cihlar wrote:
> > Any update on the review request from the note #33?
> I guess ...
Hynek Cihlar
01:09 PM Base Language Bug #2133: fix precision for decimal, dynamic-extent variables
Constantin Asofiei wrote:
> Hynek Cihlar wrote:
> > Note the call @extj.setParameter(j, true)@ for the input-output...
Hynek Cihlar
02:02 AM Base Language Bug #2133: fix precision for decimal, dynamic-extent variables
Hynek Cihlar wrote:
> Note the call @extj.setParameter(j, true)@ for the input-output case which initializes the arr...
Constantin Asofiei
11:32 AM Base Language Bug #2277: Wrong conversion of session handler
Next 4gl code produce uncompilable java code:... Greg Shah
10:31 AM Database Feature #2134: configurable denormalization of extent fields into individual fields in schema con...
h2. Configurable denormalization of extent fields into individual fields
Two types of field denormalization are supp...
Vadim Nebogatov
07:15 AM User Interface Feature #1805: add missing UI method support
Sorry, I thought that it is already committed. Now I've committed it (the file _browse_ui_test1.p_) Vadim Gindin
06:09 AM User Interface Feature #1805: add missing UI method support
Vadim Gindin wrote:
> I ran _browse_ui_test1.p_ from the /uast folder.
Please commit the test to the testcases proj...
Constantin Asofiei
05:34 AM User Interface Feature #1805: add missing UI method support
I've found the following bug in Java implementation during the testing. I ran _browse_ui_test1.p_ from the /uast fold... Vadim Gindin
05:49 AM Conversion Tools Feature #2251: improve the call graph generation
The branch rev 10504 contains the fix for generating the callgraph reports on windows (the filename should have been ... Constantin Asofiei

04/02/2014

05:50 PM Database Feature #2231 (Closed): LockType error processing
Eric Faulhaber
05:49 PM Database Feature #2231: LockType error processing
Committed to bzr rev. 10503. Vadim Nebogatov
04:22 PM Database Feature #2231: LockType error processing
Yes, please commit and distribute the update. Eric Faulhaber
01:41 PM Database Feature #2231: LockType error processing
Second regression 20140402_084955 is completed with 2 FAILED tests:
1. tc_job_002 FAILED failure in step 40: failu...
Vadim Nebogatov
03:32 AM Database Feature #2231: LockType error processing
Regression 20140401_172003 completed with 4 FAILED tests:
1. tc_job_002 FAILED failure in step 40: 'Unexpected EOF i...
Vadim Nebogatov
03:30 PM Database Feature #2273 (WIP): address remaining limitations of SQL Server needed to support legacy 4GL beh...
h3. Research the options we have in terms of unlimited length text data (including participation of these data types ... Ovidiu Maxiniuc
01:28 PM Database Feature #2273: address remaining limitations of SQL Server needed to support legacy 4GL behavior
Some good news out of today's meeting with the customer: they have not taken advantage of the newer, 1972 byte index ... Eric Faulhaber
01:11 PM Database Feature #2273: address remaining limitations of SQL Server needed to support legacy 4GL behavior
Yes, that is the idea. The computed column (the hashing result) would fit into SQL restriction and the @INCLUDE@ woul... Ovidiu Maxiniuc
12:43 PM Database Feature #2273: address remaining limitations of SQL Server needed to support legacy 4GL behavior
What do you think about using embedded @HashBytes()@ function like http://www.brentozar.com/archive/2013/05/indexing-... Vadim Nebogatov
11:08 AM Database Feature #2273: address remaining limitations of SQL Server needed to support legacy 4GL behavior
Eric Faulhaber wrote:
> Constantin, can you elaborate how this might work? How would we engage the external indexes ...
Constantin Asofiei
09:57 AM Database Feature #2273: address remaining limitations of SQL Server needed to support legacy 4GL behavior
Constantin, can you elaborate how this might work? How would we engage the external indexes to perform a query, for i... Eric Faulhaber
03:18 PM Base Language Bug #2133: fix precision for decimal, dynamic-extent variables
Any update on the review request from the note #33? Hynek Cihlar
03:17 PM Base Language Bug #2133: fix precision for decimal, dynamic-extent variables
File attachment for the #35 note above. Hynek Cihlar
03:16 PM Base Language Bug #2133: fix precision for decimal, dynamic-extent variables
Constantin Asofiei wrote:
> Sorry, I'm coming back on this one: when we can choose between emitting code and hiding ...
Hynek Cihlar
01:21 PM User Interface Feature #2247 (Review): interactive child process support
Marius Gligor
01:20 PM User Interface Feature #1811: implement the AJAX client driver
The interactive process implementation fo0r ChUI Swing and ChUI Web (AJAX) clients with minimum changes on the existi... Marius Gligor
10:48 AM User Interface Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects)
I'm thinking about virtual copies of widgets on the server side. I need some advice. I'm planning to create new field... Vadim Gindin

04/01/2014

05:43 PM Base Language Feature #1634: implement full native library (.so or DLL) support
The different testing performed to check the validity of the 0328a update shows no difference in local conversion in ... Eugenie Lyzenko
04:27 PM Database Feature #2273: address remaining limitations of SQL Server needed to support legacy 4GL behavior
Eric, considering that we already have a locking mechanism above the physical DB layer and this requires that the DB ... Constantin Asofiei
04:00 PM Database Feature #2273: address remaining limitations of SQL Server needed to support legacy 4GL behavior
Indeed, this is a non-trivial issue. Here are some of my thoughts:
+1st approach+ (user filtering of the input):
...
Ovidiu Maxiniuc
03:42 PM User Interface Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects)
I found and fixed a bug with start conditional step. The key was in the fact that conditional calls do not affect the... Vadim Gindin
07:09 AM Base Language Bug #2133: fix precision for decimal, dynamic-extent variables
Constantin Asofiei wrote:
> Hynek Cihlar wrote:
> > May I suggest the following solution? To revert the change in @...
Constantin Asofiei

03/31/2014

07:14 PM Base Language Bug #2133: fix precision for decimal, dynamic-extent variables
Attached is the final fix for the extent-to-extent assignment. The delta from the previous version (hc_upd20140324a.z... Hynek Cihlar
02:56 PM Base Language Bug #2133: fix precision for decimal, dynamic-extent variables
Constantin Asofiei wrote:
> Hynek Cihlar wrote:
> > Constantin Asofiei wrote:
> > For the function case, @ControlF...
Hynek Cihlar
03:31 AM Base Language Bug #2133: fix precision for decimal, dynamic-extent variables
Hynek Cihlar wrote:
> May I suggest the following solution? To revert the change in @OutputExtentParameter@ and @Arr...
Constantin Asofiei
03:29 AM Base Language Bug #2133: fix precision for decimal, dynamic-extent variables
Hynek Cihlar wrote:
> Constantin Asofiei wrote:
> For the function case, @ControlFlowOps@ is not called. Perhaps it...
Constantin Asofiei
06:03 PM Base Language Bug #2277: Wrong conversion of session handler
If code spits like this:... Evgeny Kiselev
05:58 PM Base Language Bug #2277 (New): Wrong conversion of session handler
Evgeny Kiselev
05:21 PM Database Feature #2231: LockType error processing
The update looks good. Please regression test. Eric Faulhaber
12:06 PM Database Feature #2231: LockType error processing
Attached update vmn_upd20140331a.zip.
Passed cases:...
Vadim Nebogatov
04:07 AM Base Language Feature #1608: implement full appserver support (from 4GL clients only)
0326c.zip was committed to bzr rev 10502. Constantin Asofiei

03/30/2014

04:11 PM Database Feature #2276: create a work queue of PatternEngine instances for runtime conversion tasks
Today, we instantiate multiple @PatternEngine@ instances to perform the various stages of runtime conversion tasks fo... Eric Faulhaber
04:00 PM Database Feature #2276 (Closed): create a work queue of PatternEngine instances for runtime conversion tasks
Eric Faulhaber
04:06 PM Database Feature #2231: LockType error processing
I have selected the second option suggested in note 1.
FIND- and GET- methods tested with wrong lock and nowait v...
Vadim Nebogatov
03:57 PM Database Feature #2275: cache of runtime-converted, dynamic queries and temp-tables
As I'm writing this, it's becoming clear that the query cache and temp-table cache probably need to implemented toget... Eric Faulhaber
03:43 PM Database Feature #2275 (Closed): cache of runtime-converted, dynamic queries and temp-tables
Eric Faulhaber
03:46 PM User Interface Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects)
Here is the next update with the following changes.
# I added forced view at the start of @downWorker@ method and it...
Vadim Gindin
03:38 PM Database Feature #2274: improve performance of new database features
In doing some basic profiling of the slow code, it is apparent the most egregious performance problems are with the a... Eric Faulhaber
02:45 PM Database Feature #2274: improve performance of new database features
Early testing of customer code which makes heavy use of some of the newly developed database features (particularly t... Eric Faulhaber
02:34 PM Database Feature #2274 (Closed): improve performance of new database features
Eric Faulhaber
03:08 PM Database Feature #2134 (WIP): configurable denormalization of extent fields into individual fields in sche...
In order to call this task complete, we need some documentation on how the new feature is used. Please add a history ... Eric Faulhaber
02:56 PM Database Feature #2207 (WIP): Remaining issues for dynamic buffers and dynamic tables
Eric Faulhaber
02:52 PM Database Feature #2235 (Closed): fix deployment issues related to dynamic database conversion resources
Eric Faulhaber
07:23 AM Database Feature #2235 (Review): fix deployment issues related to dynamic database conversion resources
svl_upd20140329a.zip was committed to bzr rev 10501. Stanislav Lomany
08:32 PM Base Language Bug #2133: fix precision for decimal, dynamic-extent variables
Constantin Asofiei wrote:
> This one I think requires a conversion change: @integer[] j = extj.getVariable(2);@ need...
Hynek Cihlar

03/29/2014

06:55 PM Database Feature #2235: fix deployment issues related to dynamic database conversion resources
Just for the case I've changed file separator to \ and run my usual testcase - works OK, so most likely it really doe... Stanislav Lomany
06:06 PM Database Feature #2235: fix deployment issues related to dynamic database conversion resources
Stanislav Lomany wrote:
> About @p2j.cfg.xml.{platform_identifier}@: I'm just curious - at what point we are referen...
Eric Faulhaber
06:00 PM Database Feature #2235: fix deployment issues related to dynamic database conversion resources
Code review 20140329a:
Looks good and fixes the issue. Please run conversion regression only and commit if it passes.
Eric Faulhaber
05:12 PM Database Feature #2235: fix deployment issues related to dynamic database conversion resources
About @registry.xml@: @Configuration@ class keeps absolute paths to configuration files, so if we want to load additi... Stanislav Lomany
04:09 PM Database Feature #2235 (WIP): fix deployment issues related to dynamic database conversion resources
Fix for review for issue in note 28. Stanislav Lomany
11:43 PM Database Feature #2235: fix deployment issues related to dynamic database conversion resources
I tried to run with this update applied and I found a regression. In @DynamicQueryHelper.loadPermanentSchemas@, you r... Eric Faulhaber
06:53 PM Database Feature #2273: address remaining limitations of SQL Server needed to support legacy 4GL behavior
Some more thoughts on the challenges of the computed columns approach...
* If done instead of the hard-coded length ...
Eric Faulhaber
06:35 PM Database Feature #2273: address remaining limitations of SQL Server needed to support legacy 4GL behavior
Perhaps a more general-purpose approach is to use computed columns in indexes in the place of converted @character@ f... Eric Faulhaber
04:57 PM Database Feature #2273: address remaining limitations of SQL Server needed to support legacy 4GL behavior
One possible approach is to provide additional inputs into the conversion process to properly limit the maximum lengt... Eric Faulhaber
04:55 PM Database Feature #2273: address remaining limitations of SQL Server needed to support legacy 4GL behavior
Please review the entire history log of #2141. While in the end we were able to generate DDL for a SQL Server schema,... Eric Faulhaber
04:03 PM Database Feature #2273 (Closed): address remaining limitations of SQL Server needed to support legacy 4GL ...
Eric Faulhaber
10:21 AM Database Feature #2134: configurable denormalization of extent fields into individual fields in schema con...
Attached update is passed regression and distributed. Vadim Nebogatov

03/28/2014

07:24 PM Database Feature #2134: configurable denormalization of extent fields into individual fields in schema con...
tc_job_002 is expected to fail in step 40. The other two failing tests each passed in one of your runs, so you can co... Eric Faulhaber
06:29 PM Database Feature #2134: configurable denormalization of extent fields into individual fields in schema con...
Next regression completed. Again 2 tests failed. Second test is another one but with the same error:... Vadim Nebogatov
06:32 AM Database Feature #2134: configurable denormalization of extent fields into individual fields in schema con...
I have attached vmn_upd20140328a.zip after some fixes during regression. Latest regression results: 2 tests failed.
...
Vadim Nebogatov
04:26 PM Base Language Feature #1634: implement full native library (.so or DLL) support
The update 0328a fixes the conversion issue I've found and works OK with and without another P2J server running simul... Eugenie Lyzenko
01:41 PM Base Language Feature #1634: implement full native library (.so or DLL) support
The fix for conversion issue in @EnvironmentOps@. Based on the fact the @SessionManager.get()@ returns not null when ... Eugenie Lyzenko
01:01 PM Base Language Feature #1634: implement full native library (.so or DLL) support
I have found the regression with @EnvironmentOps@ trying MAJIC conversion on my local system in Linux with last updat... Eugenie Lyzenko
11:04 PM Base Language Feature #1634: implement full native library (.so or DLL) support
> @EnvironmentOps@ is designed only for server side usage. We should never try to use it on the client. Please use th... Eugenie Lyzenko
04:24 PM Base Language Bug #2133: fix precision for decimal, dynamic-extent variables
Constantin Asofiei wrote:
> Go ahead and fix this in @ControlFlowOps$InternalEntryCaller.valid@.
For the function...
Hynek Cihlar
04:12 PM Database Feature #2235: fix deployment issues related to dynamic database conversion resources
One thing I just realized will be an issue: it is possible to run the static conversion of a project on one platform ... Eric Faulhaber
09:27 AM Database Feature #2235: fix deployment issues related to dynamic database conversion resources
Please don't remove archives unless they have been uploaded mistakenly (and have a proper replacement). For example,... Greg Shah
07:00 AM Database Feature #2235: fix deployment issues related to dynamic database conversion resources
Committed to bzr rev 10498. Stanislav Lomany
01:50 PM User Interface Feature #1811: implement the AJAX client driver
This archive contains my later changes for interactive process implementation.
It is not the final release is only a...
Marius Gligor
12:37 PM Database Feature #2143 (Closed): prototype IKVM solution for Java UDFs compiled to CIL assemblies and load...
Eric Faulhaber

03/27/2014

05:12 PM User Interface Feature #1811: implement the AJAX client driver
Code Review 0326a - Part 2
I have finished going through all the code. It is really impressive.
4. It seems ...
Greg Shah
04:22 PM Database Bug #2222: WRITE event triggered too early
It seems that I have implemented wrong the new write to database event.
My initial approach and the fix for it was a...
Ovidiu Maxiniuc
02:43 PM User Interface Feature #2252: implement GUI client support
This is an interesting comment in the Colors and Fonts chapter of the Programming Interfaces book:
> In Windows, t...
Greg Shah
11:00 AM User Interface Feature #2252: implement GUI client support
> Do you mean font names or ordinals? If ordinals, see below.
I mean both, really.
I understand that the configurat...
Greg Shah
11:07 AM Base Language Feature #1634: implement full native library (.so or DLL) support
> And I think we can do this because the value of the propathOverride is only per the server instance.
No, this is...
Greg Shah
03:42 AM Database Feature #2134: configurable denormalization of extent fields into individual fields in schema con...
I have attached latest source code changes vmn_upd20140327a.zip after some fixes during regression. Regression starte... Vadim Nebogatov

03/26/2014

06:25 PM User Interface Feature #2252: implement GUI client support
Greg Shah wrote:
> * How does the 4GL determine the list of fonts that are available?
Do you mean font names or ord...
Constantin Asofiei
05:19 PM User Interface Feature #1811: implement the AJAX client driver
Code Review 0326a - Part 1
I am splitting this into multiple parts because I don't have time to finish the entire ...
Greg Shah
03:55 PM User Interface Feature #1811: implement the AJAX client driver
Please document how interactive child process support works on Windows (in the 4GL). When you are running a ChUI 4GL... Greg Shah
02:29 PM User Interface Feature #1811: implement the AJAX client driver
I implemented the interactive process for Swing ChUI client.
When a Linux OS command is executed from the converted ...
Marius Gligor
05:00 PM Base Language Feature #1634: implement full native library (.so or DLL) support
> No. We must be able to customize this value. That means calling "up" to the server to read a value from the directo... Eugenie Lyzenko
03:54 PM Base Language Feature #1634: implement full native library (.so or DLL) support
> For the point you noted the EnvironmentOps.getVersion().toStringMessage() can be replaced with string "10.2B". Is i... Greg Shah
02:47 PM Base Language Feature #1634: implement full native library (.so or DLL) support
> The problem is this code in Registry.java:
>
> ...
Eugenie Lyzenko
12:14 PM Base Language Feature #1634: implement full native library (.so or DLL) support
The problem is this code in Registry.java:... Greg Shah
10:33 AM Base Language Feature #1634: implement full native library (.so or DLL) support
For note #1
The reason of this change is I've found if we just use as expected to be working:...
Eugenie Lyzenko
09:51 AM Base Language Feature #1634: implement full native library (.so or DLL) support
Code Review 0326a
Everything here is much better. It is very close.
1. The changes in @EnvironmentOps.fixupProp...
Greg Shah
08:37 AM Base Language Feature #1634: implement full native library (.so or DLL) support
The update for review contains the changes for previous notes. Note I have changed @ThinClient@ to do not use @Platfo... Eugenie Lyzenko
04:48 PM Base Language Bug #2133: fix precision for decimal, dynamic-extent variables
Hynek Cihlar wrote:
> In Progress, function/procedure fixed-extent parameter's components are initialized to unknown...
Constantin Asofiei
04:40 PM Base Language Bug #2133: fix precision for decimal, dynamic-extent variables
Hynek Cihlar wrote:
> Constantin Asofiei wrote:
> > Hynek Cihlar wrote:
> > > The following code sample causes the...
Constantin Asofiei
04:21 PM Base Language Bug #2133: fix precision for decimal, dynamic-extent variables
Constantin Asofiei wrote:
> Hynek Cihlar wrote:
> > The following code sample causes the error message 'Calling pro...
Hynek Cihlar
04:15 PM Base Language Bug #2133: fix precision for decimal, dynamic-extent variables
Hynek Cihlar wrote:
> The following code sample causes the error message 'Calling procedure /home/hc/p34141_Untitled...
Constantin Asofiei
04:08 PM Base Language Bug #2133: fix precision for decimal, dynamic-extent variables
The following code sample causes the error message 'Calling procedure /home/hc/p34141_Untitled8.ped cannot input an i... Hynek Cihlar
03:51 PM Base Language Bug #2133: fix precision for decimal, dynamic-extent variables
In Progress, function/procedure fixed-extent parameter's components are initialized to unknown values when an unfixed... Hynek Cihlar
03:09 PM Base Language Bug #2133: fix precision for decimal, dynamic-extent variables
The converted code doesn't give the correct error message when assigning a fixed array to an indeterminate and alread... Hynek Cihlar
10:01 AM Base Language Bug #2133: fix precision for decimal, dynamic-extent variables
I have finished a release-candidate implementation for the decimal precision. I am testing it and also looking for ed... Hynek Cihlar
04:03 PM Base Language Feature #1608: implement full appserver support (from 4GL clients only)
Code Review 0326c
The changes look good. They can be runtime regression tested.
Greg Shah
01:54 PM Base Language Feature #1608: implement full appserver support (from 4GL clients only)
Fixes for note 142 (all persistent procedures need to be deleted by the Agent which created them) and a bug in sessio... Constantin Asofiei
03:49 PM Conversion Tools Feature #2251 (Closed): improve the call graph generation
Greg Shah
02:23 PM Conversion Tools Feature #2251 (Review): improve the call graph generation
Constantin Asofiei
02:23 PM Conversion Tools Feature #2251: improve the call graph generation
Branch revision 10518 was committed to the 10496/10497, both on trunk master on devsrv01 and filesrv01. Constantin Asofiei
02:34 PM User Interface Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects)
Vadim Gindin wrote:
> # Yes, Constantin. I really skipped this case. In your example @dynamicDown=0@ indeed. The pro...
Constantin Asofiei
02:10 PM User Interface Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects)
Vadim Gindin wrote:
> I forgot to add, that your short test case shows the problem @dynamicDown=0@ in another aspect...
Constantin Asofiei
01:23 PM Base Language Bug #2265 (Closed): Extent initializer compiles fine on scalar variable definition
Greg Shah
01:16 PM Base Language Bug #2265: Extent initializer compiles fine on scalar variable definition
I see now. Can you then close the issue? Hynek Cihlar
01:12 PM Base Language Bug #2265: Extent initializer compiles fine on scalar variable definition
Hynek Cihlar wrote:
> I probably wasn't descriptive enough. The code sample doesn't compile in Progress, it gives "T...
Constantin Asofiei
12:00 PM Base Language Bug #2265: Extent initializer compiles fine on scalar variable definition
I probably wasn't descriptive enough. The code sample doesn't compile in Progress, it gives "Too many initial values ... Hynek Cihlar
10:44 AM Base Language Bug #2265: Extent initializer compiles fine on scalar variable definition
Hynek, P2J will always convert valid 4GL code, which can compile in Progress. We do not want and will not start hunti... Constantin Asofiei
10:39 AM Base Language Bug #2265: Extent initializer compiles fine on scalar variable definition
The following code snippet compiles without errors producing invalid Java code.... Hynek Cihlar
10:34 AM Base Language Bug #2265 (Closed): Extent initializer compiles fine on scalar variable definition
Hynek Cihlar

03/25/2014

06:08 PM User Interface Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects)
I forgot to add, that your short test case shows the problem @dynamicDown=0@ in another aspect. This wrong behavior l... Vadim Gindin
02:47 PM User Interface Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects)
# Yes, Constantin. I really skipped this case. In your example @dynamicDown=0@ indeed. The problem appears when @disp... Vadim Gindin
04:47 AM User Interface Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects)
Vadim, about 0324a.zip: @GenericFrame@ and other files don't have the proper history number (is the same as the previ... Constantin Asofiei
05:02 PM Base Language Feature #1634: implement full native library (.so or DLL) support
Code Review 0325a
1. The @isUnderWindowsFamily()@ does not need to be implemented on the client side. The @getOpe...
Greg Shah
11:49 AM Base Language Feature #1634: implement full native library (.so or DLL) support
The update for review with reworked OS detection tools.
The questions to clarify:
1. @EnvironmentOps@ is the clas...
Eugenie Lyzenko
04:15 PM Conversion Tools Feature #2251: improve the call graph generation
> Regarding note 97: I think bzr merge should do the trick, to merge the branch into the trunk
Yes, that was my pl...
Greg Shah
02:12 PM Conversion Tools Feature #2251: improve the call graph generation
The update passed runtime and conversion testing (both server and MAJIC code).
Regarding note 97: I think @bzr mer...
Constantin Asofiei
03:49 AM Conversion Tools Feature #2251: improve the call graph generation
Greg Shah wrote:
> > BTW, to "release" a branch to the trunk, is there another way beside just copying the branch co...
Constantin Asofiei
04:10 PM User Interface Feature #1811: implement the AJAX client driver
> I'm struggle to understand the current implementation on interactive process for native ChUI client.
We don't n...
Greg Shah
06:02 AM User Interface Feature #1811: implement the AJAX client driver
Add code to synchronize with child process exit. Marius Gligor
03:05 PM Database Feature #2235: fix deployment issues related to dynamic database conversion resources
> All looks good except the change to @XmlFilePlugin@. This class is meant to be for generic AST processing and shoul... Stanislav Lomany
11:20 AM Database Feature #2235: fix deployment issues related to dynamic database conversion resources
Code review 20140325a:
All looks good except the change to @XmlFilePlugin@. This class is meant to be for generic ...
Eric Faulhaber
10:40 AM Database Feature #2235: fix deployment issues related to dynamic database conversion resources
Removed "development" mode. Stanislav Lomany
02:11 PM Base Language Bug #2133: fix precision for decimal, dynamic-extent variables
Hynek, the changes look good. How is the decimal precision working? Constantin Asofiei
11:47 AM Base Language Bug #2133: fix precision for decimal, dynamic-extent variables
Attached are changes based on the feedback from last review - @isExpressionOfExtentType@ was removed. I submitted the... Hynek Cihlar

03/24/2014

07:04 PM User Interface Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects)
Constantin Asofiei wrote:
> ..
> # check the shared frame cases: I suspect the current-iteration will be inherited ...
Vadim Gindin
05:53 PM User Interface Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects)
I've fixed almost all your remarks. Here are to moments:
# GenericFrame imports couldn't become simpler because of p...
Vadim Gindin
09:15 AM User Interface Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects)
Vadim, good work getting the algorithms implemented. See bellow for the code review for 0322a.zip and the next steps... Constantin Asofiei
03:26 PM Conversion Tools Feature #2251: improve the call graph generation
> BTW, to "release" a branch to the trunk, is there another way beside just copying the branch content (without the .... Greg Shah
02:21 PM Conversion Tools Feature #2251: improve the call graph generation
See the branch 10517 revision (which was rebased) for the latest changes (some doc changes and a minor fix). This is ... Constantin Asofiei
06:44 AM Conversion Tools Feature #2251: improve the call graph generation
Greg Shah wrote:
> 1. What is your general sense about the performance? Do you feel it is "good", "bad" or somethin...
Constantin Asofiei
03:24 PM User Interface Feature #2252: implement GUI client support
Some initial thoughts based on reviewing basic 4GL GUI examples:
1. Fonts
* By default the GUI uses the Windows...
Greg Shah
02:58 PM User Interface Feature #2252: implement GUI client support
The following is some early planning that was done (at my request) by Sergey Yevtushenko in 2011:
> -------- Origi...
Greg Shah
02:53 PM User Interface Feature #2252: implement GUI client support
Upon additional consideration of our implementation approaches in note 2, I think it makes the most sense to implemen... Greg Shah
02:44 PM User Interface Feature #2252: implement GUI client support
We will be implementing configurable control over all fonts, colors and other standard GUI configuration via our dire... Greg Shah
02:39 PM User Interface Feature #2252: implement GUI client support
Greg Shah wrote:
> We will NOT be implementing using a native control approach. This means we will not support the ...
Constantin Asofiei
02:32 PM User Interface Feature #2252: implement GUI client support
> I couldn't find a way to make the created windows modal. So, this allows multiple windows to be active, with all th... Greg Shah
02:30 PM User Interface Feature #2252: implement GUI client support
It is my understanding that all Progress GUI widgets have a backing native Windows control as the implementation. Th... Greg Shah
01:53 PM User Interface Feature #2252: implement GUI client support
Some initial findings about how 4GL implements the GUI interfaces:
# the @MESSAGE ... VIEW-AS ALERT-BOX@ statements ...
Constantin Asofiei
02:23 PM User Interface Feature #2264 (Closed): analyze how the GUI interface is implemented in 4GL
Constantin Asofiei
01:21 PM User Interface Feature #1811: implement the AJAX client driver
I fixed a minor bug when using colors.
We have to add 1 to FG and BG because according to the current P2J implement...
Marius Gligor
12:33 PM User Interface Feature #1811: implement the AJAX client driver
Here is the RC (release candidate) of VT-100 emulator. It is an implementation of DEC VT 100 video terminal specifica... Marius Gligor
12:27 PM Database Feature #2235: fix deployment issues related to dynamic database conversion resources
Eric, I recently met the rules loading code and it uses "non-development" approach, so, considering this and overall ... Stanislav Lomany
11:46 AM Database Feature #2235: fix deployment issues related to dynamic database conversion resources
Code review 20140324a/b:
Changes look good. I would like you to still please add a comment to @SchemaLoader.loadAs...
Eric Faulhaber
04:59 AM Database Feature #2235: fix deployment issues related to dynamic database conversion resources
Removed tabs. Stanislav Lomany
04:58 AM Database Feature #2235: fix deployment issues related to dynamic database conversion resources
Copies only specific rules. Removed tabs. Removed loading of schema-triggers.xml in runtime mode.
Would you like me ...
Stanislav Lomany
12:15 PM Base Language Feature #1634: implement full native library (.so or DLL) support
For efficiency, please only call down to the client once per session. Save off the value (in the server side) the fir... Greg Shah
12:12 PM Base Language Feature #1634: implement full native library (.so or DLL) support
No, we need to fix @EnvironmentOps.getOperatingSystem()@ and @EnvironmentOps.getPathSeparator()@ to query the client ... Greg Shah
11:55 AM Base Language Feature #1634: implement full native library (.so or DLL) support
There is still an issue in @SourceNameMapper.convertName()@ with the usage of @PlatformHelper.isUnderWindowsFamily()@... Eugenie Lyzenko
11:34 AM Base Language Feature #1634: implement full native library (.so or DLL) support
There is still an issue in SourceNameMapper.convertName() with the usage of PlatformHelper.isUnderWindowsFamily(). T... Greg Shah
11:28 AM Base Language Feature #1634: implement full native library (.so or DLL) support
> Eugenie, the changes in 0324a.zip look good.
Meaning I can run conversion and runtime regression testing for thi...
Eugenie Lyzenko
10:41 AM Base Language Feature #1634: implement full native library (.so or DLL) support
Eugenie, the changes in 0324a.zip look good. Constantin Asofiei
09:37 AM Base Language Feature #1634: implement full native library (.so or DLL) support
The update for your review contains clean up for @SourceNameMap@ class for @canonicalize()@ usage and javadoc small c... Eugenie Lyzenko
08:57 AM Base Language Feature #1634: implement full native library (.so or DLL) support
Eugenie Lyzenko wrote:
> Or we do not need any additional processing, just call @p2jMap.get(pname);@?
This one is c...
Constantin Asofiei
08:49 AM Base Language Feature #1634: implement full native library (.so or DLL) support
> When I changed the FILE-NAME and NAME implementation for external procedures, I discovered that these attributes an... Eugenie Lyzenko
07:36 AM Base Language Feature #1634: implement full native library (.so or DLL) support
Eugenie Lyzenko wrote:
> I do not understand why we need the changes here? If canonicalize() now works as before any...
Constantin Asofiei
 

Also available in: Atom