FWD » Core Development

06/14/2014

04:48 PM Base Language Bug #2293: Fixing an unfixed extent output parameter causes an error

Constantin Asofiei wrote:
> This suggests that the FieldReference instance created via that c'tor is read-only, and ... Eric Faulhaber

11:42 AM Base Language Bug #2293: Fixing an unfixed extent output parameter causes an error

Hynek Cihlar wrote:
> What I am trying to say is that if you construct the @FieldReference@ with any "non-indexed" c... Constantin Asofiei

10:49 AM Base Language Bug #2293: Fixing an unfixed extent output parameter causes an error

Greg Shah wrote:
> The actual reading (and writing if necessary) is deferred until the runtime code needs to access ... Hynek Cihlar

01:18 PM User Interface Feature #2252: implement GUI client support

> To be clear, I don't plan to provide any support that the 4GL doesn't already provide. For compatibility purposes, ... Constantin Asofiei

09:35 AM User Interface Feature #2252: implement GUI client support

Greg Shah wrote:
> Could Windows (or the 4GL) be mapping this as a "generic" sans-serif font that is actually differ... Constantin Asofiei

06:44 AM Base Language Bug #2197: fix the error message list cleanup when NO-ERROR mode is enabled and ERROR-STATUS:ERRO...

I made some tests and committed them into @/errlist@ subfolder. There are also your tests there. Most of my tests con... Vadim Gindin

06/13/2014

07:41 PM User Interface Feature #1789: implement the toggle-box widget

Another screen artifact has been found working with @toggle-box@ widget. Take a look at @toggle_box13.jpg@. The probl... Eugenie Lyzenko

02:17 PM User Interface Feature #1789: implement the toggle-box widget

This new update fixes the note for previous one and has cleaned widget drawing code. Looks like no additional changes... Eugenie Lyzenko

10:38 AM User Interface Feature #1789: implement the toggle-box widget

Code Review 0613a
The changes look good. The only thing to change is to save off the screen-buffer changes into t... Greg Shah

07:17 AM User Interface Feature #1789: implement the toggle-box widget

The support for @VALUE-CHANGED@ event has been added to the @ToggleBox@. The testcase to verify - @toggle_box10.p@. T... Eugenie Lyzenko

03:55 PM Database Feature #2312: match Progress collation in a SQL Server database

Ovidiu Maxiniuc wrote:
> The order in which strings are sorted in p4gl is detected by the attached Progress procedur... Eric Faulhaber

02:20 PM Database Feature #2312: match Progress collation in a SQL Server database

Forgot to add collation test for Sql Server. Ovidiu Maxiniuc

02:19 PM Database Feature #2312 (WIP): match Progress collation in a SQL Server database

I am not sure we create a user-defined collation in SQL Server :(. From my research we have to be lucky enough to fin... Ovidiu Maxiniuc

02:05 PM Base Language Feature #2287: implement missing type conversion for POLY cases in data type wrapper assign method

> Do you think that is a good idea to use another annotation instead of "chp_wrapper" for this case?
Yes, it will ... Greg Shah

02:02 PM Base Language Feature #2287: implement missing type conversion for POLY cases in data type wrapper assign method

When my rule from annotations/functions.rules is executed the return type of the function is not yet known. I think t... Marius Gligor

01:51 PM Base Language Feature #2287: implement missing type conversion for POLY cases in data type wrapper assign method

Code Review 0613b
This code in builtin_funcs.rules is definitely not right:... Greg Shah

12:34 PM Base Language Feature #2287: implement missing type conversion for POLY cases in data type wrapper assign method

Exactly right. The @on="false"@ is a way to make the contained rule part of the @else@ branch of the conditional. Greg Shah

12:33 PM Base Language Feature #2287: implement missing type conversion for POLY cases in data type wrapper assign method

I did the changes in the rules. Please let me know if my changes are OK. Marius Gligor

12:02 PM Base Language Feature #2287: implement missing type conversion for POLY cases in data type wrapper assign method

OK. Now I understand. The real structure was:... Marius Gligor

11:40 AM Base Language Feature #2287: implement missing type conversion for POLY cases in data type wrapper assign method

This is my first issue on which I'm working and require to define new rules.
I have one question please regarding ru... Marius Gligor

10:53 AM Base Language Feature #2287: implement missing type conversion for POLY cases in data type wrapper assign method

Code Review 0613a
1. The datetimetz imports have been expanded.
2. In functions.rules, this code is too restric... Greg Shah

09:45 AM Base Language Feature #2287: implement missing type conversion for POLY cases in data type wrapper assign method

Here is the attachement. Marius Gligor

09:45 AM Base Language Feature #2287: implement missing type conversion for POLY cases in data type wrapper assign method

Here are the latest changes that I made on this issue.
1. I implemented a rule to wrap the result of a DYNAMIC-FUN... Marius Gligor

10:21 AM Base Language Bug #2293: Fixing an unfixed extent output parameter causes an error

The idea of the FieldReference is to allow the delegation of reading/writing a database field to runtime code that is... Greg Shah

04:32 AM Base Language Bug #2293: Fixing an unfixed extent output parameter causes an error

Actually, setting the sizer in the constructor @FieldReference(Database, Class, String)@ makes sense. So the question... Hynek Cihlar

04:11 AM Base Language Bug #2293: Fixing an unfixed extent output parameter causes an error

In the constructor @FieldReference(Database, Class<?>, String)@ the setter is not set and the sizer is. This is suspi... Hynek Cihlar

02:06 AM User Interface Feature #1805: add missing UI method support

I prepared the next update that contains last corrections corresponding to your last notes. I did not add new header ... Vadim Gindin

06/12/2014

05:02 PM Database Feature #2312: match Progress collation in a SQL Server database

When sorting on a text column, Progress sorts its rows differently in certain cases than PostgreSQL does by default, ... Eric Faulhaber

10:31 AM User Interface Feature #2252: implement GUI client support

To be clear, I don't plan to provide any support that the 4GL doesn't already provide. For compatibility purposes, w... Greg Shah

10:25 AM User Interface Feature #2252: implement GUI client support

> Greg Shah wrote:
> > Include any information needed for the FONT-TABLE to be configured as well (e.g. font to font ... Constantin Asofiei

10:18 AM User Interface Feature #2252: implement GUI client support

I've added these files to the testcases repo:
# @uast/fonts/system-metrics/font-list.txt@ - list of fonts standard f... Constantin Asofiei

09:07 AM Base Language Feature #2287: implement missing type conversion for POLY cases in data type wrapper assign method

Code Review 0612a
The changes look fine.
> The only solution remains to change the conversion and to wrap the r... Greg Shah

06:15 AM Base Language Feature #2287: implement missing type conversion for POLY cases in data type wrapper assign method

Unfortunately my idea to fix the note #13 does not work. Using the following test case:... Marius Gligor

09:05 AM User Interface Feature #1789: implement the toggle-box widget

Code Review 0611b
The changes look fine. Greg Shah

10:24 PM User Interface Feature #1789: implement the toggle-box widget

With this update correct handling for @ASSIGN@, screen value and variable value differences added. Also for now I hav... Eugenie Lyzenko

09:02 AM Base Language Feature #1628: fix any incompatibilities or missing features of NO-ECHO support

I think our approach to explicit terminal stream processing has been poor in the past. We "took advantage" of using ... Greg Shah

06:24 AM User Interface Feature #1805: add missing UI method support

Vadim Gindin wrote:
> Questions.
> 1) Am I using the right IDs?
Yes, the IDs are right.
> 3) May be we should del... Constantin Asofiei

06:12 AM Base Language Bug #2197: fix the error message list cleanup when NO-ERROR mode is enabled and ERROR-STATUS:ERRO...

Vadim Gindin wrote:
> Current implementation for me does not seems clear. Why don't we use a Stack structure to main... Constantin Asofiei

05:11 AM Base Language Bug #2197: fix the error message list cleanup when NO-ERROR mode is enabled and ERROR-STATUS:ERRO...

It seems we need not only additional errors list. We also need additional flags like @error@, @pending@ and some othe... Vadim Gindin

06/11/2014

07:19 PM Base Language Feature #1628: fix any incompatibilities or missing features of NO-ECHO support

I need to determine Terminal stream. But got a problem:... Evgeny Kiselev

05:18 PM User Interface Feature #1789: implement the toggle-box widget

> 1. Please rename @ToggleBoxImpl.drawChekBox()@ to @ToggleBoxImpl.drawCheckBox()@.
OK. Sorry this was just syntax... Eugenie Lyzenko

04:53 PM User Interface Feature #1789: implement the toggle-box widget

Code Review 0611a
This is a very good start.
1. Please rename @ToggleBoxImpl.drawChekBox()@ to @ToggleBoxImpl.d... Greg Shah

04:14 PM User Interface Feature #1789: implement the toggle-box widget

This update adds base skeleton for @ToggleBox@ runtime implementation. This is very early version just for review the... Eugenie Lyzenko

04:30 PM User Interface Feature #2252: implement GUI client support

OK. Automate the generation as much as is reasonable. Include any information needed for the FONT-TABLE to be confi... Greg Shah

03:58 PM User Interface Feature #2252: implement GUI client support

Greg Shah wrote:
> Please write a program that can inspect and dump these values from a legacy system. Is it suffici... Constantin Asofiei

02:32 PM User Interface Feature #2252: implement GUI client support

The results are unfortunate but understandable.
> the metrics are not even the same across JRE implementations: Op... Greg Shah

01:57 PM User Interface Feature #2252: implement GUI client support

About fond rendering: no useful info found in Java FX or a way to switch the font rasterizer. More, the metrics are ... Constantin Asofiei

10:02 AM Base Language Feature #2287: implement missing type conversion for POLY cases in data type wrapper assign method

Code Review 0611a
The changes look good.
> 2. Regarding the RAW type on the customer's Linux server I've got th... Greg Shah

08:24 AM Base Language Feature #2287: implement missing type conversion for POLY cases in data type wrapper assign method

1. I've fixed the issues from your code review.
2. Regarding the RAW type on the customer's Linux server I've got ... Marius Gligor

06/10/2014

01:45 PM Base Language Feature #2287: implement missing type conversion for POLY cases in data type wrapper assign method

Code Review 0610a
It looks very good. Some notes:
1. For the raw(BDT) constructor, please check if a properly ... Greg Shah

11:35 AM Base Language Feature #2287: implement missing type conversion for POLY cases in data type wrapper assign method

Today I did tests using test cases like Constantin suggested. The results are the same as for message cases.
The exp... Marius Gligor

11:41 AM Database Feature #2319: support for dialect-specific keywords in NameConverter

Because each SQL dialect has its own set of reserved keywords the @NameConverter@ must be aware and convert the names... Ovidiu Maxiniuc

11:12 AM Database Feature #2319 (New): support for dialect-specific keywords in NameConverter

Ovidiu Maxiniuc

11:20 AM User Interface Feature #1789: implement the toggle-box widget

Code Review 0610a
It looks good. Greg Shah

11:17 AM User Interface Feature #1789: implement the toggle-box widget

Implemented error message and clearing other questions.
Start planning to implement runtime processing. Eugenie Lyzenko

10:30 AM User Interface Feature #1789: implement the toggle-box widget

Code Review 0609b
1. The GenericWidget.isChecked()/setChecked() methods should simply execute: @throw new RuntimeE... Greg Shah

11:02 AM Base Language Feature #1628: fix any incompatibilities or missing features of NO-ECHO support

> > 5. The @GenericFrame.view(FrameElement[] data)@ use of @cacheWidgetIDs()@ seems like it will never do anything. ... Greg Shah

08:26 PM Base Language Feature #1628: fix any incompatibilities or missing features of NO-ECHO support

Greg Shah wrote:
> Code Review 0607a
>
> 1. @GenericFrame@ is missing a history entry.
> 2. Can @GenericFrame.re... Evgeny Kiselev

06/09/2014

07:02 PM User Interface Feature #1789: implement the toggle-box widget

Added stubs for compiling the converted code. The message for @UNKNOWN@ set value is not added yet.
The question:
... Eugenie Lyzenko

05:54 PM User Interface Feature #1789: implement the toggle-box widget

> Please test how unknown value works for the CHECKED attribute and implement it in ToggleBoxWidget.setChecked(logica... Eugenie Lyzenko

04:41 PM User Interface Feature #1789: implement the toggle-box widget

Code Review 0609a
Please test how unknown value works for the CHECKED attribute and implement it in @ToggleBoxWidg... Greg Shah

04:40 PM User Interface Feature #1789: implement the toggle-box widget

> 1. To define isChecked() to the CommonWidget interface
Yes, you certainly need to add stubbed support for the CH... Greg Shah

04:30 PM User Interface Feature #1789: implement the toggle-box widget

Yes, partially the conversion has already been implemented. Except handling of the @R/W@ attribute @CHECKED@. I have ... Eugenie Lyzenko

03:04 PM User Interface Feature #1789: implement the toggle-box widget

> CHUI does not make the extra space. I think in theory it is possible to simulate [ ] label layout in CHUI by defini... Greg Shah

12:16 PM Base Language Feature #2287: implement missing type conversion for POLY cases in data type wrapper assign method

Marius Gligor wrote:
> message v1 + dynamic-function("f2").
> message v1 - dynamic-function("f2").
> message dynam... Constantin Asofiei

12:02 PM Base Language Feature #2287: implement missing type conversion for POLY cases in data type wrapper assign method

For DynamicOps.plus() and DynamicOps.minus() implementation I'm using the following test case:
... Marius Gligor

12:01 PM User Interface Feature #2252: implement GUI client support

Related to fonts: I've managed to find the formula used by 4GL to compute the @pixels-per-row@ and @pixels-per-column... Constantin Asofiei

11:33 AM Base Language Feature #1628: fix any incompatibilities or missing features of NO-ECHO support

Code Review 0607a
1. @GenericFrame@ is missing a history entry.
2. Can @GenericFrame.refreshWidgets()@ could us... Greg Shah

08:58 AM Base Language Feature #1628: fix any incompatibilities or missing features of NO-ECHO support

Fixed all issues from note #22, #23, #24
testcases:... Evgeny Kiselev

06/07/2014

07:44 AM User Interface Feature #1805: add missing UI method support

Haste makes waste - It's about me in this case. I'm sorry.
I'm working on your notes. I'm really forgot about fie... Vadim Gindin

06/06/2014

07:57 PM User Interface Feature #1790: implement menu support

For now, we can only do the ChUI version but it should be designed to add GUI later. There will be work on both conv... Greg Shah

07:53 PM User Interface Feature #1789: implement the toggle-box widget

Testcases have been committed in bzr as 1146. Eugenie Lyzenko

07:39 PM User Interface Feature #1789: implement the toggle-box widget

The attached screens are to illustrate point #1 and #2 above. The @ATTR-SPACE@ does not affect the @TOGGLE-BOX@ looki... Eugenie Lyzenko

01:28 PM User Interface Feature #1789: implement the toggle-box widget

ATTR-SPACE can be put into the frame phrase:... Greg Shah

12:37 PM User Interface Feature #1789: implement the toggle-box widget

> 1. Check if @ATTR-SPACE@ or other options can have an impact on the label positioning. All the labels in your examp... Eugenie Lyzenko

01:29 PM Base Language Feature #2232: finish testing the wrapped mode using the web services exposed by the testing server

In wrapped mode, the request and the response are both treated as a string with the serialized XML contents of the SO... Constantin Asofiei

12:50 PM Base Language Bug #2197: fix the error message list cleanup when NO-ERROR mode is enabled and ERROR-STATUS:ERRO...

Vadim, regarding Q2 in note 4: as Greg mentioned, we can't clean the list too early and the right place to me looks l... Constantin Asofiei

12:28 PM Base Language Feature #2287: implement missing type conversion for POLY cases in data type wrapper assign method

I would really like to avoid such a flag. The reason is simple: I want the wrapper classes (BDT subclasses) to limit... Greg Shah

11:21 AM Base Language Feature #2287: implement missing type conversion for POLY cases in data type wrapper assign method

regarding "dynamic" flag I think that is better to set on this call ControlFlowOps.invokeDynamicFunctionImpl Marius Gligor

11:20 AM Base Language Feature #2287: implement missing type conversion for POLY cases in data type wrapper assign method

Marius Gligor wrote:
> In order to know if a BDT is the result of a DYNAMIC-FUNCTION call I have an idea.
Your idea... Constantin Asofiei

11:00 AM Base Language Feature #2287: implement missing type conversion for POLY cases in data type wrapper assign method

Here are the latest changes that I did so far for other BDT's like handle, longchar, raw, memptr, date, raw etc.
I... Marius Gligor

10:20 AM User Interface Feature #1805: add missing UI method support

Vadim Gindin wrote:
> The update passed regression testing and have committed to bzr. Rev #10545
Some issues about ... Constantin Asofiei

09:47 AM User Interface Feature #1805: add missing UI method support

The update passed regression testing and have committed to bzr. Rev #10545 Vadim Gindin

10:06 AM User Interface Feature #2146 (Closed): add support for FIRST-TAB-ITEM/NEXT-TAB-ITEM attributes (needed for server)

Greg Shah

09:49 AM User Interface Feature #2146: add support for FIRST-TAB-ITEM/NEXT-TAB-ITEM attributes (needed for server)

The update passed regression testing and have committed to bzr. Rev #10545 Vadim Gindin

10:06 AM User Interface Feature #2144 (Closed): add minimum runtime support for methods (server)

Greg Shah

06/05/2014

09:55 AM User Interface Feature #1789: implement the toggle-box widget

Please add tests for the following cases:
1. Check if ATTR-SPACE or other options can have an impact on the label ... Greg Shah

07:03 AM User Interface Feature #1789: implement the toggle-box widget

After analyzing of the @ABL Reference@ book the testcases to demonstrate the behavior in all possible options accordi... Eugenie Lyzenko

09:19 AM Runtime Infrastructure Bug #2305 (Closed): context-local vars need to be reset in a predetermined order

Greg Shah

02:54 AM Runtime Infrastructure Bug #2305: context-local vars need to be reset in a predetermined order

Attached was committed to bzr rev 10544. Constantin Asofiei

12:22 AM Runtime Infrastructure Bug #2305: context-local vars need to be reset in a predetermined order

Update 0601b looks good to me, nice work. Please note that header entry number 098 is duplicated in @TemporaryBuffer@. Eric Faulhaber

06/04/2014

06:34 PM Database Feature #2220: dynamic query methods which require implementation

Update for review with indexInformation implemented. Stanislav Lomany

10:02 AM Base Language Feature #2287: implement missing type conversion for POLY cases in data type wrapper assign method

Excellent point/question.
Marius: please do implement the missing functionality in the util/DynamicOps class as ... Greg Shah

09:56 AM Base Language Feature #2287: implement missing type conversion for POLY cases in data type wrapper assign method

Greg: will the DynamicOps APIs be implemented with this task or another? Constantin Asofiei

06/03/2014

06:09 PM Runtime Infrastructure Feature #2316: improve directory XML encoding

-------- Original Message --------
Subject: directory.xml - an idea to the backlog
Date: Tue, 03 Jun 2014 22:16:0... Greg Shah

06:07 PM Runtime Infrastructure Feature #2316 (New): improve directory XML encoding

Greg Shah

04:51 PM Database Bug #2315: CAN-FIND() conversion throws exception if record is unavailable for WHERE clause.

Details are in issue #2301, notes 32, 34, 35. Vadim Nebogatov

04:49 PM Database Bug #2315 (Closed): CAN-FIND() conversion throws exception if record is unavailable for WHERE cla...

Vadim Nebogatov

04:32 PM Database Feature #2314: make the _meta database conversion and runtime optional

For projects which don't require/use the metadata DB, the conversion process should not generate the @dmo._meta@ DMO'... Constantin Asofiei

04:31 PM Database Feature #2314 (New): make the _meta database conversion and runtime optional

Constantin Asofiei

02:41 PM Base Language Feature #2287: implement missing type conversion for POLY cases in data type wrapper assign method

Code Review 0603b
The changes look good. Greg Shah

12:34 PM Base Language Feature #2287: implement missing type conversion for POLY cases in data type wrapper assign method

The archive contains the implementation of decimal wrapper type conversion for POLY cases. Marius Gligor

11:29 AM Base Language Feature #2287: implement missing type conversion for POLY cases in data type wrapper assign method

Until to fix the conversion issue I found a temporary solution to test the behaviour on P2J by swap the _isEqual oper... Marius Gligor

10:05 AM Base Language Feature #2287: implement missing type conversion for POLY cases in data type wrapper assign method

Code Review 0603a
The changes look good. I'm glad you were able to fix the problem without extra conversion-time ... Greg Shah

09:55 AM Base Language Feature #2287: implement missing type conversion for POLY cases in data type wrapper assign method

I haven't reviewed your changes yet. But while you were editing the code, I wrote this:
> When this expression: _is... Greg Shah

09:30 AM Base Language Feature #2287: implement missing type conversion for POLY cases in data type wrapper assign method

I added new BDT types for conversion to a logical value.
I found and implemented the conversion rules for date and h... Marius Gligor

09:09 AM Base Language Feature #2287: implement missing type conversion for POLY cases in data type wrapper assign method

I added the line in my configuration file and now works properly.
Thanks Marius Gligor

08:09 AM Base Language Feature #2287: implement missing type conversion for POLY cases in data type wrapper assign method

Marius Gligor wrote:
> I have no such line in my p2j.cfg.xml.
> My configuration file is for <!-- Majic-specific P2... Constantin Asofiei

08:05 AM Base Language Feature #2287: implement missing type conversion for POLY cases in data type wrapper assign method

I have no such line in my p2j.cfg.xml.
My configuration file is for <!-- Majic-specific P2J main configuration -->
Marius Gligor

07:23 AM Base Language Feature #2287: implement missing type conversion for POLY cases in data type wrapper assign method

Marius Gligor wrote:
> 2. Another problem that I found is related to initial values for P4G primitives.
I think thi... Constantin Asofiei

07:17 AM Base Language Feature #2287: implement missing type conversion for POLY cases in data type wrapper assign method

1. Working to add more BDT types for conversion inside the logical class and I found a blocked issue.
I have the fo... Marius Gligor

05:04 AM Base Language Feature #1630 (Closed): implement support for UNBUFFERED in I/O statements

Greg Shah

08:12 PM Base Language Feature #1630: implement support for UNBUFFERED in I/O statements

Committed to bzr rev. 10542. Evgeny Kiselev

02:33 AM User Interface Feature #1805: add missing UI method support

PS: make sure to merge your update with the latest bzr version. Constantin Asofiei

02:31 AM User Interface Feature #1805: add missing UI method support

Review for 0602a:
# when we have APIs exposed via network servers (i.e. ClientExports), is best to avoid (de)seriali... Constantin Asofiei

06/02/2014

05:20 PM User Interface Feature #2252: implement GUI client support

Code Review 0602a
The code looks good. There are a few files that are missing the standard headers and so forth, ... Greg Shah

03:20 AM User Interface Feature #2252: implement GUI client support

Merged with the latest P2J updates (rules files). Marius Gligor

05:02 PM User Interface Feature #1805: add missing UI method support

I corrected implementation corresponding to the last notes. Please take a look. Vadim Gindin

03:45 PM Database Feature #2313 (Hold): match Progress collation on a PostgreSQL database on Windows

Eric Faulhaber

03:44 PM Database Feature #2312 (WIP): match Progress collation in a SQL Server database

Eric Faulhaber

02:11 PM Base Language Feature #2287: implement missing type conversion for POLY cases in data type wrapper assign method

Code Review 0602b
The changes look good. I assume you are working on the same changes for the other BDT types. Greg Shah

12:20 PM Base Language Feature #2287: implement missing type conversion for POLY cases in data type wrapper assign method

1. I've started to work on this issue by executing the provided test case on P4G environment and I found the followin... Marius Gligor

02:01 AM Base Language Feature #2287 (WIP): implement missing type conversion for POLY cases in data type wrapper assign...

Marius Gligor

12:15 PM Database Bug #18: issues with ne/equal and true/false conversion in WHERE clauses

This task is not known to affect any customer code; removing from M11 accordingly. If testing indicates otherwise, we... Eric Faulhaber

12:10 PM Base Language Bug #2288 (Closed): incorrect conversion and results for unknown value comparisons

Update 0421a passed runtime regression testing and was committed to bzr rev. 10523 (although in the commit message I ... Eric Faulhaber

09:32 AM User Interface Feature #1806 (Closed): implement UNLESS-HIDDEN

Greg Shah

09:20 AM User Interface Feature #1806: implement UNLESS-HIDDEN

The regression tasting has been passed. The update @...0530a@ has been committed in bzr as 10540. Eugenie Lyzenko

09:15 AM User Interface Feature #1806: implement UNLESS-HIDDEN

The CTRL-C testing has been completed. There are no regressions found. Had to run 3-way tests in a separate session t... Eugenie Lyzenko

08:36 AM Base Language Feature #2311 (Closed): rewrite parsing of handle chains and other misc parser changes

Greg Shah

06:40 AM Base Language Feature #2311 (Review): rewrite parsing of handle chains and other misc parser changes

Greg Shah wrote:
> Excellent! Please check it in and distribute it.
Committed to bzr rev 10539. The task can be clo... Constantin Asofiei

06:24 AM Base Language Feature #2311: rewrite parsing of handle chains and other misc parser changes

Excellent! Please check it in and distribute it. Greg Shah

07:33 AM Runtime Infrastructure Bug #2305: context-local vars need to be reset in a predetermined order

0601b.zip passed runtime testing - I've ran it twice, and no @ContextLocalCleanupException@ or surviving context-loca... Constantin Asofiei

06:28 AM Runtime Infrastructure Bug #2305: context-local vars need to be reset in a predetermined order

That is really great work! The remote connection problem is a subtle one. Greg Shah

06:34 AM Base Language Feature #1630: implement support for UNBUFFERED in I/O statements

Great! Please do commit it and distribute it. Greg Shah

08:08 PM Base Language Feature #1630: implement support for UNBUFFERED in I/O statements

Update @evk_upd20140528a.zip@ has passed regression testing and ready to commit. Evgeny Kiselev

06/01/2014

02:42 PM Runtime Infrastructure Bug #2305 (Review): context-local vars need to be reset in a predetermined order

This contains the fix for RemotePersistence and note 7 (remote connection). Is going into testing now. Constantin Asofiei

02:22 PM Runtime Infrastructure Bug #2305: context-local vars need to be reset in a predetermined order

Constantin Asofiei wrote:
> Before pushing for a fix for the -remoteFactory- RemotePersitence problem, I want to deb... Constantin Asofiei

12:22 PM Runtime Infrastructure Bug #2305: context-local vars need to be reset in a predetermined order

Eric Faulhaber wrote:
> I still don't understand (regarding the second case), why @PersistenceFactory.getInstance@ wo... Constantin Asofiei

08:41 AM Base Language Feature #2311: rewrite parsing of handle chains and other misc parser changes

0531b.passed conversion testing - MAJIC has 1 case and the server project has 2 cases where RecordBuffer.start/EndBat... Constantin Asofiei

05/31/2014

03:31 PM Base Language Feature #2311: rewrite parsing of handle chains and other misc parser changes

Greg Shah wrote:
> What do you suggest for the assignment stmts issue?
The fix in the end was pretty simple - I jus... Constantin Asofiei

09:09 PM Base Language Feature #1630: implement support for UNBUFFERED in I/O statements

Greg Shah wrote:
> Code Review 0528a
>
> The code looks good.
>
> Have you finished testing all of your testca... Evgeny Kiselev

08:37 PM User Interface Feature #1806: implement UNLESS-HIDDEN

Code Review 0530a
I agree, the changes are safe. No additional testing is needed. Greg Shah

05/30/2014

07:39 PM Base Language Feature #2311: rewrite parsing of handle chains and other misc parser changes

What do you suggest for the assignment stmts issue? We can defer it, but we may just hit it in future code. If that... Greg Shah

05:56 PM Base Language Feature #2311: rewrite parsing of handle chains and other misc parser changes

Greg Shah wrote:
> OK, then go ahead, check in and distribute it.
Committed to bzr rev 10538.
As a reminder, the... Constantin Asofiei

05:40 PM Base Language Feature #2311: rewrite parsing of handle chains and other misc parser changes

OK, then go ahead, check in and distribute it. Greg Shah

05:38 PM Base Language Feature #2311: rewrite parsing of handle chains and other misc parser changes

Greg Shah wrote:
> You're confident that the handle unwrapping changes are safe?
MAJIC uses only @unwrapWidget@, an... Constantin Asofiei

05:01 PM Base Language Feature #2311: rewrite parsing of handle chains and other misc parser changes

You're confident that the handle unwrapping changes are safe? Greg Shah

04:52 PM Base Language Feature #2311: rewrite parsing of handle chains and other misc parser changes

Greg Shah wrote:
> I am fine with the changes. At this point, is there anything left to do?
Conversion testing pas... Constantin Asofiei

04:41 PM Base Language Feature #2311: rewrite parsing of handle chains and other misc parser changes

Code Review 0530b
I am fine with the changes. At this point, is there anything left to do? Greg Shah

04:25 PM Base Language Feature #2311: rewrite parsing of handle chains and other misc parser changes

OK, the attached version contains this:
# @progress.g@ history fixed
# @methods_attributes.rules@ - was added a not... Constantin Asofiei

04:05 PM Base Language Feature #2311: rewrite parsing of handle chains and other misc parser changes

> Thus, is there anything else I should do at this point? Because I doubt the COM_INVOCATION/COM_METHOD/COM_PARAMETER... Greg Shah

03:29 PM Base Language Feature #2311: rewrite parsing of handle chains and other misc parser changes

Constantin Asofiei wrote:
> What I think ECW needs is just some simplifications of the cases when COLON nodes are in... Constantin Asofiei

03:01 PM Base Language Feature #2311: rewrite parsing of handle chains and other misc parser changes

Constantin Asofiei wrote:
> > 1. The com_invocation/com_method processing in methods_attributes.rules is removed. I... Constantin Asofiei

02:17 PM Base Language Feature #2311: rewrite parsing of handle chains and other misc parser changes

> BTW, are there other POLY tests, beside the ones at #2050?
Yes, dynamic_function_context_analysis.p is useful to... Greg Shah

01:46 PM Base Language Feature #2311: rewrite parsing of handle chains and other misc parser changes

Greg Shah wrote:
> Code Review 0526f
>
> Generally, I am happy with the changes. The methods_attributes.rules is ... Constantin Asofiei

07:38 PM User Interface Feature #1806: implement UNLESS-HIDDEN

This update merges @UNLESS-HIDDEN@ changed with the recent code base. I think the tasks are pretty independent and me... Eugenie Lyzenko

03:49 PM User Interface Feature #1806: implement UNLESS-HIDDEN

The main part has been completed without regressions in two rounds. Continue with the CTRL-C part. Eugenie Lyzenko

04:58 PM Database Feature #2296 (Closed): update record buffer validation to prevent database index overflow

Eric Faulhaber

08:11 AM Base Language Feature #1630: implement support for UNBUFFERED in I/O statements

Code Review 0528a
The code looks good.
Have you finished testing all of your testcases? If it is fully working... Greg Shah

08:10 PM Base Language Feature #1630: implement support for UNBUFFERED in I/O statements

>1. Please merge the code up to the latest P2J level in bzr (Stream.java is missing changes).
>2. In both classes, p... Evgeny Kiselev

08:06 AM User Interface Feature #1789: implement the toggle-box widget

For now, we don't have GUI support yet in the rest of the client. So you can only implement ChUI right now. Later o... Greg Shah

05/29/2014

05:54 PM User Interface Feature #1806: implement UNLESS-HIDDEN

The conversion testing has been completed without any differences in converted Java code. Started the regression test... Eugenie Lyzenko

04:26 PM User Interface Feature #1806: implement UNLESS-HIDDEN

Code Review 0529a
The changes look good. Please get them regression tested. Greg Shah

01:09 PM User Interface Feature #1806: implement UNLESS-HIDDEN

Finally I have got all local tests passed. The new changes in update for review includes:
1. Removing @LabelImpl@ cl... Eugenie Lyzenko

05:52 PM User Interface Feature #1789: implement the toggle-box widget

> Start by writing testcases to demonstrate the toggle-box behavior and all its options.
Do we need to cover only ... Eugenie Lyzenko

05:26 PM Base Language Feature #2311: rewrite parsing of handle chains and other misc parser changes

Code Review 0526f
Generally, I am happy with the changes. The methods_attributes.rules is so much simpler now. Ni... Greg Shah

05:38 AM Base Language Feature #2311: rewrite parsing of handle chains and other misc parser changes

A remainder issue is an investigation of the @annotations/assignment_style_stmt_rewriting.rules@ file: this will spli... Constantin Asofiei

01:11 PM User Interface Feature #1805: add missing UI method support

Vadim Gindin wrote:
> Constantin, thank you for the good test. It really will be useful.
>
> Here are the problem... Constantin Asofiei

07:26 AM User Interface Feature #1805: add missing UI method support

Constantin, thank you for the good test. It really will be useful.
Here are the problems I can formulate at this mom... Vadim Gindin

05/28/2014

04:21 PM User Interface Feature #1806: implement UNLESS-HIDDEN

> If everything is working in your local tests, then you can go into regression testing (both conversion and runtime)... Eugenie Lyzenko

03:37 PM User Interface Feature #1806: implement UNLESS-HIDDEN

> The changes are good, except that the @hidden()@ method should be removed from @LabeledWidget@ instead of being com... Eugenie Lyzenko

03:29 PM User Interface Feature #1806: implement UNLESS-HIDDEN

Code Review 0528b
The changes are good, except that the @hidden()@ method should be removed from @LabeledWidget@ i... Greg Shah

02:59 PM User Interface Feature #1806: implement UNLESS-HIDDEN

> Yes, please do explicitly cast it. Otherwise it is confusing to future readers/maintainers of the code.
OK. The ... Eugenie Lyzenko

01:49 PM User Interface Feature #1806: implement UNLESS-HIDDEN

> If not add hidden() to LabeledWidget - we will need explicit casting fin to some class that have hidden() inside th... Greg Shah

01:42 PM User Interface Feature #1806: implement UNLESS-HIDDEN

> 1. The hidden() method of LabeledWidget is already present in the Widget interface. LabeledDataContainer extends Fi... Eugenie Lyzenko

12:49 PM User Interface Feature #1806: implement UNLESS-HIDDEN

Code Review 0528a
I like the approach. My only questions:
1. The @hidden()@ method of @LabeledWidget@ is alrea... Greg Shah

10:35 AM User Interface Feature #1806: implement UNLESS-HIDDEN

The fix for hidden widgets has been added to the update.
The goal is to suppress label text drawing for hidden wid... Eugenie Lyzenko

03:54 PM User Interface Feature #1789: implement the toggle-box widget

Start by writing testcases to demonstrate the toggle-box behavior and all its options.
Then add conversion support... Greg Shah

02:38 PM Base Language Bug #2293: Fixing an unfixed extent output parameter causes an error

Constantin Asofiei wrote:
> OK, this is a conversion problem, if the fix is not trivial leave it for another time.
... Hynek Cihlar

12:43 PM Base Language Bug #2293: Fixing an unfixed extent output parameter causes an error

Hynek Cihlar wrote:
> Constantin Asofiei wrote:
> > Not sure if you are aware, table fields can not be set as dynam... Constantin Asofiei

12:35 PM Base Language Bug #2293: Fixing an unfixed extent output parameter causes an error

Constantin Asofiei wrote:
> Not sure if you are aware, table fields can not be set as dynamic extent in 4GL. How doe... Hynek Cihlar

11:52 AM Base Language Bug #2293: Fixing an unfixed extent output parameter causes an error

Hynek Cihlar wrote:
> Is the conversion of output extent fields supposed to work? When converting a temp-table field... Constantin Asofiei

11:45 AM Base Language Bug #2293: Fixing an unfixed extent output parameter causes an error

Is the conversion of output extent fields supposed to work? When converting a temp-table field passed as output param... Hynek Cihlar

10:36 AM Base Language Bug #2293: Fixing an unfixed extent output parameter causes an error

By the way, we can remove the need to call @setParameter@ from the converted code completely. For example, when @exte... Hynek Cihlar

01:45 PM Base Language Feature #1630: implement support for UNBUFFERED in I/O statements

Code Review 0523a
The changes look good. I have some minor comments and questions:
1. Please merge the code up to ... Greg Shah

12:58 PM User Interface Feature #1805: add missing UI method support

Vadim Gindin wrote:
> Actually I found that FrameWidget has the frame property, that can be used for that case. I on... Constantin Asofiei

12:49 PM Database Feature #2296: update record buffer validation to prevent database index overflow

The update was committed to bzr in rev 10537 and distributed by mail. Ovidiu Maxiniuc

09:59 AM Database Feature #2296: update record buffer validation to prevent database index overflow

Here is the summary of all the 8 tests:
20140523_172349 (CTR+C): massive fails
20140523_195225 (main): all test set... Ovidiu Maxiniuc

12:24 PM Base Language Feature #2311: rewrite parsing of handle chains and other misc parser changes

The ges_upd20140428a.zip (amongs other changes) rewrites the AST tree for a chaining in a handle, com-handle or objec... Constantin Asofiei

12:09 PM Base Language Feature #2311 (Closed): rewrite parsing of handle chains and other misc parser changes

Constantin Asofiei

05/27/2014

04:34 PM User Interface Feature #1806: implement UNLESS-HIDDEN

Code Review 0523a
The changes look good.
> So this is the general bug in DISPLAY statement handling and if ther... Greg Shah

04:15 PM User Interface Feature #1805: add missing UI method support

First of all I actualized testcases. See folders MOVE_BEFORE_TAB_ITEM and first_tab_item.
Constantin Asofiei wrote... Vadim Gindin

01:35 PM User Interface Feature #1805: add missing UI method support

Vadim Gindin wrote:
> Here is the first working variant. It works for simple cases (without nested frames and with o... Constantin Asofiei

02:33 PM Database Feature #2296: update record buffer validation to prevent database index overflow

Ovidiu Maxiniuc wrote:
> What do you think of the change in RecordBuffer.java:10134, namely restricting the flush() ... Eric Faulhaber

01:48 PM Database Feature #2296: update record buffer validation to prevent database index overflow

Eric Faulhaber wrote:
> Code review 20140523a:
>
> Update looks good. The findings you documented in the code com... Ovidiu Maxiniuc

12:55 PM Database Feature #2296: update record buffer validation to prevent database index overflow

Code review 20140523a:
Update looks good. The findings you documented in the code comments regarding the Progress ... Eric Faulhaber

09:06 AM Database Feature #2296: update record buffer validation to prevent database index overflow

The second execution took extremely long to finish.
There were a couple less failures in CTRL+C part.
The main pa... Ovidiu Maxiniuc

01:59 PM Base Language Bug #2293: Fixing an unfixed extent output parameter causes an error

Constantin Asofiei wrote:
> Hynek,
>
> The approach loosk good, just a question about how the converted code looks: ... Hynek Cihlar

11:59 AM Base Language Bug #2293: Fixing an unfixed extent output parameter causes an error

Hynek,
The approach loosk good, just a question about how the converted code looks: if we have @integer[] p = extp... Constantin Asofiei

05/26/2014

04:25 PM User Interface Feature #1805: add missing UI method support

Here is the first working variant. It works for simple cases (without nested frames and with only one field-group). F... Vadim Gindin

02:35 PM Database Feature #2296: update record buffer validation to prevent database index overflow

The initial regression test failed. There were no changes in generated ddl and no TRPL rules files affected for the c... Ovidiu Maxiniuc

08:50 PM Base Language Feature #1630: implement support for UNBUFFERED in I/O statements

>>Also, please add a test for OUTPUT TO "somefile.txt" UNBUFFERED (redirects the unnamed stream from the terminal to ... Evgeny Kiselev

05/23/2014

04:32 PM User Interface Feature #1806: implement UNLESS-HIDDEN

Updated testcases for @DISPLAY@ statement. Looks like the problem with @DISPLAY UNLESS-HIDDEN@ is not related to @UNL... Eugenie Lyzenko

03:07 PM User Interface Feature #1806: implement UNLESS-HIDDEN

Update for review with adding minimum level of safety checking. The modified widget list will be passed to the usual ... Eugenie Lyzenko

03:15 PM Database Feature #2296: update record buffer validation to prevent database index overflow

Eric Faulhaber wrote:
> Ovidiu Maxiniuc wrote:
> > As workaround for the unique null issue of SQL server, the ID is... Ovidiu Maxiniuc

03:05 PM Database Feature #2296: update record buffer validation to prevent database index overflow

Ovidiu Maxiniuc wrote:
> As workaround for the unique null issue of SQL server, the ID is added in the dialect for u... Eric Faulhaber

02:50 PM Database Feature #2296: update record buffer validation to prevent database index overflow

Uploaded om_upd20140523a.zip for review. It is merged with latest (10536) bzr rev.
The big issue here is that I coul... Ovidiu Maxiniuc

02:37 PM Base Language Bug #2293: Fixing an unfixed extent output parameter causes an error

Constantin Asofiei wrote:
> How do you expect the converted code will look?
There are not many changes in the con... Hynek Cihlar

01:50 AM Base Language Bug #2293: Fixing an unfixed extent output parameter causes an error

Hynek Cihlar wrote:
> In terms of implementation, I don't have a better idea than storing the variable pair consisti... Constantin Asofiei

07:34 AM User Interface Feature #2252: implement GUI client support

The package contains the changes and new classes used to implements CREATE WINDOW statement. So far the following iss... Marius Gligor

06:48 AM Database Feature #1580: upgrade Hibernate to latest level

This is how to build Hibernate from sources:... Stanislav Lomany

05/22/2014

07:05 PM User Interface Feature #1806: implement UNLESS-HIDDEN

Reattached the srceen shot for issue. Eugenie Lyzenko

07:01 PM User Interface Feature #1806: implement UNLESS-HIDDEN

> Make sure to implement this too if we don't already support it.
OK. The second drop for today contains runtime m... Eugenie Lyzenko

02:59 PM User Interface Feature #1806: implement UNLESS-HIDDEN

Code Review 0522a
The changes look good.
> Also the statement ENABLE ALL WITH FRAME... sets the HIDDEN flag to ... Greg Shah

01:13 PM User Interface Feature #1806: implement UNLESS-HIDDEN

This fix for your review is conversion rule change that allow the @UNLESS-HIDDEN@ option to be properly converted for... Eugenie Lyzenko

12:00 PM User Interface Feature #1806: implement UNLESS-HIDDEN

Currently only @DISPLAY@ and @ENABLE@ are supported with @UNLESS-HIDDEN@ option on the conversion level. For other st... Eugenie Lyzenko

10:16 AM User Interface Feature #1806: implement UNLESS-HIDDEN

The testcases executed in 4GL under Linux and screenshots uploaded. Yes, you are right, the @HIDDEN@ flag as @TRUE@ e... Eugenie Lyzenko

04:58 PM Base Language Feature #2050: ATTR_POLY/METH_POLY used as rvalue or in expressions

As far as I know, only the issue in note 24 remains open for this task.
I believe that most of the problem in this... Greg Shah

01:20 PM Base Language Bug #2293: Fixing an unfixed extent output parameter causes an error

The implementation should be straightforward with one exception - fixing the indeterminate extent argument. When the ... Hynek Cihlar

11:39 AM Base Language Bug #2293: Fixing an unfixed extent output parameter causes an error

Constantin Asofiei wrote:
> Hynek Cihlar wrote:
> > When error is raised during function or procedure execution, th... Hynek Cihlar

01:41 AM Base Language Bug #2293: Fixing an unfixed extent output parameter causes an error

Hynek Cihlar wrote:
> When error is raised during function or procedure execution, the variable passed in the block ... Constantin Asofiei

10:07 AM User Interface Feature #2252: implement GUI client support

Code Review 0522b
It looks good.
> 2. Could you please offer more details? What means "implement the WindowGuiI... Greg Shah

09:59 AM User Interface Feature #2252: implement GUI client support

For ChUI interface the status and message area are implemented as widgets (StatusLine instances)
To keep the compati... Marius Gligor

03:55 AM User Interface Feature #2252: implement GUI client support

1. The GuiScreen interface extends ScreenDriver interface.
2. Could you please offer more details? What means "imp... Marius Gligor

08:25 AM User Interface Feature #2308: remote client launch

Doesn't the 4GL appserver implementation have some features in this regard? We should at least document their basic ... Greg Shah

02:57 AM User Interface Feature #2308: remote client launch

The P2J Server should have no configuration/restriction on how many P2J clients act as remote launchers and the machi... Constantin Asofiei

02:15 AM User Interface Feature #1805: add missing UI method support

Greg Shah wrote:
> > I don't recall and can't find a way of jumping from frame F1 to frame F2 (both with enabled wid... Constantin Asofiei

05/21/2014

06:02 PM Base Language Bug #2293: Fixing an unfixed extent output parameter causes an error

Constantin Asofiei wrote:
> Hynek Cihlar wrote:
> > The above covers functions only. I will also test procedure out... Hynek Cihlar

01:30 PM Base Language Bug #2293: Fixing an unfixed extent output parameter causes an error

Hynek Cihlar wrote:
> The above covers functions only. I will also test procedure output parameters to see how it be... Constantin Asofiei

11:16 AM Base Language Bug #2293: Fixing an unfixed extent output parameter causes an error

Constantin Asofiei wrote:
> Hynek, something else to test: what happens with an extent var passed as an OUTPUT argum... Hynek Cihlar

03:00 PM Runtime Infrastructure Bug #2305: context-local vars need to be reset in a predetermined order

Eric Faulhaber wrote:
> *However, before we implement either workaround, I have to understand: why are we seeing the... Eric Faulhaber

02:35 PM Runtime Infrastructure Bug #2305: context-local vars need to be reset in a predetermined order

Most of the @ContextLocalCleanupException@ instances (all but one) follow this pattern:... Eric Faulhaber

05:37 AM Runtime Infrastructure Bug #2305: context-local vars need to be reset in a predetermined order

After runtime testing 0520c.zip changes, the following need to be addressed:
# these are reported as "surviving" aft... Constantin Asofiei

02:46 PM Database Bug #2280 (Closed): Error with FIND-FIRST() method

Eric Faulhaber

02:30 PM User Interface Feature #1805: add missing UI method support

> I don't recall and can't find a way of jumping from frame F1 to frame F2 (both with enabled widgets) just by pressi... Greg Shah

02:09 PM User Interface Feature #1805: add missing UI method support

Vadim, some thoughts:
# I don't recall and can't find a way of jumping from frame F1 to frame F2 (both with enabled ... Constantin Asofiei

09:13 AM User Interface Feature #1805: add missing UI method support

> At this moment I didn't find such test case.
That is good news.
> I don't feel free with terms. Could you des... Greg Shah

02:23 PM User Interface Feature #1783 (Closed): properly handle empty UNDERLINE statements

Greg Shah

02:15 PM User Interface Feature #1783: properly handle empty UNDERLINE statements

The update @0516a@ has been committed to bzr as 10536. Eugenie Lyzenko

01:56 PM User Interface Feature #1783: properly handle empty UNDERLINE statements

Finally I have finished @CTRL-C@ testing with all passed results. Not in single run.due to multiple false negative re... Eugenie Lyzenko

12:40 PM User Interface Feature #2252: implement GUI client support

Code Review 0521a
Wow! Very cool. I like it.
Some thoughts:
1. I would like the GUI screen driver to be desi... Greg Shah

11:55 AM User Interface Feature #2252: implement GUI client support

I've implemented a first skeleton version for drawing WINDOW widgets in GUI interfaces.
I attached a picture with th... Marius Gligor

10:38 AM User Interface Feature #2308: remote client launch

To be clear, this special launcher client would be started on the remove system and it would be configured to connect... Greg Shah

10:19 AM User Interface Feature #2308: remote client launch

Create a special P2J client that is a dedicated client process launcher. This client must be able to run on any arbi... Greg Shah

10:14 AM User Interface Feature #2308 (Closed): remote client launch

Greg Shah

10:13 AM User Interface Feature #2307: enable skinning of the web client login page

The ui/client/chui/driver/web/chui_web.html needs to allow some basic customization by a customer. The following sho... Greg Shah

10:01 AM User Interface Feature #2307 (New): enable skinning of the web client login page

Greg Shah

09:58 AM User Interface Feature #2306: add copy/paste support to the web client

This is not a 4GL feature, but rather it is meant to provide a mechanism that duplicates what is possible in normal t... Greg Shah

09:54 AM User Interface Feature #2306 (Closed): add copy/paste support to the web client

Greg Shah

09:27 AM User Interface Feature #1806: implement UNLESS-HIDDEN

The UNLESS-HIDDEN option should be fully implemented for the following language statements:
DISABLE
DISPLAY
ENAB... Greg Shah

08:42 AM Base Language Feature #1596 (Closed): complete big decimal implementation

Greg Shah

08:41 AM Base Language Feature #1600 (Closed): provide a conversion option to emit decimal literals using a string liter...

Greg Shah

05/20/2014

05:07 PM Base Language Feature #1600: provide a conversion option to emit decimal literals using a string literal instea...

Regression tests passed. Code changes committed to bzr revision 10535. Hynek Cihlar

04:40 PM User Interface Feature #1805: add missing UI method support

At this moment I didn't find such test case. I don't feel free with terms. Could you describe how do you define z-ord... Vadim Gindin

11:35 AM User Interface Feature #1805: add missing UI method support

Before you spend additional time on implementation, please post a testcase here which would break in P2J because the ... Greg Shah

03:51 PM Runtime Infrastructure Bug #2305: context-local vars need to be reset in a predetermined order

Code Review 0520c
The changes look good. Greg Shah

01:12 PM Runtime Infrastructure Bug #2305: context-local vars need to be reset in a predetermined order

This task is split from #2266 notes 33,34,35,36,37,38 (updates ca_upd20140512b.zip and ca_upd20140513a.zip from #226... Constantin Asofiei

12:26 PM Runtime Infrastructure Bug #2305 (Closed): context-local vars need to be reset in a predetermined order

Constantin Asofiei

02:17 PM User Interface Feature #2252: implement GUI client support

On CTRL-C the entire set of Windows are cleared in GUI. Marius Gligor

12:27 PM User Interface Feature #2252: implement GUI client support

> I think that a best idea is to clear also the windowRegistry whenever the DEFAULT_WINDOW is create (default constru... Greg Shah

12:06 PM User Interface Feature #2252: implement GUI client support

Initially Window class had only the default constructor. The init() method was initially the body of the default cons... Marius Gligor

11:26 AM User Interface Feature #2252: implement GUI client support

Code Review 0516b
The changes look good. I only have one question: why were the @local.set(null);@ and @config = ... Greg Shah

01:04 PM Database Feature #2220: dynamic query methods which require implementation

Yes, they differ and match P2J. Stanislav Lomany

09:45 AM Database Feature #2220: dynamic query methods which require implementation

Do the results differ if the query is not set to be scrolling? Eric Faulhaber

11:56 AM Base Language Bug #2197: fix the error message list cleanup when NO-ERROR mode is enabled and ERROR-STATUS:ERRO...

> Why there are possible of more than one error?! - It's for cases where could be more than one error during executio... Greg Shah

10:36 AM Base Language Feature #1630: implement support for UNBUFFERED in I/O statements

It is expected that P2J is not working. The runtime support for UNBUFFERED is not yet implemented. Your testcases l... Greg Shah

08:50 PM Base Language Feature #1630: implement support for UNBUFFERED in I/O statements

@UNBUFFERED@ statement is not working properly in p2j. This keyword is properly converted, but worked different.
One... Evgeny Kiselev

05:27 AM Base Language Bug #2293: Fixing an unfixed extent output parameter causes an error

Hynek, something else to test: what happens with an extent var passed as an OUTPUT argument, if the function/proc doe... Constantin Asofiei

05/19/2014

05:13 PM Database Feature #2296: update record buffer validation to prevent database index overflow

During last days I encountered inconsistent readings about the errors I get and whether I get some errors:
I did som... Ovidiu Maxiniuc

04:38 PM Base Language Feature #1600: provide a conversion option to emit decimal literals using a string literal instea...

Greg Shah wrote:
> Code Review 0519a
>
> It looks good. Sorry that I didn't think about this approach before now... Hynek Cihlar

03:18 PM Base Language Feature #1600: provide a conversion option to emit decimal literals using a string literal instea...

Code Review 0519a
It looks good. Sorry that I didn't think about this approach before now. It was your good idea... Greg Shah

02:29 PM Base Language Feature #1600: provide a conversion option to emit decimal literals using a string literal instea...

Attached is the change set with the removed check for decimal literals being effectively mathematical integers. Now t... Hynek Cihlar

02:10 PM Base Language Feature #1600: provide a conversion option to emit decimal literals using a string literal instea...

Greg Shah wrote:
> > Or are you saying that we should not care about the literal being effectively an integer (and d... Hynek Cihlar

02:05 PM Base Language Feature #1600: provide a conversion option to emit decimal literals using a string literal instea...

> Or are you saying that we should not care about the literal being effectively an integer (and do not check for this... Greg Shah

11:46 AM Base Language Feature #1600: provide a conversion option to emit decimal literals using a string literal instea...

Greg Shah wrote:
> Code Review 0518a
>
> The changes look good. I really like your approach of using the Java @d... Hynek Cihlar

09:31 AM Base Language Feature #1600: provide a conversion option to emit decimal literals using a string literal instea...

Code Review 0518a
The changes look good. I really like your approach of using the Java @double@ and @BigDecimal@ ... Greg Shah

04:33 PM Database Bug #2219 (Closed): problematic dynamic query test cases

Eric Faulhaber

07:34 AM Database Bug #2219 (Review): problematic dynamic query test cases

Stanislav Lomany

07:34 AM Database Bug #2219 (WIP): problematic dynamic query test cases

Stanislav Lomany

04:31 PM Base Language Feature #2184 (Closed): create and populate the temp-table on the remote side, based on the recei...

Eric Faulhaber

07:34 AM Base Language Feature #2184 (Review): create and populate the temp-table on the remote side, based on the recei...

Stanislav Lomany

07:33 AM Base Language Feature #2184 (WIP): create and populate the temp-table on the remote side, based on the received...

Merged update. Stanislav Lomany

02:02 PM Base Language Bug #2250 (Closed): Conversion error when decimal precision defined on dynamic extent variable

Greg Shah

01:39 PM Base Language Bug #2250: Conversion error when decimal precision defined on dynamic extent variable

I accidentally fixed this issue in the issue #2294. This can be closed now. Hynek Cihlar

09:39 AM Conversion Tools Feature #2251: improve the call graph generation

Please see #2260 for 2 open questions/issues. Greg Shah

08:20 AM User Interface Feature #1783: properly handle empty UNDERLINE statements

Code Review 0516a
I am fine with the changes. When CTRL-C processing passes, please check it in and distribute it. Greg Shah

05/18/2014

06:32 PM Base Language Feature #1600: provide a conversion option to emit decimal literals using a string literal instea...

Attached is the implementation with the special handling of mathematical integers. Now the decimal literal is emitted... Hynek Cihlar

09:09 AM User Interface Feature #1805: add missing UI method support

I don't fully understand the real link between z-order and tab order. Definitely it really exists and it complex. I ... Vadim Gindin

11:07 PM User Interface Feature #1783: properly handle empty UNDERLINE statements

The main part completed without regressions in a single run. Continue testing with @CTRL-C@ part. Eugenie Lyzenko

05/17/2014

08:39 PM User Interface Feature #1783: properly handle empty UNDERLINE statements

Sorry, the suggested fix does not work. Need to check @ThinClient@ redirection, not simple @Frame@ one. The fix has b... Eugenie Lyzenko

05/16/2014

07:52 PM User Interface Feature #1783: properly handle empty UNDERLINE statements

The regression has been found. Testcase TC-ITEM-MASTER-103 the difference in page size for report generation. The exp... Eugenie Lyzenko

02:30 PM User Interface Feature #1783: properly handle empty UNDERLINE statements

The conversion test completed. The converted sources are binary equal. Continue with runtime regression testing. Eugenie Lyzenko

11:47 AM User Interface Feature #1783: properly handle empty UNDERLINE statements

> So we can start the regression testing and fix the problems with UP(discovered in note 25) as another task. What d... Greg Shah

10:48 AM User Interface Feature #1783: properly handle empty UNDERLINE statements

Greg Shah wrote:
...
>
> The primary issue here is that you are not really exercising the new code very much. Tr... Eugenie Lyzenko

08:30 AM User Interface Feature #1783: properly handle empty UNDERLINE statements

> The only exception is P2J does not display the warning message that the Y coord can not be negative while 4GL displ... Greg Shah

02:23 PM User Interface Feature #2252: implement GUI client support

When a WindowWidget option is changed the window configuration file should be send down to the client via LogicalTerm... Marius Gligor

01:08 PM User Interface Feature #2252: implement GUI client support

> in Windows, is there a way to intercept gdi32.dll API calls?
Yes, there are some tools out there. For example:
... Greg Shah

10:52 AM User Interface Feature #2252: implement GUI client support

Greg, I keep forgetting to mention something about font metrics, so here it is: in Windows, is there a way to interce... Constantin Asofiei

10:04 AM User Interface Feature #2252: implement GUI client support

Here are my latest changes:
1. On server side I used ID's from the same address space like frames. This offer a wi... Marius Gligor

01:18 PM User Interface Bug #2303: Incorrect UP statement handling with underlined widgets

The @UP@ command for down frames with underlined widgets works incorrectly in P2J. The 4GL screens step by step and t... Eugenie Lyzenko

01:16 PM User Interface Bug #2303 (New): Incorrect UP statement handling with underlined widgets

Eugenie Lyzenko

11:55 AM User Interface Feature #2302: Warning message when setting widget row to negative value

The 4GL displays the warning message when setting row to the negative value is requested. The testcase and screenshot... Eugenie Lyzenko

11:52 AM User Interface Feature #2302 (New): Warning message when setting widget row to negative value

Eugenie Lyzenko

11:45 AM Base Language Feature #1600: provide a conversion option to emit decimal literals using a string literal instea...

Good points. OK, go ahead with your approach. Please do put in the code to detect the 17 digit issue at conversion ... Greg Shah

10:26 AM Base Language Feature #1600: provide a conversion option to emit decimal literals using a string literal instea...

Greg Shah wrote:
> We very much like to avoid wrapping when unnecessary. Your idea about whole numbers is a good on... Hynek Cihlar

09:37 AM Base Language Feature #1600: provide a conversion option to emit decimal literals using a string literal instea...

We very much like to avoid wrapping when unnecessary. Your idea about whole numbers is a good one. It does have to ... Greg Shah

08:47 AM Base Language Feature #1600: provide a conversion option to emit decimal literals using a string literal instea...

I am wondering, whether we should emit the wrapper even for (effectively) whole numbers? Ex. instead of @.assign(new ... Hynek Cihlar

03:44 AM User Interface Feature #1805: add missing UI method support

1. Methods @moveToTop@ and @moveToBottom@ change the real place of the widget in the displaying order. They really mo... Vadim Gindin