Activity
From 05/27/2014 to 06/25/2014
06/25/2014
- 05:37 PM User Interface Feature #2252: implement GUI client support
- > Do you have rev 1159? I know rev 1158 of this file was missing the images, rev 1159 looks OK on my side.
Yes, I ... - 04:19 PM User Interface Feature #2252: implement GUI client support
- Greg Shah wrote:
> If I understand things correctly, a dependency we will have will be that the fonts on which an ap... - 03:58 PM User Interface Feature #2252: implement GUI client support
- I read the @uast/fonts/font_details.odt@. Clearly there are still some tricky parts to figure out.
If I understan... - 03:20 PM User Interface Feature #2252: implement GUI client support
- The @uast/fonts/font_details.odt@ contains details about how the widget metrics are computed; the main notes are:
* ... - 03:51 PM User Interface Feature #1794: implement font support
- We won't know if we need FONT-TABLE support (or not) until we see the cut-down customer GUI code. The full customer G...
- 03:50 PM User Interface Feature #1794: implement font support
- Do we need support for the @FONT-TABLE@ handle? Note that this handle allows to:
* adjust the size of the actual FO... - 03:44 PM Base Language Feature #2232: finish testing the wrapped mode using the web services exposed by the testing server
- Marius Gligor wrote:
> Having these fixes all tested web services are working in P2J.
The update looks OK. For thi... - 11:16 AM Base Language Feature #2232: finish testing the wrapped mode using the web services exposed by the testing server
- Debugging the SimpleOperations converted web service test case in P2J an AxisFault is throw in WebServiceHelper line ...
- 12:35 PM Database Feature #2220: dynamic query methods which require implementation
- Sample looks good, thanks.
- 11:58 AM Database Feature #2220: dynamic query methods which require implementation
- > Looks good, though I would still like to see sample output. Note there is another version of @IndexHelper@ in play ...
- 11:34 AM Database Feature #2220: dynamic query methods which require implementation
- Testcase:...
- 10:20 AM User Interface Feature #1789 (Closed): implement the toggle-box widget
- 10:00 AM User Interface Feature #1789: implement the toggle-box widget
- The update 0624a has been committed in bzr as 10552.
- 09:28 AM User Interface Feature #1789: implement the toggle-box widget
- Go ahead with the check-in and distribution.
- 09:23 AM User Interface Feature #1789: implement the toggle-box widget
- The CTRL-C part has been completed without regressions. Hopefully 2-way and 3-way in a single session. The results ha...
- 08:23 AM User Interface Feature #1789: implement the toggle-box widget
- The main regression part completed without regression. Continue with CTRL-C part.
- 08:56 AM Base Language Feature #2287 (Closed): implement missing type conversion for POLY cases in data type wrapper ass...
- 02:40 AM Base Language Feature #2287 (Review): implement missing type conversion for POLY cases in data type wrapper ass...
- Passed MAJIC regression tests. Passed the customer server conversion test.
Committed revision 10551. - 08:56 AM Base Language Feature #2050 (Closed): ATTR_POLY/METH_POLY used as rvalue or in expressions
- 02:41 AM Base Language Feature #2050 (Review): ATTR_POLY/METH_POLY used as rvalue or in expressions
- Passed MAJIC regression tests. Passed the customer's server conversion test.
Committed revision 10551. - 07:09 AM Base Language Bug #2197: fix the error message list cleanup when NO-ERROR mode is enabled and ERROR-STATUS:ERRO...
- Take a look at first NO-ERROR implementation please. I want to understand if I am on a right way. Also note at the pl...
- 09:00 PM Base Language Feature #1628: fix any incompatibilities or missing features of NO-ECHO support
- Code Review 0624a
The merge looks fine. - 08:52 PM Base Language Feature #1628: fix any incompatibilities or missing features of NO-ECHO support
- Find a testcase that fails regularly and use the test XML file or the results details to see the recreate. Manually ...
06/24/2014
- 07:54 PM Base Language Feature #1628: fix any incompatibilities or missing features of NO-ECHO support
- Merged with last revision.
I have still a problem with regression testing. ~ 100 tests have been failed by timeout... - 07:13 PM Database Feature #2220: dynamic query methods which require implementation
- Code review 0604a:
Looks good, though I would still like to see sample output. Note there is another version of @I... - 06:45 PM Database Feature #2220: dynamic query methods which require implementation
- I am reviewing the 0604a update now (sorry it took so long for me to get to this). Could you please post some test ca...
- 11:42 AM Base Language Feature #2208 (Closed): create a java application running web services for testing purposes
- Marius has done a code review and he notes that the code is acceptable and that this task can be closed.
Please do... - 11:34 AM Base Language Feature #2232: finish testing the wrapped mode using the web services exposed by the testing server
- Today I started to do a code review on issue #2208
1. I did a checkout of testcases project and I have the testcas... - 11:04 AM User Interface Feature #1789: implement the toggle-box widget
- > Please check in your testcases to testcases/uast/toggle_box/.
Done. The revision is 1157.
- 10:15 AM User Interface Feature #1789: implement the toggle-box widget
- Code Review 0624a
The changes look good. - 09:44 AM User Interface Feature #1789: implement the toggle-box widget
- The runtime regression has been found for @Button@ related code for GSO 195 - help string is not updated correctly fo...
- 11:51 PM User Interface Feature #1789: implement the toggle-box widget
- Please check in your testcases to testcases/uast/toggle_box/.
- 02:56 AM User Interface Feature #1805: add missing UI method support
- Committed vig_upd20140617a.zip. Rev #10550
- 12:55 AM User Interface Feature #1805: add missing UI method support
- Yes, please commit it and distribute it to the team.
- 12:35 AM User Interface Feature #1805: add missing UI method support
- The latest update passed regression testing. Can I commit it?
- 12:48 AM User Interface Feature #2252: implement GUI client support
- #2323 is a task to implement support for GUI coordinate processing. Currently the implementation is hard coded to Ch...
- 12:15 AM User Interface Feature #2323: refactor coordinate system and implement GUI coordinate support
- This task is just for time tracking. All history should be placed in the parent task #2252.
- 12:14 AM User Interface Feature #2323 (Closed): refactor coordinate system and implement GUI coordinate support
06/23/2014
- 04:17 PM User Interface Feature #1789: implement the toggle-box widget
- The conversion part has been finished. The converted code is binary equal. Continue with runtime testing.
- 09:50 AM User Interface Feature #1789: implement the toggle-box widget
- Code Review 0622a
I'm fine with the changes. Please get it regression tested (both conversion and runtime). - 03:44 PM Base Language Feature #2287: implement missing type conversion for POLY cases in data type wrapper assign method
- Yes. All that remains is to commit the changes into remote repository and notify the team.
- 03:43 PM Base Language Feature #2287: implement missing type conversion for POLY cases in data type wrapper assign method
- Please check in and distribute you update.
If I understand properly, both #2287 and #2050 can be closed now, right? - 03:12 PM Base Language Feature #2287: implement missing type conversion for POLY cases in data type wrapper assign method
- MAJIC conversion regression test passed.
- 12:42 PM Base Language Feature #2287: implement missing type conversion for POLY cases in data type wrapper assign method
- The customer's server conversion passed. I have the same expected differences.
I'm going to prepare and start a MAJI... - 11:37 AM Base Language Feature #2287: implement missing type conversion for POLY cases in data type wrapper assign method
- Code Review 0623a
Your new version is much better. The code looks good.
If the customer server conversion test... - 07:56 AM Base Language Feature #2287: implement missing type conversion for POLY cases in data type wrapper assign method
- 1. Done.
2. Doesn't work should be: ... - 11:09 AM Base Language Feature #2232: finish testing the wrapped mode using the web services exposed by the testing server
- No I didn't do any code review for #2208 so far.
- 10:44 AM Base Language Feature #2232: finish testing the wrapped mode using the web services exposed by the testing server
- Have you reviewed #2208 already? If so, can we close it or does that code need some changes?
- 10:42 AM Base Language Feature #2232: finish testing the wrapped mode using the web services exposed by the testing server
- As part of this task, please do prepare code changes that resolve any found issues.
- 10:39 AM Base Language Feature #2232: finish testing the wrapped mode using the web services exposed by the testing server
- 1. I used the following existing test case (wsdl-test1.p) to check the RESPONSE on 4GL when call a SOAP WS in wrapped...
06/22/2014
- 06:19 PM User Interface Feature #1789: implement the toggle-box widget
- New update for review uploaded. The @StopConditionException@ has been raised to interrupt execution. The pause insert...
- 05:24 PM User Interface Feature #1789: implement the toggle-box widget
- > Then you can tell if the code generates an error or not. You can also try ON END-KEY, ON STOP and ON QUIT instead o...
06/21/2014
- 05:07 AM User Interface Feature #1791: implement dynamic UI support
- The window-related features will be implemented in a different task. For #2028, focus on the general dynamic widget ...
- 04:44 AM User Interface Feature #1789: implement the toggle-box widget
- Code Review 0620a
The code looks good, especially the refactoring of common code into @buildWidgetSpectificMessage... - 04:41 AM User Interface Feature #1789: implement the toggle-box widget
- > Yes, looks like you are right. This is the usual exit for CHUI client session in 4GL for application finish.
> ......
06/20/2014
- 07:54 PM User Interface Feature #1789: implement the toggle-box widget
- The update for review uses @preRealizeCheck()@ to verify widget realization ability and @QuitConditionException@ to q...
- 07:08 PM User Interface Feature #1789: implement the toggle-box widget
- > This sounds like a QUIT (QuitConditionException). Check this before you make any other changes.
Yes, looks like ... - 05:28 PM User Interface Feature #1789: implement the toggle-box widget
- > The remaining issue is in P2J we have additional message "Press space bar to continue." while in 4GL the only messa...
- 05:20 PM User Interface Feature #1789: implement the toggle-box widget
- Code Review 0619a
1. We can't reuse valid() because this is there for other reasons (to provide support for the HA... - 03:59 PM Base Language Feature #2287: implement missing type conversion for POLY cases in data type wrapper assign method
- Code Review 0619a
1. Line 1132 of expressions.rules has a typo. @uppercase = (cls == "caharacter" or cls == "long... - 09:56 AM Base Language Feature #2287: implement missing type conversion for POLY cases in data type wrapper assign method
- I have no other questions regarding conversion. I tried to do just punctual changes in rules and keep no changes on o...
- 09:47 AM Base Language Feature #2287: implement missing type conversion for POLY cases in data type wrapper assign method
- Marius, I've reviewed your previous several notes on the matter, and your reasoning and approach with respect to @toU...
- 09:03 AM Base Language Feature #2287: implement missing type conversion for POLY cases in data type wrapper assign method
- Eric will be reviewing and responding to this WHERE clause issue.
One thought: in the end, if your changes only ch... - 08:03 AM Base Language Feature #2287: implement missing type conversion for POLY cases in data type wrapper assign method
- I've restarted an new customer server conversion using the latest changes. The full conversion took 5 hours and 21 mi...
- 09:57 AM Database Feature #2312: match Progress collation in a SQL Server database
- Reading [[http://technet.microsoft.com/en-us/library/ms175194(v=sql.110).aspx]], I understand that SQL Server has a b...
- 07:42 AM Database Feature #2312: match Progress collation in a SQL Server database
- Is it possible to create new collations/locales for Windows itself (as we do on Linux) and then use these with SQL Se...
- 07:00 AM Base Language Bug #2293: Fixing an unfixed extent output parameter causes an error
- > I copied the throw statement together with other code from OutputExtentParameter. The exception is there to catch t...
- 02:59 AM Base Language Feature #2232 (WIP): finish testing the wrapped mode using the web services exposed by the testin...
06/19/2014
- 06:27 PM Base Language Bug #2293: Fixing an unfixed extent output parameter causes an error
- Constantin Asofiei wrote:
> Review for 0618a.zip:
> * fix the copyright date in annotations/output_parameters.rules... - 04:41 AM Base Language Bug #2293: Fixing an unfixed extent output parameter causes an error
- Review for 0618a.zip:
* fix the copyright date in annotations/output_parameters.rules and convert/output_parameters.... - 03:03 PM User Interface Feature #1789: implement the toggle-box widget
- > The only thing needed is to properly sort the methods in AbstractButton and ToggleBox (public then protected then p...
- 09:21 PM User Interface Feature #1789: implement the toggle-box widget
- Code Review 0618a
The changes look good. The only thing needed is to properly sort the methods in AbstractButton ... - 09:09 PM User Interface Feature #1789: implement the toggle-box widget
- This update for review includes refactoring for @Button@ and @ToggleBox@ common code. The idea is to use new base cla...
- 08:24 AM Base Language Feature #2287: implement missing type conversion for POLY cases in data type wrapper assign method
- The rules for DYNAMIC-FUNCTION in WHERE expressions are like on any other expressions like IF for example.
So the ty... - 04:46 AM Base Language Feature #2287: implement missing type conversion for POLY cases in data type wrapper assign method
- I created and converted a small test case using a WHERE clause and a DYNAMIC-FUNCTION operand....
- 03:19 AM Base Language Feature #2287: implement missing type conversion for POLY cases in data type wrapper assign method
- Here is the analyse of unexpected differences from the customer's server conversion. The affected generated files are...
06/18/2014
- 04:12 PM Base Language Feature #2287: implement missing type conversion for POLY cases in data type wrapper assign method
- Here the other differences in generated Java code. The first two are OK because we have a NOT-EQ expression.
The thi... - 03:40 PM Base Language Feature #2287: implement missing type conversion for POLY cases in data type wrapper assign method
- Yes I know that and will do. In the mean time I changed the Apenndo0.java class by hand and I did a rebuild of the pr...
- 03:26 PM Base Language Feature #2287: implement missing type conversion for POLY cases in data type wrapper assign method
- Marius Gligor wrote:
> Unfortunately the converted code was not compiled:
It's not just a matter for the code to co... - 03:24 PM Base Language Feature #2287: implement missing type conversion for POLY cases in data type wrapper assign method
- On the customer's Server conversion I saved the initial succeeded conversion.
Today I applied my changes on P2J proj... - 02:45 PM User Interface Feature #1789: implement the toggle-box widget
- > So I think this is not ToggleBox specific and we can postpone this subtask if you do not mind. Let me know if any n...
- 02:39 PM User Interface Feature #1789: implement the toggle-box widget
- > > Also may be as one more thing to do is to refactor the Button and ToggleBox implementation to merge possible comm...
- 02:04 PM User Interface Feature #1789: implement the toggle-box widget
- > Also may be as one mo thing to do is to refactor the Button and ToggleBox implementation to merge possible common c...
- 09:56 AM User Interface Feature #1789: implement the toggle-box widget
- Also may be as one more thing to do is to refactor the @Button@ and @ToggleBox@ implementation to merge possible comm...
- 09:52 AM User Interface Feature #1789: implement the toggle-box widget
- > 2. The javadoc for @ToggleBoxImpl.forceCursorOnFocus()@ should explain that the return value is always false.
OK... - 08:42 AM User Interface Feature #1789: implement the toggle-box widget
- Code Review 0617a
1. In the javadoc for these changes, "cusror" should be "cursor".
2. The javadoc for @ToggleB... - 09:44 PM User Interface Feature #1789: implement the toggle-box widget
- This update fixes UI artifact using new @Widget@ interface method implementation. Also the @ToggleBox@ class has been...
- 10:19 AM Base Language Bug #2293: Fixing an unfixed extent output parameter causes an error
- I have also checked-in all test cases for the above changes. See testcases/uast/output_var_param.p and testcases/uast...
- 10:01 AM Base Language Bug #2293: Fixing an unfixed extent output parameter causes an error
- *The attached file provides*
* fix for output extent parameter dimension not initialized to unknown... - 08:46 AM Base Language Bug #2197: fix the error message list cleanup when NO-ERROR mode is enabled and ERROR-STATUS:ERRO...
- Vadim Gindin wrote:
> I've updated tests as you asked. In cases when actual error is raised there are no possibility... - 04:40 AM Base Language Bug #2197: fix the error message list cleanup when NO-ERROR mode is enabled and ERROR-STATUS:ERRO...
- I've updated tests as you asked. In cases when actual error is raised there are no possibility to hardcode it to the ...
- 09:14 PM Base Language Feature #1628: fix any incompatibilities or missing features of NO-ECHO support
- Regression testing is finished. But atm I've found quite a lot timeout failed tests:
50 in gso_tests
42 in tc_tests...
06/17/2014
- 05:39 PM User Interface Feature #1789: implement the toggle-box widget
- > > The problematic area is marked in red. I think this is something like phantom cursor. It is blinking and disappea...
- 04:15 PM User Interface Feature #2252: implement GUI client support
- Greg Shah wrote:
> For example, most buttons will only ever have a small number of possible labels (often only 1). W... - 04:11 PM User Interface Feature #2252: implement GUI client support
- I had not planned to require P2J to be running on a Windows OS in order to run the converted system. It would be a r...
- 03:53 PM User Interface Feature #2252: implement GUI client support
- I have some bad news... width for TEXT/FILL-IN widgets is computed via the avg-font-width, but for BUTTON, is compute...
- 10:50 AM User Interface Feature #2252: implement GUI client support
- +More Findings+
11. MESSAGE statement window targeting:
For both a regular MESSAGE statement and the MESSAGE VI... - 09:12 AM User Interface Feature #2252: implement GUI client support
- The Progress documentation suggests the following precedence order for window targeting (please note that I have alre...
- 01:32 PM Base Language Feature #2287: implement missing type conversion for POLY cases in data type wrapper assign method
- For now, please change @zip64Mode="always"@ to @zip64Mode="as-needed"@. This change will be checked in soon, but for...
- 12:50 PM Base Language Feature #2287: implement missing type conversion for POLY cases in data type wrapper assign method
- I started the customer's server conversion on my workstation. The conversion took 4 hours 58 minutes and 41 seconds.
... - 08:08 AM Base Language Feature #2287: implement missing type conversion for POLY cases in data type wrapper assign method
- There is only one P2J repo, so you are OK.
- 07:30 AM Base Language Feature #2287: implement missing type conversion for POLY cases in data type wrapper assign method
- I started the customer server conversion on my workstation as is described on #2299.
For P2J I used the current deve... - 07:20 AM Base Language Feature #2287: implement missing type conversion for POLY cases in data type wrapper assign method
- Code Review 0617a
The changes are good.
Is there anything else to do for this task (or for #2050)? If not, the... - 03:53 AM Base Language Feature #2287: implement missing type conversion for POLY cases in data type wrapper assign method
- Using ExpressionConversionWorker the rule in annotations/functions.rules became more simple and cover also the case o...
- 10:52 AM User Interface Feature #2229: implement CURRENT-WINDOW, ACTIVE-WINDOW and DEFAULT-WINDOW system handles for GUI
- Please put all history into #2252. This task is just for time tracking.
- 08:48 AM Base Language Feature #1628: fix any incompatibilities or missing features of NO-ECHO support
- Greg Shah wrote:
> Constantin: do you have any concerns with my changes (or with Evgeny's)?
The changes look OK to me. - 07:16 AM Base Language Feature #1628: fix any incompatibilities or missing features of NO-ECHO support
- Constantin: do you have any concerns with my changes (or with Evgeny's)?
- 07:15 AM Base Language Feature #1628: fix any incompatibilities or missing features of NO-ECHO support
- Code Review 0616a
I'm OK with the changes. Please run both conversion and runtime regression testing. If you hav... - 08:07 PM Base Language Feature #1628: fix any incompatibilities or missing features of NO-ECHO support
- This update merged with ges_upd20140612a.zip
Fixed issues from note 28.
Also I've decided to remove unnecessary cal... - 06:05 AM Base Language Bug #2197: fix the error message list cleanup when NO-ERROR mode is enabled and ERROR-STATUS:ERRO...
- Vadim Gindin wrote:
> 1. The main conclusion is there are no stacking behavior with error lists. I.e. the error list... - 02:34 AM User Interface Feature #1805: add missing UI method support
- Vadim, please use this version, the headers in Frame.java and GenericFrame.java are fixed now.
06/16/2014
- 05:36 PM Database Feature #2312: match Progress collation in a SQL Server database
- Apparently none of available collations are good enough.
Attached a spreadsheet with summary of the research.
* 1st... - 04:53 AM Database Feature #2312: match Progress collation in a SQL Server database
- As expected, the order is the same on both windows and linux implementations. The output file is attached.
I go o... - 05:13 PM User Interface Feature #2252: implement GUI client support
- For #2229, I have started a set of testcases to explore the behavior and features of the GUI multi-window environment...
- 04:45 PM User Interface Feature #1789: implement the toggle-box widget
- I have added a note to #1791 to describe the problem and to reference note 30 in this task. You don't need to do any...
- 03:54 PM User Interface Feature #1789: implement the toggle-box widget
- > What does the 4GL do here? I believe that this can't be done in the 4GL either. It probably raises an error. We sho...
- 02:02 PM User Interface Feature #1789: implement the toggle-box widget
- Code Review 0613b
The changes look fine.
> the message will display for all such widgets, not for the first enc... - 04:44 PM User Interface Feature #1791: implement dynamic UI support
- One issue that needs to be addressed is how the order of attribute assignment (in the CREATE widget statement) can af...
- 03:29 PM Base Language Feature #2287: implement missing type conversion for POLY cases in data type wrapper assign method
- In regard to how to setup and run conversion on the server project, please see #2299. Read that task history careful...
- 03:23 PM Base Language Feature #2287: implement missing type conversion for POLY cases in data type wrapper assign method
- Code Review 0616a
The approach is much better. It is almost done now. The final issue is this code (from annotat... - 01:34 PM Base Language Feature #2287: implement missing type conversion for POLY cases in data type wrapper assign method
- Constantin, please could you offer me more details? What is server project, where is located, how to do the test?
- 12:42 PM Base Language Feature #2287: implement missing type conversion for POLY cases in data type wrapper assign method
- Marius, when regression testing this update, make sure to check the converted sources for the server project, if ther...
- 11:38 AM Base Language Feature #2287: implement missing type conversion for POLY cases in data type wrapper assign method
- Here are the new changes related to this issue and #2050.
1. I created a new annotation "poly_wrapper" to be used ... - 02:55 PM User Interface Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects)
- I'm moving this to the GUI milestone as we have done more than enough for the needs of M11.
Vadim: we will pick th... - 01:24 PM User Interface Feature #1805: add missing UI method support
- Code Review 0613a
The changes look fine. Please get this runtime regression tested. - 12:28 PM Base Language Bug #2293: Fixing an unfixed extent output parameter causes an error
- Greg Shah wrote:
> Eric: is there a reason not to allow this to naturally support write use cases?
It's not neede... - 11:24 AM Base Language Bug #2293: Fixing an unfixed extent output parameter causes an error
- Eric: is there a reason not to allow this to naturally support write use cases?
- 08:21 AM Base Language Bug #2293: Fixing an unfixed extent output parameter causes an error
- I didn't find any write-usages myself and from the code it wasn't clear whether it was planned to use the constructor...
- 03:02 AM Base Language Feature #2050 (WIP): ATTR_POLY/METH_POLY used as rvalue or in expressions
- 08:23 PM Base Language Feature #1628: fix any incompatibilities or missing features of NO-ECHO support
- Greg Shah wrote:
> Please check if this is working. Does this resolve your problem? Does this work for the genera...
06/14/2014
- 04:48 PM Base Language Bug #2293: Fixing an unfixed extent output parameter causes an error
- Constantin Asofiei wrote:
> This suggests that the FieldReference instance created via that c'tor is read-only, and ... - 11:42 AM Base Language Bug #2293: Fixing an unfixed extent output parameter causes an error
- Hynek Cihlar wrote:
> What I am trying to say is that if you construct the @FieldReference@ with any "non-indexed" c... - 10:49 AM Base Language Bug #2293: Fixing an unfixed extent output parameter causes an error
- Greg Shah wrote:
> The actual reading (and writing if necessary) is deferred until the runtime code needs to access ... - 01:18 PM User Interface Feature #2252: implement GUI client support
- > To be clear, I don't plan to provide any support that the 4GL doesn't already provide. For compatibility purposes, ...
- 09:35 AM User Interface Feature #2252: implement GUI client support
- Greg Shah wrote:
> Could Windows (or the 4GL) be mapping this as a "generic" sans-serif font that is actually differ... - 06:44 AM Base Language Bug #2197: fix the error message list cleanup when NO-ERROR mode is enabled and ERROR-STATUS:ERRO...
- I made some tests and committed them into @/errlist@ subfolder. There are also your tests there. Most of my tests con...
06/13/2014
- 07:41 PM User Interface Feature #1789: implement the toggle-box widget
- Another screen artifact has been found working with @toggle-box@ widget. Take a look at @toggle_box13.jpg@. The probl...
- 02:17 PM User Interface Feature #1789: implement the toggle-box widget
- This new update fixes the note for previous one and has cleaned widget drawing code. Looks like no additional changes...
- 10:38 AM User Interface Feature #1789: implement the toggle-box widget
- Code Review 0613a
The changes look good. The only thing to change is to save off the screen-buffer changes into t... - 07:17 AM User Interface Feature #1789: implement the toggle-box widget
- The support for @VALUE-CHANGED@ event has been added to the @ToggleBox@. The testcase to verify - @toggle_box10.p@. T...
- 03:55 PM Database Feature #2312: match Progress collation in a SQL Server database
- Ovidiu Maxiniuc wrote:
> The order in which strings are sorted in p4gl is detected by the attached Progress procedur... - 02:20 PM Database Feature #2312: match Progress collation in a SQL Server database
- Forgot to add collation test for Sql Server.
- 02:19 PM Database Feature #2312 (WIP): match Progress collation in a SQL Server database
- I am not sure we create a user-defined collation in SQL Server :(. From my research we have to be lucky enough to fin...
- 02:05 PM Base Language Feature #2287: implement missing type conversion for POLY cases in data type wrapper assign method
- > Do you think that is a good idea to use another annotation instead of "chp_wrapper" for this case?
Yes, it will ... - 02:02 PM Base Language Feature #2287: implement missing type conversion for POLY cases in data type wrapper assign method
- When my rule from annotations/functions.rules is executed the return type of the function is not yet known. I think t...
- 01:51 PM Base Language Feature #2287: implement missing type conversion for POLY cases in data type wrapper assign method
- Code Review 0613b
This code in builtin_funcs.rules is definitely not right:... - 12:34 PM Base Language Feature #2287: implement missing type conversion for POLY cases in data type wrapper assign method
- Exactly right. The @on="false"@ is a way to make the contained rule part of the @else@ branch of the conditional.
- 12:33 PM Base Language Feature #2287: implement missing type conversion for POLY cases in data type wrapper assign method
- I did the changes in the rules. Please let me know if my changes are OK.
- 12:02 PM Base Language Feature #2287: implement missing type conversion for POLY cases in data type wrapper assign method
- OK. Now I understand. The real structure was:...
- 11:40 AM Base Language Feature #2287: implement missing type conversion for POLY cases in data type wrapper assign method
- This is my first issue on which I'm working and require to define new rules.
I have one question please regarding ru... - 10:53 AM Base Language Feature #2287: implement missing type conversion for POLY cases in data type wrapper assign method
- Code Review 0613a
1. The datetimetz imports have been expanded.
2. In functions.rules, this code is too restric... - 09:45 AM Base Language Feature #2287: implement missing type conversion for POLY cases in data type wrapper assign method
- Here is the attachement.
- 09:45 AM Base Language Feature #2287: implement missing type conversion for POLY cases in data type wrapper assign method
- Here are the latest changes that I made on this issue.
1. I implemented a rule to wrap the result of a DYNAMIC-FUN... - 10:21 AM Base Language Bug #2293: Fixing an unfixed extent output parameter causes an error
- The idea of the FieldReference is to allow the delegation of reading/writing a database field to runtime code that is...
- 04:32 AM Base Language Bug #2293: Fixing an unfixed extent output parameter causes an error
- Actually, setting the sizer in the constructor @FieldReference(Database, Class, String)@ makes sense. So the question...
- 04:11 AM Base Language Bug #2293: Fixing an unfixed extent output parameter causes an error
- In the constructor @FieldReference(Database, Class<?>, String)@ the setter is not set and the sizer is. This is suspi...
- 02:06 AM User Interface Feature #1805: add missing UI method support
- I prepared the next update that contains last corrections corresponding to your last notes. I did not add new header ...
06/12/2014
- 05:02 PM Database Feature #2312: match Progress collation in a SQL Server database
- When sorting on a text column, Progress sorts its rows differently in certain cases than PostgreSQL does by default, ...
- 10:31 AM User Interface Feature #2252: implement GUI client support
- To be clear, I don't plan to provide any support that the 4GL doesn't already provide. For compatibility purposes, w...
- 10:25 AM User Interface Feature #2252: implement GUI client support
- > Greg Shah wrote:
> > Include any information needed for the FONT-TABLE to be configured as well (e.g. font to font ... - 10:18 AM User Interface Feature #2252: implement GUI client support
- I've added these files to the testcases repo:
# @uast/fonts/system-metrics/font-list.txt@ - list of fonts standard f... - 09:07 AM Base Language Feature #2287: implement missing type conversion for POLY cases in data type wrapper assign method
- Code Review 0612a
The changes look fine.
> The only solution remains to change the conversion and to wrap the r... - 06:15 AM Base Language Feature #2287: implement missing type conversion for POLY cases in data type wrapper assign method
- Unfortunately my idea to fix the note #13 does not work. Using the following test case:...
- 09:05 AM User Interface Feature #1789: implement the toggle-box widget
- Code Review 0611b
The changes look fine. - 10:24 PM User Interface Feature #1789: implement the toggle-box widget
- With this update correct handling for @ASSIGN@, screen value and variable value differences added. Also for now I hav...
- 09:02 AM Base Language Feature #1628: fix any incompatibilities or missing features of NO-ECHO support
- I think our approach to explicit terminal stream processing has been poor in the past. We "took advantage" of using ...
- 06:24 AM User Interface Feature #1805: add missing UI method support
- Vadim Gindin wrote:
> Questions.
> 1) Am I using the right IDs?
Yes, the IDs are right.
> 3) May be we should del... - 06:12 AM Base Language Bug #2197: fix the error message list cleanup when NO-ERROR mode is enabled and ERROR-STATUS:ERRO...
- Vadim Gindin wrote:
> Current implementation for me does not seems clear. Why don't we use a Stack structure to main... - 05:11 AM Base Language Bug #2197: fix the error message list cleanup when NO-ERROR mode is enabled and ERROR-STATUS:ERRO...
- It seems we need not only additional errors list. We also need additional flags like @error@, @pending@ and some othe...
06/11/2014
- 07:19 PM Base Language Feature #1628: fix any incompatibilities or missing features of NO-ECHO support
- I need to determine Terminal stream. But got a problem:...
- 05:18 PM User Interface Feature #1789: implement the toggle-box widget
- > 1. Please rename @ToggleBoxImpl.drawChekBox()@ to @ToggleBoxImpl.drawCheckBox()@.
OK. Sorry this was just syntax... - 04:53 PM User Interface Feature #1789: implement the toggle-box widget
- Code Review 0611a
This is a very good start.
1. Please rename @ToggleBoxImpl.drawChekBox()@ to @ToggleBoxImpl.d... - 04:14 PM User Interface Feature #1789: implement the toggle-box widget
- This update adds base skeleton for @ToggleBox@ runtime implementation. This is very early version just for review the...
- 04:30 PM User Interface Feature #2252: implement GUI client support
- OK. Automate the generation as much as is reasonable. Include any information needed for the FONT-TABLE to be confi...
- 03:58 PM User Interface Feature #2252: implement GUI client support
- Greg Shah wrote:
> Please write a program that can inspect and dump these values from a legacy system. Is it suffici... - 02:32 PM User Interface Feature #2252: implement GUI client support
- The results are unfortunate but understandable.
> the metrics are not even the same across JRE implementations: Op... - 01:57 PM User Interface Feature #2252: implement GUI client support
- About fond rendering: no useful info found in Java FX or a way to switch the font rasterizer. More, the metrics are ...
- 10:02 AM Base Language Feature #2287: implement missing type conversion for POLY cases in data type wrapper assign method
- Code Review 0611a
The changes look good.
> 2. Regarding the RAW type on the customer's Linux server I've got th... - 08:24 AM Base Language Feature #2287: implement missing type conversion for POLY cases in data type wrapper assign method
- 1. I've fixed the issues from your code review.
2. Regarding the RAW type on the customer's Linux server I've got ...
06/10/2014
- 01:45 PM Base Language Feature #2287: implement missing type conversion for POLY cases in data type wrapper assign method
- Code Review 0610a
It looks very good. Some notes:
1. For the raw(BDT) constructor, please check if a properly ... - 11:35 AM Base Language Feature #2287: implement missing type conversion for POLY cases in data type wrapper assign method
- Today I did tests using test cases like Constantin suggested. The results are the same as for message cases.
The exp... - 11:41 AM Database Feature #2319: support for dialect-specific keywords in NameConverter
- Because each SQL dialect has its own set of reserved keywords the @NameConverter@ must be aware and convert the names...
- 11:12 AM Database Feature #2319 (New): support for dialect-specific keywords in NameConverter
- 11:20 AM User Interface Feature #1789: implement the toggle-box widget
- Code Review 0610a
It looks good. - 11:17 AM User Interface Feature #1789: implement the toggle-box widget
- Implemented error message and clearing other questions.
Start planning to implement runtime processing. - 10:30 AM User Interface Feature #1789: implement the toggle-box widget
- Code Review 0609b
1. The GenericWidget.isChecked()/setChecked() methods should simply execute: @throw new RuntimeE... - 11:02 AM Base Language Feature #1628: fix any incompatibilities or missing features of NO-ECHO support
- > > 5. The @GenericFrame.view(FrameElement[] data)@ use of @cacheWidgetIDs()@ seems like it will never do anything. ...
- 08:26 PM Base Language Feature #1628: fix any incompatibilities or missing features of NO-ECHO support
- Greg Shah wrote:
> Code Review 0607a
>
> 1. @GenericFrame@ is missing a history entry.
> 2. Can @GenericFrame.re...
06/09/2014
- 07:02 PM User Interface Feature #1789: implement the toggle-box widget
- Added stubs for compiling the converted code. The message for @UNKNOWN@ set value is not added yet.
The question:
... - 05:54 PM User Interface Feature #1789: implement the toggle-box widget
- > Please test how unknown value works for the CHECKED attribute and implement it in ToggleBoxWidget.setChecked(logica...
- 04:41 PM User Interface Feature #1789: implement the toggle-box widget
- Code Review 0609a
Please test how unknown value works for the CHECKED attribute and implement it in @ToggleBoxWidg... - 04:40 PM User Interface Feature #1789: implement the toggle-box widget
- > 1. To define isChecked() to the CommonWidget interface
Yes, you certainly need to add stubbed support for the CH... - 04:30 PM User Interface Feature #1789: implement the toggle-box widget
- Yes, partially the conversion has already been implemented. Except handling of the @R/W@ attribute @CHECKED@. I have ...
- 03:04 PM User Interface Feature #1789: implement the toggle-box widget
- > CHUI does not make the extra space. I think in theory it is possible to simulate [ ] label layout in CHUI by defini...
- 12:16 PM Base Language Feature #2287: implement missing type conversion for POLY cases in data type wrapper assign method
- Marius Gligor wrote:
> message v1 + dynamic-function("f2").
> message v1 - dynamic-function("f2").
> message dynam... - 12:02 PM Base Language Feature #2287: implement missing type conversion for POLY cases in data type wrapper assign method
- For DynamicOps.plus() and DynamicOps.minus() implementation I'm using the following test case:
... - 12:01 PM User Interface Feature #2252: implement GUI client support
- Related to fonts: I've managed to find the formula used by 4GL to compute the @pixels-per-row@ and @pixels-per-column...
- 11:33 AM Base Language Feature #1628: fix any incompatibilities or missing features of NO-ECHO support
- Code Review 0607a
1. @GenericFrame@ is missing a history entry.
2. Can @GenericFrame.refreshWidgets()@ could us... - 08:58 AM Base Language Feature #1628: fix any incompatibilities or missing features of NO-ECHO support
- Fixed all issues from note #22, #23, #24
testcases:...
06/07/2014
- 07:44 AM User Interface Feature #1805: add missing UI method support
- Haste makes waste - It's about me in this case. I'm sorry.
I'm working on your notes. I'm really forgot about fie...
06/06/2014
- 07:57 PM User Interface Feature #1790: implement menu support
- For now, we can only do the ChUI version but it should be designed to add GUI later. There will be work on both conv...
- 07:53 PM User Interface Feature #1789: implement the toggle-box widget
- Testcases have been committed in bzr as 1146.
- 07:39 PM User Interface Feature #1789: implement the toggle-box widget
- The attached screens are to illustrate point #1 and #2 above. The @ATTR-SPACE@ does not affect the @TOGGLE-BOX@ looki...
- 01:28 PM User Interface Feature #1789: implement the toggle-box widget
- ATTR-SPACE can be put into the frame phrase:...
- 12:37 PM User Interface Feature #1789: implement the toggle-box widget
- > 1. Check if @ATTR-SPACE@ or other options can have an impact on the label positioning. All the labels in your examp...
- 01:29 PM Base Language Feature #2232: finish testing the wrapped mode using the web services exposed by the testing server
- In wrapped mode, the request and the response are both treated as a string with the serialized XML contents of the SO...
- 12:50 PM Base Language Bug #2197: fix the error message list cleanup when NO-ERROR mode is enabled and ERROR-STATUS:ERRO...
- Vadim, regarding Q2 in note 4: as Greg mentioned, we can't clean the list too early and the right place to me looks l...
- 12:28 PM Base Language Feature #2287: implement missing type conversion for POLY cases in data type wrapper assign method
- I would really like to avoid such a flag. The reason is simple: I want the wrapper classes (BDT subclasses) to limit...
- 11:21 AM Base Language Feature #2287: implement missing type conversion for POLY cases in data type wrapper assign method
- regarding "dynamic" flag I think that is better to set on this call ControlFlowOps.invokeDynamicFunctionImpl
- 11:20 AM Base Language Feature #2287: implement missing type conversion for POLY cases in data type wrapper assign method
- Marius Gligor wrote:
> In order to know if a BDT is the result of a DYNAMIC-FUNCTION call I have an idea.
Your idea... - 11:00 AM Base Language Feature #2287: implement missing type conversion for POLY cases in data type wrapper assign method
- Here are the latest changes that I did so far for other BDT's like handle, longchar, raw, memptr, date, raw etc.
I... - 10:20 AM User Interface Feature #1805: add missing UI method support
- Vadim Gindin wrote:
> The update passed regression testing and have committed to bzr. Rev #10545
Some issues about ... - 09:47 AM User Interface Feature #1805: add missing UI method support
- The update passed regression testing and have committed to bzr. Rev #10545
- 10:06 AM User Interface Feature #2146 (Closed): add support for FIRST-TAB-ITEM/NEXT-TAB-ITEM attributes (needed for server)
- 09:49 AM User Interface Feature #2146: add support for FIRST-TAB-ITEM/NEXT-TAB-ITEM attributes (needed for server)
- The update passed regression testing and have committed to bzr. Rev #10545
- 10:06 AM User Interface Feature #2144 (Closed): add minimum runtime support for methods (server)
06/05/2014
- 09:55 AM User Interface Feature #1789: implement the toggle-box widget
- Please add tests for the following cases:
1. Check if ATTR-SPACE or other options can have an impact on the label ... - 07:03 AM User Interface Feature #1789: implement the toggle-box widget
- After analyzing of the @ABL Reference@ book the testcases to demonstrate the behavior in all possible options accordi...
- 09:19 AM Runtime Infrastructure Bug #2305 (Closed): context-local vars need to be reset in a predetermined order
- 02:54 AM Runtime Infrastructure Bug #2305: context-local vars need to be reset in a predetermined order
- Attached was committed to bzr rev 10544.
- 12:22 AM Runtime Infrastructure Bug #2305: context-local vars need to be reset in a predetermined order
- Update 0601b looks good to me, nice work. Please note that header entry number 098 is duplicated in @TemporaryBuffer@.
06/04/2014
- 06:34 PM Database Feature #2220: dynamic query methods which require implementation
- Update for review with indexInformation implemented.
- 10:02 AM Base Language Feature #2287: implement missing type conversion for POLY cases in data type wrapper assign method
- Excellent point/question.
Marius: please do implement the missing functionality in the util/DynamicOps class as ... - 09:56 AM Base Language Feature #2287: implement missing type conversion for POLY cases in data type wrapper assign method
- Greg: will the DynamicOps APIs be implemented with this task or another?
06/03/2014
- 06:09 PM Runtime Infrastructure Feature #2316: improve directory XML encoding
- -------- Original Message --------
Subject: directory.xml - an idea to the backlog
Date: Tue, 03 Jun 2014 22:16:0... - 06:07 PM Runtime Infrastructure Feature #2316 (New): improve directory XML encoding
- 04:51 PM Database Bug #2315: CAN-FIND() conversion throws exception if record is unavailable for WHERE clause.
- Details are in issue #2301, notes 32, 34, 35.
- 04:49 PM Database Bug #2315 (Closed): CAN-FIND() conversion throws exception if record is unavailable for WHERE cla...
- 04:32 PM Database Feature #2314: make the _meta database conversion and runtime optional
- For projects which don't require/use the metadata DB, the conversion process should not generate the @dmo._meta@ DMO'...
- 04:31 PM Database Feature #2314 (New): make the _meta database conversion and runtime optional
- 02:41 PM Base Language Feature #2287: implement missing type conversion for POLY cases in data type wrapper assign method
- Code Review 0603b
The changes look good. - 12:34 PM Base Language Feature #2287: implement missing type conversion for POLY cases in data type wrapper assign method
- The archive contains the implementation of decimal wrapper type conversion for POLY cases.
- 11:29 AM Base Language Feature #2287: implement missing type conversion for POLY cases in data type wrapper assign method
- Until to fix the conversion issue I found a temporary solution to test the behaviour on P2J by swap the _isEqual oper...
- 10:05 AM Base Language Feature #2287: implement missing type conversion for POLY cases in data type wrapper assign method
- Code Review 0603a
The changes look good. I'm glad you were able to fix the problem without extra conversion-time ... - 09:55 AM Base Language Feature #2287: implement missing type conversion for POLY cases in data type wrapper assign method
- I haven't reviewed your changes yet. But while you were editing the code, I wrote this:
> When this expression: _is... - 09:30 AM Base Language Feature #2287: implement missing type conversion for POLY cases in data type wrapper assign method
- I added new BDT types for conversion to a logical value.
I found and implemented the conversion rules for date and h... - 09:09 AM Base Language Feature #2287: implement missing type conversion for POLY cases in data type wrapper assign method
- I added the line in my configuration file and now works properly.
Thanks - 08:09 AM Base Language Feature #2287: implement missing type conversion for POLY cases in data type wrapper assign method
- Marius Gligor wrote:
> I have no such line in my p2j.cfg.xml.
> My configuration file is for <!-- Majic-specific P2... - 08:05 AM Base Language Feature #2287: implement missing type conversion for POLY cases in data type wrapper assign method
- I have no such line in my p2j.cfg.xml.
My configuration file is for <!-- Majic-specific P2J main configuration -->
- 07:23 AM Base Language Feature #2287: implement missing type conversion for POLY cases in data type wrapper assign method
- Marius Gligor wrote:
> 2. Another problem that I found is related to initial values for P4G primitives.
I think thi... - 07:17 AM Base Language Feature #2287: implement missing type conversion for POLY cases in data type wrapper assign method
- 1. Working to add more BDT types for conversion inside the logical class and I found a blocked issue.
I have the fo... - 05:04 AM Base Language Feature #1630 (Closed): implement support for UNBUFFERED in I/O statements
- 08:12 PM Base Language Feature #1630: implement support for UNBUFFERED in I/O statements
- Committed to bzr rev. 10542.
- 02:33 AM User Interface Feature #1805: add missing UI method support
- PS: make sure to merge your update with the latest bzr version.
- 02:31 AM User Interface Feature #1805: add missing UI method support
- Review for 0602a:
# when we have APIs exposed via network servers (i.e. ClientExports), is best to avoid (de)seriali...
06/02/2014
- 05:20 PM User Interface Feature #2252: implement GUI client support
- Code Review 0602a
The code looks good. There are a few files that are missing the standard headers and so forth, ... - 03:20 AM User Interface Feature #2252: implement GUI client support
- Merged with the latest P2J updates (rules files).
- 05:02 PM User Interface Feature #1805: add missing UI method support
- I corrected implementation corresponding to the last notes. Please take a look.
- 03:45 PM Database Feature #2313 (Hold): match Progress collation on a PostgreSQL database on Windows
- 03:44 PM Database Feature #2312 (WIP): match Progress collation in a SQL Server database
- 02:11 PM Base Language Feature #2287: implement missing type conversion for POLY cases in data type wrapper assign method
- Code Review 0602b
The changes look good. I assume you are working on the same changes for the other BDT types. - 12:20 PM Base Language Feature #2287: implement missing type conversion for POLY cases in data type wrapper assign method
- 1. I've started to work on this issue by executing the provided test case on P4G environment and I found the followin...
- 02:01 AM Base Language Feature #2287 (WIP): implement missing type conversion for POLY cases in data type wrapper assign...
- 12:15 PM Database Bug #18: issues with ne/equal and true/false conversion in WHERE clauses
- This task is not known to affect any customer code; removing from M11 accordingly. If testing indicates otherwise, we...
- 12:10 PM Base Language Bug #2288 (Closed): incorrect conversion and results for unknown value comparisons
- Update 0421a passed runtime regression testing and was committed to bzr rev. 10523 (although in the commit message I ...
- 09:32 AM User Interface Feature #1806 (Closed): implement UNLESS-HIDDEN
- 09:20 AM User Interface Feature #1806: implement UNLESS-HIDDEN
- The regression tasting has been passed. The update @...0530a@ has been committed in bzr as 10540.
- 09:15 AM User Interface Feature #1806: implement UNLESS-HIDDEN
- The CTRL-C testing has been completed. There are no regressions found. Had to run 3-way tests in a separate session t...
- 08:36 AM Base Language Feature #2311 (Closed): rewrite parsing of handle chains and other misc parser changes
- 06:40 AM Base Language Feature #2311 (Review): rewrite parsing of handle chains and other misc parser changes
- Greg Shah wrote:
> Excellent! Please check it in and distribute it.
Committed to bzr rev 10539. The task can be clo... - 06:24 AM Base Language Feature #2311: rewrite parsing of handle chains and other misc parser changes
- Excellent! Please check it in and distribute it.
- 07:33 AM Runtime Infrastructure Bug #2305: context-local vars need to be reset in a predetermined order
- 0601b.zip passed runtime testing - I've ran it twice, and no @ContextLocalCleanupException@ or surviving context-loca...
- 06:28 AM Runtime Infrastructure Bug #2305: context-local vars need to be reset in a predetermined order
- That is really great work! The remote connection problem is a subtle one.
- 06:34 AM Base Language Feature #1630: implement support for UNBUFFERED in I/O statements
- Great! Please do commit it and distribute it.
- 08:08 PM Base Language Feature #1630: implement support for UNBUFFERED in I/O statements
- Update @evk_upd20140528a.zip@ has passed regression testing and ready to commit.
06/01/2014
- 02:42 PM Runtime Infrastructure Bug #2305 (Review): context-local vars need to be reset in a predetermined order
- This contains the fix for RemotePersistence and note 7 (remote connection). Is going into testing now.
- 02:22 PM Runtime Infrastructure Bug #2305: context-local vars need to be reset in a predetermined order
- Constantin Asofiei wrote:
> Before pushing for a fix for the -remoteFactory- RemotePersitence problem, I want to deb... - 12:22 PM Runtime Infrastructure Bug #2305: context-local vars need to be reset in a predetermined order
- Eric Faulhaber wrote:
> I still don't understand (regarding the second case), why @PersistenceFactory.getInstance@ wo... - 08:41 AM Base Language Feature #2311: rewrite parsing of handle chains and other misc parser changes
- 0531b.passed conversion testing - MAJIC has 1 case and the server project has 2 cases where RecordBuffer.start/EndBat...
05/31/2014
- 03:31 PM Base Language Feature #2311: rewrite parsing of handle chains and other misc parser changes
- Greg Shah wrote:
> What do you suggest for the assignment stmts issue?
The fix in the end was pretty simple - I jus... - 09:09 PM Base Language Feature #1630: implement support for UNBUFFERED in I/O statements
- Greg Shah wrote:
> Code Review 0528a
>
> The code looks good.
>
> Have you finished testing all of your testca... - 08:37 PM User Interface Feature #1806: implement UNLESS-HIDDEN
- Code Review 0530a
I agree, the changes are safe. No additional testing is needed.
05/30/2014
- 07:39 PM Base Language Feature #2311: rewrite parsing of handle chains and other misc parser changes
- What do you suggest for the assignment stmts issue? We can defer it, but we may just hit it in future code. If that...
- 05:56 PM Base Language Feature #2311: rewrite parsing of handle chains and other misc parser changes
- Greg Shah wrote:
> OK, then go ahead, check in and distribute it.
Committed to bzr rev 10538.
As a reminder, the... - 05:40 PM Base Language Feature #2311: rewrite parsing of handle chains and other misc parser changes
- OK, then go ahead, check in and distribute it.
- 05:38 PM Base Language Feature #2311: rewrite parsing of handle chains and other misc parser changes
- Greg Shah wrote:
> You're confident that the handle unwrapping changes are safe?
MAJIC uses only @unwrapWidget@, an... - 05:01 PM Base Language Feature #2311: rewrite parsing of handle chains and other misc parser changes
- You're confident that the handle unwrapping changes are safe?
- 04:52 PM Base Language Feature #2311: rewrite parsing of handle chains and other misc parser changes
- Greg Shah wrote:
> I am fine with the changes. At this point, is there anything left to do?
Conversion testing pas... - 04:41 PM Base Language Feature #2311: rewrite parsing of handle chains and other misc parser changes
- Code Review 0530b
I am fine with the changes. At this point, is there anything left to do? - 04:25 PM Base Language Feature #2311: rewrite parsing of handle chains and other misc parser changes
- OK, the attached version contains this:
# @progress.g@ history fixed
# @methods_attributes.rules@ - was added a not... - 04:05 PM Base Language Feature #2311: rewrite parsing of handle chains and other misc parser changes
- > Thus, is there anything else I should do at this point? Because I doubt the COM_INVOCATION/COM_METHOD/COM_PARAMETER...
- 03:29 PM Base Language Feature #2311: rewrite parsing of handle chains and other misc parser changes
- Constantin Asofiei wrote:
> What I think ECW needs is just some simplifications of the cases when COLON nodes are in... - 03:01 PM Base Language Feature #2311: rewrite parsing of handle chains and other misc parser changes
- Constantin Asofiei wrote:
> > 1. The com_invocation/com_method processing in methods_attributes.rules is removed. I... - 02:17 PM Base Language Feature #2311: rewrite parsing of handle chains and other misc parser changes
- > BTW, are there other POLY tests, beside the ones at #2050?
Yes, dynamic_function_context_analysis.p is useful to... - 01:46 PM Base Language Feature #2311: rewrite parsing of handle chains and other misc parser changes
- Greg Shah wrote:
> Code Review 0526f
>
> Generally, I am happy with the changes. The methods_attributes.rules is ... - 07:38 PM User Interface Feature #1806: implement UNLESS-HIDDEN
- This update merges @UNLESS-HIDDEN@ changed with the recent code base. I think the tasks are pretty independent and me...
- 03:49 PM User Interface Feature #1806: implement UNLESS-HIDDEN
- The main part has been completed without regressions in two rounds. Continue with the CTRL-C part.
- 04:58 PM Database Feature #2296 (Closed): update record buffer validation to prevent database index overflow
- 08:11 AM Base Language Feature #1630: implement support for UNBUFFERED in I/O statements
- Code Review 0528a
The code looks good.
Have you finished testing all of your testcases? If it is fully working... - 08:10 PM Base Language Feature #1630: implement support for UNBUFFERED in I/O statements
- >1. Please merge the code up to the latest P2J level in bzr (Stream.java is missing changes).
>2. In both classes, p... - 08:06 AM User Interface Feature #1789: implement the toggle-box widget
- For now, we don't have GUI support yet in the rest of the client. So you can only implement ChUI right now. Later o...
05/29/2014
- 05:54 PM User Interface Feature #1806: implement UNLESS-HIDDEN
- The conversion testing has been completed without any differences in converted Java code. Started the regression test...
- 04:26 PM User Interface Feature #1806: implement UNLESS-HIDDEN
- Code Review 0529a
The changes look good. Please get them regression tested. - 01:09 PM User Interface Feature #1806: implement UNLESS-HIDDEN
- Finally I have got all local tests passed. The new changes in update for review includes:
1. Removing @LabelImpl@ cl... - 05:52 PM User Interface Feature #1789: implement the toggle-box widget
- > Start by writing testcases to demonstrate the toggle-box behavior and all its options.
Do we need to cover only ... - 05:26 PM Base Language Feature #2311: rewrite parsing of handle chains and other misc parser changes
- Code Review 0526f
Generally, I am happy with the changes. The methods_attributes.rules is so much simpler now. Ni... - 05:38 AM Base Language Feature #2311: rewrite parsing of handle chains and other misc parser changes
- A remainder issue is an investigation of the @annotations/assignment_style_stmt_rewriting.rules@ file: this will spli...
- 01:11 PM User Interface Feature #1805: add missing UI method support
- Vadim Gindin wrote:
> Constantin, thank you for the good test. It really will be useful.
>
> Here are the problem... - 07:26 AM User Interface Feature #1805: add missing UI method support
- Constantin, thank you for the good test. It really will be useful.
Here are the problems I can formulate at this mom...
05/28/2014
- 04:21 PM User Interface Feature #1806: implement UNLESS-HIDDEN
- > If everything is working in your local tests, then you can go into regression testing (both conversion and runtime)...
- 03:37 PM User Interface Feature #1806: implement UNLESS-HIDDEN
- > The changes are good, except that the @hidden()@ method should be removed from @LabeledWidget@ instead of being com...
- 03:29 PM User Interface Feature #1806: implement UNLESS-HIDDEN
- Code Review 0528b
The changes are good, except that the @hidden()@ method should be removed from @LabeledWidget@ i... - 02:59 PM User Interface Feature #1806: implement UNLESS-HIDDEN
- > Yes, please do explicitly cast it. Otherwise it is confusing to future readers/maintainers of the code.
OK. The ... - 01:49 PM User Interface Feature #1806: implement UNLESS-HIDDEN
- > If not add hidden() to LabeledWidget - we will need explicit casting fin to some class that have hidden() inside th...
- 01:42 PM User Interface Feature #1806: implement UNLESS-HIDDEN
- > 1. The hidden() method of LabeledWidget is already present in the Widget interface. LabeledDataContainer extends Fi...
- 12:49 PM User Interface Feature #1806: implement UNLESS-HIDDEN
- Code Review 0528a
I like the approach. My only questions:
1. The @hidden()@ method of @LabeledWidget@ is alrea... - 10:35 AM User Interface Feature #1806: implement UNLESS-HIDDEN
- The fix for hidden widgets has been added to the update.
The goal is to suppress label text drawing for hidden wid... - 03:54 PM User Interface Feature #1789: implement the toggle-box widget
- Start by writing testcases to demonstrate the toggle-box behavior and all its options.
Then add conversion support... - 02:38 PM Base Language Bug #2293: Fixing an unfixed extent output parameter causes an error
- Constantin Asofiei wrote:
> OK, this is a conversion problem, if the fix is not trivial leave it for another time.
... - 12:43 PM Base Language Bug #2293: Fixing an unfixed extent output parameter causes an error
- Hynek Cihlar wrote:
> Constantin Asofiei wrote:
> > Not sure if you are aware, table fields can not be set as dynam... - 12:35 PM Base Language Bug #2293: Fixing an unfixed extent output parameter causes an error
- Constantin Asofiei wrote:
> Not sure if you are aware, table fields can not be set as dynamic extent in 4GL. How doe... - 11:52 AM Base Language Bug #2293: Fixing an unfixed extent output parameter causes an error
- Hynek Cihlar wrote:
> Is the conversion of output extent fields supposed to work? When converting a temp-table field... - 11:45 AM Base Language Bug #2293: Fixing an unfixed extent output parameter causes an error
- Is the conversion of output extent fields supposed to work? When converting a temp-table field passed as output param...
- 10:36 AM Base Language Bug #2293: Fixing an unfixed extent output parameter causes an error
- By the way, we can remove the need to call @setParameter@ from the converted code completely. For example, when @exte...
- 01:45 PM Base Language Feature #1630: implement support for UNBUFFERED in I/O statements
- Code Review 0523a
The changes look good. I have some minor comments and questions:
1. Please merge the code up to ... - 12:58 PM User Interface Feature #1805: add missing UI method support
- Vadim Gindin wrote:
> Actually I found that FrameWidget has the frame property, that can be used for that case. I on... - 12:49 PM Database Feature #2296: update record buffer validation to prevent database index overflow
- The update was committed to bzr in rev 10537 and distributed by mail.
- 09:59 AM Database Feature #2296: update record buffer validation to prevent database index overflow
- Here is the summary of all the 8 tests:
20140523_172349 (CTR+C): massive fails
20140523_195225 (main): all test set... - 12:24 PM Base Language Feature #2311: rewrite parsing of handle chains and other misc parser changes
- The ges_upd20140428a.zip (amongs other changes) rewrites the AST tree for a chaining in a handle, com-handle or objec...
- 12:09 PM Base Language Feature #2311 (Closed): rewrite parsing of handle chains and other misc parser changes
05/27/2014
- 04:34 PM User Interface Feature #1806: implement UNLESS-HIDDEN
- Code Review 0523a
The changes look good.
> So this is the general bug in DISPLAY statement handling and if ther... - 04:15 PM User Interface Feature #1805: add missing UI method support
- First of all I actualized testcases. See folders MOVE_BEFORE_TAB_ITEM and first_tab_item.
Constantin Asofiei wrote... - 01:35 PM User Interface Feature #1805: add missing UI method support
- Vadim Gindin wrote:
> Here is the first working variant. It works for simple cases (without nested frames and with o... - 02:33 PM Database Feature #2296: update record buffer validation to prevent database index overflow
- Ovidiu Maxiniuc wrote:
> What do you think of the change in RecordBuffer.java:10134, namely restricting the flush() ... - 01:48 PM Database Feature #2296: update record buffer validation to prevent database index overflow
- Eric Faulhaber wrote:
> Code review 20140523a:
>
> Update looks good. The findings you documented in the code com... - 12:55 PM Database Feature #2296: update record buffer validation to prevent database index overflow
- Code review 20140523a:
Update looks good. The findings you documented in the code comments regarding the Progress ... - 09:06 AM Database Feature #2296: update record buffer validation to prevent database index overflow
- The second execution took extremely long to finish.
There were a couple less failures in CTRL+C part.
The main pa... - 01:59 PM Base Language Bug #2293: Fixing an unfixed extent output parameter causes an error
- Constantin Asofiei wrote:
> Hynek,
>
> The approach loosk good, just a question about how the converted code looks: ... - 11:59 AM Base Language Bug #2293: Fixing an unfixed extent output parameter causes an error
- Hynek,
The approach loosk good, just a question about how the converted code looks: if we have @integer[] p = extp...
Also available in: Atom