Project

General

Profile

Activity

From 05/16/2016 to 06/14/2016

06/15/2016

10:15 PM User Interface Bug #3075: The window icon popup menu isn't displayed if a user clicks on the window icon by the ...
Sergey, 11080 fixes the issue, but I don't understand the change in @prepareCopy@ mentioned by Greg:... Constantin Asofiei

06/14/2016

07:36 PM Base Language Bug #2489: FileSystemOps.searchPath(String) should return the 4GL procedure name for external pro...
Code Review Task Branch 2489a Revision 11048
I'm fine with the changes. Please runtime regression test them.
Greg Shah
07:35 PM Base Language Bug #2489: FileSystemOps.searchPath(String) should return the 4GL procedure name for external pro...
From Ovidiu:
> Task branch 2489a was rebased to latest trunk. After update, the current revision is 11048.
Greg Shah
07:31 PM User Interface Bug #3075: The window icon popup menu isn't displayed if a user clicks on the window icon by the ...
Code Review Task Branch 3084a Revision 11080
My only concern is that in @p2j.clipboard.js@, the @prepareCopy()@ wi...
Greg Shah
01:21 PM User Interface Bug #3075: The window icon popup menu isn't displayed if a user clicks on the window icon by the ...
Thanks, please review the committed revision 11080. It should fix the issue. Sergey Ivanovskiy
11:49 AM User Interface Bug #3075: The window icon popup menu isn't displayed if a user clicks on the window icon by the ...
Sergey Ivanovskiy wrote:
> Is it ok if we send the shrunken MSG_CURRENT_SELECTION message without its content to ind...
Constantin Asofiei
11:47 AM User Interface Bug #3075: The window icon popup menu isn't displayed if a user clicks on the window icon by the ...
Is it ok if we send the shrunken MSG_CURRENT_SELECTION message without its content to indicate that the current selec... Sergey Ivanovskiy
11:19 AM User Interface Bug #3075: The window icon popup menu isn't displayed if a user clicks on the window icon by the ...
Sergey Ivanovskiy wrote:
> Constantin Asofiei wrote:
> > Also, in EditorGuiImpl, in the current approach you are mi...
Constantin Asofiei
09:15 AM User Interface Bug #3075: The window icon popup menu isn't displayed if a user clicks on the window icon by the ...
Constantin Asofiei wrote:
> Also, in EditorGuiImpl, in the current approach you are missing the @invalidateSelection...
Sergey Ivanovskiy
08:54 AM User Interface Bug #3075: The window icon popup menu isn't displayed if a user clicks on the window icon by the ...
Constantin Asofiei wrote:
> Sergey, you are pushing the selected text from the widget to the driver. Is this always ...
Sergey Ivanovskiy
08:31 AM User Interface Bug #3075: The window icon popup menu isn't displayed if a user clicks on the window icon by the ...
Sergey, you are pushing the selected text from the widget to the driver. Is this always correct? What if the user s... Constantin Asofiei
08:02 AM User Interface Bug #3075: The window icon popup menu isn't displayed if a user clicks on the window icon by the ...
Committed revision 11079 updated the java doc for @SystemAction@. Sergey Ivanovskiy
07:44 AM User Interface Bug #3075: The window icon popup menu isn't displayed if a user clicks on the window icon by the ...
> Committed revision is 11078 (rebase). @SystemAction@ registers a widget action that is known to the web client too.... Greg Shah
03:27 AM User Interface Bug #3075: The window icon popup menu isn't displayed if a user clicks on the window icon by the ...
Committed revision is 11078 (rebase). @SystemAction@ registers a widget action that is known to the web client too. I... Sergey Ivanovskiy
07:07 PM Conversion Tools Feature #1735: leverage lambda expressions (Java 8 "closures") to reduce code bloat
Based on seeing the potential negative performance impact on MAJIC, I have done a less naive testcase to see if I can... Greg Shah
12:15 PM Conversion Tools Feature #1735: leverage lambda expressions (Java 8 "closures") to reduce code bloat
Task branch 1735d is currently based from trunk 11041 (it needs a rebase to trunk 11044). As of 1735d branch rev 110... Greg Shah

06/13/2016

05:20 PM User Interface Bug #3075: The window icon popup menu isn't displayed if a user clicks on the window icon by the ...
Sergey: please rebase and restart testing. Greg Shah
05:19 PM User Interface Bug #3075: The window icon popup menu isn't displayed if a user clicks on the window icon by the ...
Code Review Task Branch 3084a Revision 11077
The changes look fine.
Constantin: is the @EditorPopupGuiImpl@ cha...
Greg Shah
01:37 PM User Interface Bug #3075: The window icon popup menu isn't displayed if a user clicks on the window icon by the ...
Committed revision 11077 has minor fixes: StringIndexOutOfBoundsException (note 23) and select all and copy scenario ... Sergey Ivanovskiy
01:15 PM User Interface Bug #3075: The window icon popup menu isn't displayed if a user clicks on the window icon by the ...
> Code Review Task Branch 3084a Revision 11076
>
> 1. In @WindowTitlePopupGuiImpl.create()@, why do we only call @...
Sergey Ivanovskiy
01:10 PM User Interface Bug #3075: The window icon popup menu isn't displayed if a user clicks on the window icon by the ...
The issue is related to the selection issue. The copy/cut/paste functionalities can work correctly only if the user's... Sergey Ivanovskiy
12:49 PM User Interface Bug #3075: The window icon popup menu isn't displayed if a user clicks on the window icon by the ...
The following case doesn't work for the web client
1) Open the Editor's popup and click on "Select All" menu item
2...
Sergey Ivanovskiy
12:13 PM User Interface Bug #3075: The window icon popup menu isn't displayed if a user clicks on the window icon by the ...
Greg Shah wrote:
> > P2J has StringIndexOutOfBoundsException for the "Select All" editor action.
>
> If you see ...
Sergey Ivanovskiy
10:54 AM User Interface Bug #3075: The window icon popup menu isn't displayed if a user clicks on the window icon by the ...
> P2J has StringIndexOutOfBoundsException for the "Select All" editor action.
If you see a quick solution, go ahe...
Greg Shah
10:53 AM User Interface Bug #3075: The window icon popup menu isn't displayed if a user clicks on the window icon by the ...
Code Review Task Branch 3084a Revision 11076
1. In @WindowTitlePopupGuiImpl.create()@, why do we only call @regist...
Greg Shah
09:54 AM User Interface Bug #3075: The window icon popup menu isn't displayed if a user clicks on the window icon by the ...
The window minimize action doesn't work correctly from the system menu for the web client. The menu overlay window is... Sergey Ivanovskiy
03:33 AM User Interface Bug #3075: The window icon popup menu isn't displayed if a user clicks on the window icon by the ...
Committed revision 11075 fixed the modal window case if the window icon wouldn't present. Sergey Ivanovskiy

06/12/2016

04:11 PM User Interface Bug #3075: The window icon popup menu isn't displayed if a user clicks on the window icon by the ...
3084a rev 11074 is rebased on the current trunc rev 11043. Sergey Ivanovskiy
03:13 AM User Interface Bug #3075: The window icon popup menu isn't displayed if a user clicks on the window icon by the ...
There are no differences in the conversion sources for the Majic. Planning to rebase and do manual GUI testing later ... Sergey Ivanovskiy

06/10/2016

05:16 PM User Interface Bug #3075: The window icon popup menu isn't displayed if a user clicks on the window icon by the ...
Starting the conversion testing on devsrv01 according to handbook/timco.html#comparison_version.
# @~/projects/p2j@ ...
Sergey Ivanovskiy
03:21 PM User Interface Bug #3075: The window icon popup menu isn't displayed if a user clicks on the window icon by the ...
Sergey Ivanovskiy wrote:
> Greg, what are tests that you are planning to be performed before it can be merged to tru...
Greg Shah
03:19 PM User Interface Bug #3075: The window icon popup menu isn't displayed if a user clicks on the window icon by the ...
Code Review Task Branch 3084a Revision 11073
The changes are fine.
Greg Shah
02:45 PM User Interface Bug #3075: The window icon popup menu isn't displayed if a user clicks on the window icon by the ...
Greg, what are tests that you are planning to be performed before it can be merged to trunc? Manual GUI testing? Sergey Ivanovskiy
10:15 AM User Interface Bug #3075: The window icon popup menu isn't displayed if a user clicks on the window icon by the ...
Committed revision 11073 fixed mouse window title popup for the Web client. Please review the changes. Sergey Ivanovskiy
08:36 AM User Interface Bug #3075: The window icon popup menu isn't displayed if a user clicks on the window icon by the ...
Please clear this issue in 3084a and I'd like to get that tested and merged to trunk ASAP. Greg Shah
08:10 AM User Interface Bug #3075: The window icon popup menu isn't displayed if a user clicks on the window icon by the ...
To work around this issue I am planning to register new fake actions, @SystemAction@, for the window title bar and it... Sergey Ivanovskiy
05:48 AM User Interface Bug #3075: The window icon popup menu isn't displayed if a user clicks on the window icon by the ...
After applying changes of 11042 trunc revision all changes for this task are vanished and mean nothing. Now LeftMouse... Sergey Ivanovskiy
08:35 AM User Interface Bug #2931: test Safari browser support
Code Review Task Branch 3084a Revision 11072
The changes are good.
Greg Shah
09:29 PM User Interface Bug #2931: test Safari browser support
Committed revision 11071. It needs to rebase to 11042 trunc and to check menu functionalities. Sergey Ivanovskiy

06/09/2016

01:22 PM User Interface Bug #2970 (Closed): rework menus to use OverlayWindow
Greg Shah
01:21 PM User Interface Bug #2970: rework menus to use OverlayWindow
2970a merged to trunk as revision 11042 and archived. Hynek Cihlar
12:52 PM User Interface Bug #2970: rework menus to use OverlayWindow
Please merge to trunk. Greg Shah
12:42 PM User Interface Bug #2970: rework menus to use OverlayWindow
Eugenie Lyzenko wrote:
> Hynek Cihlar wrote:
> > Eugenie Lyzenko wrote:
> > > The mouse pointer will not be over m...
Hynek Cihlar
12:29 PM User Interface Bug #2970: rework menus to use OverlayWindow
Hynek Cihlar wrote:
> Eugenie Lyzenko wrote:
> > The mouse pointer will not be over menu, correct? Will the menu co...
Eugenie Lyzenko
12:18 PM User Interface Bug #2970: rework menus to use OverlayWindow
Eugenie Lyzenko wrote:
> The mouse pointer will not be over menu, correct? Will the menu consider @mouseEntered@ as ...
Hynek Cihlar
11:59 AM User Interface Bug #2970: rework menus to use OverlayWindow
Hynek Cihlar wrote:
> Eugenie Lyzenko wrote:
> There is no functional difference, the change makes the code more re...
Eugenie Lyzenko
11:36 AM User Interface Bug #2970: rework menus to use OverlayWindow
2970a 11065 has passed ChUI regression testing, there are just the usual failed tests not related to this issue.
I...
Hynek Cihlar
02:38 AM User Interface Bug #2970: rework menus to use OverlayWindow
Vadim Gindin wrote:
> Did you also test popup_ext.p and system popups (window title popup, scroll popup and editor p...
Hynek Cihlar
01:21 PM User Interface Bug #2931: test Safari browser support
> would you prefer that this task should be done in the separate task or it should be done here?
Please create a n...
Greg Shah
12:50 PM User Interface Bug #2931: test Safari browser support
Sergey Ivanovskiy wrote:
> I detected the same problem that appears using Safari on Google Chrome ver. 50.0.2661.102...
Sergey Ivanovskiy
09:45 AM User Interface Bug #2931: test Safari browser support
> If the browser API is changed, then this function is failed now. It can be changed to return null object without th... Greg Shah
09:32 AM User Interface Bug #2931: test Safari browser support
If the browser API is changed, then this function is failed now. It can be changed to return null object without thro... Sergey Ivanovskiy
09:24 AM User Interface Bug #2931: test Safari browser support
Constantin Asofiei wrote:
> Sergey, one question about 3084a: in @p2j.js@ @createKeyEvent@, you have a @finally@ blo...
Greg Shah
09:22 AM User Interface Bug #2931: test Safari browser support
Code Review Task Branch 3084a Revision 11070
The changes are good.
Greg Shah
09:05 AM Database Bug #3126: Incorrect compound query iteration order if a backing buffer is updated.
> Can this be seen in the customer's application?
No. Found it accidentaly in standalone tescases.
> Does this ha...
Stanislav Lomany
09:03 AM Database Bug #3126: Incorrect compound query iteration order if a backing buffer is updated.
Testcase 2:... Stanislav Lomany
08:56 AM Database Bug #3126: Incorrect compound query iteration order if a backing buffer is updated.
Can this be seen in the customer's application? Or is this just an issue you found in standalone testcases?
Does ...
Greg Shah
08:54 AM Database Bug #3126: Incorrect compound query iteration order if a backing buffer is updated.
Testcase 1:... Stanislav Lomany
08:51 AM Database Bug #3126 (New): Incorrect compound query iteration order if a backing buffer is updated.
Stanislav Lomany

06/08/2016

05:33 PM User Interface Bug #2970: rework menus to use OverlayWindow
Did you also test popup_ext.p and system popups (window title popup, scroll popup and editor popup)? Vadim Gindin
03:36 PM User Interface Bug #2970: rework menus to use OverlayWindow
Eugenie Lyzenko wrote:
> >> 2. gui/SubMenuGuiImpl.java. The boolean flag mouseEntered usage is reworked. Please e...
Hynek Cihlar
03:11 PM User Interface Bug #2970: rework menus to use OverlayWindow
>> 2. gui/SubMenuGuiImpl.java. The boolean flag mouseEntered usage is reworked. Please explain the idea behind the... Eugenie Lyzenko
02:30 PM User Interface Bug #2970: rework menus to use OverlayWindow
Vadim Gindin wrote:
> I've just tried to run @menu/simple_sm.p@ and I got infinite loop. Did you run that test?
T...
Hynek Cihlar
02:15 PM User Interface Bug #2970: rework menus to use OverlayWindow
Eugenie Lyzenko wrote:
> Code review for 11060 revision.
>
> 1. @gui/MenuItemGuiImpl.java@. The boolean flag @mou...
Hynek Cihlar
01:35 PM User Interface Bug #2970: rework menus to use OverlayWindow
Some additional questions:
# @OverlayWindow.draw()@ contains the following code. ...
Vadim Gindin
01:19 PM User Interface Bug #2970: rework menus to use OverlayWindow
I've just tried to run @menu/simple_sm.p@ and I got infinite loop. Did you run that test? Vadim Gindin
01:11 PM User Interface Bug #2970: rework menus to use OverlayWindow
Code review for 11060 revision.
1. @gui/MenuItemGuiImpl.java@. The boolean flag @mouseEntered@ is removed from @on...
Eugenie Lyzenko
11:25 AM User Interface Bug #2970: rework menus to use OverlayWindow
Constantin Asofiei wrote:
> You have a @TODO: remove@ for @@SubMenuGuiImpl.isDescendantFocused@.
The unused metho...
Hynek Cihlar
11:25 AM User Interface Bug #2970: rework menus to use OverlayWindow
Greg Shah wrote:
> Code Review Task Branch 2970a Revision 11059
>
> 1. Why was the @KA_CURSOR_RIGHT@ event proces...
Hynek Cihlar
10:41 AM User Interface Bug #2970: rework menus to use OverlayWindow
Hynek, beside what Greg noted, the changes in 2970a/11059 are OK, I like that they are not invasive so they do not af... Constantin Asofiei
10:15 AM User Interface Bug #2970: rework menus to use OverlayWindow
Code Review Task Branch 2970a Revision 11059
This is a very nice improvement. I think the menu implementation is ...
Greg Shah
09:37 AM User Interface Bug #2970: rework menus to use OverlayWindow
Task branch 2970a 11059 resolves the issues mentioned in previous note and passes Web GUI regression testing. Please ... Hynek Cihlar
05:21 PM User Interface Bug #2931: test Safari browser support
Zooming 4 times this picture helps to observe that a vertical char consists from 3 parallels and the middle line is l... Sergey Ivanovskiy
05:09 PM User Interface Bug #2931: test Safari browser support
I detected the same problem that appears using Safari on Google Chrome ver. 50.0.2661.102 and Win7 32-bit image. The ... Sergey Ivanovskiy
04:43 PM User Interface Bug #2931: test Safari browser support
Committed revision 11070 (3084a) fixed 5-8 and added comments to @fontMetrics@. 11069 revision is a rebase from the 1... Sergey Ivanovskiy
04:38 PM User Interface Bug #2931: test Safari browser support
I used here the code from YUI library https://github.com/yui/yui3/blob/master/src/event-simulate/js/event-simulate.js... Sergey Ivanovskiy
04:18 PM User Interface Bug #2931: test Safari browser support
Sergey, one question about 3084a: in @p2j.js@ @createKeyEvent@, you have a @finally@ block which uses an @event@ obje... Constantin Asofiei
03:53 PM User Interface Bug #2931: test Safari browser support
> I uses mean and variance approach because antialiasing transforms pixels so that they become colored in gray colors... Greg Shah
03:15 PM User Interface Bug #2931: test Safari browser support
> 1. In @p2j.screen.js@, the @fontMetrics@ constructor function uses
> instead of the previous approach:
> What do w...
Sergey Ivanovskiy
02:47 PM User Interface Bug #2931: test Safari browser support
Code Review Task Branch 3080a Revision 11068
Wow! That is a lot of work. Good job.
1. In @p2j.screen.js@, the...
Greg Shah
12:53 PM User Interface Bug #2931: test Safari browser support
Greg, please review the committed revision 11068 (3084a). This task is ready. Sergey Ivanovskiy
08:27 PM User Interface Bug #2931: test Safari browser support
Sergey Ivanovskiy wrote:
> Found an interesting Safari feature to draw vertical line '\u2502' on the offscreen canva...
Sergey Ivanovskiy
10:05 AM User Interface Bug #3125: Mnemonics support in menus needs to be improved
There are various issues with mnemonics support in menus in current trunk.
# In GUI, the correct key combination t...
Hynek Cihlar
10:00 AM User Interface Bug #3125 (New): Mnemonics support in menus needs to be improved
Hynek Cihlar
09:52 AM User Interface Bug #3124: Various ChUI menu issues
These issues can be reproduced in current trunk in ChUI mode.
# Root submenus in a window-attached menu are not hi...
Hynek Cihlar
09:48 AM User Interface Bug #3124 (New): Various ChUI menu issues
Hynek Cihlar
09:46 AM User Interface Bug #3123: Pressing ESC in an active GUI menu should only exit the menu
The issue can be reproduced in current trunk in GUI mode.
The steps are:
1. Activate a window-attached or a popu...
Hynek Cihlar
09:43 AM User Interface Bug #3123 (New): Pressing ESC in an active GUI menu should only exit the menu
Hynek Cihlar

06/07/2016

07:32 PM User Interface Bug #2970: rework menus to use OverlayWindow
Task branch 2970a 11058 is the reworked menus ready for review. The revision has passed ChUI and Swing GUI regression... Hynek Cihlar
03:59 PM User Interface Bug #2931: test Safari browser support
Found an interesting Safari feature to draw vertical line '\u2502' on the offscreen canvas for the '12px monospace' f... Sergey Ivanovskiy
12:33 PM User Interface Bug #2931: test Safari browser support
Now working on the note 29 to detect the font height correctly using offscreen canvas. The tests to detect the first ... Sergey Ivanovskiy

06/06/2016

11:21 AM User Interface Bug #2931: test Safari browser support
The CHUI web client displays the screen incorrectly in the case of Safari. The width and height of the canvas, font f... Sergey Ivanovskiy

06/03/2016

02:15 PM User Interface Bug #2931: test Safari browser support
Greg, please review committed revision 11065. It fixed auto-repeat processing for Safari. Sergey Ivanovskiy
11:43 AM User Interface Bug #2931: test Safari browser support
It seems that this document demystifies the root of the 229 code https://lists.w3.org/Archives/Public/www-dom/2010Jul... Sergey Ivanovskiy
07:09 AM User Interface Bug #2931: test Safari browser support
It seems that Safari sends keyDown events with 229 key code for autorepeats. http://stackoverflow.com/questions/25043... Sergey Ivanovskiy
06:23 AM User Interface Bug #2931: test Safari browser support
Please review the committed revision 11064. There still exists the autorepeat issue even the automatic switch to a do... Sergey Ivanovskiy
05:14 AM User Interface Bug #2931: test Safari browser support
These commands @document.execCommand("copy|cut|paste")@ are not supported by Safari, thus we must prompt a user to us... Sergey Ivanovskiy
09:18 AM Conversion Tools Feature #1735: leverage lambda expressions (Java 8 "closures") to reduce code bloat
Thanks. Yes, it is already making a difference. There is much more improvement to come. Greg Shah
09:13 AM Conversion Tools Feature #1735: leverage lambda expressions (Java 8 "closures") to reduce code bloat
Greg, I really like the look of this. Paul E
07:35 AM User Interface Bug #2970: rework menus to use OverlayWindow
2970a rebased against trunk 11041, now at revision 11049. Hynek Cihlar

06/02/2016

06:23 PM Conversion Tools Feature #1735: leverage lambda expressions (Java 8 "closures") to reduce code bloat
Changed conversion to emit DELETE statement validation expressions as lambdas instead of an inner class of the block.... Greg Shah
03:42 PM User Interface Bug #2931: test Safari browser support
> I guess OPTION needs to be used for ALT?
Yes.
> How does one do F1 - F12? How to do HOME, END, INSERT, DELETE, BA...
Sergey Ivanovskiy
02:15 PM User Interface Bug #2923: ./combo_box/combo_box9_1.p web combobox width is not enough to display its content wit...
I think this way can be successful to fix this issue. Sergey Ivanovskiy
02:14 PM User Interface Bug #2923: ./combo_box/combo_box9_1.p web combobox width is not enough to display its content wit...
New branch 2923a is created. Sergey Ivanovskiy
10:00 AM User Interface Bug #2923: ./combo_box/combo_box9_1.p web combobox width is not enough to display its content wit...
> Greg, do you have any objection if I will create 2923a branch for this combobox issue and remove combobox changes f... Greg Shah
10:00 AM User Interface Bug #2923: ./combo_box/combo_box9_1.p web combobox width is not enough to display its content wit...
> For this example the following issue can be observed. The P2J combobox entry item is always selected and its backgr... Greg Shah
09:38 AM User Interface Bug #2923: ./combo_box/combo_box9_1.p web combobox width is not enough to display its content wit...
Greg, do you have any objection if I will create 2923a branch for this combobox issue and remove combobox changes fro... Sergey Ivanovskiy
09:14 AM User Interface Bug #2923: ./combo_box/combo_box9_1.p web combobox width is not enough to display its content wit...
For this example the following issue can be observed. The P2J combobox entry item is always selected and its backgrou... Sergey Ivanovskiy
09:03 AM User Interface Bug #2923: ./combo_box/combo_box9_1.p web combobox width is not enough to display its content wit...
Eugenie Lyzenko wrote:
> Constantin Asofiei wrote:
> > Also, Eugenie: please review the comb-related changes in 308...
Sergey Ivanovskiy
10:59 AM User Interface Bug #3122: The P2J frame doesn't display a horizontal scroll bar if it contains many widgets in o...
This picture describes it more clearly. Sergey Ivanovskiy
10:25 AM User Interface Bug #3122: The P2J frame doesn't display a horizontal scroll bar if it contains many widgets in o...
For this attached test https://proj.goldencode.com/redmine/attachments/5018/combo_box9_1.p the Progress 4GL renders a... Sergey Ivanovskiy
10:22 AM User Interface Bug #3122 (New): The P2J frame doesn't display a horizontal scroll bar if it contains many widget...
Sergey Ivanovskiy
10:19 AM User Interface Bug #3121: The combobox entry is always selected if it is focused
The P2J combobox entry item is always selected and its background is colored if this widget has the input focus. Othe... Sergey Ivanovskiy
10:14 AM User Interface Bug #3121 (New): The combobox entry is always selected if it is focused
Sergey Ivanovskiy
09:32 AM User Interface Feature #1807: implement clipboard support
Task #3120 has been created for the ChUI implementation (which will provide an "internal" clipboard).
Basic suppor...
Greg Shah
05:50 AM User Interface Bug #3120: ChUI CLIPBOARD implementation
The task #3080 note 103 implemented the CLIPBOARD support for GUI (Swing and Web clients), but the CLIPBOARD support ... Sergey Ivanovskiy
05:41 AM User Interface Bug #3120 (New): ChUI CLIPBOARD implementation
Sergey Ivanovskiy

06/01/2016

06:45 PM User Interface Bug #2923: ./combo_box/combo_box9_1.p web combobox width is not enough to display its content wit...
Thanks, planning to compare items locations for the entry field and combobox list pixels with Progress 4GL. This meth... Sergey Ivanovskiy
04:29 PM User Interface Bug #2923: ./combo_box/combo_box9_1.p web combobox width is not enough to display its content wit...
Constantin Asofiei wrote:
> Also, Eugenie: please review the comb-related changes in 3084a.
I'm OK with changes. ...
Eugenie Lyzenko
03:18 PM User Interface Bug #2923: ./combo_box/combo_box9_1.p web combobox width is not enough to display its content wit...
Constantin Asofiei wrote:
> Sergey, for this task, have you checked combo items with length less than the combo's wi...
Sergey Ivanovskiy
03:16 PM User Interface Bug #2923: ./combo_box/combo_box9_1.p web combobox width is not enough to display its content wit...
Sergey, for this task, have you checked combo items with length less than the combo's width?
Also, Eugenie: please...
Constantin Asofiei
03:34 PM User Interface Bug #3119: Clicking on the modal dialog close caption button hides its owner, but the dialog itse...
This behavior can be observed for @./simple_alert_box.p@ test. Please, look at the #3075-7 Sergey Ivanovskiy
03:31 PM User Interface Bug #3119 (New): Clicking on the modal dialog close caption button hides its owner, but the dialo...
Sergey Ivanovskiy
03:22 PM User Interface Bug #3075: The window icon popup menu isn't displayed if a user clicks on the window icon by the ...
Sergey Ivanovskiy wrote:
> @./simple_alert_box.p com.goldencode.testcases.SimpleAlertBox.execute@ The web client is...
Constantin Asofiei
08:51 AM User Interface Bug #3075: The window icon popup menu isn't displayed if a user clicks on the window icon by the ...
> Committed revision 11032 fixes the creation of window popup for a modal window. I have checked SELECTION-LIST widge... Greg Shah
10:37 AM Database Feature #2421 (Closed): Implement DELETE-RESULT-LIST-ENTRY for PresortCompoundQuery
Eric Faulhaber
09:09 AM Runtime Infrastructure Bug #3118: performance can be improved by reducing the number of places where we instantiate an e...
Greg Shah wrote:
> NullPointerException - 17,246
> Mostly in
> com.goldencode.p2j.uast.UastHintsWorke...
Eric Faulhaber
09:07 AM Runtime Infrastructure Bug #3118: performance can be improved by reducing the number of places where we instantiate an e...
It is not clear what the real improvement will be if some or all of these cases were eliminated. We do know that the... Greg Shah
09:05 AM Runtime Infrastructure Bug #3118: performance can be improved by reducing the number of places where we instantiate an e...
-------- Forwarded Message --------
Subject: Re: Redmine #3109
Date: Mon, 16 May 2016 09:15:12 -0400
From: ias ...
Greg Shah
09:04 AM Runtime Infrastructure Bug #3118 (New): performance can be improved by reducing the number of places where we instantiat...
Greg Shah
08:49 AM User Interface Bug #2741: SELECTION-LIST sizing issues
Item 4 in note 2 needs to be resolved in this task.
In addition, there is a report of the selection-list border dr...
Greg Shah
07:58 AM Base Language Bug #2489: FileSystemOps.searchPath(String) should return the 4GL procedure name for external pro...
Code Review Task Branch 2489a Revision 11040
Overall, this is very good. Please rebase. Also apply these minor c...
Greg Shah

05/31/2016

01:49 PM Database Bug #3117: test and fix VALIDATION() expressions in a DELETE statement
In regard to the END condition processing, Eric reports this:
> This behavior came from a developer making a "corr...
Greg Shah
01:46 PM Database Bug #3117: test and fix VALIDATION() expressions in a DELETE statement
Please see the TODO comments in @BufferImpl.deleteRecord(Supplier<logical> valexp, Supplier<character> valmsg)@ and i... Greg Shah
01:43 PM Database Bug #3117 (New): test and fix VALIDATION() expressions in a DELETE statement
Greg Shah
12:18 PM User Interface Bug #3073 (Closed): Combo-box bug: widget is not in the container
Greg Shah
12:17 PM User Interface Bug #3073: Combo-box bug: widget is not in the container
I've tested it and couldn't recreate it. So we can assume this task is not actual. Vadim Gindin
11:08 AM User Interface Bug #2931: test Safari browser support
> Do you mean that if we replace COMMAND by CTRL, then COMMAND+RIGHT_ARROW action becomes CTRL+RIGHT_ARROW and can't ... Greg Shah
10:22 AM User Interface Bug #2931: test Safari browser support
> > Yes, planning to map COMMAND to CTRL by processing COMMAND + keystrokes as it is CTRL+keystrokes.
>
> OK, good...
Sergey Ivanovskiy
10:07 AM User Interface Bug #2931: test Safari browser support
> Yes, planning to map COMMAND to CTRL by processing COMMAND + keystrokes as it is CTRL+keystrokes.
OK, good. Aft...
Greg Shah
10:00 AM User Interface Bug #2931: test Safari browser support
Yes, planning to map COMMAND to CTRL by processing COMMAND + keystrokes as it is CTRL+keystrokes.
3084a is rebased t...
Sergey Ivanovskiy
09:35 AM User Interface Bug #2931: test Safari browser support
> I didn't find special Progress 4GL rules to map COMMAND + key, where COMMAND is a LEFT_WINDOW key or a RIGHT_WINDOW... Greg Shah
09:05 AM User Interface Bug #2931: test Safari browser support
Planning to rebase 3084a. Sergey Ivanovskiy
07:30 AM User Interface Bug #2931: test Safari browser support
There are graphical keyboards settings: Key Repeat and Delay Until Repeat, but the keyboard type is selected with the... Sergey Ivanovskiy
07:25 AM User Interface Bug #2931: test Safari browser support
It looks like a system bug because switching input sources and removing additional ones can produce correct browser e... Sergey Ivanovskiy
07:09 AM User Interface Bug #2931: test Safari browser support
The described in notes 12 and 13 Safari behavior is related to the different input sources. For my environment Englis... Sergey Ivanovskiy
06:59 AM User Interface Bug #2931: test Safari browser support
The repeat keys behavior of Safari can be observed if we access a physical keyboard of the target device. In the case... Sergey Ivanovskiy
06:53 AM User Interface Bug #2931: test Safari browser support
The most different behavior of Safari can be observed if we press and hold some key. The Safari produces these codes ... Sergey Ivanovskiy
06:33 AM User Interface Bug #2931: test Safari browser support
Greg, what do you think it is necessarily to map MAC OS shortcuts with new modifier key COMMAND to 4GL codes with the... Sergey Ivanovskiy
06:18 AM User Interface Bug #2931: test Safari browser support
My first expression of using MAC OS X is very positive and I like the hardware implementation of Mac mini too. Please... Sergey Ivanovskiy
05:55 AM User Interface Bug #2931: test Safari browser support
The other question is that should we map the others useful keyboard shortcuts to 4GL codes with the same meaning to b... Sergey Ivanovskiy
05:43 AM User Interface Bug #2931: test Safari browser support
I didn't find special Progress 4GL rules to map COMMAND + key, where COMMAND is a LEFT_WINDOW key or a RIGHT_WINDOW k... Sergey Ivanovskiy
04:20 AM User Interface Bug #2931: test Safari browser support
Note 6 states incorrectly that keypress event can't be suppressed for CTRL+C, CTRL+V, CTRL+X with Safari. I am using ... Sergey Ivanovskiy

05/30/2016

06:07 PM User Interface Bug #2931: test Safari browser support
For Safari CTRL + LETTER keystrokes raises keypress event with charCode that is calculated by ctrlCode = keyDownCode ... Sergey Ivanovskiy

05/29/2016

05:55 PM User Interface Bug #2970: rework menus to use OverlayWindow
2970a rebased against trunk 11039, now at revision 11045. Hynek Cihlar

05/28/2016

06:21 PM Database Feature #2421 (Review): Implement DELETE-RESULT-LIST-ENTRY for PresortCompoundQuery
Task branch 2421a was merged into the trunk as bzr revision 11039. Stanislav Lomany
04:51 AM Database Feature #2421: Implement DELETE-RESULT-LIST-ENTRY for PresortCompoundQuery
Rebased task branch 2421a from P2J trunk revision 11038. Stanislav Lomany
12:15 AM Conversion Tools Feature #1735: leverage lambda expressions (Java 8 "closures") to reduce code bloat
Task branch 1735b has changes that modify conversion to emit UI validation expressions as lambdas instead of an inner... Greg Shah

05/27/2016

04:32 PM Base Language Bug #2489: FileSystemOps.searchPath(String) should return the 4GL procedure name for external pro...
Task branch 2489a was rebased to trunk 11037. The changes from note 7 were applied. The current revision is 11040.
I...
Ovidiu Maxiniuc
12:15 AM Database Feature #2421: Implement DELETE-RESULT-LIST-ENTRY for PresortCompoundQuery
Code review 2421a/11039:
The code looks good to me. Please regression test.
Eric Faulhaber

05/26/2016

02:22 PM Database Feature #2421: Implement DELETE-RESULT-LIST-ENTRY for PresortCompoundQuery
Please review task branch 2421a revision 11039. Stanislav Lomany
02:07 PM Database Feature #2421: Implement DELETE-RESULT-LIST-ENTRY for PresortCompoundQuery
Rebased task branch 2421a from P2J trunk revision 11035. Stanislav Lomany

05/24/2016

04:07 PM Conversion Tools Feature #1735: leverage lambda expressions (Java 8 "closures") to reduce code bloat
Branch 1735a was merged to trunk as revision 11035. 1735a was archived.
This revision changes two cases of Logica...
Greg Shah
03:53 PM Database Feature #2421: Implement DELETE-RESULT-LIST-ENTRY for PresortCompoundQuery
Stanislav Lomany wrote:
> Should I fix this as the part of this task?
Yes, please do.
Eric Faulhaber
03:41 PM Database Feature #2421: Implement DELETE-RESULT-LIST-ENTRY for PresortCompoundQuery
Eric, there is the conversion issue for validation messages. Testcase:... Stanislav Lomany
09:30 PM Database Feature #2421: Implement DELETE-RESULT-LIST-ENTRY for PresortCompoundQuery
Stanislav Lomany wrote:
> Eric, for the case: am I right that @DELETE-RESULT-LIST-ENTRY@ and @{FIRST|LAST}[-OF]@ can...
Eric Faulhaber
02:08 PM Database Feature #2275: cache of runtime-converted, dynamic queries and temp-tables
The task branch 2275a was committed to trunk as revision 11034 and then archived. Notification was sent to team.
The...
Ovidiu Maxiniuc
10:36 AM Database Feature #2275: cache of runtime-converted, dynamic queries and temp-tables
Code review 2275a/11038:
The changes look fine. None of this code is used in the normal regression test environmen...
Eric Faulhaber
01:34 PM User Interface Bug #3073: Combo-box bug: widget is not in the container
Vadim: please test this and confirm if you can recreate it. Greg Shah

05/23/2016

02:40 PM Database Feature #2421: Implement DELETE-RESULT-LIST-ENTRY for PresortCompoundQuery
Eric, for the case: am I right that @DELETE-RESULT-LIST-ENTRY@ and @{FIRST|LAST}[-OF]@ cannot be used on the same que... Stanislav Lomany
10:02 AM Database Feature #2275: cache of runtime-converted, dynamic queries and temp-tables
Thanks, Eric.
The golden idea was to save the (default) parameters, too, in with 1st level cache, so we could 'rehyd...
Ovidiu Maxiniuc
09:56 AM Database Feature #2275: cache of runtime-converted, dynamic queries and temp-tables
The key to my suggested approach working is that the second scenario above cannot be appreciably slower than the curr... Eric Faulhaber
09:34 AM Database Feature #2275: cache of runtime-converted, dynamic queries and temp-tables
I've been thinking about the same problem with the 2-level cache, but I came to a different conclusion. The first lev... Eric Faulhaber
08:49 AM Database Feature #2275: cache of runtime-converted, dynamic queries and temp-tables
Eric,
I am working on double cache solution. I encountered the following issue which I sensed but was not able to de...
Ovidiu Maxiniuc
08:15 AM Database Feature #2275: cache of runtime-converted, dynamic queries and temp-tables
Ovidiu, please note that one of the changes in task branch 3109a (now P2J trunk 11032) was to increase the DQH cache ... Eric Faulhaber

05/20/2016

02:16 PM Database Feature #2275: cache of runtime-converted, dynamic queries and temp-tables
Eric Faulhaber wrote:
> Ovidiu Maxiniuc wrote:
> > I am not happy with the 'manufactured' variable names. Maybe we ...
Ovidiu Maxiniuc
02:03 PM Database Feature #2275: cache of runtime-converted, dynamic queries and temp-tables
[ECF: moved this entry to #3081-3] Ovidiu Maxiniuc
01:42 PM Database Feature #2275: cache of runtime-converted, dynamic queries and temp-tables
Ovidiu Maxiniuc wrote:
> I am not happy with the 'manufactured' variable names. Maybe we should discuss about this t...
Eric Faulhaber
11:53 AM User Interface Bug #2857: font differences for toggle box and menu
Remaining issues:
# Closing menu, reported by Constantin
# Adjustment of sizes in SWING:
## sub-menu body height a...
Vadim Gindin

05/19/2016

06:18 PM User Interface Bug #2970 (WIP): rework menus to use OverlayWindow
Hynek Cihlar
06:16 PM User Interface Bug #3071 (Closed): A NPE is thrown when Alt-Tab while COMBO-BOX drop down active
Greg Shah
06:14 PM User Interface Bug #3071: A NPE is thrown when Alt-Tab while COMBO-BOX drop down active
Cannot reproduce anymore, resolved by #3062. Hynek Cihlar
03:26 PM Database Feature #2421: Implement DELETE-RESULT-LIST-ENTRY for PresortCompoundQuery
I don't foresee an issue from the proposed change. Eric Faulhaber
02:43 PM Database Feature #2421: Implement DELETE-RESULT-LIST-ENTRY for PresortCompoundQuery
Yes, it is. Stanislav Lomany
02:34 PM Database Feature #2421: Implement DELETE-RESULT-LIST-ENTRY for PresortCompoundQuery
Stanislav Lomany wrote:
> Let me know if you foresee any problems with that.
@PreselectQuery@ was not originally me...
Eric Faulhaber
01:36 PM Database Feature #2421: Implement DELETE-RESULT-LIST-ENTRY for PresortCompoundQuery
Eric, please consider the case when an inner record of a compound query is updated AND corresponding inner sub-query ... Stanislav Lomany
03:02 PM User Interface Bug #2931: test Safari browser support
Committed revision 11045 fixed drawings of images. It seems that Chrome and Safari browsers have the same drawing iss... Sergey Ivanovskiy
02:59 PM User Interface Bug #2931: test Safari browser support
The P2J standard server certificate must be set as a trusted one at the first access to the login page. If it isn't d... Sergey Ivanovskiy
10:04 AM User Interface Bug #2931: test Safari browser support
Committed revision 11044(3084a) substitutes "const" statements to "var"s. Encountered new issue that self-signed cert... Sergey Ivanovskiy
11:34 AM Database Feature #2275: cache of runtime-converted, dynamic queries and temp-tables
Ovidiu Maxiniuc wrote:
> I need to check the operator and the opposite operand and convert the variable type/value. ...
Eric Faulhaber
11:01 AM Database Feature #2275: cache of runtime-converted, dynamic queries and temp-tables
Eric Faulhaber wrote:
> Ovidiu Maxiniuc wrote:
> > To fix this we could add casting or automatically convert the in...
Ovidiu Maxiniuc
10:54 AM Database Feature #2275: cache of runtime-converted, dynamic queries and temp-tables
Ovidiu Maxiniuc wrote:
> To fix this we could add casting or automatically convert the injected variable to required...
Eric Faulhaber
10:38 AM Database Feature #2275: cache of runtime-converted, dynamic queries and temp-tables
Eric,
I found the errors logged in @/var/log/postgresql/postgresql-9.2-p2j_enUS.log@. I don't think hibernate is abl...
Ovidiu Maxiniuc

05/18/2016

02:39 PM Database Feature #2275: cache of runtime-converted, dynamic queries and temp-tables
After more research on testcase from note 16 that causes some failures:
* I tried to isolate the testcase with TEMP-...
Ovidiu Maxiniuc
10:57 AM Conversion Tools Bug #3114: changing SharedVariableManager to call TransactionManager.register[Global]()
Greg, you are correct that SVM should do the register, and not emit explicit @TM.register@ calls. And yes, we need t... Constantin Asofiei
09:36 AM User Interface Bug #2857: font differences for toggle box and menu
Vadim, please use this patch for @AbstractGuiDriver.draw()@:... Constantin Asofiei

05/17/2016

04:35 PM Conversion Tools Bug #3114: changing SharedVariableManager to call TransactionManager.register[Global]()
It seems like we could change @SharedVariableManager@ to call @TransactionManager.register[Global]()@ when a @new [gl... Greg Shah
04:29 PM Conversion Tools Bug #3114 (New): changing SharedVariableManager to call TransactionManager.register[Global]()
Greg Shah
03:55 PM Database Feature #2421: Implement DELETE-RESULT-LIST-ENTRY for PresortCompoundQuery
Created task branch 2421a from P2J trunk revision 11031. Stanislav Lomany
03:29 PM Database Feature #2275: cache of runtime-converted, dynamic queries and temp-tables
Encountered an issue with new processing. The queries like ... Ovidiu Maxiniuc
02:26 PM Database Feature #2275: cache of runtime-converted, dynamic queries and temp-tables
Eric Faulhaber wrote:
> Ovidiu, can you please help me understand how the @variable_definitions.rules@ changes (both...
Ovidiu Maxiniuc
01:03 PM Database Feature #2275: cache of runtime-converted, dynamic queries and temp-tables
Ovidiu, can you please help me understand how the @variable_definitions.rules@ changes (both annotations and conversi... Eric Faulhaber
03:19 PM User Interface Bug #2923: ./combo_box/combo_box9_1.p web combobox width is not enough to display its content wit...
Committed revision 11043 fixes this issue. The screen looks suitable. Sergey Ivanovskiy
02:44 PM User Interface Bug #2923: ./combo_box/combo_box9_1.p web combobox width is not enough to display its content wit...
The proposed solution doesn't work because it applies the stretch to the content uniformly to all combo boxes. There ... Sergey Ivanovskiy
02:53 PM User Interface Bug #2857: font differences for toggle box and menu
Here is the test to recreate the error:... Vadim Gindin
02:47 PM User Interface Bug #3113 (Closed): web client failure when trying to connect two web clients to the same P2J server
Greg Shah
02:29 PM User Interface Bug #3113: web client failure when trying to connect two web clients to the same P2J server
Sergey Ivanovskiy wrote:
> Have checked that if @webClient/port@ is 0, then we can use two clients simultaneously. I...
Constantin Asofiei
02:28 PM User Interface Bug #3113: web client failure when trying to connect two web clients to the same P2J server
Have checked that if @webClient/port@ is 0, then we can use two clients simultaneously. I think the debug port is als... Sergey Ivanovskiy
02:01 PM User Interface Bug #3113: web client failure when trying to connect two web clients to the same P2J server
Sergey, I think you might be right, at that time I forgot that the web port (on which the redirection is done) is har... Constantin Asofiei
01:44 PM User Interface Bug #3113: web client failure when trying to connect two web clients to the same P2J server
Greg Shah wrote:
> Constantin reports:
>
> > have you tried connecting two web clients, to the same server (on th...
Sergey Ivanovskiy
01:26 PM User Interface Bug #3113: web client failure when trying to connect two web clients to the same P2J server
Constantin reports:
> have you tried connecting two web clients, to the same server (on the same machine)? I get ...
Greg Shah
01:25 PM User Interface Bug #3113 (Closed): web client failure when trying to connect two web clients to the same P2J server
Greg Shah

05/16/2016

02:08 PM Database Feature #2275: cache of runtime-converted, dynamic queries and temp-tables
Created task branch 2275a from trunk 11030. Last revision is 11031. The update is based on the algorithm described in... Ovidiu Maxiniuc
09:45 AM User Interface Bug #3062 (Closed): COMBO-BOX steals focus when its drop-down active
Greg Shah
09:43 AM User Interface Bug #3062: COMBO-BOX steals focus when its drop-down active
3062a merged to trunk as revision 11030 and archived. Hynek Cihlar
09:15 AM User Interface Bug #3062: COMBO-BOX steals focus when its drop-down active
Please go ahead and merge to trunk. Greg Shah
 

Also available in: Atom