Activity

From 09/03/2014 to 10/02/2014

10/02/2014

05:48 PM Database Feature #2220: dynamic query methods which require implementation: Stanislav Lomany wrote:
> That is correct except for:
>
> > * Fixing adaptive, non-scrolling queries.
>
> If y... Eric Faulhaber
05:00 PM Database Feature #2220: dynamic query methods which require implementation: That is correct except for:
> * Fixing adaptive, non-scrolling queries.
If you mean improving it for multi-tabl... Stanislav Lomany
12:11 PM Database Feature #2220: dynamic query methods which require implementation: OK, so my understanding of where this all stands now (and please correct me if I'm missing something) is that we have... Eric Faulhaber
07:47 AM Database Feature #2220: dynamic query methods which require implementation: > > Note that my decision to remove @Cursor.offEnd@ field probably was a mistake.
>
> It is still removed in this ... Stanislav Lomany
01:52 AM Database Feature #2220: dynamic query methods which require implementation: > Other than this, is @DELETE-RESULT-LIST-ENTRY@ fully implemented now? Is there anything else left to do on this tas... Stanislav Lomany
11:13 PM Database Feature #2220: dynamic query methods which require implementation: Code review 0928a:
I think the changes are OK, but please see my questions and comments below.
In note 45 above... Eric Faulhaber
04:15 PM User Interface Feature #2252: implement GUI client support: Greg Shah wrote:
> Is there anything left to do for STATUS or MESSAGE in #2229?
Nothing.
> ..
> What is the sta... Vadim Gindin
04:00 PM User Interface Feature #2252: implement GUI client support: Is there anything left to do for STATUS or MESSAGE in #2229? If not, then please work on DEFINE FRAME/FORM next (see... Greg Shah
03:56 PM User Interface Feature #2252: implement GUI client support: Code Review vig_upd20141002b.zip
It looks good. Greg Shah
03:52 PM User Interface Feature #2252: implement GUI client support: I thought so. I've combined history entries. Vadim Gindin
03:36 PM User Interface Feature #2252: implement GUI client support: Code Review vig_upd20141002a.zip
The changes are fine. Please do combine the history entries into a single entry ... Greg Shah
03:18 PM User Interface Feature #2252: implement GUI client support: I merged status* update and message* update. Here is the merged common update. Can I stay 2 history entries in corres... Vadim Gindin
12:56 PM User Interface Feature #2252: implement GUI client support: Code Review ca_upd20141002h.zip
It looks good. We should remember the "wishlist" somewhere for later development:... Greg Shah
12:11 PM User Interface Feature #2252: implement GUI client support: Greg Shah wrote:
> 1. The @StandardServer.invoke()@ issue still exists.
Thanks, forgot about it, is fixed now.
>... Constantin Asofiei
12:58 PM Database Bug #2402 (Test): ClassCastException thrown when accessing EXTENT fields: Code review 1002a:
The file is out of date; please merge your change up to bzr rev 10619. Other than that, the cha... Eric Faulhaber
12:50 PM Database Bug #2402: ClassCastException thrown when accessing EXTENT fields: Ovidiu Maxiniuc wrote:
> The original exception is discarded because it is caused by an @abnormalEnd()@ in the @Bloc... Eric Faulhaber
12:41 PM Database Bug #2402: ClassCastException thrown when accessing EXTENT fields: Eric Faulhaber wrote:
> Nice catch. If there is nothing more to do than the solution proposed above, please prepare ... Ovidiu Maxiniuc
12:23 PM Database Bug #2402: ClassCastException thrown when accessing EXTENT fields: The original exception is discarded because it is caused by an @abnormalEnd()@ in the @BlockManager@ so the whole unw... Ovidiu Maxiniuc
11:40 AM Database Bug #2402: ClassCastException thrown when accessing EXTENT fields: Ovidiu Maxiniuc wrote:
> The original exception is lost and not printed in logs.
Have you determined why it is lo... Eric Faulhaber
11:38 AM Database Bug #2402 (WIP): ClassCastException thrown when accessing EXTENT fields: Nice catch. If there is nothing more to do than the solution proposed above, please prepare an update and push it thr... Eric Faulhaber
06:16 AM Database Bug #2402: ClassCastException thrown when accessing EXTENT fields: What is wring is that @RecordBuffer.Handler.invoke(Object proxy, Method method, Object[] args)@, in the case of EXTEN... Ovidiu Maxiniuc
05:53 AM Database Bug #2402: ClassCastException thrown when accessing EXTENT fields: I found this while investigating queries in #2266. The following code was constructed based real code from a customer... Ovidiu Maxiniuc
05:42 AM Database Bug #2402 (Closed): ClassCastException thrown when accessing EXTENT fields: Ovidiu Maxiniuc

10/01/2014

06:26 PM User Interface Feature #2334: implement the GUI message line widget: Code Review 1001a
The code changes look good.
I think the @ThinClient.splitMessage()@ should probably be move... Greg Shah
11:58 AM User Interface Feature #2334: implement the GUI message line widget: 1. The number of visible lines is @Window.RESERVED_LINES - 1@ (2) like on ChUI .
2. Message area could hold ... Marius Gligor
08:29 AM User Interface Feature #2334: implement the GUI message line widget: I'm sure that any such code is just temporary and has no deep meaning. You can remove the conditional "protection" l... Greg Shah
06:03 AM User Interface Feature #2334: implement the GUI message line widget: I'm trying to test the following p4 statement @current-window:message-area-font=5.@ which in turn is converted in Jav... Marius Gligor
05:35 PM User Interface Feature #2252: implement GUI client support: Code Review ca_upd20141001d.zip
1. The @StandardServer.invoke()@ issue still exists.
2. The merge of the histor... Greg Shah
03:50 PM User Interface Feature #2252: implement GUI client support: Code Review vig_upd20141001a.zip
Everything looks fine. Please merge your STATUS and MESSAGE updates into a singl... Greg Shah
03:33 PM User Interface Feature #2252: implement GUI client support: > By the way, should I ran majic from the folder @~/testing/majic@, created by @run_regression.sh configure@ or from ... Greg Shah
01:20 PM User Interface Feature #2252: implement GUI client support: Attached update is built on top of 0926c and 0296g.zip. Not yet merged with latest version. Issues from review no... Constantin Asofiei
12:43 PM User Interface Feature #2252: implement GUI client support: I merged my update (message multi-window support) with the last updates, moved 3 flags from ThinClient to Window and ... Vadim Gindin
11:24 AM User Interface Feature #2252: implement GUI client support: I ran regression testing on devsrv01 2 or 3 times. That is the point. I didn't see failures in the tests, that are ma... Vadim Gindin
08:25 AM User Interface Feature #2252: implement GUI client support: Please focus on running testing on devsrv01. What failures are you seeing consistently on that system? How many tim... Greg Shah
03:36 AM User Interface Feature #2252: implement GUI client support: I tried to manually recreate the failures in tests I noted earlier in devsrv01. But there were no such error. Moreove... Vadim Gindin
04:46 PM Database Feature #2220: dynamic query methods which require implementation: OK, please thoroughly document the problem in a separate issue in this project, including why it is specific to @Pres... Eric Faulhaber
02:43 PM Database Feature #2220: dynamic query methods which require implementation: I've checked the presence of @PresortCompoundQuery@ in the customer app. It presents only in @FOR EACH@ form, so ther... Stanislav Lomany
12:17 PM User Interface Feature #2340: implement the window title bar: Regarding selection of mouse source which is the widget that should handle the mouse events.
Basically we have widg... Marius Gligor

09/30/2014

04:46 PM Database Feature #2220: dynamic query methods which require implementation: If in your estimation it is not more than a few hours of effort, then yes -- it doesn't sound like it would be a lot ... Eric Faulhaber
04:41 PM Database Feature #2220: dynamic query methods which require implementation: Eric, there is a quirk in 4GL @DELETE-RESULT-LIST-ENTRY@ implementation: for adaptive non-scrolling queries if @DELET... Stanislav Lomany
04:11 PM User Interface Feature #2252: implement GUI client support: OK, then please ignore this issue and try to debug and/or solve your problems a different way. One important questio... Greg Shah
03:49 PM User Interface Feature #2252: implement GUI client support: No, server logs (server.log, server_gso_0.log) does not contain such error. Vadim Gindin
08:48 AM User Interface Feature #2252: implement GUI client support: Are these same "apparent deadlock" issues occurring when you run testing on devsrv01? Greg Shah
07:44 AM User Interface Feature #2252: implement GUI client support: Understood. I ran local server with remote (devsrv01) database. An Internet connection to GCD is good and stable. Con... Vadim Gindin
02:52 AM User Interface Feature #2252: implement GUI client support: Yes, good point -- it makes sense that the application would not work at all if the fundamental things I told you to ... Eric Faulhaber
03:28 PM User Interface Feature #2334: implement the GUI message line widget: Thanks Constantin I will check on customer's server.
I have another question related to fonts please: The call to @F... Marius Gligor
01:46 PM User Interface Feature #2334: implement the GUI message line widget: Greg/Marius: in case you are not aware, see note 3 from #2252 - the message area in GUI holds a maximum of 50 message... Constantin Asofiei
01:43 PM User Interface Feature #2334: implement the GUI message line widget: Code Review 0930a
This looks really good.
1. There are still some hard coded message lines left behind.
2. I... Greg Shah
01:37 PM User Interface Feature #2334: implement the GUI message line widget: The picture are uploaded just to show how scroll bar looks. I forced 8 lines instead 2 for message area.
When messag... Marius Gligor
01:05 PM User Interface Feature #2334: implement the GUI message line widget: Why do the message-area5.png, message-area6.png and message-area7.png show a message area that is 8 lines in size? T... Greg Shah
01:00 PM User Interface Feature #2334: implement the GUI message line widget: > Should be the same value as for ChUI or should be a parameter stored in server directory?
As I noted in note 79 ... Greg Shah
10:56 AM User Interface Feature #2334: implement the GUI message line widget: 1. For ChUI the number of message lines is hard coded and the @ThinClient# getMessageLines@ return always @Window.RES... Marius Gligor
08:56 AM Base Language Feature #1628: fix any incompatibilities or missing features of NO-ECHO support: What is the status of your work on this task? Greg Shah
08:14 AM User Interface Feature #1791: implement dynamic UI support: From EVL via email:
> Just for you to know: in addition there are some missing functionality on client side I've d... Greg Shah
08:00 PM User Interface Feature #1791: implement dynamic UI support: Committed to bzr as 10617. Eugenie Lyzenko

09/29/2014

07:52 PM User Interface Feature #1791: implement dynamic UI support: The @CTRL-C@ part completed without regressions. Had to start 3-way tests in separate session to get all passed in su... Eugenie Lyzenko
06:22 PM User Interface Feature #1791: implement dynamic UI support: >Please post the testcase code here.
Here it is. Pretty ugly but I guess do work.... Eugenie Lyzenko
05:08 PM User Interface Feature #1791: implement dynamic UI support: In other words, we will deal with the dynamic frame scoping as the next update (after you get back). Greg Shah
05:07 PM User Interface Feature #1791: implement dynamic UI support: > So I think the conclusion is scope is attached to widget pool, correct?
It tells us that at least some of the sc... Greg Shah
04:58 PM User Interface Feature #1791: implement dynamic UI support: >3. Try to use the frame in procedure Y, but outside (after) the REPEAT block. If that works, then you know that the ... Eugenie Lyzenko
09:03 AM User Interface Feature #1791: implement dynamic UI support: Code Review 0929a
The code looks good.
The last problem is the @openScope()@. We definitely need to execute ... Greg Shah
08:40 AM User Interface Feature #1791: implement dynamic UI support: > >3. I'm not sure opening the scope of a dynamic frame in GenericWidget.setId() is correct. That will associate it w... Greg Shah
05:15 AM User Interface Feature #1791: implement dynamic UI support: Small change to fix resource type requesting in @GenericWidget@ for building the error message. The testing cycle is ... Eugenie Lyzenko
04:48 PM User Interface Feature #2252: implement GUI client support: Eric, If it would be a database connectivity problem the application would not work. The error happen at the quit pro... Vadim Gindin
02:31 PM User Interface Feature #2252: implement GUI client support: Vadim, from the @server_gso_370.log@ file you attached, it looks like the P2J server cannot connect to the database. ... Eric Faulhaber
01:29 PM User Interface Feature #2252: implement GUI client support: I looked into testing results for my update and tried to reproduce failed tests locally. I found that most of them fa... Vadim Gindin
12:07 PM User Interface Feature #2252: implement GUI client support: Greg Shah wrote:
> Constantin Asofiei wrote:
> > Greg Shah wrote:
> > > Wouldn't moving to tracking changes at the... Constantin Asofiei
12:04 PM User Interface Feature #2252: implement GUI client support: Constantin Asofiei wrote:
> Greg Shah wrote:
> > Wouldn't moving to tracking changes at the field-level solve this ... Greg Shah
12:00 PM User Interface Feature #2252: implement GUI client support: Greg Shah wrote:
> Wouldn't moving to tracking changes at the field-level solve this issue?
We are not in the track... Constantin Asofiei
11:30 AM User Interface Feature #2252: implement GUI client support: Wouldn't moving to tracking changes at the field-level solve this issue? Greg Shah
11:04 AM User Interface Feature #2252: implement GUI client support: About the MethodHandle performance issues: disabling the field setter listener code during duplicate plus the AspectJ... Constantin Asofiei
08:30 AM User Interface Feature #2252: implement GUI client support: > This is because the AspectJ Point Cuts (intercepted field setters) are called always (including during instance fie... Greg Shah

09/28/2014

04:28 PM User Interface Feature #1791: implement dynamic UI support: This update for review reflects your recent notes. I'm going to put it on regression testing cycle shortly. Eugenie Lyzenko
02:34 PM User Interface Feature #1791: implement dynamic UI support: The changes passed the regression testing.
>3. I'm not sure opening the scope of a dynamic frame in GenericWidget.... Eugenie Lyzenko
09:55 AM User Interface Feature #1791: implement dynamic UI support: Code Review 0927a
It looks good! As you suggest, if it passes testing you can check it in since any broken dynami... Greg Shah
03:21 PM Database Feature #2220: dynamic query methods which require implementation: Update for adaptive scrolling cache. Fixed forward/backward. Doesn't reproduce 4GL off-end state issues noted in the ... Stanislav Lomany
11:14 AM User Interface Feature #2252: implement GUI client support: > 1. Could we drive association of common listeners (e.g. @pushScreenDefinition()@ or rounding) by AspectJ using anno... Constantin Asofiei
09:30 AM User Interface Feature #2252: implement GUI client support: Code Review ca_upd20140926g.zip
Generally, it all looks fine. The only thing I don't understand is why @ConfigMan... Greg Shah

09/27/2014

12:24 PM User Interface Feature #1791: implement dynamic UI support: This is the main dynamic widget support update for review. Has the incorrect attributes handling, dynamic frames, wid... Eugenie Lyzenko
12:07 PM User Interface Feature #2399: Implement output redirection in GUI mode: The challenge here is that the GUI session uses GUI-specific widgets which know how to render themselves on raster-ba... Hynek Cihlar
12:03 PM User Interface Feature #2399 (Rejected): Implement output redirection in GUI mode: Hynek Cihlar

09/26/2014

06:38 PM User Interface Feature #2252: implement GUI client support: Code Review ca_upd20140926c.zip - Part 2
I still haven't reviewed your latest update. That is next. My apologies ... Greg Shah
04:32 PM User Interface Feature #2252: implement GUI client support: > In the context of #2388 I checked the current state of output redirection logic and it seems to be far away from th... Greg Shah
04:20 PM User Interface Feature #2252: implement GUI client support: In the context of #2388 I checked the current state of output redirection logic and it seems to be far away from the ... Hynek Cihlar
02:22 PM User Interface Feature #2252: implement GUI client support: Greg Shah wrote:
> 1. Why not sync the server state on the next trip down to the client, instead of waiting for a @p... Constantin Asofiei
01:41 PM User Interface Feature #2252: implement GUI client support: Code Review ca_upd20140926c.zip - Part 1
I'm half-way through the review of your previous update. I haven't looke... Greg Shah
12:51 PM User Interface Feature #2252: implement GUI client support: This update contains some fixes and the AspectJ changes related to optimizing the computation of widget config update... Constantin Asofiei
11:48 AM User Interface Feature #2252: implement GUI client support: Constantin Asofiei wrote:
> Vadim, there is this code in OutputManager.setInvalidate which breaks the GUI window cre... Vadim Gindin
11:19 AM User Interface Feature #2252: implement GUI client support: I found the same problem.
I fixed this problem in my current task by creating a method @SwingGuiPrimitives#hasWindow... Marius Gligor
10:55 AM User Interface Feature #2252: implement GUI client support: Vadim, there is this code in OutputManager.setInvalidate which breaks the GUI window creation:... Constantin Asofiei
05:25 AM User Interface Feature #2252: implement GUI client support: This entry contains details for #2254
New configuration manager
------------------------------------
The new Con... Constantin Asofiei
02:33 PM User Interface Feature #1791: implement dynamic UI support: Greg/Eugenie: first of all, a trigger can't be registered with a handle which is not valid. The widget (dynamic or n... Constantin Asofiei
01:50 PM User Interface Feature #1791: implement dynamic UI support: > But imagine the case when dynamic widget creation is the result of user(or application logic) intervention. For exa... Greg Shah
01:16 PM User Interface Feature #1791: implement dynamic UI support: >We don't want to change how the client works. The client has no knowledge of handles. And to know when to fire a tri... Eugenie Lyzenko
08:55 AM User Interface Feature #1791: implement dynamic UI support: > So the triggers should be attached to the handle itself, not to the widget object(which might be not yet created). ... Greg Shah
07:52 AM User Interface Feature #1791: implement dynamic UI support: Triggering issue to discuss.
The problem I'm currently work with is related to the triggers identification for dyn... Eugenie Lyzenko
11:32 AM Database Feature #2220: dynamic query methods which require implementation: About off-end after reposition. It may have a quirky state. As far as I've checked the rules are following:
# off-en... Stanislav Lomany

09/25/2014

01:10 PM User Interface Feature #2334: implement the GUI message line widget: Agreed and understood. Greg Shah
12:40 PM User Interface Feature #2334: implement the GUI message line widget: Yes we could do the code more abstract. But first of all I want to have the coordinates fixed.
Fonts are used only o... Marius Gligor
12:30 PM User Interface Feature #2334: implement the GUI message line widget: Code Review 0925a
This is really good! I'm excited that you have achieved the "Hello World" for GUI.
My only c... Greg Shah
11:29 AM User Interface Feature #2334: implement the GUI message line widget: Here are my latest changes. I fixed many problems related to status bar and message area widgets but is still an inte... Marius Gligor
12:51 PM Database Feature #2220: dynamic query methods which require implementation: Test update for adaptive scrolling cache. Mixed with svl_upd20140812a (posted above, reviewed, not committed). Note t... Stanislav Lomany

09/24/2014

05:34 PM User Interface Feature #1791: implement dynamic UI support: > If something is not supported on conversion level(like RADIO-BUTTONS attribute for RADIO-SET widget) I can postpone... Greg Shah
05:13 PM User Interface Feature #1791: implement dynamic UI support: > OK, this all sounds like a reasonable approach. How quickly can you implement the necessary changes?
I guess if... Eugenie Lyzenko
04:41 PM User Interface Feature #1791: implement dynamic UI support: OK, this all sounds like a reasonable approach. How quickly can you implement the necessary changes? Greg Shah
01:11 PM User Interface Feature #1791: implement dynamic UI support: From the testing I did I can tell we certainly need tp change the @ScreenBuffer@ class. To be able to extent the cont... Eugenie Lyzenko
04:46 PM User Interface Feature #2323 (Closed): refactor coordinate system and implement GUI coordinate support: Greg Shah
02:19 PM User Interface Feature #2252: implement GUI client support: Greg Shah wrote:
> I agree. I will close #2323 unless you believe there is something else to do (outside of the add... Hynek Cihlar
10:49 AM User Interface Feature #2252: implement GUI client support: Code Review hc_upd20140924a.zip
Wow! Great work. That is a huge amount of change. Please go ahead and check it ... Greg Shah
10:31 AM User Interface Feature #2252: implement GUI client support: Code Review vig_upd20140924a.zip
The overall approach is correct. Eventually, some of this logic may be moved to ... Greg Shah
10:19 AM User Interface Feature #2252: implement GUI client support: For the #2323 please review the attached file.
- fixed initialization of GUI mode
- fixed AlertBox positioning in... Hynek Cihlar
04:43 AM User Interface Feature #2252: implement GUI client support: Here is the update with multi-window support for message methods. Following methods was moved from @ThinClient@ to @W... Vadim Gindin

09/23/2014

06:13 PM User Interface Feature #2334: implement the GUI message line widget: > 1. The implementation of GUI widgets still depends on coordinate conversion between pixels units and character unit... Greg Shah
06:07 PM User Interface Feature #2334: implement the GUI message line widget: Code Review 0923a
1. In @WindowGuiImpl@ do we need to keep the hard coded message output (e.g. @line 1@...)? Even... Greg Shah
01:33 PM User Interface Feature #2334: implement the GUI message line widget: A first implementation of GUI message area. I implemented a scroll bar widget a scroll pane widget and a scrollable l... Marius Gligor
03:23 PM User Interface Feature #1791: implement dynamic UI support: Eugenie, you can ignore these for now. Your support for dynamic widget creation should be generic enough to be able ... Constantin Asofiei
03:02 PM User Interface Feature #1791: implement dynamic UI support: There is an issues creating something other than fill-in widget. Consider the following code in @DynamicWidgetFactory... Eugenie Lyzenko
01:41 PM User Interface Feature #1791: implement dynamic UI support: How much testing have you done and what are your findings? Greg Shah
11:41 AM User Interface Feature #2252: implement GUI client support: This is the priority order for implementation of multi-window support (please edit this entry over time to mark off w... Greg Shah
09:02 AM Base Language Feature #1628: fix any incompatibilities or missing features of NO-ECHO support: In the redirected terminal output (see @RedirectedTerminal.sync()@), we are not supposed to generate output when:
... Greg Shah

09/22/2014

10:16 AM User Interface Feature #2252: implement GUI client support: Please see the "Source Management" section of the timco.html document for details on how to deal with check-out/check... Greg Shah
09:18 AM User Interface Feature #2252: implement GUI client support: Vadim Gindin wrote:
> These errors correlate with my update not with Eugenys.
I guess your changes affect MAJIC cod... Constantin Asofiei
08:57 AM User Interface Feature #2252: implement GUI client support: These errors correlate with my update not with Eugenys. Vadim Gindin
08:22 AM User Interface Feature #2252: implement GUI client support: Eugenie (EVL) sent a recent update email that notified that there were MAJIC changes to match his recent check-in:
... Greg Shah
08:02 AM User Interface Feature #2252: implement GUI client support: Tried to run regression testing and faced with the problem: majic is not builded because of compile errors:... Vadim Gindin
08:54 AM Base Language Feature #1628: fix any incompatibilities or missing features of NO-ECHO support: I've found problem in calculating border for frame.
Border is calculating correct, but message will appear on the "b... Evgeny Kiselev

09/20/2014

12:14 PM User Interface Feature #2252: implement GUI client support: Greg Shah wrote:
> Would you please add a task documenting the problem? It should be added to the "Harness" project... Hynek Cihlar
08:32 AM User Interface Feature #2252: implement GUI client support: > The mystery resolved! Harness reporting doesn't HTML-escape the HTML outputs, that is the reason the button is not ... Greg Shah
08:30 AM User Interface Feature #2252: implement GUI client support: Code Review vig_upd20140920a.zip
1. @THIS-PROCEDURE:CURRENT-WINDOW@ is not handled via state sync but you previous... Greg Shah
08:04 AM User Interface Feature #2252: implement GUI client support: The mystery resolved! Harness reporting doesn't HTML-escape the HTML outputs, that is the reason the button is not vi... Hynek Cihlar

09/19/2014

04:18 PM User Interface Feature #2252: implement GUI client support: I made corrections. Have a look please. Vadim Gindin
08:08 AM User Interface Feature #2252: implement GUI client support: Code Review vig_upd20140919c.zip
This is moving in the right direction. Greg Shah
08:07 AM User Interface Feature #2252: implement GUI client support: > > Perhaps it should be kept in a context-local static var so it is shared between all @Window@ instances for this c... Greg Shah
05:32 AM User Interface Feature #2252: implement GUI client support: Next update with the latest corrections except StatusStack move from ThinClient. See below.
Greg Shah wrote (note ... Vadim Gindin
02:43 PM User Interface Feature #1791: implement dynamic UI support: > If 1-3 will work fine I think we do not need any special processing for dynamic widgets on the client side. What do... Greg Shah
01:37 PM User Interface Feature #1791: implement dynamic UI support: >One area I wonder about is whether the client-side WidgetRegistry needs to add/remove dynamic widgets differently.
... Eugenie Lyzenko
11:32 AM User Interface Feature #1791: implement dynamic UI support: OK, go ahead and commit/distribute evl_upd20140919a.zip.
> >No, there is no such thing as a NEW GLOBAL SHARED frame.... Greg Shah
11:16 AM User Interface Feature #1791: implement dynamic UI support: >Let me take one last look first.
OK.
>No, there is no such thing as a NEW GLOBAL SHARED frame. You can only cr... Eugenie Lyzenko
11:06 AM User Interface Feature #1791: implement dynamic UI support: Let me take one last look first. Greg Shah
11:05 AM User Interface Feature #1791: implement dynamic UI support: The CTRL-C testing finished without regressions. I had to run 3-way tests in standalone session and they are OK too.
... Eugenie Lyzenko
09:57 AM User Interface Feature #1791: implement dynamic UI support: The only change in this update is removed TODO from @GenericWidget.resourceDelete()@.
Is it OK to commit and distr... Eugenie Lyzenko
06:24 AM User Interface Feature #1791: implement dynamic UI support: >This memory leak already exists in P2J. So we can go forward with your change anyway. But I do want to fix this some... Eugenie Lyzenko
12:30 PM Base Language Bug #2338 (Closed): fix _MSG function: Greg Shah
10:35 AM Base Language Bug #2338: fix _MSG function: committed to revision 10614 Vadim Gindin
09:47 AM Base Language Bug #2338: fix _MSG function: Vadim Gindin wrote:
> The update vig_upd20140917a.zip has passed regression testing. Can I commit it?
Yes, go ahead... Constantin Asofiei
06:04 AM Base Language Bug #2338: fix _MSG function: The update vig_upd20140917a.zip has passed regression testing. Can I commit it? Vadim Gindin
11:56 AM User Interface Bug #2396: memory leak when using shared frames: In #1791 we found that using shared frames results in a memory leak because we never fully remove shared frames from ... Greg Shah
11:28 AM User Interface Bug #2396 (New): memory leak when using shared frames: Greg Shah
10:30 AM Database Bug #2395: db admin rights requirement for the system table query: In @PostgreSQLSequenceHandler.safeContains@ the query on a system table requires DB admin rights. For development and... Ovidiu Maxiniuc
10:01 AM Database Bug #2395 (New): db admin rights requirement for the system table query: Ovidiu Maxiniuc

09/18/2014

05:32 PM User Interface Feature #2252: implement GUI client support: Code Review vig_upd20140919b.zip
This mostly is moving in the right direction.
1. The @statusStack@, @StatusD... Greg Shah
05:17 PM User Interface Feature #2252: implement GUI client support: > 1. Why it is necessary to hold the stack of statuses even for one-window UI?
Because you can have nested WAIT-FO... Greg Shah
04:50 PM User Interface Feature #2252: implement GUI client support: Fixed 2 files (compile errors) Vadim Gindin
02:34 PM User Interface Feature #2252: implement GUI client support: I've made corrections with status stack, but I have some doubts.
1. Why it is necessary to hold the stack of statu... Vadim Gindin
12:16 PM User Interface Feature #2252: implement GUI client support: Details for #2388:
I have created a test suite that explores the behavior of window move/positioning. #2388 is int... Greg Shah
05:01 PM User Interface Feature #1791: implement dynamic UI support: > On the other hand I think the shared frame in 4GL approach has memory leak bomb initially. We never know at this ti... Greg Shah
01:53 PM User Interface Feature #1791: implement dynamic UI support: >1. The changes to LT bring back that memory leak of shared frames, right? I understand it may be needed to defer the... Eugenie Lyzenko
01:30 PM User Interface Feature #1791: implement dynamic UI support: >2. Can the TODO from @GenericWidget.resourceDelete()@ be removed now?
I think we can remove. This is not my TODO ... Eugenie Lyzenko
12:32 PM User Interface Feature #1791: implement dynamic UI support: Code Review 0918a
I only have the following concerns:
1. The changes to LT bring back that memory leak of share... Greg Shah
11:57 AM User Interface Feature #1791: implement dynamic UI support: >Your top priority is getting the new widget ID implementation through regression testing and checked in.
OK.
>Ho... Eugenie Lyzenko
10:43 AM User Interface Feature #1791: implement dynamic UI support: Your top priority is getting the new widget ID implementation through regression testing and checked in.
However, ... Greg Shah
10:41 AM User Interface Feature #1791: implement dynamic UI support: Yes, it must build upon (add to) that code. Greg Shah
10:39 AM User Interface Feature #1791: implement dynamic UI support: >Get this update prepared and uploaded for review ASAP. Please also test it with a variety of dynamic widget cases to... Eugenie Lyzenko
09:46 AM User Interface Feature #1791: implement dynamic UI support: I am fine with the proposed approach. Some thoughts:
1. The use of reflection (to lookup the constructor) needs s... Greg Shah
08:29 AM User Interface Feature #1791: implement dynamic UI support: Now at least two issues/regressions remain:
- one for NullPointerException.
- other with shared variable missing.
... Eugenie Lyzenko
12:49 PM Base Language Feature #1628: fix any incompatibilities or missing features of NO-ECHO support: Evgeny Kiselev wrote:
> Constantin Asofiei wrote:
> > update 0917
> for TerminalStream class you've rollback next ... Constantin Asofiei
09:22 AM Base Language Feature #1628: fix any incompatibilities or missing features of NO-ECHO support: Constantin Asofiei wrote:
> update 0917
for TerminalStream class you've rollback next lines:... Evgeny Kiselev
12:02 PM User Interface Feature #2388: finish GUI window move/position support: This is just for time tracking. Please put all history in the parent task #2252. Greg Shah
12:01 PM User Interface Feature #2388 (Closed): finish GUI window move/position support: Greg Shah

09/17/2014

07:33 PM User Interface Feature #1791: implement dynamic UI support: Code Review 0917a
I am fine with the changes.
Besides the testing, how soon can you make a list of the changes ... Greg Shah
02:58 PM User Interface Feature #1791: implement dynamic UI support: The regression testing has regression. The next update will be tested as fix. What is in the update:
1. Merge with... Eugenie Lyzenko
07:23 PM User Interface Feature #2252: implement GUI client support: > WAIT-FOR always has widget specification. This widget uniquely identify the window it belongs. Assuming we have 2 w... Greg Shah
06:40 PM User Interface Feature #2252: implement GUI client support: Greg Shah wrote:
> I think the more important question is how does the @statusStack@ need to be implemented in a mul... Vadim Gindin
02:05 PM User Interface Feature #2252: implement GUI client support: > I am wondering how is the test runner interacting with the application and whether it may cause a different path of... Greg Shah
01:45 PM User Interface Feature #2252: implement GUI client support: Regarding #2323 please advice with runtime regression results. Several test cases fail with an alert box missing butt... Hynek Cihlar
10:45 AM Base Language Bug #2338: fix _MSG function: Yes, I checked all tests. Here is the final update. Vadim Gindin
09:46 AM Base Language Bug #2338: fix _MSG function: Vadim Gindin wrote:
> This is a final update. Can I run regression testing?
If your standalone tests all pass (incl... Constantin Asofiei
09:45 AM Base Language Bug #2338: fix _MSG function: This is a final update. Can I run regression testing? Vadim Gindin
04:10 AM Base Language Bug #2338: fix _MSG function: Vadim Gindin wrote:
> Added implementation for warnings to ErrorManager methods.
>
> Questions.
> 1. There are 2... Constantin Asofiei
10:35 AM User Interface Feature #2333: implement the GUI status line widget: I am keeping this open only because we still have the drawing differences between Windows and Linux. When the #2323 ... Greg Shah
10:17 AM User Interface Feature #2333 (Review): implement the GUI status line widget: Marius Gligor
10:16 AM User Interface Feature #2333: implement the GUI status line widget: 0916a passed regression tests. Committed revision 10613. Marius Gligor
08:54 AM Base Language Feature #1628: fix any incompatibilities or missing features of NO-ECHO support: > do you think that adding a row at the bottom of the frame (when output to stream) might be something specific to 4G... Greg Shah
08:17 AM Base Language Feature #1628: fix any incompatibilities or missing features of NO-ECHO support: Evgeny, this version is merged with the latest P2J. What else needs to be done:
# test all PUT versions (PUT ... AT/... Constantin Asofiei
07:42 AM Base Language Feature #1628: fix any incompatibilities or missing features of NO-ECHO support: Evgeny Kiselev wrote:
> > 3. The @RedirectedTerminal@ change seems dangerous and incorrect. @box[i]@ will only be t... Constantin Asofiei
07:29 AM User Interface Feature #2334: implement the GUI message line widget: In @OpenEdge@ GUI the message area is a reserved region at the bottom of window above status bar implemented as a scr... Marius Gligor
01:42 AM User Interface Feature #2334 (WIP): implement the GUI message line widget: Marius Gligor

09/16/2014

02:25 PM User Interface Feature #2252: implement GUI client support: > I asked more about popStatus and pushStatus, rather then nesting. Do you mean I should stay these methods in ThinCl... Greg Shah
01:59 PM User Interface Feature #2252: implement GUI client support: I asked more about popStatus and pushStatus, rather then nesting. Do you mean I should stay these methods in ThinClient? Vadim Gindin
01:38 PM User Interface Feature #2252: implement GUI client support: > Recalling, I'm going to move these methods (pop and push) to Window. What window to apply these methods for? May be... Greg Shah
01:15 PM User Interface Feature #2252: implement GUI client support: I have the following question about methods @pushStatus@ and @popStatus@ (ThinClient). They are called from applyChan... Vadim Gindin
10:55 AM User Interface Feature #2252: implement GUI client support: In regard to task #2334 (finish message area support), the following needs to be done:
* create a proper scrollabl... Greg Shah
11:15 AM User Interface Feature #2333: implement the GUI status line widget: OK, the failure is actually on the client side and it is just that our GUI support does not yet handle frames. So wh... Greg Shah
11:12 AM User Interface Feature #2333: implement the GUI status line widget: [09/16/2014 18:11:26 EEST] (StandardServer.invoke:SEVERE) {00000005:00000016:bogus} Abnormal end!
java.lang.reflect.... Marius Gligor
11:10 AM User Interface Feature #2333: implement the GUI status line widget: Please post the full stack trace. Greg Shah
11:09 AM User Interface Feature #2333: implement the GUI status line widget: I found the following error: @Attempt to instantiate classclass com.goldencode.p2j.ui.client.Frame which has no prope... Marius Gligor
11:05 AM User Interface Feature #2333: implement the GUI status line widget: What causes the server-side crash? Greg Shah
11:03 AM User Interface Feature #2333: implement the GUI status line widget: When GUI client starts after authentication the @Ask.p@ is tried to be executed on server side but crash in @Standard... Marius Gligor
10:50 AM User Interface Feature #2333: implement the GUI status line widget: Code Review 0916a
The changes look good. Please go ahead into runtime regression testing.
> In conclusions all... Greg Shah
10:20 AM User Interface Feature #2333: implement the GUI status line widget: 1. Insets could be used by other widgets as well like message area, window title bar.
Even window widgets could ... Marius Gligor

09/15/2014

05:57 PM Base Language Feature #1628: fix any incompatibilities or missing features of NO-ECHO support: Constantin Asofiei wrote:
> Evgeny Kiselev wrote:
> > P2J output with my patch:
> If you are referring to 0910a.zi... Evgeny Kiselev
04:12 PM Base Language Feature #1628: fix any incompatibilities or missing features of NO-ECHO support: Evgeny Kiselev wrote:
> P2J output with my patch:
If you are referring to 0910a.zip, try to break it like this:
<p... Constantin Asofiei
01:06 PM Base Language Feature #1628: fix any incompatibilities or missing features of NO-ECHO support: Constantin Asofiei wrote:
> # about MESSAGE (and maybe other statements, like DISPLAY) when output is not the termin... Evgeny Kiselev
04:39 AM Base Language Feature #1628: fix any incompatibilities or missing features of NO-ECHO support: Constantin Asofiei wrote:
> # about the box issue:
> - is this a regression from your update or a bug you found?
>... Evgeny Kiselev
04:20 PM User Interface Feature #2252: implement GUI client support: > I'm just recalling that the client-side implementation is not finished yet. Status line does not display a value.
... Greg Shah
03:35 PM User Interface Feature #2252: implement GUI client support: Greg Shah wrote:
>..
> Is there anything else that remains to be done to finish multi-window status support?
I'm... Vadim Gindin
11:38 AM User Interface Feature #2252: implement GUI client support: Code Review vig_upd20140912a.zip
In general, the changes are really good. I do want to make some slight changes t... Greg Shah
10:01 AM User Interface Feature #2252: implement GUI client support: > Considering that if i.e. char metrics are set, the pixel metrics automatically change, I'm inclined to let the clie... Greg Shah
03:17 PM User Interface Feature #2333: implement the GUI status line widget: Code Review 0915a
The changes look very good.
1. Are the @GuiOptions@ insets only useful for the status line? ... Greg Shah
11:47 AM User Interface Feature #2333: implement the GUI status line widget: Here are the changes which I did so far. Some of the changes like color inheritance could be applied to other widget... Marius Gligor
02:42 PM User Interface Feature #1791: implement dynamic UI support: OK, we will keep going with the current plan. Hopefully it will pass testing and get checked in tomorrow. Greg Shah
02:34 PM User Interface Feature #1791: implement dynamic UI support: Greg Shah wrote:
> This update just puts the new ID infrastructure into place. It doesn't solve any of the other dy... Constantin Asofiei
02:31 PM User Interface Feature #1791: implement dynamic UI support: > My goal is to separate the widget's config (and in the end the runtime state) from its concrete implementation, so... Greg Shah
01:49 PM User Interface Feature #1791: implement dynamic UI support: On a side note, do you now how much work is left on this task? I want to integrate this with my changes. Constantin Asofiei
01:33 PM User Interface Feature #1791: implement dynamic UI support: Greg Shah wrote:
> How many of these cases can act like "real" widgets? In other words, many of these are not treat... Constantin Asofiei
12:57 PM User Interface Feature #1791: implement dynamic UI support: How many of these cases can act like "real" widgets? In other words, many of these are not treated as widgets by the... Greg Shah
11:49 AM User Interface Feature #1791: implement dynamic UI support: Greg Shah wrote:
> > there are some widgets created on client-side which don't have a server-side counterpart
>
>... Constantin Asofiei
11:43 AM User Interface Feature #1791: implement dynamic UI support: > there are some widgets created on client-side which don't have a server-side counterpart
Please provide more det... Greg Shah
10:11 AM User Interface Feature #1791: implement dynamic UI support: Greg/Eugenie: there are some widgets created on client-side which don't have a server-side counterpart. Looking at t... Constantin Asofiei
08:19 AM Base Language Bug #2338: fix _MSG function: Added implementation for warnings to ErrorManager methods.
Questions.
1. There are 2 methods @ErrorManager.isSile... Vadim Gindin

09/13/2014

02:52 PM Database Bug #2222 (WIP): WRITE event triggered too early: Eric Faulhaber

09/12/2014

04:34 PM User Interface Feature #2252: implement GUI client support: Constantin Asofiei wrote:
> Vadim Gindin wrote:
> >I'm sure about all of them except "statusStack". Could you pleas... Vadim Gindin
03:56 PM User Interface Feature #2252: implement GUI client support: Hynek Cihlar wrote:
> // At the moment it is unknown to me whether the coordinate conversion and
> ... Constantin Asofiei
03:20 PM User Interface Feature #2252: implement GUI client support: Greg Shah wrote:
> > Should the flag be then somehow cached? The most logical place should probably be the widget in... Hynek Cihlar
01:58 PM User Interface Feature #2252: implement GUI client support: Greg Shah wrote:
> The only issue with this is that every call takes a trip down to the client to call @OutputManage... Constantin Asofiei
01:54 PM User Interface Feature #2252: implement GUI client support: > (1) In the change set in the file Coordinate.java - // TODO: #2323 implement GUI coordinate rounding.
> GUI roundi... Greg Shah
01:22 PM User Interface Feature #2252: implement GUI client support: Code Review 0911a
The changes look good. Greg Shah
12:45 PM User Interface Feature #2252: implement GUI client support: I am attaching update to the work in progress of #2323. The change set resolves comments from review, resolves resolv... Hynek Cihlar
04:36 AM User Interface Feature #2252: implement GUI client support: Vadim Gindin wrote:
>I'm sure about all of them except "statusStack". Could you please describe its function and may... Constantin Asofiei
04:08 PM Database Bug #2387: improve compatibility of NO-UNDO temp-tables: The validation of no-undo temp-tables in P2J does not quite match the behavior in Progress. See testcases @uast/flush... Eric Faulhaber
04:03 PM Database Bug #2387 (New): improve compatibility of NO-UNDO temp-tables: Eric Faulhaber
02:04 PM Database Bug #2222: WRITE event triggered too early: Attached update has passed regression testing and is checked into bzr revs. 10609 (all changed/new files) and 10610 (... Eric Faulhaber
12:54 PM Base Language Feature #2385 (Closed): implement environment access on GUI interfaces.: Greg Shah
10:54 AM Base Language Feature #2385: implement environment access on GUI interfaces.: 0911c passed regression tests. Committed revision 10608. Marius Gligor
12:26 PM Database Bug #2382: Improve format string error handling in ADD-NEW-FIELD implementation: Attached draft intermediate update vmn_upd20140912a.zip with some fixes based on previous local changes. Vadim Nebogatov

09/11/2014

07:02 PM User Interface Feature #2252: implement GUI client support: I'm working on status methods implementation. I'm going to move some fields from ThinClient to Window (or TitledWindo... Vadim Gindin
12:13 AM User Interface Feature #2252: implement GUI client support: Committed to revision 10606. Vadim Gindin
02:07 PM Base Language Feature #1628: fix any incompatibilities or missing features of NO-ECHO support: Evgeny Kiselev wrote:
> testcases:
> uast/no_echo/put_unformatted_bug.p
> uast/no_echo/put_unformtted_bug1.p
# pl... Constantin Asofiei
12:16 PM Base Language Feature #1628: fix any incompatibilities or missing features of NO-ECHO support: committed testcases into testcases/uast/no_echo
revision 1199.
testcases:
uast/no_echo/put_unformatted_bug.p
ua... Evgeny Kiselev
07:23 AM Base Language Feature #1628: fix any incompatibilities or missing features of NO-ECHO support: Evgeny Kiselev wrote:
> > What standalone testcases have you run to confirm your changes are correct?
I think Greg... Constantin Asofiei
01:58 PM Base Language Feature #2385: implement environment access on GUI interfaces.: Code Review 0911c
The changes look good. Please get these runtime regression tested. Greg Shah
01:39 PM Base Language Feature #2385: implement environment access on GUI interfaces.: OK. I understood thanks. Marius Gligor
01:37 PM Base Language Feature #2385: implement environment access on GUI interfaces.: In other words, when you call @DirectoryManager.getInstance()@ on the client, you will get a remote proxy to a server... Greg Shah
01:36 PM Base Language Feature #2385: implement environment access on GUI interfaces.: The @DirectoryServer@ class (which backs the @DirectoryManager.getInstance()@ on the server side) uses @Utils.getDire... Greg Shah
01:34 PM Base Language Feature #2385: implement environment access on GUI interfaces.: Marius Gligor wrote:
> Yes you are right it works in @/server/default/runtime/default/@
> But on note 12 you said:... Constantin Asofiei
01:33 PM Base Language Feature #2385: implement environment access on GUI interfaces.: done. Marius Gligor
01:30 PM Base Language Feature #2385: implement environment access on GUI interfaces.: Yes you are right it works in @/server/default/runtime/default/@
But on note 12 you said: @The lookup should allow ... Marius Gligor
01:24 PM Base Language Feature #2385: implement environment access on GUI interfaces.: I think you need to have it located in @/server/default/runtime/default/@ instead of @/server/default/@. Greg Shah
01:21 PM Base Language Feature #2385: implement environment access on GUI interfaces.: It works only for DirScope.ACCOUNTS Marius Gligor
01:17 PM Base Language Feature #2385: implement environment access on GUI interfaces.: I tried to use @DirectoryManager.getInstance()@ but it doesn't work.
I'm using the following code:... Marius Gligor
12:41 PM Base Language Feature #2385: implement environment access on GUI interfaces.: Code Review 0911b
Instead of adding a @ServerExports@ method to access the read-only flag, please use the @Directo... Greg Shah
11:35 AM Base Language Feature #2385: implement environment access on GUI interfaces.: Fixed 0911a code review. The read only flag is global and read from server node @readOnlyEnvironments@ which should h... Marius Gligor
10:49 AM Base Language Feature #2385: implement environment access on GUI interfaces.: Code Review 0911a
The changes are very good.
> a) The read only flag which change the loading rule from client ... Greg Shah
09:51 AM Base Language Feature #2385 (Review): implement environment access on GUI interfaces.: Marius Gligor
09:26 AM Base Language Feature #2385: implement environment access on GUI interfaces.: 1. I fixed code review issues from 0910a.
2. I integrated the changes from task #2366 related to override default ... Marius Gligor
09:26 AM User Interface Feature #2333 (WIP): implement the GUI status line widget: Marius Gligor

09/10/2014

07:08 PM Base Language Feature #1628: fix any incompatibilities or missing features of NO-ECHO support: Greg Shah wrote:
> What is the status of your regression testing?
I've just started regression testing with latest ... Evgeny Kiselev
07:04 PM Base Language Feature #1628: fix any incompatibilities or missing features of NO-ECHO support: Greg Shah wrote:
> Code Review 0910a
>
> I am worried that your changes are just there to fix some very specific ... Evgeny Kiselev
03:06 PM Base Language Feature #1628: fix any incompatibilities or missing features of NO-ECHO support: What is the status of your regression testing?
What standalone testcases have you run to confirm your changes are ... Greg Shah
03:01 PM Base Language Feature #1628: fix any incompatibilities or missing features of NO-ECHO support: Code Review 0910a
I am worried that your changes are just there to fix some very specific behavior in a few testca... Greg Shah
07:44 AM Base Language Feature #1628: fix any incompatibilities or missing features of NO-ECHO support: I've added addition comments in code. There is next algorithm.
1) first output is @put unformatted@ (in my case this... Evgeny Kiselev
05:31 PM User Interface Feature #2252: implement GUI client support: Code Review 0905a
I am fine with the changes.
> But there was an exception. See error log (client_vig_26776.log... Greg Shah
05:01 PM User Interface Feature #2252: implement GUI client support: I was running regression testing several times. Made some fix. Here is the latest update. It passes regression testin... Vadim Gindin
12:26 PM User Interface Feature #2252: implement GUI client support: In regard to task #2333 (finish status area support), the following needs to be done:
* proper font/color usage
*... Greg Shah
05:20 PM Base Language Feature #2385: implement environment access on GUI interfaces.: Code Review 0910a
1. Doesn't @StanzaIni@ always get used on the client side? If so, then the jar file reading is ... Greg Shah
11:09 AM Base Language Feature #2385: implement environment access on GUI interfaces.: Here are my changes that I did so far on this task. Please do a code review on these changes and let me know the resu... Marius Gligor

09/09/2014

04:23 PM Base Language Bug #2338: fix _MSG function: Vadim Gindin wrote:
> I ran your test and in both cases (with or without NO-ERROR) it behaved in the same way. _MSG(... Constantin Asofiei
04:07 PM Base Language Bug #2338: fix _MSG function: I ran your test and in both cases (with or without NO-ERROR) it behaved in the same way. _MSG(1) = 74. The error bein... Vadim Gindin
01:21 PM Base Language Bug #2338: fix _MSG function: > > 1. With NO-ERROR the error number wasn't recorded to _MSG array. That is little unexpected.
> Please correct me,... Vadim Gindin
01:02 PM Base Language Bug #2338: fix _MSG function: Vadim Gindin wrote:
> I'm not sure, that I understood correctly. I expected that 0 is the default value that exists ... Constantin Asofiei
12:49 PM Base Language Bug #2338: fix _MSG function: Constantin Asofiei wrote:
> I think it shows that:
> # if a @NO-ERROR@ is added to @DELETE book@, then the ERROR-ST... Vadim Gindin
06:57 AM Base Language Bug #2338: fix _MSG function: Vadim Gindin wrote:
> 2a. format constraint 1-digit number.
> While trying to validate number 10 there are an er... Constantin Asofiei
01:29 PM Database Feature #2273: address remaining limitations of SQL Server needed to support legacy 4GL behavior: The update passed the regression test and was committed to bzr (rev 10599) and distributed by mail on 14 aug 2014. Ovidiu Maxiniuc

09/08/2014

05:07 PM Database Bug #2222: WRITE event triggered too early: Eric,
I reviewed closely your last update. Changes make sense. I did not find any issues except for a few javadoc ... Ovidiu Maxiniuc
02:09 PM Base Language Bug #2338: fix _MSG function: > 1a. size(memptr) < size(file). For exapmle size(memptr) = 5 and size(file) = 23.
> Progress reads all file and dyn... Greg Shah
02:07 PM Base Language Bug #2386: STRING(memptr_var) will render the contents of the memptr as a null terminated string: See uast/memptr/memptr_to_string.p.
In the 4GL, the contents seem to be read from index 1 (1-based indexing) and i... Greg Shah
02:03 PM Base Language Bug #2386 (New): STRING(memptr_var) will render the contents of the memptr as a null terminated s...: Greg Shah
12:55 PM User Interface Feature #2252: implement GUI client support: > 1. In many places in this update, you are moving back to @int@ from @double@. A good example is @src/com/goldencod... Hynek Cihlar
10:34 AM User Interface Feature #2252: implement GUI client support: Code Review hc_upd20140907a.zip
I like the new @Coordinate@ helper class. Use of it makes clear to the reader tha... Greg Shah

09/07/2014

04:31 PM User Interface Feature #2252: implement GUI client support: Attached is the update of hc_upd20140831a. It resolves the issues from review at notes 184 and 188.
The most impo... Hynek Cihlar
02:50 PM Base Language Bug #2338: fix _MSG function: I forgot to add for the case №1 "Stream", that STRING(memptr) in Progress successfully outputs string representation ... Vadim Gindin
02:45 PM Base Language Bug #2338: fix _MSG function: I tried to test these mysterious cases. It is not easy. Here are some findings.
1. @Stream.readBlock()@ method, th... Vadim Gindin

09/06/2014

09:59 PM Database Bug #2222: WRITE event triggered too early: Ovidiu Maxiniuc wrote:
> I have not finished yet reviewing your update 20140903a, only a side-by-side compare with c... Eric Faulhaber

09/05/2014

06:19 PM Database Bug #2222: WRITE event triggered too early: I have not finished yet reviewing your update 20140903a, only a side-by-side compare with current bzr. At first impre... Ovidiu Maxiniuc
12:06 AM Database Bug #2222: WRITE event triggered too early: Ovidiu, would you please review the attached update? It goes way beyond the write trigger fix to deal with the incorr... Eric Faulhaber
02:06 PM Base Language Feature #27: implement a compatible ENCODE built-in function: Here is the Progress 4GL compatible @ENCODE@ algorithm specification.
+Summary+
The function takes a source byt... Greg Shah
11:05 AM Base Language Feature #2385: implement environment access on GUI interfaces.: I agree with your thoughts. If this read-only approach is still going to take a significant amount of time/changes, ... Greg Shah
10:56 AM Base Language Feature #2385: implement environment access on GUI interfaces.: Indeed the big problem with @INI@ files on @P2J@ is the deployment location. Reading or writing @INI@ files on server... Marius Gligor
10:06 AM Base Language Feature #2385: implement environment access on GUI interfaces.: Interesting findings.
> Since we are looking to use INI files in both Linux OS and Windows OS the name of the INI ... Greg Shah
09:36 AM Base Language Feature #2385: implement environment access on GUI interfaces.: I did some tests using @LOAD@ @USE@ and @UNLOAD@ statements to manage user environment on both @OE@ and @P2J@.
Curre... Marius Gligor
08:56 AM User Interface Feature #1791: implement dynamic UI support: > Sorry, that I'm meddling.
You are not meddling. You are CONTRIBUTING. Your questions help us make this project... Greg Shah
08:24 AM User Interface Feature #1791: implement dynamic UI support: Code Review 0904a
I'm fine with the changes. Greg Shah
04:48 AM User Interface Feature #1791: implement dynamic UI support: Sorry, that I'm meddling. Why your updates does not change @handle.getResourceId@ static method (and corresponding @R... Vadim Gindin

09/04/2014

07:49 PM User Interface Feature #1791: implement dynamic UI support: The today update for review includes:
1. Merge with the recent code base.
2. Fix for shared frame importing @Screen... Eugenie Lyzenko
10:31 AM User Interface Feature #2286 (Closed): design and implement basic GUI window widget support: Greg Shah
10:16 AM User Interface Feature #1793 (Closed): improve color support: Greg Shah
10:08 AM User Interface Feature #1793: improve color support: 0904c Passed conversion and regression tests. Committed revision 10605. Marius Gligor
09:46 AM User Interface Feature #1793: improve color support: Code Review 0904c
It is good. Go ahead and check it in/distribute it. Greg Shah
09:31 AM User Interface Feature #1793: improve color support: Done. Marius Gligor
09:03 AM User Interface Feature #1793: improve color support: Code Review 0904b
I am OK with the changes and I do think they are safe enough to avoid further testing.
I have... Greg Shah
08:03 AM User Interface Feature #1793: improve color support: A minor change to log a message whenever colors cannot be mapped and are mapped by default to a 0 RGB value. Marius Gligor
07:44 AM User Interface Feature #1793: improve color support: The changes in 0903b passed both conversion and regression tests. However I didn't do the commits and distributions y... Marius Gligor
04:02 AM Base Language Feature #2385: implement environment access on GUI interfaces.: Ovidiu,
So far I did no changes on current implementation for Windows environment access.
I only added getLegac... Marius Gligor
03:05 AM Base Language Feature #2385 (WIP): implement environment access on GUI interfaces.: Current implementation for @COLOR-TABLE@ and @FONT-TABLE@ statements load the default environment from server directo... Marius Gligor
02:47 AM Base Language Feature #2385: implement environment access on GUI interfaces.: GUI clients are using environment statements LOAD USE and UNLOAD to load colors, fonts and potentially other resource... Marius Gligor
02:06 AM Base Language Feature #2385 (Closed): implement environment access on GUI interfaces.: Marius Gligor

09/03/2014

07:26 PM User Interface Feature #1791: implement dynamic UI support: >My only question is whether the @ScreenBuffer(int frameId, int numWidgets)@ constructor is ever safe to use in the n... Eugenie Lyzenko
07:22 PM User Interface Feature #1791: implement dynamic UI support: Status update.
The next regression I've faced is in PO adding screen. This is the serious issue with shared frames... Eugenie Lyzenko
09:05 AM User Interface Feature #1791: implement dynamic UI support: Code Review 0901b
The changes look good and they do look more correct.
My only question is whether the @ScreenB... Greg Shah
04:54 PM User Interface Feature #2252: implement GUI client support: Greg Shah wrote:
> Code Review vig_upd20140901a.zip
>
> I am generally fine with this as an interim update.
>
... Vadim Gindin
09:15 AM User Interface Feature #2252: implement GUI client support: > 1. Place a standardized marker in a comment, which can be searched on to find all these places again. Something li... Hynek Cihlar
08:58 AM User Interface Feature #2252: implement GUI client support: Hynek Cihlar wrote:
> Greg Shah wrote:
> > Code Review hc_upd20140831a
> >
> > Wow, that is a lot of work! It to... Greg Shah
08:53 AM User Interface Feature #2252: implement GUI client support: > It shows window button on the task bar but does not show the window itself. Testcase window_parenting/pause.p. Bod... Greg Shah
08:48 AM User Interface Feature #2252: implement GUI client support: Code Review vig_upd20140901a.zip
I am generally fine with this as an interim update.
1. Can we make the window ... Greg Shah
03:37 PM Base Language Bug #2367 (Closed): re-connecting an appserver agent after a hard client termination: Greg Shah
06:47 AM Base Language Bug #2367: re-connecting an appserver agent after a hard client termination: Greg Shah wrote:
> Code Review 0902a
>
> The changes look good.
Committed to rev 10604. Constantin Asofiei
01:14 PM Base Language Feature #27: implement a compatible ENCODE built-in function: New/updated articles have been found:
http://programmers.stackexchange.com/questions/206645/how-can-i-reverse-engi... Greg Shah
12:59 PM Base Language Feature #27: implement a compatible ENCODE built-in function: The following link (see attached for the actual text file that is linked) is a really useful primer on the theory beh... Greg Shah
12:12 PM User Interface Feature #1793: improve color support: > I have no other works to do on this task.
OK, please get this regression tested (both conversion and runtime).
... Greg Shah
11:58 AM User Interface Feature #1793: improve color support: I have no other works to do on this task.
Nevertheless they are other issues to implements like LOAD, USE, UNLOAD, ... Marius Gligor
11:49 AM User Interface Feature #1793: improve color support: Code Review 0903b
The changes look good. I like the more general approach to reading color tables from the server... Greg Shah
11:00 AM User Interface Feature #1793: improve color support: I fixed the issues reported on Code Review 0903a (note 39) Marius Gligor
10:04 AM User Interface Feature #1793: improve color support: Code Review 0903a
The changes look good.
1. WindowConfig is missing a history entry.
2. The call from the cl... Greg Shah
06:01 AM User Interface Feature #1793: improve color support: I did some changes inside @ColorTable@ class to load colors on a per user manner.
I've fixed also some javadoc texts. Marius Gligor
12:07 PM User Interface Feature #2384: implement custom color overrides for ChUI: This task is meant to allow the configuration of custom colors for ChUI as is possible in the 4GL using the protermca... Greg Shah
12:05 PM User Interface Feature #2384 (New): implement custom color overrides for ChUI: Greg Shah

« Previous

Also available in: Atom

Project

General

Profile

FWD

Activity

Activity

10/02/2014

10/01/2014

09/30/2014

09/29/2014

09/28/2014

09/27/2014

09/26/2014

09/25/2014

09/24/2014

09/23/2014

09/22/2014

09/20/2014

09/19/2014

09/18/2014

09/17/2014

09/16/2014

09/15/2014

09/13/2014

09/12/2014

09/11/2014

09/10/2014

09/09/2014

09/08/2014

09/07/2014

09/06/2014

09/05/2014

09/04/2014

09/03/2014