Project

General

Profile

Activity

From 09/26/2014 to 10/25/2014

10/26/2014

10:40 PM Database Feature #2220 (Closed): dynamic query methods which require implementation
Eric Faulhaber

10/24/2014

06:25 PM User Interface Feature #2252: implement GUI client support
Constantin Asofiei wrote:
..
> * please replace all @-1@ in method calls where is set as windowID, with a WindowCon...
Vadim Gindin
12:48 PM User Interface Feature #2252: implement GUI client support
Constantin Asofiei wrote:
> Marius, one more thing: see the testcases/uast/window_events/mouseevts.p file. This wil...
Marius Gligor
11:14 AM User Interface Feature #2252: implement GUI client support
Code Review hc_upd20141024a.zip
It looks good.
Greg Shah
11:06 AM User Interface Feature #2252: implement GUI client support
Greg Shah wrote:
> Code Review hc_upd20141023b.zip
>
> 1. @CaptionButton@ doesn't have any changes except your hi...
Hynek Cihlar
09:40 AM User Interface Feature #2252: implement GUI client support
Marius, one more thing: see the testcases/uast/window_events/mouseevts.p file. This will show a message each time a ... Constantin Asofiei
09:29 AM User Interface Feature #2252: implement GUI client support
Marius, another thought: I think @findMouseSource@, when called for a ScrollableContainer (maybe ViewPort too?) needs... Constantin Asofiei
09:22 AM User Interface Feature #2252: implement GUI client support
I will remove the @FontManager@ changes from my changes. Marius Gligor
09:18 AM User Interface Feature #2252: implement GUI client support
Greg Shah wrote:
> Code Review hc_upd20141023b.zip
>
> 1. @CaptionButton@ doesn't have any changes except your hi...
Hynek Cihlar
09:08 AM User Interface Feature #2252: implement GUI client support
Marius, first, some issues with the update:
# the window popup menu (right click on the window title bar) is broken ...
Constantin Asofiei
09:04 AM User Interface Feature #2252: implement GUI client support
Code Review mag_upd20141024a.zip
1. Shouldn't @ui/chui/FrameImpl.java@ be removed from the update?
2. @MouseHan...
Greg Shah
08:40 AM User Interface Feature #2252: implement GUI client support
Code Review hc_upd20141023b.zip
1. @CaptionButton@ doesn't have any changes except your history entry.
2. @Popu...
Greg Shah
08:04 AM User Interface Feature #2252: implement GUI client support
Here are my new changes merged with latest repository updates.

1. GUI frames have a scrollable container having s...
Marius Gligor
08:03 AM User Interface Feature #2252: implement GUI client support
Vadim Gindin wrote:
> Next update.
Vadim, for 1024a.zip update; I think this should be the final iteration of revie...
Constantin Asofiei
05:03 PM User Interface Feature #1791: implement dynamic UI support
Code Review 1024a
The code looks good. Although this should have very little risk, please still put it through run...
Greg Shah
03:31 PM User Interface Feature #1791: implement dynamic UI support
Eugenie Lyzenko wrote:
> Unfortunately I have found one bug that is common to static and dynamic frames. If static o...
Constantin Asofiei
03:29 PM User Interface Feature #1791: implement dynamic UI support
This is the first drop for your review of the next step in dynamic widget implementation.
Unfortunately I have fou...
Eugenie Lyzenko

10/23/2014

06:05 PM User Interface Feature #2412 (WIP): Implement widget browser
Hynek Cihlar
06:00 PM User Interface Feature #2388 (WIP): finish GUI window move/position support
Hynek Cihlar
05:56 PM User Interface Feature #2252: implement GUI client support
Related to #2388.
The attached change set updates hc_upd20141021b and in addition contains:
- all changes relat...
Hynek Cihlar
02:22 PM User Interface Feature #2252: implement GUI client support
Next update.
Constantin Asofiei wrote:
> Vadim, review for your 22a.zip:
> * LogicalTerminal: you have this on l...
Vadim Gindin
11:52 AM User Interface Feature #2252: implement GUI client support
Code Review mag_upd20141023a.zip
It looks really good. The only issue I see is that the @ui/chui/FrameImpl.java@ ...
Greg Shah
11:51 AM User Interface Feature #2252: implement GUI client support
Greg Shah wrote:
> Code Review ca_upd20141023a.zip
>
> I am fine with these changes. Please check them in.
Comm...
Constantin Asofiei
11:39 AM User Interface Feature #2252: implement GUI client support
Code Review ca_upd20141023a.zip
I am fine with these changes. Please check them in.
Greg Shah
09:11 AM User Interface Feature #2252: implement GUI client support
Here are my latest changed for GUI empty frame implementation. Marius Gligor
08:04 AM User Interface Feature #2252: implement GUI client support
Vadim, review for your 22a.zip:
* LogicalTerminal: you have this on line 614 @import sun.reflect.generics.visitor.*;...
Constantin Asofiei
07:28 AM User Interface Feature #2252: implement GUI client support
This is replacement of 1021c.zip, for #2340. It passed runtime testing (cumulative) and it addresses the issues in no... Constantin Asofiei
04:15 PM User Interface Feature #2423: add proper key-to-event mappings in GUI
Interesting findings. This is just one more place where Progress didn't spend the effort to make the platforms appea... Greg Shah
01:30 PM User Interface Feature #2423: add proper key-to-event mappings in GUI
After running key_code_report.p (for keys 0 to 2048), the key labels/functions for ChUI in linux and windows are diff... Constantin Asofiei
12:05 PM User Interface Bug #2427: do not allow ALT+space to show the popup menu for the OS window
See notes 395, 396, 397 in #2252 - we need a way to disable the popup menu associated with the OS window, when ALT+Sp... Constantin Asofiei
12:01 PM User Interface Bug #2427 (New): do not allow ALT+space to show the popup menu for the OS window
Constantin Asofiei
12:00 PM User Interface Feature #2340 (Closed): implement the window title bar
Greg Shah
09:12 AM User Interface Feature #2416 (Review): implement frame widget support for GUI
Marius Gligor
09:11 AM User Interface Feature #2425 (WIP): implement GUI rectangle widget
Marius Gligor

10/22/2014

05:14 PM Database Bug #2426: converted unique indexes containing text data disallow records which differ only by ri...
Solving this is a bit tricky. The indexes are defined as they are in P2J to allow the database's query planner to sel... Eric Faulhaber
04:54 PM Database Bug #2426: converted unique indexes containing text data disallow records which differ only by ri...
Data import is failing for certain records, complaining of unique constraint violations, when the indexed data appear... Eric Faulhaber
04:39 PM Database Bug #2426 (Hold): converted unique indexes containing text data disallow records which differ onl...
Eric Faulhaber
04:50 PM User Interface Feature #2252: implement GUI client support
Marius Gligor wrote:
> I checked. @FontManager@ use the same font but seems to be a bug in @FontManager@ :
> @getPi...
Hynek Cihlar
01:38 PM User Interface Feature #2252: implement GUI client support
Details for #2425:
Please implement the rectangle widget on GUI in a way that is compatible with how the 4GL draws...
Greg Shah
01:12 PM User Interface Feature #2252: implement GUI client support
I checked. @FontManager@ use the same font but seems to be a bug in @FontManager@ :
@getPixelsPerRow@ should return ...
Marius Gligor
12:58 PM User Interface Feature #2252: implement GUI client support
I forgot an update itself Vadim Gindin
12:57 PM User Interface Feature #2252: implement GUI client support
Constantin,
I've made all corrections corresponding to your remarks. All of them was addressed (including the note...
Vadim Gindin
12:45 PM User Interface Feature #2252: implement GUI client support
Greg Shah wrote:
> Code Review hc_upd20141021b.zip
>
> 1. Why is there a dependency on @GuiOutputManager@ in @Fra...
Hynek Cihlar
12:39 PM User Interface Feature #2252: implement GUI client support
OK. I'll check. Thanks! Marius Gligor
12:38 PM User Interface Feature #2252: implement GUI client support
Marius Gligor wrote:
> @screen().coordinates().rowFromNative(11)@ @gives 1.0@
The @rowFromNative@ will end up usi...
Hynek Cihlar
12:26 PM User Interface Feature #2252: implement GUI client support
Hynek Cihlar wrote:
> How did you convert the 14 pixels to characters?
>
> Marius Gligor wrote:
> > I have a qu...
Marius Gligor
12:23 PM User Interface Feature #2252: implement GUI client support
Code Review hc_upd20141021b.zip
This is really good. It cleans up many lingering issues, so I am excited to see i...
Greg Shah
12:20 PM User Interface Feature #2252: implement GUI client support
@screen().coordinates().rowFromNative(14)@ Marius Gligor
12:18 PM User Interface Feature #2252: implement GUI client support
How did you convert the 14 pixels to characters?
Marius Gligor wrote:
> I have a question regarding screen coord...
Hynek Cihlar
12:14 PM User Interface Feature #2252: implement GUI client support
I have a question regarding screen coordinates. @OpenEdge@ use rows and columns for screen coordinates in character u... Marius Gligor
09:22 AM User Interface Feature #2252: implement GUI client support
Constantin Asofiei wrote:
> Vadim Gindin wrote:
> > Constantin Asofiei wrote:
> > ..
> > > # @getScreenDimension@...
Vadim Gindin
09:19 AM User Interface Feature #2252: implement GUI client support
Another note for #2424:
The window widget only becomes scrollable when the virtual size is greater than the maximu...
Greg Shah
08:44 AM User Interface Feature #2252: implement GUI client support
Vadim Gindin wrote:
> Constantin Asofiei wrote:
> ..
> > # @getScreenDimension@ usage instead of @TC.getScreenSize...
Constantin Asofiei
08:42 AM User Interface Feature #2252: implement GUI client support
Constantin Asofiei wrote:
..
> # @getScreenDimension@ usage instead of @TC.getScreenSize@ - should have caught this...
Vadim Gindin
02:00 PM User Interface Feature #2423: add proper key-to-event mappings in GUI
If I recall correctly, I started with a deep review of the 4GL docs and our current ChUI/NCURSES source code. I thin... Greg Shah
11:36 AM User Interface Feature #2423: add proper key-to-event mappings in GUI
Greg, for this task, beside adding the key functions in Keyboard$WorkArea, the SwingKeyboardReader needs to be split ... Constantin Asofiei
07:24 AM User Interface Feature #2423 (WIP): add proper key-to-event mappings in GUI
Constantin Asofiei
01:32 PM User Interface Feature #2425: implement GUI rectangle widget
This is for time tracking only. Please place all history in parent task #2252. Greg Shah
01:31 PM User Interface Feature #2425 (Closed): implement GUI rectangle widget
Greg Shah
07:31 AM User Interface Feature #2340 (Review): implement the window title bar
Constantin Asofiei
02:39 AM Database Feature #2220 (Review): dynamic query methods which require implementation
Committed to bzr revision 10633. Stanislav Lomany

10/21/2014

06:53 PM User Interface Feature #2252: implement GUI client support
Sorry, I forgot to mention that hc_upd20141021b.zip deletes:
src/com/goldencode/p2j/ui/ChuiCoordinatesConversion.j...
Hynek Cihlar
06:44 PM User Interface Feature #2252: implement GUI client support
Attached is the implementation of #2388 - finish GUI window move/position support.
Also note that:
- I refactored...
Hynek Cihlar
06:19 PM User Interface Feature #2252: implement GUI client support
Details on #2424:
Please start by extending the @testcases/uast/window_sizing/@ testcases to explore the window si...
Greg Shah
05:31 PM User Interface Feature #2252: implement GUI client support
Code Review ca_upd20141021c.zip
The changes look good.
Greg Shah
05:28 PM User Interface Feature #2252: implement GUI client support
> create separate sub-classes for each case, i.e. WindowEvent and PortableMouseEvent.
This is probably best.
> ...
Greg Shah
05:17 PM User Interface Feature #2252: implement GUI client support
Code Review mag_upd20141021a.zip
The results look very good.
1. @FrameGuiImpl.initialize()@ needs javadoc.
2...
Greg Shah
04:50 PM User Interface Feature #2252: implement GUI client support
Greg Shah wrote:
> 1. @LegacyOSEvents@ seems to map to the Progress 4GL "Portable Mouse Events" (e.g. MOUSE-SELECT-D...
Constantin Asofiei
04:26 PM User Interface Feature #2252: implement GUI client support
Code Review ca_upd20141021b.zip
The update is very good.
1. @LegacyOSEvents@ seems to map to the Progress 4GL "...
Greg Shah
04:25 PM User Interface Feature #2252: implement GUI client support
> Do you think is possible to intercept this in some native code (just to disable the popup menu) and after that re-... Greg Shah
02:09 PM User Interface Feature #2252: implement GUI client support
Greg Shah wrote:
> In regard to the ALT+Space issue, I wonder if something like this will help:
I've tested it on win...
Constantin Asofiei
01:50 PM User Interface Feature #2252: implement GUI client support
In regard to the ALT+Space issue, I wonder if something like this will help:... Greg Shah
01:40 PM User Interface Feature #2252: implement GUI client support
Greg Shah wrote:
> > I was looking for a way of "pluging-in" a certain image type into the JVM, without having to ma...
Constantin Asofiei
12:52 PM User Interface Feature #2252: implement GUI client support
> I think we should treat this in a separate task - we might need a way to make the Keyboard mappings configurable de... Greg Shah
12:52 PM User Interface Feature #2252: implement GUI client support
> I was looking for a way of "pluging-in" a certain image type into the JVM, without having to manually handle i.e. I... Greg Shah
12:40 PM User Interface Feature #2252: implement GUI client support
Greg Shah wrote:
> > I don't understand how is GUI mode special, so that it needs to treat the keyboard differently...
Constantin Asofiei
12:01 PM User Interface Feature #2252: implement GUI client support
Greg Shah wrote:
> In regard to the ALT-F4 problem, isn't this due to the @setDefaultCloseOperation(JFrame.EXIT_ON_C...
Constantin Asofiei
11:50 AM User Interface Feature #2252: implement GUI client support
Review for @vig_20141020a.zip@:
# @ClientExports.statusInputRevert@
- please add it back, regardless if is used a...
Constantin Asofiei
11:27 AM User Interface Feature #2252: implement GUI client support
Here are my latest changes for frame GUI support which is still an intermediate work.
1. I fixed previous code rev...
Marius Gligor
11:19 AM User Interface Feature #2252: implement GUI client support
In regard to the ALT-F4 problem, isn't this due to the @setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE);@ in @Abstract... Greg Shah
10:20 AM User Interface Feature #2252: implement GUI client support
Greg Shah wrote:
> > I can not find a way to disable the window's OS popup menu to appear when the ALT+SPACE key is ...
Constantin Asofiei
10:16 AM User Interface Feature #2252: implement GUI client support
> I don't understand how is GUI mode special, so that it needs to treat the keyboard differently.
It isn't specia...
Greg Shah
09:49 AM User Interface Feature #2252: implement GUI client support
Greg, this is for #2340. From your list:
> 1. Implementing proper keyboard and mouse event processing at the 4GL eve...
Constantin Asofiei
05:57 PM User Interface Feature #2424: GUI window sizing and scrollbar/viewport handling
This is just for time tracking. Please place all history in parent task #2252. Greg Shah
05:56 PM User Interface Feature #2424 (Closed): GUI window sizing and scrollbar/viewport handling
Greg Shah
01:18 PM User Interface Feature #2423: add proper key-to-event mappings in GUI
From #2252 note 391:
Greg Shah wrote:
> > I don't understand how is GUI mode special, so that it needs to treat ...
Constantin Asofiei
01:17 PM User Interface Feature #2423 (Closed): add proper key-to-event mappings in GUI
Constantin Asofiei
12:32 PM User Interface Feature #1791: implement dynamic UI support
Eugenie Lyzenko wrote:
> >And where do we cause this notification to occur? Static frames call TransactionManager.re...
Constantin Asofiei
08:50 AM User Interface Feature #1791: implement dynamic UI support
> I think we need only frame.setInScope(true) on the client side. Because for dynamic frames there is no scope nestin... Greg Shah
07:11 AM User Interface Feature #1791: implement dynamic UI support
>All of this should be gotten "automatically" by either an explicit DELETE WIDGET hndl.
OK.
>or by the implicit...
Eugenie Lyzenko
10:29 AM Database Feature #2220: dynamic query methods which require implementation
I have two runs with tc_job_clock_002 and tc_job_clock_004 failed. So I'll run regression one more time. Stanislav Lomany
10:16 AM Database Feature #2220: dynamic query methods which require implementation
Code review 1020a:
Change look good.
> Passed regression testing (except three tc_job_clock tests)
Do you ha...
Eric Faulhaber
10:06 AM Database Feature #2220: dynamic query methods which require implementation
Update with fixed regressions for review. One regression was minor overlook, two were related to @FilteredResults@ wh... Stanislav Lomany

10/20/2014

05:59 PM User Interface Feature #1791: implement dynamic UI support
>And where do we cause this notification to occur? Static frames call TransactionManager.registerFinalizable() and ge... Eugenie Lyzenko
05:04 PM User Interface Feature #1791: implement dynamic UI support
>2. Which portions of client side OPEN_SCOPE code are needed? Is it as simple as implementing a full OPEN_SCOPE notif... Eugenie Lyzenko
01:09 PM User Interface Feature #1791: implement dynamic UI support
I think we are almost there.
I agree that dynamic widgets appear to be managed based on the widget-pool. This is ...
Greg Shah
02:26 PM User Interface Feature #2422: add features to BROWSE
OK, good. As you create them, please do check in your testcases to @testcases/uast/browse/@. This includes bugs lik... Greg Shah
01:13 PM User Interface Feature #2422 (WIP): add features to BROWSE
I'll post here bugs which I'll found along the way.
Bug 1.
When a value is edited in an editable browse, key presse...
Stanislav Lomany
12:19 PM User Interface Feature #2252: implement GUI client support
I forgot to add, that I reverted @display*, view* and enable*@ methods in @GenericFrame@ as you advised earlier. I ge... Vadim Gindin
12:04 PM User Interface Feature #2252: implement GUI client support
I fixed some remained remarks and added frames windows map to @LogicalTerminal@. That helps to keep track of windows,... Vadim Gindin

10/17/2014

06:23 PM User Interface Feature #1791: implement dynamic UI support
4 more testcases have been committed in bzr as 1214.
Testcase @dyn_wid_test27.p@ demonstrates the client side reac...
Eugenie Lyzenko
05:44 PM User Interface Feature #2422: add features to BROWSE
Please do this work in 2 parts:
1. The conversion and runtime work to get the configuration values set into @Brows...
Greg Shah
05:36 PM User Interface Feature #2422: add features to BROWSE
Please add (or finish) the following features in BROWSE. At this time, the GUI version of BROWSE is not needed. The... Greg Shah
05:25 PM User Interface Feature #2422 (Closed): add features to BROWSE
Greg Shah
04:57 PM User Interface Feature #2252: implement GUI client support
Code Review mag_upd20141017a.zip
I like where this is going.
1. Do you think that the @Frame@ color management ...
Greg Shah
04:27 PM User Interface Feature #2252: implement GUI client support
Code Review mag_upd20141016a.zip
The code looks really good.
There are some minor code standard issues (use o...
Greg Shah
02:15 PM User Interface Feature #2252: implement GUI client support
I made corrections corresponding to latest remarks. See remarks statuses below (marked with *done*).
Constantin Asof...
Vadim Gindin
10:07 AM User Interface Feature #2252: implement GUI client support
Here are my first changes to abstract the code for frames and other minor improvements. Three classes are involved:
...
Marius Gligor
08:09 AM User Interface Feature #2252: implement GUI client support
> you have cases where you transform a DISPLAY into a DISPLAY ... IN WINDOW CURRENT-WINDOW; please go through all cas... Greg Shah
04:05 AM User Interface Feature #2252: implement GUI client support
Some useful examples regarding window and frame sizes:
1. The window client area in GUI is 80 columns and 24 rows....
Marius Gligor
03:12 AM User Interface Feature #2252: implement GUI client support
Vadim Gindin wrote:
> I corrected most of Constantin's remarks. Have a look please.
Please specify either what is f...
Constantin Asofiei
08:02 PM User Interface Feature #2252: implement GUI client support
I corrected most of Constantin's remarks. Have a look please. Vadim Gindin
02:34 AM Database Feature #2421: Implement DELETE-RESULT-LIST-ENTRY for PresortCompoundQuery
So far I've found two major problems for this type of query:
1. Cursor is not used for getting next/prev values - on...
Stanislav Lomany
02:28 AM Database Feature #2421 (Closed): Implement DELETE-RESULT-LIST-ENTRY for PresortCompoundQuery
Stanislav Lomany

10/16/2014

05:47 PM User Interface Feature #1791: implement dynamic UI support
Some consideration for handling @LogicalTerminal.signalFrameScope()@ signals in server and client sides.
The serve...
Eugenie Lyzenko
02:52 PM User Interface Feature #1791: implement dynamic UI support

> > I'm planning to upload all other dynamic widgets tests in uast/dynamic_widget. Is it OK?
>
> Yes, please do....
Eugenie Lyzenko
02:05 PM User Interface Feature #1791: implement dynamic UI support
> I'm planning to upload all other dynamic widgets tests in uast/dynamic_widget. Is it OK?
Yes, please do.
> I ...
Greg Shah
01:36 PM User Interface Feature #1791: implement dynamic UI support
I have committed in bzr the modified version of @dyn_wid_test25.p@ with check for the screen values after retry. And ... Eugenie Lyzenko
08:59 AM User Interface Feature #1791: implement dynamic UI support
The frame scoping related tests (19-26) has been committed in bzr as 1211. I did not add dynamic widget tests there(n... Eugenie Lyzenko
11:17 AM User Interface Feature #2252: implement GUI client support
Here is an intermediate work for GUI frame implementation. So far I tested some options like @NO-BOX, SIZE phrase, AT... Marius Gligor

10/15/2014

05:07 PM User Interface Feature #1791: implement dynamic UI support
How do you know that in @dyn_wid_test25.p@ the widget screen-value is not reset during the retry? None of the fillin... Greg Shah
04:56 PM User Interface Feature #1791: implement dynamic UI support
More investigation results.
1. There is no changes as result of setting @DOWN@ value to 0.
2. @RETRY@ statement...
Eugenie Lyzenko
04:57 PM User Interface Feature #2252: implement GUI client support
> By the way I saw such errors earlier. Why they happen? It does not looks like app error because the user already ex... Greg Shah
03:17 PM User Interface Feature #2252: implement GUI client support
I would say no. Most of tc_ failures look like when in Syman Menu user press R (that is quit command) and after quit ... Vadim Gindin
02:57 PM User Interface Feature #2252: implement GUI client support
> regression testing trunk without my update gave 1 failed gso_* test (gso_290) and 19 failed tc_* tests.
Are any ...
Greg Shah
02:55 PM User Interface Feature #2252: implement GUI client support
regression testing trunk without my update gave 1 failed gso_* test (gso_290) and 19 failed tc_* tests. Vadim Gindin
09:39 AM User Interface Feature #2252: implement GUI client support
Greg Shah wrote:
> > In other words is a tight relation between position in character units and native units.
>
>...
Hynek Cihlar
08:32 AM User Interface Feature #2252: implement GUI client support
> In other words is a tight relation between position in character units and native units.
I have explored this fo...
Greg Shah
08:03 AM User Interface Feature #2252: implement GUI client support
I tested some frame location options, Progress @AT pharse@. The option @AT COLUMN c ROW w@ is implemented and works.
...
Marius Gligor
05:06 AM User Interface Feature #2252: implement GUI client support
Last review part of the vig_upd20141013a.zip:
ThinClient:
# where viewWorker/view/etc is called with windowId = -...
Constantin Asofiei
01:53 AM User Interface Feature #2252: implement GUI client support
Vadim Gindin wrote:
> > Browse.java:
> > - line 1989/2582: avoid resolving ancestor() twice...
>
> These are two...
Constantin Asofiei
04:19 PM Database Bug #2420: Fully reproduce QUERY-OFF-END behavior
@QUERY-OFF-END@ may return quirky values which doesn't always represent "logical" off-end state.
See the following t...
Stanislav Lomany
04:08 PM Database Bug #2420 (New): Fully reproduce QUERY-OFF-END behavior
Stanislav Lomany
03:22 PM Database Feature #2220: dynamic query methods which require implementation
Code review 1015a:
I found nothing problematic, though it is quite a large and complicated update, so it is hard t...
Eric Faulhaber
01:34 PM Database Feature #2220: dynamic query methods which require implementation
Final update for review. Latest changes are related to @DELETE-RESULT-LIST-ENTRY@ and @peekNext/peekPrevious@ in comp... Stanislav Lomany

10/14/2014

05:48 PM User Interface Feature #2252: implement GUI client support
Thank you for review. My comments are below.
Constantin Asofiei wrote:
> Vadim, about vig_upd20141013a.zip:
>
...
Vadim Gindin
11:45 AM User Interface Feature #2252: implement GUI client support
Vadim, about vig_upd20141013a.zip:
Browse.java:
- line 1989/2582: avoid resolving ancestor() twice...
- line 25...
Constantin Asofiei
11:23 AM User Interface Feature #2252: implement GUI client support
Greg Shah wrote:
> Hynek Cihlar wrote:
> The @move-win()@ function and the test suite in general evolved greatly as...
Hynek Cihlar
11:15 AM User Interface Feature #2252: implement GUI client support
Code Review mag_upd20141014b.zip
It looks good.
Greg Shah
11:11 AM User Interface Feature #2252: implement GUI client support
Hynek Cihlar wrote:
> Greg I have a question about the window_sizing test cases. Why some of the calls to @move-win@...
Greg Shah
11:10 AM User Interface Feature #2252: implement GUI client support
Sorry was my fault. For @frame_scoping.rules@ I didn't found a solution so far.
The rules in @frame_generator.xml@ w...
Marius Gligor
11:05 AM User Interface Feature #2252: implement GUI client support
Vadim: Constantin is reviewing your vig_upd20141013a.zip update and will provide some feedback.
> We can see extra...
Greg Shah
11:01 AM User Interface Feature #2252: implement GUI client support
Code Review mag_upd20141014a
The changes to @CommonFrame@ and @GenericFrame@ seem fine.
The @frame_scoping.rule...
Greg Shah
10:59 AM User Interface Feature #2252: implement GUI client support
Constantin Asofiei wrote:
> Marius Gligor wrote:
> > @FrameWidget@ has both @set/getWidth/WidthChars@ and @set/getH...
Greg Shah
10:16 AM User Interface Feature #2252: implement GUI client support
Greg I have a question about the window_sizing test cases. Why some of the calls to @move-win@ function don't use the... Hynek Cihlar
09:45 AM User Interface Feature #2252: implement GUI client support
I did the changes for set/get WidthChars/HeightChars by inheriting from @Sizeable@ API.
Marius Gligor
08:02 AM User Interface Feature #2252: implement GUI client support
Vadim Gindin wrote:
> Hynek, they are based on my update. Here it is.
I didn't find anything suspicious. I would ...
Hynek Cihlar
07:01 AM User Interface Feature #2252: implement GUI client support
Here are the results of compiling the frame test @f-1.p@ using @xref@ option: ... Marius Gligor
06:16 AM User Interface Feature #2252: implement GUI client support
Hynek, they are based on my update. Here it is. Vadim Gindin
05:28 AM User Interface Feature #2252: implement GUI client support
Vadim Gindin wrote:
> I fixed HIDE error from previous regression testing and It reduced number of gso_* failed test...
Hynek Cihlar
05:26 AM User Interface Feature #2252: implement GUI client support
Sorry, Redmine corrupts output screens in my previous note in spite of it's preview displayed them correctly. I'm att... Vadim Gindin
05:24 AM User Interface Feature #2252: implement GUI client support
Marius Gligor wrote:
> @FrameWidget@ has both @set/getWidth/WidthChars@ and @set/getHeight/HeightChars@ We should ke...
Constantin Asofiei
05:19 AM User Interface Feature #2252: implement GUI client support
I fixed HIDE error from previous regression testing and It reduced number of gso_* failed tests from 90 to 26. tc_* f... Vadim Gindin
04:49 AM User Interface Feature #2252: implement GUI client support
@FrameWidget@ has both @set/getWidth/WidthChars@ and @set/getHeight/HeightChars@ We should keep the same methods for ... Marius Gligor
03:15 AM User Interface Feature #2252: implement GUI client support
Greg Shah wrote:
> Code Review mag_upd20141013a.zip
> 1. In methods_attributes.rules, @ref@ can't be relied upon to...
Constantin Asofiei
11:22 AM Database Bug #2402 (Closed): ClassCastException thrown when accessing EXTENT fields
Eric Faulhaber
10:44 AM User Interface Feature #1791: implement dynamic UI support
Eugenie:
1. Please ensure that all 3 examples shown in note 212 are checked in to the dynamic widget testcases and...
Greg Shah
04:16 AM User Interface Feature #1791: implement dynamic UI support
Greg Shah wrote:
> I do agree that I can't yet think of a way to make static frame statements like DISPLAY or DOWN w...
Constantin Asofiei

10/13/2014

07:08 PM User Interface Feature #1791: implement dynamic UI support
> As we expected from the 4GL documentation the dynamic frame is only one down frame.
One thing that is strange is...
Greg Shah
04:06 PM User Interface Feature #1791: implement dynamic UI support
For @iterate()@ hook. As we expected from the 4GL documentation the dynamic frame is only one down frame. Trying to u... Eugenie Lyzenko
06:35 PM User Interface Feature #2252: implement GUI client support
Code Review mag_upd20141013a.zip
I don't think either of these changes is correct.
1. In methods_attributes.rul...
Greg Shah
06:01 PM User Interface Feature #2252: implement GUI client support
> How to get WindowWidget having GenericFrame or GenericWidget? Some code on server side needs to use Window handling... Greg Shah
03:32 PM User Interface Feature #2252: implement GUI client support
How to get WindowWidget having GenericFrame or GenericWidget? Some code on server side needs to use Window handling: ... Vadim Gindin
10:14 AM User Interface Feature #2252: implement GUI client support
Today I worked to fix frame conversion issues:
1. For frame scoping I changed the @frame_scoping.rules@ by adding ...
Marius Gligor
09:12 AM User Interface Feature #2252: implement GUI client support
Reposted from #2415 (by MAG):
Passed regression tests. Committed revision 10625.
The following files were delet...
Greg Shah
08:59 AM User Interface Feature #2252: implement GUI client support
> Do you have anything against if I add the flag to the config and getters/setters to the widgets? The flag will be s... Greg Shah
09:11 AM User Interface Feature #2415 (Closed): insert indicator support for GUI window
Greg Shah

10/12/2014

05:17 PM Base Language Bug #2419: Type mismatch error in the converted code when integer literal passed to decimal param...
The following piece of code converts to uncompilable Java code.... Hynek Cihlar
05:14 PM Base Language Bug #2419 (New): Type mismatch error in the converted code when integer literal passed to decimal...
Hynek Cihlar

10/11/2014

03:15 PM Database Bug #2382: Improve format string error handling in ADD-NEW-FIELD implementation
Updated test cases @vmn_upd20141011b.zip@ attached. Only one file @date_error_field_format.p@ was updated and used fo... Vadim Nebogatov
12:28 PM User Interface Feature #2252: implement GUI client support
Hynek Cihlar wrote:
> ... or better yet ask the driver for the translated origin and offset @boundary@.
This one is...
Constantin Asofiei
11:44 AM User Interface Feature #2252: implement GUI client support
Constantin Asofiei wrote:
> Hynek Cihlar wrote:
> > I see. Do you have anything against if I add the flag to the co...
Hynek Cihlar
05:02 AM User Interface Feature #2252: implement GUI client support
Hynek Cihlar wrote:
> I see. Do you have anything against if I add the flag to the config and getters/setters to the...
Constantin Asofiei
02:51 AM User Interface Feature #2415: insert indicator support for GUI window
Passed regression tests. Committed revision 10625.
The following files were deleted:
src/com/goldencode/p2j/ui/cl...
Marius Gligor

10/10/2014

03:52 PM User Interface Feature #2252: implement GUI client support
Greg Shah wrote:
> For a widget to be realized, it means that the widget has been viewed (made visible on the screen...
Hynek Cihlar
03:37 PM User Interface Feature #2252: implement GUI client support
For a widget to be realized, it means that the widget has been viewed (made visible on the screen) at least once. In... Greg Shah
03:28 PM User Interface Feature #2252: implement GUI client support
I have a question to the widget experts out there. What does it mean for a window (in GUI) to be realized? I found th... Hynek Cihlar
03:08 PM User Interface Feature #2252: implement GUI client support
The @gso_200/buyer_search1.txt@ is only referenced in 1 test (@majic_baseline/tests/gso/gso_200/gso_200.xml@):
<pr...
Greg Shah
02:14 PM User Interface Feature #2252: implement GUI client support
> > Constantin Asofiei wrote:
> Sorry, in note 315 I meant ScreenBitmap.rows/cols - this is still set to character u...
Hynek Cihlar
02:06 PM User Interface Feature #2252: implement GUI client support
Greg Shah wrote:
> Code Review vig_upd20141009a.zip
>
> I'm fine with the changes. It looks like the @messageBox...
Vadim Gindin
12:42 PM User Interface Feature #2252: implement GUI client support
> The audit logs have always been there... I think audit might have been enabled sometime before devsrv01 was in plac... Greg Shah
12:40 PM User Interface Feature #2252: implement GUI client support
> The problem is that generated code is not compiled due to an error in statement. fFrame.setHeightChars(new integer(... Greg Shah
12:31 PM User Interface Feature #2252: implement GUI client support
Marius Gligor wrote:
> We could change a little bit @WidgetFactoryAdaptor.create@ method to works with constructors ...
Constantin Asofiei
12:29 PM User Interface Feature #2252: implement GUI client support
Greg Shah wrote:
> Constantin: did we intentionally enable this at some point? It seems like we should clean that u...
Constantin Asofiei
12:15 PM User Interface Feature #2252: implement GUI client support
Code Review mag_upd20141010a.zip
It looks good. Please test it.
Greg Shah
12:06 PM User Interface Feature #2252: implement GUI client support
I've started to work on task #2416. First of all I converted your sample... Marius Gligor
12:02 PM User Interface Feature #2252: implement GUI client support
Fixed Code Review mag_upd20141009a.zip issues. Marius Gligor
10:33 AM User Interface Feature #2252: implement GUI client support
Code Review vig_upd20141009a.zip
I'm fine with the changes. It looks like the @messageBox()@ signatures look much...
Greg Shah
10:00 AM User Interface Feature #2252: implement GUI client support
> we can add a .sh script with the same name as the archive, and execute that script in the i.e. ~/testing/majic or ... Greg Shah
09:37 AM User Interface Feature #2252: implement GUI client support
Code Review mag_upd20141009a.zip
It looks good.
1. The explicit use of @import com.goldencode.p2j.ui.chui.ThinC...
Greg Shah
06:48 AM User Interface Feature #2252: implement GUI client support
Hynek Cihlar wrote:
> Constantin Asofiei wrote:
> > Hynek, if the common UI logic is using native coordinates (you ...
Constantin Asofiei
06:32 AM User Interface Feature #2252: implement GUI client support
The next update, that failed regression testing. I've also attached logs. They looks strange. The log "testing_*" con... Vadim Gindin
12:36 PM User Interface Feature #1791: implement dynamic UI support
Greg Shah wrote:
> Constantin: do you have anything to add?
Dynamic widgets can survive the creator procedure, if t...
Constantin Asofiei
12:12 PM User Interface Feature #1791: implement dynamic UI support
> Investigating the scoping approach for dynamic widgets I've found interesting info in Progress Programming Handbook... Greg Shah
09:22 AM User Interface Feature #1791: implement dynamic UI support
Committed in bzr as 10624. No testing required. Eugenie Lyzenko
09:21 AM User Interface Feature #1791: implement dynamic UI support
Small drop to fix the missed/not required history entries. Will be committed and distributed soon. Eugenie Lyzenko
01:37 AM User Interface Feature #2416 (WIP): implement frame widget support for GUI
Marius Gligor

10/09/2014

04:40 PM User Interface Feature #2252: implement GUI client support
Constantin Asofiei wrote:
> Hynek, if the common UI logic is using native coordinates (you have bitmaps of NativeRec...
Hynek Cihlar
03:58 PM User Interface Feature #2252: implement GUI client support
Hynek, if the common UI logic is using native coordinates (you have bitmaps of NativeRectangle), then am I correct to... Constantin Asofiei
10:56 AM User Interface Feature #2252: implement GUI client support
Constantin Asofiei wrote:
> Greg, an idea: we can add a .sh script with the same name as the archive, and execute th...
Hynek Cihlar
09:24 AM User Interface Feature #2252: implement GUI client support
Marius Gligor wrote:
> 3. I observed that we cannot manage deleted files from project when we run regression tests. ...
Constantin Asofiei
09:11 AM User Interface Feature #2252: implement GUI client support
1. The idea behind @AbstractMessageArea@ was to find an @OOP@ solution (abstraction) rather than a trivial test like ... Marius Gligor
04:38 PM User Interface Feature #1791: implement dynamic UI support
Investigating the scoping approach for dynamic widgets I've found interesting info in @Progress Programming Handbook@... Eugenie Lyzenko
11:54 AM User Interface Bug #2418: frame construction issue
Sometimes the frame are not correctly formed. Consider the following procedure:... Ovidiu Maxiniuc
11:47 AM User Interface Bug #2418 (New): frame construction issue
Ovidiu Maxiniuc
09:15 AM User Interface Feature #2415 (Review): insert indicator support for GUI window
Marius Gligor

10/08/2014

06:26 PM User Interface Feature #2252: implement GUI client support
About #2415 and #2334:
Now we know that there is no insert indicator for GUI. That is good information. Before w...
Greg Shah
03:23 PM User Interface Feature #2252: implement GUI client support
Code Review vig_upd20141008a.zip
1. Please add this TODO just above the call to @view()@ on line 4471 of @GenericF...
Greg Shah
02:06 PM User Interface Feature #2252: implement GUI client support
Vadim Gindin wrote:
> There are also other strange error:
> @org.hibernate.service.UnknownServiceException: Unknown...
Eric Faulhaber
01:52 PM User Interface Feature #2252: implement GUI client support
Merged update. Vadim Gindin
01:29 PM User Interface Feature #2252: implement GUI client support
VIG: While I look at the log, please merge your vig_upd20141007a.zip with the latest bzr level 10623. Greg Shah
01:01 PM User Interface Feature #2252: implement GUI client support
After regression testing of vig_upd20141007a.zip I faced with the error (see attached log):
@java.io.NotSerializable...
Vadim Gindin
12:37 PM User Interface Feature #2252: implement GUI client support
Today I managed to connect @OE@ to @sports2000@ database on the customer's server. Having a database connection I did... Marius Gligor
02:27 PM Database Bug #2417: DatabaseManager reports severe error when registering a database more than once
The following code in @DatabaseManager.registerDatabase(DatabaseConfig, Database, boolean)@ may not be correct:
<pre...
Eric Faulhaber
02:22 PM Database Bug #2417 (New): DatabaseManager reports severe error when registering a database more than once
Eric Faulhaber
09:22 AM User Interface Feature #2333 (Closed): implement the GUI status line widget
Greg Shah
07:40 AM Database Bug #2402: ClassCastException thrown when accessing EXTENT fields
The attached update passed the regression test.
It was committed to bzr as rev. 10622 and distributed by mail.
Ovidiu Maxiniuc
02:47 AM User Interface Feature #2334 (Review): implement the GUI message line widget
1007b passed regression tests. committed revision 10621.
This task require more changes after task #2229 will be fin...
Marius Gligor

10/07/2014

01:13 PM User Interface Feature #2252: implement GUI client support
Before you consider your work with #2415 closed, please test SET, INSERT, CHOOSE, ENABLE + WAIT-FOR. I'm not referri... Greg Shah
12:32 PM User Interface Feature #2252: implement GUI client support
1. I tested @INSERT@ indicator for @GUI@ using the following simple tests:... Marius Gligor
10:49 AM User Interface Feature #2252: implement GUI client support
Merged update with Constantin's fix of @ProcedureManager.currentWindow@ bug. Vadim Gindin
10:34 AM User Interface Feature #2334: implement the GUI message line widget
Code Review 1007b
I'm good with the update.
Greg Shah
10:11 AM User Interface Feature #2334: implement the GUI message line widget
Fixed Code Review 1007a. I renamed @MessageLineGui@ to @InsertIndicator.java@
I'm going to start regression tests.
Marius Gligor
09:50 AM User Interface Feature #2334: implement the GUI message line widget
Code Review 1007a
@client/chui/MessageAreaImpl.java@ is missing a history entry. Otherwise I am fine with the upd...
Greg Shah
06:17 AM User Interface Feature #2334: implement the GUI message line widget
Here are my latest changes which contains:
1. I fixed @MessageAreaImpl@ issue. I renamed @MessageArea@ class as @A...
Marius Gligor
09:07 AM Base Language Feature #1628: fix any incompatibilities or missing features of NO-ECHO support
Code Review evk_upd20141003a.zip
1. The redirected terminal change now looks much safer.
2. Please describe the...
Greg Shah
08:26 PM Base Language Feature #1628: fix any incompatibilities or missing features of NO-ECHO support
merged with latest revision
fixed issue with box[]
In @Stream@ lazyNewLine now working only with put operation, EXP...
Evgeny Kiselev
06:23 AM User Interface Feature #2415 (WIP): insert indicator support for GUI window
Marius Gligor

10/06/2014

06:41 PM User Interface Feature #2252: implement GUI client support
Details of work for #2416:
This task is about implementing GUI frame support. At this time we will only implement a...
Greg Shah
05:30 PM User Interface Feature #2252: implement GUI client support
Details of work for #2415:
I have not yet seen an insert indicator be displayed/maintained in GUI windows. This i...
Greg Shah
11:12 AM User Interface Feature #2252: implement GUI client support
Code Review hc_upd20141005a.zip
If it passes testing, you can check it in.
Please note that since this affects ...
Greg Shah
11:06 AM User Interface Feature #2252: implement GUI client support
Code Review vig_upd20141006a.zip
This looks really good. Did you fix the NPE from regression testing yet?
1. T...
Greg Shah
09:40 AM User Interface Feature #2252: implement GUI client support
Final update for #2254, replacement for 1002h.zip - passed testing, released to bzr rev 10620. The lib/aspectjtools.... Constantin Asofiei
08:27 AM User Interface Feature #2252: implement GUI client support
The change set is already up to date with ca_upd20141003a.zip and ca_upd20140929c.zip and is currently regression-tes... Hynek Cihlar
05:15 PM User Interface Feature #2416: implement frame widget support for GUI
This task is only for time tracking. Please put all history entries in parent task #2252. Greg Shah
05:15 PM User Interface Feature #2416 (Closed): implement frame widget support for GUI
Greg Shah
05:14 PM User Interface Feature #2415: insert indicator support for GUI window
This task is only for time tracking. Please put all history entries in parent task #2252. Greg Shah
05:13 PM User Interface Feature #2415 (Closed): insert indicator support for GUI window
Greg Shah
12:09 PM User Interface Feature #2334: implement the GUI message line widget
@MessageAreaImpl@ in package @com.goldencode.p2j.ui.client.gui@ is no longer used on GUI. The @MessageAreaGuiImpl@ is... Marius Gligor
11:57 AM User Interface Feature #2334: implement the GUI message line widget
Code Review 1006a
Everything looks good except there is some hard coded message output in @MessageAreaImpl.draw()@...
Greg Shah
11:30 AM User Interface Feature #2334: implement the GUI message line widget
I updated and configured my project to use AOP builder. Here are my latest changes and fixes that I did after doing t... Marius Gligor
09:40 AM User Interface Feature #2254 (Closed): eliminate the logic in the Config* classes and make them simple container...
Greg Shah
04:56 AM User Interface Feature #2254 (WIP): eliminate the logic in the Config* classes and make them simple containers w...
Constantin Asofiei
07:25 AM Database Bug #2413: Invalid multi-table conversion (Compound(Preselect, Adaptive) instead of Preselect)
Testcase:... Stanislav Lomany
07:13 AM Database Bug #2413 (New): Invalid multi-table conversion (Compound(Preselect, Adaptive) instead of Preselect)
Stanislav Lomany

10/05/2014

05:31 PM User Interface Feature #2252: implement GUI client support
Here is an update for multi-window support of DISPLAY/VIEW/HIDE statements. Have a look please. I'm not sure about VI... Vadim Gindin
04:49 PM User Interface Feature #2252: implement GUI client support
I am attaching the change set with added javadocs and the TODO implemented.
Greg Shah wrote:
> Code Review hc_upd...
Hynek Cihlar
08:13 AM User Interface Feature #2252: implement GUI client support
Code Review hc_upd20141004a.zip
I like the approach. It changes nothing for current context local instances, but ...
Greg Shah
08:54 AM User Interface Feature #2412: Implement widget browser
The Widget browser should provide runtime insight into the widget hierarchy. The idea is to have some basic functiona... Hynek Cihlar
08:46 AM User Interface Feature #2412 (Closed): Implement widget browser
Hynek Cihlar

10/04/2014

05:32 PM User Interface Feature #2252: implement GUI client support
@Constantin, I found a little problem with the initialization of LogicalTerminal in ca_upd20141002h.zip.
LogicalT...
Hynek Cihlar

10/03/2014

11:26 AM Database Bug #2405: CompoundQuery.previous() invalid behavior after back off-end
... Stanislav Lomany
11:24 AM Database Bug #2405 (New): CompoundQuery.previous() invalid behavior after back off-end
Stanislav Lomany
11:04 AM User Interface Feature #2252: implement GUI client support
DOWN/UP/SCROLL statements also do not support IN WINDOW clause. Compile error is @IN WINDOW invalid with UP, DOWN, an... Vadim Gindin
09:34 AM User Interface Feature #2252: implement GUI client support
Greg Shah wrote:
> It looks good. We should remember the "wishlist" somewhere for later development:
>
> * Deleg...
Constantin Asofiei
08:49 AM User Interface Feature #2252: implement GUI client support
> Regression testing of p2j trunk without my update succeed. Only 2 tests have failed: tc_job_002 and tc_misc_reports... Greg Shah
08:37 AM User Interface Feature #2252: implement GUI client support
Hynek Cihlar wrote:
> Greg Shah wrote:
> > * Implement a listener/notification framework and a clean way to associa...
Greg Shah
05:44 AM User Interface Feature #2252: implement GUI client support
Regression testing of p2j trunk without my update succeed. Only 2 tests have failed: tc_job_002 and tc_misc_reports_0... Vadim Gindin
02:29 AM User Interface Feature #2252: implement GUI client support
Greg Shah wrote:
> * Implement a listener/notification framework and a clean way to associate listeners with their t...
Hynek Cihlar

10/02/2014

05:48 PM Database Feature #2220: dynamic query methods which require implementation
Stanislav Lomany wrote:
> That is correct except for:
>
> > * Fixing adaptive, non-scrolling queries.
>
> If y...
Eric Faulhaber
05:00 PM Database Feature #2220: dynamic query methods which require implementation
That is correct except for:
> * Fixing adaptive, non-scrolling queries.
If you mean improving it for multi-tabl...
Stanislav Lomany
12:11 PM Database Feature #2220: dynamic query methods which require implementation
OK, so my understanding of where this all stands now (and please correct me if I'm missing something) is that we have... Eric Faulhaber
07:47 AM Database Feature #2220: dynamic query methods which require implementation
> > Note that my decision to remove @Cursor.offEnd@ field probably was a mistake.
>
> It is still removed in this ...
Stanislav Lomany
01:52 AM Database Feature #2220: dynamic query methods which require implementation
> Other than this, is @DELETE-RESULT-LIST-ENTRY@ fully implemented now? Is there anything else left to do on this tas... Stanislav Lomany
11:13 PM Database Feature #2220: dynamic query methods which require implementation
Code review 0928a:
I think the changes are OK, but please see my questions and comments below.
In note 45 above...
Eric Faulhaber
04:15 PM User Interface Feature #2252: implement GUI client support
Greg Shah wrote:
> Is there anything left to do for STATUS or MESSAGE in #2229?
Nothing.
> ..
> What is the sta...
Vadim Gindin
04:00 PM User Interface Feature #2252: implement GUI client support
Is there anything left to do for STATUS or MESSAGE in #2229? If not, then please work on DEFINE FRAME/FORM next (see... Greg Shah
03:56 PM User Interface Feature #2252: implement GUI client support
Code Review vig_upd20141002b.zip
It looks good.
Greg Shah
03:52 PM User Interface Feature #2252: implement GUI client support
I thought so. I've combined history entries. Vadim Gindin
03:36 PM User Interface Feature #2252: implement GUI client support
Code Review vig_upd20141002a.zip
The changes are fine. Please do combine the history entries into a single entry ...
Greg Shah
03:18 PM User Interface Feature #2252: implement GUI client support
I merged status* update and message* update. Here is the merged common update. Can I stay 2 history entries in corres... Vadim Gindin
12:56 PM User Interface Feature #2252: implement GUI client support
Code Review ca_upd20141002h.zip
It looks good. We should remember the "wishlist" somewhere for later development:...
Greg Shah
12:11 PM User Interface Feature #2252: implement GUI client support
Greg Shah wrote:
> 1. The @StandardServer.invoke()@ issue still exists.
Thanks, forgot about it, is fixed now.
>...
Constantin Asofiei
12:58 PM Database Bug #2402 (Test): ClassCastException thrown when accessing EXTENT fields
Code review 1002a:
The file is out of date; please merge your change up to bzr rev 10619. Other than that, the cha...
Eric Faulhaber
12:50 PM Database Bug #2402: ClassCastException thrown when accessing EXTENT fields
Ovidiu Maxiniuc wrote:
> The original exception is discarded because it is caused by an @abnormalEnd()@ in the @Bloc...
Eric Faulhaber
12:41 PM Database Bug #2402: ClassCastException thrown when accessing EXTENT fields
Eric Faulhaber wrote:
> Nice catch. If there is nothing more to do than the solution proposed above, please prepare ...
Ovidiu Maxiniuc
12:23 PM Database Bug #2402: ClassCastException thrown when accessing EXTENT fields
The original exception is discarded because it is caused by an @abnormalEnd()@ in the @BlockManager@ so the whole unw... Ovidiu Maxiniuc
11:40 AM Database Bug #2402: ClassCastException thrown when accessing EXTENT fields
Ovidiu Maxiniuc wrote:
> The original exception is lost and not printed in logs.
Have you determined why it is lo...
Eric Faulhaber
11:38 AM Database Bug #2402 (WIP): ClassCastException thrown when accessing EXTENT fields
Nice catch. If there is nothing more to do than the solution proposed above, please prepare an update and push it thr... Eric Faulhaber
06:16 AM Database Bug #2402: ClassCastException thrown when accessing EXTENT fields
What is wring is that @RecordBuffer.Handler.invoke(Object proxy, Method method, Object[] args)@, in the case of EXTEN... Ovidiu Maxiniuc
05:53 AM Database Bug #2402: ClassCastException thrown when accessing EXTENT fields
I found this while investigating queries in #2266. The following code was constructed based real code from a customer... Ovidiu Maxiniuc
05:42 AM Database Bug #2402 (Closed): ClassCastException thrown when accessing EXTENT fields
Ovidiu Maxiniuc

10/01/2014

06:26 PM User Interface Feature #2334: implement the GUI message line widget
Code Review 1001a
The code changes look good.
I think the @ThinClient.splitMessage()@ should probably be move...
Greg Shah
11:58 AM User Interface Feature #2334: implement the GUI message line widget
1. The number of visible lines is @Window.RESERVED_LINES - 1@ (2) like on ChUI .
2. Message area could hold ...
Marius Gligor
08:29 AM User Interface Feature #2334: implement the GUI message line widget
I'm sure that any such code is just temporary and has no deep meaning. You can remove the conditional "protection" l... Greg Shah
06:03 AM User Interface Feature #2334: implement the GUI message line widget
I'm trying to test the following p4 statement @current-window:message-area-font=5.@ which in turn is converted in Jav... Marius Gligor
05:35 PM User Interface Feature #2252: implement GUI client support
Code Review ca_upd20141001d.zip
1. The @StandardServer.invoke()@ issue still exists.
2. The merge of the histor...
Greg Shah
03:50 PM User Interface Feature #2252: implement GUI client support
Code Review vig_upd20141001a.zip
Everything looks fine. Please merge your STATUS and MESSAGE updates into a singl...
Greg Shah
03:33 PM User Interface Feature #2252: implement GUI client support
> By the way, should I ran majic from the folder @~/testing/majic@, created by @run_regression.sh configure@ or from ... Greg Shah
01:20 PM User Interface Feature #2252: implement GUI client support
Attached update is built on top of 0926c and 0296g.zip. Not yet merged with latest version. Issues from review no... Constantin Asofiei
12:43 PM User Interface Feature #2252: implement GUI client support
I merged my update (message multi-window support) with the last updates, moved 3 flags from ThinClient to Window and ... Vadim Gindin
11:24 AM User Interface Feature #2252: implement GUI client support
I ran regression testing on devsrv01 2 or 3 times. That is the point. I didn't see failures in the tests, that are ma... Vadim Gindin
08:25 AM User Interface Feature #2252: implement GUI client support
Please focus on running testing on devsrv01. What failures are you seeing consistently on that system? How many tim... Greg Shah
03:36 AM User Interface Feature #2252: implement GUI client support
I tried to manually recreate the failures in tests I noted earlier in devsrv01. But there were no such error. Moreove... Vadim Gindin
04:46 PM Database Feature #2220: dynamic query methods which require implementation
OK, please thoroughly document the problem in a separate issue in this project, including why it is specific to @Pres... Eric Faulhaber
02:43 PM Database Feature #2220: dynamic query methods which require implementation
I've checked the presence of @PresortCompoundQuery@ in the customer app. It presents only in @FOR EACH@ form, so ther... Stanislav Lomany
12:17 PM User Interface Feature #2340: implement the window title bar
Regarding selection of mouse source which is the widget that should handle the mouse events.
Basically we have widg...
Marius Gligor

09/30/2014

04:46 PM Database Feature #2220: dynamic query methods which require implementation
If in your estimation it is not more than a few hours of effort, then yes -- it doesn't sound like it would be a lot ... Eric Faulhaber
04:41 PM Database Feature #2220: dynamic query methods which require implementation
Eric, there is a quirk in 4GL @DELETE-RESULT-LIST-ENTRY@ implementation: for adaptive non-scrolling queries if @DELET... Stanislav Lomany
04:11 PM User Interface Feature #2252: implement GUI client support
OK, then please ignore this issue and try to debug and/or solve your problems a different way. One important questio... Greg Shah
03:49 PM User Interface Feature #2252: implement GUI client support
No, server logs (server.log, server_gso_0.log) does not contain such error. Vadim Gindin
08:48 AM User Interface Feature #2252: implement GUI client support
Are these same "apparent deadlock" issues occurring when you run testing on devsrv01? Greg Shah
07:44 AM User Interface Feature #2252: implement GUI client support
Understood. I ran local server with remote (devsrv01) database. An Internet connection to GCD is good and stable. Con... Vadim Gindin
02:52 AM User Interface Feature #2252: implement GUI client support
Yes, good point -- it makes sense that the application would not work at all if the fundamental things I told you to ... Eric Faulhaber
03:28 PM User Interface Feature #2334: implement the GUI message line widget
Thanks Constantin I will check on customer's server.
I have another question related to fonts please: The call to @F...
Marius Gligor
01:46 PM User Interface Feature #2334: implement the GUI message line widget
Greg/Marius: in case you are not aware, see note 3 from #2252 - the message area in GUI holds a maximum of 50 message... Constantin Asofiei
01:43 PM User Interface Feature #2334: implement the GUI message line widget
Code Review 0930a
This looks really good.
1. There are still some hard coded message lines left behind.
2. I...
Greg Shah
01:37 PM User Interface Feature #2334: implement the GUI message line widget
The picture are uploaded just to show how scroll bar looks. I forced 8 lines instead 2 for message area.
When messag...
Marius Gligor
01:05 PM User Interface Feature #2334: implement the GUI message line widget
Why do the message-area5.png, message-area6.png and message-area7.png show a message area that is 8 lines in size? T... Greg Shah
01:00 PM User Interface Feature #2334: implement the GUI message line widget
> Should be the same value as for ChUI or should be a parameter stored in server directory?
As I noted in note 79 ...
Greg Shah
10:56 AM User Interface Feature #2334: implement the GUI message line widget
1. For ChUI the number of message lines is hard coded and the @ThinClient# getMessageLines@ return always @Window.RES... Marius Gligor
08:56 AM Base Language Feature #1628: fix any incompatibilities or missing features of NO-ECHO support
What is the status of your work on this task? Greg Shah
08:14 AM User Interface Feature #1791: implement dynamic UI support
From EVL via email:
> Just for you to know: in addition there are some missing functionality on client side I've d...
Greg Shah
08:00 PM User Interface Feature #1791: implement dynamic UI support
Committed to bzr as 10617. Eugenie Lyzenko

09/29/2014

07:52 PM User Interface Feature #1791: implement dynamic UI support
The @CTRL-C@ part completed without regressions. Had to start 3-way tests in separate session to get all passed in su... Eugenie Lyzenko
06:22 PM User Interface Feature #1791: implement dynamic UI support
>Please post the testcase code here.
Here it is. Pretty ugly but I guess do work....
Eugenie Lyzenko
05:08 PM User Interface Feature #1791: implement dynamic UI support
In other words, we will deal with the dynamic frame scoping as the next update (after you get back). Greg Shah
05:07 PM User Interface Feature #1791: implement dynamic UI support
> So I think the conclusion is scope is attached to widget pool, correct?
It tells us that at least some of the sc...
Greg Shah
04:58 PM User Interface Feature #1791: implement dynamic UI support
>3. Try to use the frame in procedure Y, but outside (after) the REPEAT block. If that works, then you know that the ... Eugenie Lyzenko
09:03 AM User Interface Feature #1791: implement dynamic UI support
Code Review 0929a
The code looks good.
The last problem is the @openScope()@. We definitely need to execute ...
Greg Shah
08:40 AM User Interface Feature #1791: implement dynamic UI support
> >3. I'm not sure opening the scope of a dynamic frame in GenericWidget.setId() is correct. That will associate it w... Greg Shah
05:15 AM User Interface Feature #1791: implement dynamic UI support
Small change to fix resource type requesting in @GenericWidget@ for building the error message. The testing cycle is ... Eugenie Lyzenko
04:48 PM User Interface Feature #2252: implement GUI client support
Eric, If it would be a database connectivity problem the application would not work. The error happen at the quit pro... Vadim Gindin
02:31 PM User Interface Feature #2252: implement GUI client support
Vadim, from the @server_gso_370.log@ file you attached, it looks like the P2J server cannot connect to the database. ... Eric Faulhaber
01:29 PM User Interface Feature #2252: implement GUI client support
I looked into testing results for my update and tried to reproduce failed tests locally. I found that most of them fa... Vadim Gindin
12:07 PM User Interface Feature #2252: implement GUI client support
Greg Shah wrote:
> Constantin Asofiei wrote:
> > Greg Shah wrote:
> > > Wouldn't moving to tracking changes at the...
Constantin Asofiei
12:04 PM User Interface Feature #2252: implement GUI client support
Constantin Asofiei wrote:
> Greg Shah wrote:
> > Wouldn't moving to tracking changes at the field-level solve this ...
Greg Shah
12:00 PM User Interface Feature #2252: implement GUI client support
Greg Shah wrote:
> Wouldn't moving to tracking changes at the field-level solve this issue?
We are not in the track...
Constantin Asofiei
11:30 AM User Interface Feature #2252: implement GUI client support
Wouldn't moving to tracking changes at the field-level solve this issue? Greg Shah
11:04 AM User Interface Feature #2252: implement GUI client support
About the MethodHandle performance issues: disabling the field setter listener code during duplicate plus the AspectJ... Constantin Asofiei
08:30 AM User Interface Feature #2252: implement GUI client support
> This is because the AspectJ Point Cuts (intercepted field setters) are called always (including during instance fie... Greg Shah

09/28/2014

04:28 PM User Interface Feature #1791: implement dynamic UI support
This update for review reflects your recent notes. I'm going to put it on regression testing cycle shortly. Eugenie Lyzenko
02:34 PM User Interface Feature #1791: implement dynamic UI support
The changes passed the regression testing.
>3. I'm not sure opening the scope of a dynamic frame in GenericWidget....
Eugenie Lyzenko
09:55 AM User Interface Feature #1791: implement dynamic UI support
Code Review 0927a
It looks good! As you suggest, if it passes testing you can check it in since any broken dynami...
Greg Shah
03:21 PM Database Feature #2220: dynamic query methods which require implementation
Update for adaptive scrolling cache. Fixed forward/backward. Doesn't reproduce 4GL off-end state issues noted in the ... Stanislav Lomany
11:14 AM User Interface Feature #2252: implement GUI client support
> 1. Could we drive association of common listeners (e.g. @pushScreenDefinition()@ or rounding) by AspectJ using anno... Constantin Asofiei
09:30 AM User Interface Feature #2252: implement GUI client support
Code Review ca_upd20140926g.zip
Generally, it all looks fine. The only thing I don't understand is why @ConfigMan...
Greg Shah

09/27/2014

12:24 PM User Interface Feature #1791: implement dynamic UI support
This is the main dynamic widget support update for review. Has the incorrect attributes handling, dynamic frames, wid... Eugenie Lyzenko
12:07 PM User Interface Feature #2399: Implement output redirection in GUI mode
The challenge here is that the GUI session uses GUI-specific widgets which know how to render themselves on raster-ba... Hynek Cihlar
12:03 PM User Interface Feature #2399 (Rejected): Implement output redirection in GUI mode
Hynek Cihlar

09/26/2014

06:38 PM User Interface Feature #2252: implement GUI client support
Code Review ca_upd20140926c.zip - Part 2
I still haven't reviewed your latest update. That is next. My apologies ...
Greg Shah
04:32 PM User Interface Feature #2252: implement GUI client support
> In the context of #2388 I checked the current state of output redirection logic and it seems to be far away from th... Greg Shah
04:20 PM User Interface Feature #2252: implement GUI client support
In the context of #2388 I checked the current state of output redirection logic and it seems to be far away from the ... Hynek Cihlar
02:22 PM User Interface Feature #2252: implement GUI client support
Greg Shah wrote:
> 1. Why not sync the server state on the next trip down to the client, instead of waiting for a @p...
Constantin Asofiei
01:41 PM User Interface Feature #2252: implement GUI client support
Code Review ca_upd20140926c.zip - Part 1
I'm half-way through the review of your previous update. I haven't looke...
Greg Shah
12:51 PM User Interface Feature #2252: implement GUI client support
This update contains some fixes and the AspectJ changes related to optimizing the computation of widget config update... Constantin Asofiei
11:48 AM User Interface Feature #2252: implement GUI client support
Constantin Asofiei wrote:
> Vadim, there is this code in OutputManager.setInvalidate which breaks the GUI window cre...
Vadim Gindin
11:19 AM User Interface Feature #2252: implement GUI client support
I found the same problem.
I fixed this problem in my current task by creating a method @SwingGuiPrimitives#hasWindow...
Marius Gligor
10:55 AM User Interface Feature #2252: implement GUI client support
Vadim, there is this code in OutputManager.setInvalidate which breaks the GUI window creation:... Constantin Asofiei
05:25 AM User Interface Feature #2252: implement GUI client support
This entry contains details for #2254
New configuration manager
------------------------------------
The new Con...
Constantin Asofiei
02:33 PM User Interface Feature #1791: implement dynamic UI support
Greg/Eugenie: first of all, a trigger can't be registered with a handle which is not valid. The widget (dynamic or n... Constantin Asofiei
01:50 PM User Interface Feature #1791: implement dynamic UI support
> But imagine the case when dynamic widget creation is the result of user(or application logic) intervention. For exa... Greg Shah
01:16 PM User Interface Feature #1791: implement dynamic UI support
>We don't want to change how the client works. The client has no knowledge of handles. And to know when to fire a tri... Eugenie Lyzenko
08:55 AM User Interface Feature #1791: implement dynamic UI support
> So the triggers should be attached to the handle itself, not to the widget object(which might be not yet created). ... Greg Shah
07:52 AM User Interface Feature #1791: implement dynamic UI support
Triggering issue to discuss.
The problem I'm currently work with is related to the triggers identification for dyn...
Eugenie Lyzenko
11:32 AM Database Feature #2220: dynamic query methods which require implementation
About off-end after reposition. It may have a quirky state. As far as I've checked the rules are following:
# off-en...
Stanislav Lomany
 

Also available in: Atom