Activity
From 02/06/2015 to 03/07/2015
03/08/2015
- 07:40 PM User Interface Feature #2480: add support for button and image attributes and options
- The testing completed, no regressions. The results: @10794_5c96d7c_20150307_evl.zip@.
Looks like I have to re-run ...
03/07/2015
- 01:51 PM User Interface Feature #2480: add support for button and image attributes and options
- Merge with 10796 code base.
- 08:46 PM User Interface Feature #2480: add support for button and image attributes and options
- The conversion testing completed. Generated codes are identical, no regressions. Starting runtime testing.
- 03:51 AM User Interface Bug #2520: Dynamic list controls are not visible
- Fixed. Started regression test
- 03:36 AM User Interface Feature #2508: test LIST-ITEMS support in P2J and confirm that it is complete, add or fix feature...
- Passed runtime regression testing and checked in as bzr rev 10796.
03/06/2015
- 05:56 PM Database Bug #2488: replace runtime compilation of dynamic queries
- Code review 0306a:
Looks good. I'll run tests with this update and let you know how it goes. - 01:31 PM Database Bug #2488: replace runtime compilation of dynamic queries
- The strings literals are generated as ready-to-be-written to java source files and the escape sequences must be proce...
- 04:46 PM User Interface Feature #2480: add support for button and image attributes and options
- Eugenie Lyzenko wrote:
> >Eugenie, do you know where the clipping rectangle is first calculated wrong? If not, can y... - 04:15 PM User Interface Feature #2480: add support for button and image attributes and options
- >I have no objections to this.
OK. I'm starting the conversion and runtime testing. - 04:01 PM User Interface Feature #2480: add support for button and image attributes and options
- >Eugenie, do you know where the clipping rectangle is first calculated wrong? If not, can you trace it down? Also, is...
- 02:20 PM User Interface Feature #2480: add support for button and image attributes and options
- Greg Shah wrote:
> > One consideration about clipping. The feature is now working for button widget but I think it h... - 02:05 PM User Interface Feature #2480: add support for button and image attributes and options
- > One consideration about clipping. The feature is now working for button widget but I think it has an issue. If usin...
- 02:04 PM User Interface Feature #2480: add support for button and image attributes and options
- Code Review evl_upd20150306a.zip
I'm fine with the changes. - 12:32 PM User Interface Feature #2480: add support for button and image attributes and options
- This update for review has completed runtime implementation for @NO-FOCUS@/@FLAT-BUTTON@ client part plus fixed newly...
- 03:45 PM User Interface Feature #2508: test LIST-ITEMS support in P2J and confirm that it is complete, add or fix feature...
- After 3 runs the following 2 tests failed (in addition to the expected tc_job_002):...
- 03:00 PM User Interface Feature #1790: implement menu support
- Code Review vig_upd20150306a.zip
This is a good step forward.
1. It seems like there should be shared code betw... - 02:16 PM User Interface Feature #1790: implement menu support
- > When I'm pressing '->' in MENUBAR first menu-item (sub-menu) is blended when loosing focus. There are several calls...
- 10:37 AM User Interface Feature #1790: implement menu support
- It seems I will not make working version until today. Here is my current update with the following changes.
* Focus ... - 02:40 PM User Interface Feature #2422: add features to BROWSE
- One regression test has failed: @P2JQuery.bufferHandle()@ returns invalid handle. Looking into it.
- 08:46 AM User Interface Feature #2422: add features to BROWSE
- Code Review svl_upd20150305a.zip
I'm OK with the changes.
Eric: please review the @QueryWrapper@ change. - 02:59 AM User Interface Feature #2422: add features to BROWSE
- Update for review. Fixes minor issues.
- 11:44 AM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
- NUM-ITEMS runtime support (combo-box and selection-list)
INNER-LINES runtime setter attribute unknown behavior shoul... - 09:38 AM User Interface Feature #2534 (Closed): methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
- 08:46 AM User Interface Bug #2520: Dynamic list controls are not visible
- It seems that I've resolved the issue (with one-line fix). Will start regression testing after the one for #2508 will...
03/05/2015
- 03:50 PM User Interface Feature #2508: test LIST-ITEMS support in P2J and confirm that it is complete, add or fix feature...
- Code Review ias_upd20150305a.zip
I'm good with the changes. - 03:30 PM User Interface Feature #2508: test LIST-ITEMS support in P2J and confirm that it is complete, add or fix feature...
- NPE was a result of my bug. To fix the cursor issue it was sufficient to hide cursor on SELECTION-LIST focus gain (an...
- 09:02 AM User Interface Feature #2508: test LIST-ITEMS support in P2J and confirm that it is complete, add or fix feature...
- OK, please do fix these as part of this task.
- 09:00 AM User Interface Feature #2508: test LIST-ITEMS support in P2J and confirm that it is complete, add or fix feature...
- Greg Shah wrote:
> Are these bugs specific to your change or are they already existing in P2J?
These bugs are not... - 08:57 AM User Interface Feature #2508: test LIST-ITEMS support in P2J and confirm that it is complete, add or fix feature...
- Are these bugs specific to your change or are they already existing in P2J?
- 08:56 AM User Interface Feature #2508: test LIST-ITEMS support in P2J and confirm that it is complete, add or fix feature...
- Found at least two bugs.
1. When there are several widgets in a frame the cursor position doesn't change when switch...
03/04/2015
- 04:26 PM User Interface Feature #2487: implement READ-FILE() and SAVE-FILE() methods in the editor widget
- > 1) take big file (much more then limit). And time to load this file will be much bigger then time to read file just...
- 04:24 PM User Interface Feature #2487: implement READ-FILE() and SAVE-FILE() methods in the editor widget
- Code Review evk_upd20150301a.zip
1. Please name @LogicalTerminal.writeFile()@ as @LogicalTerminal.saveFile()@ to b... - 03:58 PM User Interface Feature #2487: implement READ-FILE() and SAVE-FILE() methods in the editor widget
- > Also I need to set modified flag. But didn't find good place to do it. Where I can have access to this flag ?
Se... - 08:08 PM User Interface Feature #2487: implement READ-FILE() and SAVE-FILE() methods in the editor widget
- 1) Added error handling and file stream close
4GL writes data into file till IO error. But for read operation 4gl re... - 03:17 PM User Interface Feature #2508: test LIST-ITEMS support in P2J and confirm that it is complete, add or fix feature...
- Merged with revno 10793. Tested. The selection list behavior on gain/loose focus has to be fixed.
- 11:43 AM User Interface Feature #2498 (Closed): implement ADD-LAST() method
- 11:08 AM User Interface Feature #2498: implement ADD-LAST() method
- Passed runtime regression testing and checked in as bzr rev 10793.
- 11:08 AM User Interface Feature #2498: implement ADD-LAST() method
- After updating majic_baseline @tc_po_item_003@ and @tc_po_item_004@. Majic rebuild passed OK.
- 08:49 AM User Interface Feature #2498: implement ADD-LAST() method
- Greg Shah wrote:
> Don't worry about the ctrl-c tests. The 3-way tests are known to fail and so long as all of them... - 08:41 AM User Interface Feature #2498: implement ADD-LAST() method
- Don't worry about the ctrl-c tests. The 3-way tests are known to fail and so long as all of them don't fail on all r...
- 05:24 AM User Interface Feature #2498: implement ADD-LAST() method
- Constantin Asofiei wrote:
> With rev 10787 there were baseline changes. You should reconfigure your setup or do a ... - 05:17 AM User Interface Feature #2498: implement ADD-LAST() method
- Igor Skornyakov wrote:
> @gso_ctrlc_3way_tests@ restarted. I've extracted @tc_po_item_003@ and @tc_po_item_004@ and ... - 05:08 AM User Interface Feature #2498: implement ADD-LAST() method
- In a third run all @gso_ctrlc_3way_tests@ failed. @tc_job_clock_004@ passed. I've also noticed that the following te...
- 06:45 AM Database Bug #2524: missing support for NEXT-SIBLING attribute for buffer handles
- Ovidiu Maxiniuc wrote:
> Constantin Asofiei wrote:
> > Ovidiu, about HandleChain changes: the buffer-specific code ... - 05:43 AM Database Bug #2524: missing support for NEXT-SIBLING attribute for buffer handles
- Constantin Asofiei wrote:
> Ovidiu, about HandleChain changes: the buffer-specific code I think should reside in ove... - 05:37 AM Database Bug #2524: missing support for NEXT-SIBLING attribute for buffer handles
- Ovidiu, about HandleChain changes: the buffer-specific code I think should reside in overridden methods in the Buffer...
- 05:17 AM Database Bug #2524: missing support for NEXT-SIBLING attribute for buffer handles
- Eric Faulhaber wrote:
> Ovidiu: please rename the testcase to something more descriptive (you can keep "2524" as par... - 09:33 PM User Interface Feature #2480: add support for button and image attributes and options
- This update for review contains runtime implementation for @NO-FOCUS@/@FLAT-BUTTON@. It is required to do more testin...
03/03/2015
- 05:28 PM Database Bug #2524: missing support for NEXT-SIBLING attribute for buffer handles
- One more thing: please make the @BufferImpl@ constructor you added @protected@ instead of @public@. As an implementat...
- 03:29 PM Database Bug #2524: missing support for NEXT-SIBLING attribute for buffer handles
- Code review 0303c:
You added a call to @release()@ at @TemporaryBuffer@:3411, which seems unrelated to the remaini... - 12:26 PM Database Bug #2524: missing support for NEXT-SIBLING attribute for buffer handles
- The attached update fixes the management of dynamic buffer handles.
- 05:18 PM User Interface Feature #2498: implement ADD-LAST() method
- The following tests failed identically in two runs:...
- 09:43 AM User Interface Feature #2498: implement ADD-LAST() method
- Greg Shah wrote:
> I think @unwrapControlEntity()@ should be removed from @handle@. Rebuilding MAJIC will confirm... - 09:37 AM User Interface Feature #2498: implement ADD-LAST() method
- Code Review ias_upd20150303c.zip
I think @unwrapControlEntity()@ should be removed from @handle@. Rebuilding MAJI... - 07:30 AM User Interface Feature #2498: implement ADD-LAST() method
- The problem was with @ScrollConatiner.ensureVisibility()@: I've reimplemented it to achieve the correct behavior for ...
- 02:50 PM User Interface Feature #2422: add features to BROWSE
- svl_upd20150302a was committed to bzr revision 10792.
- 02:25 PM User Interface Feature #2422: add features to BROWSE
- OK, my bad. I misread your post. The last record to the top of the browse IS CORRECT. In this case my update works pr...
- 01:28 PM User Interface Feature #2422: add features to BROWSE
- Correct or not, it's what Progress 9.1 did with the AOG Browse screen. It was quite strange. I've never recreated it ...
- 01:23 PM User Interface Feature #2422: add features to BROWSE
- Eric, are you sure that scrolling to the last row (and making it the scroll row) is not a correct behavior?
- 09:50 AM User Interface Feature #2422: add features to BROWSE
- AOG Browse fails. Reverting the code in AdaptiveQuery doesn't fix the issue. I'll look into that.
- 09:31 AM User Interface Feature #2422: add features to BROWSE
- @Cursor@:297 looks a little different to me. Have you confirmed the described behavior with the AOG Browse has not be...
- 03:47 AM User Interface Feature #2422: add features to BROWSE
- Eric, in this file there is also updated history entry which says ...
- 09:29 PM User Interface Feature #2422: add features to BROWSE
- Greg Shah wrote:
> Code Review svl_upd20150302a.zip
>
> I'm OK with the changes.
>
> Eric: please review the @... - 11:55 AM Database Bug #2533 (WIP): management of dynamic buffer handles
03/02/2015
- 05:11 PM User Interface Feature #2422: add features to BROWSE
- Code Review svl_upd20150302a.zip
I'm OK with the changes.
Eric: please review the @AdaptiveQuery@ change. - 05:05 PM User Interface Feature #2422: add features to BROWSE
- Passed regression testing, so I can check it in just after review.
- 03:47 PM User Interface Feature #2422: add features to BROWSE
- Update for review with fixes for RFQ tests. Regression testing is running.
- 04:44 PM User Interface Feature #2498: implement ADD-LAST() method
- Just a note. If the screen size is ~ 132x43 then the failing screen with and without my changes look identical (manua...
- 11:21 AM User Interface Feature #2498: implement ADD-LAST() method
- Greg Shah wrote:
> Remove your update and manually test again to determine if it is your update that causes this. I... - 11:15 AM User Interface Feature #2498: implement ADD-LAST() method
- Remove your update and manually test again to determine if it is your update that causes this. I guess it is so, unl...
- 11:14 AM User Interface Feature #2498: implement ADD-LAST() method
- Constantin Asofiei wrote:
> Igor, is your terminal set to 80 cols by 24 rows? MAJIC layout will not be correct if th... - 11:08 AM User Interface Feature #2498: implement ADD-LAST() method
- Igor, is your terminal set to 80 cols by 24 rows? MAJIC layout will not be correct if the terminal is not set like this.
- 11:07 AM User Interface Feature #2498: implement ADD-LAST() method
- Hynek Cihlar wrote:
> Igor if haven't already, try to run the test manually. That is, start the client, login, and f... - 08:34 AM User Interface Feature #2498: implement ADD-LAST() method
- Igor Skornyakov wrote:
> I've added a delay to gso_301 (more presisely, to @common/find_rfq_so_8000356.xml@), but th... - 08:27 AM User Interface Feature #2498: implement ADD-LAST() method
- Constantin Asofiei wrote:
> Greg Shah wrote:
> > Has anyone seen this kind of failure in the RFQ tests? Could we h... - 02:24 PM User Interface Feature #2334 (Closed): implement the GUI message line widget
- 11:30 AM User Interface Bug #2528: finish investigation and implemention of INPUT, SCREEN-VALUE and INPUT-VALUE
- This task is meant to complete the implementation of the INPUT, SCREEN-VALUE and INPUT-VALUE.
Some initial finding... - 11:22 AM User Interface Bug #2528 (New): finish investigation and implemention of INPUT, SCREEN-VALUE and INPUT-VALUE
- 11:15 AM Base Language Bug #2527: after ENDKEY (F4) the server-side screen buffer needs to be updated
- An ENDKEY condition generated by i.e. F4 while an update is in progress will update the SCREEN-VALUE and INPUT functi...
- 11:09 AM Base Language Bug #2527 (New): after ENDKEY (F4) the server-side screen buffer needs to be updated
- 09:20 PM User Interface Feature #2487: implement READ-FILE() and SAVE-FILE() methods in the editor widget
- Interesting. These sound pretty easy for us to implement.
> maximum stored data depends on @INNER-CHARS@ paramete... - 07:11 PM User Interface Feature #2487: implement READ-FILE() and SAVE-FILE() methods in the editor widget
- 1) If some IO error while reading/writing, then it read or wrote data can be used, but status of operation will be "n...
02/27/2015
- 05:18 PM User Interface Feature #2480: add support for button and image attributes and options
- The update contains conversion support and runtime start point starting point for @NO-FOCUS@ and @FLAT-BUTTON@ option...
- 02:21 PM User Interface Feature #2498: implement ADD-LAST() method
- No, let it finish.
- 01:41 PM User Interface Feature #2498: implement ADD-LAST() method
- Greg Shah wrote:
> Igor: do you have any other problems to solve or is this it?
No. I do not have any new problem... - 01:37 PM User Interface Feature #2498: implement ADD-LAST() method
- Igor: do you have any other problems to solve or is this it?
Constantin, Hynek, Eric and I all have quite a few ch... - 01:11 PM User Interface Feature #2498: implement ADD-LAST() method
- Greg Shah wrote:
> Has anyone seen this kind of failure in the RFQ tests? Could we have checked something in that ha... - 01:03 PM User Interface Feature #2498: implement ADD-LAST() method
- Has anyone seen this kind of failure in the RFQ tests? Could we have checked something in that has broken RFQ?
- 11:45 AM User Interface Feature #2498: implement ADD-LAST() method
- Both gsO301 and gso_308 failed at the same screen. As far as I understand the code for this screen is in @syman/so/se...
- 07:18 AM User Interface Feature #2498: implement ADD-LAST() method
- After fixes only the following tests failed in two runs:
3 gso_301: failure in step 6: 'timeout before the spec... - 08:37 AM Database Bug #2526: Records preserving its position in the sorting index for adaptive query
- As for initial analysis: currently we use record snapshots as the base to find the next record in the index using an ...
- 08:28 AM Database Bug #2526: Records preserving its position in the sorting index for adaptive query
- This problem was noticed in an editable browse which easily exposes this bug. Assigning a value to a field of the ind...
- 08:17 AM Database Bug #2526 (New): Records preserving its position in the sorting index for adaptive query
- 07:41 AM User Interface Feature #2525: Runtime support of frame positional attributes
- The objective of this issue is to implement support of missing parts of frame positional attributes. Also to make sur...
- 07:23 AM User Interface Feature #2525 (New): Runtime support of frame positional attributes
02/26/2015
- 04:07 PM User Interface Feature #2479 (Closed): DEFINE IMAGE and image phrase support for both button and image
- 03:38 PM User Interface Feature #2479: DEFINE IMAGE and image phrase support for both button and image
- The update @evl_upd20150225b.zip@ has been committed in bzr as 10780.
- 03:20 PM User Interface Feature #2479: DEFINE IMAGE and image phrase support for both button and image
- Yes, please check it in.
- 03:14 PM User Interface Feature #2479: DEFINE IMAGE and image phrase support for both button and image
- Testing completed. The results file: @10778_5c96d7c_20150226_evl.zip@.
So the update is ready to be committed and ... - 11:47 AM User Interface Feature #2479: DEFINE IMAGE and image phrase support for both button and image
- The main part of the regression tests completed OK. Waiting for CTRL-C to be done.
- 07:48 PM User Interface Feature #2479: DEFINE IMAGE and image phrase support for both button and image
- The conversion testing completed. Codes are identical, no regression. Continue with the runtime testing.
- 12:49 PM Database Bug #2488: replace runtime compilation of dynamic queries
- I found a test case that fails to convert properly....
- 12:25 PM User Interface Feature #2422: add features to BROWSE
- Stanislav Lomany wrote:
> After my recent minor changes RFQ tests started to fail. I'm looking into that.
I would... - 12:15 PM User Interface Feature #2422: add features to BROWSE
- After my recent minor changes RFQ tests started to fail. I'm looking into that.
- 12:09 PM User Interface Feature #2422: add features to BROWSE
- The persistence changes in 0225a look OK to me.
- 09:38 AM User Interface Feature #2422: add features to BROWSE
- Code Review svl_upd20150225a.zip
I'm fine with the changes. I looked at everything pretty carefully, except @Brow... - 10:18 AM User Interface Feature #1790: implement menu support
- Yes, that was the reason.. Sorry for trouble.
- 10:03 AM User Interface Feature #1790: implement menu support
- Mistake..
Here is the place in @ThinClient.waitFor@ where immedExit is set to true:... - 09:59 AM User Interface Feature #1790: implement menu support
- I found that during processing of @ThinClient.waitFor@ the flag @immedExit@ is set to true. It probably a reason.. It...
- 09:51 AM User Interface Feature #1790: implement menu support
- I'm stuck... I can't make menu events working. I don't fully understand how events queue works. Here are the followin...
- 06:30 AM User Interface Feature #2508: test LIST-ITEMS support in P2J and confirm that it is complete, add or fix feature...
- Code Review ias_upd20150225a.zip
1. The update should only contain files that were modified for this task. As far...
02/25/2015
- 03:58 PM User Interface Feature #2479: DEFINE IMAGE and image phrase support for both button and image
- > Eugenie: please confirm that it is not needed. If so, please remove it. Then go ahead with both conversion and ru...
- 03:52 PM User Interface Feature #2479: DEFINE IMAGE and image phrase support for both button and image
- > the call to @setPhysicalLocation@ in @IGI.initialize@ should be unnecessary as you already set the physical locatio...
- 03:36 PM User Interface Feature #2479: DEFINE IMAGE and image phrase support for both button and image
- Greg Shah wrote:
> Code Review evl_upd20150225a.zip
>
> I'm fine with the changes.
>
> Hynek: please look at t... - 02:11 PM User Interface Feature #2479: DEFINE IMAGE and image phrase support for both button and image
- Code Review evl_upd20150225a.zip
I'm fine with the changes.
Hynek: please look at the @BaseConfig@ change and c... - 12:07 PM User Interface Feature #2479: DEFINE IMAGE and image phrase support for both button and image
- This update for review has general fix for dynamic widget location issue. All processing shifted to @BaseConfig.apply...
- 09:33 AM User Interface Feature #2479: DEFINE IMAGE and image phrase support for both button and image
- Greg Shah wrote:
> Code Review evl_upd20150224a.zip
>
> Are @ButtonGuiImpl.draw()@ and @ImageGuiImpl.draw()@ real... - 09:17 AM User Interface Feature #2479: DEFINE IMAGE and image phrase support for both button and image
- Eugenie Lyzenko wrote:
> One more possible TODO change is rework for image phrase setters for button related images ... - 09:16 AM User Interface Feature #2479: DEFINE IMAGE and image phrase support for both button and image
- One more possible TODO change is rework for image phrase setters for button related images we have discussed previous...
- 09:05 AM User Interface Feature #2479: DEFINE IMAGE and image phrase support for both button and image
- Code Review evl_upd20150224a.zip
Are @ButtonGuiImpl.draw()@ and @ImageGuiImpl.draw()@ really the proper locations ... - 08:53 AM User Interface Feature #2479: DEFINE IMAGE and image phrase support for both button and image
- Eugenie Lyzenko wrote:
> The only thing I see is to unify @CONVERT-3D-COLORS@ attribute for button and image widgets... - 08:51 AM User Interface Feature #2479: DEFINE IMAGE and image phrase support for both button and image
- The only thing I see is to unify @CONVERT-3D-COLORS@ attribute for button and image widgets. Currently button has @NO...
- 03:53 PM Database Bug #2524: missing support for NEXT-SIBLING attribute for buffer handles
- The reference pdf states that the SESSION:FIRST-BUFFER is the head of the linked list of _"handles for the dynamic bu...
- 03:09 PM User Interface Feature #2508: test LIST-ITEMS support in P2J and confirm that it is complete, add or fix feature...
- Finished adding DELIMITER attribute support and fixing LIST-ITEMS and LIST-ITEM-PAIRS logic. Testing is still require...
- 02:32 PM User Interface Feature #2508: test LIST-ITEMS support in P2J and confirm that it is complete, add or fix feature...
- Greg Shah wrote:
> Progress is full of these insane "quirks". In these cases we try to leave careful comments and j... - 02:19 PM User Interface Feature #2508: test LIST-ITEMS support in P2J and confirm that it is complete, add or fix feature...
- Progress is full of these insane "quirks". In these cases we try to leave careful comments and javadoc to explain th...
- 02:15 PM User Interface Feature #2508: test LIST-ITEMS support in P2J and confirm that it is complete, add or fix feature...
- Greg Shah wrote:
> Are you saying that the 4GL reacts differently in these two situations?
Yes, it does.
> If so... - 02:02 PM User Interface Feature #2508: test LIST-ITEMS support in P2J and confirm that it is complete, add or fix feature...
- Are you saying that the 4GL reacts differently in these two situations?
Unknown literal:... - 12:47 PM User Interface Feature #2508: test LIST-ITEMS support in P2J and confirm that it is complete, add or fix feature...
- I've discovered a strange behavior: for the COMBO-BOX and SELECTION-LIST @ADD-LAST(..., ?)@ is rejected but the code
... - 01:58 PM User Interface Feature #2498: implement ADD-LAST() method
- Greg Shah wrote:
> OK, this makes sense. As you move forward, do keep in mind that you will likely need to merge yo... - 11:58 AM User Interface Feature #2498: implement ADD-LAST() method
- OK, this makes sense. As you move forward, do keep in mind that you will likely need to merge your code up to newer ...
- 11:35 AM User Interface Feature #2498: implement ADD-LAST() method
- Adding separate height/width fields doesn't help. Starting a detailed investigation. In particular I can see the the ...
- 09:08 AM User Interface Feature #2478 (Closed): button image support
- 09:07 AM User Interface Feature #2476 (Closed): window icon support improvements
- 08:55 AM User Interface Feature #2480: add support for button and image attributes and options
- The following attributes/options are left to b implemented/verified as working if already implemented:
+Button opt... - 05:53 AM User Interface Feature #2422: add features to BROWSE
- Major browse update for review. Changed caching logic in order to match 4GL.
02/24/2015
- 06:33 PM User Interface Feature #2479: DEFINE IMAGE and image phrase support for both button and image
- This update for review merges the recent code base plus fixes the location issue for dynamic images and buttons. The ...
- 03:14 PM Database Bug #2524 (WIP): missing support for NEXT-SIBLING attribute for buffer handles
- 03:11 PM Database Bug #2524: missing support for NEXT-SIBLING attribute for buffer handles
- I noticed the following message printed in the app-server 'client' log after each executed request....
- 02:44 PM Database Bug #2524 (Closed): missing support for NEXT-SIBLING attribute for buffer handles
02/23/2015
- 03:08 PM User Interface Feature #2508: test LIST-ITEMS support in P2J and confirm that it is complete, add or fix feature...
- The version on lindev01 is 10.2B and has not been changed since it was installed in early 2013. I access it via /usr...
- 02:34 PM User Interface Feature #2508: test LIST-ITEMS support in P2J and confirm that it is complete, add or fix feature...
- RADIO-BUTTONS attribute for the RADIO-SET widget behaves like LIST-ITEM-PAIRS for the SELECTION-LIST.
Conclusion:
... - 10:38 AM User Interface Feature #2508: test LIST-ITEMS support in P2J and confirm that it is complete, add or fix feature...
- 1. We need to add support for the DELIMITER attribute
2. DELIMITER attribute value cannot be "unknown", but can be "... - 02:41 PM User Interface Feature #2498: implement ADD-LAST() method
- Greg Shah wrote:
> Although it seems unlikely that the problems are caused by your update, it is very unusual for th... - 11:30 AM User Interface Feature #2498: implement ADD-LAST() method
- Although it seems unlikely that the problems are caused by your update, it is very unusual for the same list of tests...
- 09:14 AM User Interface Feature #2498: implement ADD-LAST() method
- Greg,
Can I commit my changes?
Thank you. - 01:29 PM User Interface Feature #2479: DEFINE IMAGE and image phrase support for both button and image
- > Normally, I would ask you to get these tested, but Igor has overlapping changes being tested in #2498 and he has ha...
- 01:07 PM User Interface Feature #2479: DEFINE IMAGE and image phrase support for both button and image
- Code Review evl_upd20150223a.zip
The changes look good.
Normally, I would ask you to get these tested, but Igor... - 12:39 PM User Interface Feature #2479: DEFINE IMAGE and image phrase support for both button and image
- Sorry the update @0223a@ was inconsistent(has not final versions). Please see the new drop.
- 12:20 PM User Interface Feature #2479: DEFINE IMAGE and image phrase support for both button and image
- This update for review adds boolean attributes setters/getters outside of the @DEFINE IMAGE@ or @DEFINE BUTTON@ state...
- 07:19 AM User Interface Feature #2479: DEFINE IMAGE and image phrase support for both button and image
- The remaining thing I'm going to implement is having getters/setters for all attributes in image and button widgets t...
- 12:02 PM User Interface Feature #1790: implement menu support
- >> At this point are ChUI menus fully functional?
>
> No. I can't finish client-side part because of event-processi... - 10:07 AM User Interface Feature #1790: implement menu support
- You're right. Some of noted points are not implemented. See below
Greg Shah wrote:
> At this point are ChUI menus...
02/22/2015
- 04:05 PM User Interface Feature #2479: DEFINE IMAGE and image phrase support for both button and image
- Greg Shah wrote:
> Yes, go ahead and commit it.
Committed in bzr as 10771. - 03:32 PM User Interface Feature #2479: DEFINE IMAGE and image phrase support for both button and image
- Yes, go ahead and commit it.
- 02:53 PM User Interface Feature #2479: DEFINE IMAGE and image phrase support for both button and image
- The conversion testing completed, generated codes are identical. No regressions.
So the update is ready to be comm... - 07:03 AM User Interface Feature #2479: DEFINE IMAGE and image phrase support for both button and image
- The update fixes the size/location regression for images used to draw the buttons. Plus slightly enhanced icon detect...
- 08:01 AM User Interface Feature #2498: implement ADD-LAST() method
- Attached detailed reports for failed tests.
- 05:44 AM User Interface Feature #2498: implement ADD-LAST() method
- There where 3 runs of the regression test.
The following test failed in in all 3 runs:
gso_tests
57 gso_187: fa...
02/20/2015
- 06:10 PM User Interface Feature #2513: implement GUI runtime support for TOGGLE-BOX
- Here is the next update containing basic GUI implementation.
Questions:
1. When I'm going between checkboxes I've... - 05:25 PM User Interface Feature #2523: implement GUI radio-set widget
- The core widget implementation for GUI must be created including drawing and event processing. Mouse support must wo...
- 05:23 PM User Interface Feature #2523 (Closed): implement GUI radio-set widget
- 05:22 PM User Interface Feature #2522: add attribute/method support for radio-set
- Implement conversion and runtime support for the following:
+Attributes+
NUM-BUTTONS
+Methods+
DISABLE()
... - 05:21 PM User Interface Feature #2522 (Closed): add attribute/method support for radio-set
- 05:21 PM User Interface Feature #2479: DEFINE IMAGE and image phrase support for both button and image
- >Please do fix both of these issues (character unit mismatches and the regression for IMAGE-SIZE options) as part of ...
- 05:00 PM User Interface Feature #2479: DEFINE IMAGE and image phrase support for both button and image
- Eugenie Lyzenko wrote:
> >Have you run your testcases in both windev01 and in P2J? Does our implementation match exa... - 04:59 PM User Interface Feature #2479: DEFINE IMAGE and image phrase support for both button and image
- > I've changed the rule file and want to make sure there will be no regression her. Is it OK?
Good point. Yes, c... - 04:57 PM User Interface Feature #2479: DEFINE IMAGE and image phrase support for both button and image
- >Have you run your testcases in both windev01 and in P2J? Does our implementation match exactly?
Yes, I'm comparin... - 04:41 PM User Interface Feature #2479: DEFINE IMAGE and image phrase support for both button and image
- >OK. I don't think this needs full runtime testing. The GUI stuff won't get loaded in MAJIC testing. Even the server-...
- 04:34 PM User Interface Feature #2479: DEFINE IMAGE and image phrase support for both button and image
- Have you run your testcases in both windev01 and in P2J? Does our implementation match exactly?
- 04:32 PM User Interface Feature #2479: DEFINE IMAGE and image phrase support for both button and image
- OK. I don't think this needs full runtime testing. The GUI stuff won't get loaded in MAJIC testing. Even the serve...
- 04:06 PM User Interface Feature #2479: DEFINE IMAGE and image phrase support for both button and image
- >1. In Convert3DColorsFilter, are the input colors to be converted really hard coded in the 4GL?
I think so, from ... - 03:52 PM User Interface Feature #2479: DEFINE IMAGE and image phrase support for both button and image
- Code Review evl_upd20150220a.zip
1. In @Convert3DColorsFilter@, are the input colors to be converted really hard c... - 03:40 PM User Interface Feature #2479: DEFINE IMAGE and image phrase support for both button and image
- This updates for review includes runtime implementation of the @CONVERT-3D-COLORS@ option for image and button widget...
- 02:22 PM User Interface Feature #2479: DEFINE IMAGE and image phrase support for both button and image
- Code Review evl_upd20150219a.zip
It is good. - 08:01 PM User Interface Feature #2479: DEFINE IMAGE and image phrase support for both button and image
- This update adds conversion rule change to support @RETAIN-SHAPE@ sub-option and runtime implementation for @STRETCH-...
- 05:20 PM User Interface Feature #2521 (Closed): enhance/implement radio-set for GUI
- 02:31 PM User Interface Feature #2508: test LIST-ITEMS support in P2J and confirm that it is complete, add or fix feature...
- Yes, I think you are right. Please test and fix any issues related to those.
Another thing: please test these bot... - 02:26 PM User Interface Feature #2508: test LIST-ITEMS support in P2J and confirm that it is complete, add or fix feature...
- I understand the LIST-ITEM-PAIRS and RADIO-BUTTONS attributes are in the scope of this task as well. Is that correct?
- 02:16 PM User Interface Feature #1790: implement menu support
- At this point are ChUI menus fully functional?
Is there any error handling, event or other missing functionality? ... - 01:56 PM User Interface Feature #1790: implement menu support
- Javadoc fix.
Remaining features needing to be implemented is empty at this moment. Probably some features will be ... - 01:22 PM User Interface Feature #1790: implement menu support
- Please post a list of the remaining features needing to be implemented, enhanced and/or bugs needing fixing. You can...
- 01:21 PM User Interface Feature #1790: implement menu support
- In your next update, please resolve these:...
- 01:02 PM User Interface Feature #1790: implement menu support
- Current update has passed full testing and committed to rev #10766.
- 12:26 PM User Interface Feature #1790: implement menu support
- OK, you can commit vig_upd20150220a.zip.
- 12:12 PM User Interface Feature #1790: implement menu support
- Here is merged current update with the latest revision.
- 12:06 PM User Interface Feature #1790: implement menu support
- > I suspect that this error is not related with my update. Don't you know why it happens?
We don't know for sure. ... - 11:02 AM User Interface Feature #1790: implement menu support
- I've ran regression testing 3rd time. And the test @tc_codes_employees_20@ has passed. So, we can assume that update ...
- 03:28 AM User Interface Feature #1790: implement menu support
- Current update has passed conversion testing. I ran regression testing twice. Only one test has failed during both ru...
- 02:00 PM User Interface Feature #2498: implement ADD-LAST() method
- Code Review ias_upd20150220c.zip
It looks good. - 01:50 PM User Interface Feature #2498: implement ADD-LAST() method
- Greg Shah wrote:
> There is about to be a check in from #1790. When that occurs, please merge up to the latest bzr ... - 12:47 PM User Interface Feature #2498: implement ADD-LAST() method
- There is about to be a check in from #1790. When that occurs, please merge up to the latest bzr revision and put tha...
- 12:42 PM User Interface Feature #2498: implement ADD-LAST() method
- The following tests failed in both runs:
57 gso_187 GSO 187 - Initial selection on Contact Master returns to main... - 12:00 PM User Interface Feature #2498: implement ADD-LAST() method
- Code Review ias_upd20150220a.zip
The @ScrollDirection@ constructor still needs Javadoc. Obviously, this doesn't i... - 11:57 AM User Interface Feature #2498: implement ADD-LAST() method
- > The ChuiOutputManager sets the value of the cursorInvalid in the at method and doesn't reset it in the append(Strin...
- 03:57 AM User Interface Feature #2498: implement ADD-LAST() method
- Greg Shah wrote:
> Igor: in regard to the scrolling problems, I'd like for you to finish the current task without ad... - 03:41 AM User Interface Feature #2498: implement ADD-LAST() method
- Constantin Asofiei wrote:
> Please add Keyboard.SE_NEXT_FRAME and Keyboard.SE_PREV_FRAME cases to AbstractWidget.ign... - 03:39 AM User Interface Feature #2498: implement ADD-LAST() method
- Greg Shah wrote:
> Code Review ias_upd20150219a.zip
>
> 1. In @RadioButtonImpl.draw()@, why iterate through chara... - 02:34 AM User Interface Feature #2498: implement ADD-LAST() method
- About the NPE in note 73 and the w3.p test. A widget can be determine as no longer alive (thus can be deleted) by bo...
- 02:20 AM User Interface Feature #2498: implement ADD-LAST() method
- Igor Skornyakov wrote:
> 3. After some recent changes (as far as I understand - introducing @manageSystemActions()@ ... - 07:39 PM User Interface Feature #2498: implement ADD-LAST() method
- Code Review ias_upd20150219a.zip
1. In @RadioButtonImpl.draw()@, why iterate through character by character instea... - 07:08 PM User Interface Feature #2498: implement ADD-LAST() method
- Igor: in regard to the scrolling problems, I'd like for you to finish the current task without adding more work to it...
- 07:03 PM User Interface Feature #2498: implement ADD-LAST() method
- Constantin: please comment on note 72 and item 3 in note 85.
- 01:47 PM User Interface Bug #2520: Dynamic list controls are not visible
- Greg Shah wrote:
> Is this still a problem on bzr rev 10766?
Yes, it is.
- 01:38 PM User Interface Bug #2520: Dynamic list controls are not visible
- Is this still a problem on bzr rev 10766?
- 01:37 PM User Interface Bug #2520: Dynamic list controls are not visible
- The dynamic RADIO-SET and COMBO-BOX are not visible, but are "working" - one can make a "blind" selection with the RA...
- 07:47 AM User Interface Bug #2520 (Closed): Dynamic list controls are not visible
- 01:40 PM User Interface Bug #2518: NPE on exit from testcase with mixed usage of static and dynamic widgets
- From CA:
About the NPE in note 73 and the w3.p test. A widget can be determine as no longer alive (thus can be del... - 01:40 PM User Interface Bug #2518: NPE on exit from testcase with mixed usage of static and dynamic widgets
- The attached sample after conversion throws NPE on exit:
[02/17/2015 19:25:51 MSK] (StandardServer.invoke:SEVERE) ... - 07:41 AM User Interface Bug #2518 (New): NPE on exit from testcase with mixed usage of static and dynamic widgets
- 01:39 PM User Interface Bug #2519: suspicious looking scrolling code
- 1. The @ScrollBar.scroll()@ method looks to contain a typo: in line 253 @limit.x@ seems to be instead of @limit.y@
2... - 07:43 AM User Interface Bug #2519 (New): suspicious looking scrolling code
- 01:36 PM User Interface Feature #2487: implement READ-FILE() and SAVE-FILE() methods in the editor widget
- Code Review evk_upd20150218a.zip
It is a good step.
1. @EditorWidget.read/saveFile(character)@ need @null@ and ... - 08:02 PM User Interface Feature #2487: implement READ-FILE() and SAVE-FILE() methods in the editor widget
- Added runtime support. I'm not finished testing at the moment, but common functionality is working.
- 11:25 AM User Interface Feature #2422: add features to BROWSE
- Technically that's not a browse problem, but because of record retrieval logic browse uses, an editable browse easily...
02/19/2015
- 03:04 PM Database Bug #2488: replace runtime compilation of dynamic queries
- Ovidiu Maxiniuc wrote:
> The generated code is unchanged for majic. The attached update passed the conversion test.
... - 12:01 PM Database Bug #2488: replace runtime compilation of dynamic queries
- The generated code is unchanged for majic. The attached update passed the conversion test.
- 09:44 AM Database Bug #2488: replace runtime compilation of dynamic queries
- Eric Faulhaber wrote:
> Where did the need to improve the predicate prep come from? What is the rationale behind the... - 11:18 AM User Interface Feature #2498: implement ADD-LAST() method
- I've finished with scrolling changes. My changes do not affect the @ComboBox@ behavior as this widget doesn't rely on...
- 09:45 AM User Interface Feature #2479: DEFINE IMAGE and image phrase support for both button and image
- Code Review evl_upd20150218a.zip
It looks good.
02/18/2015
- 06:06 PM User Interface Feature #2479: DEFINE IMAGE and image phrase support for both button and image
- This update for your review adds transparency runtime implementation for image widget. Also it prepares other boolean...
- 05:49 PM User Interface Feature #1790: implement menu support
- Code Review vig_upd20150219a.zip
I ma OK with the changes. Please get this update conversion and runtime regressi... - 05:37 PM User Interface Feature #1790: implement menu support
- The next update, containing remarks corrections and overrides bug fix
- 04:01 PM User Interface Feature #1790: implement menu support
- > Don't you remember where that conversion logic?
See the @process_frame@ function in @annotations/frame_scoping.r... - 03:46 PM User Interface Feature #1790: implement menu support
- Greg Shah wrote:
> > Wait a minute. It seems that it is a frames naming (class naming) problem.
>
> This makes se... - 02:52 PM User Interface Feature #1790: implement menu support
- > Wait a minute. It seems that it is a frames naming (class naming) problem.
This makes sense. Please put some pr... - 02:36 PM User Interface Feature #1790: implement menu support
- Greg Shah wrote:
> In the 4GL I suspect that your @DISPLAY@ statements in the triggers are targeting the the default... - 02:21 PM User Interface Feature #1790: implement menu support
- In the 4GL I suspect that your @DISPLAY@ statements in the triggers are targeting the the default "unnamed" frame. S...
- 02:00 PM User Interface Feature #1790: implement menu support
- I'm debugging difficult bug:...
- 05:41 PM User Interface Feature #2487: implement READ-FILE() and SAVE-FILE() methods in the editor widget
- Is there a bug in our implementation of the 4GL built-in function @SEARCH()@ that makes it work differently with file...
- 05:38 PM User Interface Feature #2487: implement READ-FILE() and SAVE-FILE() methods in the editor widget
- Greg Shah wrote:
> I don't think you need to do anything like that. The client-side code would call @FileSystemDaem... - 05:34 PM User Interface Feature #2487: implement READ-FILE() and SAVE-FILE() methods in the editor widget
- I don't think you need to do anything like that. The client-side code would call @FileSystemDaemon.searchPath()@, wh...
- 05:31 PM User Interface Feature #2487: implement READ-FILE() and SAVE-FILE() methods in the editor widget
- Can you suggest what is common "looking" directories in 4gl ? at least common work dir I can take from @Configuration...
- 03:40 PM Database Bug #2488: replace runtime compilation of dynamic queries
- Code review 0218a:
Where did the need to improve the predicate prep come from? What is the rationale behind the cu... - 02:40 PM Database Bug #2488: replace runtime compilation of dynamic queries
- Added support for @LogicalExpression@ anon c'tor.
Refactored some method names to better fit their implementation. - 02:41 PM Database Bug #2514: incorrect return values for get{First|Next|Last|Previous} methods
- This update should fix the return values for respective methods.
- 07:07 AM User Interface Feature #2498: implement ADD-LAST() method
- Hynek Cihlar wrote:
> I think it won't hurt if you start fixing the immediate pains - the unclear model of scroll ... - 07:04 AM User Interface Feature #2498: implement ADD-LAST() method
- Igor Skornyakov wrote:
> I'm not sure that I understand this completely. However it seems that it means that a widge... - 05:03 AM User Interface Feature #2498: implement ADD-LAST() method
- Hynek Cihlar wrote:
> Personally I would rather see the scroll event initiated by the widget receiving focus itsel...
02/17/2015
- 04:28 PM User Interface Feature #2498: implement ADD-LAST() method
- Greg Shah wrote:
> Igor Skornyakov wrote:
> > I see. May I make a suggestion?
> > First of all I think that it is ... - 04:12 PM User Interface Feature #2498: implement ADD-LAST() method
- Igor Skornyakov wrote:
> Greg Shah wrote:
>
> > Please provide more specifics about what needs to be different.
... - 04:07 PM User Interface Feature #2498: implement ADD-LAST() method
- Igor Skornyakov wrote:
> I see. May I make a suggestion?
> First of all I think that it is important for the scroll... - 02:29 PM User Interface Feature #2498: implement ADD-LAST() method
- I see. May I make a suggestion?
First of all I think that it is important for the scroll to be well-defined and idemp... - 02:03 PM User Interface Feature #2498: implement ADD-LAST() method
- Igor Skornyakov wrote:
> Greg Shah wrote:
>
> > Please provide more specifics about what needs to be different.
... - 12:59 PM User Interface Feature #2498: implement ADD-LAST() method
- Greg Shah wrote:
> Please provide more specifics about what needs to be different.
Well, first of all the whole... - 12:42 PM User Interface Feature #2498: implement ADD-LAST() method
- Greg Shah wrote:
> Generally, no it is not OK.
>
> I do see that @RadioButtonImpl.drawButton()@ does not honor th... - 12:40 PM User Interface Feature #2498: implement ADD-LAST() method
- Igor Skornyakov wrote:
> Another note. The look of the RadioSet widget at runtime is different in 4GL and Java: in 4... - 12:34 PM User Interface Feature #2498: implement ADD-LAST() method
- Igor Skornyakov wrote:
> It seems that the @ScrollContainer.ensureVisibility()@ method's implementation is not suita... - 12:33 PM User Interface Feature #2498: implement ADD-LAST() method
- In regard to the NPE, I don't understand why we would be pushing screen definitions to the client during the processi...
- 11:57 AM User Interface Feature #2498: implement ADD-LAST() method
- Another note. The look of the RadioSet widget at runtime is different in 4GL and Java: in 4GL the focused item is hig...
- 11:34 AM User Interface Feature #2498: implement ADD-LAST() method
- It seems that the @ScrollContainer.ensureVisibility()@ method's implementation is not suitable for at least a @RadioS...
- 11:29 AM User Interface Feature #2498: implement ADD-LAST() method
- The sample code is a result of my test evolution - I've added more code while investigating the widget behavior. Plea...
- 10:02 AM User Interface Feature #2498: implement ADD-LAST() method
- The code seems very complicated, with many more frames than I would have expected to be used or needed. Did you get ...
- 04:13 AM User Interface Feature #2498: implement ADD-LAST() method
- Greg Shah wrote:
> 3. About the NPE in @LogicalTerminal.pushScreenDefinition()@, can you show the 4GL code that can ... - 10:44 PM User Interface Feature #2498: implement ADD-LAST() method
- Code Review ias_upd20150216a.zip
1. The @RadioSetInterface@ header should be above the import and package statemen... - 03:34 PM Database Bug #2488: replace runtime compilation of dynamic queries
- Oops, I forgot the update. here it is.
- 03:33 PM Database Bug #2488: replace runtime compilation of dynamic queries
- Changes since 0210a:
* Improved @preparePredicate()@ for OPEN QUERY predicates to
- allow one level nested quotes
- a... - 10:21 PM Database Bug #2488: replace runtime compilation of dynamic queries
- Code review 0210a:
The version of @DynamicQueryHelper@ in the update shows no difference from the latest version i... - 08:55 AM User Interface Feature #2412: Implement widget browser
- Code Review hc_upd20150217b.zip
It looks good. Please check it in. - 04:54 AM User Interface Feature #2412: Implement widget browser
- Missing history entry added and converted tabs to spaces in the whole PropertyTable.java. build.xml removed as this s...
- 10:48 PM User Interface Feature #2412: Implement widget browser
- Code Review hc_upd20150217a.zip
1. @PropertyTable@ needs a history entry. It also needs all of its hard-tab chars... - 08:15 PM User Interface Feature #2412: Implement widget browser
- The attached update extends Widget browser with the possibility to copy widget properties to clipboard. This is usefu...
- 02:06 AM User Interface Feature #2422: add features to BROWSE
- > > But I can handle browsing part because BrowseColumnWidget.setDColor(Color) does the job.
>
> I don't understan... - 10:31 PM User Interface Feature #2422: add features to BROWSE
- > while BrowseColumnWidget.setDColor(NumberType) doesn't actually set a color because ColorSpec.convert() always retu...
02/16/2015
- 03:49 PM User Interface Feature #2498: implement ADD-LAST() method
- Added support for the HORIZONTAL and EXPAND attributes. Still need to fix scrolling behavior.
- 03:32 PM User Interface Feature #2422: add features to BROWSE
- FYI, Majic alters browse column "colors" in two places. E.g.:...
- 09:51 AM User Interface Feature #2479: DEFINE IMAGE and image phrase support for both button and image
- Committed in bzr as 10757.
- 09:38 AM User Interface Feature #2479: DEFINE IMAGE and image phrase support for both button and image
- Check it in.
- 08:51 AM User Interface Feature #2479: DEFINE IMAGE and image phrase support for both button and image
- The runtime testing completed without regressions(separate run for CTRL-C 3 way tests). The results are in @10754_5c9...
02/13/2015
- 02:32 PM Database Bug #2514: incorrect return values for get{First|Next|Last|Previous} methods
- Alternative working form for ...
- 07:46 AM Database Bug #2514: incorrect return values for get{First|Next|Last|Previous} methods
- The set of get{First|Next|Last|Previous} methods should return:
* @?@ (unknown) if the query object handle is invali... - 07:38 AM Database Bug #2514 (Closed): incorrect return values for get{First|Next|Last|Previous} methods
- 12:38 PM User Interface Feature #2479: DEFINE IMAGE and image phrase support for both button and image
- Greg Shah wrote:
> Code Review evl_upd20150212b.zip
>
> It looks good, get it both conversion and runtime regress... - 09:22 AM User Interface Feature #2479: DEFINE IMAGE and image phrase support for both button and image
- Code Review evl_upd20150212b.zip
It looks good, get it both conversion and runtime regression tested. - 10:53 AM User Interface Feature #1790: implement menu support
- Code Review vig_upd20150210a.zip
This is very close.
1. There is a build directory included in your update zip ... - 09:55 AM User Interface Feature #2498: implement ADD-LAST() method
- Code Review ias_upd20150212a.zip
It is very good. Some minor things:
1. Add @RadioSetInterface@ to @HandleComm...
02/12/2015
- 04:42 PM User Interface Feature #2479: DEFINE IMAGE and image phrase support for both button and image
- OK. This update for review changes row/column offsets to double and adjust client side to use new double data.
- 04:10 PM User Interface Feature #2479: DEFINE IMAGE and image phrase support for both button and image
- Eugenie Lyzenko wrote:
> >Instead of having 3 sets of setters, you could have 1 set and generate an enum value that ... - 12:02 PM User Interface Feature #2479: DEFINE IMAGE and image phrase support for both button and image
- >Instead of having 3 sets of setters, you could have 1 set and generate an enum value that distinguishes between @But...
- 07:24 AM User Interface Feature #2479: DEFINE IMAGE and image phrase support for both button and image
- Eugenie Lyzenko wrote:
> >Is there anything left to do for this task?
>
> The following options need to be implem... - 07:24 AM User Interface Feature #2479: DEFINE IMAGE and image phrase support for both button and image
- Code Review evl_upd20150212a.zip
1. All row/col values need to be decimal/double as well. I should have seen thi... - 07:17 AM User Interface Feature #2479: DEFINE IMAGE and image phrase support for both button and image
- Eugenie Lyzenko wrote:
> >2. Although it is probably OK, I find it confusing that the image phrase generates differe... - 07:00 AM User Interface Feature #2479: DEFINE IMAGE and image phrase support for both button and image
- >2. Although it is probably OK, I find it confusing that the image phrase generates different setters for the same op...
- 05:13 AM User Interface Feature #2479: DEFINE IMAGE and image phrase support for both button and image
- >Is there anything left to do for this task?
The following options need to be implemented:
CONVERT-3D-COLORS
STR... - 07:53 PM User Interface Feature #2479: DEFINE IMAGE and image phrase support for both button and image
- Code Review evl_upd20150211b.zip
This is really good.
1. I suspect the @IMAGE-SIZE@/@IMAGE-SIZE-CHARS@ should b... - 03:58 PM User Interface Feature #2513: implement GUI runtime support for TOGGLE-BOX
- That is probably the issue. Try it from the command line.
- 03:25 PM User Interface Feature #2513: implement GUI runtime support for TOGGLE-BOX
- Done. I've uploaded @vig_server_client.zip@ to @/home/vig@
I use Java configuration in Eclipse. - 02:51 PM User Interface Feature #2513: implement GUI runtime support for TOGGLE-BOX
- Please archive your testcases/simple/server, testcases/simple/client folders and upload them to devsrv01.
How do y... - 02:48 PM User Interface Feature #2513: implement GUI runtime support for TOGGLE-BOX
- Constantin Asofiei wrote:
> Vadim Gindin wrote:
> > Thanks. I tried it and got the error:
> > [...]
> Are you usi... - 02:43 PM User Interface Feature #2513: implement GUI runtime support for TOGGLE-BOX
- @display "This"@ behaves as the first test: window 1x1 in the left top corner.
- 02:43 PM User Interface Feature #2513: implement GUI runtime support for TOGGLE-BOX
- Vadim Gindin wrote:
> Thanks. I tried it and got the error:
> [...]
Are you using the latest P2J rev? Note that t... - 01:42 PM User Interface Feature #2513: implement GUI runtime support for TOGGLE-BOX
- Thanks. I tried it and got the error:...
- 08:44 AM User Interface Feature #2513: implement GUI runtime support for TOGGLE-BOX
- Vadim Gindin wrote:
> I didn't find any peculiarities. Here is the test:
>
> [...]
Have you added basic runtime ... - 06:58 AM User Interface Feature #2513: implement GUI runtime support for TOGGLE-BOX
- I faced with the following difficulty: running application window (GUI) has the size 1x1 and position in the first pi...
- 03:19 PM User Interface Feature #2498: implement ADD-LAST() method
- 1. fixed the issues you've mentioned by Greg.
2. Added server-side support for HORIZONTAL and EXPAND attributes. Cli... - 08:20 AM User Interface Feature #2498: implement ADD-LAST() method
- Code Review ias_upd20150211b.zip
1. This code in @CommonWidget@ is incorrect:... - 09:39 PM Base Language Feature #1628: fix any incompatibilities or missing features of NO-ECHO support
- Code Review evk_upd20150205a.zip
The changes look fine. You'll need to merge up to the latest level before the ne...
02/11/2015
- 04:40 PM User Interface Feature #2479: DEFINE IMAGE and image phrase support for both button and image
- The second update for today has small fixes for image widget bugs/regressions. I guess now if there are no objections...
- 01:15 PM User Interface Feature #2479: DEFINE IMAGE and image phrase support for both button and image
- The update for review includes candidate for image phrase handling for button widget. Need the tests to not getting r...
- 07:38 PM User Interface Feature #2479: DEFINE IMAGE and image phrase support for both button and image
- This drop includes merging with the recent code base and fix for handling case when requested image size is bigger th...
- 04:05 PM User Interface Feature #2498: implement ADD-LAST() method
- 1. The converted code with horizontal RADIO-SET behaves very different from the 4GL. In particular the EXPAND flag is...
- 07:14 AM User Interface Feature #2498: implement ADD-LAST() method
- Finished refactoring and adding new attributes/methods support. Now I should check the behavior of RADIO-SET runtime ...
- 12:41 PM User Interface Feature #2513: implement GUI runtime support for TOGGLE-BOX
- I didn't find any peculiarities. Here is the test:...
- 06:56 AM Database Bug #2488: replace runtime compilation of dynamic queries
- The problem reported in note-62 is fixed by adding the @methods_attributes.rules@ to runtime conversion. With this oc...
02/10/2015
- 06:20 PM User Interface Feature #2487: implement READ-FILE() and SAVE-FILE() methods in the editor widget
- Code Review evk_upd20150209a.zip
Looks good so far. - 06:18 PM User Interface Feature #2487: implement READ-FILE() and SAVE-FILE() methods in the editor widget
- > I planed to add in the LogicalTerminal new methods for read/save files.
That is OK. These should call down to a... - 05:59 PM User Interface Feature #2487: implement READ-FILE() and SAVE-FILE() methods in the editor widget
- Just want to clarify:
I planed to add in the @LogicalTerminal@ new methods for read/save files. Also I need to add s... - 12:22 PM User Interface Feature #2487: implement READ-FILE() and SAVE-FILE() methods in the editor widget
- Added conversion support for SAVE-FILE method
- 02:58 PM User Interface Feature #2498: implement ADD-LAST() method
- > The converted code runs w/o any complains
The 4GL docs state that @LIST-ITEM-PAIRS@ is valid for combo-box, sele... - 02:56 PM User Interface Feature #2498: implement ADD-LAST() method
- Constantin Asofiei wrote:
> Igor, as you are using a dynamic RADIO-SET and not a static RADIO-SET (created via the... - 02:49 PM User Interface Feature #2498: implement ADD-LAST() method
- Greg Shah wrote:
> Do you mean that the code will not EXECUTE in the 4GL? It fails at compilation?
It will com... - 02:46 PM User Interface Feature #2498: implement ADD-LAST() method
- Igor Skornyakov wrote:
> Greg Shah wrote:
> > This you can fix. Please post a simplified testcase (in @[...]@ tags... - 02:42 PM User Interface Feature #2498: implement ADD-LAST() method
- > which is illegal for 4GL
Do you mean that the code will not EXECUTE in the 4GL? It fails at compilation? - 02:36 PM User Interface Feature #2498: implement ADD-LAST() method
- Greg Shah wrote:
> This you can fix. Please post a simplified testcase (in @[...]@ tags) so that I can see what you... - 02:27 PM User Interface Feature #2498: implement ADD-LAST() method
- > I have the following in mind. As you know I've moved some methods from CommonWdget/GenericWidget to a separate inte...
- 02:23 PM User Interface Feature #2498: implement ADD-LAST() method
- Greg Shah wrote:
> We don't want to support any case where the code can never be valid or where we are mis-convertin... - 02:09 PM User Interface Feature #2498: implement ADD-LAST() method
- Igor Skornyakov wrote:
> One more question.
> I've noticed that in some cases an invalid attribute result in 4GL co... - 02:08 PM User Interface Feature #2498: implement ADD-LAST() method
- Igor Skornyakov wrote:
> The situation with invisible dynamic RADIO-SET widget is still unclear. It appears that dyn... - 12:49 PM User Interface Feature #2498: implement ADD-LAST() method
- One more question.
I've noticed that in some cases an invalid attribute result in 4GL compilation failure while in o... - 12:31 PM User Interface Feature #2498: implement ADD-LAST() method
- The situation with invisible dynamic RADIO-SET widget is still unclear. It appears that dynamic COMBO-BOX and SELECTI...
- 02:41 PM Database Bug #2488: replace runtime compilation of dynamic queries
- The attached update should handle the @WhereExpressions@.
There are a few other issues that must be solved first:
*... - 02:07 PM Database Bug #2488: replace runtime compilation of dynamic queries
- Eric Faulhaber wrote:
> At a glance, yes, that looks wrong. Have you converted the static form of the same query? Thi... - 01:57 PM Database Bug #2488: replace runtime compilation of dynamic queries
- At a glance, yes, that looks wrong. Have you converted the static form of the same query? This will tell you if the p...
- 01:52 PM Database Bug #2488: replace runtime compilation of dynamic queries
- Eric,
I almost finished implementing support for 'extending' and interpreting the client-side @WhereExpression@ but ... - 02:14 PM User Interface Feature #2513: implement GUI runtime support for TOGGLE-BOX
- Not exactly. What I meant is that I would like to see some specific findings about the drawing and event processing ...
- 02:12 PM User Interface Feature #2513: implement GUI runtime support for TOGGLE-BOX
- About my implementation plan. I just think that I'll firstly implement drawing and after that I'll be implementing ev...
- 09:22 AM User Interface Feature #2513: implement GUI runtime support for TOGGLE-BOX
- This widget is supported for ChUI runtime usage today. It's conversion should be pretty complete, but I haven't chec...
- 09:19 AM User Interface Feature #2513 (Closed): implement GUI runtime support for TOGGLE-BOX
- 03:16 AM User Interface Feature #1790: implement menu support
- Here is the current update.
It adds to following changes to previous:
* An implementation of find* methods,
* Se...
02/09/2015
- 04:00 PM User Interface Feature #2498: implement ADD-LAST() method
- Extracted list widgets-specific methods to a separate interface @com.goldencode.p2j.ui.CommonListWidget@
- 03:23 PM User Interface Feature #2498: implement ADD-LAST() method
- > Should I remove these methods from CommonWidget/GenericWidget?
Yes.
> Please note that in this case these met... - 03:16 PM User Interface Feature #2498: implement ADD-LAST() method
- I've extracted methods which are defines for lists widgets only to a separate interface. Should I remove these method...
- 12:21 PM User Interface Feature #2498: implement ADD-LAST() method
- Greg Shah wrote:
> This is easy to do, but it has the unwanted result of making the generated code much more verbose... - 12:10 PM User Interface Feature #2498: implement ADD-LAST() method
- > Don't you think that it is more practical to change the code generation? I mean that the code generator can validat...
- 11:47 AM User Interface Feature #2498: implement ADD-LAST() method
- > Just by marking the method as "Widget" in @methods_attributes.rules@ would work. It is not how we want it to work,...
- 11:46 AM User Interface Feature #2498: implement ADD-LAST() method
- Greg Shah wrote:
> Are you saying that you cannot write code like this: @my-widget:add-last(my-char-var, "Some Text"... - 11:03 AM User Interface Feature #2498: implement ADD-LAST() method
- Perhaps that interface would be called @ListManagement@.
>> 2. Don't we still need addLast(character, String)?
> ... - 11:00 AM User Interface Feature #2498: implement ADD-LAST() method
- > > 3. The change in @handle@ is incorrect. @ControlEntity@ is not an interface and MUST NOT be an unwrap target. A...
- 10:56 AM User Interface Feature #2498: implement ADD-LAST() method
- Greg Shah wrote:
> 1. Coding standard issues that remain:
>
> * @for(@ should be @for (@ - @ComboBoxModel@, @Radi... - 09:23 AM User Interface Feature #2498: implement ADD-LAST() method
- Code Review ias_upd20150209a.zip
1. Coding standard issues that remain:
* @for(@ should be @for (@ - @ComboBoxM... - 08:43 AM User Interface Feature #2498: implement ADD-LAST() method
- 1. Formatting issues are fixed (I hope)
2. The list widgets' behaviour updated according to recent findings.
- 07:32 AM User Interface Feature #2498: implement ADD-LAST() method
- > Please note however that if one tries to delete an item with label which doesn't exists in a case-sensitive way but...
- 07:21 AM User Interface Feature #2498: implement ADD-LAST() method
- A more thorough analysis revealed the following details about the list widgets' behaviour:
1. For COMBO-BOX: the @DE... - 02:16 PM Database Bug #2488: replace runtime compilation of dynamic queries
- Eric Faulhaber wrote:
> If we cannot come up with a single test case which would result in client-side where clause ... - 01:25 PM Database Bug #2488: replace runtime compilation of dynamic queries
- IIRC the point is that there can be multiple dynamic buffers with the same name in the same scope and some P2J struct...
- 01:13 PM Database Bug #2488: replace runtime compilation of dynamic queries
- Stanislav Lomany wrote:
> Eric, are you basically asking why suffixes are added to the names of dynamic buffers?
Ye... - 01:08 PM Database Bug #2488: replace runtime compilation of dynamic queries
- Eric, are you basically asking why suffixes are added to the names of dynamic buffers?
- 12:17 PM Database Bug #2488: replace runtime compilation of dynamic queries
- Stanislav, I don't fully understand the following comment, from @DynamicQueryHelper@:763:...
- 10:36 AM Database Bug #2488: replace runtime compilation of dynamic queries
- If we cannot come up with a single test case which would result in client-side where clause processing (all so far se...
- 09:24 AM Database Bug #2488: replace runtime compilation of dynamic queries
- Regarding the user-defined functions. I was thinking too ahead. At this moment the @ProgressParser@ cannot handle UDF...
- 08:25 AM Database Bug #2488: replace runtime compilation of dynamic queries
- Eric Faulhaber wrote:
> The result of this evaluation would be fed into an adapter subclass of the @WhereExpression@... - 04:15 AM Database Bug #2488: replace runtime compilation of dynamic queries
- Eric,
I tried such constructs on windev01.
*CAN-FIND*: P2J parses and successfully converts them in java code, ... - 11:22 AM User Interface Feature #2422: add features to BROWSE
- Addition to note 63. Another 4GL bug which I'm not going to reproduce. Applies to GUI only. Reproduction:
@down to 8... - 11:07 AM User Interface Feature #2422: add features to BROWSE
- It turns out that for ChUI behavior of Page Down differs for preselect and adaptive queries. For example the followin...
02/07/2015
- 11:38 PM Database Bug #2488: replace runtime compilation of dynamic queries
- Each OPEN QUERY in the following test case (@client-where-simple.p@) will force client-side where clause processing:
... - 07:03 PM Database Bug #2488: replace runtime compilation of dynamic queries
- The regression test was successful. Please commit and distribute the update.
02/06/2015
- 04:15 PM Database Bug #2488: replace runtime compilation of dynamic queries
- The conversion test was successful. There are no differences in the generated code with the attached update.
- 02:07 PM Database Bug #2488: replace runtime compilation of dynamic queries
- > The best alternative is to use your solution from note 43 and rename the new method to @putAnnotationObject()@ so t...
- 02:00 PM Database Bug #2488: replace runtime compilation of dynamic queries
- Eric,
The last updates fail to convert the majic sources. The reason is the @putAnnotation()@ method. Although I use... - 12:38 PM Database Bug #2488: replace runtime compilation of dynamic queries
- Thanks, Ovidiu. Please post your conversion results when that's done. I'll run my tests later today or overnight.
- 07:31 AM Database Bug #2488: replace runtime compilation of dynamic queries
- > * Why did you indent build.xml:265?
There were some TABs characters in that file that I replaced with plain spaces... - 03:48 PM User Interface Feature #2479: DEFINE IMAGE and image phrase support for both button and image
- This update for review presents the approach for image-phrase implementation candidate. Needs to check and debug but ...
- 02:20 PM User Interface Feature #1790: implement menu support
- Vadim Gindin wrote:
> Will you also insist on using of @PaintEvent@? If yes could you help me to understand how it s... - 12:28 PM User Interface Feature #1790: implement menu support
- How to properly test static menus deletion?
- 02:13 PM User Interface Feature #2498: implement ADD-LAST() method
- >
> > 6. The item ID generator should not be in the @ControlSetConfig@ class. We are trying to eliminate all logi... - 01:46 PM User Interface Feature #2498: implement ADD-LAST() method
- Greg Shah wrote:
> 2. Is there any way to introduce problems in @ComboBoxModel.calcSelection()@ by relying upon the ... - 01:14 PM User Interface Feature #2498: implement ADD-LAST() method
- Code Review ias_upd20150205a.zip
I really like your nicely factored @ControlSetEntity@ @add*()@ implementation. I... - 12:27 PM User Interface Feature #2498: implement ADD-LAST() method
- Got it. Thank you.
- 12:24 PM User Interface Feature #2498: implement ADD-LAST() method
- > I've also notices that all handle.unwrapXXX() methods work with interfaces while ControlEntity is a class. I don't ...
- 12:04 PM User Interface Feature #2498: implement ADD-LAST() method
- Got it. Actually I've already stated to look at the conversion details.
I've added @unwrapConrolEntity()@ method to ... - 11:52 AM User Interface Feature #2498: implement ADD-LAST() method
- I will do the code review next. Sorry that I have been slow to respond. I've just been very busy.
In regard to t... - 10:26 AM User Interface Feature #2498: implement ADD-LAST() method
- Regression test performed twice.
The following steps failed identically in both runs:
4 ctrlc_11_session1 CTRL...
Also available in: Atom