Project

General

Profile

Activity

From 05/01/2015 to 05/30/2015

05/30/2015

09:12 PM User Interface Feature #2546: implement combo-box widget in GUI
The update for review presents the current state of the combo-box. The server side updated to introduce new option - ... Eugenie Lyzenko

05/29/2015

01:40 PM User Interface Feature #1811: implement the AJAX client driver
Please provide more details about exactly what you have tried to do and the results of each of those experiments/effo... Greg Shah
10:02 AM User Interface Feature #1811: implement the AJAX client driver
The way I envisioned the flow to work is that we send font information to the web client, like font name, size and st... Anton Breaur
01:25 PM Database Feature #2580: make field denormalization the default schema conversion for extent fields
For a schema with a lot of tables requiring extent field denormalization, it would be simpler and less error prone to... Eric Faulhaber
01:21 PM Database Feature #2580 (New): make field denormalization the default schema conversion for extent fields
Eric Faulhaber
06:48 AM User Interface Feature #2546: implement combo-box widget in GUI
Constantin Asofiei wrote:
> > What features in @FillInGuiImpl@ are critical and can not be changed in any cases? Ano...
Eugenie Lyzenko
01:40 AM User Interface Feature #2546: implement combo-box widget in GUI
Eugenie Lyzenko wrote:
> Are you currently working on fill-in GUI implementation?
No, I'm not working on GUI FILL-...
Constantin Asofiei
05:00 AM Base Language Bug #2578: incorrect promotion of local defined variables
Greg Shah wrote:
> Code Review om_upd20150528a.zip
> 1. Are the form header changes are necessary to fix this bug? I...
Ovidiu Maxiniuc

05/28/2015

04:50 PM User Interface Feature #2546: implement combo-box widget in GUI
Constantin,
To implement different combo-box modes with editable entry field I'm planning to integrate fill-in GUI...
Eugenie Lyzenko
03:45 PM Base Language Bug #2578: incorrect promotion of local defined variables
Code Review om_upd20150528a.zip
1. Are the form header changes are necessary to fix this bug? If I understand cor...
Greg Shah
02:08 PM Base Language Bug #2578: incorrect promotion of local defined variables
Eric Faulhaber wrote:
> The changes look correct to me, but I am not expert in this area of the code. Greg will be r...
Ovidiu Maxiniuc
01:08 PM Base Language Bug #2578: incorrect promotion of local defined variables
Code review 0527b:
The changes look correct to me, but I am not expert in this area of the code. Greg will be revi...
Eric Faulhaber
11:02 AM User Interface Feature #1790: implement menu support
Vadim Gindin wrote:
> Constantin Asofiei wrote:
> > Vadim Gindin wrote:
> > > It could print the title on the top ...
Vadim Gindin
10:36 AM User Interface Feature #1790: implement menu support
Constantin Asofiei wrote:
> Vadim Gindin wrote:
> > It could print the title on the top left corner when it draws r...
Vadim Gindin
07:46 AM User Interface Feature #1790: implement menu support
Vadim Gindin wrote:
> It could print the title on the top left corner when it draws rectangle but it doesn't happen....
Constantin Asofiei
07:06 AM User Interface Feature #1790: implement menu support
Constantin Asofiei wrote:
> Vadim Gindin wrote:
> > MENU widget does not support coordinate attributes and WIDTH/HE...
Vadim Gindin
04:41 AM User Interface Feature #1790: implement menu support
Vadim Gindin wrote:
> MENU widget does not support coordinate attributes and WIDTH/HEIGHT attributes too..
OK, I di...
Constantin Asofiei

05/27/2015

06:13 PM User Interface Feature #2546: implement combo-box widget in GUI
The update for review has two new changes:
1. Implementation for first char search/select in GUI combo-box when drop...
Eugenie Lyzenko
08:40 PM User Interface Feature #2546: implement combo-box widget in GUI
The update for review merged with recent code base. In addition it adds tooltip feature to the combo-box and implemen... Eugenie Lyzenko
03:27 PM Base Language Bug #2578: incorrect promotion of local defined variables
This update is not the ideal solution I wanted but it fixes both last issues.
It passed my testcases, as well as the...
Ovidiu Maxiniuc
10:55 AM Base Language Bug #2578: incorrect promotion of local defined variables
My candidate has the following flaw I am trying to fix: when a @FORM HEADER@ is defined locally in an internal proced... Ovidiu Maxiniuc
11:51 AM User Interface Feature #1790: implement menu support
Constantin Asofiei wrote:
> Vadim Gindin wrote:
> > I'm trying to draw simple menubar and I have coordinates proble...
Vadim Gindin
07:21 AM User Interface Feature #1790: implement menu support
Vadim Gindin wrote:
> I'm trying to draw simple menubar and I have coordinates problem. I expected that [0,0] point ...
Constantin Asofiei
06:25 AM User Interface Feature #1790: implement menu support
I'm trying to draw simple menubar and I have coordinates problem. I expected that [0,0] point will reside under the w... Vadim Gindin

05/26/2015

03:50 PM User Interface Feature #1811: implement the AJAX client driver
> 1. Consider the fonts that are defined in @src/font-metrics.xml@ and @FontTable.standardFontTable@.
From what I ...
Anton Breaur
09:55 AM User Interface Feature #1811: implement the AJAX client driver
Code Review fonts_js.zip from note 712
Overall, this is moving in the right direction.
Next steps:
1. Consid...
Greg Shah
01:23 PM User Interface Feature #2422: add features to BROWSE
@CURRENT-ROW-MODIFIED@ logic differs from @MODIFIED@ logic. The latter is tricky, while @CURRENT-ROW-MODIFIED@ is str... Stanislav Lomany
01:10 PM Base Language Bug #2578: incorrect promotion of local defined variables
Do you have a new version that I should use for the code review? Greg Shah
10:26 AM User Interface Feature #2546: implement combo-box widget in GUI
Multiple selection investigation results. In ChUI only DROP-DOWN-LIST mode can be active(even if other specified). In... Eugenie Lyzenko

05/25/2015

03:28 PM User Interface Feature #1811: implement the AJAX client driver
Added the @fontMetrics@ module from @p2j.screen.js@ and managed to compute all the metrics described in @com.goldenco... Anton Breaur
03:19 AM User Interface Feature #1794: implement font support
Greg Shah wrote:
> Code Review ca_upd20150520d.zip
>
> It looks good. This is a nice improvement over my previou...
Constantin Asofiei

05/23/2015

10:06 AM User Interface Feature #1794: implement font support
Code Review ca_upd20150520d.zip
It looks good. This is a nice improvement over my previous approach (yours is muc...
Greg Shah

05/22/2015

03:36 PM User Interface Feature #1811: implement the AJAX client driver
Anton Breaur wrote:
> > I do worry that we won't have access to all the metrics that we need, but I'm happy to avoid...
Greg Shah
09:50 AM User Interface Feature #1811: implement the AJAX client driver
> I do worry that we won't have access to all the metrics that we need, but I'm happy to avoid custom font rendering ... Anton Breaur
08:37 AM User Interface Feature #1811: implement the AJAX client driver
> I think the proper way is to use @save()@ to store off the context before drawing the scaled string and then @resto... Anton Breaur
08:31 AM User Interface Feature #1811: implement the AJAX client driver
I'm OK with not using @opentype.js@, so long as we can get everything implemented which we need. I do worry that we ... Greg Shah
07:54 AM User Interface Feature #1811: implement the AJAX client driver
I gave up opentype.js and took a different approach. We can apply a scaling transformation to the canvas context, and... Anton Breaur
02:01 PM Base Language Bug #2578: incorrect promotion of local defined variables
Please ignore my om_upd20150522a.zip. It brings nothing new, I zipped the wrong files. Sorry. Ovidiu Maxiniuc
11:28 AM Base Language Bug #2578: incorrect promotion of local defined variables
I moved the @HandleExprN@ instance variable definitions to same scope as their class. The Majic conversion testing pa... Ovidiu Maxiniuc
11:48 PM Base Language Bug #2578: incorrect promotion of local defined variables
I tested @om_upd20150521a.zip@ with the current project. After conversion, there were a number of compile errors (act... Eric Faulhaber

05/21/2015

01:02 PM Base Language Bug #2578: incorrect promotion of local defined variables
Code review 0521a:
Looks good to me in terms of the persistence-related changes, though I did notice a typo in the...
Eric Faulhaber
11:32 AM Base Language Bug #2578: incorrect promotion of local defined variables
I have tested this update with majic conversion and it looks fine to me.
There are a lot of changes in the code: asi...
Ovidiu Maxiniuc
10:01 AM User Interface Feature #1811: implement the AJAX client driver
> I have attached a partial implementation for drawString and drawStringScaled methods in javascript. The index.html ... Greg Shah
07:12 AM User Interface Feature #1794: implement font support
0520d.zip has passed runtime testing. Constantin Asofiei
04:18 AM User Interface Bug #2579: Cursor offset is reset after a trigger containing MESSAGE ... UPDATE
Testcase:... Stanislav Lomany
04:13 AM User Interface Bug #2579 (New): Cursor offset is reset after a trigger containing MESSAGE ... UPDATE
Stanislav Lomany

05/20/2015

01:25 PM Base Language Bug #2578: incorrect promotion of local defined variables
Eric Faulhaber wrote:
> See @get_top_level_section_anchor@ in @common-progress.rules@. I use this as a substitute fo...
Ovidiu Maxiniuc
12:52 PM Base Language Bug #2578: incorrect promotion of local defined variables
See @get_top_level_section_anchor@ in @common-progress.rules@. I use this as a substitute for @getSectionAnchor@. Eric Faulhaber
12:49 PM Base Language Bug #2578: incorrect promotion of local defined variables
That's exactly what I should do in this regard, too: to move the embedded assignment expressions to a more specific s... Ovidiu Maxiniuc
12:29 PM Base Language Bug #2578: incorrect promotion of local defined variables
Ovidiu Maxiniuc wrote:
> I think that is the correct location/scope of the inner @EmbeddedAssignmentExpr0@ class (li...
Eric Faulhaber
09:24 AM Base Language Bug #2578: incorrect promotion of local defined variables
After some local tests with proposed fix I did a first conversion on Majic. There are indeed a lot of changes, 10% th... Ovidiu Maxiniuc
12:42 PM Database Bug #2536: improve dynamic query parser error handling
Code review 0519a:
I'm glad you made this change, I was going to ask for something like it. After you made the err...
Eric Faulhaber
07:41 AM User Interface Feature #1794: implement font support
This version is built on top of 0519b.zip and improves the font table and metric loading + some other GUI-related fixes. Constantin Asofiei

05/19/2015

07:06 PM User Interface Feature #1811: implement the AJAX client driver
I have attached a partial implementation for drawString and drawStringScaled methods in javascript. The index.html de... Anton Breaur
12:58 PM User Interface Feature #1811: implement the AJAX client driver
The ab_upd20150518a.zip conflicts with the @FontManager@ changes in ca_upd20150519b.zip. How do we want to sequence ... Greg Shah
12:51 PM User Interface Feature #1811: implement the AJAX client driver
Greg Shah wrote:
> Code Review ab_upd20150518a.zip
>
> I'm good with the changes.
>
> Constantin: any objectio...
Constantin Asofiei
12:33 PM User Interface Feature #1811: implement the AJAX client driver
Code Review ab_upd20150518a.zip
I'm good with the changes.
Constantin: any objections?
Greg Shah
06:34 PM User Interface Feature #2546: implement combo-box widget in GUI
Addition to GUI combo-box TODO:
8. Investigate and implement different drop-down list modes, particularly if it is...
Eugenie Lyzenko
03:07 PM User Interface Feature #2546: implement combo-box widget in GUI
The update fixes the "phantom" drop-down drawing at incorrect position by delaying the first available draw to the mo... Eugenie Lyzenko
04:32 PM Base Language Bug #2578: incorrect promotion of local defined variables
I think here we are over-generalizing for a specific case handled at line 619 of @where_clause_post.rules@, where we ... Eric Faulhaber
03:23 PM Base Language Bug #2578: incorrect promotion of local defined variables
Eric,
As I expected, the variables are generally promoted if they are found to be referenced in a query substitution...
Ovidiu Maxiniuc
12:27 PM Base Language Bug #2578: incorrect promotion of local defined variables
Ovidiu Maxiniuc wrote:
> The reason why the variable is promoted is related to the fact that it takes part into the ...
Eric Faulhaber
12:02 PM Base Language Bug #2578: incorrect promotion of local defined variables
Please check the @uast/scoping/local-variable-in-query.p@. Ovidiu Maxiniuc
11:30 AM Base Language Bug #2578: incorrect promotion of local defined variables
Please check this 4GL code into the testcases project and post the name here. Eric Faulhaber
10:29 AM Base Language Bug #2578: incorrect promotion of local defined variables
When running some testcases for a customer I encountered cases when they were passing at a first run, then re-running... Ovidiu Maxiniuc
10:03 AM Base Language Bug #2578 (Closed): incorrect promotion of local defined variables
Ovidiu Maxiniuc
01:47 PM User Interface Feature #2252: implement GUI client support
Create a new repo under @~/repo/p2j_repo/@ called @images@. We can keep things like SVG files there, similar to how ... Greg Shah
01:16 PM User Interface Feature #2252: implement GUI client support
Greg Shah wrote:
> How are you converting the SVG to bitmaps? Do you do this during the P2J build or statically?
...
Hynek Cihlar
01:14 PM User Interface Feature #2252: implement GUI client support
Hynek Cihlar wrote:
> As part of #2559 I have created a set of icon files in SVG format. The application jar file wi...
Greg Shah
08:17 AM User Interface Feature #2252: implement GUI client support
Constantin Asofiei wrote:
> Hynek, have you had a chance to work on this?
No.
> If not, I'll take it.
Wond...
Hynek Cihlar
07:41 AM User Interface Feature #2252: implement GUI client support
Hynek, have you had a chance to work on this? If not, I'll take it.
Hynek Cihlar wrote:
> Still I think the layou...
Constantin Asofiei
05:42 AM User Interface Feature #2252: implement GUI client support
As part of #2559 I have created a set of icon files in SVG format. The application jar file will hold rastr exports o... Hynek Cihlar
01:13 PM User Interface Feature #1794: implement font support
Greg Shah wrote:
> Code Review ca_upd20150519b.zip
>
> The changes look good.
>
> 1. In regard to this todo in...
Constantin Asofiei
12:53 PM User Interface Feature #1794: implement font support
Code Review ca_upd20150519b.zip
The changes look good.
1. In regard to this todo in @SwingGuiDriver.createFont(...
Greg Shah
09:59 AM User Interface Feature #1794: implement font support
This update adds:
* support for custom fonts in the Swing GUI driver
* support for implicit font size used by 4GL
...
Constantin Asofiei
09:32 AM User Interface Feature #1794: implement font support
If the font size is missing, 4GL looks like it defaults to these:
# courier new: 12
# segoe ui: 12
# tahoma: 12
#...
Constantin Asofiei
03:37 AM Database Bug #2536: improve dynamic query parser error handling
I added a few changes to @DynamicQueryHelper@ that refine the messages printed in console. At this moment the log is ... Ovidiu Maxiniuc

05/18/2015

07:08 PM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
The @frame.enableUnlessHidden()@ call is generated for @enable unless-hidden all@ statement/Generic but CommonFrame/G... Igor Skornyakov
06:54 PM User Interface Feature #2546: implement combo-box widget in GUI
The update has code merged with @10867@. Eugenie Lyzenko
03:56 PM User Interface Feature #2546: implement combo-box widget in GUI
The next update for review has fixes for both message processing TODO's. Also now the top row in opened drop-down is ... Eugenie Lyzenko
05:11 PM User Interface Feature #1811: implement the AJAX client driver
> Do you have more research to do or are you ready to work on specific javascript code to implement these features?
...
Anton Breaur
05:09 PM User Interface Feature #1811: implement the AJAX client driver
> I assume this would not be accepted.
Correct.
So far, your proposal sounds reasonable. Do you have more rese...
Greg Shah
04:50 PM User Interface Feature #1811: implement the AJAX client driver
I have executed local testing of all client types, using the IM POC code for the 4 ChUI clients. MAJIC regression te... Greg Shah
04:49 PM User Interface Feature #1811: implement the AJAX client driver
A description of the more rational driver structure is as follows:
com/goldencode/p2j/ui/client/driver/ - Driver c...
Greg Shah
04:21 PM User Interface Feature #1811: implement the AJAX client driver
Merged with bzr rev 10866. This only changes @ColorTable@ and @FrameWidget@. Since my changes are just some javadoc... Greg Shah
04:18 PM User Interface Feature #1811: implement the AJAX client driver
No objections to the changes in ges_upd20150518a.zip here. Hynek Cihlar
02:01 PM User Interface Feature #1811: implement the AJAX client driver
>Your task is to propose an approach for how to implement this native porton in javascript. We will have to implement... Anton Breaur
12:10 PM User Interface Feature #1811: implement the AJAX client driver
Attached is the fixed update.
> ThinClient.resume() - shouldn't be the batch mode activated only when already acti...
Greg Shah
06:54 AM User Interface Feature #1811: implement the AJAX client driver
Greg Shah wrote:
> Constantin/Hynek: please review this code. I'll check it in unless there are objections.
Beside...
Constantin Asofiei
03:53 PM Database Bug #2536: improve dynamic query parser error handling
Is there anything left to do on this issue at this point, or can it be closed? Eric Faulhaber
03:51 PM Database Bug #2577: extent information in meta table
Ovidiu Maxiniuc wrote:
> I've just checked the @custom-extent@ support. As you thought, it doesn't work. The @messag...
Eric Faulhaber
03:16 PM Database Bug #2577: extent information in meta table
Committed to bzr as revno 10865.
I've just checked the @custom-extent@ support. As you thought, it doesn't work. T...
Ovidiu Maxiniuc
02:10 PM Database Bug #2577: extent information in meta table
Code review 0518b:
The fix looks fine. Please check it in as is, no regression testing needed (it is additive and ...
Eric Faulhaber
12:54 PM Database Bug #2577: extent information in meta table
I discovered that the extent information is missing in the field meta table (it's always @0@). This causes some testc... Ovidiu Maxiniuc
12:38 PM Database Bug #2577 (Closed): extent information in meta table
Ovidiu Maxiniuc
03:10 PM Bugs Bug #2569: memory leaks of procedure, buffer, handle resources
The attached update is essentially the same as ecf_upd20150518a, but with the original error logging in @TM.abnormalE... Eric Faulhaber
05:40 AM Bugs Bug #2569: memory leaks of procedure, buffer, handle resources
Constantin Asofiei wrote:
> There's one more place with a @new WorkArea()@ in @ColorTable.asHandle@. Please fix th...
Eric Faulhaber
02:45 AM Bugs Bug #2569: memory leaks of procedure, buffer, handle resources
Eric Faulhaber wrote:
> Constantin, I included the suggested @handle.removeResource@ fix, and it did indeed solve th...
Constantin Asofiei
12:23 AM Bugs Bug #2569: memory leaks of procedure, buffer, handle resources
Constantin, I included the suggested @handle.removeResource@ fix, and it did indeed solve that problem. Thank you!
...
Eric Faulhaber

05/17/2015

05:07 PM User Interface Feature #2559 (WIP): implement ALERT-BOX support
Hynek Cihlar
04:01 PM User Interface Feature #1811: implement the AJAX client driver
Review of ges_upd20150517a.zip.
This is a lot of nice cleanup!

* @ThinClient.resume()@ - shouldn't be the batc...
Hynek Cihlar
11:06 AM User Interface Feature #1811: implement the AJAX client driver
This update has the ca_upd20150516a.zip changes merged.
My original @scaleFont()@ implementation did not edit the ...
Greg Shah
10:37 AM User Interface Feature #1811: implement the AJAX client driver
Code Review ca_upd20150516a.zip
The changes make sense. I've integrated them with my code, but I've done it a bit...
Greg Shah
11:34 AM User Interface Bug #2576: Cursor position in numeric fields (ChUI)
4GL and P2J has different cursor behavior for numeric values. In an @"___12345"@ field 4GL allows to move cursor in u... Stanislav Lomany
11:33 AM User Interface Bug #2576 (New): Cursor position in numeric fields (ChUI)
Stanislav Lomany
11:14 AM User Interface Feature #2422: add features to BROWSE
I agree. Please open a separate task for this. Greg Shah
11:07 AM User Interface Feature #2422: add features to BROWSE
I've implemented @CURSOR-OFFSET@ for fill-in, but there is one issues, which I think deserves a separate task - 4GL a... Stanislav Lomany

05/16/2015

01:57 PM User Interface Feature #1811: implement the AJAX client driver
Greg Shah wrote:
> At this point the only known issue is that the fonts in GUI seem off. I made quite a significant...
Constantin Asofiei
12:31 PM User Interface Feature #1811: implement the AJAX client driver
Anton: here is your next task.
Please review the following from my update:...
Greg Shah
11:35 AM User Interface Feature #1811: implement the AJAX client driver
Attached is the latest scripts to help review or apply the update. Greg Shah
11:08 AM User Interface Feature #1811: implement the AJAX client driver
Oh, alright. I will keep those standards in mind then. Anton Breaur
11:06 AM User Interface Feature #1811: implement the AJAX client driver
As I mentioned in note 682:
> You do *not* have to fix the current update.
I just added the bold to highlight ...
Greg Shah
10:58 AM User Interface Feature #1811: implement the AJAX client driver
I will fix these and upload an update. Anton Breaur
10:51 AM User Interface Feature #1811: implement the AJAX client driver
Code Review ab_upd20150516a.zip
Anton: although I have already merged your changes with my own, I am providing thi...
Greg Shah
10:29 AM User Interface Feature #1811: implement the AJAX client driver
0515b passed CTRL-C testing.
The attached is 0515b merged with the changes in ab_upd20150516a.zip. The web ChUI c...
Greg Shah
10:01 AM User Interface Feature #1811: implement the AJAX client driver
I'm merging and testing your changes. The important difference is in the @EmbeddedWebServerImpl.startupServer()@. Greg Shah
09:56 AM User Interface Feature #1811: implement the AJAX client driver
The latest patch works fine with revision 10863 merged version.
I still don't understand the web_client.html issue. ...
Anton Breaur
09:20 AM User Interface Feature #1811: implement the AJAX client driver
This fixes the web chui failure. It was created on top of the merged with revision 10855 version, and not yet tested ... Anton Breaur
08:37 AM User Interface Feature #1811: implement the AJAX client driver
> The web_client.html is the login page. This works with my 0515b update. It allows the ChUI-specific index.html to... Anton Breaur
08:02 AM User Interface Feature #1811: implement the AJAX client driver
I ran main regression testing on the 0515b update last night. GSO 418 did fail in addition to the expected failure i... Greg Shah
07:36 AM User Interface Feature #1811: implement the AJAX client driver
The web_client.html is the login page. This works with my 0515b update. It allows the ChUI-specific index.html to b... Greg Shah
09:02 PM User Interface Feature #2546: implement combo-box widget in GUI
This is just today changes for review. Scrolling approach changed to reflect 4GL behavior. Also I have found in GUI t... Eugenie Lyzenko

05/15/2015

07:54 PM User Interface Feature #1811: implement the AJAX client driver
Greg, I don't understand the web_client.html issue. The web chui client does not need that resource.
If you applied ...
Anton Breaur
02:30 PM User Interface Feature #1811: implement the AJAX client driver
This includes a fix for the batch process launching from Swing clients.
I have also tried to implement the fixes f...
Greg Shah
12:22 PM User Interface Feature #1811: implement the AJAX client driver
Merged to bzr 10863. Greg Shah
11:41 AM User Interface Feature #1811: implement the AJAX client driver
Please post your changed versions of my files (only include those files you have changed). Greg Shah
11:26 AM User Interface Feature #1811: implement the AJAX client driver
> Although all the docs and examples point out that wraping a ResourceHandler under a ContextHandler should enable lo... Anton Breaur
05:02 PM User Interface Feature #1794: implement font support
Greg Shah wrote:
> I have an idea what @scaled via DPI@ and @scaled via legacy metrics@ mean. Can you explain what ...
Constantin Asofiei
04:51 PM User Interface Feature #1794: implement font support
I have an idea what @scaled via DPI@ and @scaled via legacy metrics@ mean. Can you explain what you did for @scaled ... Greg Shah
04:27 PM User Interface Feature #1794: implement font support
About using the font/text metrics reported by the driver for widget size formulas. I've tested the @Courier New@, @M... Constantin Asofiei
03:28 PM User Interface Feature #1794: implement font support
As we consider font compatibility issues, the following are some useful references:
http://en.wikipedia.org/wiki/C...
Greg Shah
08:26 AM User Interface Feature #2546: implement combo-box widget in GUI
Code Review evl_upd20150514b.zip
I'm good with this version. Please just remove the ChUI reference in the @DropDo...
Greg Shah
03:43 AM User Interface Feature #2252: implement GUI client support
hc_upd20150513b.zip committed to bzr rev 10862. Hynek Cihlar
02:53 AM User Interface Feature #2252: implement GUI client support
Greg Shah wrote:
> Code Review hc_upd20150513b.zip
>
> I'm OK with it.
>
> Constantin?
The changes look OK.
Constantin Asofiei
03:16 AM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
Greg Shah wrote:
> 3. I don't understand the point about @ShowBars.NEVER@.
There seemed to be a confusion about t...
Hynek Cihlar
02:58 AM User Interface Feature #2573: GUI implementation for the "n COLUMNS" frame option
This task is to implement in P2J the "n COLUMNS" option at the frame phrase, in GUI. In ChUI, this kind of layout is ... Constantin Asofiei
02:54 AM User Interface Feature #2573 (New): GUI implementation for the "n COLUMNS" frame option
Constantin Asofiei

05/14/2015

07:11 PM User Interface Feature #2546: implement combo-box widget in GUI
The update has fixes for previous notes and creating new class @DropDownImpl@ to handle ChUI specifics. The @ChuiWidg... Eugenie Lyzenko
06:11 PM User Interface Feature #2546: implement combo-box widget in GUI
> You mean we need to create new class @DropDownImpl@ to concentrate all ChUI specifics?
Yes.
Greg Shah
06:05 PM User Interface Feature #2546: implement combo-box widget in GUI
Greg Shah wrote:
>
> 3. Since @DropDown.fixVisibleRows()@ is ChUI specific, it should be in @DropDownImpl@. In th...
Eugenie Lyzenko
05:29 PM User Interface Feature #2546: implement combo-box widget in GUI
Code Review evl_upd20150514a.zip
I like the code.
1. The @ComboBox.initEventsSet()@ and @ComboBox.addMouseExitE...
Greg Shah
04:47 PM User Interface Feature #2546: implement combo-box widget in GUI
This update accumulates recent changes and fixes for combo-box. What's new:
1. The drop-down can now be left either ...
Eugenie Lyzenko
03:58 PM User Interface Feature #2546: implement combo-box widget in GUI
Code Review evl_upd20150512a.zip
I'm OK with the changes so far. @ScrollableSelectionListGuiImpl@, @DropDownGuiIm...
Greg Shah
04:23 AM User Interface Feature #2546: implement combo-box widget in GUI
I noticed drop downs are drawn using the same renderer as the parent @Window@. This means they can never be drawn out... Hynek Cihlar
06:33 PM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
Greg Shah wrote:
> 1. Is there only 1 issue described in those notes or more than one?
I understand that it is a ...
Igor Skornyakov
06:29 PM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
Igor Skornyakov wrote:
> Greg Shah wrote:
>
> > Is another task is needed for the issue in note 67, 71 - 72 and 8...
Greg Shah
06:16 PM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
Greg Shah wrote:
> Is another task is needed for the issue in note 67, 71 - 72 and 84 - 86?
I do not consider t...
Igor Skornyakov
06:10 PM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
I've created a separate task #2572 for work on @realized@.
Is another task is needed for the issue in note 67, 71 ...
Greg Shah
05:25 PM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
Eugenie Lyzenko wrote:
> 2. This call worked only for drop-down list and only for the time it exists. No other class...
Hynek Cihlar
04:58 PM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
Greg Shah wrote:
> > Probably due to the following in @DropDownGuiImpl.setHeightAndPos()@?
> >
> > [...]
>
> I...
Eugenie Lyzenko
03:59 PM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
Hynek Cihlar wrote:
> Igor Skornyakov wrote:
> > I've noticed the following issue (see attached sample code). With ...
Greg Shah
11:26 AM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
Constantin Asofiei wrote:
> I mean, does the frame get realized regardless which widget gets its size read?
I d...
Igor Skornyakov
11:19 AM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
Igor Skornyakov wrote:
> Constantin Asofiei wrote:
>
> > OK, this is interesting; I think reading width/height at...
Constantin Asofiei
10:09 AM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
Constantin Asofiei wrote:
> OK, this is interesting; I think reading width/height attributes will make the frame "...
Igor Skornyakov
10:03 AM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
Igor Skornyakov wrote:
> Constantin Asofiei wrote:
>
> > Igor: please post your example for the case you are tryi...
Constantin Asofiei
09:59 AM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
Constantin Asofiei wrote:
> Igor: please post your example for the case you are trying to solve.
Constantin. In...
Igor Skornyakov
09:44 AM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
Eugenie Lyzenko wrote:
> My suggest: the widget become realized when it become the part of some frame. More specifica...
Constantin Asofiei
09:42 AM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
Igor Skornyakov wrote:
> Is it sufficient to set a 'realized' flag in the widget config?
There already is a @Widget...
Constantin Asofiei
09:41 AM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
My suggest: the widget become realized when it become the part of some frame. More specifically: when it is used in w... Eugenie Lyzenko
09:23 AM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
Eugenie Lyzenko wrote:
> From @4GL 9.1 Progress Programming Handbook@, chapter 16-26, page 614:
>
> [...]
Th...
Igor Skornyakov
09:07 AM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
Igor Skornyakov wrote:
> BTW: I would like to repeat the question I've asked earlier. What is the exact semantics of...
Eugenie Lyzenko
07:34 AM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
BTW: I would like to repeat the question I've asked earlier. What is the exact semantics of the widget 'realization'?... Igor Skornyakov
03:59 AM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
Hynek Cihlar wrote:
>
> Probably due to the following in @DropDownGuiImpl.setHeightAndPos()@?
>
> [...]
Th...
Igor Skornyakov
03:56 AM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
Igor Skornyakov wrote:
> I've noticed the following issue (see attached sample code). With native 4GL one can see a ...
Hynek Cihlar
03:37 AM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
Constantin Asofiei wrote:
> Is this something which prevents the 4GL program to run? Basically, our goal is to conve...
Igor Skornyakov
01:26 AM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
Igor Skornyakov wrote:
> Need to add frame validation at the moment of realization to ensure that all widgets fit in...
Constantin Asofiei
06:22 PM User Interface Feature #2252: implement GUI client support
Code Review hc_upd20150513b.zip
I'm OK with it.
Constantin?
Greg Shah
07:12 AM User Interface Feature #2252: implement GUI client support
The attached update fixes a mismatch in frame size caused by char->pixel conversion. This prevents frame size adjustm... Hynek Cihlar
06:05 PM User Interface Bug #2572: improve realized for widgets
The @realized@ flag for widgets needs to be improved to duplicate the 4GL behavior. Unfortunately, this behavior is ... Greg Shah
06:02 PM User Interface Bug #2572 (New): improve realized for widgets
Greg Shah
07:27 AM User Interface Feature #1811: implement the AJAX client driver
> > After investigating the web Chui issue, I found that the ChuiWebDriver.getWelcomePageUrl method builds the wrong ... Anton Breaur
07:06 AM User Interface Feature #1811: implement the AJAX client driver
> We are not just limited to using this approach.
To be clear, my preference is to use predefined classes from Jet...
Greg Shah
07:00 AM User Interface Feature #1811: implement the AJAX client driver
> Adding another subfolder to res folders as such: com/goldencode/p2j/ui/client/chui/driver/web/res/client and com/go... Greg Shah
06:56 AM User Interface Feature #1811: implement the AJAX client driver
> After investigating the web Chui issue, I found that the ChuiWebDriver.getWelcomePageUrl method builds the wrong UR... Greg Shah
06:27 AM User Interface Feature #1811: implement the AJAX client driver
Adding another subfolder to res folders as such: @com/goldencode/p2j/ui/client/chui/driver/web/res/client@ and @com/g... Anton Breaur

05/13/2015

06:44 PM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
Need to add frame validation at the moment of realization to ensure that all widgets fit in the frame. At this moment... Igor Skornyakov
01:28 PM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
I've noticed the following issue (see attached sample code). With native 4GL one can see a bordered frame w/o scrollb... Igor Skornyakov
12:25 PM User Interface Feature #1811: implement the AJAX client driver
After investigating the web Chui issue, I found that the @ChuiWebDriver.getWelcomePageUrl@ method builds the wrong UR... Anton Breaur
07:45 AM User Interface Feature #2252: implement GUI client support
Constantin Asofiei wrote:
> I think is related to something I was suspecting it will cause us issues: when pushScree...
Hynek Cihlar
06:03 AM User Interface Feature #2252: implement GUI client support
Hynek Cihlar wrote:
> Constantin Asofiei wrote:
> > Hynek, when you have time, please take a look at testcases/uast...
Constantin Asofiei
04:36 AM User Interface Feature #2252: implement GUI client support
Constantin Asofiei wrote:
> Hynek, when you have time, please take a look at testcases/uast/demo/movie-ratings-dynam...
Hynek Cihlar
09:14 PM User Interface Feature #2546: implement combo-box widget in GUI
This update for review has several small fixes for UI representation for the drop-down and scroll-bar inside.
1. The...
Eugenie Lyzenko

05/12/2015

05:32 PM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
The additional note: the second config update I've mentioned before is actually a one triggered by a server-side @Syn... Igor Skornyakov
02:08 PM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
Hynek Cihlar wrote:
> Please post your whole update and a small sample I can run. Thanks.
My code is currently in...
Igor Skornyakov
01:38 PM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
Please post your whole update and a small sample I can run. Thanks. Hynek Cihlar
01:22 PM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
Well, I've noticed some strange thing - the backup values for 2 field are stale (do not reflect the values before cha... Igor Skornyakov
01:11 PM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
I think they are (see attached file). Please note however that @readExternal@/@writeExternal@ are not invoked (neithe... Igor Skornyakov
01:01 PM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
Are all the fields properly handled in @readExternal@, @writeExternal@ and @applyConfig@? Please post your code changes. Hynek Cihlar
12:51 PM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
Additional observations: @addDirtyConfig@ was invoked for all 3 fields. Igor Skornyakov
12:43 PM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
Hynek,
I've added 3 fields to the @ComboBoxConfig@ :
/** The number of assignments to INNER-LINES since the la...
Igor Skornyakov
12:38 PM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
Igor, which fields are not propagated? Please post a sample code. Hynek Cihlar
12:33 PM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
It seems that there is a problem with config changes' propagation from client side to the server one. I change 3 fiel... Igor Skornyakov
01:53 PM Database Bug #2488: replace runtime compilation of dynamic queries
Eric Faulhaber wrote:
> Code review 0512a:
>
> The change looks good. If it fixes your problem locally, please co...
Ovidiu Maxiniuc
12:37 PM Database Bug #2488: replace runtime compilation of dynamic queries
Code review 0512a:
The change looks good. If it fixes your problem locally, please commit and distribute, since re...
Eric Faulhaber
11:47 AM Database Bug #2488: replace runtime compilation of dynamic queries
The attached update allows variables to be declared and initialized in the dynamically constructed object. They were ... Ovidiu Maxiniuc

05/11/2015

11:28 AM User Interface Feature #2422: add features to BROWSE
Until SET-REPOSITIONED-ROW is implemented, GET-REPOSITIONED-ROW always returns 1. Stanislav Lomany
01:03 AM User Interface Feature #2422: add features to BROWSE
I like the approach. It improves compatibility on the server-side while not requiring an explosion of new widgets (a... Greg Shah
09:44 PM User Interface Feature #2422: add features to BROWSE
Greg, about AUTO-ZAP: I think we can create @FillInConfig.zapActive@ variable and update it each time zap state it is... Stanislav Lomany
10:30 AM User Interface Feature #2563: implement GUI EDITOR widget
>Please test what happens with the image's WIDTH/HEIGHT-CHARS/PIXELS attributes in these cases (image or size phrase)... Eugenie Lyzenko
02:57 AM User Interface Feature #2563: implement GUI EDITOR widget
Attached version was committed to bzr rev 10858 (just a header entry added to ImageGuiImpl, it was missing in 0510d.zip) Constantin Asofiei
02:53 AM User Interface Feature #2563: implement GUI EDITOR widget
Eugenie Lyzenko wrote:
> Imagine two situations:
> 1. We have no image and @width@/@height@ == 0.
> 2. We have no ...
Constantin Asofiei
09:57 AM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
Greg Shah wrote:
> You can work with Constantin to plan the changes needed. At this point, just put in the minimum ...
Igor Skornyakov
09:51 AM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
You can work with Constantin to plan the changes needed. At this point, just put in the minimum support that you nee... Greg Shah
08:18 AM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
I think that I understand the root of the problem. The @FrameWidget.frame@ field initially contains the corresponding... Igor Skornyakov
07:46 AM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
Greg Shah wrote:
> We don't have frame family support yet (that is the last part of #1798). It won't get worked unt...
Igor Skornyakov
07:44 AM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
We don't have frame family support yet (that is the last part of #1798). It won't get worked until later this summer... Greg Shah
07:25 AM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
It seems that we have a problem with nested frames - all the intermediate frames and inner widget have a @frame@ fiel... Igor Skornyakov
06:52 AM User Interface Feature #2252: implement GUI client support
The problem seems to be in mixing the window size vs. the window workspace size. When the frame layouts itself it mus... Hynek Cihlar
05:51 AM User Interface Feature #2252: implement GUI client support
Constantin Asofiei wrote:
> Hynek Cihlar wrote:
> > See the attached update, now the frame seems to be stable.
> ...
Hynek Cihlar
03:27 AM User Interface Feature #2252: implement GUI client support
Hynek Cihlar wrote:
> See the attached update, now the frame seems to be stable.
>
> The problem was in the char...
Constantin Asofiei
03:14 AM Bugs Bug #2569: memory leaks of procedure, buffer, handle resources
Eric, don't know how I didn't notice this until now. @handle.removeResource@ should be called for every kind of resou... Constantin Asofiei

05/10/2015

05:27 PM User Interface Feature #2563: implement GUI EDITOR widget
>Eugenie, can you review the ImageGuiImpl change in 0510d.zip? I wonder if you had a specific reason to return width/... Eugenie Lyzenko
03:07 PM User Interface Feature #2563: implement GUI EDITOR widget
Eugenie, can you review the ImageGuiImpl change in 0510d.zip? I wonder if you had a specific reason to return width/h... Constantin Asofiei
02:28 PM User Interface Feature #2563: implement GUI EDITOR widget
ca_upd20150510d.zip has passed runtime testing. But there might be more problematic edge cases (like merging lines o... Constantin Asofiei
10:33 AM User Interface Feature #2563: implement GUI EDITOR widget
New version: fixed 2 editor regressions and some other GUI improvements (FILL-IN colors, LABEL font, IMAGE size). Constantin Asofiei
04:09 PM User Interface Feature #2252: implement GUI client support
See the attached update, now the frame seems to be stable.
The problem was in the char->pixel->char conversion. T...
Hynek Cihlar
03:12 PM User Interface Feature #2252: implement GUI client support
Hynek, when you have time, please take a look at testcases/uast/demo/movie-ratings-dynamic.p - in P2J, when setting c... Constantin Asofiei
09:12 AM User Interface Feature #2252: implement GUI client support
Eugenie Lyzenko wrote:
> Hynek Cihlar wrote:
> > The update improves drawing of window caption buttons. They are now ...
Hynek Cihlar
08:28 AM User Interface Feature #2252: implement GUI client support
Hynek Cihlar wrote:
> The update improves drawing of window caption buttons. They are now more alike those from stan...
Eugenie Lyzenko
08:13 AM User Interface Feature #2252: implement GUI client support
The javadoc problem fixed and the update committed to bzr rev 10857. Hynek Cihlar
04:19 AM User Interface Feature #2252: implement GUI client support
Hynek Cihlar wrote:
> The update improves drawing of window caption buttons. They are now more alike those from stan...
Constantin Asofiei
02:46 AM User Interface Feature #2252: implement GUI client support
The update improves drawing of window caption buttons. They are now more alike those from standard Windows theme. Can... Hynek Cihlar
02:41 AM User Interface Feature #2252: implement GUI client support
The attached update fixes window scrollable size calculation when window virtual size not set. The change only affect... Hynek Cihlar
04:05 AM User Interface Feature #2422: add features to BROWSE
Stanislav Lomany wrote:
> Constanin, I change some @FillIn.config.val@ on the client side, then a trigger in invoked...
Constantin Asofiei
02:44 AM User Interface Feature #2422: add features to BROWSE
Constanin, I change some @FillIn.config.val@ on the client side, then a trigger in invoked and I get @FillInWidget.co... Stanislav Lomany
02:05 AM User Interface Feature #2422: add features to BROWSE
Stanislav Lomany wrote:
> > So long as the values in the config are modified, they will be synchronized to the serve...
Constantin Asofiei
01:59 AM User Interface Feature #2422: add features to BROWSE
> So long as the values in the config are modified, they will be synchronized to the server automatically the next ti... Stanislav Lomany
02:51 AM User Interface Feature #2564: implement GUI BROWSE widget
Another addition: CREATE-ON-ADD. Stanislav Lomany

05/09/2015

03:52 PM User Interface Feature #2563 (WIP): implement GUI EDITOR widget
First candidate version for a usable EDITOR in GUI. Basic keys (cursor movement, home/end, delete/backspace, text ed... Constantin Asofiei
12:53 PM Database Bug #2570 (Closed): buffers must be members of the class which defines their tightest scope
The attached fix resolves the original problem and the items in notes 6-8. It has passed regression testing and is co... Eric Faulhaber
07:03 AM User Interface Feature #1811: implement the AJAX client driver
Merged with bzr 10855. Greg Shah
12:06 AM User Interface Feature #1811: implement the AJAX client driver
Merged with bzr 10853. Greg Shah
04:17 AM User Interface Feature #2252: implement GUI client support
Tha attached file replaces hc_upd20150508b.zip. It is merged with trunk, and was committed to bzr rev 10855. Hynek Cihlar
11:20 PM Bugs Bug #2569: memory leaks of procedure, buffer, handle resources
I had to step away for a few days to chase down a related task. Now I've had a chance to do some more debugging.
T...
Eric Faulhaber
09:48 PM User Interface Feature #2546: implement combo-box widget in GUI
The @evl_upd20150508d.zip@ has been committed as @10853@. Will be distributed shortly. Eugenie Lyzenko
09:31 PM User Interface Feature #2546: implement combo-box widget in GUI
The regression tests passed, results: @10850_eff7cc1_20150508_evl.zip@. Had to start 3-way @CTRL-C@ tests in separate... Eugenie Lyzenko
08:02 PM User Interface Feature #2546: implement combo-box widget in GUI
The main part completed, no regressions found. Waiting for @CTRL-C@ results. Eugenie Lyzenko

05/08/2015

06:15 PM User Interface Feature #2546: implement combo-box widget in GUI
Greg Shah wrote:
> Please coordinate with Hynek to determine which of you will check in first. I'm guessing that yo...
Eugenie Lyzenko
06:11 PM User Interface Feature #2546: implement combo-box widget in GUI
Code Review evl_upd20150508d.zip
Looks good.
Please coordinate with Hynek to determine which of you will check ...
Greg Shah
06:08 PM User Interface Feature #2546: implement combo-box widget in GUI
Several cosmetic changes to have the better look for combo-box. Only GUI code changed, so no additional testing is re... Eugenie Lyzenko
05:00 PM User Interface Feature #2546: implement combo-box widget in GUI
Update merged with the @10852@. Eugenie Lyzenko
04:28 PM User Interface Feature #2546: implement combo-box widget in GUI
Sounds good. Please note that you will need to merge with Vadim's @GuiWidgetFactory@ changes which are about to be c... Greg Shah
04:26 PM User Interface Feature #2546: implement combo-box widget in GUI
Greg Shah wrote:
> If you pass testing on 10850, you can check it in without re-testing.
OK. In this case I'm res...
Eugenie Lyzenko
04:18 PM User Interface Feature #2546: implement combo-box widget in GUI
I have finished one main cycle of the runtime testing(and have the good chances to be passed). But need another one t... Eugenie Lyzenko
04:16 PM User Interface Feature #2546: implement combo-box widget in GUI
If you pass testing on 10850, you can check it in without re-testing. Greg Shah
04:12 PM User Interface Feature #2546: implement combo-box widget in GUI
Eugenie Lyzenko wrote:
> The question. The update I'm testing has no crossing with @ecf_upd20150508a.zip@ and compat...
Constantin Asofiei
04:08 PM User Interface Feature #2546: implement combo-box widget in GUI
The question. The update I'm testing has no crossing with @ecf_upd20150508a.zip@ and compatible on the source level w... Eugenie Lyzenko
12:36 PM User Interface Feature #2546: implement combo-box widget in GUI
The missing file. Eugenie Lyzenko
12:30 PM User Interface Feature #2546: implement combo-box widget in GUI
Eugenie Lyzenko wrote:
> The merge with 10850 plus small fixes for opened drop-down. Will be used for regression tes...
Greg Shah
12:27 PM User Interface Feature #2546: implement combo-box widget in GUI
Eugenie Lyzenko wrote:
> Another questions:
> 1. What the widget is required to do to properly position/sizing with...
Constantin Asofiei
11:52 AM User Interface Feature #2546: implement combo-box widget in GUI
Another questions:
1. What the widget is required to do to properly position/sizing with layout manager in GUI?
2. ...
Eugenie Lyzenko
11:14 AM User Interface Feature #2546: implement combo-box widget in GUI
The merge with 10850 plus small fixes for opened drop-down. Will be used for regression testing. Eugenie Lyzenko
09:38 AM User Interface Feature #2546: implement combo-box widget in GUI
Eugenie Lyzenko wrote:
> >Well, you are relying on labelText.length() + 2 to determine the width in character units....
Constantin Asofiei
09:26 AM User Interface Feature #2546: implement combo-box widget in GUI
>Well, you are relying on labelText.length() + 2 to determine the width in character units... in GUI, this is no long... Eugenie Lyzenko
09:16 AM User Interface Feature #2546: implement combo-box widget in GUI
Eugenie Lyzenko wrote:
> >Can you post an example/screen shot of the distortions you mention?
> See the picture(com...
Constantin Asofiei
09:08 AM User Interface Feature #2546: implement combo-box widget in GUI
>Can you post an example/screen shot of the distortions you mention?
See the picture(compare to ..samlpe_04028_2.jpg ...
Eugenie Lyzenko
08:55 AM User Interface Feature #2546: implement combo-box widget in GUI
Eugenie Lyzenko wrote:
> >Please merge to rev 10849.
> Merged update is attached.
>
> >Post the merged update an...
Constantin Asofiei
08:51 AM User Interface Feature #2546: implement combo-box widget in GUI
>Please merge to rev 10849.
Merged update is attached.
>Post the merged update and get this into regression testi...
Eugenie Lyzenko
08:06 AM User Interface Feature #2546: implement combo-box widget in GUI
Code Review evl_upd20150507c.zip
The changes look good.
Please merge to rev 10849. Post the merged update and ...
Greg Shah
12:17 AM User Interface Feature #2546: implement combo-box widget in GUI
This is small protection improvement to the drop-down termination facility. Eugenie Lyzenko
05:08 PM User Interface Feature #2252: implement GUI client support
Constantin Asofiei wrote:
> Hynek Cihlar wrote:
> > The attached replaces hc_upd20150508a.zip and fixes a compilati...
Hynek Cihlar
02:18 PM User Interface Feature #2252: implement GUI client support
Code Review hc_upd20150508b.zip
I'm fine with the code once you have agreed with Constantin on the issue in note 9...
Greg Shah
12:55 PM User Interface Feature #2252: implement GUI client support
Hynek Cihlar wrote:
> The attached replaces hc_upd20150508a.zip and fixes a compilation error. Constantin, what was ...
Constantin Asofiei
12:02 PM User Interface Feature #2252: implement GUI client support
And the file...
Hynek Cihlar wrote:
> The attached replaces hc_upd20150508a.zip and fixes a compilation error. Co...
Hynek Cihlar
12:01 PM User Interface Feature #2252: implement GUI client support
The attached replaces hc_upd20150508a.zip and fixes a compilation error. Constantin, what was the purpose of ... Hynek Cihlar
11:52 AM User Interface Feature #2252: implement GUI client support
Constantin Asofiei wrote:
> Hynek Cihlar wrote:
> > The attached update improves window scrolling support. This is ...
Constantin Asofiei
11:49 AM User Interface Feature #2252: implement GUI client support
Hynek Cihlar wrote:
> The attached update improves window scrolling support. This is a first phase update focusing o...
Constantin Asofiei
11:43 AM User Interface Feature #2252: implement GUI client support
The attached update improves window scrolling support. This is a first phase update focusing on happy code paths. I a... Hynek Cihlar
11:26 AM User Interface Feature #2252: implement GUI client support
I just found the following in @ScrollBarGuiImpl@. Does anybody know the reason why mouse clicks are handled this way ... Hynek Cihlar
10:32 AM User Interface Feature #2252: implement GUI client support
Greg Shah wrote:
> Code Review ca_upd20150508b.zip
>
> I'm fine with the changes. Check them in.
Committed re...
Constantin Asofiei
10:29 AM User Interface Feature #2252: implement GUI client support
Code Review ca_upd20150508b.zip
I'm fine with the changes. Check them in.
Greg Shah
10:21 AM User Interface Feature #2252: implement GUI client support
Fixed a regression in rev 10849/ ca_upd20150508a.zip - window resize via mouse was no longer working properly. Constantin Asofiei
08:10 AM User Interface Feature #2252: implement GUI client support
Greg Shah wrote:
> > font scaling switched from using legacy metric scaling to DPI scaling (from 72 to OS DPI)
>
...
Constantin Asofiei
07:51 AM User Interface Feature #2252: implement GUI client support
> font scaling switched from using legacy metric scaling to DPI scaling (from 72 to OS DPI)
What are the implicati...
Greg Shah
07:31 AM User Interface Feature #2252: implement GUI client support
Greg Shah wrote:
> Code Review ca_upd20150508a.zip
>
> It's good. Please check it in.
Committed revision 10849.
Constantin Asofiei
07:27 AM User Interface Feature #2252: implement GUI client support
Code Review ca_upd20150508a.zip
It's good. Please check it in.
Greg Shah
03:44 AM User Interface Feature #2252: implement GUI client support
Greg Shah wrote:
> Code Review ca_upd20150507a.zip
>
> I'm generally fine with the changes. Unfortunately, your ...
Constantin Asofiei
04:37 PM User Interface Feature #2513: implement GUI runtime support for TOGGLE-BOX
I've fixed it and committed to revision 10852. Vadim Gindin
04:26 PM User Interface Feature #2513: implement GUI runtime support for TOGGLE-BOX
Code Review vig_upd20150509b.zip
In @ToggleBoxGuiImpl@, please change @CHKBOX_WIDHT@ to @CHKBOX_WIDTH@. Otherwise...
Greg Shah
04:21 PM User Interface Feature #2513: implement GUI runtime support for TOGGLE-BOX
I've fixed highlighting and checked ZeroColumnLayout change for CHUI. I've found that CHUI implementation also has bu... Vadim Gindin
03:38 PM User Interface Feature #2513: implement GUI runtime support for TOGGLE-BOX
Vadim Gindin wrote:
> Greg Shah wrote:
> > Code Review vig_upd20150509a.zip
> >
> > 1. Is your @ZeroColumnLayout...
Constantin Asofiei
03:25 PM User Interface Feature #2513: implement GUI runtime support for TOGGLE-BOX
Greg Shah wrote:
> Code Review vig_upd20150509a.zip
>
> 1. Is your @ZeroColumnLayout@ change safe for ChUI?
I ...
Vadim Gindin
03:17 PM User Interface Feature #2513: implement GUI runtime support for TOGGLE-BOX
Code Review vig_upd20150509a.zip
1. Is your @ZeroColumnLayout@ change safe for ChUI?
2. Please remove the @src/...
Greg Shah
02:42 PM User Interface Feature #2513: implement GUI runtime support for TOGGLE-BOX
I just wanted to fix highlighting for not standard size. Here is my current update. Vadim Gindin
02:36 PM User Interface Feature #2513: implement GUI runtime support for TOGGLE-BOX
What do you have left to do for this first pass? Greg Shah
02:28 PM User Interface Feature #2513: implement GUI runtime support for TOGGLE-BOX
Vadim Gindin wrote:
> Thank you. Here are my next 2 current layout bugs:
>
> # After I dynamically reset toggle-b...
Constantin Asofiei
01:08 PM User Interface Feature #2513: implement GUI runtime support for TOGGLE-BOX
Vadim Gindin wrote:
> Thank you. Here are my next 2 current layout bugs:
>
> # After I dynamically reset toggle-b...
Vadim Gindin
01:05 PM User Interface Feature #2513: implement GUI runtime support for TOGGLE-BOX
Thank you. Here are my next 2 current layout bugs:
# After I dynamically reset toggle-box label to ? 4GL automatic...
Vadim Gindin
10:47 AM User Interface Feature #2513: implement GUI runtime support for TOGGLE-BOX
Vadim Gindin wrote:
> I've tried to set these attributes for the static button, but no visible changes happen.
OK, ...
Constantin Asofiei
10:27 AM User Interface Feature #2513: implement GUI runtime support for TOGGLE-BOX
Constantin Asofiei wrote:
> Vadim Gindin wrote:
> > Constantin Asofiei wrote:
> > > Vadim Gindin wrote:
> > > > I...
Vadim Gindin
08:57 AM User Interface Feature #2513: implement GUI runtime support for TOGGLE-BOX
Vadim Gindin wrote:
> Constantin Asofiei wrote:
> > Vadim Gindin wrote:
> > > I've fixed it. Sorry to trouble.
> ...
Constantin Asofiei
08:43 AM User Interface Feature #2513: implement GUI runtime support for TOGGLE-BOX
Constantin Asofiei wrote:
> Vadim Gindin wrote:
> > I've fixed it. Sorry to trouble.
> What was the problem?
>
...
Vadim Gindin
07:32 AM User Interface Feature #2513: implement GUI runtime support for TOGGLE-BOX
Vadim Gindin wrote:
> I've fixed it. Sorry to trouble.
What was the problem?
There is a change in rev 10849 Thin...
Constantin Asofiei
07:30 AM User Interface Feature #2513: implement GUI runtime support for TOGGLE-BOX
I've fixed it. Sorry to trouble. Vadim Gindin
06:11 AM User Interface Feature #2513: implement GUI runtime support for TOGGLE-BOX
Constantin, I'm trying to find out the reason of the strange affect. See attached image.
First time the applicatio...
Vadim Gindin
05:07 AM User Interface Feature #2513: implement GUI runtime support for TOGGLE-BOX
Hynek:
I think afterConfigUpdate is in your case called from "apply config" call and afterSetWidthPixels() is exi...
Vadim Gindin
04:23 PM User Interface Feature #2422: add features to BROWSE
Code Review svl_upd20150508a.zip
It looks fine.
Please keep building the additional work for this week (2-6) on...
Greg Shah
04:11 PM User Interface Feature #2422: add features to BROWSE
Update for review. Contains INSERT-ROW/NEW-ROW basics. There are missing fixes for empty browse and "Cannot insert ro... Stanislav Lomany
01:48 PM User Interface Feature #2422: add features to BROWSE
> P2J has pushScreenDefinition() to sync server config with client. Do we have anything that makes similar action in ... Greg Shah
01:04 PM User Interface Feature #2422: add features to BROWSE
P2J has @pushScreenDefinition()@ to sync server config with client. Do we have anything that makes similar action in ... Stanislav Lomany
01:00 PM User Interface Feature #2422: add features to BROWSE
> Don't we already have a client-side widget for each column?
We have single fill-in which is created and then destr...
Stanislav Lomany
12:19 PM User Interface Feature #2422: add features to BROWSE
> Regarding 3, 4, 5 - should I solve fill-in problems? 3 and 4 may potentially turn out to be complicated.
Yes, le...
Greg Shah
12:15 PM User Interface Feature #2422: add features to BROWSE
Some planning info from SVL:
Here are the items left:
# INSERT-ROW basics - Will send today
# AUTO-ZAP/CURSOR-OFFSE...
Greg Shah
09:38 AM User Interface Feature #2422: add features to BROWSE
> What should it be in this case - set of FillIns and corresponding FillInWidgets on the server side with transparent... Greg Shah
07:24 AM User Interface Feature #2422: add features to BROWSE
I have some things about @AUTO-ZAP/CURSOR-OFFSET/CURRENT-ROW-MODIFIED@ to clear:
# How do we expect to implement att...
Stanislav Lomany
02:14 PM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
Greg Shah wrote:
> Please provide some details about the status of this task.
Greg,
I hope to finish the task at...
Igor Skornyakov
01:52 PM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
Please provide some details about the status of this task. Greg Shah
11:11 AM Base Language Feature #1628: fix any incompatibilities or missing features of NO-ECHO support
Good, this sounds promising. Please do implement the changes so that they are nicely separated (e.g. no ChUI/GUI-spe... Greg Shah
10:52 AM User Interface Feature #1811: implement the AJAX client driver
Merged with bzr 10850. Greg Shah
10:05 AM User Interface Feature #1811: implement the AJAX client driver
Both are fixed with this update. Greg Shah
09:59 AM User Interface Feature #1811: implement the AJAX client driver
Another issue: FontDetails.key is never set - it should be set by @FontManager$WorkArea.getFont@. Constantin Asofiei
09:46 AM User Interface Feature #1811: implement the AJAX client driver
Greg Shah wrote:
> Here is the update merged with bzr 10849.
There is a compilation problem in @WidgetBrowserAspect...
Constantin Asofiei
09:21 AM User Interface Feature #1811: implement the AJAX client driver
Here is the update merged with bzr 10849. Greg Shah

05/07/2015

06:54 PM User Interface Feature #1811: implement the AJAX client driver
Two other notes about my update:
1. The node "chuiWeb" in the directory needs to be changed to "webClient".
2. ...
Greg Shah
06:48 PM User Interface Feature #1811: implement the AJAX client driver
Following up on my note 651, the attached update is the first (partially working) pass at steps 1 - 7.
I have also...
Greg Shah
06:45 PM User Interface Feature #2546: implement combo-box widget in GUI
Finally I have found the fix for drop-down disappearing. So the new update for review is attached. Certainly this is ... Eugenie Lyzenko
05:56 PM User Interface Feature #2546: implement combo-box widget in GUI
This is the cleaned code for review. The UI drop-down disappearing issue is still here. Working on it. Eugenie Lyzenko
12:02 PM User Interface Feature #2546: implement combo-box widget in GUI
Eugenie Lyzenko wrote:
> Constantin, if you have some short answer please share. Does every mouse movement cause the...
Constantin Asofiei
11:56 AM User Interface Feature #2546: implement combo-box widget in GUI
>Shouldn't the WidgetFactoryAdapter.createDropDown() just throw an exception? Under what conditions will it actually ... Eugenie Lyzenko
08:36 AM User Interface Feature #2546: implement combo-box widget in GUI
Code Review evl_upd20150506a.zip
Generally, this looks good.
Shouldn't the @WidgetFactoryAdapter.createDropDown...
Greg Shah
11:51 PM User Interface Feature #2546: implement combo-box widget in GUI
This is the next step for review. Finally the scrollbar is working to use sroll-buttons to navigate drop-down.
The...
Eugenie Lyzenko
06:17 PM User Interface Feature #2513: implement GUI runtime support for TOGGLE-BOX
Here is my current update. I've fixed WIDTH/HEIGHT attributes calculation. Vadim Gindin
01:28 PM User Interface Feature #2513: implement GUI runtime support for TOGGLE-BOX
Thank you! It was a classpath problem. I had "/testcases/uast/font/system.metrics" folder in my classpath and after I... Vadim Gindin
01:15 PM User Interface Feature #2513: implement GUI runtime support for TOGGLE-BOX
Vadim Gindin wrote:
> Constantin Asofiei wrote:
> > About matching the label metrics in GUI with the legacy metrics...
Constantin Asofiei
01:11 PM User Interface Feature #2513: implement GUI runtime support for TOGGLE-BOX
Constantin Asofiei wrote:
> About matching the label metrics in GUI with the legacy metrics as on windev01.
> # Aft...
Vadim Gindin
09:17 AM User Interface Feature #2513: implement GUI runtime support for TOGGLE-BOX
About matching the label metrics in GUI with the legacy metrics as on windev01.
# After each conversion, there is a ...
Constantin Asofiei
09:13 AM User Interface Feature #2513: implement GUI runtime support for TOGGLE-BOX
In looking at your screen-shots, is the P2J toggle-box shadow color correct? It seems too dark. Greg Shah
08:53 AM User Interface Feature #2513: implement GUI runtime support for TOGGLE-BOX
Vadim Gindin wrote:
> About label width for widgets: @gd.getTextWidth("tbx", gf.font().font)@ has returned 13. Is it...
Constantin Asofiei
08:52 AM User Interface Feature #2513: implement GUI runtime support for TOGGLE-BOX
Vadim Gindin wrote:
> About WIDTH*/HEIGHT* attributes initialization problem. Hynek proposed me to initialize these ...
Constantin Asofiei
08:50 AM User Interface Feature #2513: implement GUI runtime support for TOGGLE-BOX
Greg Shah wrote:
> About the window clearing, I don't think this has anything to do with the toggle-box. We will wo...
Vadim Gindin
08:45 AM User Interface Feature #2513: implement GUI runtime support for TOGGLE-BOX
About the window clearing, I don't think this has anything to do with the toggle-box. We will work it in another task. Greg Shah
08:34 AM User Interface Feature #2513: implement GUI runtime support for TOGGLE-BOX
Greg Shah wrote:
> Please post 2 screen captures (of the 4GL and P2J) so I can understand what you mean.
I'm post...
Vadim Gindin
08:22 AM User Interface Feature #2513: implement GUI runtime support for TOGGLE-BOX
About WIDTH*/HEIGHT* attributes initialization problem. Hynek proposed me to initialize these fields in @ToggleBox.in... Vadim Gindin
08:17 AM User Interface Feature #2513: implement GUI runtime support for TOGGLE-BOX
Please post 2 screen captures (of the 4GL and P2J) so I can understand what you mean. Greg Shah
07:45 AM User Interface Feature #2513: implement GUI runtime support for TOGGLE-BOX
Greg Shah wrote:
> > But 4GL clears the window and P2J - does not. Should I fix it?
>
> Do you mean that the fram...
Vadim Gindin
07:36 AM User Interface Feature #2513: implement GUI runtime support for TOGGLE-BOX
> But 4GL clears the window and P2J - does not. Should I fix it?
Do you mean that the frame f is still displayed i...
Greg Shah
04:02 AM User Interface Feature #2513: implement GUI runtime support for TOGGLE-BOX
Greg, thank you! "F2" is mapped on "GO" event in GUI. I've tested GO event. It works for toggle-box. Trigger @on go o... Vadim Gindin
03:45 AM User Interface Feature #2513: implement GUI runtime support for TOGGLE-BOX
Greg Shah wrote:
> > >
> > > This is incorrect. @GO@ is a frame-level event. Try @on go of frame f@ instead of @...
Vadim Gindin
04:54 PM User Interface Feature #2252: implement GUI client support
Code Review ca_upd20150507a.zip
I'm generally fine with the changes. Unfortunately, your nice changes are going t...
Greg Shah
03:57 PM User Interface Feature #2252: implement GUI client support
Fixes following issues:
# frame title in GUI - centered vertically and fixed frame height problems. Also, it uses th...
Constantin Asofiei
03:36 PM Base Language Feature #1628: fix any incompatibilities or missing features of NO-ECHO support
All other issues are resolved. All tests has been passed if I exclude changes from Window and ThinClient classes (exc... Evgeny Kiselev
03:18 AM Database Bug #2570: buffers must be members of the class which defines their tightest scope
The third item in note 6 was actually a more serious latent bug than I thought. Buffer name conflict resolution was g... Eric Faulhaber

05/06/2015

07:00 PM User Interface Feature #2513: implement GUI runtime support for TOGGLE-BOX
> So it is not fixed yet.. Should I work on it now anyway?
Actually, yes. Constantin's changes are already checke...
Greg Shah
06:59 PM User Interface Feature #2513: implement GUI runtime support for TOGGLE-BOX
> >
> > This is incorrect. @GO@ is a frame-level event. Try @on go of frame f@ instead of @on go of lll@ will not...
Greg Shah
06:24 PM User Interface Feature #2513: implement GUI runtime support for TOGGLE-BOX
"2. Make sure ASSIGN and SCREEN-VALUE after WAIT-FOR work."
I've checked. P2J works as 4GL. Here is my test case:
...
Vadim Gindin
05:59 PM User Interface Feature #2513: implement GUI runtime support for TOGGLE-BOX
Greg Shah wrote:
> > I mean that the last message "after .." is not printed, i.e. execution is stopped before this s...
Vadim Gindin
05:56 PM User Interface Feature #2513: implement GUI runtime support for TOGGLE-BOX
> I mean that the last message "after .." is not printed, i.e. execution is stopped before this statement.
The pro...
Greg Shah
05:25 PM User Interface Feature #2513: implement GUI runtime support for TOGGLE-BOX
Greg Shah wrote:
> This testcase doesn't seem correct. In the 4GL, the @UPDATE@ statement is roughly equivalent to ...
Vadim Gindin
04:25 PM User Interface Feature #2513: implement GUI runtime support for TOGGLE-BOX
This testcase doesn't seem correct. In the 4GL, the @UPDATE@ statement is roughly equivalent to @ENABLE@ + @WAIT-FOR... Greg Shah
04:14 PM User Interface Feature #2513: implement GUI runtime support for TOGGLE-BOX
There is a strange thing with UPDATE statement for toggle-box. Have a look at this procedure:... Vadim Gindin
11:11 AM User Interface Feature #2513: implement GUI runtime support for TOGGLE-BOX
In regard to the WIDTH/HEIGHT issue, Hynek reported the following:
> I tested your sample. The problem doesn't see...
Greg Shah
10:44 AM User Interface Feature #2513: implement GUI runtime support for TOGGLE-BOX
Code Review vig_upd20150506a.zip
I'm OK with the code so far.
Since MAJIC doesn't use toggle-boxes and your cha...
Greg Shah
10:40 AM User Interface Feature #2513: implement GUI runtime support for TOGGLE-BOX
> This test works fine (P2J like Progress). both toggle-boxes are checked and message area contains the string "yes".... Greg Shah
08:43 AM User Interface Feature #2513: implement GUI runtime support for TOGGLE-BOX
I forgot to add, that at this moment WIDTH/HEIGHT attributes are calculated improperly at this moment. Here is my cur... Vadim Gindin
08:36 AM User Interface Feature #2513: implement GUI runtime support for TOGGLE-BOX
Greg Shah wrote:
> The 4GL docs say that @VALUE-CHANGED@ should work. Make sure that your testcase is correct. Tha...
Vadim Gindin
08:12 AM User Interface Feature #2513: implement GUI runtime support for TOGGLE-BOX
Greg Shah wrote:
> Vadim Gindin wrote:
> > If user presses mouse on checkbox and starts dragging the mouse over it ...
Vadim Gindin
02:26 PM Base Language Feature #1628: fix any incompatibilities or missing features of NO-ECHO support
Code Review evk_upd20150504a.zip
1. @import org.apache.commons.logging.*;@ should not be added to @Stream.java@.
...
Greg Shah
12:16 PM Base Language Feature #1628: fix any incompatibilities or missing features of NO-ECHO support
Thx, I've fixed it. now it's working fine for if I worked from p2j.jar instead of using code. Evgeny Kiselev
02:26 AM Base Language Feature #1628: fix any incompatibilities or missing features of NO-ECHO support
Evgeny Kiselev wrote:
> merged with latest revision
> moved cursorInvalid to the BasePrimitives
> But I couldn't t...
Constantin Asofiei
01:25 PM Database Bug #2570: buffers must be members of the class which defines their tightest scope
> With my update, it doesn't compile.
Congrats! You made it more correct. :)
Greg Shah
01:22 PM Database Bug #2570: buffers must be members of the class which defines their tightest scope
The types of failures I'm seeing:
* A buffer which previously was a top-level instance variable is referenced in a...
Eric Faulhaber
12:31 PM Database Bug #2570: buffers must be members of the class which defines their tightest scope
Greg Shah wrote:
> Code Review ecf_upd20150506a.zip
>
> I don't see much in the way of problems. Where there man...
Eric Faulhaber
10:04 AM Database Bug #2570: buffers must be members of the class which defines their tightest scope
Code Review ecf_upd20150506a.zip
I don't see much in the way of problems. Where there many changes to the MAJIC c...
Greg Shah
03:58 AM Database Bug #2570: buffers must be members of the class which defines their tightest scope
I've decided to defer the name conflict improvements indefinitely, as it turns out there's a lot of potential breakag... Eric Faulhaber
12:08 PM User Interface Feature #2422: add features to BROWSE
Implemented REFRESHABLE and ADD-LIKE-COLUMN. Committed to bzr rev 10848. Stanislav Lomany
09:35 AM User Interface Feature #2422: add features to BROWSE
> So CREATE-ON-ADD is added to the GUI list.
OK, please add notes to #2564 so that this is not missed.
Also: if...
Greg Shah
09:52 PM User Interface Feature #2422: add features to BROWSE
About @CREATE-ON-ADD@. At this point it cannot be implemented because:
1. I do not quite understand what it does. He...
Stanislav Lomany

05/05/2015

05:09 PM User Interface Feature #2513: implement GUI runtime support for TOGGLE-BOX
Vadim Gindin wrote:
> If user presses mouse on checkbox and starts dragging the mouse over it checkbox background is...
Greg Shah
05:07 PM User Interface Feature #2513: implement GUI runtime support for TOGGLE-BOX
The 4GL docs say that @VALUE-CHANGED@ should work. Make sure that your testcase is correct. That event is probably ... Greg Shah
01:14 PM User Interface Feature #2513: implement GUI runtime support for TOGGLE-BOX
I've checked attributes and events. P2J works as Progress. VALUE-CHANGED event is not working for both Progress and P... Vadim Gindin
10:13 AM User Interface Feature #2513: implement GUI runtime support for TOGGLE-BOX
If user presses mouse on checkbox and starts dragging the mouse over it checkbox background is colored to some other ... Vadim Gindin
03:36 AM User Interface Feature #2513: implement GUI runtime support for TOGGLE-BOX
Static case works fine: both P2J and Progress shows toggle-box in one row after the button "exit". Vadim Gindin
03:25 AM User Interface Feature #2513: implement GUI runtime support for TOGGLE-BOX
Vadim Gindin wrote:
> Addition to previous note. If I'll remove @skip(1)@ expression from the frame definition, than...
Constantin Asofiei
03:22 AM User Interface Feature #2513: implement GUI runtime support for TOGGLE-BOX
Addition to previous note. If I'll remove @skip(1)@ expression from the frame definition, than Progress will show tog... Vadim Gindin
02:18 AM User Interface Feature #2513: implement GUI runtime support for TOGGLE-BOX
Just for documenting purpose. This testcase also shows wrong placement of toggle-box. Progress shows toggle-box at th... Vadim Gindin
04:17 PM Database Bug #2570: buffers must be members of the class which defines their tightest scope
There were regressions with naming conflicts. Working on a fix. Eric Faulhaber
12:10 PM Database Bug #2570: buffers must be members of the class which defines their tightest scope
P2J incorrectly creates all record buffers as instance members of the top level class. Buffers scoped more tightly th... Eric Faulhaber
11:46 AM Database Bug #2570 (Closed): buffers must be members of the class which defines their tightest scope
Eric Faulhaber
09:33 AM Base Language Feature #1628: fix any incompatibilities or missing features of NO-ECHO support
merged with latest revision
moved cursorInvalid to the BasePrimitives
But I couldn't test it now (after merged 29.0...
Evgeny Kiselev

05/04/2015

02:30 PM User Interface Feature #2513: implement GUI runtime support for TOGGLE-BOX
I'm working on WIDTH/HEIGHT attributes and after the last update this attributes became 0. Don't you know why? And wh... Vadim Gindin
12:30 PM Bugs Bug #2569: memory leaks of procedure, buffer, handle resources
Constantin Asofiei wrote:
> [...]
> Attached solves this issue.
Confirmed, no more warnings in the log. Performan...
Eric Faulhaber
11:08 AM Bugs Bug #2569: memory leaks of procedure, buffer, handle resources
Constantin Asofiei wrote:
> Eric Faulhaber wrote:
> > Test runs with the last few updates have been noticeably slow...
Eric Faulhaber
09:25 AM Bugs Bug #2569: memory leaks of procedure, buffer, handle resources
Eric Faulhaber wrote:
> Test runs with the last few updates have been noticeably slower (~2.5x).
Are there regress...
Constantin Asofiei
02:22 AM Bugs Bug #2569: memory leaks of procedure, buffer, handle resources
Test runs with the last few updates have been noticeably slower (~2.5x). I haven't profiled yet to determine the caus... Eric Faulhaber
11:01 AM User Interface Feature #2422: add features to BROWSE
20150504a looks OK to me from the persistence side. Eric Faulhaber
09:35 AM User Interface Feature #2422: add features to BROWSE
Code Review svl_upd20150504a.zip
1. In @ThinClient.queryClosed()@ and @ThinClient.refreshScrollRow()@, the call to...
Greg Shah
03:19 AM User Interface Feature #2422: add features to BROWSE
All the flaws fixed. Stanislav Lomany
10:02 AM User Interface Feature #2446 (Closed): implement BUTTON and IMAGE GUI widgets (runtime and conversion support)
Greg Shah
10:01 AM User Interface Feature #2545 (Closed): add support for specially named button images
Greg Shah
10:00 AM User Interface Feature #2545: add support for specially named button images
@evl_upd20150503a.zip@ has been committed as @10847@. Eugenie Lyzenko
09:45 AM User Interface Feature #2545: add support for specially named button images
Greg Shah wrote:
> Code Review evl_upd20150503a.zip
>
> It looks good. Check it in when it passes testing.
Th...
Eugenie Lyzenko
09:27 AM User Interface Feature #2545: add support for specially named button images
Code Review evl_upd20150503a.zip
It looks good. Check it in when it passes testing.
Greg Shah
10:01 AM User Interface Bug #2452 (Closed): Button label resize fails with error 4054
Greg Shah
09:48 AM User Interface Bug #2452: Button label resize fails with error 4054
The fix for this issue is included into update for task #2545 for commit and distribute, @evl_upd20150503a.zip@. Pass... Eugenie Lyzenko

05/03/2015

06:31 PM User Interface Feature #2545: add support for specially named button images
The code is the merge with @10846@ and small change to label cutting approach. With the recent changes the frame widt... Eugenie Lyzenko
09:40 AM User Interface Feature #2545: add support for specially named button images
Please merge to bzr 10846 and get this tested. Greg Shah
04:48 PM Bugs Bug #2569: memory leaks of procedure, buffer, handle resources
Constantin Asofiei wrote:
> Please try this version. I think it might solve your problem: previously the postponed ...
Eric Faulhaber
04:40 PM Bugs Bug #2569: memory leaks of procedure, buffer, handle resources
Constantin Asofiei wrote:
> Is this from an intermediate state or final state, when everything should have cleaned u...
Eric Faulhaber
04:38 PM Bugs Bug #2569: memory leaks of procedure, buffer, handle resources
Eric Faulhaber wrote:
> > [...] And I don't think the right place is in @BufferImpl.resourceDelete@ - the proper pla...
Constantin Asofiei
03:51 PM Bugs Bug #2569: memory leaks of procedure, buffer, handle resources
Eric Faulhaber wrote:
> The 0503a appears to be working as designed with respect to cleaning up the reference chain ...
Constantin Asofiei
03:50 PM Bugs Bug #2569: memory leaks of procedure, buffer, handle resources
The 0503a appears to be working as designed with respect to cleaning up the reference chain previously pinned by @Tem... Eric Faulhaber
02:58 PM Bugs Bug #2569: memory leaks of procedure, buffer, handle resources
Constantin Asofiei wrote:
> Are there any other references to the @proxies to static temp-tables@ (the end of the ch...
Eric Faulhaber
02:10 PM Bugs Bug #2569: memory leaks of procedure, buffer, handle resources
I've just noticed the handle's logging for invalid resources is too noisy, it gets logged for valid cases (as when a ... Constantin Asofiei
01:56 PM Bugs Bug #2569: memory leaks of procedure, buffer, handle resources
Eric Faulhaber wrote:
> Constantin Asofiei wrote:
> > I don't understand something: aren't the @TemporaryBuffer@ an...
Constantin Asofiei
12:19 PM Bugs Bug #2569: memory leaks of procedure, buffer, handle resources
Constantin Asofiei wrote:
> I don't understand something: aren't the @TemporaryBuffer@ and @TempTableBuilder@ instan...
Eric Faulhaber
06:54 AM Bugs Bug #2569: memory leaks of procedure, buffer, handle resources
Eric Faulhaber wrote in #2555 note 53:
> I tried a few tests and spent a lot of time in the debugger tonight. We sti...
Constantin Asofiei
06:41 AM Bugs Bug #2569: memory leaks of procedure, buffer, handle resources
Eric Faulhaber wrote:
> A related matter is that since all dynamically defined temp-tables are created at global sco...
Constantin Asofiei
05:17 AM Bugs Bug #2569: memory leaks of procedure, buffer, handle resources
For better readability of the content in the last last post, please see attached file. Eric Faulhaber
05:15 AM Bugs Bug #2569: memory leaks of procedure, buffer, handle resources
A related matter is that since all dynamically defined temp-tables are created at global scope, we have additional, s... Eric Faulhaber
05:05 AM Bugs Bug #2569: memory leaks of procedure, buffer, handle resources
See #2555 for the beginning of this discussion, which diverged from the original focus of that issue. Eric Faulhaber
05:03 AM Bugs Bug #2569 (Closed): memory leaks of procedure, buffer, handle resources
Eric Faulhaber
01:23 PM User Interface Feature #2422: add features to BROWSE
Code Review svl_upd20150503a.zip
Eric: please review.
1. Shouldn't there be a @methods_attributes.rules@ change...
Greg Shah
12:32 PM User Interface Feature #2422: add features to BROWSE
Update for review - REFRESHABLE and ADD-LIKE-COLUMN. Stanislav Lomany
03:33 AM User Interface Feature #1790: implement menu support
There were 2 failed test that was not being recreated during manual testing. So, I've committed current changes with ... Vadim Gindin

05/02/2015

02:35 PM User Interface Feature #1790: implement menu support
> Should I ignore this error?
If I understand correctly, you are saying that your manual testing could not recreat...
Greg Shah
02:54 AM User Interface Feature #1790: implement menu support
So, I've checked gso_269. It also is not reproduced as tc_code_employees_261 manually (as tc_code_employees_264 in th... Vadim Gindin
01:39 AM User Interface Feature #1790: implement menu support
Constantin Asofiei wrote:
> Vadim, what update are these results from? Because I can recreate it with your 0430a.zip...
Vadim Gindin
12:42 AM Database Bug #2568: Possibly wrong default column label value
P2J returns an empty string if a label or column label is not specified, so it is not clear how distinguish cases whe... Stanislav Lomany
12:36 AM Database Bug #2568 (New): Possibly wrong default column label value
Stanislav Lomany
08:50 PM User Interface Feature #2546: implement combo-box widget in GUI
This is the next step for review in combo-box GUI widget implementation. So what it can:
1. Complete keyboard suppor...
Eugenie Lyzenko

05/01/2015

04:54 PM User Interface Feature #1790: implement menu support
You can check in your code as soon as it passes, unless you have to make some other fix besides the history entry men... Greg Shah
04:15 PM User Interface Feature #1790: implement menu support
Code Review vig_upd20150501b.zip
Please just add a history entry to @MenuWidget@. Otherwise it looks good.
Greg Shah
03:52 PM User Interface Feature #1790: implement menu support
OK. There was some mess with that. I hope, you right, moreover my update passed successfully regression testing befor... Vadim Gindin
12:44 PM User Interface Feature #1790: implement menu support
Vadim, what update are these results from? Because I can recreate it with your 0430a.zip but not with 0430b.zip.
A...
Constantin Asofiei
11:11 AM User Interface Feature #1790: implement menu support
Vadim Gindin wrote:
> Constantin Asofiei wrote:
> > Vadim Gindin wrote:
> > > I've checked gso_17 test, the first ...
Constantin Asofiei
11:09 AM User Interface Feature #1790: implement menu support
Constantin Asofiei wrote:
> Vadim Gindin wrote:
> > I've checked gso_17 test, the first failed test and found the f...
Vadim Gindin
04:39 AM User Interface Feature #1790: implement menu support
Vadim Gindin wrote:
> I've checked gso_17 test, the first failed test and found the following. During the test there...
Constantin Asofiei
04:38 AM User Interface Feature #1790: implement menu support
Vadim Gindin wrote:
> There are a lot of similar errors where generated files differ from expected. But there are an...
Constantin Asofiei
02:24 AM User Interface Feature #1790: implement menu support
There are a lot of similar errors where generated files differ from expected. But there are another errors exist. I'v... Vadim Gindin
02:00 AM User Interface Feature #1790: implement menu support
I've checked gso_17 test, the first failed test and found the following. During the test there are gso_17.txt is gene... Vadim Gindin
01:03 AM User Interface Feature #1790: implement menu support
This update (after merge) failed regression testing: gso_tests (19) tc_tests (24). I'm working on it. Vadim Gindin
03:34 PM User Interface Feature #2545: add support for specially named button images
Code Review evl_upd20150501a.zip
It's good.
> Now the conversion testing is not required because is was already...
Greg Shah
03:25 PM User Interface Feature #2545: add support for specially named button images
This is the merge with @10845@. Now the conversion testing is not required because is was already done(as part of the... Eugenie Lyzenko
11:14 AM User Interface Feature #1798: implement full frame family support (parent-child relationships between frames)
Greg Shah wrote:
> Code Review ca_upd20150501a.zip
>
> It looks good. Check it in when it passes.
Committed rev...
Constantin Asofiei
10:35 AM User Interface Feature #1798: implement full frame family support (parent-child relationships between frames)
Code Review ca_upd20150501a.zip
It looks good. Check it in when it passes.
Greg Shah
05:44 AM User Interface Feature #1798: implement full frame family support (parent-child relationships between frames)
Merged version of 0421a.zip with rev 10844. Conversion testing passed, runtime testing is starting (it should pass t... Constantin Asofiei
05:10 AM User Interface Feature #2564: implement GUI BROWSE widget
Addition to the list:
MIN-HEIGHT-CHARS
SORT - I think that actually means implementation of drop-down cells
Stanislav Lomany
05:06 AM User Interface Feature #2422: add features to BROWSE
> If I understand correctly, then we have the following categories:
>
> 1. features currently being implemented
K...
Stanislav Lomany
05:04 AM User Interface Feature #2422: add features to BROWSE
Here is the list of all remaining features:
*GUI-specific*
FIT-LAST-COLUMN/EXPANDABLE
NO-COLUMN-SCROLLING
ROW...
Stanislav Lomany
04:04 AM User Interface Feature #2252: implement GUI client support
Greg Shah wrote:
> Code Review ca_upd20150429a.zip
>
> This is a really good update. I suspect it is cleaning up...
Constantin Asofiei
 

Also available in: Atom