Project

General

Profile

Activity

From 11/27/2017 to 12/26/2017

12/26/2017

03:47 PM User Interface Feature #3394: generic drawing improvements: repaint and other misc code
3394a/11309 has passed ETF full search, developer, and batch tests. Eric Faulhaber
10:42 AM User Interface Feature #3394: generic drawing improvements: repaint and other misc code
Constantin Asofiei wrote:
> Please try 3394a 11309 - I think I had an unbalanced scope start/delete in SVM.
That di...
Eric Faulhaber
04:06 AM User Interface Feature #3394: generic drawing improvements: repaint and other misc code
Eric Faulhaber wrote:
> There is a regression in task branch 3394a. ETF search testing grinds to a halt after a few ...
Constantin Asofiei

12/25/2017

04:03 PM User Interface Feature #3394: generic drawing improvements: repaint and other misc code
There is a regression in task branch 3394a. ETF search testing grinds to a halt after a few minutes with multiple "No... Eric Faulhaber
07:46 PM Base Language Bug #3406: implement silent error mode as a lambda to allow aborting the control flow
Greg, I've left changes for browse TODOs in 3406b rev 11214. Stanislav Lomany

12/23/2017

05:33 PM User Interface Feature #2368: allow widget output to stream in GUI mode
Constantin Asofiei wrote:
> Hynek, can you give me a simple standalone test which shows a few of the failures you de...
Hynek Cihlar
04:10 PM User Interface Feature #2368: allow widget output to stream in GUI mode
Hynek, can you give me a simple standalone test which shows a few of the failures you describe in the previous note? Constantin Asofiei
09:59 AM User Interface Feature #2368: allow widget output to stream in GUI mode
There are numerous places where @ClassCastException@ is thrown when in GUI redirected mode and an @ALERT-BOX@ or an e... Hynek Cihlar
04:22 AM User Interface Bug #3373 (Review): incremental scroll in non-full Browse page
Stanislav Lomany
03:36 AM Base Language Bug #3406: implement silent error mode as a lambda to allow aborting the control flow
Created task branch 3406b from trunk rev 11213. Stanislav Lomany

12/22/2017

06:35 PM Base Language Feature #3262: implement COM/OLE Automation support
The revision @11308@ gives the same converted code for @COM@ sample testcases I have used in @COM@ native implementat... Eugenie Lyzenko
05:22 PM Base Language Feature #3262: implement COM/OLE Automation support
There is an issue with how we convert LOAD-CONTROLS. We've decide to treat every COM access as a generic call (witho... Constantin Asofiei
11:34 AM User Interface Feature #3394: generic drawing improvements: repaint and other misc code
I've tested 3394a revision 11307 with Hotel GUI. It fixes the abend (Check-In then Add) and it fixes the tree contro... Greg Shah
08:33 AM User Interface Feature #3394: generic drawing improvements: repaint and other misc code
Rebased 3394a from trunk rev 11213 - new revision 11304.
3394a rev 11305 contains javadoc and history header fixes.
Constantin Asofiei
10:08 AM User Interface Bug #3425: text is drawn 1-pixel to the left, cutting the text
> So, rollback these two revisions in 3394a and commit them.
Done.
Stanislav Lomany
09:23 AM User Interface Bug #3425: text is drawn 1-pixel to the left, cutting the text
Stanislav Lomany wrote:
> > Stanislav: Please take this task. Please remove the changes for 11296/11297 such that i...
Constantin Asofiei
09:23 AM User Interface Bug #3425: text is drawn 1-pixel to the left, cutting the text
> Do you want me to revert 11296/11297 and then you merge 3394 and I check into another branch
This one. The fix ...
Greg Shah
09:21 AM User Interface Bug #3425: text is drawn 1-pixel to the left, cutting the text
> Stanislav: Please take this task. Please remove the changes for 11296/11297 such that it won't cause regressions. ... Stanislav Lomany
09:13 AM User Interface Bug #3425: text is drawn 1-pixel to the left, cutting the text
Greg Shah wrote:
> Stanislav: Please take this task. Please remove the changes for 11296/11297 such that it won't c...
Constantin Asofiei
09:09 AM User Interface Bug #3425: text is drawn 1-pixel to the left, cutting the text
Stanislav: Please take this task. Please remove the changes for 11296/11297 such that it won't cause regressions. I... Greg Shah
09:07 AM User Interface Bug #3425: text is drawn 1-pixel to the left, cutting the text
Is this code from @BrowseGuiImpl.doLayout()@ correct?... Sergey Ivanovskiy
08:49 AM User Interface Bug #3425: text is drawn 1-pixel to the left, cutting the text
Stanislav Lomany wrote:
> > Stanislav, please describe font settings thoroughly, what are fonts without anti-aliasin...
Sergey Ivanovskiy
08:22 AM User Interface Bug #3425: text is drawn 1-pixel to the left, cutting the text
> Stanislav, please describe font settings thoroughly, what are fonts without anti-aliasing?
I don't know, but th...
Stanislav Lomany
08:12 AM User Interface Bug #3425: text is drawn 1-pixel to the left, cutting the text
The rev.11297, 11301 don't make changes for column widths. It is supposed that they are calculated correctly. Sergey Ivanovskiy
08:03 AM User Interface Bug #3425: text is drawn 1-pixel to the left, cutting the text
Did you build a font-metrics file for the strings from your test? Sergey Ivanovskiy
08:01 AM User Interface Bug #3425: text is drawn 1-pixel to the left, cutting the text
Stanislav Lomany wrote:
> It is not clear if actual P2J version (rev 11295) has issues with clipping (please use fon...
Sergey Ivanovskiy
07:43 AM User Interface Bug #3425: text is drawn 1-pixel to the left, cutting the text
It is not clear if actual P2J version (rev 11295) has issues with clipping (please use fonts without anti-aliasing fo... Stanislav Lomany
07:10 AM User Interface Bug #3425: text is drawn 1-pixel to the left, cutting the text
I'm not good, wait a bit. Stanislav Lomany
07:09 AM User Interface Bug #3425: text is drawn 1-pixel to the left, cutting the text
If Stanislav is OK with these changes, then we are good to go. Greg Shah
04:52 AM User Interface Bug #3425: text is drawn 1-pixel to the left, cutting the text
Yes. Agree, committed rev 11301. Sergey Ivanovskiy
09:12 AM Base Language Bug #3406: implement silent error mode as a lambda to allow aborting the control flow
Greg Shah wrote:
> > in ControlFlowOps - is the H061 still needed?
>
> No, not after trunk rev 11213.
Backed ou...
Constantin Asofiei
09:05 AM Base Language Bug #3406: implement silent error mode as a lambda to allow aborting the control flow
> in ControlFlowOps - is the H061 still needed?
No, not after trunk rev 11213.
Greg Shah
08:31 AM Base Language Bug #3406: implement silent error mode as a lambda to allow aborting the control flow
Greg, in @ControlFlowOps@ - is the H061 still needed?... Constantin Asofiei
12:54 AM Base Language Bug #3406: implement silent error mode as a lambda to allow aborting the control flow
3406a/11232 has passed ETF search, dev, and batch testing, main regression testing, and ctrl+c testing. The branch wa... Eric Faulhaber
08:25 PM Base Language Bug #3406: implement silent error mode as a lambda to allow aborting the control flow
Follow-up: I tested with trunk; same error.
However, it's fixed in 3394a (tested with 11299), so... never mind.
Eric Faulhaber
08:01 PM Base Language Bug #3406: implement silent error mode as a lambda to allow aborting the control flow
Is this a known Hotel GUI issue? I hit this while trying to check in a guest on the "Available" screen first thing af... Eric Faulhaber
08:24 PM User Interface Bug #3381: Sub-menu drawing issues
Hynek Cihlar wrote:
> With the latest 3394a the multiple selection issue is fixed and the Esc key works properly. Ho...
Eugenie Lyzenko

12/21/2017

05:56 PM User Interface Bug #3425: text is drawn 1-pixel to the left, cutting the text
Greg Shah wrote:
> Stanislav/Hynek: please review.
Formally, I don't see anything wrong with the code. Maybe I wo...
Hynek Cihlar
03:44 PM User Interface Bug #3425: text is drawn 1-pixel to the left, cutting the text
Code Review Task Branch 3394a Revisions 11296/7
I don't see a specific issue with the changes. However, the valid...
Greg Shah
03:12 PM User Interface Bug #3425: text is drawn 1-pixel to the left, cutting the text
Please review committed revision 11297. Sergey Ivanovskiy
02:40 PM User Interface Bug #3425: text is drawn 1-pixel to the left, cutting the text
Please review committed revision 11296 that should fix drawing of labels with help of #3394-88. Sergey Ivanovskiy
05:21 PM Base Language Bug #3406: implement silent error mode as a lambda to allow aborting the control flow
I have manually tested Hotel GUI (Swing, Virtual Desktop and Embedded Modes) in both 3406a (11232) and trunk (11212).... Greg Shah
11:25 AM Base Language Bug #3406: implement silent error mode as a lambda to allow aborting the control flow
Task branch 3406a has been rebased to p2j trunk revision 11212. Eric Faulhaber
01:25 AM Base Language Bug #3406: implement silent error mode as a lambda to allow aborting the control flow
3406a/11226 has passed dev, search, and batch ETF testing. Two runs of main runtime regression testing show a handful... Eric Faulhaber
05:09 PM User Interface Bug #3381: Sub-menu drawing issues
Hynek Cihlar wrote:
> I'll try to rephrase what the problem is. When you open a submenu body, none of the menu items...
Eugenie Lyzenko
04:47 PM User Interface Bug #3381: Sub-menu drawing issues
Eugenie Lyzenko wrote:
> Hynek Cihlar wrote:
> >
> > Yes, this is it. You can see it in the gif close to the end ...
Hynek Cihlar
04:42 PM User Interface Bug #3381: Sub-menu drawing issues
Hynek Cihlar wrote:
>
> Yes, this is it. You can see it in the gif close to the end of the playback.
But in @FW...
Eugenie Lyzenko
04:35 PM User Interface Bug #3381: Sub-menu drawing issues
Eugenie Lyzenko wrote:
> Hynek Cihlar wrote:
> > 4. Menu item is highlighted when its submenu is opened, it should ...
Hynek Cihlar
04:32 PM User Interface Bug #3381: Sub-menu drawing issues
Hynek Cihlar wrote:
> 4. Menu item is highlighted when its submenu is opened, it should not be.
I do not understa...
Eugenie Lyzenko
04:22 PM User Interface Bug #3381: Sub-menu drawing issues
Eugenie Lyzenko wrote:
> > 2. There is a noticable lag when navigating from one root submenu to another, in native 4...
Hynek Cihlar
04:20 PM User Interface Bug #3381: Sub-menu drawing issues
Hynek Cihlar wrote:
> With the latest 3394a the multiple selection issue is fixed and the Esc key works properly. Ho...
Eugenie Lyzenko
04:13 PM User Interface Bug #3381: Sub-menu drawing issues
With the latest 3394a the multiple selection issue is fixed and the Esc key works properly. However there are some ne... Hynek Cihlar
01:03 PM User Interface Bug #3381: Sub-menu drawing issues
Task branch @3394a@ has been updated for review to revision @11295@.
This is new approach to control menu item sel...
Eugenie Lyzenko
06:56 AM User Interface Bug #3381: Sub-menu drawing issues
Code Review Task Branch 3394a Revision 11293
I'm OK with the changes.
> I think in 4GL the ESC handling is not...
Greg Shah
10:18 PM User Interface Bug #3381: Sub-menu drawing issues
Task branch @3394a@ has been updated for review to revision @11293@.
This is suggested fix for @ESC@ key processin...
Eugenie Lyzenko
02:20 PM User Interface Feature #3369: add support for BGCOLOR-RGB and FGCOLOR-RGB, FWD extension widget attributes
Code Review Task Branch 3369b Revision 11211
It is not clear why we need both @Coordinate.guiRound()@ and @Coordin...
Greg Shah
12:59 PM User Interface Feature #3369: add support for BGCOLOR-RGB and FGCOLOR-RGB, FWD extension widget attributes
3369b replaces all UI coordinate roundings implemented by @BigDecimal@ with more primitive constructs, like @java.mat... Hynek Cihlar
07:22 AM User Interface Feature #3394: generic drawing improvements: repaint and other misc code
3394a revision 11294 fixes browse column widths due to incorrectly resolved column font. Hynek Cihlar
06:03 AM Base Language Feature #3262: implement COM/OLE Automation support
Branch @3262b@ was merged to trunk as revno @11212@ then it was archived. Eugenie Lyzenko
05:57 AM Base Language Feature #3262: implement COM/OLE Automation support
Greg Shah wrote:
> Please merge 3262b to trunk.
OK. Starting.
Eugenie Lyzenko
04:56 AM Base Language Feature #3262: implement COM/OLE Automation support
Please merge 3262b to trunk. Greg Shah
09:39 PM Base Language Feature #3262: implement COM/OLE Automation support
Testing completed. No regressions have been found. The results: @3262b_11251_a5eeab0_20171220_evl.zip@.
So the bra...
Eugenie Lyzenko
08:07 PM Base Language Feature #3262: implement COM/OLE Automation support
The main cycle completed. No regression. Running @CTRL-C@ part.
Can I merge into trunk if no regressions for @CTRL...
Eugenie Lyzenko

12/20/2017

05:54 PM Base Language Bug #3406: implement silent error mode as a lambda to allow aborting the control flow
It's not the case. Stanislav Lomany
05:53 PM Base Language Bug #3406: implement silent error mode as a lambda to allow aborting the control flow
OK, then please hold off on updating this branch, unless you believe these changes are necessary to making the new er... Eric Faulhaber
05:39 PM Base Language Bug #3406: implement silent error mode as a lambda to allow aborting the control flow
> OK, please put it in and I'll restart testing.
That may require some time because is not yet ready.
Stanislav Lomany
05:16 PM Base Language Bug #3406: implement silent error mode as a lambda to allow aborting the control flow
OK, please put it in and I'll restart testing. Eric Faulhaber
05:09 PM Base Language Bug #3406: implement silent error mode as a lambda to allow aborting the control flow
No, its not risky, just minor fix which IIRC doesn't affect regression testing. Stanislav Lomany
05:03 PM Base Language Bug #3406: implement silent error mode as a lambda to allow aborting the control flow
Stanislav Lomany wrote:
> I wanted to fix TODOs and error in processing in one place, but can do that in another bra...
Eric Faulhaber
04:54 PM Base Language Bug #3406: implement silent error mode as a lambda to allow aborting the control flow
I wanted to fix TODOs and error in processing in one place, but can do that in another branch. Stanislav Lomany
04:35 PM Base Language Bug #3406: implement silent error mode as a lambda to allow aborting the control flow
So, are we expecting any more code changes at this point, or is revision 11226 what we're testing? Actually, I alread... Eric Faulhaber
04:27 PM Base Language Bug #3406: implement silent error mode as a lambda to allow aborting the control flow
The TODOs in 3406a rev 11226:
# @SharedVariableManager.errorHelper@ - this is used when there is a problem resolving...
Constantin Asofiei
03:21 PM Base Language Bug #3406: implement silent error mode as a lambda to allow aborting the control flow
> @ErrorManager.recordOrShowError@ or @ErrorManager.recordOrThrowError@?
@ErrorManager.recordOrShowError@
Stanislav Lomany
03:01 PM Base Language Bug #3406: implement silent error mode as a lambda to allow aborting the control flow
Greg Shah wrote:
> I've also added TODO and ECF_TODO comments in other locations that need review.
>
> Eric: Plea...
Eric Faulhaber
02:56 PM Base Language Bug #3406: implement silent error mode as a lambda to allow aborting the control flow
Stanislav Lomany wrote:
> > Stanislav: Please look at @Browse@ and @BrowseWidget@ for the TODOs I've added.
>
> T...
Greg Shah
02:52 PM Base Language Bug #3406: implement silent error mode as a lambda to allow aborting the control flow
Our original approach to silent error mode was to bracket each NO-ERROR statement (or assignment or standalone expres... Greg Shah
02:33 PM Base Language Bug #3406: implement silent error mode as a lambda to allow aborting the control flow
> Stanislav: Please look at @Browse@ and @BrowseWidget@ for the TODOs I've added.
These exceptions serve the purpo...
Stanislav Lomany
12:30 PM Base Language Bug #3406: implement silent error mode as a lambda to allow aborting the control flow
Per our offline discussion, revision 11225 enables the re-throw of the error condition inside the silent worker's cat... Greg Shah
04:11 AM Base Language Bug #3406: implement silent error mode as a lambda to allow aborting the control flow
Revision 3406a/11224 almost resolves the deferred validation issue, except instead of the pause and "Press space bar ... Eric Faulhaber
03:28 AM Base Language Bug #3406: implement silent error mode as a lambda to allow aborting the control flow
The issue for at least two of the tests (a concurrent pair) is that the harness is expecting a validation failure (un... Eric Faulhaber
11:29 PM Base Language Bug #3406: implement silent error mode as a lambda to allow aborting the control flow
3406a/11223 passed ETF developer testing, but failed regular regression testing twice with 4 of the same tests failin... Eric Faulhaber
04:44 PM Base Language Feature #3262: implement COM/OLE Automation support
Conversion testing has been passed, code trees are identical. Continue with runtime testing. Eugenie Lyzenko
11:19 AM Base Language Feature #3262: implement COM/OLE Automation support
Task branch @3262b@ has been rebased with recent trunk @11211@, new version is @11251@. Eugenie Lyzenko
10:53 AM Base Language Feature #3262: implement COM/OLE Automation support
Greg Shah wrote:
> > There is an issues with getting the file resources (Excel files templates) from application *.j...
Eugenie Lyzenko
10:41 AM Base Language Feature #3262: implement COM/OLE Automation support
Greg Shah wrote:
> > The rules were changed, so conversion test is required I guess. Also safe harness run is desira...
Eugenie Lyzenko
10:39 AM Base Language Feature #3262: implement COM/OLE Automation support
> The rules were changed, so conversion test is required I guess. Also safe harness run is desirable to make sure we ... Greg Shah
10:33 AM Base Language Feature #3262: implement COM/OLE Automation support
Greg Shah wrote:
> > I think we can test and merge 3262b into trunk and defer other work to 3262c.
>
> What testi...
Eugenie Lyzenko
10:26 AM Base Language Feature #3262: implement COM/OLE Automation support
> There is an issues with getting the file resources (Excel files templates) from application *.jar files.
Are the...
Greg Shah
10:09 AM Base Language Feature #3262: implement COM/OLE Automation support
Greg Shah wrote:
>How safe is the 3262b branch at this point? Is it suitable for merge to trunk or is there known wo...
Eugenie Lyzenko
09:45 AM Base Language Feature #3262: implement COM/OLE Automation support
How safe is the 3262b branch at this point? Is it suitable for merge to trunk or is there known work needed?
I kn...
Greg Shah
01:53 PM User Interface Bug #3381: Sub-menu drawing issues
Eugenie Lyzenko wrote:
> Fixes for issue except @ESC@ key press reaction, for which I still do not have the @4GL@ te...
Hynek Cihlar
12:41 PM User Interface Bug #3381: Sub-menu drawing issues
Task branch @3394a@ has been updated for review to revision @11291@.
Fixes for issue except @ESC@ key press reacti...
Eugenie Lyzenko
11:32 AM User Interface Bug #3381: Sub-menu drawing issues
Hynek Cihlar wrote:
>
> Another point is the way the menu bar should handle Esc key. On the first Esc press the su...
Eugenie Lyzenko
03:38 AM User Interface Bug #3381: Sub-menu drawing issues
Hynek Cihlar wrote:
> With the revision there are still some issues with the main bar. Please see the attached gif.
...
Hynek Cihlar
03:10 AM User Interface Bug #3381: Sub-menu drawing issues
Eugenie Lyzenko wrote:
> Task branch @3394a@ has been updated for review to revision @11288@.
>
> This is the fix...
Hynek Cihlar
12:50 AM User Interface Bug #3381: Sub-menu drawing issues
Task branch @3394a@ has been updated for review to revision @11288@.
This is the fix for classic theme menu painti...
Eugenie Lyzenko
09:28 PM User Interface Bug #3381: Sub-menu drawing issues
There are some @UI@ painting deviations for classic theme implementation. Consider the following native Windows pictu... Eugenie Lyzenko
08:38 PM User Interface Bug #3381: Sub-menu drawing issues
Task branch @3394a@ has been updated for review to revision @11286@.
The minor changes to resolve menu related iss...
Eugenie Lyzenko
04:00 AM User Interface Bug #3425: text is drawn 1-pixel to the left, cutting the text
Thank you, if we don't shift the text by 1 pixel to the left, then some table headers don't fit the column and some r... Sergey Ivanovskiy
03:50 AM User Interface Bug #3425: text is drawn 1-pixel to the left, cutting the text
The @text-metrics.xml@ for AW was last updated by Constantin on Tue 2017-11-28 22:20:15 +0200 as revno 110.
I don't...
Ovidiu Maxiniuc
03:24 AM User Interface Bug #3425: text is drawn 1-pixel to the left, cutting the text
Ovidiu Maxiniuc wrote:
> It is possible that the font configuration to had been different. If it is wrong, please dr...
Sergey Ivanovskiy

12/19/2017

02:47 PM User Interface Feature #3394: generic drawing improvements: repaint and other misc code
Sergey Ivanovskiy wrote:
> OK, please review the committed revision 11282.
The changes look good.
Hynek Cihlar
02:16 PM User Interface Feature #3394: generic drawing improvements: repaint and other misc code
OK, please review the committed revision 11282. Sergey Ivanovskiy
11:10 AM User Interface Feature #3394: generic drawing improvements: repaint and other misc code
Greg Shah wrote:
> Sergey Ivanovskiy wrote:
> > Please review committed revision 11275 - tried to fix activations o...
Hynek Cihlar
08:26 AM User Interface Feature #3394: generic drawing improvements: repaint and other misc code
Sergey Ivanovskiy wrote:
> Please review committed revision 11275 - tried to fix activations of task icons in the vi...
Greg Shah
01:19 PM User Interface Bug #3425: text is drawn 1-pixel to the left, cutting the text
I cannot remember why I added that special processing. Most likely I adjusted that based on offset revealed when comp... Ovidiu Maxiniuc
01:13 PM User Interface Bug #3425: text is drawn 1-pixel to the left, cutting the text
> It seems that table labels are displayed 1-pixel left due to this code ClassicTheme.this.drawBrowseCellText
This...
Stanislav Lomany
12:21 PM User Interface Bug #3425: text is drawn 1-pixel to the left, cutting the text
OK. It seems that table labels are displayed 1-pixel left due to this code @ClassicTheme.this.drawBrowseCellText@
<p...
Sergey Ivanovskiy
11:15 AM User Interface Bug #3425: text is drawn 1-pixel to the left, cutting the text
> Should I work on these browser issues?
Yes, but make sure you get input from Stanislav so that you don't cause r...
Greg Shah
11:06 AM User Interface Bug #3425: text is drawn 1-pixel to the left, cutting the text
Committed revision 11280(3394a) should fix the web text position along a horizontal. It seems that the other text pos... Sergey Ivanovskiy
09:40 AM User Interface Bug #3425: text is drawn 1-pixel to the left, cutting the text
I didn't implement this function. Please explain the reasons that in the code below the text @x@-position coordinate ... Sergey Ivanovskiy
09:27 AM User Interface Bug #3425: text is drawn 1-pixel to the left, cutting the text
The web client displays text in tables incorrectly too.
!TextInBrowser.png!
Sergey Ivanovskiy
09:25 AM User Interface Bug #3425: text is drawn 1-pixel to the left, cutting the text
It seems that header's and cell's content in tables incorrectly positioned. It can be observed for the web and swing ... Sergey Ivanovskiy
06:56 AM User Interface Bug #3425 (Closed): text is drawn 1-pixel to the left, cutting the text
Sergey Ivanovskiy
07:47 AM User Interface Bug #3381: Sub-menu drawing issues
Task branch @3394a@ has been updated for review to revision @11279@.
This change contains the fix for @ClassicThem...
Eugenie Lyzenko

12/18/2017

06:29 PM User Interface Feature #3394: generic drawing improvements: repaint and other misc code
Sergey Ivanovskiy wrote:
> Constantin Asofiei wrote:
> >.. I ask because I have some more generic fixes related to ...
Constantin Asofiei
12:28 PM User Interface Feature #3394: generic drawing improvements: repaint and other misc code
Please review committed revision 11275 - tried to fix activations of task icons in the virtual desktop. Sergey Ivanovskiy
03:11 PM User Interface Bug #3381: Sub-menu drawing issues
Code Review Task Branch 3394a Revisions 11276/11277
I like the approach.
Greg Shah
12:58 PM User Interface Bug #3381: Sub-menu drawing issues
Task branch @3394a@ has been updated for review to revision @11276@, @11277@.
Added the ability to configure menu ...
Eugenie Lyzenko
03:25 AM User Interface Bug #3381: Sub-menu drawing issues
Eugenie Lyzenko wrote:
> Hynek Cihlar wrote:
> > > Can someone clarify what this code was added for? What is the ca...
Hynek Cihlar
03:17 AM User Interface Bug #3381: Sub-menu drawing issues
Eugenie Lyzenko wrote:
> Yes, but because in trunk there is no functionality to hide submenu once mouse is left the ...
Hynek Cihlar

12/17/2017

05:50 PM User Interface Bug #3381: Sub-menu drawing issues
Greg Shah wrote:
> > Guys, the delay improves usability in cases when you navigate the menu by mouse. Without the de...
Eugenie Lyzenko
12:43 PM User Interface Bug #3381: Sub-menu drawing issues
Hynek Cihlar wrote:
> > Can someone clarify what this code was added for? What is the case the code become working. ...
Eugenie Lyzenko
11:18 AM User Interface Bug #3381: Sub-menu drawing issues
Hynek Cihlar wrote:
> Eugenie Lyzenko wrote:
> > Greg Shah wrote:
> > > Code Review Task Branch 3394a Revision 112...
Greg Shah
09:14 AM User Interface Bug #3381: Sub-menu drawing issues
Hynek Cihlar wrote:
> Eugenie Lyzenko wrote:
> > Hynek Cihlar wrote:
> > I think the root cause here is the 1-pixe...
Eugenie Lyzenko
05:53 AM User Interface Bug #3381: Sub-menu drawing issues
Eugenie Lyzenko wrote:
> Task branch @3394a@ has been updated for review to revision @11272@.
>
> This is the fix...
Hynek Cihlar
05:00 AM User Interface Bug #3381: Sub-menu drawing issues
Eugenie Lyzenko wrote:
> Hynek Cihlar wrote:
> > Eugenie, I think there is another regression in the menu bar. The ...
Hynek Cihlar
04:57 AM User Interface Bug #3381: Sub-menu drawing issues
Eugenie Lyzenko wrote:
> Greg Shah wrote:
> > Code Review Task Branch 3394a Revision 11267
> > ...
> > 1. Does th...
Hynek Cihlar
05:13 PM Base Language Bug #3406: implement silent error mode as a lambda to allow aborting the control flow
Unfortunately, the ChUI app regression testing fails with the same core regressions that have been happening earlier ... Greg Shah
10:38 AM Base Language Bug #3406: implement silent error mode as a lambda to allow aborting the control flow
ETF batch tests passed. If it passes regular regression testing, I think this revision can be merged to trunk. Eric Faulhaber
02:16 AM Base Language Bug #3406: implement silent error mode as a lambda to allow aborting the control flow
Greg, 3406a/11222 has passed ETF search and dev tests (2 clean runs of the latter). I am testing batch next, but plea... Eric Faulhaber
04:52 AM User Interface Feature #3394: generic drawing improvements: repaint and other misc code
Sergey Ivanovskiy wrote:
> I guess that @config.showInTaskbar@ is always true for the regular desktop window and fal...
Hynek Cihlar

12/16/2017

09:02 AM Base Language Feature #3262: implement COM/OLE Automation support
Task branch @3262b@ has been rebased with recent trunk @11210@, new version is @11250@. Eugenie Lyzenko
11:07 PM User Interface Bug #3381: Sub-menu drawing issues
Task branch @3394a@ has been updated for review to revision @11272@.
This is the fix for menu regressions/issues/n...
Eugenie Lyzenko

12/15/2017

06:24 PM User Interface Feature #3394: generic drawing improvements: repaint and other misc code
3394a rev 11269 was rebased with trunk rev 11210. 3394a new rev is 11271. Constantin Asofiei
01:18 PM User Interface Feature #3394: generic drawing improvements: repaint and other misc code
This implementation of @WindowGuiImpl.this.isDesktopMinimized()@ is confusing ... Sergey Ivanovskiy
01:00 PM User Interface Feature #3394: generic drawing improvements: repaint and other misc code
I think that this implementation @WindowGuiImpl.iconify(postEvent)@ to iconify window is incorrect... Sergey Ivanovskiy
10:24 AM User Interface Feature #3394: generic drawing improvements: repaint and other misc code
Constantin Asofiei wrote:
>.. I ask because I have some more generic fixes related to focus window (which affect Swi...
Sergey Ivanovskiy
05:57 PM User Interface Bug #3381: Sub-menu drawing issues
Hynek Cihlar wrote:
> Eugenie, I think there is another regression in the menu bar. The delayed submenu hiding doesn...
Eugenie Lyzenko
04:52 PM User Interface Bug #3381: Sub-menu drawing issues
Task branch @3394a@ has been updated for review to revision @11268@.
Undo for menu show/hide delay implementation....
Eugenie Lyzenko
03:48 PM User Interface Bug #3381: Sub-menu drawing issues
Greg Shah wrote:
> Please comment out the delay code to disable it. I want to ensure it can be added later if neede...
Eugenie Lyzenko
03:30 PM User Interface Bug #3381: Sub-menu drawing issues
Please comment out the delay code to disable it. I want to ensure it can be added later if needed, but for now I pre... Greg Shah
03:23 PM User Interface Bug #3381: Sub-menu drawing issues
Greg Shah wrote:
> Code Review Task Branch 3394a Revision 11267
> ...
> 1. Does the delay implementation improve t...
Eugenie Lyzenko
11:58 AM User Interface Bug #3381: Sub-menu drawing issues
Hynek Cihlar wrote:
> Another exception when menu bar menu item is mouse-highlighted and arrow keys pressed.
>
> ...
Sergey Ivanovskiy
06:39 AM User Interface Bug #3381: Sub-menu drawing issues
Eugenie, I think there is another regression in the menu bar. The delayed submenu hiding doesn't seem to apply there ... Hynek Cihlar
06:37 AM User Interface Bug #3381: Sub-menu drawing issues
Another exception when menu bar menu item is mouse-highlighted and arrow keys pressed.... Hynek Cihlar
06:22 AM User Interface Bug #3381: Sub-menu drawing issues
Code Review Task Branch 3394a Revision 11267
The delay implementation seems good. I'm still not sure I like havin...
Greg Shah
06:12 AM User Interface Bug #3381: Sub-menu drawing issues
Eugenie Lyzenko wrote:
> We used message box for testing and issue resolution purpose, isn't it? It is not a part of...
Hynek Cihlar
11:19 PM User Interface Bug #3381: Sub-menu drawing issues
Task branch @3394a@ has been updated for review to revision @11267@.
Greg,
This is the approach I suggest to us...
Eugenie Lyzenko

12/14/2017

06:50 PM User Interface Bug #3381: Sub-menu drawing issues
Task branch @3394a@ has been updated for review to revision @11266@.
The review notes resolution. The code in @Ove...
Eugenie Lyzenko
06:35 PM User Interface Bug #3381: Sub-menu drawing issues
Hynek Cihlar wrote:
> Code review the #3381 changes in task branch 3394a.
> ...
> The body of @onKeyPressed()@ is ...
Eugenie Lyzenko
04:09 PM User Interface Bug #3381: Sub-menu drawing issues
Greg Shah wrote:
> > The only thing left in this area is to implement the delay between menu status change and mouse...
Eugenie Lyzenko
09:17 AM User Interface Bug #3381: Sub-menu drawing issues
Eugenie Lyzenko wrote:
> Please rebuild all. I still unable to recreate this. Pressing title bar caused the menu to ...
Hynek Cihlar
08:59 AM User Interface Bug #3381: Sub-menu drawing issues
Hynek Cihlar wrote:
> Eugenie Lyzenko wrote:
> > What is your testing environment? Swing client, Web client or both...
Eugenie Lyzenko
08:56 AM User Interface Bug #3381: Sub-menu drawing issues
Hynek Cihlar wrote:
> Code review the #3381 changes in task branch 3394a.
> [...]
> In the code above, shouldn't t...
Eugenie Lyzenko
07:58 AM User Interface Bug #3381: Sub-menu drawing issues
Another regression with the window menu bar. Run the @uast/menu/Menubar.p@ try to navigate the menu, an exception bel... Hynek Cihlar
07:53 AM User Interface Bug #3381: Sub-menu drawing issues
Another problem is that the popup menu cannot be navigated by keyboard. However this probably exists in trunk, too. Hynek Cihlar
07:52 AM User Interface Bug #3381: Sub-menu drawing issues
Eugenie Lyzenko wrote:
> What is your testing environment? Swing client, Web client or both?
I can see this only ...
Hynek Cihlar
07:43 AM User Interface Bug #3381: Sub-menu drawing issues
Hynek Cihlar wrote:
> Eugenie Lyzenko wrote:
> > Hynek Cihlar wrote:
> > > There is a regression caused by the cha...
Eugenie Lyzenko
07:39 AM User Interface Bug #3381: Sub-menu drawing issues
Code review the #3381 changes in task branch 3394a.
MenuItemGuiImpl.selectMenuItem...
Hynek Cihlar
07:06 AM User Interface Bug #3381: Sub-menu drawing issues
Eugenie Lyzenko wrote:
> Hynek Cihlar wrote:
> > There is a regression caused by the changes. When the popup is dis...
Hynek Cihlar
07:04 AM User Interface Bug #3381: Sub-menu drawing issues
Hynek Cihlar wrote:
> There is a regression caused by the changes. When the popup is displayed and another window (o...
Eugenie Lyzenko
06:04 AM User Interface Bug #3381: Sub-menu drawing issues
There is a regression caused by the changes. When the popup is displayed and another window (or the title bar of the ... Hynek Cihlar
05:20 AM User Interface Bug #3381: Sub-menu drawing issues
> The only thing left in this area is to implement the delay between menu status change and mouse enter/leave the sub... Greg Shah
10:09 PM User Interface Bug #3381: Sub-menu drawing issues
Task branch @3394a@ has been updated for review to revision @11265@.
This update adds hover base show/hide pop-up ...
Eugenie Lyzenko

12/13/2017

03:44 PM User Interface Bug #3381: Sub-menu drawing issues
Task branch @3394a@ has been updated for review to revision @11264@.
Added fix for sub menu hiding issues as react...
Eugenie Lyzenko
09:31 PM User Interface Bug #3381: Sub-menu drawing issues
Task branch @3394a@ has been updated for review to revision @11259@.
This is the fix for @"Export" item doesn't di...
Eugenie Lyzenko
09:35 AM User Interface Feature #3394: generic drawing improvements: repaint and other misc code
Constantin Asofiei wrote:
> Does the same bug happen on the Web client, too? I ask because I have some more generic...
Sergey Ivanovskiy
09:22 AM User Interface Feature #3394: generic drawing improvements: repaint and other misc code
Sergey Ivanovskiy wrote:
> Sergey Ivanovskiy wrote:
> > It seems that the root cause of the combo box issue is the ...
Constantin Asofiei
09:03 AM User Interface Feature #3394: generic drawing improvements: repaint and other misc code
Sergey Ivanovskiy wrote:
> It seems that the root cause of the combo box issue is the current focus window is still ...
Sergey Ivanovskiy
08:35 AM User Interface Feature #3394: generic drawing improvements: repaint and other misc code
It seems that the root cause of the combo box issue is the current focus window is still a drop down overlay when the... Sergey Ivanovskiy

12/12/2017

09:42 AM User Interface Feature #3394: generic drawing improvements: repaint and other misc code
OK. Related to the Hotel GUI I didn't detect artifacts except the focus traversal chain started from the opened dropd... Sergey Ivanovskiy
09:26 AM User Interface Feature #3394: generic drawing improvements: repaint and other misc code
> > In the current version of 3394a (rev 11256) there is at least one known regression related to the combo box dropd... Greg Shah
08:44 AM User Interface Feature #3394: generic drawing improvements: repaint and other misc code
Sergey Ivanovskiy wrote:
> In the current version of 3394a (rev 11256) there is at least one known regression relate...
Sergey Ivanovskiy
07:30 AM User Interface Feature #3394: generic drawing improvements: repaint and other misc code
OK, thank you. Sergey Ivanovskiy
07:28 AM User Interface Feature #3394: generic drawing improvements: repaint and other misc code
Quantity of radio buttons should match the maximum number of guests for the selected room type. So far I see no issues. Stanislav Lomany
07:24 AM User Interface Feature #3394: generic drawing improvements: repaint and other misc code
I am just looking into it but if we open Update Reservation for rooms with 3 and 4 guests, then this dialog displays ... Sergey Ivanovskiy
07:15 AM User Interface Feature #3394: generic drawing improvements: repaint and other misc code
Sergey Ivanovskiy wrote:
> There is an issue with radio buttons.
> !RadioButtonsGroup.png!
Please describe it.
...
Constantin Asofiei
07:02 AM User Interface Feature #3394: generic drawing improvements: repaint and other misc code
There is an issue with radio buttons.
!RadioButtonsGroup.png!
Sergey Ivanovskiy
06:05 AM User Interface Feature #3394: generic drawing improvements: repaint and other misc code
Please review these minor changes in the committed revision 11257 that discarded PainEvents with empty update rectang... Sergey Ivanovskiy
05:14 AM User Interface Feature #3394: generic drawing improvements: repaint and other misc code
Constantin, empty rectangles are generated from size or another updates on @widget.repaint()@. Please look at this lo... Sergey Ivanovskiy
04:48 AM User Interface Feature #3394: generic drawing improvements: repaint and other misc code
In the current version of 3394a (rev 11256) there is at least one known regression related to the combo box dropdown ... Sergey Ivanovskiy
11:35 PM Base Language Bug #3406: implement silent error mode as a lambda to allow aborting the control flow
Investigation so far shows that the 4GL's where clause processing and error handling is a bit different than ours. An... Eric Faulhaber
09:08 PM User Interface Bug #3381: Sub-menu drawing issues
Task branch @3394a@ has been updated for review to revision @11256@.
The fix for @Windows10@ selected menu item ba...
Eugenie Lyzenko
07:46 PM User Interface Bug #3381: Sub-menu drawing issues
Task branch @3394a@ has been updated for review to revision @11255@.
This update include several painting issues i...
Eugenie Lyzenko

12/11/2017

02:56 PM User Interface Feature #3394: generic drawing improvements: repaint and other misc code
Constantin, your changes fixed the tree control and all date picker issues. Thank you for help. There are only visibl... Sergey Ivanovskiy
02:37 PM User Interface Feature #3394: generic drawing improvements: repaint and other misc code
Sergey Ivanovskiy wrote:
> OK. Did you try to draw sequence diagrams related to drawings? It seems there are differe...
Constantin Asofiei
02:32 PM User Interface Feature #3394: generic drawing improvements: repaint and other misc code
OK. Did you try to draw sequence diagrams related to drawings? It seems there are different scenarios that can invoke... Sergey Ivanovskiy
02:23 PM User Interface Feature #3394: generic drawing improvements: repaint and other misc code
Sergey, when you mentioned the @afterConfigUpdateBase@, it got me thinking... we need to post physical boundaries and... Constantin Asofiei
09:23 AM User Interface Feature #3394: generic drawing improvements: repaint and other misc code
This trace should be discussed too... Sergey Ivanovskiy
08:44 AM User Interface Feature #3394: generic drawing improvements: repaint and other misc code
Constantin, you are correct that @AbstractWidget.afterConfigUpdateBase@ (trunc version) looks incorrect because of @p... Sergey Ivanovskiy
05:16 AM User Interface Feature #3394: generic drawing improvements: repaint and other misc code
It looks like a bug that for a date picker button defined by... Sergey Ivanovskiy
04:51 AM User Interface Feature #3394: generic drawing improvements: repaint and other misc code
This function of @OutputManager@... Sergey Ivanovskiy
02:17 PM User Interface Bug #3381: Sub-menu drawing issues
> No there is no such line in @FWD@. Can you remember when you saw it last time?
I guess somewhere between revisio...
Stanislav Lomany
12:07 PM User Interface Bug #3381: Sub-menu drawing issues
Stanislav,
From your picture I can see vertical line in @Windows10@ theme:
!missing_vert_win10.jpg!
No there...
Eugenie Lyzenko

12/09/2017

05:01 PM Base Language Bug #3406: implement silent error mode as a lambda to allow aborting the control flow
The root cause of the first failing test is that the new code in @AbstractQuery.preprocessSubstitutionArguments@ does... Eric Faulhaber
04:08 PM Base Language Bug #3406: implement silent error mode as a lambda to allow aborting the control flow
The errors I've looked at so far seem to be cases of @P2JQuery.Parameter@ lambda expressions being passed too far alo... Eric Faulhaber
03:16 PM Base Language Bug #3406: implement silent error mode as a lambda to allow aborting the control flow
ETF testing failed immediately because the DMO ASM code used the old BDT @assign@ signatures. Once I fixed this (comm... Eric Faulhaber
07:43 AM User Interface Bug #3382: Client-side popup menus abend
Hynek Cihlar wrote:
> Eugenie Lyzenko wrote:
> > Guys,
> >
> > I'm just trying to run browse pop-up test in my W...
Eugenie Lyzenko
04:19 AM User Interface Bug #3382: Client-side popup menus abend
Eugenie Lyzenko wrote:
> Guys,
>
> I'm just trying to run browse pop-up test in my Windows devbox. And has abend ...
Hynek Cihlar
08:06 PM User Interface Bug #3382: Client-side popup menus abend
Guys,
I'm just trying to run browse pop-up test in my Windows devbox. And has abend from inability to open temp t...
Eugenie Lyzenko
10:01 PM User Interface Bug #3381: Sub-menu drawing issues
4GL level1 menu opening:
!sub_menu1_level1.jpg!
4GL level2 menu opening:
!sub_menu1_level2.jpg!
Eugenie Lyzenko

12/08/2017

04:25 PM User Interface Feature #3394: generic drawing improvements: repaint and other misc code
Constantin, no, updates for combo boxes and tree and another widgets are different issues. I didn't solve them. This ... Sergey Ivanovskiy
04:20 PM User Interface Feature #3394: generic drawing improvements: repaint and other misc code
Sergey Ivanovskiy wrote:
> Please review committed revision 11249 (3394a) that should discard empty rectangles from ...
Constantin Asofiei
03:22 PM User Interface Feature #3394: generic drawing improvements: repaint and other misc code
Please review committed revision 11249 (3394a) that should discard empty rectangles from @SceenBitmap@. It seems that... Sergey Ivanovskiy
12:11 PM User Interface Feature #3394: generic drawing improvements: repaint and other misc code
Please clarify what is incorrect in setNewSelection?
I traced @ScrenBitmap.this.setState@ and found many cases wit...
Sergey Ivanovskiy
08:50 AM User Interface Feature #3394: generic drawing improvements: repaint and other misc code
Sergey Ivanovskiy wrote:
> The following changes can help to fix combo box updates
> [...]
> but I found another p...
Constantin Asofiei
08:39 AM User Interface Feature #3394: generic drawing improvements: repaint and other misc code
But it is possible that these empty clipping rectangles have been incorrectly added to @ScreenBitmap@. It needs to fi... Sergey Ivanovskiy
05:27 AM User Interface Feature #3394: generic drawing improvements: repaint and other misc code
Sergey Ivanovskiy wrote:
> I changed coordinates in #3394-41. The rectangle is empty and is invalid but if it is pas...
Constantin Asofiei
05:26 AM User Interface Feature #3394: generic drawing improvements: repaint and other misc code
Constantin Asofiei wrote:
> Sergey Ivanovskiy wrote:
> > I meant the existing definition of @NativeRectangle.this.e...
Sergey Ivanovskiy
05:22 AM User Interface Feature #3394: generic drawing improvements: repaint and other misc code
Sergey Ivanovskiy wrote:
> Constantin Asofiei wrote:
> > See @CombobBox.setValue@ and other @setValue@ for i.e. sel...
Constantin Asofiei
05:21 AM User Interface Feature #3394: generic drawing improvements: repaint and other misc code
Constantin Asofiei wrote:
> See @CombobBox.setValue@ and other @setValue@ for i.e. selection-list and other widgets ...
Sergey Ivanovskiy
05:16 AM User Interface Feature #3394: generic drawing improvements: repaint and other misc code
Sergey Ivanovskiy wrote:
> I meant the existing definition of @NativeRectangle.this.empty()@ which is correct.
I do...
Constantin Asofiei
05:13 AM User Interface Feature #3394: generic drawing improvements: repaint and other misc code
I meant the existing definition of @NativeRectangle.this.empty()@ which is correct. Sergey Ivanovskiy
05:10 AM User Interface Feature #3394: generic drawing improvements: repaint and other misc code
Yes I mean @NativeRectangle@, but @Rectangle@ has the same issue. To clarify this bug with empty rectangles let us co... Sergey Ivanovskiy
05:07 AM User Interface Feature #3394: generic drawing improvements: repaint and other misc code
Sergey Ivanovskiy wrote:
> Yes, and the fact that the month combo box is not repainted with actual value.
See @Comb...
Constantin Asofiei
04:58 AM User Interface Feature #3394: generic drawing improvements: repaint and other misc code
Yes, and the fact that the month combo box is not repainted with actual value.
It seems that the @NativeRectangle....
Sergey Ivanovskiy
04:56 AM User Interface Feature #3394: generic drawing improvements: repaint and other misc code
Sergey Ivanovskiy wrote:
> Please look at this picture date_picker.mkv.
You refer to the border artefacts around th...
Constantin Asofiei
04:43 AM User Interface Feature #3394: generic drawing improvements: repaint and other misc code
Please look at this picture date_picker.mkv. Sergey Ivanovskiy
03:02 PM User Interface Bug #3382: Client-side popup menus abend
Hynek Cihlar wrote:
>
> In your last change you used the menu popup location passed to @Menu.showPopup()@, which a...
Eugenie Lyzenko
12:40 PM User Interface Bug #3382: Client-side popup menus abend
Eugenie Lyzenko wrote:
> Hynek Cihlar wrote:
> > Yes, the coordinates must be taken from the mouse event causing th...
Hynek Cihlar
10:42 AM User Interface Bug #3382: Client-side popup menus abend
Hynek Cihlar wrote:
> Yes, the coordinates must be taken from the mouse event causing the popup to come up and not f...
Eugenie Lyzenko
06:57 AM User Interface Bug #3382: Client-side popup menus abend
Eugenie Lyzenko wrote:
> Hynek Cihlar wrote:
> > Eugenie, why not to get the location from the mouse event? What if...
Hynek Cihlar
04:47 AM User Interface Bug #3382: Client-side popup menus abend
Hynek Cihlar wrote:
> Eugenie, why not to get the location from the mouse event? What if the popup isn't actually di...
Eugenie Lyzenko
02:57 AM User Interface Bug #3382: Client-side popup menus abend
Eugenie Lyzenko wrote:
> Task branch @3394a@ has been updated for review to revision @11247@.
>
> Fixed the bar s...
Hynek Cihlar
08:10 PM User Interface Bug #3382: Client-side popup menus abend
Task branch @3394a@ has been updated for review to revision @11247@.
Fixed the bar scrolling initiated from pop-up...
Eugenie Lyzenko
01:05 PM Conversion Tools Feature #2110: improve orphan comment processing
I think I know the cause of most (if not all) of our orphaned comment problem.
It is caused by how we deal with to...
Greg Shah

12/07/2017

03:32 PM User Interface Feature #3394: generic drawing improvements: repaint and other misc code
Sergey Ivanovskiy wrote:
> OK, I lost the conception of redrawing if the business methods change some widget (its po...
Constantin Asofiei
03:32 PM User Interface Feature #3394: generic drawing improvements: repaint and other misc code
Constantin Asofiei wrote:
> Sergey Ivanovskiy wrote:
> > This resize rectangle is displayed forever after its appea...
Eugenie Lyzenko
03:25 PM User Interface Feature #3394: generic drawing improvements: repaint and other misc code
OK, I lost the conception of redrawing if the business methods change some widget (its position, its size, its conten... Sergey Ivanovskiy
03:18 PM User Interface Feature #3394: generic drawing improvements: repaint and other misc code
Sergey Ivanovskiy wrote:
> This resize rectangle is displayed forever after its appearance on double click at the fr...
Constantin Asofiei
03:17 PM User Interface Feature #3394: generic drawing improvements: repaint and other misc code
Sergey Ivanovskiy wrote:
> Please answer to this conceptual question. What is the meaning of this flag and when it c...
Constantin Asofiei
02:53 PM User Interface Feature #3394: generic drawing improvements: repaint and other misc code
Please answer to this conceptual question. What is the meaning of this flag and when it can be used (@BaseConfig@)? C... Sergey Ivanovskiy
02:50 PM User Interface Feature #3394: generic drawing improvements: repaint and other misc code
This resize rectangle is displayed forever after its appearance on double click at the frame space right to the last ... Sergey Ivanovskiy
02:47 PM User Interface Feature #3394: generic drawing improvements: repaint and other misc code
Don't know it is an answer. The frame is @folder-frm 27 Dimension[126.0,16.43] Point[0.0,1.0] visible true can false;... Sergey Ivanovskiy
02:33 PM User Interface Feature #3394: generic drawing improvements: repaint and other misc code
Sergey Ivanovskiy wrote:
> With the current version the main tab frame can be resizable and resize or editor grid is...
Constantin Asofiei
02:22 PM User Interface Feature #3394: generic drawing improvements: repaint and other misc code
With the current version the main tab frame can be resizable and resize or editor grid is displayed. It wasn't observ... Sergey Ivanovskiy
09:54 AM User Interface Feature #3394: generic drawing improvements: repaint and other misc code
Don't mind, I answered by myself. Sergey Ivanovskiy
09:44 AM User Interface Feature #3394: generic drawing improvements: repaint and other misc code
Please help to answer why in this code adatesd0.w for the date picker the x and y coordinates for the selected date r... Sergey Ivanovskiy
01:29 PM User Interface Bug #3382: Client-side popup menus abend
Hynek Cihlar wrote:
>When you are at the changes can you make sure the key input works correctly? I am getting an ex...
Eugenie Lyzenko
04:00 AM User Interface Bug #3382: Client-side popup menus abend
Eugenie Lyzenko wrote:
> Well, looks like I have found alternative approach. So the set of changes:
I like that. ...
Hynek Cihlar
11:52 PM User Interface Bug #3382: Client-side popup menus abend
Well, looks like I have found alternative approach. So the set of changes:
1. No using @invokeLater()@ to avoid chan...
Eugenie Lyzenko

12/06/2017

05:12 PM User Interface Bug #3382: Client-side popup menus abend
Eugenie Lyzenko wrote:
> If adapter @adapter.mouseClicked(e)@ calls body that has @invokeLater@ wrapper the result w...
Hynek Cihlar
05:06 PM User Interface Bug #3382: Client-side popup menus abend
Eugenie Lyzenko wrote:
> Hynek Cihlar wrote:
> >
> > (2) Enqueue only the call to @TC.messageBox()@ in the mouse ...
Hynek Cihlar
05:05 PM User Interface Bug #3382: Client-side popup menus abend
Hynek Cihlar wrote:
> Eugenie Lyzenko wrote:
> > This is exactly how it is currently implemented. Pop-up @ScrollPop...
Eugenie Lyzenko
04:57 PM User Interface Bug #3382: Client-side popup menus abend
Hynek Cihlar wrote:
>
> (2) Enqueue only the call to @TC.messageBox()@ in the mouse adapter body. Less impact on t...
Eugenie Lyzenko
04:50 PM User Interface Bug #3382: Client-side popup menus abend
Eugenie Lyzenko wrote:
> This is exactly how it is currently implemented. Pop-up @ScrollPopupGuiImpl.mouseClicked()@...
Hynek Cihlar
04:39 PM User Interface Bug #3382: Client-side popup menus abend
Hynek Cihlar wrote:
> > In this case we have null parent again because @invokeLater()@ defer click handler to the mo...
Eugenie Lyzenko
04:36 PM User Interface Bug #3382: Client-side popup menus abend
Eugenie Lyzenko wrote:
> Yes, at least scrolling down by pop-up menu does not work.
I think there are two options...
Hynek Cihlar
04:30 PM User Interface Bug #3382: Client-side popup menus abend
Hynek Cihlar wrote:
> Eugenie Lyzenko wrote:
> > But if we postpone click processing to the end - we have dismissed...
Eugenie Lyzenko
04:27 PM User Interface Bug #3382: Client-side popup menus abend
Eugenie Lyzenko wrote:
> But if we postpone click processing to the end - we have dismissed menu when it should exis...
Hynek Cihlar
04:17 PM User Interface Bug #3382: Client-side popup menus abend
Eugenie Lyzenko wrote:
> Hynek Cihlar wrote:
> > Hynek Cihlar wrote:
> >
> > In fact I don't see any reason the ...
Hynek Cihlar
03:32 PM User Interface Bug #3382: Client-side popup menus abend
Hynek Cihlar wrote:
> Hynek Cihlar wrote:
>
> In fact I don't see any reason the ordering should not be enforced ...
Eugenie Lyzenko
01:55 PM User Interface Bug #3382: Client-side popup menus abend
Hynek Cihlar wrote:
> > Another word you mean every possible code (we will remove @ThinClient.messageBox()@ from fin...
Hynek Cihlar
01:31 PM User Interface Bug #3382: Client-side popup menus abend
Eugenie Lyzenko wrote:
> What I do not understand here is why we are committed to @ThinClient.messageBox()@? This is...
Hynek Cihlar
12:20 PM User Interface Bug #3382: Client-side popup menus abend
Hynek Cihlar wrote:
>
> The call to @ThinClient.messageBox()@ must be executed in @ThinClient.invokeLater@ so that...
Eugenie Lyzenko
12:04 PM User Interface Bug #3382: Client-side popup menus abend
Eugenie Lyzenko wrote:
> Unfortunately this is not enough to fix the issue. Moving @MenuItemGuiImpl.selectMenuItem()...
Hynek Cihlar
09:49 PM User Interface Bug #3382: Client-side popup menus abend
Unfortunately this is not enough to fix the issue. Moving @MenuItemGuiImpl.selectMenuItem()@ before @ScrollPopupGuiIm... Eugenie Lyzenko
03:25 PM User Interface Feature #3394: generic drawing improvements: repaint and other misc code
Sergey Ivanovskiy wrote:
> With the current 3394a the Hotel GUI Check-in date picker doesn't repaint items correctly...
Constantin Asofiei
03:24 PM User Interface Feature #3394: generic drawing improvements: repaint and other misc code
With the current 3394a the Hotel GUI Check-in date picker doesn't repaint items correctly if the current month (year)... Sergey Ivanovskiy

12/05/2017

02:34 PM User Interface Bug #3382: Client-side popup menus abend
Eugenie Lyzenko wrote:
> You mean execution @selectMenuItem()@ first, then mouse adapters?
Exactly so.
Hynek Cihlar
05:55 AM User Interface Bug #3382: Client-side popup menus abend
Hynek Cihlar wrote:
> Please try to move the execution of mouse adapters in @MenuItemGuiImpl.mouseClicked@ before @s...
Eugenie Lyzenko
04:29 AM User Interface Bug #3382: Client-side popup menus abend
Eugenie Lyzenko wrote:
> So the suggested fix approach can be the following change in @ThinClient.invokeTriggers(......
Hynek Cihlar
09:35 PM User Interface Bug #3382: Client-side popup menus abend
So the suggested fix approach can be the following change in @ThinClient.invokeTriggers(...)@, line starting at @1822... Eugenie Lyzenko
01:00 PM Base Language Bug #3406: implement silent error mode as a lambda to allow aborting the control flow
I need to investigate more thoroughly, but my initial thoughts:
@RecordBuffer$Handler.invoke@: should be safe to r...
Eric Faulhaber
12:45 PM Base Language Bug #3406: implement silent error mode as a lambda to allow aborting the control flow
I will post more details of the problem and the proposed solution shortly. But for now, I have a question.
The pe...
Greg Shah
11:16 AM Base Language Bug #3406: implement silent error mode as a lambda to allow aborting the control flow
Created task branch 3406a. The changes for this task are going to be in a sensitive area and will affect many files. Greg Shah

12/04/2017

06:36 PM User Interface Bug #3382: Client-side popup menus abend
Debugging result. The current events data flow:
1. After the user clicks on @Scroll here@ pop up menu from scrollb...
Eugenie Lyzenko
04:00 PM User Interface Feature #3394: generic drawing improvements: repaint and other misc code
Sergey Ivanovskiy wrote:
> The order of repaints can be the root cause?
No, as they just determine which widgets wi...
Constantin Asofiei
03:27 PM User Interface Feature #3394: generic drawing improvements: repaint and other misc code
The order of repaints can be the root cause? Sergey Ivanovskiy
03:25 PM User Interface Feature #3394: generic drawing improvements: repaint and other misc code
Updated #3394-18 with correct logs. Yes, they are 121 and 124. Sergey Ivanovskiy
03:10 PM User Interface Feature #3394: generic drawing improvements: repaint and other misc code
Sergey Ivanovskiy wrote:
> Finally, the last two nodes: "Twin" and "Luxury Suite " were not repainted.
Do you now t...
Constantin Asofiei
03:08 PM User Interface Feature #3394: generic drawing improvements: repaint and other misc code
Yes, I tested Hotel GUI Add Room Dialog and opened the first node and then opened the second node. Finally, the last ... Sergey Ivanovskiy
01:38 PM User Interface Feature #3394: generic drawing improvements: repaint and other misc code
Sergey Ivanovskiy wrote:
> Interesting note if setup conditional breakpoints for the tree control widgets in @Abstra...
Constantin Asofiei
01:35 PM User Interface Feature #3394: generic drawing improvements: repaint and other misc code
Interesting note if setup conditional breakpoints for the tree control widgets in @AbstractWidget.afterConfigUpdateBa... Sergey Ivanovskiy
03:57 PM User Interface Bug #2766: implement a text metrics server process
Code Review Task Branch 3394a Revisions 11232/11233
I'm good with the changes.
Greg Shah
02:36 PM User Interface Bug #2766: implement a text metrics server process
Greg, please review 3394a rev 11232/11233. Constantin Asofiei
01:27 PM User Interface Bug #2766: implement a text metrics server process
Greg Shah wrote:
> You recently added the captured @text-metrics.xml@ to the project. Was there a problem that drov...
Constantin Asofiei
01:21 PM User Interface Bug #2766: implement a text metrics server process
> Another note: currently FontManager reads the entire font-table (~46k strings) into the client-side's memory. In th... Greg Shah
01:18 PM User Interface Bug #2766: implement a text metrics server process
I was not using the properly derived font (as Swing was doing) when computing the metrics. With current changes, the... Constantin Asofiei
10:52 AM User Interface Bug #2766: implement a text metrics server process
Some quick and dirty changes in web code allow AWT Font and FontMetrics to be used. But I think I'm not using the co... Constantin Asofiei
08:02 AM User Interface Bug #2766: implement a text metrics server process
Agreed. Greg Shah
06:26 AM User Interface Bug #2766: implement a text metrics server process
Greg Shah wrote:
> Another approach might be to use caching for the calculated metrics. This would have to be done ...
Constantin Asofiei
06:14 AM User Interface Bug #2766: implement a text metrics server process
I agree we should resolve this.
If we can calculate suitable metrics in the Java client, I would be fine with that...
Greg Shah
06:05 AM User Interface Bug #2766: implement a text metrics server process
In addition to the functional issues we see from deviations from the Windows metrics when encountering dynamic text, ... Greg Shah
08:38 AM Base Language Bug #3406 (Closed): implement silent error mode as a lambda to allow aborting the control flow
Greg Shah

12/03/2017

09:13 AM Base Language Bug #3400: shared variables context for RUN int-proc IN ext-proc-handle is not properly pushed
Greg Shah wrote:
> Code Review Task Branch 3394a Revision 11225
>
> 1. In @ProcedureManager.searchInStack()@, why...
Constantin Asofiei
12:56 AM Base Language Bug #3400: shared variables context for RUN int-proc IN ext-proc-handle is not properly pushed
Code Review Task Branch 3394a Revision 11225
1. In @ProcedureManager.searchInStack()@, why use a map as @searched@...
Greg Shah

12/02/2017

02:38 PM Base Language Bug #3400: shared variables context for RUN int-proc IN ext-proc-handle is not properly pushed
The fixes are in 3394a rev 11225
In the end, the problem was that the lookup for shared vars must be performed on ...
Constantin Asofiei
11:44 AM User Interface Bug #3382: Client-side popup menus abend
Eugenie Lyzenko wrote:
>
> This also eliminates the exception for widgets that detached from parent, like pop-up m...
Hynek Cihlar

12/01/2017

05:46 PM User Interface Bug #3382: Client-side popup menus abend
Hynek Cihlar wrote:
> Eugenie Lyzenko wrote:
>
> If in the menu-item it is expected that the top-level window may...
Eugenie Lyzenko
04:56 PM User Interface Bug #3382: Client-side popup menus abend
Eugenie Lyzenko wrote:
> This change resolve the issue. Any objections or notes?
The exception thrown from @topLe...
Hynek Cihlar
04:38 PM User Interface Bug #3382: Client-side popup menus abend
The root cause for this issue is the code in pop up menu item:... Eugenie Lyzenko
04:42 PM User Interface Bug #3401: clarifications for windows related methods in Widget and GuiDriver classes
Patch committed to 3394a as revision 11221. Ovidiu Maxiniuc
03:07 PM User Interface Bug #3401: clarifications for windows related methods in Widget and GuiDriver classes
Recently I used the @window()@ method to pass the window id of a @EditorGuiImpl@ in the @GuiDriver@ for accessing som... Ovidiu Maxiniuc
02:42 PM User Interface Bug #3401 (Closed): clarifications for windows related methods in Widget and GuiDriver classes
Ovidiu Maxiniuc
10:47 AM Base Language Feature #3262: implement COM/OLE Automation support
Task branch @3262b@ has been updated for review to revision @11248@.
Adding protection for null characters passed ...
Eugenie Lyzenko
10:45 PM Base Language Feature #3262: implement COM/OLE Automation support
During testing COM feature with big application found new issues:
1. The file resources to be taken from application...
Eugenie Lyzenko
10:11 PM Base Language Feature #3262: implement COM/OLE Automation support
> Is it OK to leave this feature postponed?
Yes, you can match the support level of the Java code.
Greg Shah
09:50 PM Base Language Feature #3262: implement COM/OLE Automation support
Task branch @3262b@ has been updated for review to revision @11247@.
OK. This update returns native code to the st...
Eugenie Lyzenko
07:14 PM Base Language Feature #3262: implement COM/OLE Automation support
Constantin Asofiei wrote:
> > So for now you offer to have nothing extent array support.
> Yes, because the correct...
Eugenie Lyzenko
10:27 AM User Interface Feature #3394: generic drawing improvements: repaint and other misc code
3394a was rebased from trunk rev 11208 - new rev 11219. Constantin Asofiei
09:55 AM User Interface Feature #3394: generic drawing improvements: repaint and other misc code
Constantin Asofiei wrote:
> I'm rebasing 3394a rev 11217 in 15 minutes if nobody objects.
Constantin Asofiei
09:40 AM User Interface Feature #3394: generic drawing improvements: repaint and other misc code
I'm rebasing 3394a rev 11217 in 15 minutes if nobody objects. Constantin Asofiei
08:21 AM Base Language Bug #3400: shared variables context for RUN int-proc IN ext-proc-handle is not properly pushed
The main problems I identified are:
# a shared-var leak for persistent procedures (they are not being removed when t...
Constantin Asofiei
08:19 AM Base Language Bug #3400 (Closed): shared variables context for RUN int-proc IN ext-proc-handle is not properly ...
Constantin Asofiei

11/30/2017

05:53 PM Base Language Feature #3396: shift searchpath and other pathing lists in the directory to use the platform neut...
I almost completely forgot about #3225. I took a quick look over it. The 3225b contains only a single altered file: @... Ovidiu Maxiniuc
04:51 PM Base Language Feature #3396: shift searchpath and other pathing lists in the directory to use the platform neut...
The @searchpath@ is the @directory.xml@ value that is used by the FWD runtime to represent the @PROPATH@. Since FWD ... Greg Shah
05:14 PM Base Language Feature #3262: implement COM/OLE Automation support
Guys,
More complex approach can be to introduce new class for results coming from native side to Java, say @ComRet...
Eugenie Lyzenko
04:55 PM Base Language Feature #3262: implement COM/OLE Automation support
Eugenie Lyzenko wrote:
> Another word as I can see you removed (undone) all recent changes prepared to handle extent...
Constantin Asofiei
04:50 PM Base Language Feature #3262: implement COM/OLE Automation support
Constantin Asofiei wrote:
> Eugenie, please see 3262b rev 11246. Note that you will need to have some changes in th...
Eugenie Lyzenko
04:15 PM Base Language Feature #3262: implement COM/OLE Automation support
Eugenie, please see 3262b rev 11246. Note that you will need to have some changes in the FWD native COM part, becaus... Constantin Asofiei
01:01 PM Base Language Feature #3262: implement COM/OLE Automation support
Yes. I didn't start yet to fix the branch, I'll try tonight or tomorrow the latest. Constantin Asofiei
12:57 PM Base Language Feature #3262: implement COM/OLE Automation support
Yes, we have signature match issue. Like this when @FWD@ expects @comhandle.call()@ returning @BDT@ while our @comhan... Eugenie Lyzenko
11:53 AM Base Language Feature #3262: implement COM/OLE Automation support
Greg Shah wrote:
> Code Review Task Branch 3262b Revision 11244
>
> I've checked in some changes as 11245. I'm g...
Eugenie Lyzenko
11:00 AM Base Language Feature #3262: implement COM/OLE Automation support
Code Review Task Branch 3262b Revision 11244
I've checked in some changes as 11245. I'm good with that version. ...
Greg Shah
09:28 AM Base Language Feature #3262: implement COM/OLE Automation support
Task branch @3262b@ has been updated for review to revision @11244@.
The notes resolution changes. Optional @NO-CO...
Eugenie Lyzenko
08:47 AM Base Language Feature #3262: implement COM/OLE Automation support
Greg Shah wrote:
> Code Review Task Branch 3262b Revision 11243
>
> 1. Please make the 4th parameter to @launch()...
Eugenie Lyzenko
06:07 AM Base Language Feature #3262: implement COM/OLE Automation support
Code Review Task Branch 3262b Revision 11243
1. Please make the 4th parameter to @launch()@ optional. This means ...
Greg Shah
10:42 PM Base Language Feature #3262: implement COM/OLE Automation support
Task branch @3262b@ has been updated for review to revision @11243@.
This is minor javadoc fixes for my recent cha...
Eugenie Lyzenko
09:47 PM Base Language Feature #3262: implement COM/OLE Automation support
Task branch @3262b@ has been rebased with recent trunk @11208@, new version is @11242@. Eugenie Lyzenko
09:27 PM Base Language Feature #3262: implement COM/OLE Automation support
Task branch @3262b@ has been updated for review to revision @11241@.
This update fixes the handling of the @NO-WAI...
Eugenie Lyzenko

11/29/2017

05:15 PM Base Language Feature #3262: implement COM/OLE Automation support
> Is this OK?
Yes.
> Observing the rule file for process launch I see we do not have any support for NO-CONSOLE...
Greg Shah
02:58 PM Base Language Feature #3262: implement COM/OLE Automation support
For Windows @SILENT@ option I suggest to change the @ProcessDaemon@ class to take into account the same reaction for ... Eugenie Lyzenko
11:19 AM Base Language Feature #3262: implement COM/OLE Automation support
> For example notepad.exe and regedit.exe cause the 4GL application to finish external app to continue after os-comm... Greg Shah
11:15 AM Base Language Feature #3262: implement COM/OLE Automation support
Constantin Asofiei wrote:
> Eugenie, I've tried this simple program, with @pro@, @prowin@ and from procedure editor,...
Eugenie Lyzenko
11:12 AM Base Language Feature #3262: implement COM/OLE Automation support
Yes, @notepad.exe@, @regedit.exe@, also @write.exe@ can be started with @no-console@ option. However the behavior is ... Eugenie Lyzenko
11:05 AM Base Language Feature #3262: implement COM/OLE Automation support
Greg Shah wrote:
> Are you testing with OpenEdge 11.6?
@11.6.3@.
Eugenie Lyzenko
10:28 AM Base Language Feature #3262: implement COM/OLE Automation support
Eugenie, I've tried this simple program, with @pro@, @prowin@ and from procedure editor, and it opens the @notepad.ex... Constantin Asofiei
10:27 AM Base Language Feature #3262: implement COM/OLE Automation support
Greg Shah wrote:
> Try running a program that has no GUI and which also can be made to run without STDIN/STDOUT/STDE...
Hynek Cihlar
08:59 AM Base Language Feature #3262: implement COM/OLE Automation support
Try running a program that has no GUI and which also can be made to run without STDIN/STDOUT/STDERR. In other words,... Greg Shah
08:24 AM Base Language Feature #3262: implement COM/OLE Automation support
Are you testing with OpenEdge 11.6? Greg Shah
08:11 AM Base Language Feature #3262: implement COM/OLE Automation support
Greg Shah wrote:
> @dir@ is an internal feature of the @cmd.exe@ shell. It won't work without the shell. But launc...
Eugenie Lyzenko
07:43 AM Base Language Feature #3262: implement COM/OLE Automation support
@dir@ is an internal feature of the @cmd.exe@ shell. It won't work without the shell. But launching a @.exe@ progra... Greg Shah
07:39 AM Base Language Feature #3262: implement COM/OLE Automation support
Greg Shah wrote:
> I will review the changes shortly.
>
> > NO-CONSOLE - does not start any child process in GUI....
Eugenie Lyzenko
06:02 AM Base Language Feature #3262: implement COM/OLE Automation support
I will review the changes shortly.
> NO-CONSOLE - does not start any child process in GUI.
I don't understand w...
Greg Shah
09:22 PM Base Language Feature #3262: implement COM/OLE Automation support
Task branch @3262b@ has been updated for review to revision @11240@.
The change adds initial step to turn the chil...
Eugenie Lyzenko
05:58 AM User Interface Feature #3394: generic drawing improvements: repaint and other misc code
3394a 11213 passed main runtime testing. Constantin Asofiei

11/28/2017

06:51 PM Base Language Feature #3262: implement COM/OLE Automation support
The testcases repo has been updated to revision @1705@.
The child process starting testcases added for @GUI@ mode ...
Eugenie Lyzenko
05:59 PM Base Language Feature #3262: implement COM/OLE Automation support
Greg Shah wrote:
>
> Please check the @NO-WAIT@, @SILENT@ and @NO-CONSOLE@ options. I suspect the @NO-WAIT@ is pr...
Eugenie Lyzenko
03:56 PM Base Language Feature #3262: implement COM/OLE Automation support
Task branch @3262b@ has been rebased with trunk @11207@, new revision is @11239@. Eugenie Lyzenko
03:47 PM Base Language Feature #3262: implement COM/OLE Automation support
Starting the rebase. Eugenie Lyzenko
03:45 PM Base Language Feature #3262: implement COM/OLE Automation support
Constantin Asofiei wrote:
> Greg/Eugenie: I plan to make the Java code in 3262b generic enough so that we will be ab...
Greg Shah
03:44 PM Base Language Feature #3262: implement COM/OLE Automation support
> >Eugenie: Would you please run some testcases to see how the interactive child process launching works under GUI? I... Greg Shah
03:42 PM Base Language Feature #3262: implement COM/OLE Automation support
Greg/Eugenie: I plan to make the Java code in 3262b generic enough so that we will be able to add the missing extent ... Constantin Asofiei
03:32 PM Base Language Feature #3262: implement COM/OLE Automation support
Planning to rebase the branch with the recent trunk in a 10 min. if nobody objects. Eugenie Lyzenko
03:27 PM Base Language Feature #3262: implement COM/OLE Automation support
Greg Shah wrote:
>Eugenie: Would you please run some testcases to see how the interactive child process launching wo...
Eugenie Lyzenko
03:19 PM Base Language Feature #3262: implement COM/OLE Automation support
Eugenie Lyzenko wrote:
> Constantin Asofiei wrote:
> > Eugenie Lyzenko wrote:
> > > Constantin Asofiei wrote:
> >...
Constantin Asofiei
03:17 PM Base Language Feature #3262: implement COM/OLE Automation support
Constantin Asofiei wrote:
> Eugenie Lyzenko wrote:
> > Constantin Asofiei wrote:
> > >Eugenie: the large GUI app w...
Eugenie Lyzenko
03:06 PM Base Language Feature #3262: implement COM/OLE Automation support
Greg Shah wrote:
> Code Review Task Branch 3262b Revision 11234
> ...
>4. The changes in comauto_win.c are so exte...
Eugenie Lyzenko
02:42 PM Base Language Feature #3262: implement COM/OLE Automation support
Task branch @3262b@ has been updated for review to revision @11238@.
Undo the @EnvironmentOps@ change that fixes t...
Eugenie Lyzenko
02:29 PM Base Language Feature #3262: implement COM/OLE Automation support
Eugenie Lyzenko wrote:
> Constantin Asofiei wrote:
> >Eugenie: the large GUI app we are using has constructs like S...
Constantin Asofiei
02:27 PM Base Language Feature #3262: implement COM/OLE Automation support
Constantin Asofiei wrote:
>Eugenie: the large GUI app we are using has constructs like STRING(com-var:property) - th...
Eugenie Lyzenko
02:25 PM Base Language Feature #3262: implement COM/OLE Automation support
Constantin Asofiei wrote:
> Greg Shah wrote:
> > It seems we should just continue the work in this branch to finish...
Greg Shah
02:24 PM Base Language Feature #3262: implement COM/OLE Automation support
> The FWD executes ProcessDaemon.launch() for START EXCEL.EXE some_file.csv. This causes the ChildProcessFactory.getC... Greg Shah
02:16 PM Base Language Feature #3262: implement COM/OLE Automation support
Eugenie Lyzenko wrote:
> Greg Shah wrote:
> > Code Review Task Branch 3262b Revision 11234
> >
> >1. In assignme...
Constantin Asofiei
02:15 PM Base Language Feature #3262: implement COM/OLE Automation support
Greg Shah wrote:
> It seems we should just continue the work in this branch to finish the extent support, rather tha...
Constantin Asofiei
02:14 PM Base Language Feature #3262: implement COM/OLE Automation support
Greg Shah wrote:
> Code Review Task Branch 3262b Revision 11234
>
>1. In assignments.rules, the newly added code ...
Eugenie Lyzenko
02:13 PM Base Language Feature #3262: implement COM/OLE Automation support
It seems we should just continue the work in this branch to finish the extent support, rather than reverting it all. Greg Shah
02:00 PM Base Language Feature #3262: implement COM/OLE Automation support
Greg Shah wrote:
> Constantin: Do you have any concerns about the changes in this branch?
I've fixed some cases (re...
Constantin Asofiei
01:58 PM Base Language Feature #3262: implement COM/OLE Automation support
Greg Shah wrote:
> Code Review Task Branch 3262b Revision 11234
>
> 3. The @EnvironmentOps@ change is not correct...
Eugenie Lyzenko
01:56 PM Base Language Feature #3262: implement COM/OLE Automation support
Greg Shah wrote:
> > found the cases that use COM prefixed with starting EXCEL.EXE as subprocess which is currently ...
Eugenie Lyzenko
12:26 PM Base Language Feature #3262: implement COM/OLE Automation support
Constantin: Do you have any concerns about the changes in this branch? Greg Shah
12:25 PM Base Language Feature #3262: implement COM/OLE Automation support
> found the cases that use COM prefixed with starting EXCEL.EXE as subprocess which is currently not supported in FWD... Greg Shah
12:23 PM Base Language Feature #3262: implement COM/OLE Automation support
Code Review Task Branch 3262b Revision 11234
1. In @assignments.rules@, the newly added code is disabled because o...
Greg Shah
04:11 PM User Interface Feature #3394: generic drawing improvements: repaint and other misc code
Greg Shah wrote:
> 1. In @Button.setText()@ and @ToggleBox.setText()@ why is it safe to only repaint in @autoResize@...
Constantin Asofiei
04:08 PM User Interface Feature #3394: generic drawing improvements: repaint and other misc code
Code Review Task Branch 3394a Revision 11211
1. In @Button.setText()@ and @ToggleBox.setText()@ why is it safe to ...
Greg Shah
01:15 PM User Interface Feature #3394: generic drawing improvements: repaint and other misc code
> I think the improvements I made to postpone the drawing should be done only in GUI; ChUI has the PUT SCREEN stuff w... Greg Shah
11:43 AM User Interface Feature #3394: generic drawing improvements: repaint and other misc code
Greg Shah wrote:
> Do you want to make 3394a the next "accumulate the fixes" branch? Or would you prefer to keep it...
Constantin Asofiei
10:57 AM User Interface Feature #3394: generic drawing improvements: repaint and other misc code
Do you want to make 3394a the next "accumulate the fixes" branch? Or would you prefer to keep it separate? Greg Shah
02:26 PM User Interface Bug #3390 (Closed): Eliminate unnecessary frame redraws due to inconsistent calculated height
Greg Shah
02:15 PM User Interface Bug #3390: Eliminate unnecessary frame redraws due to inconsistent calculated height
3390a was merged to trunk as revision 11207 and archived. Hynek Cihlar
02:10 PM User Interface Bug #3390: Eliminate unnecessary frame redraws due to inconsistent calculated height
Please merge to trunk. Greg Shah
01:53 PM User Interface Bug #3390: Eliminate unnecessary frame redraws due to inconsistent calculated height
3390a passed regression tests and was rebased against trunk 11206. No more changes are expected in the branch. Hynek Cihlar
01:11 PM User Interface Bug #3373: incremental scroll in non-full Browse page
It is OK to call @UnimplementedFeature@ on the client. It will be logged there and that is OK.
Since 3369a is merg...
Greg Shah
12:13 PM Base Language Feature #3396 (WIP): shift searchpath and other pathing lists in the directory to use the platfor...
Greg Shah
07:29 AM User Interface Bug #3395: rectangle:edge-chars is not working in GUI
The @RECTANGLE:EDGE-CHARS@ is not working in GUI clients. We need to be able for @EDGE-PIXELS@ and @EDGE-CHARS@ to w... Constantin Asofiei
07:28 AM User Interface Bug #3395 (Closed): rectangle:edge-chars is not working in GUI
Constantin Asofiei

11/27/2017

06:49 PM User Interface Feature #3394: generic drawing improvements: repaint and other misc code
3394a rev 11208 adds this:
* Batch the MSG_REGISTER_HOVERABLE_WIDGET messages.
* Avoid gd.setCurrentSelection(null)...
Constantin Asofiei
05:38 PM User Interface Feature #3394: generic drawing improvements: repaint and other misc code
I've been looking into the JS code and there are some findings:
# we can reduce the @MSG_REGISTER_HOVERABLE_WIDGET@ ...
Constantin Asofiei
04:40 PM User Interface Feature #3394: generic drawing improvements: repaint and other misc code
For #3394-3, the changes are in 3394a rev 11207. Constantin Asofiei
03:22 PM User Interface Feature #3394: generic drawing improvements: repaint and other misc code
Another issue to improve is described by this email chain:
-------
Constantin,
according to win32 api docs...
Constantin Asofiei
03:20 PM User Interface Feature #3394: generic drawing improvements: repaint and other misc code
An issue to try to improve is described by this email chain:
-------------
I agree that Hynek's idea of two que...
Constantin Asofiei
03:19 PM User Interface Feature #3394: generic drawing improvements: repaint and other misc code
In branch 3369a (trunk rev 11206), there are some fixes which remove some aggressive @repaint()@ calls when i.e. fram... Constantin Asofiei
03:18 PM User Interface Feature #3394 (Closed): generic drawing improvements: repaint and other misc code
Constantin Asofiei
06:15 PM Base Language Feature #3262: implement COM/OLE Automation support
Task branch @3262b@ has been updated for review to revision @11233@, rebased with recent trunk, new version is @11234... Eugenie Lyzenko
03:56 PM User Interface Bug #3390: Eliminate unnecessary frame redraws due to inconsistent calculated height
Hynek Cihlar wrote:
> A fix checked in to 3390a revision 11206. Please review.
I'm OK with the changes.
Constantin Asofiei
03:47 PM Bug #3378 (Closed): Date input fields don't get focus by clicking on them
Branch 3369a was merged to trunk as revision 11206. Greg Shah
03:47 PM User Interface Bug #3374 (Closed): NPE in ConfigManager
Branch 3369a was merged to trunk as revision 11206. Greg Shah
03:46 PM Database Bug #3372 (Closed): Unexpected usage of standalone unknown value.
Branch 3369a was merged to trunk as revision 11206. Greg Shah
03:46 PM User Interface Bug #3371 (Closed): NPE in AbstractGuiDriver in client log
Branch 3369a was merged to trunk as revision 11206. Greg Shah
03:45 PM Bugs Bug #3355 (Closed): The tab pane button for HOTEL GUI is not included in the focus traversal chain
Branch 3369a was merged to trunk as revision 11206. Greg Shah
03:44 PM User Interface Feature #3369 (Closed): add support for BGCOLOR-RGB and FGCOLOR-RGB, FWD extension widget attributes
Greg Shah
03:11 PM User Interface Feature #3369 (WIP): add support for BGCOLOR-RGB and FGCOLOR-RGB, FWD extension widget attributes
3369a Was merged to trunk rev 11206 and archived. Constantin Asofiei
02:29 PM User Interface Feature #3369: add support for BGCOLOR-RGB and FGCOLOR-RGB, FWD extension widget attributes
No problem. I am un-committing 3369a/ right now. Ovidiu Maxiniuc
01:30 PM User Interface Feature #3369: add support for BGCOLOR-RGB and FGCOLOR-RGB, FWD extension widget attributes
No, I want to get the 3369a into the trunk.
Ovidiu: Would you please move the changes 11248 into a separate branch?
Greg Shah
01:15 PM User Interface Feature #3369: add support for BGCOLOR-RGB and FGCOLOR-RGB, FWD extension widget attributes
Constantin Asofiei wrote:
> Another regression fixed, 3369a rev 11247 is in testing.
Rev 11247 passed main part of ...
Constantin Asofiei
08:56 AM User Interface Feature #3369: add support for BGCOLOR-RGB and FGCOLOR-RGB, FWD extension widget attributes
Another regression fixed, 3369a rev 11247 is in testing. Constantin Asofiei
03:33 AM User Interface Feature #3369: add support for BGCOLOR-RGB and FGCOLOR-RGB, FWD extension widget attributes
Don't mind it works now, after external jconsole has been accessed to the client process. It is not a bug probably. Sergey Ivanovskiy
03:29 AM User Interface Feature #3369: add support for BGCOLOR-RGB and FGCOLOR-RGB, FWD extension widget attributes
I am using 3369a to work on #3385 and it seems that the Login screen (Swing client) doesn't accept keys input. Sergey Ivanovskiy
09:29 AM User Interface Bug #3373: incremental scroll in non-full Browse page
> I thing we should log the event instead (@UnimplementedFeature.TODO@) as a reminder and return @false@ because no r... Stanislav Lomany
 

Also available in: Atom