FWD

01/16/2018

10:24 PM User Interface Bug #3381: Sub-menu drawing issues

Task branch @3381a@ has been updated for review to revision @11221@.
The update is a starting point for keyboard n... Eugenie Lyzenko

01/15/2018

12:41 PM User Interface Bug #3381: Sub-menu drawing issues

Interesting finding for original @4GL@ behavior. On @4GL@ capable @Windows@ system.
When navigating menu via keybo... Eugenie Lyzenko

08:12 AM User Interface Bug #3381: Sub-menu drawing issues

Eugenie Lyzenko wrote:
> Hynek,
>
> Are the problem in notes @94@ and @95@ the regressions from branch changes or... Hynek Cihlar

06:56 AM User Interface Bug #3381: Sub-menu drawing issues

Hynek,
Are the problem in notes @94@ and @95@ the regressions from branch changes or new found issues? Eugenie Lyzenko

04:33 AM User Interface Bug #3381: Sub-menu drawing issues

Greg Shah wrote:
> Hynek: Can we merge this to trunk? Or should we merge this into 3435a?
Yes I think it can be ... Hynek Cihlar

04:28 AM User Interface Bug #3381: Sub-menu drawing issues

Some more issue in the latest 3381a.
To reproduce 1:
* in @menu/menubar.p@
* click on a root menu item
* click ... Hynek Cihlar

04:04 AM User Interface Bug #3381: Sub-menu drawing issues

I found two more issue in the latest 3381a.
To reproduce 1:
* run @menu/menubar.p@
* open the menu and navigate ... Hynek Cihlar

01/13/2018

07:20 AM User Interface Bug #3381: Sub-menu drawing issues

Hynek: Can we merge this to trunk? Or should we merge this into 3435a? Greg Shah

01/12/2018

05:40 PM User Interface Bug #3381: Sub-menu drawing issues

Running the testcases I have not found the regressions.
And the @ChUI@ code was not touched in this branch. Eugenie Lyzenko

05:54 AM User Interface Bug #3425: text is drawn 1-pixel to the left, cutting the text

FYI.
To draw a columns separator we should decide to which column it belongs. In original design a column contained ... Stanislav Lomany

01/11/2018

05:40 PM Database Feature #3296: misc db features

Test case for triple-nested CAN-FIND issue @nested-canfind-3-deep.p@:... Eric Faulhaber

04:43 AM User Interface Bug #3381: Sub-menu drawing issues

Eugenie Lyzenko wrote:
> Task branch @3381a@ has been updated for review to revision @11220@.
>
> And I still nee... Hynek Cihlar

01/10/2018

06:25 PM User Interface Bug #3381: Sub-menu drawing issues

Task branch @3381a@ has been updated for review to revision @11220@.
Fixed the @1@ and @2@ notes resolution. The i... Eugenie Lyzenko

03:18 PM User Interface Bug #3381: Sub-menu drawing issues

Hynek Cihlar wrote:
>1. When menu bar is hovered and then mouse-exited the highlight should go away, but it stays on... Eugenie Lyzenko

01:15 AM User Interface Bug #3381: Sub-menu drawing issues

Code review 3381a/11219.
Exiting the highlighted item now looks solid. Also I don't see anything wrong with the co... Hynek Cihlar

01/09/2018

03:10 PM User Interface Bug #3381: Sub-menu drawing issues

Task branch @3381a@ has been updated for review to revision @11219@.
This is the fix for point @3@ with mouse exit... Eugenie Lyzenko

01:22 PM User Interface Bug #3381: Sub-menu drawing issues

Hynek Cihlar wrote:
> Eugenie Lyzenko wrote:
> > OK. Need to perform some debugging.
>
> Eugenie, I suggest you ... Eugenie Lyzenko

08:24 AM User Interface Bug #3381: Sub-menu drawing issues

Eugenie Lyzenko wrote:
> OK. Need to perform some debugging.
Eugenie, I suggest you put a couple of trace stateme... Hynek Cihlar

08:19 AM User Interface Bug #3381: Sub-menu drawing issues

Hynek Cihlar wrote:
> > Yes, it is true. However I think the mouse exited event is not properly posted in this case.... Eugenie Lyzenko

06:07 AM User Interface Bug #3381: Sub-menu drawing issues

Eugenie Lyzenko wrote:
> Hynek Cihlar wrote:
> > > I mean the main event queue in @ThinClient@ event loop where the... Hynek Cihlar

06:06 AM User Interface Bug #3381: Sub-menu drawing issues

Hynek Cihlar wrote:
> > I mean the main event queue in @ThinClient@ event loop where the mouse events are posting fr... Eugenie Lyzenko

05:51 AM User Interface Bug #3381: Sub-menu drawing issues

Eugenie Lyzenko wrote:
> Hynek Cihlar wrote:
> > Eugenie Lyzenko wrote:
> > > Task branch @3381a@ has been updated... Hynek Cihlar

05:46 AM User Interface Bug #3381: Sub-menu drawing issues

Hynek Cihlar wrote:
> Eugenie Lyzenko wrote:
> > Task branch @3381a@ has been updated for review to revision @11218... Eugenie Lyzenko

04:18 AM User Interface Bug #3381: Sub-menu drawing issues

Eugenie Lyzenko wrote:
> Task branch @3381a@ has been updated for review to revision @11218@.
>
> This is the fix... Hynek Cihlar

09:42 PM User Interface Bug #3381: Sub-menu drawing issues

Task branch @3381a@ has been updated for review to revision @11218@.
This is the fixes for notes @1-4@. As to note... Eugenie Lyzenko

01:33 PM Runtime Infrastructure Bug #3436: miscellaneous performance fixes

Some additional ideas on performance to implement when there is time:
*Read-only Tables.* We need to identify tabl... Eric Faulhaber

01/08/2018

04:22 PM Base Language Feature #3342: implement a facility to easily run a JasperReports report definition from 4GL code...

1-8 hours depending on if there will be issues with Jasper. Stanislav Lomany

04:16 PM Base Language Feature #3342: implement a facility to easily run a JasperReports report definition from 4GL code...

What is the effort to enable output to XLS? Greg Shah

12:58 PM User Interface Bug #3381: Sub-menu drawing issues

Eugenie Lyzenko wrote:
> Task branch @3381a@ has been updated for review to revision @11216@.
>
> The update cont... Hynek Cihlar

01/05/2018

11:38 AM User Interface Bug #3425: text is drawn 1-pixel to the left, cutting the text

I still see the issue. This is using the latest 3435a:
!3435a_browse_header_text_positioning_issue_20180105.png!
... Greg Shah

10:36 AM User Interface Bug #3425 (WIP): text is drawn 1-pixel to the left, cutting the text

I do not see the issue in the hotel app either Swing or web using the current trunk. Please confirm. Stanislav Lomany

06:40 AM User Interface Feature #3369: add support for BGCOLOR-RGB and FGCOLOR-RGB, FWD extension widget attributes

Hynek Cihlar wrote:
> I wasn't in the issue watch list and I missed the last two notes.
>
> I resolved the point ... Greg Shah

07:07 PM Runtime Infrastructure Bug #3436: miscellaneous performance fixes

Eric Faulhaber wrote:
> @BigDecimal.valueOf(double)@ and @BigDecimal.setScale(int,int)@ are still showing up as medi... Hynek Cihlar

01/04/2018

06:57 PM User Interface Feature #3369: add support for BGCOLOR-RGB and FGCOLOR-RGB, FWD extension widget attributes

I wasn't in the issue watch list and I missed the last two notes.
I resolved the point in note 40, rebased 3369b a... Hynek Cihlar

04:48 PM User Interface Bug #3381: Sub-menu drawing issues

Task branch @3381a@ has been updated for review to revision @11216@.
The update contains fixes to resolve menu rel... Eugenie Lyzenko

07:45 PM User Interface Bug #3381: Sub-menu drawing issues

Task branch @3381a@ has been updated for review to revision @11215@.
This is the fix for notes @2@ and @4@ in rema... Eugenie Lyzenko

01:40 PM Runtime Infrastructure Bug #3436: miscellaneous performance fixes

@BigDecimal.valueOf(double)@ and @BigDecimal.setScale(int,int)@ are still showing up as medium hot spots on the clien... Eric Faulhaber

01:28 PM Runtime Infrastructure Bug #3436: miscellaneous performance fixes

Hynek, profiling of the client confirmed that we were still calling @ConfigManager.getInstance@ quite a lot from the ... Eric Faulhaber

07:22 PM Runtime Infrastructure Bug #3436: miscellaneous performance fixes

Possibly. I'll do some more profiling and see if these cases pop up. Thanks.
In the mean time, I've committed the ... Eric Faulhaber

01:28 PM User Interface Feature #3246: reduce the amount of data being sent to the client-side when an UI attribute is be...

Greg Shah wrote:
> Is the current GUI application using the calendar control?
>
> We intend to implement a "4GL s... Constantin Asofiei

12:27 PM User Interface Feature #3246: reduce the amount of data being sent to the client-side when an UI attribute is be...

> Almost; this is always problematic when building an UI with dynamic widgets - see the calendar. In this case, there... Greg Shah

12:21 PM User Interface Feature #3246: reduce the amount of data being sent to the client-side when an UI attribute is be...

> I would consider to automate this and implement the common logic of the setter in AspectJ (i.e. the check for dirty... Greg Shah

01/03/2018

06:40 PM Runtime Infrastructure Bug #3436: miscellaneous performance fixes

Eric Faulhaber wrote:
> Hynek, please review the changes in 3436a/11215. Greg asked me to put this in a branch separ... Hynek Cihlar

04:35 PM Runtime Infrastructure Bug #3436: miscellaneous performance fixes

Hynek, please review the changes in 3436a/11215. Greg asked me to put this in a branch separate from 3435a, pending y... Eric Faulhaber

04:51 AM Runtime Infrastructure Bug #3436: miscellaneous performance fixes

Code review 3435a/11228. The changes are good. Hynek Cihlar

05:09 PM User Interface Feature #3246: reduce the amount of data being sent to the client-side when an UI attribute is be...

Greg Shah wrote:
> Constantin:
>
> * Is my recollection correct?
Almost; this is always problematic when buildi... Constantin Asofiei

04:55 PM User Interface Feature #3246: reduce the amount of data being sent to the client-side when an UI attribute is be...

FYI, here's what the same use case looks like on the client, starting at @BitSet.clear@ <- @BitSet.set@ <- @ConfigMan... Eric Faulhaber

04:26 PM User Interface Feature #3246: reduce the amount of data being sent to the client-side when an UI attribute is be...

Greg Shah wrote:
> Instead of looking at AspectJ, perhaps we can come up with an alternate approach. What about a g... Hynek Cihlar

03:36 PM User Interface Feature #3246: reduce the amount of data being sent to the client-side when an UI attribute is be...

The following screenshot was taken by ECF during his work on profiling the initial load of a complex ADM screen:
!... Greg Shah

02:47 PM User Interface Bug #3381: Sub-menu drawing issues

Eugenie Lyzenko wrote:
> Hynek Cihlar wrote:
> > 4. Item 3 from note 60 is still an issue.
>
> I do not have thi... Hynek Cihlar

08:53 AM User Interface Bug #3381: Sub-menu drawing issues

Hynek Cihlar wrote:
> 4. Item 3 from note 60 is still an issue.
I do not have this one. If you mean: @3. When a m... Eugenie Lyzenko

01/02/2018

05:48 PM Runtime Infrastructure Bug #3436: miscellaneous performance fixes

Hynek, please see task branch 3435a/11228. The thread-local access in @ConfigSyncManager@ was showing up as a hot spo... Eric Faulhaber

10:06 AM Runtime Infrastructure Bug #3436: miscellaneous performance fixes

Code Review Task Branch 3435a Revisions 11223 through 11225 Inclusive
I'm good with the changes. Greg Shah

03:47 PM Base Language Bug #3406 (Closed): implement silent error mode as a lambda to allow aborting the control flow

3406b revisions 11215 and 11216 have been merged into 3435a (as revision 11227). Branch 3406b has been archived. Greg Shah

11:07 AM Base Language Bug #3406: implement silent error mode as a lambda to allow aborting the control flow

Branch 3406a was archived.
Task branch 3406b has been rebased from trunk rev 11214. The latest revision is 11215.... Greg Shah

02:48 PM User Interface Bug #3381: Sub-menu drawing issues

Created task branch @3381a@ from trunk revision @11214@. Eugenie Lyzenko

12/29/2017

05:51 PM Runtime Infrastructure Bug #3436: miscellaneous performance fixes

Greg Shah wrote:
> Why not "solve" this by setting some hard limit (50,000 or 100,000) and checking the map size at ... Eric Faulhaber

01:59 PM Runtime Infrastructure Bug #3436: miscellaneous performance fixes

> how likely do you think it is we could get a very large set (say, more than several 10 thousands) of unique regex e... Greg Shah

01:50 PM Runtime Infrastructure Bug #3436: miscellaneous performance fixes

Code Review Task Branch 3435a Revisions 11217 through 11221 Inclusive
I'm fine with the changes. I looked pretty ... Greg Shah

12/28/2017

03:20 PM Runtime Infrastructure Bug #3436: miscellaneous performance fixes

The use of @ExpiryCache.get@ is showing up in profiling from where I added compiled regex pattern caching to @TextOps... Eric Faulhaber

02:59 PM Runtime Infrastructure Bug #3436: miscellaneous performance fixes

Added caching to various places that were showing up as bottlenecks in profiling. Changes committed to 3435a/11217. M... Eric Faulhaber

02:58 PM Runtime Infrastructure Bug #3436 (Closed): miscellaneous performance fixes

Eric Faulhaber

01:52 PM User Interface Bug #3348 (Closed): The opened dropdown influences on the choice for the next tab widget for its ...

Greg Shah

01:46 PM User Interface Bug #3348: The opened dropdown influences on the choice for the next tab widget for its combobox

No, it was fixed in 3394a. Sergey Ivanovskiy

01:03 PM User Interface Bug #3348: The opened dropdown influences on the choice for the next tab widget for its combobox

Does this issue still exist in trunk revision 11214? Greg Shah

01:35 PM User Interface Feature #3369: add support for BGCOLOR-RGB and FGCOLOR-RGB, FWD extension widget attributes

This branch needs a rebase. Do you still believe it is safe to merge to trunk? Another option is to merge it into 3... Greg Shah

12:29 PM User Interface Bug #3381: Sub-menu drawing issues

Hynek Cihlar wrote:
> Greg Shah wrote:
> > The changes are included in task branch 3394a which has been merged to t... Hynek Cihlar

11:19 AM User Interface Bug #3381: Sub-menu drawing issues

Greg Shah wrote:
> The changes are included in task branch 3394a which has been merged to trunk as revision 11214.
... Hynek Cihlar

11:14 AM User Interface Bug #3381: Sub-menu drawing issues

The changes are included in task branch 3394a which has been merged to trunk as revision 11214.
Hynek: Do you have... Greg Shah

11:16 AM Base Language Bug #3430 (Closed): non-shared temp-tables are registered with SVM

Greg Shah

11:14 AM User Interface Bug #3382: Client-side popup menus abend

The changes are included in task branch 3394a which has been merged to trunk as revision 11214.
Can I close this t... Greg Shah

11:13 AM User Interface Bug #2766: implement a text metrics server process

The improvements for web client font metrics processing are included in task branch 3394a which has been merged to tr... Greg Shah

11:12 AM User Interface Bug #3373: incremental scroll in non-full Browse page

The changes are included in task branch 3394a which has been merged to trunk as revision 11214. Greg Shah

11:11 AM User Interface Bug #3401 (Closed): clarifications for windows related methods in Widget and GuiDriver classes

The changes are included in task branch 3394a which has been merged to trunk as revision 11214. Greg Shah

11:08 AM Base Language Bug #3400 (Closed): shared variables context for RUN int-proc IN ext-proc-handle is not properly ...

The changes are included in task branch 3394a which has been merged to trunk as revision 11214. Greg Shah

10:57 AM User Interface Feature #3394 (Closed): generic drawing improvements: repaint and other misc code

Greg Shah

10:57 AM User Interface Feature #3394: generic drawing improvements: repaint and other misc code

Task branch 3394a has been merged to trunk as revision 11214.
I've archived 3394a. Greg Shah

09:13 AM User Interface Feature #3394: generic drawing improvements: repaint and other misc code

The only overlap this time is tc_job_clock_004 which was expected to fail due to the time of the run. At this point ... Greg Shah

03:17 AM User Interface Feature #3394: generic drawing improvements: repaint and other misc code

The next run of ChUI regression completed. Only 2 failures overlapped. Both of those are likely false negatives, ti... Greg Shah

09:29 PM User Interface Feature #3394: generic drawing improvements: repaint and other misc code

I've done one run of main ChUI regression testing. 6 unexpected failures occurred, but they all seem like false nega... Greg Shah

03:20 AM User Interface Feature #2368: allow widget output to stream in GUI mode

I'm OK with the approach, it seems correct. Greg Shah

12/27/2017

04:03 PM User Interface Feature #2368: allow widget output to stream in GUI mode

Hynek Cihlar wrote:
> The named stream redirection seems to work OK since the streamable OM in the GUI OM is redirec... Hynek Cihlar

12:43 PM Conversion Tools Feature #1770: multi-threaded conversion driver

This is an obvious improvement to make that would cut conversion times to a fraction of the current single-threaded t... Greg Shah

08:50 AM User Interface Bug #3373 (Closed): incremental scroll in non-full Browse page

Fixed in branch 3394a revision 11298 which will be merged to trunk shortly. Greg Shah

12/26/2017

03:47 PM User Interface Feature #3394: generic drawing improvements: repaint and other misc code

3394a/11309 has passed ETF full search, developer, and batch tests. Eric Faulhaber

10:42 AM User Interface Feature #3394: generic drawing improvements: repaint and other misc code

Constantin Asofiei wrote:
> Please try 3394a 11309 - I think I had an unbalanced scope start/delete in SVM.
That di... Eric Faulhaber

04:06 AM User Interface Feature #3394: generic drawing improvements: repaint and other misc code

Eric Faulhaber wrote:
> There is a regression in task branch 3394a. ETF search testing grinds to a halt after a few ... Constantin Asofiei

12/25/2017

04:03 PM User Interface Feature #3394: generic drawing improvements: repaint and other misc code

There is a regression in task branch 3394a. ETF search testing grinds to a halt after a few minutes with multiple "No... Eric Faulhaber

07:46 PM Base Language Bug #3406: implement silent error mode as a lambda to allow aborting the control flow

Greg, I've left changes for browse TODOs in 3406b rev 11214. Stanislav Lomany

12/23/2017

05:33 PM User Interface Feature #2368: allow widget output to stream in GUI mode

Constantin Asofiei wrote:
> Hynek, can you give me a simple standalone test which shows a few of the failures you de... Hynek Cihlar

04:10 PM User Interface Feature #2368: allow widget output to stream in GUI mode

Hynek, can you give me a simple standalone test which shows a few of the failures you describe in the previous note? Constantin Asofiei

09:59 AM User Interface Feature #2368: allow widget output to stream in GUI mode

There are numerous places where @ClassCastException@ is thrown when in GUI redirected mode and an @ALERT-BOX@ or an e... Hynek Cihlar

04:22 AM User Interface Bug #3373 (Review): incremental scroll in non-full Browse page

Stanislav Lomany

03:36 AM Base Language Bug #3406: implement silent error mode as a lambda to allow aborting the control flow

Created task branch 3406b from trunk rev 11213. Stanislav Lomany

12/22/2017

06:35 PM Base Language Feature #3262: implement COM/OLE Automation support

The revision @11308@ gives the same converted code for @COM@ sample testcases I have used in @COM@ native implementat... Eugenie Lyzenko

05:22 PM Base Language Feature #3262: implement COM/OLE Automation support

There is an issue with how we convert LOAD-CONTROLS. We've decide to treat every COM access as a generic call (witho... Constantin Asofiei

11:34 AM User Interface Feature #3394: generic drawing improvements: repaint and other misc code

I've tested 3394a revision 11307 with Hotel GUI. It fixes the abend (Check-In then Add) and it fixes the tree contro... Greg Shah

08:33 AM User Interface Feature #3394: generic drawing improvements: repaint and other misc code

Rebased 3394a from trunk rev 11213 - new revision 11304.
3394a rev 11305 contains javadoc and history header fixes. Constantin Asofiei

10:08 AM User Interface Bug #3425: text is drawn 1-pixel to the left, cutting the text

> So, rollback these two revisions in 3394a and commit them.
Done. Stanislav Lomany

09:23 AM User Interface Bug #3425: text is drawn 1-pixel to the left, cutting the text

Stanislav Lomany wrote:
> > Stanislav: Please take this task. Please remove the changes for 11296/11297 such that i... Constantin Asofiei

09:23 AM User Interface Bug #3425: text is drawn 1-pixel to the left, cutting the text

> Do you want me to revert 11296/11297 and then you merge 3394 and I check into another branch
This one. The fix ... Greg Shah

09:21 AM User Interface Bug #3425: text is drawn 1-pixel to the left, cutting the text

> Stanislav: Please take this task. Please remove the changes for 11296/11297 such that it won't cause regressions. ... Stanislav Lomany

09:13 AM User Interface Bug #3425: text is drawn 1-pixel to the left, cutting the text

Greg Shah wrote:
> Stanislav: Please take this task. Please remove the changes for 11296/11297 such that it won't c... Constantin Asofiei

09:09 AM User Interface Bug #3425: text is drawn 1-pixel to the left, cutting the text

Stanislav: Please take this task. Please remove the changes for 11296/11297 such that it won't cause regressions. I... Greg Shah

09:07 AM User Interface Bug #3425: text is drawn 1-pixel to the left, cutting the text

Is this code from @BrowseGuiImpl.doLayout()@ correct?... Sergey Ivanovskiy

08:49 AM User Interface Bug #3425: text is drawn 1-pixel to the left, cutting the text

Stanislav Lomany wrote:
> > Stanislav, please describe font settings thoroughly, what are fonts without anti-aliasin... Sergey Ivanovskiy

08:22 AM User Interface Bug #3425: text is drawn 1-pixel to the left, cutting the text

> Stanislav, please describe font settings thoroughly, what are fonts without anti-aliasing?
I don't know, but th... Stanislav Lomany

08:12 AM User Interface Bug #3425: text is drawn 1-pixel to the left, cutting the text

The rev.11297, 11301 don't make changes for column widths. It is supposed that they are calculated correctly. Sergey Ivanovskiy

08:03 AM User Interface Bug #3425: text is drawn 1-pixel to the left, cutting the text

Did you build a font-metrics file for the strings from your test? Sergey Ivanovskiy

08:01 AM User Interface Bug #3425: text is drawn 1-pixel to the left, cutting the text

Stanislav Lomany wrote:
> It is not clear if actual P2J version (rev 11295) has issues with clipping (please use fon... Sergey Ivanovskiy

07:43 AM User Interface Bug #3425: text is drawn 1-pixel to the left, cutting the text

It is not clear if actual P2J version (rev 11295) has issues with clipping (please use fonts without anti-aliasing fo... Stanislav Lomany

07:10 AM User Interface Bug #3425: text is drawn 1-pixel to the left, cutting the text

I'm not good, wait a bit. Stanislav Lomany

07:09 AM User Interface Bug #3425: text is drawn 1-pixel to the left, cutting the text

If Stanislav is OK with these changes, then we are good to go. Greg Shah

04:52 AM User Interface Bug #3425: text is drawn 1-pixel to the left, cutting the text

Yes. Agree, committed rev 11301. Sergey Ivanovskiy

09:12 AM Base Language Bug #3406: implement silent error mode as a lambda to allow aborting the control flow

Greg Shah wrote:
> > in ControlFlowOps - is the H061 still needed?
>
> No, not after trunk rev 11213.
Backed ou... Constantin Asofiei

09:05 AM Base Language Bug #3406: implement silent error mode as a lambda to allow aborting the control flow

> in ControlFlowOps - is the H061 still needed?
No, not after trunk rev 11213. Greg Shah

08:31 AM Base Language Bug #3406: implement silent error mode as a lambda to allow aborting the control flow

Greg, in @ControlFlowOps@ - is the H061 still needed?... Constantin Asofiei

12:54 AM Base Language Bug #3406: implement silent error mode as a lambda to allow aborting the control flow

3406a/11232 has passed ETF search, dev, and batch testing, main regression testing, and ctrl+c testing. The branch wa... Eric Faulhaber

08:25 PM Base Language Bug #3406: implement silent error mode as a lambda to allow aborting the control flow

Follow-up: I tested with trunk; same error.
However, it's fixed in 3394a (tested with 11299), so... never mind. Eric Faulhaber

08:01 PM Base Language Bug #3406: implement silent error mode as a lambda to allow aborting the control flow

Is this a known Hotel GUI issue? I hit this while trying to check in a guest on the "Available" screen first thing af... Eric Faulhaber

08:24 PM User Interface Bug #3381: Sub-menu drawing issues

Hynek Cihlar wrote:
> With the latest 3394a the multiple selection issue is fixed and the Esc key works properly. Ho... Eugenie Lyzenko

12/21/2017

05:56 PM User Interface Bug #3425: text is drawn 1-pixel to the left, cutting the text

Greg Shah wrote:
> Stanislav/Hynek: please review.
Formally, I don't see anything wrong with the code. Maybe I wo... Hynek Cihlar

03:44 PM User Interface Bug #3425: text is drawn 1-pixel to the left, cutting the text

Code Review Task Branch 3394a Revisions 11296/7
I don't see a specific issue with the changes. However, the valid... Greg Shah

03:12 PM User Interface Bug #3425: text is drawn 1-pixel to the left, cutting the text

Please review committed revision 11297. Sergey Ivanovskiy

02:40 PM User Interface Bug #3425: text is drawn 1-pixel to the left, cutting the text

Please review committed revision 11296 that should fix drawing of labels with help of #3394-88. Sergey Ivanovskiy

05:21 PM Base Language Bug #3406: implement silent error mode as a lambda to allow aborting the control flow

I have manually tested Hotel GUI (Swing, Virtual Desktop and Embedded Modes) in both 3406a (11232) and trunk (11212).... Greg Shah

11:25 AM Base Language Bug #3406: implement silent error mode as a lambda to allow aborting the control flow

Task branch 3406a has been rebased to p2j trunk revision 11212. Eric Faulhaber

01:25 AM Base Language Bug #3406: implement silent error mode as a lambda to allow aborting the control flow

3406a/11226 has passed dev, search, and batch ETF testing. Two runs of main runtime regression testing show a handful... Eric Faulhaber

05:09 PM User Interface Bug #3381: Sub-menu drawing issues

Hynek Cihlar wrote:
> I'll try to rephrase what the problem is. When you open a submenu body, none of the menu items... Eugenie Lyzenko

04:47 PM User Interface Bug #3381: Sub-menu drawing issues

Eugenie Lyzenko wrote:
> Hynek Cihlar wrote:
> >
> > Yes, this is it. You can see it in the gif close to the end ... Hynek Cihlar

04:42 PM User Interface Bug #3381: Sub-menu drawing issues

Hynek Cihlar wrote:
>
> Yes, this is it. You can see it in the gif close to the end of the playback.
But in @FW... Eugenie Lyzenko

04:35 PM User Interface Bug #3381: Sub-menu drawing issues

Eugenie Lyzenko wrote:
> Hynek Cihlar wrote:
> > 4. Menu item is highlighted when its submenu is opened, it should ... Hynek Cihlar

04:32 PM User Interface Bug #3381: Sub-menu drawing issues

Hynek Cihlar wrote:
> 4. Menu item is highlighted when its submenu is opened, it should not be.
I do not understa... Eugenie Lyzenko

04:22 PM User Interface Bug #3381: Sub-menu drawing issues

Eugenie Lyzenko wrote:
> > 2. There is a noticable lag when navigating from one root submenu to another, in native 4... Hynek Cihlar

04:20 PM User Interface Bug #3381: Sub-menu drawing issues

Hynek Cihlar wrote:
> With the latest 3394a the multiple selection issue is fixed and the Esc key works properly. Ho... Eugenie Lyzenko

04:13 PM User Interface Bug #3381: Sub-menu drawing issues

With the latest 3394a the multiple selection issue is fixed and the Esc key works properly. However there are some ne... Hynek Cihlar

01:03 PM User Interface Bug #3381: Sub-menu drawing issues

Task branch @3394a@ has been updated for review to revision @11295@.
This is new approach to control menu item sel... Eugenie Lyzenko

06:56 AM User Interface Bug #3381: Sub-menu drawing issues

Code Review Task Branch 3394a Revision 11293
I'm OK with the changes.
> I think in 4GL the ESC handling is not... Greg Shah

10:18 PM User Interface Bug #3381: Sub-menu drawing issues

Task branch @3394a@ has been updated for review to revision @11293@.
This is suggested fix for @ESC@ key processin... Eugenie Lyzenko

02:20 PM User Interface Feature #3369: add support for BGCOLOR-RGB and FGCOLOR-RGB, FWD extension widget attributes

Code Review Task Branch 3369b Revision 11211
It is not clear why we need both @Coordinate.guiRound()@ and @Coordin... Greg Shah

12:59 PM User Interface Feature #3369: add support for BGCOLOR-RGB and FGCOLOR-RGB, FWD extension widget attributes

3369b replaces all UI coordinate roundings implemented by @BigDecimal@ with more primitive constructs, like @java.mat... Hynek Cihlar

07:22 AM User Interface Feature #3394: generic drawing improvements: repaint and other misc code

3394a revision 11294 fixes browse column widths due to incorrectly resolved column font. Hynek Cihlar

06:03 AM Base Language Feature #3262: implement COM/OLE Automation support

Branch @3262b@ was merged to trunk as revno @11212@ then it was archived. Eugenie Lyzenko

05:57 AM Base Language Feature #3262: implement COM/OLE Automation support

Greg Shah wrote:
> Please merge 3262b to trunk.
OK. Starting. Eugenie Lyzenko

04:56 AM Base Language Feature #3262: implement COM/OLE Automation support

Please merge 3262b to trunk. Greg Shah

09:39 PM Base Language Feature #3262: implement COM/OLE Automation support

Testing completed. No regressions have been found. The results: @3262b_11251_a5eeab0_20171220_evl.zip@.
So the bra... Eugenie Lyzenko

08:07 PM Base Language Feature #3262: implement COM/OLE Automation support

The main cycle completed. No regression. Running @CTRL-C@ part.
Can I merge into trunk if no regressions for @CTRL... Eugenie Lyzenko

12/20/2017

05:54 PM Base Language Bug #3406: implement silent error mode as a lambda to allow aborting the control flow

It's not the case. Stanislav Lomany

05:53 PM Base Language Bug #3406: implement silent error mode as a lambda to allow aborting the control flow

OK, then please hold off on updating this branch, unless you believe these changes are necessary to making the new er... Eric Faulhaber

05:39 PM Base Language Bug #3406: implement silent error mode as a lambda to allow aborting the control flow

> OK, please put it in and I'll restart testing.
That may require some time because is not yet ready. Stanislav Lomany

05:16 PM Base Language Bug #3406: implement silent error mode as a lambda to allow aborting the control flow

OK, please put it in and I'll restart testing. Eric Faulhaber

05:09 PM Base Language Bug #3406: implement silent error mode as a lambda to allow aborting the control flow

No, its not risky, just minor fix which IIRC doesn't affect regression testing. Stanislav Lomany

05:03 PM Base Language Bug #3406: implement silent error mode as a lambda to allow aborting the control flow

Stanislav Lomany wrote:
> I wanted to fix TODOs and error in processing in one place, but can do that in another bra... Eric Faulhaber

04:54 PM Base Language Bug #3406: implement silent error mode as a lambda to allow aborting the control flow

I wanted to fix TODOs and error in processing in one place, but can do that in another branch. Stanislav Lomany

04:35 PM Base Language Bug #3406: implement silent error mode as a lambda to allow aborting the control flow

So, are we expecting any more code changes at this point, or is revision 11226 what we're testing? Actually, I alread... Eric Faulhaber

04:27 PM Base Language Bug #3406: implement silent error mode as a lambda to allow aborting the control flow

The TODOs in 3406a rev 11226:
# @SharedVariableManager.errorHelper@ - this is used when there is a problem resolving... Constantin Asofiei

03:21 PM Base Language Bug #3406: implement silent error mode as a lambda to allow aborting the control flow

> @ErrorManager.recordOrShowError@ or @ErrorManager.recordOrThrowError@?
@ErrorManager.recordOrShowError@ Stanislav Lomany

03:01 PM Base Language Bug #3406: implement silent error mode as a lambda to allow aborting the control flow

Greg Shah wrote:
> I've also added TODO and ECF_TODO comments in other locations that need review.
>
> Eric: Plea... Eric Faulhaber

02:56 PM Base Language Bug #3406: implement silent error mode as a lambda to allow aborting the control flow

Stanislav Lomany wrote:
> > Stanislav: Please look at @Browse@ and @BrowseWidget@ for the TODOs I've added.
>
> T... Greg Shah

02:52 PM Base Language Bug #3406: implement silent error mode as a lambda to allow aborting the control flow

Our original approach to silent error mode was to bracket each NO-ERROR statement (or assignment or standalone expres... Greg Shah

02:33 PM Base Language Bug #3406: implement silent error mode as a lambda to allow aborting the control flow

> Stanislav: Please look at @Browse@ and @BrowseWidget@ for the TODOs I've added.
These exceptions serve the purpo... Stanislav Lomany

12:30 PM Base Language Bug #3406: implement silent error mode as a lambda to allow aborting the control flow

Per our offline discussion, revision 11225 enables the re-throw of the error condition inside the silent worker's cat... Greg Shah

04:11 AM Base Language Bug #3406: implement silent error mode as a lambda to allow aborting the control flow

Revision 3406a/11224 almost resolves the deferred validation issue, except instead of the pause and "Press space bar ... Eric Faulhaber

03:28 AM Base Language Bug #3406: implement silent error mode as a lambda to allow aborting the control flow

The issue for at least two of the tests (a concurrent pair) is that the harness is expecting a validation failure (un... Eric Faulhaber

11:29 PM Base Language Bug #3406: implement silent error mode as a lambda to allow aborting the control flow

3406a/11223 passed ETF developer testing, but failed regular regression testing twice with 4 of the same tests failin... Eric Faulhaber

04:44 PM Base Language Feature #3262: implement COM/OLE Automation support

Conversion testing has been passed, code trees are identical. Continue with runtime testing. Eugenie Lyzenko

11:19 AM Base Language Feature #3262: implement COM/OLE Automation support

Task branch @3262b@ has been rebased with recent trunk @11211@, new version is @11251@. Eugenie Lyzenko

10:53 AM Base Language Feature #3262: implement COM/OLE Automation support

Greg Shah wrote:
> > There is an issues with getting the file resources (Excel files templates) from application *.j... Eugenie Lyzenko

10:41 AM Base Language Feature #3262: implement COM/OLE Automation support

Greg Shah wrote:
> > The rules were changed, so conversion test is required I guess. Also safe harness run is desira... Eugenie Lyzenko

10:39 AM Base Language Feature #3262: implement COM/OLE Automation support

> The rules were changed, so conversion test is required I guess. Also safe harness run is desirable to make sure we ... Greg Shah

10:33 AM Base Language Feature #3262: implement COM/OLE Automation support

Greg Shah wrote:
> > I think we can test and merge 3262b into trunk and defer other work to 3262c.
>
> What testi... Eugenie Lyzenko

10:26 AM Base Language Feature #3262: implement COM/OLE Automation support

> There is an issues with getting the file resources (Excel files templates) from application *.jar files.
Are the... Greg Shah

10:09 AM Base Language Feature #3262: implement COM/OLE Automation support

Greg Shah wrote:
>How safe is the 3262b branch at this point? Is it suitable for merge to trunk or is there known wo... Eugenie Lyzenko

09:45 AM Base Language Feature #3262: implement COM/OLE Automation support

How safe is the 3262b branch at this point? Is it suitable for merge to trunk or is there known work needed?
I kn... Greg Shah

01:53 PM User Interface Bug #3381: Sub-menu drawing issues

Eugenie Lyzenko wrote:
> Fixes for issue except @ESC@ key press reaction, for which I still do not have the @4GL@ te... Hynek Cihlar

12:41 PM User Interface Bug #3381: Sub-menu drawing issues

Task branch @3394a@ has been updated for review to revision @11291@.
Fixes for issue except @ESC@ key press reacti... Eugenie Lyzenko

11:32 AM User Interface Bug #3381: Sub-menu drawing issues

Hynek Cihlar wrote:
>
> Another point is the way the menu bar should handle Esc key. On the first Esc press the su... Eugenie Lyzenko

03:38 AM User Interface Bug #3381: Sub-menu drawing issues

Hynek Cihlar wrote:
> With the revision there are still some issues with the main bar. Please see the attached gif.
... Hynek Cihlar

03:10 AM User Interface Bug #3381: Sub-menu drawing issues

Eugenie Lyzenko wrote:
> Task branch @3394a@ has been updated for review to revision @11288@.
>
> This is the fix... Hynek Cihlar

12:50 AM User Interface Bug #3381: Sub-menu drawing issues

Task branch @3394a@ has been updated for review to revision @11288@.
This is the fix for classic theme menu painti... Eugenie Lyzenko

09:28 PM User Interface Bug #3381: Sub-menu drawing issues

There are some @UI@ painting deviations for classic theme implementation. Consider the following native Windows pictu... Eugenie Lyzenko

08:38 PM User Interface Bug #3381: Sub-menu drawing issues

Task branch @3394a@ has been updated for review to revision @11286@.
The minor changes to resolve menu related iss... Eugenie Lyzenko

04:00 AM User Interface Bug #3425: text is drawn 1-pixel to the left, cutting the text

Thank you, if we don't shift the text by 1 pixel to the left, then some table headers don't fit the column and some r... Sergey Ivanovskiy

03:50 AM User Interface Bug #3425: text is drawn 1-pixel to the left, cutting the text

The @text-metrics.xml@ for AW was last updated by Constantin on Tue 2017-11-28 22:20:15 +0200 as revno 110.
I don't... Ovidiu Maxiniuc

03:24 AM User Interface Bug #3425: text is drawn 1-pixel to the left, cutting the text

Ovidiu Maxiniuc wrote:
> It is possible that the font configuration to had been different. If it is wrong, please dr... Sergey Ivanovskiy

12/19/2017

02:47 PM User Interface Feature #3394: generic drawing improvements: repaint and other misc code

Sergey Ivanovskiy wrote:
> OK, please review the committed revision 11282.
The changes look good. Hynek Cihlar

02:16 PM User Interface Feature #3394: generic drawing improvements: repaint and other misc code

OK, please review the committed revision 11282. Sergey Ivanovskiy

11:10 AM User Interface Feature #3394: generic drawing improvements: repaint and other misc code

Greg Shah wrote:
> Sergey Ivanovskiy wrote:
> > Please review committed revision 11275 - tried to fix activations o... Hynek Cihlar

08:26 AM User Interface Feature #3394: generic drawing improvements: repaint and other misc code

Sergey Ivanovskiy wrote:
> Please review committed revision 11275 - tried to fix activations of task icons in the vi... Greg Shah

01:19 PM User Interface Bug #3425: text is drawn 1-pixel to the left, cutting the text

I cannot remember why I added that special processing. Most likely I adjusted that based on offset revealed when comp... Ovidiu Maxiniuc

01:13 PM User Interface Bug #3425: text is drawn 1-pixel to the left, cutting the text

> It seems that table labels are displayed 1-pixel left due to this code ClassicTheme.this.drawBrowseCellText
This... Stanislav Lomany

12:21 PM User Interface Bug #3425: text is drawn 1-pixel to the left, cutting the text

OK. It seems that table labels are displayed 1-pixel left due to this code @ClassicTheme.this.drawBrowseCellText@
<p... Sergey Ivanovskiy

11:15 AM User Interface Bug #3425: text is drawn 1-pixel to the left, cutting the text

> Should I work on these browser issues?
Yes, but make sure you get input from Stanislav so that you don't cause r... Greg Shah

11:06 AM User Interface Bug #3425: text is drawn 1-pixel to the left, cutting the text

Committed revision 11280(3394a) should fix the web text position along a horizontal. It seems that the other text pos... Sergey Ivanovskiy

09:40 AM User Interface Bug #3425: text is drawn 1-pixel to the left, cutting the text

I didn't implement this function. Please explain the reasons that in the code below the text @x@-position coordinate ... Sergey Ivanovskiy

09:27 AM User Interface Bug #3425: text is drawn 1-pixel to the left, cutting the text

The web client displays text in tables incorrectly too.
!TextInBrowser.png! Sergey Ivanovskiy

09:25 AM User Interface Bug #3425: text is drawn 1-pixel to the left, cutting the text

It seems that header's and cell's content in tables incorrectly positioned. It can be observed for the web and swing ... Sergey Ivanovskiy

06:56 AM User Interface Bug #3425 (Closed): text is drawn 1-pixel to the left, cutting the text

Sergey Ivanovskiy

07:47 AM User Interface Bug #3381: Sub-menu drawing issues

Task branch @3394a@ has been updated for review to revision @11279@.
This change contains the fix for @ClassicThem... Eugenie Lyzenko

12/18/2017

06:29 PM User Interface Feature #3394: generic drawing improvements: repaint and other misc code

Sergey Ivanovskiy wrote:
> Constantin Asofiei wrote:
> >.. I ask because I have some more generic fixes related to ... Constantin Asofiei

12:28 PM User Interface Feature #3394: generic drawing improvements: repaint and other misc code

Please review committed revision 11275 - tried to fix activations of task icons in the virtual desktop. Sergey Ivanovskiy

03:11 PM User Interface Bug #3381: Sub-menu drawing issues

Code Review Task Branch 3394a Revisions 11276/11277
I like the approach. Greg Shah

12:58 PM User Interface Bug #3381: Sub-menu drawing issues

Task branch @3394a@ has been updated for review to revision @11276@, @11277@.
Added the ability to configure menu ... Eugenie Lyzenko

03:25 AM User Interface Bug #3381: Sub-menu drawing issues

Eugenie Lyzenko wrote:
> Hynek Cihlar wrote:
> > > Can someone clarify what this code was added for? What is the ca... Hynek Cihlar

03:17 AM User Interface Bug #3381: Sub-menu drawing issues

Eugenie Lyzenko wrote:
> Yes, but because in trunk there is no functionality to hide submenu once mouse is left the ... Hynek Cihlar

12/17/2017

05:50 PM User Interface Bug #3381: Sub-menu drawing issues

Greg Shah wrote:
> > Guys, the delay improves usability in cases when you navigate the menu by mouse. Without the de... Eugenie Lyzenko

12:43 PM User Interface Bug #3381: Sub-menu drawing issues

Hynek Cihlar wrote:
> > Can someone clarify what this code was added for? What is the case the code become working. ... Eugenie Lyzenko

11:18 AM User Interface Bug #3381: Sub-menu drawing issues

Hynek Cihlar wrote:
> Eugenie Lyzenko wrote:
> > Greg Shah wrote:
> > > Code Review Task Branch 3394a Revision 112... Greg Shah

09:14 AM User Interface Bug #3381: Sub-menu drawing issues

Hynek Cihlar wrote:
> Eugenie Lyzenko wrote:
> > Hynek Cihlar wrote:
> > I think the root cause here is the 1-pixe... Eugenie Lyzenko

05:53 AM User Interface Bug #3381: Sub-menu drawing issues

Eugenie Lyzenko wrote:
> Task branch @3394a@ has been updated for review to revision @11272@.
>
> This is the fix... Hynek Cihlar

05:00 AM User Interface Bug #3381: Sub-menu drawing issues

Eugenie Lyzenko wrote:
> Hynek Cihlar wrote:
> > Eugenie, I think there is another regression in the menu bar. The ... Hynek Cihlar

04:57 AM User Interface Bug #3381: Sub-menu drawing issues

Eugenie Lyzenko wrote:
> Greg Shah wrote:
> > Code Review Task Branch 3394a Revision 11267
> > ...
> > 1. Does th... Hynek Cihlar

05:13 PM Base Language Bug #3406: implement silent error mode as a lambda to allow aborting the control flow

Unfortunately, the ChUI app regression testing fails with the same core regressions that have been happening earlier ... Greg Shah

10:38 AM Base Language Bug #3406: implement silent error mode as a lambda to allow aborting the control flow

ETF batch tests passed. If it passes regular regression testing, I think this revision can be merged to trunk. Eric Faulhaber

02:16 AM Base Language Bug #3406: implement silent error mode as a lambda to allow aborting the control flow

Greg, 3406a/11222 has passed ETF search and dev tests (2 clean runs of the latter). I am testing batch next, but plea... Eric Faulhaber

04:52 AM User Interface Feature #3394: generic drawing improvements: repaint and other misc code

Sergey Ivanovskiy wrote:
> I guess that @config.showInTaskbar@ is always true for the regular desktop window and fal... Hynek Cihlar