Project

General

Profile

Activity

From 04/03/2018 to 05/02/2018

05/02/2018

03:40 PM User Interface Feature #3281: implement some frame options
Sergey Ivanovskiy wrote:
> Constantin Asofiei wrote:
> > Anyone has any idea why this code was added to FillInGuiIm...
Sergey Ivanovskiy
02:49 PM User Interface Feature #3281: implement some frame options
Constantin Asofiei wrote:
> Anyone has any idea why this code was added to FillInGuiImpl and EditorGuiImpl.mouseClic...
Sergey Ivanovskiy
02:23 PM User Interface Feature #3281: implement some frame options
Anyone has any idea why this code was added to FillInGuiImpl and EditorGuiImpl.mouseClicked?... Constantin Asofiei

05/01/2018

05:46 PM User Interface Bug #3559: trigger matching for multi-label events (i.e. RETURN/ENTER/CTRM-M, PAGE-UP/PGUP/PREV-P...
4GL has a weird way of matching an event to a trigger, if that event has multiple labels associated with it. For exa... Constantin Asofiei
05:36 PM User Interface Bug #3559 (New): trigger matching for multi-label events (i.e. RETURN/ENTER/CTRM-M, PAGE-UP/PGUP/...
Constantin Asofiei

04/27/2018

09:49 AM Bugs Bug #3503 (Closed): generated classname mismatch for menu and sub-menu
Branch 3469a was merged to trunk as revision 11252. Greg Shah
05:26 AM Base Language Feature #3558: SEARCH("<program_name>.r") should return a value when there is a converted 4GL pro...
Many applications implement code that checks for the existence of specific @.r@ files ("compiled" r-code for specific... Greg Shah
05:17 AM Base Language Feature #3558 (New): SEARCH("<program_name>.r") should return a value when there is a converted 4...
Greg Shah

04/26/2018

04:11 PM User Interface Feature #3469: final improvements and polish for the embedded mode web client
3469a was merged to trunk rev 11252 and archived. Constantin Asofiei

04/25/2018

06:34 AM User Interface Bug #3487: Sub-menu graphical issues
3487b dead-archived. Hynek Cihlar
06:30 AM User Interface Bug #3487: Sub-menu graphical issues
Merged the only change in 3487b to 3553a.
Correction, merged the change in 3487b to 3538a.
Hynek Cihlar
05:23 AM User Interface Bug #3487: Sub-menu graphical issues
Greg Shah wrote:
> Are you proposing to merge this to trunk now? Or do you plan to include the changes for #3538?
...
Hynek Cihlar
05:19 AM User Interface Bug #3487: Sub-menu graphical issues
Code Review Task Branch 3487b Revision 11252
I'm fine with the change.
Are you proposing to merge this to trunk...
Greg Shah
04:23 AM User Interface Bug #3487: Sub-menu graphical issues
The ChUI menu regressions are more serious than I thought. I created new issue #3553 and checked in my WIP changes th... Hynek Cihlar
06:33 AM User Interface Bug #3538: The next focus widget for menu widget is not defined
Created task branch 3538a and merged in changes from 3487b. Hynek Cihlar
04:28 AM User Interface Bug #3553: ChUI menus don't work
There are already multiple open issues for ChUI menus, some seem to have some overlap with this one. https://proj.gol... Hynek Cihlar
04:20 AM User Interface Bug #3553: ChUI menus don't work
Created task branch 3553a and checked in some early and incomplete changes. This only fixes the related event handlin... Hynek Cihlar
04:00 AM User Interface Bug #3553: ChUI menus don't work
Window-attached menu (MENU-BAR) can't be entered and "opened" with the standard menu-enter keys (F3) or mnemonics. An... Hynek Cihlar
03:55 AM User Interface Bug #3553 (New): ChUI menus don't work
Hynek Cihlar

04/24/2018

06:56 AM User Interface Bug #3532 (Closed): Failed to instantiate menu definition class
Greg Shah
03:10 AM User Interface Bug #3532: Failed to instantiate menu definition class
The issue was resolved in 3487a, the branch was merged to trunk in revision 11259. Hynek Cihlar
06:56 AM User Interface Bug #3508 (Closed): 1st level popup menu won't close when menu item selected
Greg Shah
03:09 AM User Interface Bug #3508: 1st level popup menu won't close when menu item selected
The issue was resolved in 3487a, the branch was merged to trunk in revision 11259. Hynek Cihlar
03:07 AM User Interface Bug #3487: Sub-menu graphical issues
3487a rebased and merged to trunk as revision 11251. The branch was archived. Hynek Cihlar
02:36 AM User Interface Bug #3487: Sub-menu graphical issues
3487a passed ChUI test harness. I am merging to trunk. Hynek Cihlar

04/23/2018

12:48 PM User Interface Bug #3487: Sub-menu graphical issues
When it passes testing, merge to trunk. Greg Shah
11:44 AM User Interface Bug #3487: Sub-menu graphical issues
Greg Shah wrote:
> The existing revision of 3487a is a significant improvement over trunk, right?
Yes, it fixes...
Hynek Cihlar
11:44 AM User Interface Bug #3487: Sub-menu graphical issues
ChUI regression test harness finished with some failures which are most likely negative failures. I restarted the tests. Hynek Cihlar
09:57 AM User Interface Bug #3487: Sub-menu graphical issues
Code Review Task branch 3487a Revision 11258
I'm good with the changes.
Greg Shah
07:29 AM User Interface Bug #3487: Sub-menu graphical issues
The existing revision of 3487a is a significant improvement over trunk, right? Unless there are regressions, I would... Greg Shah
07:04 AM User Interface Bug #3487: Sub-menu graphical issues
While regression testing 3487a I see client abends which prevent me to run all the required cases. These errors alrea... Hynek Cihlar

04/22/2018

06:19 PM User Interface Bug #3487: Sub-menu graphical issues
3487a revision 11258 resolves the points from the last review. It passed GUI regression tests (a large customer's GUI... Hynek Cihlar

04/20/2018

12:49 PM User Interface Bug #3487: Sub-menu graphical issues
Code Review Task Branch 3487a Revision 11256
These changes are really good. I see no functional issues.
One mi...
Greg Shah
08:56 AM User Interface Bug #3487: Sub-menu graphical issues
3487a revision 11256 fixes this issue plus #3462, #3508, #3532.
Regression testing is in progress. Please review.
Hynek Cihlar
08:53 AM User Interface Bug #3487: Sub-menu graphical issues
3487a rebased against trunk 11249. Hynek Cihlar
11:41 AM Database Feature #3549: implement RAW-TRANSFER statement
As of branch 3507a revision 11264, the RAW-TRANSFER language statement (and the BUFFER method) has a complete "basic"... Greg Shah

04/19/2018

05:05 AM User Interface Bug #3487: Sub-menu graphical issues
3487a rebased against trunk 11248. Hynek Cihlar

04/18/2018

02:53 PM User Interface Bug #3487: Sub-menu graphical issues
Checked in revision 11247 to 3487a.
This resolves all the issues mentioned in this issue plus:
* popup menu not s...
Hynek Cihlar
10:32 AM User Interface Bug #3550: Window restore from maximized state GUI mode issue
Greg Shah wrote:
> Eugenie confirmed this is not an issue in Swing.
To be clear. The Swing portion of the issue i...
Eugenie Lyzenko
10:28 AM User Interface Bug #3550: Window restore from maximized state GUI mode issue
Eugenie confirmed this is not an issue in Swing. Greg Shah
09:41 AM User Interface Bug #3550: Window restore from maximized state GUI mode issue
This can be recreated in trunk revision 11248 (and before). It is not related to the changes from #3548, but was jus... Greg Shah
09:39 AM User Interface Bug #3550: Window restore from maximized state GUI mode issue
Found issue in trunk for hotel GUI. When window is restoring from maximized state by restore title bar button the win... Eugenie Lyzenko
09:33 AM User Interface Bug #3550 (New): Window restore from maximized state GUI mode issue
Eugenie Lyzenko
10:29 AM User Interface Bug #3548 (Closed): Window widget FULL-(WIDTH|HEIGHT)-(CHARS|PIXELS) proper initialization
Greg Shah
10:22 AM User Interface Bug #3548: Window widget FULL-(WIDTH|HEIGHT)-(CHARS|PIXELS) proper initialization
Greg Shah wrote:
> Did you test Hotel GUI in both Swing and Web?
Yes. The Swing difference is in new issue that f...
Eugenie Lyzenko
09:56 AM User Interface Bug #3548: Window widget FULL-(WIDTH|HEIGHT)-(CHARS|PIXELS) proper initialization
Did you test Hotel GUI in both Swing and Web? Greg Shah
09:32 AM User Interface Bug #3548: Window widget FULL-(WIDTH|HEIGHT)-(CHARS|PIXELS) proper initialization
Branch @3548a@ was merged to trunk as revno @11248@ then it was archived. Eugenie Lyzenko
08:25 AM User Interface Bug #3548: Window widget FULL-(WIDTH|HEIGHT)-(CHARS|PIXELS) proper initialization
Please merge 3548a to trunk.
> But found issue in trunk for hotel GUI. When window is restoring from maximized sta...
Greg Shah
08:01 AM User Interface Bug #3548: Window widget FULL-(WIDTH|HEIGHT)-(CHARS|PIXELS) proper initialization
Not found the regressions in hotel @GUI@.
But found issue in trunk for hotel GUI. When window is restoring from ma...
Eugenie Lyzenko
07:35 AM User Interface Bug #3548: Window widget FULL-(WIDTH|HEIGHT)-(CHARS|PIXELS) proper initialization
Greg Shah wrote:
> Have you already tested Hotel GUI?
In progress now. Need to check one option comparing with tr...
Eugenie Lyzenko
07:26 AM User Interface Bug #3548: Window widget FULL-(WIDTH|HEIGHT)-(CHARS|PIXELS) proper initialization
Have you already tested Hotel GUI? Greg Shah
07:25 AM User Interface Bug #3548: Window widget FULL-(WIDTH|HEIGHT)-(CHARS|PIXELS) proper initialization
Greg Shah wrote:
> What GUI testing is needed to confirm this is safe for trunk? Is it enough to test the AW and Ho...
Eugenie Lyzenko
07:09 AM User Interface Bug #3548: Window widget FULL-(WIDTH|HEIGHT)-(CHARS|PIXELS) proper initialization
What GUI testing is needed to confirm this is safe for trunk? Is it enough to test the AW and Hotel usage cases? Greg Shah
02:40 AM User Interface Bug #3548: Window widget FULL-(WIDTH|HEIGHT)-(CHARS|PIXELS) proper initialization
Code review 3548a revision 11253.
The changes are OK. I don't register any more open points for the branch.
Hynek Cihlar
07:18 AM Base Language Feature #3342: implement a facility to easily run a JasperReports report definition from 4GL code...
> Not sure why a user may want to control row height in other cases.
One reason may be to implement some find of f...
Greg Shah
10:20 PM Base Language Feature #3342: implement a facility to easily run a JasperReports report definition from 4GL code...
This is the testcase for xls output. @.jrxml@ files (or @.jasper@ files, which are compiled @.jrxml@ s) are loaded fr... Stanislav Lomany
09:12 PM Base Language Feature #3342: implement a facility to easily run a JasperReports report definition from 4GL code...
> control over row height (different rows can have different heights)
You can control height of all rows at once. An...
Stanislav Lomany

04/17/2018

05:36 PM User Interface Bug #3548: Window widget FULL-(WIDTH|HEIGHT)-(CHARS|PIXELS) proper initialization
Hynek Cihlar wrote:
>
> The test case is as follows. Show a window, hide it, assign menu-bar, read the @FULL-@ att...
Eugenie Lyzenko
05:19 PM User Interface Bug #3548: Window widget FULL-(WIDTH|HEIGHT)-(CHARS|PIXELS) proper initialization
Eugenie Lyzenko wrote:
> >Consider the case when the window layout is changed (for example menu-bar assigned) while ...
Hynek Cihlar
05:13 PM User Interface Bug #3548: Window widget FULL-(WIDTH|HEIGHT)-(CHARS|PIXELS) proper initialization
Hynek Cihlar wrote:
> Code review 3548a revision 11252.
>
> The code changes are OK except the @!config().dynamic...
Eugenie Lyzenko
04:56 PM User Interface Bug #3548: Window widget FULL-(WIDTH|HEIGHT)-(CHARS|PIXELS) proper initialization
Eugenie Lyzenko wrote:
> Hynek Cihlar wrote:
> > Code review 3548a revision 11251.
> >
> > The changes are good....
Hynek Cihlar
07:10 AM User Interface Bug #3548: Window widget FULL-(WIDTH|HEIGHT)-(CHARS|PIXELS) proper initialization
Hynek Cihlar wrote:
> Code review 3548a revision 11251.
>
> The changes are good. But note that the value of the ...
Eugenie Lyzenko
04:48 AM User Interface Bug #3548: Window widget FULL-(WIDTH|HEIGHT)-(CHARS|PIXELS) proper initialization
Code review 3548a revision 11251.
The changes are good. But note that the value of the @FULL-*@ attribute changes ...
Hynek Cihlar
11:03 AM User Interface Feature #3469: final improvements and polish for the embedded mode web client
See #3498-21 for a list of some ADM2 reference materials. Greg Shah
04:41 AM User Interface Feature #3469: final improvements and polish for the embedded mode web client
Eric, if you want to be sure, convert with this patch applied to trunk, then with the patch applied to your branch an... Constantin Asofiei
02:19 AM User Interface Feature #3469: final improvements and polish for the embedded mode web client
Eric Faulhaber wrote:
> Constantin, there is a TRPL function @generate_code_for_page_getPageHandles@ in @rules/adm/a...
Constantin Asofiei
01:00 AM User Interface Feature #3469: final improvements and polish for the embedded mode web client
Constantin, there is a TRPL function @generate_code_for_page_getPageHandles@ in @rules/adm/adm_windows.xml@. I see th... Eric Faulhaber
06:04 AM Base Language Feature #3342: implement a facility to easily run a JasperReports report definition from 4GL code...
Please make sure the testcase shows the features listed in #3342-64. Greg Shah
05:31 AM Base Language Feature #3342: implement a facility to easily run a JasperReports report definition from 4GL code...
To be clear: the example you posted is about the "hidden" browse export to various formats. That is not what we are ... Greg Shah
05:28 AM Base Language Feature #3342: implement a facility to easily run a JasperReports report definition from 4GL code...
This doesn't seem to be a complete sample. There are no @.jrxml@ report definitions. There are no queries being att... Greg Shah
01:06 AM Base Language Feature #3342: implement a facility to easily run a JasperReports report definition from 4GL code...
Here is the testcase that allows to run all kinds of browse Jasper reports. Note that the word cutting problem is sti... Stanislav Lomany

04/16/2018

07:10 PM Database Feature #3549: implement RAW-TRANSFER statement
Do to a short term need to provide a working implementation, I am writing a "basic" implementation that works but whi... Greg Shah
06:59 PM Database Feature #3549: implement RAW-TRANSFER statement
When I started looking at some testcases, I took a quick look at the serialized output to see how much of the structu... Greg Shah
01:22 PM Database Feature #3549: implement RAW-TRANSFER statement
The following are my early findings based on research and some initial testcases (see @testcases/uast/raw_transfer/*@... Greg Shah
01:33 PM User Interface Bug #3548: Window widget FULL-(WIDTH|HEIGHT)-(CHARS|PIXELS) proper initialization
Task branch @3548a@ has been updated for review to revision @11251@.
This is reworked code with changed location t...
Eugenie Lyzenko
01:30 PM User Interface Bug #3548: Window widget FULL-(WIDTH|HEIGHT)-(CHARS|PIXELS) proper initialization
Code review task branch 3548a revision 11250.
@WindowGuiImpl.fullSizeAttributesUpdated@ is redundant. Just move th...
Hynek Cihlar
07:02 AM User Interface Bug #3548: Window widget FULL-(WIDTH|HEIGHT)-(CHARS|PIXELS) proper initialization
Task branch @3548a@ has been updated for review to revision @11250@.
This is the small typo fixes for file headers...
Eugenie Lyzenko
09:35 AM User Interface Bug #3286 (Closed): fix features that can be relied upon to implement a limited form of dynamic r...
The work for this was done in #3434. The fixes in branch 3434a were merged into trunk as revision 11246. Greg Shah
10:29 PM User Interface Feature #3474 (Closed): OPEN-MIME-RESOURCE
Eric Faulhaber

04/14/2018

09:43 PM User Interface Bug #3548: Window widget FULL-(WIDTH|HEIGHT)-(CHARS|PIXELS) proper initialization
Task branch @3548a@ has been updated for review to revision @11249@.
Two more changes here:
1. I've accidentall...
Eugenie Lyzenko

04/13/2018

04:51 PM Database Feature #3549: implement RAW-TRANSFER statement
Useful links:
"How is the order of fields in temp-table definitions specified?":https://knowledgebase.progress.com...
Greg Shah
12:57 PM User Interface Bug #3548: Window widget FULL-(WIDTH|HEIGHT)-(CHARS|PIXELS) proper initialization
Task branch @3548a@ has been rebased with recent trunk and updated for review to revision @11248@.
This is the bas...
Eugenie Lyzenko

04/12/2018

07:35 PM User Interface Bug #3548: Window widget FULL-(WIDTH|HEIGHT)-(CHARS|PIXELS) proper initialization
Currently I see two deviation for @FWD@ comparing to @4GL@:
1. The default window attribute values are @unknown (?...
Eugenie Lyzenko
06:15 PM User Interface Bug #3548: Window widget FULL-(WIDTH|HEIGHT)-(CHARS|PIXELS) proper initialization
Created task branch @3548a@ from trunk revision @11246@. Eugenie Lyzenko
05:52 PM User Interface Bug #3548 (WIP): Window widget FULL-(WIDTH|HEIGHT)-(CHARS|PIXELS) proper initialization
Greg Shah
04:34 PM User Interface Bug #3548: Window widget FULL-(WIDTH|HEIGHT)-(CHARS|PIXELS) proper initialization
Hynek Cihlar wrote:
>
> It seems the lifetime of the @FULL-WIDTH-CHARS@ value is a bit more complex. I did a few s...
Eugenie Lyzenko
04:33 PM User Interface Bug #3548 (Closed): Window widget FULL-(WIDTH|HEIGHT)-(CHARS|PIXELS) proper initialization
Eugenie Lyzenko
06:34 PM User Interface Feature #3474: OPEN-MIME-RESOURCE
3474a has been merged into the trunk as bzr revision 11247 and archived. Sergey Ivanovskiy
06:23 PM User Interface Feature #3474: OPEN-MIME-RESOURCE
Yes, please do. Greg Shah
06:19 PM User Interface Feature #3474: OPEN-MIME-RESOURCE
Planning to merge rev 11269. Sergey Ivanovskiy
06:09 PM User Interface Feature #3474: OPEN-MIME-RESOURCE
Rev 11268 was rebased over current trunc rev 11246. Committed revision 11269 fixed related to this branch javadoc war... Sergey Ivanovskiy
05:02 PM User Interface Feature #3474: OPEN-MIME-RESOURCE
Please wait for task branch 3434a to be merged to trunk, then rebase and merge 3474a to trunk. Please confirm that 34... Eric Faulhaber
04:55 PM User Interface Feature #3474: OPEN-MIME-RESOURCE
These 2 failed tests passed in 2 single runs. Sergey Ivanovskiy
04:01 PM User Interface Feature #3474: OPEN-MIME-RESOURCE
Sergey Ivanovskiy wrote:
> The first round of main-regression tests passed with 3 failed tests. The second round is ...
Sergey Ivanovskiy
03:31 PM User Interface Feature #3474: OPEN-MIME-RESOURCE
Code review 3474a revision 11267.
The change is OK.
Hynek Cihlar
02:11 PM User Interface Feature #3474: OPEN-MIME-RESOURCE
The first round of main-regression tests passed with 3 failed tests. The second round is running now. Sergey Ivanovskiy
02:01 PM User Interface Feature #3474: OPEN-MIME-RESOURCE
Please review committed revision 11267 that added @UTF-8@ charset to @open-resource.html@ in order @OPEN-MIME-RESOURC... Sergey Ivanovskiy
06:40 AM User Interface Feature #3474: OPEN-MIME-RESOURCE
Greg Shah wrote:
> Sergey: You can start ChUI regression testing on devsrv01.
3474a passed conversion regression te...
Sergey Ivanovskiy
06:37 AM User Interface Feature #3474: OPEN-MIME-RESOURCE
Hynek Cihlar wrote:
> Code review 3474a revision 11266.
>
> The changes look good. I have no more objections.
> ...
Sergey Ivanovskiy
05:55 PM Runtime Infrastructure Bug #3272 (Closed): Login into web client with empty password crashes spawner
Branch 3434a was merged to trunk as revision 11246. Greg Shah
05:52 PM Database Feature #3549 (New): implement RAW-TRANSFER statement
Greg Shah
06:56 AM User Interface Bug #3487: Sub-menu graphical issues
Created task branch 3487a. Hynek Cihlar
06:45 AM Database Bug #3495 (Closed): invalid date initial value in schema causes a broken DMO constructor
This fix was included in branch 3489a which was merged to trunk as revision 11245. It will be available for download... Greg Shah

04/11/2018

03:58 PM User Interface Feature #3474: OPEN-MIME-RESOURCE
Sergey: You can start ChUI regression testing on devsrv01. Greg Shah
03:09 PM User Interface Feature #3474: OPEN-MIME-RESOURCE
Code review 3474a revision 11266.
The changes look good. I have no more objections.
Sergey, also please test th...
Hynek Cihlar
12:23 PM User Interface Feature #3474: OPEN-MIME-RESOURCE
3474a rev 11266 is rebased over the current trunc rev 11245. Sergey Ivanovskiy
10:48 AM User Interface Feature #3474: OPEN-MIME-RESOURCE
Code Review Task Branch 3474a Revision 11265
I'm good with the changes.
Hynek?
Greg Shah
10:36 AM User Interface Feature #3474: OPEN-MIME-RESOURCE
Please review the committed revision 11265. Sergey Ivanovskiy
10:27 AM User Interface Feature #3474: OPEN-MIME-RESOURCE
Yes, understand now. Committed revision 11265 fixed this issue. Sergey Ivanovskiy
10:20 AM User Interface Feature #3474: OPEN-MIME-RESOURCE
Sergey Ivanovskiy wrote:
> Hynek Cihlar wrote:
> > Code review 3474a revision 11263
> >
> > @SwingGuiDriver.open...
Hynek Cihlar
10:13 AM User Interface Feature #3474: OPEN-MIME-RESOURCE
Hynek Cihlar wrote:
> Code review 3474a revision 11263
>
> @SwingGuiDriver.openMimeResource()@
> The method will...
Sergey Ivanovskiy
09:39 AM User Interface Feature #3474: OPEN-MIME-RESOURCE
Hynek Cihlar wrote:
> Code review 3474a revision 11263
>
> @SwingGuiDriver.openMimeResource()@
> The method will...
Sergey Ivanovskiy
09:22 AM User Interface Feature #3474: OPEN-MIME-RESOURCE
Code review 3474a revision 11263
@SwingGuiDriver.openMimeResource()@
The method will throw an unexpected exceptio...
Hynek Cihlar
09:03 AM User Interface Feature #3474: OPEN-MIME-RESOURCE
Code Review Task Branch 3474a Revision 11263
I'm good with the changes.
Hynek: Do you have any objections?
Greg Shah
08:04 AM User Interface Feature #3474: OPEN-MIME-RESOURCE
Please review committed revision 11263. Sergey Ivanovskiy
08:02 AM User Interface Feature #3474: OPEN-MIME-RESOURCE
Greg Shah wrote:
> > If Desktop class helps to open Open Office documents, then this implementation will have diffe...
Sergey Ivanovskiy
08:00 AM User Interface Feature #3474: OPEN-MIME-RESOURCE
I see you already fixed it. Thank you. Sergey Ivanovskiy
07:58 AM User Interface Feature #3474: OPEN-MIME-RESOURCE
Hynek, please note that your changes in this code... Sergey Ivanovskiy
04:52 AM User Interface Feature #3474: OPEN-MIME-RESOURCE
OK, it is 3rd variant. Sergey Ivanovskiy
03:43 AM User Interface Feature #3474: OPEN-MIME-RESOURCE
Sergey Ivanovskiy wrote:
> Hynek Cihlar wrote:
> > Hynek Cihlar wrote:
> > > Anyway, @buildOpenResourceUrl@ always...
Hynek Cihlar
12:10 AM User Interface Feature #3474: OPEN-MIME-RESOURCE
Hynek Cihlar wrote:
> Hynek Cihlar wrote:
> > Anyway, @buildOpenResourceUrl@ always prepends the url with the webRo...
Sergey Ivanovskiy

04/10/2018

04:56 PM User Interface Feature #3474: OPEN-MIME-RESOURCE
Hynek Cihlar wrote:
> Anyway, @buildOpenResourceUrl@ always prepends the url with the webRoot as already mentioned. ...
Hynek Cihlar
04:54 PM User Interface Feature #3474: OPEN-MIME-RESOURCE
Sergey Ivanovskiy wrote:
> Hynek Cihlar wrote:
> > Sergey Ivanovskiy wrote:
> > > >MSG_OPEN_MIME_RESOURCE message ...
Hynek Cihlar
04:51 PM User Interface Feature #3474: OPEN-MIME-RESOURCE
Hynek Cihlar wrote:
> Also I think @path@ in @url += "/open/resource/?path=" + path;@ in @buildOpenResourceUrl@ shou...
Sergey Ivanovskiy
04:48 PM User Interface Feature #3474: OPEN-MIME-RESOURCE
Also I think @path@ in @url += "/open/resource/?path=" + path;@ in @buildOpenResourceUrl@ should be url encoded. Hynek Cihlar
04:47 PM User Interface Feature #3474: OPEN-MIME-RESOURCE
Hynek Cihlar wrote:
> Sergey Ivanovskiy wrote:
> > >MSG_OPEN_MIME_RESOURCE message handler in p2j.socket.js doesn't...
Sergey Ivanovskiy
04:43 PM User Interface Feature #3474: OPEN-MIME-RESOURCE
Sergey Ivanovskiy wrote:
> >MSG_OPEN_MIME_RESOURCE message handler in p2j.socket.js doesn't handle absolute urls,
>...
Hynek Cihlar
04:18 PM User Interface Feature #3474: OPEN-MIME-RESOURCE
>MSG_OPEN_MIME_RESOURCE message handler in p2j.socket.js doesn't handle absolute urls,
>buildOpenResourceUrl always ...
Sergey Ivanovskiy
03:45 PM User Interface Feature #3474: OPEN-MIME-RESOURCE
> If Desktop class helps to open Open Office documents, then this implementation will have different functionality. ... Greg Shah
02:59 PM User Interface Feature #3474: OPEN-MIME-RESOURCE
Sergey Ivanovskiy wrote:
> > Plus I renamed @ReportOutputFormat@ to @MediaType@ and moved it in @com.goldencode.p2j....
Hynek Cihlar
02:58 PM User Interface Feature #3474: OPEN-MIME-RESOURCE
Sergey Ivanovskiy wrote:
> I don't understand why it requires @finalizer@ because the @try with resource@ constructi...
Hynek Cihlar
02:57 PM User Interface Feature #3474: OPEN-MIME-RESOURCE
Hynek Cihlar wrote:
> Code review 3474a revision 11260.
>
> Plus I renamed @ReportOutputFormat@ to @MediaType@ an...
Sergey Ivanovskiy
02:52 PM User Interface Feature #3474: OPEN-MIME-RESOURCE
Hynek Cihlar wrote:
> Code review 3474a revision 11260.
> @SwingGuiDriver.openMimeResource()@
> There is a standar...
Sergey Ivanovskiy
02:46 PM User Interface Feature #3474: OPEN-MIME-RESOURCE
Hynek Cihlar wrote:
> @GuiWebDriver.openMimeResource()@
> The opened input stream should be closed in a finalizer. ...
Sergey Ivanovskiy
02:32 PM User Interface Feature #3474: OPEN-MIME-RESOURCE
Hynek Cihlar wrote:
> Code review 3474a revision 11260.
>
> @open-resource.html@:
> @"https://" + window.locatio...
Sergey Ivanovskiy
01:46 PM User Interface Feature #3474: OPEN-MIME-RESOURCE
Code review 3474a revision 11260.
@open-resource.html@:
@"https://" + window.location.host + "${webRoot}/${docume...
Hynek Cihlar
08:50 AM User Interface Feature #3474: OPEN-MIME-RESOURCE
Code Review Task Branch 3474a Revision 11259
I'm good with the changes. I did check in some minor formatting and ...
Greg Shah
06:09 AM User Interface Feature #3474: OPEN-MIME-RESOURCE
Please review committed revision 11259 (missed changes) that removed @ScreenDriver.this.openURL@ since @openURL@ was ... Sergey Ivanovskiy
05:52 AM User Interface Feature #3474: OPEN-MIME-RESOURCE
Please review committed revision 11258 that fixed #3474-62. Sergey Ivanovskiy
03:47 PM Bug #3378: Date input fields don't get focus by clicking on them
Thank you, I archived 3355a now. Sergey Ivanovskiy
03:35 PM Bug #3378: Date input fields don't get focus by clicking on them
Sergey Ivanovskiy wrote:
> OK, merged this change into 3369a, revision 11221. Planning to archive 3355a.
Sergey, I ...
Constantin Asofiei

04/09/2018

03:25 PM Build and Source Control Bug #3273 (Closed): Native part of FWD build fails when the used JDK is installed to a path locat...
OK, thanks for the clarification.
I'm closing this task.
Greg Shah
02:52 PM Build and Source Control Bug #3273: Native part of FWD build fails when the used JDK is installed to a path location with ...
Greg Shah wrote:
> > This is the really GCC package limitation that does not like the spaces in include file path.
...
Eugenie Lyzenko
02:35 PM Build and Source Control Bug #3273: Native part of FWD build fails when the used JDK is installed to a path location with ...
The documentation update is good.
> This is the really GCC package limitation that does not like the spaces in inc...
Greg Shah
02:31 PM Build and Source Control Bug #3273: Native part of FWD build fails when the used JDK is installed to a path location with ...
Greg Shah wrote:
> Please update our documentation ("Install the JDK":https://proj.goldencode.com/projects/p2j/wiki/...
Eugenie Lyzenko
01:51 PM Build and Source Control Bug #3273: Native part of FWD build fails when the used JDK is installed to a path location with ...
Please update our documentation ("Install the JDK":https://proj.goldencode.com/projects/p2j/wiki/Install_the_JDK) to ... Greg Shah
12:23 PM Build and Source Control Bug #3273: Native part of FWD build fails when the used JDK is installed to a path location with ...
After search for solution I've the following conclusion: This is the really @GCC@ package limitation that does not li... Eugenie Lyzenko
10:31 AM User Interface Feature #3474: OPEN-MIME-RESOURCE
> I didn't implement a special code because this command should open a browser with a file resource.
It could be ...
Greg Shah
09:36 AM User Interface Feature #3474: OPEN-MIME-RESOURCE
Greg Shah wrote:
> Code Review Task Branch 3474a Revision 11256
Thank you, planning to fix all these issues.
>...
Sergey Ivanovskiy
07:12 AM User Interface Feature #3474: OPEN-MIME-RESOURCE
Code Review Task Branch 3474a Revision 11256
This is really good. I think it is almost finished.
1. Please cha...
Greg Shah
08:32 AM Runtime Infrastructure Bug #3272: Login into web client with empty password crashes spawner
Task branch @3434a@ has been updated for review to revision @11251@.
This is the fix for @spawn.exe@ crash when us...
Eugenie Lyzenko

04/07/2018

10:38 AM User Interface Feature #3474: OPEN-MIME-RESOURCE
Please review committed revision 11256 that fixed #3474-55 and #3474-56. Sergey Ivanovskiy

04/06/2018

01:15 PM Database Feature #3296: misc db features
Last week I added some small fix that should correctly generate the nested CAN-FINDs in a single nested query if poss... Ovidiu Maxiniuc
01:08 PM Database Feature #3500: implement CLOB and BLOB support
The CLOB and BLOB implementation in the 4GL is pretty simple. They describe the actual contents of the field as a "lo... Greg Shah
10:19 AM User Interface Feature #3474: OPEN-MIME-RESOURCE
> If resources are external, then only urls will be sent to the client side. Does it need to have a feedback in this ... Greg Shah
08:30 AM User Interface Feature #3474: OPEN-MIME-RESOURCE
We don't specify the case if this command is failed. What should be done in this case? Now if resources are failed to... Sergey Ivanovskiy
07:57 AM User Interface Feature #3474: OPEN-MIME-RESOURCE
> There are server's resources and client's resources.
As far as I know, at this point all the resources we need t...
Greg Shah
07:52 AM User Interface Feature #3474: OPEN-MIME-RESOURCE
> Only resources that are already on the FWD systems should be streamed. Any directly accessible URLS should be sent... Sergey Ivanovskiy
07:12 AM User Interface Feature #3474: OPEN-MIME-RESOURCE
Please remove this comment and code:... Greg Shah
07:06 AM User Interface Feature #3474: OPEN-MIME-RESOURCE
> Yes, now it is possible to load documents by their URLs. it depends on requirements for OPEN-MIME-RESOURCE.
I sh...
Greg Shah
06:42 AM User Interface Feature #3474: OPEN-MIME-RESOURCE
> Hynek Cihlar wrote:
> > When you supply an absolute URL with a domain, the @openStream()@ and the @ByteStreams.cop...
Sergey Ivanovskiy
06:04 AM User Interface Feature #3474: OPEN-MIME-RESOURCE
Hynek Cihlar wrote:
> When you supply an absolute URL with a domain, the @openStream()@ and the @ByteStreams.copy()@...
Hynek Cihlar
05:55 AM User Interface Feature #3474: OPEN-MIME-RESOURCE
Sergey Ivanovskiy wrote:
> Hynek Cihlar wrote:
> > Currently all the url targets are first copied to the machine th...
Hynek Cihlar
05:11 AM User Interface Feature #3474: OPEN-MIME-RESOURCE
Hynek Cihlar wrote:
> Currently all the url targets are first copied to the machine that runs the FWD client and the...
Sergey Ivanovskiy
04:37 AM User Interface Feature #3474: OPEN-MIME-RESOURCE
Currently all the url targets are first copied to the machine that runs the FWD client and then streamed to the end-u... Hynek Cihlar
01:38 AM User Interface Feature #3474 (Review): OPEN-MIME-RESOURCE
Sergey Ivanovskiy
01:19 AM User Interface Feature #3474: OPEN-MIME-RESOURCE
Greg, please review committed revision 11255. Sergey Ivanovskiy

04/05/2018

09:58 AM User Interface Feature #3474: OPEN-MIME-RESOURCE
OK, planning to add this optional parameter. Committed revision 11254 changed @SwingGuiDriver.this.deliverPrintOutput... Sergey Ivanovskiy
07:18 AM User Interface Feature #3474: OPEN-MIME-RESOURCE
> We should probably make this configurable. Greg, what do you think?
Yes, this makes sense. We can embed by defa...
Greg Shah
04:43 AM User Interface Feature #3474: OPEN-MIME-RESOURCE
Sergey Ivanovskiy wrote:
> The implemented method to wrap documents with help of @open-resource.html@ template (embe...
Hynek Cihlar
02:45 AM User Interface Feature #3474: OPEN-MIME-RESOURCE
It seems that now url string should be with its protocol, for an example "file:./a.txt". Sergey Ivanovskiy
02:43 AM User Interface Feature #3474: OPEN-MIME-RESOURCE
I checked that plain string parameters can be used too. Committed rev 11252 added missed java docs. Sergey Ivanovskiy
02:23 AM User Interface Feature #3474: OPEN-MIME-RESOURCE
Sergey Ivanovskiy wrote:
> Finally, this construction works properly
> [...]
Does this allow you to have something...
Constantin Asofiei
01:32 AM User Interface Feature #3474: OPEN-MIME-RESOURCE
The implemented method to wrap documents with help of @open-resource.html@ template (embed) doesn't work for binary c... Sergey Ivanovskiy

04/04/2018

09:05 AM User Interface Feature #3474: OPEN-MIME-RESOURCE
It needs to reuse the code that is responsible to fill html templates @HtmlResourceHandler@. Otherwise these function... Sergey Ivanovskiy

04/03/2018

03:12 PM User Interface Feature #3469: final improvements and polish for the embedded mode web client
Greg Shah wrote:
> Perhaps the hamburger menu is better located to the right of the application's logo? It seems aw...
Eric Faulhaber
03:06 PM User Interface Feature #3469: final improvements and polish for the embedded mode web client
Perhaps the hamburger menu is better located to the right of the application's logo? It seems awkward to the left of... Greg Shah
03:01 PM User Interface Feature #3469: final improvements and polish for the embedded mode web client
Eric wrote:
> But as before, we probably want to blend the iframe background with the browser client background.
Ye...
Constantin Asofiei
02:57 PM User Interface Feature #3469: final improvements and polish for the embedded mode web client
Eric Faulhaber wrote:
> Constantin Asofiei wrote:
> > Eric, for the menubar, beside https://jqueryui.com/menu/ I ca...
Constantin Asofiei
02:35 PM User Interface Feature #3469: final improvements and polish for the embedded mode web client
Constantin Asofiei wrote:
> Eric, for the menubar, beside https://jqueryui.com/menu/ I can't find anything suitable ...
Eric Faulhaber
10:07 AM User Interface Feature #3469: final improvements and polish for the embedded mode web client
Eric, for the menubar, beside https://jqueryui.com/menu/ I can't find anything suitable (and out-of-the-box, to some ... Constantin Asofiei
09:26 AM User Interface Feature #3469: final improvements and polish for the embedded mode web client
> Is the licence OK? https://github.com/Templarian/MaterialDesign-Webfont/blob/master/license.md
Yes, it is OK. I...
Greg Shah
08:30 AM User Interface Feature #3469: final improvements and polish for the embedded mode web client
I'm using this project to get the material-design-icons webfonts: https://github.com/Templarian/MaterialDesign-Webfon... Constantin Asofiei
02:57 PM User Interface Feature #3474: OPEN-MIME-RESOURCE
> I didn't implement it for Swing clients.
It would be useful to launch a browser (we already support that) and th...
Greg Shah
02:01 PM User Interface Feature #3474: OPEN-MIME-RESOURCE
Please review committed revision 11248. Now this construction is supported by web clients. ... Sergey Ivanovskiy
10:59 AM User Interface Feature #3474: OPEN-MIME-RESOURCE
Hynek Cihlar wrote:
> Sergey Ivanovskiy wrote:
> > It seems that file resources available from Swing client should ...
Sergey Ivanovskiy
10:58 AM User Interface Feature #3474: OPEN-MIME-RESOURCE
Committed revision 11247 fixed issues with pdf and added new MSG_OPEN_MIME_RESOURCE. Working to implement file resour... Sergey Ivanovskiy
08:55 AM User Interface Feature #3474: OPEN-MIME-RESOURCE
Sergey Ivanovskiy wrote:
> It seems that file resources available from Swing client should be available via web clie...
Hynek Cihlar
08:32 AM User Interface Feature #3474: OPEN-MIME-RESOURCE
It seems that file resources available from Swing client should be available via web clients. Thus, @FileResourceHand... Sergey Ivanovskiy
07:26 AM User Interface Feature #3474: OPEN-MIME-RESOURCE
Yes, it works for me too. The problem was "Content-disposition" value: @attachment@ or @inline@. If @attachment@ is s... Sergey Ivanovskiy
06:27 AM User Interface Feature #3474: OPEN-MIME-RESOURCE
Sergey Ivanovskiy wrote:
> Another questions follow. We have @ReportOutputFormat@ and @GuiDriver.this.deliverPrintOu...
Hynek Cihlar
06:20 AM User Interface Feature #3474: OPEN-MIME-RESOURCE
Sergey Ivanovskiy wrote:
> Hynek Cihlar wrote:
> > Sergey Ivanovskiy wrote:
> > > I mean https output stream. For ...
Hynek Cihlar
06:10 AM User Interface Feature #3474: OPEN-MIME-RESOURCE
Another questions follow. We have @ReportOutputFormat@ and @GuiDriver.this.deliverPrintOutput(Consumer<OutputStream> ... Sergey Ivanovskiy
05:33 AM User Interface Feature #3474: OPEN-MIME-RESOURCE
Hynek Cihlar wrote:
> Sergey Ivanovskiy wrote:
> > I mean https output stream. For an example, this code works prop...
Sergey Ivanovskiy
04:54 AM User Interface Feature #3474: OPEN-MIME-RESOURCE
Sergey Ivanovskiy wrote:
> I mean https output stream. For an example, this code works properly
> [...]
> The next...
Hynek Cihlar
04:52 AM User Interface Feature #3474: OPEN-MIME-RESOURCE
Yes, agree. About embed tag I can test this http://mozilla.github.io/pdf.js/getting_started/ with our own view pdf te... Sergey Ivanovskiy
04:49 AM User Interface Feature #3474: OPEN-MIME-RESOURCE
Sergey Ivanovskiy wrote:
> I mean https output stream. For an example, this code works properly
> [...]
The prob...
Hynek Cihlar
04:40 AM User Interface Feature #3474: OPEN-MIME-RESOURCE
In my test the requested wrapped document has this url @https://localhost:7449/open/resource/?path=8fd81ccd-2f4c-4668... Sergey Ivanovskiy
04:28 AM User Interface Feature #3474: OPEN-MIME-RESOURCE
I mean https output stream. For an example, this code works properly... Sergey Ivanovskiy
04:10 AM User Interface Feature #3474: OPEN-MIME-RESOURCE
Sergey Ivanovskiy wrote:
> It seems the idea applied in @PDFPrintOutputHandler@ to use direct output on @document.sa...
Hynek Cihlar
03:59 AM User Interface Feature #3474: OPEN-MIME-RESOURCE
It seems the idea applied in @PDFPrintOutputHandler@ to use direct output on @document.save(output)@ should not work ... Sergey Ivanovskiy
04:21 AM Build and Source Control Bug #3545: Build fails on Windows when build dir on different drive letter than the gradle depend...
On 28.3.2018 17:23, Greg Shah wrote:
> :ant-prepare FAILED FAILURE: Build failed with an exception. * What went wron...
Hynek Cihlar
04:20 AM Build and Source Control Bug #3545 (New): Build fails on Windows when build dir on different drive letter than the gradle ...
Hynek Cihlar
 

Also available in: Atom