Project

General

Profile

Activity

From 09/18/2018 to 10/17/2018

10/17/2018

03:47 PM Bugs Support #3749 (Closed): Documentation setup Hotel application
For setting up the hotel application in the section "Convert and Build Using FWD" it says
"Change to this project d...
Marc Braun
09:46 AM Base Language Feature #3741: implement complete support for the CALL object handle and related attributes and m...
I think your examples are *not* showing direct memory usage.
From #3741-21:
> Another example is this: var-type...
Greg Shah
05:18 AM Base Language Feature #3741: implement complete support for the CALL object handle and related attributes and m...
My plan at this time is this:
* implement the infrastructure to make everything working
* if there is difference be...
Constantin Asofiei
03:08 AM Base Language Feature #3741: implement complete support for the CALL object handle and related attributes and m...
Greg Shah wrote:
> My first worry was that this was some kind of direct memory issue. For example, the value might ...
Constantin Asofiei

10/16/2018

06:42 PM Base Language Feature #3741: implement complete support for the CALL object handle and related attributes and m...
My first worry was that this was some kind of direct memory issue. For example, the value might be passed as a memor... Greg Shah
03:24 PM Base Language Feature #3741: implement complete support for the CALL object handle and related attributes and m...
There is some weird stuff with OUTPUT/INPUT-OUTPUT parameters, when the data-type specified at @SET-PARAMETER@ and th... Constantin Asofiei
12:41 PM Base Language Feature #3741: implement complete support for the CALL object handle and related attributes and m...
Greg Shah wrote:
> > This will require some refactoring of the NativeInvoker APIs, to access it directly.
>
> I ...
Constantin Asofiei
12:13 PM Base Language Feature #3741: implement complete support for the CALL object handle and related attributes and m...
> it may make sense to have this started for the CALL handle
Agreed, go with this.
> This will require some re...
Greg Shah
12:07 PM Base Language Feature #3741: implement complete support for the CALL object handle and related attributes and m...
Greg, something related to ControlFlowOps: some time ago I had a thought of using a builder approach for invoking thi... Constantin Asofiei
12:53 PM User Interface Feature #2673: support a kind of virtual desktop in the GUI web client
Hotel GUI rev 189 changes the configuration for the login page and desktop to present these screens as follows:
*L...
Eric Faulhaber
11:41 AM User Interface Feature #2673: support a kind of virtual desktop in the GUI web client
Let's leave it as is for now. We can change the opacity of the image directly in the PNG. Eric Faulhaber
11:24 AM User Interface Feature #2673: support a kind of virtual desktop in the GUI web client
May be this task can be done using images composition but I am not sure... Sergey Ivanovskiy
11:02 AM User Interface Feature #2673: support a kind of virtual desktop in the GUI web client
This is much better, but it only seems to be applying the opacity setting to the background color, not to the backgro... Eric Faulhaber
09:40 AM User Interface Feature #2673: support a kind of virtual desktop in the GUI web client
Please review these changes committed revision 11319. Now the background image position is not affected by the form c... Sergey Ivanovskiy
07:56 AM User Interface Feature #2673: support a kind of virtual desktop in the GUI web client
Good point. Please create a separate configuration for login and desktop. The same features should be available on ... Greg Shah
07:54 AM User Interface Feature #2673: support a kind of virtual desktop in the GUI web client
Should this opacity style be applied to the login form only? Should it be applied to the virtual desktop too? Now we ... Sergey Ivanovskiy
06:48 AM User Interface Feature #2673: support a kind of virtual desktop in the GUI web client
> we should add new parameter opacity
Please add this.
A customer should not have to edit the html files to get...
Greg Shah
06:34 AM User Interface Feature #2673: support a kind of virtual desktop in the GUI web client
Now the opacity is not supported, but it can be coded directly in @web_client.html@... Sergey Ivanovskiy
11:45 AM Conversion Tools Bug #3748: Building issue on Windows for missing get_current_dir_name() api in MinGW
Task branch @3706a@ has been updated for review to revision @11321@.
Fix for missing @get_current_dir_name()@ call...
Eugenie Lyzenko
11:33 AM Conversion Tools Bug #3748: Building issue on Windows for missing get_current_dir_name() api in MinGW
Greg Shah wrote:
> Please put the change into 3706a AND also post the updated file here so that customers can access...
Eugenie Lyzenko
11:28 AM Conversion Tools Bug #3748: Building issue on Windows for missing get_current_dir_name() api in MinGW
Please put the change into 3706a AND also post the updated file here so that customers can access it before we releas... Greg Shah
11:18 AM Conversion Tools Bug #3748: Building issue on Windows for missing get_current_dir_name() api in MinGW
The root cause of the failing build in Windows is missing support for @get_current_dir_name()@ GNU extension in MinGW... Eugenie Lyzenko
08:54 AM Conversion Tools Bug #3748 (Closed): Building issue on Windows for missing get_current_dir_name() api in MinGW
Eugenie Lyzenko

10/15/2018

06:13 PM Base Language Feature #3741: implement complete support for the CALL object handle and related attributes and m...
Greg Shah wrote:
> Constantin Asofiei wrote:
> > Open issues which will be left after everything else is working or...
Constantin Asofiei
06:10 PM Base Language Feature #3741: implement complete support for the CALL object handle and related attributes and m...
Constantin Asofiei wrote:
> Open issues which will be left after everything else is working or postponed:
> * runti...
Greg Shah
05:08 PM Base Language Feature #3741: implement complete support for the CALL object handle and related attributes and m...
Open issues which will be left after everything else is working or postponed:
* runtime for @PROCEDURE-TYPE@ and @TH...
Constantin Asofiei
05:22 PM User Interface Feature #2673: support a kind of virtual desktop in the GUI web client
Sergey, I'm trying to get the FWD logo centered horizontally on the login page, with a light grey background, maintai... Eric Faulhaber
09:18 AM User Interface Bug #3747: frozen web desktop
Recently, the AW client running as virtual desktop just froze. The only clue I found was in client log: ... Ovidiu Maxiniuc
09:14 AM User Interface Bug #3747 (New): frozen web desktop
Ovidiu Maxiniuc

10/12/2018

09:38 AM Runtime Infrastructure Bug #3746 (Closed): Running embedded mode with webClient/virtualDesktopEnabled set to true causes...
Greg Shah
05:00 AM Runtime Infrastructure Bug #3746 (Feedback): Running embedded mode with webClient/virtualDesktopEnabled set to true caus...
Hynek Cihlar
04:59 AM Runtime Infrastructure Bug #3746: Running embedded mode with webClient/virtualDesktopEnabled set to true causes an NPE
Please close this issue. The exception behavior was a regression of my local changes. Hynek Cihlar
04:54 AM Runtime Infrastructure Bug #3746: Running embedded mode with webClient/virtualDesktopEnabled set to true causes an NPE
Tested on Hotel GUI embedded mode.
It would be nice if FWD server gave a useful warning/error message in the serve...
Hynek Cihlar
04:51 AM Runtime Infrastructure Bug #3746 (Closed): Running embedded mode with webClient/virtualDesktopEnabled set to true causes...
Hynek Cihlar

10/11/2018

03:36 AM Database Bug #3743: H2 NPE after a forced shutdown of reporting server
Using Eclipse:
* start the reporting server
* login to Analytics using your browser
* shutdown the reporting serve...
Constantin Asofiei
03:33 AM Database Bug #3743 (New): H2 NPE after a forced shutdown of reporting server
Constantin Asofiei

10/08/2018

07:12 PM User Interface Feature #2673: support a kind of virtual desktop in the GUI web client
Committed revision 11303 added @background-color@ setting for the virtual desktop. Sergey Ivanovskiy
06:36 PM User Interface Feature #2673: support a kind of virtual desktop in the GUI web client
Constantin, please change position if it looks better. It is my subjective judgement that it looks properly with the ... Sergey Ivanovskiy
06:25 PM User Interface Feature #2673: support a kind of virtual desktop in the GUI web client
Sergey Ivanovskiy wrote:
> Committed revision 11302 (3706a) has minor fix for @background-color@ and committed rev 1...
Constantin Asofiei
06:14 PM User Interface Feature #2673: support a kind of virtual desktop in the GUI web client
Committed revision 11302 (3706a) has minor fix for @background-color@ and committed rev 178 (Hotel GUI) changed @dire... Sergey Ivanovskiy
05:31 PM User Interface Feature #2673: support a kind of virtual desktop in the GUI web client
Committed revision 11300 (3706a) should fix NPE by doing conditional static initializations for the virtual desktop m... Sergey Ivanovskiy
04:47 PM User Interface Feature #2673: support a kind of virtual desktop in the GUI web client
Fixing this NPE now and planning to change @background-size@ to @auto@ can help to preserve the original image. Sergey Ivanovskiy
04:40 PM User Interface Feature #2673: support a kind of virtual desktop in the GUI web client
Sergey Ivanovskiy wrote:
> Don't understand, please clarify your question. The @web_client.html@ template has been f...
Greg Shah
04:34 PM User Interface Feature #2673: support a kind of virtual desktop in the GUI web client
Sergey, when starting a standalone server for Hotel GUI embedded mode (ran from /embedded/ folder), I get this error:... Constantin Asofiei
04:25 PM User Interface Feature #2673: support a kind of virtual desktop in the GUI web client
Don't understand, please clarify your question. The @web_client.html@ template has been filled by @WebHandler@ on @GE... Sergey Ivanovskiy
04:15 PM User Interface Feature #2673: support a kind of virtual desktop in the GUI web client
If we can't serve the resources, how does this work? Greg Shah
01:34 PM User Interface Feature #2673: support a kind of virtual desktop in the GUI web client
It seems that @web_client.html@ can be decorated for an example using the existing Bootsrap styles. In order to do th... Sergey Ivanovskiy
12:30 PM User Interface Feature #2673: support a kind of virtual desktop in the GUI web client
Committed revision 177 (Hotel_GUI) added @available-themes@ and @background-image@ style settings. Sergey Ivanovskiy
12:18 PM User Interface Feature #2673: support a kind of virtual desktop in the GUI web client
Yes. Greg Shah
12:03 PM User Interface Feature #2673: support a kind of virtual desktop in the GUI web client
Greg, would you like to use the same desktop image for web_client.html as for index.html?
Sergey Ivanovskiy
11:59 AM User Interface Feature #2673: support a kind of virtual desktop in the GUI web client
> Greg, do we need this now?
If it is easily possible, then yes please do it.
Greg Shah
11:40 AM User Interface Feature #2673: support a kind of virtual desktop in the GUI web client
OK. Please wait. Sergey Ivanovskiy
11:34 AM User Interface Feature #2673: support a kind of virtual desktop in the GUI web client
Sergey, please update the Hotel GUI project with all directory settings required for the background image (@directory... Constantin Asofiei
11:22 AM User Interface Feature #2673: support a kind of virtual desktop in the GUI web client
Sergey Ivanovskiy wrote:
> Constantin Asofiei wrote:
> > Sergey Ivanovskiy wrote:
> > > Constantin, it seems that ...
Constantin Asofiei
11:21 AM User Interface Feature #2673: support a kind of virtual desktop in the GUI web client
Constantin Asofiei wrote:
> Sergey Ivanovskiy wrote:
> > Constantin, it seems that @web_client.html@ template is fo...
Sergey Ivanovskiy
11:17 AM User Interface Feature #2673: support a kind of virtual desktop in the GUI web client
Sergey Ivanovskiy wrote:
> Constantin, it seems that @web_client.html@ template is for login page
Did you add suppo...
Constantin Asofiei
11:14 AM User Interface Feature #2673: support a kind of virtual desktop in the GUI web client
OK. This task is done. It seems that if the FWD had @SET-DESKTOP-IMAGE url.@ statement, then adding MSG_SET_DESKTOP_I... Sergey Ivanovskiy
11:11 AM User Interface Feature #2673: support a kind of virtual desktop in the GUI web client
Please make sure that Hotel GUI has a functional solution today. We intend to show this at the PUG Challenge. Greg Shah
11:07 AM User Interface Feature #2673: support a kind of virtual desktop in the GUI web client
Constantin, it seems that @web_client.html@ template is for login page but the JS web client uses @index.html@ template. Sergey Ivanovskiy
11:03 AM User Interface Feature #2673: support a kind of virtual desktop in the GUI web client
I meant that the background images should be managed by the web client web server and should be delivered via https. ... Sergey Ivanovskiy
10:58 AM User Interface Feature #2673: support a kind of virtual desktop in the GUI web client
Eventually, you can set the @body@ image at login, and after login, move this image as background for our virtual des... Constantin Asofiei
10:57 AM User Interface Feature #2673: support a kind of virtual desktop in the GUI web client
Sergey Ivanovskiy wrote:
> It seems now to me that this solution is not good, because we should add the desktop imag...
Constantin Asofiei
10:45 AM User Interface Feature #2673: support a kind of virtual desktop in the GUI web client
It seems now to me that this solution is not good, because we should add the desktop image support to @index.html@ te... Sergey Ivanovskiy
10:15 AM User Interface Feature #2673: support a kind of virtual desktop in the GUI web client
Greg Shah wrote:
> Do you have settings we can use with Hotel GUI to add the FWD logo and improve the attractiveness...
Sergey Ivanovskiy
10:01 AM User Interface Feature #2673: support a kind of virtual desktop in the GUI web client
Found a copy paste error in the @p2j.socket.js@ and added empty styles validation. Please review committed rev.11296. Sergey Ivanovskiy
09:56 AM User Interface Feature #2673: support a kind of virtual desktop in the GUI web client
> but there is no mechanism to refresh the background image without restarting the server.
This is OK.
Greg Shah
08:50 AM User Interface Feature #2673: support a kind of virtual desktop in the GUI web client
Greg Shah wrote:
> Do you have settings we can use with Hotel GUI to add the FWD logo and improve the attractiveness...
Sergey Ivanovskiy
08:46 AM User Interface Feature #2673: support a kind of virtual desktop in the GUI web client
Greg Shah wrote:
> You described how incorrect settings were handled. What about missing settings?
No, missing set...
Sergey Ivanovskiy
08:17 AM User Interface Feature #2673: support a kind of virtual desktop in the GUI web client
Do you have settings we can use with Hotel GUI to add the FWD logo and improve the attractiveness of the virtual desk... Greg Shah
08:16 AM User Interface Feature #2673: support a kind of virtual desktop in the GUI web client
You described how incorrect settings were handled. What about missing settings? Greg Shah
07:56 AM User Interface Feature #2673: support a kind of virtual desktop in the GUI web client
I tested if these settings are not configured. Incorrect settings can lead to CSS style errors.The java web client or... Sergey Ivanovskiy
05:45 AM User Interface Feature #2673: support a kind of virtual desktop in the GUI web client
Sergey Ivanovskiy wrote:
> Please review committed revision 11292 (3706a) that added desktop images for the virtual ...
Constantin Asofiei
03:24 AM User Interface Feature #2673: support a kind of virtual desktop in the GUI web client
Committed revision 11294 fixed NPE if @background-image@ is not set.
Sergey Ivanovskiy
12:16 PM Conversion Tools Feature #3696: implement Progress AST anti-parser
3696a has been rebased from trunk 11286. The latest revision is 11300. Greg Shah

10/07/2018

05:48 PM User Interface Feature #2673: support a kind of virtual desktop in the GUI web client
Please review committed revision 11292 (3706a) that added desktop images for the virtual desktop mode. Sergey Ivanovskiy
04:44 PM User Interface Feature #2673: support a kind of virtual desktop in the GUI web client
I'm saying that your approach has security advantages. Greg Shah
03:51 PM User Interface Feature #2673: support a kind of virtual desktop in the GUI web client
I didn't add CSS parameters validation now but these parameters are secured by the directory. They can't be inserted ... Sergey Ivanovskiy
03:25 PM User Interface Feature #2673: support a kind of virtual desktop in the GUI web client
Constantin Asofiei wrote:
> Sergey, I don't think we want to encode each and every CSS property you want to set for ...
Greg Shah
03:15 PM User Interface Feature #2673: support a kind of virtual desktop in the GUI web client
Sergey, I don't think we want to encode each and every CSS property you want to set for the image, as a distinct dire... Constantin Asofiei
02:53 PM User Interface Feature #2673: support a kind of virtual desktop in the GUI web client
I didn't invent these parameters they define the CSS background image styles:
https://developer.mozilla.org/en-US/do...
Sergey Ivanovskiy

10/06/2018

12:45 PM User Interface Feature #2673: support a kind of virtual desktop in the GUI web client
I like it. Please post some details on the meaning of each one. Greg Shah
09:11 PM User Interface Feature #2673: support a kind of virtual desktop in the GUI web client
Planning to add new directory settings under @webClient/desktop@... Sergey Ivanovskiy

10/05/2018

03:28 PM User Interface Feature #2673: support a kind of virtual desktop in the GUI web client
Yes, agree. Sergey Ivanovskiy
03:26 PM User Interface Feature #2673: support a kind of virtual desktop in the GUI web client
Constantin Asofiei wrote:
> Actually, what @Theme.getName()@ is not really usable in a UX point of view: it returns ...
Ovidiu Maxiniuc
01:48 PM User Interface Feature #2673: support a kind of virtual desktop in the GUI web client
Thanks for the thoughtful discourse of this task. Planning to follow it. Sergey Ivanovskiy
01:38 PM User Interface Feature #2673: support a kind of virtual desktop in the GUI web client
Sergey Ivanovskiy wrote:
> Agree that class annotations can be used for theme name, but in this case we will add new...
Constantin Asofiei
01:27 PM User Interface Feature #2673: support a kind of virtual desktop in the GUI web client
The @Theme.getName()@ is practically not used. I added it for similar reasons. Currently the name is only displayed i... Ovidiu Maxiniuc
11:29 AM User Interface Feature #2673: support a kind of virtual desktop in the GUI web client
Agree that class annotations can be used for theme name, but in this case we will add new dependency. @Theme@ interfa... Sergey Ivanovskiy
11:17 AM User Interface Feature #2673: support a kind of virtual desktop in the GUI web client
Sergey Ivanovskiy wrote:
> > Hmm... ideally we wouldn't need to instantiate the theme to get its name. An annotatio...
Constantin Asofiei
11:13 AM User Interface Feature #2673: support a kind of virtual desktop in the GUI web client
Constantin Asofiei wrote:
> Sergey Ivanovskiy wrote:
> > > * why is the @OutputManager.instance()@ change required ...
Sergey Ivanovskiy
11:09 AM User Interface Feature #2673: support a kind of virtual desktop in the GUI web client
Sergey Ivanovskiy wrote:
> > * why is the @OutputManager.instance()@ change required for this task? Is this trying t...
Constantin Asofiei
11:01 AM User Interface Feature #2673: support a kind of virtual desktop in the GUI web client
Constantin Asofiei wrote:
> Review for 3600e rev 11337 (now in trunk 11286):
> * @WebHandler.doPost@ - you need to ...
Sergey Ivanovskiy
10:40 AM User Interface Feature #2673: support a kind of virtual desktop in the GUI web client
Review for 3600e rev 11337 (now in trunk 11286):
* @WebHandler.doPost@ - you need to validate @base.getParameter("th...
Constantin Asofiei
10:25 AM User Interface Feature #2673: support a kind of virtual desktop in the GUI web client
This code rev 11337 from 3600e is in the trunc rev 11286 already. The rest independent part of my task is to set the ... Sergey Ivanovskiy
10:10 AM User Interface Feature #2673: support a kind of virtual desktop in the GUI web client
Sergey Ivanovskiy wrote:
> Please review the committed rev 11337
What branch is this in?
Constantin Asofiei
08:55 AM User Interface Feature #2673: support a kind of virtual desktop in the GUI web client
Constantin: Please review. Greg Shah
12:07 PM User Interface Feature #3684: implement a web theme inspired by material design
The only remaining issue is the customization. For the moment the implementation is hardcoded, more like "this way yo... Ovidiu Maxiniuc
12:01 PM User Interface Feature #3684: implement a web theme inspired by material design
Ovidiu, is there anything left to do from the original goals of implementing the material theme, or can we close this... Eric Faulhaber
08:57 AM User Interface Feature #3684: implement a web theme inspired by material design
> but it seems the task bar style and its buttons style can be changed to flat with new background and foreground col... Greg Shah
04:32 AM User Interface Feature #3684: implement a web theme inspired by material design
Greg Shah wrote:
> Can you show what you mean using a screen capture from Hotel GUI? What specifically needs to be ...
Sergey Ivanovskiy
11:13 AM User Interface Feature #3269 (Closed): implement optional enhanced mode for ABL GUI which supports dynamic layout
It seems the core implementation is done. We can address defects and enhancements in separate tasks. Eric Faulhaber

10/04/2018

06:17 PM User Interface Feature #2673: support a kind of virtual desktop in the GUI web client
Please review the committed rev 11337 that added UI Theme drop down for the web client. The UI themes are given by @a... Sergey Ivanovskiy
05:04 PM User Interface Feature #2673: support a kind of virtual desktop in the GUI web client
Sergey Ivanovskiy wrote:
> Don't understand. Now the options are verified against security context. Since this conte...
Constantin Asofiei
04:43 PM User Interface Feature #2673: support a kind of virtual desktop in the GUI web client
Constantin Asofiei wrote:
> Sergey, for reading the available themes from the directory, follow the @FontTable.readF...
Sergey Ivanovskiy
04:06 PM User Interface Feature #2673: support a kind of virtual desktop in the GUI web client
Sergey, for reading the available themes from the directory, follow the @FontTable.readFontTable@ approach; these sho... Constantin Asofiei
03:50 PM User Interface Feature #2673: support a kind of virtual desktop in the GUI web client
Greg, please could you advise to do in this case. @WebHandler.verifySpawnOptions@ is used for the trusted mode in thi... Sergey Ivanovskiy
12:20 PM User Interface Feature #2673: support a kind of virtual desktop in the GUI web client
I was trying to set theme via @"client:driver:theme"@... Sergey Ivanovskiy
06:08 PM Base Language Feature #3741: implement complete support for the CALL object handle and related attributes and m...
I'm OK with hard coding the return values, however that does mean we'll have extra maintenance over time when Progres... Greg Shah
06:05 PM Base Language Feature #3741: implement complete support for the CALL object handle and related attributes and m...
> Also, list-set-attrs for a call handle gives a memory violation error in 4GL.
Of course it does. :)
We won't ...
Greg Shah
06:00 PM Base Language Feature #3741: implement complete support for the CALL object handle and related attributes and m...
OTOH, I think we should hard-code the values returned by these @list-query-attrs@ and @list-set-attrs@ builtin functi... Constantin Asofiei
05:56 PM Base Language Feature #3741: implement complete support for the CALL object handle and related attributes and m...
Greg Shah wrote:
> For this POC we also need the built-in functions @LIST-QUERY-ATTRS()@ and @LIST-SET-ATTRS()@. It...
Constantin Asofiei
05:54 PM Base Language Feature #3741: implement complete support for the CALL object handle and related attributes and m...
For this POC we also need the built-in functions @LIST-QUERY-ATTRS()@ and @LIST-SET-ATTRS()@. It seems pretty close ... Greg Shah
05:52 PM Base Language Feature #3741: implement complete support for the CALL object handle and related attributes and m...
Yes, please add them now. Greg Shah
05:46 PM Base Language Feature #3741: implement complete support for the CALL object handle and related attributes and m...
These attributes are not supported at parse time in FWD; they are all related to 'Invoking a Windows DLL routine or a... Constantin Asofiei
05:37 PM Base Language Feature #3741: implement complete support for the CALL object handle and related attributes and m...
Created task branch 3741a from trunk rev 11285. Constantin Asofiei
05:07 PM Base Language Feature #3741: implement complete support for the CALL object handle and related attributes and m...
Greg Shah wrote:
> Please take a look at @ProgressAst.keyword()@ and @ProgressAst.keywordAll()@. Is this what you a...
Constantin Asofiei
04:38 PM Base Language Feature #3741: implement complete support for the CALL object handle and related attributes and m...
Please take a look at @ProgressAst.keyword()@ and @ProgressAst.keywordAll()@. Is this what you are looking for? Greg Shah
04:30 PM Base Language Feature #3741: implement complete support for the CALL object handle and related attributes and m...
For handle attributes and methods, there's interesting stuff, too:
* there is a kind of runtime-validation of the gi...
Constantin Asofiei
03:44 PM Base Language Feature #3741: implement complete support for the CALL object handle and related attributes and m...
I think parameter passing/validation will be one of the complex parts. 4GL has a validation done at the @set-paramete... Constantin Asofiei
03:17 PM Base Language Feature #3741 (WIP): implement complete support for the CALL object handle and related attributes...
Constantin Asofiei
01:11 PM Base Language Feature #3741: implement complete support for the CALL object handle and related attributes and m...
The application POC which we are working on uses @CREATE CALL@ and a pretty complete set of the attributes and method... Greg Shah
01:10 PM Base Language Feature #3741 (Closed): implement complete support for the CALL object handle and related attribu...
Greg Shah
03:15 PM Conversion Tools Feature #3701 (Closed): create a logic/control flow chart "view" for top-level blocks which will ...
Greg Shah
03:15 PM Conversion Tools Feature #3701: create a logic/control flow chart "view" for top-level blocks which will be availa...
3701a was merged to trunk rev 11285 and archived. Constantin Asofiei
12:08 PM Conversion Tools Feature #3701: create a logic/control flow chart "view" for top-level blocks which will be availa...
Constantin Asofiei wrote:
> > One thing to mention is that the link text still sometimes is upside-down. It would be...
Greg Shah
03:15 PM Conversion Tools Feature #3699 (Closed): improve call-graph visualization to make it much more usable
Greg Shah
03:14 PM Conversion Tools Feature #3699: improve call-graph visualization to make it much more usable
3701a was merged to trunk rev 11285 and archived. Constantin Asofiei
03:01 PM Conversion Tools Feature #3699: improve call-graph visualization to make it much more usable
I'm OK with the changes. Please merge to trunk. When 3696 is finished we'll handle the anti-parsing integration. Greg Shah
02:38 PM Conversion Tools Feature #3699: improve call-graph visualization to make it much more usable
Greg Shah wrote:
> Just open a task for this and we won't work on it now. It seems likely this is just a browser bu...
Constantin Asofiei
02:24 PM Conversion Tools Feature #3699: improve call-graph visualization to make it much more usable
Just open a task for this and we won't work on it now. It seems likely this is just a browser bug and may get fixed ... Greg Shah
02:12 PM Conversion Tools Feature #3699: improve call-graph visualization to make it much more usable
Greg Shah wrote:
> Constantin Asofiei wrote:
> > IE11 has problems rendering the links (which are @polyline@ SVG el...
Constantin Asofiei
01:54 PM Conversion Tools Feature #3699: improve call-graph visualization to make it much more usable
Constantin Asofiei wrote:
> IE11 has problems rendering the links (which are @polyline@ SVG elements). I think is r...
Greg Shah
01:46 PM Conversion Tools Feature #3699: improve call-graph visualization to make it much more usable
IE11 has problems rendering the links (which are @polyline@ SVG elements). I think is related to @stroke-width@, but... Constantin Asofiei
12:55 PM Conversion Tools Feature #3699: improve call-graph visualization to make it much more usable
Greg Shah wrote:
> 1. Why are the @private@ methods @describeNode()@ and @describeTooltip()@ in @CallGraphApi@ being...
Constantin Asofiei
12:07 PM Conversion Tools Feature #3699: improve call-graph visualization to make it much more usable
Code Review Task Branch3701a Revision 11305
The results are really good. FYI, considering the amount of change in...
Greg Shah
02:35 PM Conversion Tools Bug #3742: IE11 doesn't render the flowchart or callgraph links
In IE11, the callgraph and flowchart links are not rendered; you need to open a flowchart and go back to previous scr... Constantin Asofiei
02:34 PM Conversion Tools Bug #3742 (New): IE11 doesn't render the flowchart or callgraph links
Constantin Asofiei
01:07 PM User Interface Feature #3684: implement a web theme inspired by material design
Ovidiu Maxiniuc wrote:
> The problem occurs when there are both fixed and scrollable columns in a browse. The fixed ...
Ovidiu Maxiniuc
07:20 AM Runtime Infrastructure Bug #3740: Not all ENTRY/LEAVE events are triggered when entering/leaving a hierarchy of enabled ...
Consider the following example:... Hynek Cihlar
07:17 AM Runtime Infrastructure Bug #3740 (New): Not all ENTRY/LEAVE events are triggered when entering/leaving a hierarchy of en...
Hynek Cihlar

10/03/2018

05:22 PM Conversion Tools Feature #3701 (Review): create a logic/control flow chart "view" for top-level blocks which will ...
> One thing to mention is that the link text still sometimes is upside-down. It would be good to fix that.
If you ar...
Constantin Asofiei
05:22 PM Conversion Tools Feature #3699 (Review): improve call-graph visualization to make it much more usable
The code reports are now the default view after login.
Please review 3701a rev 11305.
Constantin Asofiei
01:46 PM Conversion Tools Feature #3699: improve call-graph visualization to make it much more usable
!fwd_code_analytics_call_graph_visualization_screen.png!
!fwd_code_analytics_code_control_flow_logic_main_window_e...
Greg Shah
01:44 PM Conversion Tools Feature #3699: improve call-graph visualization to make it much more usable
This is very cool! I think it is a nice improvement for call graph and the flow chart support is in a good place for... Greg Shah
01:10 PM Conversion Tools Feature #3699: improve call-graph visualization to make it much more usable
The flowchart legend is in 11304. Constantin Asofiei
11:54 AM Conversion Tools Feature #3699: improve call-graph visualization to make it much more usable
Greg Shah wrote:
> Do you want a code review? History entries and javadoc seem to be missing, so I can wait until y...
Constantin Asofiei
11:54 AM Conversion Tools Feature #3699: improve call-graph visualization to make it much more usable
Do you want a code review? History entries and javadoc seem to be missing, so I can wait until you are ready.
I'm...
Greg Shah
10:10 AM Conversion Tools Feature #3699: improve call-graph visualization to make it much more usable
Greg, please take a look at 3701a rev 11303 - I don't think I can find something better than this.
Note that col...
Constantin Asofiei
01:18 PM User Interface Feature #3684: implement a web theme inspired by material design
The problem occurs when there are both fixed and scrollable columns in a browse. The fixed ones are drawn with a (+1,... Ovidiu Maxiniuc
08:38 AM User Interface Feature #3684: implement a web theme inspired by material design
Greg Shah wrote:
> Can you show what you mean using a screen capture from Hotel GUI? What specifically needs to be ...
Ovidiu Maxiniuc
08:35 AM User Interface Feature #3684: implement a web theme inspired by material design
Can you show what you mean using a screen capture from Hotel GUI? What specifically needs to be done and what do you... Greg Shah
03:35 AM User Interface Feature #3684: implement a web theme inspired by material design
It can be observed with the Material theme that the virtual desktop looks differently not according to the selected t... Sergey Ivanovskiy
12:19 PM User Interface Feature #2673: support a kind of virtual desktop in the GUI web client
I realized that it is done intentionally due to security restriction. If this code is invoked from @StandardServer@ d... Sergey Ivanovskiy
12:04 PM User Interface Feature #2673: support a kind of virtual desktop in the GUI web client
Do we really need a separate @theme@ directory class? This essentially is just a key/value mapping between strings. C... Eric Faulhaber
11:53 AM User Interface Feature #2673: support a kind of virtual desktop in the GUI web client
I defined this new class but @SecurityManager.getAccountIds()@ throws @NullPointerException@ ... Sergey Ivanovskiy
11:45 AM User Interface Feature #2673: support a kind of virtual desktop in the GUI web client
I think you need to define the @theme@ node type in @src/dir_schema.xml@.
Ovidiu Maxiniuc
11:40 AM User Interface Feature #2673: support a kind of virtual desktop in the GUI web client
I don't understand but this code returns null value for @nodePath1@... Sergey Ivanovskiy

10/02/2018

03:10 PM User Interface Feature #2673: support a kind of virtual desktop in the GUI web client
Planning to get all available themes from the directory. Sergey Ivanovskiy
03:07 PM User Interface Feature #2673: support a kind of virtual desktop in the GUI web client
I think the themes available to a user should come from a list in the directory, not from every available subclass of... Eric Faulhaber
03:03 PM User Interface Feature #2673: support a kind of virtual desktop in the GUI web client
OK, thank you. I found that there is @reflections-0.9.9-RC1.jar@ in the @build/lib@ but @build.gradle@ doesn't list t... Sergey Ivanovskiy
10:51 AM User Interface Feature #2673: support a kind of virtual desktop in the GUI web client
Sergey Ivanovskiy wrote:
> Please help to answer if there is a way to enumerate all supported themes. The supported ...
Ovidiu Maxiniuc
09:12 AM User Interface Feature #2673: support a kind of virtual desktop in the GUI web client
Please help to answer if there is a way to enumerate all supported themes. The supported themes can be made hard code... Sergey Ivanovskiy

10/01/2018

02:41 PM User Interface Feature #3684: implement a web theme inspired by material design
Sergey Ivanovskiy wrote:
> Ovidiu, please review the committed 11324. It seems that the root cause was that the web ...
Ovidiu Maxiniuc
08:00 PM User Interface Feature #3684: implement a web theme inspired by material design
Ovidiu, please review the committed 11324. It seems that the root cause was that the web client was waiting for the p... Sergey Ivanovskiy

09/25/2018

08:40 PM Conversion Tools Feature #3701: create a logic/control flow chart "view" for top-level blocks which will be availa...
The result is really impressive! I love the extra controls to expand all blocks and choose horizontal/vertical. It ... Greg Shah

09/24/2018

05:42 PM Conversion Tools Feature #3701: create a logic/control flow chart "view" for top-level blocks which will be availa...
Greg, please see 3701a rev 11299. You may want to check @./abl/fwd-embedded-driver.p.ast@, it contains more complex ... Constantin Asofiei
04:44 AM User Interface Feature #3684: implement a web theme inspired by material design
Eric Faulhaber wrote:
> Ovidiu, the material theme looks really great. Nice job! I have a few questions and a sugges...
Ovidiu Maxiniuc

09/22/2018

11:34 PM User Interface Feature #3684: implement a web theme inspired by material design
I also just noticed that the I-beam cursor seems to get lost when tabbing between fill-ins. The highlight/underline o... Eric Faulhaber
11:20 PM User Interface Feature #3684: implement a web theme inspired by material design
Ovidiu, the material theme looks really great. Nice job! I have a few questions and a suggested change:
* How easy...
Eric Faulhaber

09/21/2018

02:14 PM User Interface Feature #2673: support a kind of virtual desktop in the GUI web client
We have SET_DESKTOP_BGCOLOR drawing primitive that is used to set background colors in the embedded mode client with ... Sergey Ivanovskiy
12:27 PM User Interface Feature #2673 (WIP): support a kind of virtual desktop in the GUI web client
Sergey, please work on the following:
* We should provide wallpaper support. We can allow a scaled or cropped imag...
Greg Shah
12:16 PM User Interface Feature #2673: support a kind of virtual desktop in the GUI web client
This issue is fixed. Sergey Ivanovskiy
12:15 PM User Interface Feature #2673: support a kind of virtual desktop in the GUI web client
Yes, the web client updates the desktop size using this message @MSG_GET_DESKTOP_DIMENSION@. I looked at p2j.socket.j... Sergey Ivanovskiy
12:04 PM User Interface Feature #2673: support a kind of virtual desktop in the GUI web client
> The web page already is a kind of desktop or screen. We define that "screen size" in GuiWebDriver, defaulting it to... Greg Shah
12:32 PM User Interface Feature #3684: implement a web theme inspired by material design
I will work on this issue as a part of #2673. Sergey Ivanovskiy
10:14 AM User Interface Feature #3684: implement a web theme inspired by material design
Sergey: Can you please look at this web client palette message issue? Greg Shah
12:23 PM User Interface Feature #2676 (Closed): implement the equivalent to configurable support for a windows theme
Greg Shah
09:06 AM User Interface Bug #3723: Pressing ESC key twice doesn't allow the web client to log out properly
Found that if we executed a simple GUI program in the web client and press ESC key, then "Procedure complete ..." sta... Sergey Ivanovskiy
09:03 AM User Interface Bug #3723 (New): Pressing ESC key twice doesn't allow the web client to log out properly
Sergey Ivanovskiy

09/19/2018

07:12 PM Conversion Tools Feature #3701: create a logic/control flow chart "view" for top-level blocks which will be availa...
Rev 11296 captures.
On first entry:
!fully_collapsed_flow_chart_branch_3701a_rev_11296.png!
When the repeat ...
Greg Shah
05:28 PM Conversion Tools Feature #3701: create a logic/control flow chart "view" for top-level blocks which will be availa...
Greg Shah wrote:
> Are you trying to avoid statement-specific nodes?
Yes, I want to avoid adding other nodes, and j...
Constantin Asofiei
04:24 PM Conversion Tools Feature #3701: create a logic/control flow chart "view" for top-level blocks which will be availa...
> What about this: we output the entire 4GL code for such statements, and add a way to show to the target AST for i.e... Greg Shah
03:05 PM Conversion Tools Feature #3701: create a logic/control flow chart "view" for top-level blocks which will be availa...
Greg Shah wrote:
> Yes, I think so. This is an opportunity for the individual symbols in the flow chart to be augme...
Constantin Asofiei
10:45 AM Conversion Tools Feature #3701: create a logic/control flow chart "view" for top-level blocks which will be availa...
> OK, so any statement which can affects the flow should be enhanced, to provide details about the call target.
Ye...
Greg Shah
10:21 AM Conversion Tools Feature #3701: create a logic/control flow chart "view" for top-level blocks which will be availa...
Greg Shah wrote:
> Does that make sense? If there is a specific target, provide some linkage and handle any call/re...
Constantin Asofiei
12:24 PM User Interface Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...
I've added "rework of the Save Changes processing and directory approach for layout/UI customization as described in ... Greg Shah
12:12 PM User Interface Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...
> I think this approach is workable. Does anyone have any questions, comments or concerns?
I like it. I don't lik...
Stanislav Lomany
11:05 AM User Interface Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...
I think the current approach for storing/reading/saving layout and UI settings cannot be used in a production environ... Greg Shah

09/18/2018

06:30 PM Conversion Tools Feature #3701: create a logic/control flow chart "view" for top-level blocks which will be availa...
> should all call-sites appear, and if so, should they link somewhere or just as code snippets
By definition, most...
Greg Shah
05:53 PM Conversion Tools Feature #3701: create a logic/control flow chart "view" for top-level blocks which will be availa...
Greg, I need some input for #3701-22. Constantin Asofiei
 

Also available in: Atom