Project

General

Profile

Activity

From 07/09/2019 to 08/07/2019

08/07/2019

05:23 PM Database Feature #3809: ProDataSet support
Constantin Asofiei wrote:
> Considering that this 'fill must have a data-source or before-fill callback' doesn't rai...
Constantin Asofiei
04:22 PM Database Feature #3809: ProDataSet support
I think I'm on to something: if the NO-ERROR mode is ON while DATASET:FILL is executed, this gets deactivated if ther... Constantin Asofiei
02:20 PM User Interface Feature #4170 (Closed): add drag and drop support to treeview widget
Greg Shah
11:24 AM User Interface Feature #3940: CREATE-RESULT-LIST-ENTRY() method support
At this point FWD has limited implementation of @CREATE-RESULT-LIST-ENTRY@: it is only implemented for @AdaptiveQuery... Stanislav Lomany
08:01 AM Database Feature #3816: table and table handle parameter options
Constantin Asofiei wrote:
> There's another issue with BIND which I don't see how to solve yet: if the source and ta...
Marian Edu

08/06/2019

08:20 PM User Interface Feature #4164: implement misc UI features (frame options, misc attributes)

* -test the @FRAME-COL@ function to ensure it is compatible-
* frame options
** @SCROLL@ (runtime stubs)
** -@US...
Greg Shah
08:17 PM User Interface Feature #4164 (WIP): implement misc UI features (frame options, misc attributes)
Greg Shah

08/05/2019

09:38 AM Database Feature #3816: table and table handle parameter options
There's another issue with BIND which I don't see how to solve yet: if the source and target tables have different na... Constantin Asofiei
08:33 AM Database Feature #3816: table and table handle parameter options
I'll drop here some starting spec on @TABLE@ parameters.
* When a temp-table is defined as @REFERENCE-ONLY@, it ca...
Stanislav Lomany

08/03/2019

08:25 PM Database Feature #3816: table and table handle parameter options
Constantin Asofiei wrote:
> * this 'mutable proxy' must be kept only at the Java field, with the 'original definitio...
Constantin Asofiei
08:15 PM Database Feature #3816: table and table handle parameter options
The main changes related to making the Buffer mutable are working, same with the Dataset. But there is some cleanup ... Constantin Asofiei

08/02/2019

05:26 PM Database Feature #3816: table and table handle parameter options
Ovidiu Maxiniuc wrote:
> We talked about calling an update notification on parent dataset once a buffer was "redirec...
Constantin Asofiei
05:26 PM Database Feature #3816: table and table handle parameter options
Eric Faulhaber wrote:
> Constantin Asofiei wrote:
> > There's another part related to the field mapping between the...
Constantin Asofiei
05:20 PM Database Feature #3816: table and table handle parameter options
Constantin Asofiei wrote:
> There's another part related to the field mapping between the source and target temp-tab...
Ovidiu Maxiniuc
05:20 PM Database Feature #3816: table and table handle parameter options
Constantin Asofiei wrote:
> There's another part related to the field mapping between the source and target temp-tab...
Eric Faulhaber
05:18 PM Database Feature #3816: table and table handle parameter options
There's another part related to the field mapping between the source and target temp-tables: when they are used in qu... Constantin Asofiei
04:21 PM Database Bug #4163: SHARED non-NEW buffer definitions must act as the equivalent of FIND or CREATE
SHARED non-NEW buffer definitions must promote the buffer and generally act as the equivalent of FIND or CREATE.
...
Greg Shah
04:12 PM Database Bug #4163 (Closed): SHARED non-NEW buffer definitions must act as the equivalent of FIND or CREATE
Greg Shah
03:34 PM Base Language Feature #4162 (Closed): enhance existing SESSION:STARTUP-PARAMETERS support to honor -ininame value
Greg Shah
12:03 PM User Interface Bug #3690: BUTTON widget reaction on SPACEBAR and ENTER keys
I have fixed the lack of response from the buttons inside the alert box. This was due to the fact that no ActionEvent... Adrian Lungu

08/01/2019

06:50 PM Database Feature #3816: table and table handle parameter options
Ovidiu, I think the @private-data@ issue I've mentioned is because, even if you have something like @def input parame... Constantin Asofiei
06:16 PM Database Feature #3816: table and table handle parameter options
Constantin Asofiei wrote:
> Ovidiu, do you know if we currently have a registry of explicitly defined buffers for a ...
Ovidiu Maxiniuc
06:02 PM Database Feature #3816: table and table handle parameter options
Ovidiu, do you know if we currently have a registry of explicitly defined buffers for a table? I ask because 4GL swi... Constantin Asofiei
05:58 PM Database Feature #3816: table and table handle parameter options
Something similar to this I added for @StaticDataSet@. There is the @bound@ @Dataset@ which can be @null@ for REFEREN... Ovidiu Maxiniuc
05:42 PM Database Feature #3816: table and table handle parameter options
Eric Faulhaber wrote:
> What exactly would be mutable? The current buffer proxy? Some new wrapper class? Please help...
Constantin Asofiei
05:34 PM Database Feature #3816: table and table handle parameter options
Eric Faulhaber wrote:
> Hm, I don't know enough about the current DATASET implementation to comment or adjust my pro...
Ovidiu Maxiniuc
05:25 PM Database Feature #3816: table and table handle parameter options
Eric Faulhaber wrote:
> @bufB@ is a parameter scoped to the called procedure, correct? Doesn't it naturally go out o...
Constantin Asofiei
05:24 PM Database Feature #3816: table and table handle parameter options
Constantin Asofiei wrote:
> If we don't make these mutable...
What exactly would be mutable? The current buffer p...
Eric Faulhaber
05:22 PM Database Feature #3816: table and table handle parameter options
Constantin Asofiei wrote:
> Eric, I'm backtracking a little on your "@TemporaryBuffer.associate@ will return a new p...
Eric Faulhaber
05:18 PM Database Feature #3816: table and table handle parameter options
Constantin Asofiei wrote:
> Eric Faulhaber wrote:
> > Sorry, what precisely are you asking about? The remapped gett...
Eric Faulhaber
04:54 PM Database Feature #3816: table and table handle parameter options
Eric, I'm backtracking a little on your "@TemporaryBuffer.associate@ will return a new proxy idea". The reason are t... Constantin Asofiei
04:51 PM Database Feature #3816: table and table handle parameter options
Eric Faulhaber wrote:
> Sorry, what precisely are you asking about? The remapped getter/setter calls in the invocati...
Constantin Asofiei
04:30 PM Database Feature #3816: table and table handle parameter options
Eric Faulhaber wrote:
> Constantin, Ovidiu, do either of you know of any "4GL resource state" that is managed in @Bu...
Constantin Asofiei
04:22 PM Database Feature #3816: table and table handle parameter options
Eric Faulhaber wrote:
> Constantin, Ovidiu, do either of you know of any "4GL resource state" that is managed in @Bu...
Ovidiu Maxiniuc
04:14 PM Database Feature #3816: table and table handle parameter options
Constantin, Ovidiu, do either of you know of any "4GL resource state" that is managed in @BufferImpl@ which does NOT ... Eric Faulhaber
04:08 PM Database Feature #3816: table and table handle parameter options
I suppose we could create a proxy for all the interfaces which @BufferImpl@ statically implements (including those of... Eric Faulhaber
03:53 PM Database Feature #3816: table and table handle parameter options
Eric Faulhaber wrote:
> Same restriction for @h-ttB:BUFFER-FIELD("fB")@?
Yes, this throws error 7351. However, @h-t...
Ovidiu Maxiniuc
03:51 PM Database Feature #3816: table and table handle parameter options
Eric Faulhaber wrote:
> Ovidiu Maxiniuc wrote:
> > Because the all calls are 'live' redirected to @ttA@ buffer, the...
Ovidiu Maxiniuc
03:45 PM Database Feature #3816: table and table handle parameter options
Ovidiu Maxiniuc wrote:
> Because the all calls are 'live' redirected to @ttA@ buffer, the changes done on @ttB@ will...
Eric Faulhaber
03:43 PM Database Feature #3816: table and table handle parameter options
Marian, what is exactly the difference between passing a structure (I guess DATASETs and BUFFERs are similar here) wi... Ovidiu Maxiniuc
03:42 PM Database Feature #3816: table and table handle parameter options
Constantin Asofiei wrote:
> Will this @BufferImpl@ reflect any changes back to the caller's buffer (@bufA@)? Also, ...
Eric Faulhaber
03:32 PM Database Feature #3816: table and table handle parameter options
I think the dynamic dereference can be handled separately. In this case, both @ttB@ and @ttA@ will only have the acce... Ovidiu Maxiniuc
03:31 PM Database Feature #3816: table and table handle parameter options
Constantin Asofiei wrote:
> Eric Faulhaber wrote:
> > Since this is the same object, is my dynamic field dereferenc...
Eric Faulhaber
03:27 PM Database Feature #3816: table and table handle parameter options
Ovidiu Maxiniuc wrote:
> I think it might work. The new local BUFFER will keep the reference of the passed-in BUFFER...
Eric Faulhaber
03:16 PM Database Feature #3816: table and table handle parameter options
Eric Faulhaber wrote:
> Since this is the same object, is my dynamic field dereference scenario 2 described in #3816...
Constantin Asofiei
03:15 PM Database Feature #3816: table and table handle parameter options
I think it might work. The new local BUFFER will keep the reference of the passed-in BUFFER and will delegate all met... Ovidiu Maxiniuc
03:13 PM Database Feature #3816: table and table handle parameter options
Eric Faulhaber wrote:
> @TB.associate@ returns @<T>@, where @<T>@ is a reference to the *locally* defined buffer (i....
Constantin Asofiei
02:51 PM Database Feature #3816: table and table handle parameter options
Thanks, Marian. I think my design will handle the BY-REFERENCE case, which is complicated a bit by the fact that FWD ... Eric Faulhaber
02:39 PM Database Feature #3816: table and table handle parameter options
I don't know much about how you have that implemented but a temp-table is a data structure in 4gl, it has a default b... Marian Edu
01:28 PM Database Feature #3816: table and table handle parameter options
As I understand it, there are 3 cases of field dereferencing within the callee procedure, which need to be supported ... Eric Faulhaber
12:08 PM Database Feature #3816: table and table handle parameter options
Eric Faulhaber wrote:
> Potential complication: since the field names can differ for the same fields (i.e., those wh...
Constantin Asofiei
12:07 PM Database Feature #3816: table and table handle parameter options
Eric Faulhaber wrote:
> Instead of returning @void@, @TemporaryBuffer.associate@ returns @<T>@, where @<T>@ is a buf...
Constantin Asofiei
12:02 PM Database Feature #3816: table and table handle parameter options
Guys, what do you think about this approach?
Instead of returning @void@, @TemporaryBuffer.associate@ returns @<T>...
Eric Faulhaber
10:56 AM Database Feature #3816: table and table handle parameter options
Sorry, I was not very explicit because I reached some of the conclusion while writing the note. Here is an more compl... Ovidiu Maxiniuc
09:06 AM Database Feature #3816: table and table handle parameter options
> Actually the indexes must be a match.
I wonder if my testing was previously somehow incorrect or not extensive e...
Greg Shah
08:26 AM Database Feature #3816: table and table handle parameter options
Actually the indexes must be a match.
I tried to run the following test procedure:...
Ovidiu Maxiniuc
02:59 PM User Interface Bug #3690: BUTTON widget reaction on SPACEBAR and ENTER keys
Adrian Lungu wrote:
> Moved revision 11322 onto a new branch 3889a. Revisions 11320 and 11321 were merged into 4045a...
Sergey Ivanovskiy
07:12 AM User Interface Bug #4161: MESSAGE statement without data produces different output than 4GL
There is a minor incompatibility between the @MESSAGE@ output between 4GL and FWD, at least in the case when output i... Igor Skornyakov
07:11 AM User Interface Bug #4161 (New): MESSAGE statement without data produces different output than 4GL
Igor Skornyakov
07:10 AM Base Language Bug #4160: Arrays assigment issue
I've encountered an issue with assigning arrays. Consider the following 4GL code:... Igor Skornyakov
07:07 AM Base Language Bug #4160 (WIP): Arrays assigment issue
Igor Skornyakov
08:56 PM Database Feature #3815: more temp-table options
Fixes for remaining CODEPAGE issues are in 3816a rev 11327. Stanislav Lomany

07/31/2019

07:57 PM Database Feature #3816: table and table handle parameter options
> The source and target buffers must match only on the number of fields and their types (in the proper order), as far... Greg Shah
06:35 PM Database Feature #3816: table and table handle parameter options
A few questions on your last post...
What happens if @ttB@ does not match the structure (i.e., type and order of f...
Eric Faulhaber
03:30 PM Database Feature #3816: table and table handle parameter options
The mess is getting even messier. The source and target buffers must match only on the number of fields and their ty... Constantin Asofiei
02:42 PM Database Feature #3816: table and table handle parameter options
Eric Faulhaber wrote:
> Hm, I just realized @BufferImpl@ inherits all the instance data from @HandleChain@ and its a...
Constantin Asofiei
02:33 PM Database Feature #3816: table and table handle parameter options
Hm, I just realized @BufferImpl@ inherits all the instance data from @HandleChain@ and its ancestry. This plan is get... Eric Faulhaber
02:32 PM Database Feature #3816: table and table handle parameter options
Eric Faulhaber wrote:
>... so I need some guidance as to whether the core design idea of doing this at the proxy lev...
Constantin Asofiei
02:29 PM Database Feature #3816: table and table handle parameter options
Constantin Asofiei wrote:
> Eric Faulhaber wrote:
> > In terms of FWD's implementation, if we needed to "un-assign"...
Eric Faulhaber
02:14 PM Database Feature #3816: table and table handle parameter options
Eric Faulhaber wrote:
> In terms of FWD's implementation, if we needed to "un-assign" the buffer (i.e., invocation h...
Constantin Asofiei
02:01 PM Database Feature #3816: table and table handle parameter options
Constantin Asofiei wrote:
> Also, another unknown is what happens with the buffer's referenced record, for the impli...
Eric Faulhaber
01:33 PM Database Feature #3816: table and table handle parameter options
I should clarify that last statement. The proxy instance also holds instance data which @BufferImpl@ (the proxy's par... Eric Faulhaber
01:25 PM Database Feature #3816: table and table handle parameter options
Hm, I was thinking of making the proxy itself mutable, but the only instance data the proxy holds is the invocation h... Eric Faulhaber
01:15 PM Database Feature #3816: table and table handle parameter options
Eric Faulhaber wrote:
> Do we need the ability to re-associate a different @RecordBuffer@ instance with a @Buffer@ p...
Constantin Asofiei
01:00 PM Database Feature #3816: table and table handle parameter options
Constantin, et al.: what are we thinking, in terms of an implementation of BY-REFERENCE for buffers in FWD?
Do we ...
Eric Faulhaber
06:30 PM Database Feature #3809: ProDataSet support
Constantin, please see revision 11409. Ovidiu Maxiniuc
05:07 PM Database Feature #3809: ProDataSet support
Constantin Asofiei wrote:
> Does this fix the BY-REFERENCE, too? I mean, any DATASET can be replaced by an argument ...
Ovidiu Maxiniuc
05:03 PM Database Feature #3809: ProDataSet support
Ovidiu Maxiniuc wrote:
> Support for REFERENCE-ONLY option and NUM-REFERENCES attribute of DATASET was added in the ...
Constantin Asofiei
04:41 PM Database Feature #3809: ProDataSet support
Support for REFERENCE-ONLY option and NUM-REFERENCES attribute of DATASET was added in the branch 4124a.
Committed r...
Ovidiu Maxiniuc
07:29 AM User Interface Bug #3690: BUTTON widget reaction on SPACEBAR and ENTER keys
Moved revision 11322 onto a new branch 3889a. Revisions 11320 and 11321 were merged into 4045a. Branch 3690a is no lo... Adrian Lungu

07/29/2019

06:22 PM Database Feature #3816: table and table handle parameter options
> I can 'emulate' certain features (like ensuring the buffer is on the same record, when entering and exiting a proce... Stanislav Lomany
04:51 AM Database Feature #3816: table and table handle parameter options
I'm just saying there is no real dependency between @REFERENCE-ONLY@ and @BY-REFERENCE@. For @BIND@ however one of th... Marian Edu
04:20 AM Database Feature #3816: table and table handle parameter options
Marian Edu wrote:
> Constantin, are you referring to @BY-REFERENCE@ here? @REFERENCE-ONLY@ is just an option on temp...
Constantin Asofiei
04:00 AM Database Feature #3816: table and table handle parameter options
Constantin Asofiei wrote:
> Next issue I need solved is REFERENCE-ONLY for DATASET and TEMP-TABLE: these really are ...
Marian Edu
02:14 PM Conversion Tools Bug #4157: Name conversion report problem
h2. The problem
The page https://proj.goldencode.com/projects/p2j/wiki/Chapter_13_Other_Customization says:
> "...
Vladimir Tsichevski
02:04 PM Conversion Tools Bug #4157 (New): Name conversion report problem
Vladimir Tsichevski
09:38 AM Conversion Tools Bug #4151: make databaseMode usage safer in rpt_file_list

> # the name of the annotation is @srcname@, not the @srcfile@.
The @srcfile@ is the right name indeed. Please i...
Vladimir Tsichevski
07:13 AM Conversion Tools Bug #4156: Conversion failed with "Cannot find buffer ..."
h2. The problem
Conversion of this code fragment failed on the 'cb' stage:...
Vladimir Tsichevski
07:01 AM Conversion Tools Bug #4156 (New): Conversion failed with "Cannot find buffer ..."
Vladimir Tsichevski

07/28/2019

02:05 PM Database Feature #3816: table and table handle parameter options
Next issue I need solved is REFERENCE-ONLY for DATASET and TEMP-TABLE: these really are the same resources as, for ex... Constantin Asofiei

07/26/2019

03:22 PM Database Feature #3809: ProDataSet support
Branch 4124a was updated with following changes:
* @BufferImpl@ has SET-CALLBACK methods implemented;
* @DataSet@ p...
Ovidiu Maxiniuc
02:08 PM Database Feature #3815: more temp-table options
> Is @def shared temp-table tt-one@ in the same source file as @def temp-table tt-like like tt-one.@?
No, they ar...
Stanislav Lomany
01:21 PM Database Feature #3815: more temp-table options
> But I don't know if @tempTableRef@ really needs to be @null@ for non-master buffers - if this is true, and it can b... Stanislav Lomany
09:38 AM Database Feature #3815: more temp-table options
Constantin Asofiei wrote:
> Ovidiu/Stanislav: we need to determine how the @TemporaryBuffer.tempTableRef@ is behaves...
Ovidiu Maxiniuc
07:59 AM Database Feature #3815: more temp-table options
Ovidiu/Stanislav: we need to determine how the @TemporaryBuffer.tempTableRef@ is behaves. For @master != null@, I fo... Constantin Asofiei
07:20 AM Database Feature #3815: more temp-table options
> The problem is that the entries in the SVM.tempTables registry are keyed by converted name, not legacy name. I supp... Greg Shah
04:40 AM Database Feature #3815: more temp-table options
> I need to take a look again. If it's only about the adding a new map, it should be resolved quickly.
Actually th...
Stanislav Lomany
01:45 PM Conversion Tools Bug #4151: make databaseMode usage safer in rpt_file_list
The report in 4069a does not work for two reasons:
# there is not such property as @root@. There is a function @bo...
Vladimir Tsichevski
12:29 PM Conversion Tools Bug #4151: make databaseMode usage safer in rpt_file_list
Sorry, I had not pushed my changes. Try @bzr update@ now. Greg Shah
12:24 PM Conversion Tools Bug #4151: make databaseMode usage safer in rpt_file_list
Greg Shah wrote:

> Please see task branch 4069a revision 11353 where I have made the appropriate changes. Please...
Vladimir Tsichevski
10:48 AM Conversion Tools Bug #4151: make databaseMode usage safer in rpt_file_list
> Note: Only the root AST node is tested for the condition in the condition parameter in this very report in FWD v.3.... Greg Shah
08:13 AM Conversion Tools Bug #4151: make databaseMode usage safer in rpt_file_list
The page https://proj.goldencode.com/projects/p2j/wiki/Chapter_10_Reporting was updated to reflect the changes in the... Vladimir Tsichevski
11:55 AM Database Feature #4155: remove conversion dependency on metadata .df file
FWD currently parses a metadata @.df@ file exported from the data dictionary as part of early schema dictionary proce... Eric Faulhaber
11:45 AM Database Feature #4155 (WIP): remove conversion dependency on metadata .df file
Eric Faulhaber
09:40 AM Database Feature #3816: table and table handle parameter options
Ovidiu Maxiniuc wrote:
> Can you add more detail? Why is it incorrect?
See the changes in 4124a rev 11384. The ide...
Constantin Asofiei
09:26 AM Database Feature #3816: table and table handle parameter options
Can you add more detail? Why is it incorrect? Ovidiu Maxiniuc
02:42 AM Database Feature #3816: table and table handle parameter options
The current approach with datasets, where a @OUTPUT dsHandle BY-REFERENCE@ argument is passed to a @OUTPUT DATASET@ p... Constantin Asofiei
07:18 AM Conversion Tools Bug #4154: NPE in ENABLE ALL
h2. Analysis
The NPE arises while the resulting XML is generated. It is caused by a badly formed "note" annotation...
Vladimir Tsichevski
06:37 AM Conversion Tools Bug #4154: NPE in ENABLE ALL
h2. The problem
For the following 4gl code conversion throws @NullPointerException@:...
Vladimir Tsichevski

07/25/2019

03:30 PM User Interface Bug #3889: incorrect initial widget and screen values for combo boxes and selection lists
> I have noticed that the INT values work for the SIMPLE and DROP_DOWN combo-boxes, despite the fact that in Progress... Greg Shah
12:52 PM User Interface Bug #3889: incorrect initial widget and screen values for combo boxes and selection lists
I made some tests onto which I ran revision 11322 of branch 3690a. By now, I have included all combo-box sub-types: D... Adrian Lungu
03:08 PM Conversion Tools Bug #4151: make databaseMode usage safer in rpt_file_list
The task branch 4151a has been committed into the trunk as bzr revision 11327. Vladimir Tsichevski
02:03 PM Conversion Tools Bug #4151: make databaseMode usage safer in rpt_file_list
Please merge 4151a to trunk.
You will need to make some edits to the documentation as well, but make sure that it ...
Greg Shah
02:01 PM Conversion Tools Bug #4151: make databaseMode usage safer in rpt_file_list
> AFAIR, with the introduction of the code analytics feature set, this rule set is no longer used.
This ruleset a...
Greg Shah
01:59 PM Conversion Tools Bug #4151: make databaseMode usage safer in rpt_file_list
Code Review Task Branch 4151a Revision 11327
I'm good with the changes.
Greg Shah
12:47 PM Database Feature #3816: table and table handle parameter options
Stanislav Lomany wrote:
> # When a temp-table is defined as @REFERENCE-ONLY@, it cannot be used until it is initiali...
Marian Edu
11:15 AM Database Feature #3816: table and table handle parameter options
Stanislav Lomany wrote:
> I like the idea of a buffer being mutable, because it solves all of the issues above. An...
Eric Faulhaber
06:05 AM Runtime Infrastructure Feature #3819: PROFILER system handle
> Sorry, forgot to mention those, they are already up on bazaar. An output file for each test.
Good. Those must b...
Greg Shah
02:58 AM Runtime Infrastructure Feature #3819: PROFILER system handle
Greg Shah wrote:
> Robert:
>
> Can you please capture the recorded profiler output for each of the testcases? Th...
Robert-Adrian Chelaru
05:24 AM Conversion Tools Bug #4154 (Closed): NPE in ENABLE ALL
Vladimir Tsichevski
12:26 AM Base Language Feature #3853: implement LOG-MANAGER runtime
I have made few tests who are described below:
NOTE: some procedures will generate a .log file with same name - for ...
Mihai Popescu-Tiganea

07/24/2019

06:38 PM Database Feature #3815: more temp-table options
> How much time do you expect is needed to resolve this open item?
I need to take a look again. If it's only about...
Stanislav Lomany
04:53 PM Database Feature #3815: more temp-table options
> Please put a TODO in Text.assign(clob) for this and come back to it after the merge.
Unless there is a specific ...
Greg Shah
04:52 PM Database Feature #3815: more temp-table options
Stanislav Lomany wrote:
> > Stanislav, what information do you need from the NEW SHARED TEMP-TABLE definition which ...
Greg Shah
06:13 PM Database Feature #3809: ProDataSet support
I fixed support for FILL operations with a DATA-SOURCE having a provided query.
Also improved camel-casing support f...
Ovidiu Maxiniuc
11:35 AM Database Feature #3809: ProDataSet support
Constantin Asofiei wrote:
> Ovidiu, there is other issue for DATA-RELATION and DATA-SOURCE: when attaching a DATA-SO...
Ovidiu Maxiniuc
11:34 AM Database Feature #3809: ProDataSet support
Related to the legacy field names changes: I have some cases where a PreselectQuery gets converted to RandomAccessQue... Constantin Asofiei
11:31 AM Database Feature #3809: ProDataSet support
Ovidiu, there is other issue for DATA-RELATION and DATA-SOURCE: when attaching a DATA-SOURCE, this may or may not hav... Constantin Asofiei
05:43 AM Database Feature #3809: ProDataSet support
Ovidiu Maxiniuc wrote:
> Please see r11369 from branch 4124a. All annotation for historical names of fields, tables ...
Constantin Asofiei
05:11 PM Runtime Infrastructure Feature #3819: PROFILER system handle
Robert:
Can you please capture the recorded profiler output for each of the testcases? These should be checked in...
Greg Shah
03:20 PM Conversion Tools Bug #4151: make databaseMode usage safer in rpt_file_list
Greg Shah wrote:
> Eric: You put in the @databaseMode@. What do you think?
I'm pretty sure I've never touched ...
Eric Faulhaber
01:29 PM Database Feature #3816: table and table handle parameter options
> Marian: It would be great if your team would write these specs.
While these specs are in progress I suppose we c...
Stanislav Lomany
05:53 AM Database Feature #3816: table and table handle parameter options
Greg Shah wrote:
> > It would have been better to start by crafting some implementation specs not just writing test-...
Greg Shah
05:52 AM Database Feature #3816: table and table handle parameter options
> It would have been better to start by crafting some implementation specs not just writing test-cases although test-... Greg Shah
05:39 AM Database Feature #3816: table and table handle parameter options
Marian Edu wrote:
> It would have been better to start by crafting some implementation specs not just writing test-c...
Constantin Asofiei
05:35 AM Database Feature #3816: table and table handle parameter options
Greg Shah wrote:
> Do I understand correctly that BIND would only have a useful effect when stored as a resource of ...
Marian Edu
05:26 AM Database Feature #3816: table and table handle parameter options
> BIND is also like BY-REFERENCE only that the object you have as REFERENCE-ONLY remains bound to the object received... Greg Shah
04:55 AM Database Feature #3816: table and table handle parameter options
Constantin Asofiei wrote:
> Marian Edu wrote:
> > All this should be covered by tests in @io@ folder for dataset an...
Marian Edu
10:00 AM User Interface Bug #3690: BUTTON widget reaction on SPACEBAR and ENTER keys
I think it makes sense to split these changes. Please merge the 11320 and 11321 revisions into 4045a.
Then create...
Greg Shah
08:35 AM User Interface Bug #3690: BUTTON widget reaction on SPACEBAR and ENTER keys
Indeed, revision 11321 was meant to fully fix bug #3690, while revision 11322 is still work in progress. There should... Adrian Lungu

07/23/2019

04:50 PM Database Feature #3809: ProDataSet support
Constantin Asofiei wrote:
> When serializing a DATASET or TABLE to JSON/XML, we need to keep the legacy field names ...
Ovidiu Maxiniuc
04:23 PM User Interface Bug #3690: BUTTON widget reaction on SPACEBAR and ENTER keys
Code review 3690a revisions 11321 and 11322. I'm good with the changes. Just please remove the commented out code in ... Hynek Cihlar
10:17 AM User Interface Bug #3690: BUTTON widget reaction on SPACEBAR and ENTER keys
Yes, revision 11321 of 3690a fixes the points mentioned and it is ready for review. Last reviewed revision was 11320. Adrian Lungu
10:05 AM User Interface Bug #3690: BUTTON widget reaction on SPACEBAR and ENTER keys
Adrian, do the changes in 3690a revision 11321 represent your fixes for the code review items? If so, is it ready fo... Greg Shah
04:23 PM Conversion Tools Bug #4151 (Review): make databaseMode usage safer in rpt_file_list
Vladimir Tsichevski
04:21 PM Conversion Tools Bug #4151: make databaseMode usage safer in rpt_file_list
The changes are as follows:
# only the root AST node is now tested for the condition;
# the databaseMode comamnd-...
Vladimir Tsichevski
11:28 AM Base Language Feature #3810: SECURITY-POLICY and other security features
Constantin Asofiei wrote:
> This code in @SecurityPolicyManager.setClient@, with @LOGIN@ state:
> [...]
> FWD rais...
Igor Skornyakov
11:23 AM Base Language Feature #3810: SECURITY-POLICY and other security features
Igor Skornyakov wrote:
> Constantin Asofiei wrote:
> > Igor, does @set-client@ really fail if trying to login while...
Constantin Asofiei
11:21 AM Base Language Feature #3810: SECURITY-POLICY and other security features
Constantin Asofiei wrote:
> Igor, does @set-client@ really fail if trying to login while the DB is already connected...
Igor Skornyakov
10:56 AM Base Language Feature #3810: SECURITY-POLICY and other security features
Igor, does @set-client@ really fail if trying to login while the DB is already connected? Constantin Asofiei
10:02 AM User Interface Bug #3889: incorrect initial widget and screen values for combo boxes and selection lists
Code Review Task Branch 3690a Revision 11322
1. For @ComboBoxWidget@, @GenericWidget@ and @GenericFrame@, we know...
Greg Shah
03:48 AM Database Feature #2156: datetime-tz and hibernate
Eric Faulhaber wrote:
> In @DBUtils@, the mapping for @datetimetz@ is now set to @new CustomType(new DatetimeUserTyp...
Constantin Asofiei
03:38 AM Database Feature #3816: table and table handle parameter options
Marian Edu wrote:
> All this should be covered by tests in @io@ folder for dataset and table.
Do you have tests for...
Constantin Asofiei
12:32 AM Database Feature #3816: table and table handle parameter options
Constantin Asofiei wrote:
> There's one more case I need to fix: TABLE-HANDLE passed as OUTPUT argument for a TABLE ...
Marian Edu

07/22/2019

07:47 PM Database Feature #2156: datetime-tz and hibernate
Code review 4124a/11361 (of changes related to @datetimetz@ UDF implementation only):
A creative solution to a dif...
Eric Faulhaber
02:08 PM Database Feature #2156: datetime-tz and hibernate
Greg Shah wrote:
> Is there any remaining work on this task or is the fix just a partial or a workaround?
The only ...
Constantin Asofiei
02:07 PM Database Feature #2156: datetime-tz and hibernate
Is there any remaining work on this task or is the fix just a partial or a workaround? Greg Shah
11:42 AM Database Feature #2156: datetime-tz and hibernate
The fix is in 4124a rev 11361. Constantin Asofiei
09:42 AM Database Feature #2156: datetime-tz and hibernate
So, in the end I'm sending full string and refactoring the argument to be a ISO character date instead of @datetimetz... Constantin Asofiei
07:30 AM Database Feature #2156: datetime-tz and hibernate
Greg Shah wrote:
> Doe the current customer data actually use different offsets?
I don't know. But I'm changing the...
Constantin Asofiei
06:48 AM Database Feature #2156: datetime-tz and hibernate
Doe the current customer data actually use different offsets? Greg Shah
04:29 AM Database Feature #2156: datetime-tz and hibernate
Constantin Asofiei wrote:
> Next step is to try and add versions which have a @java.sql.ResultSet@ as first argument...
Constantin Asofiei
03:55 AM Database Feature #2156: datetime-tz and hibernate
I'm at a loss; PL/Java maps @anyarray@ postgresql to @Object[]@ (according to this @https://github.com/tada/pljava/wi... Constantin Asofiei
01:17 AM Database Feature #2156: datetime-tz and hibernate
Eric Faulhaber wrote:
> No. What does the @180@ parameter represent?
That is the offset.
> Doesn't the string al...
Constantin Asofiei
08:02 PM Database Feature #2156: datetime-tz and hibernate
Constantin Asofiei wrote:
> I have this working for H2, but not working for PostgreSQL. The definition in @Operator...
Eric Faulhaber
06:31 PM Database Feature #3816: table and table handle parameter options
There's one more case I need to fix: TABLE-HANDLE passed as OUTPUT argument for a TABLE parameter, without using BY-R... Constantin Asofiei
11:42 AM Database Feature #3816: table and table handle parameter options
My fixes are in 4124a rev 11361. Constantin Asofiei
10:32 AM Database Feature #3816: table and table handle parameter options
Constantin wrote:
> we need good tests for BY-REFERENCE, TABLE, TABLE-HANDLE, DATASET, DATASET-HANDLE when combine...
Greg Shah
04:54 PM Conversion Tools Bug #4151: make databaseMode usage safer in rpt_file_list
> It also may make sense to check for srcfile on the root node. If it exists there, use it else use file.
Agreed. ...
Vladimir Tsichevski
02:03 PM Conversion Tools Bug #4151: make databaseMode usage safer in rpt_file_list
It also may make sense to check for @srcfile@ on the @root@ node. If it exists there, use it else use @file@. Greg Shah
02:02 PM Conversion Tools Bug #4151: make databaseMode usage safer in rpt_file_list
That sounds reasonable.
Eric: You put in the @databaseMode@. What do you think?
Greg Shah
01:39 PM Conversion Tools Bug #4151: make databaseMode usage safer in rpt_file_list
The right thing will be to change the script logic as follows:
# if the "srcfile" annotation is defined for a node...
Vladimir Tsichevski
11:26 AM Conversion Tools Bug #4151 (WIP): make databaseMode usage safer in rpt_file_list
Vladimir Tsichevski
10:58 AM Conversion Tools Bug #4151: make databaseMode usage safer in rpt_file_list
There are 2 sources of "database" ASTs:
* @.df@ files which are the schemata for databases
* static temp-table de...
Greg Shah
10:41 AM Conversion Tools Bug #4151: make databaseMode usage safer in rpt_file_list
If the @databaseMode="true"@ is used when running the @reports/rpt_file_list@ report, and not a @*.schema@ AST source... Vladimir Tsichevski
09:59 AM Conversion Tools Bug #4151 (Closed): make databaseMode usage safer in rpt_file_list
Vladimir Tsichevski
11:45 AM Database Feature #3809: ProDataSet support
When serializing a DATASET or TABLE to JSON/XML, we need to keep the legacy field names (and table names) in the same... Constantin Asofiei

07/21/2019

07:31 PM Database Feature #3809: ProDataSet support
Constantin Asofiei wrote:
> The structure of the indexes for a table in the JavaOpenClient is described here: https:...
Ovidiu Maxiniuc
01:13 PM Database Feature #3809: ProDataSet support
The structure of the indexes for a table in the JavaOpenClient is described here: https://documentation.progress.com/... Constantin Asofiei
10:23 AM Database Feature #3809: ProDataSet support
Constantin Asofiei wrote:
> Ovidiu, why is this code in BufferImpl.fill being called for each record you add in the ...
Ovidiu Maxiniuc
07:26 AM Database Feature #3809: ProDataSet support
Ovidiu, why is this code in BufferImpl.fill being called for each record you add in the parent buffer? Because the ch... Constantin Asofiei
07:14 PM Database Feature #2156: datetime-tz and hibernate
I have this working for H2, but not working for PostgreSQL. The definition in @Operators.java@ is:... Constantin Asofiei
06:37 PM Database Feature #2156: datetime-tz and hibernate
Greg Shah wrote:
> I thought we also had issues with the @DatetimeTzUserType@ not yet being implemented for multiple...
Eric Faulhaber
05:32 PM Database Feature #2156: datetime-tz and hibernate
I thought we also had issues with the @DatetimeTzUserType@ not yet being implemented for multiple columns. However, ... Greg Shah
05:07 PM Database Feature #2156: datetime-tz and hibernate
The simple test which shows that FWD doesn't work yet with datetime-tz is this:... Constantin Asofiei
01:42 PM Database Feature #3816: table and table handle parameter options
Constantin Asofiei wrote:
> And I need to add the same approach for TABLE-HANDLE parameters with BY-REFERENCE argume...
Constantin Asofiei
12:27 PM Database Feature #3816: table and table handle parameter options
And I need to add the same approach for TABLE-HANDLE parameters with BY-REFERENCE arguments. Constantin Asofiei
12:12 PM Database Feature #3816: table and table handle parameter options
I think I have a fix for BY-REFERENCE issues I had; kind of a hack (do not delete a handle holding a DATASET, if the... Constantin Asofiei

07/20/2019

08:44 AM Database Feature #3809: ProDataSet support
After fixing #3860-63, to allow runtime-specification of default databases per a project, I get a validation exceptio... Constantin Asofiei
08:38 PM Database Feature #3809: ProDataSet support
I've placed some notes to #3816-34, #3816-35, #3816-36, as that task handles @BY-REFERENCE@ (only for tables). But t... Constantin Asofiei
08:44 AM Database Feature #3816: table and table handle parameter options
Constantin Asofiei wrote:
> To continue with previous notes, as it may be related to @TABLE-HANDLE@, too: I think a ...
Constantin Asofiei
05:57 AM Database Feature #3816: table and table handle parameter options
To continue with previous notes, as it may be related to @TABLE-HANDLE@, too: I think a @DELETE@ for a @DATASET-HANDL... Constantin Asofiei
08:36 PM Database Feature #3816: table and table handle parameter options
The static dataset delete was just a minor issue. Even if I'm assuming that INPUT-OUTPUT behaves the same as BY-REFE... Constantin Asofiei

07/19/2019

07:56 PM Database Feature #3816: table and table handle parameter options
Looks like this states that the 'delete will not happen if the DATASET is not owned by the procedure attempting the d... Constantin Asofiei
07:20 PM Database Feature #3816: table and table handle parameter options
I found in a project code like this:... Constantin Asofiei
01:13 PM Database Feature #3816: table and table handle parameter options
Stanislav Lomany wrote:
> Guys, I'm interested, how technically we can pass a table parameter by reference? In this ...
Eric Faulhaber
08:55 PM Database Feature #3816: table and table handle parameter options
Guys, I'm interested, how technically we can pass a table parameter by reference? In this case 4GL passes the default... Stanislav Lomany
05:58 PM Database Feature #3809: ProDataSet support
Ovidiu Maxiniuc wrote:
> Constantin Asofiei wrote:
> > Ovidiu, as we discussed, I need NEXT-ROWID, BATCH-SIZE and R...
Ovidiu Maxiniuc
02:46 PM Database Feature #3809: ProDataSet support
The other part which I need is dynamic construction of a DATA-SET from a DataSetContainer received from a remote side... Constantin Asofiei
09:53 AM Database Feature #3809: ProDataSet support
Constantin Asofiei wrote:
> Ovidiu, as we discussed, I need NEXT-ROWID, BATCH-SIZE and RESTART-ROWID to work.
I s...
Ovidiu Maxiniuc
09:05 AM Database Feature #3809: ProDataSet support
Ovidiu, as we discussed, I need NEXT-ROWID, BATCH-SIZE and RESTART-ROWID to work. Constantin Asofiei
10:43 AM Base Language Feature #3817: create resource bundles from string literals and implement optional support for se...
FYI, the "Possenet":/projects/p2j/wiki/Downloads#Possenet-Open-Source-Files code that we use does seem to have a (old... Greg Shah

07/18/2019

07:54 AM Runtime Infrastructure Feature #3819: PROFILER system handle
For Profiler:Attributes we have the following structure
Files which are simply named by the attribute (ex: descrip...
Robert-Adrian Chelaru
05:04 AM Build and Source Control Feature #4147: Improve Gradle build for offline use
With the new lib layout some jar files will be duplicated (cca 100 MB of duplicated size). Unfortunately zip doesn't ... Hynek Cihlar
04:55 AM Build and Source Control Feature #4147: Improve Gradle build for offline use
I created task branch 4147a from version FWD 3.2.0 (trunk revision 11281). Checked in "Fix to allow locale definition... Hynek Cihlar

07/17/2019

06:44 PM Build and Source Control Feature #4147: Improve Gradle build for offline use
I'm good with the changes. Greg Shah
05:35 PM Build and Source Control Feature #4147: Improve Gradle build for offline use
Hynek Cihlar wrote:
> Another version of @build.gradle@ attached.
And the file.
Hynek Cihlar
05:35 PM Build and Source Control Feature #4147: Improve Gradle build for offline use
Another version of @build.gradle@ attached. I added the task @fetchGradle@ which will fetch the Gradle distribution t... Hynek Cihlar
04:59 PM Build and Source Control Feature #4147: Improve Gradle build for offline use
The ideas above are implemented in the attached @build.gradle@. The changes are based on the FWD version 3.2.0. The c... Hynek Cihlar
04:46 PM Base Language Feature #2135: implement COPY-LOB language statement
Eric, when COPY-LOB uses as target an uninitialized memptr (unknown) or if its size doesn't fit the source, then the ... Constantin Asofiei
05:28 AM Base Language Feature #3810: SECURITY-POLICY and other security features
Constantin Asofiei wrote:
> This is something which I think is expected to be maintained post-conversion. So I don'...
Igor Skornyakov
05:04 AM Base Language Feature #3810: SECURITY-POLICY and other security features
From Igor #4121-154:
> Sorry, I have missed this issue before. The reason is that there are no _SEC_AUTHENTICATION_S...
Constantin Asofiei
08:24 PM Database Feature #3816: table and table handle parameter options
> Temp-tables declared as REFERENCE-ONLY are initialized in FWD as usual buffers (i.e. StaticTempTable is created and... Greg Shah

07/16/2019

07:30 PM Base Language Bug #4149: BlockManager and TransactionManager handle TransactionType.NONE incorrectly
There are 3 major issues that need attention:
* @TransactionManager@ does not protect many registrations or notifi...
Greg Shah
06:30 PM Base Language Bug #4149 (New): BlockManager and TransactionManager handle TransactionType.NONE incorrectly
Greg Shah
05:28 PM Database Feature #3816: table and table handle parameter options
Some thoughts about BIND:
# Temp-tables declared as @REFERENCE-ONLY@ are initialized in FWD as usual buffers (i.e. @...
Stanislav Lomany
01:33 PM User Interface Bug #3691: literal $ character in format appears on the right side of the fill-in
Task branch 4130a was rebased from trunk rev 11326. The latest revision is now 11327. Greg Shah
12:52 PM User Interface Bug #3691: literal $ character in format appears on the right side of the fill-in
I am going to rebase 4130a now. Do not make any changes to 4130a. Greg Shah
12:52 PM User Interface Bug #3691: literal $ character in format appears on the right side of the fill-in
Code Review Task Branch 4130a Revision 11321 and 11322
I've fixed the issues in items 1 and 2 as revision 11323.
...
Greg Shah
11:17 AM User Interface Bug #3691: literal $ character in format appears on the right side of the fill-in
after uncommitting, branch 4130a got into inconsistent state. So I recreate all changes of the branch 4130a in the br... Alexei Kaigorodov
09:44 AM User Interface Bug #3691: literal $ character in format appears on the right side of the fill-in
Code Review Task Branch 4130a Revisions 11324 and 11325
Functionally, I'm OK with trying these changes.
1. Plea...
Greg Shah
09:07 AM User Interface Bug #3691: literal $ character in format appears on the right side of the fill-in
As noted previously, you MUST NOT merge changes from trunk into your branch. We have a very specific rebasing proces... Greg Shah
07:28 AM User Interface Bug #3691: literal $ character in format appears on the right side of the fill-in
changed the fix to ArrayIndexOutOfBoundsException, now all uast/format_string tests passed. I pushed all fixes relate... Alexei Kaigorodov
10:19 AM Base Language Feature #3751: implement support for OO 4GL and structured error handling
>> 3. NullStream has some new imports that are not needed.
>
> I just reverted NullStream.java to its previous stat...
Greg Shah
10:07 AM Base Language Feature #3751: implement support for OO 4GL and structured error handling
Greg Shah wrote:
> Code Review Task Branch 4124a Revision 11338
>
> This looks good. Minor notes:
>
> 1. @Str...
Hynek Cihlar
09:59 AM Base Language Feature #3751: implement support for OO 4GL and structured error handling
Code Review Task Branch 4124a Revision 11338
This looks good. Minor notes:
1. @StreamFactory@ has changes in t...
Greg Shah
07:40 AM Base Language Feature #3751: implement support for OO 4GL and structured error handling
Greg Shah wrote:
> * A context local map of the name to @StreamWrapper@ instances.
> * A way to lookup the @RemoteS...
Hynek Cihlar
10:14 AM Base Language Bug #4148: Passing HANDLE to method with TABLE-HANDLE or DATASET-HANDLE converts to uncompilable ...
The subjected test case:... Hynek Cihlar
10:12 AM Base Language Bug #4148 (New): Passing HANDLE to method with TABLE-HANDLE or DATASET-HANDLE converts to uncompi...
Hynek Cihlar
10:00 PM Database Feature #4011: database/persistence layer performance improvements
Running the instrumentation added in trunk rev 11323 (#4056) has indicated that common persistence scenarios spend a ... Eric Faulhaber
09:59 PM Database Feature #4016: replace portions of Hibernate which are non-performant
Based on further analysis, including using the persistence instrumentation (#4056), we have decided to remove as much... Eric Faulhaber

07/15/2019

04:40 PM Base Language Feature #3751: implement support for OO 4GL and structured error handling
Code Review Task Branch 4124a Revision 11335
The JSON changes are fine.
The changes related to @Implemented str...
Greg Shah
10:14 AM Base Language Feature #3751: implement support for OO 4GL and structured error handling
Hynek Cihlar wrote:
> Additional fixes for the json legacy classes checked in to 4124a revision 11335. No more chang...
Hynek Cihlar
04:13 PM Database Bug #4035 (Closed): newly created record is not flushed at the right time
4035a/11327 passed main regression testing and ETF. I rebased to trunk rev 11325, merged to trunk, and committed as t... Eric Faulhaber
11:00 PM Database Bug #4035: newly created record is not flushed at the right time
To summarize the idea:
* Any FOR BLOCK or FOR LOOP causes a special aggressive flushing mode to occur when all the...
Greg Shah
10:44 PM Database Bug #4035: newly created record is not flushed at the right time
Code Review Task Branch 4035a Revision 11327
I'm OK with the changes. I think they accurately implement the behav...
Greg Shah
10:11 PM Database Bug #4035: newly created record is not flushed at the right time
Greg, aggressive buffer flush mode support was added in 4035a/11327. It fixes the @buf1.p@/@buf2.p@ test case and fix... Eric Faulhaber
10:22 AM Database Feature #3816: table and table handle parameter options
After I've rebased to the latest trunk, the errors of the following type occur:... Stanislav Lomany
07:55 AM User Interface Bug #3691: literal $ character in format appears on the right side of the fill-in
I added format and data to recreate a situation when @missing>0@. This caused an @ArrayIndexOutOfBoundsException@ in... Alexei Kaigorodov
06:48 AM Base Language Feature #3817: create resource bundles from string literals and implement optional support for se...
Hi Greg,
there is a small issue we have with this one, we do not have any licenses for the 'translation manager/vi...
Marian Edu
06:12 AM Base Language Feature #3810: SECURITY-POLICY and other security features
this is for for version 11.7.4, there are changes from one version to another from time to time... don't have a 'hist... Marian Edu
06:10 AM Base Language Feature #3810: SECURITY-POLICY and other security features
Constantin Asofiei wrote:
> Marian, please export the meta tables from your machine and commit it to the @db/@ folde...
Marian Edu

07/14/2019

07:44 PM Database Feature #3809: ProDataSet support
Ovidiu, please look at 4124a rev 11336 - it fixes the DatasetContainer so that it works with appserver calls. Constantin Asofiei
04:04 PM Base Language Feature #3751: implement support for OO 4GL and structured error handling
Additional fixes for the json legacy classes checked in to 4124a revision 11335. No more changes for the json legacy ... Hynek Cihlar
04:19 AM Database Feature #3816: table and table handle parameter options
Rebased task branch 3816a from P2J trunk revision 11325. Stanislav Lomany

07/13/2019

01:53 PM Base Language Feature #3751: implement support for OO 4GL and structured error handling
As a side-note: this might be a side-effect of using builtin/skeleton classes; anyway, I'd like not to spend time fix... Constantin Asofiei
01:51 PM Base Language Feature #3751: implement support for OO 4GL and structured error handling
Hynek Cihlar wrote:
> I'm trying to test the @JsonArray.Read(TABLE-HANDLE)@ method, but can't get my test case conve...
Constantin Asofiei
01:30 PM Base Language Feature #3751: implement support for OO 4GL and structured error handling
I'm trying to test the @JsonArray.Read(TABLE-HANDLE)@ method, but can't get my test case converted. It works in OpenE... Hynek Cihlar
03:11 AM Base Language Feature #3751: implement support for OO 4GL and structured error handling
Greg Shah wrote:
> Code Review Task Branch 4124a Revision 11328
>
> Client side streams cannot be serialized to t...
Hynek Cihlar
06:27 AM Database Feature #3809: ProDataSet support
4124a rev 11333 fixes a naming issue with DATASET or TABLE parameters, when the source is in a super-class: for DATAS... Constantin Asofiei

07/12/2019

06:44 PM Base Language Feature #3751: implement support for OO 4GL and structured error handling
Code Review Task Branch 4124a Revision 11328
Client side streams cannot be serialized to the server. Instead, on ...
Greg Shah
04:31 PM Base Language Feature #3751: implement support for OO 4GL and structured error handling
Greg Shah wrote:
> Actually, I see you added a @StreamDaemon.findStream(String name)@ helper. Instead of exposing t...
Hynek Cihlar
02:45 PM Base Language Feature #3751: implement support for OO 4GL and structured error handling
Hynek, please commit all other fixes related to JSON support to 4124a; I plan to rebase it, so please wait for the no... Constantin Asofiei
11:18 AM Base Language Feature #3751: implement support for OO 4GL and structured error handling
Actually, I see you added a @StreamDaemon.findStream(String name)@ helper. Instead of exposing this from @ThinClient... Greg Shah
11:13 AM Base Language Feature #3751: implement support for OO 4GL and structured error handling
Code Review Task Branch 3809c Revisions 11383 and 11378
Everything seems OK except 1 important thing: these classe...
Greg Shah
10:24 AM Base Language Feature #3751: implement support for OO 4GL and structured error handling
Please review 3809c revisions 11383 and 11378. This implements the @read@ and @writeStream@ methods for json legacy c... Hynek Cihlar
04:42 PM Database Feature #3809: ProDataSet support
3809d was merged to 4124a rev 11329 and dead-archived. Constantin Asofiei
02:42 PM Database Feature #3809: ProDataSet support
Branch 3809c passed MAJIC testing and was merged to trunk rev 11325, and archived. It contains changes:
* OM: many ...
Constantin Asofiei
02:21 PM Database Feature #3809: ProDataSet support
Please merge 3809c to trunk. Greg Shah
02:02 PM Database Feature #3809: ProDataSet support
Runtime testing (main part) passed with 3809c rev 11382. Constantin Asofiei
11:02 AM User Interface Bug #3691: literal $ character in format appears on the right side of the fill-in
@missing > 0@ is being used to track the condition where all of the following are true:
* the result must be right...
Greg Shah
08:35 AM User Interface Bug #3691: literal $ character in format appears on the right side of the fill-in
Greg Shah wrote:
> Please fix it as well. Use 4130a as the branch.
I found the reason of the wrong alignment:
...
Alexei Kaigorodov
10:46 AM Base Language Feature #3810: SECURITY-POLICY and other security features
OK, so we need the matching metadata schema to be checked in to the testcases project as per the request in #3810-328... Greg Shah
10:05 AM Base Language Feature #3810: SECURITY-POLICY and other security features
Greg Shah wrote:
> Is this caused by differences between the version of the metadata schema used in conversion as co...
Igor Skornyakov
09:57 AM Base Language Feature #3810: SECURITY-POLICY and other security features
Igor Skornyakov wrote:
> Greg Shah wrote:
> >
> > Do we need any protection code and does the feature fail the sa...
Greg Shah
02:24 AM Database Feature #4056: instrument FWD and supporting libraries to measure database performance
Branch 4056a was merged to trunk revision 11323. It passed ChUI conversion and runtime regression testing (the latter... Eric Faulhaber

07/11/2019

03:53 PM Database Bug #4035: newly created record is not flushed at the right time
Eric Faulhaber wrote:
> Yes, it works if ALL indexed fields are updated after the second create book.
Even if you e...
Constantin Asofiei
03:45 PM Database Bug #4035: newly created record is not flushed at the right time
Yes, it works if ALL indexed fields are updated after the second @create book@.
However, I'm not sure that forcing...
Eric Faulhaber
03:20 PM Database Bug #4035: newly created record is not flushed at the right time
Eric Faulhaber wrote:
> Constantin Asofiei wrote:
> > Eric, some thoughts: for indexed fields, maybe we should assu...
Constantin Asofiei
03:17 PM Database Bug #4035: newly created record is not flushed at the right time
Constantin Asofiei wrote:
> Eric, some thoughts: for indexed fields, maybe we should assume that when a (sub)tx bloc...
Eric Faulhaber
03:10 PM Database Bug #4035: newly created record is not flushed at the right time
Eric, some thoughts: for indexed fields, maybe we should assume that when a (sub)tx block iterates, its indexed field... Constantin Asofiei
03:05 PM Database Bug #4035: newly created record is not flushed at the right time
Greg Shah wrote:
> Are the buffer scopes the same as the converted code? Based on what you told me previously, the ...
Eric Faulhaber
02:56 PM Database Bug #4035: newly created record is not flushed at the right time
Are the buffer scopes the same as the converted code? Based on what you told me previously, the transaction scoping ... Greg Shah
02:53 PM Database Bug #4035: newly created record is not flushed at the right time
Here are the compile listings for the test cases above (note: I have renamed them to @flush-buf1.p@ and @flush-buf2.p... Eric Faulhaber
02:51 PM Database Feature #3809: ProDataSet support
Greg Shah wrote:
> > The problem is time and the fact that the mapping are to PPTT constants, which started to be ve...
Ovidiu Maxiniuc
02:44 PM Database Feature #3809: ProDataSet support
If the branch passes ChUI regression testing, I am good with it being merged to trunk. Eric Faulhaber
02:26 PM Database Feature #3809: ProDataSet support
> The problem is time and the fact that the mapping are to PPTT constants, which started to be very cryptic. I will p... Greg Shah
02:19 PM Database Feature #3809: ProDataSet support
Greg Shah wrote:
> Code Review Task Branch 3809c Revisions 11325 through 11380
> I only reviewed the changes in @ut...
Ovidiu Maxiniuc
01:57 PM Database Feature #3809: ProDataSet support
Eric Faulhaber wrote:
> Code review task branch 3809c, rev 11326-11375 (part 4):
> @RecordBuffer@:
>
> * Please ...
Ovidiu Maxiniuc
01:57 PM Database Feature #3809: ProDataSet support
Code Review Task Branch 3809c Revisions 11325 through 11380
I only reviewed the changes in @util/@ and @uast/@. I...
Greg Shah
01:10 PM Database Feature #3809: ProDataSet support
Ovidiu, FYI, I have committed in rev 11380 some very minor format and typo cleanups that I made inline during my code... Eric Faulhaber
10:39 AM Database Feature #3809: ProDataSet support
Eric Faulhaber wrote:
> Code review task branch 3809c, rev 11326-11375 (part 3):
>
> @CallbackData@: Should @geTa...
Ovidiu Maxiniuc
01:25 AM Database Feature #3809: ProDataSet support
Performance/Resource Concerns:
As noted earlier, these are things that stood out to me, but I obviously haven't do...
Eric Faulhaber
01:15 AM Database Feature #3809: ProDataSet support
Code review task branch 3809c, rev 11326-11375 (part 4):
@RecordBuffer@:
* Please use proper logging instead of...
Eric Faulhaber
12:07 AM Database Feature #3809: ProDataSet support
Code review task branch 3809c, rev 11326-11375 (part 3):
@CallbackData@: Should @geTarget@ be @getTarget@? It is c...
Eric Faulhaber
01:59 PM Database Feature #3816: table and table handle parameter options
FYI, branch 3809c has significant changes/improvements to table parameter processing (and dataset parameter processin... Greg Shah
10:47 AM Database Feature #3816: table and table handle parameter options
The priority should be on the implementation of conversion and runtime support for the core features listed in #3816-... Greg Shah
09:45 AM Database Feature #3816: table and table handle parameter options
Created task branch 3816a from P2J trunk revision 11324. Stanislav Lomany
09:11 AM Database Feature #3816: table and table handle parameter options
Okay, I fixed NPE and now I can get meaningful results for the testcases. It is about a hundred of testcases. I didn'... Stanislav Lomany
10:22 AM User Interface Bug #3691: literal $ character in format appears on the right side of the fill-in
> I discovered that so called floating-decimal display format in string mode works different in FWD and 4gl:
string(...
Greg Shah
12:52 AM User Interface Bug #3691: literal $ character in format appears on the right side of the fill-in
Greg Shah wrote:
> I am OK with trying the change from @splitFormat@ to @rightAligned@. You can put it into branch ...
Alexei Kaigorodov
06:29 AM Build and Source Control Feature #4147: Improve Gradle build for offline use
Current issues:
* Gradle wrapper or a Gradle distribution must must be downloaded before Gradle build can be run.
...
Hynek Cihlar
05:33 AM Build and Source Control Feature #4147 (Closed): Improve Gradle build for offline use
Hynek Cihlar

07/10/2019

04:25 PM Database Feature #3816: table and table handle parameter options
Good, thank you! @convert/buffer_definitions.rules@ has this variable... Stanislav Lomany
04:13 PM Database Feature #3816: table and table handle parameter options
One has it and the other does not. I've attached my output (I changed the @.p@ names but the code is the same). Greg Shah
03:47 PM Database Feature #3816: table and table handle parameter options
Yes, convert both attached files in a single run and check if @TemporaryBuffer.createDynamicTable@ presents in both c... Stanislav Lomany
03:45 PM Database Feature #3816: table and table handle parameter options
Do you have a standalone testcase I can use? Greg Shah
03:37 PM Database Feature #3816: table and table handle parameter options
Could someone please confirm the issue from the previous note? That it's not an issue with my RAM. Stanislav Lomany
09:47 AM Database Feature #3816: table and table handle parameter options
Consider we have two procedures:... Stanislav Lomany
09:31 PM Database Feature #3816: table and table handle parameter options
There is a procedure @dataset/help/get_tt_num_rows.p@ which is used by pretty much all testcases (which now they are ... Stanislav Lomany
03:28 PM Database Feature #3809: ProDataSet support
Eric Faulhaber wrote:
> @AbstractTempTable@: Why do we override/implement the @readXml@ methods in this abstract cla...
Ovidiu Maxiniuc
02:37 PM Database Feature #3809: ProDataSet support
Eric Faulhaber wrote:
> * Is it necessary for @buffer()@ to be @public@? I went through great pains to keep it @prot...
Hynek Cihlar
02:09 PM Database Feature #3809: ProDataSet support
Code review task branch 3809c, rev 11326-11375 (part 2 - I am not done with the runtime review yet, but I wanted to g... Eric Faulhaber
10:26 AM Database Feature #3809: ProDataSet support
Constantin Asofiei wrote:
> Ovidiu Maxiniuc wrote:
> > Constantin, could you review Hynek's changes?
> I'm OK with...
Hynek Cihlar
09:00 AM Database Feature #3809: ProDataSet support
Ovidiu Maxiniuc wrote:
> Constantin, could you review Hynek's changes?
I'm OK with the OO changes.
Hynek, btw, I...
Constantin Asofiei
07:42 AM Database Feature #3809: ProDataSet support
Eric Faulhaber wrote:
> Code review task branch 3809c, rev 11326-11375 (part 1):
>
> Ovidiu, this is quite an imp...
Ovidiu Maxiniuc
12:20 AM Database Feature #3809: ProDataSet support
Code review task branch 3809c, rev 11326-11375 (part 1):
Ovidiu, this is quite an impressive update! I am still re...
Eric Faulhaber
09:04 AM Base Language Feature #3855: implement equivalent support for REST (classic appserver, PASOE REST and WEB trans...
Constantin Asofiei wrote:
> Marian, another question: any idea what a @HTTP_idContext@ context value means? And what...
Marian Edu
08:43 AM Base Language Feature #3855: implement equivalent support for REST (classic appserver, PASOE REST and WEB trans...
Marian, another question: any idea what a @HTTP_idContext@ context value means? And what @IWebRequest.getContextNames... Constantin Asofiei

07/09/2019

04:35 PM Base Language Feature #3751: implement support for OO 4GL and structured error handling
Hynek Cihlar wrote:
> Constantin Asofiei wrote:
> > Hynek, please test/check the @Progress.Json.Objectmodel.ObjectM...
Constantin Asofiei
04:30 PM Base Language Feature #3751: implement support for OO 4GL and structured error handling
Constantin Asofiei wrote:
> Hynek, please test/check the @Progress.Json.Objectmodel.ObjectModelParser@ implementatio...
Hynek Cihlar
03:49 PM Base Language Feature #3751: implement support for OO 4GL and structured error handling
Hynek, please test/check the @Progress.Json.Objectmodel.ObjectModelParser@ implementation. Constantin Asofiei
03:27 PM Base Language Feature #3855: implement equivalent support for REST (classic appserver, PASOE REST and WEB trans...
Marian, please commit the SoapUI text log for the FWDHandler tests. Constantin Asofiei
02:10 PM User Interface Bug #3691: literal $ character in format appears on the right side of the fill-in
I am OK with trying the change from @splitFormat@ to @rightAligned@. You can put it into branch 4130a. Does it fix ... Greg Shah
11:42 AM User Interface Bug #3691: literal $ character in format appears on the right side of the fill-in
Greg Shah wrote:
> Yes, you are looking at the wrong process. As noted in #3691-67:
>
> > As discussed in the "...
Alexei Kaigorodov
09:42 AM User Interface Bug #3691: literal $ character in format appears on the right side of the fill-in
Yes, you are looking at the wrong process. As noted in #3691-67:
> As discussed in the "Runtime Architecture":/p...
Greg Shah
09:37 AM User Interface Bug #3691: literal $ character in format appears on the right side of the fill-in
Greg Shah wrote:
> No. Are you debugging the FWD client?
I an debugging the FWD server.
Alexei Kaigorodov
09:35 AM User Interface Bug #3691: literal $ character in format appears on the right side of the fill-in
No. Are you debugging the FWD client? Greg Shah
09:27 AM User Interface Bug #3691: literal $ character in format appears on the right side of the fill-in
Greg Shah wrote:
> Set breakpoints in @FillIn.processKeyEvent()@ and @FillIn.draw()@. Then follow the event process...
Alexei Kaigorodov
09:22 AM User Interface Bug #3691: literal $ character in format appears on the right side of the fill-in
Set breakpoints in @FillIn.processKeyEvent()@ and @FillIn.draw()@. Then follow the event processing flow through the... Greg Shah
09:08 AM User Interface Bug #3691: literal $ character in format appears on the right side of the fill-in
Greg Shah wrote:
> Look deeper that this set of classes. Look at @DisplayFormat.Presentation@.
I set breakpoin...
Alexei Kaigorodov
05:28 AM User Interface Bug #3691: literal $ character in format appears on the right side of the fill-in
> Debugger stops at these breakpoints when the window is prepared, but does not stops when I edit the input fields.
...
Greg Shah
02:55 AM User Interface Bug #3691: literal $ character in format appears on the right side of the fill-in
Greg Shah wrote:
> > They work while the window is initialized bot does not work when I edit the content of the fiel...
Alexei Kaigorodov
07:23 AM Database Feature #3809: ProDataSet support
Constantin Asofiei wrote:
> Ovidiu, please work with high priority on DATASET support for appserver - follow how @Ta...
Ovidiu Maxiniuc
07:22 AM Database Feature #3809: ProDataSet support
Ovidiu, please work with high priority on DATASET support for appserver - follow how @TableResultSet@ and @TableWrapp... Constantin Asofiei
04:25 AM Database Feature #3809: ProDataSet support
I've started the rebase process to latest trunk. Thanks for notifying me. I was about to overwrite your revision. Ovidiu Maxiniuc
04:23 AM Database Feature #3809: ProDataSet support
Ovidiu Maxiniuc wrote:
> BTW: Hynek, please review your changes in r11370. I encountered several conflicts with @Jso...
Hynek Cihlar
 

Also available in: Atom