Project

General

Profile

Activity

From 03/24/2020 to 04/22/2020

04/22/2020

06:18 PM User Interface Feature #4394: add some frame options and attributes
Greg Shah wrote:
> OK, perhaps I need to clarify.
>
> @javaname@ is a converted Java name and will have been tran...
Roger Borrello
06:09 PM User Interface Feature #4394: add some frame options and attributes
OK, perhaps I need to clarify.
@javaname@ is a converted Java name and will have been transformed to remove all th...
Greg Shah
06:08 PM User Interface Feature #4394: add some frame options and attributes
Greg Shah wrote:
> No. Nein. Nyet. Non. Nee.
Tried updating that, and it looks like it should be using @name@. Ho...
Roger Borrello
06:07 PM User Interface Feature #4394: add some frame options and attributes
No. Nein. Nyet. Non. Nee. Greg Shah
06:00 PM User Interface Feature #4394: add some frame options and attributes
Getting back to @FRAME-NAME@, it looks like @convert/frame_construction.rules@ retrieves the critical data using:
<p...
Roger Borrello
04:50 PM User Interface Feature #4170: add drag and drop support to treeview widget
Can I use these changes to add @COUNT@... Sergey Ivanovskiy
02:51 PM User Interface Feature #4170: add drag and drop support to treeview widget
Sergey Ivanovskiy wrote:
> What 4GL create node methods are supported by TreeView FWD widget? I tried this code that...
Hynek Cihlar
01:30 PM User Interface Feature #4170: add drag and drop support to treeview widget
Also I found that Progress 4GL COM Object Viewer returns incorrect signature for @Expand@ event of @ITreeViewEvents@ ... Sergey Ivanovskiy
12:21 PM User Interface Feature #4170: add drag and drop support to treeview widget
What 4GL create node methods are supported by TreeView FWD widget? I tried this code that works with 4GL... Sergey Ivanovskiy
03:45 PM User Interface Feature #4164: implement misc UI features (frame options, misc attributes)
When not using redirection, the testcase passes.... Roger Borrello
03:39 PM User Interface Feature #4164: implement misc UI features (frame options, misc attributes)
I also notice on the last frame (a dialog box) the @F2@ never is recognized in the @wait-for go of frame df0.@ I have... Roger Borrello
03:01 PM User Interface Feature #4164: implement misc UI features (frame options, misc attributes)
Constantin Asofiei wrote:
> Roger Borrello wrote:
> > I am using "output to..." to collect the output. I can try wi...
Roger Borrello
02:42 PM User Interface Feature #4164: implement misc UI features (frame options, misc attributes)
Roger Borrello wrote:
> I am using "output to..." to collect the output. I can try without. However, I would think t...
Constantin Asofiei
02:39 PM User Interface Feature #4164: implement misc UI features (frame options, misc attributes)
Constantin Asofiei wrote:
> Area you using streams in your tests, or the redirected terminal ( unnamed stream)? I...
Roger Borrello
02:22 PM User Interface Feature #4164: implement misc UI features (frame options, misc attributes)
Roger Borrello wrote:
> During debug, I found that when the @visible@ flag is set prior to the frame being displayed...
Constantin Asofiei
01:41 PM User Interface Feature #4164: implement misc UI features (frame options, misc attributes)
During debug, I found that when the @visible@ flag is set prior to the frame being displayed, the @getFrame(frameId)@... Roger Borrello
11:44 AM User Interface Feature #4164: implement misc UI features (frame options, misc attributes)
With respect to @FRAME-COL@ (and @FRAME-ROW@), I am debugging why these are incorrect when checked using this code:
...
Roger Borrello
03:31 PM Database Feature #4011: database/persistence layer performance improvements
Eric Faulhaber wrote:
> Is @MultiClassLoader@ really needed for the import, or just @AsmClassLoader@?
Good point....
Ovidiu Maxiniuc
03:24 PM Database Feature #4011: database/persistence layer performance improvements
Is @MultiClassLoader@ really needed for the import, or just @AsmClassLoader@? Eric Faulhaber
03:21 PM Database Feature #4011: database/persistence layer performance improvements
Ovidiu Maxiniuc wrote:
> BTW, for import and server to start the
> @-Djava.system.class.loader=com.goldencode.p2...
Eric Faulhaber
03:20 PM Database Feature #4011: database/persistence layer performance improvements
BTW, for import and server to start the
@-Djava.system.class.loader=com.goldencode.p2j.classloader.MultiClassLoad...
Ovidiu Maxiniuc
03:06 PM Database Feature #4011: database/persistence layer performance improvements
Eric,
I committed r11412. The changes include:
* I fixed the reported issue. It was caused by the @key@ being dif...
Ovidiu Maxiniuc
05:20 AM Database Feature #4011: database/persistence layer performance improvements
Ovidiu, when I try to log into Hotel GUI embedded mode (or run any test case) with rev 14111, I get this:... Eric Faulhaber
08:18 PM Database Feature #4011: database/persistence layer performance improvements
Eric Faulhaber wrote:
>> I noticed your TODO in DatabaseManager. I am going to address is immediately as this is use...
Ovidiu Maxiniuc
03:10 PM User Interface Bug #4625: Frame configuration not shared or synched back to the GUI frame on redirection
During debug, I found that when the @visible@ flag is set prior to the frame being displayed, the @getFrame(frameId)@... Roger Borrello
03:03 PM User Interface Bug #4625 (New): Frame configuration not shared or synched back to the GUI frame on redirection
Roger Borrello
02:46 PM User Interface Bug #4624: Fill-in: StringIndexOutOfBoundsException and other bugs
h1. Problem 1. Wrong END key action result
The code:...
Vladimir Tsichevski
02:19 PM User Interface Bug #4624 (Closed): Fill-in: StringIndexOutOfBoundsException and other bugs
Vladimir Tsichevski
11:39 AM Base Language Feature #3855: implement equivalent support for REST (classic appserver, PASOE REST and WEB trans...
Marian Edu wrote:
> Constantin Asofiei wrote:
> > Marian, another question please: who/when sets the @SERVLET_SRVR_...
Constantin Asofiei
11:23 AM Base Language Feature #3855: implement equivalent support for REST (classic appserver, PASOE REST and WEB trans...
Constantin Asofiei wrote:
> Marian, another question please: who/when sets the @SERVLET_SRVR_DEBUG@ and @SERVLET_SER...
Marian Edu
10:42 AM Base Language Feature #3855: implement equivalent support for REST (classic appserver, PASOE REST and WEB trans...
Marian, another question please: who/when sets the @SERVLET_SRVR_DEBUG@ and @SERVLET_SERVER_APP_MODE@ CGI vars? I ca... Constantin Asofiei
10:50 AM Base Language Feature #4384: Builtin OO Implementation
Greg Shah wrote:
> > Greg: please fix the permissions, I can't even do a checkout from https://proj.goldencode.com/d...
Constantin Asofiei
10:45 AM Base Language Feature #4384: Builtin OO Implementation
> Greg: please fix the permissions, I can't even do a checkout from https://proj.goldencode.com/downloads/skeletons/r... Greg Shah
10:37 AM Base Language Feature #4384: Builtin OO Implementation
Marian Edu wrote:
> Constantin Asofiei wrote:
>
> > I would try @bzr diff -p1 -r <your checkout revision>@ so th...
Constantin Asofiei
10:34 AM Base Language Feature #4384: Builtin OO Implementation
Constantin Asofiei wrote:
> Marian, quick question - do you have the @toString@ method for @net.Uri@ class implement...
Marian Edu
10:32 AM Base Language Feature #4384: Builtin OO Implementation
Constantin Asofiei wrote:
> I would try @bzr diff -p1 -r <your checkout revision>@ so that on our side we can use...
Marian Edu
10:18 AM Base Language Feature #4384: Builtin OO Implementation
Marian, quick question - do you have the @toString@ method for @net.Uri@ class implemented? If not, I'm adding it in ... Constantin Asofiei
10:16 AM Base Language Feature #4384: Builtin OO Implementation
Marian Edu wrote:
> That sounds like fun, now that I can debug the whole conversion process this might be interestin...
Constantin Asofiei
10:15 AM Base Language Feature #4384: Builtin OO Implementation
Marian Edu wrote:
> Should I try again a 'bzr send' for the skeleton or how should we send the changes there?
T...
Marian Edu
10:11 AM Base Language Feature #4384: Builtin OO Implementation
Constantin Asofiei wrote:
> Marian Edu wrote:
> > I see properties are converted to getter/setter methods and are a...
Marian Edu
10:06 AM Base Language Feature #4384: Builtin OO Implementation
Marian Edu wrote:
> I see properties are converted to getter/setter methods and are annotated with the name as defin...
Constantin Asofiei
09:56 AM Base Language Feature #4384: Builtin OO Implementation
I see properties are converted to getter/setter methods and are annotated with the name as defined in 4GL, for variab... Marian Edu
06:15 AM Base Language Feature #4349: add support for 4GL ENUM
Hi Greg, we need @FlagsEnum@ for reflection so tried to implement something for this but there seems this is not yet ... Marian Edu

04/21/2020

06:34 PM User Interface Feature #4164: implement misc UI features (frame options, misc attributes)
Greg Shah wrote:
> 4335a revision 11428 adds conversion and server-side support for @EDITOR:AUTO-INDENT@. The clien...
Roger Borrello
09:57 AM User Interface Feature #4164: implement misc UI features (frame options, misc attributes)
Roger Borrello wrote:
> Please confirm @editor:auto-indent@ already converts and just needs runtime support only (so...
Greg Shah
09:26 AM User Interface Feature #4164: implement misc UI features (frame options, misc attributes)
Please confirm @editor:auto-indent@ already converts and just needs runtime support only (so I can bypass)? Roger Borrello
06:05 PM Base Language Feature #4381: implement LIBRARY() and MEMBER() built-in functions
Greg Shah wrote:
> Being more explicit about returning unknown when the input is unknown is a good practice. The fa...
Roger Borrello
05:48 PM Base Language Feature #4381: implement LIBRARY() and MEMBER() built-in functions
Added a simpler testcase @uast/library_calls/library_member2.p@ Roger Borrello
05:32 PM Base Language Feature #4381: implement LIBRARY() and MEMBER() built-in functions
Being more explicit about returning unknown when the input is unknown is a good practice. The fact that the matching... Greg Shah
05:22 PM Base Language Feature #4381: implement LIBRARY() and MEMBER() built-in functions
Roger Borrello wrote:
> Greg Shah wrote:
> > You will need to add the proper error handling, but otherwise it is fi...
Roger Borrello
05:18 PM Base Language Feature #4381: implement LIBRARY() and MEMBER() built-in functions
Greg Shah wrote:
> I don't see anything obviously wrong. The code seems like it should work.
>
> You will need t...
Roger Borrello
05:04 PM Base Language Feature #4381: implement LIBRARY() and MEMBER() built-in functions
I don't see anything obviously wrong. The code seems like it should work.
You will need to add the proper error h...
Greg Shah
04:39 PM Base Language Feature #4381: implement LIBRARY() and MEMBER() built-in functions
Made the changes to allow the pattern to be pre-compiled, but it no longer matches the given string.... Roger Borrello
02:53 PM Base Language Feature #4381: implement LIBRARY() and MEMBER() built-in functions
Code Review Task Branch 4231b Revision 11479
This is quite good. Here are some things to fix to make it better.
...
Greg Shah
02:19 PM Base Language Feature #4381: implement LIBRARY() and MEMBER() built-in functions
Ready for review...... Roger Borrello
02:14 PM Base Language Feature #4381 (WIP): implement LIBRARY() and MEMBER() built-in functions
Roger Borrello
12:43 PM Base Language Feature #4381: implement LIBRARY() and MEMBER() built-in functions
That makes sense. Greg Shah
12:27 PM Base Language Feature #4381: implement LIBRARY() and MEMBER() built-in functions
Roger Borrello wrote:
> Should these be placed nearby @SEARCH@ in @FileSystemOps@ like @searchLibrary@ and @searchMe...
Roger Borrello
12:25 PM Base Language Feature #4381: implement LIBRARY() and MEMBER() built-in functions
Should these be placed nearby @SEARCH@ in @FileSystemOps@ like @searchLibrary@ and @searchMember@? Roger Borrello
10:55 AM Base Language Feature #4381: implement LIBRARY() and MEMBER() built-in functions
Created @uast/library_member.p@ testcase based off some customer code. However, the use of @LIBRARY@ in the sample do... Roger Borrello
10:41 AM Base Language Feature #4381: implement LIBRARY() and MEMBER() built-in functions
Useful background information on libraries: https://documentation.progress.com/output/ua/OpenEdge_latest/index.html#p... Roger Borrello
03:29 PM Base Language Feature #4395: add support for KEEP-MESSAGES option
Greg Shah wrote:
> Code Review Task branch 4231b Revision 11470
>
> 1. In @KEEP-MESSAGES@ mode, have you checked ...
Roger Borrello
10:07 AM Base Language Feature #4395: add support for KEEP-MESSAGES option
Don't change existing sample code in a way that destroys the original intent and control flow. Add a new testcase an... Greg Shah
09:16 AM Base Language Feature #4395: add support for KEEP-MESSAGES option
Greg Shah wrote:
> What is the testcase? Why is it retrying instead of exiting?
It is @uast/io/basic_redirecte...
Roger Borrello
08:48 AM Base Language Feature #4395: add support for KEEP-MESSAGES option
> It's difficult to determine how the 4GL is actually handling this. Perhaps it implicitly closes the stream, and we ... Greg Shah
01:40 PM User Interface Feature #4170: add drag and drop support to treeview widget
I assume v6 is the correct one, but I do not know for sure. Greg Shah
01:06 PM User Interface Feature #4170: add drag and drop support to treeview widget
On my windows image I have two versions of a tree view control: Microsoft TreeView Control 6.0 (SP6) from @mscomctl.... Sergey Ivanovskiy
08:07 AM Database Feature #3814: more schema metadata
At this moment I'm using the current approach based on @metadata@ in @p2j.cfg.xml@. I believe that it will be easy to... Igor Skornyakov
08:02 AM Database Feature #3814: more schema metadata
We can leave behind a conversion artifact for this, since the dynamic queries are only processed at runtime this shou... Greg Shah
03:47 AM Database Feature #3814: more schema metadata
Greg/Igor: a VST can be used from dynamic queries, too. And this will leave nothing for us to determine via the stan... Constantin Asofiei
06:08 AM Database Feature #4011: database/persistence layer performance improvements
Ovidiu Maxiniuc wrote:
> I merged in my changes related to import and a few other fixes. Latest revision of 4011a is...
Eric Faulhaber
10:01 PM Database Feature #4011: database/persistence layer performance improvements
I merged in my changes related to import and a few other fixes. Latest revision of 4011a is 11411. Notes:
* the prop...
Ovidiu Maxiniuc
05:38 AM Base Language Feature #4384: Builtin OO Implementation
Constantin Asofiei wrote:
> OK, I see that we are missing from @Progress.Lang.Class@ the methods which resolve a cla...
Marian Edu
05:37 AM Base Language Feature #4384: Builtin OO Implementation
Marian Edu wrote:
> Constantin Asofiei wrote:
> > Marian, I'm mostly interested in @Progress.Lang.Class:new@ and @i...
Constantin Asofiei
05:29 AM Base Language Feature #4384: Builtin OO Implementation
Constantin Asofiei wrote:
> Marian, I'm mostly interested in @Progress.Lang.Class:new@ and @invoke@ calls when @Para...
Marian Edu
05:18 AM Base Language Feature #4384: Builtin OO Implementation
Marian, I'm mostly interested in @Progress.Lang.Class:new@ and @invoke@ calls when @ParameterList@ is involved (so ye... Constantin Asofiei
04:59 AM Base Language Feature #4384: Builtin OO Implementation
Quick question about @P.L.Class@ as that is listed in the short list there... do you need reflection support for that... Marian Edu

04/20/2020

04:53 PM Base Language Feature #4395: add support for KEEP-MESSAGES option
I have updates to correct behavior where @Press space bar to continue@ was displayed in ChUI, even though output was ... Roger Borrello
03:38 PM Base Language Feature #4395: add support for KEEP-MESSAGES option
Roger, PUT SCREEN issues in GUI are known, see #2372. Constantin Asofiei
03:31 PM Base Language Feature #4395: add support for KEEP-MESSAGES option
I am not seeing the testcases @put screen...@ show up in GUI like it does in 4GL. In @ThinClient@, the @putScreen@ me... Roger Borrello
02:32 PM Base Language Feature #4395: add support for KEEP-MESSAGES option
The latter seems most likely the same issue as #4619. Roger Borrello
02:27 PM Base Language Feature #4395: add support for KEEP-MESSAGES option
Code Review (cont.)
2. In @LowLevelStream@ and @StreamDaemon@ you need to add an @id@ parameter javadoc entry for...
Greg Shah
02:23 PM Base Language Feature #4395: add support for KEEP-MESSAGES option
Code Review Task branch 4231b Revision 11470
1. In @KEEP-MESSAGES@ mode, have you checked the following behavior?
...
Greg Shah
02:01 PM Base Language Feature #4395: add support for KEEP-MESSAGES option
> An unrelated issues has to do with how display "Last Line" with frame f-last. is handled, with message "A message."... Greg Shah
01:45 PM Base Language Feature #4395 (WIP): add support for KEEP-MESSAGES option
Roger Borrello
01:45 PM Base Language Feature #4395: add support for KEEP-MESSAGES option
Ready for review.... Roger Borrello
11:40 AM Base Language Feature #4395: add support for KEEP-MESSAGES option
In the spirit of "learning to fish", you could use the following to answer the question yourself:
@my-int-var = in...
Greg Shah
11:16 AM Base Language Feature #4395: add support for KEEP-MESSAGES option
Now we are cooking... @keepMessages@ is now available to the client in the critical location.
At looking at the s...
Roger Borrello
09:30 AM Base Language Feature #4395: add support for KEEP-MESSAGES option
> I do know my breakpoint in StreamDaemon.setKeepMessages(int id) doesn't get hit.
This breakpoint will be hit in ...
Greg Shah
09:27 AM Base Language Feature #4395: add support for KEEP-MESSAGES option
Greg Shah wrote:
> See @ThinClient.getCurrentRedirection()@.
On the server side, @RemoteStream.setKeepMessages@ i...
Roger Borrello
07:22 AM Base Language Feature #4395: add support for KEEP-MESSAGES option
See @ThinClient.getCurrentRedirection()@. Greg Shah
01:02 AM Base Language Feature #4395: add support for KEEP-MESSAGES option
Greg Shah wrote:
> > Do I still need to fiddle with RemoteStream if I am converting as:
>
> Yes. @RemoteStream@ ...
Roger Borrello
02:49 PM User Interface Bug #4619: GUI fill-in widgets show in FWD, when 4GL shows nothing
The @message set@ case may not be related to this at all. Greg Shah
02:31 PM User Interface Bug #4619: GUI fill-in widgets show in FWD, when 4GL shows nothing
Would this be related to the variable factory itself, or the widgets? I had another testcase @uast/io/basic_redirecte... Roger Borrello
08:42 AM Database Feature #3814: more schema metadata
Greg Shah wrote:
> > I do not understand what the "conversion support" (#3814-7) means as it seems that it is suffic...
Igor Skornyakov
08:29 AM Database Feature #3814: more schema metadata
> I do not understand what the "conversion support" (#3814-7) means as it seems that it is sufficient just to add the... Greg Shah
07:52 AM Database Feature #3814: more schema metadata
Looking at the content of the @_Database-Feature@ VST from the sample customer environment I do not think that it can... Igor Skornyakov
05:17 AM Database Feature #4011: database/persistence layer performance improvements
I committed rev 11409. With this drop, I can log into virtual desktop Hotel GUI. I can navigate the tabs, though the ... Eric Faulhaber
03:34 AM Database Feature #4011: database/persistence layer performance improvements
I've checked in revisions 11407 and 11408, which replace the UNDO architecture and the transaction management.
Ple...
Eric Faulhaber
04:06 AM User Interface Feature #3876: add support for "direct font control" at the widget level
Sergey Ivanovskiy wrote:
> We have some functions that can return the metric size of a string from the driver, the S...
Hynek Cihlar
02:32 AM User Interface Feature #3876: add support for "direct font control" at the widget level
Hynek Cihlar wrote:
> Sergey Ivanovskiy wrote:
> > It seems that these changes
> > [...]
> >
> > are not consi...
Sergey Ivanovskiy

04/19/2020

05:45 PM Base Language Feature #4395: add support for KEEP-MESSAGES option
> Do I still need to fiddle with RemoteStream if I am converting as:
Yes. @RemoteStream@ is how it gets to the cl...
Greg Shah
05:14 PM Base Language Feature #4395: add support for KEEP-MESSAGES option
Greg Shah wrote:
> @getKeepMessages()@ should be named @isKeepMessages()@ since the flag is a @boolean@. The standa...
Roger Borrello
10:35 AM Base Language Feature #4395: add support for KEEP-MESSAGES option
@getKeepMessages()@ should be named @isKeepMessages()@ since the flag is a @boolean@. The standard for Java "bean" n... Greg Shah
10:16 AM Base Language Feature #4395: add support for KEEP-MESSAGES option
It looks like there is a bug in @LogicalTerminal.message()@ whereby the output stream is never checked for redirectio... Roger Borrello
09:58 AM Base Language Feature #4395: add support for KEEP-MESSAGES option
That part is straightforward. I am using @setKeepMessages()@ without a parameter because it is an option that default... Roger Borrello
02:39 PM Database Feature #3814: more schema metadata
Well, it seems that we need some changes in the conversion process. The SCHEMA meta tables should be included in the ... Igor Skornyakov
12:48 PM Database Feature #3814: more schema metadata
In this note, I summarise my current understanding of the scope of this task and things which are not clear for me.
...
Igor Skornyakov

04/18/2020

08:58 AM Database Feature #3814: more schema metadata
Greg Shah wrote:
> You've been analyzing this for a few days. Please provide more details so we can discuss.
Gre...
Igor Skornyakov
07:06 AM Database Feature #3814: more schema metadata
> I understand that most of the data mentioned in this task are related to data security.
I don't think so. The @...
Greg Shah
06:40 AM Base Language Feature #4395: add support for KEEP-MESSAGES option
> I would just call the setter directly as setKeepMessages(true), instead of modifying the StreamFactory APIs.
Agr...
Greg Shah

04/17/2020

06:49 PM Base Language Feature #4395: add support for KEEP-MESSAGES option
Greg/Roger: the IO options can be emitted as a setter; see this portion of @convert/input_output.rules@:... Constantin Asofiei
06:39 PM Base Language Feature #4395: add support for KEEP-MESSAGES option
Please look at @StreamFactory@. You will see that it is stateless in regard to new streams. The @KEEP-MESSAGES@ fla... Greg Shah
05:18 PM Base Language Feature #4395: add support for KEEP-MESSAGES option
The @input_output.rules@ do not do anything with the @KEEP-MESSAGES@ options. There is the possibility of adding an a... Roger Borrello
03:49 PM Base Language Feature #4395: add support for KEEP-MESSAGES option
Updated testcase @uast/binary/read-text-and-binary.p@ to show there is no differences in having @keep-messages@ on th... Roger Borrello
02:27 PM Base Language Feature #4395: add support for KEEP-MESSAGES option
... Roger Borrello
12:33 PM Base Language Feature #4395: add support for KEEP-MESSAGES option
... Roger Borrello
06:39 PM User Interface Feature #4394 (WIP): add some frame options and attributes
Roger Borrello
06:38 PM User Interface Bug #4611: Implement a font enumeration Java API directly callable from legacy code
For Swing GUI, the fonts can be enumerated with:... Hynek Cihlar
06:36 PM User Interface Feature #4393: add TITLE-DCOLOR attribute support
Just _temporarily_ I updated to utilize the same method as @toMillis@.
By updating @directory.xml@:...
Roger Borrello
02:03 PM User Interface Feature #4393: add TITLE-DCOLOR attribute support
With my proposed change, the code could be implemented with a simple check @EnvironmentOps.versionNumber() >= 11.3@. ... Greg Shah
01:38 PM User Interface Feature #4393: add TITLE-DCOLOR attribute support
Greg Shah wrote:
> Constantin: What was the code that you added recently which had to check the version numbers at r...
Constantin Asofiei
12:43 PM User Interface Feature #4393: add TITLE-DCOLOR attribute support
We have @EnvironmentOps.versionWorker(long lvl)@ which can determine a version string for the 4GL version to which we... Greg Shah
11:56 AM User Interface Feature #4393 (WIP): add TITLE-DCOLOR attribute support
Roger Borrello
11:55 AM User Interface Feature #4393: add TITLE-DCOLOR attribute support
Greg Shah wrote:
> Yes, it could be a version difference. Run the testcases on both 10.x and 11.x and record the di...
Roger Borrello
09:33 AM User Interface Feature #4393: add TITLE-DCOLOR attribute support
> Should these be pursued?
No. Create new tasks.
Greg Shah
09:13 AM User Interface Feature #4393: add TITLE-DCOLOR attribute support
The @frame_title_color_default_values.p@ tests pass, however, there are a couple of differences.
# There is space in...
Roger Borrello
08:48 AM User Interface Feature #4393: add TITLE-DCOLOR attribute support
Code Review Task Branch 4231b Revision 11463
The changes are good.
A minor code standards issue: split the foll...
Greg Shah
07:07 AM User Interface Feature #4393: add TITLE-DCOLOR attribute support
> while in 4GL, it activates the button and an NPE exception is thrown:
This implies there is an NPE in the 4GL wh...
Greg Shah
06:32 PM User Interface Feature #3876: add support for "direct font control" at the widget level
Hynek Cihlar wrote:
> but there were errors converting the method call returning String array. I tried to fix this a...
Hynek Cihlar
04:56 PM User Interface Feature #3876: add support for "direct font control" at the widget level
Sergey Ivanovskiy wrote:
> It seems that these changes
> [...]
>
> are not consistent with @isFontInstalled@ us...
Hynek Cihlar
03:44 PM User Interface Feature #3876: add support for "direct font control" at the widget level
It seems that these changes ... Sergey Ivanovskiy
11:28 AM User Interface Feature #3876: add support for "direct font control" at the widget level
Greg Shah wrote:
> Yes. When you designed the default freely licensed fonts for FWD, this included replacing the co...
Eugenie Lyzenko
09:10 AM User Interface Feature #3876: add support for "direct font control" at the widget level
Yes. When you designed the default freely licensed fonts for FWD, this included replacing the common/standard bitmap... Greg Shah
09:00 AM User Interface Feature #3876: add support for "direct font control" at the widget level
Greg Shah wrote:
> The changes are good. I've made some additional tweaks.
>
> Eugenie: I'd like to include a li...
Eugenie Lyzenko
07:39 AM User Interface Feature #3876: add support for "direct font control" at the widget level
The changes are good. I've made some additional tweaks.
Eugenie: I'd like to include a list of the commonly used ...
Greg Shah
06:31 PM Conversion Tools Bug #4620: Direct Java conversion fails for arrays of objects
The attached diff resolves the conversion error, but the resulting Java code does not compile. The issue will need mo... Hynek Cihlar
06:29 PM Conversion Tools Bug #4620: Direct Java conversion fails for arrays of objects
The following piece of code fails to convert.... Hynek Cihlar
06:27 PM Conversion Tools Bug #4620 (New): Direct Java conversion fails for arrays of objects
Hynek Cihlar
02:28 PM Database Feature #3814: more schema metadata
I understand that most of the data mentioned in this task are related to data security. I'm not sure that most of the... Igor Skornyakov
11:55 AM User Interface Bug #4619: GUI fill-in widgets show in FWD, when 4GL shows nothing
> In 4GL, this is not a fill-in and
I think you mean that it is an editable fill-in in FWD and not in the 4GL?
...
Greg Shah
11:20 AM User Interface Bug #4619: GUI fill-in widgets show in FWD, when 4GL shows nothing
A simple integer on a frame becomes a fill-in widget with the default value showing. In 4GL, this is not a fill-in an... Roger Borrello
11:18 AM User Interface Bug #4619 (New): GUI fill-in widgets show in FWD, when 4GL shows nothing
Roger Borrello
11:11 AM User Interface Bug #4618: Default location of dialog box title is left justified instead of centered
The @uast/frame_title_color_default_values.p@ testcase shows that the dialog box has the title text left justified in... Roger Borrello
11:08 AM User Interface Bug #4618 (New): Default location of dialog box title is left justified instead of centered
Roger Borrello
10:32 AM User Interface Bug #4617: Number of GUI frames in default window differs from 4GL
Testcase related to #4393 reveals that FWD allows 5 frames on the default window, when 4GL only shows 4.
!GUI_fram...
Roger Borrello
10:29 AM User Interface Bug #4617 (New): Number of GUI frames in default window differs from 4GL
Roger Borrello

04/16/2020

06:36 PM User Interface Feature #4394: add some frame options and attributes
Roger Borrello wrote:
> By updating @getFrameRow@ and @getFrameCol@ in @ThinClient.java@ to return a 0, if the frame...
Hynek Cihlar
06:19 PM User Interface Feature #3876: add support for "direct font control" at the widget level
I added the required information in [[p2j:Font_Control_in_4GL_Widgets]] together with an example. I found a couple of... Hynek Cihlar
06:03 PM User Interface Feature #4393: add TITLE-DCOLOR attribute support
Regarding the menu tests, both GUI and ChUI result in the same attribute output.
However, there are different beha...
Roger Borrello
04:40 PM User Interface Feature #4393: add TITLE-DCOLOR attribute support
These changes should complete the browse attributes and options.... Roger Borrello
02:34 PM User Interface Feature #4393: add TITLE-DCOLOR attribute support
Issue of the title bar missing was related to @annotations/sorting.rules@ where @DCOLOR@ was not included as criteria... Roger Borrello
01:49 PM User Interface Feature #4393: add TITLE-DCOLOR attribute support
It is not obviously on the client or server, we can't really know. But since it is drawing something and just missin... Greg Shah
11:37 AM User Interface Feature #4393: add TITLE-DCOLOR attribute support
Roger Borrello wrote:
> Another issue I am looking at. The browse title is missing, if @DCOLOR@ is part of the optio...
Roger Borrello
10:59 AM User Interface Feature #4393: add TITLE-DCOLOR attribute support
Yes, I think so. Greg Shah
10:27 AM User Interface Feature #4393: add TITLE-DCOLOR attribute support
Greg Shah wrote:
> > I did not have good results with that flag, or I was using it incorrectly. However, the config....
Roger Borrello
04:21 PM Database Bug #3471: incremental conversion is regressed
4231b rev 11462 contains some performance fixes related to the memory usage.
The idea here was:
* 'unpin' the AST...
Constantin Asofiei
04:03 PM Database Bug #3471: incremental conversion is regressed
Additional notes which may be useful:
The core idea is that the FWD ConversionDriver has an incremental conversion...
Greg Shah
12:05 PM Database Feature #3813: misc DB features part deux
Greg Shah wrote:
> Igor: Can you please commit your import fixes so that the build is working again? I need to push...
Igor Skornyakov
11:24 AM Database Feature #3813: misc DB features part deux
Igor: Can you please commit your import fixes so that the build is working again? I need to push this to our customers. Greg Shah
11:20 AM User Interface Feature #4170: add drag and drop support to treeview widget
Investigating what issues need to be done for #4170-20 in item 2. Sergey Ivanovskiy
03:58 AM Base Language Feature #4384: Builtin OO Implementation
Marian Edu wrote:
> Constantin Asofiei wrote:
>
> > Marian, just do a bzr revert and bzr clean-tree - to cleanup ...
Constantin Asofiei
03:35 AM Base Language Feature #4384: Builtin OO Implementation
Constantin Asofiei wrote:
> Marian, just do a bzr revert and bzr clean-tree - to cleanup after the update.
OK, ...
Marian Edu
03:17 AM Base Language Feature #4384: Builtin OO Implementation
Marian Edu wrote:
> Greg Shah wrote:
> > Branch 4384b was created from 4231b revision 11458. Access it using @bzr ...
Constantin Asofiei
03:02 AM Base Language Feature #4384: Builtin OO Implementation
Greg Shah wrote:
> Branch 4384b was created from 4231b revision 11458. Access it using @bzr co sftp://<userid>@xfer...
Marian Edu
08:16 PM Base Language Feature #4384: Builtin OO Implementation
4384a was archived as dead on devsrv01. Please note that I was unable to @bzr push --overwrite@ on devsrv01 so I zip... Greg Shah
08:14 PM Base Language Feature #4384: Builtin OO Implementation
Branch 4384b was created from 4231b revision 11458. Access it using @bzr co sftp://<userid>@xfer.goldencode.com/opt/... Greg Shah

04/15/2020

07:15 PM Database Feature #3813: misc DB features part deux
Constantin Asofiei wrote:
> Igor, there is an issue in @BufferFieldImpl@ - this import "import org.aspectj.org.eclip...
Igor Skornyakov
06:29 PM Database Feature #3813: misc DB features part deux
Igor, there is an issue in @BufferFieldImpl@ - this import "import org.aspectj.org.eclipse.jdt.core.dom.*;" is not OK... Constantin Asofiei
07:11 PM Database Feature #4011: database/persistence layer performance improvements
Eric Faulhaber wrote:
> However, I have another question on this topic: aren't the values in each row of the @.d@ fi...
Ovidiu Maxiniuc
07:05 PM Database Feature #4011: database/persistence layer performance improvements
Ovidiu Maxiniuc wrote:
> [...] I think we can either:
> * drop the method, I think the association property-index c...
Eric Faulhaber
06:52 PM Database Feature #4011: database/persistence layer performance improvements
Eric Faulhaber wrote:
> The other issue is that I had removed the deprecated @BaseRecord.indexOf@ method in my worki...
Ovidiu Maxiniuc
06:01 PM Database Feature #4011: database/persistence layer performance improvements
Ovidiu Maxiniuc wrote:
> I found out that @PropertyMapper@ tries to delegate the setting of a field if @delegate@ ...
Eric Faulhaber
05:12 PM Database Feature #4011: database/persistence layer performance improvements
Eric,
I started rewriting some parts of the @import.xml@, @ImportWorker@ and related classes to take advantage of th...
Ovidiu Maxiniuc
06:44 PM Base Language Feature #4384: Builtin OO Implementation
> I think we should preserve 4384a as a dead branch on devsrv01 and create 4384b.
Will do.
Greg Shah
06:38 PM Base Language Feature #4384: Builtin OO Implementation
Greg Shah wrote:
> # rebase 4231b from trunk 11346
The rebase of 4231b is done.
> # replace the 4384a branch with ...
Constantin Asofiei
05:57 PM Base Language Feature #4384: Builtin OO Implementation
> Greg: can you please update the web repo?
Done.
Greg Shah
05:40 PM Base Language Feature #4384: Builtin OO Implementation
Greg Shah wrote:
> I think the faster way is to:
>
> # merge the exact revisions from 4384a into 4231b
The 11426...
Constantin Asofiei
05:36 PM Base Language Feature #4384: Builtin OO Implementation
Marian Edu wrote:
> Constantin Asofiei wrote:
>
> > Yes, please zip it and upload it to xfer.
> I'm confused as ...
Constantin Asofiei
04:25 PM Base Language Feature #4384: Builtin OO Implementation
I think the faster way is to:
# merge the exact revisions from 4384a into 4231b
# rebase 4231b from trunk 11346
...
Greg Shah
02:06 PM Base Language Feature #4384: Builtin OO Implementation
Constantin Asofiei wrote:
> Marian, did you do a bzr merge or bzr rebase for 4384a, with 4231b?
>
> I'm trying to...
Constantin Asofiei
01:40 PM Base Language Feature #4384: Builtin OO Implementation
Marian, did you do a bzr merge or bzr rebase for 4384a, with 4231b?
I'm trying to rebase 4384a from 4231b, and I t...
Constantin Asofiei
12:47 PM Base Language Feature #4384: Builtin OO Implementation
Constantin Asofiei wrote:
> Yes, please zip it and upload it to xfer.
I'm confused as of what you refer to when y...
Marian Edu
12:32 PM Base Language Feature #4384: Builtin OO Implementation
Marian Edu wrote:
> Constantin Asofiei wrote:
> > Marian Edu wrote:
> > > Did pulled the skeleton fresh and sync t...
Constantin Asofiei
12:31 PM Base Language Feature #4384: Builtin OO Implementation
Constantin Asofiei wrote:
> Marian Edu wrote:
> > Did pulled the skeleton fresh and sync the two folders, attached ...
Marian Edu
12:03 PM Base Language Feature #4384: Builtin OO Implementation
Marian Edu wrote:
> Did pulled the skeleton fresh and sync the two folders, attached the patch.
Where did you pull ...
Constantin Asofiei
11:21 AM Base Language Feature #4384: Builtin OO Implementation
Constantin Asofiei wrote:
> OK, do let me know when they are there. I need to do a review and see if they can be me...
Marian Edu
10:48 AM Base Language Feature #4384: Builtin OO Implementation
Marian Edu wrote:
> Will try to push the changes to 4384a now
OK, do let me know when they are there. I need to do...
Constantin Asofiei
10:45 AM Base Language Feature #4384: Builtin OO Implementation
Constantin Asofiei wrote:
> Marian, are all your 4384a changes pushed to xfer?
>
> Also, please upload to xfer th...
Marian Edu
10:22 AM Base Language Feature #4384: Builtin OO Implementation
Marian, are all your 4384a changes pushed to xfer?
Also, please upload to xfer the full skeleton project, with you...
Constantin Asofiei
02:21 PM User Interface Feature #4394: add some frame options and attributes
By updating @getFrameRow@ and @getFrameCol@ in @ThinClient.java@ to return a 0, if the frame is not visible, I get ma... Roger Borrello
12:11 PM User Interface Feature #4394: add some frame options and attributes
Roger Borrello wrote:
> Initial attribute values being returned for @frame-col@ and @frame-row@ are incorrect. They ...
Roger Borrello
11:38 AM User Interface Feature #4394: add some frame options and attributes
Initial attribute values being returned for @frame-col@ and @frame-row@ are incorrect. They are coming from the clien... Roger Borrello
10:38 AM User Interface Feature #4394: add some frame options and attributes
We always must return BDT values from attribute getters. We never return @String@ instances. Greg Shah
10:22 AM User Interface Feature #4394: add some frame options and attributes
Greg Shah wrote:
> Right. So your existing code is not correct. I suspect that this is not the string @"?"@ but it...
Roger Borrello
09:53 AM User Interface Feature #4394: add some frame options and attributes
Right. So your existing code is not correct. I suspect that this is not the string @"?"@ but it is just how the lan... Greg Shah
09:46 AM User Interface Feature #4394: add some frame options and attributes
Greg Shah wrote:
> Code Review Task Branch 4231b Revision 11446
>
> The only issue is the use of @new String()@ i...
Roger Borrello
09:46 AM Database Bug #3471 (Closed): incremental conversion is regressed
Greg Shah
09:15 PM Database Feature #4613: add missing support for database user defined functions (UDF) if they are supporte...
FWD supports many built-in functions for use in WHERE clauses, such that they are executed at the database server usi... Eric Faulhaber

04/14/2020

07:03 PM Database Feature #3813: misc DB features part deux
Eric Faulhaber wrote:
> Igor, I will open a new task for this. We will need to put together a process for identifyin...
Igor Skornyakov
06:54 PM Database Feature #3813: misc DB features part deux
Igor Skornyakov wrote:
> The only remaining thing in this task is @Built-In Function Usage in WHERE Clauses@.
> Whe...
Eric Faulhaber
03:33 PM Database Feature #3813: misc DB features part deux
The only remaining thing in this task is @Built-In Function Usage in WHERE Clauses@.
Where can I take a look at the ...
Igor Skornyakov
03:30 PM Database Feature #3813: misc DB features part deux
Implemented runtime support for the @BUFFER:BUFFER-VALIDATE@.
4231b revision 11447.
Igor Skornyakov
06:58 PM Database Feature #4613 (New): add missing support for database user defined functions (UDF) if they are su...
Eric Faulhaber
06:06 PM Database Bug #3471: incremental conversion is regressed
Branch 3471a was merged to trunk rev 11346 and archived. This adds support for incremental conversion. Not mandator... Constantin Asofiei
05:43 PM Database Bug #3471: incremental conversion is regressed
Phase 2 planning:
* move the h2-related code as a service in goldencode.ast
* tmpTabNodes usage - find a better way...
Constantin Asofiei
11:58 AM Database Bug #3471: incremental conversion is regressed
Code Review Task Branch 3471a Revision 11376
I'm fine with the changes. You can merge to trunk when your testing ...
Greg Shah
11:27 AM Database Bug #3471: incremental conversion is regressed
The lambda issues were addressed in 3471a 11375.
I think this can be merged to trunk, after I finish another conve...
Constantin Asofiei
11:15 AM Database Bug #3471: incremental conversion is regressed
3471a rev 11376 contains a fix for #4384-187 issue related to converting references for builtin classes with no FWD i... Constantin Asofiei
04:57 PM Database Feature #3814: more schema metadata
Ovidiu Maxiniuc wrote:
> Igor, you can query the meta tables from a 4GL environment as a standard stable. For exampl...
Igor Skornyakov
04:35 PM Database Feature #3814: more schema metadata
Igor, you can query the meta tables from a 4GL environment as a standard stable. For example:... Ovidiu Maxiniuc
04:13 PM Database Feature #3814: more schema metadata
Where can I find the description of the schema metadata? So far I've found only this article: https://knowledgebase.p... Igor Skornyakov
02:38 PM User Interface Feature #4394: add some frame options and attributes
As someone wise once said: "The problem was a loose nut behind the wheel.". :)
Our current implementation assumes ...
Greg Shah
02:35 PM User Interface Feature #4394: add some frame options and attributes
Roger Borrello wrote:
> Greg Shah wrote:
> > The @b4Frname.assign()@ is missing the @f0Frame.widgeti().getFrameName...
Roger Borrello
02:07 PM User Interface Feature #4394: add some frame options and attributes
Greg Shah wrote:
> The @b4Frname.assign()@ is missing the @f0Frame.widgeti().getFrameName()@ argument.
>
> You'll...
Roger Borrello
02:06 PM User Interface Feature #4394: add some frame options and attributes
We can't go on an 2 week effort to dig into this. It would be good to fix these as well. The issue is probably diffe... Greg Shah
12:53 PM User Interface Feature #4394: add some frame options and attributes
Roger Borrello wrote:
> Looking at more code emitted... would this be similar to why this code:
> [...]
> converts...
Roger Borrello
12:26 PM User Interface Feature #4394: add some frame options and attributes
Greg Shah wrote:
> The @b4Frname.assign()@ is missing the @f0Frame.widgeti().getFrameName()@ argument.
>
> You'll...
Roger Borrello
10:37 AM User Interface Feature #4394: add some frame options and attributes
Code Review Task Branch 4231b Revision 11446
The only issue is the use of @new String()@ in @GenericWidget.getFram...
Greg Shah
10:30 AM User Interface Feature #4394: add some frame options and attributes
The @b4Frname.assign()@ is missing the @f0Frame.widgeti().getFrameName()@ argument.
You'll have to fix it. Most l...
Greg Shah
10:21 AM User Interface Feature #4394: add some frame options and attributes
Current testcase has 2 of the same use of the @:frame-name@ attribute, with very different conversions:
# @assign b4...
Roger Borrello
10:03 AM Base Language Feature #4384: Builtin OO Implementation
Greg Shah wrote:
> > > Not sure how the skeleton works for you, looks like it's being used by the parser to resolve ...
Constantin Asofiei
09:57 AM Base Language Feature #4384: Builtin OO Implementation
Great! Greg Shah
09:44 AM Base Language Feature #4384: Builtin OO Implementation
Greg Shah wrote:
> Thanks for posting a high level status.
>
> It is very high priority to get the conversion par...
Marian Edu
09:41 AM Base Language Feature #4384: Builtin OO Implementation
Greg Shah wrote:
> > One thing: I didn't anticipate your need to greatly change the skeletons. Can you help us under...
Marian Edu
09:40 AM Base Language Feature #4384: Builtin OO Implementation
Thanks for posting a high level status.
It is very high priority to get the conversion parts finished ASAP. Can y...
Greg Shah
09:35 AM Base Language Feature #4384: Builtin OO Implementation
Greg Shah wrote:
> One thing: I didn't anticipate your need to greatly change the skeletons. Can you help us unde...
Marian Edu
09:34 AM Base Language Feature #4384: Builtin OO Implementation
> One thing: I didn't anticipate your need to greatly change the skeletons. Can you help us understand the need for t... Greg Shah
09:32 AM Base Language Feature #4384: Builtin OO Implementation
> > Not sure how the skeleton works for you, looks like it's being used by the parser to resolve references,
Yes,...
Greg Shah
02:17 AM Base Language Feature #4384: Builtin OO Implementation
Roger Borrello wrote:
> h2. OO Built-Ins Requiring Implementation
>
> Breakdown of OO BuiltIns to focus on:
> * ...
Marian Edu

04/13/2020

07:02 PM Database Bug #3471: incremental conversion is regressed
Greg Shah wrote:
> 5. The design is quite elegant. The fact that the maps and sets in conversion have been replaced...
Constantin Asofiei
06:54 PM Database Bug #3471: incremental conversion is regressed
Code Review Task Branch 3471a Revision 11373
+Part 2+
5. The design is quite elegant. The fact that the maps a...
Greg Shah
06:33 PM Database Bug #3471: incremental conversion is regressed
Greg Shah wrote:
> 1. In the calling locations of @helper.persistCollection()@ it would be better if the types of t...
Constantin Asofiei
04:34 PM Database Bug #3471: incremental conversion is regressed
Code Review Task Branch 3471a Revision 11373
So far, I've very impressed.
+Part 1+
I'm posting the review in...
Greg Shah
07:27 AM Database Bug #3471: incremental conversion is regressed
Greg, 3471a rev 11373 is ready for review Constantin Asofiei
05:28 PM User Interface Feature #4394: add some frame options and attributes
Code ready for review. Additional testcases being developed. Tested via @ON MOUSE-SELECT-CLICK@ of various widgets on... Roger Borrello
04:19 PM User Interface Feature #4394: add some frame options and attributes
> My assumptions is that there will need to be getter/setter support added in FrameInterface.java and FrameWidget.jav... Greg Shah
04:07 PM User Interface Feature #4394: add some frame options and attributes
Greg Shah wrote:
> Add support for:
>
> * @FRAME-NAME@ attribute (this is actually a generic widget attribute but...
Roger Borrello
10:22 AM Base Language Feature #4384: Builtin OO Implementation
Constantin Asofiei wrote:
> As a temporary patch, you can move this section:
> [...]
> from @rules/fixups/post_par...
Marian Edu
08:27 AM Base Language Feature #4384: Builtin OO Implementation
Constantin Asofiei wrote:
> Constantin Asofiei wrote:
> > If you want to fix this now, just move the @_1@ suffix fr...
Marian Edu
08:14 AM Base Language Feature #4384: Builtin OO Implementation
Constantin Asofiei wrote:
> If you want to fix this now, just move the @_1@ suffix from the property getter to the J...
Constantin Asofiei
08:13 AM Base Language Feature #4384: Builtin OO Implementation
Marian, this is fixed in 3471a which will be in trunk soon.
If you want to fix this now, just move the @_1@ suffix...
Constantin Asofiei
07:43 AM Base Language Feature #4384: Builtin OO Implementation
Constantin Asofiei wrote:
> Marian Edu wrote:
> > And the skeleton have a public property and protected methods lik...
Marian Edu
07:41 AM Base Language Feature #4384: Builtin OO Implementation
Marian Edu wrote:
> And the skeleton have a public property and protected methods like this:
> [...]
Hmm... are th...
Constantin Asofiei
07:33 AM Base Language Feature #4384: Builtin OO Implementation
And the skeleton have a public property and protected methods like this:... Marian Edu
07:30 AM Base Language Feature #4384: Builtin OO Implementation
Constantin Asofiei wrote:
> Marian Edu wrote:
> > The test is oo/openedge/net/message_part/test_property_headers.p
...
Marian Edu
07:28 AM Base Language Feature #4384: Builtin OO Implementation
Marian Edu wrote:
> The test is oo/openedge/net/message_part/test_property_headers.p
Marian, I'm looking into it.
Constantin Asofiei
07:14 AM Base Language Feature #4384: Builtin OO Implementation
OK, I give-up :(
I'm trying to make sense of why the conversion is using the wrong method name here but I really d...
Marian Edu
09:11 AM Database Feature #3813: misc DB features part deux
Implemented changes suggested by Eric (see #3813-157) and fixed dependency of the DMO instantiation on @SESSION:DATE... Igor Skornyakov
05:26 AM Database Feature #3813: misc DB features part deux
Eric Faulhaber wrote:
> No, please don't work on the conversion part. The @LegacyField@ annotation is precisely the ...
Igor Skornyakov
05:05 AM Database Feature #3813: misc DB features part deux
Igor Skornyakov wrote:
> Greg Shah wrote:
> > Igor: Can you implement the parts of the support except for the looku...
Eric Faulhaber
05:03 AM Database Feature #3813: misc DB features part deux
Igor, for @LegacyField@ look in @dmo_common.rules@, around line 1780, for code like this:... Constantin Asofiei
03:24 AM Database Feature #3813: misc DB features part deux
Greg Shah wrote:
> Igor: Can you implement the parts of the support except for the lookup of the value? Then it can...
Igor Skornyakov
09:20 PM Database Feature #3813: misc DB features part deux
Greg Shah wrote:
> Eric: I assume you mean that just the backing value is there in the DMO in 4011a. The rest of th...
Eric Faulhaber

04/12/2020

07:40 PM Database Feature #3813: misc DB features part deux
Eric Faulhaber wrote:
> Igor Skornyakov wrote:
>
> > I'm supposed to work at least on @DECIMALS@ support right no...
Greg Shah
05:05 PM Database Feature #4011: database/persistence layer performance improvements
Eric Faulhaber wrote:
> The other issue is that I had removed the deprecated @BaseRecord.indexOf@ method in my worki...
Eric Faulhaber
05:03 PM Database Feature #4011: database/persistence layer performance improvements
Thanks for fixing up the import.
I had two errors compiling with rev 11406. One was due to a change I have made in...
Eric Faulhaber

04/11/2020

04:12 PM Database Feature #3813: misc DB features part deux
Eric Faulhaber wrote:
> Sorry, Igor, would not have been giving you implementation advice had I realized Ovidiu alre...
Igor Skornyakov
04:08 PM Database Feature #3813: misc DB features part deux
Sorry, Igor, would not have been giving you implementation advice had I realized Ovidiu already implemented this feat... Eric Faulhaber
04:01 PM Database Feature #3813: misc DB features part deux
Igor Skornyakov wrote:
> I'm supposed to work at least on @DECIMALS@ support right now.
If there is not a criti...
Eric Faulhaber
03:58 PM Database Feature #3813: misc DB features part deux
Ovidiu Maxiniuc wrote:
> [...]
> Both attributes and can be directly accessed via the new @DmoMetadataManager@ / @D...
Eric Faulhaber
03:03 PM Database Feature #3813: misc DB features part deux
Ovidiu Maxiniuc wrote:
> Igor, I believe both of the above attributes are members fields in the new @Property@ DMO a...
Igor Skornyakov
02:50 PM Database Feature #3813: misc DB features part deux
Igor, I believe both of the above attributes are members fields in the new @Property@ DMO annotation of the new persi... Ovidiu Maxiniuc
08:08 AM Database Feature #3813: misc DB features part deux
Can anybody help me to understand how the @LegacyField@ annotations are generated? We need at least two fixes for thi... Igor Skornyakov
12:38 PM Base Language Feature #4384: Builtin OO Implementation
I've tried to merge your changes to skeleton with ours and no wonder there are merge conflicts, I can solve those now... Marian Edu

04/10/2020

06:23 PM User Interface Bug #4612: Fix ChUI browse drawing when the current row is out of the view
In a ChUI browse the current row can be out of the view. It is a rare case and I'm aware only of one case when this h... Stanislav Lomany
05:54 PM User Interface Bug #4612 (New): Fix ChUI browse drawing when the current row is out of the view
Stanislav Lomany
06:06 PM Database Feature #3813: misc DB features part deux
Eric Faulhaber wrote:
> Igor Skornyakov wrote:
>
> > I need the get the @DECIMALS@ value from the @BufferFieldImp...
Igor Skornyakov
06:00 PM Database Feature #3813: misc DB features part deux
Igor Skornyakov wrote:
> I need the get the @DECIMALS@ value from the @BufferFieldImpl@ method I do not see how ge...
Eric Faulhaber
04:38 PM Database Feature #3813: misc DB features part deux
Eric Faulhaber wrote:
> The DMO field will always return a BDT value, never @null@, even if it is unknown value. The...
Igor Skornyakov
03:58 PM Database Feature #3813: misc DB features part deux
Fixed the issue with @INITIAL@ value parsing for date fields.
Committed with @SessionExport@ support to 4231b revis...
Igor Skornyakov
03:06 PM Database Feature #3813: misc DB features part deux
I've removed my changes regarding @LogicalTerminal@. Apart from extracting @SessionExports@ operations to a separate ... Igor Skornyakov
01:57 PM Database Feature #3813: misc DB features part deux
Greg Shah wrote:
> > I understand that EnvironmentDaemon is not a suitable pattern for the situation with SESSION:DA...
Igor Skornyakov
01:46 PM Database Feature #3813: misc DB features part deux
> I understand that EnvironmentDaemon is not a suitable pattern for the situation with SESSION:DATE-FORMAT and the ot... Greg Shah
01:11 PM Database Feature #3813: misc DB features part deux
I understand that @EnvironmentDaemon@ is not a suitable pattern for the situation with @SESSION:DATE-FORMAT@ and the ... Igor Skornyakov
04:26 PM Database Feature #4011: database/persistence layer performance improvements
The first revision of import process was committed to 4011a. I have successfully imported the hotel_gui database in b... Ovidiu Maxiniuc
09:23 AM User Interface Feature #3876: add support for "direct font control" at the widget level
Greg Shah wrote:
> Please create a new task for that. We will defer work on it for now.
Done.
Hynek Cihlar
09:13 AM User Interface Feature #3876: add support for "direct font control" at the widget level
Please create a new task for that. We will defer work on it for now. In the wiki page, explain the idea and link to... Greg Shah
09:12 AM User Interface Feature #3876: add support for "direct font control" at the widget level
Greg Shah wrote:
> > He could do this using the standard system tools. Or do you want to add other 4GL extensions th...
Hynek Cihlar
09:07 AM User Interface Feature #3876: add support for "direct font control" at the widget level
> He could do this using the standard system tools. Or do you want to add other 4GL extensions that would allow this?... Greg Shah
09:00 AM User Interface Feature #3876: add support for "direct font control" at the widget level
Greg Shah wrote:
> I've just edited the "Font Control in 4GL Widgets":/projects/p2j/wiki/Font_Control_in_4GL_Widgets...
Hynek Cihlar
08:16 AM User Interface Feature #3876: add support for "direct font control" at the widget level
I've just edited the "Font Control in 4GL Widgets":/projects/p2j/wiki/Font_Control_in_4GL_Widgets. Please review and... Greg Shah
09:21 AM User Interface Bug #4611: Implement a font enumeration Java API directly callable from legacy code
The motivation here is to provide a way to allow to enumerate available font faces in legacy code. That is FWD/4GL co... Hynek Cihlar
09:16 AM User Interface Bug #4611 (New): Implement a font enumeration Java API directly callable from legacy code
Hynek Cihlar

04/09/2020

03:32 PM Database Feature #3813: misc DB features part deux
Greg Shah wrote:
> Yes, it will certinly make it better, even if it is not the full solution.
>
> You can patte...
Igor Skornyakov
03:30 PM Database Feature #3813: misc DB features part deux
Igor Skornyakov wrote:
> BTW: maybe the problem is not with the @SessionUtils@ _per se_, but in the way @SessionExpo...
Greg Shah
03:29 PM Database Feature #3813: misc DB features part deux
Yes, it will certinly make it better, even if it is not the full solution.
You can pattern it using the @Environ...
Greg Shah
03:29 PM Database Feature #3813: misc DB features part deux
BTW: maybe the problem is not with the @SessionUtils@ _per se_, but in the way @SessionExports@ is instantiated in th... Igor Skornyakov
02:55 PM Database Feature #3813: misc DB features part deux
Greg Shah wrote:
> Yes. This is what I meant by my comment:
>
> > I don't know why we are using SessionUtils on ...
Igor Skornyakov
02:47 PM Database Feature #3813: misc DB features part deux
Igor Skornyakov wrote:
> A @SESSION:TIMEZONE = 3.@ (@SessionUtils.setTimezone@) causes the same exception as in #381...
Greg Shah
02:45 PM Database Feature #3813: misc DB features part deux
A @SESSION:TIMEZONE = 3.@ (@SessionUtils.setTimezone@) causes the same exception as in #3813-123 (@No export or no ac... Igor Skornyakov
02:24 PM User Interface Feature #4164: implement misc UI features (frame options, misc attributes)
As Constantin notes, you are telling the code to only have the frame positioned in @col 1 row 1@ because only the FIR... Greg Shah
01:05 PM User Interface Feature #4164: implement misc UI features (frame options, misc attributes)
Roger, the @AT COL ROW@ in the frame phrase (for DISPLAY) sets the frame's definition location, not at runtime.
To...
Constantin Asofiei
01:01 PM User Interface Feature #4164: implement misc UI features (frame options, misc attributes)
New testcase has expanded my ability to validate values, but I'm not sure it's on the mark yet. I was expecting the f... Roger Borrello
06:56 AM Base Language Feature #4384: Builtin OO Implementation
Marian Edu wrote:
> @Greg, do you have already a blue print for the OE Enums? We still have some issues with those a...
Greg Shah
02:54 AM Base Language Feature #4384: Builtin OO Implementation
@Greg, do you have already a blue print for the OE Enums? We still have some issues with those and would be nice to k... Marian Edu
06:46 AM Runtime Infrastructure Feature #4406: server-side REST execution without appserver agents
I think that the solution should be made generic enough that it can work with non-REST cases as well. I think this m... Greg Shah

04/08/2020

11:29 AM User Interface Feature #4394: add some frame options and attributes
The @frame-name@ is just a string, right? So you can do anything with it to see the value (e.g. @message widget:fram... Greg Shah
11:03 AM User Interface Feature #4394: add some frame options and attributes
I cannot find any useful documentation related to how @FRAME-NAME@ would be used in a testcase. Searching through our... Roger Borrello
09:05 AM User Interface Feature #4609: rework scrolling approach to use an cleaner, MVC design
For a customer-specific grid widget, Vladimir wrote an alternative MVC scrolling implementation. The details are doc... Greg Shah
09:02 AM User Interface Feature #4609 (New): rework scrolling approach to use an cleaner, MVC design
Greg Shah

04/07/2020

05:19 PM Database Feature #4011: database/persistence layer performance improvements
While working with the @hotel_gui@ and in particular with embedded client I feel that FWD is non-deterministically un... Ovidiu Maxiniuc
04:46 PM Database Feature #3813: misc DB features part deux
The runtime support for the @DEFAULT-STRING@ (modulo the issue with EXTENT fields (see #3813-99) is finished.
Commit...
Igor Skornyakov
04:27 PM Database Feature #3813: misc DB features part deux
Greg Shah wrote:
> Most likely, the initial value for these problem cases should be the unknown value. Please check...
Igor Skornyakov
04:24 PM Database Feature #3813: misc DB features part deux
> I've implemented preventive pre-check in the getDefaultString and do not try to vet the values for the problematic ... Greg Shah
04:01 PM Database Feature #3813: misc DB features part deux
Greg Shah wrote:
> > Formally this issue is not related to #3813 and does not prevent tesing.
>
> We still should...
Igor Skornyakov
03:59 PM Database Feature #3813: misc DB features part deux
Greg Shah wrote:
> > I've found that current INITIAL attribute support generates exceptions for other data types (su...
Igor Skornyakov
03:48 PM Database Feature #3813: misc DB features part deux
> Formally this issue is not related to #3813 and does not prevent tesing.
We still should probably fix this now. ...
Greg Shah
03:37 PM Database Feature #3813: misc DB features part deux
Greg Shah wrote:
> Igor Skornyakov wrote:
> > On the conversion of the field definition
> > [...]
> > the time pa...
Igor Skornyakov
03:31 PM Database Feature #3813: misc DB features part deux
Another issue:
The converted statement @SessionUtils.setDateFormat(new character("ydm"))@ causes runtime exception:
...
Igor Skornyakov
03:30 PM Database Feature #3813: misc DB features part deux
> I've found that current INITIAL attribute support generates exceptions for other data types (such as raw or even ch... Greg Shah
03:27 PM Database Feature #3813: misc DB features part deux
Igor Skornyakov wrote:
> On the conversion of the field definition
> [...]
> the time part is lost.
Please show...
Greg Shah
03:23 PM Database Feature #3813: misc DB features part deux
Eric Faulhaber wrote:
> I don't think that was intentional. Please add it if you need it. My advice about @getPrecis...
Igor Skornyakov
03:21 PM Database Feature #3813: misc DB features part deux
In addition to the #3813-95, I've found that current @INITIAL@ attribute support generates exceptions for other data ... Igor Skornyakov
03:09 PM Database Feature #3813: misc DB features part deux
On the conversion of the field definition... Igor Skornyakov
02:56 PM Database Feature #3813: misc DB features part deux
Igor Skornyakov wrote:
> Eric Faulhaber wrote:
> > Where @foo@ represents a DMO and @bar@ is a @decimal@ property, ...
Eric Faulhaber
01:33 PM Database Feature #3813: misc DB features part deux
@DEFAULT-STRING@ uses only decimal separator when rendering @DECIMAL@ values. The value of the group separator is not... Igor Skornyakov
11:04 AM Database Feature #3813: misc DB features part deux
Greg Shah wrote:
> No. A format string is not the same thing as the @DATE-FORMAT@. A format string for @date@ migh...
Igor Skornyakov
10:45 AM Database Feature #3813: misc DB features part deux
> DEFAULT-STRING renders its dates and numeric values in LOCAL format, subject to the DATE-FORMAT and NUMERIC-FORMAT ... Greg Shah
08:23 AM Database Feature #3813: misc DB features part deux
Greg Shah wrote:
> The @date@, @datetime@, @datetime-tz@, @integer@, @int64@ and @decimal@ classes all are designed ...
Igor Skornyakov
08:14 AM Database Feature #3813: misc DB features part deux
The @date@, @datetime@, @datetime-tz@, @integer@, @int64@ and @decimal@ classes all are designed to format their stat... Greg Shah
07:51 AM Database Feature #3813: misc DB features part deux
Greg Shah wrote:
> Igor Skornyakov wrote:
> > Do we have methods for rendering date/numeric data using @SESSION:DAT...
Igor Skornyakov
07:46 AM Database Feature #3813: misc DB features part deux
Greg Shah wrote:
> > We need to correctly distinguish between datetime literal and valid expression as NOW. The firs...
Igor Skornyakov
07:39 AM Database Feature #3813: misc DB features part deux
> We need to correctly distinguish between datetime literal and valid expression as NOW. The first question is what c... Greg Shah
07:36 AM Database Feature #3813: misc DB features part deux
Igor Skornyakov wrote:
> Do we have methods for rendering date/numeric data using @SESSION:DATE-FORMAT@ and @SESSION...
Greg Shah
05:45 AM Database Feature #3813: misc DB features part deux
Do we have methods for rendering date/numeric data using @SESSION:DATE-FORMAT@ and @SESSION:NUMERIC-FORMAT@ attribute... Igor Skornyakov
05:39 AM Database Feature #3813: misc DB features part deux
Eric Faulhaber wrote:
> Where @foo@ represents a DMO and @bar@ is a @decimal@ property, the following will return th...
Igor Skornyakov
04:40 AM Database Feature #3813: misc DB features part deux
The issue described in the #3813-97 was a result of the following. I've compiled two tests. The TEMP-TABLE @source-da... Igor Skornyakov
03:35 AM Database Feature #3813: misc DB features part deux
Eric Faulhaber wrote:
> Where @foo@ represents a DMO and @bar@ is a @decimal@ property, the following will return th...
Igor Skornyakov
01:51 PM Base Language Feature #4384: Builtin OO Implementation
Greg Shah wrote:
> FYI, I have updated @https://proj.goldencode.com/downloads/skeletons/repo@ to rev 89 earlier toda...
Marian Edu
01:43 PM Base Language Feature #4384: Builtin OO Implementation
> Sounds simple enough, how do we know when we need to incorporate changes from 4231b, will someone notify us or we s... Greg Shah
01:39 PM Base Language Feature #4384: Builtin OO Implementation
Marian Edu wrote:
> Marian Edu wrote:
> > Constantin Asofiei wrote:
> > > I think is related to using a skeleton c...
Greg Shah
12:58 PM Base Language Feature #4384: Builtin OO Implementation
The fix is in 4231b rev 11427 on xfer. I should have added it to 4384a, sorry.
You can try the rebase now :)
Constantin Asofiei
12:53 PM Base Language Feature #4384: Builtin OO Implementation
Marian Edu wrote:
> Constantin Asofiei wrote:
> > I think is related to using a skeleton class. For example, at lea...
Marian Edu
12:42 PM Base Language Feature #4384: Builtin OO Implementation
Constantin Asofiei wrote:
> I think is related to using a skeleton class. For example, at least the skeleton methods...
Marian Edu
12:40 PM Base Language Feature #4384: Builtin OO Implementation
I think is related to using a skeleton class. For example, at least the skeleton methods are missing the @extent@ for... Constantin Asofiei
12:39 PM Base Language Feature #4384: Builtin OO Implementation
Marian Edu wrote:
> Constantin Asofiei wrote:
> > Marian Edu wrote:
> > > @Constantin, the code generated still do...
Marian Edu
12:26 PM Base Language Feature #4384: Builtin OO Implementation
Constantin Asofiei wrote:
> Marian Edu wrote:
> > @Constantin, the code generated still doesn't work for us when in...
Marian Edu
12:16 PM Base Language Feature #4384: Builtin OO Implementation
Greg Shah wrote:
> In fact, you can always rebase an unbound 4384a branch from the latest 4231b on xfer and then @...
Marian Edu
12:15 PM Base Language Feature #4384: Builtin OO Implementation
Marian Edu wrote:
> @Constantin, the code generated still doesn't work for us when indeterminate extents are used. T...
Constantin Asofiei
12:08 PM Base Language Feature #4384: Builtin OO Implementation
> OK, we will continue to work with our local git repository and only I will push changes to bazaar to keep it simple... Greg Shah
11:49 AM Base Language Feature #4384: Builtin OO Implementation
Constantin Asofiei wrote:
> Marian Edu wrote:
> > There was no cast in the conversion rule and we didn't changed th...
Marian Edu
11:18 AM Base Language Feature #4384: Builtin OO Implementation
Greg Shah wrote:
> Created branch 4384a, branched from 4231b revision 11425.
>
> Access it:
>
> @bzr co sftp:/...
Marian Edu
12:11 PM Base Language Bug #4602: fixes for OO 4GL and structured error handling
Another case to cover: simple statements with @NO-ERROR@, like @ch = h:name NO-ERROR.@ and @input from os-dir("missin... Constantin Asofiei

04/06/2020

07:29 PM Database Feature #3813: misc DB features part deux
Where @foo@ represents a DMO and @bar@ is a @decimal@ property, the following will return the value of DECIMAL from t... Eric Faulhaber
05:43 PM Database Feature #3813: misc DB features part deux
Igor Skornyakov wrote:
> I cannot find where the value of the DECIMAL option of the field definition is located in t...
Igor Skornyakov
05:38 PM Database Feature #3813: misc DB features part deux
I cannot find where the value of the DECIMAL option of the field definition is located in the conversion artifacts.
...
Igor Skornyakov
01:35 PM Database Feature #3813: misc DB features part deux
Ovidiu Maxiniuc wrote:
> I will schedule working on this issue. 4011a is not yet stable enough, but we'll see whethe...
Igor Skornyakov
01:29 PM Database Feature #3813: misc DB features part deux
> BTW: do I understand correctly that more complicated expressions cannot be used in the @INITIAL@ clause?
TBH, befo...
Ovidiu Maxiniuc
12:40 PM Database Feature #3813: misc DB features part deux
Ovidiu Maxiniuc wrote:
> I am working on 4011a branch, where the field's attributes (including the default value) ar...
Igor Skornyakov
12:29 PM Database Feature #3813: misc DB features part deux
The following field definition... Igor Skornyakov
12:26 PM Database Feature #3813: misc DB features part deux
I am working on 4011a branch, where the field's attributes (including the default value) are defined as DMO interface... Ovidiu Maxiniuc
11:40 AM Database Feature #3813: misc DB features part deux
At the moment FWD runtime support if the INITIAL attribute for fields like @FIELD s-datetime AS DATETIME INITIAL NOW@... Igor Skornyakov
09:57 AM Database Feature #3813: misc DB features part deux
Greg Shah wrote:
> Doesn't the @DEFAULT-VALUE@ of the DMO map more closely to @BUFFER-FIELD:DEFAULT-VALUE@ instead o...
Igor Skornyakov
09:50 AM Database Feature #3813: misc DB features part deux
Doesn't the @DEFAULT-VALUE@ of the DMO map more closely to @BUFFER-FIELD:DEFAULT-VALUE@ instead of using the @DEFAULT... Greg Shah
09:42 AM Database Feature #3813: misc DB features part deux
We have no support for the BUFFER-FIELD:DEFAULT-VALUE (even conversion is not supported). This can be a little bit tr... Igor Skornyakov
04:33 PM User Interface Feature #4164: implement misc UI features (frame options, misc attributes)
Greg Shah wrote:
> Make a list of the problems here and fix them.
>1. What do these return before the frame is real...
Roger Borrello
03:31 PM Base Language Feature #4384: Builtin OO Implementation
Created branch 4384a, branched from 4231b revision 11425.
Access it:
@bzr co sftp://<userid>@xfer.goldencode.co...
Greg Shah
07:34 AM Database Feature #4011: database/persistence layer performance improvements
Eric Faulhaber wrote:
> Which revision of hotel_gui are you using with 4011a/11404?
I found r202 of hotel_gui is wh...
Ovidiu Maxiniuc

04/05/2020

06:08 PM Database Feature #4011: database/persistence layer performance improvements
Ovidiu Maxiniuc wrote:
> I have committed my latest changes to 4011a as r11404.
> The standalone hotel_gui is start...
Eric Faulhaber
07:52 AM Database Feature #4011: database/persistence layer performance improvements
I have committed my latest changes to 4011a as r11404.
The standalone hotel_gui is starting up and tabs can be navig...
Ovidiu Maxiniuc
07:37 AM Database Feature #4011: database/persistence layer performance improvements
> This is a non-orthodox workaround.
You're being kind. Let us call it what it is: an ugly solution. Unfortunate...
Greg Shah

04/04/2020

06:24 PM Database Feature #4011: database/persistence layer performance improvements
Greg, thanks for suggestion. This is a non-orthodox workaround. Here is what I've done.
I altered @NUM_LITERAL@ in l...
Ovidiu Maxiniuc

04/03/2020

06:33 PM Database Feature #3813: misc DB features part deux
By the end of the weekend, please report the list of open items remaining in this task. We can push the #3813-81 it... Greg Shah
06:31 PM Database Feature #4011: database/persistence layer performance improvements
Is the column name version of @order@ always "qualified" (e.g. @tt1.order@)? If so, then you can easily differentiat... Greg Shah
05:29 PM Database Feature #4011: database/persistence layer performance improvements
In fact, @by@ does not suffer from this inconvenient as it is already a Progress reserved keyword and cannot be the n... Ovidiu Maxiniuc
04:59 PM Database Feature #4011: database/persistence layer performance improvements
I encountered the following issue and I see no easy trick to work around. It is a antlr issue I think. Suppose we hav... Ovidiu Maxiniuc
01:00 PM User Interface Feature #4164: implement misc UI features (frame options, misc attributes)
Make a list of the problems here and fix them. Greg Shah
12:33 PM User Interface Feature #4164: implement misc UI features (frame options, misc attributes)
I'll update, now that I (finally) understand. I do have some initial items, some not related to this testcase, but be... Roger Borrello
11:19 AM User Interface Feature #4164: implement misc UI features (frame options, misc attributes)
I think you should check the @FRAME-ROW(frame)@ builtin for all of the same case.
Make sure to test:
* What do ...
Greg Shah
10:38 AM User Interface Feature #4164: implement misc UI features (frame options, misc attributes)
Greg Shah wrote:
> > That is not really correct, because the attribute is off the widget, in this case i.
>
> Pl...
Roger Borrello
10:16 AM User Interface Feature #4164: implement misc UI features (frame options, misc attributes)
> That is not really correct, because the attribute is off the widget, in this case i.
Please read #4164-1 more c...
Greg Shah
09:54 AM User Interface Feature #4164: implement misc UI features (frame options, misc attributes)
Greg Shah wrote:
> All you care about is positioning the frame in different locations.
That is not really corre...
Roger Borrello
09:34 AM User Interface Feature #4164: implement misc UI features (frame options, misc attributes)
I had a testcase:... Roger Borrello
08:53 AM User Interface Feature #4164: implement misc UI features (frame options, misc attributes)
All you care about is positioning the frame in different locations. This is trivial to do in the AT phrase of the fr... Greg Shah
09:54 AM Base Language Feature #4384: Builtin OO Implementation
Marian Edu wrote:
> There was no cast in the conversion rule and we didn't changed the rules simply modified the gen...
Constantin Asofiei
09:49 AM Base Language Feature #4384: Builtin OO Implementation
Constantin Asofiei wrote:
> Marian, there's a FWD conversion bug for this extent assign case. I'll fix it.
>
> W...
Marian Edu
09:38 AM Base Language Feature #4384: Builtin OO Implementation
Marian, there's a FWD conversion bug for this extent assign case. I'll fix it.
What's the signature for @assignMu...
Constantin Asofiei
09:25 AM Base Language Feature #4384: Builtin OO Implementation
Marian Edu wrote:
> fixes the reference but the uncheck cast is ugly to say at least :(
Changing the @assignMulti...
Marian Edu
09:15 AM Base Language Feature #4384: Builtin OO Implementation
Constantin Asofiei wrote:
> Marian, what's the use case for the extent problem? Can you modify it so that it uses a ...
Marian Edu

04/02/2020

05:40 PM User Interface Bug #4604: DCOLOR on FRAME or BROWSE TITLE phrase results in title not being displayed
Using @4231b-11418@:
Testcase @./uast/frame_title_color_default_values.p@ shows that @define frame@ with a title p...
Roger Borrello
09:04 AM User Interface Bug #4604: DCOLOR on FRAME or BROWSE TITLE phrase results in title not being displayed
Please document the testcase and the trunk revision in which this can be recreated. Greg Shah
08:22 AM Database Feature #3813: misc DB features part deux
Contrary to what is said in the Progress documentation the @DEFAULT-STRING@ attribute is read-only. This is logical a... Igor Skornyakov

04/01/2020

06:54 PM User Interface Bug #4604 (New): DCOLOR on FRAME or BROWSE TITLE phrase results in title not being displayed
Roger Borrello
01:58 PM User Interface Feature #4393: add TITLE-DCOLOR attribute support
Yes, it could be a version difference. Run the testcases on both 10.x and 11.x and record the differences only. The... Greg Shah
12:22 PM User Interface Feature #4393: add TITLE-DCOLOR attribute support
I was re-running @frame_title_color_attributes.p@ to try to close this task down, and I was running on OE release 10.... Roger Borrello
10:53 AM User Interface Feature #4393: add TITLE-DCOLOR attribute support
h2. Browse TITLE Attribute Defaults (before/after realization)
|_. |_. ChUI (bef) |_. ChUI (aft) |_. GUI (...
Roger Borrello
08:09 PM User Interface Feature #4393: add TITLE-DCOLOR attribute support
> Should I remove the comment: "For the browse options phrase, only the TITLE DCOLOR <num> "title" form can be used..... Greg Shah
01:13 PM Base Language Feature #4384: Builtin OO Implementation
Constantin Asofiei wrote:
> Marian Edu wrote:
> > Tried various combinations, none seems to work. Anything else we ...
Marian Edu
12:59 PM Base Language Feature #4384: Builtin OO Implementation
Marian Edu wrote:
> Tried various combinations, none seems to work. Anything else we need to do apart from @gradle j...
Constantin Asofiei
12:44 PM Base Language Feature #4384: Builtin OO Implementation
Constantin Asofiei wrote:
> The error fixes mentioned in #4384-121 are in 4231b rev 11406 - xfer was updated.
@Co...
Marian Edu
12:43 PM Base Language Feature #4384: Builtin OO Implementation
Constantin Asofiei wrote:
> Marian Edu wrote:
> > OK, so the one that already exist we do not 'refactor' but we nee...
Marian Edu
12:01 PM Base Language Feature #4384: Builtin OO Implementation
OK Greg Shah
11:34 AM Base Language Feature #4384: Builtin OO Implementation
Marian Edu wrote:
> OK, so the one that already exist we do not 'refactor' but we need to add them as exceptions.
...
Constantin Asofiei
11:30 AM Base Language Feature #4384: Builtin OO Implementation
Constantin Asofiei wrote:
> This one, and maybe others, I think were added early on, and were written 'by hand', wit...
Marian Edu
11:17 AM Base Language Feature #4384: Builtin OO Implementation
> One way would be to find the p2j.oo equivalent automatically (searching for the LegacyResource annotation), and use... Greg Shah
11:11 AM Base Language Feature #4384: Builtin OO Implementation
Marian Edu wrote:
> That's exactly what we did and observed the pattern we described, problem is for instance @IHttp...
Constantin Asofiei
11:09 AM Base Language Feature #4384: Builtin OO Implementation
Greg Shah wrote:
> > Greg: for the skeleton classes, the Java equivalent is the one returned by our NameConverter ru...
Constantin Asofiei
11:07 AM Base Language Feature #4384: Builtin OO Implementation
Constantin Asofiei wrote:
> Greg: for the skeleton classes, the Java equivalent is the one returned by our @NameConv...
Marian Edu
11:05 AM Base Language Feature #4384: Builtin OO Implementation
> Greg: for the skeleton classes, the Java equivalent is the one returned by our NameConverter rules - a IWebHandler ... Greg Shah
11:02 AM Base Language Feature #4384: Builtin OO Implementation
Greg: for the skeleton classes, the Java equivalent is the one returned by our @NameConverter@ rules - a @IWebHandler... Constantin Asofiei
11:01 AM Base Language Feature #4384: Builtin OO Implementation
>> Yes, but in Java we use "camel cased" names.
>
> camel case for variables, class names are still pascal case it ...
Greg Shah
09:57 AM Base Language Feature #4384: Builtin OO Implementation
Greg Shah wrote:
>
> Yes, but in Java we use "camel cased" names.
camel case for variables, class names are still...
Marian Edu
09:46 AM Base Language Feature #4384: Builtin OO Implementation
> it seems the conversion translate the OE names to all lower for the package name
Yes. Except the @Progress@ and...
Greg Shah
08:56 AM Base Language Feature #4384: Builtin OO Implementation
Quick question on naming convention, for interfaces it seems the conversion translate the OE names to all lower for t... Marian Edu
11:47 AM Database Feature #4011: database/persistence layer performance improvements
Greg Shah wrote:
> > There is another issue which I have in mind: when creating a savepoint, shouldn't we also sav...
Eric Faulhaber
11:36 AM Database Feature #4011: database/persistence layer performance improvements
Greg Shah wrote:
> What happens if in the meantime between the roll-forward and the original execution of a statem...
Eric Faulhaber
07:39 AM Database Feature #4011: database/persistence layer performance improvements
> maybe, instead of trying to track NO-UNDO DMOs as POJOs, I need to track the SQL statements that were rolled back a... Greg Shah
07:21 AM Database Feature #4011: database/persistence layer performance improvements
Eric, this FFD replay is the same though I had in mind. I don't think we can keep the database in good condition and ... Ovidiu Maxiniuc

03/31/2020

07:00 PM User Interface Feature #4393: add TITLE-DCOLOR attribute support
Made updates in Rev11413. I was attempting to get the title to appear when @DCOLOR@ was part of the title phrase. Thi... Roger Borrello
05:05 PM User Interface Feature #4393: add TITLE-DCOLOR attribute support
Greg Shah wrote:
> No, looking back on things they are all possible. I didn't update the comment in @frame_generato...
Roger Borrello
04:02 PM User Interface Feature #4393: add TITLE-DCOLOR attribute support
No, looking back on things they are all possible. I didn't update the comment in @frame_generator.xml@ but the notes... Greg Shah
03:45 PM User Interface Feature #4393: add TITLE-DCOLOR attribute support
Greg Shah wrote:
> See the @gen_color@ in @frame_generator.xml@. It should only be generating code for @TITLE DCOLO...
Roger Borrello
03:18 PM User Interface Feature #4393: add TITLE-DCOLOR attribute support
Not sure the @realized@ flag is correct.
See the @gen_color@ in @frame_generator.xml@. It should only be generati...
Greg Shah
03:13 PM User Interface Feature #4393: add TITLE-DCOLOR attribute support
Greg Shah wrote:
> I guess you are referencing @testcases/uast/browse_title_color_options.p@. Options are not attri...
Roger Borrello
03:12 PM User Interface Feature #4393: add TITLE-DCOLOR attribute support
Greg Shah wrote:
> What testcase are you using? The code in @testcases/uast/browse_title_color_attributes.p@ doesn'...
Roger Borrello
03:11 PM User Interface Feature #4393: add TITLE-DCOLOR attribute support
I guess you are referencing @testcases/uast/browse_title_color_options.p@. Options are not attributes. The text abo... Greg Shah
02:46 PM User Interface Feature #4393: add TITLE-DCOLOR attribute support
What testcase are you using? The code in @testcases/uast/browse_title_color_attributes.p@ doesn't look anything like... Greg Shah
02:16 PM User Interface Feature #4393: add TITLE-DCOLOR attribute support
Another issue I am looking at. The browse title is missing, if @DCOLOR@ is part of the options:
!GUI_browse_title_...
Roger Borrello
01:45 PM User Interface Feature #4393: add TITLE-DCOLOR attribute support
Greg Shah wrote:
> Be more specific. In which testscase and for which lines of code is this happening? GUI, ChUI? ...
Roger Borrello
01:11 PM User Interface Feature #4393: add TITLE-DCOLOR attribute support
> I see the testcase in FWD displays 4052 in a popup for every browse widget.
Be more specific. In which testsca...
Greg Shah
12:42 PM User Interface Feature #4393: add TITLE-DCOLOR attribute support
Done, but in my testing, I see the testcase in FWD displays 4052 in a popup for every browse widget. Either I need to... Roger Borrello
12:22 PM User Interface Feature #4393: add TITLE-DCOLOR attribute support
So @setTitleColor(ColorSpec)@ was just missing. My changes fixed the conversion, but you will need to add the runtim... Greg Shah
12:14 PM User Interface Feature #4393: add TITLE-DCOLOR attribute support
Greg Shah wrote:
> What happens in trunk?...
Roger Borrello
12:07 PM User Interface Feature #4393: add TITLE-DCOLOR attribute support
> It looks like setTitleColor needs to be implemented. I have added it to BrowseWidget and I believe the interface is... Greg Shah
11:55 AM User Interface Feature #4393: add TITLE-DCOLOR attribute support
Compilation of the testcase:... Roger Borrello
11:52 AM User Interface Feature #4393: add TITLE-DCOLOR attribute support
Roger Borrello wrote:
> Converting the @browse_title_color_options.p@ testcase, @setTitleColor@ is unresolved. Did t...
Greg Shah
11:43 AM User Interface Feature #4393: add TITLE-DCOLOR attribute support
Converting the @browse_title_color_options.p@ testcase, @setTitleColor@ is unresolved. Did that method ne get overloo... Roger Borrello
11:31 AM User Interface Feature #4393: add TITLE-DCOLOR attribute support
Code Review updates made:... Roger Borrello
10:55 AM User Interface Feature #4393: add TITLE-DCOLOR attribute support
Greg Shah wrote:
> For now, I'm just suggesting that you create a helper for @BrowseWidget@, so make common code ins...
Roger Borrello
10:14 AM User Interface Feature #4393: add TITLE-DCOLOR attribute support
For now, I'm just suggesting that you create a helper for @BrowseWidget@, so make common code instead of the duplicat... Greg Shah
10:12 AM User Interface Feature #4393: add TITLE-DCOLOR attribute support
Greg Shah wrote:
> Anytime you are writing the same code over and over, you can make a helper. It is ALWAYS better ...
Roger Borrello
09:52 AM User Interface Feature #4393: add TITLE-DCOLOR attribute support
Anytime you are writing the same code over and over, you can make a helper. It is ALWAYS better than copying the cod... Greg Shah
09:45 AM User Interface Feature #4393: add TITLE-DCOLOR attribute support
Greg Shah wrote:
> Code Review Task Branch 4231b Revision 11407
> 4. In @BrowseWidget@, you would have much less co...
Roger Borrello
09:06 AM User Interface Feature #4393: add TITLE-DCOLOR attribute support
> Just to be sure... you want comments removed?
Yes.
> Isn't there any usefulness to tieing the keyword to the...
Greg Shah
09:03 AM User Interface Feature #4393: add TITLE-DCOLOR attribute support
Greg Shah wrote:
> Code Review Task Branch 4231b Revision 11407
>
> 1. In @gaps/expressions.rules@, the @kw_tit*@...
Roger Borrello
08:39 AM User Interface Feature #4393: add TITLE-DCOLOR attribute support
Code Review Task Branch 4231b Revision 11407
1. In @gaps/expressions.rules@, the @kw_tit*@ comments should be remo...
Greg Shah
06:25 PM Database Feature #4011: database/persistence layer performance improvements
I've been struggling with how to fit a bulk delete (i.e., @delete from <table> [ where <condition> ]@) which operates... Eric Faulhaber
11:00 AM User Interface Feature #4394: add some frame options and attributes
@SCROLL@ and @NO-ATTR-SPACE@ will be finished in #4164. The only thing needed for this task is @FRAME-NAME@. Greg Shah
10:14 AM Database Feature #3813: misc DB features part deux
Working on @BUFFER-FIELD:DEFAULT-STRING@ and @BUFFER-DECIMALS@ attributes support. Igor Skornyakov
03:16 AM Base Language Feature #4384: Builtin OO Implementation
Marian Edu wrote:
> But didn't you mentioned c'tors are already treated differently in FWD? Not sure if we have that...
Constantin Asofiei
02:45 AM Base Language Feature #4384: Builtin OO Implementation
Constantin Asofiei wrote:
> The error fixes mentioned in #4384-121 are in 4231b rev 11406 - xfer was updated.
OK,...
Marian Edu
02:41 AM Base Language Feature #4384: Builtin OO Implementation
Constantin Asofiei wrote:
> I have FWD fixes for cases of 'nested' calls (for ctors, methods, internal procedures, d...
Marian Edu
02:31 AM Base Language Feature #4384: Builtin OO Implementation
Constantin Asofiei wrote:
> Marian, what's the use case for the extent problem? Can you modify it so that it uses a ...
Marian Edu

03/30/2020

04:14 PM User Interface Feature #4393: add TITLE-DCOLOR attribute support
Committed updates:... Roger Borrello
03:59 PM User Interface Feature #4393: add TITLE-DCOLOR attribute support
Roger Borrello wrote:
> Currently looking at why the @./uast/menu/menu_title_color_attributes.p@ testcase fails in *...
Roger Borrello
03:21 PM User Interface Feature #4393: add TITLE-DCOLOR attribute support
Currently looking at why the @./uast/menu/menu_title_color_attributes.p@ testcase fails in *Core Code Conversion*:
<...
Roger Borrello
02:17 PM User Interface Feature #4393: add TITLE-DCOLOR attribute support
Same issues occur with @trunk@. I'll focus on implementation, but these will prevent validation of the implementation... Roger Borrello
02:10 PM User Interface Feature #4393: add TITLE-DCOLOR attribute support
Greg Shah wrote:
> What do you mean by "build"? It parsed fine.
When I tried to convert the @./uast/browse_title...
Roger Borrello
02:04 PM User Interface Feature #4393: add TITLE-DCOLOR attribute support
What do you mean by "build"? It parsed fine. Greg Shah
02:03 PM User Interface Feature #4393: add TITLE-DCOLOR attribute support
Suddenly that implementation seems secondary to an issue that came up when I tried to build @./uast/browse_title_colo... Roger Borrello
02:00 PM User Interface Feature #4393: add TITLE-DCOLOR attribute support
The frame definitions will use @setTitle*(long)@. It is possible for the attribute usage to convert this way too, un... Greg Shah
01:51 PM User Interface Feature #4393: add TITLE-DCOLOR attribute support
Doesn't the @int64@ interface to the converted 4GL? Perhaps that's what is confusing me. Is there a @long@ interface ... Roger Borrello
12:52 PM User Interface Feature #4393: add TITLE-DCOLOR attribute support
No.
> Just reverse the logic. The long version calls the wrapper version.
This means that @setTitleFgColor(...
Greg Shah
12:25 PM User Interface Feature #4393: add TITLE-DCOLOR attribute support
I see the missing "new" in there. Roger Borrello
12:20 PM User Interface Feature #4393: add TITLE-DCOLOR attribute support
Greg Shah wrote:
> You did not reverse the logic.
Like this?...
Roger Borrello
11:37 AM User Interface Feature #4393: add TITLE-DCOLOR attribute support
You did not reverse the logic. Greg Shah
11:23 AM User Interface Feature #4393: add TITLE-DCOLOR attribute support
Greg Shah wrote:
> Just reverse the logic. The @long@ version calls the wrapper version.
Can you review this imp...
Roger Borrello
11:19 AM User Interface Feature #4393: add TITLE-DCOLOR attribute support
Just reverse the logic. The @long@ version calls the wrapper version. Greg Shah
10:49 AM User Interface Feature #4393: add TITLE-DCOLOR attribute support
The previous convention for the setters had the @int64@ versions calling the @long@ versions:... Roger Borrello
10:24 AM User Interface Feature #4393: add TITLE-DCOLOR attribute support
> For the cases where menu TITLE- attributes are actually handled (TITLE-BGCOLOR, TITLE-FGCOLOR and TITLE-FONT), but ... Greg Shah
10:07 AM User Interface Feature #4393: add TITLE-DCOLOR attribute support
For the cases where @menu TITLE-@ attributes are actually handled (TITLE-BGCOLOR, TITLE-FGCOLOR and TITLE-FONT), but ... Roger Borrello
09:20 AM User Interface Feature #4393: add TITLE-DCOLOR attribute support
Yes. Greg Shah
09:20 AM User Interface Feature #4393: add TITLE-DCOLOR attribute support
In @MenuWidget@, is it adequate to utilize @config.popupOnly@ to determine between popup and non-popup menus for the ... Roger Borrello
03:51 PM Database Feature #4011: database/persistence layer performance improvements
Ovidiu Maxiniuc wrote:
> OTOH, in case of the TEMP-TABLEs, there is the case when two independent tables are defin...
Eric Faulhaber
11:38 AM Database Feature #4011: database/persistence layer performance improvements
My concerns on different @extent@ fields were related to @shared@ tables. However, re-reading #2942 notes I see that ... Ovidiu Maxiniuc
09:53 AM Database Feature #4011: database/persistence layer performance improvements
I really like your proposal as well. It seems "more correct" and it reads better.
In regard to the question "whic...
Greg Shah
09:47 AM Database Feature #4011: database/persistence layer performance improvements
Eric Faulhaber wrote:
> Ovidiu, I like the chaining approach. This is an approach I have adopted with other new APIs...
Ovidiu Maxiniuc
09:42 AM Database Feature #4011: database/persistence layer performance improvements
Constantin Asofiei wrote:
> I think your solution can limit the legacy annotations to only schema-related informatio...
Ovidiu Maxiniuc
02:39 PM Base Language Bug #4602: fixes for OO 4GL and structured error handling
From #4384-121:
> I have FWD fixes for cases of 'nested' calls (for ctors, methods, internal procedures, dynamic f...
Constantin Asofiei
02:32 PM Base Language Bug #4602 (Review): fixes for OO 4GL and structured error handling
Constantin Asofiei
02:31 PM Base Language Feature #4384: Builtin OO Implementation
Marian, what's the use case for the extent problem? Can you modify it so that it uses a fixed extent? Or to execute ... Constantin Asofiei
02:02 PM Base Language Feature #4384: Builtin OO Implementation
> From these, I think only the last two may need explicit fixing - as it looks like the ERROR can be 'eaten' by a par... Greg Shah
01:08 PM Base Language Feature #4384: Builtin OO Implementation
Marian Edu wrote:
> We have an issue with the 'extent' variables here, we get at NPE on @ArrayAssigner.registerDynam...
Constantin Asofiei
12:55 PM Base Language Feature #4384: Builtin OO Implementation
I have FWD fixes for cases of 'nested' calls (for ctors, methods, internal procedures, dynamic functions), which cove... Constantin Asofiei
04:51 AM Base Language Feature #4384: Builtin OO Implementation
We have an issue with the 'extent' variables here, we get at NPE on @ArrayAssigner.registerDynamicArray@ because as t... Marian Edu

03/28/2020

04:54 PM Database Feature #4011: database/persistence layer performance improvements
Ovidiu, I like the chaining approach. This is an approach I have adopted with other new APIs which have lots of possi... Eric Faulhaber
09:57 AM Database Feature #4011: database/persistence layer performance improvements
Ovidiu, your idea of setting these non-schema settings for a temp-table at the program where it is defined is interes... Constantin Asofiei
12:17 PM Base Language Feature #4384: Builtin OO Implementation
Constantin Asofiei wrote:
> Marian Edu wrote:
> > Maybe this is the issue, we're using an @internalProcedure@ block...
Marian Edu

03/27/2020

07:44 PM Database Feature #4011: database/persistence layer performance improvements
We are talking about two different types of 'attributes' of the temp-tables:
* structural (actual data structure, m...
Ovidiu Maxiniuc
01:59 PM Database Feature #4011: database/persistence layer performance improvements
Eric Faulhaber wrote:
> If we were generating different DMO types for differences in certain [temp-]table attributes...
Constantin Asofiei
01:34 PM Database Feature #4011: database/persistence layer performance improvements
I'm pretty sure we were never generating more than one DMO implementation class per DMO interface. These were designe... Eric Faulhaber
01:30 PM Database Feature #4011: database/persistence layer performance improvements
Ovidiu Maxiniuc wrote:
> Constantin, you are right, one of the @xml-node-name@ s will be lost in this case.
This wa...
Constantin Asofiei
01:22 PM Database Feature #4011: database/persistence layer performance improvements
Constantin, you are right, one of the @xml-node-name@ s will be lost in this case.
However, this is a bug (I can say...
Ovidiu Maxiniuc
01:06 PM Database Feature #4011: database/persistence layer performance improvements
Eric Faulhaber wrote:
> Constantin Asofiei wrote:
> > Eric/Ovidiu: maybe you've already considered, but please keep...
Constantin Asofiei
01:01 PM Database Feature #4011: database/persistence layer performance improvements
Constantin Asofiei wrote:
> Eric/Ovidiu: maybe you've already considered, but please keep in mind also the 'resource...
Eric Faulhaber
11:47 AM Database Feature #4011: database/persistence layer performance improvements
Eric/Ovidiu: maybe you've already considered, but please keep in mind also the 'resource' behavior for temp-tables (w... Constantin Asofiei
11:23 AM Database Feature #4011: database/persistence layer performance improvements
Less is more. I see no reason a customer would want the same structure duplicated just to get the affect of setting ... Greg Shah
11:20 AM Database Feature #4011: database/persistence layer performance improvements
Greg Shah wrote:
> > I suppose an alternative is to include NO-UNDO among the criteria which differentiates DMO inte...
Eric Faulhaber
11:12 AM Database Feature #4011: database/persistence layer performance improvements
> I suppose an alternative is to include NO-UNDO among the criteria which differentiates DMO interfaces during conver... Greg Shah
10:55 AM Database Feature #4011: database/persistence layer performance improvements
So, what I understand from your comment is that the NO-UNDO state is a property of the table the record belongs to (i... Eric Faulhaber
10:40 AM Database Feature #4011: database/persistence layer performance improvements
How can we test that? The only way is to use @buffer-copy@, but this will copy field by field, not the whole record.
...
Ovidiu Maxiniuc
10:30 AM Database Feature #4011: database/persistence layer performance improvements
I guess the better question is whether it is possible for the same data record to be used by such temp-tables (i.e., ... Eric Faulhaber
09:09 AM Database Feature #4011: database/persistence layer performance improvements
Eric Faulhaber wrote:
> Ovidiu, if two temp-tables are defined identically, except that one is declared NO-UNDO and ...
Ovidiu Maxiniuc
04:28 AM Database Feature #4011: database/persistence layer performance improvements
Ovidiu, if two temp-tables are defined identically, except that one is declared NO-UNDO and the other is not, do we g... Eric Faulhaber
06:53 PM User Interface Feature #4393: add TITLE-DCOLOR attribute support
Cleaned up and checked in:... Roger Borrello
05:48 PM User Interface Feature #4393: add TITLE-DCOLOR attribute support
> All the ChUI tests passed side-by-side, except for the fact that the color schemes seemed different. There were oft... Greg Shah
05:44 PM User Interface Feature #4393: add TITLE-DCOLOR attribute support
Remove all getters. Remove the @int64@ setters. Only the @long@ setters should be in either @CommonFrame@ or @Gener... Greg Shah
05:43 PM User Interface Feature #4393: add TITLE-DCOLOR attribute support
Roger Borrello wrote:
> Greg Shah wrote:
>
> > We need the @setTitle*(long)@ methods in @CommonFrame@. That is i...
Greg Shah
05:42 PM User Interface Feature #4393: add TITLE-DCOLOR attribute support
Greg Shah wrote:
> We need the @setTitle*(long)@ methods in @CommonFrame@. That is it. Don't add the full @Title...
Roger Borrello
05:22 PM User Interface Feature #4393: add TITLE-DCOLOR attribute support
I will go back and update per your last note. I was writing the below while you made your update:
All the ChUI tes...
Roger Borrello
05:19 PM User Interface Feature #4393: add TITLE-DCOLOR attribute support
> Menus and Browse don't have the same complexity of the class structure, do they?
No, they don't.
> All the fr...
Greg Shah
04:39 PM User Interface Feature #4393: add TITLE-DCOLOR attribute support
Roger Borrello wrote:
> The frames are CommonFrame, and trying to access the methods which aren't in that interface....
Roger Borrello
03:57 PM User Interface Feature #4393: add TITLE-DCOLOR attribute support
The frames are CommonFrame, and trying to access the methods which aren't in that interface.... Roger Borrello
03:45 PM User Interface Feature #4393: add TITLE-DCOLOR attribute support
Roger Borrello wrote:
> Updates for frames in *4231b-11400*.
Hold on... a couple more frame testcases to validate...
Roger Borrello
03:41 PM User Interface Feature #4393: add TITLE-DCOLOR attribute support
Updates for frames in *4231b-11400*. Roger Borrello
03:26 PM User Interface Feature #4393: add TITLE-DCOLOR attribute support
Greg Shah wrote:
> Try @frame df:title-dcolor = 1@ instead of @3@ on line 208 of @testcases/uast/frame_title_color_a...
Roger Borrello
03:22 PM User Interface Feature #4393: add TITLE-DCOLOR attribute support
Try @frame df:title-dcolor = 1@ instead of @3@ on line 208 of @testcases/uast/frame_title_color_attributes.p@. You s... Greg Shah
03:11 PM User Interface Feature #4393: add TITLE-DCOLOR attribute support
My previous note was stating the "current" state, so thank you for clarifying.
With respect to the ChUI testing, I...
Roger Borrello
02:17 PM User Interface Feature #4393: add TITLE-DCOLOR attribute support
> TitiledElement - leave alone
Yes
> CommonFrame - currently an inteface that extends TitledElement. No getters...
Greg Shah
01:51 PM User Interface Feature #4393: add TITLE-DCOLOR attribute support
Greg Shah wrote:
> Yes, I'm thinking that we leave the frame options in @CommonFrame@/@GenericFrame@. These are jus...
Roger Borrello
09:56 AM User Interface Feature #4393: add TITLE-DCOLOR attribute support
Yes, I'm thinking that we leave the frame options in @CommonFrame@/@GenericFrame@. These are just the setters (@setT... Greg Shah
09:52 AM User Interface Feature #4393: add TITLE-DCOLOR attribute support
Greg Shah wrote:
> > Or, do you mean to convert frame f1:<widget/method> differently, and access the asWidget() meth...
Constantin Asofiei
09:48 AM User Interface Feature #4393: add TITLE-DCOLOR attribute support
> Or, do you mean to convert frame f1:<widget/method> differently, and access the asWidget() method directly?
Yes,...
Greg Shah
09:46 AM User Interface Feature #4393: add TITLE-DCOLOR attribute support
Greg Shah wrote:
> I was thinking about the dual nature, but I guess I got part of it backwards. If not present in ...
Constantin Asofiei
09:39 AM User Interface Feature #4393: add TITLE-DCOLOR attribute support
I was thinking about the dual nature, but I guess I got part of it backwards. If not present in @widget_references.r... Greg Shah
09:25 AM User Interface Feature #4393: add TITLE-DCOLOR attribute support
Greg Shah wrote:
> Roger: If I'm right, then you would remove all the changes from @FrameWidget@ and just put them i...
Constantin Asofiei
09:12 AM User Interface Feature #4393: add TITLE-DCOLOR attribute support
Roger: If I'm right, then you would remove all the changes from @FrameWidget@ and just put them in @GenericFrame@. Greg Shah
09:12 AM User Interface Feature #4393: add TITLE-DCOLOR attribute support
Code Review Task Branch 4231b Revision 11399
OK, you are close here.
Looking deeper at the changes in @widget_r...
Greg Shah
11:15 AM Base Language Feature #4384: Builtin OO Implementation
Marian Edu wrote:
> Maybe this is the issue, we're using an @internalProcedure@ block for constructors so it should ...
Constantin Asofiei
10:00 AM Base Language Feature #4384: Builtin OO Implementation
Constantin Asofiei wrote:
> A @RETUNR ERROR "foo"@ sets the @RETURN-VALUE@ in some cases. And if there is no @BLOCK...
Marian Edu
09:35 AM Base Language Feature #4384: Builtin OO Implementation
Marian Edu wrote:
> - there is no real difference between return error, return error new AppError (I think this stat...
Constantin Asofiei
09:26 AM Base Language Feature #4384: Builtin OO Implementation
Greg Shah wrote:
> OK, that is fair. We need to handle all cases with compatibility before implementing any optimiz...
Marian Edu
09:14 AM Base Language Feature #4384: Builtin OO Implementation
OK, that is fair. We need to handle all cases with compatibility before implementing any optimizations. Greg Shah
09:03 AM Base Language Feature #4384: Builtin OO Implementation
Greg Shah wrote:
> In regard to 4231b rev 11398, do we need to loop through the enclosing blocks in @BlockManager.pr...
Constantin Asofiei
08:54 AM Base Language Feature #4384: Builtin OO Implementation
In regard to 4231b rev 11398, do we need to loop through the enclosing blocks in @BlockManager.processLegacyError()@ ... Greg Shah
07:19 AM Base Language Feature #4384: Builtin OO Implementation
Marian Edu wrote:
> Marian Edu wrote:
> > Will try to change the test to see if that is still the case, right now t...
Constantin Asofiei
05:45 AM Base Language Feature #4384: Builtin OO Implementation
Marian Edu wrote:
> Will try to change the test to see if that is still the case, right now the errors are not being...
Marian Edu
05:33 AM Base Language Feature #4384: Builtin OO Implementation
Constantin Asofiei wrote:
> I think your problem is now fixed in 4231b 11398 (xfer was updated, too). Please test.
...
Marian Edu

03/26/2020

07:34 PM User Interface Feature #4393: add TITLE-DCOLOR attribute support
Roger Borrello wrote:
> Right now, the error message is being displayed, but the client is cycling in a loop, and no...
Roger Borrello
07:06 PM User Interface Feature #4393: add TITLE-DCOLOR attribute support
Look at the Hotel ChUI @p2j.cfg.xml@ for clues. You can also add things to that project to test, though the regular ... Greg Shah
06:43 PM User Interface Feature #4393: add TITLE-DCOLOR attribute support
For the ChUI, what is the key to building it as-if using ChUI development, so that @&quot;{&amp;window-system}&quot; ... Roger Borrello
05:08 PM User Interface Feature #4393: add TITLE-DCOLOR attribute support
I have the @frame_title_color_attributes.p@ testcase working on GUI. There are some differences, between FWD and 4GL,... Roger Borrello
04:48 PM User Interface Feature #4393: add TITLE-DCOLOR attribute support
Correct. Greg Shah
04:34 PM User Interface Feature #4393: add TITLE-DCOLOR attribute support
In @common-progress.rules:read_only_attribute@ is included @prog.kw_titl_bgc@. I am going to remove this, since we ca... Roger Borrello
03:52 PM User Interface Feature #4393: add TITLE-DCOLOR attribute support
Nevermind. Found the sources to our @readOnlyError@. Roger Borrello
03:43 PM User Interface Feature #4393: add TITLE-DCOLOR attribute support
Greg Shah wrote:
> Figure out why the @getTitleFont()@ is converting differently than @getTitleBgColor()@. The font...
Roger Borrello
02:59 PM User Interface Feature #4393: add TITLE-DCOLOR attribute support
Figure out why the @getTitleFont()@ is converting differently than @getTitleBgColor()@. The font is not converting t... Greg Shah
02:57 PM User Interface Feature #4393: add TITLE-DCOLOR attribute support
No, I don't think so. Greg Shah
02:56 PM User Interface Feature #4393: add TITLE-DCOLOR attribute support
Greg Shah wrote:
> Why would we want it to be @extends@?
I don't want to do that. I believe I need to add our get...
Roger Borrello
02:38 PM User Interface Feature #4393: add TITLE-DCOLOR attribute support
Why would we want it to be @extends@? Greg Shah
02:23 PM User Interface Feature #4393: add TITLE-DCOLOR attribute support
Greg Shah wrote:
> Did you add it to @FrameWidget@?
ahh... @TitledElement@ is in there as @implements@, but not @...
Roger Borrello
02:21 PM User Interface Feature #4393: add TITLE-DCOLOR attribute support
Did you add it to @FrameWidget@? Greg Shah
02:16 PM User Interface Feature #4393: add TITLE-DCOLOR attribute support
Greg Shah wrote:
> Remove it from @CommonFrame@.
When @extends TitledElement@ is removed from @CommonFrame@, the ...
Roger Borrello
01:47 PM User Interface Feature #4393: add TITLE-DCOLOR attribute support
Greg Shah wrote:
> Feel free to fix your bugs.
LOL... nowhere did I add a 4052 warning... I'll find and fix, whoeve...
Roger Borrello
01:06 PM User Interface Feature #4393: add TITLE-DCOLOR attribute support
Remove it from @CommonFrame@.
> Proceeding with the testcase, with all getters/setters in both GenericFrame and Fr...
Greg Shah
12:46 PM User Interface Feature #4393: add TITLE-DCOLOR attribute support
Greg Shah wrote:
> @GenericFrame@ should not implement @TitledElement@, only implement in @FrameWidget@. You can st...
Roger Borrello
12:04 PM User Interface Feature #4393: add TITLE-DCOLOR attribute support
@GenericFrame@ should not implement @TitledElement@, only implement in @FrameWidget@. You can still leave the setter... Greg Shah
11:23 AM User Interface Feature #4393: add TITLE-DCOLOR attribute support
Greg Shah wrote:
> > Where are the frame-options methods?
>
> That is the @setTitleColor(ColorSpec)@ (which you k...
Roger Borrello
11:11 AM User Interface Feature #4393: add TITLE-DCOLOR attribute support
> Where are the frame-options methods?
That is the @setTitleColor(ColorSpec)@ (which you keep complaining about) w...
Greg Shah
11:01 AM User Interface Feature #4393: add TITLE-DCOLOR attribute support
Greg Shah wrote:
> I forgot that we emit attributes using the @FrameWidget@ instead of direct access to the @Generic...
Roger Borrello
10:48 AM User Interface Feature #4393: add TITLE-DCOLOR attribute support
I forgot that we emit attributes using the @FrameWidget@ instead of direct access to the @GenericFrame@ instance. Th... Greg Shah
10:38 AM User Interface Feature #4393: add TITLE-DCOLOR attribute support
Using this to ef with @titleDColor@:... Roger Borrello
09:05 AM User Interface Feature #4393: add TITLE-DCOLOR attribute support
> In setTitleColor(ColorSpec titleColor) on line 6860? That wasn't me... I mentioned how odd that method looked. Did ... Greg Shah
08:55 AM User Interface Feature #4393: add TITLE-DCOLOR attribute support
Greg Shah wrote:
> Code Review Task Branch 4231b Revision 11395
>
> The changes are moving the right direction.
...
Roger Borrello
07:29 AM User Interface Feature #4393: add TITLE-DCOLOR attribute support
Code Review Task Branch 4231b Revision 11395
The changes are moving the right direction.
1. You've messed with ...
Greg Shah
06:53 AM User Interface Feature #4393: add TITLE-DCOLOR attribute support
> Does this mean titleDColor is stored outside GenericFrame?
Yes.
As I said in #4393-20:
> Thus, only @conf...
Greg Shah
09:45 PM User Interface Feature #4393: add TITLE-DCOLOR attribute support
Updates are buildable in revision 11395. Right now @GenericFrame@ is the only update without stubs. Please review... ... Roger Borrello
09:34 PM User Interface Feature #4393: add TITLE-DCOLOR attribute support
The documentation for Attributes:Frames for writing/assignment says...
_in ChUI:_
_before realization, all ...
Roger Borrello
05:21 PM Database Feature #4011: database/persistence layer performance improvements
If the directory has a flag to force everything to be treated as @NO-UNDO@, then I don't see the need for a conversio... Greg Shah
05:04 PM Database Feature #4011: database/persistence layer performance improvements
Greg Shah wrote:
> > The only value I see is that of pointing out which temp-tables are NOT marked NO-UNDO in the 4G...
Eric Faulhaber
04:29 PM Database Feature #4011: database/persistence layer performance improvements
> The only value I see is that of pointing out which temp-tables are NOT marked NO-UNDO in the 4GL code, which might ... Greg Shah
04:04 PM Database Feature #4011: database/persistence layer performance improvements
Eric Faulhaber wrote:
> Greg Shah wrote:
>
> > He mentioned that he believes his team never knowingly uses UNDOab...
Eric Faulhaber
03:43 PM Database Feature #4011: database/persistence layer performance improvements
Eric,
IIRC, the @UndoStateProvider@ is used for two reasons:
* to allow the @undo@ property to be lazily set (in s...
Ovidiu Maxiniuc
03:10 PM Database Feature #4011: database/persistence layer performance improvements
Ovidiu, I am implementing the forced NO-UNDO override idea Greg mentioned above, and I have come across @UndoStatePro... Eric Faulhaber
03:02 PM Base Language Feature #4384: Builtin OO Implementation
Eugenie Lyzenko wrote:
> I do not need to restart conversion for this change, right?
Reconversion is not needed.
Constantin Asofiei
02:54 PM Base Language Feature #4384: Builtin OO Implementation
Constantin Asofiei wrote:
> I think your problem is now fixed in 4231b 11398 (xfer was updated, too). Please test.
...
Eugenie Lyzenko
02:43 PM Base Language Feature #4384: Builtin OO Implementation
I think your problem is now fixed in 4231b 11398 (xfer was updated, too). Please test.
The reason: I was processi...
Constantin Asofiei
01:55 PM Base Language Feature #4384: Builtin OO Implementation
Marian Edu wrote:
> Creating an empty @hosts.txt@ file in working folder solved the issue though so we're all good n...
Constantin Asofiei
01:06 PM Base Language Feature #4384: Builtin OO Implementation
Marian Edu wrote:
> While writing this thought to regenerate the code for the tests and try again, it now seems the ...
Marian Edu
12:35 PM Base Language Feature #4384: Builtin OO Implementation
Greg Shah wrote:
> I have pushed revision 11389 to @xfer.goldencode.com:/opt/fwd/4231b@.
Did eventually made a pu...
Marian Edu
10:17 AM User Interface Feature #4164: implement misc UI features (frame options, misc attributes)
Branch 4231b revision 11395 includes @GenericFrame@ changes that complete @next-tab-item@ and @prev-tab-item@ per #41... Greg Shah

03/25/2020

03:42 PM User Interface Bug #4589: menu case sensitivity and conversion
> The current changes were checked with testcases/uast/menu tests that passed except 4 known cases:
Roger is worki...
Greg Shah
03:33 PM User Interface Bug #4589: menu case sensitivity and conversion
The current changes were checked with @testcases/uast/menu@ tests that passed except 4 known cases:... Sergey Ivanovskiy
03:21 PM User Interface Bug #4589: menu case sensitivity and conversion
If everything is working so far and there are no regressions, then I am OK with it. Greg Shah
02:32 PM User Interface Bug #4589: menu case sensitivity and conversion
Greg, I compared the previous version and the current changes and found that this map used @submenu = names.convert(... Sergey Ivanovskiy
10:36 AM User Interface Bug #4589: menu case sensitivity and conversion
Code Review Task Branch 4231b Revision 11387
It seems wrong to use the javaname (even a lowercased one) as a key t...
Greg Shah
08:13 AM User Interface Bug #4589: menu case sensitivity and conversion
Greg Shah wrote:
> This is not a problem with menu conversion. The skeletons should never be converted. They are s...
Hynek Cihlar
08:13 AM User Interface Bug #4589: menu case sensitivity and conversion
Hynek Cihlar wrote:
> Sergey, I think I stepped on another error during <large_app> conversion caused by the menu ch...
Hynek Cihlar
08:04 AM User Interface Bug #4589: menu case sensitivity and conversion
This is not a problem with menu conversion. The skeletons should never be converted. They are supposed to be exclud... Greg Shah
07:53 AM User Interface Bug #4589: menu case sensitivity and conversion
Sergey, I think I stepped on another error during <large_app> conversion caused by the menu changes.... Hynek Cihlar
03:20 PM User Interface Feature #4393: add TITLE-DCOLOR attribute support
Consider the following facts:
* The reason we store state in a separate config class (e.g. @BaseConfig@) is to hav...
Greg Shah
02:41 PM User Interface Feature #4393: add TITLE-DCOLOR attribute support
Are @titleBGgColor@ and @titleFgColor@ attributes to be kept with @titleDColor@ and @titleFont@ in @BaseConfig@? Roger Borrello
01:45 PM User Interface Feature #4393: add TITLE-DCOLOR attribute support
> Yes I did, but in that method, it is setting frame.config.titleDColor instead of frame.config.titleColor.
There ...
Greg Shah
01:34 PM User Interface Feature #4393: add TITLE-DCOLOR attribute support
Greg Shah wrote:
> Did you see this part in #4393-6:
>
> > @GenericFrame@: Add @getTitleDColor()@, @setTitleDColo...
Roger Borrello
12:59 PM User Interface Feature #4393: add TITLE-DCOLOR attribute support
Did you see this part in #4393-6:
> @GenericFrame@: Add @getTitleDColor()@, @setTitleDColor(int64 dcolor)@, @setTi...
Greg Shah
12:52 PM User Interface Feature #4393: add TITLE-DCOLOR attribute support
@GenericFrame@ had a method that looks a little broken:... Roger Borrello
11:45 AM User Interface Feature #4393: add TITLE-DCOLOR attribute support
Just implement what is in @TitledElement@. The @ColorSpec@ stuff is not related. Greg Shah
11:44 AM User Interface Feature #4393: add TITLE-DCOLOR attribute support
Should there be setters for *FG*, *BG*, and *D* which receive @(ColorSpec color)@? Or just @int64@ and @long@? Roger Borrello
11:21 AM User Interface Feature #4393: add TITLE-DCOLOR attribute support
Greg Shah wrote:
> It is recommended anytime you are:
>
> * implementing a method from an interface (which you ar...
Roger Borrello
11:17 AM User Interface Feature #4393: add TITLE-DCOLOR attribute support
It is recommended anytime you are:
* implementing a method from an interface (which you are doing, right?) OR
* o...
Greg Shah
10:58 AM User Interface Feature #4393: add TITLE-DCOLOR attribute support
I'm in @BrowseWidget@ and I see some methods with @&#64;Override@ annotation, and some without. What determines wheth... Roger Borrello
09:49 PM User Interface Feature #4393: add TITLE-DCOLOR attribute support
Just re-enable the warnings suppression. Greg Shah

03/24/2020

05:48 PM User Interface Feature #4393: add TITLE-DCOLOR attribute support
Is the below caused by commented out @options { generateAmbigWarnings = false; }@ ? Was that just for debug?... Roger Borrello
05:06 PM User Interface Feature #4393: add TITLE-DCOLOR attribute support
Attached are my incomplete changes for this task. The intention is to *finish the implementation of all the options ... Greg Shah
03:47 PM Base Language Feature #4384: Builtin OO Implementation
@bzr send@ would maintain the revision history. An alternative is to zip up only your changed files and send those. ... Greg Shah
03:44 PM Base Language Feature #4384: Builtin OO Implementation
Greg Shah wrote:
> I have pushed revision 11389 to @xfer.goldencode.com:/opt/fwd/4231b@.
Thanks Greg, quick quest...
Marian Edu
03:28 PM Base Language Feature #4384: Builtin OO Implementation
Marian Edu wrote:
> is the issue with error throwing from two or more level deep method call fixed already?
Yes, ev...
Constantin Asofiei
03:24 PM Base Language Feature #4384: Builtin OO Implementation
I have pushed revision 11389 to @xfer.goldencode.com:/opt/fwd/4231b@. Greg Shah
03:23 PM Base Language Feature #4384: Builtin OO Implementation
Constantin Asofiei wrote:
> Marian, the changes are in 4231b rev 11389
>
> Some parts were a little tricky to fix...
Marian Edu
03:19 PM Base Language Feature #4384: Builtin OO Implementation
Marian, the changes are in 4231b rev 11389
Some parts were a little tricky to fix... sorry it took so long. If yo...
Constantin Asofiei
04:09 AM Base Language Feature #4384: Builtin OO Implementation
Marian Edu wrote:
> So, should we change Assert as it should using internalProcedure block and loadClass with static...
Constantin Asofiei
02:57 AM Base Language Feature #4384: Builtin OO Implementation
Constantin Asofiei wrote:
> Marian Edu wrote:
> > Let me know if you have questions or need more test cases for thi...
Marian Edu
07:18 AM User Interface Bug #4589: menu case sensitivity and conversion
Sergey Ivanovskiy wrote:
> The AST of menu item in the assignment expression #4589-41 missed @<annotation datatype="...
Sergey Ivanovskiy
06:07 AM User Interface Bug #4589: menu case sensitivity and conversion
The AST of menu item in the assignment expression #4589-41 missed @<annotation datatype="java.lang.String" key="in_wi... Sergey Ivanovskiy
05:37 AM User Interface Bug #4589: menu case sensitivity and conversion
This code... Sergey Ivanovskiy
05:12 AM User Interface Bug #4589: menu case sensitivity and conversion
The code is still needed to fix ACCELERATOR assignments for menu. I added new test case @test-accelerator-1.p@ into @... Sergey Ivanovskiy
 

Also available in: Atom