FWD

10/04/2021

03:25 PM Base Language Feature #3817: create resource bundles from string literals and implement optional support for se...

Code Review Task Branch 3821c Revision 13032
It is good. Greg Shah

03:22 PM Base Language Feature #3817: create resource bundles from string literals and implement optional support for se...

Hynek Cihlar wrote:
> Hynek Cihlar wrote:
> > Greg Shah wrote:
> > > 7. In @frame_generator.xml@, I'm worried that... Hynek Cihlar

06:17 AM Base Language Feature #3817: create resource bundles from string literals and implement optional support for se...

Code Review Task Branch 3821c Revision 13022
It looks good. Greg Shah

03:52 AM Base Language Feature #3817: create resource bundles from string literals and implement optional support for se...

Hynek Cihlar wrote:
> Greg Shah wrote:
> >
> > 3. In @annotations/i18n.rules@, why not change @sprintf("%s/%s.%s"... Hynek Cihlar

10/03/2021

07:17 PM Base Language Feature #3817: create resource bundles from string literals and implement optional support for se...

Code Review Task Branch 3821c Revision 13021
The changes are all good. Greg Shah

03:36 PM Base Language Feature #3817: create resource bundles from string literals and implement optional support for se...

3821c revision 13021 adds support for import of the translation data exported from Translation Manager. Please review... Hynek Cihlar

06:21 PM Database Feature #4369: implement stateless FWD server clustering

Another open source framework to consider is "MicroStream":https://www.infoq.com/news/2021/09/microstream-5-is-open-s... Greg Shah

10/02/2021

04:08 PM Base Language Feature #3817: create resource bundles from string literals and implement optional support for se...

Hynek Cihlar wrote:
> As a consequence it will be very important to have the TM database up to date with the convert... Hynek Cihlar

04:05 PM Base Language Feature #3817: create resource bundles from string literals and implement optional support for se...

A few notes about the import of Translation Manager translation database.
There are some limitations in the TM's m... Hynek Cihlar

08:55 PM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration

I think we need to implement the following:
* standard redirections
* log file names and locations
* log helper ... Greg Shah

08:41 PM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration

Our "internal" FWD-specific logging is written to @STDERR@. This happens when we write to any @Logger@ instance obta... Greg Shah

10/01/2021

03:40 PM Base Language Bug #5446: PUT UNFORMATTED performace (stream is flushed on each call)

> The only feasible way I see to make caching the StreamWrapper.putWorker calls work is this
It seems reasonable. Greg Shah

02:26 PM Base Language Bug #5446: PUT UNFORMATTED performace (stream is flushed on each call)

The only feasible way I see to make caching the @StreamWrapper.putWorker@ calls work is this:
* encapsulate all usag... Constantin Asofiei

01:31 PM Base Language Bug #5446: PUT UNFORMATTED performace (stream is flushed on each call)

Greg Shah wrote:
> The downcall case can be handled using state synchronization like we do with the other UI feature... Constantin Asofiei

12:06 PM Base Language Bug #5446: PUT UNFORMATTED performace (stream is flushed on each call)

> Serializing everything (especially FieldEntry instances) ensures we have the correct data to output (and any error... Greg Shah

11:59 AM Base Language Bug #5446: PUT UNFORMATTED performace (stream is flushed on each call)

Greg Shah wrote:
> In regard to the avoidance of round trips, we could buffer these on the server side for file stre... Constantin Asofiei

11:10 AM Base Language Bug #5446: PUT UNFORMATTED performace (stream is flushed on each call)

> This is related to any caller of @Stream.putWorker@, which are @PUT@, @PUT CONTROL@, @PUT UNFORMATTED@ and @EXPORT@... Greg Shah

10:58 AM Base Language Bug #5446: PUT UNFORMATTED performace (stream is flushed on each call)

Something I need to clarify: this flush in FWD is not a problem just for @PUT UNFORMATTED@ (this is just the statemen... Constantin Asofiei

09:02 AM Base Language Bug #5446: PUT UNFORMATTED performace (stream is flushed on each call)

> The question is: is the buffer flush for a PUT statement required in 4GL?
I think we needed to downcall and flus... Greg Shah

12:17 PM Base Language Feature #3817: create resource bundles from string literals and implement optional support for se...

Give it a try. Greg Shah

12:04 PM Base Language Feature #3817: create resource bundles from string literals and implement optional support for se...

Greg Shah wrote:
> > > Btw. I also have to modify the TM sources as it doesn't export procedure file names.
> >
>... Hynek Cihlar

11:50 AM Base Language Feature #3817: create resource bundles from string literals and implement optional support for se...

> > Btw. I also have to modify the TM sources as it doesn't export procedure file names.
>
> Perhaps I should cont... Greg Shah

11:44 AM Base Language Feature #3817: create resource bundles from string literals and implement optional support for se...

Hynek Cihlar wrote:
> Btw. I also have to modify the TM sources as it doesn't export procedure file names.
Perhap... Hynek Cihlar

11:36 AM Base Language Feature #3817: create resource bundles from string literals and implement optional support for se...

Greg Shah wrote:
> Code Review Task Branch 3821c Revision 13017
>
> This is very good. I think the result is qui... Hynek Cihlar

10:54 AM Base Language Feature #3817: create resource bundles from string literals and implement optional support for se...

Code Review Task Branch 3821c Revision 13017
This is very good. I think the result is quite elegant and is layere... Greg Shah

09:27 AM Base Language Feature #3817: create resource bundles from string literals and implement optional support for se...

Hynek Cihlar wrote:
> This part is not finished yet. The expected worflow is to export the translations from Thransa... Hynek Cihlar

08:30 AM Base Language Feature #3817: create resource bundles from string literals and implement optional support for se...

Greg Shah wrote:
> Both Constantin and I will review this.
>
> What is the process to export the translation mana... Hynek Cihlar

08:18 AM Base Language Feature #3817: create resource bundles from string literals and implement optional support for se...

Both Constantin and I will review this.
What is the process to export the translation manager database and provide... Greg Shah

08:11 AM Base Language Feature #3817: create resource bundles from string literals and implement optional support for se...

3821c revision 13017 adds core runtime and conversion support.
The conversion support when explicitly enabled gen... Hynek Cihlar

09:37 PM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration

This task is intended to implement a unified and simple approach for configuring logging. We need to also consider w... Greg Shah

09:33 PM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration

+4GL Logging Facilities+
* @LOG-MANAGER@ system handle
** assign the @LOGFILE-NAME@ attribute to associate a log ... Greg Shah

09/30/2021

01:17 PM Runtime Infrastructure Bug #5703 (Closed): rationalize, standardize and simplify the client-side log file name configura...

Greg Shah

12:35 PM Runtime Infrastructure Bug #5701: logfile names for -O outputToFile use the spawner pid instead of the Java (FWD client ...

When @clientConfig/outputToFile@ is specified in the directory for an appserver process, the value is treated as a sp... Greg Shah

12:22 PM Runtime Infrastructure Bug #5701 (Closed): logfile names for -O outputToFile use the spawner pid instead of the Java (FW...

Greg Shah

11:50 AM Runtime Infrastructure Bug #5699: broken logfile name on Windows appserver clients (and probably other cases on Windows)

Spawned appserver clients (and batch processes?) can be configured in the server's directory with a log filename for ... Greg Shah

11:23 AM Runtime Infrastructure Bug #5699 (Closed): broken logfile name on Windows appserver clients (and probably other cases on...

Greg Shah

08:04 AM Base Language Feature #3817: create resource bundles from string literals and implement optional support for se...

> The attached file shows Translation Manager Compile dialog. This is used to compile 4GL sources with the specified ... Greg Shah

09/29/2021

12:49 PM Conversion Tools Feature #4105: improve flexibility of schema loading

> It is documented as the default option. If -P is present or none of other file specification parameters the PLAIN m... Greg Shah

12:18 PM Conversion Tools Feature #4105: improve flexibility of schema loading

Greg Shah wrote:
> Code Review Task Branch 3821c Revision 12996
> 1. As far as I know, there is no support for a @P... Ovidiu Maxiniuc

10:29 AM Conversion Tools Feature #4105: improve flexibility of schema loading

If I understand correctly, only the 2nd bullet remains. Correct? Greg Shah

10:29 AM Conversion Tools Feature #4105: improve flexibility of schema loading

Code Review Task Branch 3821c Revision 12996
This is very nice! Some minor feedback:
1. As far as I know, ther... Greg Shah

09:24 AM Base Language Feature #3817: create resource bundles from string literals and implement optional support for se...

Hynek Cihlar wrote:
> Any untranslatable strings are simply not wrapped by the translation method.
GNU gettext is... Hynek Cihlar

09:17 AM Base Language Feature #3817: create resource bundles from string literals and implement optional support for se...

Greg Shah wrote:
> > Once/if the customer moves away from the 4GL sources the work flow will be a bit different, the... Hynek Cihlar

09:10 AM Base Language Feature #3817: create resource bundles from string literals and implement optional support for se...

> Once/if the customer moves away from the 4GL sources the work flow will be a bit different, the PO files will be ge... Greg Shah

09:02 AM Base Language Feature #3817: create resource bundles from string literals and implement optional support for se...

Hynek Cihlar wrote:
> Hynek,
>
> After conversion, is the translation table mapping to 4GL source code line/colum... Hynek Cihlar

08:59 AM Base Language Feature #3817: create resource bundles from string literals and implement optional support for se...

Hynek,
After conversion, is the translation table mapping to 4GL source code line/column numbers? Why is this nee... Hynek Cihlar

09:13 AM Base Language Feature #4384: Builtin OO Implementation

> Probably not that important but thought to mention it as deviation anyway.
Recorded as a separate bug #5691. Greg Shah

09:13 AM Base Language Bug #5691: deviation in error generation for invalid method/property chaining

From Marian in #4384-577:
> When chaining method/properties access on an invalid object in 4GL there are two error... Greg Shah

09:12 AM Base Language Bug #5691 (New): deviation in error generation for invalid method/property chaining

Greg Shah

06:22 AM Base Language Bug #5651: conditions raised from a finally block

Greg Shah wrote:
> Are there any known customer issues that are caused by the remaining issues? If not, we will def... Constantin Asofiei

09/28/2021

04:24 PM Database Feature #5685: optimization: limit iteration of RecordBuffers in Commitable hooks by scope

Greg Shah wrote:
> I know we notify related buffers when something happens to a record that they may be holding. ... Eric Faulhaber

07:37 AM Database Feature #5685: optimization: limit iteration of RecordBuffers in Commitable hooks by scope

Anything passed as a named parameter must be kept in the list I think:
* @buffer@ parameters
* @table@ parameters... Greg Shah

04:05 PM Base Language Bug #5651: conditions raised from a finally block

Are there any known customer issues that are caused by the remaining issues? If not, we will defer those items. Greg Shah

04:04 PM Base Language Bug #5651: conditions raised from a finally block

Code Review Task Branch 3821c Revision 13001
No objections. Greg Shah

09/27/2021

05:20 PM Database Feature #5685: optimization: limit iteration of RecordBuffers in Commitable hooks by scope

From previous profiling, I recall we spend too much time iterating through the @BufferManager.openBuffers@ scoped lis... Eric Faulhaber

05:07 PM Database Feature #5685 (New): optimization: limit iteration of RecordBuffers in Commitable hooks by scope

Eric Faulhaber

02:30 PM Base Language Feature #3817: create resource bundles from string literals and implement optional support for se...

The attached file shows Translation Manager Compile dialog. This is used to compile 4GL sources with the specified la... Hynek Cihlar

09:33 AM Base Language Bug #5651: conditions raised from a finally block

3821c/13001 adds the try/finally protection for TM.processFinallyBlock. Constantin Asofiei

07:27 AM Base Language Feature #4384: Builtin OO Implementation

Probably not that important but thought to mention it as deviation anyway.
When chaining method/properties access ... Marian Edu

09/24/2021

06:23 PM Conversion Tools Feature #4105: improve flexibility of schema loading

The support for database profiles in configuration file was committed to 12996 of 3821c.
The active profile can be s... Ovidiu Maxiniuc

09/23/2021

04:05 PM Database Bug #5683: Consider using multiple .df files for a database

It may be useful to have multiple .df files for a database. For example, allow instead of (or in addition to) the @da... Igor Skornyakov

04:03 PM Database Bug #5683 (New): Consider using multiple .df files for a database

Igor Skornyakov

10:41 AM User Interface Bug #5682: Buttons rendering issues

I ran the uast tests for buttons some time ago, and this is what I gathered:
Button image related:
# Any test u... Vladimir Tsichevski

10:37 AM User Interface Bug #5682 (New): Buttons rendering issues

Vladimir Tsichevski

05:58 AM Runtime Infrastructure Feature #5680: improve error reporting during spawning, authentication and client startup

The web client startup process is quite complicated, since we must have a FWD client for every web client. Some fail... Greg Shah

05:47 AM Runtime Infrastructure Feature #5680 (New): improve error reporting during spawning, authentication and client startup

Greg Shah

09/22/2021

06:16 PM Runtime Infrastructure Feature #4132 (Closed): implement configurable user and session limits

Greg Shah

06:15 PM Runtime Infrastructure Feature #4132: implement configurable user and session limits

3821c revision 12981 includes the following changes:
> Added support for setting a maximum number of simultaneous ... Greg Shah

03:43 PM User Interface Bug #5214: Broken z-order for all driver widgets (including SPREADSHEET, HTML-BROWSER, etc.)

Is there any reason to leave this task open? Greg Shah

01:34 PM User Interface Bug #5622: TREEVIEW widget issues

Hynek Cihlar wrote:
> Vladimir Tsichevski wrote:
> > Fixed in 3821c rev. 12975
>
> I think the changes are OK, j... Vladimir Tsichevski

12:44 PM User Interface Bug #5622: TREEVIEW widget issues

Vladimir Tsichevski wrote:
> Fixed in 3821c rev. 12975
I think the changes are OK, just move the static methods b... Hynek Cihlar

11:46 AM User Interface Bug #5622: TREEVIEW widget issues

Hynek Cihlar wrote:
> Code review 3821c revision 12897.
>
> Please test how the method @remove@ will behave when ... Vladimir Tsichevski

09/21/2021

06:06 PM User Interface Bug #5622: TREEVIEW widget issues

Vladimir Tsichevski wrote:
> Node navigation: @Next@, @Previous@, @FirstSibling@, @LastSibling@. Then applied to the... Vladimir Tsichevski

06:06 PM User Interface Bug #5622: TREEVIEW widget issues

Vladimir Tsichevski wrote:
> The @Parent@ setter is not currently implemented.
>
> In OCX, setting the node paren... Vladimir Tsichevski

05:59 PM User Interface Bug #5622: TREEVIEW widget issues

Node navigation: @Next@, @Previous@, @FirstSibling@, @LastSibling@. Then applied to the tree root, these methods must... Vladimir Tsichevski

04:53 PM User Interface Bug #5622: TREEVIEW widget issues

The @Parent@ setter is not currently implemented.
In OCX, setting the node parent node always makes the node first... Vladimir Tsichevski

05:56 AM Conversion Tools Feature #4105: improve flexibility of schema loading

Overall, I like the approach very much.
> I chosen System property solution because it can be queried directly in ... Greg Shah

05:43 AM Base Language Feature #4384: Builtin OO Implementation

I can't reproduce it with @oo/openedge/core/collections/CloneableString.cls@ either. If you see this again, let us k... Greg Shah

03:05 AM Base Language Feature #4384: Builtin OO Implementation

Greg Shah wrote:
> > all using Progress.Lang.*. statements gets converted to @import com.goldencode.testcases.oo.pr... Marian Edu

09/20/2021

06:59 PM Conversion Tools Feature #4105: improve flexibility of schema loading

Since we need to run the conversion multiple times but keep the same @p2j.cfg.xml@ it means the only way to inform th... Ovidiu Maxiniuc

03:33 PM Base Language Feature #4384: Builtin OO Implementation

Greg Shah wrote:
> Ovidiu: Please apply the changes needed to work with @fwdspi.jar@ in the new testcases project.
... Ovidiu Maxiniuc

03:22 PM Base Language Feature #4384: Builtin OO Implementation

> all using Progress.Lang.*. statements gets converted to @import com.goldencode.testcases.oo.progress.lang.*;@
A... Greg Shah

09:59 AM Base Language Feature #4384: Builtin OO Implementation

Also after conversion now all @using Progress.Lang.*.@ statements gets converted to @import com.goldencode.testcases.... Marian Edu

07:17 AM Base Language Feature #4384: Builtin OO Implementation

Ovidiu: Please apply the changes needed to work with @fwdspi.jar@ in the new testcases project. Greg Shah

02:45 AM Base Language Feature #4384: Builtin OO Implementation

Marian Edu wrote:
> I'm getting an error when trying to start the server after last merge:
> [...]
>
> Something... Marian Edu

02:34 AM Base Language Feature #4384: Builtin OO Implementation

You are using H2, right? Copy the @build/lib/fwdspi.jar@ to the JRE's ext folder and delete the previous p2jspi.jar. Constantin Asofiei

02:31 AM Base Language Feature #4384: Builtin OO Implementation

I'm getting an error when trying to start the server after last merge:... Marian Edu

02:26 AM Base Language Feature #4384: Builtin OO Implementation

Greg Shah wrote:
> Vladimir on our team has resolved the javadoc errors in 3821c rev 12945. You don't need to do th... Marian Edu

01:06 PM Base Language Bug #3020: Add support for the IMMEDIATE-DISPLAY and MULTITASKING-INTERVAL SEEION attributes

Gaps are updated in 3821c/12958. Constantin Asofiei

12:54 PM Base Language Bug #3020 (Test): Add support for the IMMEDIATE-DISPLAY and MULTITASKING-INTERVAL SEEION attributes

The changes are in task branch 3821c revision 12957. Greg Shah

07:51 AM User Interface Bug #5622: TREEVIEW widget issues

The @EnsureVisible@ operation is broken for @TREEVIEW@. Here I call the operation for the first child of the @Root@ n... Vladimir Tsichevski

09/18/2021

10:16 AM Conversion Tools Feature #4105: improve flexibility of schema loading

We should not have to "swap out" the @p2j.cfg.xml@ for different conversion runs. Greg Shah

10:16 AM Conversion Tools Feature #4105: improve flexibility of schema loading

To clarify item 3:
* We have a customer which has 2 builds/compiles of their application:
** A version that runs ... Greg Shah

09/17/2021

06:29 PM Conversion Tools Feature #4105: improve flexibility of schema loading

The previous commit was pushing the metadata processing (@standard.dict@) to @ReportDriver@.
Starting with revision ... Ovidiu Maxiniuc

03:27 PM Base Language Bug #5651: conditions raised from a finally block

Greg, to answer your question, yes, the unwind can be overridden in the FINALLY (via LEAVE/NEXT/RETRY or even anothe... Constantin Asofiei

12:44 PM Runtime Infrastructure Feature #4132: implement configurable user and session limits

I'm only implementing these limits for interactive users. Process accounts, web/REST sessions, related threads and s... Greg Shah

11:55 AM Base Language Feature #4384: Builtin OO Implementation

Vladimir on our team has resolved the javadoc errors in 3821c rev 12945. You don't need to do this in 4384m. Greg Shah

06:17 AM Base Language Feature #4384: Builtin OO Implementation

Greg Shah wrote:
> Marian: In 4384m, would you please resolve these javadoc errors.
>
> [...]
Greg, we can certa... Marian Edu

05:10 AM Base Language Feature #3817: create resource bundles from string literals and implement optional support for se...

Greg Shah wrote:
> Please note that we will need to update the font metrics calculation to process all the translati... Hynek Cihlar

05:10 AM Base Language Feature #3817: create resource bundles from string literals and implement optional support for se...

Greg Shah wrote:
> > As a corollary, an external procedure ran non-persistently, with no outstanding persistent inst... Hynek Cihlar

09/16/2021

07:16 PM Base Language Feature #4366 (Closed): support TLS 1.2 and other updated secure socket protocols

Greg Shah

06:26 PM Base Language Feature #4366: support TLS 1.2 and other updated secure socket protocols

What other variety of tests would be helpful? Do these results coincide with expected results? To me it looks like ne... Roger Borrello

01:35 PM Base Language Feature #4366: support TLS 1.2 and other updated secure socket protocols

Below are my findings... I hope the table looks OK.
|\2/2. |_\7. Server |
... Roger Borrello

11:42 AM Base Language Feature #4366: support TLS 1.2 and other updated secure socket protocols

Roger Borrello wrote:
> Because I am unworthy! Awesome!
Haha 😀!
> Let me follow-up with a question. If I have a ... Ovidiu Maxiniuc

10:27 AM Base Language Feature #4366: support TLS 1.2 and other updated secure socket protocols

Ovidiu Maxiniuc wrote:
> Why not re-arrange the table as:
Because I am unworthy! Awesome!
Let me follow-up wit... Roger Borrello

09:02 AM Base Language Feature #4366: support TLS 1.2 and other updated secure socket protocols

Roger Borrello wrote:
> I guess there are a limited number of permutations to deal with. Below is my testplan:
Why ... Ovidiu Maxiniuc

08:50 AM Base Language Feature #4366: support TLS 1.2 and other updated secure socket protocols

Roger Borrello wrote:
> There is a pre-configuration step to perform, outside of the programming to generate:
> * t... Ovidiu Maxiniuc

08:09 AM Base Language Feature #4366: support TLS 1.2 and other updated secure socket protocols

> I wanted to check that when the server is setup for ssl and the client is tls, we can still connect, but the data i... Greg Shah

02:33 PM Base Language Feature #4384: Builtin OO Implementation

Marian: In 4384m, would you please resolve these javadoc errors.... Greg Shah

10:59 AM Base Language Feature #4384: Builtin OO Implementation

Task branch 4384m has been created from 3821c revision 12935. This is available on xfer (@/opt/fwd/4384m/@). Greg Shah

10:28 AM Base Language Feature #4384: Builtin OO Implementation

Marian, my only issue is that in @oo.core.Assert@ you've replaced @ObjectOps.load(Assert.class);@ with @ObjectOps.loa... Constantin Asofiei

09:23 AM Base Language Feature #4384: Builtin OO Implementation

Greg Shah wrote:
> It is safe to go ahead and make a patch using 12922. We'll merge that back quickly and get you a... Marian Edu

08:31 AM Base Language Feature #4384: Builtin OO Implementation

It is safe to go ahead and make a patch using 12922. We'll merge that back quickly and get you a new branch. Greg Shah

01:12 AM Base Language Feature #4384: Builtin OO Implementation

Greg Shah wrote:
> I think we've definitely made many fixes that may affect you. Let's go through the rebase + merg... Marian Edu

01:56 PM Base Language Feature #3817: create resource bundles from string literals and implement optional support for se...

Please note that we will need to update the font metrics calculation to process all the translations. And we will ne... Greg Shah

01:42 PM Base Language Feature #3817: create resource bundles from string literals and implement optional support for se...

> As a corollary, an external procedure ran non-persistently, with no outstanding persistent instances, can be invoke... Greg Shah

01:12 PM Base Language Feature #3817: create resource bundles from string literals and implement optional support for se...

To support the conversion path for customers using OE translation workflow, the translations can be "dumped" from Tra... Hynek Cihlar

01:07 PM Base Language Feature #3817: create resource bundles from string literals and implement optional support for se...

See my findings below. I will update this note as I go.
Greg Shah wrote:
> +Areas to Investigate+
>
> * Write ... Hynek Cihlar

10:33 AM Conversion Tools Bug #5664 (Closed): treeview parent node conversion issue

Greg Shah

10:06 AM Conversion Tools Bug #5664: treeview parent node conversion issue

Vladimir Tsichevski wrote:
> The result is committed as rev. 12932. Please review.
I'm OK with the change.
Constantin Asofiei

08:57 AM Conversion Tools Bug #5664: treeview parent node conversion issue

Constantin Asofiei wrote:
> Review for 3821c/12930:
> * the test for function parameters needs to be like @upPath("... Vladimir Tsichevski

03:51 AM Conversion Tools Bug #5664: treeview parent node conversion issue

Review for 3821c/12930:
* the test for function parameters needs to be like @upPath("KW_FUNCT/LPARENS/PARAMETER/SYMB... Constantin Asofiei

06:54 AM Database Bug #5673: Additional support for INDEXED REPOSITION open query attribute

The INDEXED REPOSITION 4GL optimization allows query reposition to records which were not initially in the database (... Alexandru Lungu

06:44 AM Database Bug #5673 (New): Additional support for INDEXED REPOSITION open query attribute

Alexandru Lungu

09/15/2021

06:47 PM Base Language Feature #4366: support TLS 1.2 and other updated secure socket protocols

I guess there are a limited number of permutations to deal with. Below is my testplan:
|_. Server |_. Client |_. R... Roger Borrello

06:04 PM Base Language Feature #4366: support TLS 1.2 and other updated secure socket protocols

I can finally accomplish the testing. I wanted to check that when the server is setup for @ssl@ and the client is @tl... Roger Borrello

05:36 PM Base Language Feature #4366: support TLS 1.2 and other updated secure socket protocols

Well it was just a matter of time before I figured out what I was doing wrong. I hadn't noticed that there were 2 sep... Roger Borrello

03:36 PM Base Language Feature #4366: support TLS 1.2 and other updated secure socket protocols

I run the tests only from my workstation. No network changes required. The parameters look fine, I am positive the fi... Ovidiu Maxiniuc

02:36 PM Base Language Feature #4366: support TLS 1.2 and other updated secure socket protocols

I am troubled by the fact that I can use my current configuration with the @sockets/server-connect.p@ and @sockets/cl... Roger Borrello

02:24 PM Base Language Feature #4366: support TLS 1.2 and other updated secure socket protocols

Roger Borrello wrote:
> Ovidiu, thank you for all those pointers. Thanks to them, I was successful in making sure th... Ovidiu Maxiniuc

02:11 PM Base Language Feature #4366: support TLS 1.2 and other updated secure socket protocols

> I think that the wiki should be a little more step-by-step with the example, including basic passwords for the stor... Greg Shah

02:00 PM Base Language Feature #4366: support TLS 1.2 and other updated secure socket protocols

Ovidiu, thank you for all those pointers. Thanks to them, I was successful in making sure the store password and the ... Roger Borrello

09:33 AM Base Language Feature #4366: support TLS 1.2 and other updated secure socket protocols

I understand now. And I have just noticed the "keystore" password commented in your note-57.
The problem is that y... Ovidiu Maxiniuc

05:30 PM Base Language Bug #5651: conditions raised from a finally block

I am willing to postpone the implementation of @NEXT@ in a @FINALLY@. We can put code in to detect this at conversio... Greg Shah

04:43 PM Base Language Bug #5651: conditions raised from a finally block

And something I didn't expect: same suite ran in ChUI and GUI (OE 11.6.3) gives different results in ~5% of cases. T... Constantin Asofiei

04:33 PM Base Language Bug #5651: conditions raised from a finally block

Ughhh. Supporting @NEXT@ in a finally which overrides a prior @LEAVE@ is an awful "feature" and a terrible idea. Wh... Greg Shah

02:43 PM Base Language Bug #5651: conditions raised from a finally block

Greg, there is an issue which is kind of tricky. For looping blocks, the finally can not be processed at the @popSco... Constantin Asofiei

03:19 PM Conversion Tools Bug #5664 (Review): treeview parent node conversion issue

Vladimir Tsichevski

03:19 PM Conversion Tools Bug #5664 (WIP): treeview parent node conversion issue

Constantin Asofiei wrote:
> Vladimir, see @annotations/ocx_conversions.rules@, line 536 I think. That part is missi... Vladimir Tsichevski

07:22 AM Conversion Tools Bug #5664: treeview parent node conversion issue

Vladimir, see @annotations/ocx_conversions.rules@, line 536 I think. That part is missing function parameters.
<pre... Constantin Asofiei

07:15 AM Conversion Tools Bug #5664: treeview parent node conversion issue

This issue probably needs to be renamed since it neither relates to @TREEVIEW@, nor to @PARENT@ call. Vladimir Tsichevski

09:26 AM Base Language Feature #4384: Builtin OO Implementation

I think we've definitely made many fixes that may affect you. Let's go through the rebase + merge process and then g... Greg Shah

08:45 AM Base Language Feature #4384: Builtin OO Implementation

Constantin Asofiei wrote:
> Please try this patch and see if anything changes:
Better, thanks a bunch :)
Marian Edu

08:27 AM Base Language Feature #4384: Builtin OO Implementation

Argh, think we need to get to a newer revision as this might be the cause for more other errors we see because the ob... Marian Edu

08:26 AM Base Language Feature #4384: Builtin OO Implementation

Please try this patch and see if anything changes:... Constantin Asofiei

08:16 AM Base Language Feature #4384: Builtin OO Implementation

Constantin Asofiei wrote:
> What 3821c revision are you on? We had some issues with destructors which were not being... Marian Edu

08:08 AM Base Language Feature #4384: Builtin OO Implementation

What 3821c revision are you on? We had some issues with destructors which were not being called at all, fixed in Obje... Constantin Asofiei

07:53 AM Base Language Feature #4384: Builtin OO Implementation

I see a bunch of unexpected errors being thrown when we ran all tests for OpenEdge.Core.Memptr, #1005 (Procedure xxx ... Marian Edu

09/14/2021

05:39 PM Base Language Feature #4366: support TLS 1.2 and other updated secure socket protocols

OK... because I am having issues with the below, I'll flip-flop the passwords. I get @Unable to prtocess parameters. ... Roger Borrello

04:52 PM Base Language Feature #4366: support TLS 1.2 and other updated secure socket protocols

The problem is here:
> @-Dssl-socket:keystore:password=keystore@
In fact, there are two of them:
# use @password@ ... Ovidiu Maxiniuc

04:31 PM Base Language Feature #4366: support TLS 1.2 and other updated secure socket protocols

This is what I did (still resulting in the tampered error).... Roger Borrello

05:12 PM Conversion Tools Feature #4105: improve flexibility of schema loading

Moved @FLAG_DICT@ declaration from @AstManager@ to @AstGenerator@. Augmented @flags@ to 64 bits (8 reserved).
Comm... Ovidiu Maxiniuc

10:29 AM Conversion Tools Feature #4105: improve flexibility of schema loading

I think the correct location is in @AstGenerator@ (the same place we have the @DICT_POSTFIX@ constant. Greg Shah

10:28 AM Conversion Tools Feature #4105: improve flexibility of schema loading

I think that is OK, because the flags only need to be consistent within a given project. In other words, as long as ... Greg Shah

10:06 AM Conversion Tools Feature #4105: improve flexibility of schema loading

Greg Shah wrote:
> My only feedback is that the @FLAG_DICT@ should not be defined in @AstManager@. The @AstManager@... Ovidiu Maxiniuc

09:30 AM Conversion Tools Feature #4105: improve flexibility of schema loading

Code Review Task Branch 3821c Revision 12923
The changes are very nice. I like the idea of being able to mark AST... Greg Shah

04:48 PM Conversion Tools Bug #5664: treeview parent node conversion issue

Greg Shah wrote:
> The problem with the first function is that there is already a 4GL @PARENT@ attribute that can be... Vladimir Tsichevski

04:19 PM Conversion Tools Bug #5664: treeview parent node conversion issue

The problem with the first function is that there is already a 4GL @PARENT@ attribute that can be accessed on a @HAND... Greg Shah

04:15 PM Conversion Tools Bug #5664: treeview parent node conversion issue

Moved from #5034-1198 (by Vladimir):
Gentlemen,
I'm stuck converting code related to @TREEVIEW/TREELIST@.
Th... Greg Shah

04:15 PM Conversion Tools Bug #5664 (Closed): treeview parent node conversion issue

Greg Shah

08:31 AM Base Language Feature #3817: create resource bundles from string literals and implement optional support for se...

Here are a few notes about building the Adetran project. These are on top of the existing documentation.
h2. Build... Hynek Cihlar

04:46 AM User Interface Feature #5223: SPREADSHEET: Implement formula circular references

Keikai dev team released a test release with the added support of circular references and its parametrization through... Hynek Cihlar

09/13/2021

03:42 PM Conversion Tools Feature #4105: improve flexibility of schema loading

Greg Shah wrote:
> Code Review Task branch 3821c Revision 12898
> 1. Any project that uses skeletons will not be ab... Ovidiu Maxiniuc

03:10 PM Base Language Feature #4366: support TLS 1.2 and other updated secure socket protocols

Roger,
Your key loads in my test procedure(s). They are the exactly the same from @Socket Handle and Server Socket H... Ovidiu Maxiniuc

01:36 PM Base Language Feature #4366: support TLS 1.2 and other updated secure socket protocols

That error I get when the password is somehow incorrect. Can you send me the @default_server.store@ you've generated. Ovidiu Maxiniuc

12:32 PM Base Language Feature #4366: support TLS 1.2 and other updated secure socket protocols

Ovidiu, I am trying to follow the wiki, and my server source code is the same as your example (except I am using a va... Roger Borrello

10:55 AM Database Bug #5625: changing a before-table reserved field does not flush the change in the after-table

Constantin Asofiei wrote:
> The original issue is fixed. But I can't tell for sure what happens with the fix in #56... Ovidiu Maxiniuc

06:14 AM Database Bug #5625: changing a before-table reserved field does not flush the change in the after-table

The original issue is fixed. But I can't tell for sure what happens with the fix in #5625-15 if the record is just l... Constantin Asofiei

05:41 AM Database Bug #5625: changing a before-table reserved field does not flush the change in the after-table

Can we close this? Greg Shah

09/11/2021

07:07 AM Runtime Infrastructure Bug #5663: allow webcertificates details to be specified via files

Currently the structure of the webCertificates is this:... Constantin Asofiei

07:05 AM Runtime Infrastructure Bug #5663 (New): allow webcertificates details to be specified via files

Constantin Asofiei

09/10/2021

07:06 PM User Interface Bug #5622: TREEVIEW widget issues

In 3821c rev. 12916:
# added conversion of @DRAGGED-NODE@ and @DRAGGED-OVER-NODE@ getters (See #5172-81);
# fixed: ... Vladimir Tsichevski

05:19 PM User Interface Bug #5622: TREEVIEW widget issues

@KeyDown@ event handler conversion error: the first event argument must be of @INPUT-OUTPUT@ type instead of @INPUT@,... Vladimir Tsichevski

05:17 PM User Interface Bug #5622: TREEVIEW widget issues

Then @TREEVIEW@ loses keyboard focus, the selected node highlight should be removed. Vladimir Tsichevski

05:14 PM User Interface Bug #5622: TREEVIEW widget issues

Vladimir Tsichevski wrote:
> Scrolling issue:
>
> # Run @treeview.p@ application
> # Expand enough nodes to make... Vladimir Tsichevski

04:00 PM Base Language Feature #4366: support TLS 1.2 and other updated secure socket protocols

Yes, the "working" directory is the right work. I have just updated the wiki. Ovidiu Maxiniuc

03:49 PM Base Language Feature #4366: support TLS 1.2 and other updated secure socket protocols

In your text, you mention "This .store container must be located in root directory of the FWD-client" and "trusted-ce... Greg Shah

02:17 PM Base Language Feature #4366: support TLS 1.2 and other updated secure socket protocols

Greg Shah wrote:
> Ovidiu: Please document the specific requirements. We may need to make code changes to make it e... Ovidiu Maxiniuc

02:03 PM Base Language Feature #4366: support TLS 1.2 and other updated secure socket protocols

Roger Borrello wrote:
> Ovidiu, I was using @SSLCertGenUtil@ to do the generation of the keys into the directory ("s... Ovidiu Maxiniuc

07:04 AM Base Language Feature #4366: support TLS 1.2 and other updated secure socket protocols

Passing the output from the SSLCertGenUtil cannot work since it is not encoded as hex.
Ovidiu: Please document t... Greg Shah

09:04 AM Database Bug #5625: changing a before-table reserved field does not flush the change in the after-table

Is there any work remaining in this task? Greg Shah

09:00 AM Database Bug #5625: changing a before-table reserved field does not flush the change in the after-table

Ovidiu Maxiniuc wrote:
> This happened because there was no session / transaction open at that moment. I created a s... Constantin Asofiei

07:28 AM Base Language Feature #4384: Builtin OO Implementation

Greg Shah wrote:
> > * @SERIALIZABLE@ keyword should probably be used by conversion to make the class implement @Ser... Marian Edu

07:00 AM Database Bug #4071: FWD server stops allowing new web client logins after abend

> I think we need to consider if there is ever a scenario in which context cleanup is needed for reader/writer thread... Greg Shah

09/09/2021

07:21 PM Database Bug #4071: FWD server stops allowing new web client logins after abend

I was closing the web client of a large application in virtual desktop mode, debugging the update of the @meta_connec... Eric Faulhaber

06:29 PM Base Language Feature #4366: support TLS 1.2 and other updated secure socket protocols

Greg Shah wrote:
> Roger: Please ask Ovidiu specific questions to get help with this configuration. Also, after Ovi... Roger Borrello

09:46 AM Base Language Feature #4366: support TLS 1.2 and other updated secure socket protocols

Ovidiu: Please edit [[p2j:Certificates_and_Keys_for_4GL_Language_Features#Socket-Handle-and-Server-Socket-Handle-SSL-... Greg Shah

08:26 AM Base Language Feature #4366: support TLS 1.2 and other updated secure socket protocols

If you look at the code for @SymmetricEncryption.decrypt()@, you'll see that in @asBytes()@ it assumes that the input... Greg Shah

08:17 AM Base Language Feature #4366: support TLS 1.2 and other updated secure socket protocols

Greg Shah wrote:
> Is that what you expect? If the actual key password has 2 tildes, then you need to double them i... Roger Borrello

07:15 AM Base Language Feature #4366: support TLS 1.2 and other updated secure socket protocols

The tilde is an escape char in the 4GL. If your code is this:
@define variable kapw as char init "v~~4l#8ZrkkJwW?... Greg Shah

02:56 PM Database Bug #4564: unqualified field references can get the wrong buffer name if a FORM or DEF FRAME is p...

No. @com.goldencode.p2j.persist.*@ is a runtime package. It has nothing to do with conversion. Greg Shah

02:30 PM Database Bug #4564: unqualified field references can get the wrong buffer name if a FORM or DEF FRAME is p...

We are still patching some procedures to fully-qualify their field-references. They are willing to incorporate the up... Roger Borrello

02:18 PM Conversion Tools Feature #4105: improve flexibility of schema loading

Code Review Task branch 3821c Revision 12898
This is just for the @ReportDriver@ changes. I don't expect the curr... Greg Shah

01:10 PM Conversion Tools Feature #3883: eclipse plug for developing 4GL code using FWD including editing, syntax checks, r...

> I couldn't add new breakpoints doubleclicking in the editor or using the menu, I had to add it manually in the debu... Greg Shah

03:01 AM User Interface Bug #5622: TREEVIEW widget issues

Code review 3821c revision 12897.
Please test how the method @remove@ will behave when a convertibe number is pass... Hynek Cihlar

09/08/2021

07:50 PM Database Bug #5625: changing a before-table reserved field does not flush the change in the after-table

This happened because there was no session / transaction open at that moment. I created a short-lived micro-transacti... Ovidiu Maxiniuc

07:17 AM Database Bug #5625: changing a before-table reserved field does not flush the change in the after-table

Unfortunately this makes things worse - try the test without a full tx present and you will get a @"Attempting DML wh... Constantin Asofiei

07:48 PM Conversion Tools Feature #4105: improve flexibility of schema loading

Starting with r12902/3821c, it is possible to specify a different logical database name from the @.df@ basename.
I... Ovidiu Maxiniuc

12:41 PM Conversion Tools Feature #4105: improve flexibility of schema loading

Code review 3821c/12898:
This update contains changes for three issues: #4105, #5625, and #4766. The #4105 changes... Eric Faulhaber

06:20 PM Base Language Feature #4366: support TLS 1.2 and other updated secure socket protocols

I am back to testing with my testcases...the @ssl-server.p@ has:... Roger Borrello

04:21 PM Base Language Feature #4366 (Test): support TLS 1.2 and other updated secure socket protocols

Code Review Task Branch 3821c Revision 12901
The changes look good. Greg Shah

03:27 PM Base Language Feature #4366 (Feedback): support TLS 1.2 and other updated secure socket protocols

Please review:... Roger Borrello

08:18 AM Base Language Feature #4366: support TLS 1.2 and other updated secure socket protocols

Greg Shah wrote:
> > This is not correct, there is no @LowLevelSocketImpl@ usage for the @WebServiceImpl@ at this ti... Constantin Asofiei

07:33 AM Base Language Feature #4366: support TLS 1.2 and other updated secure socket protocols

> This is not correct, there is no @LowLevelSocketImpl@ usage for the @WebServiceImpl@ at this time.
Does anyone k... Greg Shah

04:25 AM Base Language Feature #4366: support TLS 1.2 and other updated secure socket protocols

Greg Shah wrote:
> +WEB-SERVICE:CONNECT()+
>
> On the server, a call to @<web_service_handle>:CONNECT()@ will pa... Constantin Asofiei

06:16 PM User Interface Feature #5151: Add complete support for tree-list OCX triggers

The second argument for the @OnKeyDown@ event is *integer* key modifiers mask. It is currently converted as @new logi... Vladimir Tsichevski

05:31 PM User Interface Bug #5622: TREEVIEW widget issues

Vladimir Tsichevski wrote:
> Some of @TREEVIEW@ events expect arguments of @INPUT-OUTPUT@ type. For example, the arg... Vladimir Tsichevski

05:21 PM User Interface Bug #5622: TREEVIEW widget issues

Some of @TREEVIEW@ events expect arguments of @INPUT-OUTPUT@ type. For example, the argument @KeyCode@ of the @KeyPre... Vladimir Tsichevski

09:18 AM User Interface Bug #5622: TREEVIEW widget issues

If needed, there was a conversion of the customer application using 12899. Please see #5034-1173 for details.
Roger Borrello

04:22 AM User Interface Bug #5622: TREEVIEW widget issues

Vladimir Tsichevski wrote:
> Hynek, can you please help me?
>
> What is the proper way to set the widget default ... Hynek Cihlar

12:28 PM Conversion Tools Feature #3883: eclipse plug for developing 4GL code using FWD including editing, syntax checks, r...

From Hynek:
> Btw. the debugging experience in Developer Studio is pretty lousy. For example I couldn't add new br... Greg Shah

12:26 PM Base Language Feature #5662: add -WSDLAuth and -SSLAuth (and related) connect options for the web-services handle

These connect options (and the key/cert related options) were added after OE 10.2B which was the initial implemented ... Greg Shah

12:24 PM Base Language Feature #5662 (New): add -WSDLAuth and -SSLAuth (and related) connect options for the web-service...

Greg Shah

10:08 AM Base Language Bug #4766: fix CHR and ASC

Code Review Task Branch 3821c Revision 12898
The changes look good. Greg Shah

08:25 AM Base Language Feature #4384: Builtin OO Implementation

> * @SERIALIZABLE@ keyword should probably be used by conversion to make the class implement @Serializable@ so we can... Greg Shah

04:49 AM Base Language Feature #4384: Builtin OO Implementation

Going through all tests to see if still passing, update implementation as needed (other changes did impact the test r... Marian Edu

09/07/2021

06:27 PM User Interface Bug #5622: TREEVIEW widget issues

Vladimir Tsichevski wrote:
> Eugenie Lyzenko wrote:
> > Vladimir,
> >
> > Does the @ocx_conversion.rules@ requir... Eugenie Lyzenko

06:19 PM User Interface Bug #5622: TREEVIEW widget issues

Eugenie Lyzenko wrote:
> Vladimir,
>
> Does the @ocx_conversion.rules@ require urgent reconversion of big custome... Vladimir Tsichevski

04:49 PM User Interface Bug #5622: TREEVIEW widget issues

Vladimir,
Does the @ocx_conversion.rules@ require urgent reconversion of big customer application? I need to take ... Eugenie Lyzenko

03:56 PM User Interface Bug #5622: TREEVIEW widget issues

Hynek, can you please help me?
What is the proper way to set the widget default mouse pointer icon? By this I mean... Vladimir Tsichevski

03:31 PM User Interface Bug #5622: TREEVIEW widget issues

In 3821c rev. 12897 the following issues has been fixed:
# Partial (mostly conversion only) support added for @TRE... Vladimir Tsichevski

05:03 PM Base Language Feature #4366: support TLS 1.2 and other updated secure socket protocols

> but we still need a way to determine what to pass in the #4366-21 when @LowLevelSocketImpl.initialize@ creates the ... Greg Shah

03:08 PM Base Language Feature #4366: support TLS 1.2 and other updated secure socket protocols

Greg Shah wrote:
> I don't know for sure, but I suspect that @LowLevelSocketListenerImpl.enableSSLConnections()@ sho... Roger Borrello

02:34 PM Base Language Feature #4366: support TLS 1.2 and other updated secure socket protocols

I don't know for sure, but I suspect that @LowLevelSocketListenerImpl.enableSSLConnections()@ should be using @"SSL"@. Greg Shah

02:23 PM Base Language Feature #4366: support TLS 1.2 and other updated secure socket protocols

In examining the difference between the @src/com/goldencode/p2j/util/LowLevelSocketImpl.java@ and @src/com/goldencode... Roger Borrello

10:56 AM Base Language Feature #4366: support TLS 1.2 and other updated secure socket protocols

First, let's note that the various versions of SSL are not the same as the various TLS versions. There are slight in... Greg Shah

10:21 AM Base Language Feature #4366: support TLS 1.2 and other updated secure socket protocols

Greg Shah wrote:
> Perhaps we should force it to the 1.2 level. Since a v1 or v1.1 peer can negotiate the connectio... Roger Borrello

04:13 PM Database Bug #5625: changing a before-table reserved field does not flush the change in the after-table

The above changes were committed in revision 12898/3821c, after testing them for a few days on my local environment.
... Ovidiu Maxiniuc

04:09 PM Base Language Bug #4766: fix CHR and ASC

The fix for @chr(0)@ was committed in revision 12898/3821c. Ovidiu Maxiniuc

09:12 AM Base Language Bug #4766: fix CHR and ASC

Nice catch. The problem is not actually in @I18nOps@ (which converts @chr(0)@ to @"\0"@) but in @character@ construct... Ovidiu Maxiniuc

08:39 AM Base Language Bug #4766: fix CHR and ASC

Ovidiu Maxiniuc wrote:
> Marian Edu wrote:
> > [...] There was previously a condition in @I18nOps@ that returned nu... Marian Edu

08:26 AM Base Language Bug #4766: fix CHR and ASC

Marian Edu wrote:
> [...] There was previously a condition in @I18nOps@ that returned null for codes less or equal t... Ovidiu Maxiniuc

08:14 AM Base Language Bug #4766: fix CHR and ASC

Marian, please provide the (isolated) testcases you refer to in note #4766-5. Please specify the active CP(s) you are... Ovidiu Maxiniuc

07:06 AM Base Language Bug #4766: fix CHR and ASC

This is probably still a work in progress but just mentioned this here since we've found some of our tests in OO impl... Marian Edu

04:08 PM Conversion Tools Feature #4105: improve flexibility of schema loading

Committed revision 12898.
It includes:
* The @importFile@, @xmlFile@ attributes of @namespace@ of @p2j.cfg.xml@ a... Ovidiu Maxiniuc

09/06/2021

03:49 PM Base Language Bug #5651: conditions raised from a finally block

I think we need to handle all the cases now. We can't know what minor edit will cause new cases to be used tomorrow ... Greg Shah

09:55 AM Base Language Bug #5651: conditions raised from a finally block

I just found that another customer application is using @RETURN "<val>"@ from the finally block.
I'll right a repo... Constantin Asofiei

07:27 AM Base Language Bug #5651: conditions raised from a finally block

I think you can go ahead with the change. Greg Shah