Golden Code Redmine

04/25/2025

09:13 AM User Interface Bug #4135: high dpi screens display in low dpi

Hynek: are you OK with moving #4135-124 to another task?
I'd like to get 4135b into trunk as soon as it is ready. ... Greg Shah

06:54 AM Conversion Tools Feature #7180: create a centralized manager for the conversion list and per-file/project status a...

The ChUI regression tests also have these customer-specific rule-sets. Greg Shah

06:53 AM Conversion Tools Feature #7180: create a centralized manager for the conversion list and per-file/project status a...

See [[p2j:Chapter_13_Other_Customization#Integrating-Custom-Conversion-Logic|Integrating Custom Conversion Logic]]. Greg Shah

06:32 AM Conversion Tools Feature #7180: create a centralized manager for the conversion list and per-file/project status a...

There shouldn't be any TRPL code generated on the fly. I don't think we do that anywhere.
Are there customer-spec... Greg Shah

08:33 PM TRPL Feature #9942: syntax for tree structure defintion and usage as templates or for pattern matching

We have a mechanism for implementing templates in TRPL v1, using the @TemplateWorker@ (TW). The idea is that the TW ... Greg Shah

04/24/2025

04:27 PM TRPL Feature #9942 (New): syntax for tree structure defintion and usage as templates or for pattern ma...

Greg Shah

04:03 PM TRPL Feature #9941: natural/integrated scoping for resources

Today we use the @DictionaryWorker@ to implement scoped dictionaries. This allows us to explicitly push/pop state ba... Greg Shah

03:35 PM TRPL Feature #9941 (New): natural/integrated scoping for resources

Greg Shah

03:34 PM TRPL Feature #9940: array syntax for referencing parent, child or sibling nodes

It is common to use chaining to reference parent nodes. Instead of @copy.parent.parent.parent@ or @copy.getAncestor(... Greg Shah

03:28 PM TRPL Feature #9940 (New): array syntax for referencing parent, child or sibling nodes

Greg Shah

02:09 PM TRPL Feature #9938: property syntax for annotations

> for the @this.name@ syntax, the @name@ must not collide with a @Aast@ getter method (as we can do a @node.firstChil... Greg Shah

01:04 PM TRPL Feature #9938: property syntax for annotations

In TRPL 1.0, annotations are "second class" features. The syntax of the language itself does not provide any facilit... Greg Shah

11:51 AM TRPL Feature #9938 (New): property syntax for annotations

Greg Shah

07:19 AM Base Language Feature #9436: add built-in OO classes

We have customer applications that can only run in 11.x. Those applications will be compared with FWD using the OE 1... Greg Shah

06:17 AM Base Language Feature #9436: add built-in OO classes

We have customers that are on 11.x and will never go to 12.x. It is critical that the tests can work across multiple... Greg Shah

07:16 AM Conversion Tools Feature #5586: move all conversion artifacts/outputs into the cvtdb or into a dedicated directory...

If this error only happens in 5586a then it is a real regression.
Adding the temp-table to the schema dictionary i... Greg Shah

06:11 AM Conversion Tools Feature #7180: create a centralized manager for the conversion list and per-file/project status a...

Dănuț Filimon wrote:
> Greg, I ended up modifying @rules/dbref/collect_refs.xml@ when removing @file@ usage. It look... Greg Shah

04/23/2025

05:28 PM Harness Feature #9284 (Closed): Support for local terminal

Greg Shah

01:58 PM Harness Feature #9284: Support for local terminal

Can we close this? Greg Shah

05:28 PM Testing Bug #9338 (Closed): Import JUnit test report back into Harness

Greg Shah

01:58 PM Testing Bug #9338: Import JUnit test report back into Harness

This can be closed, right? Greg Shah

03:22 PM Database Feature #9831: add admin API to set c3p0 configuration for individual tenant databases

Isn't @c3p0.break_on_fail@ always supposed to be @true@? I don't think we want customers to configure that. Greg Shah

12:49 PM Harness Feature #9922: Allow specifying encoding of external files.

> AFAIK there is no option in OE to copy the screen buffer to plain text, this is a FWD only feature for the chui_nat... Greg Shah

08:31 AM Harness Feature #9922: Allow specifying encoding of external files.

I do think it is possible that the file encoding could be different than the terminal encoding. An example of this i... Greg Shah

08:24 AM Base Language Feature #6292 (Closed): nested catch blocks

Greg Shah

08:17 AM Base Language Feature #6292: nested catch blocks

With 9470a merged to trunk as revision 15867, is this task complete? Greg Shah

04/22/2025

04:46 PM Runtime Infrastructure Feature #9687: drop support for Java 8 and Java 11

I've pushed 9687b revision 15895 to xfer. Greg Shah

08:37 AM Runtime Infrastructure Feature #9687: drop support for Java 8 and Java 11

Is this ready for the customer to access or does it need more changes and/or testing? Greg Shah

11:02 AM Testing Support #9844: finalize approach/techniques/standards for automating ABLUnit interactive UI tests

> The problem is there is no option to specify expected screen text file encoding.
We should add this. Greg Shah

10:41 AM Testing Support #9844: finalize approach/techniques/standards for automating ABLUnit interactive UI tests

Shouldn't we allow multibyte characters to be matched in screens? Using @?@ isn't a proper test. Greg Shah

09:46 AM Conversion Tools Support #9919: discuss and define the MVP for the first pass at IDE support

In #6319 and #3883 we are implementing IDE support for two common Java IDE platforms. For the first pass, we need to... Greg Shah

09:37 AM Conversion Tools Support #9919 (WIP): discuss and define the MVP for the first pass at IDE support

Greg Shah

08:49 AM Conversion Tools Bug #9905 (Internal Test): EOF file is not matched during preprocessing

Code Review Task Branch 9905a Revision 15868
The changes look good. Greg Shah

08:33 AM Base Language Bug #8944: FINALLY block transaction processing

If the @FINALLY@ is more deeply nested (the full transaction is in a more enclosing block, not in the immediately con... Greg Shah

04/18/2025

07:43 AM User Interface Bug #9913: DATE FILL-IN: Unexpected normalization on Enter and Tab keys

Only running the @ENTRY@ triggers after the user presses another key does not seem right. Greg Shah

04/17/2025

12:24 PM Database Feature #9093 (Closed): add protection for multi-tenant imports to optionally only import tables ...

Greg Shah

10:16 AM Conversion Tools Bug #9905: EOF file is not matched during preprocessing

OK, the bottom line here: please keep going with the fixes. The FWD output should match OE output exactly. Greg Shah

10:13 AM Testing Support #6859: preprocessor tests

OK, then open a new task for this additional "quirk". Make sure we have tests that explore these cases. You will ha... Greg Shah

10:10 AM Base Language Bug #9906 (Internal Test): Incorrect date parsing in FWD DATE(CHARACTER) implementation

Code Review Task Branch 9906a Revisions 15863 through 15864
I'm good with the changes. Greg Shah

08:08 AM Base Language Bug #9906: Incorrect date parsing in FWD DATE(CHARACTER) implementation

> I simplify error handling by throwing exceptions at various points in the method body (as exceptions are designed f... Greg Shah

10:00 AM Base Language Bug #4766: fix CHR and ASC

> It is necessary to add files for these cases?
Does OE have a default conversion that they implement in these cas... Greg Shah

09:51 AM Testing Support #6860: lexer tests

> we can already draw the conclusion that the lexer is right
Not fully. It tells us that the lexer rule that matc... Greg Shah

08:23 AM User Interface Bug #9913: DATE FILL-IN: Unexpected normalization on Enter and Tab keys

> In OE, pressing Enter does not alter the FILL-IN's displayed content.
Make sure you test ChUI. I think that ENT... Greg Shah

04/16/2025

04:47 PM Base Language Bug #9906: Incorrect date parsing in FWD DATE(CHARACTER) implementation

Code Review Task Branch 9906a Revisions 15860 through 15862
1. The rework of @parseWorker()@ is so extensive that ... Greg Shah

03:29 PM Database Feature #9093: add protection for multi-tenant imports to optionally only import tables that are ...

That is because #9875 was marked as a subtask of this one, which then blocks the direct setting of the %Done. Greg Shah

02:54 PM Database Feature #9093: add protection for multi-tenant imports to optionally only import tables that are ...

Can we set Done to 100%? Greg Shah

01:43 PM Testing Support #6860: lexer tests

These tests seem reasonable. You can check them in.
I think we do need more complex tests, which show that thes... Greg Shah

12:46 PM Conversion Tools Bug #9905: EOF file is not matched during preprocessing

> This change fixes all the harness EOF errors, but only if we dont have a NL present at any of the files(also includ... Greg Shah

12:42 PM Testing Support #6859: preprocessor tests

It seems this is another special case of #6308. Does this only happen after a string literal? Greg Shah

09:01 AM User Interface Bug #4135: high dpi screens display in low dpi

It is a valid use case that must work properly. Greg Shah

08:35 AM User Interface Bug #4135: high dpi screens display in low dpi

Didn't the customer already complain about zooming? I worry that we do need to fix this now. Greg Shah

08:49 AM Conversion Tools Feature #7180: create a centralized manager for the conversion list and per-file/project status a...

Dănuț Filimon wrote:
> I our last meeting I mentioned that I modified Aast.getFilename() to Aast.getArtifact(). file... Greg Shah

08:38 AM Conversion Tools Support #9703 (Closed): explore and document the existing OE IDE feature set

Nice! Greg Shah

04/15/2025

04:38 PM Harness Bug #9859 (Merge Pending): Problem compiling Java code under windows

You can merge now. Greg Shah

02:13 PM Harness Bug #9859: Problem compiling Java code under windows

Are there changes from the diff posted in #9859-2? If not, no additional review is needed. Greg Shah

02:10 PM Conversion Tools Support #9703: explore and document the existing OE IDE feature set

I've read the changes. They are quite good. Some followup questions/comments:
1. In the "A Simple GUI/TTY Projec... Greg Shah

10:18 AM Base Language Feature #9436: add built-in OO classes

I don't want to duplicate the test code by version unless the test code itself is drastically different. Greg Shah

10:17 AM Base Language Feature #9436: add built-in OO classes

> I am not sure how to handle these:
> 1. in testcases: Should I modify the existent tests? Not sure if that is ok, ... Greg Shah

09:05 AM Conversion Tools Feature #7180: create a centralized manager for the conversion list and per-file/project status a...

@file@ is a "global" variable that is provided by @CommonAstSupport@. Greg Shah

08:55 AM Conversion Tools Bug #6308 (Internal Test): post string literal alternative coding quirk in 4GL preprocessor

Code Review Task Branch 6308a Revision 15852
The change is good.
In rev 15853, I added comments and changed the... Greg Shah

08:32 AM Base Language Bug #4766: fix CHR and ASC

They must be loaded from our jar file. Since they are static, we will check them in to the FWD project itself and ch... Greg Shah

04/14/2025

02:54 PM Conversion Tools Bug #6308: post string literal alternative coding quirk in 4GL preprocessor

Code Review Task Branch 6308a Revision 15851
My only concern is that this quirk will occur for any alternative cod... Greg Shah

11:17 AM Harness Feature #9285 (Closed): Allow remote access to Event Semaphores and Mutexes

I've reviewed the docs and made some minor edits. Greg Shah

10:44 AM TRPL Feature #1745: review, decide upon and document the 1.0 features which will be retained in 2.0

Is @AUTOMATIC NULL CHECKING@ really only used 5 times? That is suspicious. Greg Shah

09:01 AM Conversion Tools Feature #5586 (Internal Test): move all conversion artifacts/outputs into the cvtdb or into a ded...

Code Review Task Branch 5586a Revisions 15809 through 15811
The changes are good.
Minor change: please create a... Greg Shah

08:42 AM Base Language Bug #9841: SUPER() and THIS-OBJECT() statements are not part of 'oo_call_type'

We probably should leave behind a @matchType@ annotation at the call site that records @"fuzzy"@ or @"exact"@. Greg Shah

04/11/2025

10:47 AM Testing Support #6860: lexer tests

OK, sorry I didn't think carefully enough about this issue. The problem is the multi-process nature of the testing a... Greg Shah

08:03 AM Testing Support #6860: lexer tests

Florin Eugen Rotaru wrote:
> Florin Eugen Rotaru wrote:
>
> > One solution would be to have a dedicated cvt folde... Greg Shah

08:02 AM Testing Support #6860: lexer tests

> One solution would be to have a dedicated cvt folder for each testing conversion.
We must *not* do this. Greg Shah

09:36 AM Conversion Tools Bug #9886 (Internal Test): Double slashes should produce a new line during preprocessing

Greg Shah

09:36 AM Conversion Tools Bug #9886: Double slashes should produce a new line during preprocessing

> in FWD whether we use Preprocessor on windows or unix we have ONLY @\n@, due to the following I think
Please reg... Greg Shah

09:31 AM Conversion Tools Bug #9886: Double slashes should produce a new line during preprocessing

Code Review Task Branch 9886a Revision 15852
I'm good with the changes. Greg Shah

09:20 AM Conversion Tools Bug #7255: FWD resolves a OO file not included in conversion, if it exists on disk and on PROPATH

Code Review Task Branch 7255a Revisions 15828 through 15830
I'm good with the changes. Greg Shah

09:13 AM Testing Support #6859: preprocessor tests

Open bugs as needed. Greg Shah

08:53 AM Testing Support #6859: preprocessor tests

Stefan Vieru wrote:
> I have a question about how to handle the testing of @;'@.
> In the wiki mentioned above, it ... Greg Shah

08:52 AM Testing Bug #9891: Open discussion on how to implement performance testing

Overall, I agree with most of the above. Some thoughts:
* I like the idea of implementing common code in your man... Greg Shah

08:30 AM TRPL Feature #1745: review, decide upon and document the 1.0 features which will be retained in 2.0

The idea here is that the language features match the parser structure, not the individual tokens. Greg Shah

08:29 AM TRPL Feature #1745: review, decide upon and document the 1.0 features which will be retained in 2.0

Octavian Adrian Gavril wrote:
> Greg Shah wrote:
> > Also, we don't need to track @protected@ lexer rules since the... Greg Shah

07:57 AM TRPL Feature #1745: review, decide upon and document the 1.0 features which will be retained in 2.0

Also, we don't need to track @protected@ lexer rules since they don't actually generate tokens used by the parser. I... Greg Shah

07:55 AM TRPL Feature #1745: review, decide upon and document the 1.0 features which will be retained in 2.0

> I assumed that if logging occurs within the @try@ block and no exception is thrown by @match()@ up to that point, w... Greg Shah

08:23 AM Conversion Tools Feature #7180: create a centralized manager for the conversion list and per-file/project status a...

> The problem is that I'll reach into NsConfig which I've already tried to refactor once and failed. I think I'll man... Greg Shah

07:45 AM Conversion Tools Feature #7180: create a centralized manager for the conversion list and per-file/project status a...

> I've got a question, if I have to create the artifact in the rules like in the following situation:
> [...] where ... Greg Shah

07:44 AM Conversion Tools Feature #7180: create a centralized manager for the conversion list and per-file/project status a...

> I ended up generating artifacts like this for ProgressASTs, so the issue from #7180-80 is valid. There are a few co... Greg Shah

08:01 AM Testing Support #9854: Discussion on how to leverage Harness to test certain drivers of FWD

Tomasz Domin wrote:
> Greg Shah wrote:
> > Let's fix the threading issue(s) in the @LexerTestDriver@ (wherever they... Greg Shah

07:39 AM Testing Support #9854: Discussion on how to leverage Harness to test certain drivers of FWD

Let's fix the threading issue(s) in the @LexerTestDriver@ (wherever they are, the problem may be in the lexer, symbol... Greg Shah

07:28 AM Base Language Bug #4766: fix CHR and ASC

I'll be interested to know how many map entries are really needed (for the diffs). If the number is small enough, we... Greg Shah

04/10/2025

04:15 PM Conversion Tools Bug #9886: Double slashes should produce a new line during preprocessing

Code Review Task Branch 9886a Revisions 15850 and 15851
1. Could the problem here be something related to the Wind... Greg Shah

12:09 PM TRPL Feature #1745: review, decide upon and document the 1.0 features which will be retained in 2.0

I've done some quick checking of the results. Most of the numbers look pretty reasonable, even the ones that are ver... Greg Shah

10:51 AM Base Language Bug #4602: fixes for OO 4GL and structured error handling

> 1) @undo, retry@ statment in repetive blocks like @repeat_to@, @repeat_to_while@, @do_to@, @do_to_while@, @for_loop... Greg Shah

09:58 AM TRPL Bug #9835: The same rules files are loaded and compiled multiple times

Yes, you can use 1745a. Greg Shah

09:25 AM Runtime Infrastructure Feature #9687: drop support for Java 8 and Java 11

Tomasz: When you get the chance, please update [[p2j:JVM Requirements]] to add Java 11 and Java 17. Later, when we r... Greg Shah

07:58 AM Runtime Infrastructure Feature #9687: drop support for Java 8 and Java 11

What has to be fixed before we can provide this as an early release to a customer? That customer needs to make Jetty... Greg Shah

08:01 AM Conversion Tools Feature #7180: create a centralized manager for the conversion list and per-file/project status a...

> After making lots of changes to replace the filename usage, I ended up changing some calls in the @Worker@ classes ... Greg Shah

07:59 AM Conversion Tools Feature #7180: create a centralized manager for the conversion list and per-file/project status a...

> However, there's also the option of replacing the @BasePlugin.fnames@ from a Map<String, Long> to a Map<Artifact, L... Greg Shah

04/09/2025

11:53 AM Base Language Feature #3853: implement LOG-MANAGER runtime

Status update from Galya regarding the changes that merged to trunk with #8661:
> The LegacyLogManagerImpl is boos... Greg Shah

11:51 AM User Interface Bug #8353: Fully support stanza INI LOAD/USE/UNLOAD scenarios

The work to complete the implementation, as documented by Galya:
* confirm the native code is not case sensitive w... Greg Shah

11:50 AM Base Language Feature #6417: cleanup some known items in appserver support

Status summary by Galya:
> I think some of the issues in the appserver are resolved in recent revisions, but what'... Greg Shah

11:14 AM Runtime Infrastructure Feature #9851: hard code the FWD version string in the JNI code at build time

> Got it. Is there a way to find the code for @gradlew native@ ? I looked into @build.gradle@ but did not find anythi... Greg Shah

09:48 AM Runtime Infrastructure Feature #9851: hard code the FWD version string in the JNI code at build time

> > In @build.gradle@ you can see we write it into code like @Version.java@.
> >
> Hmm, ok. Should this version be... Greg Shah

09:17 AM Runtime Infrastructure Feature #9851: hard code the FWD version string in the JNI code at build time

> How could we get the version at build time?
In @build.gradle@ you can see we write it into code like @Version.ja... Greg Shah

10:03 AM User Interface Bug #9887: FILL-IN: date: FWD does not trim right after selected region deletion

Can this be in the UI project? Greg Shah

09:56 AM Conversion Tools Feature #7180: create a centralized manager for the conversion list and per-file/project status a...

> The more I did deeper into AstManager/AstGenerator, I see that we can also provide an id instead of the filename fo... Greg Shah

09:42 AM Base Language Bug #4766: fix CHR and ASC

Delia Mitric wrote:
> Delia Mitric wrote:
>
> > The main difference is that if a character *c* from *cp1* doesn't... Greg Shah

08:59 AM Base Language Bug #4766: fix CHR and ASC

Don't look at the convmap. Just write the generator code in 4GL. We don't care what is in the convmap because we ar... Greg Shah

08:57 AM Testing Support #6859 (WIP): preprocessor tests

Greg Shah

08:57 AM Testing Support #6859: preprocessor tests

> * Once those old testcases are migrated and working, we would evaluate the following to identify other tests that w... Greg Shah

07:54 AM Testing Support #6859: preprocessor tests

Have you migrated or created all tests noted in #6859-5? Greg Shah

04/08/2025

06:22 PM Testing Support #6859 (Merge Pending): preprocessor tests

Code Review Task branch 6859a Revision 15847
The changes are good. They are also low risk. You can merge to trun... Greg Shah

01:16 PM Runtime Infrastructure Bug #9740: Client running in batch mode stops with a crash on Windows

We can't recreate the problem here. The only theory we have is that the @p2j.dll@ is not updated with a later versio... Greg Shah

08:42 AM Testing Support #9854: Discussion on how to leverage Harness to test certain drivers of FWD

> My idea was to have a _test_ which prepares the actual files AND some tests that make the comparisons. These should... Greg Shah

08:36 AM Testing Support #9844: finalize approach/techniques/standards for automating ABLUnit interactive UI tests

> If you wish I could direct some effort right now and add a simple Harness test including a script that should work ... Greg Shah

08:33 AM Testing Support #6860 (WIP): lexer tests

Code Review Task Branch 6860a Revision 15844
It is good. Greg Shah

08:19 PM Testing Support #6860: lexer tests

6860a rev 15843 has some code format cleanup.
Florin: Please review the changes and follow the standards in the ... Greg Shah

08:21 AM Base Language Bug #4766: fix CHR and ASC

> I'm not suggesting to use the conversion files from OE, the documentation for the syntax of those files is not exte... Greg Shah

08:10 AM Base Language Bug #4766: fix CHR and ASC

> > We can provide these conversion tables are resources inside the jar, we only need to write a class that initializ... Greg Shah

08:02 AM Base Language Bug #4766: fix CHR and ASC

> > We can provide these conversion tables are resources inside the jar, we only need to write a class that initializ... Greg Shah

08:18 AM Conversion Tools Feature #5586: move all conversion artifacts/outputs into the cvtdb or into a dedicated directory...

> Well, the changes on the branch already generate the .schema, .p2o and .dict files inside @cvt/data@, with the sche... Greg Shah

07:59 AM Conversion Tools Feature #5586: move all conversion artifacts/outputs into the cvtdb or into a dedicated directory...

> I'm looking into 3 but I can't find an example where namespace dir is used. I see in testcases that it is reference... Greg Shah

07:54 AM Conversion Tools Bug #7255: FWD resolves a OO file not included in conversion, if it exists on disk and on PROPATH

> Since @files@ in FileList is stored as a Java array I don't know whether it could be made in more efficient way. Bu... Greg Shah

04/07/2025

06:25 PM Testing Support #6860: lexer tests

> But the @<test>@ elements are quite different in FWD and in OE.
If there is no overlap, then we should use separ... Greg Shah

06:15 PM Testing Support #6860: lexer tests

Code Review Task Branch 6860a Revisions 15838 through 15842
It is looking good.
1. Instead of passing @printToS... Greg Shah

02:07 PM Testing Support #9844: finalize approach/techniques/standards for automating ABLUnit interactive UI tests

> The example there is decent, given you figure out how the Harness initiates the test. You must run the test once, s... Greg Shah

08:07 AM Testing Support #9844: finalize approach/techniques/standards for automating ABLUnit interactive UI tests

I guess my point here is that the code in #9844-17 is clean, easy to read and seems easy to write.
My only concern... Greg Shah

08:03 AM Testing Support #9844: finalize approach/techniques/standards for automating ABLUnit interactive UI tests

Is it really a big difference to write the code in Java in the first place instead of in their scripting environment? Greg Shah

01:56 PM User Interface Bug #9882 (Rejected): FILL-IN: date format input event handler restricts minus sign to four-digit...

Greg Shah

01:29 PM Conversion Tools Bug #7255: FWD resolves a OO file not included in conversion, if it exists on disk and on PROPATH

Code Review Task Branch 7255a Revisions 15822 through 15827
I don't have an objection to the functional changes. ... Greg Shah

07:58 AM Base Language Bug #4766: fix CHR and ASC

> Do you think it is necessary to add also these huge convmaps in FWD?
Unfortunately, yes. Greg Shah

04/05/2025

09:16 AM Testing Support #9270 (Merge Pending): design and implement an approach for executing multi-session 4GL t...

You can merge now. Greg Shah

09:10 AM Testing Support #9844: finalize approach/techniques/standards for automating ABLUnit interactive UI tests

All of your discussion *assumes that we are using some kind of scripting option*. Sikuli is implemented in *Java*. ... Greg Shah

04/04/2025

09:19 AM Runtime Infrastructure Support #8922: runtime infrastructure tests

Galya B wrote:
> Greg Shah wrote:
> > Galya B wrote:
> > > Should I write 4GL tests for testcases that work with o... Greg Shah

08:14 AM Runtime Infrastructure Support #8922: runtime infrastructure tests

Galya B wrote:
> Should I write 4GL tests for testcases that work with only one directory.xml that is derived from t... Greg Shah

07:50 AM Runtime Infrastructure Support #8922: runtime infrastructure tests

Galya B wrote:
> Where is the startup guide on how to write tests, add them to testcases and run them in Harness?
... Greg Shah

08:13 AM Conversion Tools Feature #5586: move all conversion artifacts/outputs into the cvtdb or into a dedicated directory...

Code Review Task Branch 5586a Revisions 15804 through 15808
1. In @Configuration.getPathToConversionFolder()@, I d... Greg Shah

07:54 AM Testing Support #9844: finalize approach/techniques/standards for automating ABLUnit interactive UI tests

I thought Sikuli could be used directly from Java, that you don't have to use Jython. Jython is too limiting and if ... Greg Shah

06:25 AM Testing Support #9844: finalize approach/techniques/standards for automating ABLUnit interactive UI tests

> It turns out that Sikuli runs in Jython, and while it doesn't allow @opencv@ to be directly imported (AFAIK) any pr... Greg Shah

05:16 AM Conversion Tools Feature #7180: create a centralized manager for the conversion list and per-file/project status a...

> The filename is retrieved through the @getFilename()@ call and this one relies on a @ParserSharedInputState/LexerSh... Greg Shah

04/03/2025

08:45 AM Testing Support #6859: preprocessor tests

> Let me know if I should take this issue or what to do with it.
Not yet. Let's get the test suite in place first... Greg Shah

06:38 AM Testing Support #6859: preprocessor tests

> Also another issues I've found during preprocessing is that: when a // comment is found, progress adds a NL. In FWD... Greg Shah

06:37 AM Testing Support #6859: preprocessor tests

> When we have @;)@ progress translates that into just @)@, but in FWD it stays the same.
> I guess i have to look i... Greg Shah

06:28 AM Testing Support #6859: preprocessor tests

> In OE the preprocessor IF would go on the 2nd statement, while in FWD it will go in the first. The reason being her... Greg Shah

06:27 AM Testing Support #6859: preprocessor tests

Overall, this is all moving along nicely.
In regard to the different test plans/tests for OE vs FWD, please look i... Greg Shah

06:23 AM Testing Support #6859: preprocessor tests

> My question would be: should i include somewhere in Preprocessor.java the logic that would created the path to the ... Greg Shah

08:41 AM TRPL Feature #1745: review, decide upon and document the 1.0 features which will be retained in 2.0

I think we will need a custom driver that loads everything (all rule set files) and forces all content to parse and a... Greg Shah

08:39 AM Testing Support #9854: Discussion on how to leverage Harness to test certain drivers of FWD

The FWD @build.xml@ does this OS detection and changes things based on the result. You can look at that as an example. Greg Shah

04/02/2025

01:58 PM Base Language Feature #9488: implement all built-in OO classes using the open source ADE code from 12.8.4

Constantin Asofiei wrote:
> Greg Shah wrote:
> > So, I'd like to know if we need it in the short term or not. If n... Greg Shah

12:48 PM Base Language Feature #9488: implement all built-in OO classes using the open source ADE code from 12.8.4

> Greg: considering that the #9457 project doesn't use generics in the app code, I want to find a way to delay this i... Greg Shah

01:50 PM Conversion Tools Bug #9863: Fileset eXclude broken on native Windows

> > Then the only issue is possible drive letters.
> If "Running the Front End Conversion":/projects/p2j/wiki/Runnin... Greg Shah

07:54 AM Conversion Tools Bug #9863: Fileset eXclude broken on native Windows

Don't use @\\@ anywhere, unless we really have to do so. Instead of shifting to the @File.separatorChar@, I would pr... Greg Shah

01:28 PM Base Language Feature #9868: Support generics introduced in Progress 12.x

I'm guessing that there is no syntax in the built-in classes which shows how to define a parameterized type (e.g. @T@... Greg Shah

01:23 PM Base Language Feature #9868: Support generics introduced in Progress 12.x

For convenience, I'm reproducing my post from #9488-131:
> Greg: considering that the #9457 project doesn't use ge... Greg Shah

12:58 PM Runtime Infrastructure Feature #7080: expose all admin APIs via REST

Constantin Asofiei wrote:
> Eric/Greg: if testing is OK with 8976a, we need to release this before #9687, so the jet... Greg Shah

12:10 PM Conversion Tools Feature #7180: create a centralized manager for the conversion list and per-file/project status a...

Dănuț Filimon wrote:
> It also appears that TransformDriver.ExcludeCheck class and TransformDriver.ScanCheck class a... Greg Shah

12:07 PM Conversion Tools Feature #7180: create a centralized manager for the conversion list and per-file/project status a...

> As mentioned yesterday, I am trying to make way for direct usage of artifacts in the AstManager. The problem I am f... Greg Shah

09:12 AM Testing Support #9844: finalize approach/techniques/standards for automating ABLUnit interactive UI tests

Șerban Bursuc wrote:
> Greg, there are quite a lot of requirements listed. Can you list the requirements in the orde... Greg Shah

04/01/2025

05:26 PM Conversion Tools Bug #9863: Fileset eXclude broken on native Windows

No. Doing so would greatly reduce the possible combinations of input. There is no good functional reason to require... Greg Shah

03:30 PM Conversion Tools Bug #9863: Fileset eXclude broken on native Windows

The wildcard being required is not something that is OK. Was that your question? Greg Shah

02:29 PM Conversion Tools Bug #9863: Fileset eXclude broken on native Windows

Debug it. The cause should be clear in the debugger. Greg Shah

03:31 PM Testing Bug #9525: Testcases: incorrect placeholders in directory.xml.template and other configuration pr...

The testcases project will *not* be used as a template for customers. It is private.
Also: unless we need a speci... Greg Shah

01:24 PM Testing Support #6860: lexer tests

> Yes, at least for the successful ones. Note that we can successfully lex procedures in FWD that would otherwise fai... Greg Shah

10:24 AM Runtime Infrastructure Feature #9687 (Review): drop support for Java 8 and Java 11

Greg Shah

08:32 AM Runtime Infrastructure Feature #9687: drop support for Java 8 and Java 11

We will deliver it to the customer as a branch as soon as your testing is done. That customer does not use the sprea... Greg Shah

08:03 AM Runtime Infrastructure Feature #9687: drop support for Java 8 and Java 11

> Do we need following dependencies, first two are marked by the customer, but they are only APIs ?
You would know... Greg Shah

08:29 AM Testing Support #6859: preprocessor tests

> It works for procedures without input parameters, but since you said there's no such thing for startup procedures, ... Greg Shah

08:02 AM Testing Support #6859: preprocessor tests

Help me understand what you need to use input parameters to achieve. Greg Shah

08:01 AM Testing Support #6859: preprocessor tests

> A question about this, how would I call this Driver from harness .xml test?
It can be called with direct Java co... Greg Shah

05:56 AM TRPL Feature #1745: review, decide upon and document the 1.0 features which will be retained in 2.0

Please try to confirm all of your numbers using other matching techniques (even something like grep). Many of the nu... Greg Shah

03/31/2025

04:34 PM Testing Support #6860: lexer tests

> Greg, what do you think of my approach? Do you see any issues?
I like the approach. We will have to see how the... Greg Shah

04:32 PM Testing Support #6860: lexer tests

> I have created the *tests/conversion/lexer* directory in *testcases* and added tests for @COMMENT@ rule and for @ST... Greg Shah

01:38 PM Runtime Infrastructure Feature #9687: drop support for Java 8 and Java 11

> should I upgrade all FWD dependencies to latest working versions as I did in #6692 ?
Yes, unless you have a reas... Greg Shah

10:23 AM Runtime Infrastructure Feature #9687: drop support for Java 8 and Java 11

> Should I upgrade all items marked in orange ?
Yes, these are all considered a problem.
> There one thing I do... Greg Shah

08:01 AM Runtime Infrastructure Feature #9687: drop support for Java 8 and Java 11

> I also did a small upgrade of dependencies to reduce vulnerabilities. I am checking if I could update more dependen... Greg Shah

09:24 AM TRPL Feature #1745: review, decide upon and document the 1.0 features which will be retained in 2.0

> Greg, what do you think about the numbers above? Also, what should I continue tracking with?
Please instrument @... Greg Shah

08:52 AM Harness Bug #9859: Problem compiling Java code under windows

We don't include testing in our % Done. The idea is that % Done refers to the functionality of the fix/feature. It ... Greg Shah

08:21 AM Harness Bug #9859 (Internal Test): Problem compiling Java code under windows

Why %Done of 50%? Greg Shah

08:21 AM Harness Bug #9859: Problem compiling Java code under windows

Code Review 9859a.diff
The change is good. Greg Shah

08:06 AM Testing Support #9270: design and implement an approach for executing multi-session 4GL testcases

Code Review Task Branch 9270a Revisions 78 through 80
No objections. I did check in a minor reversion of whitespa... Greg Shah

08:05 AM Testing Support #9270: design and implement an approach for executing multi-session 4GL testcases

Agreed. Greg Shah

07:58 AM Testing Support #9854: Discussion on how to leverage Harness to test certain drivers of FWD

> > > The problem we have is different tooling on OE/Windows and FWD/Linux. I tried to mitigate it by using ant and P... Greg Shah

07:42 AM Testing Support #9844: finalize approach/techniques/standards for automating ABLUnit interactive UI tests

Please look at the wiki pages I linked above. I think we are past the POC stage. We have implemented non-trivial te... Greg Shah

03/28/2025

04:55 PM Testing Support #9844: finalize approach/techniques/standards for automating ABLUnit interactive UI tests

h1. Introduction
We've done quite a bit of work on automating UI testing. When you consider our work on the [[har... Greg Shah

03:46 PM Base Language Bug #4766: fix CHR and ASC

> Java was born with that lesson learned. The String will store the @UNICODE@. We work directly, with the 'characters... Greg Shah

09:25 AM Base Language Bug #4766: fix CHR and ASC

> > We *must* implement the same behavior as OE for the *default* @convmap@ on those character sets which we support... Greg Shah

02:04 PM Harness Feature #6265: generate junit-compatible xml results for output

Are the changes already included in 9270a? Greg Shah

10:28 AM Harness Feature #6265: generate junit-compatible xml results for output

The % Done is 70%. What is left to do? Greg Shah

12:29 PM Testing Support #6859: preprocessor tests

The general idea is good. I would probably just encode the parameters are extent variables and call @GeneratePreproc... Greg Shah

12:25 PM Testing Support #6859: preprocessor tests

From Stefan:
> I worked on the Driver for 4GL and created some Harness tests to get a better understanding.
>
... Greg Shah

11:08 AM Testing Support #6859: preprocessor tests

Stefan Vieru wrote:
> Greg Shah wrote:
>
> > # The "core" of each test is one or more 4GL source files (@.p@, @.i... Greg Shah

11:36 AM Testing Support #9854: Discussion on how to leverage Harness to test certain drivers of FWD

The reason we need to run in OE:
* Confirm that the tests do in fact work there.
* Test on different OE versions ... Greg Shah

11:30 AM Testing Support #9854: Discussion on how to leverage Harness to test certain drivers of FWD

> Marian, is there any documentation on writing some OE driver for harness to do single-user tests? I was thinking of... Greg Shah

10:59 AM Testing Support #9270: design and implement an approach for executing multi-session 4GL testcases

Code Review Task Branch 9270a Revisions 35 through 77
Overall, the changes are very good.
1. Shouldn't the @abl... Greg Shah

10:27 AM Testing Support #9270: design and implement an approach for executing multi-session 4GL testcases

Don't forget that without a reviewer set, this task will not appear in the list of needed code reviews. Greg Shah

09:29 AM Runtime Infrastructure Bug #9804 (Internal Test): improve the OpenClient remote calls

Code Review Task branch 9804a Revisions 15816
All good. Greg Shah

09:22 AM Runtime Infrastructure Feature #9851: hard code the FWD version string in the JNI code at build time

/In #6662, we inserted code to set the @FWD_VERSION@ environment variable in the environment of a child process when ... Greg Shah

09:08 AM Runtime Infrastructure Feature #9851 (Test): hard code the FWD version string in the JNI code at build time

Greg Shah

08:36 AM Base Language Feature #6506: implement CGI WebSpeed support and the standard web-disp.p dispatch functionality

Two things that are complicating the process of completing these changes:
* #8661 a long running task where the co... Greg Shah