Greg Shah's activity
From 05/27/2025 to 06/25/2025
06/25/2025
- 10:17 AM Conversion Tools Bug #10208: do not convert the schema in incremental mode if it hasn't changed
- > Disabling M0 will need to be done only for the main db, and not the temp schemas.
Before #6083, we could imple... - 09:48 AM Conversion Tools Bug #10208: do not convert the schema in incremental mode if it hasn't changed
- Customers have reported that we always convert the schema in incremental mode (see #10175-26). For large projects, t...
- 09:00 AM Conversion Tools Bug #10208 (Closed): do not convert the schema in incremental mode if it hasn't changed
- 10:16 AM Conversion Tools Feature #6083: schema (.df) changes in incremental conversion mode should only reconvert those pr...
- In addition to calculating the non-schema dependencies for incremental mode, whatever changes to the schemata have be...
- 08:48 AM User Interface Bug #9855 (Test): Date FILL-IN: adjusts DATE format to SESSION:DATE-FORMAT order
06/24/2025
- 06:50 PM Runtime Infrastructure Feature #10200: session level heap usage tracking
- The idea is to use JVM APIs to track overall heap and CPU metrics to determine when the system is overcommitted. Aft...
- 06:44 PM Runtime Infrastructure Feature #10200 (New): session level heap usage tracking
- 05:21 PM Database Bug #10198: analyze FIND statements which use only a small number of fields
- #4400 is a mechanism to identify every query back to its original definition in source code. We could do a similar t...
- 05:11 PM Database Feature #10199: implement a temp-table size limit such that usage above that limit is backed by d...
- Unlimited temp-table usage causes an OOME for the server. OE "spills" to disk when temp-table usage is too large. W...
- 05:05 PM Database Feature #10199 (New): implement a temp-table size limit such that usage above that limit is backe...
06/23/2025
- 10:12 AM Database Feature #10169: result-set streaming (and asynchronous programming?)
- We might want some kind of "read ahead" limit to avoid doing too much on the secondary thread.
- 07:59 AM Conversion Tools Feature #5586: move all conversion artifacts/outputs into the cvtdb or into a dedicated directory...
- Stefan Vieru wrote:
> Greg, please let me know if I need to do anything else on this issue and if it's ready to be m...
06/20/2025
- 11:00 AM Conversion Tools Feature #5586: move all conversion artifacts/outputs into the cvtdb or into a dedicated directory...
- Start here and we will see where we move it.
- 08:44 AM Conversion Tools Feature #5586: move all conversion artifacts/outputs into the cvtdb or into a dedicated directory...
- Since we must provide guidance to customers on this shift, it is important that we prepare documentation and examples...
- 08:26 AM Conversion Tools Feature #5586: move all conversion artifacts/outputs into the cvtdb or into a dedicated directory...
- But don't we need to change the project-level @build.xml@ to process things like @clean@ in a different location?
- 07:46 AM Conversion Tools Feature #5586: move all conversion artifacts/outputs into the cvtdb or into a dedicated directory...
- Please remind me: is there any requirement for scripting or configuration changes in the project cfg?
- 10:45 AM TRPL Feature #3211: implement multi-threaded pattern engine and rework the ConversionDriver to leverag...
- I think the global scope variables should be local/thread-specific as well. If any of that is truly shared state, we...
- 08:25 AM Testing Support #6860 (Test): lexer tests
- 07:45 AM Testing Support #6860 (Merge Pending): lexer tests
- You can merge 6860a to trunk now.
- 07:57 AM Database Feature #10169: result-set streaming (and asynchronous programming?)
- I don't think we should look at pushing 4GL logic into other threads. Our core design will not allow this without a ...
- 07:49 AM Conversion Tools Feature #4076: remove empty triggers during conversion
- Ovidiu Maxiniuc wrote:
> After some thoughts, I think we can drop the empty triggers. If the 4GL programmer +really+... - 04:59 AM Conversion Tools Feature #4076: remove empty triggers during conversion
- The dangerous case here is when there are more than one trigger that exists with the same filename (and operating on ...
- 07:43 AM User Interface Feature #9055: server-side processing of client platform dependencies in the UI
- Great!
Hynek: keep going with your plan and we will need to test that application once you have enough implemented. - 07:39 AM Database Bug #9078: emit FindQuery as (reused) variables
- > will the template above do to generate FindQuery[] fqueryArray = new FindQuery[5]; or is there a way to make it sim...
06/19/2025
- 05:44 AM Database Feature #10169: result-set streaming (and asynchronous programming?)
- One approach for implementation would be to measure conditions at runtime and shift into this streaming/async mode wh...
- 05:40 AM User Interface Feature #9055: server-side processing of client platform dependencies in the UI
- Please check with Lorian who is working on those report tasks. If that code is executed in the appserver agent, then...
- 05:37 AM Conversion Tools Bug #9863 (Internal Test): Fileset eXclude broken on native Windows
- > > It handles the @!filter.endsWith("/")@ case but don't we also need to handle the @filter.endsWith("/")@ case?
> ...
06/18/2025
- 03:27 PM Conversion Tools Bug #9863: Fileset eXclude broken on native Windows
- Code Review Task Branch 9863a Revisions 15980 through 15982
The changes are good.
1. I wonder if @FLF.normalize... - 02:10 PM Base Language Feature #9516 (Internal Test): include pre-converted webspeed runtime code in FWD
- 01:07 PM Base Language Feature #9516 (WIP): include pre-converted webspeed runtime code in FWD
- The changes look good to me. What is left to do?
- 07:01 AM Base Language Feature #9516: include pre-converted webspeed runtime code in FWD
- Yes, that is understood. Includes from the ADE code can be used in customer 4GL code. For webspeed, it is required ...
- 12:59 PM Conversion Tools Bug #9917 (Internal Test): Fileset not ignoring case
- OK, good.
- 08:38 AM Conversion Tools Bug #9917: Fileset not ignoring case
- Code Review Task Branch 9917a Revisions 15969 through 15971
Overall, the changes seem reasonable.
My only quest... - 08:27 AM Runtime Infrastructure Bug #10174: Method/Procedure call overwrites procedure return value
- I was told (many years ago) by someone at Progress, that they implemented OO methods in this way:
* If the method ... - 07:20 AM Runtime Infrastructure Feature #9685: move FWD to Java 21
- Tomasz Domin wrote:
> Greg Shah wrote:
> > > move JNI and native dependencies into the jar (Linux) - 1d and 1d+ win... - 06:46 AM Runtime Infrastructure Feature #9685: move FWD to Java 21
- Is there any reason we can't do the performance testing first?
- 06:45 AM Runtime Infrastructure Feature #9685: move FWD to Java 21
- > move JNI and native dependencies into the jar (Linux) - 1d and 1d+ windows testing
Is this related to the FFM re... - 07:06 AM Database Feature #9456: implement SQL Server dialect and helpers
- > * I hit another MSSQL implementation restriction, one we were not aware of in the iteration of several years ago: t...
- 06:24 AM Base Language Feature #6506: implement CGI WebSpeed support and the standard web-disp.p dispatch functionality
- > Do we rewrite automatically the .htm extension to .w?
Yes. OE will automatically convert all @.htm@ and @.html@...
06/17/2025
- 05:43 PM User Interface Bug #6258 (Closed): SELECTION-LIST: Swing ChUI: SPACE and arrow buttons processing
- 12:25 PM Database Feature #10169: result-set streaming (and asynchronous programming?)
- This seems quite promising, I especially like the idea of adding threading in to keep the data transfer happening in ...
- 12:23 PM Database Feature #10169: result-set streaming (and asynchronous programming?)
- From Artur in #9802-210:
As already discussed, one of the main reasons for the differences in performance we see i... - 12:20 PM Database Feature #10169 (WIP): result-set streaming (and asynchronous programming?)
- 10:58 AM Testing Feature #1889: rework the date.java internal tests as real unit tests
- As a fallback, you can try creating a tunnel to 192.168.1.37 on our internal GCD network. That is the same system as...
- 06:59 AM Testing Support #10113: evaluate and test code coverage tooling
- How about adding code to @build_coverage.xml@ to download and copy the jars if they are not there? That way the depe...
- 06:42 AM Testing Support #10113: evaluate and test code coverage tooling
- > Shall the change to the @p2j@ mentioned in #10113-3 be merged?
I don't want JaCoCo to be a standard dependency o...
06/16/2025
- 07:18 PM Testing Support #6860: lexer tests
- > I've added tests and harness tests for the missing branches of the lexer rules according to the code coverage repo...
- 06:58 PM Testing Support #6860 (Test): lexer tests
- 06:58 PM Testing Support #6860: lexer tests
- Overall, the changes are very good. Have you made any changes to fill in code coverage gaps?
It is a little confu... - 04:08 PM Testing Support #10113 (Internal Test): evaluate and test code coverage tooling
- Overall, I'm OK with the approach. I like that it leaves the existing ant rules unchanged. The primary drawback is ...
- 02:33 PM Testing Feature #1889: rework the date.java internal tests as real unit tests
- > To support this an instruction should exists on where to put such sources, the rules on how the classes and directo...
- 02:28 PM Testing Feature #1889 (Test): rework the date.java internal tests as real unit tests
- Florin: Do the tests all pass in both OE and FWD?
- 11:29 AM Testing Feature #1889: rework the date.java internal tests as real unit tests
- > I’ve attached the following ABLUnit classes for testing date format validation and parsing:
Do any of these rela... - 08:34 AM Testing Feature #1889: rework the date.java internal tests as real unit tests
- There are many date literals in the @date.java@ tests which are not present in the lexer testcases. To be clear: all...
06/13/2025
- 02:09 PM Runtime Infrastructure Bug #10136: SESSION:TEMP-DIRECTORY missing directory
- I don't object to your idea, but I'm also OK with always having the @tmp{random-digits}@ segregation. If a customer ...
- 09:15 AM TRPL Feature #3211: implement multi-threaded pattern engine and rework the ConversionDriver to leverag...
- Correct
- 06:47 AM TRPL Feature #3211: implement multi-threaded pattern engine and rework the ConversionDriver to leverag...
- > Should we incorporate new changes related to #1753 in the next revision to help resolve this?
Yes. I only split... - 09:12 AM Conversion Tools Bug #9863: Fileset eXclude broken on native Windows
- We still need to canonicalize the result. Please write a version of the processing that can handle it.
- 08:06 AM Conversion Tools Bug #9863: Fileset eXclude broken on native Windows
- > I'm also wondering if we should account for @..@ in the filters?
Canonicalization whould deal with things like @... - 06:41 AM Conversion Tools Bug #9863: Fileset eXclude broken on native Windows
- > Currently @X ./abl/tmp/@ does nothing. It will not exclude any files from the specified folder since the pattern wi...
- 06:06 AM Conversion Tools Bug #9863: Fileset eXclude broken on native Windows
- Dănuț Filimon wrote:
> Greg Shah wrote:
> > > I am sure we do not want to add a feature which didn't exist before.
... - 05:59 AM Conversion Tools Bug #9863: Fileset eXclude broken on native Windows
- > I am sure we do not want to add a feature which didn't exist before.
Is it a new feature? Or is it just making ... - 06:02 AM Conversion Tools Feature #6256: improved profile support
- > I don't think two profiles should have the same namespace defined (with the same name).
Correct. Such a thing i...
06/12/2025
- 11:14 AM Testing Support #10113: evaluate and test code coverage tooling
- With #9725 we are getting rid of the old ways of running conversion, so we should not spend time on those.
- 08:56 AM Conversion Tools Bug #9863: Fileset eXclude broken on native Windows
- Dănuț Filimon wrote:
> Greg, is the scenario [...] something that should be supported? Using a single \ instead of \... - 08:52 AM Conversion Tools Bug #9863: Fileset eXclude broken on native Windows
- > If I replace the '\\' with '/', the only problem will be the pattern because the files in Windows will be using '\'...
- 08:41 AM Conversion Tools Bug #6308: post string literal alternative coding quirk in 4GL preprocessor
- OK, good.
- 08:27 AM Runtime Infrastructure Bug #10136: SESSION:TEMP-DIRECTORY missing directory
- > The same applies when you specify the path with -T startup parameter.
If you pass a non-existing directory name ...
06/11/2025
- 02:58 PM Conversion Tools Bug #6308: post string literal alternative coding quirk in 4GL preprocessor
- > The cause is that after the @&THEN@ of the first @&IF@, we set @InStatement@ on false.
> Removing this fixed the i... - 02:42 PM Conversion Tools Bug #9863: Fileset eXclude broken on native Windows
- Code Review Task Branch 9863a Revision 15979
The change @filter = filter.replace('/', File.separatorChar);@ seems ... - 01:26 PM Conversion Tools Bug #9863: Fileset eXclude broken on native Windows
- > Let me know if I should work on supporting the @X ./abl/folder1/@ filter in this task, I will adjust the %Done if s...
- 02:23 PM Conversion Tools Feature #6256: improved profile support
- > These profiles can only be used in the default @ConversionDriver@ mode which is @ListType.CMD_LINE@. For any of th...
- 01:48 PM Conversion Tools Feature #6256: improved profile support
- > There is a problem when the 'exclude' filter is used to not add files to conversion. During pre-scan phase, the fi...
- 10:56 AM Runtime Infrastructure Bug #10136: SESSION:TEMP-DIRECTORY missing directory
- We only should implement the change if that is how OE works.
06/10/2025
- 12:16 PM Runtime Infrastructure Bug #9740 (Closed): Client running in batch mode stops with a crash on Windows
- 09:36 AM TRPL Feature #3211: implement multi-threaded pattern engine and rework the ConversionDriver to leverag...
- As discussed in today's IDE meeting, as a default approach I would expect that functions and variables are both *stro...
- 08:55 AM Conversion Tools Bug #9863: Fileset eXclude broken on native Windows
- We've been canonicalizing filenames to use @/@ on Windows in the past and had not found this limitation.
- 07:01 AM Conversion Tools Bug #9863: Fileset eXclude broken on native Windows
- The patterns should not be file-system specific. In fact, we should only support the @/@ as the path separator. The...
- 08:50 AM Database Feature #10094: RECIDs from different tenants of same logical database should not overlap
- > Please let me know if I got your question right.
Yes, mostly.
If the schema can be incorrect from prior runs ... - 05:53 AM Database Feature #10094: RECIDs from different tenants of same logical database should not overlap
- I'm trying to determine if we need to write a migration script to cleanup existing MT installations so that they matc...
- 08:40 AM Base Language Bug #10110 (Internal Test): add ClientPrincipal support for FWD OpenClient
- Code Review Task Branch 10110a Revision 15978
I have no objections.
I should have caught this sooner. I'd pref... - 06:50 AM Conversion Tools Feature #5586: move all conversion artifacts/outputs into the cvtdb or into a dedicated directory...
- Returning @null@ will likely result in an NPE and we will see the stack trace already.
- 05:55 AM Database Bug #9994 (Rejected): Err: Cannot run GET methods on query until it is opened.
- 05:29 AM Testing Support #10113: evaluate and test code coverage tooling
- The idea is to use existing tooling such as JaCoCo or JCov to calculate code coverage for an area of FWD code. For n...
- 05:23 AM Testing Support #10113 (Pending): evaluate and test code coverage tooling
06/09/2025
- 10:39 AM Conversion Tools Feature #5630 (Closed): add missing classes referenced during parsing to the conversion list in f...
- 10:39 AM Conversion Tools Bug #6082 (Closed): automatically add to conversion list all non-skeleton .cls dependencies
- 08:54 AM Runtime Infrastructure Feature #7080: expose all admin APIs via REST
- What additional testing is needed for 7080a? The admin console is broken in trunk until this is merged, right?
- 08:03 AM Database Feature #10094: RECIDs from different tenants of same logical database should not overlap
- Does this mean that existing imported databases may have some indexes which need to be dropped?
06/06/2025
- 11:28 AM Base Language Feature #9516: include pre-converted webspeed runtime code in FWD
- > Greg, we still have to bring the ADE converted source code into FWD. So, I assume for webspeed we will have a @com...
- 09:35 AM Base Language Feature #9516: include pre-converted webspeed runtime code in FWD
- Constantin Asofiei wrote:
> Radu Apetrii wrote:
> > Constantin Asofiei wrote:
> > > Lets make the WEB stream do no... - 11:24 AM Conversion Tools Feature #5586: move all conversion artifacts/outputs into the cvtdb or into a dedicated directory...
- In those cases, we should not call @getPathToConversionFolder()@. Just bypass it when the input is @null@. In other...
- 09:37 AM Conversion Tools Feature #5586: move all conversion artifacts/outputs into the cvtdb or into a dedicated directory...
- > I have found that there are many places that might call getPathToConversionFolder with a null filename
This seem...
06/05/2025
- 10:47 AM TRPL Feature #3211: implement multi-threaded pattern engine and rework the ConversionDriver to leverag...
- Are we instantiating multiple copies of the expression classes (one per thread)? Make sure the containers are initia...
- 10:09 AM Conversion Tools Feature #5586: move all conversion artifacts/outputs into the cvtdb or into a dedicated directory...
- > Created r15974 with the following changes:
Please add comments to these code locations to explain that @// these... - 10:00 AM Database Feature #7504: Export data tool from FWD into .d files
- Roger: I would prefer if @import.sh@ *did not* work on multiple database at once. The reasoning: separate logs for e...
06/04/2025
- 02:19 PM Database Feature #7504: Export data tool from FWD into .d files
- > I don't think adding as a reviewer adds as a watcher... is that a function that can be added?
No - 02:18 PM TRPL Feature #3211: implement multi-threaded pattern engine and rework the ConversionDriver to leverag...
- > Do you think the initialization and execution of init/post rules should happen on a per-thread basis?
Global in... - 02:06 PM Conversion Tools Feature #5630: add missing classes referenced during parsing to the conversion list in file list ...
- For now, that approach does resolve this issue. In the future, we would also want to be able to use the annotations ...
- 02:03 PM Conversion Tools Bug #6082: automatically add to conversion list all non-skeleton .cls dependencies
- What other related features are still not complete? The intention here is to resolve the problem that explciitly or ...
- 11:56 AM Conversion Tools Bug #9917: Fileset not ignoring case
- > I'd expect the right start.p to be selected here. What do you think Greg?
Yes. On a case-insensitive approach, ...
06/03/2025
- 11:03 AM Base Language Bug #10004: NativeInvoker fails if an argument is of type integerConstant
- Please compare it with the captured baseline. We might not hold up the branch for any regressions but we should know...
- 10:25 AM Base Language Bug #10004: NativeInvoker fails if an argument is of type integerConstant
- They are not migrated with JUnit/ABLUnit yet. You have to manually run a ChUI client to execute the test "driver" pr...
- 08:00 AM Base Language Bug #10004: NativeInvoker fails if an argument is of type integerConstant
- Artur Școlnic wrote:
> I have some issues running library_calls tests, is there a customer test suite that would be ... - 08:41 AM Conversion Tools Feature #6256: improved profile support
- Code Review Task Branch 6256a Revisions 15942 and 15943
The change is good.
Are you sure that the requirements ... - 08:15 AM Conversion Tools Feature #5630: add missing classes referenced during parsing to the conversion list in file list ...
- Does trunk rev 15852 (changes from #7255) resolve this task?
- 08:15 AM Conversion Tools Bug #6082: automatically add to conversion list all non-skeleton .cls dependencies
- Does trunk rev 15852 (changes from #7255) resolve this task?
06/02/2025
- 02:50 PM Database Feature #7504: Export data tool from FWD into .d files
- Roger: Please review @export.sh@.
- 11:25 AM Conversion Tools Feature #6256: improved profile support
- I don't remember that code. It isn't currently used in the project associated with #4069.
Still, if it was needed... - 10:43 AM Conversion Tools Feature #6256: improved profile support
- > > I updated https://proj.goldencode.com/projects/p2j/wiki/Chapter_6_Project_Setup#Profiles, but I am not sure how t...
- 10:53 AM TRPL Feature #3211: implement multi-threaded pattern engine and rework the ConversionDriver to leverag...
- > I added @astMap@ since @AstSymbolResolver.cleanup@ is used by each thread. I'm continuing to fully integrate these ...
- 07:17 AM Harness Feature #9922: Allow specifying encoding of external files.
- Shouldn't the close of the @BufferedReader@ be in a @finally@ block?
What testing is needed?
05/30/2025
- 11:18 AM Database Feature #7504: Export data tool from FWD into .d files
- The ant target is only there when the conversion project is there. In production, it is not there, so the @export.sh...
- 07:43 AM Testing Support #9844: finalize approach/techniques/standards for automating ABLUnit interactive UI tests
- > I guess that's a requirement if the testcases branch is public... is it?
No - 04:58 AM Conversion Tools Bug #9918: tilde doesn't duplicate semicolon in alternative codings
- That seems reasonable.
05/29/2025
- 09:31 AM Base Language Feature #9448: compatibility test security features
- We should fix that issue as part of this task.
- 07:54 AM Base Language Feature #9448: compatibility test security features
- +Marian
- 07:53 AM Base Language Feature #9448: compatibility test security features
- Yes, please do check them in and update [[p2j:Security Tests]] with the details of your changes.
- 07:39 AM Base Language Feature #9448: compatibility test security features
- How extensive are the tests? Did you write them or are they pre-existing?
> For fixing the compiling issue, I add... - 08:06 AM Conversion Tools Feature #6256: improved profile support
- Alexandru Lungu wrote:
> > So we intend for profiles to be self-contained definitions of applications/modules. I pre... - 07:37 AM Conversion Tools Feature #6256: improved profile support
- > When a profile is used using the -p option and we also use ListType.FILESET (-z), it should behave like -z was not ...
- 08:05 AM Database Feature #9831 (Closed): add admin API to set c3p0 configuration for individual tenant databases
- Thanks, Brian!
- 08:05 AM Runtime Infrastructure Feature #9002 (Closed): Improve landlord database connection resiliency and add transactions when...
- Thanks, Brian!
05/28/2025
- 12:53 PM Conversion Tools Bug #9917 (Internal Test): Fileset not ignoring case
- Code Review Task Branch 9917a Revision 15945
Please only initialize @directoryCache@ when @!isCaseSensitive()@ is ... - 11:14 AM TRPL Feature #3211: implement multi-threaded pattern engine and rework the ConversionDriver to leverag...
- > Do you think the resolver instance should not be shared? I'm concerned that fields such as @ruleScope@, @targetRoot...
- 11:07 AM Conversion Tools Support #9919: discuss and define the MVP for the first pass at IDE support
- Interesting results. I will have to check the licensing of LSP4J, not sure yet if it is safe to use.
I wasn't pla... - 10:36 AM Runtime Infrastructure Feature #9851 (Merge Pending): hard code the FWD version string in the JNI code at build time
- Code Review Task Branch 9851b Revision 15946
No objections. This should be quite safe.
You can merge 9851b to ... - 10:33 AM Runtime Infrastructure Feature #9851: hard code the FWD version string in the JNI code at build time
- Roger Borrello wrote:
> I do want to reiterate that many cases where the FWD version becomes "unknown" are resolved ... - 07:39 AM Runtime Infrastructure Feature #9851 (Merge Pending): hard code the FWD version string in the JNI code at build time
- You can merge to trunk now.
- 10:27 AM Conversion Tools Feature #6256: improved profile support
- Please plan to make additions to our documentation to explain this syntax.
05/27/2025
- 02:23 PM Runtime Infrastructure Feature #9851: hard code the FWD version string in the JNI code at build time
- The changes should be fairly safe. Please check Hotel GUI and Hotel ChUI and something with batch processes. If the...
- 01:02 PM Runtime Infrastructure Feature #9851 (Internal Test): hard code the FWD version string in the JNI code at build time
- Code Review Task Branch 9851a Revision 15934
The change is good. Have you tested the build process and the result... - 10:17 AM User Interface Bug #10045: The embedded Hotel Gui application is broken
- Sergey Ivanovskiy wrote:
> Although I was able to use the embedded Hotel GUI application but should not the old embe...
Also available in: Atom