Golden Code Redmine

07/25/2025

07:59 AM Base Language Feature #10290: Add support for character string literals options

Trunk is temporarily frozen now pending a customer delivery. When trunk unfreezes, we will put this into the merge q... Greg Shah

07:56 AM Database Bug #10337 (Test): Possible memory leak with FastFindCache

Greg Shah

07/24/2025

10:53 AM Base Language Feature #10290 (Internal Test): Add support for character string literals options

Code Review Task Branch 10290a Revision 16057
The changes are good.
The only thing is that @for (Pattern patter... Greg Shah

06:04 AM Base Language Feature #10290 (WIP): Add support for character string literals options

Greg Shah

06:03 AM Base Language Feature #10290: Add support for character string literals options

Code Review Task Branch 10290a Revision 16056
1. This code makes edits to @this.text@. ... Greg Shah

04:07 AM User Interface Feature #9055 (Internal Test): server-side processing of client platform dependencies in the UI

This needs to be tested for both ChUI and GUI. Greg Shah

07/23/2025

11:55 AM Base Language Feature #3853: implement LOG-MANAGER runtime

The core logging implementation exists in FWD today. What remains still to do from #3853-1, is to implement the runt... Greg Shah

10:48 AM User Interface Feature #5742 (Closed): improve web client startup time

Greg Shah

10:45 AM Runtime Infrastructure Feature #7279 (Closed): Enhance CentralLogger to support configurable LogFormatter

Greg Shah

10:41 AM Runtime Infrastructure Bug #6084 (Closed): NIO SSL performance is slower than standard Java SSL

Greg Shah

10:40 AM Database Support #4080: AWS Aurora support

I think this can be closed, but we should document that we support Aurora. Greg Shah

10:37 AM Database Feature #6454: database informational features

Eric: Can we close this? Greg Shah

07:31 AM Database Feature #10310: move tenant database from one multitenant cluster to another

The @recid@ uniqueness in FWD maps to the FWD server, not to the PostgreSQL cluster. This means that this migration ... Greg Shah

07/22/2025

08:31 AM Testing Support #9844: finalize approach/techniques/standards for automating ABLUnit interactive UI tests

Have you tried to get Roger's customer-specific GUI tests running on your system? Perhaps that would be a good test ... Greg Shah

07:48 AM Conversion Tools Bug #9917: Fileset not ignoring case

I wonder if Octavian's work in #3211 is related? Greg Shah

07/21/2025

11:58 AM Base Language Feature #9447 (Closed): XML support feature improvements and testing

Greg Shah

11:57 AM Base Language Support #9446 (Closed): compatibility test PUT-DOUBLE

Greg Shah

11:57 AM Base Language Feature #9442 (Closed): implement limited support for RCODE-INFORMATION

Greg Shah

11:56 AM Base Language Feature #8904 (Closed): implement -catchStop and the integration/conversion of STOP conditions in...

Greg Shah

10:55 AM Database Feature #6457: finish COPY-LOB support

From the wiki:
> All files from @tests/copy_lob/support/data@ should be moved to @deploy/client/tests/copy_lob/sup... Greg Shah

09:05 AM Database Feature #6457: finish COPY-LOB support

As you work through issues in these tests, please update [[p2j:LOB Tests]] with details of the test status and how to... Greg Shah

09:01 AM TRPL Feature #3211: implement multi-threaded pattern engine and rework the ConversionDriver to leverag...

We cannot put references to DMOs or temp-tables into generic AST support code. Please redesign the feature to expose... Greg Shah

07/18/2025

09:03 AM Base Language Feature #10290: Add support for character string literals options

OK, do that. Greg Shah

07:55 AM Base Language Feature #10290: Add support for character string literals options

Paul Bodale wrote:
> Another thing. I could not find what the @X@ option does. I've made some experiments with it an... Greg Shah

07:54 AM Base Language Feature #10290: Add support for character string literals options

I have to look further at this. The change in the lexer and parser may be tricky.
The alternative is something li... Greg Shah

07:07 AM Base Language Feature #10290: Add support for character string literals options

> I'm exploring regex rules, I think that this is the way to go because they are just so many combos.
Then we prob... Greg Shah

06:54 AM Database Support #6709: track nested FIND inside a related FOR loop

> If conversion changes are acceptable, this is what I'd like to do.
Yes, go ahead. Greg Shah

06:47 AM Database Support #6709: track nested FIND inside a related FOR loop

Dănuț Filimon wrote:
> [...]
>
> I can't come up with any idea on how to let the FindQuery that @tt2@ is a refere... Greg Shah

06:52 AM Runtime Infrastructure Feature #9687: drop support for Java 8 and Java 11

I plan to push this to xfer as soon as:
* Hynek confirms that the changes pass review.
* Tomasz confirms that the... Greg Shah

07/17/2025

09:50 AM Base Language Feature #10290: Add support for character string literals options

Also note that the digits are optional when they appear at the end of the options.
We could make changes to the le... Greg Shah

09:44 AM Base Language Feature #10290: Add support for character string literals options

Code Review Task Branch 10290a Revision 16055
1. Why is the code inserted at the top of @literals.rules@ instead o... Greg Shah

07:57 AM Database Bug #9683: CompoundQuery is doing extra hydration attempts

I assume we will finish this task first, but I am highlighting that we *really need to finish* the general solution t... Greg Shah

07/16/2025

01:36 PM Base Language Feature #10290: Add support for character string literals options

It is where we convert the contents. Processing the options is better done in TRPL where we have access to the optio... Greg Shah

12:48 PM Base Language Feature #10290: Add support for character string literals options

I expect the fix for the issue to be written in @rules/convert/literals.rules@. Greg Shah

12:43 PM Database Feature #4369: implement stateless FWD server clustering

We already run in Docker quite nicely. The issue is that there is quite a bit of 4GL compatibility (like database lo... Greg Shah

12:25 PM Database Bug #9683: CompoundQuery is doing extra hydration attempts

We need to finish the work in #6720. Greg Shah

12:24 PM Database Support #6709: track nested FIND inside a related FOR loop

We don't want this to be driven by conversion, but rather we would want to detect things purely based on runtime proc... Greg Shah

12:23 PM Database Support #6709: track nested FIND inside a related FOR loop

If we are implementing a runtime mode for this detection, we would expect to use the @TransactionManager@ to get deta... Greg Shah

07/15/2025

09:59 AM Base Language Feature #10290: Add support for character string literals options

> I don't think that will work, as we will not be able to test in 4GL.
I'm talking about the 4GL helper code in th... Greg Shah

09:10 AM Base Language Feature #10290: Add support for character string literals options

Constantin Asofiei wrote:
> Greg, isn't 4GL right-trimming when it does comparisons?
>
> I think we may need a 'c... Greg Shah

08:45 AM Base Language Feature #10290: Add support for character string literals options

If this works, then these string options are just a "shorthand" for encoding string literals. We can simply do that ... Greg Shah

08:44 AM Base Language Feature #10290: Add support for character string literals options

What about something as simple as this:... Greg Shah

08:28 AM Base Language Feature #10290: Add support for character string literals options

Yes, I understand that FWD currently ignores these. I want details on the OE behavior. Is it possible to write some... Greg Shah

07:55 AM Base Language Feature #10290: Add support for character string literals options

> Although probably the following instructions would be a better testcase as they don't behave the same:
I agree t... Greg Shah

06:42 AM Base Language Feature #10290: Add support for character string literals options

We parse those and already handle the @:U@ case. Please show a 4GL testcase that demonstrates alignment/trimming beh... Greg Shah

07:41 AM Conversion Tools Bug #10099: Tilde consumes the octals/follow-up characters, when in OE this doesn't happen

What revision of 6859b has the fix? Greg Shah

07:14 AM Database Feature #7504: Export data tool from FWD into .d files

The changes are good. I modified the title and contents to remove the reference to "Progress". These are now just r... Greg Shah

07/14/2025

05:10 PM Database Feature #7504: Export data tool from FWD into .d files

Actually, please merge after 10286a. Greg Shah

02:35 PM Database Feature #7504 (Merge Pending): Export data tool from FWD into .d files

7504b can be merged to trunk now. Greg Shah

07/11/2025

10:59 AM TRPL Feature #3211: implement multi-threaded pattern engine and rework the ConversionDriver to leverag...

We don't want a global lock. That essentially single threads the DMO conversion. Not good.
Instead, we would add... Greg Shah

05:19 AM TRPL Feature #3211: implement multi-threaded pattern engine and rework the ConversionDriver to leverag...

Don't we have a map in which we store some reference to a temp-table that is being converted to a DMO, keyed by an in... Greg Shah

07/10/2025

08:09 AM User Interface Bug #10085: Fix offset cursor when pressing (CTRL+V) in an editor

> Greg, could you help me please to clarify this? Thank you!
I think you are asking Vladimir to answer this? Greg Shah

08:08 AM Conversion Tools Feature #6256: improved profile support

> I think we should modify the profile to do one of the following:
> # Make the namespaces global and remove the pro... Greg Shah

07/09/2025

11:25 AM Conversion Tools Feature #6256: improved profile support

> I got a message from Razvan that he converted the ChUI project, but the "convert" command was skipped. This is beca... Greg Shah

06:21 AM Conversion Tools Feature #6256: improved profile support

> and there are different ways to get the file-set?
What do you mean? Greg Shah

08:00 AM Database Feature #10094: RECIDs from different tenants of same logical database should not overlap

*Eric/Constantin: Please review this ASAP so we can move this task ahead.* Greg Shah

07:18 AM Database Feature #7504: Export data tool from FWD into .d files

Ovidiu: Please get this into the merge queue if it is ready to go. Greg Shah

07/08/2025

03:55 PM Documentation Support #9709: Needed: Basic example of configuring separate client and server

Web client does need the spawner on the client box. That means implementing the broker functionality (see [[p2j:Remo... Greg Shah

09:44 AM Conversion Tools Feature #10190: Prototype the changes to the build to add ANTLR v4

Florin Eugen Rotaru wrote:
> Building with Java 1.8 fails because the currently ANTLR4 version needs at least Java 1... Greg Shah

08:28 AM Database Feature #10270: implement some temp-tables using the persistent database instance when they are j...

The idea here is that we could analyze usage of each temp-table and implement heuristcs that mark specific temp-table... Greg Shah

08:23 AM Database Feature #10270 (New): implement some temp-tables using the persistent database instance when they...

Greg Shah

08:07 AM Testing Support #6859: preprocessor tests

Stefan Vieru wrote:
> Greg Shah wrote:
> > Code Review Task Branch 6859b Revisions 16029 through 16036
> >
> > 4... Greg Shah

08:04 AM Testing Support #6859: preprocessor tests

Stefan Vieru wrote:
> Greg Shah wrote:
> > Code Review Task Branch 6859b Revisions 16029 through 16036
> >
> > 3.... Greg Shah

07/07/2025

04:51 PM Conversion Tools Feature #10265: schema-only conversion

As of trunk rev 16028, one cannot convert schemata without including at least one program. In #9455-25, this techniq... Greg Shah

04:41 PM Conversion Tools Feature #10265 (Closed): schema-only conversion

Greg Shah

09:16 AM Database Support #10222: Is cross-session dirty share available through Fast Find Cache even if disabled?

> FWD is not leaking anything except FINDs that were done on other sessions as well. It sounds quite bad to me. Overa... Greg Shah

08:36 AM Testing Support #6859: preprocessor tests

Code Review Task Branch 6859b Revisions 16029 through 16036
These changes will need to be tested with the full ran... Greg Shah

07/03/2025

06:40 AM Base Language Bug #10004: NativeInvoker fails if an argument is of type integerConstant

Please see #10193-17 for an related update. Greg Shah

07/02/2025

01:04 PM Conversion Tools Feature #6256 (Internal Test): improved profile support

OK, it looks good. Greg Shah

08:49 AM Conversion Tools Feature #6256: improved profile support

Code Review Task Branch 6256a Revision 16022
My only question is why would the metadata schema be bypassed in prof... Greg Shah

05:46 AM Database Feature #9455: port native user defined functions to SQL Server

Eduard Soltan wrote:
> Question, can the tests from @testcases/udfs@ be adopted to SQL Server and properly tested?
... Greg Shah

05:45 AM Testing Support #10238: migrate UDF tests to ABLUnit and expand coverage

See [[p2j:UDF Tests]]. Greg Shah

05:44 AM Testing Support #10238 (New): migrate UDF tests to ABLUnit and expand coverage

Greg Shah

07/01/2025

06:00 PM Conversion Tools Bug #10215 (Internal Test): ant rpt fails when running only conversion.front

Greg Shah

06:00 PM Conversion Tools Bug #10215: ant rpt fails when running only conversion.front

Is #6490-29 still fixed with the 10125a? If so, this seems pretty low risk to merge. Greg Shah

05:56 PM Conversion Tools Feature #10190 (Internal Test): Prototype the changes to the build to add ANTLR v4

Greg Shah

05:56 PM Conversion Tools Feature #10190: Prototype the changes to the build to add ANTLR v4

Code Review Task Branch 10190a Revision 16001
The changes are good. Greg Shah

08:57 AM Conversion Tools Feature #10190 (WIP): Prototype the changes to the build to add ANTLR v4

Code Review Task Branch 10190a Revisions 15999 and 16000
The @registerGrammarTask()@ isn't quite right. Not all g... Greg Shah

04:51 PM Base Language Bug #9906: Incorrect date parsing in FWD DATE(CHARACTER) implementation

Vladimir Tsichevski wrote:
> Greg Shah wrote:
> > What testing has been done?
>
> The @TestParse.cls@ has 600+ t... Greg Shah

03:40 PM Base Language Bug #9906: Incorrect date parsing in FWD DATE(CHARACTER) implementation

What testing has been done? Greg Shah

08:21 AM Conversion Tools Feature #6256: improved profile support

Anything at the global level should be assumed to be present for all profiles. Anything in a profile should be *adde... Greg Shah

08:17 AM TRPL Feature #3211: implement multi-threaded pattern engine and rework the ConversionDriver to leverag...

> To avoid conflicts across thread I move the initialization into the variable declaration:
This should not be req... Greg Shah

08:13 AM Database Support #10222: Is cross-session dirty share available through Fast Find Cache even if disabled?

Artur Școlnic wrote:
> I used the temp table for simplicity, the behavior of the @find@ should be similar. I am just... Greg Shah

07:21 AM Documentation Support #9709: Needed: Basic example of configuring separate client and server

Sergey: Please review and answer the questions. Greg Shah

06/30/2025

03:15 PM Conversion Tools Support #10231: Document the code style guidelines for ANTLR grammars, based on progress.g

The core rules have these forms:... Greg Shah

02:27 PM TRPL Feature #3211: implement multi-threaded pattern engine and rework the ConversionDriver to leverag...

OK, that seems reasonable. The behavior of global init and post is meant to be executed once, not once per thread. ... Greg Shah

10:26 AM Conversion Tools Bug #10215: ant rpt fails when running only conversion.front

Why not just put some protection code in @describe_extent_lvalue@? Better yet, make sure that @describe_extent_lvalu... Greg Shah

09:12 AM Conversion Tools Bug #10208: do not convert the schema in incremental mode if it hasn't changed

Dănuț Filimon wrote:
> Greg, the skipDBSchema is quite old. I suggest removing it and using the @schema@ flag to do ... Greg Shah

07:59 AM Database Support #10222: Is cross-session dirty share available through Fast Find Cache even if disabled?

Artur Școlnic wrote:
> I agree, in a hypothetical scenario where someone changes a record and immediately attempts t... Greg Shah

07:47 AM Conversion Tools Feature #10190: Prototype the changes to the build to add ANTLR v4

Florin Eugen Rotaru wrote:
> Greg Shah wrote:
> > Code Review Task Branch 10190a Revisions 15996 through 15998
> >... Greg Shah

07:45 AM Base Language Bug #10221: jackson has a limitation of 20million for a string value

Is there any downside to making this change? (e.g. increased memory usage by default)
> do we make this configurab... Greg Shah

06/27/2025

01:32 PM Conversion Tools Feature #6256: improved profile support

Code Review Task Branch 6256a Revisions 15944 and 15945
If a profile contains any schema at all, then the top-leve... Greg Shah

01:01 PM TRPL Feature #3211: implement multi-threaded pattern engine and rework the ConversionDriver to leverag...

Octavian Adrian Gavril wrote:
> Greg Shah wrote:
> > You mean global in scope but not shared?
> >
> I'm referrin... Greg Shah

09:50 AM TRPL Feature #3211: implement multi-threaded pattern engine and rework the ConversionDriver to leverag...

Octavian Adrian Gavril wrote:
> Greg Shah wrote:
> > Are you talking about global post rules? Global init and post... Greg Shah

09:41 AM TRPL Feature #3211: implement multi-threaded pattern engine and rework the ConversionDriver to leverag...

> made some worker method calls from <post-rules to be executed by the main thread only. This way, adm_windows.xml, n... Greg Shah

12:29 PM Conversion Tools Feature #10190: Prototype the changes to the build to add ANTLR v4

Code Review Task Branch 10190a Revisions 15996 through 15998
The overall approach looks good.
1. We will have s... Greg Shah

09:47 AM Conversion Tools Bug #10208: do not convert the schema in incremental mode if it hasn't changed

The approach seems correct to me.
> I am not sure if there are any hint files for schema?
Yes, there are schema... Greg Shah

06/26/2025

11:40 AM Conversion Tools Feature #10190: Prototype the changes to the build to add ANTLR v4

> Instead of using the bundled AntlrTask from gradle(which was introducing the dependency conflict), we can manually ... Greg Shah

10:09 AM Conversion Tools Bug #10208: do not convert the schema in incremental mode if it hasn't changed

I don't object, but can we just add the schemata to the FILE_SIGNATURE table? Greg Shah