Golden Code Redmine

09/23/2025

09:32 AM Runtime Infrastructure Feature #10451: GUI interaction event logging

I like the idea of a separate output log but I don't want to have more than one logging infrastructure. Let's try to... Greg Shah

07:46 AM Base Language Bug #10613: Incremental conversion issue: temp-table dmo does not get converted

Teodor Gorghe wrote:
> Danut, the *6083a* has a fix for this issue? I see that Constantin reported it on #10536-15.
... Greg Shah

09/19/2025

08:24 AM TRPL Feature #3211: implement multi-threaded pattern engine and rework the ConversionDriver to leverag...

I don't want to single thread things that are not needed. I prefer not to leave this dependency on state modificatio... Greg Shah

09/18/2025

01:37 PM TRPL Feature #3211: implement multi-threaded pattern engine and rework the ConversionDriver to leverag...

If we just pass enough information to the name converter to know the dialect, then none of this schema knowledge or s... Greg Shah

11:02 AM TRPL Feature #3211: implement multi-threaded pattern engine and rework the ConversionDriver to leverag...

I prefer to eliminate the schema-specific nature of the design. I don't see the value it provides in this case. Ple... Greg Shah

09:29 AM TRPL Feature #3211: implement multi-threaded pattern engine and rework the ConversionDriver to leverag...

Octavian Adrian Gavril wrote:
> Greg Shah wrote:
> > Why does the schema name matter here? A reserved SQL keyword ... Greg Shah

08:44 AM TRPL Feature #3211: implement multi-threaded pattern engine and rework the ConversionDriver to leverag...

Why does the schema name matter here? A reserved SQL keyword is reserved for a given dialect no matter what schema i... Greg Shah

08:30 AM TRPL Feature #3211: implement multi-threaded pattern engine and rework the ConversionDriver to leverag...

> I think a solution would be to move @reservedSQL@ as static field (*no context-local*) and to refactor it as a map ... Greg Shah

09/17/2025

09:17 AM TRPL Feature #3211: implement multi-threaded pattern engine and rework the ConversionDriver to leverag...

Aren't reserved keywords things that we know in advance and they don't change? Why would they need to be dynamically... Greg Shah

09:06 AM TRPL Feature #3211: implement multi-threaded pattern engine and rework the ConversionDriver to leverag...

> > Any such static data needs to be properly thread-safe so that all access is syncronized or handled via some concu... Greg Shah

08:59 AM TRPL Feature #3211: implement multi-threaded pattern engine and rework the ConversionDriver to leverag...

Any such static data needs to be properly thread-safe so that all access is syncronized or handled via some concurren... Greg Shah

08:58 AM TRPL Feature #3211: implement multi-threaded pattern engine and rework the ConversionDriver to leverag...

What do you mean by "static context"? Anything that is a static member will exist for the lifetime of the JVM. Conv... Greg Shah

09/16/2025

09:47 AM TRPL Feature #3211: implement multi-threaded pattern engine and rework the ConversionDriver to leverag...

Shouldn't each @PatternEngine@ invocation create a new thread pool? Making a single-threaded process would be as sim... Greg Shah

07:24 AM Base Language Feature #6432: implement the WEB special stream

I see that @StreamFactory.openWebStream()@ has this:... Greg Shah

09/15/2025

11:14 AM Runtime Infrastructure Bug #10565: java.security.NoSuchAlgorithmException: no such algorithm: SunX509 for provider Consc...

What is the recreate? Greg Shah

09:15 AM Base Language Bug #10365: Mismatched number of parameters passed to routine for external function

We will rely upon the testing of 6506b to test these changes. Greg Shah

09:14 AM Base Language Bug #10365: Mismatched number of parameters passed to routine for external function

The changes should be in 6506b. Greg Shah

08:54 AM Base Language Bug #10365: Mismatched number of parameters passed to routine for external function

Constantin: Do you have any remaining concerns? Greg Shah

08:55 AM Conversion Tools Support #10231 (Review): Document the code style guidelines for ANTLR grammars, based on progress.g

Greg Shah

08:18 AM Testing Support #6860: lexer tests

We need to write documentation for this test suite in [[p2j:Lexer Testcases]]. Greg Shah

08:16 AM Testing Support #6859: preprocessor tests

We need to write documentation for this test suite in [[p2j:Preprocessor Testcases]]. Greg Shah

09/11/2025

09:11 AM Conversion Tools Bug #10469: incremental conversion when basepath is more than one folder (aka abl/foo) with #5586

Code Review Task Branch 6083a Revision 16159
The changes make sense. Greg Shah

06:43 AM User Interface Bug #10485: App freeze due to lack of synchronization

The network test is only a diagnostic tool. Real users will almost never use it. The websocket should only ever be ... Greg Shah

09/10/2025

10:49 AM TRPL Feature #3211: implement multi-threaded pattern engine and rework the ConversionDriver to leverag...

OK Greg Shah

09:53 AM TRPL Feature #3211: implement multi-threaded pattern engine and rework the ConversionDriver to leverag...

> The current issue that I'm working on is related to custom properties added to temp-tables DMOs by files which use ... Greg Shah

08:43 AM Conversion Tools Feature #6256: improved profile support

> The hotel samples do not have this configuration, but I can still setup the build.xml to contain the steps necessar... Greg Shah

07:56 AM Conversion Tools Feature #6256: improved profile support

In this multi vs merged scenario, its mutually exclusive nature means that the application jar will contain the conve... Greg Shah

08:40 AM Conversion Tools Feature #6319: IntelliJ plugin

> Greg, does this answer your question?
Yes, it does.
Some remaining questions:
* What are the functional li... Greg Shah

09/09/2025

07:26 AM Conversion Tools Bug #6738 (Internal Test): incremental conversion when deleting program or class files

Greg Shah

07:26 AM Conversion Tools Bug #6738: incremental conversion when deleting program or class files

Code Review Task Branch 6083a Revisions 16158
I'm good with the change. Greg Shah

07:10 AM Conversion Tools Bug #6738: incremental conversion when deleting program or class files

> How should I look for the name_map.xml in the jar if the expected path is @./cvt/name_map.xml@?
What I'm saying ... Greg Shah

06:47 AM Conversion Tools Bug #6738: incremental conversion when deleting program or class files

Code Review Task Branch 6083a Revisions 16156 and 16157
The changes are fine except I don't think we want to have ... Greg Shah

07:08 AM Conversion Tools Feature #6319: IntelliJ plugin

> With the last IntelliJ update *(2025.2)*, the LSP API is now available to all IDEA users. In other words, we can no... Greg Shah

09/08/2025

10:57 AM Database Feature #6720: lazy hydration

In these tests you aren't measuring the cost of creating the BDT values. That tends to be expensive. Greg Shah

08:13 AM User Interface Bug #10485: App freeze due to lack of synchronization

Paula Păstrăguș wrote:
> Yes, sendMessage is only called from the push worker thread, so in practice it doesn’t real... Greg Shah

09/05/2025

08:50 AM Conversion Tools Feature #10265 (WIP): schema-only conversion

Greg Shah

08:50 AM Conversion Tools Feature #10265: schema-only conversion

Code Review Task Branch 10265a Revision 16139
I don't think this change is the right approach.
* The point of t... Greg Shah

08:19 AM Conversion Tools Bug #6738: incremental conversion when deleting program or class files

> I discussed with Alex and he mentioned that name_map.xml should be placed in the @cvt@ folder because it is an arti... Greg Shah

08:18 AM Conversion Tools Bug #6738: incremental conversion when deleting program or class files

Let's have the name map default to @./cvt/name_map.xml@ and get the @build.xml@ change put into all projects.
It m... Greg Shah

09/04/2025

11:28 AM Conversion Tools Feature #6256: improved profile support

Roger Borrello wrote:
> Greg Shah wrote:
> > The @.df@ should stay in @data/@. It is only the intermediate and out... Greg Shah

11:22 AM Conversion Tools Feature #6256: improved profile support

> Let me know your thoughts.
I'm OK with the approach, especially if the @build.xml@ can be common to most applica... Greg Shah

10:38 AM Conversion Tools Bug #6738: incremental conversion when deleting program or class files

Dănuț Filimon wrote:
> Since I used a bit of code from *6083a* and the changes are related to the recent incremental... Greg Shah

10:38 AM Conversion Tools Bug #6738: incremental conversion when deleting program or class files

Code Review Task Branch 6738a Revision 16145
1. In @ConversionData.cleanupDeletedFiles()@, I wonder if the @mgr.sa... Greg Shah

09/03/2025

10:28 AM Database Bug #7793 (Internal Test): incremental conversion with deleted table from .df

Code Review Task Branch 6083a Revisions 16130 and 16131
The changes are good. Greg Shah

09/02/2025

05:56 PM Conversion Tools Feature #6256: improved profile support

> I'm able to remove all the extra @convert.zset@ BS.
This is good. Please do this without the profile (use the ... Greg Shah

05:54 PM Conversion Tools Feature #6256: improved profile support

The @.df@ should stay in @data/@. It is only the intermediate and output artifacts that should be in @cvt/data/@.
... Greg Shah

11:38 AM Conversion Tools Feature #6256: improved profile support

Roger Borrello wrote:
> Greg Shah wrote:
> > If they are in the jar, we definitely DO NOT want them deployed in the... Greg Shah

10:02 AM Conversion Tools Feature #6256: improved profile support

If they are in the jar, we definitely DO NOT want them deployed in the filesystem.
> BTW, even though these change... Greg Shah

08:28 AM Conversion Tools Feature #6256: improved profile support

Yes, the filesystem approach is for dev environments and the jar would be used in prod. Greg Shah

08:05 AM Conversion Tools Feature #6256: improved profile support

Not sure about the @.dict@ but we currently have a dependency on the @.p2o@ for import and it certainly should have a... Greg Shah

03:55 PM Database Bug #7793: incremental conversion with deleted table from .df

Code Review Task Branch 6083a Revisions 16127 and 16128
Overall, it looks good.
1. In @getPathToConversionFolde... Greg Shah

10:25 AM User Interface Bug #10512: REGRESSION: In ChUI, all RADIO-SET items are positioned at the same location

Please update [[regression:Open Regressions in FWD v4]] with an entry about the regression. Greg Shah

08:33 AM Database Feature #10491: Tool to standardize PG cluster creation

> It's difficult to tell how any other projects create their clusters, since it isn't part of any current scripting. ... Greg Shah

08:06 AM Base Language Bug #10509: SEARCH(directory_path) returns unkown

Please post the 4GL code example that works differently in OE and FWD. Greg Shah

07:12 AM Base Language Bug #9037 (WIP): Two timers problem: only one fires

There are multiple reviews that have been done, with some issues raised that need to be addressed.
Does the recent... Greg Shah

09/01/2025

08:45 AM Database Bug #7793: incremental conversion with deleted table from .df

> > * Reconvert any source artifact whose output artifact has been deleted.
> I don't really understand the idea her... Greg Shah

08/29/2025

12:16 PM Database Feature #10491: Tool to standardize PG cluster creation

I am not suggesting that we expand use of @build_db.xml@. The opposite, I want everything in there to be using tools... Greg Shah

09:50 AM Base Language Bug #10365: Mismatched number of parameters passed to routine for external function

Any objections, Constantin? Greg Shah

09:35 AM Base Language Bug #10365: Mismatched number of parameters passed to routine for external function

Code Review Task Branch 6506a Revision 15775
No objections. Please edit the comment at location so that it doesn'... Greg Shah

09:48 AM Conversion Tools Bug #6308 (Internal Test): post string literal alternative coding quirk in 4GL preprocessor

I've reviewed this change and all the related change in 6859b. It is difficult to assess by code review alone, if th... Greg Shah

09:47 AM Conversion Tools Bug #9886 (Internal Test): Double slashes should produce a new line during preprocessing

I've reviewed this change and all the related change in 6859b. It is difficult to assess by code review alone, if th... Greg Shah

09:47 AM Conversion Tools Bug #9903 (Internal Test): alternative codings with ' (quote) don't convert to ` (backtick)

I've reviewed this change and all the related change in 6859b. It is difficult to assess by code review alone, if th... Greg Shah

09:47 AM Conversion Tools Bug #9918 (Internal Test): tilde doesn't duplicate semicolon in alternative codings

I've reviewed this change and all the related change in 6859b. It is difficult to assess by code review alone, if th... Greg Shah

09:47 AM Conversion Tools Bug #10099 (Internal Test): Tilde consumes the octals/follow-up characters, when in OE this doesn...

I've reviewed this change and all the related change in 6859b. It is difficult to assess by code review alone, if th... Greg Shah

09:10 AM Database Bug #7793: incremental conversion with deleted table from .df

It is fine to store at any point in the process, late or early, it should not matter. Greg Shah

08:59 AM Database Bug #7793: incremental conversion with deleted table from .df

If possible, try not to make the changes for #7180 more difficult.
It also seems like a potentially good idea to s... Greg Shah

09:01 AM Database Bug #10483: memory leak in BufferManager.openBuffers

> The protection ensures only for this specific case.
I understand. But should we expand this to be unconditional... Greg Shah

08:41 AM Database Bug #10483: memory leak in BufferManager.openBuffers

Code Review Task Branch 10483a Revision 16137 and 16138
For @RB.openScope()@, what are 4GL code examples that caus... Greg Shah

08/28/2025

02:57 PM Database Feature #10491: Tool to standardize PG cluster creation

This must be able to fully replace the cluster initialization in @build_db.xml@. In other words, we will eliminate t... Greg Shah

02:53 PM Database Feature #10491: Tool to standardize PG cluster creation

> Should I leave it like that, or allow each current line to have the specified authorization method, instead of the ... Greg Shah

07:24 AM Conversion Tools Bug #10208 (Closed): do not convert the schema in incremental mode if it hasn't changed

Greg Shah

07:24 AM Conversion Tools Bug #9863 (Closed): Fileset eXclude broken on native Windows

Greg Shah

07:24 AM Conversion Tools Feature #6256 (Closed): improved profile support

Greg Shah

07:22 AM Database Bug #7793: incremental conversion with deleted table from .df

I like the approach. You can put the changes into 6083a. Greg Shah

07:18 AM Conversion Tools Feature #5586 (Closed): move all conversion artifacts/outputs into the cvtdb or into a dedicated ...

Greg Shah

08/27/2025

10:38 AM Conversion Tools Feature #6083 (Internal Test): schema (.df) changes in incremental conversion mode should only re...

Code Review Task Branch 6083a Revisions 16125 through 16127
I'm good with the changes. Greg Shah

06:49 AM Conversion Tools Feature #6083: schema (.df) changes in incremental conversion mode should only reconvert those pr...

> The only issue that I can see right now, is that the last table parsed will contain the df footer:
That must be ... Greg Shah

06:46 AM Conversion Tools Bug #9917: Fileset not ignoring case

You can control the merge. Greg Shah

06:14 AM User Interface Bug #10075: Number format validation issues

> Therefore, I’ve decided to place @NumberFormatValidationTest.cls@ in the same directory as @TestString.cls@
Thi... Greg Shah

08/26/2025

03:44 PM User Interface Bug #10075: Number format validation issues

I mean in that set of tests. It probably won't be in that same class. Over time we will probably refactor the exist... Greg Shah

03:02 PM User Interface Bug #10075: Number format validation issues

It is still the place to put the test code. I expect many more tests to be added over time. Greg Shah

01:23 PM User Interface Bug #10075: Number format validation issues

See [[p2j:Format String Tests]]. Greg Shah

07:17 AM User Interface Bug #10075: Number format validation issues

Please commit all tests into the testcases project. Greg Shah

10:09 AM Conversion Tools Feature #6083: schema (.df) changes in incremental conversion mode should only reconvert those pr...

Yes, and it just needs to be checked by tablename and schema (the table is uniquely named per schema). Greg Shah

08:15 AM Conversion Tools Feature #6083: schema (.df) changes in incremental conversion mode should only reconvert those pr...

The original detection of a change to the @.df@ might just be from whitespace changes or ordering differences (conten... Greg Shah

07:41 AM Conversion Tools Feature #6083: schema (.df) changes in incremental conversion mode should only reconvert those pr...

If we are operating on the original text from the @.df@ then we would NOT be calculating any changes in the AST. Greg Shah

07:54 AM Base Language Bug #4766: fix CHR and ASC

In OE, one must provide the proper command line arguments to set the @CP*@ values. Since we use the PCT ("Progress C... Greg Shah

08/25/2025

10:33 AM Database Support #10420: Refactoring DMO interface layers

Good additions, Alex! Greg Shah

09:19 AM Conversion Tools Feature #6083: schema (.df) changes in incremental conversion mode should only reconvert those pr...

We could calculate the checksum for the original input text for that table. That would be more consistent with our f... Greg Shah