Activity

From 04/25/2014 to 05/24/2014

05/23/2014

02:37 PM Bug #2293: Fixing an unfixed extent output parameter causes an error: Constantin Asofiei wrote:
> How do you expect the converted code will look?
There are not many changes in the con... Hynek Cihlar
01:50 AM Bug #2293: Fixing an unfixed extent output parameter causes an error: Hynek Cihlar wrote:
> In terms of implementation, I don't have a better idea than storing the variable pair consisti... Constantin Asofiei

05/22/2014

04:58 PM Feature #2050: ATTR_POLY/METH_POLY used as rvalue or in expressions: As far as I know, only the issue in note 24 remains open for this task.
I believe that most of the problem in this... Greg Shah
01:20 PM Bug #2293: Fixing an unfixed extent output parameter causes an error: The implementation should be straightforward with one exception - fixing the indeterminate extent argument. When the ... Hynek Cihlar
11:39 AM Bug #2293: Fixing an unfixed extent output parameter causes an error: Constantin Asofiei wrote:
> Hynek Cihlar wrote:
> > When error is raised during function or procedure execution, th... Hynek Cihlar
01:41 AM Bug #2293: Fixing an unfixed extent output parameter causes an error: Hynek Cihlar wrote:
> When error is raised during function or procedure execution, the variable passed in the block ... Constantin Asofiei

05/21/2014

06:02 PM Bug #2293: Fixing an unfixed extent output parameter causes an error: Constantin Asofiei wrote:
> Hynek Cihlar wrote:
> > The above covers functions only. I will also test procedure out... Hynek Cihlar
01:30 PM Bug #2293: Fixing an unfixed extent output parameter causes an error: Hynek Cihlar wrote:
> The above covers functions only. I will also test procedure output parameters to see how it be... Constantin Asofiei
11:16 AM Bug #2293: Fixing an unfixed extent output parameter causes an error: Constantin Asofiei wrote:
> Hynek, something else to test: what happens with an extent var passed as an OUTPUT argum... Hynek Cihlar
08:42 AM Feature #1596 (Closed): complete big decimal implementation: Greg Shah
08:41 AM Feature #1600 (Closed): provide a conversion option to emit decimal literals using a string liter...: Greg Shah

05/20/2014

05:07 PM Feature #1600: provide a conversion option to emit decimal literals using a string literal instea...: Regression tests passed. Code changes committed to bzr revision 10535. Hynek Cihlar
11:56 AM Bug #2197: fix the error message list cleanup when NO-ERROR mode is enabled and ERROR-STATUS:ERRO...: > Why there are possible of more than one error?! - It's for cases where could be more than one error during executio... Greg Shah
10:36 AM Feature #1630: implement support for UNBUFFERED in I/O statements: It is expected that P2J is not working. The runtime support for UNBUFFERED is not yet implemented. Your testcases l... Greg Shah
08:50 PM Feature #1630: implement support for UNBUFFERED in I/O statements: @UNBUFFERED@ statement is not working properly in p2j. This keyword is properly converted, but worked different.
One... Evgeny Kiselev
05:27 AM Bug #2293: Fixing an unfixed extent output parameter causes an error: Hynek, something else to test: what happens with an extent var passed as an OUTPUT argument, if the function/proc doe... Constantin Asofiei

05/19/2014

04:38 PM Feature #1600: provide a conversion option to emit decimal literals using a string literal instea...: Greg Shah wrote:
> Code Review 0519a
>
> It looks good. Sorry that I didn't think about this approach before now... Hynek Cihlar
03:18 PM Feature #1600: provide a conversion option to emit decimal literals using a string literal instea...: Code Review 0519a
It looks good. Sorry that I didn't think about this approach before now. It was your good idea... Greg Shah
02:29 PM Feature #1600: provide a conversion option to emit decimal literals using a string literal instea...: Attached is the change set with the removed check for decimal literals being effectively mathematical integers. Now t... Hynek Cihlar
02:10 PM Feature #1600: provide a conversion option to emit decimal literals using a string literal instea...: Greg Shah wrote:
> > Or are you saying that we should not care about the literal being effectively an integer (and d... Hynek Cihlar
02:05 PM Feature #1600: provide a conversion option to emit decimal literals using a string literal instea...: > Or are you saying that we should not care about the literal being effectively an integer (and do not check for this... Greg Shah
11:46 AM Feature #1600: provide a conversion option to emit decimal literals using a string literal instea...: Greg Shah wrote:
> Code Review 0518a
>
> The changes look good. I really like your approach of using the Java @d... Hynek Cihlar
09:31 AM Feature #1600: provide a conversion option to emit decimal literals using a string literal instea...: Code Review 0518a
The changes look good. I really like your approach of using the Java @double@ and @BigDecimal@ ... Greg Shah
04:31 PM Feature #2184 (Closed): create and populate the temp-table on the remote side, based on the recei...: Eric Faulhaber
07:34 AM Feature #2184 (Review): create and populate the temp-table on the remote side, based on the recei...: Stanislav Lomany
07:33 AM Feature #2184 (WIP): create and populate the temp-table on the remote side, based on the received...: Merged update. Stanislav Lomany
02:02 PM Bug #2250 (Closed): Conversion error when decimal precision defined on dynamic extent variable: Greg Shah
01:39 PM Bug #2250: Conversion error when decimal precision defined on dynamic extent variable: I accidentally fixed this issue in the issue #2294. This can be closed now. Hynek Cihlar

05/18/2014

06:32 PM Feature #1600: provide a conversion option to emit decimal literals using a string literal instea...: Attached is the implementation with the special handling of mathematical integers. Now the decimal literal is emitted... Hynek Cihlar

05/16/2014

11:45 AM Feature #1600: provide a conversion option to emit decimal literals using a string literal instea...: Good points. OK, go ahead with your approach. Please do put in the code to detect the 17 digit issue at conversion ... Greg Shah
10:26 AM Feature #1600: provide a conversion option to emit decimal literals using a string literal instea...: Greg Shah wrote:
> We very much like to avoid wrapping when unnecessary. Your idea about whole numbers is a good on... Hynek Cihlar
09:37 AM Feature #1600: provide a conversion option to emit decimal literals using a string literal instea...: We very much like to avoid wrapping when unnecessary. Your idea about whole numbers is a good one. It does have to ... Greg Shah
08:47 AM Feature #1600: provide a conversion option to emit decimal literals using a string literal instea...: I am wondering, whether we should emit the wrapper even for (effectively) whole numbers? Ex. instead of @.assign(new ... Hynek Cihlar

05/15/2014

04:22 PM Bug #2294 (Closed): In Progress the variable initializer ignores the declared decimal precision: Greg Shah
12:55 PM Bug #2294: In Progress the variable initializer ignores the declared decimal precision: Committed to bzr revision 10532. Hynek Cihlar
11:31 AM Bug #2294: In Progress the variable initializer ignores the declared decimal precision: Good! Check in and distribute the changes. Greg Shah
11:26 AM Bug #2294: In Progress the variable initializer ignores the declared decimal precision: The regression test (after several attempts) passed. Hynek Cihlar

05/13/2014

08:03 AM Feature #1628: fix any incompatibilities or missing features of NO-ECHO support: The client code will have to be looked at closely in regard to flushing. There are other times when flushing occurs ... Greg Shah

05/12/2014

06:21 PM Feature #1628: fix any incompatibilities or missing features of NO-ECHO support: Everything is correct, except one:
>C: this line outputs the default (unnamed) frame to the unnamed stream which is ... Evgeny Kiselev
02:58 PM Feature #1628: fix any incompatibilities or missing features of NO-ECHO support: > Behaviour of display and stream functionality is more complicated than I thought before.
Yes, it is very tricky.... Greg Shah
03:53 PM Feature #1600: provide a conversion option to emit decimal literals using a string literal instea...: Code Review 0512b
Looks good. Get it regression tested. Both conversion and runtime testing are necessary. The ... Greg Shah
03:33 PM Feature #1600: provide a conversion option to emit decimal literals using a string literal instea...: Greg Shah wrote:
> Code Review 0512a
>
> The code looks fine. My only question is about this:
>
> [...]
>
... Hynek Cihlar
02:14 PM Feature #1600: provide a conversion option to emit decimal literals using a string literal instea...: Code Review 0512a
The code looks fine. My only question is about this:... Greg Shah
12:52 PM Feature #1600 (Review): provide a conversion option to emit decimal literals using a string liter...: Hynek Cihlar
12:46 PM Feature #1600: provide a conversion option to emit decimal literals using a string literal instea...: Please review the attached changes. The related test cases are committed as uast/decimal_literal_precision.p.
Hynek Cihlar
09:34 PM Feature #1600 (WIP): provide a conversion option to emit decimal literals using a string literal ...: Hynek Cihlar
02:16 PM Feature #1630: implement support for UNBUFFERED in I/O statements: Check all uses (not just OUTPUT). I would hope that it just means that we flush with every write (synchronously). Greg Shah
11:52 AM Bug #2133 (Closed): fix precision for decimal, dynamic-extent variables: Greg Shah
11:14 AM Bug #2294: In Progress the variable initializer ignores the declared decimal precision: Hynek, the changes on 0511a.zip look good. How was the regression testing? Constantin Asofiei

05/11/2014

05:02 PM Bug #2294 (Review): In Progress the variable initializer ignores the declared decimal precision: Hynek Cihlar
04:41 PM Bug #2294: In Progress the variable initializer ignores the declared decimal precision: Please review the attached change set. It passes the companion uast/testcases which include cases for @setTempPrecisi... Hynek Cihlar

05/09/2014

06:42 PM Feature #1630: implement support for UNBUFFERED in I/O statements: Do I need to test only @output@ or all places there can be used @unbuffered@ ? (like input, input-output and etc) Evgeny Kiselev
03:58 PM Feature #1628: fix any incompatibilities or missing features of NO-ECHO support: Behaviour of display and stream functionality is more complicated than I thought before.
Some @display@ call can ref... Evgeny Kiselev
08:19 AM Bug #2300: :: operator used in UI statements: It was a standalone case I used for investigation of some other issue.
The temporary fix was the cause of the regre... Ovidiu Maxiniuc
08:10 AM Bug #2300: :: operator used in UI statements: Was this found in standalone testcases or does this actually occur in customer code? Greg Shah
04:15 AM Bug #2300: :: operator used in UI statements: The conversion error is revealed by the following simple testcase:... Ovidiu Maxiniuc
03:41 AM Bug #2300 (New): :: operator used in UI statements: Ovidiu Maxiniuc

05/08/2014

12:38 PM Bug #2133: fix precision for decimal, dynamic-extent variables: 0505a passed regression test and was committed to bzr revision 10524. Hynek Cihlar
07:24 AM Feature #2184: create and populate the temp-table on the remote side, based on the received metad...: Stanislav Lomany wrote:
> Merged with the latest revision.
Stanislav, the logic looks good to me. Constantin Asofiei
07:09 AM Feature #2184: create and populate the temp-table on the remote side, based on the received metad...: Merged with the latest revision. Stanislav Lomany
10:01 PM Feature #2184: create and populate the temp-table on the remote side, based on the received metad...: Stas, I apologize it has taken so long for me to review this. Because of this delay, it is no longer in sync with the... Eric Faulhaber

05/07/2014

05:22 PM Bug #2294: In Progress the variable initializer ignores the declared decimal precision: Constantin Asofiei wrote:
> Hynek Cihlar wrote:
> > In the converted code the only use case for setPrecision seems ... Hynek Cihlar
02:23 AM Bug #2294: In Progress the variable initializer ignores the declared decimal precision: Hynek Cihlar wrote:
> In the converted code the only use case for setPrecision seems to be the variable definition. ... Constantin Asofiei

05/06/2014

02:22 PM Bug #2147 (Closed): fix any runtime issues with format strings (server project): Greg Shah
02:16 PM Feature #1885 (Closed): fix and add necessary format string support: Greg Shah
12:46 PM Bug #2294: In Progress the variable initializer ignores the declared decimal precision: The only occurrence of @setPrecision@ is in srcnew/java/aero/timco/majic/item/Toolissu.java. There it is used the sam... Hynek Cihlar
12:37 PM Bug #2294: In Progress the variable initializer ignores the declared decimal precision: Constantin Asofiei wrote:
> I don't think is worth having both @decimal.setPrecision@ and @decimal.setLazyPrecision@... Hynek Cihlar
09:56 AM Bug #2294: In Progress the variable initializer ignores the declared decimal precision: I don't think is worth having both @decimal.setPrecision@ and @decimal.setLazyPrecision@, because there is no case wh... Constantin Asofiei
12:25 PM Bug #2133: fix precision for decimal, dynamic-extent variables: Constantin Asofiei wrote:
> As a side note, when building testcases, instead of using this:
> [...]
> you might fi... Hynek Cihlar
09:41 AM Bug #2133: fix precision for decimal, dynamic-extent variables: The changes look good.
As a side note, when building testcases, instead of using this:... Constantin Asofiei
09:38 AM Feature #2138: finish SEARCH-TARGET support: Greg Shah wrote:
> Great! Please check it in and distribute it.
Committed to bzr rev 10518. Constantin Asofiei
09:13 AM Feature #2138: finish SEARCH-TARGET support: Great! Please check it in and distribute it. Greg Shah
09:10 AM Feature #2138: finish SEARCH-TARGET support: Greg Shah wrote:
> 1. What is the reasoning behind the elimination of the @pushSuperProcedure()@ and @popSuperProced... Constantin Asofiei
08:42 AM Feature #2138: finish SEARCH-TARGET support: Code Review 0505a
1. What is the reasoning behind the elimination of the @pushSuperProcedure()@ and @popSuperProce... Greg Shah
04:27 AM Feature #2138: finish SEARCH-TARGET support: After the case found in #2266, the SUPER and RUN SUPER calls were re-investigated and these rules were found, for @SE... Constantin Asofiei
09:49 PM Feature #1628: fix any incompatibilities or missing features of NO-ECHO support: Greg Shah wrote:
> Code Review 0502a
>
> 1. Is the @GenericFrame@ change intentionally meant to only modify the c... Evgeny Kiselev

05/05/2014

01:22 PM Bug #2294: In Progress the variable initializer ignores the declared decimal precision: Please see the attached changes and provide feedback.
The solution seems to be functionally correct, however it i... Hynek Cihlar
12:54 PM Bug #2133: fix precision for decimal, dynamic-extent variables: Attached are the fixed formatting issues. Also, the related testcases are committed in the file @testcases/uast/exten... Hynek Cihlar
11:47 AM Feature #1628: fix any incompatibilities or missing features of NO-ECHO support: Code Review 0502a
1. Is the @GenericFrame@ change intentionally meant to only modify the case where @DISPLAY@ is u... Greg Shah

05/02/2014

07:47 PM Feature #1628: fix any incompatibilities or missing features of NO-ECHO support: This is pre review update, without doc headers.
1) @DirStream.java@ there is unnecessary new line. I'm not sure if t... Evgeny Kiselev
03:21 AM Bug #2133: fix precision for decimal, dynamic-extent variables: Hynek, the logic looks good, but there are some formatting issues:
* assignments.rules:
- line 229 is too long
* d... Constantin Asofiei

05/01/2014

01:16 AM Bug #2294 (WIP): In Progress the variable initializer ignores the declared decimal precision: Hynek Cihlar

04/30/2014

12:15 PM Bug #2133 (Review): fix precision for decimal, dynamic-extent variables: The attached code fixes decimal precision for extent variables and extent-to-extent assignment when rvalue is a param... Hynek Cihlar

04/25/2014

05:54 PM Bug #2293 (WIP): Fixing an unfixed extent output parameter causes an error: Hynek Cihlar
05:49 PM Bug #2293: Fixing an unfixed extent output parameter causes an error: Constantin Asofiei wrote:
> Hynek, this one is a little tricky: with output parameters, I think 4GL assumes nothing ... Hynek Cihlar
01:50 PM Bug #2293: Fixing an unfixed extent output parameter causes an error: Hynek, this one is a little tricky: with output parameters, I think 4GL assumes nothing is received from the original... Constantin Asofiei
01:44 PM Bug #2293: Fixing an unfixed extent output parameter causes an error: The code sample in note 1 is missing parameter qualifier. Below is the corrected version.... Hynek Cihlar
03:40 AM Bug #2293: Fixing an unfixed extent output parameter causes an error: Please post how the converted code for the program on note 1. Constantin Asofiei
03:09 PM Bug #2291 (Closed): Could not resolve closest legacy method for function returning an extent: Greg Shah
01:12 PM Bug #2291: Could not resolve closest legacy method for function returning an extent: Attached is the final change with the fixed code formatting. Committed into bzr revision 10516. No regression test run. Hynek Cihlar
03:39 AM Bug #2291: Could not resolve closest legacy method for function returning an extent: The change is OK, no regression testing is required. But before releasing it, make sure the code respects the 98-char... Constantin Asofiei
03:25 AM Bug #2292: Fix error handling when unfixed extent passed to fixed extent input parameter: Some notes here:
# the @/home/hc/p34141_Untitled8.ped@ is the actual program name, not some special string (i.e. if ... Constantin Asofiei

« Previous

Also available in: Atom

Project

General

Profile

FWD » Core Development » Base Language

Activity

Activity

05/23/2014

05/22/2014

05/21/2014

05/20/2014

05/19/2014

05/18/2014

05/16/2014

05/15/2014

05/13/2014

05/12/2014

05/11/2014

05/09/2014

05/08/2014

05/07/2014

05/06/2014

05/05/2014

05/02/2014

05/01/2014

04/30/2014

04/29/2014

04/28/2014

04/26/2014

04/25/2014