FWD » Core Development » Base Language

04/27/2025

09:40 AM Feature #6161: add support for DYNAMIC-PROPERTY() built-in function and DYNAMIC-PROPERTY language...

Paul Bodale wrote:
> * When setting a simple BDT property the code sometimes converts to the java native type. This ... Constantin Asofiei

09:34 AM Feature #6490: DYNAMIC-INVOKE which returns an extent

Review for 6490 rev 15875:
* @rules/convert/base_structure.xml@
** shouldn't this call @is_extent_or_poly_case@ fro... Constantin Asofiei

09:19 AM Feature #9488: implement all built-in OO classes using the open source ADE code from 12.8.4

Ioana, please get these changes and commit them (one at a time) to 9436b; please see the review bellow, and also make... Constantin Asofiei

07:34 AM Feature #9488: implement all built-in OO classes using the open source ADE code from 12.8.4

9488a was rebased from trunk rev 15875 - new rev 15902. Constantin Asofiei

08:38 AM Feature #9436: add built-in OO classes

Review for 9436b rev 15881:
* @MemoryOutputStream@
** please update the support annotations for @MemoryOutputStream... Constantin Asofiei

07:35 AM Feature #9436: add built-in OO classes

9436b was rebased from trunk rev 15875 - new rev 15881. Constantin Asofiei

04/26/2025

02:55 AM Feature #8904: implement -catchStop and the integration/conversion of STOP conditions into except...

Ovidiu Maxiniuc wrote:
> Review of 8904a/r15892.
>
> Generally, I am OK with the changes. And this is a large cha... Eduard Soltan

04/25/2025

03:04 PM Bug #4766: fix CHR and ASC

Delia Mitric wrote:
> What I don't understand is why BE result is the same as the LE result and I don't know how sh... Ovidiu Maxiniuc

02:48 AM Bug #4766: fix CHR and ASC

Ovidiu Maxiniuc wrote:
> Let's use @€@ (EURO SIGN) as reference.
> * it is the 8364th character in the Unicode se... Delia Mitric

10:53 AM Feature #8904: implement -catchStop and the integration/conversion of STOP conditions into except...

Review of 8904a/r15892.
Generally, I am OK with the changes. And this is a large change-set. I have just a few com... Ovidiu Maxiniuc

08:14 AM Feature #8904: implement -catchStop and the integration/conversion of STOP conditions into except...

Constantin Asofiei wrote:
> The only concern is the usage of @isIgnore()@ in @ErrorManager.handleStopException@ - do... Eduard Soltan

08:05 AM Feature #8904: implement -catchStop and the integration/conversion of STOP conditions into except...

The only concern is the usage of @isIgnore()@ in @ErrorManager.handleStopException@ - do we really need this?
Othe... Constantin Asofiei

09:31 AM Feature #6506: implement CGI WebSpeed support and the standard web-disp.p dispatch functionality

Radu Apetrii wrote:
> Constantin Asofiei wrote:
> > * @WebNotifyListener.stopListening@ just does @webNotifyThread.... Constantin Asofiei

09:23 AM Feature #6506: implement CGI WebSpeed support and the standard web-disp.p dispatch functionality

Constantin Asofiei wrote:
> * @WebNotifyListener.stopListening@ just does @webNotifyThread.interrupt()@ - you need t... Radu Apetrii

08:58 AM Feature #6506: implement CGI WebSpeed support and the standard web-disp.p dispatch functionality

Review for 6506a rev 15763:
* @WebNotifyListener.stopListening@ just does @webNotifyThread.interrupt()@ - you need t... Constantin Asofiei

08:50 AM Feature #6506 (Review): implement CGI WebSpeed support and the standard web-disp.p dispatch funct...

On 6506a rev. 15763 I did the following:
* Addressed Constantin's review from #6506-103.
** Added code to terminate... Radu Apetrii

06:00 AM Feature #6506: implement CGI WebSpeed support and the standard web-disp.p dispatch functionality

Radu Apetrii wrote:
> And should I also add in @Agent.handleWebspeed@ a call to @WebHandlerHelper.clear()@ right bef... Constantin Asofiei

05:44 AM Feature #6506: implement CGI WebSpeed support and the standard web-disp.p dispatch functionality

And should I also add in @Agent.handleWebspeed@ a call to @WebHandlerHelper.clear()@ right before the return statemen... Radu Apetrii

05:29 AM Feature #6506: implement CGI WebSpeed support and the standard web-disp.p dispatch functionality

Radu Apetrii wrote:
> Constantin Asofiei wrote:
> > and remove @WebspeedRequestHandler@ - I don't see a reason for ... Constantin Asofiei

05:17 AM Feature #6506: implement CGI WebSpeed support and the standard web-disp.p dispatch functionality

Constantin Asofiei wrote:
> and remove @WebspeedRequestHandler@ - I don't see a reason for it.
May I also remove th... Radu Apetrii

09:31 AM Bug #8944: FINALLY block transaction processing

Artur Școlnic wrote:
> The patch from #9803-46 solved the initial problem this task was opened for, considering that... Eduard Soltan

07:57 AM Bug #8944: FINALLY block transaction processing

The patch from #9803-46 solved the initial problem this task was opened for, considering that changes from 4602a will... Artur Școlnic

04:53 AM Bug #8944: FINALLY block transaction processing

I have added a fix for transaction management in 4602a, rev. 15880. Eduard Soltan

02:50 AM Bug #8944: FINALLY block transaction processing

According to note #8944-26 and my observation in FWD.
Transaction is opened in @TM.PushScope@, through @TxWrapper.sc... Eduard Soltan

08:51 AM Feature #6432 (Review): implement the WEB special stream

The changes for web stream are on 6506a rev. 15763. The notes are on #6506-108, under the #6432 category. Also, the s... Radu Apetrii

08:26 AM Bug #9060: Cache oftenly used values that are immutable

OK, lets leave it as this for now.
For 9060b:
* please do @bzr diff -r 15867 --using meld@ and check the copyrigh... Constantin Asofiei

08:21 AM Bug #9060: Cache oftenly used values that are immutable

Returning a mutable instance for all implementations seems to work fine, the testing passed. Artur Școlnic

08:20 AM Bug #9060: Cache oftenly used values that are immutable

Constantin Asofiei wrote:
> * also, I think is part of a larger problem: we have @DataHandler.getField()@, for which... Constantin Asofiei

05:58 AM Bug #9060: Cache oftenly used values that are immutable

Artur, the change in @ControlFlowOps@ and @TargetLob@ are good. But, the @RecordBuffer@ change is not OK:
* you cha... Constantin Asofiei

05:49 AM Bug #9060: Cache oftenly used values that are immutable

I committed the fix for this and other issues to 9060b/15882. Constantin, maybe you can take a look while I continue ... Artur Școlnic

08:25 AM Feature #9488: implement all built-in OO classes using the open source ADE code from 12.8.4

Went thru the commits in *9488a*. Here is a summary:
h2. Fixes for converting legacy oo
- Added support for emi... Ioana-Cristina Prioteasa

05:02 AM Feature #9488: implement all built-in OO classes using the open source ADE code from 12.8.4

Classes that implement @com.goldencode.p2j.oo.core.collections.Icollection@(@OpenEdge.Core.Collections.ICollection@):... Ioana-Cristina Prioteasa

08:03 AM Feature #6161: add support for DYNAMIC-PROPERTY() built-in function and DYNAMIC-PROPERTY language...

Constantin Asofiei wrote:
> Paul, please review the support for @DYNAMIC-PROPERTY@ and what tests exist, and what ne... Paul Bodale

05:46 AM Bug #9877: output extent parameter when the type is object

Committed rev. 15873 on branch 9877a which fixes the issue where the code would convert to the text @${rettype}@.
... Paul Bodale

04/24/2025

03:26 PM Feature #8904 (Review): implement -catchStop and the integration/conversion of STOP conditions in...

Eduard Soltan

03:25 PM Feature #8904 (WIP): implement -catchStop and the integration/conversion of STOP conditions into ...

Committed the handling of StopConditionException through ErrorManager.
Conversion of large GUI app and another cus... Eduard Soltan

02:14 PM Bug #9060: Cache oftenly used values that are immutable

Artur, I understand that, but constant types should be resolved to their actual types. There is a bug somewhere in @... Constantin Asofiei

09:22 AM Bug #9060: Cache oftenly used values that are immutable

... Artur Școlnic

09:09 AM Bug #9060: Cache oftenly used values that are immutable

The point is: the @type@ at that place most likely is a i.e. @integerConstant@ - look further or otherwise debug and ... Constantin Asofiei

09:08 AM Bug #9060: Cache oftenly used values that are immutable

Constantin Asofiei wrote:
> Artur, see @FuzzyMethodRt.resolveSignature@ - @type = arg.getClass().getSimpleName();@ -... Artur Școlnic

08:58 AM Bug #9060: Cache oftenly used values that are immutable

Artur, see @FuzzyMethodRt.resolveSignature@ - @type = arg.getClass().getSimpleName();@ - if arg is a @BaseDataTypeCon... Constantin Asofiei

08:40 AM Bug #9060: Cache oftenly used values that are immutable

With a simple null check, the failing tests are passing. Artur Școlnic

08:39 AM Bug #9060: Cache oftenly used values that are immutable

... Artur Școlnic

08:35 AM Bug #9060: Cache oftenly used values that are immutable

Artur, on a second thought: this is a *runtime* stack - that location should never be reached. Something is wrong in... Constantin Asofiei

08:18 AM Bug #9060: Cache oftenly used values that are immutable

... Artur Școlnic

08:17 AM Bug #9060: Cache oftenly used values that are immutable

Artur Școlnic wrote:
> The call is @fuzzyMethodLookup(methodName, sig, accessMode, isStatic, internal, null);@
Plea... Constantin Asofiei

08:16 AM Bug #9060: Cache oftenly used values that are immutable

The call is @fuzzyMethodLookup(methodName, sig, accessMode, isStatic, internal, null);@
null is passed for the @node... Artur Școlnic

08:12 AM Bug #9060: Cache oftenly used values that are immutable

I don't understand, @fuzzyMethodLookup@ is almost sure called. I see @WARNING: more than one method def found using ... Constantin Asofiei

07:59 AM Bug #9060: Cache oftenly used values that are immutable

In @fuzzyMethodLookup@, the line:... Artur Școlnic

05:43 AM Bug #9060: Cache oftenly used values that are immutable

Also, testing needs to include performance testing, where possible. Constantin Asofiei

05:43 AM Bug #9060: Cache oftenly used values that are immutable

In @TargetLob(FieldReference field)@, @field.get()@ is called twice per call. Please use @bdt@ for the second call. Constantin Asofiei

05:40 AM Bug #9060 (Internal Test): Cache oftenly used values that are immutable

Artur Școlnic

01:10 PM Bug #4766: fix CHR and ASC

Delia Mitric wrote:
> It is possible to be a bug in the Progress version I use? (11.6)
I do not think there is an e... Ovidiu Maxiniuc

07:38 AM Feature #9436: add built-in OO classes

I have a version of these tests that compile and pass both on 12.8 and 11.6.
I attached the zip.
*Marian*, would yo... Ioana-Cristina Prioteasa

07:19 AM Feature #9436: add built-in OO classes

We have customer applications that can only run in 11.x. Those applications will be compared with FWD using the OE 1... Greg Shah

07:10 AM Feature #9436: add built-in OO classes

Greg Shah wrote:
> Yes, 11.x must be supported.
I don't really see the benefits, other than testing PSC code on OE,... Marian Edu

06:17 AM Feature #9436: add built-in OO classes

We have customers that are on 11.x and will never go to 12.x. It is critical that the tests can work across multiple... Greg Shah

05:09 AM Feature #9436: add built-in OO classes

Ioana-Cristina Prioteasa wrote:
> If what is on xfer works on 12.2(i am not sure how I can access that version to te... Marian Edu

04:22 AM Feature #9436: add built-in OO classes

Marian Edu wrote:
> How old? In any case the baseline used for writing tests (ABLUnit style) was OE12.2, ABLUnit cod... Ioana-Cristina Prioteasa

04:17 AM Feature #9436: add built-in OO classes

Ioana-Cristina Prioteasa wrote:
> For integrating the v12 tests I think I need to use the preprocessor. For example ... Marian Edu

04:16 AM Feature #9436: add built-in OO classes

Ioana-Cristina Prioteasa wrote:
> Marian, I am now looking at the tests for @OpenEdge.Core.Collections.ArrayIterator... Marian Edu

04:11 AM Feature #9436: add built-in OO classes

For integrating the v12 tests I think I need to use the preprocessor. For example in @ArrayIteratorStub@ I need to ad... Ioana-Cristina Prioteasa

03:43 AM Feature #9436: add built-in OO classes

Marian, I am now looking at the tests for @OpenEdge.Core.Collections.ArrayIterator@ at @tests/oo/openedge/core/collec... Ioana-Cristina Prioteasa

02:12 AM Bug #9877: output extent parameter when the type is object

Committed rev. 15872 to branch 9877a. This revision fixes a problem found during conversion testing where the code wo... Paul Bodale

04/23/2025

02:15 PM Feature #9488: implement all built-in OO classes using the open source ADE code from 12.8.4

Ioana, please go through all the changes in 9488a and group them by the common 'feature'; so, file x, y, z fix this p... Constantin Asofiei

08:31 AM Feature #9488: implement all built-in OO classes using the open source ADE code from 12.8.4

I did all the necessary modifications and saved the latest converted code at @devsrv01:/home/icp/ADE_latest_converted... Ioana-Cristina Prioteasa

07:40 AM Feature #9488: implement all built-in OO classes using the open source ADE code from 12.8.4

Ioana, I've created #9923 for the @bulkSetValue(new longchar@ problem - for now, please fix this 'by hand' by changin... Constantin Asofiei

06:47 AM Feature #9488: implement all built-in OO classes using the open source ADE code from 12.8.4

Committed in *9488a rev. 15866*: When loading builtin classes, correctly resolve setter and getter names. In @ClassDe... Ioana-Cristina Prioteasa

09:41 AM Bug #9923: extent argument type vs parameter type compatibility

For INPUT case, the solution (if arg and parameter type differs and is extent) would be to emit a @<T extends BaseDat... Constantin Asofiei

08:03 AM Bug #9923: extent argument type vs parameter type compatibility

Paul Bodale wrote:
> Constantin Asofiei wrote:
> > Paul: please let me know if you've already found something simil... Constantin Asofiei

07:59 AM Bug #9923: extent argument type vs parameter type compatibility

Constantin Asofiei wrote:
> Paul: please let me know if you've already found something similar.
Yes, I noticed th... Paul Bodale

07:39 AM Bug #9923: extent argument type vs parameter type compatibility

There is this test which shows that extent arguments can be of different (but compatible) types:... Constantin Asofiei

07:35 AM Bug #9923 (New): extent argument type vs parameter type compatibility

Constantin Asofiei

08:24 AM Feature #6292 (Closed): nested catch blocks

Greg Shah

08:18 AM Feature #6292: nested catch blocks

Greg Shah wrote:
> With 9470a merged to trunk as revision 15867, is this task complete?
Yes, I think so. Eduard Soltan

08:17 AM Feature #6292: nested catch blocks

With 9470a merged to trunk as revision 15867, is this task complete? Greg Shah

08:16 AM Bug #4766: fix CHR and ASC

Delia Mitric wrote:
> Yes, because I'm trying to see how "conversion" from cpinternal to source codepage is made. ... Marian Edu

05:47 AM Bug #4766: fix CHR and ASC

Marian Edu wrote:
> Delia Mitric wrote:
> > * @ASC(chr(14844588), "UTF-16", "UTF-16").@ run with cpinternal = UTF-8... Delia Mitric

05:17 AM Bug #4766: fix CHR and ASC

Delia Mitric wrote:
> * @ASC(chr(14844588), "UTF-16", "UTF-16").@ run with cpinternal = UTF-8 results in: *11305698*... Marian Edu

03:38 AM Bug #4766: fix CHR and ASC

Greg Shah wrote:
> > It is necessary to add files for these cases?
>
> Does OE have a default conversion that the... Delia Mitric

06:26 AM Bug #9060: Cache oftenly used values that are immutable

Constantin Asofiei wrote:
> Does @ this.lob = (LargeObject) field.get().duplicate();@ work, only and only if @field... Artur Școlnic

06:24 AM Bug #9060: Cache oftenly used values that are immutable

Does @ this.lob = (LargeObject) field.get().duplicate();@ work, only and only if @field.get()@ is a @BaseDataTypeCon... Constantin Asofiei

06:20 AM Bug #9060: Cache oftenly used values that are immutable

Artur Școlnic wrote:
> Constantin Asofiei wrote:
> > * in @Stream.readField@, @return res;@ should be used for non-... Constantin Asofiei

06:10 AM Feature #6506: implement CGI WebSpeed support and the standard web-disp.p dispatch functionality

Radu, this is review for 6560a rev 15762:
* in @Agent.startWebspeed@, add a finally block after the catch, to also t... Constantin Asofiei

05:48 AM Bug #9877 (Internal Test): output extent parameter when the type is object

We can to put this into conversion testing, the review for 15861 is OK. Anything else to do for this task? If not, p... Constantin Asofiei

02:53 AM Bug #9877: output extent parameter when the type is object

Constantin Asofiei wrote:
> Paul, just one question: @get_param_ast@ - this is supposed to find a PARAMETER node und... Paul Bodale

02:17 AM Bug #9877: output extent parameter when the type is object

Paul, just one question: @get_param_ast@ - this is supposed to find a PARAMETER node under @LPARENS@ of the method/fu... Constantin Asofiei

05:46 AM Feature #8904: implement -catchStop and the integration/conversion of STOP conditions into except...

Eduard, please double-check @StopConditionException@ throw throughout the project (i.e. @DbUtils.handleException@)
... Constantin Asofiei

05:35 AM Feature #8904: implement -catchStop and the integration/conversion of STOP conditions into except...

Constantin Asofiei wrote:
> Eduard Soltan wrote:
> > Committed on 8904a, rev. 15888.
>
> I assume there was a re... Eduard Soltan

05:11 AM Feature #8904: implement -catchStop and the integration/conversion of STOP conditions into except...

Eduard Soltan wrote:
> Committed on 8904a, rev. 15888.
I assume there was a rebase - please push the branch. Constantin Asofiei

04:00 AM Feature #8904: implement -catchStop and the integration/conversion of STOP conditions into except...

Committed on 8904a, rev. 15888. Eduard Soltan

03:32 AM Feature #8904: implement -catchStop and the integration/conversion of STOP conditions into except...

No, I can't inherit from any of this classes.
It gives the following error, for all subclasses of Progress.Lang.Sto... Eduard Soltan

03:21 AM Feature #8904: implement -catchStop and the integration/conversion of STOP conditions into except...

Constantin Asofiei wrote:
> > > You cannot inherit from this class.
> Please confirm this with a test.
And also t... Constantin Asofiei

03:10 AM Feature #8904: implement -catchStop and the integration/conversion of STOP conditions into except...

Eduard Soltan wrote:
> Constantin Asofiei wrote:
> > Eduard, is it possible to have application-defined @Stop@ sub-... Constantin Asofiei

02:43 AM Feature #8904: implement -catchStop and the integration/conversion of STOP conditions into except...

Constantin Asofiei wrote:
> Eduard, is it possible to have application-defined @Stop@ sub-classes? I think the conve... Eduard Soltan

02:23 AM Feature #8904: implement -catchStop and the integration/conversion of STOP conditions into except...

Eduard, is it possible to have application-defined @Stop@ sub-classes? I think the conversion rules need to check exp... Constantin Asofiei

03:52 AM Feature #6161 (WIP): add support for DYNAMIC-PROPERTY() built-in function and DYNAMIC-PROPERTY la...

Paul, please review the support for @DYNAMIC-PROPERTY@ and what tests exist, and what needs to be added. Constantin Asofiei

04/22/2025

01:54 PM Bug #8944: FINALLY block transaction processing

Constantin Asofiei wrote:
> Eduard, in 4GL there is an implicit FULL transaction created when EXLCUSIVE-LOCK is used... Eduard Soltan

01:48 PM Bug #8944: FINALLY block transaction processing

Eduard, in 4GL there is an implicit FULL transaction created when EXLCUSIVE-LOCK is used or a @CREATE <buffeR>@ is us... Constantin Asofiei

01:00 PM Bug #8944: FINALLY block transaction processing

Greg Shah wrote:
> If the @FINALLY@ is more deeply nested (the full transaction is in a more enclosing block, not in... Eduard Soltan

08:33 AM Bug #8944: FINALLY block transaction processing

If the @FINALLY@ is more deeply nested (the full transaction is in a more enclosing block, not in the immediately con... Greg Shah

07:23 AM Bug #8944: FINALLY block transaction processing

Artur Școlnic wrote:
> Isn't a new transaction for the finally block expected?
I created the a test cases to look... Eduard Soltan

05:22 AM Bug #8944: FINALLY block transaction processing

Isn't a new transaction for the finally block expected? Artur Școlnic

05:16 AM Bug #8944: FINALLY block transaction processing

Artur Școlnic wrote:
> As far as I know, a full transaction is started by a block only if a transaction is not alrea... Eduard Soltan

10:42 AM Feature #9488: implement all built-in OO classes using the open source ADE code from 12.8.4

Committed in *9488a rev. 15865* a possible solution for the naming issue described in #9488-147. It solves all the ca... Ioana-Cristina Prioteasa

09:37 AM Bug #9060: Cache oftenly used values that are immutable

Constantin Asofiei wrote:
> * in @Stream.readField@, @return res;@ should be used for non-constant case (to keep the... Artur Școlnic

09:07 AM Bug #9060: Cache oftenly used values that are immutable

Review of 9060b rev 15860:
* in @Stream.readField@, @return res;@ should be used for non-constant case (to keep the ... Constantin Asofiei

08:37 AM Bug #9877 (Review): output extent parameter when the type is object

Paul Bodale

08:37 AM Bug #9877: output extent parameter when the type is object

I tested with both java 8 and java 17 and in both cases the project compiles and runs.
I committed rev. 15861 with... Paul Bodale

06:50 AM Feature #6490: DYNAMIC-INVOKE which returns an extent

While working on another task, I encountered a problem that applies to the changes I made for DYNAMIC-INVOKE and modi... Paul Bodale

06:25 AM Feature #9436: add built-in OO classes

Committed on *testcases project rev. 1744*: Added tests for @Progress.Collections.List@ and built-in function @HASH-C... Ioana-Cristina Prioteasa

04/17/2025

02:43 PM Bug #9906: Incorrect date parsing in FWD DATE(CHARACTER) implementation

Vladimir Tsichevski wrote:
> After review succeeds, I am going to sort all members of the @date@ class to match th... Vladimir Tsichevski

10:10 AM Bug #9906 (Internal Test): Incorrect date parsing in FWD DATE(CHARACTER) implementation

Code Review Task Branch 9906a Revisions 15863 through 15864
I'm good with the changes. Greg Shah

08:53 AM Bug #9906: Incorrect date parsing in FWD DATE(CHARACTER) implementation

Greg Shah wrote:
> > I simplify error handling by throwing exceptions at various points in the method body (as excep... Vladimir Tsichevski

08:08 AM Bug #9906: Incorrect date parsing in FWD DATE(CHARACTER) implementation

> I simplify error handling by throwing exceptions at various points in the method body (as exceptions are designed f... Greg Shah

10:00 AM Bug #4766: fix CHR and ASC

> It is necessary to add files for these cases?
Does OE have a default conversion that they implement in these cas... Greg Shah

09:57 AM Bug #4766: fix CHR and ASC

Managed to modify build file in order to copy the .dat files into jar and started to work on loading them at runtime.... Delia Mitric

10:00 AM Bug #9877: output extent parameter when the type is object

Constantin Asofiei wrote:
> Also, please test with OO method calls, too.
I wrote a batch of tests and after some ... Paul Bodale

09:50 AM Bug #8944: FINALLY block transaction processing

I will take a look at this one, since there CATCH blocks also need transaction support. And there is a good chances t... Eduard Soltan

09:04 AM Feature #9488: implement all built-in OO classes using the open source ADE code from 12.8.4

This is the list of classes from ADE that implement the @I*Holder@ classes:... Ioana-Cristina Prioteasa

07:02 AM Feature #9488: implement all built-in OO classes using the open source ADE code from 12.8.4

Investigating the issue described in #9488-144. This testcase recreates the issue:... Ioana-Cristina Prioteasa

08:29 AM Feature #6432 (WIP): implement the WEB special stream

So, according to my current notes, I will:
* Create a server-side @GenericOutputStream@ that extends @Stream@.
* In... Radu Apetrii

07:40 AM Feature #6433 (WIP): implement WEB-CONTEXT system handle

As part of the base implementation here, I will:
* Take the CGI vars from @RemoteWebRequest@ and place them in the h... Radu Apetrii

07:25 AM Bug #9060: Cache oftenly used values that are immutable

I addressed the review and fixed a few bugs, I no longer have failing tests in the unit test modules I am using (> 5k... Artur Școlnic

06:16 AM Bug #9060: Cache oftenly used values that are immutable

I can't see an obvious usage in the customer project i am working with. Artur Școlnic

05:46 AM Bug #9060: Cache oftenly used values that are immutable

Artur Școlnic wrote:
> Import statements, but I also saw code like:
I meant the array overload of @readField@ Constantin Asofiei

05:07 AM Bug #9060: Cache oftenly used values that are immutable

Import statements, but I also saw code like:... Artur Școlnic

04:54 AM Bug #9060: Cache oftenly used values that are immutable

Question: please remind me when @readField(BaseDataType[] var)@ is emitted. Constantin Asofiei

04:49 AM Bug #9060: Cache oftenly used values that are immutable

Sounds good. Artur Școlnic

04:48 AM Bug #9060: Cache oftenly used values that are immutable

Artur Școlnic wrote:
> The changes are in 9060b/15859.
Change the code in @readField(BaseDataType)@ so that a new i... Constantin Asofiei

04:45 AM Bug #9060: Cache oftenly used values that are immutable

The changes are in 9060b/15859. Artur Școlnic

04:42 AM Bug #9060: Cache oftenly used values that are immutable

Artur Școlnic wrote:
> In order to make the @Stream.readField@ work with the constant types, I had to change the met... Constantin Asofiei

04:40 AM Bug #9060: Cache oftenly used values that are immutable

In order to make the @Stream.readField@ work with the constant types, I had to change the method implementation so th... Artur Școlnic

05:54 AM Feature #6506: implement CGI WebSpeed support and the standard web-disp.p dispatch functionality

A really quick summary on 6506a rev. 15762:
* Moved the location of the @WebspeedHandler@ to @src/com/goldencode/p2j... Radu Apetrii

03:49 AM Bug #9893: LegacyErrorException is not rethrown in processForBody/processBody

I had a conversation with Eduard, and today I continued his implementation and committed it in @9753a/15850@
Funct... Andrei Plugaru

02:53 AM Bug #9841 (Test): SUPER() and THIS-OBJECT() statements are not part of 'oo_call_type'

Branch 9841a was merged into trunk as rev. 15862 and archived. Paul Bodale

02:34 AM Bug #9841 (Merge Pending): SUPER() and THIS-OBJECT() statements are not part of 'oo_call_type'

Please merge to trunk now. Constantin Asofiei

04/16/2025

05:49 PM Bug #9906: Incorrect date parsing in FWD DATE(CHARACTER) implementation

Greg Shah wrote:
> Code Review Task Branch 9906a Revisions 15860 through 15862
>
> 1. The rework of @parseWorker(... Vladimir Tsichevski

04:47 PM Bug #9906: Incorrect date parsing in FWD DATE(CHARACTER) implementation

Code Review Task Branch 9906a Revisions 15860 through 15862
1. The rework of @parseWorker()@ is so extensive that ... Greg Shah

02:15 PM Bug #9906 (Review): Incorrect date parsing in FWD DATE(CHARACTER) implementation

Issue fixed in 9906a rev. 15862. Now all tests in @TestParse.cls@ do pass. Please, review.
After review succeeds, ... Vladimir Tsichevski

12:06 PM Bug #9906: Incorrect date parsing in FWD DATE(CHARACTER) implementation

#9906-6 and #9906-67 fixed in 9906a rev. 15861. Vladimir Tsichevski

11:57 AM Bug #9906: Incorrect date parsing in FWD DATE(CHARACTER) implementation

Similar problem with @now@, illustrated by the following additional tests:... Vladimir Tsichevski

11:41 AM Bug #9906: Incorrect date parsing in FWD DATE(CHARACTER) implementation

In OE, the @today@ string in date parsing accepts leading and trailing spaces (e.g., @ today @), but in FWD, it only ... Vladimir Tsichevski

11:37 AM Bug #9906: Incorrect date parsing in FWD DATE(CHARACTER) implementation

Attached is a simplified version of the ABLUnit test class for date string parsing, updated to no longer be affected ... Vladimir Tsichevski

10:59 AM Bug #9910: Incorrect Error Handling for ROUTINE-LEVEL ON ERROR UNDO, THROW in FWD ABLUnit Tests

Got you. I think that these tests are pretty similar.... Eduard Soltan

10:15 AM Bug #9910: Incorrect Error Handling for ROUTINE-LEVEL ON ERROR UNDO, THROW in FWD ABLUnit Tests

Eduard Soltan wrote:
> This is the unit test result I get with trunk rev. 15859:
>
> [...]
I apologize for ove... Vladimir Tsichevski

09:16 AM Bug #9910: Incorrect Error Handling for ROUTINE-LEVEL ON ERROR UNDO, THROW in FWD ABLUnit Tests

This is the unit test result I get with trunk rev. 15859:... Eduard Soltan

08:34 AM Bug #9910: Incorrect Error Handling for ROUTINE-LEVEL ON ERROR UNDO, THROW in FWD ABLUnit Tests

Eduard: please check and advise. Constantin Asofiei

08:27 AM Bug #9910: Incorrect Error Handling for ROUTINE-LEVEL ON ERROR UNDO, THROW in FWD ABLUnit Tests

In OE ABLUnit test classes, errors in tests marked with @ROUTINE-LEVEL ON ERROR UNDO, THROW@ are correctly reported a... Vladimir Tsichevski

08:20 AM Bug #9910 (New): Incorrect Error Handling for ROUTINE-LEVEL ON ERROR UNDO, THROW in FWD ABLUnit T...

Vladimir Tsichevski

10:33 AM Bug #9893: LegacyErrorException is not rethrown in processForBody/processBody

Andrei Plugaru wrote:
> The solution is already in @9753a/15849@. Constantin, please review it when you are availabl... Eduard Soltan

09:40 AM Bug #9893: LegacyErrorException is not rethrown in processForBody/processBody

Perhaps a more simple approach with a flag in set in @DeferredLegacyErrorException@ and @LegacyErrorException@, and v... Eduard Soltan

09:38 AM Bug #9893: LegacyErrorException is not rethrown in processForBody/processBody

I know this one, @ValidationError@ error from @batchAssign@ is propagated as a LegacyError, but another @ValidationEr... Eduard Soltan

08:34 AM Bug #9893: LegacyErrorException is not rethrown in processForBody/processBody

Eduard: please check and advise. Constantin Asofiei

09:48 AM Feature #9436: add built-in OO classes

I investigated the new @hash-code()@ function added in Progress 12.
A few points worth noting:
* the formula used i... Ioana-Cristina Prioteasa

05:10 AM Feature #9436: add built-in OO classes

I might be doing something wrong, I am not not running the tests in the testcases project. I convert them separately ... Ioana-Cristina Prioteasa

02:33 AM Feature #9436: add built-in OO classes

Ioana-Cristina Prioteasa wrote:
> Committed to *9436b rev.15854*: completed implementation of @OpenEdge.Core.Collect... Marian Edu

09:30 AM Bug #9877: output extent parameter when the type is object

Constantin Asofiei wrote:
> Paul Bodale wrote:
> > Is the cast to @object[]@ correct? Or should it be @object&lt;? ... Paul Bodale

05:49 AM Bug #9877: output extent parameter when the type is object

Paul Bodale wrote:
> Is the cast to @object[]@ correct? Or should it be @object&lt;? extends ClsA&gt;[]@?
Does it c... Constantin Asofiei

05:42 AM Bug #9877: output extent parameter when the type is object

Committed rev. 15858 on branch 9877a. This version resolves the initial issue but I'm not sure it converts correctly ... Paul Bodale

08:53 AM Bug #4602 (WIP): fixes for OO 4GL and structured error handling

Eduard Soltan

07:32 AM Bug #4602: fixes for OO 4GL and structured error handling

Also there is the following test case which is not handled in fwd:... Eduard Soltan

07:18 AM Bug #4602: fixes for OO 4GL and structured error handling

Committed on 4602a, rev. 15763. Added history entries and java docs. Eduard Soltan

06:18 AM Bug #4602: fixes for OO 4GL and structured error handling

A little break down of the things performed on 4602a:
1) Added support for catch blocks in iteration blocks. Basic... Eduard Soltan

08:35 AM Feature #9488: implement all built-in OO classes using the open source ADE code from 12.8.4

Saved to @devsrv01@ the modified ADE sources, with the def var statement instead of var and generics eliminated: @/ho... Ioana-Cristina Prioteasa

03:59 AM Feature #6490: DYNAMIC-INVOKE which returns an extent

Tests for this task are found in the testcases project (xfer server) following this path:... Paul Bodale

03:21 AM Bug #9841: SUPER() and THIS-OBJECT() statements are not part of 'oo_call_type'

Constantin Asofiei wrote:
> So @rules/convert/literals.rules@ has no changes compared to rev 15840? If so, do a @bzr... Paul Bodale

03:15 AM Bug #9841: SUPER() and THIS-OBJECT() statements are not part of 'oo_call_type'

So @rules/convert/literals.rules@ has no changes compared to rev 15840? If so, do a @bzr revert -r 15840 rules/conver... Constantin Asofiei

04/15/2025

12:36 PM Bug #9906: Incorrect date parsing in FWD DATE(CHARACTER) implementation

h1(#date-parsing-rule-set). Date Parsing Rule Set
h2. Overview
This rule set defines how to interpret a text in... Vladimir Tsichevski

11:41 AM Bug #9906 (WIP): Incorrect date parsing in FWD DATE(CHARACTER) implementation

The FWD implementation of the 4GL @DATE(CHARACTER)@ function is parsing date strings incorrectly. Attached is a 4GL t... Vladimir Tsichevski

11:04 AM Bug #9906 (Closed): Incorrect date parsing in FWD DATE(CHARACTER) implementation

Vladimir Tsichevski

10:18 AM Feature #9436: add built-in OO classes

I don't want to duplicate the test code by version unless the test code itself is drastically different. Greg Shah

10:17 AM Feature #9436: add built-in OO classes

> I am not sure how to handle these:
> 1. in testcases: Should I modify the existent tests? Not sure if that is ok, ... Greg Shah

08:58 AM Feature #9436: add built-in OO classes

Committed to *9436b rev.15854*: completed implementation of @OpenEdge.Core.Collections.ArrayIterator@. This is an exa... Ioana-Cristina Prioteasa

09:13 AM Feature #9488: implement all built-in OO classes using the open source ADE code from 12.8.4

While working on the implementation for @ArrayIterator@, I discovered a conversion issue that appears twice in @OpenE... Ioana-Cristina Prioteasa

08:32 AM Bug #4766: fix CHR and ASC

They must be loaded from our jar file. Since they are static, we will check them in to the FWD project itself and ch... Greg Shah

05:40 AM Bug #4766: fix CHR and ASC

Greg Shah wrote:
> Don't look at the convmap. Just write the generator code in 4GL. We don't care what is in the c... Delia Mitric

07:52 AM Bug #9877: output extent parameter when the type is object

The conversion is done at @convert/output_parameter.rules@ around line 138.
In @annotations/output_parameter.rules... Constantin Asofiei

07:44 AM Bug #9877: output extent parameter when the type is object

Ok so, I tried examples with @integer[]@ and @decimal[]@ but the converted code won't compile. That is because of the... Paul Bodale

04:12 AM Bug #9877: output extent parameter when the type is object

> Quick question, when converting extent variables given as arguments what is the node that is generally taken into a... Constantin Asofiei

03:44 AM Bug #9877: output extent parameter when the type is object

Normally those definitions should be the same or else there would be a compilation error. But it is much more complic... Paul Bodale

03:21 AM Bug #9877: output extent parameter when the type is object

Quick question, when converting extent variables given as arguments what is the node that is generally taken into acc... Paul Bodale

04/14/2025

09:58 AM Bug #9899: calling NEW matches on wrong method

While testing the task #9841 I discovered this case where FWD matches on the wrong constructor.... Paul Bodale

09:37 AM Bug #9899 (New): calling NEW matches on wrong method

Paul Bodale

09:56 AM Feature #9436: add built-in OO classes

Committed to *9436b rev.15853*:
* Completed implementation for @Progress.Collection.List@.
* Added @Progress.Collec... Ioana-Cristina Prioteasa

07:15 AM Feature #9436: add built-in OO classes

https://docs.progress.com/bundle/abl-reference/page/Progress.Collections.ListIterator-ltTgt-class.html
Try to get ... Constantin Asofiei

06:51 AM Feature #9436: add built-in OO classes

But how do I get the list in the iterator? I'll write some unit-tests. Ioana-Cristina Prioteasa

06:39 AM Feature #9436: add built-in OO classes

There must be some internal members which are not exposed. Otherwise, it may be that:
* having list @[a, b, c, d]@
... Constantin Asofiei

06:36 AM Feature #9436: add built-in OO classes

@Progress.Collections.List@ implements @Progress.Collection.IIterable@, with method @getIterator()@, in Progress the ... Ioana-Cristina Prioteasa

09:33 AM Bug #9841: SUPER() and THIS-OBJECT() statements are not part of 'oo_call_type'

Constantin Asofiei wrote:
> Paul, I understand about the @decimal@ and @integer@ c'tors and @int@ literal. But I do... Paul Bodale

09:19 AM Bug #9841: SUPER() and THIS-OBJECT() statements are not part of 'oo_call_type'

Paul, I understand about the @decimal@ and @integer@ c'tors and @int@ literal. But I don't think this is part of the... Constantin Asofiei

08:42 AM Bug #9841: SUPER() and THIS-OBJECT() statements are not part of 'oo_call_type'

We probably should leave behind a @matchType@ annotation at the call site that records @"fuzzy"@ or @"exact"@. Greg Shah

08:33 AM Bug #9841: SUPER() and THIS-OBJECT() statements are not part of 'oo_call_type'

Constantin Asofiei wrote:
> Does parse time resolve the c'tor via @exactMethodLookup@ or @fuzzyMethodLookup@?
Sho... Paul Bodale

08:02 AM Bug #9841: SUPER() and THIS-OBJECT() statements are not part of 'oo_call_type'

Debug @ClassDefinition.lookupMethodWorker@. Constantin Asofiei

08:02 AM Bug #9841: SUPER() and THIS-OBJECT() statements are not part of 'oo_call_type'

Constantin Asofiei wrote:
> Does parse time resolve the c'tor via @exactMethodLookup@ or @fuzzyMethodLookup@?
How... Paul Bodale

07:31 AM Bug #9841: SUPER() and THIS-OBJECT() statements are not part of 'oo_call_type'

Does parse time resolve the c'tor via @exactMethodLookup@ or @fuzzyMethodLookup@? Constantin Asofiei

06:05 AM Bug #9841: SUPER() and THIS-OBJECT() statements are not part of 'oo_call_type'

Made the following changes to @resolveLegacyEntry@ the method:... Paul Bodale

05:07 AM Bug #9841: SUPER() and THIS-OBJECT() statements are not part of 'oo_call_type'

Constantin, following our discussion I made a simple case for testing:... Paul Bodale

08:17 AM Bug #4766: fix CHR and ASC

Greg Shah wrote:
> I'll be interested to know how many map entries are really needed (for the diffs). If the number... Delia Mitric

03:56 AM Feature #9488: implement all built-in OO classes using the open source ADE code from 12.8.4

This is the function:... Ioana-Cristina Prioteasa

04/11/2025

08:56 AM Bug #9893 (Review): LegacyErrorException is not rethrown in processForBody/processBody

The solution is already in @9753a/15849@. Constantin, please review it when you are available. Andrei Plugaru

08:47 AM Bug #9893 (WIP): LegacyErrorException is not rethrown in processForBody/processBody

While investigating another issue, I found this testcase which has the wrong behaviour in FWD:... Andrei Plugaru

08:38 AM Bug #9893 (Internal Test): LegacyErrorException is not rethrown in processForBody/processBody

Andrei Plugaru

08:40 AM Bug #9892: FWD does not support 12731 and 13000 compilation errors.

... Artur Școlnic

08:35 AM Bug #9892 (New): FWD does not support 12731 and 13000 compilation errors.

Artur Școlnic

08:23 AM Feature #9488: implement all built-in OO classes using the open source ADE code from 12.8.4

Ioana-Cristina Prioteasa wrote:
> The problematic line:
> [...]
> Is this a conversion issue?
> For it to compile... Constantin Asofiei

08:14 AM Feature #9488: implement all built-in OO classes using the open source ADE code from 12.8.4

I am working now on implementing @Progress.Collections.List@. We decided to support @List<Object>@ for now and in the... Ioana-Cristina Prioteasa

07:58 AM Bug #9841: SUPER() and THIS-OBJECT() statements are not part of 'oo_call_type'

Paul Bodale wrote:
> Take for example native java int. This could be considered as a DECIMAL or INTEGER. If there ar... Constantin Asofiei

07:55 AM Bug #9841: SUPER() and THIS-OBJECT() statements are not part of 'oo_call_type'

Constantin Asofiei wrote:
> Paul, please try this with your branch:
> [...]
Code converts to this:... Paul Bodale

07:47 AM Bug #9841: SUPER() and THIS-OBJECT() statements are not part of 'oo_call_type'

Do we still need the @wrap_parameter@ change for NEW, after the change from @oo_call_type@ was removed? Because also ... Constantin Asofiei

07:33 AM Bug #9841: SUPER() and THIS-OBJECT() statements are not part of 'oo_call_type'

Paul, please try this with your branch:... Constantin Asofiei

03:45 AM Bug #9841 (Internal Test): SUPER() and THIS-OBJECT() statements are not part of 'oo_call_type'

Constantin Asofiei

07:28 AM Bug #4766: fix CHR and ASC

I'll be interested to know how many map entries are really needed (for the diffs). If the number is small enough, we... Greg Shah

04:17 AM Bug #4766: fix CHR and ASC

I used 4GL code to generate the "code conversion" files between two charsets.
The problem is that I need to change c... Delia Mitric

07:03 AM Bug #4602: fixes for OO 4GL and structured error handling

Committed on UAST testcases project under @uast/error_handling2/4GLTestsGenerator/@ the Java sources used to generate... Eduard Soltan

06:13 AM Bug #4602: fixes for OO 4GL and structured error handling

Greg Shah wrote:
> > 1) @undo, retry@ statment in repetive blocks like @repeat_to@, @repeat_to_while@, @do_to@, @do_... Eduard Soltan

06:44 AM Bug #9877: output extent parameter when the type is object

Constantin Asofiei wrote:
> OK, well, your signature at the function definitions matches the argument's. define the ... Paul Bodale

03:54 AM Feature #8904: implement -catchStop and the integration/conversion of STOP conditions into except...

Review for 8904a rev 15865.
* dependent on the 9470a changes, so 9470a will go first after testing is finished
* @S... Constantin Asofiei

01:54 AM Feature #8904: implement -catchStop and the integration/conversion of STOP conditions into except...

Conversion and runtime testing for CHUI and CTRL-C tests went successfully. ✅
GUI application conversion and unit te... Eduard Soltan

04/10/2025

11:00 AM Bug #4602: fixes for OO 4GL and structured error handling

Eduard Soltan wrote:
> Committed the testcases to old testcases project under @uast/error_handling2@.
Please also c... Constantin Asofiei

10:51 AM Bug #4602: fixes for OO 4GL and structured error handling

> 1) @undo, retry@ statment in repetive blocks like @repeat_to@, @repeat_to_while@, @do_to@, @do_to_while@, @for_loop... Greg Shah

07:55 AM Bug #4602: fixes for OO 4GL and structured error handling

Committed the testcases to old testcases project under @uast/error_handling2@. Eduard Soltan

09:44 AM Bug #9060: Cache oftenly used values that are immutable

Rebased 9060b on trunk rev 15849. Artur Școlnic

07:57 AM Bug #9877: output extent parameter when the type is object

OK, well, your signature at the function definitions matches the argument's. define the argument @obj@ as @progress.l... Constantin Asofiei

07:53 AM Bug #9877: output extent parameter when the type is object

Constantin Asofiei wrote:
> Are you compiling with Java 8 or Java 17?
Java 17. ... Paul Bodale

07:45 AM Bug #9877: output extent parameter when the type is object

Are you compiling with Java 8 or Java 17? Constantin Asofiei

07:00 AM Bug #9877 (WIP): output extent parameter when the type is object

I tried to play around with this but I wasn't able to find a case where this would not compile.
The basic example I ... Paul Bodale

05:45 AM Feature #8904: implement -catchStop and the integration/conversion of STOP conditions into except...

I have committed on the 8904a. Fix for review issues and a fix for a issues that encountered in the conversion of tes... Eduard Soltan

04:53 AM Bug #9841: SUPER() and THIS-OBJECT() statements are not part of 'oo_call_type'

Commited rev. 15848 on branch 9841a. This revision solves the following issue:
> in some cases the class of the ar... Paul Bodale

04:14 AM Bug #9841: SUPER() and THIS-OBJECT() statements are not part of 'oo_call_type'

Constantin, I've encountered some problems after the last commit but it might've been because of the problems I had w... Paul Bodale

02:38 AM Feature #9488: implement all built-in OO classes using the open source ADE code from 12.8.4

@ADE_converted_sources.zip@ is available at @devsrv01:/home/icp/ADE_converted_sources.zip@. Ioana-Cristina Prioteasa

04/09/2025

11:53 AM Feature #3853: implement LOG-MANAGER runtime

Status update from Galya regarding the changes that merged to trunk with #8661:
> The LegacyLogManagerImpl is boos... Greg Shah

11:50 AM Feature #6417: cleanup some known items in appserver support

Status summary by Galya:
> I think some of the issues in the appserver are resolved in recent revisions, but what'... Greg Shah

10:02 AM Feature #9488: implement all built-in OO classes using the open source ADE code from 12.8.4

Committed to *9488a rev. 15864*: Relaxed restriction in wrapper detection rule to allow built-in OO method calls to b... Ioana-Cristina Prioteasa

08:30 AM Feature #9488: implement all built-in OO classes using the open source ADE code from 12.8.4

I am trying now to eliminate @ArrayIterator@ from the ADE conversion list, I have the new skeleton version (that cont... Ioana-Cristina Prioteasa

05:56 AM Feature #9488: implement all built-in OO classes using the open source ADE code from 12.8.4

Ioana-Cristina Prioteasa wrote:
> May these be related to 9488 rev. 15860?
See 9488a rev 15863, this solves the con... Constantin Asofiei

05:10 AM Feature #9488: implement all built-in OO classes using the open source ADE code from 12.8.4

I did some tests regarding MIN MAX:... Ioana-Cristina Prioteasa

03:25 AM Feature #9488: implement all built-in OO classes using the open source ADE code from 12.8.4

There is one more issue. In @ObjectStack@, the call to the @Stack@ constructor with parameter has the wrong name:
<p... Ioana-Cristina Prioteasa

09:57 AM Feature #9436: add built-in OO classes

Besides the new constructor @ArrayIterator@ is now implementing @IListIterator@. This is the diff of the skeletons:
... Ioana-Cristina Prioteasa

09:43 AM Feature #9436: add built-in OO classes

Committed to *9436b*:
* *rev. 15826*: Corrected support level for @IprimitiveArrayHolder@, @IlongcharArrayHolder@, @... Ioana-Cristina Prioteasa

07:09 AM Feature #9436: add built-in OO classes

Thanks, for now work on the ADE dependencies for @Progress@ package. Constantin Asofiei

07:06 AM Feature #9436: add built-in OO classes

This is the latest list of what is needed from the @Progress@ package:
h3. STUB
* @./skeleton/oo4gl/Progress/... Ioana-Cristina Prioteasa

09:42 AM Bug #4766: fix CHR and ASC

Delia Mitric wrote:
> Delia Mitric wrote:
>
> > The main difference is that if a character *c* from *cp1* doesn't... Greg Shah

08:59 AM Bug #4766: fix CHR and ASC

Don't look at the convmap. Just write the generator code in 4GL. We don't care what is in the convmap because we ar... Greg Shah

08:26 AM Bug #4766: fix CHR and ASC

Delia Mitric wrote:
> The main difference is that if a character *c* from *cp1* doesn't exists in *cp2*, in OE it ... Delia Mitric

08:05 AM Bug #4766: fix CHR and ASC

Ovidiu Maxiniuc wrote:
> +For the resource files:+
> I do not think there are many multibyte CPs. And at 16 bit, ... Delia Mitric

07:55 AM Bug #9841: SUPER() and THIS-OBJECT() statements are not part of 'oo_call_type'

Commited rev. 15846 to branch 9841a.
As we've discussed, this revision reverts the changes made to the @oo_call_t... Paul Bodale

03:24 AM Bug #9841: SUPER() and THIS-OBJECT() statements are not part of 'oo_call_type'

Paul Bodale wrote:
> Should I insert 2 entries one for modifications related to this task and one for modifications ... Constantin Asofiei

02:43 AM Bug #9841: SUPER() and THIS-OBJECT() statements are not part of 'oo_call_type'

Commited rev. 15845 to branch 9841a with the following changes.
Constantin Asofiei wrote:
> * @oo_references.rule... Paul Bodale

07:09 AM Feature #8904: implement -catchStop and the integration/conversion of STOP conditions into except...

Also, please update the @LegacyResourceSupport@ annotation for the @LockConflict@ and other classes related to @oo.l... Constantin Asofiei

06:58 AM Feature #8904: implement -catchStop and the integration/conversion of STOP conditions into except...

Review for 8904a rev 15863:
* @control_flow.rules@
** @executeLib@ should be @execLib@
* @Persistence.java@
** ne... Constantin Asofiei

06:40 AM Feature #8904: implement -catchStop and the integration/conversion of STOP conditions into except...

Fixed review issues and rebased to latest trunk. Eduard Soltan

03:23 AM Bug #4602: fixes for OO 4GL and structured error handling

Eduard, for now please commit the tests (the ones I sent and what you wrote) to old testcases project, @testcases/uas... Constantin Asofiei

04/08/2025

10:55 AM Bug #9841: SUPER() and THIS-OBJECT() statements are not part of 'oo_call_type'

Review of 9841a rev 15844:
* @oo_references.rules@ - you are calling @wrap_argument@ while on the argument, and @wra... Constantin Asofiei

10:47 AM Bug #9841: SUPER() and THIS-OBJECT() statements are not part of 'oo_call_type'

Paul Bodale wrote:
> in some cases the class of the argument that dictates the method signature is found to be @com.... Constantin Asofiei

10:37 AM Bug #9841: SUPER() and THIS-OBJECT() statements are not part of 'oo_call_type'

Constantin Asofiei wrote:
> OK, so this is about NEW function, and looks like we must wrap the literals with the par... Paul Bodale

07:44 AM Bug #9841: SUPER() and THIS-OBJECT() statements are not part of 'oo_call_type'

Constantin Asofiei wrote:
> What I need for now is the SUPER and THIS-OBJECT statements for constructor calls to wor... Paul Bodale

06:11 AM Bug #9841: SUPER() and THIS-OBJECT() statements are not part of 'oo_call_type'

OK, so this is about NEW function, and looks like we must wrap the literals with the parameter types for the expected... Constantin Asofiei

06:08 AM Bug #9841: SUPER() and THIS-OBJECT() statements are not part of 'oo_call_type'

> it's most probably the one I described here #9841-20 (last part)
Confirmed.
This is not a problem regarding co... Paul Bodale

05:31 AM Bug #9841: SUPER() and THIS-OBJECT() statements are not part of 'oo_call_type'

Regarding the problem with the double constructors that we discussed about I discovered that it came from the fact th... Paul Bodale

09:24 AM Feature #9488: implement all built-in OO classes using the open source ADE code from 12.8.4

What I mentioned about MIN/MAX was related to a @CASE i * 1@, where @multiply@ returns int64 while the expression is ... Constantin Asofiei

08:06 AM Feature #9488: implement all built-in OO classes using the open source ADE code from 12.8.4

The @parent.type@ check was not needed, it was included in the parent rule. I committed this solution to *9488a rev.1... Ioana-Cristina Prioteasa

07:46 AM Feature #9488: implement all built-in OO classes using the open source ADE code from 12.8.4

I think the issue with @new unknown()@ is in @/rules/convert/literals.rules@:... Ioana-Cristina Prioteasa

05:47 AM Feature #9488: implement all built-in OO classes using the open source ADE code from 12.8.4

Compilation Errors
1. Generics need to be added by hand in
* @LegacyInteger@: we need @implements Icomparable<Iin... Ioana-Cristina Prioteasa

05:13 AM Feature #9488: implement all built-in OO classes using the open source ADE code from 12.8.4

Please ignore the @./skeleton/oo4gl/OEUnit/Data/FixtureDataSet.cls@ and @./skeleton/oo4gl/OEUnit/Util/List.cls@.
Constantin Asofiei

05:05 AM Feature #9488: implement all built-in OO classes using the open source ADE code from 12.8.4

This is the latest list of what is needed from the @OpenEdge@, @Ccs@ and @OEUnit@ packages:
h3. Already implemente... Ioana-Cristina Prioteasa

09:09 AM Feature #8904: implement -catchStop and the integration/conversion of STOP conditions into except...

Constantin Asofiei wrote:
> Review for 8904a rev 15846:
> * @Queue.java@
> ** this *must not* be aware of the exce... Eduard Soltan

06:51 AM Feature #8904: implement -catchStop and the integration/conversion of STOP conditions into except...

please look for all @progress STOP@ and change to @legacy STOP@. Constantin Asofiei

06:47 AM Feature #8904: implement -catchStop and the integration/conversion of STOP conditions into except...

Review for 8904a rev 15846:
* @control_flow.rules@
** please create a function for the @.equals("Stop") etc@ condi... Constantin Asofiei

08:54 AM Bug #4766: fix CHR and ASC

Delia Mitric wrote:
> One thing to note is that *UTF-16 / -16LE / -16BE* and *UTF-32 / -32LE / -32BE* present weird ... Ovidiu Maxiniuc

08:21 AM Bug #4766: fix CHR and ASC

> I'm not suggesting to use the conversion files from OE, the documentation for the syntax of those files is not exte... Greg Shah

08:18 AM Bug #4766: fix CHR and ASC

Greg Shah wrote:
> But for the built-in/standard conversions, I don't want to read the convmap files directly so t... Marian Edu

08:10 AM Bug #4766: fix CHR and ASC

> > We can provide these conversion tables are resources inside the jar, we only need to write a class that initializ... Greg Shah

08:02 AM Bug #4766: fix CHR and ASC

> > We can provide these conversion tables are resources inside the jar, we only need to write a class that initializ... Greg Shah

06:44 AM Bug #4766: fix CHR and ASC

Delia Mitric wrote:
> One thing to note is that *UTF-16 / -16LE / -16BE* and *UTF-32 / -32LE / -32BE* present weird ... Marian Edu

06:40 AM Bug #4766: fix CHR and ASC

Ovidiu Maxiniuc wrote:
> We can provide these conversion tables are resources inside the jar, we only need to write ... Marian Edu

04:40 AM Bug #4766: fix CHR and ASC

One thing to note is that *UTF-16 / -16LE / -16BE* and *UTF-32 / -32LE / -32BE* present weird behavior.
As I've noti... Delia Mitric

02:57 AM Bug #4766: fix CHR and ASC

Ovidiu Maxiniuc wrote:
> We can provide these conversion tables are resources inside the jar, we only need to write ... Delia Mitric

04:59 AM Bug #9060: Cache oftenly used values that are immutable

Also, please rebase. Constantin Asofiei

04:57 AM Bug #9060: Cache oftenly used values that are immutable

Review of 9060b rev 15771:
* @FieldReference@
** is missing history entry
** do we need to do the same for @blobCo... Constantin Asofiei

04:29 AM Bug #4602: fixes for OO 4GL and structured error handling

Managed to find and solve (hopefully) the problem input-output parameter updates in the caller with different flow-of... Eduard Soltan

03:43 AM Feature #9435 (Closed): class-level virtual procedure/function definitions

Constantin Asofiei

04/07/2025

10:19 AM Bug #4766: fix CHR and ASC

We can provide these conversion tables are resources inside the jar, we only need to write a class that initializes f... Ovidiu Maxiniuc

07:58 AM Bug #4766: fix CHR and ASC

> Do you think it is necessary to add also these huge convmaps in FWD?
Unfortunately, yes. Greg Shah

03:26 AM Bug #4766: fix CHR and ASC

Delia Mitric wrote:
> I'm working on adding the convmaps from OE and for now I added just the convmaps for combinati... Marian Edu

03:05 AM Bug #4766: fix CHR and ASC

I'm working on adding the convmaps from OE and for now I added just the convmaps for combinations of codepages cp1-cp... Delia Mitric

09:52 AM Feature #9488: implement all built-in OO classes using the open source ADE code from 12.8.4

I committed in *9488a rev.15861*:
* Added @SymbolResolver.getLegacyPackageName@ method that extracts the legacy pack... Ioana-Cristina Prioteasa

08:58 AM Bug #4602: fixes for OO 4GL and structured error handling

Marian Edu wrote:
>
> Eduard, not sure what is the difference here - I assume in FWD the variables are updated (al... Eduard Soltan

03:44 AM Bug #4602: fixes for OO 4GL and structured error handling

Eduard Soltan wrote:
> The problem that I am facing right now. I have some tests with control-of-flow statement and ... Marian Edu

01:53 AM Bug #4602: fixes for OO 4GL and structured error handling

The problem that I am facing right now. I have some tests with control-of-flow statement and error throwings directly... Eduard Soltan

01:20 AM Bug #4602: fixes for OO 4GL and structured error handling

I have generated a test suite with errors or control-of-flow condition being thrown in different blocks (do, repeat, ... Eduard Soltan

04:23 AM Bug #9877: output extent parameter when the type is object

There is this example which uses a different 4GL object type at the argument and the parameter:... Constantin Asofiei

04:11 AM Bug #9877 (Test): output extent parameter when the type is object

Constantin Asofiei

02:54 AM Bug #9841: SUPER() and THIS-OBJECT() statements are not part of 'oo_call_type'

After our discussion I was looking into the problem with the double constructor wrapping of the literal, and I found ... Paul Bodale

04/04/2025

09:04 AM Feature #9488: implement all built-in OO classes using the open source ADE code from 12.8.4

Something like this would solve the issue:... Ioana-Cristina Prioteasa

08:56 AM Feature #9488: implement all built-in OO classes using the open source ADE code from 12.8.4

I was wrong in my last post. This is the original 4GL code for the second @annotateMethodCall@ issue:... Ioana-Cristina Prioteasa

08:06 AM Feature #9488: implement all built-in OO classes using the open source ADE code from 12.8.4

The issue in @OpenEdge.Core.Collections.List@:
@annotateMethodCall@ failed because there was no method match. This h... Ioana-Cristina Prioteasa

06:22 AM Bug #9841: SUPER() and THIS-OBJECT() statements are not part of 'oo_call_type'

It just occurred to me, this means that the problem is not with SUPER or THIS-OBJECT but with how the constructor in ... Paul Bodale

06:17 AM Bug #9841: SUPER() and THIS-OBJECT() statements are not part of 'oo_call_type'

I debugged a failing test and started with NEW Paul Bodale

06:10 AM Bug #9841: SUPER() and THIS-OBJECT() statements are not part of 'oo_call_type'

Paul Bodale wrote:
> # I then did a small change (inserted a space) to the file in which the child class is declared... Constantin Asofiei

06:02 AM Bug #9841: SUPER() and THIS-OBJECT() statements are not part of 'oo_call_type'

Constantin Asofiei wrote:
> Please make a simple test where you have:
> * the super-class defining a 'decimal' cons... Paul Bodale

04:55 AM Bug #9841: SUPER() and THIS-OBJECT() statements are not part of 'oo_call_type'

Please make a simple test where you have:
* the super-class defining a 'decimal' constructor
* the sub-class callin... Constantin Asofiei

04:03 AM Bug #9841: SUPER() and THIS-OBJECT() statements are not part of 'oo_call_type'

Constantin Asofiei wrote:
> Paul Bodale wrote:
> > * @SUPER(123)@
> > * @SUPER(-123)@
> > The constructors for th... Paul Bodale

03:24 AM Bug #9841: SUPER() and THIS-OBJECT() statements are not part of 'oo_call_type'

Paul Bodale wrote:
> * @SUPER(123)@
> * @SUPER(-123)@
> The constructors for the integer literals are generated co... Constantin Asofiei

03:19 AM Bug #9841: SUPER() and THIS-OBJECT() statements are not part of 'oo_call_type'

I modified the rule to add checks for the THIS-OBJECT and SUPER methods and committed a solution to branch 9841a revi... Paul Bodale

06:08 AM Bug #9060: Cache oftenly used values that are immutable

OK, then please create a task in the database project for this. The code may be used just for importing the .d data ... Constantin Asofiei

05:59 AM Bug #9060: Cache oftenly used values that are immutable

Well, @PropertyMapper@ uses it:... Artur Școlnic

05:50 AM Bug #9060: Cache oftenly used values that are immutable

Dănuț Filimon wrote:
> Artur Școlnic wrote:
> > I see that Eric and Ovidiu worked on @ImportWorker.initialize@, can... Constantin Asofiei

05:49 AM Bug #9060: Cache oftenly used values that are immutable

Artur Școlnic wrote:
> I see that Eric and Ovidiu worked on @ImportWorker.initialize@, can someone please explain wh... Dănuț Filimon

05:43 AM Bug #9060: Cache oftenly used values that are immutable

I see that Eric and Ovidiu worked on @ImportWorker.initialize@, can someone please explain where should it be called,... Artur Școlnic

05:30 AM Bug #9060: Cache oftenly used values that are immutable

So I think @PropertyMapper.preprocessClob/Blob@ is necessary because it assigns to @var@ the actual data of the lob, ... Artur Școlnic

05:06 AM Bug #9060: Cache oftenly used values that are immutable

I did the tests, with 9060b, both export and import is broken, with trunk, export is ok, but the import is broken. I ... Artur Școlnic

04/03/2025

10:12 AM Bug #9841: SUPER() and THIS-OBJECT() statements are not part of 'oo_call_type'

Constantin Asofiei wrote:
> Is having the rule like this work?
I checked again with trunk revision 15840 ( + rule... Paul Bodale

09:13 AM Bug #9841: SUPER() and THIS-OBJECT() statements are not part of 'oo_call_type'

Constantin Asofiei wrote:
> Is having the rule like this work?
> [...]
>
> I don't understand the need to remove... Paul Bodale

08:53 AM Bug #9841: SUPER() and THIS-OBJECT() statements are not part of 'oo_call_type'

Is having the rule like this work?... Constantin Asofiei

08:45 AM Bug #9841: SUPER() and THIS-OBJECT() statements are not part of 'oo_call_type'

@SUPER (cResult, 123).@ :... Paul Bodale

08:41 AM Bug #9841: SUPER() and THIS-OBJECT() statements are not part of 'oo_call_type'

Please post the AST for the SUPER and the @voidMthd@ call. Constantin Asofiei

08:40 AM Bug #9841: SUPER() and THIS-OBJECT() statements are not part of 'oo_call_type'

Constantin Asofiei wrote:
> Or otherwise find why the literal at SUPER/THIS-OBJECT doesn't have 'wrap' annotation.
... Paul Bodale

07:34 AM Bug #9841: SUPER() and THIS-OBJECT() statements are not part of 'oo_call_type'

Or otherwise find why the literal at SUPER/THIS-OBJECT doesn't have 'wrap' annotation. Constantin Asofiei

07:34 AM Bug #9841: SUPER() and THIS-OBJECT() statements are not part of 'oo_call_type'

I would enhance @copy.parent.isAnnotation("wrap")@ to check that the parent is SUPER or THIS-OBJECT (use the @type_pa... Constantin Asofiei

07:30 AM Bug #9841 (Review): SUPER() and THIS-OBJECT() statements are not part of 'oo_call_type'

Constantin Asofiei wrote:
> Please look also into what @force_no_wrap@ means.
The annotation is used to avoid wra... Paul Bodale

03:53 AM Bug #9841: SUPER() and THIS-OBJECT() statements are not part of 'oo_call_type'

Constantin Asofiei wrote:
> find when @evalLib("oo_call_type", parent, this)@ was added.
It was added in trunk re... Paul Bodale

07:35 AM Feature #9488: implement all built-in OO classes using the open source ADE code from 12.8.4

Ioana-Cristina Prioteasa wrote:
> What I could find in /CCcs/Common/Support and is not in FWD:
Please add these to ... Constantin Asofiei

07:13 AM Feature #9488: implement all built-in OO classes using the open source ADE code from 12.8.4

We have implemented in FWD:
* IcharacterHolder.java
* IdecimalHolder.java
* Iint64Holder.java
* Il... Ioana-Cristina Prioteasa

07:01 AM Feature #9488: implement all built-in OO classes using the open source ADE code from 12.8.4

Also, for the CCS and other 'holder' classes - are these fully implemented in FWD? Constantin Asofiei

07:00 AM Feature #9488: implement all built-in OO classes using the open source ADE code from 12.8.4

For LegacyInteger, for now make the change by hand.
For LegacyList, these are related to generics (I think) - see th... Constantin Asofiei

06:59 AM Feature #9488: implement all built-in OO classes using the open source ADE code from 12.8.4

This is the support for these in p2j:
- @OpenEdge.Core.Collection.List@ (p2j.oo.core.collections.LegacyList) - STUBS... Ioana-Cristina Prioteasa

05:40 AM Feature #9488: implement all built-in OO classes using the open source ADE code from 12.8.4

Why are you converting String.cls? This is already implemented. Please post the only the .cls files which have no i... Constantin Asofiei

05:22 AM Feature #9488: implement all built-in OO classes using the open source ADE code from 12.8.4

Rebased 9488a and tested again the conversion for only these files (needed from ADE and not existent in p2j with full... Ioana-Cristina Prioteasa

04:17 AM Feature #9488: implement all built-in OO classes using the open source ADE code from 12.8.4

I've added my changes to 9488a rev 15736. Sorry, they are not fully tested/complete. Please check with your test no... Constantin Asofiei

04:03 AM Feature #9488: implement all built-in OO classes using the open source ADE code from 12.8.4

Minimized the testcase where the setter of a property is not correctly emitted and ends up as @n/a@.
For this:
<pre... Ioana-Cristina Prioteasa

04/02/2025

01:58 PM Feature #9488: implement all built-in OO classes using the open source ADE code from 12.8.4

Constantin Asofiei wrote:
> Greg Shah wrote:
> > So, I'd like to know if we need it in the short term or not. If n... Greg Shah

01:03 PM Feature #9488: implement all built-in OO classes using the open source ADE code from 12.8.4

Greg Shah wrote:
> So, I'd like to know if we need it in the short term or not. If not, then we should defer it.
T... Constantin Asofiei

12:48 PM Feature #9488: implement all built-in OO classes using the open source ADE code from 12.8.4

> Greg: considering that the #9457 project doesn't use generics in the app code, I want to find a way to delay this i... Greg Shah

09:59 AM Feature #9488: implement all built-in OO classes using the open source ADE code from 12.8.4

Found missing skeletons needed on #9488 or #9436 and I committed then to the bzr skeleton project, rev. 125:
* Progr... Ioana-Cristina Prioteasa

09:45 AM Feature #9488: implement all built-in OO classes using the open source ADE code from 12.8.4

The initial idea was to convert everything we need from ADE and later choose of we keep the current implementation(ex... Ioana-Cristina Prioteasa

06:02 AM Feature #9488: implement all built-in OO classes using the open source ADE code from 12.8.4

Created issue #9868 for the discussion about generics. I will try to gather some examples of generics usage and add t... Ioana-Cristina Prioteasa

04:48 AM Feature #9488: implement all built-in OO classes using the open source ADE code from 12.8.4

I think the problem with the @ObjectOps.newInstance@ missing the parameter type mode is that the target method or con... Constantin Asofiei

01:28 PM Feature #9868: Support generics introduced in Progress 12.x

I'm guessing that there is no syntax in the built-in classes which shows how to define a parameterized type (e.g. @T@... Greg Shah

01:23 PM Feature #9868: Support generics introduced in Progress 12.x

For convenience, I'm reproducing my post from #9488-131:
> Greg: considering that the #9457 project doesn't use ge... Greg Shah

07:36 AM Feature #9868: Support generics introduced in Progress 12.x

Progress 12.x introduced built-in classes that use generics, such as @Progress.Collections.HashMap@ and @Progress.Col... Ioana-Cristina Prioteasa

05:52 AM Feature #9868 (New): Support generics introduced in Progress 12.x

Ioana-Cristina Prioteasa

10:55 AM Bug #9841: SUPER() and THIS-OBJECT() statements are not part of 'oo_call_type'

Please look also into what @force_no_wrap@ means. And find -where- when @evalLib("oo_call_type", parent, this)@ was ... Constantin Asofiei

10:54 AM Bug #9841: SUPER() and THIS-OBJECT() statements are not part of 'oo_call_type'

Looks like the problem is coming from the rule at the line 381 in convert/literals.rules. ... Paul Bodale

08:54 AM Bug #9841 (WIP): SUPER() and THIS-OBJECT() statements are not part of 'oo_call_type'

I accidentally created a branch 9841 while trying to create a branch for this task. I don't know how to delete it or ... Paul Bodale

04/01/2025

07:46 AM Bug #9819 (WIP): SESSION:FIRST-ASYNC-REQUEST and SESSION:LAST-ASYNC-REQUEST

Placing back in WIP, the runtime for these SESSION attributes needs to be implemented. Constantin Asofiei

07:45 AM Bug #9819 (Closed): SESSION:FIRST-ASYNC-REQUEST and SESSION:LAST-ASYNC-REQUEST

Constantin Asofiei

03:24 AM Bug #9819: SESSION:FIRST-ASYNC-REQUEST and SESSION:LAST-ASYNC-REQUEST

9819a was merged to trunk rev. 15831 and archived. Eduard Soltan

03:04 AM Bug #9819: SESSION:FIRST-ASYNC-REQUEST and SESSION:LAST-ASYNC-REQUEST

Actually 9773a is in trunk, please merge now. Constantin Asofiei

03:03 AM Bug #9819 (Merge Pending): SESSION:FIRST-ASYNC-REQUEST and SESSION:LAST-ASYNC-REQUEST

Please merge after 9773a. Constantin Asofiei

03/31/2025

08:08 AM Feature #3853: implement LOG-MANAGER runtime

I've noticed the @persist@ package excessively uses methods in @ErrorManager@ that don't create legacy logs. After 86... Galya B

07:45 AM Feature #3853: implement LOG-MANAGER runtime

8661b covers @ASPlumbing@ on level @1@ and @2@ in the new PASOE implementation. Galya B

05:11 AM Feature #6490: DYNAMIC-INVOKE which returns an extent

h2. Status as of March 31
---
- All tests except assigning to buffers are passing conversion and compilation ... Paul Bodale

03/30/2025

04:16 AM Bug #9819: SESSION:FIRST-ASYNC-REQUEST and SESSION:LAST-ASYNC-REQUEST

I had a problem with my workstation and had to redo the conversion. I performed the conversion with 9818a of a large ... Eduard Soltan