FWD » Core Development » Database

01/14/2023

09:56 PM Feature #6813: analyze and improve performance of dynamic conversion of temp-tables and queries

Ovidiu Maxiniuc wrote:
> Eric Faulhaber wrote:
> > That should make the replacement TRPL code simpler and more comp... Ovidiu Maxiniuc

08:37 PM Feature #6813: analyze and improve performance of dynamic conversion of temp-tables and queries

Greg Shah wrote:
> I understand. Even though it is possibly not much improvement, it still must be something small ... Ovidiu Maxiniuc

01/13/2023

06:26 PM Feature #6371: implement SAVE CACHE statement

I pushed minor updates to the table validation procedure - new rule plus the table name shows up in the error window.... Boris Schegolev

11:56 AM Feature #6371: implement SAVE CACHE statement

Eric Faulhaber wrote:
> Eric Faulhaber wrote:
> On second thought, this might not be what you were seeing. This was... Boris Schegolev

03:53 AM Feature #6371: implement SAVE CACHE statement

Eric Faulhaber wrote:
> Boris, with rev 14450, I get this in an infinite loop when I run @save-cache3.p@:
>
> [..... Eric Faulhaber

02:48 AM Feature #6371: implement SAVE CACHE statement

Boris, with rev 14450, I get this in an infinite loop when I run @save-cache3.p@:... Eric Faulhaber

04:51 PM Feature #7037: remove dirty share manager

I'm done for today, but for the case you're in a hurry, I've attached option 1: @NopDirtyShareContext@ as well as opt... Stanislav Lomany

03:44 PM Feature #7037: remove dirty share manager

> Please create a @NopDirtyShareContext@ by extending @DirtyShareContext@ and write each method as an empty implement... Stanislav Lomany

02:15 PM Feature #7037 (WIP): remove dirty share manager

Stanislav Lomany

11:43 AM Feature #7037: remove dirty share manager

Greg Shah wrote:
> Please create a @NopDirtyShareContext@ by extending @DirtyShareContext@ and write each method as ... Eric Faulhaber

10:18 AM Feature #7037: remove dirty share manager

FYI, the following are the existing (known) use cases for the dirty share database.
# FIND query cross-session mod... Greg Shah

10:07 AM Feature #7037: remove dirty share manager

Optimally this should be configurable in the directory so that we can turn it on or off without code changes. Greg Shah

10:06 AM Feature #7037: remove dirty share manager

Please create a @NopDirtyShareContext@ by extending @DirtyShareContext@ and write each method as an empty implementat... Greg Shah

03:27 AM Feature #7037: remove dirty share manager

Greg Shah wrote:
> How easy is it to separate the portions only used for the cross-session behavior (which is about ... Eric Faulhaber

02:49 AM Feature #7037: remove dirty share manager

How easy is it to separate the portions only used for the cross-session behavior (which is about the 4GL transaction ... Greg Shah

10:36 AM Feature #6813: analyze and improve performance of dynamic conversion of temp-tables and queries

Greg Shah wrote:
> > They must be grouped in a block / single_block / stmt_list to benefit from natural processing d... Ovidiu Maxiniuc

03:11 AM Feature #6813: analyze and improve performance of dynamic conversion of temp-tables and queries

Greg Shah wrote:
> > I think there are other source of improvements in TRPL. One I can guess now are usages of @down... Eric Faulhaber

03:02 AM Feature #6813: analyze and improve performance of dynamic conversion of temp-tables and queries

> I think there are other source of improvements in TRPL. One I can guess now are usages of @downPath@ and @upPath@ w... Greg Shah

03:01 AM Feature #6813: analyze and improve performance of dynamic conversion of temp-tables and queries

> They must be grouped in a block / single_block / stmt_list to benefit from natural processing downstream. I debugge... Greg Shah

12:06 AM Feature #6813: analyze and improve performance of dynamic conversion of temp-tables and queries

I tried to create a new @dynamic_query@ entry point for parser. There are 3-4 statements which need to be supported:
... Ovidiu Maxiniuc

06:25 AM Feature #6816: improve PreselectQuery.assembleHQL

I've attached a patch in which I've done some refactoring to the @SortCriterion@ constructor. Mainly, instead of call... Radu Apetrii

01/12/2023

02:30 PM Feature #7037: remove dirty share manager

The dirty share manager originally was added to solve a problem with a particular use case in one customer's applicat... Eric Faulhaber

01:53 PM Feature #7037 (Test): remove dirty share manager

Eric Faulhaber

10:54 AM Feature #6444: dataset improvements

Added fix for H2 bug with bind parameters in recursive CTEs.
Now the test works fine both temp tables and permanent ... Igor Skornyakov

01:51 AM Feature #6444: dataset improvements

> It returns nothing. Moreover, as I mentioned the problem is gone if the query has no parameters.
> It is known tha... Igor Skornyakov

01:43 AM Feature #6444: dataset improvements

Ovidiu Maxiniuc wrote:
> Executing @.next()@ will cause the result to advance. You lose the object of interest. You ... Igor Skornyakov

09:33 AM Support #6714: check if there is an optimization opportunity when copying temp-tables based on mu...

Some concerns on moving the source records to the destination table just by updating the multiplex ID to the destinat... Constantin Asofiei

08:14 AM Feature #6813: analyze and improve performance of dynamic conversion of temp-tables and queries

Nice! Let's see what we can get back by implementing a new parser rule (@dynamic_query@) which is designed to do the... Greg Shah

12:17 AM Feature #6813: analyze and improve performance of dynamic conversion of temp-tables and queries

I added timers for the setup of @SymbolResolver@, @SchemaDictionary@ and other tasks needed for the @query-prepare@ a... Ovidiu Maxiniuc

03:07 AM Bug #7035 (WIP): Extract query parameters from statically converted FQL

The following is a testcase in which FWD hard-codes the arguments into the FQL:... Alexandru Lungu

02:52 AM Bug #7035 (Closed): Extract query parameters from statically converted FQL

Alexandru Lungu

01/11/2023

03:22 PM Feature #6444: dataset improvements

Igor Skornyakov wrote:
> I've tested with permanent H2 tables.
> If I stop with the debugger in the @SQLQuery.scrol... Ovidiu Maxiniuc

02:16 PM Feature #6444: dataset improvements

Igor Skornyakov wrote:
> In addition to #6444-86.
> If I set a breakpoint at the last statement of the @FqlToSqlCon... Igor Skornyakov

11:29 AM Feature #6444: dataset improvements

In addition to #6444-86.
If I set a breakpoint at the last statement of the @FqlToSqlConverter.toSQL()@ (@return sql... Igor Skornyakov

10:47 AM Feature #6444: dataset improvements

Ovidiu Maxiniuc wrote:
> To test these queries during in real application using the data currently in temp-tables, y... Igor Skornyakov

06:23 AM Support #6714: check if there is an optimization opportunity when copying temp-tables based on mu...

There already is a JMX for @OutputTableCopier@ with the same name and it measures the execution time and call count o... Dănuț Filimon

04:35 AM Support #6714: check if there is an optimization opportunity when copying temp-tables based on mu...

Danut, can you add a counter JMX for your modification? I think we can benefit from finding out how many times this s... Alexandru Lungu

04:04 AM Feature #6371: implement SAVE CACHE statement

Simply skipping surrogate primary key column seems to break index handling, rules are failing during AST validation. ... Boris Schegolev

01/10/2023

06:43 PM Feature #6813: analyze and improve performance of dynamic conversion of temp-tables and queries

> Looking at the time results from #6813-18 it looks to me that the main slow-performance problem lies in the convers... Greg Shah

04:46 PM Feature #6813: analyze and improve performance of dynamic conversion of temp-tables and queries

Looking at the time results from #6813-18 it looks to me that the main slow-performance problem lies in the conversio... Ovidiu Maxiniuc

09:18 AM Support #6714: check if there is an optimization opportunity when copying temp-tables based on mu...

I've made a comparison between *3821c/rev.14467* and the patched version from #6714-5 using different *patched versio... Dănuț Filimon

09:01 AM Feature #6444: dataset improvements

I'm not sure how the @EDITOR:EMPTY@ attribute was included here. We will move that work to #7032. Greg Shah

07:01 AM Feature #6825: improve table meta runtime (TableMapper and other)

The changes for #6825-4 are in 6129b/14347 Constantin Asofiei

06:40 AM Feature #6830 (Review): find and fix all SQL SELECT statements with inlined literal arguments, an...

Radu Apetrii

05:01 AM Feature #6830: find and fix all SQL SELECT statements with inlined literal arguments, and rewrite...

Constantin Asofiei wrote:
> Radu, the changes are OK with 6129b and a customer app (performance is improved). Pleas... Radu Apetrii

04:15 AM Feature #6371: implement SAVE CACHE statement

Also, please review the data type checking in the PostgreSQL dialect again, and apply the methodology I described in ... Eric Faulhaber

04:12 AM Feature #6371: implement SAVE CACHE statement

Revision 14449 fixes the table name and legacy table name when creating the schema AST. Only the DMO interface name s... Eric Faulhaber

01/09/2023

06:11 PM Feature #6371: implement SAVE CACHE statement

In the end the solution is pretty simple - see revision 14448. Boris Schegolev

12:42 PM Feature #6830: find and fix all SQL SELECT statements with inlined literal arguments, and rewrite...

Radu, the changes are OK with 6129b and a customer app (performance is improved). Please commit the 6830-6129b.patch... Constantin Asofiei

06:36 AM Feature #6830: find and fix all SQL SELECT statements with inlined literal arguments, and rewrite...

Here you go, the patch ported to 6129b, rev. 14344.
I tested some little examples to see that nothing breaks, but n... Radu Apetrii

03:23 AM Feature #6830: find and fix all SQL SELECT statements with inlined literal arguments, and rewrite...

Radu Apetrii wrote:
> Constantin Asofiei wrote:
> > Radu, what is the state of this task? Was anything committed to... Constantin Asofiei

02:36 AM Feature #6830: find and fix all SQL SELECT statements with inlined literal arguments, and rewrite...

Constantin Asofiei wrote:
> Radu, what is the state of this task? Was anything committed to 3821c?
No, I did not co... Radu Apetrii

08:39 AM Feature #7020: always use "expanded" extent fields

> * added a new @denormalized@ attribute in @@Property@ annotation
Please name this @expanded@ because the "denorm... Greg Shah

06:31 AM Feature #6444: dataset improvements

Here is my understanding of the current task status
h3. DATA-RELATION:RECURSIVE attribute
* The FILL method s... Igor Skornyakov

01/07/2023

10:20 PM Feature #7020: always use "expanded" extent fields

Greg Shah wrote:
> The Open Client proxy generation is the replacement of the OpenEdge "proxygen" tool which creates... Ovidiu Maxiniuc

10:19 PM Feature #7020 (WIP): always use "expanded" extent fields

Status update.
My work ATM include:
* re-enabled denormalisation for temp-tables. I do not use this except for havi... Ovidiu Maxiniuc

08:32 PM Feature #6813: analyze and improve performance of dynamic conversion of temp-tables and queries

After previous note I changes the testcase a bit: I changed the second from the end line: @message "Run " + string(k)... Ovidiu Maxiniuc

07:10 PM Feature #6813 (WIP): analyze and improve performance of dynamic conversion of temp-tables and que...

I used the following 4GL program in order to replicate Constantin's testcase for static/dynamic queries:... Ovidiu Maxiniuc

01/06/2023

04:45 PM Feature #6371: implement SAVE CACHE statement

Yes, I met this problem a few times. I will make the change you suggest. It will not be that straightforward because ... Boris Schegolev

12:30 PM Feature #6371: implement SAVE CACHE statement

Upon a validation failure, the failing table needs to be removed from the last known @DatabaseState@. Otherwise, if a... Eric Faulhaber

06:56 AM Feature #6371: implement SAVE CACHE statement

Eric Faulhaber wrote:
> So, please implement a unique interface naming scheme, similar to what we have in @DynamicTa... Boris Schegolev

04:46 AM Feature #6371: implement SAVE CACHE statement

I committed 6371/14445, which fixes the raising of an error condition for a schema validation failure. Now @save-cach... Eric Faulhaber

02:48 PM Feature #6830: find and fix all SQL SELECT statements with inlined literal arguments, and rewrite...

Radu, what is the state of this task? Was anything committed to 3821c? Constantin Asofiei

09:51 AM Feature #6444: dataset improvements

Committed the current state of the RECURSIVE DATA-RELATION support to 6444a/14473. Igor Skornyakov

03:55 AM Feature #6444: dataset improvements

Created task branch 6444a from the trunk Igor Skornyakov

08:17 AM Feature #6995: possibly support NO-UNDO temporary tables directly in H2

If we are doing any substantial work implementing NO-UNDO in the customer scenario, then let's move ahead. Greg Shah

05:09 AM Feature #6995: possibly support NO-UNDO temporary tables directly in H2

Eric Faulhaber wrote:
> > Furthermore, I just added @OrmNoUndoTrace@ in 3821c/rev. 14470. This is used to analyze th... Alexandru Lungu

02:29 AM Feature #6995: possibly support NO-UNDO temporary tables directly in H2

Constantin Asofiei wrote:
> Eric Faulhaber wrote:
> > Constantin, do you see measurable @SQLRedo@ and/or @Savepoint... Eric Faulhaber

02:17 AM Feature #6995: possibly support NO-UNDO temporary tables directly in H2

Eric Faulhaber wrote:
> Constantin, do you see measurable @SQLRedo@ and/or @SavepointManager@ activity in your profi... Constantin Asofiei

02:02 AM Feature #6995: possibly support NO-UNDO temporary tables directly in H2

Alexandru Lungu wrote:
> I tested with a large customer application (~10 mins POC) and I got only 7 redo operation... Eric Faulhaber

01:38 AM Feature #6995: possibly support NO-UNDO temporary tables directly in H2

Constantin, do you see measurable @SQLRedo@ and/or @SavepointManager@ activity in your profiling of the large applica... Eric Faulhaber

03:33 AM Feature #6448 (Closed): make location of LOB files configurable for import

Thank you. Eric Faulhaber

03:25 AM Feature #6448 (Feedback): make location of LOB files configurable for import

Eric Faulhaber wrote:
> Igor, if you've already tested this, the only thing that remains is to update the [[p2j:Data... Igor Skornyakov

02:44 AM Feature #6448: make location of LOB files configurable for import

Igor, if you've already tested this, the only thing that remains is to update the [[p2j:Data_Migration#Data-Import|do... Eric Faulhaber

03:00 AM Feature #6928: H2 UPDATE performance improvement

Is there anything left to do, in order for FWD to use the new H2 jar by default? Is the FWD build updated? Is the jar... Eric Faulhaber

02:51 AM Support #6709: track nested FIND inside a related FOR loop

I've changed the way tracking is done based on #6709-33. The only change I've done to @TransactionManager@ is to retr... Dănuț Filimon

02:28 AM Feature #6454: database informational features

Eric Faulhaber wrote:
> The changes in @dbrestrictions.diff@ look good. Please commit it to 6129b. 6129b/14335 also ... Igor Skornyakov

12:37 AM Feature #6454: database informational features

Igor Skornyakov wrote:
> Eric Faulhaber wrote:
> > Igor, other than requiring review for the patch in #6454-11 and ... Eric Faulhaber

01/05/2023

03:05 PM Feature #6816: improve PreselectQuery.assembleHQL

Constantin Asofiei wrote:
> Eric, I was assuming that the SortCriterion is being used at the FQL level, before the F... Eric Faulhaber

02:52 PM Feature #6816: improve PreselectQuery.assembleHQL

Constantin Asofiei wrote:
> Alexandru Lungu wrote:
> > Is the profiling done with multiple users? The cache is glob... Eric Faulhaber

02:25 PM Feature #6816: improve PreselectQuery.assembleHQL

Eric, I was assuming that the SortCriterion is being used at the FQL level, before the FQL translation (dependent on ... Constantin Asofiei

02:20 PM Feature #6816: improve PreselectQuery.assembleHQL

Constantin Asofiei wrote:
> Also, the cache Key doesn't need the dialect - the DmoMeta already is distinct for tem... Eric Faulhaber

11:06 AM Feature #6816: improve PreselectQuery.assembleHQL

I've increased the cache limit to something big (2048000) and now for 100 runs the average is only a little less wors... Constantin Asofiei

10:06 AM Feature #6816: improve PreselectQuery.assembleHQL

Alexandru Lungu wrote:
> Is the profiling done with multiple users? The cache is global across all users, so it is a... Constantin Asofiei

09:15 AM Feature #6816: improve PreselectQuery.assembleHQL

Is the profiling done with multiple users? The cache is global across all users, so it is a synchronized data structu... Alexandru Lungu

07:59 AM Feature #6816: improve PreselectQuery.assembleHQL

I have a mod count for the @LRUCache.cache@ map (used by @SortCrtierionFactory@) of 11k for just 10 runs of the perfo... Constantin Asofiei

07:45 AM Feature #6816: improve PreselectQuery.assembleHQL

Unfortunately the patch shows a slowdown in the performance testing. I'm not sure from where it is. I wonder if is ... Constantin Asofiei

06:26 AM Feature #6816: improve PreselectQuery.assembleHQL

Sure, here you go. I've updated the file so the command @patch@ now works on 6129b. Radu Apetrii

02:20 PM Feature #6825: improve table meta runtime (TableMapper and other)

Totally agree! Ovidiu Maxiniuc

02:02 PM Feature #6825: improve table meta runtime (TableMapper and other)

The @MutableFieldInfo@ is being kept in @TableMapper$TempTableMapper.fieldInfo@ by the @TempTable@ instance. So I se... Constantin Asofiei

12:59 PM Feature #7020: always use "expanded" extent fields

> AFAIK, the Open Client proxy generation rules are general purpose, not specific to @<customer>@. Constantin, can y... Greg Shah

12:58 PM Feature #7020: always use "expanded" extent fields

From Eric:
I think you have understood it exactly right.
> If we get rid of the custom name (I am not sure but ... Greg Shah

12:56 PM Feature #7020: always use "expanded" extent fields

From Ovidiu:
I read this email several times in order to get the things right. I understand that the denormalizati... Greg Shah

12:55 PM Feature #7020: always use "expanded" extent fields

From Eric:
While you should read the whole history there, I can summarize as follows:
* We think there will be ... Greg Shah

12:52 PM Feature #7020 (Test): always use "expanded" extent fields

Greg Shah

02:25 AM Feature #6371: implement SAVE CACHE statement

Boris Schegolev wrote:
> I disabled DMO unloading in @SchemaCheck@, although I don't fully understand reasoning behi... Eric Faulhaber

01/04/2023

06:38 PM Feature #6371: implement SAVE CACHE statement

I disabled DMO unloading in @SchemaCheck@, although I don't fully understand reasoning behind it.
Also, I reworked... Boris Schegolev

03:56 PM Feature #6444: dataset improvements

Ovidiu Maxiniuc wrote:
> You said _"The same query executed against the same H2 database with H2 Console with the sa... Igor Skornyakov

03:38 PM Feature #6444: dataset improvements

You said _"The same query executed against the same H2 database with H2 Console with the same JDBC driver (fwd-h2-1.4... Ovidiu Maxiniuc

03:00 PM Feature #6444: dataset improvements

Ovidiu Maxiniuc wrote:
> Igor Skornyakov wrote:
> > I have a strange situation.
> > In fact, it is the same for al... Igor Skornyakov

02:35 PM Feature #6444: dataset improvements

Igor Skornyakov wrote:
> I have a strange situation.
> In fact, it is the same for all 3 dialects. For temp tables,... Ovidiu Maxiniuc

10:19 AM Feature #6444: dataset improvements

I have a strange situation.
The second pass query provides a correct result set for PostgreSQL and MariaDB, but retu... Igor Skornyakov

11:30 AM Feature #6816: improve PreselectQuery.assembleHQL

Radu, can you port this patch to 6129b? I'd like to test the impact on a customer's application. Constantin Asofiei

05:28 AM Bug #6829: H2 forces re-parse of all prepared statements when metadata is changed

Alexandru, I think a first pass would be to change the FQL generation to use @c1@, @c2@, etc as aliases instead of th... Constantin Asofiei

05:14 AM Feature #6995 (WIP): possibly support NO-UNDO temporary tables directly in H2

I've added a @OrmRedo@ Timer JMX in 3821c/rev. 14469. I've debugged some local tests to find out a "pattern" scenario... Alexandru Lungu

01/03/2023

02:35 PM Feature #6371: implement SAVE CACHE statement

The changes to support the DMO interface/class unloading and re-use at the proxy level are turning into something mor... Eric Faulhaber

02:27 PM Feature #6371: implement SAVE CACHE statement

Greg Shah wrote:
> Let's assume that only the denormalized extents will be supported for now. It doesn't make sense... Eric Faulhaber

09:47 PM Feature #6371: implement SAVE CACHE statement

Let's assume that only the denormalized extents will be supported for now. It doesn't make sense to add the more com... Greg Shah

11:33 AM Feature #6444: dataset improvements

Igor Skornyakov wrote:
> I've changed my test so that data sources used for FILL get data from the permanent tables.... Igor Skornyakov

11:09 AM Feature #6444: dataset improvements

I've changed my test so that data sources used for FILL get data from the permanent tables.
However, at runtime, I s... Igor Skornyakov

07:08 AM Bug #6829: H2 forces re-parse of all prepared statements when metadata is changed

Constantin Asofiei wrote:
> Alexandru, I have in a heap dump @UnclosablePreparedStatement@ instances with ~90KB reta... Alexandru Lungu

03:48 AM Feature #6720 (WIP): lazy hydration

Eric Faulhaber

01/02/2023

05:34 PM Feature #6371: implement SAVE CACHE statement

Boris Schegolev wrote:
> > If there are any other critical configuration values that cannot be determined by defau... Eric Faulhaber

12/31/2022

03:29 AM Feature #6444: dataset improvements

Eric Faulhaber wrote:
> If I understand the issue correctly, I respectfully disagree. In the event there is no expli... Igor Skornyakov

02:56 AM Feature #6444: dataset improvements

Greg Shah wrote:
> > Greg, please correct me if I am overly aggressive on this.
>
> If the application code can b... Eric Faulhaber

02:17 AM Feature #6444: dataset improvements

Greg Shah wrote:
> In this case, I suspect we should implement the application-visible behavior.
I see. In this c... Igor Skornyakov

02:15 AM Feature #6444: dataset improvements

Ovidiu Maxiniuc wrote:
> I understand that, ultimately, the content of the databases (ABL and FWD) are identically a... Igor Skornyakov

12/30/2022

06:11 PM Feature #6371: implement SAVE CACHE statement

I added an implementation for SchemaValidator + unit test for it. See revision 14442. Boris Schegolev

11:00 AM Feature #6371: implement SAVE CACHE statement

> Do we have an example of the table structure where such 2-field DTTZ storage is used? First column is DATETIME and ... Greg Shah

05:07 PM Feature #6444: dataset improvements

> Greg, please correct me if I am overly aggressive on this.
If the application code can be implemented to rely up... Greg Shah

03:19 PM Feature #6444: dataset improvements

Well, the _binary_ might not have been the best attribute here to describe the compatibility.
I understand that, u... Ovidiu Maxiniuc

02:35 PM Feature #6444: dataset improvements

Ovidiu Maxiniuc wrote:
> I understand that. Can we isolate this damage to recursive relations only? These cases are ... Igor Skornyakov

02:11 PM Feature #6444: dataset improvements

Igor Skornyakov wrote:
>
> > > Should we care about the order in which records are added to the target tables dur... Ovidiu Maxiniuc

01:59 PM Feature #6444: dataset improvements

Ovidiu Maxiniuc wrote:
> > I understand that refactoring from using a 'plain' query string (@hql@) to a query string... Igor Skornyakov

01:34 PM Feature #6444: dataset improvements

Igor Skornyakov wrote:
> I understand that refactoring from using a 'plain' query string (@hql@) to a query string h... Ovidiu Maxiniuc

12/29/2022

03:23 PM Feature #6371: implement SAVE CACHE statement

I pushed an update for error handling and other minor changes - rev. 14441.
Greg Shah wrote:
> We have 2 customer... Boris Schegolev

12:14 AM Feature #6371: implement SAVE CACHE statement

Boris Schegolev wrote:
> Also, for the primary key: I guess we need to add a validation before registering a new tab... Eric Faulhaber

07:57 PM Feature #6371: implement SAVE CACHE statement

>> 2 What is the issue with timezoned types (timestamp with time zone)?
>
> We need to support them ultimately, but... Greg Shah

12/28/2022

04:47 PM Feature #6371: implement SAVE CACHE statement

Also, for the primary key: I guess we need to add a validation before registering a new table to check that the table... Boris Schegolev

04:41 PM Feature #6371: implement SAVE CACHE statement

Eric Faulhaber wrote:
> Before you changed it to "TODO: Surrogate Primary Key", the note for 8-byte integer read, "T... Boris Schegolev

02:09 PM Feature #6371: implement SAVE CACHE statement

Boris Schegolev wrote:
> I updated the documentation / WIKI page. A few questions here:
>
> 1 What's the TODO for... Eric Faulhaber

01:59 PM Feature #6444: dataset improvements

> If this blocks you from making headway on the recursive FILL operation, please work on another item that needs atte... Igor Skornyakov

01:51 PM Feature #6444: dataset improvements

Eric Faulhaber wrote:
> I think we should wait for Ovidiu's input when he returns before undertaking any massive cha... Igor Skornyakov

01:43 PM Feature #6444: dataset improvements

Eric Faulhaber wrote:
> Igor Skornyakov wrote:
> > [...]
> > I understand that refactoring from using a 'plain' qu... Eric Faulhaber

01:40 PM Feature #6444: dataset improvements

Igor Skornyakov wrote:
> [...]
> I understand that refactoring from using a 'plain' query string (@hql@) to a query... Eric Faulhaber

01:38 PM Feature #6444: dataset improvements

Eric Faulhaber wrote:
> I don't know what the intent of this variable was, maybe something that is only changed for ... Igor Skornyakov

01:37 PM Feature #6444: dataset improvements

Igor Skornyakov wrote:
> At this moment it looks that @FqlToSqlConverter.generateUniqueSqlColumnNames@ is always @tr... Eric Faulhaber

05:30 AM Feature #6444: dataset improvements

At this moment it looks that @FqlToSqlConverter.generateUniqueSqlColumnNames@ is always @true@.
Can I rely on this?
... Igor Skornyakov

02:56 AM Feature #6444: dataset improvements

Working on the second pass query for the recursive data-relation FILL support I have to deal with the situation when ... Igor Skornyakov

12/27/2022

05:28 PM Feature #6371: implement SAVE CACHE statement

I updated the documentation / WIKI page. A few questions here:
# What's the TODO for Surrogate Primary Key about?
... Boris Schegolev

12/25/2022

04:20 AM Feature #6444: dataset improvements

Igor Skornyakov wrote:
> I think that we also can avoid it if the DATA-SOURCE QUERY uses a single table but at this ... Igor Skornyakov

12/23/2022

11:15 AM Feature #6371: implement SAVE CACHE statement

Eric Faulhaber wrote:
> That seems like a great idea, as long as column-level comments are supported in @create tabl... Boris Schegolev

09:45 AM Feature #6371: implement SAVE CACHE statement

> As for branching, in git I would rebase 6371a onto 6129b. Not sure how to do that in Bazaar and don't want to break... Greg Shah

01:32 AM Feature #6371: implement SAVE CACHE statement

Boris Schegolev wrote:
> I am implementing one-to-many SQL->4GL type mappings. I would only suggest to use column's ... Eric Faulhaber

09:43 AM Feature #6444: dataset improvements

In the relation model, the physical order or the records in the table is irrelevant and the order of records in the r... Igor Skornyakov

12/22/2022

05:09 PM Feature #6371: implement SAVE CACHE statement

I am implementing one-to-many SQL->4GL type mappings. I would only suggest to use column's comment property for 4GL t... Boris Schegolev

04:26 AM Feature #6371: implement SAVE CACHE statement

Boris, please work on the validation of the mutable database requirements described in the [[p2j:Non-Standard_Save_Ca... Eric Faulhaber

09:51 AM Support #6709: track nested FIND inside a related FOR loop

Eric: Please review and advise. Greg Shah

09:49 AM Support #6709: track nested FIND inside a related FOR loop

Code Review 6709-20221222.diff
The conversion changes seem reasonable.
Do we really need to implement this as p... Greg Shah

08:40 AM Support #6709: track nested FIND inside a related FOR loop

I will try to patch a customer application I have on my development environment to test the changes. If everything is... Alexandru Lungu

07:02 AM Support #6709: track nested FIND inside a related FOR loop

I managed to convert Hotel GUI and a few smaller tests and use FieldReference. I actually didn't make use of @convert... Dănuț Filimon

09:50 AM Support #7004 (New): eliminate the off-end processing in the TransactionManager and minimize the ...

Greg Shah

12/21/2022

11:30 AM Feature #6371: implement SAVE CACHE statement

I pushed a cleanup for PostgreSQL dialect - there were MySQL types mixed in. Boris Schegolev

02:11 AM Feature #6371: implement SAVE CACHE statement

Revision 6371a/14438 works around the @SchemaDictionary@ issue described in #6371-80, but the workaround is limited, ... Eric Faulhaber

12/20/2022

05:42 AM Support #6709: track nested FIND inside a related FOR loop

Committed 3821c/rev.14460. Added nested find annotation and report. Any annotated @FIND@ that is nested in a @FOR EAC... Dănuț Filimon

12/19/2022

06:09 PM Support #6709: track nested FIND inside a related FOR loop

Yes. Greg Shah

03:41 AM Support #6709: track nested FIND inside a related FOR loop

Greg Shah wrote:
> You've tested conversion for both the large customer application and also Hotel GUI?
Yes, both... Dănuț Filimon

01:32 PM Bug #6834: RAQ navigation on records having NULL values on same index components

The issue is described with details and example in #6755. I will copy it here because that task contains sensitive da... Ovidiu Maxiniuc

10:28 AM Feature #6444: dataset improvements

Ovidiu Maxiniuc wrote:
> I am not very happy with this double iteration. It implies a performance penalty. Ultimatel... Igor Skornyakov

10:12 AM Feature #6444: dataset improvements

Igor Skornyakov wrote:
> I need to iterate over a DATA-SOURCE twice - first with the original QUERY and then with th... Ovidiu Maxiniuc

12/16/2022

02:59 PM Feature #6444: dataset improvements

Something is wrong in the @BufferImpl.fill()@ logic regarding child relations. In the @data_relation/recursive_relati... Igor Skornyakov

03:48 AM Feature #6444: dataset improvements

I need to iterate over a DATA-SOURCE twice - first with the original QUERY and then with the 'relaxed' one. What is t... Igor Skornyakov

10:59 AM Support #6709: track nested FIND inside a related FOR loop

I'm OK with the @6709-20221216.patch@.
You've tested conversion for both the large customer application and also H... Greg Shah

09:53 AM Support #6709: track nested FIND inside a related FOR loop

Greg Shah wrote:
> Please post an updated patch for review.
> We emit the getter or the @FieldReference@ in @conv... Dănuț Filimon

08:30 AM Support #6709: track nested FIND inside a related FOR loop

> The bug is fixed and the conversion was successful. Should I commit the changes?
Please post an updated patch fo... Greg Shah

03:31 AM Support #6709: track nested FIND inside a related FOR loop

Greg Shah wrote:
> Danut, please address the bug and make sure to test conversion with that application.
The bug is... Dănuț Filimon

08:06 AM Support #6714: check if there is an optimization opportunity when copying temp-tables based on mu...

I've made a mistake and used the wrong patch when testing previously. The second @removeRecords@ call didn't execute ... Dănuț Filimon

12/15/2022

02:11 PM Bug #6997: OUTPUT BY-REFERENCE records are not cleared

I returned to this testcase. I altered the original code a bit and I found more evidences in favour of confirming the... Ovidiu Maxiniuc

08:36 AM Feature #6816: improve PreselectQuery.assembleHQL

Another update: after the last post I started working on a Factory design pattern for @SortCriterion@. This patch inc... Radu Apetrii