Activity

From 08/16/2023 to 09/14/2023

09/14/2023

08:09 AM Feature #7416: Reiterate DatabaseStatistics and leverage to other database profling tools: Sorry, my bad. Alexandru Lungu
05:36 AM Bug #7797: FWD-H2 LAZY reverse index regression: Radu Apetrii wrote:
> This might turn out to be more messy than I hoped. I was right saying that the changes are the... Alexandru Lungu
05:19 AM Bug #7797: FWD-H2 LAZY reverse index regression: This might turn out to be more messy than I hoped. I was right saying that the changes are there, but it's a bit more... Radu Apetrii
03:30 AM Bug #7797: FWD-H2 LAZY reverse index regression: I don't have an example yet.
Attempt to make something like @FOR EACH tt BY tt.f1 DESC@, while you have an @ASC@ i... Alexandru Lungu
03:10 AM Bug #7797: FWD-H2 LAZY reverse index regression: I'm on it. I think I already have the changes necessary, but they need to be added to 7066c_h2 (which I will create v... Radu Apetrii

09/13/2023

11:55 AM Bug #7641: Lower the number of Map.get() calls in the persistence layer: Alexandru Lungu wrote:
> As this doesn't provide consistent improvements in this state, I am pending this for furthe... Constantin Asofiei
10:22 AM Bug #7641: Lower the number of Map.get() calls in the persistence layer: Done some improvements and committed 7641a / rev. 14721. I didn't expect to have that many (new) instances of @Static... Alexandru Lungu
10:47 AM Feature #7066: Implement multi-table indexed query in H2: > No, but it was quite straight-forward to solve that test. I committed to 7066b_h2, rev. 28.
Great news.
Merge... Alexandru Lungu
05:26 AM Feature #7066: Implement multi-table indexed query in H2: Alexandru Lungu wrote:
> I am OK with the changes. The regression tests are ok. Does this also solve #7776?
No, but... Radu Apetrii
04:46 AM Feature #7066: Implement multi-table indexed query in H2: I am OK with the changes. The regression tests are ok. Does this also solve #7776?
Radu, *please extend your regress... Alexandru Lungu
04:30 AM Feature #7066: Implement multi-table indexed query in H2: Done. I committed to *7066b_h2, rev. 27* changes that target the behavior of @lazy@ when using @previous()@. I tried ... Radu Apetrii
02:59 AM Feature #7066: Implement multi-table indexed query in H2: Greg Shah wrote:
> Since 7066a_h2 is needed to fix a bug (regression?) that causes #7666 (and several other related ... Radu Apetrii
10:45 AM Bug #7797: FWD-H2 LAZY reverse index regression: ... Alexandru Lungu
10:37 AM Bug #7797 (Closed): FWD-H2 LAZY reverse index regression: Alexandru Lungu
09:43 AM Bug #7793: incremental conversion with deleted table from .df: Ovidiu Maxiniuc wrote:
> I have only one unknown thing: at runtime, how do we decide which is the timestamp which ma... Constantin Asofiei
09:37 AM Bug #7793: incremental conversion with deleted table from .df: I think of the following solution:
* add a conversion timestamp to DMOs (as an annotation). This might be useful for... Ovidiu Maxiniuc
08:22 AM Bug #7793: incremental conversion with deleted table from .df: The current solutions for a customer were:
* delete all artifacts for this table manually (from src/, build/, other ... Constantin Asofiei
07:42 AM Bug #7793: incremental conversion with deleted table from .df: We don't support incremental conversion when the schema changes. This is expected to fail. Greg Shah
11:57 PM Bug #7793: incremental conversion with deleted table from .df: Ovidiu, the scenario is this:
* full conversion uses table Book with dump-name 'paper'.
* incremental conversion re... Constantin Asofiei
05:30 AM Bug #7776: Previous regression on FWD-H2 lazy mode: Alexandru Lungu wrote:
> If that is the case, note that @beforeLast@ can be reset back to @false@ if we ever do @nex... Radu Apetrii
04:59 AM Bug #7535: Temporary tables require trailing recid component even for unique indexes: Merged 7535a_h2/rev.27 into FWD-H2 trunk as rev. 27 and archived. Alexandru Lungu

09/12/2023

07:25 PM Bug #7788: NPE when assigning query to browse: Let me put my thoughts. Is it a browse issue? Yes and no.
First, if you try this code:... Stanislav Lomany
11:10 AM Bug #7788: NPE when assigning query to browse: > Maybe they were tested individually and the actual operator is || instead of &&?
This was exactly what I thought... Alexandru Lungu
10:32 AM Bug #7788: NPE when assigning query to browse: Alexandru Lungu wrote:
> There are two issues here:
> * The browse is not dynamic, so @_dynamic@ returns @false@. I... Ovidiu Maxiniuc
08:18 AM Bug #7788: NPE when assigning query to browse: That part is not quite relevant for the test-case. The following is also problematic:... Alexandru Lungu
07:26 AM Bug #7788: NPE when assigning query to browse: Nice catch!
It seems like the query from @new-query-handle@ is not properly initialized. I did not run the testcase ... Ovidiu Maxiniuc
04:42 AM Bug #7788: NPE when assigning query to browse: This code works in 4GL, but after conversion it throws a NullPointerExpression.... Alexandru Donica
03:47 AM Bug #7788 (New): NPE when assigning query to browse: Alexandru Donica
05:45 PM Bug #7793: incremental conversion with deleted table from .df: I am not sure I understand. Please correct me if I am wrong.
We have an initial conversion over a .df which contai... Ovidiu Maxiniuc
12:02 PM Bug #7793: incremental conversion with deleted table from .df: If an incremental conversion is done with a .df file which removes a table, the DMO remains in place, both as .java a... Constantin Asofiei
11:48 AM Bug #7793 (Closed): incremental conversion with deleted table from .df: Constantin Asofiei
04:52 PM Feature #4722: data import should be able to run with only the converted application jar file (an...: Review of 4722a, up to 14738.
I am generally OK with the code. Just a few notes to add:
Globally:
* the module... Ovidiu Maxiniuc
03:08 PM Feature #4722: data import should be able to run with only the converted application jar file (an...: Ovidiu: Please review. Greg Shah
11:33 AM Bug #7641: Lower the number of Map.get() calls in the persistence layer: I continued improving 7641a, which is now at rev. 14720. Basically, I moved @SchemaHelper@ to persist, instead of orm... Alexandru Lungu
10:30 AM Feature #7066: Implement multi-table indexed query in H2: Since 7066a_h2 is needed to fix a bug (regression?) that causes #7666 (and several other related tasks), what is the ... Greg Shah
07:58 AM Bug #7731: performance improvements for FQLPreprocessor: Dănuț Filimon wrote:
> So I should leave the cache size to *512k* instead of *8192* and wait for #7767 to be complet... Constantin Asofiei
07:50 AM Bug #7731: performance improvements for FQLPreprocessor: Constantin Asofiei wrote:
> The total number of cache hits (or misses). Set the cache number to something large (li... Dănuț Filimon
07:21 AM Bug #7731: performance improvements for FQLPreprocessor: Dănuț Filimon wrote:
> I will test it right away but is the number of calls the only information that you want to kn... Constantin Asofiei
06:58 AM Bug #7731: performance improvements for FQLPreprocessor: Constantin Asofiei wrote:
> For #7767, there are ~280k of @HQLParser.expression@ calls, which in turn create some 94... Dănuț Filimon
06:45 AM Bug #7731: performance improvements for FQLPreprocessor: Dănuț Filimon wrote:
> The problem with using simple @FIND FIRST@ statements is that if I want to use a counter vari... Constantin Asofiei
06:39 AM Bug #7731: performance improvements for FQLPreprocessor: Constantin Asofiei wrote:
> I don't think longer where clauses will show much - try to build a test having 100s/1000... Dănuț Filimon
05:01 AM Feature #6496 (WIP): add equivalent support for -trig command line option: Alex, please handle this now. There is some insight in spr and proghand documentations, but quite minimal.
Attempt t... Alexandru Lungu

09/11/2023

11:00 AM Bug #7731: performance improvements for FQLPreprocessor: Dănuț Filimon wrote:
> I want to test a customer application to see if the current size of the LRUCache (8196) is en... Constantin Asofiei
08:57 AM Bug #7731: performance improvements for FQLPreprocessor: *Committed 7731a/rev.14733*. Added the initial implementation for the HQLAst cache.
* The cache will be created usin... Dănuț Filimon
08:27 AM Bug #7731: performance improvements for FQLPreprocessor: I want to test a customer application to see if the current size of the LRUCache (8192) is enough and increase it if ... Dănuț Filimon
08:18 AM Bug #7731: performance improvements for FQLPreprocessor: Constantin Asofiei wrote:
> Danut, just to be clear, I'm referring to the HQL AST returned by this code:
> [...]
>... Dănuț Filimon
08:13 AM Bug #7731: performance improvements for FQLPreprocessor: Danut, just to be clear, I'm referring to the HQL AST returned by this code:... Constantin Asofiei
08:07 AM Bug #7731: performance improvements for FQLPreprocessor: Dănuț Filimon wrote:
> One problem with the cache implementation is that when we have two dynamic queries, one with ... Dănuț Filimon
07:57 AM Bug #7731: performance improvements for FQLPreprocessor: The @FQLPreprocessor@ will always use the cache when the dialect is @P2JH2Dialect@ because of the @inline = inline &&... Dănuț Filimon
05:56 AM Bug #7389: Make fast-copy statements cachable: Committed 7404a to trunk as rev. 14730. Alexandru Lungu
05:55 AM Bug #7488 (Test): Slow fast-copy with before tables in H2: Committed 7404a to trunk as rev. 14730. Alexandru Lungu
04:36 AM Bug #7641 (Review): Lower the number of Map.get() calls in the persistence layer: I committed 7641a rev. 14716 and 14717 with some improvements, including the use of Java array instead of ArrayList. ... Alexandru Lungu

09/10/2023

12:27 PM Feature #4722: data import should be able to run with only the converted application jar file (an...: Added H2 support in ScriptRunner.
Committed to 4722a/14738.
All changes to the ScriptRunner are done now.
Please... Igor Skornyakov
05:17 AM Feature #4722: data import should be able to run with only the converted application jar file (an...: Igor Skornyakov wrote:
> Ovidiu Maxiniuc wrote:
> > The statement for dropping the index is @getDropIndexString()@ ... Igor Skornyakov

09/08/2023

04:52 PM Feature #4722: data import should be able to run with only the converted application jar file (an...: Ovidiu Maxiniuc wrote:
> The statement for dropping the index is @getDropIndexString()@ for each @Dialect@. If you l... Igor Skornyakov
04:36 PM Feature #4722: data import should be able to run with only the converted application jar file (an...: The statement for dropping the index is @getDropIndexString()@ for each @Dialect@. If you look at @MariaDbLenientDial... Ovidiu Maxiniuc
03:18 PM Feature #4722: data import should be able to run with only the converted application jar file (an...: Ovidiu Maxiniuc wrote:
> Igor Skornyakov wrote:
> > I understand that on the "normal" database creation the @schema... Igor Skornyakov
03:02 PM Feature #4722: data import should be able to run with only the converted application jar file (an...: Igor Skornyakov wrote:
> I understand that on the "normal" database creation the @schema_index_${dbname}_${dialect}.... Ovidiu Maxiniuc
02:34 PM Feature #4722: data import should be able to run with only the converted application jar file (an...: I've noticed the following.
If I use @<parameter name="ddl-dialects" value="h2,postgresql,mariadblenient" />@ in the... Igor Skornyakov
02:27 PM Feature #4722: data import should be able to run with only the converted application jar file (an...: Add support for more SQL script types for PostgreSQL and MariaDB.
Committed to 4722/14735.
New commands are *create... Igor Skornyakov
07:41 AM Feature #4722: data import should be able to run with only the converted application jar file (an...: I understand that on the "normal" database creation the @schema_index_${dbname}_${dialect}.sql@ DDL script is not use... Igor Skornyakov
09:33 AM Feature #6720: lazy hydration: > I found tons of examples where static inference of @FIELDS@ clause would make lazy hydration less appealing.
My ... Greg Shah
08:43 AM Feature #6720: lazy hydration: I've reread this issue and refreshed my mind. There are some key observations before moving on:
* Eric, 6720b exis... Alexandru Lungu

09/07/2023

09:59 AM Bug #7776: Previous regression on FWD-H2 lazy mode: ... Alexandru Lungu
09:39 AM Bug #7776 (Closed): Previous regression on FWD-H2 lazy mode: Alexandru Lungu
09:04 AM Feature #7404 (Test): Trasform replace-mode into append-mode when target table is empty: Committed 7404a to trunk as rev. 14730. Alexandru Lungu
08:02 AM Feature #7404: Trasform replace-mode into append-mode when target table is empty: Starting the rebase; I will notify you when ready. Alexandru Lungu
06:54 AM Feature #7404: Trasform replace-mode into append-mode when target table is empty: If you are ready, you can go ahead with the merge now. Greg Shah
02:47 AM Feature #7404: Trasform replace-mode into append-mode when target table is empty: OK. Alexandru Lungu

09/06/2023

12:28 PM Feature #7404: Trasform replace-mode into append-mode when target table is empty: Merged is postponed for tomorrow - please coordinate with Greg before queuing for merge. Constantin Asofiei
10:58 AM Feature #7404: Trasform replace-mode into append-mode when target table is empty: Constantin Asofiei wrote:
> I'll do a round of ETF tests.
ETF tests is OK. Actually, it fixes a test which previou... Constantin Asofiei
09:34 AM Feature #7404: Trasform replace-mode into append-mode when target table is empty: Fixed the history numbers. I tested today the performance and I had 7 runs: some with 0.9% - 1.5% perf. improvement a... Alexandru Lungu
09:15 AM Feature #7404: Trasform replace-mode into append-mode when target table is empty: Alexandru, do you have a round of performance testing with 7156b + 7404a? I ask because #7404-28 notes a performance... Constantin Asofiei
08:53 AM Feature #7404: Trasform replace-mode into append-mode when target table is empty: I'll do a round of ETF tests.
In the mean time, please fix the history numbers - one per file, for the very first ... Constantin Asofiei
10:36 AM Bug #7731: performance improvements for FQLPreprocessor: The cache is meant to be on the FQL string, before the parse is performed - there is no buffer reference (i.e. semant... Constantin Asofiei
10:34 AM Bug #7731: performance improvements for FQLPreprocessor: If we create a @HQLAst@ cache and I assume that we want to access and populate it in @FQLPreprocessor.parse()@, won't... Dănuț Filimon
09:49 AM Feature #4722: data import should be able to run with only the converted application jar file (an...: This branch was rebased to @trunk_14728@ and is now at revision @14734@. Roger Borrello
08:13 AM Bug #7496: finish support for query:forward-only attribute: Alexandru Lungu wrote:
> Danut, as a debugging hint, I downloaded the PG driver sources and debugged them when @Resu... Dănuț Filimon
04:55 AM Bug #7496: finish support for query:forward-only attribute: Danut, as a debugging hint, I downloaded the PG driver sources and debugged them when @ResultSet.next@ was called. Th... Alexandru Lungu
04:39 AM Bug #7496: finish support for query:forward-only attribute: The dump was done using @TYPE_SCROLL_INSENSITIVE@ and @ForwardResults@ wasn't used, I had to modify he original dump ... Dănuț Filimon
03:03 AM Bug #7496: finish support for query:forward-only attribute: Dănuț Filimon wrote:
> I dumped the customer application database in *9 hours and 17 minutes*. While monitoring the ... Alexandru Lungu
02:35 AM Bug #7496: finish support for query:forward-only attribute: I dumped the customer application database in *9 hours and 17 minutes*. While monitoring the CPU and Memory using Vis... Dănuț Filimon
07:00 AM Feature #6371 (Closed): implement SAVE CACHE statement: Greg Shah

09/05/2023

04:01 PM Feature #4722: data import should be able to run with only the converted application jar file (an...: Found the key... during the post-init phase of the postgres image startup, all connections have to be Unix sockets. T... Roger Borrello
10:51 AM Bug #7488 (Review): Slow fast-copy with before tables in H2: I've done a second commit on 7404a removing more mutable data and making the solution more stable (rev. 14663). Now I... Alexandru Lungu
05:41 AM Bug #7488: Slow fast-copy with before tables in H2: Alexandru Lungu wrote:
> I made this change in 7404a/rev. 14662. Radu, please review.
The changes make sense, it wa... Radu Apetrii
05:19 AM Bug #7488: Slow fast-copy with before tables in H2: *Radu, in 7404a, the immutable and mutable data still not independent from each other:*
* In @FastCopyHelper.execute... Alexandru Lungu
08:24 AM Bug #7535: Temporary tables require trailing recid component even for unique indexes: I retested a customer application and used VisualVM to keep track of any @pendingReclaimedKeys@ and @reclaimedKeys@ l... Dănuț Filimon
06:48 AM Bug #7535: Temporary tables require trailing recid component even for unique indexes: > I tested 7535c using a customer application and there is an issue with direct-access. Now, temp-tables will have a ... Dănuț Filimon

09/04/2023

06:29 PM Feature #4722: data import should be able to run with only the converted application jar file (an...: I created a postgres image containing the FWD convert deployment. All the libraries that are required to run the @Scr... Roger Borrello
11:28 AM Feature #4722: data import should be able to run with only the converted application jar file (an...: This branch has been rebased to trunk_14724 and is now at revision 14728. Roger Borrello
09:55 AM Bug #7496: finish support for query:forward-only attribute: > The current problem is with the incremental version which I finally made it work, but even after making sure that n... Dănuț Filimon
06:45 AM Bug #7496: finish support for query:forward-only attribute: Rebased 7496a to trunk and is now at rev. 14732. Alexandru Lungu
08:58 AM Bug #7535: Temporary tables require trailing recid component even for unique indexes: I tested 7535c using a customer application and there is an issue with direct-access. Now, temp-tables will have a tr... Dănuț Filimon
06:21 AM Bug #7535: Temporary tables require trailing recid component even for unique indexes: Rebased 7535c with latest trunk and is now at rev. 14725. Alexandru Lungu
06:05 AM Bug #7731 (WIP): performance improvements for FQLPreprocessor: Danut, please do some investigation here - you have some consistent background with @FQLPreprocessor@ and inlining :)... Alexandru Lungu
04:00 AM Bug #7488: Slow fast-copy with before tables in H2: Dănuț Filimon wrote:
> Alexandru Lungu wrote:
> > Danut, did you had some correctness tests with fast-copy at some ... Radu Apetrii

09/03/2023

02:28 PM Feature #4722: data import should be able to run with only the converted application jar file (an...: It appears that @ScriptRunner@ requires more re-working than I've expected initially. In particular DDL scripts for t... Igor Skornyakov

09/02/2023

10:48 PM Feature #4722: data import should be able to run with only the converted application jar file (an...: Greg Shah wrote:
> Ovidiu: What additional testing is needed?
I meant testing whether the @ScriptRunner@ could be u... Ovidiu Maxiniuc

09/01/2023

07:01 PM Feature #4722: data import should be able to run with only the converted application jar file (an...: In revisiting getting the postgres image augmented to be able to run the data import internally, we have to install J... Roger Borrello
01:27 PM Feature #4722: data import should be able to run with only the converted application jar file (an...: Roger Borrello wrote:
> If you are using the latest @hotel_gui@ project, and the latest @4722a@, you should be able ... Igor Skornyakov
01:25 PM Feature #4722: data import should be able to run with only the converted application jar file (an...: Greg Shah wrote:
> Igor Skornyakov wrote:
> > I see the following message on the database import fron the @holel-gu... Igor Skornyakov
01:24 PM Feature #4722: data import should be able to run with only the converted application jar file (an...: Greg Shah wrote:
> > Please note also that at this moment @ScriptRunner@ works only with @PostgreSQL@ and @MariaDB@ ... Igor Skornyakov
12:55 PM Feature #4722: data import should be able to run with only the converted application jar file (an...: If you are using the latest @hotel_gui@ project, and the latest @4722a@, you should be able to run: @./p2j/import.sh ... Roger Borrello
12:28 PM Feature #4722: data import should be able to run with only the converted application jar file (an...: Igor Skornyakov wrote:
> I see the following message on the database import fron the @holel-gui@:
> [...]
> It see... Greg Shah
12:27 PM Feature #4722: data import should be able to run with only the converted application jar file (an...: > Please note also that at this moment @ScriptRunner@ works only with @PostgreSQL@ and @MariaDB@ since @H2@ UDFs are ... Greg Shah
11:20 AM Feature #4722: data import should be able to run with only the converted application jar file (an...: I see the following message on the database import fron the @holel-gui@:... Igor Skornyakov
11:04 AM Feature #4722: data import should be able to run with only the converted application jar file (an...: Some changes in the @ScriptRunner@ configuration logic are required.
Working on this.
Please note also that at this... Igor Skornyakov
09:42 AM Feature #4722: data import should be able to run with only the converted application jar file (an...: Greg Shah wrote:
> Application-specific DDL (for creating databases and indices) will be found in the application ja... Igor Skornyakov
09:41 AM Feature #4722: data import should be able to run with only the converted application jar file (an...: Application-specific DDL (for creating databases and indices) will be found in the application jar.
All changes go... Greg Shah
09:33 AM Feature #4722: data import should be able to run with only the converted application jar file (an...: One more questions.
Should I use 4722a branch for this task?
Thank you. Igor Skornyakov
09:27 AM Feature #4722: data import should be able to run with only the converted application jar file (an...: Greg Shah wrote:
> Igor: Please go ahead with this change. Assume that the DDL is available in the jar in a known l... Igor Skornyakov
09:09 AM Feature #4722: data import should be able to run with only the converted application jar file (an...: Igor: Please go ahead with this change. Assume that the DDL is available in the jar in a known location. Greg Shah
09:01 AM Feature #4722: data import should be able to run with only the converted application jar file (an...: Greg Shah wrote:
> > Even if there were an enhancement to have ScriptRunner be able to execute the DDL,
>
> The D... Igor Skornyakov
08:40 AM Feature #4722: data import should be able to run with only the converted application jar file (an...: > Even if there were an enhancement to have ScriptRunner be able to execute the DDL,
The DDL definitely should be ... Greg Shah
08:38 AM Feature #4722: data import should be able to run with only the converted application jar file (an...: Greg Shah wrote:
> Roger: Based on your testing, there anything else needed in this task?
From my perspective, no... Roger Borrello
08:34 AM Feature #4722: data import should be able to run with only the converted application jar file (an...: Eric: This is still waiting for review.
Ovidiu: What additional testing is needed?
Roger: Based on your testing... Greg Shah
09:14 PM Feature #4722: data import should be able to run with only the converted application jar file (an...: I've replaced the @hotel-import.sh@ with @import@ that now utilizes the *p2j.jar* and *app.jar*. There is a new requi... Roger Borrello
02:10 AM Bug #7488: Slow fast-copy with before tables in H2: Alexandru Lungu wrote:
> Danut, did you had some correctness tests with fast-copy at some point? Can you share them ... Dănuț Filimon

08/31/2023

11:15 AM Feature #4722: data import should be able to run with only the converted application jar file (an...: > Branch was rebased to trunk_14721 and is at revision 14722. I noticed there were many spelling/formatting updates i... Greg Shah
11:07 AM Feature #4722: data import should be able to run with only the converted application jar file (an...: Branch was rebased to trunk_14721 and is at revision 14722. I noticed there were many spelling/formatting updates in ... Roger Borrello
09:05 AM Feature #4722: data import should be able to run with only the converted application jar file (an...: Any objections to me rebase-ing to the latest trunk? My checkout is at revision 14663. No pending changes to commit t... Roger Borrello
09:58 AM Bug #7488: Slow fast-copy with before tables in H2: The changes are very close to state-of-the-art in 7404a. Very good job, Radu!
* Please rename @PK__MAPPING@ into @... Alexandru Lungu
09:47 AM Bug #7535: Temporary tables require trailing recid component even for unique indexes: Alexandru Lungu wrote:
> * You call @if (!isUndoable()) { reclaimKeys();}@ Note that this will reclaim all keys acro... Dănuț Filimon
07:17 AM Bug #7496: finish support for query:forward-only attribute: Personal tests and customer application were tested previously. I've retested them just to make sure, but I was not s... Dănuț Filimon
04:22 AM Bug #7731: performance improvements for FQLPreprocessor: Alexandru, I think this can help - can you take a look at it? Constantin Asofiei

08/30/2023

09:39 AM Bug #7535 (Review): Temporary tables require trailing recid component even for unique indexes: Danut, I am mostly OK with the changes in 7535c.
* You call @if (!isUndoable()) { reclaimKeys();}@ Note that this ... Alexandru Lungu
08:09 AM Bug #7488: Slow fast-copy with before tables in H2: I applied the bullets from #7488-28 and committed to 7404a, rev. 14660. In addition to that, I also merged the two @p... Radu Apetrii
04:19 AM Bug #7488: Slow fast-copy with before tables in H2: Radu Apetrii wrote:
> The only relevant purpose at the moment for @isBefore@ would be bullet 2 from the list above. ... Alexandru Lungu
04:06 AM Bug #7488: Slow fast-copy with before tables in H2: Alexandru Lungu wrote:
> * There is quite some logic around @isBefore@ inside @executeCopy@. Can you summarize it he... Radu Apetrii
05:12 AM Bug #7567: use Session.PK instead of DatabaseManager.PRIMARY_KEY wherever possible: *Committed 7567a/rev.14714 and 7567a_h2/rev.27*. Removed DatabaseManager.PRIMARY_KEY and replaced it's usage with Ses... Dănuț Filimon
04:31 AM Bug #7496 (Review): finish support for query:forward-only attribute: Danut, please let me know if there is something left in this task.
Please do a full round of testing with this:
*... Alexandru Lungu
04:00 AM Bug #7641: Lower the number of Map.get() calls in the persistence layer: Committed refactoring the code on 7641a revision 14715.
Eduard Soltan

08/29/2023

10:45 AM Bug #7488: Slow fast-copy with before tables in H2: *Review of 7404a*
* You don't actually need @FastCopyContext.newInstance@ - you can call the constructor directly.... Alexandru Lungu
06:57 AM Feature #7447 (Closed): Compare ValueString and ValueStringIgnoreCase faster in FWD-H2: Greg Shah
03:32 AM Feature #7447 (Review): Compare ValueString and ValueStringIgnoreCase faster in FWD-H2: Ok, this can be closed then - let me know if there is something left here to discuss Alexandru Lungu
03:29 AM Feature #7447: Compare ValueString and ValueStringIgnoreCase faster in FWD-H2: Great news! I retested the customer application using a different approach which allowed me to test it a lot faster a... Dănuț Filimon

08/28/2023

02:27 PM Feature #4722: data import should be able to run with only the converted application jar file (an...: @ScriptRunner@ currently only accepts the commands:
* @udf.install@
* @udf.install.search_path@
It would need ... Eric Faulhaber
01:58 PM Feature #4722: data import should be able to run with only the converted application jar file (an...: Ovidiu Maxiniuc wrote:
> I think the @build.xml@ is only modified to allow the packaging of the @ddl@ scripts inside... Roger Borrello
01:52 PM Feature #4722: data import should be able to run with only the converted application jar file (an...: I think the @build.xml@ is only modified to allow the packaging of the @ddl@ scripts inside the app's jar file.
On... Ovidiu Maxiniuc
01:40 PM Feature #4722: data import should be able to run with only the converted application jar file (an...: That is all understood... and @import.sh@ allows you to perform an import with only the @p2j.jar@, the @app.jar@ and ... Roger Borrello
01:04 PM Feature #4722: data import should be able to run with only the converted application jar file (an...: Customers need to be able to deploy without a project installation. Optimally, the solution would only require the F... Greg Shah
12:02 PM Feature #4722: data import should be able to run with only the converted application jar file (an...: If this tool cuts the muster, should it be part of FWD versus something given to the customers for use in their appli... Roger Borrello
10:24 AM Bug #7641: Lower the number of Map.get() calls in the persistence layer: Rebased 7641a to trunk. 14711. Alexandru Lungu
09:36 AM Feature #7447: Compare ValueString and ValueStringIgnoreCase faster in FWD-H2: Alexandru Lungu wrote:
> Danut, please check if this is still happening after your changes in #7454. Of course, befo... Dănuț Filimon
08:17 AM Bug #7488: Slow fast-copy with before tables in H2: Alexandru Lungu wrote:
> Radu Apetrii wrote:
> > The problem with this is that @TemporaryBuffer.copyAllRows@ is a *... Radu Apetrii
08:07 AM Bug #7488: Slow fast-copy with before tables in H2: Radu Apetrii wrote:
> The problem with this is that @TemporaryBuffer.copyAllRows@ is a *static* method, so I don't h... Alexandru Lungu
06:03 AM Bug #7488: Slow fast-copy with before tables in H2: I've applied the suggestions from the last post (except one) and committed to 7404a, rev. 14658.
Alexandru Lungu w... Radu Apetrii
08:05 AM Bug #7535: Temporary tables require trailing recid component even for unique indexes: Alexandru Lungu wrote:
> Danut, please push on 7535c (newly created) a sound solution. Most important is to allow re... Dănuț Filimon
07:16 AM Feature #7064 (Rejected): Analyze the performance impact of the implicit meta schema in H2: Greg Shah
03:56 AM Feature #7064: Analyze the performance impact of the implicit meta schema in H2: * When you open a session and create a database, you reach @Database.open@, which calls @Database.addDatabaseObject@.... Alexandru Lungu

08/25/2023

10:46 AM Bug #7535: Temporary tables require trailing recid component even for unique indexes: > It is not completely clear to me what your conclusions are regarding persistent tables. I would like to avoid attem... Alexandru Lungu
10:20 AM Bug #7535: Temporary tables require trailing recid component even for unique indexes: Alexandru Lungu wrote:
> In the last 2 examples, in practice, there are other recids (1491 instead of 1488, etc.).... Eric Faulhaber
10:38 AM Bug #6941 (Rejected): conversion issue when using undo in do transaction: Greg Shah
10:31 AM Bug #6941 (WIP): conversion issue when using undo in do transaction: This can be closed / rejected. Alexandru Lungu
10:02 AM Bug #6941: conversion issue when using undo in do transaction: It seems that this has been solved in the meantime. I tested with trunk, rev. 14709 and everything worked fine. No is... Radu Apetrii
10:29 AM Bug #7641: Lower the number of Map.get() calls in the persistence layer: I am OK with most of the changes; there seemed to be quite some places which needed refactoring.
Eduard, please co... Alexandru Lungu
09:56 AM Bug #7496: finish support for query:forward-only attribute: *Committed 7496a/rev.14705*. After fixing #7737 (#7737-12) and investigating @TRANSACTION_COMMITTING@, I managed to f... Dănuț Filimon
06:36 AM Feature #4722: data import should be able to run with only the converted application jar file (an...: Roger Borrello wrote:
> I made some upgrades to the program to:
> # Handle multiple database imports
> # Retrieve ... Greg Shah
03:57 AM Bug #7488: Slow fast-copy with before tables in H2: *Review of 7404a, rev. 14656*
The changes are quite good now and look pretty stable. However, there are still some... Alexandru Lungu

08/24/2023

04:46 PM Feature #4722: data import should be able to run with only the converted application jar file (an...: I made some upgrades to the program to:
# Handle multiple database imports
# Retrieve DDL from the application jar
... Roger Borrello
11:57 AM Feature #4722: data import should be able to run with only the converted application jar file (an...: I do notice that my application jar file does *not* include the ddl necessary to create the table structure. I can ea... Roger Borrello
08:27 AM Feature #7323: Implement soft unique index in FWD-H2: Committed 7323a_h2 as FWD-H2 rev. 26 and archived.
The FWD changes will be merged once we upgrade to the latest FW... Alexandru Lungu
03:18 AM Feature #7323: Implement soft unique index in FWD-H2: Alexandru Lungu wrote:
> Please focus on identifying any changes that may cause regressions when VALIDATE mode is no... Radu Apetrii
03:42 AM Bug #7535: Temporary tables require trailing recid component even for unique indexes: I was using @COMPILE test.p LISTING test.lst@ at some point, but this is informative only when working with a persist... Alexandru Lungu

08/23/2023

03:59 PM Bug #7535: Temporary tables require trailing recid component even for unique indexes: Constantin Asofiei wrote:
> Alexandru, you can use @COMPILE test.p LISTING test.lst@ to check the transaction behavi... Tijs Wickardt
10:23 AM Bug #7535: Temporary tables require trailing recid component even for unique indexes: Alexandru, you can use @COMPILE test.p LISTING test.lst@ to check the transaction behavior in 4GL. Keep in mind that... Constantin Asofiei
10:07 AM Bug #7535: Temporary tables require trailing recid component even for unique indexes: The test-cases you found are quite interesting. I've done some testing myself with nested transactions.
In 95% of... Alexandru Lungu
10:16 AM Feature #7064: Analyze the performance impact of the implicit meta schema in H2: Radu Apetrii wrote:
> Can/should this task be rejected? IMO, there is nothing left to investigate/implement here.
... Alexandru Lungu
09:16 AM Feature #7064: Analyze the performance impact of the implicit meta schema in H2: Can/should this task be rejected? IMO, there is nothing left to investigate/implement here. Radu Apetrii
08:42 AM Bug #7737: QueryWrapper should either show or throw errors depending on the query type: *Committed 7496a/rev.14704*. Fixed 4 errors in @QueryWrapper@.
I've created a test suite to test how errors are hand... Dănuț Filimon
07:13 AM Bug #7737: QueryWrapper should either show or throw errors depending on the query type: Danut, please fix the cases where errors behave different for static / dynamic queries. That is, change @QueryWrapper... Alexandru Lungu
07:07 AM Bug #7737: QueryWrapper should either show or throw errors depending on the query type: Alexandru Lungu wrote:
> Can you extend your testing for other kind of errors thrown by @QueryWrapper@? For instance... Dănuț Filimon
08:31 AM Feature #7404: Trasform replace-mode into append-mode when target table is empty: Radu Apetrii wrote:
> While testing something for #7488, I noticed a regression on a test with @copy-temp-table with... Radu Apetrii
06:50 AM Bug #7488: Slow fast-copy with before tables in H2: I added some more changes to @FastCopyHelper@ on 7404a, rev. 14656:
* Merged the master/before methods, meaning that... Radu Apetrii
03:33 AM Bug #7403: Copy-temp-table with replace-mode should replace already inserted records: Radu, please note that fast-copy with REPLACE happens *only if* the destination is empty. This way, append is used in... Alexandru Lungu
03:06 AM Bug #7403: Copy-temp-table with replace-mode should replace already inserted records: Alexandru Lungu wrote:
> Radu, please check if this fixes your issue in #7404-32. After, please extract the changes ... Radu Apetrii

08/22/2023

07:13 PM Feature #4722: data import should be able to run with only the converted application jar file (an...: OK... I see it isn't merged to trunk. What is left to do? I updated:... Roger Borrello
06:24 PM Feature #4722: data import should be able to run with only the converted application jar file (an...: Has this been merged to trunk yet? I have a new @import.sh@ script that should work with this usage:... Roger Borrello
09:34 AM Bug #7737: QueryWrapper should either show or throw errors depending on the query type: I see. It is weird that we don't have any similar use-case implemented in FWD: throw error if static, just show error... Alexandru Lungu
09:19 AM Bug #7737: QueryWrapper should either show or throw errors depending on the query type: Alexandru Lungu wrote:
> Is the fact that in the second example the query is scrolling?
It doesn't matter if the q... Dănuț Filimon
09:11 AM Bug #7737: QueryWrapper should either show or throw errors depending on the query type: Danut, can you attempt making the query forward-only *after* you prepare it, but *before* opening? Is there any diffe... Alexandru Lungu
09:08 AM Bug #7737 (WIP): QueryWrapper should either show or throw errors depending on the query type: Is the fact that in the second example the query is scrolling? Or maybe because the second query is dynamic? Or maybe... Alexandru Lungu
08:54 AM Bug #7737: QueryWrapper should either show or throw errors depending on the query type: Alexandru Lungu wrote:
> Is there a problem in changing @recordOrShowError@ into @recordOrThrowError@?
>
> Danut,... Dănuț Filimon
08:37 AM Bug #7737: QueryWrapper should either show or throw errors depending on the query type: Is there a problem in changing @recordOrShowError@ into @recordOrThrowError@?
Danut, do you have an example in whi... Alexandru Lungu
08:23 AM Bug #7737: QueryWrapper should either show or throw errors depending on the query type: Another simpler test:... Dănuț Filimon
08:14 AM Bug #7737: QueryWrapper should either show or throw errors depending on the query type: This test fails for *7496a/rev.14703* and *trunk/rev.14704*. ... Dănuț Filimon
07:51 AM Bug #7737 (Test): QueryWrapper should either show or throw errors depending on the query type: Dănuț Filimon
09:32 AM Bug #5452 (Closed): eliminate use of ResultSet.CONCUR_UPDATABLE?: Greg Shah
07:50 AM Bug #5452 (Test): eliminate use of ResultSet.CONCUR_UPDATABLE?: Branch 5452a was merged to trunk as rev 14704 and archived.
This can be closed. Alexandru Lungu
07:28 AM Bug #5452: eliminate use of ResultSet.CONCUR_UPDATABLE?: I am OK with the changes.
I also committed 5452a rev. 14563 removing @readOnly@ from share manager and multiplexer c... Alexandru Lungu
09:22 AM Bug #7412 (Closed): PresortQuery ORDER BY has to many clauses: Greg Shah
05:15 AM Bug #7412: PresortQuery ORDER BY has to many clauses: This can be closed. Alexandru Lungu
09:02 AM Bug #7489: Lazily initialize DMO signature: On a server start-up with 2251 DMO loaded, I got 40ms spent in quick signature building, 50ms spent in explicit signa... Alexandru Lungu
05:17 AM Feature #7404: Trasform replace-mode into append-mode when target table is empty: Radu, this task was mostly fixed, but it is still open for review. As you do a major refactoring of @FastCopyHelper@,... Alexandru Lungu
05:12 AM Feature #7320: Extend H2 tester from Hotel GUI: There are lots of insightful tests generated for FWD-H2 right from the H2 tester. However, these are unusable in FWD ... Alexandru Lungu
05:01 AM Bug #7403 (Review): Copy-temp-table with replace-mode should replace already inserted records: *I reviewed the changes in 7403a and they are OK.*
Radu, please check if this fixes your issue in #7404-32. After,... Alexandru Lungu
04:10 AM Bug #7535: Temporary tables require trailing recid component even for unique indexes: I retested after making a change to @Commitable@, but I am still left with two tests that end up in an infinite loop.... Dănuț Filimon

08/21/2023

02:09 PM Bug #7731: performance improvements for FQLPreprocessor: When something is inlined, the @FQLPreprocessor@ does not use the cache at all. What I noticed is that @FQLPreproces... Constantin Asofiei
02:03 PM Bug #7731 (Closed): performance improvements for FQLPreprocessor: Constantin Asofiei
10:01 AM Feature #7404: Trasform replace-mode into append-mode when target table is empty: While testing something for #7488, I noticed a regression on a test with @copy-temp-table with REPLACE@, introduced i... Radu Apetrii
08:01 AM Bug #7535: Temporary tables require trailing recid component even for unique indexes: Alexandru Lungu wrote:
> What about a 7535b?
Yes, please create 7535b so that I can start working on @Commitable@.
Dănuț Filimon
07:56 AM Bug #7535: Temporary tables require trailing recid component even for unique indexes: What about a 7535b? Alexandru Lungu
07:48 AM Bug #7535: Temporary tables require trailing recid component even for unique indexes: Alexandru Lungu wrote:
> Can you post the third example here to discuss why the recid is never reclaimed? Mayb is be... Dănuț Filimon
07:40 AM Bug #7535: Temporary tables require trailing recid component even for unique indexes: Dănuț Filimon wrote:
> I did 3 tests where records are deleted and then created in a loop (first test - no delete ob... Alexandru Lungu
07:36 AM Bug #7535: Temporary tables require trailing recid component even for unique indexes: Alexandru Lungu wrote:
> Create a dynamic buffer with @CREATE BUFFER buf@. Do similar work you've done in your tests... Dănuț Filimon
07:13 AM Feature #7323 (Review): Implement soft unique index in FWD-H2: Radu, I am planning to merge *7323a_h2* to FWD-H2. Please double check that everything is alright.
Please focus on... Alexandru Lungu
05:32 AM Bug #7454: Make ValueStringIgnoreCase the default generated value for setString in FWD-H2: Alexandru Lungu wrote:
> Note that the conversion *always* adds @UPPER@ for character fields because it is independe... Dănuț Filimon
05:20 AM Bug #7454: Make ValueStringIgnoreCase the default generated value for setString in FWD-H2: > This test case covers all the current problems with upper. The converted query looks like this:
Note that the co... Alexandru Lungu
05:16 AM Bug #7454: Make ValueStringIgnoreCase the default generated value for setString in FWD-H2: Alexandru Lungu wrote:
> Danut, please update [[internal-documentation:H2_Database_Fork]] with @DEFAULT_IGNORE_CASE@... Dănuț Filimon
04:45 AM Bug #7454: Make ValueStringIgnoreCase the default generated value for setString in FWD-H2: Dănuț Filimon wrote:
> @tt.f1 != "a"@ generates the expected @tt.f1 is null@ but without the @upper@ call. I am stil... Alexandru Lungu
03:59 AM Bug #7454: Make ValueStringIgnoreCase the default generated value for setString in FWD-H2: Alexandru Lungu wrote:
> Not really; @upper(tt.f1) is null@ is generated each time you do something like @tt.f1 != "... Dănuț Filimon
03:32 AM Bug #7454: Make ValueStringIgnoreCase the default generated value for setString in FWD-H2: *Committed 7454a_h2 to FWD_H2 trunk as rev. 25. Archived 7454a_h2.*
Danut, please update [[internal-documentation:... Alexandru Lungu

08/18/2023

10:53 AM Bug #7454: Make ValueStringIgnoreCase the default generated value for setString in FWD-H2: Dănuț Filimon wrote:
> upper(tt.f1) in ('A', 'B') and upper(tt.f1) is null look to be very specific.
Not really;... Alexandru Lungu
09:49 AM Bug #7454: Make ValueStringIgnoreCase the default generated value for setString in FWD-H2: Alexandru Lungu wrote:
> Danut, please let me know if there is anything left to be worked on this task. If everythin... Dănuț Filimon
09:39 AM Bug #7454 (Review): Make ValueStringIgnoreCase the default generated value for setString in FWD-H2: *Review of 7454a and 7454a_h2*
* I am OK with the changes.
* Regression tests passed.
* I am *no* longer hitting... Alexandru Lungu
04:15 AM Bug #7454: Make ValueStringIgnoreCase the default generated value for setString in FWD-H2: I've looked into the problem and @upper@ methods are not reintroduced later in @FQLPreprocessor.mainWalk()@. It was a... Dănuț Filimon
07:22 AM Bug #7535: Temporary tables require trailing recid component even for unique indexes: Dănuț Filimon wrote:
> Can you please elaborate?
Create a dynamic buffer with @CREATE BUFFER buf@. Do similar wor... Alexandru Lungu
06:48 AM Bug #7535: Temporary tables require trailing recid component even for unique indexes: Alexandru Lungu wrote:
> What happens to the other buffers (on other tables / other multiplex)? What if we iterate w... Dănuț Filimon
04:24 AM Bug #7535: Temporary tables require trailing recid component even for unique indexes: *Review of 7535a*
* Doing a reclaim on @iterate@ looks right. However, I think @iterate@ is called only for the bu... Alexandru Lungu
02:28 AM Bug #7535: Temporary tables require trailing recid component even for unique indexes: Eric Faulhaber wrote:
> I wouldn't expect @BY RECID DESC@ to work. That doesn't look like valid 4GL code.
>
> Tha... Dănuț Filimon

08/17/2023

12:09 PM Bug #7535: Temporary tables require trailing recid component even for unique indexes: Dănuț Filimon wrote:
> When running the @test01.i with tt01 BY RECID DESC@ test, I end up with this select statement... Eric Faulhaber
07:37 AM Bug #7535: Temporary tables require trailing recid component even for unique indexes: Alexandru Lungu wrote:
> Danut, can you paste here the testcase which causes the issue in #7535-35? Thank you.
The ... Dănuț Filimon
07:07 AM Bug #7535: Temporary tables require trailing recid component even for unique indexes: Danut, can you paste here the testcase which causes the issue in #7535-35? Thank you. Alexandru Lungu
04:20 AM Bug #7535: Temporary tables require trailing recid component even for unique indexes: I also found @CompoundQuery.cleaner@ which is also a @Finalizable@ instance, it's a similar situation to @PreselectQu... Dănuț Filimon
03:58 AM Bug #7535: Temporary tables require trailing recid component even for unique indexes: *Committed 7535a/rev.14673*. This is a necessary change that I mentioned in #7535-29 about the @PrelectQuery.cleaner@... Dănuț Filimon
03:46 AM Bug #7535: Temporary tables require trailing recid component even for unique indexes: Alexandru Lungu wrote:
> Danut, regarding the recid mismatch, please refer to #7647-2. Use Ovidiu's patch just to cl... Dănuț Filimon
03:23 AM Bug #7535: Temporary tables require trailing recid component even for unique indexes: > Currently I can't test this assumption because of an ongoing issue with jboss repository resource which stops the p... Alexandru Lungu
03:20 AM Bug #7535: Temporary tables require trailing recid component even for unique indexes: Danut, regarding the recid mismatch, please refer to #7647-2. Use Ovidiu's patch just to clear up *some* mismatches. ... Alexandru Lungu
11:15 AM Bug #7488: Slow fast-copy with before tables in H2: *Review of 7404a*
This is a good start, but it is still far from ideal at this point. Radu, please consider doing ... Alexandru Lungu
06:26 AM Bug #7488: Slow fast-copy with before tables in H2: I've done some refactoring to @FastCopyHelper@:
* Added a cache that stores the instances of @FastCopyHelper@ based ... Radu Apetrii
09:42 AM Feature #7504: Export data tool from FWD into .d files: Another configuration option to consider is to allow a dump of only a subset of tables (perhaps an inclusive or exclu... Eric Faulhaber
08:21 AM Feature #7504: Export data tool from FWD into .d files: Greg Shah wrote:
> We might want to consider reading the configuration from the directory. In that case it will req... Alexandru Lungu
07:41 AM Feature #7504: Export data tool from FWD into .d files: Also I should point out that export will be used on production systems that won't have the standard application cfg p... Greg Shah
07:33 AM Feature #7504: Export data tool from FWD into .d files: We might want to consider reading the configuration from the directory. In that case it will require little or no pa... Greg Shah
07:19 AM Feature #7504: Export data tool from FWD into .d files: > Yes, any such utilities will often have some requirement for configuration. But we don't want them to be hard coded... Alexandru Lungu
07:11 AM Feature #7504: Export data tool from FWD into .d files: > Greg, by stored metadata dynamically you mean the beans we can find in the @dmo@ package (read annotations, hydrate... Greg Shah
06:49 AM Feature #7504: Export data tool from FWD into .d files: > I actually would like to move away from the current ant import.db and ImportWorker approach. These rely upon TRPL a... Alexandru Lungu
08:58 AM Bug #7454: Make ValueStringIgnoreCase the default generated value for setString in FWD-H2: Alexandru Lungu wrote:
> I still have a concern with indexOf function. It takes two strings as parameters. It attemp... Dănuț Filimon
06:51 AM Bug #7454: Make ValueStringIgnoreCase the default generated value for setString in FWD-H2: Regression tests passed.
Profiling tests shown -0.3% improvement (without temporary sequences). This is modest, but ... Alexandru Lungu
07:20 AM Bug #7496: finish support for query:forward-only attribute: *Committed 7496a/rev.14656*. I brought the changes made by Stefan in #7241 (7241b) to 7496a.
I've done tests with ... Dănuț Filimon

08/16/2023

06:52 AM Bug #7535: Temporary tables require trailing recid component even for unique indexes: When running the @test01.i with tt01 BY RECID DESC@ test, I end up with this select statement: ... Dănuț Filimon
03:44 AM Bug #7535: Temporary tables require trailing recid component even for unique indexes: I mentioned that keys are not reclaimed in simple @FOR EACH@ blocks and after making the necessary changes to reclaim... Dănuț Filimon

« Previous

Also available in: Atom

Project

General

Profile

FWD » Core Development » Database

Activity

Activity

09/14/2023

09/13/2023

09/12/2023

09/11/2023

09/10/2023

09/08/2023

09/07/2023

09/06/2023

09/05/2023

09/04/2023

09/03/2023

09/02/2023

09/01/2023

08/31/2023

08/30/2023

08/29/2023

08/28/2023

08/25/2023

08/24/2023

08/23/2023

08/22/2023

08/21/2023

08/18/2023

08/17/2023

08/16/2023