Project

General

Profile

Activity

From 07/17/2023 to 08/15/2023

08/15/2023

03:45 AM Feature #7382: Check performance of delete from vs drop table in H2
Constantin Asofiei wrote:
> What I meant in FWD-H2 is to check if the number of selected records which are to be del...
Dănuț Filimon
03:20 AM Bug #7641: Lower the number of Map.get() calls in the persistence layer
Made @fieldInfo@ a simple Java array, also added to @getMutableInfo@ a new parameter @fieldCount@, those meaning is n... Eduard Soltan

08/14/2023

02:46 AM Bug #7641: Lower the number of Map.get() calls in the persistence layer
Eduard, fieldInfo (and other structures related to fields) can be 'frozen' as a Java array once this table info was b... Constantin Asofiei
02:40 AM Feature #7382: Check performance of delete from vs drop table in H2
Alexandru, I didn't mean to change the DELETE SQL. What I meant in FWD-H2 is to check if the number of selected reco... Constantin Asofiei

08/11/2023

05:27 AM Bug #7535: Temporary tables require trailing recid component even for unique indexes
*Committed 7535a/rev.14672*. Applied the patch from #7535-26 after making another small change.
* Added reclaimKeys ...
Dănuț Filimon

08/09/2023

04:56 AM Bug #7535: Temporary tables require trailing recid component even for unique indexes
Using the patch posted in #7535-26, I've done similar tests to #7535-15 on 7535a using FWD-22 and all the previous pa... Dănuț Filimon

08/08/2023

08:39 AM Feature #7504: Export data tool from FWD into .d files
From Stefan via email:
> I created an ExportWorker class for #7504 and now I am trying to understand @ant import.d...
Greg Shah
07:03 AM Bug #7667: Support OUTER-JOIN with PRESELECT at conversion
Andrei, please address #7667-2. Also, please make some tests with @CAN-FIND@ for that matter. Alexandru Lungu
05:32 AM Bug #7667: Support OUTER-JOIN with PRESELECT at conversion
Please note that the conversion of the @CompoundQuery@ to the @PreselectQuery@ should not be applied if one of the co... Igor Skornyakov
04:15 AM Bug #7667 (WIP): Support OUTER-JOIN with PRESELECT at conversion
This is a continuation of the #6196 effort of optimizing @CompoundQuery@ to merge components that have OUTER-JOIN. In... Alexandru Lungu
04:06 AM Bug #7667 (Test): Support OUTER-JOIN with PRESELECT at conversion
Alexandru Lungu
04:40 AM Feature #7323: Implement soft unique index in FWD-H2
I retested with the latest changes in 7323a and got -1% improvement now. This starts looking good. At this point I am... Alexandru Lungu
03:53 AM Bug #7496: finish support for query:forward-only attribute
There are a few things wrong with the patch from #7496-22 which I just found out while testing.
# TemporaryBuffer do...
Dănuț Filimon
03:27 AM Bug #7496: finish support for query:forward-only attribute
Danut, please find a concrete example where 7496a (together with 7241b) is failing before @SessionListener.Event.TRAN... Alexandru Lungu

08/07/2023

10:12 AM Bug #7641: Lower the number of Map.get() calls in the persistence layer
Committed on 7641a revision 14683.
@fieldInfo@ in @AbstractTempTable@ became an @ArrayList@, instead of @HashMap@....
Eduard Soltan
04:01 AM Bug #7641: Lower the number of Map.get() calls in the persistence layer
Created 7641a. Alexandru Lungu
10:01 AM Bug #7496: finish support for query:forward-only attribute
I previously tested a large customer application using the changes from 7241b/rev.14655, 7496a/rev.14655 and a few ch... Dănuț Filimon
05:23 AM Bug #7334: Reclaim used sessions to improve performance
Session reclaiming couldn't be disabled since most values either default to a set value or only disable the managing ... Dănuț Filimon

08/04/2023

10:08 AM Bug #7641: Lower the number of Map.get() calls in the persistence layer
In @TempTableMapper@ there is a @private final Map<TempTable, LegacyTableInfo> p2j = new HashMap<>();@ which should b... Eduard Soltan
06:51 AM Feature #7382: Check performance of delete from vs drop table in H2
From Constantin's solution, I think we can just generate @delete from tt1@ when we know this as the last multiplex is... Alexandru Lungu

08/03/2023

08:05 AM Feature #7323: Implement soft unique index in FWD-H2
I've committed to 7323a, rev. 14690 and 7323a_h2, rev. 23. I added support for the @DirectAccess@ idea mentioned in #... Radu Apetrii
05:05 AM Feature #7323: Implement soft unique index in FWD-H2
Alexandru Lungu wrote:
> *Radu, what is your input on this idea?*
I will investigate the aspects mentioned and I wi...
Radu Apetrii
05:00 AM Feature #7323: Implement soft unique index in FWD-H2
I don't expect a miracle from @VALIDATE@, but 30k SELECT statements are in fact a lot (from my POV). I agree that the... Alexandru Lungu
04:28 AM Feature #7323: Implement soft unique index in FWD-H2
Alexandru Lungu wrote:
> Clearly we should see better improvement as now we have ~28k less SELECT statements, right?...
Radu Apetrii
03:26 AM Bug #7488: Slow fast-copy with before tables in H2
Radu, there is some work in #7404 regarding the moving of most of the copy-temp-table operations to fast-copy using h... Alexandru Lungu

08/02/2023

04:19 AM Feature #7416: Reiterate DatabaseStatistics and leverage to other database profling tools
I have also created a script to analyze the following things:
* How many times each type of query was executed.
* W...
Radu Apetrii
04:06 AM Feature #7416: Reiterate DatabaseStatistics and leverage to other database profling tools
I've added some changes to 7416b, rev. 14681. They include the following:
* Fixed the javadoc mentioned in #7416-23....
Radu Apetrii

08/01/2023

08:13 AM Feature #7365 (Closed): Avoid using reflection in generating BDT
Greg Shah
08:02 AM Feature #7365 (Test): Avoid using reflection in generating BDT
This was merged in trunk by 7026e and can be closed. Alexandru Lungu
08:02 AM Feature #7365 (Review): Avoid using reflection in generating BDT
Alexandru Lungu
04:55 AM Bug #7334 (WIP): Reclaim used sessions to improve performance
> Even though Session originally was intended to be used for a single connection check-out, should we be checking in ... Alexandru Lungu

07/31/2023

07:52 PM Feature #4722: data import should be able to run with only the converted application jar file (an...
After your requested update to my parameters, I have been able to make the connection and import... thank you for the... Roger Borrello
02:01 PM Bug #7647: Leverage internal H2 _ROWID_ with FWD recid
While working on first implementation of datasets I encountered an issue related to records from different temp-table... Ovidiu Maxiniuc
11:30 AM Bug #7647: Leverage internal H2 _ROWID_ with FWD recid
H2 is keeping an internal _rowid_ information for each row. For in-memory tables, this is basically the index at whic... Alexandru Lungu
11:15 AM Bug #7647 (New): Leverage internal H2 _ROWID_ with FWD recid
Alexandru Lungu
11:32 AM Bug #7334: Reclaim used sessions to improve performance
(In a different task) Alexandru Lungu wrote:
> > > Otherwise, there are 20 org.postgresql.jdbc.PgConnection, some ar...
Eric Faulhaber
08:03 AM Bug #7641 (WIP): Lower the number of Map.get() calls in the persistence layer
Alexandru Lungu

07/29/2023

09:21 PM Bug #7645: Simplify _meta database initialization by removing <schema>.meta.xml resource
Currently, the population of schema related tables as part of the initialization of _meta database uses two sources:
...
Ovidiu Maxiniuc
08:58 PM Bug #7645 (Test): Simplify _meta database initialization by removing <schema>.meta.xml resource
Ovidiu Maxiniuc

07/28/2023

03:22 PM Feature #7504: Export data tool from FWD into .d files
Greg Shah wrote:
> > The database can be spoiled with different kind of extra tables / fields we don't actually want...
Ovidiu Maxiniuc
02:52 PM Feature #7504: Export data tool from FWD into .d files
I agree our ant build should have an option to use this, but I do want our utility code (Java) to be a complete stand... Greg Shah
07:51 AM Feature #7504: Export data tool from FWD into .d files
h3. Plan
We need an ant option for this. To be consistent, I suggest something like @ant export.db@ that relies on...
Alexandru Lungu
11:14 AM Bug #7641: Lower the number of Map.get() calls in the persistence layer
From Constantin:
* *AbstractTempTable.getMutableInfo* - a plain array can be kept for cases when the @LegacyFieldI...
Alexandru Lungu
11:12 AM Bug #7641 (Rejected): Lower the number of Map.get() calls in the persistence layer
Alexandru Lungu
10:23 AM Bug #7535: Temporary tables require trailing recid component even for unique indexes
Keys should be reclaimed at the end of each iteration and when the block finishes, they should not be reclaimed too e... Dănuț Filimon
09:22 AM Bug #7535: Temporary tables require trailing recid component even for unique indexes
Alexandru Lungu wrote:
> So what is the problem then? If @TemporaryBuffer.Context.commit@ is called:
> * is it call...
Dănuț Filimon
08:37 AM Bug #7535: Temporary tables require trailing recid component even for unique indexes
So what is the problem then? If @TemporaryBuffer.Context.commit@ is called:
* is it called at bad times? too late or...
Alexandru Lungu
08:14 AM Bug #7535: Temporary tables require trailing recid component even for unique indexes
Alexandru Lungu wrote:
> Note that @TemporaryBuffer.Context@ implements @Commitable@ and there is the whole reclaim ...
Dănuț Filimon
07:57 AM Bug #7535: Temporary tables require trailing recid component even for unique indexes
> TemporaryBuffer.commit() (method was commented) and RecordBuffer.rollback() (method was mostly commented)
Note t...
Alexandru Lungu
07:35 AM Bug #7535: Temporary tables require trailing recid component even for unique indexes
Alexandru Lungu wrote:
> *Please refactor the code in #7535-1 and identify where 2004 recid is reclaimed if there is...
Dănuț Filimon
09:15 AM Bug #7567 (WIP): use Session.PK instead of DatabaseManager.PRIMARY_KEY wherever possible
Alexandru Lungu

07/27/2023

03:59 PM Feature #4722: data import should be able to run with only the converted application jar file (an...
Ovidiu, were you able to duplicate my issue at all? I still cannot get the script to work.
I have a very quick pro...
Roger Borrello
09:16 AM Bug #7488: Slow fast-copy with before tables in H2
Do we really need the table names to be different at the database level? Why not reuse the same table and DMOs? It ... Greg Shah
09:03 AM Bug #7488: Slow fast-copy with before tables in H2
Greg Shah wrote:
> Perhaps they don't repeat because each time through a new dynamic tt is created (but it is really...
Alexandru Lungu
08:21 AM Bug #7535: Temporary tables require trailing recid component even for unique indexes
Danut, I don't think the changes are quite right. @autoCommit@ means:
* "yes": there is no active transaction (@do t...
Alexandru Lungu

07/26/2023

10:10 AM Feature #7382: Check performance of delete from vs drop table in H2
There are cases where the temp-table is not really multiplexed across the FWD session - only one 'instance' of this t... Constantin Asofiei
09:28 AM Bug #7454: Make ValueStringIgnoreCase the default generated value for setString in FWD-H2
*Committed 7454a_h2/rev.30 and testcases/rev.2383*.
* Character literals were modified to be @ValueStringIgnoreCase...
Dănuț Filimon
08:41 AM Bug #7454: Make ValueStringIgnoreCase the default generated value for setString in FWD-H2
Alexandru Lungu wrote:
> My point was to do a bit of refactoring on Functions to allow both IGNORECASE and CASESENSI...
Dănuț Filimon
04:02 AM Bug #7454: Make ValueStringIgnoreCase the default generated value for setString in FWD-H2
My point was to do a bit of refactoring on Functions to allow both IGNORECASE and CASESENSITIVE as parameters for suc... Alexandru Lungu
03:44 AM Bug #7454: Make ValueStringIgnoreCase the default generated value for setString in FWD-H2
Alexandru Lungu wrote:
> Danut, the following statements contradict:
> * @the UPPER function that returns Value.STR...
Dănuț Filimon
03:19 AM Bug #7454: Make ValueStringIgnoreCase the default generated value for setString in FWD-H2
Danut, the following statements contradict:
* @the UPPER function that returns Value.STRING_IGNORECASE;@: this theor...
Alexandru Lungu
09:11 AM Bug #7488: Slow fast-copy with before tables in H2
I fixed the line longer than 110 characters and removed the invalidation block. I changed updatePeerRecords so now it... Ștefan Roman
08:10 AM Bug #7488: Slow fast-copy with before tables in H2
> the most consuming ones are between static tables and dynamic tables - and these don't quite repeat.
It is a com...
Greg Shah
07:53 AM Bug #7488: Slow fast-copy with before tables in H2
Committed 7404a/rev. 14653. This resets the loose-copy flag if the loose property matching is the same as the same as... Alexandru Lungu
05:21 AM Bug #7488: Slow fast-copy with before tables in H2
Alexandru Lungu wrote:
> I will check next #7488-7: are there any copy operations that repeat (have the same source-...
Alexandru Lungu
04:29 AM Bug #7535: Temporary tables require trailing recid component even for unique indexes
Alexandru Lungu wrote:
> Lets make baby steps here. We need the recid reclaim be sound first. At that point, we shal...
Dănuț Filimon
04:12 AM Bug #7535: Temporary tables require trailing recid component even for unique indexes
Lets make baby steps here. We need the recid reclaim be sound first. At that point, we shall see how we can continue ... Alexandru Lungu
03:29 AM Bug #7421: Check only the indexes that were changed when using Validation.checkMaxIndexSize
I will redo the testing with *7421a/rev.14653* and @max-index-size@ set on 0. This will reduce the number of indexes ... Alexandru Lungu

07/25/2023

04:19 PM Feature #4722: data import should be able to run with only the converted application jar file (an...
The @registry.xml@ is not used with import. It may be opened as resource in common configuration, but its content is ... Ovidiu Maxiniuc
07:58 AM Feature #4722: data import should be able to run with only the converted application jar file (an...
Ovidiu Maxiniuc wrote:
> Roger, I used your jar and attempted to import a single table from your main database. It w...
Roger Borrello
10:31 PM Feature #4722: data import should be able to run with only the converted application jar file (an...
Roger, I used your jar and attempted to import a single table from your main database. It works. The jar is good, pro... Ovidiu Maxiniuc
09:26 PM Feature #4722: data import should be able to run with only the converted application jar file (an...
Roger, could you put your @app.jar@ in a shared folder on devsrv01. I would like to attempt to debug against it, to u... Ovidiu Maxiniuc
09:33 AM Bug #7454: Make ValueStringIgnoreCase the default generated value for setString in FWD-H2
Found an interesting example when experimenting with functions in H2.
Here is a simple table definition: @create t...
Dănuț Filimon
04:37 AM Bug #7454: Make ValueStringIgnoreCase the default generated value for setString in FWD-H2
Dănuț Filimon wrote:
> After testing a customer application, I noticed that there are instances of internal conversi...
Alexandru Lungu
04:23 AM Bug #7454: Make ValueStringIgnoreCase the default generated value for setString in FWD-H2
I looked into #7454-16, the change to the @Parser@ works properly since it has access to the database settings.
Af...
Dănuț Filimon
06:43 AM Bug #7488: Slow fast-copy with before tables in H2
Last minute notice: @updatePeerRecords@ doesn't use prepared statements, but generates plain SQL statements. *Stefan*... Alexandru Lungu
06:37 AM Bug #7488: Slow fast-copy with before tables in H2
|_. Simple copy |_. Append |_. Loose-copy |_. Extents |_. Before |_. Time |_. Count |_. Avg |_. Master Copy |_. Exten... Alexandru Lungu
04:15 AM Bug #7488: Slow fast-copy with before tables in H2
*Review of 7404a, revision 14652.*
* The lines you changed now exceed 110 characters. Consider extracting the last...
Alexandru Lungu

07/24/2023

10:00 AM Bug #7454: Make ValueStringIgnoreCase the default generated value for setString in FWD-H2
Profiling shows -0.3% improvement. this is decent, but can be way better. I expect way more improvement after we get ... Alexandru Lungu
08:51 AM Bug #7454 (WIP): Make ValueStringIgnoreCase the default generated value for setString in FWD-H2
Great!
I've added in rev. 29 the possibility to make sequences temporary. I just noticed that there are several at...
Alexandru Lungu
07:28 AM Bug #7454: Make ValueStringIgnoreCase the default generated value for setString in FWD-H2
Alexandru Lungu wrote:
> I found a regression while testing. I attempted a fix in 7454a_h2 / rev. 27. This has a wid...
Dănuț Filimon
05:53 AM Bug #7454: Make ValueStringIgnoreCase the default generated value for setString in FWD-H2
Also, Danut, please make the flag naming consistent with the option. Right now, the option is @DEFAULT_IGNORE_CASE@ a... Alexandru Lungu
05:39 AM Bug #7454: Make ValueStringIgnoreCase the default generated value for setString in FWD-H2
I found a regression while testing. I attempted a fix in 7454a_h2 / rev. 27. This has a wide impact on direct-access,... Alexandru Lungu
09:21 AM Feature #7061 (Closed): Enable the use of lazy result sets in H2
Greg Shah
03:21 AM Feature #7061: Enable the use of lazy result sets in H2
This can be closed. Alexandru Lungu
09:06 AM Bug #7535: Temporary tables require trailing recid component even for unique indexes
After investigating how the recid is reclaimed for temporary tables, I made a few changes to allow reclaiming only wh... Dănuț Filimon
06:52 AM Feature #6813: analyze and improve performance of dynamic conversion of temp-tables and queries
Eric Faulhaber wrote:
> What is left to do on this task? Can we update the % done to a value that reflects the true ...
Constantin Asofiei
04:55 AM Feature #7323: Implement soft unique index in FWD-H2
I think the numbers are quite relevant, so I will write them here:
|_. JMX |_. Before |_. After |
| Total | 29.91...
Alexandru Lungu
03:24 AM Feature #7504 (WIP): Export data tool from FWD into .d files
Alexandru Lungu

07/22/2023

08:09 AM Feature #4722: data import should be able to run with only the converted application jar file (an...
Ovidiu Maxiniuc wrote:
> To remove this, please add @data/standard.dict@ to your application jar. It is needed by dy...
Roger Borrello
09:08 PM Feature #4722: data import should be able to run with only the converted application jar file (an...
1. The log reports that @data/standard.dict@ could not be loaded as a resource from jar. Apparently, it was loaded fr... Ovidiu Maxiniuc
08:45 PM Bug #7421: Check only the indexes that were changed when using Validation.checkMaxIndexSize
Alexandru Lungu wrote:
> @checkMaxIndexSize@ is handling both SQL and 4GL limitations:
I know, I _might_ have writt...
Ovidiu Maxiniuc

07/21/2023

06:42 PM Feature #4722: data import should be able to run with only the converted application jar file (an...
Ovidiu Maxiniuc wrote:
> Roger,
> I see a few issues with the @java@ statement:
Thanks... corrected, although I'm ...
Roger Borrello
06:06 PM Feature #4722: data import should be able to run with only the converted application jar file (an...
Roger,
I see a few issues with the @java@ statement:
* you have a typo in @targetDb="postgresq"@ (final @l@ is miss...
Ovidiu Maxiniuc
03:45 PM Feature #4722: data import should be able to run with only the converted application jar file (an...
I should note that I didn't convert the application with @4722@, I am just trying to use the @p2j.jar@. Let me know i... Roger Borrello
03:41 PM Feature #4722: data import should be able to run with only the converted application jar file (an...
I had success building the DB with this command:... Roger Borrello
12:32 PM Feature #7061: Enable the use of lazy result sets in H2
Since this has since been merged to trunk, can we close this issue now? Eric Faulhaber
12:30 PM Bug #7235 (Closed): Avoid selecting all fields for an CAN-FIND sub-select
Eric Faulhaber
10:52 AM Bug #7235: Avoid selecting all fields for an CAN-FIND sub-select
Yes. Alexandru Lungu
10:44 AM Bug #7235: Avoid selecting all fields for an CAN-FIND sub-select
Can this be closed? Eric Faulhaber
11:13 AM Feature #7323: Implement soft unique index in FWD-H2
I tested with the JMX and everything is fine. The number of inserts / cures and failed cures is the same, good job.
...
Alexandru Lungu
10:51 AM Feature #7194 (Test): Avoid generating an ORDER-BY clause if not required
Eric Faulhaber wrote:
> What exactly does this mean? AFIACT, the changes have been integrated into FWD-H2, correct? ...
Alexandru Lungu
10:42 AM Feature #7194: Avoid generating an ORDER-BY clause if not required
Alexandru Lungu wrote:
> I will move this to review/100% just because everything is done already - this last step ...
Eric Faulhaber
10:49 AM Bug #7108 (Closed): Simulate upper/rtrim directly in H2 using case specific columns
Eric Faulhaber
10:36 AM Bug #7108: Simulate upper/rtrim directly in H2 using case specific columns
Yes Alexandru Lungu
10:35 AM Bug #7108: Simulate upper/rtrim directly in H2 using case specific columns
Can this be closed? Eric Faulhaber
10:38 AM Bug #7035 (Closed): Extract query parameters from statically converted FQL
Work on this task is complete for now, but based on the findings, we will not be integrating into trunk. Eric Faulhaber
10:30 AM Feature #6813: analyze and improve performance of dynamic conversion of temp-tables and queries
What is left to do on this task? Can we update the % done to a value that reflects the true status? Eric Faulhaber
08:58 AM Bug #7488: Slow fast-copy with before tables in H2
I added this first change. I tested with a small test and a client app and it works fine. Committed on 7404a, revisio... Ștefan Roman
07:24 AM Bug #7496: finish support for query:forward-only attribute
Alexandru Lungu wrote:
> Danut, please do your best to get this done asap. I intent to have it merged intro trunk by...
Dănuț Filimon
04:47 AM Bug #7421: Check only the indexes that were changed when using Validation.checkMaxIndexSize
> I just noticed that neither MariaDbLenientDialect nor MariaDbDialect override the implementation of Dialect.getInde... Alexandru Lungu
04:37 AM Bug #7421: Check only the indexes that were changed when using Validation.checkMaxIndexSize
> Note that 4GL has variable size even for data types which have fixed known static sizes. For example, an int64 may ... Alexandru Lungu
04:03 AM Bug #7535: Temporary tables require trailing recid component even for unique indexes
I think it is time for some digging :) As I said previously, lets start with the recid reclaiming process. Alexandru Lungu
03:53 AM Bug #7535: Temporary tables require trailing recid component even for unique indexes
Alexandru Lungu wrote:
> The patch was targeting only temp database, so it was clear that @pt@ tests won't be improv...
Dănuț Filimon
03:38 AM Bug #7535: Temporary tables require trailing recid component even for unique indexes
The patch was targeting only temp database, so it was clear that @pt@ tests won't be improved. Anyway, this means the... Alexandru Lungu
03:31 AM Bug #7535: Temporary tables require trailing recid component even for unique indexes
Alexandru Lungu wrote:
> Danut, can you extend the results from #7535-9 with the patch from #7373-35 (FWD-H2 1.22 an...
Dănuț Filimon
02:43 AM Bug #7535: Temporary tables require trailing recid component even for unique indexes
... Alexandru Lungu
02:42 AM Bug #7535: Temporary tables require trailing recid component even for unique indexes
Danut, can you extend the results from #7535-9 with the patch from #7373-35 (FWD-H2 1.22 and FWD-H2 1.24)? Alexandru Lungu
02:39 AM Bug #7185 (Test): H2 in-memory lazy hydration
I've got a +0.36% performance decrease, so the changes in 7185a can be dropped. At this point, the H2 modifications f... Alexandru Lungu

07/20/2023

03:13 PM Bug #7421: Check only the indexes that were changed when using Validation.checkMaxIndexSize
Dănuț Filimon wrote:
> @MariaDB@ enforces a limit of *3072* bytes.
> @PostgreSQL@ enforces a limit of *8191* bytes....
Ovidiu Maxiniuc
05:59 AM Bug #7421: Check only the indexes that were changed when using Validation.checkMaxIndexSize
At least for FWD-H2 we can skip the "check index size". In 4GL, temp-tables are subject to index size limitation, so ... Alexandru Lungu
05:21 AM Bug #7421: Check only the indexes that were changed when using Validation.checkMaxIndexSize
*Committed 7421a/rev.14653* Short-circuited indices when it is empty and removed redundant check on dirtyOffset. I al... Dănuț Filimon
02:51 AM Bug #7421: Check only the indexes that were changed when using Validation.checkMaxIndexSize
> I will do another profiling after this is completely optimized. Danut, please prepare of a full refactoring of chec... Alexandru Lungu
12:54 PM Feature #4722: data import should be able to run with only the converted application jar file (an...
I'd like to walk through the use of postgres Docker Official Image so as to discern any additional requirements for t... Roger Borrello
10:50 AM Bug #7535: Temporary tables require trailing recid component even for unique indexes
I wonder how many of these tests fail due to "bad recid reclaim" vs "bad LAZY iteration" not considering recid. I sug... Alexandru Lungu
08:59 AM Bug #7535: Temporary tables require trailing recid component even for unique indexes
Alexandru Lungu wrote:
> Danut, do you have any feedback on the change in #7535-3? According to your tests:
I test...
Dănuț Filimon
03:08 AM Bug #7535: Temporary tables require trailing recid component even for unique indexes
Danut, do you have any feedback on the change in #7535-3? According to your tests:
* Are there problems that occurs ...
Alexandru Lungu
10:49 AM Bug #7496: finish support for query:forward-only attribute
Danut, please do your best to get this done asap. I intent to have it merged intro trunk by the end of this week, so ... Alexandru Lungu
10:01 AM Feature #7323: Implement soft unique index in FWD-H2
Alexandru Lungu wrote:
> Also, please make a JMX over 7323a (without any validate changes) to check the same things....
Radu Apetrii
06:54 AM Feature #7323: Implement soft unique index in FWD-H2
*Good news*: this also passes the full-regression tests I use. The only concern now is the time - I will start a prof... Alexandru Lungu
05:54 AM Feature #7323: Implement soft unique index in FWD-H2
Tested with 7323a/rev. 14595 with a simple POC application and got no regression. I am planning to use the JMX you pr... Alexandru Lungu
04:42 AM Feature #7323: Implement soft unique index in FWD-H2
I've refactored the logging process when handling a @SQLException@ in an INSERT/UPDATE. Instead of only checking the ... Radu Apetrii
08:16 AM Bug #7185: H2 in-memory lazy hydration
Rebased 7185a to latest trunk. Branch is now at rev. 14671.
Regression testing passes successfully.
Started profili...
Alexandru Lungu
06:03 AM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...
I have merged the testcases 4514a branch repo revisions 1454 to 1456 into the testcases repo bzr+ssh://xfer.goldencod... Maciej Zieniuk

07/19/2023

04:23 PM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...
Some additional context on the testcases 4514a repo, all revisions (1454 to 1456) are safe to put into testcases repo... Maciej Zieniuk
03:43 PM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...
I lot have changed in fwd trunk and testcaseses repos since i last worked on this, some of my comments may be inacurr... Maciej Zieniuk
02:56 PM Bug #7421: Check only the indexes that were changed when using Validation.checkMaxIndexSize
AFAIR, we are always doing the "legacy" max index size check (i.e., the one that enforces a Progress database limit),... Eric Faulhaber
11:33 AM Bug #7421 (WIP): Check only the indexes that were changed when using Validation.checkMaxIndexSize
*Good news*: Testing shows no regression. Profiling shows some improvement, currently -0.8%. However, I am not quite ... Alexandru Lungu
12:25 PM Feature #4722: data import should be able to run with only the converted application jar file (an...
OK, I will investigate how the @ScriptRunner@ can be exactly used to run those scripts. Ovidiu Maxiniuc
11:46 AM Feature #4722: data import should be able to run with only the converted application jar file (an...
We should not have to place anything in the file system including @ddl/@. Let's work toward everything coming from t... Greg Shah
11:37 AM Feature #4722: data import should be able to run with only the converted application jar file (an...
I was talking only about the import, with the database created and schema installed.
The file local @ddl/@ (this i...
Ovidiu Maxiniuc
11:24 AM Feature #4722: data import should be able to run with only the converted application jar file (an...
Ovidiu Maxiniuc wrote:
> ... in a directory which lacked all other conversion artifacts, except: application, p2j an...
Constantin Asofiei
11:22 AM Feature #4722: data import should be able to run with only the converted application jar file (an...
The problem comes from the fact that the paths for .df file is configurable (for each namespace independently). The c... Ovidiu Maxiniuc
10:26 AM Feature #4722: data import should be able to run with only the converted application jar file (an...
I see little reason to work from the file system instead of the jar. Any processing from the jar, should be highly s... Greg Shah
10:46 AM Bug #7496: finish support for query:forward-only attribute
That is great - please ensure that #7496-18 still holds after refactoring. Also, do some skim debugging on more compl... Alexandru Lungu
09:48 AM Bug #7496: finish support for query:forward-only attribute
Alexandru Lungu wrote:
> Danut, please check what happens if you actually do @first@, @prev@ or @last@ when type-for...
Dănuț Filimon
07:08 AM Bug #7496: finish support for query:forward-only attribute
Danut, please check what happens if you actually do @first@, @prev@ or @last@ when type-forward only is set (in 4GL a... Alexandru Lungu
07:07 AM Feature #7323: Implement soft unique index in FWD-H2
I've analyzed the problem a bit and it seems that those @Unique index or primary key violation@ appear because the fi... Radu Apetrii

07/18/2023

04:42 PM Bug #7474: FindQuery provides the wrong result because the record is not updated in the database
I also had some thoughts on performance. Ideally, we should delay the flush as long as possible, as long as the queri... Ovidiu Maxiniuc
02:20 AM Bug #7474: FindQuery provides the wrong result because the record is not updated in the database
Ovidiu Maxiniuc wrote:
> Isn't this the same issue as #7373?
>
> As noted in my #7373-35 the problem can apparent...
Alexandru Lungu
04:30 PM Feature #4722: data import should be able to run with only the converted application jar file (an...
Greg Shah wrote:
> Ovidiu: Is there anything else needed?
Roger raised the problem of some kind of defaulting fro...
Ovidiu Maxiniuc
04:04 PM Feature #4722 (Review): data import should be able to run with only the converted application jar...
Eric: Please review.
Ovidiu: Is there anything else needed?
Greg Shah
04:01 PM Feature #4722: data import should be able to run with only the converted application jar file (an...
Branch 4722a should help you do just that. It adds the @import.xml@ script to @p2j.jar@ and allows additional files t... Ovidiu Maxiniuc
09:10 AM Feature #4722: data import should be able to run with only the converted application jar file (an...
What do I need to do for the data import to work with all the artifacts in the .jar files, so they are read from the ... Constantin Asofiei
02:18 PM Bug #7388 (Test): Create server configuration container for cache sizes
Greg Shah
10:39 AM Bug #7421: Check only the indexes that were changed when using Validation.checkMaxIndexSize
I am OK with the changes in 7421a/rev.14652.
Planning to test and profile them asap.
Alexandru Lungu
10:17 AM Bug #7488: Slow fast-copy with before tables in H2
Well, there are some bits of code using strings. Even the signature match does some string comparisons. The SQL compo... Alexandru Lungu
08:45 AM Bug #7488: Slow fast-copy with before tables in H2
Isn't there some string comparison overhead in calculating the field name mappings? Greg Shah
08:18 AM Bug #7488: Slow fast-copy with before tables in H2
> do you mean if we reuse the copying plan across copy-temp-table statements? So if two tables are part of a copy pro... Greg Shah
08:05 AM Bug #7488: Slow fast-copy with before tables in H2
I like the "copying plan" terminology :) This is accurate. We keep a database level mapping on the keys (source to de... Alexandru Lungu
07:54 AM Bug #7488: Slow fast-copy with before tables in H2
When we copy between any 2 given DMOs, do we save and reuse all the work we do to figure out the "copying plan"? Greg Shah
07:23 AM Bug #7488: Slow fast-copy with before tables in H2
Alright; please go ahead with a commit in this sense to 7404a Alexandru Lungu
03:44 AM Bug #7488: Slow fast-copy with before tables in H2
After some investigations, @FastCopyHelper.updatePeerRecords@ is not exactly the bottle-neck. When using fast-copy wi... Ștefan Roman
09:03 AM Feature #7323: Implement soft unique index in FWD-H2
Radu, this is something that triggered the error, but note that the code is only a cut-down, so you will need to set ... Alexandru Lungu
04:52 AM Feature #7323: Implement soft unique index in FWD-H2
Alexandru Lungu wrote:
> I will do my best to attempt extracting a test-case for you, but I can't guarantee I can ge...
Radu Apetrii
08:22 AM Bug #7535: Temporary tables require trailing recid component even for unique indexes
Alexandru Lungu wrote:
> Danut, please make a full test suite with text output with temp tables and persistent table...
Dănuț Filimon
03:30 AM Bug #7496: finish support for query:forward-only attribute
*Review of 7496a*
* I don't think @setScrolling@ should be called when calling @setForwardOnly@. This will make al...
Alexandru Lungu

07/17/2023

03:04 PM Bug #7535: Temporary tables require trailing recid component even for unique indexes
In fact, I was thinking first of 4GL side, to see whether strange issues occur. Ovidiu Maxiniuc
12:26 PM Bug #7467 (Test): join on meta table
7467a was merged into trunk as r14658. The branch was archived. Ovidiu Maxiniuc
11:21 AM Bug #7467: join on meta table
Please go ahead with the merge, after 6976a. Greg Shah
10:51 AM Bug #7467: join on meta table
Eric Faulhaber wrote:
> Is there any reason to keep this task in review status, if these regressions are not related...
Constantin Asofiei
02:25 AM Bug #7467: join on meta table
Constantin Asofiei wrote:
> Ovidiu Maxiniuc wrote:
> > Constantin, is it OK for you to run a quick ETF test on this...
Eric Faulhaber
10:21 AM Bug #7474: FindQuery provides the wrong result because the record is not updated in the database
Isn't this the same issue as #7373?
As noted in my #7373-35 the problem can apparently (it did for that testcase, ...
Ovidiu Maxiniuc
03:21 AM Bug #7474: FindQuery provides the wrong result because the record is not updated in the database
I feel this vulnerability we have here is quite concerning as it might generate inconsistent data from @_temp@. There... Alexandru Lungu
10:07 AM Bug #7496: finish support for query:forward-only attribute
Alexandru Lungu wrote:
> I think that we can't rely on @QueryWrapper@ to properly do the propagation in the delegate...
Dănuț Filimon
05:44 AM Bug #7496 (WIP): finish support for query:forward-only attribute
Danut, I think the following code is quite interesting:... Alexandru Lungu
04:58 AM Bug #7496: finish support for query:forward-only attribute
*Committed 7496a/rev.14653*. Quick changes made based on the #7496-12 review. Similar to @PreselectQuery@, I removed ... Dănuț Filimon
04:33 AM Bug #7496 (Review): finish support for query:forward-only attribute
*Review of 7496a*
* We still need support for @forwardOnly@ in lazy @AdaptiveQuery@. Therefore, it is fine to exec...
Alexandru Lungu
08:43 AM Bug #7567: use Session.PK instead of DatabaseManager.PRIMARY_KEY wherever possible
This should also be extended to FWD-H2 direct-access, as it presumes that the primary key column is always named @rec... Alexandru Lungu
02:38 AM Bug #7567: use Session.PK instead of DatabaseManager.PRIMARY_KEY wherever possible
@Session.PK@ was introduced during our ORM refactoring (when we removed Hibernate from FWD), to represent the configu... Eric Faulhaber
02:27 AM Bug #7567 (WIP): use Session.PK instead of DatabaseManager.PRIMARY_KEY wherever possible
Eric Faulhaber
07:57 AM Feature #7323: Implement soft unique index in FWD-H2
Radu, I tested 7323a and I still have @Unique index or primary key violation@ (lots). I've debugged a bit and I've se... Alexandru Lungu
04:22 AM Feature #7416: Reiterate DatabaseStatistics and leverage to other database profling tools
Radu, I just encountered the following in @Persistence@:... Alexandru Lungu
 

Also available in: Atom