Activity
From 04/29/2025 to 05/28/2025
05/28/2025
- 01:26 PM Feature #9456: implement SQL Server dialect and helpers
- To the list above I need to add another bullet:
* MSSQL does not allow multiple @null@ in unique indexes.
The solut... - 12:16 PM Feature #7504: Export data tool from FWD into .d files
- I had a look at r15908 of 7504b.
I noticed that the @main()@ method in @ExportWorker@ lacks the javadoc.
Also, ... - 07:22 AM Feature #7504: Export data tool from FWD into .d files
- Ovidiu Maxiniuc wrote:
> When I did the capture, I only looked up the occurrences, but did not do any further resear... - 10:05 AM Bug #10049 (Test): UDF configuration regression in Persistence.java
- Branch 10049a was merged into trunk as rev. 15946 and archived.
- 08:50 AM Bug #10049 (Merge Pending): UDF configuration regression in Persistence.java
- Please merge 10049a now.
- 03:10 AM Bug #9763 (Test): xml-node-name buffer option
- 9763b was merged to trunk rev. 15942 and archived.
- 03:00 AM Bug #9763 (Merge Pending): xml-node-name buffer option
- Eduard, you can merge 9763b now.
05/27/2025
- 03:53 PM Bug #10049: UDF configuration regression in Persistence.java
- *There is no new UDF added. Only a small runtime change.*
As noted in first note, the problem was an incorrect det... - 03:40 PM Bug #10049: UDF configuration regression in Persistence.java
- This is only a runtime change, with no new UDF installation (or other special handling/configuration or devops) requi...
- 03:18 PM Bug #10049: UDF configuration regression in Persistence.java
- The aforementioned test passed.
- 12:24 PM Feature #7504: Export data tool from FWD into .d files
- OK, you mentioned only 2 occurrences, but I knew that there are more calls of the method from the base class.
When... - 02:49 AM Feature #7504: Export data tool from FWD into .d files
- Ovidiu Maxiniuc wrote:
> I'm also on Idea and I see 35 of them. Maybe you have a filter of some kind?
> I cannot ex... - 09:55 AM Bug #9763: xml-node-name buffer option
- No, everything seems correct now.
- 06:00 AM Bug #9763: xml-node-name buffer option
- Review for 9763b rev 15950:
* BufferImpl - missing history number
* RecordBuffer - no actual change, use 'bzr rever... - 02:56 AM Feature #7020: always use "expanded" extent fields
- 7020d was rebased to latest trunk (rev. 15941) and it's now at revision 15959.
05/26/2025
- 05:37 PM Feature #9456: implement SQL Server dialect and helpers
- With my latest changes from 9456a, I was able to convert and import the @hotel@ database into a MS SQL Server instanc...
- 03:58 PM Bug #10049 (Internal Test): UDF configuration regression in Persistence.java
- OK, then I am putting this to the test.
This area is accessed each time a @Persistence@ object is initialized. The... - 02:22 PM Bug #10049: UDF configuration regression in Persistence.java
- I'm OK with the changes.
- 01:34 PM Bug #10049 (Review): UDF configuration regression in Persistence.java
- Constantin, please review the fix since it is a bit different (I rewrote 4 lines to be more human readable) than what...
- 01:32 PM Bug #10049 (Internal Test): UDF configuration regression in Persistence.java
- Constantin noticed a flaw in the configuration of UDF (SQL native vs deprecated Java). Just by chance, I identified t...
- 01:17 PM Bug #10049 (Test): UDF configuration regression in Persistence.java
- 12:15 PM Bug #9763: xml-node-name buffer option
- Fixed rebase issues in rev. 15950. Is additional testing necessary?
- 10:55 AM Bug #9763: xml-node-name buffer option
- I had one more quick look over 9763b, r15949.
In @BufferImpl.java@, I think there is a rebase error, @** 139 ES 2... - 08:19 AM Bug #9763: xml-node-name buffer option
- Eduard Soltan wrote:
> Yes it the 9763b branch, I run 9763b @bzr push --overwrite ~/secure/code/p2j_repo/p2j/active/... - 08:07 AM Bug #9763: xml-node-name buffer option
- Ovidiu Maxiniuc wrote:
> Do you mean 9763b? The current revision is 15835. Is it possible you pushed to different br... - 08:03 AM Bug #9763: xml-node-name buffer option
- Do you mean 9763b? The current revision is 15835. Is it possible you pushed to different branch?
- 07:58 AM Bug #9763: xml-node-name buffer option
- Rebased to latest trunk, *rev. 15937*. Did some quick smoke testing and unit tests of a large GUI application and it ...
- 11:14 AM Feature #7504: Export data tool from FWD into .d files
- I'm also on Idea and I see 35 of them. Maybe you have a filter of some kind?
I cannot export this list so I attached... - 08:16 AM Feature #7504: Export data tool from FWD into .d files
- I've reviewed the usages of @toStringExport()@:
* Within the @raw@ class: it's only used in @toString()@, which can ... - 07:56 AM Feature #7504: Export data tool from FWD into .d files
- +Review of 7504b / r15907+
I think there might be some issues with current changes from @raw@ class. The problem i... - 07:28 AM Feature #7504: Export data tool from FWD into .d files
- Ovidiu Maxiniuc wrote:
> +Review of 7504b / r15906+
>
> * @raw.java@: The problem is that the @toStringExport()@ ... - 05:23 AM Feature #9543 (Test): implement missing BUFFER attributes
- 9543b was merged to trunk 15936 and archived.
- 04:43 AM Feature #9543 (Merge Pending): implement missing BUFFER attributes
- Please merge 9543b after 10027a
- 01:32 AM Feature #9543: implement missing BUFFER attributes
- Ovidiu Maxiniuc wrote:
> I think the update is safe.
>
> But, before the merge into trunk, please add the followi...
05/23/2025
- 04:06 PM Feature #9543: implement missing BUFFER attributes
- I think the update is safe.
But, before the merge into trunk, please add the following changes (no code affected, ... - 05:30 AM Feature #9543: implement missing BUFFER attributes
- Some additional testing should be performed or it could merged to trunk?
- 12:34 AM Feature #9543: implement missing BUFFER attributes
- Summary of the testing performed:
- unit tests and smoke tests of large GUI appplication ✅
- smoke tests of a ... - 03:02 PM Feature #7504: Export data tool from FWD into .d files
- +Review of 7504b / r15906+
Good job. Just some minor issues:
* @Record.java@:2099: a space is required after @if@... - 07:32 AM Feature #7504: Export data tool from FWD into .d files
- Thanks for the review, Ovidiu.
Sorry for the formatting issues, i've addressed all of them in rev @15906@.
> * ... - 12:40 PM Feature #7020: always use "expanded" extent fields
- Roger Borrello wrote:
> Will the addition of this parameter in @p2j.cfg.xml@ break conversion if #7020 fix is not in... - 12:37 PM Feature #7020: always use "expanded" extent fields
- Stefanel Pezamosca wrote:
> Yes, that's correct.
Thanks. I have this in the @p2j.cfg.xml@ I will check into the p... - 12:28 PM Feature #7020: always use "expanded" extent fields
- Roger Borrello wrote:
> Stefanel Pezamosca wrote:
> > The thing changed in 7020d is the @denorm-extents@ from @p2j.... - 12:23 PM Feature #7020: always use "expanded" extent fields
- Stefanel Pezamosca wrote:
> The thing changed in 7020d is the @denorm-extents@ from @p2j.cfg.xml@ that was renamed w... - 11:15 AM Feature #7020: always use "expanded" extent fields
- Alexandru Lungu wrote:
> > Does 7020d remove normalized extent support completely? If so, then we have to resolve #7... - 10:51 AM Feature #7020: always use "expanded" extent fields
- Greg Shah wrote:
> Is there any reason to hold back 9537a? Has it been tested enough?
Yes 9537a has been tested an... - 10:27 AM Feature #7020: always use "expanded" extent fields
- > Does 7020d remove normalized extent support completely? If so, then we have to resolve #7020-122 before we merge. O...
- 09:10 AM Feature #7020: always use "expanded" extent fields
- Greg Shah wrote:
> > I think such process should be documented and create a task per customer (for us to test).
>
... - 09:07 AM Feature #7020: always use "expanded" extent fields
- > I think such process should be documented and create a task per customer (for us to test).
Agreed.
It is my u... - 08:38 AM Feature #7020: always use "expanded" extent fields
- > Are there any other tests that should be done for 7020d?
Stefanel, from my understanding, 7020d is making any sc...
05/22/2025
- 02:48 PM Feature #7504: Export data tool from FWD into .d files
- +Review of 7504b / r15905+
It seems pretty advanced to me. None of the next issues are really serious, but they sh... - 09:25 AM Feature #7504 (Review): Export data tool from FWD into .d files
- I have committed my changes to @7504b / rev 15905@.
Ovidiu, when you have a moment, could you please take a look? ... - 10:02 AM Bug #10026: A multi-table AdaptiveQuery running off-end is still updating the cursor
- I made a testcase: {{Collapse(See testcase)...
- 03:33 AM Bug #9994 (Feedback): Err: Cannot run GET methods on query until it is opened.
05/21/2025
- 01:28 PM Feature #7504: Export data tool from FWD into .d files
- While exporting data from a tenant database i found this error when reading a datetimetz value from the database
<pr... - 05:27 AM Feature #7504: Export data tool from FWD into .d files
- Yes.
That's the *size of the payload*. In other words, *the offset at which the the footer starts* (the file offset ... - 04:00 AM Feature #7504: Export data tool from FWD into .d files
- The implementation is nearly complete; however, I still need some information regarding the PSC footer....
- 10:09 AM Bug #10026: A multi-table AdaptiveQuery running off-end is still updating the cursor
- > Do you have an example/testcase that shows this? At the moment I don't understand how this case should look like su...
- 09:58 AM Bug #10026: A multi-table AdaptiveQuery running off-end is still updating the cursor
- Alexandru Lungu wrote:
> * Extra: please check in OE what happens if buffers are loaded with something else before a... - 04:58 AM Bug #10026 (WIP): A multi-table AdaptiveQuery running off-end is still updating the cursor
- 04:45 AM Bug #10026: A multi-table AdaptiveQuery running off-end is still updating the cursor
- From #10000:
> First and foremost, there is Eduard's change in trunk rev. 15701 where buffers from components 2 on... - 04:28 AM Bug #10026 (WIP): A multi-table AdaptiveQuery running off-end is still updating the cursor
- 09:50 AM Feature #9543: implement missing BUFFER attributes
- Unit tests and fwd tests of large application passed. An issue was reported there but it seems that it was a problem ...
- 08:04 AM Feature #9440: get-codepage() function should work with CLOB fields
- Commited revision *1758* on *testcases*.
Commited revision *15913* on P2J branch *9440a*. - 05:40 AM Feature #9440: get-codepage() function should work with CLOB fields
- Teodor Gorghe wrote:
> When using @get-codepage(buffer ttTable::fInt)@, on OpenEdge, it does not throw any error. Th... - 05:11 AM Feature #9440: get-codepage() function should work with CLOB fields
- When using @get-codepage(buffer ttTable::fInt)@, on OpenEdge, it does not throw any error. The returned value is @?@....
- 03:25 AM Feature #9440: get-codepage() function should work with CLOB fields
- Please expand the test to also use @get-codepage(buffer ttTable::fClob)@ (i.e. the POLY case which should convert to ...
- 03:23 AM Feature #9440: get-codepage() function should work with CLOB fields
- I modified the @/tests/base_language/builtin_functions/functionality/TestGetCodepage.cls@ to use @SESSION:CPINTERNAL@...
- 03:16 AM Feature #9440: get-codepage() function should work with CLOB fields
- I'm OK with the changes in rev 15912.
What standalone tests did you use for this? - 03:59 AM Feature #7020: always use "expanded" extent fields
- Task branch 7020d was rebased to trunk revision 15922.
7020d is now at revision 15940.
Are there any other tests... - 02:43 AM Bug #9969 (WIP): Parsing query string error with \r character.
- Reverted rev *15910* and rev *15900* from trunk in *15920*.
05/20/2025
- 11:37 AM Feature #7020: always use "expanded" extent fields
- Cool. I presumed that, but needed a confirmation.
- 09:51 AM Feature #7020: always use "expanded" extent fields
- Ovidiu Maxiniuc wrote:
> If I am not mistaken, in the case of the GUI project with harness test, the application is ... - 09:39 AM Feature #7020: always use "expanded" extent fields
- Nice catch!
The changes in 7020d, r15920 are good.
If I am not mistaken, in the case of the GUI project with harn... - 07:35 AM Feature #7020: always use "expanded" extent fields
- Lorian helped me test 7020d on his project. During the tests, we discovered an issue related to the SQL generation fo...
- 06:06 AM Bug #9016 (Review): Improve performance in FQLPreprocessor by using astCache
- Committed 9016a/15919. Added astCache to FQLPreprocessor().
Alexandru, please review. - 06:06 AM Bug #9016 (WIP): Improve performance in FQLPreprocessor by using astCache
- Had a discussion with Artur and this task was mentioned. However, this might not improve the performance in his scena...
- 05:43 AM Feature #9440: get-codepage() function should work with CLOB fields
- Commited revision 15912 on branch 9440a.
Replaced @new character()@ with @character.UNKNOWN@ on @longchar.getCodePag... - 03:03 AM Bug #9994: Err: Cannot run GET methods on query until it is opened.
- From my POV, I suggest waiting until we receive a clear response from the customer, as the original task is currently...
- 02:03 AM Bug #9994: Err: Cannot run GET methods on query until it is opened.
- Since this task doesn't reflect the actual issue discovered in 9810-100, I think it should be marked as Rejected at t...
05/19/2025
- 09:31 AM Feature #7504: Export data tool from FWD into .d files
- Create a new task for the import bug.
- 09:26 AM Feature #7504: Export data tool from FWD into .d files
- Lorian Sandu wrote:
> Greg Shah wrote:
> > > After import, the stored value in the database was @1919-12-31@ (disre... - 08:03 AM Feature #9440: get-codepage() function should work with CLOB fields
- Commited revision 15911 on branch 9440a.
I changed the @builtin_functions.rules@, with the changes you provided. In ... - 07:29 AM Feature #9440: get-codepage() function should work with CLOB fields
- Review of 15910 rev 9440a:
* this must nest the @rule@s (like if/then/(if/then/else)/else); currently is is (if/then... - 07:22 AM Feature #9440 (Review): get-codepage() function should work with CLOB fields
- 07:22 AM Feature #9440: get-codepage() function should work with CLOB fields
- Commited revision 15910 on branch 9440a, with the changes according to the latest code review.
- 03:31 AM Feature #9440 (WIP): get-codepage() function should work with CLOB fields
- Teodor, review of 9440a rev 15909:
* @builtin_functions.rules@ - this code:... - 02:24 AM Feature #9440 (Review): get-codepage() function should work with CLOB fields
- 04:25 AM Bug #9937 (Test): buffer argument with different DMO than the parameter
- 9937a was merged to trunk rev. 15914 and archived.
- 04:04 AM Bug #9937 (Merge Pending): buffer argument with different DMO than the parameter
- Please merge 9937a now.
- 03:48 AM Bug #9937: buffer argument with different DMO than the parameter
- Testing of 2 customers applications went successful.
- 02:35 AM Bug #9969: Parsing query string error with \r character.
- Ovidiu Maxiniuc wrote:
> After upgrading to trunk 15913 (including 15910), the antlr build target results in a lot (...
05/16/2025
- 06:31 PM Bug #9969: Parsing query string error with \r character.
- After upgrading to trunk 15913 (including 15910), the antlr build target results in a lot (30+) of nondeterminism err...
- 10:04 AM Bug #9969: Parsing query string error with \r character.
- Constantin Asofiei wrote:
> I think we need to handle and escape all control characters - see https://www.ascii-code... - 10:00 AM Bug #9969: Parsing query string error with \r character.
- I think we need to handle and escape all control characters - see https://www.ascii-code.com/characters/control-chara...
- 09:55 AM Bug #9969: Parsing query string error with \r character.
- This is more related to #8027 than this task.
- 09:54 AM Bug #9969: Parsing query string error with \r character.
- Constantin Asofiei wrote:
> Octavian, I think there may be a problem. In a project there is a var defined like:
> ... - 09:43 AM Bug #9969: Parsing query string error with \r character.
- Octavian, I think there may be a problem. In a project there is a var defined like:...
- 06:57 AM Bug #9969 (Test): Parsing query string error with \r character.
- Branch *9969a* was merged into trunk as *rev. 15910* and archived.
- 06:33 AM Bug #9969 (Merge Pending): Parsing query string error with \r character.
- Please merge to trunk after 9834a.
- 03:16 AM Bug #9969: Parsing query string error with \r character.
- Conversion of appserver application completed successfully. The runtime is also working fine.
- 12:47 PM Feature #7020: always use "expanded" extent fields
- +Review of 7020d r15919+
I see nothing wrong with the new code. In fact, I slightly remember writing code similar ... - 07:34 AM Feature #7020: always use "expanded" extent fields
- Ovidiu, could you take a quick look at 7020d revision 15919?
- 09:46 AM Feature #9440: get-codepage() function should work with CLOB fields
- I did managed to get the testcases project setup done. Right now, TestGetCodepage.cls fails because the code page is ...
- 07:04 AM Feature #9440 (WIP): get-codepage() function should work with CLOB fields
- Commited revision 15909 on branch 9440a.
- Implemented a new method on I18nOps getCodePage(BaseDataType).
- Changed... - 08:40 AM Feature #7504: Export data tool from FWD into .d files
- Greg Shah wrote:
> > After import, the stored value in the database was @1919-12-31@ (disregarding the formatting), ... - 08:31 AM Feature #7504: Export data tool from FWD into .d files
- > After import, the stored value in the database was @1919-12-31@ (disregarding the formatting), which indicates the ...
- 08:26 AM Feature #7504: Export data tool from FWD into .d files
- I tested my current implementation by exporting data from a large database and comparing the newly generated @*.d@ fi...
- 06:39 AM Bug #9994: Err: Cannot run GET methods on query until it is opened.
- As Constantin pointed out in #9810-98, this error also occurs in OE in situations where a field is used but not defin...
- 06:13 AM Bug #9994: Err: Cannot run GET methods on query until it is opened.
- Okay, but this still doesn’t explain why a customer application fails with this exact error when running a query like...
- 05:52 AM Bug #9994: Err: Cannot run GET methods on query until it is opened.
- This could be the issue, as the @f3@ column is added manually and is not part of the @.df@. Additionally, the @f3@ pr...
- 05:48 AM Bug #9994: Err: Cannot run GET methods on query until it is opened.
- I’ve attached the .d and .df files. After importing them, please update the pt table in pgAdmin by adding a new colum...
- 05:38 AM Bug #9994: Err: Cannot run GET methods on query until it is opened.
- Paula Păstrăguș wrote:
> I m using rev *15907*. I'm still able to replicate the issue.
Please post the DB schema ... - 05:26 AM Bug #9994: Err: Cannot run GET methods on query until it is opened.
- It seems the browser I’m using is messing with the task info a bit :) Sorry for the inconvenience!
- 05:24 AM Bug #9994: Err: Cannot run GET methods on query until it is opened.
- I m using rev *15907*. I'm still able to replicate the issue.
- 05:02 AM Bug #9994: Err: Cannot run GET methods on query until it is opened.
- I don't get the error as in #9994-1, the query is parsed correctly on my side. Am I missing something? Paula, could y...
- 04:45 AM Bug #9994 (WIP): Err: Cannot run GET methods on query until it is opened.
- 04:45 AM Bug #9994: Err: Cannot run GET methods on query until it is opened.
- First observation: The error does not reproduce when using a temp-table.
This works:
{{Collapse(Temp-Table testcase... - 04:40 AM Bug #9994: Err: Cannot run GET methods on query until it is opened.
- Unfortunately, I think this is an urgent one. It makes a customer application freeze, and the logs are overly populat...
- 04:28 AM Bug #9994: Err: Cannot run GET methods on query until it is opened.
- Paula/Radu, please adjust the priority of this task accordingly.
- 05:29 AM Feature #9477: implement missing QUERY handle methods/attributes
- > REPOSITION-BACKWARDS (full/basic)
> REPOSITION-FORWARDS (full/basic)
AFAIK, these are both supported at convers...
05/15/2025
- 06:32 PM Feature #9543 (Internal Test): implement missing BUFFER attributes
- I looked at the changes of this last revision. I think they should work. A couple of notes:
* the @isBufferCopyDesti... - 05:38 PM Feature #9546: investigate and implement field options, if missing
- First, a disclaimer: there is little information about these attributes, including on progress.com. The statements be...
- 01:14 PM Feature #9546: investigate and implement field options, if missing
- Eric, these are from the .df, right?
Ovidiu: can you take a quick look at would need to be implemented? - 01:18 PM Feature #9477: implement missing QUERY handle methods/attributes
- Alexandru, do you have any insight about the reposition methods in the first note? I recall seeing mentions about rep...
- 11:34 AM Feature #9831: add admin API to set c3p0 configuration for individual tenant databases
- The concern is from Cloud Ops because they do not have access directly to the databases in production. On our local ...
- 11:23 AM Feature #9831: add admin API to set c3p0 configuration for individual tenant databases
- I am sorry for the trouble.
The SQL statements stand in notes 6 (for PgSQL) and 8 (for H2). I adjusted them by dro... - 10:18 AM Feature #9831: add admin API to set c3p0 configuration for individual tenant databases
- This was a breaking change for deployed environments because the upgrade of the landlord schema changes were not auto...
- 10:22 AM Bug #9994: Err: Cannot run GET methods on query until it is opened.
- This error is thrown when performing @GET-NEXT@ on a query like the following:
@for each pt where f3 = false and f... - 10:17 AM Bug #9994 (Rejected): Err: Cannot run GET methods on query until it is opened.
- 09:43 AM Feature #7504: Export data tool from FWD into .d files
- +Update on the Implementation+
* Successfully made the @ExportWorker@ runnable in offline mode using a lightweight... - 09:00 AM Bug #9969 (Internal Test): Parsing query string error with \r character.
- Yes, you're right.
- 08:19 AM Bug #9969: Parsing query string error with \r character.
- Shouldn't I wait for the appserver application conversion test results?
- 08:16 AM Bug #9969 (Merge Pending): Parsing query string error with \r character.
- You can merge to trunk now.
- 08:11 AM Bug #9969: Parsing query string error with \r character.
- Greg Shah wrote:
> > I used this testcase to see if the behavior is as expected:
> > [...]
> >
> > Converted cod... - 08:05 AM Bug #9969: Parsing query string error with \r character.
- > I used this testcase to see if the behavior is as expected:
> [...]
>
> Converted code with @unixEscapes@ on @t... - 07:51 AM Bug #9969: Parsing query string error with \r character.
- Eduard mentioned in #4602-50 that exception is not thrown anymore.
- 06:41 AM Bug #9969: Parsing query string error with \r character.
- The conversion of another large GUI customer application was successfully completed. No source code differences were ...
- 03:12 AM Bug #9969 (Internal Test): Parsing query string error with \r character.
- I've restarted the conversion regression testing plan with changes from *15904*:
* Conversion of large GUI customer ... - 08:17 AM Bug #9937: buffer argument with different DMO than the parameter
- Could 9937a be merge to trunk, or additional tests should be done?
- 05:48 AM Bug #9937: buffer argument with different DMO than the parameter
- Eduard Soltan wrote:
> Asked Danut to run ETF, we should have the results by tomorrow.
ETF tests passed. - 08:34 PM Feature #9456: implement SQL Server dialect and helpers
- A few weeks ago I created task branch 9456a for holding changes which would bring SQL Server dialect closer to all ot...
- 08:33 PM Feature #9455: port native user defined functions to SQL Server
- The goal of this task is to track the porting of native UDF functions for Microsoft SQL Server.
I already did par...
05/14/2025
- 04:25 PM Feature #9831: add admin API to set c3p0 configuration for individual tenant databases
- The @breakAfterAcquireFailure@ is no longer settable. It is always active (that is, its value is @true@).
For more d... - 10:39 AM Feature #9831: add admin API to set c3p0 configuration for individual tenant databases
- I wanted to confirm that the breakAfterAcquireFailure is no longer needed in the directory.xml and is now being force...
- 02:59 PM Feature #7504: Export data tool from FWD into .d files
- Isn't the @dumpName@ attribute of @@Table@ DMO annotation useful (4GL @DUMP-NAME@ attribute) and neither the field na...
- 02:21 PM Feature #7504: Export data tool from FWD into .d files
- Greg Shah wrote:
> > In OE the .d file stores the name of the *.blb file
>
> At a minimum we should use @blb@ and... - 02:19 PM Feature #7504: Export data tool from FWD into .d files
- The export isn't converted code and does not need to be executed using the FWD client. Writing the dump on the serv...
- 12:53 PM Feature #7504: Export data tool from FWD into .d files
- Eric Faulhaber wrote:
> Do the exported files need to be on the client? It seems like going through the legacy strea... - 12:47 PM Feature #7504: Export data tool from FWD into .d files
- Do the exported files need to be on the client? It seems like going through the legacy stream support will be a perfo...
- 11:06 AM Feature #7504: Export data tool from FWD into .d files
- > In OE the .d file stores the name of the *.blb file
At a minimum we should use @blb@ and @clb@ instead of @null@... - 10:51 AM Feature #7504: Export data tool from FWD into .d files
- Lorian Sandu wrote:
> When importing the database, we don't store the original name of the file at the dmo level, th... - 10:41 AM Feature #7504: Export data tool from FWD into .d files
- I've got a working version and managed to export the data from the database to @.d@ files.
A few things i want to di... - 08:51 AM Bug #9937: buffer argument with different DMO than the parameter
- Asked Danut to run ETF, we should have the results by tomorrow.
- 08:45 AM Bug #9937: buffer argument with different DMO than the parameter
- Eduard Soltan wrote:
> Constantin Asofiei wrote:
>
> > Please continue testing.
>
> Runtime for Chui regressio... - 08:38 AM Bug #9937: buffer argument with different DMO than the parameter
- Constantin Asofiei wrote:
> Please continue testing.
Runtime for Chui regression testing and unit tests of a la... - 08:35 AM Bug #9937 (Internal Test): buffer argument with different DMO than the parameter
- Eduard Soltan wrote:
> Changed @defineAlias@ and @makeArgumentBuffer@ to create a proxy without @plugin@. Committed ... - 05:07 AM Bug #9937: buffer argument with different DMO than the parameter
- Changed @defineAlias@ and @makeArgumentBuffer@ to create a proxy without @plugin@. Committed on #9937, rev. 15892.
... - 08:31 AM Feature #9543: implement missing BUFFER attributes
- Some improvements of @buffer-copy@ in batch mode are in 9543b, rev. 15894.
- 08:28 AM Feature #9543: implement missing BUFFER attributes
- Ovidiu Maxiniuc wrote:
> Review of 9543b, r15893.
>
> * @RecordBuffer.java@:
> ** line 2019: the field is missin... - 06:34 AM Feature #9543: implement missing BUFFER attributes
- Review of 9543b, r15893.
* @RecordBuffer.java@:
** line 2019: the field is missing the javadoc;
** lines 3650, 4... - 08:27 AM Feature #7020: always use "expanded" extent fields
- After the rebase with the latest trunk, I discovered another issue related with fields include/exclude functionality....
- 07:26 AM Bug #9969 (Review): Parsing query string error with \r character.
- I've reverted the changes from @character.java@ in *9969a/15904*. This double backslash gets an unescaped '\' charact...
- 06:36 AM Bug #9969 (WIP): Parsing query string error with \r character.
- 06:36 AM Bug #9969: Parsing query string error with \r character.
- The conversion of the ChUI regression test application completed successfully, but the source compilation failed. The...
- 03:06 AM Bug #9969: Parsing query string error with \r character.
- The conversion of a large GUI client application has been completed successfully. The conversion log is clean and the...
05/13/2025
- 07:05 PM Feature #9831 (Test): add admin API to set c3p0 configuration for individual tenant databases
- Branch 9831a was merged to trunk rev. 15905 and archived.
- 06:48 PM Feature #9831 (Merge Pending): add admin API to set c3p0 configuration for individual tenant data...
- The minor changes for #9988-12 look fine.
Please merge 9831a to trunk now. - 05:54 PM Feature #7504: Export data tool from FWD into .d files
- Lorian, I think you are on the right track:
* indeed, @DmoMeta.getFields()@ will give you the correct order of field... - 06:31 AM Feature #7504: Export data tool from FWD into .d files
- I have started working on the implementation.
Taking into consideration the discussion from the previous notes, i'... - 03:53 AM Feature #7504: Export data tool from FWD into .d files
- I am raising the priority to High.
Please make regular updates on this task on the progress. - 09:28 AM Feature #7020: always use "expanded" extent fields
- I attached an sql script that will help with renaming old extent word tables, indexes and dropping old triggers/trigg...
- 02:37 AM Feature #7020: always use "expanded" extent fields
- I have rebased 7020d to trunk revision 15902 and it's now at rev.15918.
- 08:07 AM Bug #9937 (Review): buffer argument with different DMO than the parameter
- With 9937a, rev. 15890.
Unit tests of a customer application and Chui regression testing project are passing withou... - 07:20 AM Bug #9969: Parsing query string error with \r character.
- This affects all string processing in the lexer in a profound way. Full conversion testing is needed.
- 06:59 AM Bug #9969: Parsing query string error with \r character.
- Is conversion regression tesing necessary or run-time testing is enough?
- 06:51 AM Bug #9969 (Internal Test): Parsing query string error with \r character.
- Code Review Task Branch 9969a Revisions 15901 through 15903
I'm OK with the changes. Let's get it tested across a... - 03:32 AM Bug #9969: Parsing query string error with \r character.
- Ovidiu Maxiniuc wrote:
> +Review of 9969a/r15902.+
>
> * @UnicodeTranslationException@: missing javadocs for both... - 03:14 AM Bug #9969: Parsing query string error with \r character.
- Ovidiu Maxiniuc wrote:
> +Review of 9969a/r15902.+
>
> * @progress.g@: My understanding is that the inlines for n... - 06:42 AM Bug #9318 (Review): Make record nursery visible on removeRecords
- *9318a* contains *conversion changes* for Buffer.delete() and *runtime changes*, the test plan is:
* ETF (ddf) - alr... - 06:36 AM Bug #9318: Make record nursery visible on removeRecords
- > I rebased 9381a to trunk/15894 a while ago and the branch is now at revision 9318a/15898.
Please move this into ... - 06:29 AM Bug #9318: Make record nursery visible on removeRecords
- I rebased *9381a* to *trunk/15894* a while ago and the branch is now at revision *9318a/15898*.
I also retested E... - 03:33 AM Feature #9543: implement missing BUFFER attributes
- Ovidiu Maxiniuc wrote:
> +Review of 9543b, r15892.+
>
> * @RecordBuffer.java@
> ** lines 1708, 1711, 2200: I do ...
05/12/2025
- 07:21 PM Feature #9976: eliminating DMO usage in inter-program linkage
- > For parameters, the buffers should not construct their own @BaseRecord@, but use the 'pointer' to one already creat...
- 06:27 PM Feature #9976: eliminating DMO usage in inter-program linkage
- Greg,
I am not sure I got all detail, in spite of being focused on the 1st not for some time now. It's clear we will... - 08:52 AM Feature #9976: eliminating DMO usage in inter-program linkage
- In the 4GL, there is no concept of a DMO. From the beginning (in the 1980s), the 4GL has always directly mapped comp...
- 03:57 PM Bug #9969: Parsing query string error with \r character.
- +Review of 9969a/r15902.+
* @UnicodeTranslationException@: missing javadocs for both the class and the constructor... - 10:38 AM Bug #9969 (Review): Parsing query string error with \r character.
- 10:36 AM Bug #9969: Parsing query string error with \r character.
- I made a few changes that fix the way Java escaping is handled. First, in @ClearStream.java@ sequences (with '\') are...
- 09:08 AM Bug #9969: Parsing query string error with \r character.
- Branch *9969a* was rebased with trunk. The new revision is *15901*.
- 04:20 AM Bug #9969: Parsing query string error with \r character.
- Greg wrote:
> Octavian Adrian Gavril wrote:
> > I investigated the issue. I think we can apply the "\r" processing ... - 10:47 AM Bug #9937: buffer argument with different DMO than the parameter
- I found a regression with 9937a changes related to extend fields.
For extend fields in @ProxyAssembler@ there are ... - 03:44 AM Bug #9937 (Internal Test): buffer argument with different DMO than the parameter
- Eduard Soltan wrote:
> Alexandru Lungu wrote:
> > Review of 9937a:
> > * @RecordBuffer.bufferProxy@ is a new stat... - 03:29 AM Bug #9937: buffer argument with different DMO than the parameter
- Alexandru Lungu wrote:
> Review of 9937a:
> * @RecordBuffer.bufferProxy@ is a new static method added with your ch... - 03:24 AM Bug #9937: buffer argument with different DMO than the parameter
- Alexandru Lungu wrote:
>If this is statically impossible, then I think I am fully OK with the changes.
From my te... - 03:06 AM Bug #9937: buffer argument with different DMO than the parameter
- Clear. This seems to be a case where we need to "disguise" a DMO as another DMO just to satisfy Java's strong type ch...
- 09:51 AM Bug #9683 (WIP): CompoundQuery is doing extra hydration attempts
- 09:51 AM Bug #9683: CompoundQuery is doing extra hydration attempts
- Review of 9683a:
* @implements@ should be aligned to @public@ (at 3 spaces from the start of the line).
* Typo in @... - 08:03 AM Feature #9543: implement missing BUFFER attributes
- +Review of 9543b, r15892.+
I think you are on the right track, but there are a couple of issues which should be ad... - 04:19 AM Feature #9543 (Review): implement missing BUFFER attributes
- It seems that CAN-READ attribute is no longer used in client application. So I will move this task in review.
- 07:26 AM Feature #7020: always use "expanded" extent fields
- We don't want to leave behind any traces of the old modes.
- 07:24 AM Feature #7020: always use "expanded" extent fields
- Apart from the situation described above, 7020d has been tested continuously with two projects I had on hand, but I w...
- 07:20 AM Feature #7020: always use "expanded" extent fields
- I have one last question:
With @denorm-extent@, @wordTableName@ was generated as @table__extname_1@ (since the field...
05/09/2025
- 05:06 PM Feature #9976 (New): eliminating DMO usage in inter-program linkage
- 04:17 PM Bug #9937: buffer argument with different DMO than the parameter
- Please look at the test case from #9937-5.
As you can see we have pretty similar temp-table definitions in
<pr... - 09:18 AM Bug #9937: buffer argument with different DMO than the parameter
- > Alexandru, can you take a look, too, at 9937a? This touches the ArgumentProxy which IIRC was added by you.
I see... - 08:06 AM Bug #9937: buffer argument with different DMO than the parameter
- Alexandru, can you take a look, too, at 9937a? This touches the @ArgumentProxy@ which IIRC was added by you.
- 07:09 AM Bug #9937 (Review): buffer argument with different DMO than the parameter
- 07:01 AM Bug #9937: buffer argument with different DMO than the parameter
- Constantin Asofiei wrote:
> Just to double-check, please do the same in @ctest@, but with the @btt2 for tt2@ buffer ... - 06:50 AM Bug #9937: buffer argument with different DMO than the parameter
- Just to double-check, please do the same in @ctest@, but with the @btt2 for tt2@ buffer (which will not use the @buff...
- 06:48 AM Bug #9937: buffer argument with different DMO than the parameter
- Constantin Asofiei wrote:
> Are the tests in #9937-5 passing, plus what we discussed in previous notes (copy-temp-ta... - 06:19 AM Bug #9937: buffer argument with different DMO than the parameter
- Eduard, the approach is good and it should work; your reasoning is correct, the temp-tables need to be schema-compati...
- 06:16 AM Bug #9937: buffer argument with different DMO than the parameter
- Eduard Soltan wrote:
> Could you take just a quick look at 9937a, rev. 15889?
The only problem that we are facing... - 06:03 AM Bug #9937: buffer argument with different DMO than the parameter
- Could you take just a quick look at 9937a, rev. 15889?
- 04:58 AM Bug #9937: buffer argument with different DMO than the parameter
- I checked and a single method will be created by the @ProxyAssembler@ for @Proxy3@ (@getF1@ and @setF1@), or any othe...
- 03:07 AM Bug #9937: buffer argument with different DMO than the parameter
- Constantin Asofiei wrote:
> I don't think is OK to have methods from both Tt2_1 and TT1_1 DMO interfaces.
Then we... - 02:55 AM Bug #9937: buffer argument with different DMO than the parameter
- I don't think is OK to have methods from both Tt2_1 and TT1_1 DMO interfaces.
I don't think @Proxy3@ should be ret... - 02:47 AM Bug #9937: buffer argument with different DMO than the parameter
- The proxy is a dynamic class created by @ProxyAssembler@ with the following structure:...
- 08:04 AM Bug #9950 (WIP): Upgrade the metadata schema to a newer version
- I noticed the following changes in the currently supported meta files (from DDL PoV):
* 10 (mandatory) columns added... - 06:28 AM Bug #9318: Make record nursery visible on removeRecords
- I've tested ETF conversion & runtime with 9318a and found no issues with the current implementation, I will rebase to...
- 04:44 AM Feature #7504: Export data tool from FWD into .d files
- Andrei, please commit whatever changes you've done for #7504 and introduce Lorian to this task.
- 03:23 AM Bug #9914 (Test): Investigate why ListenerSet implementation is not properly working
- Branch 9914a was merged into trunk as rev. 15893 and archived.
- 02:58 AM Bug #9914 (Merge Pending): Investigate why ListenerSet implementation is not properly working
- 9914a can be merged after 5471a.
- 02:57 AM Bug #9914: Investigate why ListenerSet implementation is not properly working
- Wonderful! I shall queue the branch up for merging.
- 02:51 AM Bug #9914: Investigate why ListenerSet implementation is not properly working
- > * ask Danut to run unit tests and fwdtests for the application he is managing
No issues found ✅
- 02:15 AM Bug #9683: CompoundQuery is doing extra hydration attempts
- Rebased on trunk rev 15891. Alexandru, could you please look at the last commits, I would like to move on with testin...
05/08/2025
- 09:14 AM Feature #9543: implement missing BUFFER attributes
- Committed on 9543b, rev. 15892. Added support for AUTO-SYNCHRONIZE attribute.
- 06:24 AM Feature #9543: implement missing BUFFER attributes
- Constantin Asofiei wrote:
> BTW, if buffer-copy fails validation, does synchronize still happen?
No. - 06:23 AM Feature #9543: implement missing BUFFER attributes
- Eduard Soltan wrote:
> Constantin Asofiei wrote:
> > Please also double-check the @ASSIGN@ statement if it trigger... - 06:09 AM Feature #9543: implement missing BUFFER attributes
- Constantin Asofiei wrote:...
- 04:53 AM Feature #9543: implement missing BUFFER attributes
- What happens if you do:...
- 04:51 AM Feature #9543: implement missing BUFFER attributes
- Constantin Asofiei wrote:
> Please also double-check the @ASSIGN@ statement if it triggers the synchronize or not. ... - 04:39 AM Feature #9543: implement missing BUFFER attributes
- Constantin Asofiei wrote:
> Please also double-check the @ASSIGN@ statement if it triggers the synchronize or not. ... - 03:37 AM Feature #9543: implement missing BUFFER attributes
- For @CAN-READ@ the only information I could find in the docs is:...
- 02:52 AM Feature #9543: implement missing BUFFER attributes
- Constantin Asofiei wrote:
> Please also double-check the @ASSIGN@ statement if it triggers the synchronize or not. ... - 02:32 AM Feature #9543: implement missing BUFFER attributes
- Please also double-check the @ASSIGN@ statement if it triggers the synchronize or not. If the @ASSIGN@ part of @BUFF...
- 01:48 AM Feature #9543: implement missing BUFFER attributes
- I created some tests for @buffer-copy@ as a method and @buffer-copy@ statement....
- 07:54 AM Bug #9318: Make record nursery visible on removeRecords
- Rebased *9318a* to latest *trunk/15891*, the branch is now at revision *15895*.
- 07:37 AM Bug #9914: Investigate why ListenerSet implementation is not properly working
- > * ask Lorian to run harness
Harness passed ✅ - 04:41 AM Bug #9914: Investigate why ListenerSet implementation is not properly working
- > I will run unit tests and smoke tests of large customer application.
Everything is OK here. - 04:24 AM Bug #9914: Investigate why ListenerSet implementation is not properly working
- * ChUI regression tests passed ✅
* Smoke-test for a large customer app passed ✅
* #9722 testing passed ✅
I think...
05/07/2025
- 04:20 PM Feature #9831 (Internal Test): add admin API to set c3p0 configuration for individual tenant data...
- > Meanwhile, I am putting the branch to the test using the the hotel, webGUI navigation and harness smoke-tests of a ...
- 03:31 PM Feature #9831: add admin API to set c3p0 configuration for individual tenant databases
- Ovidiu Maxiniuc wrote:
> Radu, please do a quick review when you have the time.
I think 9831a is alright. I don't s... - 01:57 PM Feature #9831: add admin API to set c3p0 configuration for individual tenant databases
- The @breakAfterAcquireFailure@ was removed from REST API and @landlord@ database.
The issues from note #9831-15 (th... - 09:26 AM Feature #9831: add admin API to set c3p0 configuration for individual tenant databases
- Please remove @breakAfterAcquireFailure@ from the REST API, since we hard-code this setting to @true@ in the runtime.
- 05:21 AM Feature #9831: add admin API to set c3p0 configuration for individual tenant databases
- I looked at the changes in 9831a, and I can say quite confidently that functionally they are safe. I don't think they...
- 03:36 PM Bug #9914: Investigate why ListenerSet implementation is not properly working
- ETF testing passed!
- 12:19 PM Feature #9543: implement missing BUFFER attributes
- For @BUFFER-COPY@, if the destination buffer has no loaded record, then it CREATE's a record in that buffer. So, ple...
- 12:16 PM Feature #9543: implement missing BUFFER attributes
- Constantin Asofiei wrote:
> Also, are there cases when @auto-synchronize@ is disabled temporarily, like for @save-ro... - 12:12 PM Feature #9543: implement missing BUFFER attributes
- Constantin Asofiei wrote:
> Can this be described in short, the synchronize is automatically called when the buffer'... - 12:10 PM Feature #9543: implement missing BUFFER attributes
- Constantin Asofiei wrote:
> Can this be described in short, the synchronize is automatically called when the buffer'... - 10:57 AM Feature #9543: implement missing BUFFER attributes
- Also, are there cases when @auto-synchronize@ is disabled temporarily, like for @save-row-changes@ or @fill@ method c...
- 10:56 AM Feature #9543: implement missing BUFFER attributes
- Can this be described in short, the synchronize is automatically called when the buffer's record is either loaded, re...
- 10:52 AM Feature #9543: implement missing BUFFER attributes
- Created a few test cases for behaviour of @AUTO-SYNCHRONIZE@ attributes....
- 10:11 AM Feature #9543: implement missing BUFFER attributes
- OK, so we already support @SYNCHRONIZE@ method via @Buffer.querySynchronize@ - so looks like we just need to call it ...
- 09:39 AM Feature #9543: implement missing BUFFER attributes
- According to the docs for AUTO-SYNCHRONIZE attribute and a in a book *OpenEdge Development: ProDataSets* by John Sadd...
- 07:19 AM Feature #9543 (WIP): implement missing BUFFER attributes
- Actually, this is back to WIP.
Eduard: did you get a chance to test how these attrs should behave at runtime? - 07:18 AM Feature #9543 (Test): implement missing BUFFER attributes
- 09:25 AM Bug #9969 (WIP): Parsing query string error with \r character.
- 09:20 AM Bug #9969: Parsing query string error with \r character.
- The escape sequences should include an additional '\' prefix. The current revision handles this only for '\u' within ...
- 08:53 AM Bug #9969: Parsing query string error with \r character.
- Alexandru Lungu wrote:
> Eduard, is @'bc\r'@ right? Shouldn't it be @'bc~r'@ to actually generate the CR?
It is e... - 08:51 AM Bug #9969: Parsing query string error with \r character.
- Please also see #9967, which is somehow related to the escape char used under linux.
- 08:48 AM Bug #9969: Parsing query string error with \r character.
- Eduard, is @'bc\r'@ right? Shouldn't it be @'bc~r'@ to actually generate the CR?
- 08:43 AM Bug #9969: Parsing query string error with \r character.
- Our preprocessor/lexer strips @'\r'@ characters in a naive way that needs to be refined.
- 08:21 AM Bug #9969: Parsing query string error with \r character.
- Alternatively this test case also reproduce the issues:...
- 08:06 AM Bug #9969: Parsing query string error with \r character.
- ...
- 08:02 AM Bug #9969 (WIP): Parsing query string error with \r character.
- 08:20 AM Bug #9950: Upgrade the metadata schema to a newer version
- Ovidiu, please get some preliminary changes in a branch, so we can patch 9457c and test FWD server startup.
- 05:37 AM Bug #9937: buffer argument with different DMO than the parameter
- I added my changes to 9937a rev. 15888.
When we have an ArgumentBuffer proxy, any direct field access (@btt1.getF1...
05/06/2025
- 10:07 AM Feature #9831: add admin API to set c3p0 configuration for individual tenant databases
- Radu,
I rebased and did a quick review of my own code, this revealed some small issues which were fixed.
You can ... - 09:03 AM Feature #9831: add admin API to set c3p0 configuration for individual tenant databases
- Ovidiu, is this ready to be reviewed? I see that it's been placed at 90%.
- 07:55 AM Feature #9831: add admin API to set c3p0 configuration for individual tenant databases
- Added Radu as reviewer.
- 07:37 AM Bug #9914 (Internal Test): Investigate why ListenerSet implementation is not properly working
- I am OK with the changes in 9914a.
However, we will need some extensive testing with it, eventually across multiple ... - 07:26 AM Bug #9937: buffer argument with different DMO than the parameter
- Constantin Asofiei wrote:
> Does this solve cases when the field is in an expression, copy-temp-table and others? B... - 05:23 AM Bug #9937: buffer argument with different DMO than the parameter
- Does this solve cases when the field is in an expression, copy-temp-table and others? Because @getDMOProxy();@ is us...
- 05:21 AM Bug #9937: buffer argument with different DMO than the parameter
- Constantin Asofiei wrote:
> I agree; but I'd like to solve this with the proxy, if possible; before committing to... - 02:15 AM Bug #9937: buffer argument with different DMO than the parameter
- Ovidiu Maxiniuc wrote:
> Yes, I am aware, as you quoted me, _"[...] which declare the @new shared@ tables and *simpl... - 07:10 AM Feature #7020: always use "expanded" extent fields
- I have rebased 7020d to trunk revision 15884 and it's now at 15900.
05/05/2025
- 04:19 PM Feature #7020 (Internal Test): always use "expanded" extent fields
- Branch 7020c (now r15866) is rebased but does not seem to have changes from the last time I reviewed it (old r15824)....
- 03:21 AM Feature #7020: always use "expanded" extent fields
- Ovidiu, please provide a review for #7020-131.
- 03:52 PM Bug #9937: buffer argument with different DMO than the parameter
- Yes, I am aware, as you quoted me, _"[...] which declare the @new shared@ tables and *simple TT*."_ I was merely expr...
- 01:48 PM Bug #9937: buffer argument with different DMO than the parameter
- Ovidiu Maxiniuc wrote:
> So I think that would be the right implementation: to remove these attributes (like @xml-no... - 01:29 PM Bug #9937: buffer argument with different DMO than the parameter
- I think we have discussed about an idea similar to Eduard's, some time ago.
Currently, the DMO of a @shared@ temp-... - 12:50 PM Bug #9937: buffer argument with different DMO than the parameter
- Eduard Soltan wrote:
> Question: Since we established in #9763 that @xml-node-name@ is a property specific to the bu... - 12:32 PM Bug #9937 (WIP): buffer argument with different DMO than the parameter
- 12:31 PM Bug #9937: buffer argument with different DMO than the parameter
- I will let out some of my findings.
h3. Structure of tt1 after TemporaryBuffer.define
After the call in @FooTes... - 04:04 AM Bug #9937: buffer argument with different DMO than the parameter
- Eduard, I've tried something like this to create the proxy:...
- 09:51 AM Bug #9965: Compound Query components not honoring the INCLUDE clause
- ...
- 09:44 AM Bug #9965 (New): Compound Query components not honoring the INCLUDE clause
04/30/2025
- 02:15 PM Feature #9831: add admin API to set c3p0 configuration for individual tenant databases
- Eric, please review.
I will rebase the branch since it is a bit behind the main trunk. - 02:33 AM Bug #9633: bulk delete for permanent tables
- Rebased *9633a* with trunk revision *15878*, new revision is *15880*.
Also available in: Atom