Activity
From 08/11/2025 to 09/09/2025
09/09/2025
- 06:46 PM Feature #6256: improved profile support
- What I gather from your comments is that the multi-profile configuration of the application I'm talking about is OK t...
- 07:35 AM Bug #6738: incremental conversion when deleting program or class files
- Since *6083a* contains changes for 3 tasks (#6083, #7793, #6738), the test plan should be done in the following order...
- 07:26 AM Bug #6738 (Internal Test): incremental conversion when deleting program or class files
- 07:26 AM Bug #6738: incremental conversion when deleting program or class files
- Code Review Task Branch 6083a Revisions 16158
I'm good with the change. - 07:17 AM Bug #6738: incremental conversion when deleting program or class files
- Greg Shah wrote:
> > How should I look for the name_map.xml in the jar if the expected path is @./cvt/name_map.xml@?... - 07:10 AM Bug #6738: incremental conversion when deleting program or class files
- > How should I look for the name_map.xml in the jar if the expected path is @./cvt/name_map.xml@?
What I'm saying ... - 07:02 AM Bug #6738: incremental conversion when deleting program or class files
- I think this needs a change to @SourceNameMapper.NAME_MAP_FILE_PATH@, assigning @Configuration.DEF_NAME_MAP_FILE@ ins...
- 06:58 AM Bug #6738: incremental conversion when deleting program or class files
- Greg Shah wrote:
> Code Review Task Branch 6083a Revisions 16156 and 16157
>
> The changes are fine except I don'... - 06:47 AM Bug #6738: incremental conversion when deleting program or class files
- Code Review Task Branch 6083a Revisions 16156 and 16157
The changes are fine except I don't think we want to have ... - 05:58 AM Bug #6738: incremental conversion when deleting program or class files
- Committed *6083a/16157*. Added a default value for the name-map parameter, it can also be used in the rules.
- 07:08 AM Feature #6319: IntelliJ plugin
- > With the last IntelliJ update *(2025.2)*, the LSP API is now available to all IDEA users. In other words, we can no...
- 06:55 AM Feature #6319: IntelliJ plugin
- Florin Eugen Rotaru wrote:
> With the last IntelliJ update *(2025.2)*, the LSP API is now available to all IDEA user... - 04:24 AM Feature #10265 (Review): schema-only conversion
- I committed *10265a/16140* for review.
09/08/2025
- 10:52 AM Support #9919: discuss and define the MVP for the first pass at IDE support
- From the LSP POV, the starting requests that should be implemented could be:
# *textDocument/definition* – Go to t... - 10:25 AM Support #9919: discuss and define the MVP for the first pass at IDE support
- An example of a LSP implementation that can be integrated with IntelliJ, VSCode and probably others too:
1. First ...
09/05/2025
- 10:32 AM Feature #6319: IntelliJ plugin
- With the last IntelliJ update *(2025.2)*, the LSP API is now available to all IDEA users. In other words, we can now ...
- 08:50 AM Feature #10265 (WIP): schema-only conversion
- 08:50 AM Feature #10265: schema-only conversion
- Code Review Task Branch 10265a Revision 16139
I don't think this change is the right approach.
* The point of t... - 05:45 AM Feature #10265 (Review): schema-only conversion
- Greg, please review.
- 05:40 AM Feature #10265: schema-only conversion
- Committed *10265a/16139*. Schema conversion will be executed during normal/incremental conversion, even if all files ...
- 08:19 AM Bug #6738: incremental conversion when deleting program or class files
- > I discussed with Alex and he mentioned that name_map.xml should be placed in the @cvt@ folder because it is an arti...
- 08:18 AM Bug #6738: incremental conversion when deleting program or class files
- Let's have the name map default to @./cvt/name_map.xml@ and get the @build.xml@ change put into all projects.
It m... - 07:50 AM Bug #6738: incremental conversion when deleting program or class files
- To setup the name_map.xml in the cvt folder:
* @p2j.cfg.xml@:... - 07:21 AM Bug #6738: incremental conversion when deleting program or class files
- I discussed with Alex and he mentioned that name_map.xml should be placed in the @cvt@ folder because it is an artifa...
- 04:29 AM Bug #6738: incremental conversion when deleting program or class files
- Committed *6083a/16156*. Added support for having the name_map.xml in the @cfg@ folder (not @cvt@).
Greg, I think ... - 02:53 AM Bug #6738: incremental conversion when deleting program or class files
- I ported the changes from *6738a/16145* to *6083a/16155*.
Greg Shah wrote:
> Code Review Task Branch 6738a Revisi... - 02:22 AM Feature #6083: schema (.df) changes in incremental conversion mode should only reconvert those pr...
- Rebased *6083a* to latest *trunk/16147*, the branch is now at revision *16154*.
09/04/2025
- 11:28 AM Feature #6256: improved profile support
- Roger Borrello wrote:
> Greg Shah wrote:
> > The @.df@ should stay in @data/@. It is only the intermediate and out... - 11:22 AM Feature #6256: improved profile support
- > Let me know your thoughts.
I'm OK with the approach, especially if the @build.xml@ can be common to most applica... - 10:38 AM Bug #6738: incremental conversion when deleting program or class files
- Dănuț Filimon wrote:
> Since I used a bit of code from *6083a* and the changes are related to the recent incremental... - 10:38 AM Bug #6738: incremental conversion when deleting program or class files
- Code Review Task Branch 6738a Revision 16145
1. In @ConversionData.cleanupDeletedFiles()@, I wonder if the @mgr.sa... - 09:53 AM Bug #6738: incremental conversion when deleting program or class files
- Since I used a bit of code from *6083a* and the changes are related to the recent incremental work, should I port the...
- 07:11 AM Bug #6738 (Review): incremental conversion when deleting program or class files
- Greg, please review.
- 07:11 AM Bug #6738: incremental conversion when deleting program or class files
- Committed *6738a/16145*. Added support for incremental conversion when deleting a program.
The most important chan... - 04:10 AM Bug #10482 (WIP): [REGRESSION] DMO temp-table SQL name is no longer deterministic
- I'm not sure if this is a regression. I've seen that kind of differences many times when converting a large app. The ...
09/03/2025
- 05:09 PM Feature #6256: improved profile support
- Greg Shah wrote:
> The @.df@ should stay in @data/@. It is only the intermediate and output artifacts that should b... - 04:25 PM Feature #6256: improved profile support
- Greg Shah wrote:
> > I'm able to remove all the extra @convert.zset@ BS.
>
> This is good. Please do this witho... - 09:20 AM Bug #6738: incremental conversion when deleting program or class files
- When deleting a file, incremental conversion must delete the following:
* The procedure name from @name_map.xml@
* ... - 07:16 AM Bug #6738: incremental conversion when deleting program or class files
- I totally forgot that I have @this.filename@ for asts and that the name of the parsed file is always known.
09/02/2025
- 05:56 PM Feature #6256: improved profile support
- > I'm able to remove all the extra @convert.zset@ BS.
This is good. Please do this without the profile (use the ... - 05:54 PM Feature #6256: improved profile support
- The @.df@ should stay in @data/@. It is only the intermediate and output artifacts that should be in @cvt/data/@.
... - 05:15 PM Feature #6256: improved profile support
- Dănuț Filimon wrote:
> Artifacts were moved to the @cvt@ folder in trunk/16089 (#5586), please post your errors in #... - 04:22 PM Feature #6256: improved profile support
- Greg Shah wrote:
> What do you mean by a "profile directory"? Are you talking about the @cvt/@ directory? This abs... - 11:38 AM Feature #6256: improved profile support
- Roger Borrello wrote:
> Greg Shah wrote:
> > If they are in the jar, we definitely DO NOT want them deployed in the... - 11:26 AM Feature #6256: improved profile support
- Greg Shah wrote:
> If they are in the jar, we definitely DO NOT want them deployed in the filesystem.
What about th... - 10:02 AM Feature #6256: improved profile support
- If they are in the jar, we definitely DO NOT want them deployed in the filesystem.
> BTW, even though these change... - 08:43 AM Feature #6256: improved profile support
- Greg Shah wrote:
> Yes, the filesystem approach is for dev environments and the jar would be used in prod.
Right ... - 08:28 AM Feature #6256: improved profile support
- Yes, the filesystem approach is for dev environments and the jar would be used in prod.
- 08:16 AM Feature #6256: improved profile support
- Greg Shah wrote:
> Not sure about the @.dict@ but we currently have a dependency on the @.p2o@ for import and it cer... - 08:05 AM Feature #6256: improved profile support
- Not sure about the @.dict@ but we currently have a dependency on the @.p2o@ for import and it certainly should have a...
- 02:16 AM Feature #6256: improved profile support
- Roger Borrello wrote:
> I made updates to an application to position the @.df@ files into the profile directory so t... - 09:11 AM Bug #6738 (WIP): incremental conversion when deleting program or class files
- Created task branch *6738a* from latest *trunk/16144*.
- 08:49 AM Feature #3881: output actual file and line/column for all outputs in conversion/analytics
- With the changes from branch *3881a*, one of the next steps is addressing this bug:
for the 4GL code ...
09/01/2025
- 04:47 PM Feature #6256: improved profile support
- I made updates to an application to position the @.df@ files into the profile directory so that the @p2j.cfg.xml@ wou...
- 10:27 AM Feature #6319: IntelliJ plugin
- > I tried understanding where this is taking place now. In other words, the mapping between IElementTypes to PsiElem...
- 08:25 AM Bug #6738: incremental conversion when deleting program or class files
- Dănuț Filimon wrote:
> For #6738, I looked into the code and found @JavaPatternWorker$WorkArea.pfiles@, this helps u... - 06:08 AM Bug #10469: incremental conversion when basepath is more than one folder (aka abl/foo) with #5586
- The only ./cvt/ usage is in this phase:...
- 05:54 AM Bug #10469: incremental conversion when basepath is more than one folder (aka abl/foo) with #5586
- Dănuț Filimon wrote:
> Constantin Asofiei wrote:
> > I noticed something else during incremental conversion: the fi... - 05:50 AM Bug #10469: incremental conversion when basepath is more than one folder (aka abl/foo) with #5586
- Constantin Asofiei wrote:
> I noticed something else during incremental conversion: the file is reported using @./cv... - 05:46 AM Bug #10469: incremental conversion when basepath is more than one folder (aka abl/foo) with #5586
- I noticed something else during incremental conversion: the file is reported using @./cvt/@ instead of @./abl@. Can ...
- 05:48 AM Bug #9917 (Test): Fileset not ignoring case
- Branch 9917a was merged into trunk as revision 16139 and archived.
- 05:37 AM Bug #9917: Fileset not ignoring case
- Alexandru Lungu wrote:
> Danut, please merge 9917a to trunk *after 10020a*. There won't be any delivery this week - ... - 05:17 AM Feature #10265 (WIP): schema-only conversion
- Created task branch *10265a* from *trunk/16138*.
08/29/2025
- 10:41 AM Feature #6319: IntelliJ plugin
- > ParserDefiniton.createElement() - here we convert the AST elements into PSI elements that can interact with the Int...
- 09:48 AM Bug #6308 (Internal Test): post string literal alternative coding quirk in 4GL preprocessor
- I've reviewed this change and all the related change in 6859b. It is difficult to assess by code review alone, if th...
- 09:47 AM Bug #9886 (Internal Test): Double slashes should produce a new line during preprocessing
- I've reviewed this change and all the related change in 6859b. It is difficult to assess by code review alone, if th...
- 09:47 AM Bug #9903 (Internal Test): alternative codings with ' (quote) don't convert to ` (backtick)
- I've reviewed this change and all the related change in 6859b. It is difficult to assess by code review alone, if th...
- 09:47 AM Bug #9918 (Internal Test): tilde doesn't duplicate semicolon in alternative codings
- I've reviewed this change and all the related change in 6859b. It is difficult to assess by code review alone, if th...
- 09:47 AM Bug #10099 (Internal Test): Tilde consumes the octals/follow-up characters, when in OE this doesn...
- I've reviewed this change and all the related change in 6859b. It is difficult to assess by code review alone, if th...
- 06:38 AM Bug #9917 (Merge Pending): Fileset not ignoring case
- Danut, please merge 9917a to trunk *after 10020a*. There won't be any delivery this week - the next scheduled deliver...
08/28/2025
- 07:24 AM Bug #10208 (Closed): do not convert the schema in incremental mode if it hasn't changed
- 07:24 AM Bug #9863 (Closed): Fileset eXclude broken on native Windows
- 07:24 AM Feature #6256 (Closed): improved profile support
- 07:18 AM Feature #5586 (Closed): move all conversion artifacts/outputs into the cvtdb or into a dedicated ...
- 03:13 AM Bug #10469 (Review): incremental conversion when basepath is more than one folder (aka abl/foo) w...
- Committed the patch from #10469-7 to *10469a/16135*. Constantin, please review.
08/27/2025
- 10:38 AM Feature #6083 (Internal Test): schema (.df) changes in incremental conversion mode should only re...
- Code Review Task Branch 6083a Revisions 16125 through 16127
I'm good with the changes. - 06:57 AM Feature #6083: schema (.df) changes in incremental conversion mode should only reconvert those pr...
- Greg Shah wrote:
> > The only issue that I can see right now, is that the last table parsed will contain the df foot... - 06:49 AM Feature #6083: schema (.df) changes in incremental conversion mode should only reconvert those pr...
- > The only issue that I can see right now, is that the last table parsed will contain the df footer:
That must be ... - 06:28 AM Feature #6083 (Review): schema (.df) changes in incremental conversion mode should only reconvert...
- The only issue that I can see right now, is that the last table parsed will contain the df footer:...
- 09:12 AM Bug #10482: [REGRESSION] DMO temp-table SQL name is no longer deterministic
- Since 16131 or earlier, when converting for regression testing a large app, the DMOs are no longer the same - the SQL...
- 09:12 AM Bug #10482 (WIP): [REGRESSION] DMO temp-table SQL name is no longer deterministic
- 07:14 AM Bug #9917: Fileset not ignoring case
- I prefer to defer the merging after customer deliveries happening tomorrow evening.
- 06:46 AM Bug #9917: Fileset not ignoring case
- You can control the merge.
- 04:12 AM Bug #9917: Fileset not ignoring case
- The regression test plan passed with 9917a, the branch can be merged.
08/26/2025
- 10:09 AM Feature #6083: schema (.df) changes in incremental conversion mode should only reconvert those pr...
- Yes, and it just needs to be checked by tablename and schema (the table is uniquely named per schema).
- 08:49 AM Feature #6083: schema (.df) changes in incremental conversion mode should only reconvert those pr...
- So one section will be like this:...
- 08:15 AM Feature #6083: schema (.df) changes in incremental conversion mode should only reconvert those pr...
- The original detection of a change to the @.df@ might just be from whitespace changes or ordering differences (conten...
- 07:48 AM Feature #6083: schema (.df) changes in incremental conversion mode should only reconvert those pr...
- Greg Shah wrote:
> If we are operating on the original text from the @.df@ then we would NOT be calculating any chan... - 07:41 AM Feature #6083: schema (.df) changes in incremental conversion mode should only reconvert those pr...
- If we are operating on the original text from the @.df@ then we would NOT be calculating any changes in the AST.
- 06:14 AM Feature #6083: schema (.df) changes in incremental conversion mode should only reconvert those pr...
- Dănuț Filimon wrote:
> To calculate the checksum for a table, we need:
> * The original text of the table, e.g.: @g... - 04:50 AM Feature #6083: schema (.df) changes in incremental conversion mode should only reconvert those pr...
- To calculate the checksum for a table, we need:
* The original text of the table, e.g.: @guest@
* The db_signature ... - 04:20 AM Feature #6319: IntelliJ plugin
- The IntelliJ plugin deals with the syntax tree of a language using @PsiElement@ abstractions. These provide informati...
- 03:11 AM Bug #10469: incremental conversion when basepath is more than one folder (aka abl/foo) with #5586
- I experimented with the cvt and basepath parameters and also tried the scenario where:
* basepath is ./abl/hotel
* ...
08/25/2025
- 09:25 AM Feature #6083: schema (.df) changes in incremental conversion mode should only reconvert those pr...
- Greg Shah wrote:
> We could calculate the checksum for the original input text for that table. That would be more c... - 09:19 AM Feature #6083: schema (.df) changes in incremental conversion mode should only reconvert those pr...
- We could calculate the checksum for the original input text for that table. That would be more consistent with our f...
- 05:13 AM Feature #6083: schema (.df) changes in incremental conversion mode should only reconvert those pr...
- Committed *6083a/16125*. Keep track of modified tables in incremental conversion.
I've noticed that during convers... - 06:56 AM Bug #10469: incremental conversion when basepath is more than one folder (aka abl/foo) with #5586
- I already tried to add abl/hotel to the propath:...
- 06:48 AM Bug #10469: incremental conversion when basepath is more than one folder (aka abl/foo) with #5586
- You need to add @:${P2J_HOME}/abl/hotel/@ to @propath@ in @p2j.cfg.xml@. If we look in @Configuration.getPathToConve...
- 06:27 AM Bug #10469: incremental conversion when basepath is more than one folder (aka abl/foo) with #5586
- Constantin, is there any configuration missing? I get this error with the mentioned configuration:...
- 06:06 AM Bug #10469 (WIP): incremental conversion when basepath is more than one folder (aka abl/foo) with...
- I'll look into the issue right away.
- 06:05 AM Bug #10469: incremental conversion when basepath is more than one folder (aka abl/foo) with #5586
- There is a bug when @basepath="./abl/hotel/"@ and @cvtpath="./cvt"@. Incremental conversion will fail because @Confi...
- 06:04 AM Bug #10469 (Test): incremental conversion when basepath is more than one folder (aka abl/foo) wit...
- 06:05 AM Feature #6256 (Test): improved profile support
- OK, moved to 10469.
- 06:00 AM Feature #6256: improved profile support
- Constantin, this is related to 5586a changes. Can you create a separate task?
- 05:57 AM Feature #6256 (WIP): improved profile support
- There is a bug when @basepath="./abl/hotel/"@ and @cvtpath="./cvt"@. Incremental conversion will fail because @Confi...
08/22/2025
- 10:32 AM Feature #6319: IntelliJ plugin
- !ss3.png!
- 10:30 AM Feature #6319: IntelliJ plugin
- The IntelliJ platform is Swing-based and we can think of the UI components as wrappers over Swing @JComponents@. For ...
08/21/2025
- 10:31 AM Feature #10459: migrate all project configuration into a single jSON configuration file
- > The "new" hotel method generates a JSON based upon the responses to the prompts.
We will want to invert that. ... - 10:05 AM Feature #10459: migrate all project configuration into a single jSON configuration file
- The "new" hotel method generates a JSON based upon the responses to the prompts. This JSON is also made available in ...
- 09:14 AM Feature #10459: migrate all project configuration into a single jSON configuration file
- There are also schema hint files.
We should also have a tool to gather all these input files and generate the .jso... - 09:12 AM Feature #10459: migrate all project configuration into a single jSON configuration file
- The current approach to conversion project configuration is a frankenstein monster which we have pieced together over...
- 08:46 AM Feature #10459 (New): migrate all project configuration into a single jSON configuration file
- 09:22 AM Feature #6083: schema (.df) changes in incremental conversion mode should only reconvert those pr...
- Rebased *6083a* to latest *trunk/16124*.
- 09:08 AM Bug #10208 (Test): do not convert the schema in incremental mode if it hasn't changed
- Branch 10208a was merged into trunk as rev. 16124 and archived.
- 08:50 AM Bug #10208 (Merge Pending): do not convert the schema in incremental mode if it hasn't changed
- You can merge to trunk now.
- 07:22 AM Bug #10208: do not convert the schema in incremental mode if it hasn't changed
- I'm OK with a merge but please coordinate with Constantin to ensure that we don't negatively affect customer deliveri...
- 05:37 AM Bug #10208: do not convert the schema in incremental mode if it hasn't changed
- Testing went well, Radu also got the error from #10208-37 and it was related to trunk/16111 (since he converted with ...
- 08:29 AM Feature #10458 (Rejected): stable and deterministic name generation during app-by-app conversion
- This work is already represented in #9639.
- 08:23 AM Feature #10458: stable and deterministic name generation during app-by-app conversion
- We need to ensure that the names we generate (classes, methods, data members...) are stable and deterministic. This ...
- 08:00 AM Feature #10458 (Rejected): stable and deterministic name generation during app-by-app conversion
- 08:28 AM Feature #9639: centralized name management (and conversion) OR jar based resolution
- We need to ensure that the names we generate (classes, methods, data members...) are stable and deterministic. This ...
- 07:57 AM Bug #8967 (Closed): Remove relationship annotation from full conversion
- 03:32 AM Bug #9917 (Internal Test): Fileset not ignoring case
- I retested conversion without revision 15971 for the problematic application and there were no issues.
Committed *...
08/19/2025
- 10:10 AM Feature #6319: IntelliJ plugin
- I managed to implement the idea above and created a real-time side-by-side preview of the preporcessed 4GL code (usin...
- 07:08 AM Bug #10208: do not convert the schema in incremental mode if it hasn't changed
- Committed *10208a/16118*. SchemaLoader should have schemasChanged passed in runSchemaLoader().
Mutable databases w... - 05:43 AM Bug #10208: do not convert the schema in incremental mode if it hasn't changed
- I tested incremental conversion for two customers and even if the schema was not changed, it was still running the Sc...
08/18/2025
- 09:03 AM Feature #6083: schema (.df) changes in incremental conversion mode should only reconvert those pr...
- Dănuț Filimon wrote:
> Issues:
> * I am calculating the table hash and overriding before I can compare it
I have... - 07:15 AM Feature #6083: schema (.df) changes in incremental conversion mode should only reconvert those pr...
- At the moment, I've managed to implement the following:
# When we have changed schemas, I iterate over the ones that... - 08:18 AM Feature #6256 (Test): improved profile support
- Branch 6256a was merged to trunk as rev. 16116 and archived.
- 08:03 AM Feature #6256 (Merge Pending): improved profile support
- 6256a can be merged now.
08/14/2025
- 10:24 AM Feature #6319: IntelliJ plugin
- So far I have investigated the following areas of the IntelliJ Plugin Devkit.
1. @Extension Points@ - these can be... - 07:07 AM Bug #10208 (Internal Test): do not convert the schema in incremental mode if it hasn't changed
- Code Review Task Branch 10208a Revision 16117
I like it. - 04:42 AM Bug #10208 (Review): do not convert the schema in incremental mode if it hasn't changed
- Committed *10208a/16117*. Fixed full conversion problem where schemasChanged was null and the standard.df was skipped...
- 04:09 AM Bug #10208 (WIP): do not convert the schema in incremental mode if it hasn't changed
- Currently working on a fix.
- 04:08 AM Bug #10208: do not convert the schema in incremental mode if it hasn't changed
- There's a scenario in ETF where the schemasChanged is null, but also should contain all the schemas because we are no...
- 06:57 AM Feature #7180 (Review): create a centralized manager for the conversion list and per-file/project...
- Rebased *7180a* to latest *trunk/16115*, the branch is now at revision *16137*.
Committed revisions *16138* and *1... - 06:34 AM Feature #7180: create a centralized manager for the conversion list and per-file/project status a...
- Committed *7180a/16132*: Moved getPathToConversionFolder() and getPathToSourceFileFromConversionFolder() to ArtifactM...
08/13/2025
- 12:09 PM Bug #10208: do not convert the schema in incremental mode if it hasn't changed
- Found an issue with ETF conversion, I will be investigating.
- 04:01 AM Bug #10208: do not convert the schema in incremental mode if it hasn't changed
- Rebased *10208a* to latest *trunk/16110*, the branch is now at revision *16116*.
- 04:46 AM Feature #7180: create a centralized manager for the conversion list and per-file/project status a...
- Rebased *7180a* to latest *trunk/16110*, the branch is now at revision *16131*.
08/12/2025
- 06:53 AM Feature #7180: create a centralized manager for the conversion list and per-file/project status a...
- Looked at the ArtifaceManager and Configuration classes, the following are required by the ArtifactManager:
* @getPa...
08/11/2025
- 08:44 AM Feature #7180: create a centralized manager for the conversion list and per-file/project status a...
- Committed *7180a/16111*. Compatibility changes after rebasing and picking up 5586a.
I will also look into #7180-1...
Also available in: Atom