Activity
From 10/10/2025 to 11/08/2025
11/07/2025
- 12:27 AM Feature #10190 (Internal Test): Prototype the changes to the build to add ANTLR v4
- Code Review Task Branch 10190a Revision 16003
The changes look good.
11/06/2025
- 09:36 AM Bug #6629 (Review): incremental conversion for OpenClient proxy programs
- Committed *6629a/16252*. Added support for deleting program configurations.
Constantin, please review. - 09:10 AM Feature #10190 (Review): Prototype the changes to the build to add ANTLR v4
- Committed as rev *16003*.
Greg, please review. - 03:29 AM Feature #10190: Prototype the changes to the build to add ANTLR v4
- > There seems to be a small typo, when the grammar is not up to date, the log message displays two consecutive 'not' ...
- 02:48 AM Feature #10804: create replacement AST implementation for use with ANTLR 4
- > In ANTLR 4 there’s no @CommonAST@. The parser only produces a @ParseTree@, so if we want an AST-like structure, we’...
11/05/2025
- 09:37 AM Bug #6629: incremental conversion for OpenClient proxy programs
- Dănuț Filimon wrote:
> One issue with deleting a program configuration file is that deleting it will not cause all a... - 08:08 AM Bug #6629: incremental conversion for OpenClient proxy programs
- One issue with deleting a program configuration file is that deleting it will not cause all associated program files ...
- 05:02 AM Bug #6629: incremental conversion for OpenClient proxy programs
- Committed *6629a/16251*. Initial implementation for incremental conversion of proxy/soap/rest/web program configurati...
- 05:03 AM Feature #10190: Prototype the changes to the build to add ANTLR v4
- I've checked out the branch and I have a few questions regarding the current approach:
* There seems to be a small...
11/04/2025
- 12:10 PM Feature #10804: create replacement AST implementation for use with ANTLR 4
- Greg, let me summarize to make sure I’ve got the idea right, please let me know if this matches your vision:
* In ... - 07:40 AM Bug #6629: incremental conversion for OpenClient proxy programs
- Incremental conversion is working, I plan to cleanup the implementation and see if there are any improvements that I ...
11/03/2025
- 07:50 AM Bug #6629: incremental conversion for OpenClient proxy programs
- Dănuț Filimon wrote:
> I looked over the REST operations, procedures and internal procedures are used and some of th... - 07:35 AM Bug #6629: incremental conversion for OpenClient proxy programs
- I looked over the REST operations, procedures and internal procedures are used and some of them only have their name ...
- 07:30 PM Feature #10804: create replacement AST implementation for use with ANTLR 4
- We must replace our @AnnotatedAst@ class with a new implementation that does not derive from @antlr.CommonAST@. In A...
- 07:13 PM Feature #10804 (Review): create replacement AST implementation for use with ANTLR 4
- 07:21 PM Feature #1757: update ANTLR to latest version
- We will continue to discuss and consider this issue of how we handle the IDE (from the parse tree or the AST...) but ...
- 07:10 PM Feature #1757: update ANTLR to latest version
- > If we compare the two images, we can see that the tree generated by ANTLR v4 is deeper (depth 4) and more detailed ...
- 07:00 PM Feature #1757: update ANTLR to latest version
- Alexandru Lungu wrote:
> > the adapter will simply take the ANTLR 4 parse tree and convert it into the annotated AST...
11/02/2025
- 06:45 PM Feature #1757: update ANTLR to latest version
- Let me provide some additional context about our work here.
1. Our requirements will likely be set by the 4GL pr... - 05:10 PM Feature #1757: update ANTLR to latest version
- > I had an in-depth discussion with Alex,
I appreciate this, but please note that I am leading this effort directl...
10/31/2025
- 10:20 AM Feature #1757: update ANTLR to latest version
- Alex, I used the expression *2 + 3 * 4* to generate a simple AST and a ParseTree using ANTLR v2 and ANTLR v4:
!ant... - 09:01 AM Feature #1757: update ANTLR to latest version
- Paula Păstrăguș wrote:
> We’ll also need to evaluate how this affects performance. While I would expect ANTLR 4 to b... - 06:37 AM Feature #1757: update ANTLR to latest version
- > the adapter will simply take the ANTLR 4 parse tree and convert it into the annotated AST format expected by our cu...
- 06:29 AM Feature #1757: update ANTLR to latest version
- I had an in-depth discussion with Alex, and we agreed to start working on upgrading @ANTLR 2@ to @ANTLR 4@. For now, ...
- 10:05 AM Bug #6629: incremental conversion for OpenClient proxy programs
- I've got an implementation down for *.xpxg. Sorry Constantin, but I could not use your idea as I could not get the ri...
10/30/2025
- 05:34 AM Bug #6629: incremental conversion for OpenClient proxy programs
- Constantin Asofiei wrote:
> Danut, while we are at it: the .jast for the FWD OpenClient proxy programs is still in a... - 04:25 AM Bug #10784: FWD Analytics - Visualize Call Graph can't be used due to broken file paths
- Octavian Adrian Gavril wrote:
> I found as a quick fix that
Clever. Let's consider this a temporary workaround. - 03:28 AM Bug #10784: FWD Analytics - Visualize Call Graph can't be used due to broken file paths
- I found as a quick fix that we can change in @p2j.cfg.xml@ the @basepath@ from @"./abl"@ into @"${P2J_HOME}/abl"@ *af...
10/29/2025
- 01:43 PM Bug #6629: incremental conversion for OpenClient proxy programs
- Danut, while we are at it: the .jast for the FWD OpenClient proxy programs is still in abl/ and not in cvt/ folder.
- 11:04 AM Bug #6629: incremental conversion for OpenClient proxy programs
- > Greg, should soap/rest/web/proxy files be checked right at the start of the conversion or should we wait until the ...
- 10:31 AM Bug #6629: incremental conversion for OpenClient proxy programs
- Greg, should soap/rest/web/proxy files be checked right at the start of the conversion or should we wait until the la...
- 09:44 AM Bug #6629: incremental conversion for OpenClient proxy programs
- ServiceSupport.resolveRestConfiguration for REST, resolveWebHandlers for WEB, initialize for SOAP. Those 3 will have ...
- 08:50 AM Bug #6629: incremental conversion for OpenClient proxy programs
- There's @resolveProxyProgramsConfiguration()@ method that is called in @middle()@ when initializing a @ServiceSupport...
- 07:03 AM Bug #10569 (WIP): Semicolon is skipped while preprocessing
- I'll switch this back to WIP so that we know I'm back to digging.
- 05:53 AM Feature #7180 (Review): create a centralized manager for the conversion list and per-file/project...
- Committed *7180a/16273*. Moved getPathToConversionFolderPojoFromDmo() to the ArtifactManager.
7180a/16267 - 16273 ...
10/28/2025
- 12:40 PM Bug #6629: incremental conversion for OpenClient proxy programs
- Dănuț Filimon wrote:
> Constantin Asofiei wrote:
> > Otherwise, a question: if there are changes in the SOAP, REST,... - 10:41 AM Bug #6629: incremental conversion for OpenClient proxy programs
- Constantin Asofiei wrote:
> Otherwise, a question: if there are changes in the SOAP, REST, web or proxy/.xpxg resour... - 08:34 AM Bug #6629: incremental conversion for OpenClient proxy programs
- The issue I think was that when running incremental conversion, the OpenClient proxy generation in FWD was not includ...
- 08:06 AM Bug #6629: incremental conversion for OpenClient proxy programs
- Dănuț Filimon wrote:
> I got the open_client_example project from Constantin and did a simple test. After conversion... - 06:24 AM Bug #6629 (WIP): incremental conversion for OpenClient proxy programs
- I got the open_client_example project from Constantin and did a simple test. After conversion, I modified @./abl/subt...
- 07:25 AM Feature #7180: create a centralized manager for the conversion list and per-file/project status a...
- Dănuț Filimon wrote:
> Dănuț Filimon wrote:
> > * @error: neutralMillisToCalendar(long,TimeZone) has private access... - 05:37 AM Feature #7180: create a centralized manager for the conversion list and per-file/project status a...
- Dănuț Filimon wrote:
> * @error: neutralMillisToCalendar(long,TimeZone) has private access in date@
> * @error: jul... - 05:31 AM Feature #7180: create a centralized manager for the conversion list and per-file/project status a...
- I converted ChUI and the conversion passed, but the compile phase failed with errors and warnings like:
* @warning: ... - 03:25 AM Bug #10784: FWD Analytics - Visualize Call Graph can't be used due to broken file paths
- I attached the log that described the issue:
{{Collapse(report-server.log)... - 03:20 AM Bug #10784 (Test): FWD Analytics - Visualize Call Graph can't be used due to broken file paths
10/27/2025
- 08:38 AM Feature #7180: create a centralized manager for the conversion list and per-file/project status a...
- A few issues I found while testing hotel:
* All artifacts were created as BaseArtifact, there's a few places that re... - 04:46 AM Bug #10469: incremental conversion when basepath is more than one folder (aka abl/foo) with #5586
- Constantin Asofiei wrote:
> Danut, is 10469a still required? I see it was archived as dead.
The fix from 10469a ... - 04:45 AM Bug #10469: incremental conversion when basepath is more than one folder (aka abl/foo) with #5586
- Danut, is 10469a still required? I see it was archived as dead.
10/24/2025
- 08:38 AM Feature #7180: create a centralized manager for the conversion list and per-file/project status a...
- Rebased *7180a* to latest *trunk/16242*, the branch is now at revision *16270*.
Committed *7180a/16271* to make 71... - 07:15 AM Feature #7180: create a centralized manager for the conversion list and per-file/project status a...
- Committed *7180a/16247-16248*. Removed remaining Configuration dependencies from the ArtifactManager. (refs: #7180)
... - 04:38 AM Feature #7180: create a centralized manager for the conversion list and per-file/project status a...
- Dănuț Filimon wrote:
> The only issue left is with removing Configuration from the AM and testing.
I have two opt...
10/23/2025
- 09:49 AM Bug #4867 (Review): Incremental conversion: change detection algorithm ignores .hints and .ext-hi...
- Committed *4867a/16236*. hints and ext-hints files should trigger changes during incremental conversion.
Greg, ple... - 07:42 AM Bug #4867: Incremental conversion: change detection algorithm ignores .hints and .ext-hints files
- I found https://proj.goldencode.com/projects/p2j/wiki/Chapter_12_Conversion_Hints for reference.
- 07:40 AM Bug #4867 (WIP): Incremental conversion: change detection algorithm ignores .hints and .ext-hints...
- ...
- 07:07 AM Feature #7180: create a centralized manager for the conversion list and per-file/project status a...
- Here goes another commit to *7180a/16246*! Allow ConversionData to use artifacts, added computeHash() to Artifact, us...
10/22/2025
- 07:56 AM Bug #10569: Semicolon is skipped while preprocessing
- To be a bit more clear: we have applications that use a 4GL quirk where @'@ and @"@ characters can be embedded inside...
- 06:18 AM Feature #7180: create a centralized manager for the conversion list and per-file/project status a...
- Committed *7180a/16245*. Addressed the rebase issues, compatibility changes and most of the review points from #7180-...
- 05:47 AM Feature #6083 (Closed): schema (.df) changes in incremental conversion mode should only reconvert...
- 05:47 AM Bug #6738 (Closed): incremental conversion when deleting program or class files
- 05:46 AM Bug #9917 (Closed): Fileset not ignoring case
10/21/2025
- 09:11 AM Feature #10265 (Test): schema-only conversion
- Branch 10265a was merged into trunk as rev. 16227 and archived.
- 09:07 AM Feature #10265 (Merge Pending): schema-only conversion
- 05:32 AM Feature #10265: schema-only conversion
- Tested conversion and incremental with ETF, ChUI and 3 other customer applications. No issues found.
- 05:38 AM Bug #10626: DMO names can collide on case-insensitive file-system
- Dănuț Filimon wrote:
> I did a conversion with a customer application and forwarded the jars to Artur for testing, w... - 05:33 AM Bug #10626: DMO names can collide on case-insensitive file-system
- I did a conversion with a customer application and forwarded the jars to Artur for testing, where he found 3 tests fa...
- 02:38 AM Bug #10639: Incremental conversion - unexpected DMO generation for space-only changes
- Ovidiu Maxiniuc wrote:
>
> In your example, the key was @aced000[...]@ - (apparently) the same for all entries, so...
10/20/2025
- 04:38 PM Bug #10639: Incremental conversion - unexpected DMO generation for space-only changes
- I think the @key@ column should be part of the @key@ in @workInsertSql@ statement, to match the unique index.
<pre... - 10:59 AM Bug #10569: Semicolon is skipped while preprocessing
- I don't think this change is OK. I deliberately excluded those chars from that rule (i.e. @// it is OK to match " or...
- 08:56 AM Feature #7180: create a centralized manager for the conversion list and per-file/project status a...
- Fixed number 1, 2, 6.
I am a bit stuk at 9, getting the Configuration out of the AM. I have to move Configuration....
10/17/2025
- 05:17 AM Bug #10639 (Review): Incremental conversion - unexpected DMO generation for space-only changes
- I analyzed the current implementation that handles insertions in @H2Map@. I changed the @INSERT@ statement with @MERG...
- 03:01 AM Bug #10639 (WIP): Incremental conversion - unexpected DMO generation for space-only changes
- 02:46 AM Bug #10639: Incremental conversion - unexpected DMO generation for space-only changes
- Alexandru Lungu wrote:
>
> I understand the change and it looks functionally right to me (especially after re-read... - 04:50 AM Bug #10569 (Review): Semicolon is skipped while preprocessing
- This is the patch I used to solve the issue. Both the testcases and the application scenario are fine with it. Intere...
10/16/2025
- 10:13 AM Bug #10639: Incremental conversion - unexpected DMO generation for space-only changes
- Alexandru Lungu wrote:
> I understand the change and it looks functionally right to me (especially after re-readin... - 06:23 AM Bug #10639: Incremental conversion - unexpected DMO generation for space-only changes
- > Alex: Please review.
I understand the change and it looks functionally right to me (especially after re-reading ... - 09:13 AM Bug #10626 (Internal Test): DMO names can collide on case-insensitive file-system
- 09:07 AM Bug #10626: DMO names can collide on case-insensitive file-system
- Greg Shah wrote:
> Code Review Task Branch 10626a Revision 16221
>
> I don't have a problem with the changes. Pl... - 09:01 AM Bug #10626: DMO names can collide on case-insensitive file-system
- Code Review Task Branch 10626a Revision 16221
I don't have a problem with the changes. Please help me understand ... - 02:30 AM Bug #10626 (Review): DMO names can collide on case-insensitive file-system
- Greg, please review.
- 02:29 AM Bug #10626: DMO names can collide on case-insensitive file-system
- Dănuț Filimon wrote:
> Greg Shah wrote:
> > Is this ready for review? What is the % Done?
>
> I looked into th... - 07:20 AM Feature #7180: create a centralized manager for the conversion list and per-file/project status a...
- > The following pattern:
> [...] where an artifact is created to call loadTree() is because loadTree() takes an Arti... - 07:08 AM Feature #7180: create a centralized manager for the conversion list and per-file/project status a...
- The following pattern:...
- 04:10 AM Feature #7180: create a centralized manager for the conversion list and per-file/project status a...
- I managed to make 7180a build, but I don't like a few changes so I'll be working a bit on 7180a and also take care of...
10/15/2025
- 02:16 PM Feature #10726: calculate and report code quality metrics
- We will implement multiple calculations of code quality using TRPL (and possibly a subset of call graph analysis). T...
- 01:50 PM Feature #10726 (New): calculate and report code quality metrics
- 08:52 AM Feature #7180 (WIP): create a centralized manager for the conversion list and per-file/project st...
- Rebased *7180a* to latest *trunk/16220*, the branch is now at revision *16244*. I'll have to commit a few compatibili...
- 05:44 AM Feature #7180: create a centralized manager for the conversion list and per-file/project status a...
- Greg Shah wrote:
> Code Review Task Branch 7180a Revisions 16121 through 16139
I plan to rebase and address a few... - 07:02 AM Bug #10639: Incremental conversion - unexpected DMO generation for space-only changes
- Alex: Please review.
- 06:37 AM Bug #10626: DMO names can collide on case-insensitive file-system
- Greg Shah wrote:
> Is this ready for review? What is the % Done?
I looked into the ChUI project for some other ... - 06:31 AM Bug #10626: DMO names can collide on case-insensitive file-system
- Is this ready for review? What is the % Done?
- 04:50 AM Bug #10626: DMO names can collide on case-insensitive file-system
- Committed *10626a/16221*. Generates names for menus, sub-menus, dmos, pojos, frames that do not collide in case-insen...
10/14/2025
- 12:40 PM Feature #10701: implement support for generative AI code assist
- For some time now, I've been expecting that we would write some kind of plugin to integrate with popular gen AI envir...
- 10:42 AM Feature #7180: create a centralized manager for the conversion list and per-file/project status a...
- Code Review Task Branch 7180a Revisions 16121 through 16139
This is really good. We are getting close.
1. @ann... - 09:40 AM Bug #10626: DMO names can collide on case-insensitive file-system
- Dănuț Filimon wrote:
> I discussed with Octavian and he mentioned I could use @createString2StringMap@ to get a map ... - 07:21 AM Bug #10626: DMO names can collide on case-insensitive file-system
- I discussed with Octavian and he mentioned I could use @createString2StringMap@ to get a map across other rules. I ha...
- 06:14 AM Bug #10626: DMO names can collide on case-insensitive file-system
- I thought of using another set of rules to store a case sensitive map that maps the namings, but I don't think this i...
- 03:44 AM Bug #10626: DMO names can collide on case-insensitive file-system
- This bit of code:...
- 03:20 AM Bug #10626: DMO names can collide on case-insensitive file-system
- The issue with menus starts with this piece of code:...
- 06:09 AM Bug #10469 (Test): incremental conversion when basepath is more than one folder (aka abl/foo) wit...
- Branch 6083a was merged to trunk revision 16220 and archived.
- 06:08 AM Bug #6738 (Test): incremental conversion when deleting program or class files
- Branch 6083a was merged to trunk revision 16220 and archived.
- 06:07 AM Feature #6083 (Test): schema (.df) changes in incremental conversion mode should only reconvert t...
- Branch 6083a was merged to trunk revision 16220 and archived.
- 05:36 AM Feature #6083 (Merge Pending): schema (.df) changes in incremental conversion mode should only re...
- You can merge 6083a to trunk now.
10/13/2025
- 07:32 AM Bug #10626: DMO names can collide on case-insensitive file-system
- I setup and tested POJOs on hotel and found no issues, the hotel.p2o ends up using the correct class names (FooBarSom...
- 05:47 AM Bug #10626: DMO names can collide on case-insensitive file-system
- Dănuț Filimon wrote:
> Perfect, I'll just have to implement the contains() method for CaseInsensitiveHashMap in this... - 05:44 AM Bug #10626: DMO names can collide on case-insensitive file-system
- Constantin Asofiei wrote:
> Dănuț Filimon wrote:
> > Constantin Asofiei wrote:
> > > We need to generate the same ... - 05:16 AM Bug #10626: DMO names can collide on case-insensitive file-system
- Dănuț Filimon wrote:
> Constantin Asofiei wrote:
> > We need to generate the same .java names regardless of OS - so... - 05:15 AM Bug #10626: DMO names can collide on case-insensitive file-system
- Constantin Asofiei wrote:
> We need to generate the same .java names regardless of OS - so I think that collection n... - 05:08 AM Bug #10626: DMO names can collide on case-insensitive file-system
- We need to generate the same .java names regardless of OS - so I think that collection needs to be case-insensitive, ...
- 04:50 AM Bug #10626 (WIP): DMO names can collide on case-insensitive file-system
- Error from windows:...
10/10/2025
- 09:32 AM Feature #10701 (New): implement support for generative AI code assist
- 09:28 AM Feature #3703: implement TRPL based linting support
- Although my initial idea was to implement these as reports, it is likely that the reporting/analytics will migrate in...
- 09:25 AM Feature #10700: expose analytics features in our IDE support
- Maintaining a separate web UI for analytics is extra work for us and inconvenient for our users. A better solution i...
- 09:18 AM Feature #10700 (New): expose analytics features in our IDE support
- 08:36 AM Bug #10626: DMO names can collide on case-insensitive file-system
- Good, opsys is out of the question.
I converted the two tables, Foo_BARSomething and Foo_BAR_Something, and got a ... - 07:21 AM Bug #10626: DMO names can collide on case-insensitive file-system
- We shouldn't change the output based on the OPSYS setting. The output should be the same always (safe for case-insen...
- 07:07 AM Bug #10626: DMO names can collide on case-insensitive file-system
- We use @opsys@ to determine what OS is being used (default is Unix OS). opsys can be set in @p2j.cfg.xml@, so there's...
- 06:08 AM Feature #6083: schema (.df) changes in incremental conversion mode should only reconvert those pr...
- Code Review Task Branch 6083a Revision 16224
No objection. - 03:08 AM Feature #6083: schema (.df) changes in incremental conversion mode should only reconvert those pr...
- Committed *6083a/16224*. Fixed file copy and file separator.
- 06:05 AM Feature #10265: schema-only conversion
- Code Review Task Branch 10265a Revision 16215
It looks good. - 06:02 AM Feature #10265 (Internal Test): schema-only conversion
- Greg Shah wrote:
> Code Review Task Branch 10265a Revision 16214
>
> This is good. The only change that may be n... - 05:21 AM Feature #10265: schema-only conversion
- Code Review Task Branch 10265a Revision 16214
This is good. The only change that may be needed is to output somet...
Also available in: Atom