Project

General

Profile

Activity

From 03/03/2013 to 04/01/2013

04/01/2013

05:58 PM Database Feature #2080: add runtime support for database methods
Eric Faulhaber wrote:
> Code review 20130328a:
>
> * Why have you commented out the re-throwing of the @reason@ T...
Vadim Nebogatov
04:41 PM Database Feature #2080: add runtime support for database methods
I have attached update vmn_upd20130401a.zip/vmn_upd20130401b.zip
It contains @FETCH-SELECTED-ROW()@ conversion, usin...
Vadim Nebogatov
11:46 AM Database Feature #2080: add runtime support for database methods
Please edit each case and add the value of the ERROR:NUM-MESSAGES attribute (you can add it in the same MESSAGE line ... Constantin Asofiei
11:22 AM Base Language Feature #1920: implement persistent procedures
Note 80 from #2080 shows a missing error for function invocation:... Constantin Asofiei
10:53 AM Base Language Feature #1613: finish FILE-INFO system handle support
Added proposed update, with the modified search function, eliminated the change in EnvironmentOps since it wasn't nec... Costin Savin
09:29 AM Base Language Feature #1613: finish FILE-INFO system handle support
> In the Javadoc of EnvironmentOps.searchPath() there is this saying:
I think you mean EnvironmentOps.getSearchPat...
Greg Shah

03/31/2013

05:36 PM Database Feature #2080: add runtime support for database methods
Vadim Nebogatov wrote:
> Duding testing I have found out that @FETCH-SELECTED-ROW()@ conversion requires @BrowseWidg...
Eric Faulhaber
05:35 PM Database Feature #2080: add runtime support for database methods
Code review 20130328a:
* Why have you commented out the re-throwing of the @reason@ Throwable in @BlockManager.pro...
Eric Faulhaber

03/30/2013

06:45 AM Database Feature #2080: add runtime support for database methods

*class <Not found in code>*
Example:...
Vadim Nebogatov
06:42 AM Database Feature #2080: add runtime support for database methods
*class <Not found in code>*
Example:...
Vadim Nebogatov
06:40 AM Database Feature #2080: add runtime support for database methods
*class <Not found in code>*
Example:...
Vadim Nebogatov
06:37 AM Database Feature #2080: add runtime support for database methods
*class ControlFlowOps, line 3519*
Example:...
Vadim Nebogatov
05:57 AM Database Feature #2080: add runtime support for database methods
Moved to #2106, note 2
*class <Not found in code>*
Example:...
Vadim Nebogatov
05:43 AM Database Feature #2080: add runtime support for database methods
Moved to #2106, note 1
*class <Not found in code>*
Example:...
Vadim Nebogatov
05:29 AM Database Feature #2080: add runtime support for database methods
this note should be ignored according note 85
*class HandleOps, line 67*
Example:...
Vadim Nebogatov
05:24 AM Database Feature #2080: add runtime support for database methods
*class handle, line 254*
Example:...
Vadim Nebogatov
05:18 AM Database Feature #2080: add runtime support for database methods
Moved from #2080, notes 3,4
*class BrowseWidget, line 751*
Example:...
Vadim Nebogatov
04:59 AM Database Feature #2080: add runtime support for database methods
*class NumberType, line 3189*
Example:...
Vadim Nebogatov
04:55 AM Database Feature #2080: add runtime support for database methods
*class ControlFlowOps, line 3577*
Example:...
Vadim Nebogatov
04:36 AM Database Feature #2080: add runtime support for database methods
*class ControlFlowOps, line 2991*
Example:...
Vadim Nebogatov

03/29/2013

07:06 PM Base Language Feature #1650: process launching support for Windows (JNI library changes and any associated modi...
This is update just for review to see the approach. It compiles native DLL in Windows 32-bit using mingw32-gcc. Plann... Eugenie Lyzenko
05:32 PM Database Feature #2080: add runtime support for database methods
*class Date, line 1435*
Example:...
Vadim Nebogatov
04:48 PM Database Feature #2080: add runtime support for database methods
In regard to the use of an .odt document for reporting information about the errors, I prefer that you put the inform... Greg Shah
01:44 PM Database Feature #2080: add runtime support for database methods
I have found also that @SESSION:TIMEZONE@ is not supported (but mentioned in code).
Example is ...
Vadim Nebogatov
01:41 PM Base Language Feature #1584: add conversion and runtime support for INT64 and DATETIME data types
This update adds implementation for all TODOs from @int64@ and, since the implementation is mostly the same for the @... Ovidiu Maxiniuc
12:43 PM Database Bug #2093 (Closed): VALEXP support in P2J
Eric Faulhaber
12:42 PM Database Bug #2093: VALEXP support in P2J
At this moment, with the exception of the cases where the expression from the string condition is not valid, I don't ... Ovidiu Maxiniuc
10:36 AM Database Bug #2093: VALEXP support in P2J
Is there anything left to do on this issue or can it be closed? Eric Faulhaber
10:41 AM User Interface Feature #2088 (Closed): add HIDE STREAM statement support
Eric Faulhaber
10:38 AM Conversion Tools Feature #2001 (Closed): reporting v2.5
Eric Faulhaber
10:26 AM Database Bug #2095 (Closed): FIELDS/EXCEPT record phrase options not honored
Eric Faulhaber
09:43 AM Database Bug #2097 (Closed): FOR EACH with multiple, nested CAN-FINDs converts badly
The fix has addressed the original problem and does not appear to have regressed anything else in the customer's serv... Eric Faulhaber
09:19 AM Base Language Bug #2105: BlockManager does not return some datatypes correctly
A first attempt to fix would be to have only one @returnNormal@ static function with a BDT parameter and the value wr... Ovidiu Maxiniuc
09:04 AM Base Language Bug #2105: BlockManager does not return some datatypes correctly
Consider the following 4GL code:... Ovidiu Maxiniuc
08:55 AM Base Language Bug #2105 (New): BlockManager does not return some datatypes correctly
Ovidiu Maxiniuc
09:19 AM Database Bug #2094 (Closed): OUTER-JOIN record phrase option not honored
Eric Faulhaber

03/28/2013

06:59 PM Database Feature #2080: add runtime support for database methods
I have attached update vmn_upd20130328a.zip/vmn_upd20130328b.zip as replacement of vmn_upd20130326a.zip/ vmn_upd20130... Vadim Nebogatov
06:23 PM Database Feature #2080: add runtime support for database methods
Eric, sorry for so dangerous RecordBuffer.java. I think it was wrong bazaar merge with latest bzr revision. I do not ... Vadim Nebogatov
05:10 PM Database Feature #2080: add runtime support for database methods
Document with tests is updated Vadim Nebogatov
03:56 PM Database Feature #2080: add runtime support for database methods
Regarding vmn_upd20130326a.zip: there are hundreds of unnecessary/unwanted format changes in RecordBuffer, which mak... Eric Faulhaber
01:07 PM Database Feature #2080: add runtime support for database methods
Duding testing I have found out that @FETCH-SELECTED-ROW()@ conversion requires @BrowseWidget.fetchSelectedRow()@ wit... Vadim Nebogatov
01:26 PM Base Language Feature #1613: finish FILE-INFO system handle support
I retested the cases from UAST which contained search function or Propath and there weren't any difference,
However ...
Costin Savin
08:53 AM Base Language Feature #1613: finish FILE-INFO system handle support
In the Javadoc of EnvironmentOps.searchPath() there is this saying:... Costin Savin
08:48 AM Base Language Feature #1613: finish FILE-INFO system handle support
I don't understand why the comma is included in the default path. We already have protection against the path being ... Greg Shah
08:37 AM Base Language Feature #1650: process launching support for Windows (JNI library changes and any associated modi...
You are allowed to use Windows in KVM on the same Ubuntu system. It will be allowed in the standards. Thanks for as... Greg Shah
03:22 AM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
The updates om_upd20130325a.zip and om_upd20130325b.zip were committed to bzr (rev 10330, and rev. 10332) and distrib... Ovidiu Maxiniuc

03/27/2013

06:22 PM Database Feature #2080: add runtime support for database methods
I have attached some first test cases. Is such format would be ok?
Please notice that I found also some cases that ...
Vadim Nebogatov
04:21 PM Base Language Feature #1650: process launching support for Windows (JNI library changes and any associated modi...
The question. I have idea to install The Windows inside the KVM Virtual Machine on my new Ubuntu box. Will it also co... Eugenie Lyzenko
03:17 PM Database Bug #2097: FOR EACH with multiple, nested CAN-FINDs converts badly
The update has passed conversion regression testing and is committed to bzr rev. 10333. Eric Faulhaber
02:20 PM Database Bug #2097: FOR EACH with multiple, nested CAN-FINDs converts badly
A fix candidate is attached. Currently running it through conversion regression testing. Eric Faulhaber
02:58 PM Base Language Feature #1613: finish FILE-INFO system handle support
There seems to be an error in the search() logic of FileSystemDaemon.
If the given paths Array is non null it will s...
Costin Savin
10:11 AM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
om_upd20130325b.zip passed conversion testing. You can check in and distribute the update. Greg Shah

03/26/2013

05:22 PM Database Feature #2080: add runtime support for database methods
I have attached update vmn_upd20130326a.zip/ vmn_upd20130326b.zip
with current state of BUFFER-COPY() and BUFFER-COM...
Vadim Nebogatov
09:58 AM Database Feature #2080: add runtime support for database methods
I want to resolve this properly as part of this work. This includes any cases of ErrorManager.displayError() that sh... Greg Shah
03:23 PM Database Bug #2097: FOR EACH with multiple, nested CAN-FINDs converts badly
Ovidiu Maxiniuc wrote:
> ...but I wonder if we shouldn't treat the first @each person@ the same like @each w-person@...
Eric Faulhaber
09:57 AM Database Bug #2097: FOR EACH with multiple, nested CAN-FINDs converts badly
I understand. The algorithm is working in fact if you analyze the first clause that works.
And starting from here, I...
Ovidiu Maxiniuc
09:31 AM Database Bug #2097: FOR EACH with multiple, nested CAN-FINDs converts badly
Ovidiu Maxiniuc wrote:
> The reason why the where clause filtered to client-side is probably the @where_clause_prep2...
Eric Faulhaber
04:44 AM Database Bug #2097: FOR EACH with multiple, nested CAN-FINDs converts badly
The reason why the where clause filtered to client-side is probably the @where_clause_prep2.rules@. You can read in i... Ovidiu Maxiniuc
02:53 AM Database Bug #2097: FOR EACH with multiple, nested CAN-FINDs converts badly
I have isolated the #2068 note 272 regression like this:... Constantin Asofiei
11:13 AM Base Language Feature #1613: finish FILE-INFO system handle support
Code Feedback:
1. StreamWrapper has no real changes other than the copyright date and the history entry. Does it ...
Greg Shah
09:49 AM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
I am fine with the code changes. I will conversion test these now. Greg Shah

03/25/2013

04:31 PM Database Bug #2097 (Review): FOR EACH with multiple, nested CAN-FINDs converts badly
The ecf_upd20130325e.zip update (finally) has passed conversion regression testing; there are some differences in th... Eric Faulhaber
03:56 PM Database Bug #2097: FOR EACH with multiple, nested CAN-FINDs converts badly
Hopefully the final candidate; conversion regression testing it now. Eric Faulhaber
01:39 PM Database Bug #2097: FOR EACH with multiple, nested CAN-FINDs converts badly
Another candidate, in conversion regression testing now. Eric Faulhaber
09:49 AM Database Bug #2097: FOR EACH with multiple, nested CAN-FINDs converts badly
While there are a number of expected differences, there are also still some regressions, though far fewer than the la... Eric Faulhaber
05:37 AM Database Bug #2097: FOR EACH with multiple, nested CAN-FINDs converts badly
Fix candidate for regressions. Testing now. Eric Faulhaber
04:53 AM Database Bug #2097: FOR EACH with multiple, nested CAN-FINDs converts badly
This update regresses many files in Majic; cannot check it in. Eric Faulhaber
03:59 AM Database Bug #2097: FOR EACH with multiple, nested CAN-FINDs converts badly
Missed a bit of cleanup in one of the files. Eric Faulhaber
03:48 AM Database Bug #2097: FOR EACH with multiple, nested CAN-FINDs converts badly
A fix candidate and test cases are attached. I am currently putting the fix through conversion regression testing. ... Eric Faulhaber
04:14 PM Base Language Feature #1626: implement OS-DIR support as an INPUT stream
Added proposed update.The update is for both #1613 and #1626 Costin Savin
04:13 PM Base Language Feature #1613: finish FILE-INFO system handle support
Added proposed update.The update is for both #1613 and #1626 Costin Savin
03:58 PM Database Feature #2080: add runtime support for database methods
OK, I forgot that the ERROR attribute is set for error conditions raised when the NO-ERROR clause is used (this expla... Constantin Asofiei
03:30 PM Database Feature #2080: add runtime support for database methods
Constantin,
I have removed @SESSION:SUPPRESS-WARNINGS = YES.@ and started from command line. But it did not affect ...
Vadim Nebogatov
05:42 AM Database Feature #2080: add runtime support for database methods
I do not understand which line of code generates the 9039 and 12860 messages. Please remove the @SESSION:SUPPRESS-WAR... Constantin Asofiei
02:34 PM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
This is the fix for the note 178 above, please review.
If some other categories of compiler are found, the constants...
Ovidiu Maxiniuc
12:11 PM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
om_upd20130325a.zip has passed testing. Please check it in and distribute it. Greg Shah
10:53 AM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
Yes, I agree. Let's implement all of the compiler constants now and do it right. Please create a new function in co... Greg Shah
10:38 AM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
Greg, this is one question for you.
Consider this 4GL code:...
Ovidiu Maxiniuc
08:17 AM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
This looks good. I will conversion regression test it now. Greg Shah
04:06 AM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
This is a small signature fix for the following P4GL functions:... Ovidiu Maxiniuc
01:01 PM Database Bug #2095: FIELDS/EXCEPT record phrase options not honored
The current fix doesn't work for all cases, e.g.:
1. REPEAT PRESELECT.
2. DEFINE QUERY.
Note that FIELDS/EXCEP...
Stanislav Lomany
11:42 PM Database Bug #2095 (Review): FIELDS/EXCEPT record phrase options not honored
The update has passed conversion regression testing and I have committed it to bzr rev. 10329. Eric Faulhaber
10:43 PM Database Bug #2095: FIELDS/EXCEPT record phrase options not honored
The update looks good to me. I am running conversion regression testing on it now. Eric Faulhaber
08:00 PM Database Bug #2095: FIELDS/EXCEPT record phrase options not honored
Fixes the cases specified in note #2. Probably fixes all other cases too. Stanislav Lomany
08:40 AM Base Language Feature #1584: add conversion and runtime support for INT64 and DATETIME data types
Ovidiu: your next priority should be completing the runtime work on this task. The first priority is to get the int6... Greg Shah

03/24/2013

05:33 PM Database Bug #2101 (Closed): multi-buffer FOR loop with rowid and to-rowid functions in WHERE clause not c...
I've compared conversions of the customer's server project with and without this fix and it seems correct in all the ... Eric Faulhaber
09:46 PM Database Bug #2101 (Review): multi-buffer FOR loop with rowid and to-rowid functions in WHERE clause not c...
Update ecf_upd20130323a.zip has passed conversion regression testing and is committed to bzr rev. 10325. Eric Faulhaber
08:23 PM Database Bug #2101: multi-buffer FOR loop with rowid and to-rowid functions in WHERE clause not converting...
Although I'm not the assignee, in having to think through the problem for the above post, I took a quick look at the ... Eric Faulhaber
05:27 PM Database Bug #2094: OUTER-JOIN record phrase option not honored
BTW, location of the original problem is pmplan/gapptfn5.p.cache, line 700. Eric Faulhaber
05:25 PM Database Bug #2094 (Review): OUTER-JOIN record phrase option not honored
Passed conversion regression testing, committed to bzr revision 10328. I'll do a separate server folder conversion wi... Constantin Asofiei
05:03 PM Database Bug #2094: OUTER-JOIN record phrase option not honored
Change looks good to me. Please check in and distribute if/when it passes conversion regression testing. Eric Faulhaber
04:04 PM Database Bug #2094 (WIP): OUTER-JOIN record phrase option not honored
Constantin Asofiei
03:47 PM Database Bug #2094: OUTER-JOIN record phrase option not honored
Properly handles the @OUTER-JOIN@ and @LEFT OUTER-JOIN@ to convert the same. Constantin Asofiei
03:37 PM Database Bug #2094: OUTER-JOIN record phrase option not honored
This update adds support for the OUTER-JOIN clause for a record phrase. -The LEFT OUTER-JOIN will not emit anything.-... Constantin Asofiei
10:09 PM Database Bug #2094: OUTER-JOIN record phrase option not honored
The following:... Eric Faulhaber
05:10 PM Database Bug #2097: FOR EACH with multiple, nested CAN-FINDs converts badly
I'm working toward what I think the correct conversion would be:... Eric Faulhaber
04:29 PM Database Feature #2080: add runtime support for database methods
Constantin, I use ErrorManager.recordOrThrowError.
In my example above, 4GL meets errors 9039 and 12860 with differ...
Vadim Nebogatov
07:29 AM Database Feature #2080: add runtime support for database methods
PS: about @SESSION:SUPPRESS-WARNINGS = YES.@. Note that in the 4GL editor, if you run a program which doesn't set the... Constantin Asofiei
07:26 AM Database Feature #2080: add runtime support for database methods
> Another observation. Not all 4GL errors throw “exceptions”, some of them look like not critical errors or warnings,... Constantin Asofiei
07:20 AM Database Feature #2080: add runtime support for database methods
Another observation. Not all 4GL errors throw “exceptions”, some of them look like not critical errors or warnings, e... Vadim Nebogatov
03:53 AM Database Feature #2080: add runtime support for database methods
> Conversion code should also support this option, returning value if ON-ERROR is set (current behaviour) and propaga... Constantin Asofiei
03:51 AM Database Feature #2080: add runtime support for database methods
Constantin: yes, it is just switch in behavior I was looking.
Conversion code should also support this option, retur...
Vadim Nebogatov
03:07 AM Database Feature #2080: add runtime support for database methods
Eric/Vadim: there is another way to supress the 4GL's errors, the @NO-ERROR@ clause. When trying to understand when a... Constantin Asofiei
02:02 AM Database Feature #2080: add runtime support for database methods
Yes, I also think so. Return value has no sense if 4gl propagates its "exceptions". I only thought that maybe this pr... Vadim Nebogatov
09:26 PM Database Feature #2080: add runtime support for database methods
This indicates that the idiom of:... Eric Faulhaber
03:32 PM Conversion Tools Feature #2053 (Closed): create a parameter type lookup facility for built-in functions and handle...
Greg Shah
03:31 PM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
Passed conversion regression testing and is checked int obzr as revision 10327. Runtime regression testing will be r... Greg Shah
12:29 PM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
And this is the update. Greg Shah
12:29 PM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
This version clears all the regressions and also fixes note 157. The changes in Majic listed in note 171 are believed... Greg Shah
09:11 AM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
Some unexpected changes were found in regression testing. I suspect these are wrong.... Greg Shah
07:40 AM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
This case is regressed with GES 0323b (from the server folders):... Constantin Asofiei
08:40 PM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
This update fixes the regressions in Majic (although there is still 1 change that is expected but will need to be che... Greg Shah
10:11 PM Database Bug #2084 (Closed): Conversion misplaced parameter for can-find statement
Eric Faulhaber
10:10 PM Database Feature #2000 (Closed): add conversion support for table and table handle parameters
Eric Faulhaber
09:49 PM Database Feature #2092 (Closed): add server-side database support for several builtin functions
Eric Faulhaber

03/23/2013

06:54 PM Database Feature #1668: add support for additional (non-dynamic) database attributes
This update has passed conversion regression testing (CA 0323d used deleteRecord for the "quick_delete" loops, instea... Constantin Asofiei
12:58 PM Database Feature #1668: add support for additional (non-dynamic) database attributes
ca_upd20130323d.zip update looks good to me. If it passes conversion regression testing (expect some changes to Maji... Eric Faulhaber
12:52 PM Database Feature #1668: add support for additional (non-dynamic) database attributes
Replaces ca_upd2013023a.zip, and has the changes from note 105. Constantin Asofiei
12:33 PM Database Feature #1668: add support for additional (non-dynamic) database attributes
You are not missing anything, this is the first time I touch embedded sqls, so that's why the questions. Now I have a... Constantin Asofiei
12:30 PM Database Feature #1668: add support for additional (non-dynamic) database attributes
This refers to:... Eric Faulhaber
12:23 PM Database Feature #1668: add support for additional (non-dynamic) database attributes
For embedded SQL, I was referring to this rule in convert/database_access:... Constantin Asofiei
12:19 PM Database Feature #1668: add support for additional (non-dynamic) database attributes
Let's use:... Eric Faulhaber
11:38 AM Database Feature #1668: add support for additional (non-dynamic) database attributes
Eric: the ca_upd20130323a.zip has regressions. I see that the Buffer.delete API is used by other cases, like DELETE s... Constantin Asofiei
10:23 AM Database Feature #1668: add support for additional (non-dynamic) database attributes
This update changes the API for BUFFER-DELETE to deleteRecord, because else will collide with the resource's delete()... Constantin Asofiei
06:53 PM Database Feature #2080: add runtime support for database methods
Also I have noticed the difference in behavior of 4GL and converted code.
I am comparing a lot of tests in the form...
Vadim Nebogatov
06:50 PM Database Bug #2101: multi-buffer FOR loop with rowid and to-rowid functions in WHERE clause not converting...
This issue was first reported in note 192 of #2068.
The following converts badly:...
Eric Faulhaber
06:34 PM Database Bug #2101 (Closed): multi-buffer FOR loop with rowid and to-rowid functions in WHERE clause not c...
Eric Faulhaber
06:40 PM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
The changes in note 161 did cause some regressions in Majic. I have fixed all but one of them. As soon as that one ... Greg Shah
05:17 PM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
You are correct, the approach you mentioned from functions.rules matches the not-needed cases too.
> I can't really ...
Constantin Asofiei
05:07 PM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
Part of the issue with note 155 is the over-aggressive setting of ignorecast in annotations/functions.rules:... Greg Shah
04:44 PM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
The update looks OK, I can't find any obvious flaws in the logic. Constantin Asofiei
04:26 PM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
About note 157: please see the handle_dyn_func6.p and handle_dyn_func5b.p (the substring issue at note 157 is from he... Constantin Asofiei
04:18 PM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
The extra ';' might be related to the comments changes. For query-prepare (and dynamic-function as parameter in gener... Constantin Asofiei
04:16 PM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
In regard to note 155, the same testcase is a bit different after my changes in note 161. Here is the output:
<pr...
Greg Shah
03:04 PM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
Here is the proposed update to resolve notes 135 and 139. This resolves all known cases of these problems.
I will...
Greg Shah
03:18 PM Base Language Bug #2070: BlockManager Action disambiguation
Converting the extent_params_proc.p test on windows fails with this:... Constantin Asofiei
10:04 AM Conversion Tools Bug #2066: brew adds unnecessary comma in method parameter list after comment
ca_upd20130322i.zip was committed to bzr revision 10320. MAJIC conversion regression testing has passed (with comment... Constantin Asofiei

03/22/2013

05:38 PM Database Bug #2095: FIELDS/EXCEPT record phrase options not honored
> I still think the include/exclude call should directly follow the associated addComponent call. I think it is easie... Stanislav Lomany
05:31 PM Database Bug #2095: FIELDS/EXCEPT record phrase options not honored
I guess there's one more option; chain the call, as in:... Eric Faulhaber
05:04 PM Database Bug #2095: FIELDS/EXCEPT record phrase options not honored
So if the full list of options is:
1. Add the list of fields to query c'tor / addComponent
2. include(String ...) -...
Stanislav Lomany
04:34 PM Database Bug #2095: FIELDS/EXCEPT record phrase options not honored
Stanislav Lomany wrote:
> For a multi-table query the buffer should be specified, but as an option we can have quali...
Eric Faulhaber
04:28 PM Database Bug #2095: FIELDS/EXCEPT record phrase options not honored
For a multi-table query the buffer should be specified, but as an option we can have qualified field names:... Stanislav Lomany
03:32 PM Database Bug #2095: FIELDS/EXCEPT record phrase options not honored
OK, but please emit this method immediately after the associated @addComponent@ call.
> ...
Eric Faulhaber
03:07 PM Database Bug #2095: FIELDS/EXCEPT record phrase options not honored
Unless someone has objections, for multi-component queries, I'll make include/exclude methods of the parent query:
<...
Stanislav Lomany
11:42 AM Database Bug #2095: FIELDS/EXCEPT record phrase options not honored
> Removes FIELDS/EXCEPT nodes.
Thanks, I'm starting server folder conversion, hope nothing new will appear.
Constantin Asofiei
11:36 AM Database Bug #2095: FIELDS/EXCEPT record phrase options not honored
Removes FIELDS/EXCEPT nodes. Stanislav Lomany
10:38 AM Database Bug #2095: FIELDS/EXCEPT record phrase options not honored
OK Stanislav Lomany
10:14 AM Database Bug #2095: FIELDS/EXCEPT record phrase options not honored
Stanislav: if it doesn't take you long to build some rules which just drop/hide the FIELDS/EXCEPT nodes (so they will... Constantin Asofiei
04:25 PM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
Ovidiu: please post here all the cases related to LENGTH function which are not converting properly (the cases when t... Constantin Asofiei
02:43 PM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
OK, I think the case at note 155 here is related to 157. I'll wait for your changes before continuing. Constantin Asofiei
01:39 PM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
> If think for such cases ECW should return null, if the function's return type and the parameter's type are not comp... Greg Shah
11:24 AM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
There is a problem in ECW/base_structure. For a case like:... Constantin Asofiei
10:07 AM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
No, I haven't looked at this case. Greg Shah
09:59 AM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
Greg, have you touched this case:... Constantin Asofiei
09:33 AM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
ca_upd20130322d.zip committed to bzr revision 10312. Constantin Asofiei
08:20 AM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
It is good. Check it in and distribute it if it passes testing. Greg Shah
07:23 AM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
I think I found the problem for the BEGINS operator problem @if h:buffer-value begins ch then message "blah".@. In op... Constantin Asofiei
04:22 PM Conversion Tools Bug #2066: brew adds unnecessary comma in method parameter list after comment
I agree. The approach you have taken is fine for now.
I also agree that we will need to make additional changes t...
Greg Shah
04:09 PM Conversion Tools Bug #2066: brew adds unnecessary comma in method parameter list after comment
This is a quirk for the SWITCH statement comment case. At this time, I think convert/comments.rules might be incomple... Constantin Asofiei
02:32 PM Database Feature #1668: add support for additional (non-dynamic) database attributes
Costin Savin wrote:
> Well theoreticaly it is already there because both Buffer and TempTable extend it, but probabl...
Constantin Asofiei
02:32 PM Database Feature #1668: add support for additional (non-dynamic) database attributes
Well theoreticaly it is already there because both Buffer and TempTable extend it, but probably it's good to see it i... Costin Savin
02:12 PM Database Feature #1668: add support for additional (non-dynamic) database attributes
Costin, regarding cs_upd20130322b.zip - you forgot to add the new interface to HandleCommon. Please put it right afte... Constantin Asofiei
01:43 PM Database Feature #1668: add support for additional (non-dynamic) database attributes
Commited as revision number 10317 Costin Savin
01:07 PM Database Feature #1668: add support for additional (non-dynamic) database attributes
cs_upd20130322b.zip has passed conversion regression testing. Please check it in and distribute. Eric Faulhaber
10:54 AM Database Feature #1668: add support for additional (non-dynamic) database attributes
cs_upd20130322b.zip looks good. I am putting it through conversion regression testing.
It does look like we still...
Eric Faulhaber
08:21 AM Database Feature #1668: add support for additional (non-dynamic) database attributes
Added proposed update for missing addFieldToIndex methods. Moved the defaultBufferHandle() method form the Buffer int... Costin Savin
05:06 AM Database Feature #1668: add support for additional (non-dynamic) database attributes
This class evolved a little. The @defaultBufferHandle()@ (implementation of @DEFAULT-BUFFER-HANDLE@) was at the begin... Ovidiu Maxiniuc
04:35 AM Database Feature #1668: add support for additional (non-dynamic) database attributes
> ADMData was my mistake (should have not added it, as I don't see the ADM-DATA attribute defined for the temp-table ... Constantin Asofiei
02:15 PM Database Feature #2080: add runtime support for database methods
I have noticed from testing in 4GL that error message... Vadim Nebogatov
10:46 AM Database Feature #1947: add conversion support for database methods
CA 0322c.zip was committed to bzr revision 10315 and CA 0322e.zip to 10316. Constantin Asofiei
10:40 AM Database Feature #1947: add conversion support for database methods
Both updates look good, please check them in. Eric Faulhaber
09:30 AM Database Feature #1947: add conversion support for database methods
Both 0322c.zip and 0322e.zip have passed conversion regression testing. Constantin Asofiei
07:42 AM Database Feature #1947: add conversion support for database methods
Adds missing @queryRows(integer)@ API. Constantin Asofiei
06:49 AM Database Feature #1947: add conversion support for database methods
Solved note 151 by always expanding array vars passed to the REPOSITION-TO-ROWID method. This avoids adding an @query... Constantin Asofiei
06:06 AM Database Feature #1947: add conversion support for database methods
I'm working on note 151. Constantin Asofiei
05:23 AM Database Feature #1947: add conversion support for database methods
See note 202 from #2068, which documents a server failure. Note that the @REPOSITION-TO-ROWID@ can accept mixed exten... Constantin Asofiei
10:24 AM Database Feature #2000: add conversion support for table and table handle parameters
ca_upd20130322g.zip committed to bzr revision 10214. Constantin Asofiei
09:15 AM Database Feature #2000: add conversion support for table and table handle parameters
The code looks fine. If it passes testing, check it in and distribute it. Greg Shah
09:11 AM Database Feature #2000: add conversion support for table and table handle parameters
Fixes a regression in the TABLE-HANDLE parameter conversion, introduced by 10293. Constantin Asofiei
08:55 AM Database Feature #2000: add conversion support for table and table handle parameters
OK, I'll look at it. Constantin Asofiei
08:15 AM Database Feature #2000: add conversion support for table and table handle parameters
It has been regressed since revision 10279.
Correct output is:...
Stanislav Lomany
07:38 AM Database Feature #2000: add conversion support for table and table handle parameters
Stanislav: did this convert properly after you added TABLE-HANDLE parameter support?... Constantin Asofiei
09:37 AM Base Language Feature #1920: implement persistent procedures
Merged with latest bzr version, contains both CA 0322a.zip and CA 0322f.zip changes. committed to bzr revision 10313. Constantin Asofiei
08:24 AM Base Language Feature #1920: implement persistent procedures
The code is OK. It can be committed and distributed when it passes testing. Greg Shah
07:54 AM Base Language Feature #1920: implement persistent procedures
Fixes the case when a method param has subscript:... Constantin Asofiei
06:04 AM Base Language Feature #1920: implement persistent procedures
The code is OK. If it passes conversion testing you can check it in and distribute it. Greg Shah
05:31 AM Base Language Feature #1920: implement persistent procedures
Fixed conversion support for HANDLE attribute, when used with system handles:... Constantin Asofiei
08:18 AM Database Feature #2092: add server-side database support for several builtin functions
Go ahead and check this in immediately (and distribute it). It has no effect on conversion and it is already being r... Greg Shah
07:07 AM Database Feature #2092: add server-side database support for several builtin functions
Removed the extra ' character from p2jpl.ddr at line 699 Costin Savin
06:59 AM Base Language Feature #1608: implement full appserver support (from 4GL clients only)
Checked in to bzr as revision 10310. Costin Savin
05:26 AM Base Language Feature #1608: implement full appserver support (from 4GL clients only)
Conversion testing passed. Check it in and distribute it. Greg Shah

03/21/2013

04:10 PM Base Language Feature #1608: implement full appserver support (from 4GL clients only)
Added merged update Costin Savin
01:51 PM Base Language Feature #1608: implement full appserver support (from 4GL clients only)
Code Feedback:
1. The javadoc and formatting of ConnectableServer should be this:...
Greg Shah
01:13 PM Base Language Feature #1608: implement full appserver support (from 4GL clients only)
Added proposed update which fixes connect for AppServer Costin Savin
10:37 AM Base Language Feature #1608: implement full appserver support (from 4GL clients only)
You can force things to be wrapped in that case where there is more than 1 parameter. Greg Shah
10:27 AM Base Language Feature #1608: implement full appserver support (from 4GL clients only)
> [javac] .../server/common/Apitest1.java:134: error: no suitable method found for connect(String,character,character... Costin Savin
03:54 PM Database Feature #1668: add support for additional (non-dynamic) database attributes
From the TEMP-TABLE attributes the following are not implemented in any interface:
AFTER-TABLE, BEFORE-TABLE, DATA...
Costin Savin
01:54 PM Database Feature #1668: add support for additional (non-dynamic) database attributes
Eric/Costin: there is one more thing we should do - identify all attributes which are already defined by interfaces (... Constantin Asofiei
01:49 PM Database Feature #1668: add support for additional (non-dynamic) database attributes
> So, Costin: please remove Buffer and ADMData from the TempTable interface and post here what method stubs are still... Costin Savin
01:42 PM Database Feature #1668: add support for additional (non-dynamic) database attributes
So, Costin: please remove Buffer and ADMData from the TempTable interface and post here what method stubs are still ... Eric Faulhaber
01:39 PM Database Feature #1668: add support for additional (non-dynamic) database attributes
Constantin Asofiei wrote:
> Why is TempTable interface extending Buffer, ADMData and UniqueID interfaces?
Good qu...
Eric Faulhaber
01:38 PM Database Feature #1668: add support for additional (non-dynamic) database attributes
ADMData was my mistake (should have not added it, as I don't see the ADM-DATA attribute defined for the temp-table re... Constantin Asofiei
01:31 PM Database Feature #1668: add support for additional (non-dynamic) database attributes
Eric/Ovidiu/Costin: the interfaces extended by TempTable don't look OK. In the docs, the temp-table resource can acce... Constantin Asofiei
01:30 PM Database Feature #1668: add support for additional (non-dynamic) database attributes
Costin Savin wrote:
> > That's strange, all the TempTable methods should be implemented in TempTableBuilder, AFAIK. ...
Eric Faulhaber
01:25 PM Database Feature #1668: add support for additional (non-dynamic) database attributes
> That's strange, all the TempTable methods should be implemented in TempTableBuilder, AFAIK. I don't know why they a... Costin Savin
12:55 PM Database Feature #1668: add support for additional (non-dynamic) database attributes
Vadim, your 20130321a update has passed conversion regression testing. Please check it in (and the test case) and di... Eric Faulhaber
11:50 AM Database Feature #1668: add support for additional (non-dynamic) database attributes
Ovidiu Maxiniuc wrote:
> > That's strange, all the TempTable methods should be implemented in TempTableBuilder, AFAI...
Eric Faulhaber
11:36 AM Database Feature #1668: add support for additional (non-dynamic) database attributes
Code review 20130321a:
Looks good, I'm putting it through conversion regression test now.
Eric Faulhaber
10:59 AM Database Feature #1668: add support for additional (non-dynamic) database attributes
Update vmn_upd20130321a.zip (vmn_upd20130321b.zip - conversion test) is replacement of vmn_upd20130320a.zip (vmn_upd2... Vadim Nebogatov
09:17 AM Database Feature #1668: add support for additional (non-dynamic) database attributes
> That's strange, all the TempTable methods should be implemented in TempTableBuilder, AFAIK. I don't know why they ... Ovidiu Maxiniuc
06:55 AM Database Feature #1668: add support for additional (non-dynamic) database attributes
> Please post your test case.
I used the pers-addr table from p2j_test and created a temp table like pers-addr and...
Costin Savin
02:20 PM Database Bug #2095: FIELDS/EXCEPT record phrase options not honored
Stanislav Lomany wrote:
> Do I need to ensure that there are no duplicates in the converted list (e.g. if we are con...
Eric Faulhaber
02:01 PM Database Bug #2095: FIELDS/EXCEPT record phrase options not honored
It is possible to reference an element of an extent field. The progress documentation says that "If field is an array... Stanislav Lomany
11:21 AM Database Bug #2095 (WIP): FIELDS/EXCEPT record phrase options not honored
Stanislav Lomany
01:32 PM Base Language Bug #2099 (Closed): "ASSIGN widget." statement does not convert properly in some cases
Greg Shah
12:53 PM Base Language Bug #2099 (Review): "ASSIGN widget." statement does not convert properly in some cases
> Check it in and distribute it.
Committed to bzr revision 10308.
Constantin Asofiei
12:46 PM Base Language Bug #2099: "ASSIGN widget." statement does not convert properly in some cases
This looks good. Check it in and distribute it. Greg Shah
11:41 AM Base Language Bug #2099: "ASSIGN widget." statement does not convert properly in some cases
This update has passed conversion regression testing. There are some changes in MAJIC, but they do not affect runtime... Constantin Asofiei
09:45 AM Base Language Bug #2099: "ASSIGN widget." statement does not convert properly in some cases
I'm still missing something, lots of invalid changes in MAJIC. Constantin Asofiei
08:58 AM Base Language Bug #2099: "ASSIGN widget." statement does not convert properly in some cases
This is a fix attempt for this issue. Looks like the solution was to explicitly set the frame name, in case the "fram... Constantin Asofiei
01:30 PM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
While working on #2068 note 187, I encountered the following case:... Ovidiu Maxiniuc
09:48 AM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
Here is the final version of the indeterminate cases. I have done 2 equivalent versions: one using buffer-value and ... Greg Shah
11:23 AM Base Language Feature #2089 (Closed): INPUT function returning string value
Greg Shah
10:37 AM Base Language Feature #2089: INPUT function returning string value
Please do check in and distribute the change. Greg Shah
10:14 AM Base Language Feature #2089: INPUT function returning string value
Yes, they all are OK. Stanislav Lomany
09:51 AM Base Language Feature #2089: INPUT function returning string value
Here are the results of the conversion testing:... Greg Shah
08:12 AM Base Language Feature #2089: INPUT function returning string value
Code Review:
It looks good. 1 minor issue: the comment was corrupted in "handle_implicit_input" in the latest com...
Greg Shah
09:51 AM Database Feature #2000 (Review): add conversion support for table and table handle parameters
Stanislav Lomany

03/20/2013

06:55 PM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
OK, this testcase is close to being done. It shows the really insane variety of possibilities with the truly dynamic... Greg Shah
06:05 PM Database Feature #1668: add support for additional (non-dynamic) database attributes
Code review 20130320a:
All looks good except QueryWrapper: the new @numBuffers@ method implementation should dele...
Eric Faulhaber
05:38 PM Database Feature #1668: add support for additional (non-dynamic) database attributes
Update vmn_upd20130320a.zip (vmn_upd20130320b.zip - conversion test) contains correction of NUM-BUFFERS()(KW_NUM_BUFF... Vadim Nebogatov
02:07 PM Database Feature #1668: add support for additional (non-dynamic) database attributes
Costin Savin wrote:
> Tested this case, The result is a runtime error message: @"Third argument to ADD-INDEX-FIELD m...
Eric Faulhaber
02:05 PM Database Feature #1668: add support for additional (non-dynamic) database attributes
> Write a test case and see what happens if you pass in something other than "asc" or "desc" as the last parameter. D... Costin Savin
01:07 PM Database Feature #1668: add support for additional (non-dynamic) database attributes
Costin Savin wrote:
> there are only these methods defined in the TempTable interface:
> public logical addFieldTo...
Eric Faulhaber
12:37 PM Database Feature #1668: add support for additional (non-dynamic) database attributes
For:... Costin Savin
05:54 PM Base Language Feature #1641: implement SAX XML support
The update evl_upd20130320b.zip has been committed in bzr as 10303. Eugenie Lyzenko
05:46 PM Base Language Feature #1641: implement SAX XML support
> If it passes testing you can check it in and distribute it.
Conversion testing has been passed. I'm going to com...
Eugenie Lyzenko
04:40 PM Base Language Feature #1641: implement SAX XML support
If it passes testing you can check it in and distribute it. Greg Shah
03:11 PM Base Language Feature #1641: implement SAX XML support
This update merged with bzr 10302. Starting the conversion testing. Eugenie Lyzenko
02:46 PM Base Language Feature #1641: implement SAX XML support
Code feedback: everything looks good.
The only issue is that you need to merge with the recent bzr revision. Ple...
Greg Shah
02:36 PM Base Language Feature #1641: implement SAX XML support
The update includes:
1. Changing for constant types.
2. Adding history entries.
3. Fixes for misspelled words in S...
Eugenie Lyzenko
02:38 PM Database Feature #2092: add server-side database support for several builtin functions
Update cs_upd20130320a1.zip has passed conversion regression testing and is committed to bzr rev. 10301. Eric Faulhaber
01:29 PM Database Feature #2092: add server-side database support for several builtin functions
Code review 20130320a:
This one is mostly correct, except for the following:
* @Functions.minimum(Date var1, Date...
Eric Faulhaber
11:55 AM Database Feature #2092: add server-side database support for several builtin functions
Added proposed update, for the testcase it seems you can't define a field as rowid in 4gl so I modified that part.
W...
Costin Savin
05:35 AM Database Feature #2092: add server-side database support for several builtin functions
Costin: the test you've uploaded doesn't work with the repository p2j_test.df schema definition. When modifying the p... Constantin Asofiei
02:16 PM Base Language Feature #2089: INPUT function returning string value
Yes, please do. Greg Shah
02:13 PM Base Language Feature #2089: INPUT function returning string value
> When we search upward for KW_VALIDATE and enable implicit input testing, we must ensure that we are a descendant of... Stanislav Lomany
02:00 PM Base Language Feature #2089: INPUT function returning string value
When we search upward for KW_VALIDATE and enable implicit input testing, we must ensure that we are a descendant of t... Greg Shah
01:49 PM Base Language Feature #2089: INPUT function returning string value
Note that... Stanislav Lomany
12:26 PM Base Language Bug #2099: "ASSIGN widget." statement does not convert properly in some cases
This case was exposed by server folder compilation, in #2068 note 172:... Constantin Asofiei
12:08 PM Base Language Bug #2099 (Closed): "ASSIGN widget." statement does not convert properly in some cases
Constantin Asofiei

03/19/2013

07:46 PM Base Language Feature #2089: INPUT function returning string value
1 compile problem in Majic:... Greg Shah
03:13 PM Base Language Feature #2089: INPUT function returning string value
The code looks good. I will put it into conversion testing here since it will be faster. Greg Shah
02:58 PM Base Language Feature #2089: INPUT function returning string value
Not yet regression-tested. Stanislav Lomany
09:42 AM Base Language Feature #2089: INPUT function returning string value
> Stanislav: when will the update be ready?
I'm writing javadocs / merging it.
Stanislav Lomany
09:17 AM Base Language Feature #2089: INPUT function returning string value
Actually, this should be pretty much done at this point. Let's finish it now.
Stanislav: when will the update be ...
Greg Shah
07:51 AM Base Language Feature #2089: INPUT function returning string value
Greg/Stanislav: we can make this a low priority, as after the latest schema VALEXP changes in #1620, the problematic ... Constantin Asofiei
04:29 PM Database Feature #2092: add server-side database support for several builtin functions
Code review 20130319a:
* common-progress.rules: changes look good, but see comment below about max/min.
* where-...
Eric Faulhaber
02:29 PM Database Feature #2092: add server-side database support for several builtin functions
Re-arranged the code , solved the reviewed problems and merged with latest updates.
Testcase used to check convers...
Costin Savin
01:29 AM Database Feature #2092: add server-side database support for several builtin functions
Costin Savin wrote:
> Added merged update.
> Are there any other functions that need to be added? I saw DATETIME an...
Eric Faulhaber
01:11 PM Database Feature #1668: add support for additional (non-dynamic) database attributes
Constantin Asofiei wrote:
> For this, I think we should add a @P2JQuery.tableCount@ API which returns @integer@ and ...
Eric Faulhaber
07:30 AM Database Feature #1668: add support for additional (non-dynamic) database attributes
Eric,
> * num-buffers [KW_NUM_BUFF] (seems buggy) (I think this should map to P2JQuery.getTableCount, which already ...
Constantin Asofiei
11:41 AM Base Language Feature #1641: implement SAX XML support
> AFAIK any field declared in an interface is by default "static final" (the compiler takes care to put these modifie... Greg Shah
11:08 AM Base Language Feature #1641: implement SAX XML support
> 1. Please make the constants all @public final static@ instead of just @public@ (which is editable, something we do... Constantin Asofiei
09:45 AM Base Language Feature #1641: implement SAX XML support
Code Feedback (Eugenie: you can make the final changes to the code Constantin posted):
1. Please make the constant...
Greg Shah
08:18 AM Base Language Feature #1641: implement SAX XML support
Eugenie: attached you have the runtime support for this; please go ahead with the conversion support.
Greg: the co...
Constantin Asofiei
08:13 AM Base Language Feature #1641: implement SAX XML support
Eugenie, please implement the following:
These constants are recognized by the parser but we do not emit them as l...
Greg Shah
07:57 AM Database Bug #2093: VALEXP support in P2J
The AST is slightly different with last revision from bzr:... Ovidiu Maxiniuc
07:20 AM Database Bug #2093: VALEXP support in P2J
Please check the failed case in the previous note with the latest #1620 fix, if you haven't done already so. Constantin Asofiei
07:09 AM Database Bug #2093: VALEXP support in P2J
Everything seems to work smooth, validation is only generated in @schema-validation@:... Ovidiu Maxiniuc
04:03 AM Database Bug #2093: VALEXP support in P2J
Ovidiu: with the #1620 changes, I can't see any more schema VALEXP problems in the logs (I think P2J was too aggressi... Constantin Asofiei
07:03 AM Base Language Feature #1620: implement EXTENT parameter support
Attached merged update, committed to bzr revision 10298. Constantin Asofiei
07:02 AM Base Language Feature #1620: implement EXTENT parameter support
> If it passes conversion testing AND if you deem the Majic changes to be correct, then go ahead and check in/distrib... Constantin Asofiei
04:22 AM Conversion Tools Bug #2066: brew adds unnecessary comma in method parameter list after comment
wrong task Constantin Asofiei
04:12 AM Conversion Tools Bug #2066: brew adds unnecessary comma in method parameter list after comment
wrong task Constantin Asofiei
04:06 AM Conversion Tools Bug #2066: brew adds unnecessary comma in method parameter list after comment
wrong task Constantin Asofiei

03/18/2013

06:49 PM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
My changes do not work properly. Interestingly, even Majic has some pretty crazy combinations like this:
def var ...
Greg Shah
05:35 PM Base Language Feature #2089: INPUT function returning string value
Understood. Greg Shah
05:27 PM Base Language Feature #2089: INPUT function returning string value
> Also: this fuzzy matching may have bad side effects on other places we use expressionType(). For this reason, I th... Stanislav Lomany
03:36 PM Base Language Feature #2089: INPUT function returning string value
Yes, that is my point. getSignature(int, int, String[]) should be modified to return the default as the first one de... Greg Shah
03:13 PM Base Language Feature #2089: INPUT function returning string value
> In regard to your idea about a default signature, I am OK with that approach. How about this: if the signature mat... Stanislav Lomany
03:07 PM Base Language Feature #2089: INPUT function returning string value
Greg Shah wrote:
> OK, you have to some some additional things here.
>
> 1. Before you set the implicit_input, yo...
Stanislav Lomany
02:59 PM Base Language Feature #2089: INPUT function returning string value
OK, you have to some some additional things here.
1. Before you set the implicit_input, you must first know the de...
Greg Shah
02:14 PM Base Language Feature #2089: INPUT function returning string value
> Please post the code you are using to implement the implicit_input analysis.... Stanislav Lomany
01:50 PM Base Language Feature #2089: INPUT function returning string value
In regard to your idea about a default signature, I am OK with that approach. How about this: if the signature match... Greg Shah
01:34 PM Base Language Feature #2089: INPUT function returning string value
Please post the code you are using to implement the implicit_input analysis. Greg Shah
01:16 PM Base Language Feature #2089: INPUT function returning string value
> What is the problem with the use of ParmType.BDT (BaseDataType) as the 1st parameter (the way it was originally cod... Stanislav Lomany
12:19 PM Base Language Feature #2089: INPUT function returning string value
What is the problem with the use of ParmType.BDT (BaseDataType) as the 1st parameter (the way it was originally coded)? Greg Shah
11:25 AM Base Language Feature #2089: INPUT function returning string value
Signature of the @LENGTH@ function stored into @SignatureHelper.map_func@ map is @{ ParmType.BDT, ParmType.CHAR }@. A... Stanislav Lomany
04:28 PM Conversion Tools Feature #1603: enhance name conversion to support internal procedure names that contain a '.' cha...
The evl_upd20130318a.zip has been committed in bzr as 10296. As I note before it passed the conversion testing. Eugenie Lyzenko
04:08 PM Conversion Tools Feature #1603: enhance name conversion to support internal procedure names that contain a '.' cha...
Check it in and distribute it. Greg Shah
02:11 PM Conversion Tools Feature #1603: enhance name conversion to support internal procedure names that contain a '.' cha...
The update 20130318a has passed the conversion testing, compared directories are /ddl and /src/aero/timco/majic. Eugenie Lyzenko
12:13 PM Conversion Tools Feature #1603: enhance name conversion to support internal procedure names that contain a '.' cha...
The new update with scoping support has been added for review. The case when we has separate handling for button, rec... Eugenie Lyzenko
11:40 AM Conversion Tools Feature #1603: enhance name conversion to support internal procedure names that contain a '.' cha...
Yes, frames are scoped too. Greg Shah
10:26 AM Conversion Tools Feature #1603: enhance name conversion to support internal procedure names that contain a '.' cha...
I'm testing the implemented approach with dictionary usage. And I have a question. Do we need the same code to be imp... Eugenie Lyzenko
03:39 PM Database Feature #2080: add runtime support for database methods
Update vmn_upd20130318a.zip (vmn_upd20130318b.zip - tests) contains runtime support for BUFFER-COMPARE and some prepa... Vadim Nebogatov
12:30 PM Base Language Feature #1620: implement EXTENT parameter support
This makes sense. I should have read the surrounding code more carefully and I would have seen this.
If it passes...
Greg Shah
11:58 AM Base Language Feature #1620: implement EXTENT parameter support
> My only question is this: the schema_validation.rules includes support for the INSERT statement, but then the FORMA... Constantin Asofiei
11:52 AM Base Language Feature #1620: implement EXTENT parameter support
Code Review:
My only question is this: the schema_validation.rules includes support for the INSERT statement, but ...
Greg Shah
10:42 AM Base Language Feature #1620: implement EXTENT parameter support
New version of the update in which:
# the NO-VALIDATE clause with a frame must affect only the schema validation exp...
Constantin Asofiei
11:36 AM Database Bug #2097: FOR EACH with multiple, nested CAN-FINDs converts badly
This issue stems from note 127 in #2068.
The following code:...
Eric Faulhaber
11:16 AM Database Bug #2097 (Closed): FOR EACH with multiple, nested CAN-FINDs converts badly
Eric Faulhaber
08:23 AM Database Feature #2092: add server-side database support for several builtin functions
Added merged update.
Are there any other functions that need to be added? I saw DATETIME and DATETIME-TZ which fit t...
Costin Savin
06:34 AM Database Feature #2092: add server-side database support for several builtin functions
After some tests it seems that min and max can be applied also to character and date variables, not only numeric valu... Costin Savin
04:31 AM Database Feature #2092 (Review): add server-side database support for several builtin functions
Costin Savin
04:31 AM Database Feature #2092 (WIP): add server-side database support for several builtin functions
Costin Savin
12:12 AM Database Bug #2059 (Closed): CAN-FIND clause for a perm table in the RECORD_PHRASE of a temp table, with a...
Eric Faulhaber

03/17/2013

06:11 PM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
This set of changes resolves the problems in note 135 (literals.rules, ECW) and 139 (common-progress.rules). I also ... Greg Shah
04:07 AM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
Update for note 142 is at #2068, note 133 Constantin Asofiei
04:34 PM Base Language Feature #1620: implement EXTENT parameter support
I'm OK with the changes. If all of the Majic modifications appear to be correct, we will go ahead with runtime testin... Greg Shah
11:16 AM Base Language Feature #1620: implement EXTENT parameter support
There are lots of changes in MAJIC converted code, here are some examples:
# for extent fields, all elements get the...
Constantin Asofiei
10:03 AM Base Language Feature #1620: implement EXTENT parameter support
Renamed test file. Constantin Asofiei
10:01 AM Base Language Feature #1620: implement EXTENT parameter support
When fixing conversion of schema validation expressions for extent fields, it hit me that the P2J approach using SCHE... Constantin Asofiei
03:42 PM Database Bug #2077 (Closed): fix converted table and field name collisions
Eric Faulhaber
03:32 PM Database Bug #2084 (Review): Conversion misplaced parameter for can-find statement
Eric Faulhaber
03:31 PM Database Bug #2084: Conversion misplaced parameter for can-find statement
The net effect of the cs_upd20130314a.zip update is that the correct Java output is produced, but the change still le... Eric Faulhaber

03/16/2013

04:40 PM Conversion Tools Bug #2066: brew adds unnecessary comma in method parameter list after comment
There is a problem when the comment is emitted after the peer:... Constantin Asofiei
02:06 PM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
16a.zip was committed to bzr revision 10292. Constantin Asofiei
02:00 PM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
Looks good. Check it in and distribute it. Greg Shah
01:40 PM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
This update changes the ECW (by moving the ATTR_HANDLE test out of the simpleExpressionType) and the javadocs (I touc... Constantin Asofiei
01:20 PM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
I had the impression that this was fixed:... Constantin Asofiei
10:31 AM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
I will take notes 135 and 139. Greg Shah
10:25 AM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
Code Review (for all of the updates including 15c):
I am generally fine with the changes. There are some formatti...
Greg Shah
11:40 AM Conversion Tools Feature #1603: enhance name conversion to support internal procedure names that contain a '.' cha...
This is the reason we use the dictionary. The example in note 33 has 2 scopes. It will result in a parameter for th... Greg Shah
10:24 AM Database Feature #2092: add server-side database support for several builtin functions
Added proposed update,
For ROWID I didn't knew how a ROWID data type it's represented in the database so I assumed ...
Costin Savin

03/15/2013

05:57 PM Conversion Tools Feature #1603: enhance name conversion to support internal procedure names that contain a '.' cha...
... Eugenie Lyzenko
05:07 PM Conversion Tools Feature #1603: enhance name conversion to support internal procedure names that contain a '.' cha...
Ok, I just lost a comment due to "redmine wants me to login again" so here is the short part. Your approach is too ag... Constantin Asofiei
04:04 PM Conversion Tools Feature #1603: enhance name conversion to support internal procedure names that contain a '.' cha...
> What troubles you? The fact that the procedure's parameter gets promoted and collides with another proc's parameter... Eugenie Lyzenko
11:25 AM Conversion Tools Feature #1603: enhance name conversion to support internal procedure names that contain a '.' cha...
> The question is do we need to ignore 4GL case sensitivity?
Please test your case in 4GL environment, and you will...
Constantin Asofiei
11:19 AM Conversion Tools Feature #1603: enhance name conversion to support internal procedure names that contain a '.' cha...
The remaining conversion issue with recent changes is related to the name case sensitivity issue. Consider the follow... Eugenie Lyzenko
05:13 PM Database Feature #2080: add runtime support for database methods
Constantin's advice has gotten you past the immediate handle problem, but please re-read note 9. The runtime impleme... Eric Faulhaber
05:11 PM Database Feature #2080: add runtime support for database methods
Yes, it works, thank you Vadim Nebogatov
04:53 PM Database Feature #2080: add runtime support for database methods
Vadim, I don't think the runtime for the CREATE BUFFER statement is implemented. Try this instead:... Constantin Asofiei
04:41 PM Database Feature #2080: add runtime support for database methods
It seems, ... Vadim Nebogatov
12:09 PM Database Feature #2080: add runtime support for database methods
update [vmn_upd20130314a.zip]
Refs #2080, checked in as bzr revision 10291.
Corrected runtime for BUFFER-COPY (KW_B...
Vadim Nebogatov
11:52 AM Database Feature #2080: add runtime support for database methods
> Constantin: can you just pick up common-progress.rules from bzr and merge your quoter changes in?
OK, I'll wait f...
Constantin Asofiei
11:49 AM Database Feature #2080: add runtime support for database methods
Vadim: the 20130314a update looks good. Please go ahead and commit it to bzr.
Constantin: can you just pick up ...
Eric Faulhaber
11:39 AM Database Feature #2080: add runtime support for database methods
Constantin Asofiei wrote:
> Vadim, have you done the changes at notes #29? If yes, please upload just the common-pro...
Vadim Nebogatov
11:37 AM Database Feature #2080: add runtime support for database methods
Vadim, have you done the changes at notes #29? If yes, please upload just the common-progress.rules file. If not, I c... Constantin Asofiei
11:08 AM Database Feature #2080: add runtime support for database methods
Yes, the pairs parameter is in use. Eric Faulhaber
11:00 AM Database Feature #2080: add runtime support for database methods
What about pairs in RecordBuffer.compare()? Should it be supported? Vadim Nebogatov
10:39 AM Database Feature #2080: add runtime support for database methods
Vadim Nebogatov wrote:
> I am implementing now RecordBuffer.compare(Buffer buffer, character mode, character except,...
Eric Faulhaber
08:46 AM Database Feature #2080: add runtime support for database methods
I am implementing now RecordBuffer.compare(Buffer buffer, character mode, character except, character pairs) similar... Vadim Nebogatov
03:58 PM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
Another case which does not convert properly:... Constantin Asofiei
03:38 PM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
Another update, built on top of 15b:
# fix a NPE during conversion
# fix the MINIMUM/MAXIMUM functions, when used w...
Constantin Asofiei
12:25 PM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
Attached update is on top of 15a.zip and adds:
# field assignment, when the field is date/datetime/datetimetz, to al...
Constantin Asofiei
11:59 AM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
Another case of character c'tor derail:... Constantin Asofiei
10:54 AM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
Another weird issue which needs to be handled by the ECW. Following code is valid 4GL:... Constantin Asofiei
10:24 AM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
This update fixes:
# HANDLE attribute passed to method/function calls as a parameter (needs to be wrapped in a handl...
Constantin Asofiei
02:40 AM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
> Also, please do check in your 14b fix if/when it is OK.
Committed to bzr revision 10290, as the server folders conv...
Constantin Asofiei
08:13 PM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
I've been looking at the chaining problem. We have a model that is already pretty close. The OO features provide ch... Greg Shah
01:27 PM Database Bug #2095: FIELDS/EXCEPT record phrase options not honored
BTW, since multi-table queries also implement P2JQuery indirectly, they should throw UnsupportedOperationException fo... Eric Faulhaber
01:20 PM Database Bug #2095: FIELDS/EXCEPT record phrase options not honored
The runtime API will look like:... Eric Faulhaber
12:41 PM Database Bug #2095: FIELDS/EXCEPT record phrase options not honored
The use cases we must support:... Eric Faulhaber
12:16 PM Database Bug #2095: FIELDS/EXCEPT record phrase options not honored
Paraphrased from #2068:
Looks like P2J doesn't like the FIELDS clause, because with it, the fields get emitted as ...
Eric Faulhaber
12:12 PM Database Bug #2095 (Closed): FIELDS/EXCEPT record phrase options not honored
Eric Faulhaber
12:30 PM Database Bug #2084: Conversion misplaced parameter for can-find statement
Eric: I've put this through conversion regression testing (which has passed) plus server folder conversion, and I don... Constantin Asofiei
12:11 PM Database Bug #2094 (Closed): OUTER-JOIN record phrase option not honored
Eric Faulhaber
12:06 PM Database Bug #2093: VALEXP support in P2J
This issue is dedicated to note 80 from Issue #2068.
> There is this validation expression for the @dvofrsts.dvofr...
Ovidiu Maxiniuc
11:57 AM Database Bug #2093 (Closed): VALEXP support in P2J
Ovidiu Maxiniuc
02:06 AM Database Feature #2092: add server-side database support for several builtin functions
The following builtin functions are used within where clauses in queries and thus need to be supported as database se... Eric Faulhaber
01:14 AM Database Feature #2092 (Closed): add server-side database support for several builtin functions
Eric Faulhaber

03/14/2013

05:44 PM Database Feature #2080: add runtime support for database methods
What methods are priority for now? Vadim Nebogatov
05:43 PM Database Feature #2080: add runtime support for database methods
Attached update vmn_upd20130314a.zip (vmn_upd20130314b.zip - tests).
This update is replacement vmn_upd20130312a.z...
Vadim Nebogatov
03:12 PM Database Feature #2080: add runtime support for database methods
for note 22:
> Constantin: you didn't already do this, right?
No, I have not changed the @Buffer.findXXXX@ APIs
for ...
Constantin Asofiei
05:07 PM Base Language Feature #2089: INPUT function returning string value
... Greg Shah
09:55 PM Base Language Feature #2089: INPUT function returning string value
I have an update posted in #2053. It is in testing, but hopefully you can use it to test your changes. Greg Shah
04:55 PM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
Greg Shah wrote:
> In regard to note 116, I wonder where the extra wrapping is coming from. The h:label case is an A...
Constantin Asofiei
04:39 PM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
OK. Test your change and check it in if it is OK.
The parser is the best solution for this case. Yes, COLON (and...
Greg Shah
04:31 PM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
Greg Shah wrote:
> 14a causes the issue. I don't have the 14b applied. The testcase is checked in as well.
With 1...
Constantin Asofiei
04:19 PM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
14a causes the issue. I don't have the 14b applied. The testcase is checked in as well.
But if we are going to f...
Greg Shah
04:14 PM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
Do you mean 14a or 14b? The taks is #1920. Constantin Asofiei
04:13 PM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
Your recent update also causes this issue:... Greg Shah
04:12 PM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
PS: sorry, the JAST is the wrong one, I'll update the previous note shortly. Constantin Asofiei
04:10 PM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
The JAST at the time of the move_params is called, for the @h:buffer-field(ch):buffer-value@ part of the note 120's t... Constantin Asofiei
04:03 PM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
I don't see a problem with this, but honestly, I don't really fully understand the code in move_params. If it works,... Greg Shah
03:59 PM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
This update fixes case at note 120. I'm putting this back into conversion regression testing and into server folder c... Constantin Asofiei
03:57 PM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
In regard to note 116, I wonder where the extra wrapping is coming from. The h:label case is an ATTR_CHAR so there i... Greg Shah
03:48 PM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
Urgh... I should have waited 5 more minutes. My ca_upd20130314a.zip update regresses this test, during conversion (LE... Constantin Asofiei
03:40 PM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
> In regard to your update in note 115, check it in and distribute it.
Committed to bzr revision 10288.
Constantin Asofiei
03:36 PM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
The problem is that it wraps all parameters passed to the @concat@ API call, as in concat(new character(*"<", handle.... Constantin Asofiei
03:34 PM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
In regard to your update in note 115, check it in and distribute it.
In regard to note 116, I don't see where the ...
Greg Shah
03:23 PM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
Greg,
I've started per-folder conversion of the server project and I got this regression:...
Constantin Asofiei
03:14 PM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
The attached update has passed conversion regression testing. Constantin Asofiei
02:11 PM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
None at all. To make it generate instance method calls, only a few changes are needed in methods_attributes.rules (to... Constantin Asofiei
01:52 PM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
Remind me again: how much of the inversion problem is due to the fact that we use statics in handle for unwrapping in... Greg Shah
01:51 PM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
The ges_upd20130314d.zip passed conversion testing and checked in as bzr revision 10287. Greg Shah
01:49 PM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
With this in mind, note 93 looks like an effect of what we've discussed in the last 3 notes. I'll put the fix at note... Constantin Asofiei
01:46 PM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
> And AFAIK createPeerAst sets the peerid for the current processed node (the this node), right?
Yes.
> I think...
Greg Shah
01:44 PM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
Hmm... I see now what you mean. Note that in methods_attributes.rules, when we convert a METH_ node, the @this@ in th... Constantin Asofiei
01:33 PM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
The peerid that is added at the STRING node is done after any wrapping would have to take place. I am more concerned... Greg Shah
01:24 PM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
LE: I see the problem, is related to the fact that when move_params is called by methods_attributes.rules in the seco... Constantin Asofiei
01:08 PM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
About note 93. See these two ASTs:... Constantin Asofiei
12:56 PM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
This version fixes both the regression in Majic (hopefully in all cases) as well as the super(?, ?, ?) case. It reso... Greg Shah
11:55 AM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
> > 2. in expressions.rules:308 - I'm not sure why you are thinking to remove the WHEN. Can you share the case you ha... Constantin Asofiei
11:44 AM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
Good feedback.
> 2. in expressions.rules:308 - I'm not sure why you are thinking to remove the WHEN. Can you share...
Greg Shah
11:05 AM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
Review results:
1. This comment in base_structure.xml:379...
Constantin Asofiei
11:03 AM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
> Unless I read the diff wrong, the new way is the way of eliminating the getScreenValue and using the widget getter.... Greg Shah
11:00 AM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
> 1. The new way is more correct?
> 2. The old way may be working (or may not) depending on the format of the var?...
Constantin Asofiei
10:53 AM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
Questions:
1. The new way is more correct?
2. The old way may be working (or may not) depending on the format o...
Greg Shah
10:44 AM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
> 2. Detection of incompatible types in the comparison operators (which take BDT). A standalone testcase:
> def va...
Constantin Asofiei
10:22 AM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
Here is the final version, with some fixes necessary to convert Majic. Please see #2091 for a Majic change that must... Greg Shah
10:01 AM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
> Constantin: would you please do a code review of this update?
I'm looking at it now.
Constantin Asofiei
07:57 AM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
I have fixed some issues (found in my manual testing) with the update.
The conversion testing didn't ever complete...
Greg Shah
09:54 PM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
This update (hopefully) resolves everything left on this task except for the issue mentioned in note 93. Here is a s... Greg Shah
04:38 PM Conversion Tools Feature #1603: enhance name conversion to support internal procedure names that contain a '.' cha...
OK. I'll investigate the ScopedSymbolDictionary keeping approach. The next drop implements the Map usage and some min... Eugenie Lyzenko
03:52 PM Conversion Tools Feature #1603: enhance name conversion to support internal procedure names that contain a '.' cha...
> The conversion test is the comparison for MAJIC converted result before and after update. Is it correct?
Yes.
...
Greg Shah
03:08 PM Conversion Tools Feature #1603: enhance name conversion to support internal procedure names that contain a '.' cha...
> There are many diffs in Majic. Please review the following and determine if these are correct or not.
I think be...
Eugenie Lyzenko
12:41 PM Conversion Tools Feature #1603: enhance name conversion to support internal procedure names that contain a '.' cha...
There are many diffs in Majic. Please review the following and determine if these are correct or not. Greg Shah
10:49 AM Conversion Tools Feature #1603: enhance name conversion to support internal procedure names that contain a '.' cha...
> Do you want me to conversion test this on devsrv01?
Yes, please run this on devsrv01.
Eugenie Lyzenko
10:36 AM Conversion Tools Feature #1603: enhance name conversion to support internal procedure names that contain a '.' cha...
Do you want me to conversion test this on devsrv01? It is much faster than lightning and will not impact the conversi... Greg Shah
10:31 AM Conversion Tools Feature #1603: enhance name conversion to support internal procedure names that contain a '.' cha...
> 1. In both files, please start with namesfx = 2. I think this is more natural for the 2nd instance of that var.
...
Eugenie Lyzenko
08:22 AM Conversion Tools Feature #1603: enhance name conversion to support internal procedure names that contain a '.' cha...
Code Review:
Overall, it is very good. Some minor things:
1. In both files, please start with namesfx = 2. I ...
Greg Shah
03:46 PM Database Bug #2084: Conversion misplaced parameter for can-find statement
Went back and searched for another solution, since the last one started from the wrong premise that can-find BUFFER_S... Costin Savin
03:35 PM Database Bug #2084: Conversion misplaced parameter for can-find statement
Costin, please provide a detailed update of what you have found/done on this today. Eric Faulhaber
12:04 PM Base Language Bug #2065: ambiguity in date/decimal literals that is not handled properly by the ProgressLexer
Committed to bzr revision 10285. Constantin Asofiei
10:27 AM Base Language Bug #2065: ambiguity in date/decimal literals that is not handled properly by the ProgressLexer
The update looks good. You can check it in and distribute it. Greg Shah
09:56 AM Base Language Bug #2065: ambiguity in date/decimal literals that is not handled properly by the ProgressLexer
Correct, good letter, wrong date. Attached is the good one. Constantin Asofiei
08:13 AM Base Language Bug #2065: ambiguity in date/decimal literals that is not handled properly by the ProgressLexer
I think the wrong update is posted here. Greg Shah

03/13/2013

06:14 PM Base Language Feature #2089: INPUT function returning string value
About note 8: no.
You can do the following:
1. Determine the type (wrapper classname: like "integer") of the va...
Greg Shah
06:00 PM Base Language Feature #2089: INPUT function returning string value
Yes, you should work on item 2 and my changes will enable item 1. Please note that I don't want to transform all val... Greg Shah
04:42 PM Base Language Feature #2089: INPUT function returning string value
In regards to #2: should I parent all occurrences of a validated value with FUNC_POLY node as a solution? Stanislav Lomany
02:12 PM Base Language Feature #2089: INPUT function returning string value
OK, I missed that. So your question remains. Constantin Asofiei
02:11 PM Base Language Feature #2089: INPUT function returning string value
Greg was saying that "I am currently working to extend that facility to be more robust, including detecting the case ... Stanislav Lomany
01:53 PM Base Language Feature #2089: INPUT function returning string value
Stanislav Lomany wrote:
> So, am I correct that except checking the runtime part we have two problems:
> 1. It is n...
Constantin Asofiei
01:47 PM Base Language Feature #2089: INPUT function returning string value
So, am I correct that except checking the runtime part we have two problems:
1. It is not properly recognized that a...
Stanislav Lomany
06:06 PM Database Feature #2080: add runtime support for database methods
Vadim Nebogatov wrote:
> Will be ast processing with rules also required with wrapping String to character?
Const...
Eric Faulhaber
04:49 PM Database Feature #2080: add runtime support for database methods
Eric Faulhaber wrote:
> With your next update, please replace the predicate data type of @String@ in all the @Buff...
Vadim Nebogatov
03:23 PM Database Feature #2080: add runtime support for database methods
Vadim Nebogatov wrote:
> Eric Faulhaber wrote:
> > One question: why not just implement @AbstractQuery.queryReposi...
Eric Faulhaber
03:18 PM Database Feature #2080: add runtime support for database methods
Low priority: related to my last note, we are using the wrong data type for the NO-LOBS parameter in our bufferCopy/... Eric Faulhaber
03:16 PM Database Feature #2080: add runtime support for database methods
Eric Faulhaber wrote:
> One question: why not just implement @AbstractQuery.queryReposition(NumberType n)@ as
> [....
Vadim Nebogatov
02:07 PM Database Feature #2080: add runtime support for database methods
The current project never uses the NO-LOBS parameter of BUFFER-COPY and BUFFER-COMPARE, so the variants of @BufferImp... Eric Faulhaber
01:46 PM Database Feature #2080: add runtime support for database methods
Code review 20130312a:
Update looks fine.
Good catch on the @queryReposition@ method. One question: why not j...
Eric Faulhaber
11:10 AM Database Feature #2080: add runtime support for database methods
I suspect that much of the use we will see of this feature will involve expressions resolving to character values (si... Eric Faulhaber
05:40 AM Database Feature #2080: add runtime support for database methods
The FIND-FIRST/LAST/UNIQUE methods can receive a character for the first parameter. Currently, the Buffer.find* imple... Constantin Asofiei
05:48 PM Conversion Tools Feature #1603: enhance name conversion to support internal procedure names that contain a '.' cha...
The suggested fix has been uploaded. It properly converts the sample:... Eugenie Lyzenko
02:06 PM Conversion Tools Feature #1603: enhance name conversion to support internal procedure names that contain a '.' cha...
The places to modify:
for frames: rule file annotation/frame_scoping.rules, internal function "process_frame"...
Eugenie Lyzenko
10:17 AM Conversion Tools Feature #1603: enhance name conversion to support internal procedure names that contain a '.' cha...
The strange thing is that I thought we already did some of this kind of disambiguation.
We don't want this to be s...
Greg Shah
10:09 AM Conversion Tools Feature #1603: enhance name conversion to support internal procedure names that contain a '.' cha...
Another word we need to decide what are the exact cases when we need special processing for "-" character. For now I ... Eugenie Lyzenko
10:02 AM Conversion Tools Feature #1603: enhance name conversion to support internal procedure names that contain a '.' cha...
Another name collision, when vars are used:... Constantin Asofiei
07:55 AM Conversion Tools Feature #1603: enhance name conversion to support internal procedure names that contain a '.' cha...
If we have a substitution that we want to be the default, then we would always want to encode it in P2J and not in th... Greg Shah
04:51 PM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
Constantin: this case:... Greg Shah
01:34 PM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
The complete list is this (logged from where the ECW.expressionType would throw exception otherwise):... Constantin Asofiei
01:30 PM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
> When do you think you will have this available?
The server conversion is in the Base Structure phase, with a few f...
Constantin Asofiei
01:14 PM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
> What I can do is remove the last fallback checks (the _POLY-related checks ), adjust the ECW to log a message inste... Greg Shah
10:44 AM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
This is the good version, committed to bzr revision 10284.
LE: it passed conversion regression testing.
Constantin Asofiei
10:34 AM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
Yes, you understand correctly. The idea here was this: for the KW_DYN_FUNC node, we don't need to the ControlFlowOps.... Constantin Asofiei
10:32 AM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
I guess what is happening is that casttype is really meant to be used for the .class emit on a DYNAMIC-FUNCTION invoc... Greg Shah
10:24 AM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
I don't fully understand the purpose of the "ignorecast" annotation:... Greg Shah
10:01 AM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
OK, good idea. Constantin Asofiei
10:00 AM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
How about this: if these cases are already known to return logical, then I will emit the logical.class and not wrap ... Greg Shah
09:55 AM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
> In regard to the removal of the castLogical(): currently we bypass the emit of the .class instance in this case (wh... Constantin Asofiei
09:49 AM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
In regard to the removal of the castLogical(): currently we bypass the emit of the .class instance in this case (when... Greg Shah
09:25 AM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
> I think the only issue here is where the new character() wrapper is emitted.
I think you are right.
> If I unders...
Constantin Asofiei
09:10 AM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
Here is the code that is generated by my current implementation:... Greg Shah
08:52 AM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
Had a problem, forgot to initialize the @ref@ var in base_structure.xml's @parent.type == prog.kw_run@ run (without t... Constantin Asofiei
08:28 AM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
Greg Shah wrote:
> I think there should be some code like this in the example:
The code should be @h = temp-table t...
Constantin Asofiei
08:23 AM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
I think there should be some code like this in the example:... Greg Shah
07:39 AM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
And the update... Constantin Asofiei
07:38 AM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
The attached update fixes this:
# wrapping of handle for a @RUN ... IN DYNAMIC-FUNCTION@ call
# varargs signature pro...
Constantin Asofiei
06:17 AM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
Greg, in the server project there are failures related to the fact that _POLY is used as an operand. The failed opera... Constantin Asofiei
03:15 PM Base Language Bug #2065: ambiguity in date/decimal literals that is not handled properly by the ProgressLexer
The update has passed conversion regression testing. Constantin Asofiei
02:33 PM Base Language Bug #2065: ambiguity in date/decimal literals that is not handled properly by the ProgressLexer
The only remaining problem was with char field initializers, which were not handled (it was parsers fault). The notes... Constantin Asofiei
03:13 PM Database Bug #2084: Conversion misplaced parameter for can-find statement
Tried to replicate the test which failed on update cs_upd20130312a.zip (-where- before I moved the logic from post-ru... Costin Savin
11:09 AM Database Bug #2084: Conversion misplaced parameter for can-find statement
The testcase from note 11 passed, there was another file from conversion regression tests that failed (with the remap... Costin Savin
10:53 AM Database Bug #2084: Conversion misplaced parameter for can-find statement
I haven't looked at this issue in detail nor tried to reproduce the problem yet, but the last update you sent looks w... Eric Faulhaber
08:11 AM Database Bug #2084: Conversion misplaced parameter for can-find statement
There seems to be a problem with some buffers being used in different db schemas,
after the change it seems the buff...
Costin Savin
05:25 AM Database Bug #2084: Conversion misplaced parameter for can-find statement
There are changes in two files with this update, I think they are expected, but Costin is checking them now. Constantin Asofiei
02:14 AM Database Bug #2090 (Closed): correct sorting of DMO properties during schema conversion
Eric Faulhaber

03/12/2013

06:43 PM Conversion Tools Feature #1603: enhance name conversion to support internal procedure names that contain a '.' cha...
OK. I've found the answer for note #13. The matchlist.xml config file overrides the NameConverter.java internals. The... Eugenie Lyzenko
06:17 PM Conversion Tools Feature #1603: enhance name conversion to support internal procedure names that contain a '.' cha...
The question. Why adding replacement:... Eugenie Lyzenko
05:20 PM Database Feature #2080: add runtime support for database methods
Current status of methods from ref 1947
Implemented:
GET-CURRENT (KW_GET_CUR)
FIND-LAST (KW_FIND_LST)
FIND-FIRST ...
Vadim Nebogatov
05:19 PM Database Feature #2080: add runtime support for database methods
Attached update vmn_upd20130312a.zip.
Corrected runtime for BUFFER-COPY (KW_BUF_COPY) and BUFFER-COMPARE (KW_BUF_CO...
Vadim Nebogatov
04:40 PM Database Feature #2080: add runtime support for database methods
Yes, I handed my changes off to Constantin a few days ago, based on an older version, to integrate with some other ch... Eric Faulhaber
04:26 PM Database Feature #2080: add runtime support for database methods
Eric, I corrected BufferImpl.bufferCompare according #12, but noticed that you replaced function body with ... Unsupp... Vadim Nebogatov
06:22 AM Database Feature #2080: add runtime support for database methods
Tests
uast/find-with-locks.p
uast/get-with-locks.p
committed revision 991.
Vadim Nebogatov
05:01 AM Database Feature #2080: add runtime support for database methods
vmn_upd20130311c.zip checked in as bzr revision 10278. Vadim Nebogatov
08:58 PM Database Feature #2080: add runtime support for database methods
Update vmn_upd20130311c.zip has passed conversion regression testing. Please commit it to bzr and distribute. Note ... Eric Faulhaber
04:05 PM Base Language Feature #2089: INPUT function returning string value
As Constantin notes, the INPUT function in the 4GL can return either the actual data type of the widget OR it can ret... Greg Shah
03:46 PM Base Language Feature #2089: INPUT function returning string value
Greg, how should correctly converted validation code look like for the following example?... Stanislav Lomany
03:12 PM Base Language Feature #2089: INPUT function returning string value
Copied from #2068:
*CA*
Another problem found in at least rtb/ folder:...
Stanislav Lomany
03:09 PM Base Language Feature #2089 (Closed): INPUT function returning string value
Stanislav Lomany
03:37 PM Database Bug #2083: client-side where-clause leak in FindQuery
This fix looks good to me. I have merged it with the latest bzr revision, re-run conversion regression testing with ... Eric Faulhaber
01:36 PM Database Bug #2083: client-side where-clause leak in FindQuery
I see you found another solution.
I also found one simple and straightforward solution by refining the condition f...
Ovidiu Maxiniuc
12:19 PM Database Bug #2083: client-side where-clause leak in FindQuery
Ovidiu, I was having many similar issues with client-side query substitution parameters and CAN-FIND while fixing #20... Eric Faulhaber
02:33 PM Database Bug #2084: Conversion misplaced parameter for can-find statement
Added proposed update
It seems the problem is in some situation the remap scope is deleted before we get into the <p...
Costin Savin
11:28 AM Database Bug #2084: Conversion misplaced parameter for can-find statement
It seems there are still some weird cases where it fails. Working on reproducing and fixing it Costin Savin
04:54 AM Database Bug #2084: Conversion misplaced parameter for can-find statement
I'm sorry about that, it seems I forgot to save after doing the clean-up, and created the archive with some unwanted ... Costin Savin
09:54 PM Database Bug #2084: Conversion misplaced parameter for can-find statement
Code review 20130311a:
* Do you have a test case that illustrates the problem described by Constantin in notes 5 a...
Eric Faulhaber
02:08 PM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
Attached was committed to bzr revision 10282. Constantin Asofiei
01:55 PM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
OK, please go ahead and check it in. You can leave the assignments.rules there. I will deal with the merge.
> Wh...
Greg Shah
01:49 PM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
PS: the conversion regression testing has passed. The only changes are related to:... Constantin Asofiei
01:44 PM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
> The code looks fine. I have changes in the assignments.rules and I prefer if you don't include that file (it is ju... Constantin Asofiei
01:28 PM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
The code looks fine. I have changes in the assignments.rules and I prefer if you don't include that file (it is just... Greg Shah
12:48 PM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
> That makes sense. Are you going to add that?
No, I don't want to add this now.
> In a related note: my changes...
Constantin Asofiei
12:31 PM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
That makes sense. Are you going to add that?
In a related note: my changes are ready, but I want to test them wit...
Greg Shah
12:15 PM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
I don't recall seeing "attributes set to unknown"-related errors, but I think we should consider handling the attribu... Constantin Asofiei
09:16 AM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
OK, I'll fold that into my changes. It will make the result much cleaner.
In regard to your changes, that is grea...
Greg Shah
08:39 AM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
Yes, we can get rid of castLogical and use new logical() instead.
I have an update for which I still need to make ...
Constantin Asofiei
02:06 PM User Interface Feature #2088: add HIDE STREAM statement support
Committed to bzr revision 10281. Constantin Asofiei
01:58 PM User Interface Feature #2088: add HIDE STREAM statement support
This code is fine. It can be checked in without conversion regression testing. Greg Shah
01:17 PM Database Bug #2059: CAN-FIND clause for a perm table in the RECORD_PHRASE of a temp table, with a FOR EACH...
Update has passed conversion regression testing and is committed to bzr rev. 10280. Eric Faulhaber
12:14 PM Database Bug #2059: CAN-FIND clause for a perm table in the RECORD_PHRASE of a temp table, with a FOR EACH...
Fix candidate is attached. I am conversion regression testing this now. Eric Faulhaber
10:15 PM Database Feature #2000: add conversion support for table and table handle parameters
Code looks good, AFAICT, but without test cases and being able to look at the ASTs, the changes were hard to follow, ... Eric Faulhaber

03/11/2013

07:34 PM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
Do we really need BDT.castLogical()? Or can we handle this using new logical(BDT)? If we can avoid the castLogical(... Greg Shah
12:06 PM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
> In these cases where ptypes[i] is null, I think it default to BaseDataType, right?
Are you asking what the type ...
Greg Shah
10:50 AM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
> 1. It seems to me that ParmType.typesMatch() should implement a wider range of matching behavior. For example, if ... Constantin Asofiei
10:21 AM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
Code Review:
1. It seems to me that ParmType.typesMatch() should implement a wider range of matching behavior. Fo...
Greg Shah
08:36 AM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
The case automatically assigns the lower 32-bits of the long to the int. Since oldtype can never be > 2GB, this is s... Greg Shah
08:05 AM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
> Yes, that was my fix too for Java 1.6. And I don't think there will be losses, as the token type doesn't need 32 bi... Eugenie Lyzenko
06:28 AM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
This update contains some fixes in ECW.parameterTypeName and base_structure.xml, plus BUFFER-COPY/COMPARE (from Eric)... Constantin Asofiei
05:25 AM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
Yes, that was my fix too for Java 1.6. And I don't think there will be losses, as the token type doesn't need 32 bits... Constantin Asofiei
05:22 AM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
> Eugenie: what Java are you using ? I haven't got any error on my system or devsrv01.
1.6.X
The long 64 bit ca...
Eugenie Lyzenko
04:30 AM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
Eugenie: what Java are you using ? I haven't got any error on my system or devsrv01. Constantin Asofiei
06:30 PM Database Feature #2080: add runtime support for database methods
Code review 20130311c:
The merge looks fine. The implementation of @BufferImpl.bufferCompare@ doesn't look right. ...
Eric Faulhaber
05:00 PM Database Feature #2080: add runtime support for database methods
Attached update
vmn_upd20130311c.zip
vmn_upd20130311d.zip (corresponding test cases)
is next replacement of vm...
Vadim Nebogatov
04:26 PM Database Feature #2080: add runtime support for database methods
P2JQuery,
** 040 CA 20130311 Added bufferHandle(integer).
It seems wrong number
Vadim Nebogatov
03:08 PM Database Feature #2080: add runtime support for database methods
Code review 20130311a:
The changes all look good.
I noticed on this second review that even the no-arg versions...
Eric Faulhaber
10:01 AM Database Feature #2080: add runtime support for database methods
Attached update
vmn_upd20130311a.zip
vmn_upd20130311b.zip (corresponding test cases)
is replacement of vmn_upd2013...
Vadim Nebogatov
06:20 PM Database Feature #2000: add conversion support for table and table handle parameters
Regression conversion completed without errors. Stanislav Lomany
03:42 PM Database Feature #2000: add conversion support for table and table handle parameters
> Is this merged up to the latest bzr revision?
Yes, it is merged.
Stanislav Lomany
02:59 PM Database Feature #2000: add conversion support for table and table handle parameters
Is this merged up to the latest bzr revision?
If so, please do run conversion regression testing. Eric will do a ...
Greg Shah
02:32 PM Database Feature #2000: add conversion support for table and table handle parameters
Update for TABLE-HANDLE FOR case. Should I regression-test it? Stanislav Lomany
03:32 PM Database Bug #2083: client-side where-clause leak in FindQuery
The @<action>sibref.setHidden(true)</action>@ from @where_clause_post.rules@ at line 438 from my previous update seem... Ovidiu Maxiniuc
11:24 AM Database Bug #2083: client-side where-clause leak in FindQuery
After some more tests, it seems like this update does not fix the issue, in fact it is too restrictive, it will cut m... Ovidiu Maxiniuc
06:07 AM Database Bug #2083: client-side where-clause leak in FindQuery
With help from Constantin, the missing @setHidden@ is now in place. Ovidiu Maxiniuc
01:46 PM Database Bug #2084: Conversion misplaced parameter for can-find statement
Added proposed update which checks if the javaname is marked for remap but not as a generated increment name. Costin Savin
11:09 AM Base Language Feature #1640: implement DOM XML support
Added more missing APIs. Committed to bzr revision 10276 Constantin Asofiei
11:05 AM Base Language Feature #1884: add some of the v10 data types and core built-ins
-Added more missing APIs. Committed to bzr revision 10276- was for task #1640 Constantin Asofiei
11:05 AM Database Feature #1947: add conversion support for database methods
Added missing API bufferHandle(integer). Committed to bzr revision -10276- 10277. Constantin Asofiei

03/10/2013

03:29 PM Database Feature #1668: add support for additional (non-dynamic) database attributes
Update ecf_upd20130308a.zip has passed conversion regression testing and is committed as bzr rev. 10274. Eric Faulhaber
02:36 PM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
> And the update for note 50.
Constantin, how you compiled the update? I put it on top of the current bzr code and...
Eugenie Lyzenko
10:16 AM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
And the update for note 50. Constantin Asofiei
10:16 AM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
Attached update contains:
# ParmType - added needed APIs for the enum
# SignatureHelper - fixed the definition for ...
Constantin Asofiei
07:30 AM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
Eugenie: I think KW_SET_BUF should have a BDT_VARARGS instead of BDT_ARRAY, because as I see from the docs, it can re... Constantin Asofiei
07:15 AM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
Constantin Asofiei wrote:
> Greg Shah wrote:
> > Actually, after thinking about it some more, is there a need to ev...
Constantin Asofiei

03/09/2013

05:20 PM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
New drop uploaded. The function and methods are separated in two different maps. Eugenie Lyzenko
04:52 PM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
Yes, go with that approach. Greg Shah
04:30 PM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
> This also means we will have to pass the token type (FUNC_*/METH_*) in addition to the keyword.
Yes, we can impl...
Eugenie Lyzenko
03:15 PM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
This also means we will have to pass the token type (FUNC_*/METH_*) in addition to the keyword. Greg Shah
02:54 PM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
Eugenie Lyzenko wrote:
> > Eugenie: KW_FILL appears twice in the map.
>
> Yes, one for Built-in function, other f...
Constantin Asofiei
02:34 PM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
> Eugenie: KW_FILL appears twice in the map.
Yes, one for Built-in function, other for method. They both have diff...
Eugenie Lyzenko
02:27 PM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
> For KW_REPLACE: I see that you've specified two signatures for it, but according to 10.2B docs, it has 3 mandatory ... Eugenie Lyzenko
12:01 PM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
Greg Shah wrote:
> Actually, after thinking about it some more, is there a need to ever wrap the parameters to DYNAM...
Constantin Asofiei
11:44 AM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
Actually, after thinking about it some more, is there a need to ever wrap the parameters to DYNAMIC-FUNCTION? They w... Greg Shah
11:42 AM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
OK. But we could handle these cases too.
1. SUPER is especially easy to handle, because we can use the same techn...
Greg Shah
11:37 AM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
> Actually, I think the ECW already handles KW_SUPER fully. It searches up the tree to find the containing function ... Constantin Asofiei
11:31 AM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
Some thoughts:
> The fact that a function can have multiple signatures troubles us at conversion time, as if we do...
Greg Shah
11:02 AM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
Another case of the KW_DYN_FUNC: the handle parameter is optional. I think this should also be explicitly treated by ... Constantin Asofiei
09:40 AM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
There is another case which is not treated properly. When IF ternary operator has an ? on the else or then branch, as... Constantin Asofiei
08:20 AM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
About KW_DATETIME:
* how can we disambiguate the signature, if the number of mandatory parameter is the same (1) in ...
Constantin Asofiei
07:53 AM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
Eugenie: KW_FILL appears twice in the map. Constantin Asofiei
05:08 AM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
The fact that a function can have multiple signatures troubles us at conversion time, as if we don't offer a choice t... Constantin Asofiei
03:57 PM Base Language Bug #2076: DMO setter fails when parameter is BaseDataType
A simple change to ECW fixes this. I am making some other changes to the ECW as well. Then I will conversion test t... Greg Shah
11:25 AM Base Language Bug #2076: DMO setter fails when parameter is BaseDataType
There is a regression related to this update:... Constantin Asofiei
03:56 PM Base Language Feature #2050: ATTR_POLY/METH_POLY used as rvalue or in expressions
Yes, I'm thinking about what is the right solution here. I wonder if I should make the previous solution (the extra ... Greg Shah
03:52 PM Base Language Feature #2050: ATTR_POLY/METH_POLY used as rvalue or in expressions
Hmm... on a second thought, this is similar to the DMO setter case... it should wrap the _POLY/DB_NON_REF in a logica... Constantin Asofiei
03:34 PM Base Language Feature #2050: ATTR_POLY/METH_POLY used as rvalue or in expressions
I'm not sure the problem is in the ECW. Actually, there is never any attempt to call the ECW for these cases. If I ... Greg Shah
11:13 AM Base Language Feature #2050: ATTR_POLY/METH_POLY used as rvalue or in expressions
The strange thing is that I already put in support for all of these cases. I guess it is not working properly. I wi... Greg Shah
07:28 AM Base Language Feature #2050: ATTR_POLY/METH_POLY used as rvalue or in expressions
The ExpressionConversion worker needs to treat the cases when a _POLY is used in a logical test, as in:... Constantin Asofiei
11:11 AM Base Language Feature #2087 (Closed): add support for extent vars/fields used with a PUT statement (stream-only...
Checked in as bzr revision 10273. Greg Shah
04:44 AM Base Language Feature #2087: add support for extent vars/fields used with a PUT statement (stream-only feature)
The ges_upd20130308g.zip update has passed conversion regression testing. Constantin Asofiei
03:01 AM Base Language Feature #2087: add support for extent vars/fields used with a PUT statement (stream-only feature)
Thanks, that did the trick. I'm putting it through conversion regression testing. Constantin Asofiei
11:06 AM Base Language Bug #2065 (Closed): ambiguity in date/decimal literals that is not handled properly by the Progre...
Greg Shah
11:06 AM Base Language Bug #2065: ambiguity in date/decimal literals that is not handled properly by the ProgressLexer
Passed conversion testing and checked in as bzr revision 10272. Greg Shah
09:11 AM Database Bug #2083: client-side where-clause leak in FindQuery
I couldn't get my mind of client_taint and I took a quick look where is used. In where_clause_post.rules, at line 413... Constantin Asofiei
02:55 AM Base Language Feature #1640: implement DOM XML support
Adds two missing APIs in XmlFactory, related to WIDGET-POOL clause. Committed to bzr revision 10271. Constantin Asofiei

03/08/2013

05:25 PM Base Language Feature #2087: add support for extent vars/fields used with a PUT statement (stream-only feature)
Take a look at this. I think this should do the same thing. Greg Shah
03:59 PM Base Language Feature #2087: add support for extent vars/fields used with a PUT statement (stream-only feature)
The good news is that 0308h.zip has passed conversion regression testing - no changes. Constantin Asofiei
03:47 PM Base Language Feature #2087: add support for extent vars/fields used with a PUT statement (stream-only feature)
I had a feeling there was another file where this was done already for some other cases, but my brain chose to ignore... Constantin Asofiei
03:41 PM Base Language Feature #2087: add support for extent vars/fields used with a PUT statement (stream-only feature)
Code Review:
Could we have added this as an additional case in annotations/array_expansion.rules?
Greg Shah
02:58 PM Base Language Feature #2087: add support for extent vars/fields used with a PUT statement (stream-only feature)
Had a regression (didn't handle the case when the PUT used a subscripted field). Back in regression testing. Constantin Asofiei
01:31 PM Base Language Feature #2087: add support for extent vars/fields used with a PUT statement (stream-only feature)
4GL allows extent vars/fields to be used in a PUT statement:... Constantin Asofiei
01:27 PM Base Language Feature #2087 (Closed): add support for extent vars/fields used with a PUT statement (stream-only...
Constantin Asofiei
05:07 PM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
The first complete drop to review has been uploaded.
PS: Forgot to note. The file SignatureHelper.java contains the ...
Eugenie Lyzenko
04:06 PM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
> Undocumented functions?
Yes, these are undocumented.
It is our understanding that LOWER is the same thing as ...
Greg Shah
02:59 PM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
Greg,
I'm preparing the final drop to upload and requesting for ability not to follow the 98 column restriction fo...
Eugenie Lyzenko
01:38 PM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
The remaining questions:
The functions defined in progress.g but not in 4GL reference documentation:...
Eugenie Lyzenko
11:18 AM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
Add CLOB (which is really only the CLOB field case) and LARGE_CHAR_OBJECT which is either LONGCHAR or CLOB.
> SET-...
Greg Shah
10:39 AM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
> Can you provide an example? A CLOB can only be a field in the database, so I guess the method must take a reference... Eugenie Lyzenko
08:35 AM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
> There are the methods we do not define in progress.g file:
These are from v11 which we don't support yet.
> D...
Greg Shah
10:04 PM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
The handle methods has been added. There are the methods we do not define in progress.g file:
ADD-PARENT-ID-RELATION...
Eugenie Lyzenko
05:05 PM Base Language Bug #2065: ambiguity in date/decimal literals that is not handled properly by the ProgressLexer
Fix for empty string used as a date var initializer. It is being conversion tested now. Greg Shah
04:30 PM Base Language Bug #2065: ambiguity in date/decimal literals that is not handled properly by the ProgressLexer
Passed conversion testing and checked in as revision 10269.
I'll handle the date from an empty string next.
Greg Shah
03:38 PM Base Language Bug #2065: ambiguity in date/decimal literals that is not handled properly by the ProgressLexer
Another issue related to dates:... Constantin Asofiei
03:28 PM Base Language Bug #2065: ambiguity in date/decimal literals that is not handled properly by the ProgressLexer
Final version going through conversion testing now. There was an issue with removal of zeros from the year portion o... Greg Shah
02:05 PM Base Language Bug #2065 (WIP): ambiguity in date/decimal literals that is not handled properly by the ProgressL...
How many times am I going to be wrong today? Majic compiled fine with the c update but there are still many unwanted... Greg Shah
12:12 PM Base Language Bug #2065: ambiguity in date/decimal literals that is not handled properly by the ProgressLexer
Another silly mistake, I didn't properly exclude num literals from the trailing zero removal. This updated version i... Greg Shah
10:56 AM Base Language Bug #2065: ambiguity in date/decimal literals that is not handled properly by the ProgressLexer
Fixed a stupid indexing error. Going back into conversion testing. Greg Shah
10:48 AM Base Language Bug #2065: ambiguity in date/decimal literals that is not handled properly by the ProgressLexer
Updated version of the testcase plus the prepared fixes which are going into conversion testing now.
The core solu...
Greg Shah
04:40 PM Database Feature #1668: add support for additional (non-dynamic) database attributes
Fix candidate attached. I'll push this through conversion regression testing.
Vadim: please take note of this up...
Eric Faulhaber
03:56 PM Database Feature #1668: add support for additional (non-dynamic) database attributes
Eric, we've hit this on another occasion (? literal). For now, just handle both cases. The parser changes related to ... Constantin Asofiei
03:43 PM Database Feature #1668: add support for additional (non-dynamic) database attributes
Interesting...outside of the message statement, the NO_LOCK_LITERAL is the child of an intermediate EXPRESSION node, ... Eric Faulhaber
03:24 PM Database Feature #1668: add support for additional (non-dynamic) database attributes
The update doesn't handle this case:... Constantin Asofiei
03:17 PM User Interface Feature #2088: add HIDE STREAM statement support
The HIDE ALL statement can target a stream, as in:... Constantin Asofiei
03:14 PM User Interface Feature #2088 (Closed): add HIDE STREAM statement support
Constantin Asofiei
02:19 PM Conversion Tools Feature #1603: enhance name conversion to support internal procedure names that contain a '.' cha...
I'm putting this case here, because is a name collision:... Constantin Asofiei
07:39 AM Conversion Tools Feature #1603: enhance name conversion to support internal procedure names that contain a '.' cha...
Passed conversion regression testing, committed to bzr revision 10265. Constantin Asofiei
04:40 AM Conversion Tools Feature #1603: enhance name conversion to support internal procedure names that contain a '.' cha...
This converts dots in names to "dot" string. I will put this through conversion. Constantin Asofiei
01:59 PM Database Bug #2084: Conversion misplaced parameter for can-find statement
Sorry, I should have been more explicit. The failures are caused by the fact that, when you have a table named @prodc... Constantin Asofiei
01:53 PM Database Bug #2084: Conversion misplaced parameter for can-find statement
Constantin Asofiei wrote:
> Conversion regression testing has failed, as the tests above have passed because the jav...
Eric Faulhaber
06:53 AM Database Bug #2084: Conversion misplaced parameter for can-find statement
Conversion regression testing has failed, as the tests above have passed because the javaname in these cases is the s... Constantin Asofiei
04:51 AM Database Bug #2084: Conversion misplaced parameter for can-find statement
The changes looks good, also solves other compile errors where wrong buf name was used, in cases like:... Constantin Asofiei
04:01 AM Database Bug #2084: Conversion misplaced parameter for can-find statement
Added proposed update,
In previous comment I didn't understood exactly the process so I assumed there's an addition...
Costin Savin
12:20 PM Database Feature #2000: add conversion support for table and table handle parameters
About the state of work: I changed the parser so TABLE-HANDLE FOR is recognized as a variable reference rather than a... Stanislav Lomany
12:19 PM Database Bug #2083: client-side where-clause leak in FindQuery
At this moment, I use the following simplified testcase:... Ovidiu Maxiniuc
12:09 PM Database Bug #2083: client-side where-clause leak in FindQuery
I'm getting closer. Here what I found:
The extra node (@f1 [FUNC_LOGICAL]@) should be made hidden so it will not b...
Ovidiu Maxiniuc
09:09 AM Database Bug #2083: client-side where-clause leak in FindQuery
In my previous note there the and operator from where clause contains a reference to a buffer other than the one that... Ovidiu Maxiniuc
10:35 AM Database Feature #2086 (Closed): add support for the VALIDATE clause, for the temp-table's fiels defined u...
Greg Shah
10:34 AM Database Feature #2086: add support for the VALIDATE clause, for the temp-table's fiels defined using LIKE...
Committed to bzr 10266. Constantin Asofiei
09:58 AM Database Feature #2086: add support for the VALIDATE clause, for the temp-table's fiels defined using LIKE...
OK, this change looks fine. Commit and distribute it. Greg Shah
09:48 AM Database Feature #2086: add support for the VALIDATE clause, for the temp-table's fiels defined using LIKE...
The update has passed conversion regression testing. There is one additional change in MAJIC, from a @DEFINE TEMP-TAB... Constantin Asofiei
08:37 AM Database Feature #2086: add support for the VALIDATE clause, for the temp-table's fiels defined using LIKE...
Sorry, when you say "VALIDATE clause", I thought you are referring to the option for a TEMP-TABLE (not for a specific... Greg Shah
07:27 AM Database Feature #2086: add support for the VALIDATE clause, for the temp-table's fiels defined using LIKE...
New version of the update, which solves the VALIDATE when used with @DEFINE TEMP-TABLE tt1 LIKE source VALIDATE@. Als... Constantin Asofiei
03:09 AM Database Feature #2086: add support for the VALIDATE clause, for the temp-table's fiels defined using LIKE...
This fix removes the extent annotation from the source field reference in the VALEXP. What is still needed to do:
# ...
Constantin Asofiei
01:41 AM Database Feature #2086: add support for the VALIDATE clause, for the temp-table's fiels defined using LIKE...
Greg, the VALIDATE clause is used in the server project with a field definition. See file pmcon/cjcotdo0.w. There are... Constantin Asofiei
10:35 AM Base Language Feature #1640: implement DOM XML support
Committed to bzr revision 10267 Constantin Asofiei
10:02 AM Base Language Feature #1640: implement DOM XML support
I'm fine with the change. Commit and distribute it. Greg Shah
09:45 AM Base Language Feature #1640: implement DOM XML support
ca_upd20130308d.zip has passed conversion regression testing. Constantin Asofiei
08:15 AM Base Language Feature #1640: implement DOM XML support
Fixed conversion of CREATE statements related to XML support. The correct approach is to pass the handle instance as ... Constantin Asofiei

03/07/2013

06:12 PM Database Feature #2086: add support for the VALIDATE clause, for the temp-table's fiels defined using LIKE...
VALIDATE is NOT used in the server project (in a TEMP-TABLE or WORK-TABLE definition). Only NO-UNDO and RCODE-INFORM... Greg Shah
05:41 PM Database Feature #2086: add support for the VALIDATE clause, for the temp-table's fiels defined using LIKE...
MAJIC has finished conversion and there are changes, expected: validation clauses are dropped for temp-table fields d... Constantin Asofiei
04:55 PM Database Feature #2086: add support for the VALIDATE clause, for the temp-table's fiels defined using LIKE...
The server project exposed a problem with the temp-table fields defined using the LIKE clause, when the target field ... Constantin Asofiei
04:43 PM Database Feature #2086 (Closed): add support for the VALIDATE clause, for the temp-table's fiels defined u...
Constantin Asofiei
05:27 PM Conversion Tools Feature #1603: enhance name conversion to support internal procedure names that contain a '.' cha...
Go ahead with this change.
> A question: are you sure it's safe to "eat" the "-", "_" and "/" character from the n...
Greg Shah
05:15 PM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
No, CONFIG-NAME is supposed to be an attribute. It is a bug in our parser. I have some other parser changes I'm mak... Greg Shah
05:01 PM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
Found potential issue in progress.g:
According to Progress doc CONFIG-NAME is an attribute, not a method. But we def...
Eugenie Lyzenko
10:44 AM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
> If parameter is widget we need to add something: WID mapping to GenerigWidget?
Yes, that is fine.
> Arrays ar...
Greg Shah
09:58 AM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
Greg,
I'm working on the handle based methods adding. It's avout 300 lines. So I'm expecting to finish today-tomor...
Eugenie Lyzenko
09:26 PM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
The update has been uploaded. All built-in functions are there except so called "fake" web-speed ones. No methods for... Eugenie Lyzenko
05:00 PM Base Language Bug #2076 (Closed): DMO setter fails when parameter is BaseDataType
Greg Shah
04:58 PM Base Language Bug #2076: DMO setter fails when parameter is BaseDataType
Passes conversion testing and is checked into bzr as revision 10264.
Greg Shah
04:46 PM Base Language Bug #2076: DMO setter fails when parameter is BaseDataType
No, that is alright. The difference is not significant at runtime. Thanks.
I will check this in and distribute it.
Greg Shah
04:41 PM Base Language Bug #2076: DMO setter fails when parameter is BaseDataType
> Constantin: what do you think?
The result will not affect runtime, is just some small overhead. I think this is be...
Constantin Asofiei
04:32 PM Base Language Bug #2076: DMO setter fails when parameter is BaseDataType
Conversion testing has finished. There is this one unexpected change:... Greg Shah
02:25 PM Base Language Bug #2076: DMO setter fails when parameter is BaseDataType
This update is fine. I will conversion regression test it.
> Sorry I missed the "rule" directory , what I do when...
Greg Shah
01:14 PM Base Language Bug #2076: DMO setter fails when parameter is BaseDataType
Added proposed update.
Sorry I missed the "rule" directory , what I do when adding an update: I manually create the...
Costin Savin
12:20 PM Base Language Bug #2076: DMO setter fails when parameter is BaseDataType
Code Feedback:
1. Your zip still has the wrong directory name "rule" instead of "rules". How is that even getting...
Greg Shah
06:06 AM Base Language Bug #2076: DMO setter fails when parameter is BaseDataType
Added proposed update (uploaded it first by mistake to #2070) Costin Savin
03:12 PM Database Feature #2080: add runtime support for database methods
Code review 20130307a:
* There is no implementation for @QueryWrapper.getNext(LockType)@. The other @getXXX(LockT...
Eric Faulhaber
11:10 AM Database Feature #2080: add runtime support for database methods
Vadim Nebogatov wrote:
> Does P2J have common module responsible for 4GL errors processing? (I found actually ErrorM...
Eric Faulhaber
11:01 AM Database Feature #2080: add runtime support for database methods
Attached update vmn_upd20130307a.zip. Added runtime support for queryClose, queryForward, queryReposition, queryRepos... Vadim Nebogatov
05:11 AM Database Feature #2080: add runtime support for database methods
Does P2J have common module responsible for 4GL errors processing? (I found actually ErrorManager.recordOrThrowError(... Vadim Nebogatov
02:10 PM Database Bug #2084: Conversion misplaced parameter for can-find statement
The problem seems to be happening in the annotation phase in the following way:
The BUFFER_SCOPE with a bufname" va...
Costin Savin
07:46 AM Database Bug #2084: Conversion misplaced parameter for can-find statement
Example:... Costin Savin
07:44 AM Database Bug #2084 (Closed): Conversion misplaced parameter for can-find statement
Costin Savin
12:42 PM Base Language Feature #2082: add conversion support for 4GL's duplicate variable "feature"
Greg Shah wrote:
> I'm not sure why you switched from a Set to a Map in fixups/variable_definitions.rules (did you p...
Constantin Asofiei
12:29 PM Base Language Feature #2082: add conversion support for 4GL's duplicate variable "feature"
I'm not sure why you switched from a Set to a Map in fixups/variable_definitions.rules (did you plan to use it and th... Greg Shah
12:13 PM Base Language Feature #2082: add conversion support for 4GL's duplicate variable "feature"
The edited file is in task #2085.
This update has passed conversion regression testing (there are changes in two f...
Constantin Asofiei
09:51 AM Base Language Feature #2082: add conversion support for 4GL's duplicate variable "feature"
MAJIC has the case at note 14 in only one file. I've checked the history of this file and this change was introduced ... Constantin Asofiei
08:59 AM Base Language Feature #2082: add conversion support for 4GL's duplicate variable "feature"
Fixed a problem (I was using varDict.getSymbol instead of varDict.getSymbolAtScope(name, 0) to search only in the cur... Constantin Asofiei
08:45 AM Base Language Feature #2082: add conversion support for 4GL's duplicate variable "feature"
This has regressions, one of them relaed to this, as 4GL (v9-only I think) allowed this:... Constantin Asofiei
06:27 AM Base Language Feature #2082: add conversion support for 4GL's duplicate variable "feature"
So the problem was that the parser was adding tempidx to the dupped vars too. The sollution was to not register the d... Constantin Asofiei
05:49 AM Base Language Feature #2082: add conversion support for 4GL's duplicate variable "feature"
I need to rewrite this at the parser side, as the duped var gets ref'ed by the parser:... Constantin Asofiei
05:13 AM Base Language Feature #2082: add conversion support for 4GL's duplicate variable "feature"
Fixed multiple calls like:... Constantin Asofiei
12:02 PM Base Language Bug #2069: Accumulator temp table field disambiguation
Committed to bzr revision 10262. Constantin Asofiei
11:56 AM Base Language Bug #2069: Accumulator temp table field disambiguation
The change looks fine. Check it in and distribute it. Greg Shah
05:51 AM Base Language Bug #2069: Accumulator temp table field disambiguation
This has passed conversion regression testing. Constantin Asofiei
04:53 AM Base Language Bug #2069: Accumulator temp table field disambiguation
I think the sollution was to mark the tables which are weak reference as preferred, when abbreviations are encountere... Constantin Asofiei
03:51 AM Base Language Bug #2069: Accumulator temp table field disambiguation
Another creature of the rabbit hole found at #1985, 120. This fails:... Constantin Asofiei
09:57 AM Database Bug #2083: client-side where-clause leak in FindQuery
I did some patch (removing the extra expression from where node after generating the anonymous inner class needed by ... Ovidiu Maxiniuc
05:33 AM Database Bug #2083: client-side where-clause leak in FindQuery
Another can-find leak:... Constantin Asofiei
08:48 AM Database Feature #2000: add conversion support for table and table handle parameters
> When will the solution be ready for review?
Hopefully will finish it today.
Stanislav Lomany
08:46 AM Database Feature #2000: add conversion support for table and table handle parameters
When will the solution be ready for review? Greg Shah
04:44 AM Database Feature #2000: add conversion support for table and table handle parameters
About @DEF PARAMETER TABLE-HANDLE FOR th@ where @th@ is a regular variable:
1. OUTPUT case will produce compile-ti...
Stanislav Lomany
05:28 AM Base Language Bug #2070: BlockManager Action disambiguation
Added update to wrong task deleting it Costin Savin

03/06/2013

05:13 PM Database Feature #2080: add runtime support for database methods
Please implement all the methods you can, which do not require dynamic database support. For example, FIND-FIRST wit... Eric Faulhaber
04:38 PM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
OK.
The new datatype under questions:
1. If parameter is widget we need to add something: WID mapping to GenerigW...
Eugenie Lyzenko
04:00 PM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
OK, get as much done tonight as possible. Then create an update zip and upload it here.
Constantin will be able t...
Greg Shah
03:34 PM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
> Eugenie: how much more time do you expect this to take?
It is > 100 items left in functions. I guess this is ~10...
Eugenie Lyzenko
03:24 PM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
> Constantin: We can certainly go ahead with the infrastructure to use the facility. I planned this to be exposed th... Constantin Asofiei
03:14 PM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
Eugenie: how much more time do you expect this to take?
Constantin: We can certainly go ahead with the infrastruct...
Greg Shah
03:10 PM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
Greg: I don't know the order you plan to have this working, but if documenting each signature will take more time, I ... Constantin Asofiei
02:42 PM Conversion Tools Feature #1603: enhance name conversion to support internal procedure names that contain a '.' cha...
OK, looks like this addition in NamepConverte's static c'tor:... Constantin Asofiei
02:39 PM Conversion Tools Feature #1603: enhance name conversion to support internal procedure names that contain a '.' cha...
This one did turn and bit us, because the server project has files named like "foo.bar.p", which get converted to "Fo... Constantin Asofiei
02:02 PM Database Bug #2083: client-side where-clause leak in FindQuery
Ovidiu Maxiniuc wrote:
> The parameter is in fact an echo of the content of the client-side WhereExpression: @f1(cus...
Eric Faulhaber
01:59 PM Database Bug #2083: client-side where-clause leak in FindQuery
Here are the converted code for two cases (which attempt to call two new constructors), with and without another join... Ovidiu Maxiniuc
01:50 PM Database Bug #2083: client-side where-clause leak in FindQuery
I tried to simplify the sample. Suppose we have a simple function:... Ovidiu Maxiniuc
01:25 PM Database Bug #2083 (Closed): client-side where-clause leak in FindQuery
Ovidiu Maxiniuc
01:50 PM Base Language Feature #1884: add some of the v10 data types and core built-ins
Committed to bzr revision 10259. Constantin Asofiei
01:45 PM Base Language Feature #1884: add some of the v10 data types and core built-ins
I agree. The code is fine. Check it in and distribute it. Greg Shah
01:30 PM Base Language Feature #1884: add some of the v10 data types and core built-ins
Added missing TextOps.numEntries(String, String). I don't see a reason to put this through conversion regression test... Constantin Asofiei
01:37 PM Database Feature #1947 (Closed): add conversion support for database methods
Vadim committed this update to bzr as revision number 10256. Eric Faulhaber
11:21 AM Database Feature #1947: add conversion support for database methods
I made a minor change to the database_general.rules header. Please check in and distribute the attached version of y... Eric Faulhaber
10:58 AM Database Feature #1947: add conversion support for database methods
I have attached one more variant of the same update, but merged manually Vadim Nebogatov
10:29 AM Database Feature #1947: add conversion support for database methods
Code review 20130306a:
Other than the literal.rules merge issue noted above (which I do think was my mistake), eve...
Eric Faulhaber
09:35 AM Database Feature #1947: add conversion support for database methods
I will merge everything manually and resubmit Vadim Nebogatov
09:25 AM Database Feature #1947: add conversion support for database methods
As I see, update from Eric was not merged with revision you pointed. Maybe I am wrong with time calculation? Vadim Nebogatov
09:21 AM Database Feature #1947: add conversion support for database methods
Update #134 from Eric was attached at 2013-03-05 11:38PM, so I supposed that it was merged with revision 10245 that w... Vadim Nebogatov
08:54 AM Database Feature #1947: add conversion support for database methods
Vadim, literals.rules is not merged with 10245 (evl_upd20130305a.zip). I'll let Eric review the rest of the update. Constantin Asofiei
08:49 AM Database Feature #1947: add conversion support for database methods
Attached update
vmn_upd20130306a.zip / vmn_upd20130306a_test_cases.zip (start/final revisions 10245/10253)
The follow...
Vadim Nebogatov
11:46 PM Database Feature #1947: add conversion support for database methods
Vadim, please note that Ovidiu soon will be committing to bzr some changes to files which will overlap with your upda... Eric Faulhaber
01:25 PM Base Language Bug #2065: ambiguity in date/decimal literals that is not handled properly by the ProgressLexer
The following testcase shows the limits of this ambiguity.
From the header:...
Greg Shah
01:20 PM Base Language Bug #2076: DMO setter fails when parameter is BaseDataType
That crossed my mind too and started in that direction in the morning, but thought about the copy Ast with null paren... Costin Savin
01:09 PM Base Language Bug #2076: DMO setter fails when parameter is BaseDataType
The best thing to do here is to move the current logic for ECW.expressionType(Aast) to a new public worker method ECW... Greg Shah
12:44 PM Base Language Bug #2076: DMO setter fails when parameter is BaseDataType
The AST... Costin Savin
12:39 PM Base Language Bug #2076: DMO setter fails when parameter is BaseDataType
Please post the AST here for the @assign test.int-field = h:BUFFER-FIELD("dsc"):BUFFER-VALUE(2).@. Greg Shah
12:16 PM Base Language Bug #2076: DMO setter fails when parameter is BaseDataType
I'll use this example to explain.... Costin Savin
11:45 AM Base Language Bug #2076: DMO setter fails when parameter is BaseDataType
Code Review:
> I first tried to use ExpresionConversionWorker.expressionType with an ast copy without a parent (be...
Greg Shah
11:24 AM Base Language Bug #2076: DMO setter fails when parameter is BaseDataType
Added proposed update
NOTE
I first tried to use ExpresionConversionWorker.expressionType with an ast copy without...
Costin Savin
12:54 PM Base Language Feature #1920: implement persistent procedures
Added merged update, which was committed to bzr revision 10258. Constantin Asofiei
12:44 PM Base Language Feature #1920: implement persistent procedures
Passed conversion regression testing, no changes in generated sources.
I'll merge the file with latest version and...
Constantin Asofiei
11:35 AM Base Language Feature #1920: implement persistent procedures
Fixed attribute access when there are extent widgets, like:... Constantin Asofiei
12:42 PM Database Bug #2077: fix converted table and field name collisions
Committed to bzr revision 10257. Constantin Asofiei
11:54 AM Database Bug #2077: fix converted table and field name collisions
Check it in and distribute it. Greg Shah
11:40 AM Database Bug #2077: fix converted table and field name collisions
Update has passed conversion regression testing - no changes in generated code. Constantin Asofiei
10:46 AM Database Bug #2077: fix converted table and field name collisions
This solves the collision cases for good. Also, I've added support for buffer names collision check. I'm putting this... Constantin Asofiei
09:12 AM Database Bug #2077: fix converted table and field name collisions
Yes, the fix is pretty simple. I'll provide an update today. Constantin Asofiei
09:00 AM Database Bug #2077: fix converted table and field name collisions
If this is easy enough to fix, please go ahead and put the fix in. That way we don't have to remember there is a pro... Greg Shah
07:38 AM Database Bug #2077: fix converted table and field name collisions
Ovidiu, sorry I hijacked this from you last night. Anyway, this case I don't think is encountered in the server proje... Constantin Asofiei
07:26 AM Database Bug #2077: fix converted table and field name collisions
By chance I prepared a sample test-case for this issue which at this moment is not converted correctly by p2j:... Ovidiu Maxiniuc
01:50 AM Database Bug #2077: fix converted table and field name collisions
Committed to bzr revision 10246. Constantin Asofiei
11:10 AM Base Language Feature #2082 (Closed): add conversion support for 4GL's duplicate variable "feature"
Greg Shah
10:59 AM Base Language Feature #2082: add conversion support for 4GL's duplicate variable "feature"
Committed to bzr revision 10255. Constantin Asofiei
10:54 AM Base Language Feature #2082: add conversion support for 4GL's duplicate variable "feature"
Check it in and distribute it. Greg Shah
10:33 AM Base Language Feature #2082: add conversion support for 4GL's duplicate variable "feature"
The update has passed conversion regression testing. Note that even MAJIC had two cases of duplicated vars, in two fi... Constantin Asofiei
09:10 AM Base Language Feature #2082: add conversion support for 4GL's duplicate variable "feature"
Added comment and fixed the proc/function case. I'm putting it back into conversion regression testing. Constantin Asofiei
09:05 AM Base Language Feature #2082: add conversion support for 4GL's duplicate variable "feature"
Please put a comment into the variable_definitions.rules about the order of the definitions and that we deliberately ... Greg Shah
09:03 AM Base Language Feature #2082: add conversion support for 4GL's duplicate variable "feature"
> 1. Is there any difference in behavior when the non-global define variable is inside a nested scope (e.g. an intern... Constantin Asofiei
08:58 AM Base Language Feature #2082: add conversion support for 4GL's duplicate variable "feature"
The code looks good. I only have 2 questions:
1. Is there any difference in behavior when the non-global define v...
Greg Shah
08:42 AM Base Language Feature #2082 (Review): add conversion support for 4GL's duplicate variable "feature"
Attached update hides all duplicate var defs, only if the first one is DEF NEW GLOBAL SHARED. I'm putting this throug... Constantin Asofiei
08:19 AM Base Language Feature #2082: add conversion support for 4GL's duplicate variable "feature"
4GL allows two vars with the same name, if this construct is encountered:... Constantin Asofiei
08:18 AM Base Language Feature #2082 (Closed): add conversion support for 4GL's duplicate variable "feature"
Constantin Asofiei
08:57 AM Base Language Bug #2070: BlockManager Action disambiguation
Commited to bzr as revision number 10254. Costin Savin
08:35 AM Base Language Bug #2070: BlockManager Action disambiguation
The update has passed conversion regression testing, go ahead and distribute it. Constantin Asofiei
07:36 AM Base Language Bug #2070: BlockManager Action disambiguation
Added update Costin Savin
07:35 AM Base Language Bug #2070: BlockManager Action disambiguation
Please remove the dangling text from the 421 and the other edits I mentioned, and re-upload. I'm putting it through c... Constantin Asofiei
07:11 AM Base Language Bug #2070: BlockManager Action disambiguation
Added fix update Costin Savin
06:50 AM Base Language Bug #2070: BlockManager Action disambiguation
0305d.zip doesn't fully solve the issue, as the package name is computed wrong. It uses the package from the nearest ... Constantin Asofiei
08:47 AM Base Language Bug #2069 (Closed): Accumulator temp table field disambiguation
Greg Shah
08:27 AM Base Language Feature #2079 (Closed): add missing conversion support for format string
Greg Shah
08:26 AM Conversion Tools Bug #2066 (Closed): brew adds unnecessary comma in method parameter list after comment
Greg Shah
07:13 AM Conversion Tools Bug #2066: brew adds unnecessary comma in method parameter list after comment
Committed to bzr revision 10251. Constantin Asofiei
05:18 AM Conversion Tools Bug #2066: brew adds unnecessary comma in method parameter list after comment
The server folders had no errors related to comments. Constantin Asofiei
08:08 AM Base Language Feature #2078 (Closed): provide support for malformed label names
Greg Shah
01:52 AM Base Language Feature #2078: provide support for malformed label names
Committed to bzr revision 10247. Constantin Asofiei
07:14 AM Database Feature #1967: rework DMO class/interface hierarchy
0306b.zip was committed to bzr revision 10253. Constantin Asofiei
04:46 AM Database Feature #1967: rework DMO class/interface hierarchy
ca_upd20130306b.zip has passed conversion regression testing (no changes in generated sources). Constantin Asofiei
02:25 AM Database Feature #1967: rework DMO class/interface hierarchy
Attached update fixes the problem for my 0305d.zip. It brackets the deleteAll with a block only if it's parent is not... Constantin Asofiei
11:36 PM Database Feature #1967: rework DMO class/interface hierarchy
The om_upd20130304b.zip and ecf_upd20130305a.zip updates have gotten through conversion regression testing. However,... Eric Faulhaber
09:50 PM Database Feature #1967: rework DMO class/interface hierarchy
Code review -20130304a- 20130304b:
The code looks fine. The attached update corrects some cut-and-paste errors in t...
Eric Faulhaber
07:14 AM Base Language Feature #1885: fix and add necessary format string support
0306a.zip was Committed to bzr revision 10252. Constantin Asofiei
04:45 AM Base Language Feature #1885: fix and add necessary format string support
0306a.zip has passed conversion regression testing (no changes in generated sources). Constantin Asofiei
02:32 AM Base Language Feature #1885: fix and add necessary format string support
Correct version of progress.g Constantin Asofiei
02:16 AM Base Language Feature #1885: fix and add necessary format string support
This version emits the toStringMessage in case the format is a complex expression, for PUT field. Also, adds a TODO i... Constantin Asofiei
03:03 AM Database Feature #1953: add conversion support for CREATE BUFFER statement
Committed revision 10248. Ovidiu Maxiniuc
09:07 PM Database Feature #1953: add conversion support for CREATE BUFFER statement
Update 20130303a looks fine, except that the zip file is based at the com directory instead of src. Please fix this,... Eric Faulhaber
11:41 PM Database Feature #1933: add conversion support for certain metadata constructs
Conversion regression testing was successful. Please commit and distribute the 20130305b update. Eric Faulhaber
10:15 PM Database Feature #1933: add conversion support for certain metadata constructs
Code review 20130305a:
Changes look good.
Code review 20130305b:
The change is fine, but a slightly tighter ...
Eric Faulhaber
11:39 PM Database Feature #1668: add support for additional (non-dynamic) database attributes
Update 20130304c has passed conversion regression testing. Please correct the FieldReference header as noted above, ... Eric Faulhaber
09:58 PM Database Feature #1668: add support for additional (non-dynamic) database attributes
Code review 20130304c:
Code changes look fine, but please correct the file header numbering for the last 2 entries...
Eric Faulhaber

03/05/2013

06:32 PM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
Generally, I like it. This will work for some of the cases, but not all cases. Still, it is good enough to go with ... Greg Shah
06:18 PM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
> How about this approach:
> ...
The approach is working but we need to modify the getter this way for example:
...
Eugenie Lyzenko
05:22 PM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
> If we have multiple versions of the same function with different numbers of different kind of parameters how we dec... Greg Shah
05:00 PM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
Several data type question for this time:
1. If we have multiple versions of the same function with different numbers...
Eugenie Lyzenko
06:20 PM Database Bug #2077: fix converted table and field name collisions
It looks fine. Check it in and distribute it. Greg Shah
05:16 PM Database Bug #2077: fix converted table and field name collisions
Passed conversion regression testing. Constantin Asofiei
04:18 PM Database Bug #2077: fix converted table and field name collisions
I'm putting this through conversion regression testing. Constantin Asofiei
02:39 PM Database Bug #2077: fix converted table and field name collisions
This update solves collisions for dmo, table, property and column names. It adds a numeric suffix, similar to how tem... Constantin Asofiei
02:05 PM Database Bug #2077: fix converted table and field name collisions
In 4GL, it is possible to have two tables names named @p2j_test@ and @p2j-test@. Also, these field names can be in th... Constantin Asofiei
02:02 PM Database Bug #2077 (Closed): fix converted table and field name collisions
Constantin Asofiei
06:02 PM Base Language Feature #2078: provide support for malformed label names
I'm OK with the code. You can check it in and distribute. Greg Shah
05:15 PM Base Language Feature #2078: provide support for malformed label names
Passed conversion regression testing. Constantin Asofiei
04:18 PM Base Language Feature #2078: provide support for malformed label names
I'm putting this through conversion regression testing. Constantin Asofiei
04:09 PM Base Language Feature #2078: provide support for malformed label names
In 4GL, it is possible to support malformed label names, as in:... Constantin Asofiei
04:03 PM Base Language Feature #2078 (Hold): provide support for malformed label names
Constantin Asofiei
05:50 PM Database Feature #2080: add runtime support for database methods
The following static methods should be removed from AbstractQuery:... Eric Faulhaber
05:44 PM Database Feature #2080: add runtime support for database methods
This issue is for adding runtime support for all the database methods added in issue #1947. For the most part, we on... Eric Faulhaber
05:40 PM Database Feature #2080 (Closed): add runtime support for database methods
Eric Faulhaber
05:30 PM Database Feature #1947: add conversion support for database methods
Update 20130305b hit a snag in conversion regression testing. It did not cause a regression per se, because the chan... Eric Faulhaber
03:55 PM Database Feature #1947: add conversion support for database methods
I tried to update code from bzr now (I did not make any changes since the time I sent update).
Please see result - ...
Vadim Nebogatov
03:49 PM Database Feature #1947: add conversion support for database methods
I made fresh check out today morning and merged manually from updates with adding only my changes. Maybe I missed som... Vadim Nebogatov
03:44 PM Database Feature #1947: add conversion support for database methods
Eric, sorry, but I updated code today from bzr minimum 5 times during the day with bzr update command. Last time imme... Vadim Nebogatov
03:38 PM Database Feature #1947: add conversion support for database methods
Code review 20130305a:
The changes all look good, but rules/convert/literals.rules was out of date with bzr (confl...
Eric Faulhaber
09:41 AM Database Feature #1947: add conversion support for database methods
Updated test cases with expressions Vadim Nebogatov
09:31 AM Database Feature #1947: add conversion support for database methods
Yes, it is true. Tests passed in this case too with the results like
query1.getNext(LockType.LT_EXCLUSIVE, plus(7,...
Vadim Nebogatov
07:43 AM Database Feature #1947: add conversion support for database methods
Vadim,
> are even not compilable.
the correct syntax for you tests is this:...
Constantin Asofiei
07:40 AM Database Feature #1947: add conversion support for database methods
Attached update
vmn_upd20130305a.zip / vmn_upd20130305a_test_cases.zip
is next replacement of update vmn_upd20130...
Vadim Nebogatov
05:24 PM Base Language Feature #1885: fix and add necessary format string support
Yes, using toStringMessage() is a great idea. Greg Shah
05:04 PM Base Language Feature #1885: fix and add necessary format string support
This fixes the conversion problem, still need to expand PutField c'tors to accept character for the format... or, can... Constantin Asofiei
04:38 PM Base Language Feature #1885: fix and add necessary format string support
There is at least one format string problem in the server. Looks like PUT fields can have a dynamic format, and any e... Constantin Asofiei
05:16 PM Database Feature #1967: rework DMO class/interface hierarchy
I'm taking this back, wrong task: this has some regressions in terms that is too aggressive when bracketing the delet... Constantin Asofiei
05:15 PM Database Feature #1967: rework DMO class/interface hierarchy
-Passed conversion regression testing.- Constantin Asofiei
04:18 PM Database Feature #1967: rework DMO class/interface hierarchy
I'm putting this through conversion regression testing. Constantin Asofiei
01:48 PM Database Feature #1967: rework DMO class/interface hierarchy
Fix cases of a FOR EACH block converted to a tt.delete call, in case the FOR EACH is enclosed in a statement - in thi... Constantin Asofiei
04:41 PM Base Language Feature #2079: add missing conversion support for format string
This is for tracking the time for adding conversion support. All comments to be added in the parent #1885 task. Constantin Asofiei
04:40 PM Base Language Feature #2079 (Closed): add missing conversion support for format string
Constantin Asofiei
04:35 PM Base Language Bug #2070 (Closed): BlockManager Action disambiguation
Passed conversion testing and checked into bzr as revision 10244. Greg Shah
03:05 PM Base Language Bug #2070: BlockManager Action disambiguation
I'm conversion testing this now. Greg Shah
02:56 PM Base Language Bug #2070: BlockManager Action disambiguation
Added cs_upd20130305d.zip only with changes from previous update Costin Savin
02:55 PM Base Language Bug #2070: BlockManager Action disambiguation
Commited cs_upd20130305c.zip to bzr as revision number 10243.
Costin Savin
02:34 PM Base Language Bug #2070: BlockManager Action disambiguation
In cs_upd20130305d.zip, please remove the unchanged files from cs_upd20130305c.zip and add a history entry to control... Greg Shah
02:32 PM Base Language Bug #2070: BlockManager Action disambiguation
cs_upd20130305c.zip has passed conversion testing. Check it in and distribute it. I will look at cs_upd20130305d.zi... Greg Shah
02:05 PM Base Language Bug #2070: BlockManager Action disambiguation
Added proposed update Costin Savin
01:11 PM Base Language Bug #2070: BlockManager Action disambiguation
This is a problem indeed, the solution would be to explicitly import the DMO class. Costin Savin
12:23 PM Base Language Bug #2070: BlockManager Action disambiguation
Costin, please double check this, because I think we need to disambiguate this in the opposite direction too, as I th... Constantin Asofiei
11:41 AM Base Language Bug #2070: BlockManager Action disambiguation
I'm conversion testing this now. Greg Shah
11:32 AM Base Language Bug #2070: BlockManager Action disambiguation
Copied a wrong update deleted wrong file and uploaded the correct one Costin Savin
11:27 AM Base Language Bug #2070: BlockManager Action disambiguation
merge Costin Savin
11:08 AM Base Language Bug #2070: BlockManager Action disambiguation
The code looks good. Constantin will be checking in 1 more version of common-progress. Merge with that and we will ... Greg Shah
09:37 AM Base Language Bug #2070: BlockManager Action disambiguation
merge Costin Savin
05:07 AM Base Language Bug #2070: BlockManager Action disambiguation
Added proposed update Costin Savin
07:12 PM Base Language Bug #2070: BlockManager Action disambiguation
Code Review:
1. Please merge up to the latest bzr level.
2. This method:...
Greg Shah
03:46 PM Conversion Tools Bug #2066: brew adds unnecessary comma in method parameter list after comment
This update passes conversion regression testing with comments off (no changes in generated sources), and MAJIC does ... Constantin Asofiei
03:34 PM Base Language Bug #2076: DMO setter fails when parameter is BaseDataType
ExpressionConversionWorker never returns the int type (e.g. ATTR_POLY) but instead will return the wrapper class name... Greg Shah
02:36 PM Base Language Bug #2076: DMO setter fails when parameter is BaseDataType
Trying to get the rules to create a new variable with the same field type to apply only for expression type ATTR_POLY... Costin Savin
11:12 AM Base Language Bug #2069: Accumulator temp table field disambiguation
Greg Shah wrote:
> Check it in and distribute.
Committed to bzr revision 10242.

> Should we still test ca_upd20...
Constantin Asofiei
11:02 AM Base Language Bug #2069: Accumulator temp table field disambiguation
Check it in and distribute.
Should we still test ca_upd20130304b.zip by itself or should we include these other ch...
Greg Shah
10:03 AM Base Language Bug #2069: Accumulator temp table field disambiguation
0305b.zip has passed conversion regression testing. Constantin Asofiei
09:17 AM Base Language Bug #2069: Accumulator temp table field disambiguation
Another side-note for this task: we should identify all missing no-reference cases and code them in common-progress.r... Constantin Asofiei
08:47 AM Base Language Bug #2069: Accumulator temp table field disambiguation
I've fixed the history entry in common-progress.rules. Constantin Asofiei
08:39 AM Base Language Bug #2069: Accumulator temp table field disambiguation
Greg Shah wrote:
> Go ahead and check these in and distribute them. If Eric has concerns we will address them in a ...
Constantin Asofiei
08:29 AM Base Language Bug #2069: Accumulator temp table field disambiguation
Another case of no-reference is:... Constantin Asofiei
08:18 AM Base Language Bug #2069: Accumulator temp table field disambiguation
Go ahead and check these in and distribute them. If Eric has concerns we will address them in a separate distributio... Greg Shah
05:14 AM Base Language Bug #2069: Accumulator temp table field disambiguation
In the end, I ended up testing (using 10237 as baseline, but this should make no difference):
# 05a (INPUT function ...
Constantin Asofiei
11:41 PM Base Language Bug #2069: Accumulator temp table field disambiguation
This makes the INPUT function to produce no-references. About 04c.zip: my test was without 04b.zip update, to better ... Constantin Asofiei
10:48 PM Base Language Bug #2069: Accumulator temp table field disambiguation
With these changes, pmcli/ converts fully. Also, MAJIC converts fully, but there is a CAN-FIND change in a single fil... Constantin Asofiei
07:01 PM Base Language Bug #2069: Accumulator temp table field disambiguation
Does this resolve #1985 note 64 or is this just more fixes on the way to the Mad Hatter's tea party? Greg Shah
10:56 AM Database Feature #1933: add conversion support for certain metadata constructs
This update adds a message to standard console when a duplicate dmo name is detected. Ovidiu Maxiniuc
10:11 AM Database Feature #1933: add conversion support for certain metadata constructs
I only want you to add this feature if it is very fast to implement, since this is not in the critical path. Otherwi... Eric Faulhaber
10:04 AM Database Feature #1933: add conversion support for certain metadata constructs
Should I add the verification? What kind should it be? Just a @System.err/out.print()@ or persisted to logging file ?... Ovidiu Maxiniuc
09:13 AM Database Feature #1933: add conversion support for certain metadata constructs
Ovidiu Maxiniuc wrote:
> Shouldn't we use an automated postfixed name change if some name is already taken? Or at le...
Eric Faulhaber
07:52 AM Database Feature #1933: add conversion support for certain metadata constructs
Fixed java package for metadata tables.
Just a question. I know that the problem is solvable by using hints but if...
Ovidiu Maxiniuc

03/04/2013

06:46 PM Base Language Feature #2050: ATTR_POLY/METH_POLY used as rvalue or in expressions
Passed conversion testing and checked in to bzr as revision 10239. Greg Shah
05:04 PM Base Language Feature #2050: ATTR_POLY/METH_POLY used as rvalue or in expressions
New version of the update with another change to the parser that fixes a problem found in testing the server code. I... Greg Shah
03:32 PM Base Language Feature #2050: ATTR_POLY/METH_POLY used as rvalue or in expressions
#1985 note 96 shows a new problem: DB_REF_NON_STATIC needs to be supported. I have added it to the ECW. It uses con... Greg Shah
04:38 PM Base Language Bug #2069: Accumulator temp table field disambiguation
This fix attempt does the following:
# fixes #2059 's ecf_upd20130303b.zip, to include temp-tables too
# fixes a bu...
Constantin Asofiei
03:59 PM Base Language Bug #2069: Accumulator temp table field disambiguation
Constantin Asofiei wrote:
> This code tests only for BUFFER nodes, and excludes tables, temp-tables, work-tables. Wa...
Eric Faulhaber
03:39 PM Base Language Bug #2069: Accumulator temp table field disambiguation
Some news about the field name disambiguation issue. In SchemaDictionary.promoteEntry, there is this test:... Constantin Asofiei
03:17 PM Base Language Bug #2069: Accumulator temp table field disambiguation
Committed to bzr revision 10238.
These files have changes which are not limitted to just buffer scope:...
Constantin Asofiei
03:01 PM Base Language Bug #2069: Accumulator temp table field disambiguation
Check it it and distribute it. I will make sure runtime regression testing is run separately. What programs should ... Greg Shah
02:48 PM Base Language Bug #2069: Accumulator temp table field disambiguation
Conversion regression testing has finished, the note about runtime regression testing still stands, with the addition... Constantin Asofiei
01:52 PM Base Language Bug #2069: Accumulator temp table field disambiguation
The code looks good.
It also fixes all remaining issues in #1985 notes 93, 104-109 and 111. These programs all co...
Greg Shah
01:27 PM Base Language Bug #2069: Accumulator temp table field disambiguation
Looks like the matching in accumulators needs to be done using the bufname too, attached update does this. I'm puttin... Constantin Asofiei
12:25 PM Base Language Bug #2069: Accumulator temp table field disambiguation
> In my example, both fields have a schemaname of "tt.num" but the bufname will differ ("b1" vs "b2"). Actually, the... Constantin Asofiei
12:18 PM Base Language Bug #2069: Accumulator temp table field disambiguation
I don't think schemaname alone will work.
In my example, both fields have a schemaname of "tt.num" but the bufname...
Greg Shah
12:09 PM Base Language Bug #2069: Accumulator temp table field disambiguation
The 0304a.zip passed conversion regression testing, but there are lots of buffer scope-related changes, as the accum ... Constantin Asofiei
11:41 AM Base Language Bug #2069: Accumulator temp table field disambiguation
If the parser gets the schemaname right, in case of unqualified field and compilable 4GL code, I don't think we will ... Constantin Asofiei
11:15 AM Base Language Bug #2069: Accumulator temp table field disambiguation
The changes look good, though we may have to work off something different than only schemaname.... Greg Shah
10:06 AM Base Language Bug #2069: Accumulator temp table field disambiguation
This update:
* makes the field in accum function to be a no-reference.
* fixes CAN-FIND function, when its WHERE cl...
Constantin Asofiei
09:57 AM Base Language Bug #2069: Accumulator temp table field disambiguation
About the ACCUM no_reference: after I let this be a no_reference, then the "refid" annotation will not be emitted for... Constantin Asofiei
09:41 AM Base Language Bug #2069: Accumulator temp table field disambiguation
Please prepare the ACCUM no_reference and CAN-FIND changes and upload the update ASAP. Both of these seem to be corr... Greg Shah
04:03 PM Database Bug #2059: CAN-FIND clause for a perm table in the RECORD_PHRASE of a temp table, with a FOR EACH...
Good point. Actually, the best is probably just to get rid of the @schemaScope@ variable altogether and use the @glo... Eric Faulhaber
03:53 PM Database Bug #2059: CAN-FIND clause for a perm table in the RECORD_PHRASE of a temp table, with a FOR EACH...
LE: actually, I think the correct test is:... Constantin Asofiei
03:45 PM Database Bug #2059: CAN-FIND clause for a perm table in the RECORD_PHRASE of a temp table, with a FOR EACH...
Eric, your fix in SchemaDictionary I don't think it works for temp-tables, as the following code:... Constantin Asofiei
03:12 PM Database Feature #1933: add conversion support for certain metadata constructs
Ovidiu Maxiniuc wrote:
> You mean that we should use @P2OLookup@ instead of the current @SymbolResolver@ calls ?
...
Eric Faulhaber
01:04 PM Database Feature #1933: add conversion support for certain metadata constructs
> I think this is probably best done in P2OLookup (in the schema package), such that P2OLookup.javaPackage(String his... Ovidiu Maxiniuc
11:07 AM Database Feature #1933: add conversion support for certain metadata constructs
Ovidiu Maxiniuc wrote:
> 4GL has a meta set of tables associated with each database and from the user point of view ...
Eric Faulhaber
02:35 PM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
> Didn't the static import statement work? I wasn't sure if it would work with enums or not. If it doesn't work, then... Eugenie Lyzenko
02:31 PM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
> We need to create separate class file for ParmType?
Yes.
> In this case we need to declare ParmType.CHAR ins...
Greg Shah
01:35 PM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
Two questions.
1. We need to create separate class file for ParmType? In this case we need to declare ParmType.CHAR ...
Eugenie Lyzenko
10:51 AM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
This is a high priority for milestone 4 so that we can make sure to generate compilable code. Please implement this ... Greg Shah
01:19 PM Database Feature #1947: add conversion support for database methods
Vadim Nebogatove wrote (in email):
> I tried to make tests today with literal constants. Possible I implemented chan...
Eric Faulhaber
09:44 AM Database Feature #1947: add conversion support for database methods
Vadim Nebogatov wrote:
> I have analyzed one more time. Solution you wrote is useful if both parameters are literals...
Eric Faulhaber
04:05 AM Database Feature #1947: add conversion support for database methods
I have analyzed one more time. Solution you wrote is useful if both parameters are literals. But many combined cases ... Vadim Nebogatov
03:04 AM Database Feature #1947: add conversion support for database methods
I did not notice that Ubuntu Nautilus does not show backup files by default... Vadim Nebogatov
09:48 PM Database Feature #1947: add conversion support for database methods
Code review 20130303a:
* As I noted earlier, please don't include backup files (e.g., @QueryWrapper.java~@) in you...
Eric Faulhaber
12:38 PM Base Language Bug #2076: DMO setter fails when parameter is BaseDataType
Example:... Costin Savin
12:34 PM Base Language Bug #2076 (Closed): DMO setter fails when parameter is BaseDataType
Costin Savin
11:32 AM Base Language Bug #2070: BlockManager Action disambiguation
Added the proposed update Costin Savin
10:54 AM Database Feature #1668: add support for additional (non-dynamic) database attributes
Added @FieldInterface@/@FieldReference.value(NumberType)@. This is related to #2068, note 18.1.
This update must be...
Ovidiu Maxiniuc
10:53 AM Base Language Bug #2075: unknown literals in nested expressions
See #2053 where we are creating a parameter type lookup facility for builtin funcs and methods. Greg Shah
10:20 AM Base Language Bug #2075: unknown literals in nested expressions
> One of the things I was interested in using the signature data for was during expression typing (we could know exac... Constantin Asofiei
09:52 AM Base Language Bug #2075: unknown literals in nested expressions
> Go ahead and commit the change and distribute it.
Committed to bzr revision 10237.
> If I understand properly, ...
Constantin Asofiei
09:46 AM Base Language Bug #2075: unknown literals in nested expressions
Go ahead and commit the change and distribute it.
If I understand properly, we are about to have compile issues wi...
Greg Shah
09:28 AM Base Language Bug #2075: unknown literals in nested expressions
> The question: how much code do we have that is dependent upon this unintended result? I prefer to cleanup the pars... Constantin Asofiei
09:07 AM Base Language Bug #2075: unknown literals in nested expressions
Actually, I am worried that the problem is really in how the parser leaves the tree. A pretty important rule about t... Greg Shah
10:47 AM Database Feature #1967: rework DMO class/interface hierarchy
Unfortunately, at some point we might have to rename the APIs in these interfaces too, which are extended by Buffer i... Constantin Asofiei
10:33 AM Database Feature #1967: rework DMO class/interface hierarchy
This update fixes eventual collisions in dmo interfaces because of @WrappedResource@ interface (@isValid()@ & @isUnkn... Ovidiu Maxiniuc
09:37 AM Database Feature #2000: add conversion support for table and table handle parameters
Got it. I was mis-reading the meaning of the syntax. Greg Shah
09:33 AM Database Feature #2000: add conversion support for table and table handle parameters
> Is there any difference in behavior if you switch the order of the DEF SHARED VAR and DEF PARAMETER (if the DEF SHA... Stanislav Lomany
09:31 AM Database Feature #2000: add conversion support for table and table handle parameters
Is there any difference in behavior if you switch the order of the DEF SHARED VAR and DEF PARAMETER (if the DEF SHARE... Greg Shah
05:39 AM Database Feature #2000: add conversion support for table and table handle parameters
I found that @DEF PARAMETER TABLE-HANDLE FOR th@ where @th@ is a [new] shared variable is handled differently that if... Stanislav Lomany
05:15 AM Database Feature #1953: add conversion support for CREATE BUFFER statement
Added missing create() overloads.
Also reformatted and sorted so that they are more visible/countable.
Fixes compil...
Ovidiu Maxiniuc

03/03/2013

03:40 PM Base Language Bug #2069: Accumulator temp table field disambiguation
Some final notes for today:
# the @CREATE real@ statement produces a free reference, same as a @FIND FIRST real@. If...
Constantin Asofiei
12:32 PM Base Language Bug #2069: Accumulator temp table field disambiguation
Good information in note 3.
1. You have proven that the ACCUM() function parameters are not free references, they ...
Greg Shah
06:40 AM Base Language Bug #2069: Accumulator temp table field disambiguation
First of all, looks like ACCUM function should not produce free-references, because if it did produce, then the code ... Constantin Asofiei
03:28 PM Database Feature #1947: add conversion support for database methods
Attached update vmn_upd20130303a.zip with tests vmn_upd20130303a_test_cases.zip is next replacement of update vmn_upd... Vadim Nebogatov
03:22 PM Database Bug #2059: CAN-FIND clause for a perm table in the RECORD_PHRASE of a temp table, with a FOR EACH...
The attached update is an interim workaround to protect against the NPE so we can get further into conversion. Still... Eric Faulhaber
11:46 AM Base Language Bug #2075: unknown literals in nested expressions
The fix has passed conversion regression testing. Constantin Asofiei
08:06 AM Base Language Bug #2075: unknown literals in nested expressions
P2J fails to convert this case:... Constantin Asofiei
07:22 AM Base Language Bug #2075 (WIP): unknown literals in nested expressions
Constantin Asofiei
 

Also available in: Atom