Project

General

Profile

Activity

From 12/30/2013 to 01/28/2014

01/28/2014

04:23 PM Base Language Feature #1634: implement full native library (.so or DLL) support
Greg Shah wrote:
> ...
> Ovidiu: please review the rules/include/* changes, in regard to assign trigger var def sup...
Ovidiu Maxiniuc
07:54 PM Base Language Feature #1634: implement full native library (.so or DLL) support
OK. Now we are completely using our own libffi Windows builds.
Building libffi libraries from sources using MSYS a...
Eugenie Lyzenko
02:30 PM User Interface Feature #1811: implement the AJAX client driver
Code Review 0128c
The code looks good.
> but just for safety is OK.
Exactly.
> 1. We are not use Dojo at ...
Greg Shah
01:47 PM User Interface Feature #1811: implement the AJAX client driver
I did the changes. Normally no concurrency should occur on this class but just for safety is OK.
I have two other ...
Marius Gligor
01:28 PM User Interface Feature #1811: implement the AJAX client driver
> Sorry, but I don't find any place in this class to use synchronization.
> The open and close methods are synchroni...
Greg Shah
01:13 PM User Interface Feature #1811: implement the AJAX client driver
Sorry, I changed the date of last changes on the ClientBuilderOptions class header. Marius Gligor
01:08 PM User Interface Feature #1811: implement the AJAX client driver
1. Done. ChuiWebSimulator.onConnect allow us to set the session idle time out which in turn override the default valu... Marius Gligor
12:52 PM User Interface Feature #1811: implement the AJAX client driver
> The ConcurrentHashMap is fully thread safe by design and is internally synchronized.
> The Java concurrent package...
Greg Shah
11:44 AM User Interface Feature #1811: implement the AJAX client driver
I added the missing Result class.
The ConcurrentHashMap is fully thread safe by design and is internally synchronize...
Marius Gligor
11:33 AM User Interface Feature #1811: implement the AJAX client driver
Code Review 0128a
1. In ChuiWebSimulator, I would like to shift to an idle timeout (maxIdleTime) that is set progr...
Greg Shah
10:46 AM User Interface Feature #1811: implement the AJAX client driver
Here is the implementation for CTRL-C issue and some remarks.
1. A Result object is used instead a boolean value.
...
Marius Gligor
01:42 PM Database Bug #2237: wrong historical annotations in dynamic temp-tables
Looks like this update fixes the issue.
The table legacy name is also added to in-memory AST. When TRPL (p2o.xml) is...
Ovidiu Maxiniuc
09:49 AM Database Bug #2237: wrong historical annotations in dynamic temp-tables
Here is a more complex sample case:... Ovidiu Maxiniuc
09:43 AM Database Bug #2237 (WIP): wrong historical annotations in dynamic temp-tables
When creating dynamic temp-tables the field and table annotations are wrong. I could reproduce this in dynamic querie... Ovidiu Maxiniuc
09:38 AM Database Bug #2237 (Closed): wrong historical annotations in dynamic temp-tables
Ovidiu Maxiniuc
01:38 PM Database Feature #1662: runtime support for table parameters
> * I was a bit confused by the deferred copy error processing in @TemporaryBuffer@, with the corresponding change in... Stanislav Lomany
10:59 AM Database Feature #2207: Remaining issues for dynamic buffers and dynamic tables
The first issue is not a dynamic tables issue, it is about undo processing for NO-UNDO temp tables. The same result c... Stanislav Lomany
05:46 AM User Interface Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects)
Greg Shah wrote:
> I prefer an approach where multiuple virtual widgets on the server resolve to the correct widget ...
Constantin Asofiei
05:32 AM User Interface Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects)
We need be careful when using conditional down (@DOWN WITH FRAME f1@, without an expression) and explicit down (i.e. ... Constantin Asofiei

01/27/2014

06:29 PM User Interface Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects)
As we are getting close to the time for implementation, I want to mention something.
I would like to consider an i...
Greg Shah
06:12 PM User Interface Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects)
I suppose I can formulate some rule, interpreting the rules, that Progress uses to fill fields with values.
We have ...
Vadim Gindin
05:43 PM User Interface Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects)
Constantin Asofiei wrote:
> > The only unclear moment is the algorithm of Fill-in filling with values for me.
> I'm...
Vadim Gindin
04:06 PM User Interface Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects)
> The only unclear moment is the algorithm of Fill-in filling with values for me.
I'm not sure what you are refering...
Constantin Asofiei
03:58 PM User Interface Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects)
I've committed all test procedures I had.
The result of stream test _(streams.p)_ is in file _2162_ext_frame_stre...
Vadim Gindin
10:35 AM User Interface Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects)
Please commmit the tests for note 36/37 to bzr.
> About cyclic order of field groups I confirm it. All tests show i...
Constantin Asofiei
05:59 PM Base Language Feature #1634: implement full native library (.so or DLL) support
> What if to build libffi in mingw we have to set up MSYS? Is it acceptable?
Yes. But we would only use that envi...
Greg Shah
05:44 PM Base Language Feature #1634: implement full native library (.so or DLL) support
Greg, the question. What if to build libffi in mingw we have to set up MSYS? Is it acceptable? Eugenie Lyzenko
02:34 PM Base Language Feature #1634: implement full native library (.so or DLL) support
The update evl_upd20140127a.zip committed in bzr as 10456. No regression testing required, only Windows syntax code w... Eugenie Lyzenko
01:38 PM Base Language Feature #1634: implement full native library (.so or DLL) support
Conversion regression testing for ges_upd20140127a.zip has passed. No change occurs in the output. This has been ch... Greg Shah
01:31 PM Base Language Feature #1634: implement full native library (.so or DLL) support
Code Review evl_upd20140127.zip
The change is fine. Check it in and distribute it. Then post the revision number...
Greg Shah
01:02 PM Base Language Feature #1634: implement full native library (.so or DLL) support
The updates fixes compilation error on Wndows. Also the binaries allow to build p2j.dll on Windows. Has both 64-bit a... Eugenie Lyzenko
11:27 AM Base Language Feature #1634: implement full native library (.so or DLL) support
This update has some important fixes to make the commons cases work. There is still at least 1 known problem (dealin... Greg Shah
08:49 AM Base Language Feature #1634: implement full native library (.so or DLL) support
Do you have the compilation fixes ready now? If so, please upload them for review.
Have you resolved the way to b...
Greg Shah
01:29 PM Database Feature #1652: add conversion and runtime support for dynamically prepared temp-tables
Update to Hibernate sources. Committed to bzr revision 10454. Stanislav Lomany
11:23 AM Database Feature #2134: configurable denormalization of extent fields into individual fields in schema con...
The unique index is needed; it is part of the legacy metadata schema and an application may include code which relies... Eric Faulhaber
10:23 AM Database Feature #1651 (Closed): add support for dynamic database features
Eric Faulhaber
10:22 AM Database Feature #1655 (Closed): add conversion and runtime support for certain dynamic database attribute...
This update fixes problems with the columnLabel and validateExpression annotations (refs #1655), encountered while co... Eric Faulhaber
09:51 AM User Interface Feature #1811: implement the AJAX client driver
Code Review 0127a
I am fine with the code. It looks very good.
My only request is for tty.keyboard.js, tty.key...
Greg Shah
09:40 AM User Interface Feature #1811: implement the AJAX client driver
> B. Another solution is to use the existing RemoteObject to get a new account and do a re-logon. This scenario shoul... Greg Shah
08:30 AM User Interface Feature #1811: implement the AJAX client driver
1. Today I did a code review over the JS code. The changes are attached.
2. Also I started to investigate the CTRL...
Marius Gligor

01/26/2014

06:26 PM Database Feature #2134: configurable denormalization of extent fields into individual fields in schema con...
Could you check my last question (note 45) about order? Similar question should be addressed with newly added @fieldI... Vadim Nebogatov
09:25 PM Database Feature #1655 (Test): add conversion and runtime support for certain dynamic database attributes ...
The attached, merged update passed regression testing and was committed by Ovidiu to bzr rev. 10452.
I encountered...
Eric Faulhaber
08:30 PM Database Feature #1652 (Closed): add conversion and runtime support for dynamically prepared temp-tables
Eric Faulhaber
08:29 PM Database Bug #2236: HQL error generated from dynamically converted query with extent field reference in wh...
Failing test case is dbuf-query-extent1-dt.p (Stanislav: please provide test case; it is not currently in the testcas... Eric Faulhaber
08:19 PM Database Bug #2236 (Closed): HQL error generated from dynamically converted query with extent field refere...
Eric Faulhaber
08:15 PM Database Feature #2235: fix deployment issues related to dynamic database conversion resources
In #1652, note 135, Stanislav wrote:
> The following files and directories have to be accessed from the server class...
Eric Faulhaber
08:09 PM Database Feature #2235 (Closed): fix deployment issues related to dynamic database conversion resources
Eric Faulhaber
08:06 PM Database Feature #1662 (Closed): runtime support for table parameters
Eric Faulhaber

01/25/2014

04:57 PM User Interface Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects)
About cyclic order of field groups I confirm it. All tests show it. About Fill-in fields - they have equal IDs at all... Vadim Gindin
07:11 PM User Interface Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects)
Here are next tests.
1. Test: _frame_line.p_
Description: The goal is to find out is the FRAME-LINE function and ...
Vadim Gindin
11:04 AM Base Language Feature #1634: implement full native library (.so or DLL) support
> Eugenie: it is OK to get the compilation issues and the libffi.dll built properly. But after that, pause your work ... Eugenie Lyzenko
09:37 AM Base Language Feature #1634: implement full native library (.so or DLL) support
Eugenie: it is OK to get the compilation issues and the libffi.dll built properly. But after that, pause your work o... Greg Shah
10:45 AM User Interface Feature #1811: implement the AJAX client driver
It is good, thanks. Greg Shah
10:43 AM User Interface Feature #1811: implement the AJAX client driver
Sorry, was my fault. Marius Gligor
10:38 AM User Interface Feature #1811: implement the AJAX client driver
Code Review 0125c
I like it. The only thing I don't understand is why the tty.keymap.js is missing.
Greg Shah
10:26 AM User Interface Feature #1811: implement the AJAX client driver
Done. Marius Gligor
10:00 AM User Interface Feature #1811: implement the AJAX client driver
Code Review 0125b
I like this version better from the perspective of how you made the code better separated.
Bu...
Greg Shah
09:55 AM User Interface Feature #1811: implement the AJAX client driver
Code Review 0125a
I don't want to remove all the server-side Dojo support that you already provided. Put that wor...
Greg Shah
09:46 AM User Interface Feature #1811: implement the AJAX client driver
The keyboard listeners are bind on canvas instead document.
The canvas should have the focus in order to receive key...
Marius Gligor
06:31 AM User Interface Feature #1811: implement the AJAX client driver
Looking for a solution to fix the cross browser keystrokes handle issues I found:
Supported Key Combinations:
The...
Marius Gligor
09:35 AM Database Feature #1652: add conversion and runtime support for dynamically prepared temp-tables
As mentioned in #1651 note 5:
> 7. Long term, we want the standard rules to be loaded from the p2j.jar instead of ...
Greg Shah
02:54 AM Database Feature #1652: add conversion and runtime support for dynamically prepared temp-tables
The following files and directories have to be accessed from the server classpath:... Stanislav Lomany
09:29 AM User Interface Feature #2037 (Closed): runtime support for frame options
Greg Shah
09:29 AM User Interface Feature #1801: add some frame options
Attached is the actual version that is the merged code that was checked in as 10451. Greg Shah

01/24/2014

06:43 PM Base Language Feature #1597 (WIP): shift SQRT implementation (MathOps.sqrt()) to BigDecimal
Hynek Cihlar
08:29 AM Base Language Feature #1597: shift SQRT implementation (MathOps.sqrt()) to BigDecimal
I don't know the answer. Often, if the input is a decimal value, then the output can have the same precision. Other... Greg Shah
07:58 AM Base Language Feature #1597: shift SQRT implementation (MathOps.sqrt()) to BigDecimal
What is the expected precision of the algorithm? Hynek Cihlar
06:40 PM User Interface Feature #2037 (Review): runtime support for frame options
Hynek Cihlar
06:38 PM User Interface Feature #1801: add some frame options
hc_upd20140123b.zip passed regression testing and was checked-in to bazaar repository as revision 10451. Hynek Cihlar
06:27 PM Base Language Feature #1634: implement full native library (.so or DLL) support
Building on Windows notes:
The first thing after including ffi.h into compilation preocess is to change the library_...
Eugenie Lyzenko
09:46 PM Base Language Feature #1634 (Closed): implement full native library (.so or DLL) support
Greg Shah
09:37 PM Base Language Feature #1634: implement full native library (.so or DLL) support
The CTRL-C 3-way tests failed (expected) and there were 5 failures in @tc_job*@ and @tc_dc*@ tests (1 of which always... Greg Shah
04:06 PM User Interface Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects)
Vadim Gindin wrote:
> What do you mean when you are saying "the frame starts with only one field-group (for the firs...
Constantin Asofiei
03:53 PM User Interface Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects)
Vadim Gindin wrote:
> Why it is needed to have downBody array with only the first row real?
The problems are in th...
Constantin Asofiei
01:56 PM User Interface Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects)
What do you mean when you are saying "the frame starts with only one field-group (for the first row). When advancing ... Vadim Gindin
01:11 PM User Interface Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects)
As I can understand this, it sounds reasonable. I just have several questions about details. See below.
Constantin...
Vadim Gindin
03:29 PM Database Feature #1652: add conversion and runtime support for dynamically prepared temp-tables
Stas, I looked around this task history and that of related tasks, but I can't seem to find a summary of the configur... Eric Faulhaber
01:21 PM Database Feature #1652: add conversion and runtime support for dynamically prepared temp-tables
Committed to bzr revision 10448. Stanislav Lomany
01:19 PM Database Feature #1652: add conversion and runtime support for dynamically prepared temp-tables
Update for remaining issues. Presumably does not need regression testing. Stanislav Lomany
03:19 PM User Interface Feature #1811: implement the AJAX client driver
> I saw that when a pop-up window is created we can eliminate menu bars and toll bars.
> Do you believe that could b...
Greg Shah
02:27 PM User Interface Feature #1811: implement the AJAX client driver
Starting from IE 9 preventDefault() is supported. We are interested on IE 10 and IE 11 because IE 9 does not support ... Marius Gligor
02:20 PM User Interface Feature #1811: implement the AJAX client driver
Code Review 0124c
My only thought here is that we probably need to always preventDefault() and stopImmediatePropag...
Greg Shah
02:17 PM User Interface Feature #1811: implement the AJAX client driver
To disable default behavior you may have to do 2 things:
1. Prevent the default behavior. In browsers that suppor...
Greg Shah
01:48 PM User Interface Feature #1811: implement the AJAX client driver
Some small changes to fix ESC key in IE.
I did more tests on Windows using IE 11 and Chrome 31.
Unfortunately on ...
Marius Gligor
12:02 PM User Interface Feature #1811: implement the AJAX client driver
It's works in IE but I have to fix a small issue. Event preventDefault() does not work properly with IE.
I tested bo...
Marius Gligor
11:33 AM User Interface Feature #1811: implement the AJAX client driver
1. We have to solve the CTRL-C issue to initialize the converted application without a new server authentication if p... Marius Gligor
10:58 AM User Interface Feature #1811: implement the AJAX client driver
Can you please post a list of what is left to do on #2212? Greg Shah
10:51 AM User Interface Feature #1811: implement the AJAX client driver
Code Review 0124a
All the changes look good. I like the more modular approach.
Code Review 0124b
I prefer t...
Greg Shah
10:40 AM User Interface Feature #1811: implement the AJAX client driver
I did some small improvements and bug fixing. Basically I eliminated the dojo/keys module dependencies.
With this ch...
Marius Gligor
01:23 PM Database Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...
I am running now the full regression on this update. It is based on bzr rev 10450.
It contains the
* om_upd2014012...
Ovidiu Maxiniuc
09:59 AM Database Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...
Tested, results are the same:... Vadim Nebogatov
02:28 AM Database Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...
Vadim: this seems like the BUFFER-FIELD can never be deleted explicitly. I forgot about dynamic buffers - please test... Constantin Asofiei
12:33 PM Database Feature #1658 (Closed): improve database trigger support
Eric Faulhaber
12:33 PM Database Feature #1581 (Closed): add conversion and runtime support for certain metadata constructs
Eric Faulhaber
11:53 AM User Interface Feature #1787: implement batch mode support
This was committed as bzr revision 10449. Greg Shah
10:20 AM User Interface Feature #1787: implement batch mode support
The testing results are in:
@10446_f202309_20140124_evl.zip@
Taking into account all sessions the testing has been ...
Eugenie Lyzenko
09:53 AM User Interface Feature #1787: implement batch mode support
Code Review 0124a
All the merges look good. Considering that the only tricky merging was in the build scripts, I ...
Greg Shah
09:29 AM User Interface Feature #1787: implement batch mode support
The code merge with the 10447. Looks like there are no regressions found.
Do I need to commit and distribute?
Eugenie Lyzenko
08:33 AM Base Language Feature #1596: complete big decimal implementation
We had moved from use of double to BigDecimal in the past because we found deviations from the 4GL implementation tha... Greg Shah
09:47 PM Base Language Feature #1641 (Closed): implement SAX XML support
Greg Shah
08:33 PM Base Language Feature #1641: implement SAX XML support
SAX testcases committed at bzr revision 1088. Evgeny Kiselev
09:46 PM Base Language Feature #1988 (Closed): runtime support for SAX
Greg Shah
09:45 PM Base Language Support #2234: test and fix native API support on Windows
Put all history in #1634. Greg Shah
09:43 PM Base Language Support #2234 (Closed): test and fix native API support on Windows
Greg Shah
09:45 PM Base Language Support #2233: test and fix the native API support on Linux
Put all history in #1634. Greg Shah
09:43 PM Base Language Support #2233 (Closed): test and fix the native API support on Linux
Greg Shah
09:41 PM Base Language Feature #2121 (Closed): implement Java runtime support for native libraries
Greg Shah
09:41 PM Base Language Feature #1959 (Closed): implement JNI runtime support for native libraries
Greg Shah

01/23/2014

06:54 PM Database Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...
I tested the following test case based on note 98... Vadim Nebogatov
06:26 PM Database Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...
Notes about @DynamicQueryHelper@ from om_upd20140123a:
* I'm OK with using the @QueryProcessor@ interface instead of...
Constantin Asofiei
06:05 PM Database Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...
Code review om_upd20140123a:
I'm good with the changes, assuming you will come back around after M7 and finish up ...
Eric Faulhaber
05:09 PM Database Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...
Changes in this update (beside the things from notes 89, 90 & 97):
* Added support for dereference as left-side of a...
Ovidiu Maxiniuc
10:28 AM Database Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...
Update @vmn_upd20140123a.zip@ contains all implemented methods from note 47 excepting @FieldReference.resourceDelete(... Vadim Nebogatov
03:09 AM Database Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...
Vadim Nebogatov wrote:
> Is current implementation of FieldReference.resourceDelete() correct? What should be tested ...
Constantin Asofiei
02:56 AM Database Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...
About the dynamic query code in om_upd20140122a.zip:
* what I don't like is that we are duplicating code in @parseQu...
Constantin Asofiei
06:02 PM User Interface Feature #1801: add some frame options
It looks good. Go ahead with testing. Greg Shah
05:47 PM User Interface Feature #1801: add some frame options
Yes, the application will work ok without the color-map.xml file on the classpath. Just an info log entry will be out... Hynek Cihlar
05:28 PM User Interface Feature #1801: add some frame options
Code Review 0123a
I am fine with the version, except that the color-map.xml should not be checked into the P2J pro...
Greg Shah
04:56 PM User Interface Feature #1801: add some frame options
The attached file includes runtime support of the DCOLOR and PFCOLOR attributes. Hynek Cihlar
04:34 PM User Interface Feature #1801: add some frame options
The implementation is finished. I am doing basic functional tests and will be uploading for review in about half an h... Hynek Cihlar
04:13 PM User Interface Feature #1801: add some frame options
How soon can you upload a candidate for review? I will get it reviewed quickly and hopefully it will be ready for re... Greg Shah
03:58 PM User Interface Feature #1801: add some frame options
Here are the findings.
@DCOLOR@ and @PFCOLOR@ exist only in the form of attributes of INTEGER type. For the chara...
Hynek Cihlar
05:13 PM User Interface Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects)
Vadim, good findings, but you are misinterpreting something. When you are printing the frame's children in @no-loop-i... Constantin Asofiei
04:51 PM Base Language Feature #2232: finish testing the wrapped mode using the web services exposed by the testing server
Using the server created in #2208, test the web services using wrapped mode and fix any found problems.
Also, fix ...
Constantin Asofiei
04:45 PM Base Language Feature #2232 (Closed): finish testing the wrapped mode using the web services exposed by the tes...
Constantin Asofiei
04:41 PM Base Language Feature #1644 (Closed): implement SOAP support
Greg Shah
04:40 PM Base Language Feature #1995 (Closed): runtime support for SOAP
Greg Shah
04:40 PM Base Language Feature #1645 (Closed): implement web services support
Greg Shah
04:39 PM Base Language Feature #2022 (Closed): runtime support for web services
Greg Shah
02:54 PM Database Feature #1652: add conversion and runtime support for dynamically prepared temp-tables
OK, that's a bit confusing, but got it. Still, please open a separate task to track the features needed for full comp... Eric Faulhaber
02:49 PM Database Feature #1652: add conversion and runtime support for dynamically prepared temp-tables
> I think append- is the only option in scope here, since it can be used in internal code paths. The replace- and loo... Stanislav Lomany
02:38 PM Database Feature #1652: add conversion and runtime support for dynamically prepared temp-tables
Stanislav Lomany wrote:
> 3. COPY-TEMP-TABLE: copy modes: append-, replace- and loose-copy-
I think append- is the ...
Eric Faulhaber
02:29 PM Database Feature #1652: add conversion and runtime support for dynamically prepared temp-tables
> * Is the @import com.goldencode.p2j.convert.*;@ statement needed in @TemporaryBuffer@?
That is required for @ParmT...
Stanislav Lomany
02:27 PM Database Feature #1652: add conversion and runtime support for dynamically prepared temp-tables
OK, makes sense. I was understanding this to be a different problem. Eric Faulhaber
02:11 PM Database Feature #1652: add conversion and runtime support for dynamically prepared temp-tables
> Regarding the first error, is it actually necessary to modify Hibernate? I don't know where the code you modified a... Stanislav Lomany
01:36 PM Database Feature #1652: add conversion and runtime support for dynamically prepared temp-tables
Code review 20140123a:
* Is the @import com.goldencode.p2j.convert.*;@ statement needed in @TemporaryBuffer@?
* The...
Eric Faulhaber
01:04 PM Database Feature #1652: add conversion and runtime support for dynamically prepared temp-tables
Regarding the first error, is it actually necessary to modify Hibernate? I don't know where the code you modified abo... Eric Faulhaber
12:24 PM Database Feature #1652: add conversion and runtime support for dynamically prepared temp-tables
Regarding the second error, this query is generated by the conversion rules for historical reasons, when we handled s... Eric Faulhaber
12:21 PM Database Feature #1652: add conversion and runtime support for dynamically prepared temp-tables
Current state of work. Needs regression testing. Stanislav Lomany
10:50 AM Database Feature #1652: add conversion and runtime support for dynamically prepared temp-tables
> Is there a stack trace that goes with this error that shows the problem at the Hibernate level?... Stanislav Lomany
10:18 AM Database Feature #1652: add conversion and runtime support for dynamically prepared temp-tables
Is there a stack trace that goes with this error that shows the problem at the Hibernate level?
Hibernate cannot d...
Eric Faulhaber
09:59 AM Database Feature #1652: add conversion and runtime support for dynamically prepared temp-tables
I was pretty sure that extents work normally for dynamic tables, there are several checked in testcases for them. How... Stanislav Lomany
02:08 PM User Interface Feature #1787: implement batch mode support
Looks like the main part is OK. Continue testing with CTRL-C one. Eugenie Lyzenko
01:50 PM User Interface Feature #1811: implement the AJAX client driver
Code Review 0123a
This is really, really good! I'm glad that you were able to work out an approach that is much m...
Greg Shah
12:01 PM User Interface Feature #1811: implement the AJAX client driver
1. The DOM level 3 events specifications are implemented total or partial on all major web browser but sligtly differ... Marius Gligor
12:57 PM Base Language Feature #1634: implement full native library (.so or DLL) support
This is a version with more fixes, but it is not finished. Still, it is a good version to put into regression testin... Greg Shah
10:29 AM Base Language Feature #1634: implement full native library (.so or DLL) support
This version fixes a conversion regression found in testing. It has passed conversion regression testing and it also... Greg Shah
07:37 PM Base Language Feature #1634: implement full native library (.so or DLL) support
This is a version that has many fixes implemented. Many native API use cases are now working, but not all use cases ... Greg Shah

01/22/2014

06:52 PM User Interface Feature #1801: add some frame options
I don't fully know the answer. I think you will have to do some testing in the real 4GL.
I do know how we have co...
Greg Shah
06:15 PM User Interface Feature #1801: add some frame options
A question about DCOLOR and PFCOLOR. Is the following sample the correct way to set the protermcap color?... Hynek Cihlar
06:30 PM User Interface Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects)
I'm repeating that i:handle peculiarities are the same in iterating and non-iterating tests. All tests I have are com... Vadim Gindin
06:27 PM User Interface Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects)
2. _external_scoped_frame_ihandle.p_ This test checks behavior of the CURRENT-ITERATION in repeat loop in case when t... Vadim Gindin
06:14 PM User Interface Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects)
Here are tests and those results.
1. _no_loop_ihandle.p_. Try to check CURRENT-ITERATION behavior in the case when...
Vadim Gindin
11:38 AM User Interface Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects)
Vadim Gindin wrote:
> What else can I do to find when a widget row is created?
Check your findings with cases when ...
Constantin Asofiei
11:28 AM User Interface Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects)
Constantin Asofiei wrote:
> Vadim, using the test at note 15, check how the body of a down frame evolves in the case...
Vadim Gindin
06:02 PM Database Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...
Ovidiu, Vadim: it looks like you are both very close to being finished with your respective pieces. Although we origi... Eric Faulhaber
05:41 PM Database Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...
Vadim Nebogatov wrote:
> Is current implementation of FieldReference.resourceDelete() correct? What should be tested...
Eric Faulhaber
05:20 PM Database Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...
I see only one usage of @resourceDelete()@ related with buffers – @TempTableBuilder.forceClear()@.
@resourceDelete(...
Vadim Nebogatov
04:35 PM Database Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...
Constantin Asofiei wrote:
> Eric Faulhaber wrote:
> > Sorry, this was my comment and I see how it is misleading. It...
Vadim Nebogatov
02:42 PM Database Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...
Eric Faulhaber wrote:
> Sorry, one more (minor) issue on om_upd20140122a: why did you change the initialization of t...
Ovidiu Maxiniuc
02:12 PM Database Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...
Sorry, one more (minor) issue on om_upd20140122a: why did you change the initialization of the @DynamicQueryHelper.wr... Eric Faulhaber
02:03 PM Database Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...
One more thought on @BufferImpl.findByRowID@: we are using @IndexHelper@ to find the primary index, but @IndexHelper@... Eric Faulhaber
01:45 PM Database Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...
Code review om_upd20140122a:
Looks good, but I also would like Constantin to review the dynamic query generation par...
Eric Faulhaber
12:10 PM Database Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...
This update adds implementation for the findXyz() dynamic methods and adds the sort clause (using primary index) for ... Ovidiu Maxiniuc
10:20 AM Database Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...
Eric Faulhaber wrote:
> * In @schema/fixups.xml@, the rule which tests for @type == prog.kw_mand@ is not correct. Th...
Vadim Nebogatov
11:35 PM Database Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...
Code review 20140121a:
Overall looks good, but I have a few questions/concerns:
* In @schema/fixups.xml@, the rul...
Eric Faulhaber
03:12 PM Database Feature #2231: LockType error processing
With the emergence of the new dynamic features in P2J some of the parameters of the methods/attributes cannot be chec... Ovidiu Maxiniuc
03:01 PM Database Feature #2231 (Closed): LockType error processing
Ovidiu Maxiniuc
12:30 PM Base Language Feature #1634: implement full native library (.so or DLL) support
This update resolves all issues from the code review and merges to the bzr 10445 level (the latest at this writing).
...
Greg Shah
11:27 AM User Interface Feature #1787: implement batch mode support
Code Review 0122a
It looks good. Get it regression tested.
Greg Shah
10:49 AM User Interface Feature #1787: implement batch mode support
The update clears the notes for previous code review and merges with the recent codebase from bzr. Eugenie Lyzenko
09:14 AM User Interface Feature #1787: implement batch mode support
> 2. I'm surprised that we don't have to link with additional libraries for pthreads on Linux or the event semaphore ... Eugenie Lyzenko
08:41 AM User Interface Feature #1787: implement batch mode support
Code Review 0121a
1. After you use throwException() in native code, please don't use @exit(-1)@. Just use @return...
Greg Shah
09:50 AM Base Language Feature #2013 (Closed): implement the SELF system handle
Greg Shah
09:21 AM Base Language Feature #2013: implement the SELF system handle
Passed conversion and runtime testing, committed to bzr rev 10445. Constantin Asofiei
09:50 AM Base Language Feature #2015 (Closed): runtime support for SELF system handle
Greg Shah
09:09 AM User Interface Feature #1811: implement the AJAX client driver
OK, these are good findings.
Please review the DOM level 3 events specification: http://www.w3.org/TR/DOM-Level-3-...
Greg Shah
07:51 AM User Interface Feature #1811: implement the AJAX client driver
I did some small changes and improvements.
Also I tested a version using native JS instead Dojo. The results are the...
Marius Gligor
04:54 AM User Interface Feature #1811: implement the AJAX client driver
I Tested your code and here are my conclusions:
1. The code does not work at all on IE (Windows) web browser.
...
Marius Gligor

01/21/2014

05:58 PM User Interface Feature #1787: implement batch mode support
This is the release candidate for review. Works for 64-bit Windows. Need to check with 32-bit, later today. Eugenie Lyzenko
04:52 PM User Interface Feature #1787: implement batch mode support
OK, it makes sense. Change all the names to be @signals*@ instead of @signal*@. Greg Shah
04:20 PM User Interface Feature #1787: implement batch mode support
Almost all is ready. One point to discuss:
We can not use @signal.h@ as local header file for our library call. It c...
Eugenie Lyzenko
08:48 AM User Interface Feature #1787: implement batch mode support
I am fine with the use of a semaphore to block waiting for the signal. As noted above, this can be implemented the s... Greg Shah
08:47 AM User Interface Feature #1787: implement batch mode support
> The folowing code works fine in standalone application but does not work in library(like libp2j):
I have not che...
Greg Shah
08:45 AM User Interface Feature #1787: implement batch mode support
Code Review 0120b
1. We don't need calls to the ClientCore.loadNativeP2JLibrary() from many different files. We o...
Greg Shah
08:15 PM User Interface Feature #1787: implement batch mode support
This update adds the Windows implementation for @SIGINT@ handler. Works in Windows 7 64-bit in virtual machine. Conti... Eugenie Lyzenko
05:08 PM Database Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...
I also attached vmn_upd20140121b.zip with tests. Vadim Nebogatov
01:09 PM Database Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...
I have attached update vmn_upd20140121a.zip corresponding to current state in note 47. I am continue implementation o... Vadim Nebogatov
04:57 PM Base Language Bug #2197: fix the error message list cleanup when NO-ERROR mode is enabled and ERROR-STATUS:ERRO...
First of all I need to understand the problem. As we can see from the tests Java program does not clear error list, b... Vadim Gindin
04:11 PM User Interface Feature #1811: implement the AJAX client driver
By the way, you re-uploaded mag_upd20140117b.zip when I think you intended to upload mag_upd20140121b.zip. Greg Shah
04:09 PM User Interface Feature #1811: implement the AJAX client driver
I have not gotten to look at your latest code yet.
However, I think you have come to the wrong conclusion in regar...
Greg Shah
02:13 PM User Interface Feature #1811: implement the AJAX client driver
Here is an improved version for keyboard management. Seems to be closed to the final solution.
Nevertheless I will d...
Marius Gligor
10:31 AM User Interface Feature #1811: implement the AJAX client driver
1. Today I did the appropriate changes inside the JS code in order to manage the keyboard events.
So far all my t...
Marius Gligor
09:39 AM User Interface Feature #1811: implement the AJAX client driver
Please document the differences between Java/Swing key processing and the Javascript equivalent. It was my understand... Greg Shah
03:02 PM User Interface Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects)
Vadim, using the test at note 15, check how the body of a down frame evolves in the cases I've mentioned at note 22. ... Constantin Asofiei
01:25 PM User Interface Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects)
It does seem that this code can only be used from an interactive UI. That is not something that the server project r... Greg Shah
01:23 PM User Interface Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects)
Constantin notes:
Considering that CURRENT-ITERATION is used in the server project only in the adm2/smart.p and th...
Greg Shah
04:07 AM User Interface Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects)
Vadim Gindin wrote:
> The first obstacle is the @CURRENT-ITERATION@ for Buffer is an integer but for @Frame/DialogBo...
Constantin Asofiei
02:33 AM User Interface Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects)
The first obstacle is the @CURRENT-ITERATION@ for Buffer is an integer but for @Frame/DialogBox@ the @CURRENT-ITERATI... Vadim Gindin
02:11 PM User Interface Feature #1801: add some frame options
> Any other widget types to test or all the widget types?
FILL-IN and BUTTON.
Greg Shah
02:03 PM User Interface Feature #1801: add some frame options
Greg Shah wrote:
> > Unless I am missing a usecase here, the code changes are in-line with your points.
>
> OK, I...
Hynek Cihlar
01:18 PM User Interface Feature #1801: add some frame options
> Unless I am missing a usecase here, the code changes are in-line with your points.
OK, I was misunderstanding th...
Greg Shah
01:46 PM User Interface Feature #2144: add minimum runtime support for methods (server)
Implement runtime support for DESELECT-ROWS() and MOVE-BEFORE-TAB-ITEM(). Please put all history entries in the pare... Greg Shah
11:29 AM Base Language Feature #1628: fix any incompatibilities or missing features of NO-ECHO support
Based on the NO-ECHO testcases created in #1629, test the P2J implementation for NO-ECHO and make any functional addi... Greg Shah
11:06 AM User Interface Feature #2016 (Closed): implement CURRENT-WINDOW, ACTIVE-WINDOW and DEFAULT-WINDOW system handles
ChUI and batch support is complete, which is sufficient for M7. GUI support will be implemented in #2229. Greg Shah
11:05 AM User Interface Feature #2018 (Closed): runtime support for CURRENT-WINDOW, ACTIVE-WINDOW and DEFAULT-WINDOW syst...
Greg Shah
11:03 AM User Interface Feature #2229 (Closed): implement CURRENT-WINDOW, ACTIVE-WINDOW and DEFAULT-WINDOW system handles...
Greg Shah
04:19 AM Base Language Feature #1645: implement web services support
Evgeny Kiselev wrote:
> Code Review 0116a:
> 1) @com.goldencode.p2j.xml.XNodeRefImpl#getOwnerDocument()@
> Does @R...
Constantin Asofiei

01/20/2014

05:28 PM User Interface Feature #1787: implement batch mode support
Finding. The folowing code works fine in standalone application but does not work in library(like libp2j):... Eugenie Lyzenko
03:44 PM User Interface Feature #1787: implement batch mode support
This is implementation candidate for Linux @SIGINT@ interceptor.
The Java part consist of the new class @SigintWai...
Eugenie Lyzenko
09:40 AM User Interface Feature #1787: implement batch mode support
I haven't gotten to the code review yet. But your approach for Windows is good. Greg Shah
05:24 PM Database Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...
I think @fieldId@ should be also added to LegacyFieldInfo along with other attributes. It will allow to find @fieldId... Vadim Nebogatov
11:04 AM Database Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...
Stanislav Lomany wrote:
> > This seems OK to me. Stas, Constantin: any concerns with this approach?
>
> Attribute...
Constantin Asofiei
10:15 AM Database Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...
> This seems OK to me. Stas, Constantin: any concerns with this approach?
No concerns. Attributes should be stored...
Stanislav Lomany
10:10 AM Database Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...
Code review om_upd20140117a:
Code seems OK to me, though given your changes to FieldReference, you should coordina...
Eric Faulhaber
10:08 AM Database Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...
Vadim, in last Thursday's email status report, you wrote:
> I also noticed that FieldReference is not proper place f...
Eric Faulhaber
09:44 AM Database Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...
Eric Faulhaber wrote:
> The reason I made this comment about the sort clause is because for every RandomAccessQuery ...
Ovidiu Maxiniuc
06:32 AM Database Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...
Ovidiu Maxiniuc wrote:
> I have attached the intermediary update that contains some my changes for this issue.
> I...
Ovidiu Maxiniuc
05:11 PM User Interface Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects)
Review for 0121a.zip (btw, updates should be named using the day of work's date, not calendaristic):
# you are missi...
Constantin Asofiei
04:45 PM User Interface Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects)
Here it is. An archive with recommended by you changes. The questions.
1) Do I correctly implenented @handle.unwrapI...
Vadim Gindin
01:54 PM User Interface Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects)
Vadim Gindin wrote:
> I tried to convert a simple procedure and it emitted correct (at first saw) java code @myFrame...
Constantin Asofiei
01:29 PM User Interface Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects)
I tried to convert a simple procedure and it emitted correct (at first saw) java code @myFrameFrame.currentIteration(... Vadim Gindin
03:14 PM User Interface Feature #2016: implement CURRENT-WINDOW, ACTIVE-WINDOW and DEFAULT-WINDOW system handles
vig_upd20140116a.zip passed regression testing. Committed as rev #10443. Vadim Gindin
02:13 PM Base Language Feature #1645: implement web services support
Code Review 0116a:
1) @com.goldencode.p2j.xml.XNodeRefImpl#getOwnerDocument()@
Does @RESTRICTED_DOCUMENT@ can affai...
Evgeny Kiselev
01:33 PM User Interface Feature #1801: add some frame options
Another argument for splitting the color from attribute I forgot to mention is the @Color@ class itself. It also keep... Hynek Cihlar
01:24 PM User Interface Feature #1801: add some frame options
Greg Shah wrote:
> Code Review 0119a
>
> 1. Why is there a dependency on @javax.jws.soap.SOAPBinding.Use@ in Cons...
Hynek Cihlar
01:21 PM User Interface Feature #1801: add some frame options
Greg Shah wrote:
> Code Review 0117a
> 1. Is the color-map.xml an example of the customer-specific (custom) color m...
Hynek Cihlar
09:08 AM User Interface Feature #1801: add some frame options
Code Review 0119a
1. Why is there a dependency on @javax.jws.soap.SOAPBinding.Use@ in ConsolePrimitives?
2. Ple...
Greg Shah
08:56 AM User Interface Feature #1801: add some frame options
Code Review 0117a
I was disconnected most of the weekend and didn't see your update until now. I'll check the 011...
Greg Shah
12:13 PM User Interface Feature #1811: implement the AJAX client driver
1. I did more investigations regarding the Google Chrome web browser.
Both Google Chrome and jetty teams works cu...
Marius Gligor
09:52 AM Base Language Feature #2013: implement the SELF system handle
Code Review 0120a
I am fine with the changes. Commit and distribute them when they pass testing.
Greg Shah
09:18 AM Base Language Feature #2013: implement the SELF system handle
This removes NullWidget and makes both SELF and FOCUS act as real handles. Manual testing looks OK, waiting for the a... Constantin Asofiei
09:19 AM Runtime Infrastructure Feature #2124 (WIP): improve/simplify the startup of server-side batch processes and appserver "a...
Constantin Asofiei
09:17 AM Base Language Feature #2015 (WIP): runtime support for SELF system handle
Constantin Asofiei

01/19/2014

05:44 PM User Interface Feature #1787: implement batch mode support
> 4. What about Windows?
In Windows we do not have @sigwait()@. So another approach might be acceptable:
1. Ins...
Eugenie Lyzenko
05:09 PM User Interface Feature #1801: add some frame options
The attached hc_upd20140119a.zip contains in-code documentation, file headers plus some cosmetic code changes. The co... Hynek Cihlar
10:36 AM Base Language Feature #1634: implement full native library (.so or DLL) support
I haven't addressed the code review items yet. This is a version with a fix for the package names which match reserv... Greg Shah

01/18/2014

05:16 PM Database Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...
Ovidiu Maxiniuc wrote:
> // has TODO regarding generating a properly converted sort clause (currently null); otherwi...
Eric Faulhaber
03:28 PM Database Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...
Eric Faulhaber wrote:
> The VAL-EXP attribute actually is used in both read and write modes in the current project. ...
Vadim Nebogatov
04:24 PM User Interface Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects)
The work to determine the rules when the auxiliary field-group is created and how the field-group rows are made visib... Constantin Asofiei
04:03 PM User Interface Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects)
I extended your test to output the content of each field group on every iteration and other useful information. Here ... Vadim Gindin
12:43 PM User Interface Feature #2016: implement CURRENT-WINDOW, ACTIVE-WINDOW and DEFAULT-WINDOW system handles
Great, you can release 0116a.zip after it passes testing. Constantin Asofiei
12:16 PM User Interface Feature #2016: implement CURRENT-WINDOW, ACTIVE-WINDOW and DEFAULT-WINDOW system handles
There is no changes since last update vig_upd20140116a.zip Vadim Gindin
11:59 AM User Interface Feature #2016: implement CURRENT-WINDOW, ACTIVE-WINDOW and DEFAULT-WINDOW system handles
OK, place the final update here for review, before releasing it. Constantin Asofiei
07:20 AM User Interface Feature #2016: implement CURRENT-WINDOW, ACTIVE-WINDOW and DEFAULT-WINDOW system handles
So I tested it again. It works. I'm going to run regression testing. Vadim Gindin
05:34 AM Base Language Feature #1634: implement full native library (.so or DLL) support
Review for @0117b.zip@:
* @collect_names.rules@
- line 406: this @<rule>downPath("KW_OUTPUT") or downPath("KW_RETUR...
Constantin Asofiei
07:26 PM User Interface Feature #1787: implement batch mode support
> But let's just call it init_ in all cases to keep the filenames shorter.
OK. This is the prepared base for appro...
Eugenie Lyzenko

01/17/2014

06:15 PM User Interface Feature #1787: implement batch mode support
iniitalize_ would be fine. But let's just call it init_ in all cases to keep the filenames shorter. Greg Shah
05:32 PM User Interface Feature #1787: implement batch mode support
Greg,
Is it OK to name the native and OS dependent init modules as @initialize.(c|h)@ and @initialize_(linux|win)....
Eugenie Lyzenko
01:17 PM User Interface Feature #1787: implement batch mode support
> Eugenie: please work toward having this work done (and regression tested and checked in) by end of day next Friday ... Eugenie Lyzenko
10:09 AM User Interface Feature #1787: implement batch mode support
> we should consider releasing an intermediate update (withtout the @KILL -INT@ fix)
Agreed.
Eugenie: please wo...
Greg Shah
09:47 AM User Interface Feature #1787: implement batch mode support
Greg, a note: if there is a chance all the @kill -INT@ behaviour will not be ready until next friday, we should consi... Constantin Asofiei
08:40 AM User Interface Feature #1787: implement batch mode support
> Another things to discuss is about the signal processing init code for all required signals to special process. We ... Greg Shah
06:58 AM User Interface Feature #1787: implement batch mode support
> Yes. The sigaction() usage needs to be executed every time the client starts (instead of only when a child process ... Eugenie Lyzenko
08:17 PM User Interface Feature #1787: implement batch mode support
We can't use the Sun signal handling support otherwise this would limit our customer's usage of alternative JVMs.
...
Greg Shah
06:13 PM Database Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...
The VAL-EXP attribute actually is used in both read and write modes in the current project. In the function where it ... Eric Faulhaber
05:49 PM Database Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...
LE: just took a look at the implementation and the attribute name is hard-coded, not determined from annotations - so... Constantin Asofiei
05:44 PM Database Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...
Eric Faulhaber wrote:
> Vadim Nebogatov wrote:
> > Two cosmetics found in @HEIGHT-CHARS@ implementation: @HEIGHT-CH...
Constantin Asofiei
05:42 PM Database Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...
Vadim Nebogatov wrote:
> Schema conversion step starts from *.dict file received as result of parsing. Am I correct?...
Constantin Asofiei
05:40 PM Database Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...
Vadim Nebogatov wrote:
> Two cosmetics found in @HEIGHT-CHARS@ implementation: @HEIGHT-CHARS@ instead of @HEIGHT@ an...
Eric Faulhaber
05:38 PM Database Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...
Vadim Nebogatov wrote:
> @POSITION attribute@
> From tests, it is just field order (fieldId) plus 1. It is interest...
Eric Faulhaber
05:24 PM Database Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...
Constantin Asofiei wrote:
> Ah, I get it know, you want to get the legacy 4GL expression. The best way is to save it ...
Vadim Nebogatov
05:17 PM Database Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...
Ah, I get it know, you want to get the legacy 4GL expression. The best way is to save it in an annotation at the fiel... Constantin Asofiei
05:08 PM Database Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...
No special test is required: it is from p2j_test.dict for p2j_test.book.cost field. Vadim Nebogatov
05:04 PM Database Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...
Can you post a small testcase showing how this behaves? If it works how I think it works (i.e. @VALIDATE-EXPRESSION@ ... Constantin Asofiei
04:44 PM Database Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...
@VALIDATE-EXPRESSION attribute@
I missed annotation of this attribute. In *.dict it looks like ...
Vadim Nebogatov
03:06 PM Database Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...
Two cosmetics found in @HEIGHT-CHARS@ implementation: @HEIGHT-CHARS@ instead of @HEIGHT@ and @setable@ with one @t@ ... Vadim Nebogatov
01:46 PM Database Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...
@POSITION attribute@... Vadim Nebogatov
01:23 PM Database Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...
I also added some more optional annotations like
/** Data member */
@LegacyField( name = "fc" , format = "...
Vadim Nebogatov
11:27 AM Database Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...
I have attached the intermediary update that contains some my changes for this issue.
I am putting this update to c...
Ovidiu Maxiniuc
10:46 AM Database Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...
Agreed. Consider whether runtime regression testing is necessary for this update. If its impact is only on new runtim... Eric Faulhaber
10:39 AM Database Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...
Ovidiu, please check if you can extract the code which adds the new annotations into a separate update; I think is wo... Constantin Asofiei
10:10 AM Database Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...
Some more details on implementation of @bufferField(int)@:
I have done some researches that clarified me that the ...
Ovidiu Maxiniuc
09:30 AM Database Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...
Eric Faulhaber wrote:
> Sorry, this was my comment and I see how it is misleading. It was not based on testing, but ...
Constantin Asofiei
09:23 AM Database Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...
*Ovidiu* working on @BufferImpl.java@
// has TODO regarding generating a properly converted sort clause (currently...
Ovidiu Maxiniuc
08:15 AM Database Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...
Eric Faulhaber wrote:
> Vadim, to me it doesn't look like @format@ and @changeFormat@ are actually in use. I don't s...
Vadim Nebogatov
08:01 AM Database Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...
The same for the LITERAL-QUESTION attribute, I have implemented attribute support without proper analysys according n... Vadim Nebogatov
07:52 AM Database Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...
Eric Faulhaber wrote:
> AFAIK, RowObjectValidate is just an ADM SmartObjects procedure that we convert. Does this ha...
Vadim Nebogatov
07:39 AM Database Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...
Constantin Asofiei wrote:
> Vadim Nebogatov wrote:
> > public void setDataType(String dataType) [LE: cannot se...
Eric Faulhaber
07:35 AM Database Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...
Constantin Asofiei wrote:
> > // not sure why this is implemented for FieldReference; DELETE cannot be called on a
...
Eric Faulhaber
07:23 AM Database Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...
Vadim Nebogatov wrote:
> public void setDataType(String dataType) [LE: cannot set data type for a buffer field]...
Constantin Asofiei
07:19 AM Database Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...
Vadim, to me it doesn't look like @format@ and @changeFormat@ are actually in use. I don't see any rules to generate ... Eric Faulhaber
07:09 AM Database Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...
h3. Vadim, current status (implemented methods are marked in bold)
h3. BufferImpl
*public handle bufferField(chara...
Vadim Nebogatov
06:09 PM Base Language Feature #1634: implement full native library (.so or DLL) support
Updated version with conversion fixes and some added functionality to make the testcases work (hex-decode and hex-enc... Greg Shah
02:40 PM Base Language Feature #1634: implement full native library (.so or DLL) support
> The only question is what about ffi.h header?
On Ubuntu, install this package:
sudo apt-get install libffi-de...
Greg Shah
02:10 PM Base Language Feature #1634: implement full native library (.so or DLL) support
> Eugenie: please review the filesys.c change as well as the other native code changes.
I'm OK with changes. The o...
Eugenie Lyzenko
10:41 AM Base Language Feature #1634: implement full native library (.so or DLL) support
Complete first implementation. I am about to start testing, so this is likely to change. But it has all features ful... Greg Shah
05:46 PM User Interface Feature #2016: implement CURRENT-WINDOW, ACTIVE-WINDOW and DEFAULT-WINDOW system handles
As Vadim N. noted on #1655 note 63: the problem we have with @WIDTH@ and @WIDTH-CHARS@ can be found with @HEIGHT@ and... Constantin Asofiei
03:21 PM User Interface Feature #2016: implement CURRENT-WINDOW, ACTIVE-WINDOW and DEFAULT-WINDOW system handles
Sorry, my bad. The test was missing a no-error clause for the last @this-procedure:current-window = h.@ assignment; s... Constantin Asofiei
02:24 PM User Interface Feature #2016: implement CURRENT-WINDOW, ACTIVE-WINDOW and DEFAULT-WINDOW system handles
Constantin,
I've committed tests I have for this task. I already have similar tests. Could you comment, why do you...
Vadim Gindin
04:06 AM User Interface Feature #2016: implement CURRENT-WINDOW, ACTIVE-WINDOW and DEFAULT-WINDOW system handles
Vadim Gindin wrote:
> Yes I did test it but my tests did not allow me to find this issue. It probably need to test i...
Constantin Asofiei
04:31 PM Database Feature #2117 (Closed): add runtime support for _lock metadata table
See #2115, note 18. Eric Faulhaber
04:31 PM Database Feature #2115 (Closed): add runtime support for _file and _field metadata tables
This update fixes metadata foreign key detection, completes basic lock metadata support (#2117), removes underscore f... Eric Faulhaber
03:25 PM User Interface Feature #1801: add some frame options
I am attaching changes with the protermcap color support for an early review. The code was functionally tested and is... Hynek Cihlar
02:08 PM User Interface Feature #1811: implement the AJAX client driver
Code Review 0116b
The code looks good. Does ChuiWebSimulator really need to call super.quit()?
Greg Shah
01:29 PM User Interface Feature #1811: implement the AJAX client driver
System.exit(code) works fine.
Marius Gligor
01:07 PM User Interface Feature #1811: implement the AJAX client driver
Code Review 0117a
The changes look fine except for the END-ERROR approach already discussed above.
The use of S...
Greg Shah
12:58 PM User Interface Feature #1811: implement the AJAX client driver
I checked in the TerminalMenu class and we have this code for the Exit menu item:... Greg Shah
12:16 PM User Interface Feature #1811: implement the AJAX client driver
Marius Gligor wrote:
> 1. I found another way to terminate the client process on connection close. Just simple put an...
Constantin Asofiei
12:10 PM User Interface Feature #1811: implement the AJAX client driver
1. I found another way to terminate the client process on connection close. Just simple put an END-ERROR key (code 30... Marius Gligor
08:34 PM User Interface Feature #1811: implement the AJAX client driver
> Using monospaced font results in an ugly screen so in JS I changed the monospaced with monospace font (see monospac... Greg Shah
08:24 PM User Interface Feature #1811: implement the AJAX client driver
Code Review 0116a
Generally, I'm OK with the code. My only concern: the use of @Runtime.getRuntime().halt(statusC...
Greg Shah

01/16/2014

06:59 PM User Interface Feature #2016: implement CURRENT-WINDOW, ACTIVE-WINDOW and DEFAULT-WINDOW system handles
Constantin Asofiei wrote:
> * @LogicalTerminal.setCurrentWindow(handle h)@ - have you tested the assignment using th...
Vadim Gindin
03:37 AM User Interface Feature #2016: implement CURRENT-WINDOW, ACTIVE-WINDOW and DEFAULT-WINDOW system handles
* @LogicalTerminal.setCurrentWindow(handle h)@ - have you tested the assignment using the NO-ERROR clause too? Becaus... Constantin Asofiei
06:52 PM User Interface Feature #1787: implement batch mode support
> Before you tested, did you fix this issue I previously mentioned?
>
> > The sigaction() calls that used to be in...
Eugenie Lyzenko
06:24 PM User Interface Feature #1787: implement batch mode support
Before you tested, did you fix this issue I previously mentioned?
> The sigaction() calls that used to be in the i...
Greg Shah
06:14 PM User Interface Feature #1787: implement batch mode support
> OK, that means we have a problem to fix.
>
> Try this: temporarily re-enable the KeyReader thread and re-test. D...
Eugenie Lyzenko
10:41 AM User Interface Feature #1787: implement batch mode support
> I have tested the our P2J client implementation for UI console mode. And kill behaves not the same as manual CTRL-C... Greg Shah
10:36 AM User Interface Feature #1787: implement batch mode support
> I'm not sure I understand what you've tested - your test was in P2J or 4GL?
OK. I have tested the our P2J client...
Eugenie Lyzenko
10:25 AM User Interface Feature #1787: implement batch mode support
Eugenie Lyzenko wrote:
> I have tested the simple app with one fill-in in UI mode. The result is the same - kill -IN...
Constantin Asofiei
09:10 AM User Interface Feature #1787: implement batch mode support
The drop fixes the today notes. Eugenie Lyzenko
09:05 AM User Interface Feature #1787: implement batch mode support
> Eugenie, two notes:
>
> check how kill -INT is treated for normal start in 4GL (non-batch). Double-check this be...
Eugenie Lyzenko
06:37 AM User Interface Feature #1787: implement batch mode support
Code Review 0115b
1. Please put this comment in BatchDriver.init() ...
Greg Shah
04:01 AM User Interface Feature #1787: implement batch mode support
About the update:
* the appserver connection is working properly.
* @ThinClient.isBatchInBackground@ - there is a...
Constantin Asofiei
03:18 AM User Interface Feature #1787: implement batch mode support
Eugenie, two notes:
# check how @kill -INT@ is treated for normal start in 4GL (non-batch). Double-check this behavi...
Constantin Asofiei
06:23 PM Database Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...
AFAIK, RowObjectValidate is just an ADM SmartObjects procedure that we convert. Does this have any bearing on the imp... Eric Faulhaber
04:59 PM Database Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...
@MANDATORY attribute@... Vadim Nebogatov
06:54 AM Database Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...
> Do P2J already has such option for different quoted character values processing and runtime options support?
No.
...
Greg Shah
04:48 AM Database Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...
@LITERAL-QUESTION attribute@
Needed to support -literalquestion startup parameter and special processing for quot...
Vadim Nebogatov
05:48 PM User Interface Feature #1801: add some frame options
I believe this was intended as the mechanism by which the server-side code would configure custom colors and have the... Greg Shah
05:42 PM User Interface Feature #1801: add some frame options
In the original code, @ColorSpec@ contains the method @addMapping(String, Color)@ allowing dynamically add color mapp... Hynek Cihlar
03:56 PM User Interface Feature #1811: implement the AJAX client driver
On Chrome seems to be a bug when secured connection (WSS) with self signed certificate is used.
https://code.google....
Marius Gligor
01:36 PM User Interface Feature #1811: implement the AJAX client driver
1. Today I converted the keys.p application and I implemented the keyboard codes conversion for p4g.
I observed that...
Marius Gligor
03:12 PM Base Language Feature #1634: implement full native library (.so or DLL) support
Greg Shah wrote:
> Constantin: What is the easiest way to determine if a given BDT[] instance is an indeterminate le...
Constantin Asofiei
02:33 PM Base Language Feature #1634: implement full native library (.so or DLL) support
Constantin: What is the easiest way to determine if a given BDT[] instance is an indeterminate length array? I have ... Greg Shah
03:02 PM User Interface Feature #2037: runtime support for frame options
The testcases can be found here: #2227 Eugenie Lyzenko
02:05 PM Database Feature #1652 (WIP): add conversion and runtime support for dynamically prepared temp-tables
I am temporarily re-opening this task to track the final implementations of TODOs in DynamicTablesHelper and TempTabl... Eric Faulhaber
10:50 AM Base Language Bug #1969 (Closed): buffer names in get-signature
Greg Shah
10:36 AM Base Language Bug #1969: buffer names in get-signature
Committed to bzr revision 10440. Constantin Asofiei
10:06 AM Base Language Bug #1969: buffer names in get-signature
> I think you missed something in the SchemaDictionary change:
You're right, I missed that. Sorry.
I'm fine wi...
Greg Shah
10:03 AM Base Language Bug #1969: buffer names in get-signature
Greg Shah wrote:
> 1. The SchemaDictionary lowercases the name before it saves off the legacy_name annotation, but s...
Constantin Asofiei
09:25 AM Base Language Bug #1969: buffer names in get-signature
Code Review 0115a
1. The SchemaDictionary lowercases the name before it saves off the legacy_name annotation, but ...
Greg Shah
08:43 AM Base Language Bug #1969 (Review): buffer names in get-signature
PS: conversion testing has passed, runtime testing is not needed. Constantin Asofiei
08:43 AM Base Language Bug #1969 (WIP): buffer names in get-signature
Attached update fixes the BUFFER and TABLE parameter names reported by GET-SIGNATURE.
The legacy, case-sensitive n...
Constantin Asofiei
07:21 AM Database Feature #2116: add runtime support for _user metadata table
Indeed, this is true (values are @?@) for the rest of fields of _User exports except for @_Userid@/@_Password@ and @_... Ovidiu Maxiniuc
07:19 AM Base Language Feature #1645: implement web services support
Committed to bzr revision 10439. Constantin Asofiei
06:42 AM Base Language Feature #1645: implement web services support
Code Review 0116a
I am fine with the changes. Go ahead and check it in.
Evgeny: I still want you to review t...
Greg Shah
03:27 AM Base Language Feature #1645: implement web services support
and the update... Constantin Asofiei
03:26 AM Base Language Feature #1645: implement web services support
main part of runtime testing has passed. need to double check the CTRL-C part.
Attached version is merged with rev...
Constantin Asofiei
06:55 AM Base Language Feature #1641: implement SAX XML support
Please check in your SAX testcases. Greg Shah
07:39 PM Base Language Feature #1641: implement SAX XML support
Committed to bzr revision 10438. Evgeny Kiselev

01/15/2014

05:47 PM User Interface Feature #2016: implement CURRENT-WINDOW, ACTIVE-WINDOW and DEFAULT-WINDOW system handles
Here is the update with batch-mode support added. Vadim Gindin
03:40 PM User Interface Feature #2016: implement CURRENT-WINDOW, ACTIVE-WINDOW and DEFAULT-WINDOW system handles
> We can choose to set the name displayed in the error message at LegacyAttribute annotation and change the CAN-QUER... Greg Shah
02:40 PM User Interface Feature #2016: implement CURRENT-WINDOW, ACTIVE-WINDOW and DEFAULT-WINDOW system handles
Greg Shah wrote:
> Is there ever any way the 4GL can report WIDTH-CHARS as the attribute name? If not, then let's j...
Constantin Asofiei
08:28 AM User Interface Feature #2016: implement CURRENT-WINDOW, ACTIVE-WINDOW and DEFAULT-WINDOW system handles
> Greg: we can add a low-priority task for this problem, as this looks like an exotic case.
OK.
>> 2) Attribute...
Greg Shah
02:10 AM User Interface Feature #2016: implement CURRENT-WINDOW, ACTIVE-WINDOW and DEFAULT-WINDOW system handles
I understand the problem. Unfortunately, I think this will need conversion changes, to let the handle.unwrap call kno... Constantin Asofiei
05:08 PM User Interface Feature #1787: implement batch mode support
OK. I'll need to dig more to clarify the STOP condition generation.
For now I've uploaded the changes clearing all...
Eugenie Lyzenko
04:41 PM User Interface Feature #1787: implement batch mode support
I'm not sure, but I do wonder if it has something to do with our signal handling approach.
The sigaction() calls t...
Greg Shah
04:21 PM User Interface Feature #1787: implement batch mode support
> Yes, except since there is no user input in these modes, the way to pass a @CTRL-C@ to the process is by using @kil... Eugenie Lyzenko
01:58 PM User Interface Feature #1787: implement batch mode support
> OK. I'm leaving for background mode:
>
> Batch processing will be performed using:
> OpenEdge Release ...
>
>...
Greg Shah
01:35 PM User Interface Feature #1787: implement batch mode support
> 1. Copyright ranges need to be updated to 2014 for all files.
Done.
> 2. We DEFINITELY CANNOT include that Pr...
Eugenie Lyzenko
01:16 PM User Interface Feature #1787: implement batch mode support
Code Review 0115a
1. Copyright ranges need to be updated to 2014 for all files.
2. We DEFINITELY CANNOT include...
Greg Shah
01:07 PM User Interface Feature #1787: implement batch mode support
Eugenie Lyzenko wrote:
> Eugenie: @BatchDriver.init@ I don't think it should output the progress logo; it is enough ...
Constantin Asofiei
12:59 PM User Interface Feature #1787: implement batch mode support
Eugenie: @BatchDriver.init@ I don't think it should output the progress logo; it is enough to output the messages aft... Eugenie Lyzenko
12:56 PM User Interface Feature #1787: implement batch mode support
Eugenie: @BatchDriver.init@ I don't think it should output the progress logo; it is enough to output the messages aft... Constantin Asofiei
12:40 PM User Interface Feature #1787: implement batch mode support
The drop adds foreground/background differences introduced via @client.sh@ script @"client:driver:background=true|fal... Eugenie Lyzenko
02:21 AM User Interface Feature #1787: implement batch mode support
The good news is that I think @pro -b &@ behaves the same as @pro -b@ (@kill -INT@ will raise a STOP condition in the... Constantin Asofiei
02:25 PM Database Feature #2116: add runtime support for _user metadata table
I also should note that the data export of the _User table has unknown value for the _User_number field in all record... Eric Faulhaber
02:22 PM Database Feature #2116: add runtime support for _user metadata table
Ovidiu, when you were working this task, did you create any test cases that explored the contents of the _User record... Eric Faulhaber
01:50 PM User Interface Feature #1811: implement the AJAX client driver
Code Review 0115a
I am generally fine with the changes. Minor feedback:
1. Some imports need to be shifted to ...
Greg Shah
01:35 PM User Interface Feature #1811: implement the AJAX client driver
This feature isn't yet implemented but will be. We have a notification on web sockets when the connection is closed o... Marius Gligor
01:13 PM User Interface Feature #1811: implement the AJAX client driver
Marius: what happens when the browser is closed? Does the P2J client process get shut down properly? Constantin Asofiei
12:32 PM User Interface Feature #1811: implement the AJAX client driver
Today I started to implements the keyboard events protocol.
So far I tested:
-printable characters OK
-CTRL-C OK...
Marius Gligor
11:33 AM User Interface Feature #1811: implement the AJAX client driver
By the way, our current ChUI client (swing and ncurses) does not support mouse events. You don't need to add support... Greg Shah
11:21 AM User Interface Feature #1811: implement the AJAX client driver
Very cool stuff. Please use testcases/uast/keys.p to test out your key processing. Compare the results to running t... Greg Shah
10:54 AM User Interface Feature #1811: implement the AJAX client driver
OK. Now it works from both command line and from IDE.
I attached some well known screens this time taken from my web...
Marius Gligor
10:03 AM User Interface Feature #1811: implement the AJAX client driver
The swing chui client can be started with no problem from Eclipse (and I guess from other IDE too); just set it up li... Constantin Asofiei
09:58 AM User Interface Feature #1811: implement the AJAX client driver
OK Thanks. Now the SWING driver works fine.
I have configurations on my IDE to start the server and the client which...
Marius Gligor
09:22 AM User Interface Feature #1811: implement the AJAX client driver
The problem is you have two distinct P2J builds - one for the server, and one for the client. And the serialVersionUI... Constantin Asofiei
09:17 AM User Interface Feature #1811: implement the AJAX client driver
Now seems to be a serialization problem.
WARNING: {Reader} failure in reading loop
java.io.InvalidClassException:...
Marius Gligor
09:06 AM User Interface Feature #1811: implement the AJAX client driver
Take the @testcases/simple/server/server.sh@ from the repository. The problem is caused by the fact that the server i... Constantin Asofiei
09:03 AM User Interface Feature #1811: implement the AJAX client driver
I did a new conversion for Ask.p and Primes.p
Unfortunately when I want to start the primes.p on my emulator the se...
Marius Gligor
08:34 AM User Interface Feature #1811: implement the AJAX client driver
> I've started to implements the protocol for keyboard management.
> I have good news! So far It's works fine see th...
Greg Shah
08:32 AM User Interface Feature #1811: implement the AJAX client driver
Please note that you should always have a symbolic link in your project home (testcases/uast/) to the p2j/ directory ... Greg Shah
08:08 AM User Interface Feature #1811: implement the AJAX client driver
Thanks I fixed the problem.
I just copied the rules directory from p2j on testcases/uast/p2j/rules and the conversi...
Marius Gligor
07:51 AM User Interface Feature #1811: implement the AJAX client driver
Then I think there is some other p2j/ installation on the path; and I can't be of much help with that. Why I say thi... Constantin Asofiei
07:41 AM User Interface Feature #1811: implement the AJAX client driver
My p2j project is updated and the build all is OK, no errors. However the conversion does not work.
The rules/annota...
Marius Gligor
07:20 AM User Interface Feature #1811: implement the AJAX client driver
Make sure you are using the latest revision (and P2J is built). From the log, you have an outdated @rules/annotation... Constantin Asofiei
07:15 AM User Interface Feature #1811: implement the AJAX client driver
I attached the build log. Marius Gligor
07:13 AM User Interface Feature #1811: implement the AJAX client driver
Marius Gligor wrote:
> According to conversion handbook:
>
> export P2J=/home/mag/p2j
> export CLASSPATH=$P2J/bu...
Marius Gligor
07:09 AM User Interface Feature #1811: implement the AJAX client driver
And what error do you get? Constantin Asofiei
07:06 AM User Interface Feature #1811: implement the AJAX client driver
According to conversion handbook:
export P2J=/mag/p2j/to/p2j
export CLASSPATH=$P2J/build/lib/p2j.jar
java com....
Marius Gligor
07:00 AM User Interface Feature #1811: implement the AJAX client driver
Marius Gligor wrote:
> So I tried to do a new conversion but unfortunately without success.
What command do you use...
Constantin Asofiei
06:57 AM User Interface Feature #1811: implement the AJAX client driver
I've started to implements the protocol for keyboard management.
I have good news! So far It's works fine see the at...
Marius Gligor
01:53 AM Base Language Feature #1641: implement SAX XML support
Review for 0113a.zip: the update is OK, but please make the @XCommonImpl.isValid@ field protected instead of package-... Constantin Asofiei
08:40 PM Base Language Feature #1641: implement SAX XML support
Constantin Asofiei wrote:
> Review for 0112a.zip:
> * all files are missing history entries. When you add history e...
Evgeny Kiselev

01/14/2014

06:49 PM User Interface Feature #1787: implement batch mode support
> My concern with your suggested approach is that we would have to find every place that is different when using the ... Eugenie Lyzenko
06:11 PM User Interface Feature #1787: implement batch mode support
> It is important that you make sure you re-run all your tests using the @pro -b@ since our current code may have som... Eugenie Lyzenko
06:03 PM User Interface Feature #1787: implement batch mode support
It is important that you make sure you re-run all your tests using the @pro -b@ since our current code may have some ... Greg Shah
06:02 PM User Interface Feature #1787: implement batch mode support
> Do we need to support both foreground and background mode?
Yes.
> Because the & option is used with -b option...
Greg Shah
12:09 PM User Interface Feature #1787: implement batch mode support
> The key question: can we duplicate this behavior using the & directly from the shell?
May be this is not require...
Eugenie Lyzenko
09:28 AM User Interface Feature #1787: implement batch mode support
>>> The correct command for batch mode in Linux is bpro, not pro
>>>
>> Is this officially documented somewhere? Be...
Greg Shah
09:13 AM User Interface Feature #1787: implement batch mode support
Eugenie Lyzenko wrote:
> > There is a memory leak in the TypeAhead.taBuf list...
>
> Explain what do you mean tellin...
Constantin Asofiei
09:04 AM User Interface Feature #1787: implement batch mode support
> There is a memory leak in the TypeAhead.taBuf list...
Explain what do you mean telling "memory leak". Another wo...
Eugenie Lyzenko
08:57 AM User Interface Feature #1787: implement batch mode support
> > The correct command for batch mode in Linux is @bpro@, not @pro@
>
> Is this officially documented somewhere? ...
Eugenie Lyzenko
08:54 AM User Interface Feature #1787: implement batch mode support
Greg Shah wrote:
> However, I wonder what the 4GL does when you "manually" send it the CTRL-C via @kill -INT <pid>@?...
Constantin Asofiei
08:31 AM User Interface Feature #1787: implement batch mode support
> if ran under linux with pro -b -p a.p will output:
> ...
Eugenie Lyzenko
08:27 AM User Interface Feature #1787: implement batch mode support
> if batch mode is enabled, then the KeyReader thread should not be started at all (as blocking for user input is imp... Greg Shah
06:05 AM User Interface Feature #1787: implement batch mode support
There is a memory leak in the @TypeAhead.taBuf@ list, when batch mode is activated. On linux, when the @BatchDriver.r... Constantin Asofiei
04:20 PM User Interface Feature #2016: implement CURRENT-WINDOW, ACTIVE-WINDOW and DEFAULT-WINDOW system handles
You're right.. Now I'm trying to implement it (batch-mode support) and I'm getting following problem. CURRENT-WINDOW ... Vadim Gindin
05:44 AM User Interface Feature #2016: implement CURRENT-WINDOW, ACTIVE-WINDOW and DEFAULT-WINDOW system handles
Vadim, on note 24 you mentioned that "window is unknown:" in batch mode. You forgot to implement this case in @LT.cur... Constantin Asofiei
12:33 PM User Interface Feature #1811: implement the AJAX client driver
The code changes in 0114a look good. There is some missing javadoc, but otherwise things seem pretty much on target.... Greg Shah
12:07 PM User Interface Feature #1811: implement the AJAX client driver
Today I started to implements the WebSockets protocol for screen management (server -> browser JS)
Please look at th...
Marius Gligor
11:13 AM User Interface Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects)
> AFAIK, P2J uses n widget rows for displaying the body of a n-down frame;
Correct.
> assuming that 4GL indeed ...
Greg Shah
11:02 AM User Interface Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects)
About the tests at note 10: your conclusions are wrong. If you look at the repeating IDs, you will see that there are... Constantin Asofiei
08:58 AM User Interface Feature #1782: implement LAST-EVENT system handle and associated attributes
Attached update contains the correct changes applied to rev 10436 (compared to 10434). Constantin Asofiei
03:00 AM User Interface Feature #1782: implement LAST-EVENT system handle and associated attributes
Error fix. Committed to bzr, rev #10436. Vadim Gindin
07:53 AM Database Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...
Status update (related to BufferImpl)
* @findFirst@, @findLast@, @findUnique@ - implemented, testing in progress, ...
Ovidiu Maxiniuc

01/13/2014

06:27 PM Database Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...
I'm pretty sure the double quotes around the numeric value represent optional syntax. It is the value itself that is ... Eric Faulhaber
06:20 PM Database Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...
Eric Faulhaber wrote:
> > But I did not find so far methods allowing creation BaseDataType instance from a pair of s...
Vadim Nebogatov
05:45 PM Database Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...
Eric Faulhaber wrote:
> Vadim, in the version of @BufferImpl@ you just checked in (rev 10433), you removed the origi...
Vadim Nebogatov
05:42 PM Database Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...
Vadim, in the version of @BufferImpl@ you just checked in (rev 10433), you removed the original copyright year of 201... Eric Faulhaber
05:38 PM Database Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...
> But I did not find so far methods allowing creation BaseDataType instance from a pair of strings initialValue and i... Eric Faulhaber
04:49 PM Database Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...
I think for INITIAL attribute we need two string annotations: initialValue and initialType, assigning them from text/... Vadim Nebogatov
01:05 PM Database Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...
Yes, agreed. I made internal methods returning LegacyFieldInfo, bit public methods are the same. Vadim Nebogatov
10:13 PM Database Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...
While I do see some value in not repeating the pattern... Eric Faulhaber
05:13 PM User Interface Feature #2226: finish LAST-EVENT support
Please put all discussions into the task history for #1782 so that future readers don't have to look in 2 places for ... Greg Shah
05:10 PM User Interface Feature #2226: finish LAST-EVENT support
Basic behavior is working, but there are a number of special cases that don't yet work exactly like the 4GL. Please ... Greg Shah
05:08 PM User Interface Feature #2226 (Closed): finish LAST-EVENT support
Greg Shah
05:12 PM User Interface Feature #1782 (Closed): implement LAST-EVENT system handle and associated attributes
Greg Shah
04:54 PM User Interface Feature #1782: implement LAST-EVENT system handle and associated attributes
Here it is. Implementation of basic behavior Vadim Gindin
04:53 PM User Interface Feature #1782: implement LAST-EVENT system handle and associated attributes
Please post the final update zip here and we will close the task. Greg Shah
04:33 PM User Interface Feature #1782: implement LAST-EVENT system handle and associated attributes
committed to bzr rev #10435 Vadim Gindin
03:17 PM User Interface Feature #1782: implement LAST-EVENT system handle and associated attributes
Ok, then stay with option 1 (constants) but make sure to document this in the javadoc for the fields (i.e. they are p... Constantin Asofiei
03:06 PM User Interface Feature #1782: implement LAST-EVENT system handle and associated attributes
Constantin Asofiei wrote:
> ..
> Unless the DE_LOWEST and DE_HIGHEST are some codes from 4GL, is there a way to def...
Vadim Gindin
03:13 AM User Interface Feature #1782: implement LAST-EVENT system handle and associated attributes
Vadim Gindin wrote:
> Constantin Asofiei wrote:
> ..
> > * Keyboard - as for note 81 - why can't the initializatio...
Constantin Asofiei
05:11 PM User Interface Feature #2020 (Closed): runtime support for LAST-EVENT system handle and associated attributes
Greg Shah
05:04 PM Base Language Bug #2197: fix the error message list cleanup when NO-ERROR mode is enabled and ERROR-STATUS:ERRO...
Start by writing cases to investigate this behavior, then propose a solution. Greg Shah
04:59 PM User Interface Feature #1811: implement the AJAX client driver
It looks good (both the code in 0113a and the proposed protocol). Greg Shah
12:33 PM User Interface Feature #1811: implement the AJAX client driver
For a better view. Marius Gligor
12:30 PM User Interface Feature #1811: implement the AJAX client driver
The following classes are used to emulate a terminal:
ChuiWebDriver extends (ChuiScreenDriver implements ScreenDri...
Marius Gligor
12:28 PM User Interface Feature #1811: implement the AJAX client driver
I did a lot of improvements inside the JS code:
- I'm using JS sub modules stored on separate script files.
- Scree...
Marius Gligor
10:33 AM User Interface Feature #1811: implement the AJAX client driver
Code Review 0110a
I am fine with the general approach and how the code is progressing.
I only have 3 comments:
...
Greg Shah
08:26 AM Base Language Feature #1608: implement full appserver support (from 4GL clients only)
0110e.zip was committed to bzr rev 10434. Constantin Asofiei
08:23 AM Base Language Feature #1608: implement full appserver support (from 4GL clients only)
Check it in and distribute. Greg Shah
02:42 AM Base Language Feature #1608: implement full appserver support (from 4GL clients only)
0110e.zip has passed runtime testing. Constantin Asofiei
02:59 AM Base Language Feature #1641: implement SAX XML support
Review for 0112a.zip:
* all files are missing history entries. When you add history entries, don't forget to update ...
Constantin Asofiei
08:59 PM Base Language Feature #1641: implement SAX XML support
added correct @DELETE@ operation for DOM/SAX. Evgeny Kiselev

01/12/2014

05:55 PM Database Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...
It seems TableMapper needs refactoring if we plan to add some new annotations to LegacyField like now I added format(... Vadim Nebogatov
04:42 PM Database Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...
Vadim wrote (in email):
> The question: 'initial' was added in *.p2o as Ast node in contrast to other attributes adde...
Eric Faulhaber

01/11/2014

05:53 AM Database Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...
The following also need implementation in BufferImpl:... Vadim Nebogatov
07:10 PM Database Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...
Implemented bufferField(character) in BufferImpl. Attached update has not been regression tested, because it affects ... Vadim Nebogatov

01/10/2014

06:30 PM Database Bug #1914: database conversion requires Internet connectivity
Conversion on Windows virtual machine mode without networking causes the error:... Eugenie Lyzenko
04:29 PM User Interface Feature #1782: implement LAST-EVENT system handle and associated attributes
Constantin Asofiei wrote:
..
> * Keyboard - as for note 81 - why can't the initialization of DE_LOWEST and DE_HIGHEST...
Vadim Gindin
10:03 AM User Interface Feature #1782: implement LAST-EVENT system handle and associated attributes
Vadim, I'm fine with the logic. All comments are about cleanup and javadoc/comment improvement:
* ClientState - you ...
Constantin Asofiei
01:15 PM User Interface Feature #1811: implement the AJAX client driver
I designed minimal JS modules for Screen, Screen cursor, Message Beep and WebSocket communication management.
The at...
Marius Gligor
01:05 PM Database Feature #2024 (Closed): implement runtime support for database triggers
Base trigger support is finished. Several bugs have been found and are being worked as separate tasks. Eric Faulhaber
10:32 AM Base Language Feature #1645: implement web services support
Greg, I'm fine with how the runtime works with my testing. I'll put this through regression testing once I'm done wit... Constantin Asofiei
09:38 AM Base Language Feature #1645: implement web services support
OK, finish your own testing AND take into account any feedback from Evgeny from his code review of WebServiceHelper.i... Greg Shah
09:13 AM Base Language Feature #1645: implement web services support
Added the TODO.
Evgeny: when you find some time, please take a look into WebServiceHelper.invoke, the core code fo...
Constantin Asofiei
08:47 AM Base Language Feature #1645: implement web services support
I have no problem deferring this work. Please add comments to the javadoc to explain that the work is a TODO and the... Greg Shah
08:45 AM Base Language Feature #1645: implement web services support
Greg, all of these are not used by the server code. Also, the gain vs cost of implementing them I don't think is wort... Constantin Asofiei
08:38 AM Base Language Feature #1645: implement web services support
Everything looks good. My only question is related to this (and the related commented-out code):... Greg Shah
07:41 AM Base Language Feature #1645: implement web services support
Greg Shah wrote:
> 2. How safe is the use of IllegalArgumentException in SOAPHeaderImpl.getHeaderNode()/setHeaderNod...
Constantin Asofiei
10:30 AM Base Language Feature #1608: implement full appserver support (from 4GL clients only)
Attached contains 0109c.zip (with a change in LogicalTerminal too, as TransactionManager no longer needs to be cached... Constantin Asofiei
09:35 AM Runtime Infrastructure Feature #2124: improve/simplify the startup of server-side batch processes and appserver "agent" ...
I have long been thinking on the details of this work. I will document a range of ideas here.
The ongoing effort ...
Greg Shah
09:00 AM Base Language Feature #2225: implement ssl and async realted connection options for web services
The @-maxConnections@, @-connectionLifetime@, @-nosessionreuse@ and @-nohostverify@ options are not yet implemented b... Constantin Asofiei
08:57 AM Base Language Feature #2225 (New): implement ssl and async realted connection options for web services
Constantin Asofiei
04:31 AM User Interface Feature #2016: implement CURRENT-WINDOW, ACTIVE-WINDOW and DEFAULT-WINDOW system handles
Go ahead and get it tested. Before committing, fix the tab characters in LT.setProcCurrentWindow:8627. Constantin Asofiei

01/09/2014

06:11 PM User Interface Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects)
Lost new results picture. Vadim Gindin
06:09 PM User Interface Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects)
> I thought that you meant 1-DOWN by the phrase "non-down frame".
Yes, you have it right.
Greg Shah
06:06 PM User Interface Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects)
Sorry, I made a simple logical error in my test and this led us to confusion. My error was in a rows number in the ou... Vadim Gindin
05:14 PM User Interface Feature #2016: implement CURRENT-WINDOW, ACTIVE-WINDOW and DEFAULT-WINDOW system handles
Next update with last changes. Vadim Gindin
03:54 AM User Interface Feature #2016: implement CURRENT-WINDOW, ACTIVE-WINDOW and DEFAULT-WINDOW system handles
Review for 0108a.zip:
* In files where the history entry is from 2014, update the copyright years in the file's head...
Constantin Asofiei
07:01 PM User Interface Feature #2016: implement CURRENT-WINDOW, ACTIVE-WINDOW and DEFAULT-WINDOW system handles
Here is an update with last changes. I merged it with current revision and checked if it is ok again. If I correctly ... Vadim Gindin
05:09 PM Database Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...
Note 25 corrected, added one more error message after comparing with 4GL behavior. Vadim Nebogatov
04:34 PM Base Language Feature #1645: implement web services support
Code Review 0109d
1. SOAPFactory.throwError() needs javadoc.
2. How safe is the use of IllegalArgumentException...
Greg Shah
03:09 PM Base Language Feature #1645: implement web services support
Attached update adds:
# runtime implementation for legacy SOAP Header, Header Entry, Fault and Fault Detail resource...
Constantin Asofiei
03:54 PM Base Language Feature #1608: implement full appserver support (from 4GL clients only)
The changes look fine. Check them in when they pass testing. Greg Shah
02:57 PM Base Language Feature #1608: implement full appserver support (from 4GL clients only)
Fixes a couple of problems in appserver agents:
# @ProcedureManager$WorkArea$scopeFinished@ was popping the target-p...
Constantin Asofiei
03:49 PM User Interface Feature #1782: implement LAST-EVENT system handle and associated attributes
Go ahead with the runtime testing. I'll do the review tomorrow. Constantin Asofiei
03:28 PM User Interface Feature #1782: implement LAST-EVENT system handle and associated attributes
Here is the update. I'm waiting for your permission to start regression testing. Vadim Gindin
03:56 AM User Interface Feature #1782: implement LAST-EVENT system handle and associated attributes
> Correct result. I'm going to run regression testing.
Perfect. Post the update here, once you've added javadoc/todo's.
Constantin Asofiei
07:33 PM User Interface Feature #1782: implement LAST-EVENT system handle and associated attributes
I tested your ENDKEY test.
Progress shows:
PF4 - END-ERROR [KEYPRESS]
Java shows:
F4 - END-ERROR [KEYPRESS]
Cor...
Vadim Gindin
03:09 PM Base Language Feature #2022 (Review): runtime support for web services
Constantin Asofiei
03:08 PM Base Language Feature #1995 (Review): runtime support for SOAP
Constantin Asofiei
03:05 PM Base Language Feature #1644: implement SOAP support
All updates and discussions for this task was moved to #1645. Constantin Asofiei
03:03 PM Database Bug #2223: ASSIGN schema triggers without reference to database fields
There are two kinds of ASSIGN schema triggers:
* related to a well known database field (declared using @TRIGGER PRO...
Ovidiu Maxiniuc
02:41 PM Database Bug #2223 (New): ASSIGN schema triggers without reference to database fields
Ovidiu Maxiniuc
11:07 AM User Interface Feature #1811: implement the AJAX client driver
> 1. I think that is better to start by designing our custom binary protocol.
OK, good.
> 2. The Dojo toolkit S...
Greg Shah
10:22 AM User Interface Feature #1811: implement the AJAX client driver
1. I think that is better to start by designing our custom binary protocol. This means that we have to define the str... Marius Gligor
03:02 AM Base Language Feature #1641: implement SAX XML support
Evgeny Kiselev wrote:
>After deleting X-DOCUMENT all nodes become uninitialized.
You've checked only the root X-N...
Constantin Asofiei
07:50 PM Base Language Feature #1641: implement SAX XML support
After deleting @X-DOCUMENT@ all nodes become uninitialized.... Evgeny Kiselev

01/08/2014

06:10 PM User Interface Feature #2016: implement CURRENT-WINDOW, ACTIVE-WINDOW and DEFAULT-WINDOW system handles
Sorry, I forgot about this-procedure:current-window. Here is the test:... Vadim Gindin
04:23 PM User Interface Feature #1811: implement the AJAX client driver
> Maybe a short research on how to use GZIP with embedded jetty could be useful.
> Do you think that a JSON and GZIP...
Greg Shah
01:28 PM User Interface Feature #1811: implement the AJAX client driver
1. WebSockets are full-duplex communication channels over TCP. So we have to implements a communication protocol on s... Marius Gligor
10:51 AM User Interface Feature #1811: implement the AJAX client driver
Ref. #2201 implement the web client process spawning and server redirect.
Passed the regression tests.
Committed re...
Marius Gligor
04:19 PM Database Bug #2221 (Closed): indexes not created or being dropped during data import
Eric Faulhaber
04:16 PM Database Bug #2221: indexes not created or being dropped during data import
Index creation after a table's data import (i.e., all non-unique indexes) was happening outside of a transaction, as ... Eric Faulhaber
03:23 PM Database Feature #1666 (Closed): add support for mixed-direction indexes
Eric Faulhaber
07:02 AM Database Feature #1666: add support for mixed-direction indexes
Constant CC_PREFIX - removed.
Also added the modifications into the P2JSQLServer2008Dialect.java, too, but this file...
Ovidiu Maxiniuc
02:08 PM Database Bug #2222: WRITE event triggered too early
In some conditions, the WRITE event caused by the flush of the record to database occurs earlier than the correspondi... Ovidiu Maxiniuc
12:41 PM Database Bug #2222 (Hold): WRITE event triggered too early
Ovidiu Maxiniuc
01:46 PM Database Feature #1662: runtime support for table parameters
Code review 20140107a:
* I was a bit confused by the deferred copy error processing in @TemporaryBuffer@, with the...
Eric Faulhaber
11:29 AM User Interface Feature #2201 (Closed): implement the web client process spawning and server redirect
Greg Shah
08:36 AM Base Language Feature #1641: implement SAX XML support
Evgeny, we missed something: deletion of the SAX and DOM/XML objects. How I've noticed this: the @XCommonImpl.resourc... Constantin Asofiei
11:50 PM Database Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...
Once you are sufficiently comfortable that your @bufferField(character)@ implementation works properly with your test... Eric Faulhaber
07:46 PM Database Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...
Vadim: the @bufferField(character)@ implementation looks good to me.
You don't need to implement @bufferField(int)...
Eric Faulhaber

01/07/2014

06:46 PM Base Language Feature #1641: implement SAX XML support
Greg Shah wrote:
> Please place them in testcases/uast/xml/dom/ and testcases/uast/xml/sax/ directories.
DOM testca...
Evgeny Kiselev
06:02 PM Base Language Feature #1641: implement SAX XML support
Passed the regression testing. Committed at bzr revision 10428.
Evgeny Kiselev
08:24 AM Base Language Feature #1641: implement SAX XML support
I have no objections. We need to get this committed as soon as it passes regression testing.
> BTW, I can't find ...
Greg Shah
03:39 AM Base Language Feature #1641: implement SAX XML support
Did this pass testing? If yes, then this is next on queue to be committed, unless Greg has any objections.
BTW, I ...
Constantin Asofiei
07:41 PM Base Language Feature #1641: implement SAX XML support
1) merged with latest revision(removed SAX_ATTRIBUTES and SAX_READER from @IdKind@ enum, because all SAX objects are ... Evgeny Kiselev
06:05 PM Database Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...
Just noticed that I needed to start from bufferField(character fieldName). It will reuse bufferField(String fieldName... Vadim Nebogatov
05:59 PM Database Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...
The question about @BufferImpl.bufferField(int fieldNumber@) implementation.
I am going to reuse @bufferField(Str...
Vadim Nebogatov
03:12 AM Database Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...
Eric Faulhaber wrote:
> Constantin: you left TODOs in the @QueryWrapper@ methods listed above in note 20. Did you de...
Constantin Asofiei
01:26 AM Database Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...
Implementation note: where new Java annotations are needed on DMOs to implement some of the above attributes, please ... Eric Faulhaber
01:14 AM Database Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...
I realize the previous 3 entries are not necessarily all about dynamic attributes and methods, but I needed to summar... Eric Faulhaber
01:05 AM Database Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...
The following need implementation in @QueryWrapper@:... Eric Faulhaber
01:03 AM Database Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...
The following need implementation in @FieldReference@:... Eric Faulhaber
01:01 AM Database Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...
The following need implementation in @BufferImpl@:... Eric Faulhaber
06:01 PM Base Language Feature #1988 (Review): runtime support for SAX
Evgeny Kiselev
06:00 PM Base Language Feature #1988 (WIP): runtime support for SAX
Evgeny Kiselev
02:51 PM Database Bug #2221: indexes not created or being dropped during data import
We seem to have introduced a regression to the data import process. Recent customer data imports are missing many of ... Eric Faulhaber
02:35 PM Database Bug #2221 (Closed): indexes not created or being dropped during data import
Eric Faulhaber
02:20 PM Database Feature #1669 (Closed): add support for additional database methods
Remaining methods are being coordinated from #1655. Eric Faulhaber
02:18 PM Database Feature #1661 (WIP): support case-sensitive fields in indexes
The remaining portion of this task is not needed for M7; moving to M11. Eric Faulhaber
02:15 PM Database Feature #2117 (Test): add runtime support for _lock metadata table
Eric Faulhaber
02:14 PM Database Feature #1666: add support for mixed-direction indexes
Code review 20131221a:
Looks good. Please remove the commented-out @P2JH2Dialect.CC_PREFIX@ class variable -- no n...
Eric Faulhaber
01:47 PM User Interface Feature #1782: implement LAST-EVENT system handle and associated attributes
Vadim Gindin wrote:
> I mean, what tests do you consider as basic?
Case 8 from the table, @widget and key events@, ...
Constantin Asofiei
01:08 PM User Interface Feature #1782: implement LAST-EVENT system handle and associated attributes
I mean, what tests do you consider as basic? Vadim Gindin
01:07 PM User Interface Feature #1782: implement LAST-EVENT system handle and associated attributes
Constantin Asofiei wrote:
> .. just ensure the basic tests work.
I wrote in the table results of all tests I have...
Vadim Gindin
09:20 AM User Interface Feature #1782: implement LAST-EVENT system handle and associated attributes
After contacting Guy, the conclusion is that the server project does not use the program which reads the LAST-EVENT:L... Constantin Asofiei
08:41 AM User Interface Feature #1782: implement LAST-EVENT system handle and associated attributes
> Greg: can ENDKEY label (and last-key) be ever produced by user key press?
I'm not sure. Normally, I would have ...
Greg Shah
05:00 AM User Interface Feature #1782: implement LAST-EVENT system handle and associated attributes
The server project uses the LAST-EVENT:LABEL in only one place, with a case like (this is an assumption, as I can't f... Constantin Asofiei
01:41 PM User Interface Feature #2016: implement CURRENT-WINDOW, ACTIVE-WINDOW and DEFAULT-WINDOW system handles
Review of 0107a.zip:
* please try not to post updates merged with other tasks; if you find it difficult to work more...
Constantin Asofiei
01:01 PM User Interface Feature #2016: implement CURRENT-WINDOW, ACTIVE-WINDOW and DEFAULT-WINDOW system handles
Sorry I forgot to add the comment about the path. Here is updated archive. Vadim Gindin
12:56 PM User Interface Feature #2016: implement CURRENT-WINDOW, ACTIVE-WINDOW and DEFAULT-WINDOW system handles
Here is an update with last changes. Vadim Gindin
12:04 PM User Interface Feature #2016: implement CURRENT-WINDOW, ACTIVE-WINDOW and DEFAULT-WINDOW system handles
I ran the program using @pro -p a.p@; if you run it using @pro -p somefolder/a.p@, then you will have @somefolder/a.p... Constantin Asofiei
12:01 PM User Interface Feature #2016: implement CURRENT-WINDOW, ACTIVE-WINDOW and DEFAULT-WINDOW system handles
Yes, I checked it again. My exact message is:
@** /home/vig/winhandles/simple2.p: Unable to evaluate field for assig...
Vadim Gindin
11:52 AM User Interface Feature #2016: implement CURRENT-WINDOW, ACTIVE-WINDOW and DEFAULT-WINDOW system handles
Vadim Gindin wrote:
> Thank you, but Progress shows full path to procedure file starting from root folder "/". @Envi...
Constantin Asofiei
11:32 AM User Interface Feature #2016: implement CURRENT-WINDOW, ACTIVE-WINDOW and DEFAULT-WINDOW system handles
Thank you, but Progress shows full path to procedure file starting from root folder "/". @EnvironmentOps.getSourceNam... Vadim Gindin
10:37 AM User Interface Feature #2016: implement CURRENT-WINDOW, ACTIVE-WINDOW and DEFAULT-WINDOW system handles
Vadim Gindin wrote:
> Constantin, could you help me. I didn't find in @ErrorManager@ a possibility to include in the...
Constantin Asofiei
10:32 AM User Interface Feature #2016: implement CURRENT-WINDOW, ACTIVE-WINDOW and DEFAULT-WINDOW system handles
Constantin, could you help me. I didn't find in @ErrorManager@ a possibility to include in the error message the name... Vadim Gindin
07:04 AM User Interface Feature #2016: implement CURRENT-WINDOW, ACTIVE-WINDOW and DEFAULT-WINDOW system handles
Great. Please finish the changes I mentioned in note 27 (expect the @current-window = ?@ case) and post the update here. Constantin Asofiei
06:06 AM User Interface Feature #2016: implement CURRENT-WINDOW, ACTIVE-WINDOW and DEFAULT-WINDOW system handles
Yes it works and moreover there are no more need to move KW_NO_ERROR manually. Here is the new AST node:... Vadim Gindin
05:08 AM User Interface Feature #2016: implement CURRENT-WINDOW, ACTIVE-WINDOW and DEFAULT-WINDOW system handles
> It seems it because KW_NO_ERROR is inside expression and unfortunately I forced to wrap EXPRESSION inside STATEMENT... Constantin Asofiei
04:54 AM User Interface Feature #2016: implement CURRENT-WINDOW, ACTIVE-WINDOW and DEFAULT-WINDOW system handles
I understand, thank you. Now it produces this Java code:... Vadim Gindin
03:47 AM User Interface Feature #2016: implement CURRENT-WINDOW, ACTIVE-WINDOW and DEFAULT-WINDOW system handles
Vadim Gindin wrote:
> I added first change in the frame_scoping.rules to emit KW_NO_ERROR in a some place in the tar...
Constantin Asofiei
01:04 PM Database Feature #2024: implement runtime support for database triggers
From Ovidiu's email response:
The @openReadOnlyScope()@ is not needed any more. The OLD buffer is built in Databas...
Eric Faulhaber
01:19 AM Database Feature #2024: implement runtime support for database triggers
The following trigger-related methods are present but not implemented in @BufferImpl@:... Eric Faulhaber
01:01 PM Database Feature #1662 (Test): runtime support for table parameters
Eric Faulhaber
02:43 AM Database Feature #1662: runtime support for table parameters
Merged with the latest P2J. Stanislav Lomany
12:45 PM Database Feature #1588 (Closed): add conversion and runtime support for embedded SQL
Eric Faulhaber
12:43 PM Database Feature #2043 (Closed): add runtime support for some embedded SQL features
Eric Faulhaber
12:42 PM Database Feature #2126 (Closed): add support for table-level locking (share and exclusive) for runtime int...
Eric Faulhaber
12:39 PM Database Feature #1653 (Closed): add conversion and runtime support for dynamically prepared queries
Eric Faulhaber
12:35 PM Database Feature #2080 (Closed): add runtime support for database methods
All remaining, database-related methods and attributes are being managed through issue #1655. Eric Faulhaber
12:32 PM Database Feature #1654 (Closed): add conversion and runtime support for dynamic buffer creation and cleanup
Eric Faulhaber
12:31 PM Database Feature #2125 (Closed): add runtime support for dynamic buffer creation and cleanup
Eric Faulhaber
12:29 PM Database Feature #2120 (Closed): add runtime support for dynamically prepared queries
The problematic test cases above have been recorded in #2220, as they are not expected to be needed for M7. Eric Faulhaber
12:27 PM Database Feature #2220: dynamic query methods which require implementation
The following need implementation in @QueryWrapper@:... Eric Faulhaber
12:27 PM Database Feature #2220 (Closed): dynamic query methods which require implementation
Eric Faulhaber
12:25 PM Database Bug #2219: problematic dynamic query test cases
*Originally reported by Stanislav in #2120:*
Variation of the bug above. Testcase:...
Eric Faulhaber
12:24 PM Database Bug #2219: problematic dynamic query test cases
*Originally reported by Stanislav in #2120:*
Yet another minor bug. Testcase:...
Eric Faulhaber
12:22 PM Database Bug #2219 (Closed): problematic dynamic query test cases
Eric Faulhaber
12:21 PM User Interface Feature #1811: implement the AJAX client driver
Code Review 0107a
I am fine with the changes. When it passes regression testing, please check it in and distribut...
Greg Shah
11:42 AM User Interface Feature #1811: implement the AJAX client driver
Here are the latest changes on my local repository after an update from remote repository.
Only two files was merged...
Marius Gligor
12:12 PM Database Feature #1668 (Closed): add support for additional (non-dynamic) database attributes
See #1655. Eric Faulhaber
12:11 PM Database Feature #1975 (Closed): add runtime support for (non-dynamic) database attributes
I am closing this issue; the remaining methods and attributes are being managed through issue #1655. Eric Faulhaber

01/06/2014

05:46 PM Base Language Feature #2041 (Closed): implement runtime support for "shared" attributes that are just stubbed
Greg Shah
05:09 PM Base Language Feature #2041: implement runtime support for "shared" attributes that are just stubbed
The final change set attached. Committed at revision 10427. Hynek Cihlar
07:49 AM Base Language Feature #2041: implement runtime support for "shared" attributes that are just stubbed
OK, remove the @ProcedureManager.setInstantiatingProcedure@ (because is no longer used and it will just confuse reade... Constantin Asofiei
07:44 AM Base Language Feature #2041 (Review): implement runtime support for "shared" attributes that are just stubbed
Hynek Cihlar
07:40 AM Base Language Feature #2041: implement runtime support for "shared" attributes that are just stubbed
Fixed and changes attached. Regression tests passed. Hynek Cihlar
05:10 PM User Interface Feature #2016: implement CURRENT-WINDOW, ACTIVE-WINDOW and DEFAULT-WINDOW system handles
Yes It will be simpler. But It looks like the last change you propose is a solution of some private task. I added fir... Vadim Gindin
02:29 PM User Interface Feature #2016: implement CURRENT-WINDOW, ACTIVE-WINDOW and DEFAULT-WINDOW system handles
> KW_NO_ERROR probably should not be included inside EXPRESSION. Am I right? The question is how this ast node should... Constantin Asofiei
02:10 PM User Interface Feature #2016: implement CURRENT-WINDOW, ACTIVE-WINDOW and DEFAULT-WINDOW system handles
I corrected the rules block you specified to force it transfer KW_NO_ERROR too and got this ast node (after annotatio... Vadim Gindin
09:11 AM User Interface Feature #2016: implement CURRENT-WINDOW, ACTIVE-WINDOW and DEFAULT-WINDOW system handles
Vadim Gindin wrote:
> I can only suspect that the transformation from @assignment@ to @expression@ is going in the a...
Constantin Asofiei
09:06 AM User Interface Feature #2016: implement CURRENT-WINDOW, ACTIVE-WINDOW and DEFAULT-WINDOW system handles
Thank you Constantin!
I ran the conversion process with @f2+cb@ options and got my first result, but when I ran th...
Vadim Gindin
07:58 AM User Interface Feature #2016: implement CURRENT-WINDOW, ACTIVE-WINDOW and DEFAULT-WINDOW system handles
Vadim, to identify if the problem is in the parser, then is best to check the AST generated by the FRONT phase, as th... Constantin Asofiei
03:42 PM User Interface Feature #1811: implement the AJAX client driver
Something else to consider with the protocol is that the GUI driver/javascript will have more significant requirement... Greg Shah
03:32 PM User Interface Feature #1811: implement the AJAX client driver
Additional Details on the Protocol
1. The protocol will need to be full-duplex. It must be possible to have both ...
Greg Shah
03:06 PM User Interface Feature #1811: implement the AJAX client driver
> We have to design the protocol used by websockets.
> We have two options: JSON or binary payloads. As I remember y...
Greg Shah
02:55 PM User Interface Feature #1811: implement the AJAX client driver
Code Review 1223a
I am fine with the changes.
Please merge up to the latest bzr revision (10426) and then run r...
Greg Shah
03:36 PM Base Language Feature #2184: create and populate the temp-table on the remote side, based on the received metad...
This comes into play to dynamically create and/or populate an input temp-table (on the appserver side) or an output t... Greg Shah
03:16 PM Base Language Feature #1645: implement web services support
Greg Shah wrote:
> Other than that, my only question is in ControlFlowOps.initializeProxy(), is there any way the Il...
Constantin Asofiei
11:43 AM Base Language Feature #1645: implement web services support
Code Review 1224a
I like the improved abstraction of some parts of the runtime (e.g. ServerHelper). It also seems...
Greg Shah
02:37 PM Database Feature #1666: add support for mixed-direction indexes
Updated and cleaned-up version of the previous patch.
Some files were removed from the zip as their changes has alr...
Ovidiu Maxiniuc
02:36 PM User Interface Feature #1787 (Closed): implement batch mode support
Greg Shah
02:05 PM User Interface Feature #1787: implement batch mode support
evl_upd20131221b.zip did pass the regression testing and committed to bzr as 10426. Eugenie Lyzenko
10:15 AM User Interface Feature #1787: implement batch mode support
Go ahead, commit and distribute it. Greg Shah
09:18 AM User Interface Feature #1787: implement batch mode support
Greg Shah wrote:
> Constantin: do you see any concerns?
I don't see any obvious problems in the logic. My only conc...
Constantin Asofiei
08:53 AM User Interface Feature #1787: implement batch mode support
I am OK with the changes.
Constantin: do you see any concerns?
If not, then the check in can proceed.
Greg Shah
02:13 PM Database Feature #1662: runtime support for table parameters
TABLE/TABLE-HANDLE parameters work with the following exceptions:
1. extents copying doesn't work;
2. @thparm-inval...
Stanislav Lomany
01:22 PM User Interface Feature #2027 (Closed): preliminary runtime support for CREATE_WIDGET and an IN WINDOW clause
Greg Shah
01:20 PM Base Language Feature #2208: create a java application running web services for testing purposes
Some more notes: 4GL seems to alter the received SOAP Envelope by adding i.e. additional XMLNS attributes at the root... Constantin Asofiei
01:16 PM User Interface Feature #2212 (WIP): design websockets protocol for bidirectional communication between the javas...
Marius Gligor
11:12 AM User Interface Feature #1782: implement LAST-EVENT system handle and associated attributes
Constantin will be the one doing a more detailed review of your latest code.
I have taken a quick look at the code...
Greg Shah
10:13 AM Base Language Feature #1995 (WIP): runtime support for SOAP
Constantin Asofiei
09:45 AM User Interface Feature #1801: add some frame options
> Could somebody explain the rationale behind the varying end escape sequences? I.e., why are some colors terminated ... Greg Shah
07:42 AM Base Language Feature #1641: implement SAX XML support
Review for 0104a.zip:
* SaxAttributesImpl.removeAttribute (both versions): javadoc for the parameters is not on dist...
Constantin Asofiei

01/05/2014

01:48 PM Database Feature #1662: runtime support for table parameters
Stanislav Lomany wrote:
> [...]
> The ideas that I have:
> 1. Create prioritized finalizables.
> 2. Track all sta...
Eric Faulhaber
10:23 AM User Interface Feature #1801: add some frame options
Greg Shah wrote:
> Alright, please do try to resolve the variable end sequences as elegantly as possible. Try to im...
Hynek Cihlar
07:03 PM Base Language Feature #1645: implement web services support
Constantin Asofiei wrote:
> LE: Nevermind, there is the @XmlHelper.write@ in P2J.
I've used for SAX writer:...
Evgeny Kiselev

01/04/2014

05:04 PM Database Feature #1662: runtime support for table parameters
Eric, please consider OUTPUT TABLE-HANDLE parameters, like this:... Stanislav Lomany
04:44 PM Base Language Feature #1645: implement web services support
LE: Nevermind, there is the @XmlHelper.write@ in P2J. Constantin Asofiei
04:01 PM Base Language Feature #1645: implement web services support
Evgeny: please help me a little with something related to @X-Noderef@ resources. Is there an existing way to serializ... Constantin Asofiei
02:56 PM Base Language Feature #1641: implement SAX XML support
fixed issues from note 90 Evgeny Kiselev
12:45 PM Base Language Feature #1641: implement SAX XML support
Constantin Asofiei wrote:
> Review for 1231a.zip:
> # what are licences for the new jars?
under BSD license. It wa...
Evgeny Kiselev
01:23 PM User Interface Feature #1787: implement batch mode support
Well, I've got the CTRL-C tests fully passed in one round. Take a look at 2014 year results from:
10425_ed8b6f3_2014...
Eugenie Lyzenko
04:29 AM User Interface Feature #2016: implement CURRENT-WINDOW, ACTIVE-WINDOW and DEFAULT-WINDOW system handles
Thank you for the explanation. I wrote an ast node in my previous comment (#28). Vadim Gindin

01/03/2014

01:56 PM User Interface Feature #2016: implement CURRENT-WINDOW, ACTIVE-WINDOW and DEFAULT-WINDOW system handles
First, in regard to your specific problem, I doubt the issue is in the parser. The NO-ERROR should emit as:
ErrorMa...
Greg Shah
01:53 PM User Interface Feature #2016: implement CURRENT-WINDOW, ACTIVE-WINDOW and DEFAULT-WINDOW system handles
I'm trying to fix no-error loose during conversion of this statement:
@current-window = h no-error.@
I am viewi...
Vadim Gindin
06:05 AM User Interface Feature #2016: implement CURRENT-WINDOW, ACTIVE-WINDOW and DEFAULT-WINDOW system handles
Some general notes:
# in the implementations for all @current/default/active-window@ APIs in @LogicalTerminal@, wher...
Constantin Asofiei
12:18 PM User Interface Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects)
> Well, the current-iteration is not linked with an iterating block
Yes, this is exactly how we have implemented d...
Greg Shah
10:42 AM User Interface Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects)
Vadim Gindin wrote:
> P.S. About numbering. What problem do you see in it? I viewed same values for newly created wi...
Constantin Asofiei
08:13 AM User Interface Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects)
Here are widget attrs:
!widget_attrs.png!
In this result we can see values of following attrs (in order of appearing)...
Vadim Gindin
05:14 AM User Interface Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects)
Well, the @current-iteration@ is not linked with an iterating block; lets take this case:... Constantin Asofiei
12:10 PM User Interface Feature #1801: add some frame options
Alright, please do try to resolve the variable end sequences as elegantly as possible. Try to implement the simple/s... Greg Shah
07:17 PM User Interface Feature #1801: add some frame options
Greg Shah wrote:
> If I understand you correctly, you are suggesting that for NCurses/Curses we directly use the par...
Hynek Cihlar
07:10 AM Base Language Feature #2208: create a java application running web services for testing purposes
Evgeny, please make it a priority to add basic services which work with SOAP Faults and SOAP Headers (response and re... Constantin Asofiei
07:09 AM Base Language Feature #1644: implement SOAP support
I've started working on finishing the SOAP Fault support (part of #1645). The SOAP Header support is highly dependent... Constantin Asofiei
04:34 AM Base Language Feature #2041: implement runtime support for "shared" attributes that are just stubbed
OK, the location is the right one, but you need to do it only if we are starting an external proc; also, remove the @... Constantin Asofiei
04:15 AM Base Language Feature #1641: implement SAX XML support
Review for 1231a.zip:
# what are licences for the new jars?...
Constantin Asofiei

01/02/2014

02:39 PM User Interface Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects)
This is somewhat consistent with my theory. On a 5-down frame, you would expect 5 sets of widgets, but it looks like... Greg Shah
01:08 PM User Interface Feature #1801: add some frame options
This is going in the right direction.
If I understand you correctly, you are suggesting that for NCurses/Curses we...
Greg Shah
11:33 PM Database Feature #1662: runtime support for table parameters
We already have an annotation like this for #2134, but currently it is only for extent fields which have been expande... Eric Faulhaber

01/01/2014

05:17 PM Base Language Feature #2041: implement runtime support for "shared" attributes that are just stubbed
Calling @ProcedureManager.setInstantiatingProcedure@ from the constructor of @ExternalProgramWrapper@ is too early, a... Hynek Cihlar
08:02 PM Base Language Feature #1641: implement SAX XML support
1) added DTD validation with specific schema-paths
2) added XSD schema validation
3) added callback resolveEntity pro...
Evgeny Kiselev

12/31/2013

06:56 PM User Interface Feature #1801: add some frame options
Here's a proposed sample of the xml format for storing the color mappings. Parsing the escape sequence into a more st... Hynek Cihlar
08:46 PM User Interface Feature #1801: add some frame options
Internally to P2J, a color is represented with the @Color@ class. The @Color@ class holds the (logical) color value a... Hynek Cihlar
09:51 AM User Interface Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects)
I've prepared first test... Vadim Gindin

12/30/2013

11:32 AM Database Feature #1662: runtime support for table parameters
Eric, @TemporaryBuffer.copyAlRows@ which is supposed to perform record copy upon calling a procedure which uses TABLE... Stanislav Lomany
 

Also available in: Atom