Project

General

Profile

Activity

From 03/08/2014 to 04/06/2014

04/05/2014

12:28 PM Database Feature #2276: create a work queue of PatternEngine instances for runtime conversion tasks
Missed a few files, so I'm re-uploading this update. Eric Faulhaber
12:21 PM Database Feature #2276: create a work queue of PatternEngine instances for runtime conversion tasks
Interim update. I am uploading it as a safety backup, but it still needs a lot of work and cleanup. Eric Faulhaber
08:33 AM Database Feature #2258: retrofit BUFFER-COPY and BUFFER-COMPARE language statement runtime support to use ...
Please include the fix with your update for this issue. Eric Faulhaber
06:42 AM Database Feature #2258: retrofit BUFFER-COPY and BUFFER-COMPARE language statement runtime support to use ...
During testing I have found one bug not related directly with issue.
RecordBuffer, line 4032:...
Vadim Nebogatov
05:03 AM Base Language Feature #2184: create and populate the temp-table on the remote side, based on the received metad...
Guys, there is an issue with scoping on app server. Consider a simple testcase: ... Stanislav Lomany

04/04/2014

04:31 PM Database Feature #2273: address remaining limitations of SQL Server needed to support legacy 4GL behavior
For the hint syntax, we generally follow the rule of thumb that if there can be only one value, the information is st... Eric Faulhaber
04:25 PM Database Feature #2273: address remaining limitations of SQL Server needed to support legacy 4GL behavior
I started adding hint support for table fields. I added parsing and processing in TableHints.java, p2o.xml, hibernate... Ovidiu Maxiniuc
04:08 PM Database Feature #2273: address remaining limitations of SQL Server needed to support legacy 4GL behavior
Based on your findings of the longer index limit on their development systems, we have asked the customer to confirm ... Eric Faulhaber
04:01 PM Database Feature #2273: address remaining limitations of SQL Server needed to support legacy 4GL behavior
My previous test cases were too complicated.
Thanks to Greg's suggestion, I used the other condition guards for the...
Ovidiu Maxiniuc
01:37 PM Base Language Feature #1634: implement full native library (.so or DLL) support
> For this, I expected that copying the entire contents of the @x86_64-w64-mingw32.zip@ archive in my mingw64 folder ... Eugenie Lyzenko
11:33 AM Base Language Feature #1634: implement full native library (.so or DLL) support
Eugenie Lyzenko wrote:
> > Eugenie, is it correct for the x86_64-w64-mingw32.zip to contain this path: @x86_64-w64-m...
Constantin Asofiei
10:59 AM Base Language Feature #1634: implement full native library (.so or DLL) support
> Eugenie, is it correct for the x86_64-w64-mingw32.zip to contain this path: @x86_64-w64-mingw32/libs/@, instead of ... Eugenie Lyzenko
07:38 AM Base Language Feature #1634: implement full native library (.so or DLL) support
Eugenie, is it correct for the x86_64-w64-mingw32.zip to contain this path: @x86_64-w64-mingw32/libs/@, instead of @x... Constantin Asofiei
06:29 AM Base Language Feature #1634: implement full native library (.so or DLL) support
Eugenie Lyzenko wrote:
> Found the runtime regression. When the client starts, after enter username and login the fo...
Constantin Asofiei
12:12 PM Base Language Bug #2133: fix precision for decimal, dynamic-extent variables
Hynek Cihlar wrote:
> Hynek Cihlar wrote:
> > Yes, of course, sorry for that. The attached file is the correct exam...
Constantin Asofiei
12:03 PM Base Language Bug #2133: fix precision for decimal, dynamic-extent variables
Regression test of 0329a.zip passed. Fixed the indent in 0329a.zip (see the attached 0404a.zip) and committed to revi... Hynek Cihlar
11:37 AM Base Language Bug #2133: fix precision for decimal, dynamic-extent variables
Hynek Cihlar wrote:
> Yes, of course, sorry for that. The attached file is the correct example.
Constantin, is th...
Hynek Cihlar
05:00 AM Base Language Bug #2133: fix precision for decimal, dynamic-extent variables
Hynek Cihlar wrote:
> I think you reviewed the wrong file.
Yes, it was the wrong file. What confused me was that I...
Constantin Asofiei
11:09 AM Database Feature #2276: create a work queue of PatternEngine instances for runtime conversion tasks
Constantin, I implemented it this way because I was trying to mimic how we use the pattern engine during static conve... Eric Faulhaber
05:13 AM Database Feature #2276: create a work queue of PatternEngine instances for runtime conversion tasks
Eric,
> running the global init-rules once per PatternEngine instance
I'm a little concerned about this, as it will...
Constantin Asofiei
11:48 PM Database Feature #2276 (WIP): create a work queue of PatternEngine instances for runtime conversion tasks
To prove that this idea has merit, I've hacked up the dynamic conversion code and made some changes to @PatternEngine... Eric Faulhaber
11:08 AM User Interface Feature #1788: implement define rectangle and rectangle widget support
Today I did a lot of RECTANGLE tests using the customer's P4GL environment.
Also I converted a small procedure worki...
Marius Gligor
09:52 AM Database Feature #2134 (Closed): configurable denormalization of extent fields into individual fields in s...
Eric Faulhaber
06:44 AM User Interface Feature #1805: add missing UI method support
PS: my test was with the latest P2J from bzr, without your #2162 changes. Constantin Asofiei
06:39 AM User Interface Feature #1805: add missing UI method support
Vadim Gindin wrote:
> Sorry, I thought that it is already committed. Now I've committed it (the file _browse_ui_test...
Constantin Asofiei
06:09 AM Runtime Infrastructure Feature #2124: improve/simplify the startup of server-side batch processes and appserver "agent" ...
Changed to allow postbuild.sh to install the spawn tool and associated files in a specified location. The command loo... Constantin Asofiei

04/03/2014

06:30 PM Database Feature #2273: address remaining limitations of SQL Server needed to support legacy 4GL behavior
> This looks like a fatal error, I was not able to catch it with no-error clause added to assign statement, and also ... Greg Shah
03:26 PM Database Feature #2273: address remaining limitations of SQL Server needed to support legacy 4GL behavior
h3. Write test cases which violate the Progress index size limit to determine error conditions we need to handle.
...
Ovidiu Maxiniuc
06:27 PM User Interface Feature #1788: implement define rectangle and rectangle widget support
> Also I looked over P2J project code in order to understand how to implements P4 widgets on P2J and I found a class ... Greg Shah
02:32 AM User Interface Feature #1788 (WIP): implement define rectangle and rectangle widget support
Marius Gligor
06:02 PM Base Language Feature #1634: implement full native library (.so or DLL) support
Found the runtime regression. When the client starts, after enter username and login the following exception occurs:
...
Eugenie Lyzenko
03:09 PM Base Language Feature #1634: implement full native library (.so or DLL) support
The conversion testing completed without regressions. The @src/aero/timco/majic@ directory with converted files is id... Eugenie Lyzenko
12:33 PM Base Language Feature #1634: implement full native library (.so or DLL) support
> With these changes, do the native library calls all work as expected on Windows?
The converted code and output f...
Eugenie Lyzenko
12:01 PM Base Language Feature #1634: implement full native library (.so or DLL) support
> The only issue I see is that the class javadoc for @ServerPropertiesDaemon@ is incorrect (due to copy/paste). Pleas... Eugenie Lyzenko
11:29 AM Base Language Feature #1634: implement full native library (.so or DLL) support
Code Review 0403a
The only issue I see is that the class javadoc for ServerPropertiesDaemon is incorrect (due to c...
Greg Shah
07:06 AM Base Language Feature #1634: implement full native library (.so or DLL) support
> I'm refering to the @EnvironmentOps.propathOverride@ field defined at line 151 (which has no javadoc, btw, and was ... Eugenie Lyzenko
06:42 AM Base Language Feature #1634: implement full native library (.so or DLL) support
Eugenie Lyzenko wrote:
> The fixed update for review.
>
> > the @EnvironmentOps.propathOverride@ is not used, it ...
Constantin Asofiei
06:35 AM Base Language Feature #1634: implement full native library (.so or DLL) support
The fixed update for review.
> the @EnvironmentOps.propathOverride@ is not used, it needs to be removed.
This c...
Eugenie Lyzenko
02:10 AM Base Language Feature #1634: implement full native library (.so or DLL) support
Eugenie, about 0328a.zip:
# the @EnvironmentOps.propathOverride@ is not used, it needs to be removed.
# there is on...
Constantin Asofiei
05:47 PM User Interface Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects)
1. I forgot about LITERAL field-group. Added this implementation.
2. I also found one bug during the work on TODO...
Vadim Gindin
03:02 AM User Interface Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects)
Vadim Gindin wrote:
> I'm thinking about virtual copies of widgets on the server side. I need some advice. I'm plann...
Constantin Asofiei
01:23 PM Base Language Bug #2133: fix precision for decimal, dynamic-extent variables
Constantin Asofiei wrote:
> Hynek Cihlar wrote:
> > Any update on the review request from the note #33?
> I guess ...
Hynek Cihlar
01:09 PM Base Language Bug #2133: fix precision for decimal, dynamic-extent variables
Constantin Asofiei wrote:
> Hynek Cihlar wrote:
> > Note the call @extj.setParameter(j, true)@ for the input-output...
Hynek Cihlar
02:02 AM Base Language Bug #2133: fix precision for decimal, dynamic-extent variables
Hynek Cihlar wrote:
> Note the call @extj.setParameter(j, true)@ for the input-output case which initializes the arr...
Constantin Asofiei
11:32 AM Base Language Bug #2277: Wrong conversion of session handler
Next 4gl code produce uncompilable java code:... Greg Shah
10:31 AM Database Feature #2134: configurable denormalization of extent fields into individual fields in schema con...
h2. Configurable denormalization of extent fields into individual fields
Two types of field denormalization are supp...
Vadim Nebogatov
07:15 AM User Interface Feature #1805: add missing UI method support
Sorry, I thought that it is already committed. Now I've committed it (the file _browse_ui_test1.p_) Vadim Gindin
06:09 AM User Interface Feature #1805: add missing UI method support
Vadim Gindin wrote:
> I ran _browse_ui_test1.p_ from the /uast folder.
Please commit the test to the testcases proj...
Constantin Asofiei
05:34 AM User Interface Feature #1805: add missing UI method support
I've found the following bug in Java implementation during the testing. I ran _browse_ui_test1.p_ from the /uast fold... Vadim Gindin
05:49 AM Conversion Tools Feature #2251: improve the call graph generation
The branch rev 10504 contains the fix for generating the callgraph reports on windows (the filename should have been ... Constantin Asofiei

04/02/2014

05:50 PM Database Feature #2231 (Closed): LockType error processing
Eric Faulhaber
05:49 PM Database Feature #2231: LockType error processing
Committed to bzr rev. 10503. Vadim Nebogatov
04:22 PM Database Feature #2231: LockType error processing
Yes, please commit and distribute the update. Eric Faulhaber
01:41 PM Database Feature #2231: LockType error processing
Second regression 20140402_084955 is completed with 2 FAILED tests:
1. tc_job_002 FAILED failure in step 40: failu...
Vadim Nebogatov
03:32 AM Database Feature #2231: LockType error processing
Regression 20140401_172003 completed with 4 FAILED tests:
1. tc_job_002 FAILED failure in step 40: 'Unexpected EOF i...
Vadim Nebogatov
03:30 PM Database Feature #2273 (WIP): address remaining limitations of SQL Server needed to support legacy 4GL beh...
h3. Research the options we have in terms of unlimited length text data (including participation of these data types ... Ovidiu Maxiniuc
01:28 PM Database Feature #2273: address remaining limitations of SQL Server needed to support legacy 4GL behavior
Some good news out of today's meeting with the customer: they have not taken advantage of the newer, 1972 byte index ... Eric Faulhaber
01:11 PM Database Feature #2273: address remaining limitations of SQL Server needed to support legacy 4GL behavior
Yes, that is the idea. The computed column (the hashing result) would fit into SQL restriction and the @INCLUDE@ woul... Ovidiu Maxiniuc
12:43 PM Database Feature #2273: address remaining limitations of SQL Server needed to support legacy 4GL behavior
What do you think about using embedded @HashBytes()@ function like http://www.brentozar.com/archive/2013/05/indexing-... Vadim Nebogatov
11:08 AM Database Feature #2273: address remaining limitations of SQL Server needed to support legacy 4GL behavior
Eric Faulhaber wrote:
> Constantin, can you elaborate how this might work? How would we engage the external indexes ...
Constantin Asofiei
09:57 AM Database Feature #2273: address remaining limitations of SQL Server needed to support legacy 4GL behavior
Constantin, can you elaborate how this might work? How would we engage the external indexes to perform a query, for i... Eric Faulhaber
03:18 PM Base Language Bug #2133: fix precision for decimal, dynamic-extent variables
Any update on the review request from the note #33? Hynek Cihlar
03:17 PM Base Language Bug #2133: fix precision for decimal, dynamic-extent variables
File attachment for the #35 note above. Hynek Cihlar
03:16 PM Base Language Bug #2133: fix precision for decimal, dynamic-extent variables
Constantin Asofiei wrote:
> Sorry, I'm coming back on this one: when we can choose between emitting code and hiding ...
Hynek Cihlar
01:21 PM User Interface Feature #2247 (Review): interactive child process support
Marius Gligor
01:20 PM User Interface Feature #1811: implement the AJAX client driver
The interactive process implementation fo0r ChUI Swing and ChUI Web (AJAX) clients with minimum changes on the existi... Marius Gligor
10:48 AM User Interface Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects)
I'm thinking about virtual copies of widgets on the server side. I need some advice. I'm planning to create new field... Vadim Gindin

04/01/2014

05:43 PM Base Language Feature #1634: implement full native library (.so or DLL) support
The different testing performed to check the validity of the 0328a update shows no difference in local conversion in ... Eugenie Lyzenko
04:27 PM Database Feature #2273: address remaining limitations of SQL Server needed to support legacy 4GL behavior
Eric, considering that we already have a locking mechanism above the physical DB layer and this requires that the DB ... Constantin Asofiei
04:00 PM Database Feature #2273: address remaining limitations of SQL Server needed to support legacy 4GL behavior
Indeed, this is a non-trivial issue. Here are some of my thoughts:
+1st approach+ (user filtering of the input):
...
Ovidiu Maxiniuc
03:42 PM User Interface Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects)
I found and fixed a bug with start conditional step. The key was in the fact that conditional calls do not affect the... Vadim Gindin
07:09 AM Base Language Bug #2133: fix precision for decimal, dynamic-extent variables
Constantin Asofiei wrote:
> Hynek Cihlar wrote:
> > May I suggest the following solution? To revert the change in @...
Constantin Asofiei

03/31/2014

07:14 PM Base Language Bug #2133: fix precision for decimal, dynamic-extent variables
Attached is the final fix for the extent-to-extent assignment. The delta from the previous version (hc_upd20140324a.z... Hynek Cihlar
02:56 PM Base Language Bug #2133: fix precision for decimal, dynamic-extent variables
Constantin Asofiei wrote:
> Hynek Cihlar wrote:
> > Constantin Asofiei wrote:
> > For the function case, @ControlF...
Hynek Cihlar
03:31 AM Base Language Bug #2133: fix precision for decimal, dynamic-extent variables
Hynek Cihlar wrote:
> May I suggest the following solution? To revert the change in @OutputExtentParameter@ and @Arr...
Constantin Asofiei
03:29 AM Base Language Bug #2133: fix precision for decimal, dynamic-extent variables
Hynek Cihlar wrote:
> Constantin Asofiei wrote:
> For the function case, @ControlFlowOps@ is not called. Perhaps it...
Constantin Asofiei
06:03 PM Base Language Bug #2277: Wrong conversion of session handler
If code spits like this:... Evgeny Kiselev
05:58 PM Base Language Bug #2277 (New): Wrong conversion of session handler
Evgeny Kiselev
05:21 PM Database Feature #2231: LockType error processing
The update looks good. Please regression test. Eric Faulhaber
12:06 PM Database Feature #2231: LockType error processing
Attached update vmn_upd20140331a.zip.
Passed cases:...
Vadim Nebogatov
04:07 AM Base Language Feature #1608: implement full appserver support (from 4GL clients only)
0326c.zip was committed to bzr rev 10502. Constantin Asofiei

03/30/2014

04:11 PM Database Feature #2276: create a work queue of PatternEngine instances for runtime conversion tasks
Today, we instantiate multiple @PatternEngine@ instances to perform the various stages of runtime conversion tasks fo... Eric Faulhaber
04:00 PM Database Feature #2276 (Closed): create a work queue of PatternEngine instances for runtime conversion tasks
Eric Faulhaber
04:06 PM Database Feature #2231: LockType error processing
I have selected the second option suggested in note 1.
FIND- and GET- methods tested with wrong lock and nowait v...
Vadim Nebogatov
03:57 PM Database Feature #2275: cache of runtime-converted, dynamic queries and temp-tables
As I'm writing this, it's becoming clear that the query cache and temp-table cache probably need to implemented toget... Eric Faulhaber
03:43 PM Database Feature #2275 (Closed): cache of runtime-converted, dynamic queries and temp-tables
Eric Faulhaber
03:46 PM User Interface Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects)
Here is the next update with the following changes.
# I added forced view at the start of @downWorker@ method and it...
Vadim Gindin
03:38 PM Database Feature #2274: improve performance of new database features
In doing some basic profiling of the slow code, it is apparent the most egregious performance problems are with the a... Eric Faulhaber
02:45 PM Database Feature #2274: improve performance of new database features
Early testing of customer code which makes heavy use of some of the newly developed database features (particularly t... Eric Faulhaber
02:34 PM Database Feature #2274 (Closed): improve performance of new database features
Eric Faulhaber
03:08 PM Database Feature #2134 (WIP): configurable denormalization of extent fields into individual fields in sche...
In order to call this task complete, we need some documentation on how the new feature is used. Please add a history ... Eric Faulhaber
02:56 PM Database Feature #2207 (WIP): Remaining issues for dynamic buffers and dynamic tables
Eric Faulhaber
02:52 PM Database Feature #2235 (Closed): fix deployment issues related to dynamic database conversion resources
Eric Faulhaber
07:23 AM Database Feature #2235 (Review): fix deployment issues related to dynamic database conversion resources
svl_upd20140329a.zip was committed to bzr rev 10501. Stanislav Lomany
08:32 PM Base Language Bug #2133: fix precision for decimal, dynamic-extent variables
Constantin Asofiei wrote:
> This one I think requires a conversion change: @integer[] j = extj.getVariable(2);@ need...
Hynek Cihlar

03/29/2014

06:55 PM Database Feature #2235: fix deployment issues related to dynamic database conversion resources
Just for the case I've changed file separator to \ and run my usual testcase - works OK, so most likely it really doe... Stanislav Lomany
06:06 PM Database Feature #2235: fix deployment issues related to dynamic database conversion resources
Stanislav Lomany wrote:
> About @p2j.cfg.xml.{platform_identifier}@: I'm just curious - at what point we are referen...
Eric Faulhaber
06:00 PM Database Feature #2235: fix deployment issues related to dynamic database conversion resources
Code review 20140329a:
Looks good and fixes the issue. Please run conversion regression only and commit if it passes.
Eric Faulhaber
05:12 PM Database Feature #2235: fix deployment issues related to dynamic database conversion resources
About @registry.xml@: @Configuration@ class keeps absolute paths to configuration files, so if we want to load additi... Stanislav Lomany
04:09 PM Database Feature #2235 (WIP): fix deployment issues related to dynamic database conversion resources
Fix for review for issue in note 28. Stanislav Lomany
11:43 PM Database Feature #2235: fix deployment issues related to dynamic database conversion resources
I tried to run with this update applied and I found a regression. In @DynamicQueryHelper.loadPermanentSchemas@, you r... Eric Faulhaber
06:53 PM Database Feature #2273: address remaining limitations of SQL Server needed to support legacy 4GL behavior
Some more thoughts on the challenges of the computed columns approach...
* If done instead of the hard-coded length ...
Eric Faulhaber
06:35 PM Database Feature #2273: address remaining limitations of SQL Server needed to support legacy 4GL behavior
Perhaps a more general-purpose approach is to use computed columns in indexes in the place of converted @character@ f... Eric Faulhaber
04:57 PM Database Feature #2273: address remaining limitations of SQL Server needed to support legacy 4GL behavior
One possible approach is to provide additional inputs into the conversion process to properly limit the maximum lengt... Eric Faulhaber
04:55 PM Database Feature #2273: address remaining limitations of SQL Server needed to support legacy 4GL behavior
Please review the entire history log of #2141. While in the end we were able to generate DDL for a SQL Server schema,... Eric Faulhaber
04:03 PM Database Feature #2273 (Closed): address remaining limitations of SQL Server needed to support legacy 4GL ...
Eric Faulhaber
10:21 AM Database Feature #2134: configurable denormalization of extent fields into individual fields in schema con...
Attached update is passed regression and distributed. Vadim Nebogatov

03/28/2014

07:24 PM Database Feature #2134: configurable denormalization of extent fields into individual fields in schema con...
tc_job_002 is expected to fail in step 40. The other two failing tests each passed in one of your runs, so you can co... Eric Faulhaber
06:29 PM Database Feature #2134: configurable denormalization of extent fields into individual fields in schema con...
Next regression completed. Again 2 tests failed. Second test is another one but with the same error:... Vadim Nebogatov
06:32 AM Database Feature #2134: configurable denormalization of extent fields into individual fields in schema con...
I have attached vmn_upd20140328a.zip after some fixes during regression. Latest regression results: 2 tests failed.
...
Vadim Nebogatov
04:26 PM Base Language Feature #1634: implement full native library (.so or DLL) support
The update 0328a fixes the conversion issue I've found and works OK with and without another P2J server running simul... Eugenie Lyzenko
01:41 PM Base Language Feature #1634: implement full native library (.so or DLL) support
The fix for conversion issue in @EnvironmentOps@. Based on the fact the @SessionManager.get()@ returns not null when ... Eugenie Lyzenko
01:01 PM Base Language Feature #1634: implement full native library (.so or DLL) support
I have found the regression with @EnvironmentOps@ trying MAJIC conversion on my local system in Linux with last updat... Eugenie Lyzenko
11:04 PM Base Language Feature #1634: implement full native library (.so or DLL) support
> @EnvironmentOps@ is designed only for server side usage. We should never try to use it on the client. Please use th... Eugenie Lyzenko
04:24 PM Base Language Bug #2133: fix precision for decimal, dynamic-extent variables
Constantin Asofiei wrote:
> Go ahead and fix this in @ControlFlowOps$InternalEntryCaller.valid@.
For the function...
Hynek Cihlar
04:12 PM Database Feature #2235: fix deployment issues related to dynamic database conversion resources
One thing I just realized will be an issue: it is possible to run the static conversion of a project on one platform ... Eric Faulhaber
09:27 AM Database Feature #2235: fix deployment issues related to dynamic database conversion resources
Please don't remove archives unless they have been uploaded mistakenly (and have a proper replacement). For example,... Greg Shah
07:00 AM Database Feature #2235: fix deployment issues related to dynamic database conversion resources
Committed to bzr rev 10498. Stanislav Lomany
01:50 PM User Interface Feature #1811: implement the AJAX client driver
This archive contains my later changes for interactive process implementation.
It is not the final release is only a...
Marius Gligor
12:37 PM Database Feature #2143 (Closed): prototype IKVM solution for Java UDFs compiled to CIL assemblies and load...
Eric Faulhaber

03/27/2014

05:12 PM User Interface Feature #1811: implement the AJAX client driver
Code Review 0326a - Part 2
I have finished going through all the code. It is really impressive.
4. It seems ...
Greg Shah
04:22 PM Database Bug #2222: WRITE event triggered too early
It seems that I have implemented wrong the new write to database event.
My initial approach and the fix for it was a...
Ovidiu Maxiniuc
02:43 PM User Interface Feature #2252: implement GUI client support
This is an interesting comment in the Colors and Fonts chapter of the Programming Interfaces book:
> In Windows, t...
Greg Shah
11:00 AM User Interface Feature #2252: implement GUI client support
> Do you mean font names or ordinals? If ordinals, see below.
I mean both, really.
I understand that the configurat...
Greg Shah
11:07 AM Base Language Feature #1634: implement full native library (.so or DLL) support
> And I think we can do this because the value of the propathOverride is only per the server instance.
No, this is...
Greg Shah
03:42 AM Database Feature #2134: configurable denormalization of extent fields into individual fields in schema con...
I have attached latest source code changes vmn_upd20140327a.zip after some fixes during regression. Regression starte... Vadim Nebogatov

03/26/2014

06:25 PM User Interface Feature #2252: implement GUI client support
Greg Shah wrote:
> * How does the 4GL determine the list of fonts that are available?
Do you mean font names or ord...
Constantin Asofiei
05:19 PM User Interface Feature #1811: implement the AJAX client driver
Code Review 0326a - Part 1
I am splitting this into multiple parts because I don't have time to finish the entire ...
Greg Shah
03:55 PM User Interface Feature #1811: implement the AJAX client driver
Please document how interactive child process support works on Windows (in the 4GL). When you are running a ChUI 4GL... Greg Shah
02:29 PM User Interface Feature #1811: implement the AJAX client driver
I implemented the interactive process for Swing ChUI client.
When a Linux OS command is executed from the converted ...
Marius Gligor
05:00 PM Base Language Feature #1634: implement full native library (.so or DLL) support
> No. We must be able to customize this value. That means calling "up" to the server to read a value from the directo... Eugenie Lyzenko
03:54 PM Base Language Feature #1634: implement full native library (.so or DLL) support
> For the point you noted the EnvironmentOps.getVersion().toStringMessage() can be replaced with string "10.2B". Is i... Greg Shah
02:47 PM Base Language Feature #1634: implement full native library (.so or DLL) support
> The problem is this code in Registry.java:
>
> ...
Eugenie Lyzenko
12:14 PM Base Language Feature #1634: implement full native library (.so or DLL) support
The problem is this code in Registry.java:... Greg Shah
10:33 AM Base Language Feature #1634: implement full native library (.so or DLL) support
For note #1
The reason of this change is I've found if we just use as expected to be working:...
Eugenie Lyzenko
09:51 AM Base Language Feature #1634: implement full native library (.so or DLL) support
Code Review 0326a
Everything here is much better. It is very close.
1. The changes in @EnvironmentOps.fixupProp...
Greg Shah
08:37 AM Base Language Feature #1634: implement full native library (.so or DLL) support
The update for review contains the changes for previous notes. Note I have changed @ThinClient@ to do not use @Platfo... Eugenie Lyzenko
04:48 PM Base Language Bug #2133: fix precision for decimal, dynamic-extent variables
Hynek Cihlar wrote:
> In Progress, function/procedure fixed-extent parameter's components are initialized to unknown...
Constantin Asofiei
04:40 PM Base Language Bug #2133: fix precision for decimal, dynamic-extent variables
Hynek Cihlar wrote:
> Constantin Asofiei wrote:
> > Hynek Cihlar wrote:
> > > The following code sample causes the...
Constantin Asofiei
04:21 PM Base Language Bug #2133: fix precision for decimal, dynamic-extent variables
Constantin Asofiei wrote:
> Hynek Cihlar wrote:
> > The following code sample causes the error message 'Calling pro...
Hynek Cihlar
04:15 PM Base Language Bug #2133: fix precision for decimal, dynamic-extent variables
Hynek Cihlar wrote:
> The following code sample causes the error message 'Calling procedure /home/hc/p34141_Untitled...
Constantin Asofiei
04:08 PM Base Language Bug #2133: fix precision for decimal, dynamic-extent variables
The following code sample causes the error message 'Calling procedure /home/hc/p34141_Untitled8.ped cannot input an i... Hynek Cihlar
03:51 PM Base Language Bug #2133: fix precision for decimal, dynamic-extent variables
In Progress, function/procedure fixed-extent parameter's components are initialized to unknown values when an unfixed... Hynek Cihlar
03:09 PM Base Language Bug #2133: fix precision for decimal, dynamic-extent variables
The converted code doesn't give the correct error message when assigning a fixed array to an indeterminate and alread... Hynek Cihlar
10:01 AM Base Language Bug #2133: fix precision for decimal, dynamic-extent variables
I have finished a release-candidate implementation for the decimal precision. I am testing it and also looking for ed... Hynek Cihlar
04:03 PM Base Language Feature #1608: implement full appserver support (from 4GL clients only)
Code Review 0326c
The changes look good. They can be runtime regression tested.
Greg Shah
01:54 PM Base Language Feature #1608: implement full appserver support (from 4GL clients only)
Fixes for note 142 (all persistent procedures need to be deleted by the Agent which created them) and a bug in sessio... Constantin Asofiei
03:49 PM Conversion Tools Feature #2251 (Closed): improve the call graph generation
Greg Shah
02:23 PM Conversion Tools Feature #2251 (Review): improve the call graph generation
Constantin Asofiei
02:23 PM Conversion Tools Feature #2251: improve the call graph generation
Branch revision 10518 was committed to the 10496/10497, both on trunk master on devsrv01 and filesrv01. Constantin Asofiei
02:34 PM User Interface Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects)
Vadim Gindin wrote:
> # Yes, Constantin. I really skipped this case. In your example @dynamicDown=0@ indeed. The pro...
Constantin Asofiei
02:10 PM User Interface Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects)
Vadim Gindin wrote:
> I forgot to add, that your short test case shows the problem @dynamicDown=0@ in another aspect...
Constantin Asofiei
01:23 PM Base Language Bug #2265 (Closed): Extent initializer compiles fine on scalar variable definition
Greg Shah
01:16 PM Base Language Bug #2265: Extent initializer compiles fine on scalar variable definition
I see now. Can you then close the issue? Hynek Cihlar
01:12 PM Base Language Bug #2265: Extent initializer compiles fine on scalar variable definition
Hynek Cihlar wrote:
> I probably wasn't descriptive enough. The code sample doesn't compile in Progress, it gives "T...
Constantin Asofiei
12:00 PM Base Language Bug #2265: Extent initializer compiles fine on scalar variable definition
I probably wasn't descriptive enough. The code sample doesn't compile in Progress, it gives "Too many initial values ... Hynek Cihlar
10:44 AM Base Language Bug #2265: Extent initializer compiles fine on scalar variable definition
Hynek, P2J will always convert valid 4GL code, which can compile in Progress. We do not want and will not start hunti... Constantin Asofiei
10:39 AM Base Language Bug #2265: Extent initializer compiles fine on scalar variable definition
The following code snippet compiles without errors producing invalid Java code.... Hynek Cihlar
10:34 AM Base Language Bug #2265 (Closed): Extent initializer compiles fine on scalar variable definition
Hynek Cihlar

03/25/2014

06:08 PM User Interface Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects)
I forgot to add, that your short test case shows the problem @dynamicDown=0@ in another aspect. This wrong behavior l... Vadim Gindin
02:47 PM User Interface Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects)
# Yes, Constantin. I really skipped this case. In your example @dynamicDown=0@ indeed. The problem appears when @disp... Vadim Gindin
04:47 AM User Interface Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects)
Vadim, about 0324a.zip: @GenericFrame@ and other files don't have the proper history number (is the same as the previ... Constantin Asofiei
05:02 PM Base Language Feature #1634: implement full native library (.so or DLL) support
Code Review 0325a
1. The @isUnderWindowsFamily()@ does not need to be implemented on the client side. The @getOpe...
Greg Shah
11:49 AM Base Language Feature #1634: implement full native library (.so or DLL) support
The update for review with reworked OS detection tools.
The questions to clarify:
1. @EnvironmentOps@ is the clas...
Eugenie Lyzenko
04:15 PM Conversion Tools Feature #2251: improve the call graph generation
> Regarding note 97: I think bzr merge should do the trick, to merge the branch into the trunk
Yes, that was my pl...
Greg Shah
02:12 PM Conversion Tools Feature #2251: improve the call graph generation
The update passed runtime and conversion testing (both server and MAJIC code).
Regarding note 97: I think @bzr mer...
Constantin Asofiei
03:49 AM Conversion Tools Feature #2251: improve the call graph generation
Greg Shah wrote:
> > BTW, to "release" a branch to the trunk, is there another way beside just copying the branch co...
Constantin Asofiei
04:10 PM User Interface Feature #1811: implement the AJAX client driver
> I'm struggle to understand the current implementation on interactive process for native ChUI client.
We don't n...
Greg Shah
06:02 AM User Interface Feature #1811: implement the AJAX client driver
Add code to synchronize with child process exit. Marius Gligor
03:05 PM Database Feature #2235: fix deployment issues related to dynamic database conversion resources
> All looks good except the change to @XmlFilePlugin@. This class is meant to be for generic AST processing and shoul... Stanislav Lomany
11:20 AM Database Feature #2235: fix deployment issues related to dynamic database conversion resources
Code review 20140325a:
All looks good except the change to @XmlFilePlugin@. This class is meant to be for generic ...
Eric Faulhaber
10:40 AM Database Feature #2235: fix deployment issues related to dynamic database conversion resources
Removed "development" mode. Stanislav Lomany
02:11 PM Base Language Bug #2133: fix precision for decimal, dynamic-extent variables
Hynek, the changes look good. How is the decimal precision working? Constantin Asofiei
11:47 AM Base Language Bug #2133: fix precision for decimal, dynamic-extent variables
Attached are changes based on the feedback from last review - @isExpressionOfExtentType@ was removed. I submitted the... Hynek Cihlar

03/24/2014

07:04 PM User Interface Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects)
Constantin Asofiei wrote:
> ..
> # check the shared frame cases: I suspect the current-iteration will be inherited ...
Vadim Gindin
05:53 PM User Interface Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects)
I've fixed almost all your remarks. Here are to moments:
# GenericFrame imports couldn't become simpler because of p...
Vadim Gindin
09:15 AM User Interface Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects)
Vadim, good work getting the algorithms implemented. See bellow for the code review for 0322a.zip and the next steps... Constantin Asofiei
03:26 PM Conversion Tools Feature #2251: improve the call graph generation
> BTW, to "release" a branch to the trunk, is there another way beside just copying the branch content (without the .... Greg Shah
02:21 PM Conversion Tools Feature #2251: improve the call graph generation
See the branch 10517 revision (which was rebased) for the latest changes (some doc changes and a minor fix). This is ... Constantin Asofiei
06:44 AM Conversion Tools Feature #2251: improve the call graph generation
Greg Shah wrote:
> 1. What is your general sense about the performance? Do you feel it is "good", "bad" or somethin...
Constantin Asofiei
03:24 PM User Interface Feature #2252: implement GUI client support
Some initial thoughts based on reviewing basic 4GL GUI examples:
1. Fonts
* By default the GUI uses the Windows...
Greg Shah
02:58 PM User Interface Feature #2252: implement GUI client support
The following is some early planning that was done (at my request) by Sergey Yevtushenko in 2011:
> -------- Origi...
Greg Shah
02:53 PM User Interface Feature #2252: implement GUI client support
Upon additional consideration of our implementation approaches in note 2, I think it makes the most sense to implemen... Greg Shah
02:44 PM User Interface Feature #2252: implement GUI client support
We will be implementing configurable control over all fonts, colors and other standard GUI configuration via our dire... Greg Shah
02:39 PM User Interface Feature #2252: implement GUI client support
Greg Shah wrote:
> We will NOT be implementing using a native control approach. This means we will not support the ...
Constantin Asofiei
02:32 PM User Interface Feature #2252: implement GUI client support
> I couldn't find a way to make the created windows modal. So, this allows multiple windows to be active, with all th... Greg Shah
02:30 PM User Interface Feature #2252: implement GUI client support
It is my understanding that all Progress GUI widgets have a backing native Windows control as the implementation. Th... Greg Shah
01:53 PM User Interface Feature #2252: implement GUI client support
Some initial findings about how 4GL implements the GUI interfaces:
# the @MESSAGE ... VIEW-AS ALERT-BOX@ statements ...
Constantin Asofiei
02:23 PM User Interface Feature #2264 (Closed): analyze how the GUI interface is implemented in 4GL
Constantin Asofiei
01:21 PM User Interface Feature #1811: implement the AJAX client driver
I fixed a minor bug when using colors.
We have to add 1 to FG and BG because according to the current P2J implement...
Marius Gligor
12:33 PM User Interface Feature #1811: implement the AJAX client driver
Here is the RC (release candidate) of VT-100 emulator. It is an implementation of DEC VT 100 video terminal specifica... Marius Gligor
12:27 PM Database Feature #2235: fix deployment issues related to dynamic database conversion resources
Eric, I recently met the rules loading code and it uses "non-development" approach, so, considering this and overall ... Stanislav Lomany
11:46 AM Database Feature #2235: fix deployment issues related to dynamic database conversion resources
Code review 20140324a/b:
Changes look good. I would like you to still please add a comment to @SchemaLoader.loadAs...
Eric Faulhaber
04:59 AM Database Feature #2235: fix deployment issues related to dynamic database conversion resources
Removed tabs. Stanislav Lomany
04:58 AM Database Feature #2235: fix deployment issues related to dynamic database conversion resources
Copies only specific rules. Removed tabs. Removed loading of schema-triggers.xml in runtime mode.
Would you like me ...
Stanislav Lomany
12:15 PM Base Language Feature #1634: implement full native library (.so or DLL) support
For efficiency, please only call down to the client once per session. Save off the value (in the server side) the fir... Greg Shah
12:12 PM Base Language Feature #1634: implement full native library (.so or DLL) support
No, we need to fix @EnvironmentOps.getOperatingSystem()@ and @EnvironmentOps.getPathSeparator()@ to query the client ... Greg Shah
11:55 AM Base Language Feature #1634: implement full native library (.so or DLL) support
There is still an issue in @SourceNameMapper.convertName()@ with the usage of @PlatformHelper.isUnderWindowsFamily()@... Eugenie Lyzenko
11:34 AM Base Language Feature #1634: implement full native library (.so or DLL) support
There is still an issue in SourceNameMapper.convertName() with the usage of PlatformHelper.isUnderWindowsFamily(). T... Greg Shah
11:28 AM Base Language Feature #1634: implement full native library (.so or DLL) support
> Eugenie, the changes in 0324a.zip look good.
Meaning I can run conversion and runtime regression testing for thi...
Eugenie Lyzenko
10:41 AM Base Language Feature #1634: implement full native library (.so or DLL) support
Eugenie, the changes in 0324a.zip look good. Constantin Asofiei
09:37 AM Base Language Feature #1634: implement full native library (.so or DLL) support
The update for your review contains clean up for @SourceNameMap@ class for @canonicalize()@ usage and javadoc small c... Eugenie Lyzenko
08:57 AM Base Language Feature #1634: implement full native library (.so or DLL) support
Eugenie Lyzenko wrote:
> Or we do not need any additional processing, just call @p2jMap.get(pname);@?
This one is c...
Constantin Asofiei
08:49 AM Base Language Feature #1634: implement full native library (.so or DLL) support
> When I changed the FILE-NAME and NAME implementation for external procedures, I discovered that these attributes an... Eugenie Lyzenko
07:36 AM Base Language Feature #1634: implement full native library (.so or DLL) support
Eugenie Lyzenko wrote:
> I do not understand why we need the changes here? If canonicalize() now works as before any...
Constantin Asofiei

03/22/2014

05:53 PM User Interface Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects)
Well It happens! I finished the implementation. At this moment all steps are supported. This implementation passed al... Vadim Gindin
02:53 PM Database Feature #2207: Remaining issues for dynamic buffers and dynamic tables
Committed to bzr revision 10495. Stanislav Lomany
02:34 PM Database Feature #2207: Remaining issues for dynamic buffers and dynamic tables
> Stas, please have a look at Ovidiu's om_upd20140213a.zip update in #2222. It is not necessarily current with the la... Stanislav Lomany

03/21/2014

01:27 PM Conversion Tools Feature #2251: improve the call graph generation
I saw your note about the performance metrics in #2260. The numbers seem pretty good for processing such a large pro... Greg Shah
01:24 PM Conversion Tools Feature #2251: improve the call graph generation
Code Review branch rev 10514
I am good with the changes. If you still think it is finished, go ahead with regress...
Greg Shah
12:40 PM Conversion Tools Feature #2251: improve the call graph generation
Branch rev 10514 adds the "-u" argument for CallGraphGenerator, which uses the passed filename list and all ambiguous... Constantin Asofiei
10:17 AM Conversion Tools Feature #2251: improve the call graph generation
Greg Shah wrote:
> One question: it looks to me like each call-graph run is fresh and we don't support incremental c...
Constantin Asofiei
09:20 AM Conversion Tools Feature #2251: improve the call graph generation
Code Review branch rev 10513
Everything looks good.
One question: it looks to me like each call-graph run is fr...
Greg Shah
08:44 AM Conversion Tools Feature #2251: improve the call graph generation
> I think I'm missing some index configuration, as CallGraphWorker.findNodeById doesn't look like it uses an index (i... Constantin Asofiei
08:40 AM Conversion Tools Feature #2251: improve the call graph generation
Code Review branch rev 10512
Everything looks good, except that the ProgressPatternWorker change is not needed. @...
Greg Shah
11:47 AM Base Language Feature #1634: implement full native library (.so or DLL) support
The drop for review removes OS dependency in @SourceNameMapper@. Now the absolute filenames handles the same way for ... Eugenie Lyzenko
11:01 AM Base Language Feature #1634: implement full native library (.so or DLL) support
Greg Shah wrote:
> 1. In SourceNameMapper.convertName(), I think there may be a problem with the usage of @PlatformH...
Constantin Asofiei
10:46 AM Base Language Feature #1634: implement full native library (.so or DLL) support
> 2. In character.progressToJavaString(), shouldn't this code:
>
> ...
Eugenie Lyzenko
09:16 AM Base Language Feature #1634: implement full native library (.so or DLL) support
Code Review 0320a
I will let Constantin review and comment on the core logic changes in SourceNameMapper.
1. In...
Greg Shah
10:25 PM Base Language Feature #1634: implement full native library (.so or DLL) support
The update for review contains modified @SourceNameMapper@. The runtime processing of the program name different case... Eugenie Lyzenko
08:18 PM Base Language Feature #1634: implement full native library (.so or DLL) support
> Thus, we can merge the logic from @canonicalize@ into @convertName@.
And what in this plan @canonicalize()@ shou...
Eugenie Lyzenko
06:23 AM Database Feature #2134: configurable denormalization of extent fields into individual fields in schema con...
I have attached some more tests vmn_upd20140320b.zip with WHERE clause support.
Vadim Nebogatov

03/20/2014

06:19 PM Base Language Feature #1634: implement full native library (.so or DLL) support
> For these examples, and the ones on note 161, please post how the converted result needs to look on windows and how... Eugenie Lyzenko
04:23 PM Base Language Feature #1634: implement full native library (.so or DLL) support
Eugenie Lyzenko wrote:
> Like in these examples:
For these examples, and the ones on note 161, please post how the ...
Constantin Asofiei
03:35 PM Base Language Feature #1634: implement full native library (.so or DLL) support
BTW. The conversion of the MAJIC code with and without the changes from this update shows identical conversion result... Eugenie Lyzenko
07:32 AM Base Language Feature #1634: implement full native library (.so or DLL) support
> I don't understand why you need to call progressToJavaString twice, once in progress.g and once in control_flow.rul... Eugenie Lyzenko
06:53 AM Base Language Feature #1634: implement full native library (.so or DLL) support
Eugenie, about 0318a.zip:
* @control_flow.rules@ - I don't understand what this code tries to do:...
Constantin Asofiei
05:04 PM Conversion Tools Feature #2251: improve the call graph generation
Branch rev 10512 contains:
- the fix for the FILE-NAME preproc var
- some misc fixes
- some performance improvemen...
Constantin Asofiei
09:30 AM Conversion Tools Feature #2251: improve the call graph generation
OK, thanks for clarifying this. Greg Shah
09:02 AM Conversion Tools Feature #2251: improve the call graph generation
Greg Shah wrote:
> path/to/first/filename.p
> path/to/second/filename.p
> other/path/filename.p
>
> A reverse s...
Constantin Asofiei
08:56 AM Conversion Tools Feature #2251: improve the call graph generation
My concern is that this algorithm can match multiple filenames in the project, making the results ambiguous.
Assum...
Greg Shah
08:25 AM Conversion Tools Feature #2251: improve the call graph generation
Greg Shah wrote:
> 2. I'm a little worried that the @CallGraphWorker.resolveExternalPrograms()@ approach of using th...
Constantin Asofiei
04:08 PM Database Feature #2235: fix deployment issues related to dynamic database conversion resources
Eric Faulhaber wrote:
> The less we load per @PatternEngine@ instance to do this specific runtime job, the better.
...
Eric Faulhaber
03:59 PM Database Feature #2235: fix deployment issues related to dynamic database conversion resources
Stanislav Lomany wrote:
> > * In build.xml, please restrict the rulesets copied into the jar to the minimum needed f...
Eric Faulhaber
03:32 PM Database Feature #2235: fix deployment issues related to dynamic database conversion resources
> * In build.xml, please restrict the rulesets copied into the jar to the minimum needed for the dynamic database con... Stanislav Lomany
02:42 PM Database Feature #2235: fix deployment issues related to dynamic database conversion resources
Eric Faulhaber wrote:
> I suspect we don't ever need to load schema-triggers.xml at runtime for the dynamic temp-tabl...
Ovidiu Maxiniuc
02:41 PM Database Feature #2235: fix deployment issues related to dynamic database conversion resources
Eric Faulhaber wrote:
> So, I notice you are not copying name_map.cache into the testcases.jar (and you had related ...
Eric Faulhaber
02:39 PM Database Feature #2235: fix deployment issues related to dynamic database conversion resources
Code review 20140320b:
The content looks good, but please replace the hard tabs with soft tabs in build.xml before...
Eric Faulhaber
02:29 PM Database Feature #2235: fix deployment issues related to dynamic database conversion resources
Code review 20140320a:
* In build.xml, please restrict the rulesets copied into the jar to the minimum needed for th...
Eric Faulhaber
01:34 PM Database Feature #2235: fix deployment issues related to dynamic database conversion resources
Update (testcases project part). Stanislav Lomany
12:46 PM Database Feature #2235: fix deployment issues related to dynamic database conversion resources
Update for review (P2J part). Stanislav Lomany
02:07 PM Database Feature #1661: support case-sensitive fields in indexes
> > * Looks like the dynamic temp-tables are missing the computed columns at all (especially the character columns th... Stanislav Lomany
01:53 PM Database Feature #1661: support case-sensitive fields in indexes
Ovidiu Maxiniuc wrote:
> At this moment, we cannot tell if a field is case sensitive or not only by analyzing its na...
Eric Faulhaber
11:32 AM Conversion Tools Feature #1519: report improvements
A report listing hard coded absolute filenames would be useful. Greg Shah
11:32 AM Conversion Tools Feature #1519: report improvements
Dynamic extent and extent parameter reports are already done (they were done before now).
The incompatible program...
Greg Shah
08:53 AM Conversion Tools Feature #1512 (Closed): separate match processing into a single pass of all report filters per file
Greg Shah
08:50 AM Conversion Tools Feature #1520: design gap analysis approach
We want to make the marking as data driven as possible. This will allow rapid enhancement of the facilities without ... Greg Shah
10:48 PM Database Feature #2207: Remaining issues for dynamic buffers and dynamic tables
Stas, the changes you were waiting on based on my note 8 above have been committed to bzr rev. 10493, and there is a ... Eric Faulhaber
10:43 PM Database Bug #2261: improve server startup performance
The 0318a update has passed regression testing and is committed to bzr rev. 10494.
The performance improvement is ...
Eric Faulhaber

03/19/2014

06:46 PM User Interface Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects)
You are right. I made needed corrections and now it works for case "-1". At this moment I'm fixing another border cas... Vadim Gindin
05:11 PM Conversion Tools Feature #2251: improve the call graph generation
Code Review branch rev 10510
1. Please add a comment into the init-rules of post_parse_fixups.xml explaining that ...
Greg Shah
02:36 PM Conversion Tools Feature #2251: improve the call graph generation
Rev 10510 contains:
* fix for the @RUN <internal-proc>@ reported as missing external procedures.
* fix for @RUN por...
Constantin Asofiei
02:16 PM Conversion Tools Feature #2251: improve the call graph generation
There is a way to get rid of the non-indexed suffix search, when looking for external programs: keep, alongside the @... Constantin Asofiei
03:54 PM Database Bug #2222: WRITE event triggered too early
Code from om_upd20140213a.zip merged with bzr rev. 10493 uploaded.
The simple UNDO issue is solved in the update.
...
Ovidiu Maxiniuc
12:26 PM Conversion Tools Bug #2262: ON statement preprocessing and parsing issues related to unmatched quotes or tilde
This testcase (checked in as on_stmt_event_as_single_or_double_quote.p) shows the issues:... Greg Shah
11:13 AM Conversion Tools Bug #2262 (New): ON statement preprocessing and parsing issues related to unmatched quotes or tilde
Greg Shah

03/18/2014

04:48 PM Conversion Tools Feature #2251: improve the call graph generation
Greg Shah wrote:
> I think it is best to strip off the .dll from the library names (if present) and let them all cas...
Constantin Asofiei
04:36 PM Conversion Tools Feature #2251: improve the call graph generation
> As a side note, there are some PROCEDURE ... EXTERNAL cases where the library name is defined as i.e. kernel32, wit... Greg Shah
04:32 PM Conversion Tools Feature #2251: improve the call graph generation
Greg Shah wrote:
> 1. What is the effort involved to add all unreferenced include files to the dead files list?
Thi...
Constantin Asofiei
04:28 PM Conversion Tools Feature #2251: improve the call graph generation
Code Review branch rev 10507
1. What is the effort involved to add all unreferenced include files to the dead file...
Greg Shah
04:13 PM Conversion Tools Feature #2251: improve the call graph generation
After analysing the report listings for the server sources, I have these cases which are reported wrong:
# @RUN <int...
Constantin Asofiei
01:36 PM Conversion Tools Feature #2251: improve the call graph generation
rev 10507 contains the changes from note 69's review, the PatternEngine changes in note 68 plus:
- licence files for...
Constantin Asofiei
09:38 AM Conversion Tools Feature #2251: improve the call graph generation
Greg Shah wrote:
> By the way, the rebasing approach that you took looks reasonable. How hard did you find it to us...
Constantin Asofiei
09:24 AM Conversion Tools Feature #2251: improve the call graph generation
> The proposed approach for this plugin is:
Very good.
Greg Shah
09:22 AM Conversion Tools Feature #2251: improve the call graph generation
By the way, the rebasing approach that you took looks reasonable. How hard did you find it to use? Greg Shah
09:21 AM Conversion Tools Feature #2251: improve the call graph generation
Code Review branch rev 10504
1. In the native_process function, please add support for the undocumented @kw_ctos@ ...
Greg Shah
08:42 AM Conversion Tools Feature #2251: improve the call graph generation
Greg Shah wrote:
> > I don't think we need to rely on physical .ast files for the initial list of graph nodes. To d...
Constantin Asofiei
07:30 AM Conversion Tools Feature #2251: improve the call graph generation
Greg Shah wrote:
> > BTW, do you have a rebase script, so I can rebase?
>
> Not yet. Please go through the proce...
Constantin Asofiei
04:47 PM Database Feature #1661: support case-sensitive fields in indexes
At this moment, we cannot tell if a field is case sensitive or not only by analyzing its name (as signature of isCas... Ovidiu Maxiniuc
04:04 PM Database Bug #2261: improve server startup performance
Replaced with a version that does better error handling when retrieving index metadata. Eric Faulhaber
02:24 PM Database Bug #2261: improve server startup performance
The attached update implements the plan in note 3 above. Empirical testing show it trims ~33% off the server startup ... Eric Faulhaber
03:14 PM Database Feature #2134: configurable denormalization of extent fields into individual fields in schema con...
I have attached next update vmn_upd20140318a.zip with WHERE clause support. Update corresponds to latest bzr revision... Vadim Nebogatov
02:37 AM Database Feature #2134: configurable denormalization of extent fields into individual fields in schema con...
Eric Faulhaber wrote:
> Vadim Nebogatov wrote:
> > Unfortunately I missed your update...
> Please maintain this fi...
Vadim Nebogatov
01:59 PM Base Language Bug #2133: fix precision for decimal, dynamic-extent variables
Hynek Cihlar wrote:
> Unless you are against it, I will keep the @isExpressionOfExtentType@ method even though the i...
Constantin Asofiei
11:02 AM Base Language Bug #2133: fix precision for decimal, dynamic-extent variables
Constantin Asofiei wrote:
> Hynek, about 0316a.zip. The implementation of @isExpressionOfExtentType@ should check f...
Hynek Cihlar
04:09 AM Base Language Bug #2133: fix precision for decimal, dynamic-extent variables
Hynek, about 0316a.zip. The implementation of @isExpressionOfExtentType@ should check for @extent@ annotations, not ... Constantin Asofiei
01:53 PM Base Language Feature #1634: implement full native library (.so or DLL) support
The update fixes the usual string conversion in Windows. Now we have properly converted... Eugenie Lyzenko
12:51 PM User Interface Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects)
OK, I guess this test tries to predict which field-group will be next, after a UP/DOWN call? I think your problem is ... Constantin Asofiei
12:20 PM User Interface Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects)
Constantin Asofiei wrote:
> ..
> I need the exact setup of the bp_mixedupdow1.p used to capture the intermediate sc...
Vadim Gindin
05:10 AM User Interface Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects)
Vadim, when posting test scenarios, please make sure the bzr test is setup exactly the same way you used to produce t... Constantin Asofiei

03/17/2014

07:24 PM Database Bug #2261: improve server startup performance
We have redundant index metadata queries coming from @DMOIndex$DMOMetadata.collectIndexData@ and @DirtyTempTableHelpe... Eric Faulhaber
05:38 PM Database Bug #2261: improve server startup performance
I've done a little bit of research and trial and error testing. I've found that unfortunately, the JDBC DatabaseMetaD... Eric Faulhaber
04:45 PM Database Bug #2261: improve server startup performance
Startup of the server for an application with a lot of permanent tables is very slow. While this probably is not a bi... Eric Faulhaber
04:39 PM Database Bug #2261 (New): improve server startup performance
Eric Faulhaber
07:03 PM Database Feature #2134: configurable denormalization of extent fields into individual fields in schema con...
Vadim Nebogatov wrote:
> Unfortunately I missed your update...
Please maintain this fix with the rest of your chang...
Eric Faulhaber
05:11 PM Database Feature #2134: configurable denormalization of extent fields into individual fields in schema con...
Eric Faulhaber wrote:
> Vadim Nebogatov wrote:
> > Concerning bug in @where_clause_normalize.rules@ (note 61).
> ...
Vadim Nebogatov
11:20 AM Database Feature #2134: configurable denormalization of extent fields into individual fields in schema con...
Vadim Nebogatov wrote:
> Concerning bug in @where_clause_normalize.rules@ (note 61).
>
> Solution would be to ad...
Eric Faulhaber
03:31 AM Database Feature #2134: configurable denormalization of extent fields into individual fields in schema con...
Current problem: denormalized extent fields with constant index in WHERE clause are generated without index but with ... Vadim Nebogatov
04:37 PM Database Feature #2258: retrofit BUFFER-COPY and BUFFER-COMPARE language statement runtime support to use ...
I have checked in my pending changes under bzr rev. 10493. Eric Faulhaber
04:33 PM Database Bug #2222: WRITE event triggered too early
Please merge your update with the latest code in bzr.
Regarding the UNDO problem, do you need to enhance or develo...
Eric Faulhaber
02:51 PM Conversion Tools Feature #2251: improve the call graph generation
In bzr there are these changes:
* Switched to integer token types for call-site-key and node-type.
* Fixed progres...
Constantin Asofiei
11:02 AM Conversion Tools Feature #2251: improve the call graph generation
> If the entire AST structure for an external-procedure is loaded into the DB, the in-DB ASTs can't be used directly ... Greg Shah
10:54 AM Conversion Tools Feature #2251: improve the call graph generation
Code Review branch rev 10494
Except for progress.g, I am fine with the other changes.
I have these questions ab...
Greg Shah
10:10 AM Conversion Tools Feature #2251: improve the call graph generation
Please review the progress.g changes in 10494, they are related to parsing the @CREATE automation-object com-handle-v... Constantin Asofiei
10:05 AM Conversion Tools Feature #2251: improve the call graph generation
Greg Shah wrote:
> > Should I have created graph DB nodes for the call-sites' ASTs, too?
>
> I think so, yes. Th...
Constantin Asofiei
08:26 AM Conversion Tools Feature #2251: improve the call graph generation
> Should I have created graph DB nodes for the call-sites' ASTs, too?
I think so, yes. This would be consistent w...
Greg Shah
08:06 AM Conversion Tools Feature #2251: improve the call graph generation
About mapping the @call-site-key@ string values to token types:
* @includes@: this is to used mark edges with includ...
Constantin Asofiei
03:18 AM Conversion Tools Feature #2251: improve the call graph generation
Greg Shah wrote:
> 1. External targets have a "node-type" but call-sites don't. I prefer the @type@ approach to be ...
Constantin Asofiei
02:40 PM Database Feature #2148 (WIP): enhance prototype to compile p2jpl.jar file with IKVMC into .NET assembly an...
Ovidiu Maxiniuc
02:25 PM User Interface Feature #1811: implement the AJAX client driver
OK, go ahead and write our own vt100 emulation layer, from scratch. Of course, it is OK to look at the other project... Greg Shah
02:16 PM User Interface Feature #1811: implement the AJAX client driver
I didn't found any native library that could be used in our P2J interactive client.
Each application which need a te...
Marius Gligor
11:11 AM User Interface Feature #1811: implement the AJAX client driver
1. I don't know I have to check if such libraries exists.
2. Screen is writen in C and YES he provide also a VT 10...
Marius Gligor
10:37 AM User Interface Feature #1811: implement the AJAX client driver
> The VT 100 emulator could be designed by getting some code from JCTerm project and adapt to our needs.
> Also we c...
Greg Shah
09:52 AM User Interface Feature #1811: implement the AJAX client driver
The attached examples are form projects which implements SSH standalone clients.
Those projects use the same inter...
Marius Gligor

03/16/2014

04:54 PM Base Language Bug #2133: fix precision for decimal, dynamic-extent variables
I am attaching the initial implementation for fixing the @assignMulti@ method. The changes include the modification o... Hynek Cihlar
11:53 AM User Interface Feature #1811: implement the AJAX client driver
> None of the existing Java VT 100 emulators can be used as they are.
Please provide more details.
* What are...
Greg Shah
11:50 AM Conversion Tools Feature #2251: improve the call graph generation
Please do a bzr check-in for your work each night, unless there are no changes. It doesn't matter what the state of ... Greg Shah
11:46 AM Conversion Tools Feature #2251: improve the call graph generation
Code Review branch rev 10492
I have some questions regarding the "database design". There are inconsistencies:
...
Greg Shah
11:00 AM Conversion Tools Feature #2251: improve the call graph generation
> BTW, do you have a rebase script, so I can rebase?
Not yet. Please go through the process manually based on my ...
Greg Shah

03/15/2014

01:33 PM Database Feature #2134: configurable denormalization of extent fields into individual fields in schema con...
Concerning bug in @where_clause_normalize.rules@ (note 61).
Solution would be to add check @ref.type == prog.num_li...
Vadim Nebogatov

03/14/2014

07:54 PM Base Language Feature #1634: implement full native library (.so or DLL) support
The update for your review contains modification for @progress.g@ file and minor fix for @control_flow.rules@. The se... Eugenie Lyzenko
04:44 PM Conversion Tools Feature #2251: improve the call graph generation
I've added a good version for review in the 2251 branch. @rules/callgraph/callgraph_lib.rules@ contains details about... Constantin Asofiei
04:26 PM User Interface Feature #1811: implement the AJAX client driver
None of the existing Java VT 100 emulators can be used as they are.
We have to create a derivative work if license a...
Marius Gligor
01:58 PM User Interface Feature #1811: implement the AJAX client driver
A couple of quick points:
> The VT 100 terminal emulator should be a Java implementation. Searching on Internet I ...
Greg Shah
12:23 PM User Interface Feature #1811: implement the AJAX client driver
1. The interactive client on Linux/Unix could be implemented using a pseudo terminal.
A pseudo terminal (PTY) is ass...
Marius Gligor
03:48 PM Database Feature #2143: prototype IKVM solution for Java UDFs compiled to CIL assemblies and loaded in SQL...
Changes in update zip:
* removed Operators.java (it was identical to bzr version)
* added full implementation of Op...
Ovidiu Maxiniuc
11:05 AM Database Feature #2207: Remaining issues for dynamic buffers and dynamic tables
> 1. In the original testcase (violation error for the dynamic table) error is displayed twice (the fix reproduces th... Eric Faulhaber
08:13 AM Database Bug #2259: computed character columns are not created for dynamic tables
1. For static temp tables computed columns ("__fieldName") are created for indexed character columns. For dynamic tem... Stanislav Lomany
08:09 AM Database Bug #2259 (Closed): computed character columns are not created for dynamic tables
Stanislav Lomany
01:30 AM Database Feature #2134: configurable denormalization of extent fields into individual fields in schema con...
Problem resolved. Replacement original method to denormalized method was missed in temporary record mode in RecordBuf... Vadim Nebogatov
12:26 AM Database Feature #1661: support case-sensitive fields in indexes
Ovidiu, please determine what is left to do with @P2JH2Dialect.isCaseInsensitiveColumn@. I think whatever index infor... Eric Faulhaber

03/13/2014

06:12 PM User Interface Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects)
Next update works for almost all up/down cases including different step sizes (not only 1). Here are two remained unc... Vadim Gindin
05:56 PM Base Language Feature #1634: implement full native library (.so or DLL) support
The today update contains the @SourceNameMapper@ changes for you to review. The testcases are also included. The curr... Eugenie Lyzenko
01:17 PM Base Language Feature #1634: implement full native library (.so or DLL) support
Eugenie Lyzenko wrote:
> When the server is starting there is no physical dependency on the @test4.p@ file on the di...
Constantin Asofiei
12:54 PM Base Language Feature #1634: implement full native library (.so or DLL) support
> I don't understand: do you match an absolute name for the legacy 4GL program to an EXISTING file on the disk?
>
...
Eugenie Lyzenko
12:04 PM Base Language Feature #1634: implement full native library (.so or DLL) support
Eugenie Lyzenko wrote:
> I need to know what exactly the @"configured basepath"@ variable is on the run-time stage. ...
Constantin Asofiei
11:41 AM Base Language Feature #1634: implement full native library (.so or DLL) support
> canonicalize() will prepare the name so that it can be matched against a name from name_map.xml. Also, all names in... Eugenie Lyzenko
10:57 AM Base Language Feature #1634: implement full native library (.so or DLL) support
Greg Shah wrote:
> > I'm asking because the SourceNameMapper.canonicalize() is used in different places inside Sourc...
Constantin Asofiei
09:15 AM Base Language Feature #1634: implement full native library (.so or DLL) support
> And after the conversion has been completed it is not required to keep the original 4GL source tree on the server s... Greg Shah
09:05 AM Base Language Feature #1634: implement full native library (.so or DLL) support
> All files to be converted must reside within a single subdirectory under the project home. This ensures that we can... Eugenie Lyzenko
07:28 AM Base Language Feature #1634: implement full native library (.so or DLL) support
> On the conversion stage the driver map the 4GL file name to the internal class for every program to be converted
...
Greg Shah
08:58 PM Base Language Feature #1634: implement full native library (.so or DLL) support
Another important thing to clarify.
Observing the full deployment path from conversion the source to run the conve...
Eugenie Lyzenko
03:48 PM Database Feature #2143: prototype IKVM solution for Java UDFs compiled to CIL assemblies and loaded in SQL...
The attached update pack contains some missing files from previous archive. Please review.
The C# source code were t...
Ovidiu Maxiniuc
02:00 PM Database Feature #2258: retrofit BUFFER-COPY and BUFFER-COMPARE language statement runtime support to use ...
When runtime support for the handle-based methods @BUFFER-COPY()@ and @BUFFER-COMPARE()@ originally was implemented, ... Eric Faulhaber
01:41 PM Database Feature #2258 (Closed): retrofit BUFFER-COPY and BUFFER-COMPARE language statement runtime suppor...
Eric Faulhaber
11:12 AM Runtime Infrastructure Feature #2243 (Closed): integrate spawn.c changes into winspawn.c
Greg Shah
10:57 AM User Interface Feature #2247 (WIP): interactive child process support
Marius Gligor
10:56 AM User Interface Feature #1811: implement the AJAX client driver
0312c.zip Integrate spawn.c changes into winspawn.c ref. #2243
Passed regression tests. Committed revision 10492.
Marius Gligor
10:48 AM Conversion Tools Feature #2251: improve the call graph generation
Yes, I think you are right. Greg Shah
10:25 AM Conversion Tools Feature #2251: improve the call graph generation
About the preprocessor parser problem which can be reproduced with an include file like this one:... Constantin Asofiei
07:15 AM Base Language Bug #2257: Set statment does not define variable
The following code throws an exception during conversion procedure(this is legal code in 4gl):... Greg Shah
06:46 AM Database Feature #2207: Remaining issues for dynamic buffers and dynamic tables
> What cases remain to be handled?
1. In the original testcase (violation error for the dynamic table) error is disp...
Stanislav Lomany
08:52 PM Database Feature #2207: Remaining issues for dynamic buffers and dynamic tables
Update 20140311a looks OK to me, but please hold off regression testing for now. I have a large update to RecordBuffe... Eric Faulhaber
03:21 AM Database Feature #2134: configurable denormalization of extent fields into individual fields in schema con...
Eric Faulhaber wrote:
> @WhereExpression@ itself does not throw @UnsupportedOperationException@. What is throwing it...
Vadim Nebogatov
08:42 PM Database Feature #2134: configurable denormalization of extent fields into individual fields in schema con...
The attached update fixes the conversion error reported in note 61. I have not yet regression tested it. Eric Faulhaber
08:24 PM Database Feature #2134: configurable denormalization of extent fields into individual fields in schema con...
@WhereExpression@ itself does not throw @UnsupportedOperationException@. What is throwing it? What is your question? Eric Faulhaber

03/12/2014

07:44 PM Base Language Bug #2257 (New): Set statment does not define variable
Evgeny Kiselev
07:06 PM Database Feature #2134: configurable denormalization of extent fields into individual fields in schema con...
UnsupportedOperationException with using @WhereExpression@ found for denormalized fields with extent. Test case uses... Vadim Nebogatov
07:43 AM Database Feature #2134: configurable denormalization of extent fields into individual fields in schema con...
h3. Status of where clause conversion for denormalized extent fields
Problem was in what time should be denormalized...
Vadim Nebogatov
05:36 PM Base Language Feature #1634: implement full native library (.so or DLL) support
> 1. In your example is it key point the string leading to be the same as characters inside the strings(both ' or ")?... Greg Shah
04:22 PM Base Language Feature #1634: implement full native library (.so or DLL) support
> The change in progressToJavaString() will cause problems with strings in Windows mode where the next char after the... Eugenie Lyzenko
09:36 AM Base Language Feature #1634: implement full native library (.so or DLL) support
> Does it mean all file-system container values in directory.xml file for the OS where the server is running should c... Greg Shah
09:32 AM Base Language Feature #1634: implement full native library (.so or DLL) support
> It is not "predefined". That directory.xml is just a file that was designed to be run on Linux. All the values in t... Eugenie Lyzenko
08:44 AM Base Language Feature #1634: implement full native library (.so or DLL) support
Code Review 0311a
1. The change in progressToJavaString() will cause problems with strings in Windows mode where t...
Greg Shah
08:12 AM Base Language Feature #1634: implement full native library (.so or DLL) support
> The question: do we plan to keep predefined "/" file separator value in directory.xml file?
It is not "predefine...
Greg Shah
04:21 PM Database Feature #2143: prototype IKVM solution for Java UDFs compiled to CIL assemblies and loaded in SQL...
That is excellent news, Ovidiu, well done! Eric Faulhaber
04:19 PM Database Feature #2143: prototype IKVM solution for Java UDFs compiled to CIL assemblies and loaded in SQL...
*Hurray!*
I have fixed all issues mentioned in my previous notes and successfully run some basic 4GL statements usin...
Ovidiu Maxiniuc
02:19 PM User Interface Feature #1811: implement the AJAX client driver
OK, then go ahead and get this runtime regression tested. Greg Shah
02:06 PM User Interface Feature #1811: implement the AJAX client driver
No. I have no other changes to do. Marius Gligor
01:18 PM User Interface Feature #1811: implement the AJAX client driver
Code Review 0312c
I'm fine with the code.
Is there anything left to do for #2243?
Greg Shah
12:04 PM User Interface Feature #1811: implement the AJAX client driver
The encryption use is now optional. By default no encryption is used just clear-text.
In order to use encryption a c...
Marius Gligor
10:09 AM User Interface Feature #1811: implement the AJAX client driver
I like the idea.
Some issues:
# We can't use encryption keys that are hard coded in our source code. We provide...
Greg Shah
09:13 AM User Interface Feature #1811: implement the AJAX client driver
Here is my implementation for password encryption.
For Windows OS we have to keep the systemPassword in clear-text i...
Marius Gligor
09:08 AM User Interface Feature #1811: implement the AJAX client driver
Code Review 0312a
The code looks fine. What is left to do with this task?
Greg Shah
09:03 AM User Interface Feature #1811: implement the AJAX client driver
Normally, I would absolutely want to do this.
Can the encoding be easily reversed? It seems like it must be rever...
Greg Shah
08:52 AM User Interface Feature #1811: implement the AJAX client driver
Today I designed and tested a simple algorithm in C code to encode/decode the password on Windows OS.
I think that i...
Marius Gligor
08:48 AM User Interface Feature #1811: implement the AJAX client driver
> Since the redirection of STDOUT or STDIN for chui_native clients make no sense I think that is better to keep the o... Greg Shah
03:24 AM User Interface Feature #1811: implement the AJAX client driver
1. The code inside terminal_win.c is the native implementation of chui_native screen driver for Windows OS using cons... Marius Gligor
01:43 PM Conversion Tools Feature #2256: create tools to analyze the .pphints files
From #2251 note 46:
> On a side note, there are cases in the server project where there are typos in the preprocesso...
Constantin Asofiei
01:40 PM Conversion Tools Feature #2256 (New): create tools to analyze the .pphints files
Constantin Asofiei
01:17 PM Conversion Tools Feature #2251: improve the call graph generation
Greg Shah wrote:
> Anyway, as far as I know, the preprocessor should not be considering the path of the file that co...
Constantin Asofiei
01:08 PM Conversion Tools Feature #2251: improve the call graph generation
> I think this is because FileScope doesn't keep track of the folder in which the 4GL program resides...
As far as...
Greg Shah
01:01 PM Conversion Tools Feature #2251: improve the call graph generation
Greg Shah wrote:
> As far as I know it does work. Have you found a problem?
What is not working for me is this case:...
Constantin Asofiei
12:38 PM Conversion Tools Feature #2251: improve the call graph generation
> I see that the P2J preprocessor does not support relative names via "..", only relative names starting with the loc... Greg Shah
12:08 PM Conversion Tools Feature #2251: improve the call graph generation
Greg Shah wrote:
> If the .pphints problems are not hindering your work, then create a new bug task for this and we ...
Constantin Asofiei
11:15 AM Conversion Tools Feature #2251: improve the call graph generation
If the .pphints problems are not hindering your work, then create a new bug task for this and we will work it later. ... Greg Shah
10:44 AM Conversion Tools Feature #2251: improve the call graph generation
Greg Shah wrote:
> The idea: create a common create_widget_or_object rule that matches the left portion of both the ...
Constantin Asofiei
10:20 AM Conversion Tools Feature #2251: improve the call graph generation
> This might need to be fixed in the post-parse fixups phase: just alter the create_widget_stmt to accept the CONNET ... Greg Shah
10:00 AM Conversion Tools Feature #2251: improve the call graph generation
Greg Shah wrote:
> Using VALUE() for CREATE Automation is not noted in the documentation. Are you sure that this wo...
Constantin Asofiei
09:49 AM Conversion Tools Feature #2251: improve the call graph generation
Using VALUE() for CREATE Automation is not noted in the documentation. Are you sure that this works in the 4GL as CO... Greg Shah
09:32 AM Conversion Tools Feature #2251: improve the call graph generation
Greg Shah wrote:
> > we can't parse the CONNECT TO phrase properly.
>
> Please provide more details.
It's a comb...
Constantin Asofiei
09:23 AM Conversion Tools Feature #2251: improve the call graph generation
> we can't parse the CONNECT TO phrase properly.
Please provide more details.
> More, should the CREATE stateme...
Greg Shah
08:57 AM Conversion Tools Feature #2251: improve the call graph generation
About DDE, COM and OCX call-sites:
# a @COM-HANDLE@ var is initialized via @CREATE expr com-handle-var [CONNECT TO e...
Constantin Asofiei
08:55 AM Conversion Tools Feature #2251: improve the call graph generation
We might have created something like that, but I don't recall it.
However, there is some useful code in operators....
Greg Shah
07:54 AM Conversion Tools Feature #2251: improve the call graph generation
Greg, is there a way to get the concatenated result from a string expression containing only literals, like @"-H loca... Constantin Asofiei
11:02 AM Database Feature #2235: fix deployment issues related to dynamic database conversion resources
Stanislav Lomany wrote:
> How these file should be handled for testcases project - should I include them in @p2j.jar...
Eric Faulhaber
08:22 AM Database Feature #2235: fix deployment issues related to dynamic database conversion resources
Eric, after unnecessary dependencies will be eliminated, I assume that @rules@ should be stored in @p2j[rt].jar@.
@d...
Stanislav Lomany
08:46 AM Base Language Feature #1628: fix any incompatibilities or missing features of NO-ECHO support
No. But please do create a new Redmine task (a bug) that describes the problem and has the testcase code for the rec... Greg Shah
06:38 AM Database Feature #2207: Remaining issues for dynamic buffers and dynamic tables
Fix for review for issue 1 in note 1. The fix is limited to constraints violation case for NO-UNDO buffers. Stanislav Lomany

03/11/2014

07:43 PM Base Language Feature #1628: fix any incompatibilities or missing features of NO-ECHO support
Greg Shah wrote:
> Yes. Although, I am surprised it doesn't work (we support other define var cases that are in a f...
Evgeny Kiselev
08:46 PM Base Language Feature #1628: fix any incompatibilities or missing features of NO-ECHO support
I'm responding to the note in #1629.
> Am correct ?
Yes. Although, I am surprised it doesn't work (we support ...
Greg Shah
08:04 PM Base Language Feature #1628: fix any incompatibilities or missing features of NO-ECHO support
OK, I understand what you are trying to do.
I think there are 2 options (test these to see if either or both work)...
Greg Shah
05:09 PM Base Language Feature #1634: implement full native library (.so or DLL) support
This update introduces the @SourceNameMapper.canonicalize()@ changes. I've found the @fileSep@ variable used in this ... Eugenie Lyzenko
09:27 PM Base Language Feature #1634: implement full native library (.so or DLL) support
This is the suggested change for conversion part of the process for you to review.
The @SourceNameMapper.canonical...
Eugenie Lyzenko
04:10 PM User Interface Feature #1811: implement the AJAX client driver
Code Review 0311b
The code changes make sense.
My only questions are in regard to the terminal_win.c change:
...
Greg Shah
12:57 PM User Interface Feature #1811: implement the AJAX client driver
I found the problem. I fixed my bug and now it works properly. What was missing is the last argument client:driver:ba... Marius Gligor
12:10 PM User Interface Feature #1811: implement the AJAX client driver
The STDOUT redirection is implemented for Windows OS at high level but not at low level.
So my changes in terminal_w...
Marius Gligor
11:18 AM User Interface Feature #1811: implement the AJAX client driver
> the redirection of STDOUT is not yet implemented in screen drivers code for Windows OS.
> Maybe I should check the...
Greg Shah
11:14 AM User Interface Feature #1811: implement the AJAX client driver
OK. I understood. Is about appserver agents running in batch mode. The appserver agents implementation is to spawn cl... Marius Gligor
11:02 AM User Interface Feature #1811: implement the AJAX client driver
There is no batch mode for the ServerDriver because there is no concept of a real server in the 4GL. All 4GL session... Greg Shah
10:45 AM User Interface Feature #1811: implement the AJAX client driver
> 1. I'm using a command like: com.goldencode.p2j.main.ServerDriver -b p2j_proc
> This is not a batch mode?
Until...
Eugenie Lyzenko
10:34 AM User Interface Feature #1811: implement the AJAX client driver
Some time ago I worked to implements the STDOUT redirection in spawn.c for Linux/Unix OS (see note 434).
Now I'm wor...
Marius Gligor
10:09 AM User Interface Feature #1811: implement the AJAX client driver
1. I'm using a command like: com.goldencode.p2j.main.ServerDriver -b p2j_proc
This is not a batch mode?
2. The re...
Marius Gligor
08:43 AM User Interface Feature #1811: implement the AJAX client driver
> It is my understanding that batch most is mostly implemented for Windows. I think an exception is the support for m... Eugenie Lyzenko
08:20 AM User Interface Feature #1811: implement the AJAX client driver
It is my understanding that batch most *is* mostly implemented for Windows. I think an exception is the support for ... Greg Shah
05:18 AM User Interface Feature #1811: implement the AJAX client driver
On console initialization STDIN and STDOUT are checked for redirection.
If STDOUT is redirected the redirected handl...
Marius Gligor
04:01 PM Database Feature #2143: prototype IKVM solution for Java UDFs compiled to CIL assemblies and loaded in SQL...
I have this exception:... Ovidiu Maxiniuc
02:33 PM Conversion Tools Feature #2251: improve the call graph generation
I've added to @testcases/uast/callgraph-tests@ the current tests for callgraph generation. What is working:
* RUN ex...
Constantin Asofiei
12:58 PM Runtime Infrastructure Feature #2243 (Review): integrate spawn.c changes into winspawn.c
Marius Gligor

03/10/2014

07:10 PM Base Language Feature #1628: fix any incompatibilities or missing features of NO-ECHO support
For example if I set @ECHO@ I want to know in code if something is displayed and if I set @NO-ECHO@ then display buff... Evgeny Kiselev
07:08 PM Base Language Feature #1628: fix any incompatibilities or missing features of NO-ECHO support
What do you mean by "display"? Greg Shah
06:51 PM Base Language Feature #1628: fix any incompatibilities or missing features of NO-ECHO support
Is any way to check what display is showing now in 4gl ? Evgeny Kiselev
04:49 PM Database Feature #2143: prototype IKVM solution for Java UDFs compiled to CIL assemblies and loaded in SQL...
I have some issues with the current generated datatypes in for the tables ddl. My concerns regard the following:
* u...
Ovidiu Maxiniuc
12:58 PM User Interface Feature #1811: implement the AJAX client driver
Regarding to STDOUT redirection in terminal_win.c it seems that we have to do more changes here.
On init console we ...
Marius Gligor
12:10 PM User Interface Feature #1811: implement the AJAX client driver
Here are the winspawn.c changes that I did in order to integrate the code from Linux spawn.c version.

1. In order...
Marius Gligor
12:51 PM Conversion Tools Feature #2251: improve the call graph generation
Yes, please do this for any "fixes" that are done later but which are needed for call-graph processing. Greg Shah
12:45 PM Conversion Tools Feature #2251: improve the call graph generation
The ASTs for a i.e. @INPUT THROUGH@ stmt is broken and fixed by @annotations/input-output.rules:181@, the "fixup KW_T... Constantin Asofiei
09:47 AM Conversion Tools Feature #2251: improve the call graph generation
Greg Shah wrote:
> This means that processing the ASTs at that time *may* generate very different results than on th...
Constantin Asofiei
09:03 AM Conversion Tools Feature #2251: improve the call graph generation
> 1. Is there any reason why we can't generate the callgraph with the final ASTs, after conversion, and should use on... Greg Shah
08:41 AM Conversion Tools Feature #2251: improve the call graph generation
> Can you think of any external linkage type that I have not listed above?
I think all forms of the CONNECT method (...
Constantin Asofiei
07:59 AM Base Language Feature #1634: implement full native library (.so or DLL) support
> So I guess we must transform path\to\program.p string to path\\to\\program.p for java converted code
Modify @pr...
Greg Shah
04:03 AM Base Language Bug #2133: fix precision for decimal, dynamic-extent variables
Hynek Cihlar wrote:
> There's a bug in @ArrayAssigner.assignMulti(BaseDataType[], BaseDataType[])@. When assigning a...
Constantin Asofiei

03/09/2014

04:47 PM Base Language Bug #2133: fix precision for decimal, dynamic-extent variables
There's a bug in @ArrayAssigner.assignMulti(BaseDataType[], BaseDataType[])@. When assigning a determinate array to a... Hynek Cihlar

03/08/2014

02:58 PM Base Language Feature #1634: implement full native library (.so or DLL) support
>Eugenie: please do provide full support for absolute (drive letter) paths on Windows.
OK.
Another finding. The...
Eugenie Lyzenko
11:47 AM Base Language Feature #1634: implement full native library (.so or DLL) support
> My suggestion is the converted code(meaning runtime level) should have only one interpretation for Windows file sep... Greg Shah
06:38 AM Base Language Feature #1634: implement full native library (.so or DLL) support
Eugenie Lyzenko wrote:
> The first point I'm thinking about is how to convert these cases. My suggestion is the conv...
Constantin Asofiei
 

Also available in: Atom