FWD » Core Development

05/31/2014

09:09 PM Base Language Feature #1630: implement support for UNBUFFERED in I/O statements

Greg Shah wrote:
> Code Review 0528a
>
> The code looks good.
>
> Have you finished testing all of your testca... Evgeny Kiselev

08:37 PM User Interface Feature #1806: implement UNLESS-HIDDEN

Code Review 0530a
I agree, the changes are safe. No additional testing is needed. Greg Shah

05/30/2014

07:39 PM Base Language Feature #2311: rewrite parsing of handle chains and other misc parser changes

What do you suggest for the assignment stmts issue? We can defer it, but we may just hit it in future code. If that... Greg Shah

05:56 PM Base Language Feature #2311: rewrite parsing of handle chains and other misc parser changes

Greg Shah wrote:
> OK, then go ahead, check in and distribute it.
Committed to bzr rev 10538.
As a reminder, the... Constantin Asofiei

05:40 PM Base Language Feature #2311: rewrite parsing of handle chains and other misc parser changes

OK, then go ahead, check in and distribute it. Greg Shah

05:38 PM Base Language Feature #2311: rewrite parsing of handle chains and other misc parser changes

Greg Shah wrote:
> You're confident that the handle unwrapping changes are safe?
MAJIC uses only @unwrapWidget@, an... Constantin Asofiei

05:01 PM Base Language Feature #2311: rewrite parsing of handle chains and other misc parser changes

You're confident that the handle unwrapping changes are safe? Greg Shah

04:52 PM Base Language Feature #2311: rewrite parsing of handle chains and other misc parser changes

Greg Shah wrote:
> I am fine with the changes. At this point, is there anything left to do?
Conversion testing pas... Constantin Asofiei

04:41 PM Base Language Feature #2311: rewrite parsing of handle chains and other misc parser changes

Code Review 0530b
I am fine with the changes. At this point, is there anything left to do? Greg Shah

04:25 PM Base Language Feature #2311: rewrite parsing of handle chains and other misc parser changes

OK, the attached version contains this:
# @progress.g@ history fixed
# @methods_attributes.rules@ - was added a not... Constantin Asofiei

04:05 PM Base Language Feature #2311: rewrite parsing of handle chains and other misc parser changes

> Thus, is there anything else I should do at this point? Because I doubt the COM_INVOCATION/COM_METHOD/COM_PARAMETER... Greg Shah

03:29 PM Base Language Feature #2311: rewrite parsing of handle chains and other misc parser changes

Constantin Asofiei wrote:
> What I think ECW needs is just some simplifications of the cases when COLON nodes are in... Constantin Asofiei

03:01 PM Base Language Feature #2311: rewrite parsing of handle chains and other misc parser changes

Constantin Asofiei wrote:
> > 1. The com_invocation/com_method processing in methods_attributes.rules is removed. I... Constantin Asofiei

02:17 PM Base Language Feature #2311: rewrite parsing of handle chains and other misc parser changes

> BTW, are there other POLY tests, beside the ones at #2050?
Yes, dynamic_function_context_analysis.p is useful to... Greg Shah

01:46 PM Base Language Feature #2311: rewrite parsing of handle chains and other misc parser changes

Greg Shah wrote:
> Code Review 0526f
>
> Generally, I am happy with the changes. The methods_attributes.rules is ... Constantin Asofiei

07:38 PM User Interface Feature #1806: implement UNLESS-HIDDEN

This update merges @UNLESS-HIDDEN@ changed with the recent code base. I think the tasks are pretty independent and me... Eugenie Lyzenko

03:49 PM User Interface Feature #1806: implement UNLESS-HIDDEN

The main part has been completed without regressions in two rounds. Continue with the CTRL-C part. Eugenie Lyzenko

04:58 PM Database Feature #2296 (Closed): update record buffer validation to prevent database index overflow

Eric Faulhaber

08:11 AM Base Language Feature #1630: implement support for UNBUFFERED in I/O statements

Code Review 0528a
The code looks good.
Have you finished testing all of your testcases? If it is fully working... Greg Shah

08:10 PM Base Language Feature #1630: implement support for UNBUFFERED in I/O statements

>1. Please merge the code up to the latest P2J level in bzr (Stream.java is missing changes).
>2. In both classes, p... Evgeny Kiselev

08:06 AM User Interface Feature #1789: implement the toggle-box widget

For now, we don't have GUI support yet in the rest of the client. So you can only implement ChUI right now. Later o... Greg Shah

05/29/2014

05:54 PM User Interface Feature #1806: implement UNLESS-HIDDEN

The conversion testing has been completed without any differences in converted Java code. Started the regression test... Eugenie Lyzenko

04:26 PM User Interface Feature #1806: implement UNLESS-HIDDEN

Code Review 0529a
The changes look good. Please get them regression tested. Greg Shah

01:09 PM User Interface Feature #1806: implement UNLESS-HIDDEN

Finally I have got all local tests passed. The new changes in update for review includes:
1. Removing @LabelImpl@ cl... Eugenie Lyzenko

05:52 PM User Interface Feature #1789: implement the toggle-box widget

> Start by writing testcases to demonstrate the toggle-box behavior and all its options.
Do we need to cover only ... Eugenie Lyzenko

05:26 PM Base Language Feature #2311: rewrite parsing of handle chains and other misc parser changes

Code Review 0526f
Generally, I am happy with the changes. The methods_attributes.rules is so much simpler now. Ni... Greg Shah

05:38 AM Base Language Feature #2311: rewrite parsing of handle chains and other misc parser changes

A remainder issue is an investigation of the @annotations/assignment_style_stmt_rewriting.rules@ file: this will spli... Constantin Asofiei

01:11 PM User Interface Feature #1805: add missing UI method support

Vadim Gindin wrote:
> Constantin, thank you for the good test. It really will be useful.
>
> Here are the problem... Constantin Asofiei

07:26 AM User Interface Feature #1805: add missing UI method support

Constantin, thank you for the good test. It really will be useful.
Here are the problems I can formulate at this mom... Vadim Gindin

05/28/2014

04:21 PM User Interface Feature #1806: implement UNLESS-HIDDEN

> If everything is working in your local tests, then you can go into regression testing (both conversion and runtime)... Eugenie Lyzenko

03:37 PM User Interface Feature #1806: implement UNLESS-HIDDEN

> The changes are good, except that the @hidden()@ method should be removed from @LabeledWidget@ instead of being com... Eugenie Lyzenko

03:29 PM User Interface Feature #1806: implement UNLESS-HIDDEN

Code Review 0528b
The changes are good, except that the @hidden()@ method should be removed from @LabeledWidget@ i... Greg Shah

02:59 PM User Interface Feature #1806: implement UNLESS-HIDDEN

> Yes, please do explicitly cast it. Otherwise it is confusing to future readers/maintainers of the code.
OK. The ... Eugenie Lyzenko

01:49 PM User Interface Feature #1806: implement UNLESS-HIDDEN

> If not add hidden() to LabeledWidget - we will need explicit casting fin to some class that have hidden() inside th... Greg Shah

01:42 PM User Interface Feature #1806: implement UNLESS-HIDDEN

> 1. The hidden() method of LabeledWidget is already present in the Widget interface. LabeledDataContainer extends Fi... Eugenie Lyzenko

12:49 PM User Interface Feature #1806: implement UNLESS-HIDDEN

Code Review 0528a
I like the approach. My only questions:
1. The @hidden()@ method of @LabeledWidget@ is alrea... Greg Shah

10:35 AM User Interface Feature #1806: implement UNLESS-HIDDEN

The fix for hidden widgets has been added to the update.
The goal is to suppress label text drawing for hidden wid... Eugenie Lyzenko

03:54 PM User Interface Feature #1789: implement the toggle-box widget

Start by writing testcases to demonstrate the toggle-box behavior and all its options.
Then add conversion support... Greg Shah

02:38 PM Base Language Bug #2293: Fixing an unfixed extent output parameter causes an error

Constantin Asofiei wrote:
> OK, this is a conversion problem, if the fix is not trivial leave it for another time.
... Hynek Cihlar

12:43 PM Base Language Bug #2293: Fixing an unfixed extent output parameter causes an error

Hynek Cihlar wrote:
> Constantin Asofiei wrote:
> > Not sure if you are aware, table fields can not be set as dynam... Constantin Asofiei

12:35 PM Base Language Bug #2293: Fixing an unfixed extent output parameter causes an error

Constantin Asofiei wrote:
> Not sure if you are aware, table fields can not be set as dynamic extent in 4GL. How doe... Hynek Cihlar

11:52 AM Base Language Bug #2293: Fixing an unfixed extent output parameter causes an error

Hynek Cihlar wrote:
> Is the conversion of output extent fields supposed to work? When converting a temp-table field... Constantin Asofiei

11:45 AM Base Language Bug #2293: Fixing an unfixed extent output parameter causes an error

Is the conversion of output extent fields supposed to work? When converting a temp-table field passed as output param... Hynek Cihlar

10:36 AM Base Language Bug #2293: Fixing an unfixed extent output parameter causes an error

By the way, we can remove the need to call @setParameter@ from the converted code completely. For example, when @exte... Hynek Cihlar

01:45 PM Base Language Feature #1630: implement support for UNBUFFERED in I/O statements

Code Review 0523a
The changes look good. I have some minor comments and questions:
1. Please merge the code up to ... Greg Shah

12:58 PM User Interface Feature #1805: add missing UI method support

Vadim Gindin wrote:
> Actually I found that FrameWidget has the frame property, that can be used for that case. I on... Constantin Asofiei

12:49 PM Database Feature #2296: update record buffer validation to prevent database index overflow

The update was committed to bzr in rev 10537 and distributed by mail. Ovidiu Maxiniuc

09:59 AM Database Feature #2296: update record buffer validation to prevent database index overflow

Here is the summary of all the 8 tests:
20140523_172349 (CTR+C): massive fails
20140523_195225 (main): all test set... Ovidiu Maxiniuc

12:24 PM Base Language Feature #2311: rewrite parsing of handle chains and other misc parser changes

The ges_upd20140428a.zip (amongs other changes) rewrites the AST tree for a chaining in a handle, com-handle or objec... Constantin Asofiei

12:09 PM Base Language Feature #2311 (Closed): rewrite parsing of handle chains and other misc parser changes

Constantin Asofiei

05/27/2014

04:34 PM User Interface Feature #1806: implement UNLESS-HIDDEN

Code Review 0523a
The changes look good.
> So this is the general bug in DISPLAY statement handling and if ther... Greg Shah

04:15 PM User Interface Feature #1805: add missing UI method support

First of all I actualized testcases. See folders MOVE_BEFORE_TAB_ITEM and first_tab_item.
Constantin Asofiei wrote... Vadim Gindin

01:35 PM User Interface Feature #1805: add missing UI method support

Vadim Gindin wrote:
> Here is the first working variant. It works for simple cases (without nested frames and with o... Constantin Asofiei

02:33 PM Database Feature #2296: update record buffer validation to prevent database index overflow

Ovidiu Maxiniuc wrote:
> What do you think of the change in RecordBuffer.java:10134, namely restricting the flush() ... Eric Faulhaber

01:48 PM Database Feature #2296: update record buffer validation to prevent database index overflow

Eric Faulhaber wrote:
> Code review 20140523a:
>
> Update looks good. The findings you documented in the code com... Ovidiu Maxiniuc

12:55 PM Database Feature #2296: update record buffer validation to prevent database index overflow

Code review 20140523a:
Update looks good. The findings you documented in the code comments regarding the Progress ... Eric Faulhaber

09:06 AM Database Feature #2296: update record buffer validation to prevent database index overflow

The second execution took extremely long to finish.
There were a couple less failures in CTRL+C part.
The main pa... Ovidiu Maxiniuc

01:59 PM Base Language Bug #2293: Fixing an unfixed extent output parameter causes an error

Constantin Asofiei wrote:
> Hynek,
>
> The approach loosk good, just a question about how the converted code looks: ... Hynek Cihlar

11:59 AM Base Language Bug #2293: Fixing an unfixed extent output parameter causes an error

Hynek,
The approach loosk good, just a question about how the converted code looks: if we have @integer[] p = extp... Constantin Asofiei

05/26/2014

04:25 PM User Interface Feature #1805: add missing UI method support

Here is the first working variant. It works for simple cases (without nested frames and with only one field-group). F... Vadim Gindin

02:35 PM Database Feature #2296: update record buffer validation to prevent database index overflow

The initial regression test failed. There were no changes in generated ddl and no TRPL rules files affected for the c... Ovidiu Maxiniuc

08:50 PM Base Language Feature #1630: implement support for UNBUFFERED in I/O statements

>>Also, please add a test for OUTPUT TO "somefile.txt" UNBUFFERED (redirects the unnamed stream from the terminal to ... Evgeny Kiselev

05/23/2014

04:32 PM User Interface Feature #1806: implement UNLESS-HIDDEN

Updated testcases for @DISPLAY@ statement. Looks like the problem with @DISPLAY UNLESS-HIDDEN@ is not related to @UNL... Eugenie Lyzenko

03:07 PM User Interface Feature #1806: implement UNLESS-HIDDEN

Update for review with adding minimum level of safety checking. The modified widget list will be passed to the usual ... Eugenie Lyzenko

03:15 PM Database Feature #2296: update record buffer validation to prevent database index overflow

Eric Faulhaber wrote:
> Ovidiu Maxiniuc wrote:
> > As workaround for the unique null issue of SQL server, the ID is... Ovidiu Maxiniuc

03:05 PM Database Feature #2296: update record buffer validation to prevent database index overflow

Ovidiu Maxiniuc wrote:
> As workaround for the unique null issue of SQL server, the ID is added in the dialect for u... Eric Faulhaber

02:50 PM Database Feature #2296: update record buffer validation to prevent database index overflow

Uploaded om_upd20140523a.zip for review. It is merged with latest (10536) bzr rev.
The big issue here is that I coul... Ovidiu Maxiniuc

02:37 PM Base Language Bug #2293: Fixing an unfixed extent output parameter causes an error

Constantin Asofiei wrote:
> How do you expect the converted code will look?
There are not many changes in the con... Hynek Cihlar

01:50 AM Base Language Bug #2293: Fixing an unfixed extent output parameter causes an error

Hynek Cihlar wrote:
> In terms of implementation, I don't have a better idea than storing the variable pair consisti... Constantin Asofiei

07:34 AM User Interface Feature #2252: implement GUI client support

The package contains the changes and new classes used to implements CREATE WINDOW statement. So far the following iss... Marius Gligor

06:48 AM Database Feature #1580: upgrade Hibernate to latest level

This is how to build Hibernate from sources:... Stanislav Lomany

05/22/2014

07:05 PM User Interface Feature #1806: implement UNLESS-HIDDEN

Reattached the srceen shot for issue. Eugenie Lyzenko

07:01 PM User Interface Feature #1806: implement UNLESS-HIDDEN

> Make sure to implement this too if we don't already support it.
OK. The second drop for today contains runtime m... Eugenie Lyzenko

02:59 PM User Interface Feature #1806: implement UNLESS-HIDDEN

Code Review 0522a
The changes look good.
> Also the statement ENABLE ALL WITH FRAME... sets the HIDDEN flag to ... Greg Shah

01:13 PM User Interface Feature #1806: implement UNLESS-HIDDEN

This fix for your review is conversion rule change that allow the @UNLESS-HIDDEN@ option to be properly converted for... Eugenie Lyzenko

12:00 PM User Interface Feature #1806: implement UNLESS-HIDDEN

Currently only @DISPLAY@ and @ENABLE@ are supported with @UNLESS-HIDDEN@ option on the conversion level. For other st... Eugenie Lyzenko

10:16 AM User Interface Feature #1806: implement UNLESS-HIDDEN

The testcases executed in 4GL under Linux and screenshots uploaded. Yes, you are right, the @HIDDEN@ flag as @TRUE@ e... Eugenie Lyzenko

04:58 PM Base Language Feature #2050: ATTR_POLY/METH_POLY used as rvalue or in expressions

As far as I know, only the issue in note 24 remains open for this task.
I believe that most of the problem in this... Greg Shah

01:20 PM Base Language Bug #2293: Fixing an unfixed extent output parameter causes an error

The implementation should be straightforward with one exception - fixing the indeterminate extent argument. When the ... Hynek Cihlar

11:39 AM Base Language Bug #2293: Fixing an unfixed extent output parameter causes an error

Constantin Asofiei wrote:
> Hynek Cihlar wrote:
> > When error is raised during function or procedure execution, th... Hynek Cihlar

01:41 AM Base Language Bug #2293: Fixing an unfixed extent output parameter causes an error

Hynek Cihlar wrote:
> When error is raised during function or procedure execution, the variable passed in the block ... Constantin Asofiei

10:07 AM User Interface Feature #2252: implement GUI client support

Code Review 0522b
It looks good.
> 2. Could you please offer more details? What means "implement the WindowGuiI... Greg Shah

09:59 AM User Interface Feature #2252: implement GUI client support

For ChUI interface the status and message area are implemented as widgets (StatusLine instances)
To keep the compati... Marius Gligor

03:55 AM User Interface Feature #2252: implement GUI client support

1. The GuiScreen interface extends ScreenDriver interface.
2. Could you please offer more details? What means "imp... Marius Gligor

08:25 AM User Interface Feature #2308: remote client launch

Doesn't the 4GL appserver implementation have some features in this regard? We should at least document their basic ... Greg Shah

02:57 AM User Interface Feature #2308: remote client launch

The P2J Server should have no configuration/restriction on how many P2J clients act as remote launchers and the machi... Constantin Asofiei

02:15 AM User Interface Feature #1805: add missing UI method support

Greg Shah wrote:
> > I don't recall and can't find a way of jumping from frame F1 to frame F2 (both with enabled wid... Constantin Asofiei

05/21/2014

06:02 PM Base Language Bug #2293: Fixing an unfixed extent output parameter causes an error

Constantin Asofiei wrote:
> Hynek Cihlar wrote:
> > The above covers functions only. I will also test procedure out... Hynek Cihlar

01:30 PM Base Language Bug #2293: Fixing an unfixed extent output parameter causes an error

Hynek Cihlar wrote:
> The above covers functions only. I will also test procedure output parameters to see how it be... Constantin Asofiei

11:16 AM Base Language Bug #2293: Fixing an unfixed extent output parameter causes an error

Constantin Asofiei wrote:
> Hynek, something else to test: what happens with an extent var passed as an OUTPUT argum... Hynek Cihlar

03:00 PM Runtime Infrastructure Bug #2305: context-local vars need to be reset in a predetermined order

Eric Faulhaber wrote:
> *However, before we implement either workaround, I have to understand: why are we seeing the... Eric Faulhaber

02:35 PM Runtime Infrastructure Bug #2305: context-local vars need to be reset in a predetermined order

Most of the @ContextLocalCleanupException@ instances (all but one) follow this pattern:... Eric Faulhaber

05:37 AM Runtime Infrastructure Bug #2305: context-local vars need to be reset in a predetermined order

After runtime testing 0520c.zip changes, the following need to be addressed:
# these are reported as "surviving" aft... Constantin Asofiei

02:46 PM Database Bug #2280 (Closed): Error with FIND-FIRST() method

Eric Faulhaber

02:30 PM User Interface Feature #1805: add missing UI method support

> I don't recall and can't find a way of jumping from frame F1 to frame F2 (both with enabled widgets) just by pressi... Greg Shah

02:09 PM User Interface Feature #1805: add missing UI method support

Vadim, some thoughts:
# I don't recall and can't find a way of jumping from frame F1 to frame F2 (both with enabled ... Constantin Asofiei

09:13 AM User Interface Feature #1805: add missing UI method support

> At this moment I didn't find such test case.
That is good news.
> I don't feel free with terms. Could you des... Greg Shah

02:23 PM User Interface Feature #1783 (Closed): properly handle empty UNDERLINE statements

Greg Shah

02:15 PM User Interface Feature #1783: properly handle empty UNDERLINE statements

The update @0516a@ has been committed to bzr as 10536. Eugenie Lyzenko

01:56 PM User Interface Feature #1783: properly handle empty UNDERLINE statements

Finally I have finished @CTRL-C@ testing with all passed results. Not in single run.due to multiple false negative re... Eugenie Lyzenko

12:40 PM User Interface Feature #2252: implement GUI client support

Code Review 0521a
Wow! Very cool. I like it.
Some thoughts:
1. I would like the GUI screen driver to be desi... Greg Shah

11:55 AM User Interface Feature #2252: implement GUI client support

I've implemented a first skeleton version for drawing WINDOW widgets in GUI interfaces.
I attached a picture with th... Marius Gligor

10:38 AM User Interface Feature #2308: remote client launch

To be clear, this special launcher client would be started on the remove system and it would be configured to connect... Greg Shah

10:19 AM User Interface Feature #2308: remote client launch

Create a special P2J client that is a dedicated client process launcher. This client must be able to run on any arbi... Greg Shah

10:14 AM User Interface Feature #2308 (Closed): remote client launch

Greg Shah

10:13 AM User Interface Feature #2307: enable skinning of the web client login page

The ui/client/chui/driver/web/chui_web.html needs to allow some basic customization by a customer. The following sho... Greg Shah

10:01 AM User Interface Feature #2307 (New): enable skinning of the web client login page

Greg Shah

09:58 AM User Interface Feature #2306: add copy/paste support to the web client

This is not a 4GL feature, but rather it is meant to provide a mechanism that duplicates what is possible in normal t... Greg Shah

09:54 AM User Interface Feature #2306 (Closed): add copy/paste support to the web client

Greg Shah

09:27 AM User Interface Feature #1806: implement UNLESS-HIDDEN

The UNLESS-HIDDEN option should be fully implemented for the following language statements:
DISABLE
DISPLAY
ENAB... Greg Shah

08:42 AM Base Language Feature #1596 (Closed): complete big decimal implementation

Greg Shah

08:41 AM Base Language Feature #1600 (Closed): provide a conversion option to emit decimal literals using a string liter...

Greg Shah

05/20/2014

05:07 PM Base Language Feature #1600: provide a conversion option to emit decimal literals using a string literal instea...

Regression tests passed. Code changes committed to bzr revision 10535. Hynek Cihlar

04:40 PM User Interface Feature #1805: add missing UI method support

At this moment I didn't find such test case. I don't feel free with terms. Could you describe how do you define z-ord... Vadim Gindin

11:35 AM User Interface Feature #1805: add missing UI method support

Before you spend additional time on implementation, please post a testcase here which would break in P2J because the ... Greg Shah

03:51 PM Runtime Infrastructure Bug #2305: context-local vars need to be reset in a predetermined order

Code Review 0520c
The changes look good. Greg Shah

01:12 PM Runtime Infrastructure Bug #2305: context-local vars need to be reset in a predetermined order

This task is split from #2266 notes 33,34,35,36,37,38 (updates ca_upd20140512b.zip and ca_upd20140513a.zip from #226... Constantin Asofiei

12:26 PM Runtime Infrastructure Bug #2305 (Closed): context-local vars need to be reset in a predetermined order

Constantin Asofiei

02:17 PM User Interface Feature #2252: implement GUI client support

On CTRL-C the entire set of Windows are cleared in GUI. Marius Gligor

12:27 PM User Interface Feature #2252: implement GUI client support

> I think that a best idea is to clear also the windowRegistry whenever the DEFAULT_WINDOW is create (default constru... Greg Shah

12:06 PM User Interface Feature #2252: implement GUI client support

Initially Window class had only the default constructor. The init() method was initially the body of the default cons... Marius Gligor

11:26 AM User Interface Feature #2252: implement GUI client support

Code Review 0516b
The changes look good. I only have one question: why were the @local.set(null);@ and @config = ... Greg Shah

01:04 PM Database Feature #2220: dynamic query methods which require implementation

Yes, they differ and match P2J. Stanislav Lomany

09:45 AM Database Feature #2220: dynamic query methods which require implementation

Do the results differ if the query is not set to be scrolling? Eric Faulhaber

11:56 AM Base Language Bug #2197: fix the error message list cleanup when NO-ERROR mode is enabled and ERROR-STATUS:ERRO...

> Why there are possible of more than one error?! - It's for cases where could be more than one error during executio... Greg Shah

10:36 AM Base Language Feature #1630: implement support for UNBUFFERED in I/O statements

It is expected that P2J is not working. The runtime support for UNBUFFERED is not yet implemented. Your testcases l... Greg Shah

08:50 PM Base Language Feature #1630: implement support for UNBUFFERED in I/O statements

@UNBUFFERED@ statement is not working properly in p2j. This keyword is properly converted, but worked different.
One... Evgeny Kiselev

05:27 AM Base Language Bug #2293: Fixing an unfixed extent output parameter causes an error

Hynek, something else to test: what happens with an extent var passed as an OUTPUT argument, if the function/proc doe... Constantin Asofiei

05/19/2014

05:13 PM Database Feature #2296: update record buffer validation to prevent database index overflow

During last days I encountered inconsistent readings about the errors I get and whether I get some errors:
I did som... Ovidiu Maxiniuc

04:38 PM Base Language Feature #1600: provide a conversion option to emit decimal literals using a string literal instea...

Greg Shah wrote:
> Code Review 0519a
>
> It looks good. Sorry that I didn't think about this approach before now... Hynek Cihlar

03:18 PM Base Language Feature #1600: provide a conversion option to emit decimal literals using a string literal instea...

Code Review 0519a
It looks good. Sorry that I didn't think about this approach before now. It was your good idea... Greg Shah

02:29 PM Base Language Feature #1600: provide a conversion option to emit decimal literals using a string literal instea...

Attached is the change set with the removed check for decimal literals being effectively mathematical integers. Now t... Hynek Cihlar

02:10 PM Base Language Feature #1600: provide a conversion option to emit decimal literals using a string literal instea...

Greg Shah wrote:
> > Or are you saying that we should not care about the literal being effectively an integer (and d... Hynek Cihlar

02:05 PM Base Language Feature #1600: provide a conversion option to emit decimal literals using a string literal instea...

> Or are you saying that we should not care about the literal being effectively an integer (and do not check for this... Greg Shah

11:46 AM Base Language Feature #1600: provide a conversion option to emit decimal literals using a string literal instea...

Greg Shah wrote:
> Code Review 0518a
>
> The changes look good. I really like your approach of using the Java @d... Hynek Cihlar

09:31 AM Base Language Feature #1600: provide a conversion option to emit decimal literals using a string literal instea...

Code Review 0518a
The changes look good. I really like your approach of using the Java @double@ and @BigDecimal@ ... Greg Shah

04:33 PM Database Bug #2219 (Closed): problematic dynamic query test cases

Eric Faulhaber

07:34 AM Database Bug #2219 (Review): problematic dynamic query test cases

Stanislav Lomany

07:34 AM Database Bug #2219 (WIP): problematic dynamic query test cases

Stanislav Lomany

04:31 PM Base Language Feature #2184 (Closed): create and populate the temp-table on the remote side, based on the recei...

Eric Faulhaber

07:34 AM Base Language Feature #2184 (Review): create and populate the temp-table on the remote side, based on the recei...

Stanislav Lomany

07:33 AM Base Language Feature #2184 (WIP): create and populate the temp-table on the remote side, based on the received...

Merged update. Stanislav Lomany

02:02 PM Base Language Bug #2250 (Closed): Conversion error when decimal precision defined on dynamic extent variable

Greg Shah

01:39 PM Base Language Bug #2250: Conversion error when decimal precision defined on dynamic extent variable

I accidentally fixed this issue in the issue #2294. This can be closed now. Hynek Cihlar

09:39 AM Conversion Tools Feature #2251: improve the call graph generation

Please see #2260 for 2 open questions/issues. Greg Shah

08:20 AM User Interface Feature #1783: properly handle empty UNDERLINE statements

Code Review 0516a
I am fine with the changes. When CTRL-C processing passes, please check it in and distribute it. Greg Shah

05/18/2014

06:32 PM Base Language Feature #1600: provide a conversion option to emit decimal literals using a string literal instea...

Attached is the implementation with the special handling of mathematical integers. Now the decimal literal is emitted... Hynek Cihlar

09:09 AM User Interface Feature #1805: add missing UI method support

I don't fully understand the real link between z-order and tab order. Definitely it really exists and it complex. I ... Vadim Gindin

11:07 PM User Interface Feature #1783: properly handle empty UNDERLINE statements

The main part completed without regressions in a single run. Continue testing with @CTRL-C@ part. Eugenie Lyzenko

05/17/2014

08:39 PM User Interface Feature #1783: properly handle empty UNDERLINE statements

Sorry, the suggested fix does not work. Need to check @ThinClient@ redirection, not simple @Frame@ one. The fix has b... Eugenie Lyzenko

05/16/2014

07:52 PM User Interface Feature #1783: properly handle empty UNDERLINE statements

The regression has been found. Testcase TC-ITEM-MASTER-103 the difference in page size for report generation. The exp... Eugenie Lyzenko

02:30 PM User Interface Feature #1783: properly handle empty UNDERLINE statements

The conversion test completed. The converted sources are binary equal. Continue with runtime regression testing. Eugenie Lyzenko

11:47 AM User Interface Feature #1783: properly handle empty UNDERLINE statements

> So we can start the regression testing and fix the problems with UP(discovered in note 25) as another task. What d... Greg Shah

10:48 AM User Interface Feature #1783: properly handle empty UNDERLINE statements

Greg Shah wrote:
...
>
> The primary issue here is that you are not really exercising the new code very much. Tr... Eugenie Lyzenko

08:30 AM User Interface Feature #1783: properly handle empty UNDERLINE statements

> The only exception is P2J does not display the warning message that the Y coord can not be negative while 4GL displ... Greg Shah

08:47 PM User Interface Feature #1783: properly handle empty UNDERLINE statements

Well, the testcase to partially break implementation:... Eugenie Lyzenko

02:23 PM User Interface Feature #2252: implement GUI client support

When a WindowWidget option is changed the window configuration file should be send down to the client via LogicalTerm... Marius Gligor

01:08 PM User Interface Feature #2252: implement GUI client support

> in Windows, is there a way to intercept gdi32.dll API calls?
Yes, there are some tools out there. For example:
... Greg Shah

10:52 AM User Interface Feature #2252: implement GUI client support

Greg, I keep forgetting to mention something about font metrics, so here it is: in Windows, is there a way to interce... Constantin Asofiei

10:04 AM User Interface Feature #2252: implement GUI client support

Here are my latest changes:
1. On server side I used ID's from the same address space like frames. This offer a wi... Marius Gligor

01:18 PM User Interface Bug #2303: Incorrect UP statement handling with underlined widgets

The @UP@ command for down frames with underlined widgets works incorrectly in P2J. The 4GL screens step by step and t... Eugenie Lyzenko

01:16 PM User Interface Bug #2303 (New): Incorrect UP statement handling with underlined widgets

Eugenie Lyzenko

11:55 AM User Interface Feature #2302: Warning message when setting widget row to negative value

The 4GL displays the warning message when setting row to the negative value is requested. The testcase and screenshot... Eugenie Lyzenko

11:52 AM User Interface Feature #2302 (New): Warning message when setting widget row to negative value

Eugenie Lyzenko

11:45 AM Base Language Feature #1600: provide a conversion option to emit decimal literals using a string literal instea...

Good points. OK, go ahead with your approach. Please do put in the code to detect the 17 digit issue at conversion ... Greg Shah

10:26 AM Base Language Feature #1600: provide a conversion option to emit decimal literals using a string literal instea...

Greg Shah wrote:
> We very much like to avoid wrapping when unnecessary. Your idea about whole numbers is a good on... Hynek Cihlar

09:37 AM Base Language Feature #1600: provide a conversion option to emit decimal literals using a string literal instea...

We very much like to avoid wrapping when unnecessary. Your idea about whole numbers is a good one. It does have to ... Greg Shah

08:47 AM Base Language Feature #1600: provide a conversion option to emit decimal literals using a string literal instea...

I am wondering, whether we should emit the wrapper even for (effectively) whole numbers? Ex. instead of @.assign(new ... Hynek Cihlar

03:44 AM User Interface Feature #1805: add missing UI method support

1. Methods @moveToTop@ and @moveToBottom@ change the real place of the widget in the displaying order. They really mo... Vadim Gindin

05/15/2014

06:06 PM User Interface Feature #1783: properly handle empty UNDERLINE statements

I have tested two possibilities:
- perform @UP@ command for the first row in down frame several times.
- manual set... Eugenie Lyzenko

11:14 AM User Interface Feature #1783: properly handle empty UNDERLINE statements

> In other words: try to break this implementation. Report your results here. If you cannot break it, then go ahead i... Eugenie Lyzenko

10:57 AM User Interface Feature #1783: properly handle empty UNDERLINE statements

> can produce screen mess
If our clipping implementation is working properly, then a negative y value should not ... Greg Shah

10:41 AM User Interface Feature #1783: properly handle empty UNDERLINE statements

> I do wonder what happens if the Point.y value of the widget becomes negative during @relocateComponent()@. Are ther... Eugenie Lyzenko

10:23 AM User Interface Feature #1783: properly handle empty UNDERLINE statements

Code Review 0514a
The changes look good. I do wonder what happens if the Point.y value of the widget becomes nega... Greg Shah

08:10 PM User Interface Feature #1783: properly handle empty UNDERLINE statements

The suggested fix for you to review merged with the recent code base. The idea is to make full down processing on the... Eugenie Lyzenko

04:22 PM Base Language Bug #2294 (Closed): In Progress the variable initializer ignores the declared decimal precision

Greg Shah

12:55 PM Base Language Bug #2294: In Progress the variable initializer ignores the declared decimal precision

Committed to bzr revision 10532. Hynek Cihlar

11:31 AM Base Language Bug #2294: In Progress the variable initializer ignores the declared decimal precision

Good! Check in and distribute the changes. Greg Shah

11:26 AM Base Language Bug #2294: In Progress the variable initializer ignores the declared decimal precision

The regression test (after several attempts) passed. Hynek Cihlar

01:53 PM User Interface Feature #2252: implement GUI client support

Indeed windows are like other widgets and on the client side we could use the WidgetRegistry to register dynamic wind... Marius Gligor

12:20 PM User Interface Feature #2252: implement GUI client support

Code Review 0515a
My only concern is in regard to the ID processing (and the new @WindowRegistry@ class). Today, ... Greg Shah

11:08 AM User Interface Feature #2252: implement GUI client support

I designed a flow the assign unique ID's to a window dynamic created and register the new created window on server si... Marius Gligor

04:37 AM User Interface Feature #2252: implement GUI client support

Marius Gligor wrote:
> Should We move the implementation for setParentHandle and getParentHandle to BaseEntity?
Fro... Constantin Asofiei

08:46 AM User Interface Feature #1805: add missing UI method support

> I think It would be wrong to use @AbstractContainer.widgets@ order for the focus management.
Perhaps. But the c... Greg Shah

03:15 AM User Interface Feature #1805: add missing UI method support

I think It would be wrong to use @AbstractContainer.widgets@ order for the focus management. We really have two order... Vadim Gindin

05/14/2014

06:51 PM User Interface Feature #1783: properly handle empty UNDERLINE statements

Finally I have the fix. The client side modification is not enough. We need to perform implicit @down@ processing on ... Eugenie Lyzenko

04:12 PM User Interface Feature #2252: implement GUI client support

> Should We move the implementation for setParentHandle and getParentHandle to BaseEntity?
I will let Constantin r... Greg Shah

04:03 PM User Interface Feature #2252: implement GUI client support

Code Review 0514a
Everything looks good. Greg Shah

09:36 AM User Interface Feature #2252: implement GUI client support

I added a new layer of inheritance PaneEntity and PaneConfig which holds shared options for DIALOG, FRAME and WINDOW ... Marius Gligor

09:33 AM User Interface Feature #2286: design and implement basic GUI window widget support

I added a new layer of inheritance PaneEntity and PaneConfig which holds shared options for DIALOG, FRAME and WINDOW ... Marius Gligor

05/13/2014

04:49 PM Database Feature #1661 (Closed): support case-sensitive fields in indexes

Eric Faulhaber

03:50 PM User Interface Feature #1783: properly handle empty UNDERLINE statements

> Do you have an update on this? It seems like you should be pretty close to a solution, based on your findings.
Y... Eugenie Lyzenko

03:10 PM User Interface Feature #1783: properly handle empty UNDERLINE statements

Do you have an update on this? It seems like you should be pretty close to a solution, based on your findings. Greg Shah

02:19 PM User Interface Feature #2252: implement GUI client support

Greg Shah wrote:
> 2. Constantin: is there any issue with the changing of the @setParent(Object)@ signature to @setP... Constantin Asofiei

11:20 AM User Interface Feature #2252: implement GUI client support

Code Review 0513a
This is really good. Some feedback:
1. Some of the changes in BaseConfig are only shared bet... Greg Shah

10:35 AM User Interface Feature #2252: implement GUI client support

1. Here are the changes that I made so far to implements the CREATE WINDOW on server side.
On each option assigned t... Marius Gligor

10:18 AM User Interface Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects)

> Greg: I think we should wait for the delivery of the GUI sources before continuing, and run the reports on that; be... Greg Shah

10:14 AM User Interface Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects)

Vadim, some more thoughts about how current P2J works and what is missing (for down frames). Calling frame.<widget-n... Constantin Asofiei

09:00 AM Conversion Tools Feature #2251: improve the call graph generation

Fix for a problem when generating the list of dead include files, from the callgraph DB.
Committed to bzr rev 10530. Constantin Asofiei

08:03 AM Base Language Feature #1628: fix any incompatibilities or missing features of NO-ECHO support

The client code will have to be looked at closely in regard to flushing. There are other times when flushing occurs ... Greg Shah

05:38 AM User Interface Feature #1805: add missing UI method support

Added additional tests, 08-16 for the case with nested frames. All works as expected Vadim Gindin

05/12/2014

06:21 PM Base Language Feature #1628: fix any incompatibilities or missing features of NO-ECHO support

Everything is correct, except one:
>C: this line outputs the default (unnamed) frame to the unnamed stream which is ... Evgeny Kiselev

02:58 PM Base Language Feature #1628: fix any incompatibilities or missing features of NO-ECHO support

> Behaviour of display and stream functionality is more complicated than I thought before.
Yes, it is very tricky.... Greg Shah

03:53 PM Base Language Feature #1600: provide a conversion option to emit decimal literals using a string literal instea...

Code Review 0512b
Looks good. Get it regression tested. Both conversion and runtime testing are necessary. The ... Greg Shah

03:33 PM Base Language Feature #1600: provide a conversion option to emit decimal literals using a string literal instea...

Greg Shah wrote:
> Code Review 0512a
>
> The code looks fine. My only question is about this:
>
> [...]
>
... Hynek Cihlar

02:14 PM Base Language Feature #1600: provide a conversion option to emit decimal literals using a string literal instea...

Code Review 0512a
The code looks fine. My only question is about this:... Greg Shah

12:52 PM Base Language Feature #1600 (Review): provide a conversion option to emit decimal literals using a string liter...

Hynek Cihlar

12:46 PM Base Language Feature #1600: provide a conversion option to emit decimal literals using a string literal instea...

Please review the attached changes. The related test cases are committed as uast/decimal_literal_precision.p.
Hynek Cihlar

09:34 PM Base Language Feature #1600 (WIP): provide a conversion option to emit decimal literals using a string literal ...

Hynek Cihlar

03:47 PM Database Bug #2280: Error with FIND-FIRST() method

Update vmn_upd20140510a.zip committed and distributed, test case is checked into @testcases@ project. Vadim Nebogatov

09:54 PM Database Bug #2280: Error with FIND-FIRST() method

Code review 20140510a:
The fix looks good to me.
There is no point in regression testing this with the regressi... Eric Faulhaber

02:16 PM Base Language Feature #1630: implement support for UNBUFFERED in I/O statements

Check all uses (not just OUTPUT). I would hope that it just means that we flush with every write (synchronously). Greg Shah

12:41 PM Database Feature #2296: update record buffer validation to prevent database index overflow

Why are not @vData.dirtyUnique@ and @vData.dirtyNonUnique@ correctly initialized, from the point of view of index ch... Ovidiu Maxiniuc

08:43 AM Database Feature #2296: update record buffer validation to prevent database index overflow

Eric Faulhaber wrote:
> Please explain in more detail the incorrect behavior you have found with @vData@. Is it a ge... Ovidiu Maxiniuc

11:52 AM Base Language Bug #2133 (Closed): fix precision for decimal, dynamic-extent variables

Greg Shah

11:14 AM Base Language Bug #2294: In Progress the variable initializer ignores the declared decimal precision

Hynek, the changes on 0511a.zip look good. How was the regression testing? Constantin Asofiei

09:57 PM Database Feature #2281 (Closed): enhance schema name conversion to support literal replacements

Eric Faulhaber

05/11/2014

05:02 PM Database Bug #2280: Error with FIND-FIRST() method

Attached fix for this issue. Vadim Nebogatov

05:02 PM Base Language Bug #2294 (Review): In Progress the variable initializer ignores the declared decimal precision

Hynek Cihlar

04:41 PM Base Language Bug #2294: In Progress the variable initializer ignores the declared decimal precision

Please review the attached change set. It passes the companion uast/testcases which include cases for @setTempPrecisi... Hynek Cihlar

05:00 PM User Interface Feature #1783: properly handle empty UNDERLINE statements

The intermediate debugging results. The main issue is happening on the first @UNDERLINE@ statement when there is noth... Eugenie Lyzenko

01:12 PM User Interface Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects)

Vadim Gindin wrote:
> Tests about virtual widgets (сommitted to current-iteration folder).
These tests look good, a... Constantin Asofiei

11:49 AM Database Feature #2281: enhance schema name conversion to support literal replacements

Regression executed 2 times:
20140508_182010: 2 FAILED (all timeout related): tc_job_002, tc_pay_sfc_003
20140... Vadim Nebogatov

05/10/2014

09:21 AM User Interface Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects)

Tests about virtual widgets (сommitted to current-iteration folder).
1. The frame without side labels. Changing wi... Vadim Gindin

05/09/2014

06:42 PM Base Language Feature #1630: implement support for UNBUFFERED in I/O statements

Do I need to test only @output@ or all places there can be used @unbuffered@ ? (like input, input-output and etc) Evgeny Kiselev

05:29 PM Database Feature #2296: update record buffer validation to prevent database index overflow

> I was forced to rewrite the detection of affected indexes as the @vData@ does not contain the correct lists of @uni... Eric Faulhaber

04:51 PM Database Feature #2296: update record buffer validation to prevent database index overflow

I found some more edge-cases that require special handling for emulation of p4gl behavior.
I was forced to rewrite t... Ovidiu Maxiniuc

03:58 PM Base Language Feature #1628: fix any incompatibilities or missing features of NO-ECHO support

Behaviour of display and stream functionality is more complicated than I thought before.
Some @display@ call can ref... Evgeny Kiselev

11:26 AM User Interface Feature #2252: implement GUI client support

I designed a small test for WINDOW widget using the current defined attributes.
By adding some rules finally I manag... Marius Gligor

11:13 AM User Interface Feature #1811: implement the AJAX client driver

0508b - Passed regression tests. Committed revision 10525. Marius Gligor

08:19 AM Base Language Bug #2300: :: operator used in UI statements

It was a standalone case I used for investigation of some other issue.
The temporary fix was the cause of the regre... Ovidiu Maxiniuc

08:10 AM Base Language Bug #2300: :: operator used in UI statements

Was this found in standalone testcases or does this actually occur in customer code? Greg Shah

04:15 AM Base Language Bug #2300: :: operator used in UI statements

The conversion error is revealed by the following simple testcase:... Ovidiu Maxiniuc

03:41 AM Base Language Bug #2300 (New): :: operator used in UI statements

Ovidiu Maxiniuc

05/08/2014

03:55 PM Database Feature #2296: update record buffer validation to prevent database index overflow

Intermediary update attached. It contains the algorithm for validation that was should be a little changed.
The tw... Ovidiu Maxiniuc

02:25 PM User Interface Feature #1783: properly handle empty UNDERLINE statements

Yes, fix this.
I suspect this has something to do with the DOWN processing and the @afterDown@ variable used in @G... Greg Shah

02:02 PM User Interface Feature #1783: properly handle empty UNDERLINE statements

Unfortunately there are the difference in handling "real" underline statements like(@underline_test2.p@):... Eugenie Lyzenko

01:16 PM User Interface Feature #1783: properly handle empty UNDERLINE statements

Code Review 0508a
I am fine with the change.
Are all the testcases working the same way in the 4GL and P2J? ... Greg Shah

01:05 PM User Interface Feature #1783: properly handle empty UNDERLINE statements

> ... Eugenie Lyzenko

08:17 AM User Interface Feature #1783: properly handle empty UNDERLINE statements

Your solution is not correct. The 2nd parameter to @descendant()@ is the number of levels of children (1 for the imm... Greg Shah

08:10 PM User Interface Feature #1783: properly handle empty UNDERLINE statements

The jast node to be eliminated is:... Eugenie Lyzenko

12:38 PM Base Language Bug #2133: fix precision for decimal, dynamic-extent variables

0505a passed regression test and was committed to bzr revision 10524. Hynek Cihlar

12:13 PM User Interface Feature #2252: implement GUI client support

The points about the HTML5 canvas use are valid. However, in our case we have these mitigating circumstances:
# M... Greg Shah

11:49 AM User Interface Feature #2252: implement GUI client support

For now, only implement the Window attributes that are already "stubbed out" in our classes. To the degree that they ... Greg Shah

11:20 AM User Interface Feature #2252: implement GUI client support

Regarding HTML 5 Canvas please read this document: [[http://www.w3.org/TR/2dcontext/#best-practices]]
Marius Gligor

11:18 AM User Interface Feature #2252: implement GUI client support

I attached a list with all WINDOW widget attributes more than 70!
I started to do tests using some WINDOW attributes... Marius Gligor

11:40 AM User Interface Feature #1811: implement the AJAX client driver

OK, go ahead with runtime regression testing for this update. Greg Shah

10:53 AM User Interface Feature #1811: implement the AJAX client driver

Another very important aspect is the code in line 443 which force recheck for suspension in order to avoid a spurious... Marius Gligor

10:41 AM User Interface Feature #1811: implement the AJAX client driver

I tried to do as much as minimum changes in the code due to it's complexity in terms of thread synchronization.
The ... Marius Gligor

09:55 AM User Interface Feature #1811: implement the AJAX client driver

Code Review 0508b
My only concern with this update is the change to @TypeAhead@. Have you confirmed that all @Scr... Greg Shah

07:36 AM User Interface Feature #1811: implement the AJAX client driver

Marius Gligor wrote:
> Yes this is a more general issue using interactive processes on web clients see my remarks on... Constantin Asofiei

07:05 AM User Interface Feature #1811: implement the AJAX client driver

Constantin Asofiei wrote:
> Greg/Marius, something to keep in mind about shell launch on Windows: when using a web c... Marius Gligor

06:55 AM User Interface Feature #1811: implement the AJAX client driver

Greg/Marius, something to keep in mind about shell launch on Windows: when using a web client and the clients launche... Constantin Asofiei

03:46 AM User Interface Feature #1811: implement the AJAX client driver

Add also the fix for BGCOLOR and FGCOLOR in BaseEntity to use int values on setters. Marius Gligor

01:47 AM User Interface Feature #1811: implement the AJAX client driver

1. Fixed the BACKSPACE key on VT100 emulator (VT100AbstractKeyboard).
2. Fixed waiting issue in TypeAhead.suspend() Marius Gligor

11:17 AM User Interface Feature #2286: design and implement basic GUI window widget support

I attached a list with all WINDOW widget attributes more than 70!
I started to do tests using some WINDOW attributes... Marius Gligor

07:24 AM Base Language Feature #2184: create and populate the temp-table on the remote side, based on the received metad...

Stanislav Lomany wrote:
> Merged with the latest revision.
Stanislav, the logic looks good to me. Constantin Asofiei

07:09 AM Base Language Feature #2184: create and populate the temp-table on the remote side, based on the received metad...

Merged with the latest revision. Stanislav Lomany

10:01 PM Base Language Feature #2184: create and populate the temp-table on the remote side, based on the received metad...

Stas, I apologize it has taken so long for me to review this. Because of this delay, it is no longer in sync with the... Eric Faulhaber

07:02 AM Database Bug #2219: problematic dynamic query test cases

> Does this fix both variants of the problem in notes 1 & 2?
Yes.
Stanislav Lomany

10:07 PM Database Bug #2219: problematic dynamic query test cases

Code review 20140504a:
Update looks good. Please regression test and commit/distribute if it passes.
Does this ... Eric Faulhaber

03:25 AM Database Bug #2280 (WIP): Error with FIND-FIRST() method

Vadim Nebogatov

09:45 PM Database Feature #2281: enhance schema name conversion to support literal replacements

Code review 20140507a:
This update looks much better.
Regarding the implementation of the naming collision warn... Eric Faulhaber

05/07/2014

05:59 PM User Interface Feature #1783: properly handle empty UNDERLINE statements

Good. Then the important thing to do is to eliminate the output of that @;@. Take a close look at the AST and JAST ... Greg Shah

04:03 PM User Interface Feature #1783: properly handle empty UNDERLINE statements

> Is the behavior (especially AFTER the pause) the same as the 4GL?
Yes, P2J does exactly the same as 4GL. Eugenie Lyzenko

03:18 PM User Interface Feature #1783: properly handle empty UNDERLINE statements

Is the behavior (especially AFTER the pause) the same as the 4GL? Greg Shah

03:17 PM User Interface Feature #1783: properly handle empty UNDERLINE statements

... Eugenie Lyzenko

02:01 PM User Interface Feature #1783: properly handle empty UNDERLINE statements

> This is correct or not?
It is not 100% correct.
> The converted code should not contain NOP(;)?
Right. It... Greg Shah

01:38 PM User Interface Feature #1783: properly handle empty UNDERLINE statements

The current P2J code converts... Eugenie Lyzenko

05:22 PM Base Language Bug #2294: In Progress the variable initializer ignores the declared decimal precision

Constantin Asofiei wrote:
> Hynek Cihlar wrote:
> > In the converted code the only use case for setPrecision seems ... Hynek Cihlar

02:23 AM Base Language Bug #2294: In Progress the variable initializer ignores the declared decimal precision

Hynek Cihlar wrote:
> In the converted code the only use case for setPrecision seems to be the variable definition. ... Constantin Asofiei

04:04 PM Database Feature #2281: enhance schema name conversion to support literal replacements

Vadim Nebogatov wrote:
> Update vmn_upd20140507a.zip with results and used hints vmn_upd20140507b.zip attached.
Ple... Eric Faulhaber

08:02 AM Database Feature #2281: enhance schema name conversion to support literal replacements

Update vmn_upd20140507a.zip with results and used hints vmn_upd20140507b.zip attached.
Removed adding unique suffi... Vadim Nebogatov

04:02 PM User Interface Feature #1805: add missing UI method support

1) I added programmed order definition.
2) This peace of Progress doc looks strange. How the method widget can be... Vadim Gindin

02:56 PM User Interface Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects)

Committed to bzr rev #10522. Vadim Gindin

10:23 AM User Interface Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects)

Vadim, I've made some edits in the attached update: please commit and release this one. Constantin Asofiei

08:28 AM User Interface Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects)

Constantin Asofiei wrote:
> Vadim Gindin wrote:
> > 1. Simple choice is TreeMap (no external jars dependencies) and... Vadim Gindin

03:43 AM User Interface Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects)

Vadim Gindin wrote:
> 1. Simple choice is TreeMap (no external jars dependencies) and use its appropriate @containsK... Constantin Asofiei

03:34 AM User Interface Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects)

About bidirectional map implementation. That is the moment I also wanted to ask you advice about. There are possible ... Vadim Gindin

01:45 AM User Interface Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects)

Vadim Gindin wrote:
> > * conditionUpDown
> > [...]
>
> The point is that @updateFieldGroup@ methods takes @curr... Constantin Asofiei

02:55 PM Database Bug #2259 (Closed): computed character columns are not created for dynamic tables

Issue has been addressed as part of #1661. Eric Faulhaber

02:47 PM Database Feature #1661: support case-sensitive fields in indexes

Ovidiu Maxiniuc wrote:
> Where were those logs extracted from ?
My local customer server project environment.
> I ... Eric Faulhaber

02:43 PM Database Feature #1661: support case-sensitive fields in indexes

Where were those logs extracted from ? I double checked now the server logs from my regression test results and I cou... Ovidiu Maxiniuc

02:29 PM Database Feature #1661 (WIP): support case-sensitive fields in indexes

I have re-opened this task, as it appears it creates a regression with projects that use Progress metadata tables. Th... Eric Faulhaber

01:54 PM User Interface Feature #1811: implement the AJAX client driver

Perfect! Yes, that is clever. Greg Shah

01:52 PM User Interface Feature #1811: implement the AJAX client driver

Greg Shah wrote:
> Does this solution documented in section 5.13 solve the problem with @sh@?
I didn't try but I ... Marius Gligor

01:45 PM User Interface Feature #1811: implement the AJAX client driver

Does this solution documented in section 5.13 solve the problem with @sh@? Greg Shah

12:55 PM User Interface Feature #1811: implement the AJAX client driver

Changing TERMINFO seems to not work on all cases see 5.12 on this document
http://www.tldp.org/HOWTO/Keyboard-and-Co... Marius Gligor

12:48 PM User Interface Feature #1811: implement the AJAX client driver

> I changed the kbs=^H trying the following values one by one kbs=\177, kbs=\b, kbs=\011 and kbs=\EOD (kcub1)
Try ... Eugenie Lyzenko

12:20 PM User Interface Feature #1811: implement the AJAX client driver

Greg Shah wrote:
> Marius Gligor wrote:
> > Constantin Asofiei wrote:
> > > PS: something else I've forgot to ment... Eugenie Lyzenko

12:17 PM User Interface Feature #1811: implement the AJAX client driver

I'm not sure I have too much guidance here. The only thing I see is that I think the ASCII BS is @0x08@ or octal @\0... Greg Shah

11:40 AM User Interface Feature #1811: implement the AJAX client driver

I'm working to change the TERMINFO for vt100 as follow:
sudo cd /usr/share/terminfo/v/
infocmp vt100 > vt100.tmp
... Marius Gligor

10:10 AM User Interface Feature #1811: implement the AJAX client driver

Code Review 0507c
I am fine with the changes so far. One note: the VT100AbstractRenderer has the variable named @... Greg Shah

09:56 AM User Interface Feature #1811: implement the AJAX client driver

Constantin Asofiei wrote:
> Marius Gligor wrote:
> > Please try to execute this command from Swing interactive clie... Greg Shah

09:52 AM User Interface Feature #1811: implement the AJAX client driver

Marius Gligor wrote:
> Constantin Asofiei wrote:
> > PS: something else I've forgot to mention: on Windows, using a... Greg Shah

09:19 AM User Interface Feature #1811: implement the AJAX client driver

I did more tests on the customer's Windows server and I found that executing a command like:
OS-COMMAND "dir".
... Marius Gligor

08:22 AM User Interface Feature #1811: implement the AJAX client driver

Marius Gligor wrote:
> Please try to execute this command from Swing interactive client at sh prompt.
Yes, now it ... Constantin Asofiei

08:18 AM User Interface Feature #1811: implement the AJAX client driver

I searched on the Internet regarding BACKSPACE key:
1.The ^H is the normal response for VT100 terminal on response... Marius Gligor

07:00 AM User Interface Feature #1811: implement the AJAX client driver

Marius Gligor wrote:
> Regarding BACKSPACE and DELETE keys:
>
> I tried the sh command on a Konsole application:
... Constantin Asofiei

06:57 AM User Interface Feature #1811: implement the AJAX client driver

The wrap ON and OFF could be changed by keyboard sequences.
In class VT100AbstractRenderer the autoWrap was set to f... Marius Gligor

06:19 AM User Interface Feature #1811: implement the AJAX client driver

Marius Gligor wrote:
> Have you tried a sh or a /bin/bash command?
Yes, they are working. This is how it looks when... Constantin Asofiei

06:14 AM User Interface Feature #1811: implement the AJAX client driver

Have you tried a sh or a /bin/bash command?
Marius Gligor

05:57 AM User Interface Feature #1811: implement the AJAX client driver

Marius Gligor wrote:
> This are some bugs fixes for interactive client:
For some reason, when launching a process u... Constantin Asofiei

05:46 AM User Interface Feature #1811: implement the AJAX client driver

This are some bugs fixes for interactive client:
- On Windows OS if OS-COMMAND has default values the command contai... Marius Gligor

04:14 AM User Interface Feature #1811: implement the AJAX client driver

Constantin Asofiei wrote:
> Marius Gligor wrote:
> > Constantin Asofiei wrote:
> > > PS: something else I've forgo... Marius Gligor

04:03 AM User Interface Feature #1811: implement the AJAX client driver

Marius Gligor wrote:
> Constantin Asofiei wrote:
> > PS: something else I've forgot to mention: on Windows, using a... Constantin Asofiei

03:54 AM User Interface Feature #1811: implement the AJAX client driver

Constantin Asofiei wrote:
> PS: something else I've forgot to mention: on Windows, using a program with only the @DO... Marius Gligor

03:50 AM User Interface Feature #1811: implement the AJAX client driver

Marius Gligor wrote:
> So a fix should looks like:
OK, is more complex than I expected, so please fix it. Constantin Asofiei

03:47 AM User Interface Feature #1811: implement the AJAX client driver

The cmdList is constructed on ProcessDaemon.prepareCommandLine(String[])
Indeed now I saw that if cmdList is empty t... Marius Gligor

03:31 AM User Interface Feature #1811: implement the AJAX client driver

PS: something else I've forgot to mention: on Windows, using a program with only the @DOS@ command, P2J waits for a k... Constantin Asofiei

03:26 AM User Interface Feature #1811: implement the AJAX client driver

Marius, I think there is a problem in @ChuiScreenDriver.osCommand:460@:... Constantin Asofiei

05/06/2014

02:42 PM User Interface Feature #1783: properly handle empty UNDERLINE statements

The UNDERLINE statement can be specified like this:... Greg Shah

02:22 PM Base Language Bug #2147 (Closed): fix any runtime issues with format strings (server project)

Greg Shah

02:16 PM Base Language Feature #1885 (Closed): fix and add necessary format string support

Greg Shah

01:36 PM User Interface Feature #1788 (Closed): implement define rectangle and rectangle widget support

Greg Shah

01:10 PM User Interface Feature #1788: implement define rectangle and rectangle widget support

0430b - Passed regression tests. Committed revision 10519. Marius Gligor

12:43 PM User Interface Feature #1788: implement define rectangle and rectangle widget support

I restarted the regression tests both CTRL-C part and MAIN part.
This time CTRL-C part took around 58 minutes.
Also... Marius Gligor

01:10 PM User Interface Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects)

Constantin Asofiei wrote:
..
> Great. Before committing, I need to know what is the state of the TODOs which are le... Vadim Gindin

10:24 AM User Interface Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects)

Vadim Gindin wrote:
> It happen! The fixed update passed regression testing. I also made corrections corresponding t... Constantin Asofiei

03:32 AM User Interface Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects)

It happen! The fixed update passed regression testing. I also made corrections corresponding to previous note. Please... Vadim Gindin

12:46 PM Base Language Bug #2294: In Progress the variable initializer ignores the declared decimal precision

The only occurrence of @setPrecision@ is in srcnew/java/aero/timco/majic/item/Toolissu.java. There it is used the sam... Hynek Cihlar

12:37 PM Base Language Bug #2294: In Progress the variable initializer ignores the declared decimal precision

Constantin Asofiei wrote:
> I don't think is worth having both @decimal.setPrecision@ and @decimal.setLazyPrecision@... Hynek Cihlar

09:56 AM Base Language Bug #2294: In Progress the variable initializer ignores the declared decimal precision

I don't think is worth having both @decimal.setPrecision@ and @decimal.setLazyPrecision@, because there is no case wh... Constantin Asofiei

12:25 PM Base Language Bug #2133: fix precision for decimal, dynamic-extent variables

Constantin Asofiei wrote:
> As a side note, when building testcases, instead of using this:
> [...]
> you might fi... Hynek Cihlar

09:41 AM Base Language Bug #2133: fix precision for decimal, dynamic-extent variables

The changes look good.
As a side note, when building testcases, instead of using this:... Constantin Asofiei

10:43 AM Database Feature #2296: update record buffer validation to prevent database index overflow

In order to reproduce the exact Progress behavior we need to count the bytes of a index-key, the same way Progress do... Ovidiu Maxiniuc

08:06 AM Database Feature #2296: update record buffer validation to prevent database index overflow

There is no such thing a a fixed length field in Progress. Any length specification in the database is advisory (i.e... Greg Shah

09:55 AM User Interface Feature #2252: implement GUI client support

> Here is what I found looking inside the ChUI implementation.
>
> A - On server side:
> - StandardServer exports ... Greg Shah

09:08 AM User Interface Feature #2252: implement GUI client support

I have some questions related to this issue:
1. Should we follow the same model for GUI like the ChUI model (see n... Marius Gligor

09:07 AM User Interface Feature #2252: implement GUI client support

Before starting to implements the GUI model we have to describe and understand the ChUI model implementation.
Here i... Marius Gligor

09:38 AM Base Language Feature #2138: finish SEARCH-TARGET support

Greg Shah wrote:
> Great! Please check it in and distribute it.
Committed to bzr rev 10518. Constantin Asofiei

09:13 AM Base Language Feature #2138: finish SEARCH-TARGET support

Great! Please check it in and distribute it. Greg Shah

09:10 AM Base Language Feature #2138: finish SEARCH-TARGET support

Greg Shah wrote:
> 1. What is the reasoning behind the elimination of the @pushSuperProcedure()@ and @popSuperProced... Constantin Asofiei

08:42 AM Base Language Feature #2138: finish SEARCH-TARGET support

Code Review 0505a
1. What is the reasoning behind the elimination of the @pushSuperProcedure()@ and @popSuperProce... Greg Shah

04:27 AM Base Language Feature #2138: finish SEARCH-TARGET support

After the case found in #2266, the SUPER and RUN SUPER calls were re-investigated and these rules were found, for @SE... Constantin Asofiei

09:08 AM User Interface Feature #2286: design and implement basic GUI window widget support

Please put these details into the parent task. I will respond there. Greg Shah

08:58 AM User Interface Feature #2286: design and implement basic GUI window widget support

I have some questions related to this issue:

1. Should we follow the same model for GUI like the ChUI model (see no... Marius Gligor

08:53 AM User Interface Feature #2286: design and implement basic GUI window widget support

Before starting to implements the GUI model we have to describe and understand the ChUI model implementation.
Here is... Marius Gligor

03:43 AM Database Bug #2222: WRITE event triggered too early

I realized I forgot to mention one thing that I put aside because it did not fit well with my researches.
My first... Ovidiu Maxiniuc

09:49 PM Base Language Feature #1628: fix any incompatibilities or missing features of NO-ECHO support

Greg Shah wrote:
> Code Review 0502a
>
> 1. Is the @GenericFrame@ change intentionally meant to only modify the c... Evgeny Kiselev

05/05/2014

05:13 PM Database Feature #2296 (WIP): update record buffer validation to prevent database index overflow

Started implementation with initial configuration/validation and research on Progress behavior on this error. Not che... Ovidiu Maxiniuc

02:42 PM Database Feature #2281: enhance schema name conversion to support literal replacements

Vadim Nebogatov wrote:
> Actually I thought that properties and class names should meet java naming conventions.
Ge... Eric Faulhaber

01:22 PM Base Language Bug #2294: In Progress the variable initializer ignores the declared decimal precision

Please see the attached changes and provide feedback.
The solution seems to be functionally correct, however it i... Hynek Cihlar

12:54 PM Base Language Bug #2133: fix precision for decimal, dynamic-extent variables

Attached are the fixed formatting issues. Also, the related testcases are committed in the file @testcases/uast/exten... Hynek Cihlar

11:47 AM Base Language Feature #1628: fix any incompatibilities or missing features of NO-ECHO support

Code Review 0502a
1. Is the @GenericFrame@ change intentionally meant to only modify the case where @DISPLAY@ is u... Greg Shah

10:34 AM User Interface Feature #2298: temporary account creation

Change temporary accounts creation as follow:
1. On server startup, if we are configured for web clients OR for s... Greg Shah

10:19 AM User Interface Feature #2298 (New): temporary account creation

Marius Gligor

10:15 AM Database Bug #2222: WRITE event triggered too early

Most likely, you already know much of following, but I believe is better to repeat them, in the context:
To explai... Ovidiu Maxiniuc

05/04/2014

10:49 AM Database Feature #2281: enhance schema name conversion to support literal replacements

Actually I thought that properties and class names should meet java naming conventions.
I have attached vmn_upd20... Vadim Nebogatov

05:47 AM Database Bug #2219: problematic dynamic query test cases

Constantin, thank you for the idea! Stanislav Lomany

05/02/2014

07:47 PM Base Language Feature #1628: fix any incompatibilities or missing features of NO-ECHO support

This is pre review update, without doc headers.
1) @DirStream.java@ there is unnecessary new line. I'm not sure if t... Evgeny Kiselev

04:39 PM Database Feature #2296: update record buffer validation to prevent database index overflow

Since the validation algorithm will be hit quite frequently, it must be as efficient as possible:
* We should figure... Eric Faulhaber

04:28 PM Database Feature #2296: update record buffer validation to prevent database index overflow

Some notes on determining the maximum index limit to apply and whether or not to perform the validation at all:
* We... Eric Faulhaber

04:05 PM Database Feature #2296: update record buffer validation to prevent database index overflow

This task is sort of a follow-on to #2273, but is scoped slightly differently. It is meant to add some generic Progre... Eric Faulhaber

02:56 PM Database Feature #2296 (Closed): update record buffer validation to prevent database index overflow

Eric Faulhaber

03:48 PM Database Bug #2222: WRITE event triggered too early

I attached the last version of implementation. The files contain extra logging code.
Also the current set of testcas... Ovidiu Maxiniuc

02:54 PM Database Feature #1661 (Closed): support case-sensitive fields in indexes

Eric Faulhaber

10:07 AM Database Feature #2281: enhance schema name conversion to support literal replacements

I haven't had time to look at the code yet, but there seems to be something wrong with the result. The hints file has... Eric Faulhaber

08:00 AM Database Feature #2281: enhance schema name conversion to support literal replacements

Sorry, it is my fault. I worked last time with backticks, switched off to another bug fix, and did not include my pre... Vadim Nebogatov

09:52 AM Database Bug #2219: problematic dynamic query test cases

OK, please make the change. Eric Faulhaber

02:38 AM Database Bug #2219: problematic dynamic query test cases

Stanislav Lomany wrote:
> The difference between a pure @AdaptiveQuery@ and an @AdaptiveQuery@ assigned to a @QueryW... Constantin Asofiei

12:28 AM Database Bug #2219: problematic dynamic query test cases

Stanislav Lomany wrote:
> Do you think that we should convert a dynamic query using @QueryWrapper@?
Yes, assuming C... Eric Faulhaber

12:14 AM Database Bug #2219: problematic dynamic query test cases

Update for review for the original issues (except the one noted in the previous note). Stanislav Lomany

11:04 PM Database Bug #2219: problematic dynamic query test cases

Guys, we have a problem with dynamic queries which are converted to @AdaptiveQueries@. Consider testcase:... Stanislav Lomany

09:20 AM User Interface Feature #1805: add missing UI method support

While you are doing this work, please implement the MOVE-AFTER-TAB-ITEM() method and the FIRST-TAB-ITEM/NEXT-TAB-ITEM... Greg Shah

09:00 AM User Interface Feature #1805: add missing UI method support

This simple testcase is all you would need to answer your own questions:... Greg Shah

03:21 AM Base Language Bug #2133: fix precision for decimal, dynamic-extent variables

Hynek, the logic looks good, but there are some formatting issues:
* assignments.rules:
- line 229 is too long
* d... Constantin Asofiei

05/01/2014

02:55 PM User Interface Feature #1805: add missing UI method support

I read Focus Management chapter as you advised and took it into account. At this moment I just want to understand the... Vadim Gindin

02:05 PM User Interface Feature #1805: add missing UI method support

Here are my testcases for MOVE-BEFORE-TAB-ITEM attribute.
1. Simplest working case. The value is a handle one of wid... Vadim Gindin

02:32 PM User Interface Bug #2174 (Rejected): Toggle-box widget implementation abnormal end issue

This is expected behavior because the conversion and runtime support for toggle-box has not been put in place yet. F... Greg Shah

02:39 AM Database Feature #2281: enhance schema name conversion to support literal replacements

Code review 20140429a:
Unfortunately, there are some major problems with this update. Except for the escaping with... Eric Faulhaber

01:16 AM Base Language Bug #2294 (WIP): In Progress the variable initializer ignores the declared decimal precision

Hynek Cihlar