Activity
From 07/22/2014 to 08/20/2014
08/20/2014
- 05:47 PM User Interface Feature #1793: improve color support
- Enums have the advantage of being very concise in syntax and being easy to read/understand/use. The down side of usi...
- 05:44 PM User Interface Feature #1793: improve color support
- Question from MAG:
ColorPalette should holds multiple entries depending on platform Linux or Windows. ColorPalette... - 04:18 PM User Interface Feature #1791: implement dynamic UI support
- The update certainly has a regressions in frame ID handling(on client side I guess). After main syman menu displaying...
- 10:32 AM User Interface Feature #1791: implement dynamic UI support
- Sorry, I did not remove @ClientIdHelper@ from old location, so 0820a has two files with same class. Repackaged in 082...
- 09:46 AM User Interface Feature #1791: implement dynamic UI support
- Code Review 0820a
I like the changes. Well done.
> If you do not mind I'll start the runtime regression testin... - 09:42 AM User Interface Feature #1791: implement dynamic UI support
- This update for your review moves the @INPUT_FRAME_ID@ constant to @WidgetId@ class. The @WIDGET_ID_RANGE_BEGIN@ now ...
- 08:18 AM User Interface Feature #1791: implement dynamic UI support
- > I think these widgets do not have the server side counterpart because they exist only at editing time.
Yes.
>... - 09:15 AM User Interface Feature #2252: implement GUI client support
- Code Review 0820a
The changes look fine.
> Implicit Pause behaves exactly as explicit: uses CURRENT-WINDOW.
... - 02:27 AM User Interface Feature #2252: implement GUI client support
- I've tested implicit pause cases, listed in the note №160. Implicit Pause behaves exactly as explicit: uses CURRENT-W...
08/19/2014
- 06:54 PM User Interface Feature #1791: implement dynamic UI support
- Also I guess this artificial frame and fill-in will neither be in widget registry not the part of server side frame. ...
- 06:46 PM User Interface Feature #1791: implement dynamic UI support
- >Does it work? :) Please test it with standalone testcases, including shared frames.
Yes, but there is one little ... - 05:32 PM User Interface Feature #1791: implement dynamic UI support
- Code Review 0819a
I like it.
Does it work? :) Please test it with standalone testcases, including shared fra... - 03:42 PM User Interface Feature #1791: implement dynamic UI support
- This update for your review includes:
1. Methods renaming for @registerWidgetIdObject()@, @deregisterWidgetIdObject(... - 05:55 AM User Interface Feature #1791: implement dynamic UI support
- Eugenie Lyzenko wrote:
> >We can remove the @LT.activateSharedFrame()@ method completely.
>
> In this case we nee... - 05:37 AM User Interface Feature #1791: implement dynamic UI support
- >We can remove the @LT.activateSharedFrame()@ method completely.
In this case we need to move the work this method... - 10:41 PM User Interface Feature #1791: implement dynamic UI support
- > The problem here is sharedframereg is a map of <id, GenericFrame> while widget registry is a map of <id, GenericWid...
- 01:41 PM User Interface Feature #2378 (New): implements dos-hex-attribute of COLOR phrase
- 12:53 PM User Interface Feature #1793: improve color support
- These are very good findings.
> 8. I could not do tests using dos-hex-attribute on Windows ChUI (see 2-b) However ... - 12:07 PM User Interface Feature #1793: improve color support
- Here are my conclusion doing some "researches" on color implementation for ChUI and GUI interfaces on Linux OS/ Windo...
- 08:37 PM User Interface Feature #1793: improve color support
- > The valuse are stored on Windows registry and are used by Windows GUI widgets.
> I think that our GUI implementati... - 08:34 PM User Interface Feature #1793: improve color support
- Code Review 0814a
1. Line 463 of language_statements.rules has a reference to KW_FONT.
2. The progress.g change...
08/18/2014
- 07:45 PM User Interface Feature #1791: implement dynamic UI support
- >The processing of LT.replaceFrame() probably needs to remap the new frame's contained widgets into the widget regist...
- 07:22 PM User Interface Feature #1791: implement dynamic UI support
- >11. Once the client has actually hidden the frame, it will notify the server and in the LT.applyChanges() method, ...
- 05:43 PM User Interface Feature #1791: implement dynamic UI support
- >I think the sharedframereg is NOT needed after your changes. It is only used to make sure that shared frame IDs are ...
- 04:37 PM User Interface Feature #1791: implement dynamic UI support
- Eugenie Lyzenko wrote:
> >5. The deregisterFrameContent() code should still have the locking implemented...
>
> Y... - 04:35 PM User Interface Feature #1791: implement dynamic UI support
- In regard to the shared frame processing, it is quite complex. I'm not sure that our basic approach is 100% correct....
- 04:16 PM User Interface Feature #1791: implement dynamic UI support
- >5. The deregisterFrameContent() code should still have the locking implemented...
You mean @private deregisterFra... - 01:10 PM User Interface Feature #1791: implement dynamic UI support
- Code Review 0818a
1. Please rename the following:
@registerWidgetIdObject()@ to @registerWidget()@
@deregister... - 09:51 AM User Interface Feature #1791: implement dynamic UI support
- Adding some improvements in this update:
1. Deregister frame when it is destroyed
2. Adding static method to deregi... - 07:49 AM User Interface Feature #1791: implement dynamic UI support
- Checking the code with frame related testcases I have found potential issues with widget registry. This is related to...
- 04:50 PM User Interface Feature #2252: implement GUI client support
- Code Review vig_upd20140815a.zip
The only thing I would like to see changed is to move the common @hWin@ processin... - 12:57 PM User Interface Feature #2252: implement GUI client support
- Greg Shah wrote:
> I will handle the code review for vig_upd20140815a.zip shortly.
>
> > Only following statement... - 12:28 PM User Interface Feature #2252: implement GUI client support
- I will handle the code review for vig_upd20140815a.zip shortly.
> Only following statements with BEFORE-HIDE are c... - 08:01 AM User Interface Feature #2252: implement GUI client support
- Greg Shah wrote:
>
> Also, do check in your testcases.
Due to the customer server outage I have committed the t...
08/16/2014
- 06:24 PM User Interface Feature #1791: implement dynamic UI support
- This update adds more cleanup for frame deregistration. Looks like we need to remove widgets even when the frame is m...
08/15/2014
- 04:03 PM Database Feature #2376: retain bulk getter/setter methods for custom denormalized extent fields
- Test cases are checked in to testcases/uast/denormalization folder.
- 03:56 PM Database Feature #2376: retain bulk getter/setter methods for custom denormalized extent fields
- Test @testcases/uast/denormalization/bulk3@:...
- 12:42 PM Database Feature #2376: retain bulk getter/setter methods for custom denormalized extent fields
- Test @testcases/uast/denormalization/bulk2@:...
- 04:00 PM Database Feature #2134: configurable denormalization of extent fields into individual fields in schema con...
- Test cases are checked in to @testcases/uast/denormalization@ folder.
- 03:21 PM User Interface Feature #2252: implement GUI client support
- > Change the int data type to double for all existing data structures and attributes holding character coordinate val...
- 01:58 PM User Interface Feature #2252: implement GUI client support
- *About PAUSE statements list*. Only following statements with BEFORE-HIDE are correct from the Progress point of view...
- 09:09 AM User Interface Feature #2252: implement GUI client support
- I would like to do some real work (read code changes) on the GUI coordinate support (#2323). The following are the st...
- 03:15 PM User Interface Feature #1791: implement dynamic UI support
- This update for your review includes:
1. Operations with widget registry are now have protection locking
2. Addin... - 03:05 PM Base Language Feature #1628: fix any incompatibilities or missing features of NO-ECHO support
- Code Review 0812a
The proposed code can be accepted with only some minor changes (listed below).
However, I t... - 04:50 AM Base Language Feature #1628: fix any incompatibilities or missing features of NO-ECHO support
- update:
1) rollback isTerm() method
2) rollback ThinClient(described below)
3) I've added in StreamFactory next co...
08/14/2014
- 06:33 PM User Interface Feature #1791: implement dynamic UI support
- > The question: the map has data pair <Integer,GenericWidget>. On the other hand we can(and other maps uses this) use...
- 06:20 PM User Interface Feature #1791: implement dynamic UI support
- Code Review 0814b
1. The locking for the widget registry (and frame registries...) needs to be improved. Right no... - 05:12 PM User Interface Feature #1791: implement dynamic UI support
- The next update for your review contains widget ID registry implementation in addition to other notes resolution. The...
- 02:06 PM User Interface Feature #1791: implement dynamic UI support
- > May be it is better to move ClientIdHelper class to com.goldencode.p2j.ui.chui package(the same place as ThinClient...
- 02:05 PM User Interface Feature #1791: implement dynamic UI support
- Code Review 0814a
Yes, the approach is correct. Some minor feedback:
1. The @ClientIdHelper@ should be in the ... - 02:01 PM User Interface Feature #1791: implement dynamic UI support
- The question. May be it is better to move @ClientIdHelper@ class to @com.goldencode.p2j.ui.chui@ package(the same pla...
- 11:44 AM User Interface Feature #1791: implement dynamic UI support
- This update for review reflects the recent notes to using @ThinClient@ or @LogicalTerminal@ to work with ID. I need t...
- 08:37 AM User Interface Feature #1791: implement dynamic UI support
- Code Review 0813a
This version is very good.
My only concern is how this will work in certain scenarios like ... - 05:03 PM Database Feature #2220: dynamic query methods which require implementation
- >Please report the test cases you used to determine these rules and check them into the testcases project if you have...
- 11:58 AM Database Feature #2220: dynamic query methods which require implementation
- Stanislav Lomany wrote:
> I finally got caching rules for adaptive queries (single-table):
> # Cache is advanced in... - 11:41 AM Database Feature #2220: dynamic query methods which require implementation
- I finally got caching rules for adaptive queries (single-table):
# Cache is advanced in forward (if the first iterat... - 04:26 PM Database Feature #2376: retain bulk getter/setter methods for custom denormalized extent fields
- Thanks, Vadim. So, this tells us that we do not get a runtime error in Progress when invoking BUFFER-VALUE on an exte...
- 04:02 PM Database Feature #2376: retain bulk getter/setter methods for custom denormalized extent fields
- Test @testcases/uast/denormalization/bulk1@:...
- 12:54 PM User Interface Feature #2252: implement GUI client support
- Hynek Cihlar wrote:
> Constantin Asofiei wrote:
> > We need to decide what is the policy of pushing a certain widge... - 12:37 PM User Interface Feature #1793: improve color support
- Here is a first version of @COLOR-TABLE@ implementation.
The implementation of @COLOR-TABLE@ looks the same as @FONT... - 12:28 PM Database Feature #2273: address remaining limitations of SQL Server needed to support legacy 4GL behavior
- Ovidiu Maxiniuc wrote:
> The cause could be @(org.eclipse.jetty.util.component.AbstractLifeCycle:WARNING) FAILED Ser... - 08:41 AM Database Bug #2222: WRITE event triggered too early
- Code Review 0813a
I am fine with the changes.
08/13/2014
- 06:04 PM User Interface Feature #2252: implement GUI client support
- Constantin Asofiei wrote:
> We need to decide what is the policy of pushing a certain widget config to the client:
... - 09:31 AM User Interface Feature #2252: implement GUI client support
- > I will need to know not only default window from the client (static method Window.getDefaultWindow()), but also ac...
- 09:22 AM User Interface Feature #2252: implement GUI client support
- About my question 4 in the note 144. I will need to know not only default window from the client (static method @Wind...
- 05:52 PM Database Bug #2377 (New): default buffer can be incorrectly scoped to an internal procedure
- 05:47 PM Database Bug #2222: WRITE event triggered too early
- The attached update fixes a defect which enabled write triggers to corrupt the @BlockManager@'s context-local state.
... - 05:39 PM User Interface Feature #1791: implement dynamic UI support
- The point to clarify:
>Please investigate keeping a single server-side registry of all widgets, including windows,... - 04:05 PM User Interface Feature #1791: implement dynamic UI support
- Working on the point #7 from your note. But have the update to upload meantime.
In this update for review: @FrameI... - 06:28 AM User Interface Feature #1791: implement dynamic UI support
- > I think the solution can be just replacement WindowConfig.SESSION_WINDOW_ID with WidgetId.DEFAULT_WINDOW_ID in all ...
- 05:33 PM Database Feature #2376: retain bulk getter/setter methods for custom denormalized extent fields
- There appears is a hole in our current implementation of custom, denormalized extent fields, in that we have eliminat...
- 11:48 AM Database Feature #2376 (Test): retain bulk getter/setter methods for custom denormalized extent fields
- 04:35 PM Database Feature #2273: address remaining limitations of SQL Server needed to support legacy 4GL behavior
- The conversion test was successful, there are no changes in the ddl code, only the @.hbm.xml@ are affected: and extra...
- 06:17 AM Base Language Feature #1628: fix any incompatibilities or missing features of NO-ECHO support
- Evgeny Kiselev wrote:
> Also When we removed isTerm() method, there are next possible issues:
> @RemoteStream@ had ... - 06:07 AM Base Language Feature #1628: fix any incompatibilities or missing features of NO-ECHO support
- Also When we removed isTerm() method, there are next possible issues:
@RemoteStream@ had constructor @RemoteStream(in... - 06:02 AM Base Language Feature #1628: fix any incompatibilities or missing features of NO-ECHO support
- Evgeny Kiselev wrote:
> > CTRL-C part:
> > ctrlc_11_session1 step 18-28
> > ctrlc_11_session3 step 9-23, 25
> > c... - 05:55 AM Base Language Feature #1628: fix any incompatibilities or missing features of NO-ECHO support
- > CTRL-C part:
> ctrlc_11_session1 step 18-28
> ctrlc_11_session3 step 9-23, 25
> ctrlc_11_session4 step 1-26, 28
... - 04:47 AM Base Language Bug #2375: fix the memptr initialization (in extent) and memptr parameter processing
- Attached update is a first pass at fixing the problems noted in #1635 note 29,30,31,32. Testcases which cover memptr...
- 04:32 AM Base Language Bug #2375 (Closed): fix the memptr initialization (in extent) and memptr parameter processing
08/12/2014
- 07:08 PM User Interface Feature #1791: implement dynamic UI support
- > 5. The @WidgetId.allocateWindowID()@ can't work for allocating anything other than the @DEFAULT-WINDOW@, which is n...
- 10:56 AM User Interface Feature #1791: implement dynamic UI support
- Code Review 0811b
1. In WidgetId, the class javadoc states "Every JVM session has it's own set of widget ID.". Th... - 04:34 PM User Interface Feature #2252: implement GUI client support
- > Do you mean WindowWidget or exactly Window?
I mean WindowWidget.
>> 4. The external LogicalTerminal.pause*()... - 04:13 PM User Interface Feature #2252: implement GUI client support
- Greg Shah wrote:
..
> 3. @isWindowRealized()@ seems like it would be best implemented inside the @Window@ widget it... - 04:21 PM Base Language Bug #2338: fix _MSG function
- Vadim Gindin wrote:
> Constantin Asofiei wrote:
> ..
> > * QUIT/STOP/ENDKEY conditions
>
> I didn't find a way ... - 04:07 PM Base Language Bug #2338: fix _MSG function
- Constantin Asofiei wrote:
..
> * QUIT/STOP/ENDKEY conditions
I didn't find a way to test QUIT and ENDKEY conditi... - 04:01 PM Database Feature #2273: address remaining limitations of SQL Server needed to support legacy 4GL behavior
- Ovidiu Maxiniuc wrote:
> Eric Faulhaber wrote:
> > Code review 0811b:
> >
> > Looks good, but I have some questi... - 03:03 PM Database Feature #2273: address remaining limitations of SQL Server needed to support legacy 4GL behavior
- Eric Faulhaber wrote:
> Code review 0811b:
>
> Looks good, but I have some questions:
> * In the event there is ... - 10:38 AM Database Feature #2273: address remaining limitations of SQL Server needed to support legacy 4GL behavior
- Code review 0811b:
Looks good, but I have some questions:
* In the event there is no @sql-size@ hint (potentially... - 10:40 AM Database Bug #2347: hql to SQL name mapping issue
- Makes sense. So no need for a separate code review here. Once that update (0811a) is finished/tested, we can close ou...
- 10:30 AM Database Bug #2347: hql to SQL name mapping issue
- Yes, they are part of om_upd20140811a.zip (#2332).
It's hard for me to maintain them in separate updates, at some po... - 10:22 AM Database Bug #2347: hql to SQL name mapping issue
- Ovidiu, were the changes in this update rolled up into om_upd20140811a.zip (#2332)?
- 09:08 AM Base Language Feature #1635: implement MEMPTR/RAW support
- I'm fine with the proposed approach. My only concern is that I don't want us to spend too much time fixing this, as ...
- 05:03 AM Base Language Feature #1635: implement MEMPTR/RAW support
- Greg Shah wrote:
> Code Review 0811a
>
> The changes look good. When it passes testing, please check it in and d... - 08:44 AM Database Feature #2220: dynamic query methods which require implementation
- Code review 0812a:
I think it looks OK, but this whole area of the code is tricky to assess with just a review. I'... - 05:18 AM Database Feature #2220: dynamic query methods which require implementation
- Fixes for testcases in notes 28 (not about flushing part, about PREV) and 34 (LAST issue). I didn't performed extensi...
- 03:14 AM User Interface Feature #2144: add minimum runtime support for methods (server)
- passed regression testing and committed with rev 10596.
08/11/2014
- 05:14 PM User Interface Feature #2144: add minimum runtime support for methods (server)
- Code Review 0811b
I am fine with the changes. - 04:42 PM User Interface Feature #2144: add minimum runtime support for methods (server)
- next update with corrections
- 01:41 PM User Interface Feature #2144: add minimum runtime support for methods (server)
- Code Review 0811a
1. This code needs @null@ protection since @query@ can be @null@.... - 01:29 PM User Interface Feature #2144: add minimum runtime support for methods (server)
- During the work on that task I found that DESELECT-ROWS is already implemented and only some error checking was neede...
- 05:12 PM Database Feature #2273: address remaining limitations of SQL Server needed to support legacy 4GL behavior
- I have finished merging the old update with bzr rev 10595. Please see the attached update.
My simple testcases were ... - 04:26 PM Base Language Feature #1635: implement MEMPTR/RAW support
- Greg Shah wrote:
> Thoughts on how to accommodate this?
Looks like this special state is preserved until the memptr... - 01:34 PM Base Language Feature #1635: implement MEMPTR/RAW support
- > when memptr is set to unknown, the unknown equality test is computed different: it's like Schrodinger's cat, the me...
- 01:17 PM Base Language Feature #1635: implement MEMPTR/RAW support
- Code Review 0811a
The changes look good. When it passes testing, please check it in and distribute it. - 12:38 PM Base Language Feature #1635: implement MEMPTR/RAW support
- I have some weird unknown equality test using memptr... See this test:...
- 03:48 PM User Interface Feature #2252: implement GUI client support
- Constantin Asofiei wrote:
> # @ACTIVE-WINDOW@ (and maybe @CURRENT-WINDOW@ too) can be driven from the client-side; c... - 03:43 PM User Interface Feature #2252: implement GUI client support
- Greg Shah wrote:
> Code Review vig_upd20140810a.zip
Some thoughts about this update:
# instead of @UiUtils.locateP... - 03:06 PM User Interface Feature #2252: implement GUI client support
- Greg Shah wrote:
> Interesting. This is all caused by the PAGED option when the "terminal" is opened as a stream. ... - 01:21 PM User Interface Feature #2252: implement GUI client support
- Constantin Asofiei wrote:
> That is an old assumption, which is no longer valid: the widget location can't change wi... - 01:20 PM User Interface Feature #2252: implement GUI client support
- Hynek Cihlar wrote:
> Constantin Asofiei wrote:
> > The position of a widget can be set via both character-based an... - 12:41 PM User Interface Feature #2252: implement GUI client support
- Code Review vig_upd20140810a.zip
The approach is moving in the right direction.
1. I would prefer to use an @in... - 10:21 AM User Interface Feature #2252: implement GUI client support
- Code Review ca_upd20140808c.zip
The changes are OK. - 10:19 AM User Interface Feature #2252: implement GUI client support
- > The idea was that this proves that GUI still handles the PUT SCREEN. But we need to make sure that the client code ...
- 03:43 PM User Interface Feature #1791: implement dynamic UI support
- This update adds client/server session type checking into @EventDefinition.java@.
- 12:04 PM User Interface Feature #1791: implement dynamic UI support
- Forgot to add @ThinClient.java@ to previous update. Also the javadoc comments added in @WidhetId@ class.
- 11:08 AM User Interface Feature #1791: implement dynamic UI support
- The question/clarification for new ID approach update. I've found the class @EventDefinition@ is used on both on the ...
- 02:58 PM User Interface Feature #2374: implement WINDOW events in GUI mode
- From #2252 note 138:
> Doesn't it still generate the WINDOW-CLOSE 4GL event? It is very common to have code like ON ... - 02:57 PM User Interface Feature #2374 (Closed): implement WINDOW events in GUI mode
- 02:55 PM User Interface Feature #2373: implemented output to redirected, paged terminal via (un)named streams in GUI mode
- Starting from the case in #2252-141, implement output to stream when the stream is paged/page-size is set and it targ...
- 02:53 PM User Interface Feature #2373 (New): implemented output to redirected, paged terminal via (un)named streams in GU...
- 10:28 AM Base Language Feature #1628: fix any incompatibilities or missing features of NO-ECHO support
- > tc_job_002
> tc_job_clock_002
Are these the known failures as described in our documentation?
The other prob... - 09:51 AM Base Language Feature #1628: fix any incompatibilities or missing features of NO-ECHO support
- Greg Shah wrote:
> We need to get this through testing. Are there any tests which are always failing?
CTRL-C part:... - 09:48 AM Base Language Feature #1628: fix any incompatibilities or missing features of NO-ECHO support
- OK, then we need to leave the code as:...
- 09:39 AM Base Language Feature #1628: fix any incompatibilities or missing features of NO-ECHO support
- In @StreamWrapper@ with next code: ...
- 10:09 AM User Interface Feature #2372: implement support for PUT SCREEN in GUI
- Although PUT SCREEN is documented (in the 4GL reference) as not working in GUI, in fact it can be used. However, its...
- 09:54 AM User Interface Feature #2372 (New): implement support for PUT SCREEN in GUI
- 09:03 AM Database Bug #2350 (Closed): BUFFER-COPY errors related with copying fields with extent
- 08:44 AM Database Bug #2350: BUFFER-COPY errors related with copying fields with extent
- update [vmn_upd20140807a.zip] committed to bzr rev. 10595 and distributed.
- 07:45 AM Database Bug #2350: BUFFER-COPY errors related with copying fields with extent
- Please commit and distribute the 0807a update.
- 05:30 AM Database Bug #2350: BUFFER-COPY errors related with copying fields with extent
- Regression completed: @tc_job_clock_002@ finally passed in 20140810_163259.
- 02:09 AM Database Support #2371: trigger behavior
- h1. Database Trigger Firing Rules
h2. General Sequence
Session triggers generally fire before schema triggers, EXCE... - 12:28 AM Database Support #2371 (Closed): trigger behavior
08/10/2014
- 06:50 PM User Interface Feature #1791: implement dynamic UI support
- The update is the new widget ID allocation approach for you to review. Does not include the dynamic widget ID support...
- 04:05 PM Database Bug #2350: BUFFER-COPY errors related with copying fields with extent
- Regression 20140810_120027: failed tc_job_002, tc_job_clock_002 from previous regression. Will repeat regression one ...
- 12:53 PM User Interface Feature #2252: implement GUI client support
- Here is the first skeleton of implementation system handles ^-WINDOW. Could you look at it. I've added window Id para...
08/09/2014
- 06:42 PM Database Bug #2350: BUFFER-COPY errors related with copying fields with extent
- Regression 20140809_123827: failed tc_job_002, tc_job_clock_002 from previous regression. Will repeat regression one ...
- 06:09 PM User Interface Feature #2252: implement GUI client support
- Constantin Asofiei wrote:
> The position of a widget can be set via both character-based and pixel-based coordinates...
08/08/2014
- 04:25 PM User Interface Feature #2252: implement GUI client support
- I would summarize behavior rules of *-WINDOW system handles as follows.
Handles itself.
1. When the 4GL starts,... - 03:56 PM User Interface Feature #2252: implement GUI client support
- Greg Shah wrote:
> > There were two reasons I've changed them this way:
> No, your reasons make sense. Please put ... - 08:52 AM User Interface Feature #2252: implement GUI client support
- Two other thoughts:
1. When the ui/chui/ code reaches a state where:
* It only has ChUI-specific code left in i... - 08:30 AM User Interface Feature #2252: implement GUI client support
- Code Review 0808b
My only concern is with the previous @ThinClient.waitForEvent()@ change:
1. Why isn't @honorS... - 07:08 AM User Interface Feature #2252: implement GUI client support
- > add multiple driver support at runtime, to allow writing to streams. This is somehow tricky, as same widget can be ...
- 06:51 AM User Interface Feature #2252: implement GUI client support
- > > 4. Why are the @ChuiWidgetFactory@ and @GuiWidgetFactory@ classes modifying the return value signature to be the ...
- 06:32 AM User Interface Feature #2252: implement GUI client support
- Greg Shah wrote:
> 1. The @ProcessStream@ history entry is not accurate. You are removing the unnecessary TC import... - 03:17 PM User Interface Feature #2370: finish window popup menu impl
- The window popup (shown at mouse right-click on the window title or mouse click on window icon or alt+space) needs to...
- 03:15 PM User Interface Feature #2370 (Closed): finish window popup menu impl
- 03:15 PM User Interface Feature #2369: add configuration for window details inherited from the OS (title, border, color, ...
- See #2252 note 127. The widow details (like title font, color, icon, border, background, etc) need to be made config...
- 03:14 PM User Interface Feature #2369 (Rejected): add configuration for window details inherited from the OS (title, bord...
- 03:13 PM User Interface Feature #2368: allow widget output to stream in GUI mode
- In GUI mode, writing widget to streams requires access to a ChUI driver. See #2252-127.
- 03:11 PM User Interface Feature #2368 (WIP): allow widget output to stream in GUI mode
- 02:10 PM User Interface Feature #1791: implement dynamic UI support
- > The ID will be incrementing for new widget?
Yes.
> Meaning allocation direction from 1 to UPPER_LIMIT, correc... - 11:54 AM User Interface Feature #1791: implement dynamic UI support
- > I am interested in the results of your PAUSE version. But we already have enough knowledge to know that there are m...
- 09:18 AM User Interface Feature #1791: implement dynamic UI support
- I am interested in the results of your PAUSE version. But we already have enough knowledge to know that there are mo...
- 07:11 AM User Interface Feature #1791: implement dynamic UI support
- > Make sure to run this directly from the command line (with @-p@) instead of from the procedure editor. The procedu...
- 06:36 AM User Interface Feature #1791: implement dynamic UI support
- Eugenie, check if this limit is not somehow related to some @pro@ arguments. At least for recursivity issues, I've f...
- 06:15 AM User Interface Feature #1791: implement dynamic UI support
- > I made simple creation loop without delete. The results vary from run to run. The maximum I've got is 9972 creatio...
- 05:46 AM User Interface Feature #1791: implement dynamic UI support
- The process of ID saturation has some notes. I made simple creation loop without delete. The results vary from run to...
- 02:07 PM Database Bug #2350: BUFFER-COPY errors related with copying fields with extent
- Regression 20140808_092455: failed tc_job_002, tc_job_clock_002 from previous regression. Will repeat "main-regressio...
- 02:00 PM Base Language Feature #1635: implement MEMPTR/RAW support
- > Or raw/memptr values with no data are considered not-unknown?
raw/memptr has a concept of "uninitialized". For ... - 11:51 AM Base Language Feature #1635: implement MEMPTR/RAW support
- There is a bug in the BinaryData.assign code; if a raw/memptr value is set to unknown and then assigned to something ...
- 01:49 PM Base Language Bug #2367: re-connecting an appserver agent after a hard client termination
- Eric: yes, both set to 1:...
- 01:08 PM Base Language Bug #2367: re-connecting an appserver agent after a hard client termination
- Ovidiu: this was achieved with @min_agents@ and @max_agents@ both set to 1, correct?
- 01:03 PM Base Language Bug #2367: re-connecting an appserver agent after a hard client termination
- Ovidiu, please try to duplicate again, and capture the server thread dump (use @jstack@ for this). I'm curious where...
- 01:01 PM Base Language Bug #2367: re-connecting an appserver agent after a hard client termination
- When a client abruptly terminate (killed or otherwise disconnected because of network failure) the appserver enters a...
- 12:43 PM Base Language Bug #2367 (Closed): re-connecting an appserver agent after a hard client termination
- 10:26 AM Base Language Feature #1628: fix any incompatibilities or missing features of NO-ECHO support
- I edited the previous note to fix the logic I had broken...
- 10:24 AM Base Language Feature #1628: fix any incompatibilities or missing features of NO-ECHO support
- Code Review 0805a
I agree that an alternate approach in StreamWrapper seems more correct.
> StreamWrapper line 404:... - 05:51 AM Base Language Feature #1628: fix any incompatibilities or missing features of NO-ECHO support
- ctrc part passed
main part failed, but problem was in testsuit, now tests are running again.
different from previ...
08/07/2014
- 07:09 PM User Interface Feature #2252: implement GUI client support
- Code Review 0806d
This is a really great step forward for the client! I was already deep into this review before ... - 02:21 PM User Interface Feature #2252: implement GUI client support
- Replacement for ca_upd20140806d.zip. It fixes a bug exposed by regression testing (related to 0806d.zip) plus:
* cur... - 11:42 AM User Interface Feature #2252: implement GUI client support
- Constantin Asofiei wrote:
> > It seems that character positioning and sizing is always performed with the default fo... - 11:04 AM User Interface Feature #2252: implement GUI client support
- Hynek Cihlar wrote:
> Constantin Asofiei wrote:
> > Once you have this, see what happens if the widget is moved to ... - 10:41 AM User Interface Feature #2252: implement GUI client support
- Hynek Cihlar wrote:
> Greg Shah wrote:
> > > What is the correct way to move a widget from one window to another?
... - 10:35 AM User Interface Feature #2252: implement GUI client support
- Greg Shah wrote:
> > What is the correct way to move a widget from one window to another?
>
> The f1 frame is nev... - 10:32 AM User Interface Feature #2252: implement GUI client support
- > What is the correct way to move a widget from one window to another?
The f1 frame is never realized before the @... - 10:10 AM User Interface Feature #2252: implement GUI client support
- Constantin Asofiei wrote:
> Once you have this, see what happens if the widget is moved to a window with a different... - 06:15 PM Database Bug #2350: BUFFER-COPY errors related with copying fields with extent
- Regression 20140807_101619: failed tc_job_002, tc_job_clock_002, gso178_session1, gso178_session2, gso242_session1, g...
- 03:03 PM User Interface Feature #1791: implement dynamic UI support
- Interesting. We won't implement this feature right now.
Since we can't "see" the widget IDs that are generated in... - 01:21 PM User Interface Feature #1791: implement dynamic UI support
- >Probably so. Before I say for sure, please do this test: run the same test without the -usewidgetid and see if it be...
- 11:55 AM User Interface Feature #1791: implement dynamic UI support
- > This means Progress has serious constraint for using dynamic widgets
Yes.
> often delete/create is not recomm... - 10:41 AM User Interface Feature #1791: implement dynamic UI support
- Yes, you are right, just after attempt to create new widget in "wrap around" case - when widget with @ID = 1@ was jus...
- 10:16 AM User Interface Bug #2365: ThinClient.trigger() and ThinClient.validate() must send the screen-buffer for all fra...
- The original discussion in which this issue was identified:
-------- Original Message --------
Subject: Re: GUI ... - 10:14 AM User Interface Bug #2365 (Closed): ThinClient.trigger() and ThinClient.validate() must send the screen-buffer fo...
08/06/2014
- 06:05 PM Database Bug #2350: BUFFER-COPY errors related with copying fields with extent
- Corrected update vmn_upd20140807a.zip is attached. Tests still work properly, search API (#2353) also works.
Regres... - 03:41 PM Database Bug #2350: BUFFER-COPY errors related with copying fields with extent
- Code review 20140806b:
Line 2790 catches @ConditionException@ instead of @ErrorConditionException@, as I requested... - 02:02 PM Database Bug #2350: BUFFER-COPY errors related with copying fields with extent
- Corrected update vmn_upd20140806b.zip is attached, test results for note 27 are like in Progress. Regression started.
- 10:13 AM Database Bug #2350: BUFFER-COPY errors related with copying fields with extent
- Code review 20140806a:
Please note the path of the source file in the zip archive is missing the leading @src/@ di... - 10:07 AM Database Bug #2350: BUFFER-COPY errors related with copying fields with extent
- Your test results, where we are not returning a result for 2, 4, and 5 (while Progress returns false) tells me that w...
- 09:09 AM Database Bug #2350: BUFFER-COPY errors related with copying fields with extent
- Please check attached @buffer-compare-pair-list.p@. Execution results:
h3. Progress... - 09:08 PM Database Bug #2350: BUFFER-COPY errors related with copying fields with extent
- Code review 20140805a:
* As noted above, the @if@ condition at line 3662 should drop the BUFFER-COMPARE-specific p... - 08:29 PM Database Bug #2350: BUFFER-COPY errors related with copying fields with extent
- Vadim Nebogatov wrote:
> Eric Faulhaber wrote:
> > Yes, it looks like that length restriction is wrong; I'm not sur... - 05:18 PM User Interface Feature #1791: implement dynamic UI support
- > But now we need to differentiate the server and client context for this calculation because classes used in this pr...
- 05:16 PM User Interface Feature #1791: implement dynamic UI support
- > So when I got 1 number the next creation shows the error message and existed widgets disappears.
This is not exa... - 05:09 PM User Interface Feature #1791: implement dynamic UI support
- Another issue we need to solve in P2J implementation is the new implementation for @WidgetId.frameIdFromWidgetId(int ...
- 04:19 PM User Interface Feature #2252: implement GUI client support
- Greg, attached is a massive update which touches more than the window title. The GUI window is a little ugly at this...
- 08:49 AM User Interface Feature #2252: implement GUI client support
- Code Review vig_upd20140806a.zip
1. Can ACTIVE-WINDOW really be assigned from business logic? Your code allows it... - 08:14 AM User Interface Feature #2252: implement GUI client support
- > To add some real behavior (for ENABLE, MESSAGE and other statements) I need to know the future GUI client class. Wi...
- 05:28 AM User Interface Feature #2252: implement GUI client support
- I just added new fields to @LogicalTerminal@ class. To add some real behavior (for ENABLE, MESSAGE and other statemen...
- 12:32 PM Database Feature #2220: dynamic query methods which require implementation
- Stanislav Lomany wrote:
> Found this in AdaptiveQuery javadoc:
> [...]
Yes, I wrote that. All such cases are con... - 12:07 PM Database Feature #2220: dynamic query methods which require implementation
- Found this in AdaptiveQuery javadoc:...
08/05/2014
- 05:48 PM Database Bug #2350: BUFFER-COPY errors related with copying fields with extent
- I have attached next update vmn_upd20140805a.zip tested with @#2353@ and @buffer-copy-pair-list.p@ from note 18. Both...
- 04:09 PM Database Bug #2350: BUFFER-COPY errors related with copying fields with extent
- I just noticed that message ...
- 03:36 PM User Interface Feature #2252: implement GUI client support
- Vadim Gindin wrote:
> If you meant conversion rules, they already formulated for the corresponding task for CHUI cas... - 03:32 PM User Interface Feature #2252: implement GUI client support
- If you meant conversion rules, they already formulated for the corresponding task for CHUI case. I'm trying to add ju...
- 03:19 PM User Interface Feature #2252: implement GUI client support
- Vadim Gindin wrote:
> I tried to run _change_parent_frame.p_ with gui swing driver.
The swing gui driver is very-v... - 03:13 PM User Interface Feature #2252: implement GUI client support
- I tried to run _change_parent_frame.p_ with gui swing driver. I added some UI components stubs for that, but I faced ...
- 01:33 PM Database Feature #2359: automated maintenance of database support files
- Current implementation of custom functions exposed in SQL queries uses some additional files that, even if they rarel...
- 01:18 PM Database Feature #2359 (New): automated maintenance of database support files
- 01:14 PM Database Feature #2358: HQLPreprocessor and dialect specific functions
- At this moment @HQLPreprocessor@ must preprocess the HQL code depending on the dialect.
The @rtrim@ function is rep... - 01:03 PM Database Feature #2358 (WIP): HQLPreprocessor and dialect specific functions
08/04/2014
- 07:15 PM Base Language Feature #1628: fix any incompatibilities or missing features of NO-ECHO support
- merged with latest revision (ThinClient class)
Regression testing failed with 10 tests in main part and 3 tests in c... - 07:11 PM Database Bug #2350: BUFFER-COPY errors related with copying fields with extent
- [ECF: moved content of this note to #2353, note 13]
- 11:12 AM Database Bug #2350: BUFFER-COPY errors related with copying fields with extent
- Eric Faulhaber wrote:
> Yes, it looks like that length restriction is wrong; I'm not sure why I came up with that.
... - 10:42 AM Database Bug #2350: BUFFER-COPY errors related with copying fields with extent
- Vadim Nebogatov wrote:
> Condition RecordBuffer, 3661
>
> ... - 10:58 PM Database Bug #2350: BUFFER-COPY errors related with copying fields with extent
- Code review 20140803a:
It seems this code will work, but I'm wondering about some choices:
* By adding @getSize@ ... - 04:39 PM User Interface Feature #1791: implement dynamic UI support
- >How did you determine that this was the behavior?
Consider the testcase @dyn_wid_test6.p@. It has two pair of but... - 03:39 PM User Interface Feature #1791: implement dynamic UI support
- > If there are the dynamic widgets allocated at this time - they will be destroyed. So we returning to the state when...
- 02:17 PM User Interface Feature #1791: implement dynamic UI support
- The investigation findings:
1. The starting point for ID allocation is 65535. Neither 0 nor 1. And more important ... - 09:10 AM Conversion Tools Bug #2357: callgraph - set schema triggers as entry points
- Since these triggers are explicitly coded into the schema file, we must assume these are valid entry points and autom...
- 07:33 AM Conversion Tools Bug #2357: callgraph - set schema triggers as entry points
- Original issue is in #2260 note 14.
- 07:33 AM Conversion Tools Bug #2357: callgraph - set schema triggers as entry points
- Currently schema trigger procedures are not automatically set as entry points - they need to be manually added to the...
- 07:31 AM Conversion Tools Bug #2357 (New): callgraph - set schema triggers as entry points
- 08:55 AM Database Feature #2220: dynamic query methods which require implementation
- While working on the LAST issue, I've looked into invalidation logic for adaptive queries. I think it's a bit doubtfu...
- 07:37 AM Conversion Tools Feature #2251: improve the call graph generation
- 0715d.zip was released as rev 10593.
Tasks #2356 and #2357 were added for the issues in #2260. - 07:30 AM Conversion Tools Bug #2356: pphints bug - nested includes are missing from the.pphints file
- Cases like this:...
- 07:28 AM Conversion Tools Bug #2356 (New): pphints bug - nested includes are missing from the.pphints file
08/03/2014
- 06:17 PM Database Bug #2350: BUFFER-COPY errors related with copying fields with extent
- Condition RecordBuffer, 3661...
- 07:27 AM Database Bug #2350: BUFFER-COPY errors related with copying fields with extent
- I have attached update vmn_upd20140803a.zip with fixes issues from Eric review and fix from Stas.
08/02/2014
- 10:05 AM Database Bug #2350: BUFFER-COPY errors related with copying fields with extent
- Eric Faulhaber wrote:
> I noticed you prepended @opType == OperationType.COPY &...@ to the @if@ condition at line 38... - 09:24 AM Database Bug #2350: BUFFER-COPY errors related with copying fields with extent
- Code review 20140802a:
Please log a warning inside the catch block at line 3829, rather than eating the exception.... - 08:19 AM Database Bug #2350: BUFFER-COPY errors related with copying fields with extent
- Attached vmn_upd20140802a.zip with corrections according review (note 13) merged with latest bzr revision 10592.
08/01/2014
- 06:34 PM Database Bug #2350: BUFFER-COPY errors related with copying fields with extent
- Code review 20140801a:
* The use of @TempTableBuilder.getExtentSize@ at lines 3812 and 3814 does not look correct.... - 04:52 PM Database Bug #2350: BUFFER-COPY errors related with copying fields with extent
- vmn_upd20140729a.zip merged with latest bzr revision 10591 to vmn_upd20140801a.zip.
- 04:51 PM Database Feature #2220: dynamic query methods which require implementation
- OK, but that doesn't look like a flushing issue to me, so I guess we will stay out of each others' way on this one.
- 04:44 PM Database Feature #2220: dynamic query methods which require implementation
- This issue I have to fix. LAST just do not work for adaptive queries....
- 03:55 PM Database Feature #2220: dynamic query methods which require implementation
- No problem about having this issue. I just need to consider it when making testcases.
- 03:24 PM Database Feature #2220: dynamic query methods which require implementation
- Stanislav Lomany wrote:
> BTW, P2J includes records in both PREV cases.
I am working on a flush/validate fix that I... - 03:19 PM Database Feature #2220: dynamic query methods which require implementation
- You are right - it is about flushing.
>Are you saying they both include the 0 record or they both exclude it?
Inc... - 03:08 PM Database Feature #2220: dynamic query methods which require implementation
- Stanislav Lomany wrote:
> There is no difference in testcases output if the queries are iterated in the forward dire... - 03:06 PM Database Feature #2220: dynamic query methods which require implementation
- I think what's happening here is that nothing is releasing/flushing the newly created record from buffer @xtt@ before...
- 02:51 PM Database Feature #2220: dynamic query methods which require implementation
- Strange case. Testcase 1:...
- 10:12 AM Database Feature #2220: dynamic query methods which require implementation
- BTW, there is an issue with dynamic queries you probably aware of. Creation of a record using a backing buffer of a d...
- 04:02 PM User Interface Feature #1791: implement dynamic UI support
- We can at least use it for now to see how Progress creates its widget ids. Yes, it only works on GUI and without it ...
- 03:56 PM User Interface Feature #1791: implement dynamic UI support
- The only I've found is @WIDGET-ID@ attribute. But it is declared as working only in Windows GUI. Is it what we implem...
- 03:48 PM User Interface Feature #1791: implement dynamic UI support
- >From what I have seen, the Progress widget ID allocation approach is a simple sequential increment. Can you find any...
- 03:02 PM User Interface Feature #1791: implement dynamic UI support
- Code Review 0731a
We can't use this approach.
First of all, widget ID allocation will be used on the server. ... - 03:30 PM User Interface Feature #2252: implement GUI client support
- Greg Shah wrote:
> > I'm trying to display this frame in every of these windows using DISPLAY .. IN WINDOW statemen... - 11:59 AM User Interface Feature #2252: implement GUI client support
- ca_upd20140731a.zip was released as bzr rev 10589.
- 10:06 AM User Interface Feature #2252: implement GUI client support
- Greg Shah wrote:
> I will let you and Constantin split the work on this one, as you find makes the most sense. Your... - 10:00 AM User Interface Feature #2252: implement GUI client support
- Constantin wrote:
> I think we should do it before or at the same time with the #2323, but after my first iteration... - 05:56 AM User Interface Feature #2252: implement GUI client support
- Constantin Asofiei wrote:
> > _Note that character units are decimal values and pixels are integer values in Progres... - 05:03 AM User Interface Feature #2252: implement GUI client support
- Constantin Asofiei wrote:
> Greg/Hynek, something about the character and pixel units. I think these metrics can ori... - 04:59 AM User Interface Feature #2252: implement GUI client support
- > Greg Shah wrote:
> > I wonder if this is also the time when we pursue #2254.
> Yes, I think we need to do this.... - 02:34 PM Conversion Tools Feature #2251: improve the call graph generation
- Code Review 0715d
The changes look good. I especially like that edge listing tool. No regression testing is need... - 12:09 PM Conversion Tools Feature #2251: improve the call graph generation
- This is an update which fixes some problems related to schema triggers: the main problem here is that the ASTs for th...
- 12:49 PM Base Language Feature #1628: fix any incompatibilities or missing features of NO-ECHO support
- Evgeny Kiselev wrote:
> Do I need to specify in @com.goldencode.p2j.util.StreamDaemon#openTerminalStream@ page size ... - 12:32 PM Base Language Feature #1628: fix any incompatibilities or missing features of NO-ECHO support
- Constantin Asofiei wrote:
> Evgeny, about 0731a.zip: the @StreamFactory.openTerminalStream(boolean, int, boolean)@ n... - 03:54 AM Base Language Feature #1628: fix any incompatibilities or missing features of NO-ECHO support
- Evgeny, about 0731a.zip: the @StreamFactory.openTerminalStream(boolean, int, boolean)@ needs to return NULL only if t...
- 12:46 PM Database Feature #2273: address remaining limitations of SQL Server needed to support legacy 4GL behavior
- Code review 20140408a:
Changes look good. Unfortunately (my fault), the update is now way out of date with the lat... - 09:59 AM Database Feature #2273: address remaining limitations of SQL Server needed to support legacy 4GL behavior
- Eric Faulhaber wrote:
> Sorry I lost track of this. Does this update need separate review, or have these changes bee... - 09:53 AM Database Feature #2273: address remaining limitations of SQL Server needed to support legacy 4GL behavior
- Ovidiu Maxiniuc wrote:
> Reuploaded the update after merging with latest bzr revision (10506).
Sorry I lost track o... - 10:20 AM Database Feature #2148: enhance prototype to compile p2jpl.jar file with IKVMC into .NET assembly and load...
- Eric Faulhaber wrote:
> What is the status of the issues described in and the update attached to note 4? This effort... - 09:50 AM Database Feature #2148: enhance prototype to compile p2jpl.jar file with IKVMC into .NET assembly and load...
- What is the status of the issues described in and the update attached to note 4? This effort seems to have merged wit...
07/31/2014
- 06:10 PM Base Language Feature #1628: fix any incompatibilities or missing features of NO-ECHO support
- final version with properly conversion
merged with latest bzr revision - 09:16 AM Base Language Feature #1628: fix any incompatibilities or missing features of NO-ECHO support
- Evgeny: please merge 0728a.zip with the latest bzr revision - #2352 has changes which need to be merged.
- 05:32 PM User Interface Feature #1791: implement dynamic UI support
- This update for your review is the starting point for new widget approach. The public method in @WidgetId@ class:
<p... - 05:24 PM User Interface Feature #2252: implement GUI client support
- Greg Shah wrote:
> I wonder if this is also the time when we pursue #2254.
Yes, I think we need to do this. Bett... - 04:30 PM User Interface Feature #2252: implement GUI client support
- > create APIs to push only that config to the client (i.e. only the window title, not the full config)
We don't wa... - 04:11 PM User Interface Feature #2252: implement GUI client support
- Greg, my goal would be to provide full bi-directional support of these coordinate/size attributes; but if the client ...
- 01:14 PM User Interface Feature #2252: implement GUI client support
- Greg/Hynek, something about the character and pixel units. I think these metrics can originate from two directions:
... - 10:16 AM User Interface Feature #2252: implement GUI client support
- Code Review 0731a
It looks good. You can check-in and distribute, if you are comfortable with the level of testing. - 09:27 AM User Interface Feature #2252: implement GUI client support
- replacement for 0729a.zip: fixed the ScreenBitmap problems related to using lists of activated rectangles instead of ...
- 11:01 AM Database Feature #2207: Remaining issues for dynamic buffers and dynamic tables
- Since none of these use cases are known to be in the current project, I am unassigning the milestone target.
- 08:49 AM Database Feature #2220: dynamic query methods which require implementation
- About caching. So far I can state that:
1. Adaptive scrolling queries have recid-based cache which is populated as w... - 08:15 AM Database Feature #2220: dynamic query methods which require implementation
- Regarding the question if scrolling adaptive queries are modified with @DELETE-RESULT-LIST-ENTRY@ in the customer app...
07/30/2014
- 05:34 PM Database Bug #2350: BUFFER-COPY errors related with copying fields with extent
- Eric Faulhaber wrote:
> Vadim Nebogatov wrote:
> > Attached @buffer-copy-dyn-static-tt-no-display.p@ with added new... - 05:23 PM Database Bug #2350: BUFFER-COPY errors related with copying fields with extent
- Vadim Nebogatov wrote:
> NonUniqueObjectException in note 3 thrown in code RecordBuffer, 9922:
>
> [...]
>
> A... - 05:12 PM Database Bug #2350: BUFFER-COPY errors related with copying fields with extent
- Vadim Nebogatov wrote:
> Attached @buffer-copy-dyn-static-tt-no-display.p@ with added new @22-29@ tests.
Please c... - 03:23 PM Database Bug #2350: BUFFER-COPY errors related with copying fields with extent
- NonUniqueObjectException in note 3 thrown in code RecordBuffer, 9922:...
- 11:57 AM Database Bug #2350: BUFFER-COPY errors related with copying fields with extent
- See #2353, note 1.
- 10:46 AM Database Bug #2337 (Closed): trigger scanning defect
- 10:46 AM Database Bug #2344 (Closed): invalid scoping for dynamic buffers
- 10:04 AM Database Bug #2344 (Review): invalid scoping for dynamic buffers
- Regression-tested. Committed to bzr rev 10586.
07/29/2014
- 02:14 PM Database Bug #2347 (WIP): hql to SQL name mapping issue
- The provided solution uses @HQLFunction@ annotation to make available at runtime the name of the function used in gen...
- 01:58 PM User Interface Feature #2252: implement GUI client support
- > The code is correct, unless I got the coordinate system wrong. My assumption is that origin is on (top, left) corne...
- 11:58 AM User Interface Feature #2252: implement GUI client support
- Greg Shah wrote:
> Code Review ca_upd20140729a
>
> Shouldn't it be @rect.left - baseUnit <= left@ and @rect.right... - 11:25 AM User Interface Feature #2252: implement GUI client support
- Code Review ca_upd20140729a
1. In @Rectangle.difference()@, is this code correct?... - 11:13 AM User Interface Feature #2252: implement GUI client support
- Copied from #2340, posted by Constantin:
This version switches from a matrix bitmap to a list of activated rectang... - 09:10 AM User Interface Feature #2252: implement GUI client support
- Greg Shah wrote:
> As far as I can tell, the flow/rules of the layout are the same for GUI and ChUI, but because of ... - 09:02 AM User Interface Feature #2252: implement GUI client support
- > I'm trying to display this frame in every of these windows using DISPLAY .. IN WINDOW statement. After execution o...
- 08:57 AM User Interface Feature #2252: implement GUI client support
- > The mapping function for ChUI will be a simple 1 Character = 1 Pixel, for GUI the mapping logic will include some f...
- 06:12 AM User Interface Feature #2252: implement GUI client support
- Hynek Cihlar wrote:
> Also I had the impression that the font-table is allocated per session.
The font-table is ass... - 06:05 AM User Interface Feature #2252: implement GUI client support
- Hynek Cihlar wrote:
> Are you saying that we may not know the type/resolution of the UI for a particular session or ... - 05:53 AM User Interface Feature #2252: implement GUI client support
- Constantin Asofiei wrote:
> > Ad (2)
> > All coordinate values should be stored only in the pixel units.
> I don't... - 04:18 AM User Interface Feature #2252: implement GUI client support
- Greg Shah wrote:
> > 4) Unrealized windows case. There are created default window for the external procedure that ow... - 03:08 AM User Interface Feature #2252: implement GUI client support
- Hynek Cihlar wrote:
> Ad (1)
> The proper type system is not surprisingly one of the key ingredients. Nothing new h... - 08:19 PM User Interface Feature #2252: implement GUI client support
- Here are some first thoughts regarding the refactoring of coordinate system - #2323..
From what I have seen in the... - 01:55 PM Base Language Feature #1628: fix any incompatibilities or missing features of NO-ECHO support
- Code Review 0728a
I am fine with the changes. - 01:11 PM Base Language Feature #1628: fix any incompatibilities or missing features of NO-ECHO support
- Fixed everything from note 63 except conversion rules.
- 01:23 PM User Interface Feature #1790: implement menu support
- Greg Shah wrote:
> > I need to properly conversion for next line:
> > [...]
> > This code add menu to current wind... - 01:22 PM User Interface Feature #1790: implement menu support
- > I need to properly conversion for next line:
> [...]
> This code add menu to current window
Hopefully you only... - 01:13 PM User Interface Feature #1790: implement menu support
- Greg Shah wrote:
> I don't want to duplicate effort here. What do you need to add right now?
I need to properly co... - 12:47 PM Database Bug #2350: BUFFER-COPY errors related with copying fields with extent
- I have attached update vmn_upd20140729a.zip fixing all these cases excepting one problem, it seems not directly relat...
- 09:28 AM Base Language Bug #2348 (Closed): unable to find internal procedure from database session trigger
- 09:01 AM Base Language Bug #2348 (Review): unable to find internal procedure from database session trigger
- 0729a.zip was committed to bzr rev 10584. This can be closed.
- 08:54 AM Base Language Bug #2348: unable to find internal procedure from database session trigger
- Great! Please go ahead and release this as is. Thanks for the quick turnaround.
- 03:43 AM Base Language Bug #2348 (WIP): unable to find internal procedure from database session trigger
- This should fix your case. The problem was that the DB trigger invocation code was not pushing the trigger's externa...
- 09:13 AM User Interface Feature #2308 (Closed): remote client launch
- 08:14 AM User Interface Feature #2340: implement the window title bar
- This version switches from a matrix bitmap to a list of activated rectangles. This allows a more dynamic approach of...
07/28/2014
- 05:11 PM User Interface Feature #2252: implement GUI client support
- > 2) Dialog frames. It's hard to classify this case because dialogs are not visually related to it's parent window.
... - 04:48 PM Database Bug #2350 (WIP): BUFFER-COPY errors related with copying fields with extent
- 04:34 PM Database Bug #2350: BUFFER-COPY errors related with copying fields with extent
- Attached @buffer-copy-dyn-static-tt-no-display.p@ with added new @22-29@ tests.
h3. Progress results... - 04:31 PM Database Bug #2350 (Closed): BUFFER-COPY errors related with copying fields with extent
- 02:50 PM Base Language Bug #2348: unable to find internal procedure from database session trigger
- I've come across an unexpected stop condition invoking an internal procedure from a database session trigger in P2J:
... - 02:47 PM Base Language Bug #2348 (Closed): unable to find internal procedure from database session trigger
- 02:32 PM Database Bug #2347: hql to SQL name mapping issue
- Consider the following Progress code sample:...
- 01:49 PM Database Bug #2347 (Closed): hql to SQL name mapping issue
- 01:28 PM User Interface Feature #1791: implement dynamic UI support
- Sorry it has taken me so long to review your results.
> As general considerations: Currently we encode the frame I... - 12:46 PM User Interface Feature #1793: improve color support
- I fixed the issue by using OE 10.2b instead OE 11.3, thanks Constantin.
- 12:18 PM User Interface Feature #1793: improve color support
- Today I tried again to use OpenEdge for Windows on customer server.
Unfortunately I cannot use both ChUI and GUI Ope... - 11:15 AM User Interface Feature #1790: implement menu support
- Please post your current code for an early review. Your status report noted this:
> 2) added conversion for curre... - 11:02 AM Base Language Feature #2196: implement proper resource deletion of resources created in a procedure ran persistent
- 0728a.zip passed testing and was committed to bzr rev 10582.
- 10:40 AM Base Language Feature #2196: implement proper resource deletion of resources created in a procedure ran persistent
- Code Review 0728a
The change looks good. I am actually very, very surprised we got away without this for so long. - 04:43 AM Base Language Feature #2196: implement proper resource deletion of resources created in a procedure ran persistent
- Attached update fixes a case when a frame (for which its instantiating procedure is no longer alive) is implicitly hi...
07/26/2014
- 02:52 PM Database Bug #2344: invalid scoping for dynamic buffers
- Stanislav Lomany wrote:
> @4) Department CREATE@ output:
>
> [...]
You have to run "1) Department Type CREATE.... - 02:43 PM Database Bug #2344: invalid scoping for dynamic buffers
- Code review 0725a:
Looks good. Please note that Vadim has a change to @RecordBuffer@ for #2331 (@vmn_upd20140723a....
07/25/2014
- 06:19 PM User Interface Feature #1791: implement dynamic UI support
- Some new investigation results. The widgets are adding while frame creation....
- 06:09 PM Database Bug #2344: invalid scoping for dynamic buffers
- @4) Department CREATE@ output:...
- 05:57 PM Database Bug #2344: invalid scoping for dynamic buffers
- Yes. I ignored it:...
- 05:53 PM Database Bug #2344: invalid scoping for dynamic buffers
- Are you getting this after running @dbuf-scope1.p@?...
- 05:52 PM Database Bug #2344: invalid scoping for dynamic buffers
- Stanislav Lomany wrote:
> > Make sure the department_code_create API is not regressed
>
> Am I missing some files... - 05:49 PM Database Bug #2344: invalid scoping for dynamic buffers
- > Make sure the department_code_create API is not regressed
Am I missing some files or do you mean 4) Department C... - 04:53 PM Database Bug #2344: invalid scoping for dynamic buffers
- Good.
- 04:47 PM Database Bug #2344: invalid scoping for dynamic buffers
- I use...
- 04:27 PM Database Bug #2344: invalid scoping for dynamic buffers
- Please check your testcases into testcases/uast/dynamic_buffer/.
- 04:26 PM Database Bug #2344: invalid scoping for dynamic buffers
- > > Dynamic buffers for permanent tables should have global scope.
>
> Are you sure about this? How did you confir... - 04:25 PM Database Bug #2344: invalid scoping for dynamic buffers
- Pending a reply to my last question...
Stanislav Lomany wrote:
> Fixes my testcases, #2329 and parameter_code_sea... - 04:06 PM Database Bug #2344: invalid scoping for dynamic buffers
- Stanislav Lomany wrote:
> Dynamic buffers for permanent tables should have global scope.
Are you sure about this?... - 06:20 AM Database Bug #2344: invalid scoping for dynamic buffers
- Fixes my testcases, #2329 and parameter_code_search (I guess #2331 is about that?). Note that I've altered ...
- 04:08 PM Base Language Feature #1628: fix any incompatibilities or missing features of NO-ECHO support
- > For this task I need to rollback changes which contains things related to #2345?
Yes, following the implementati... - 01:27 PM Base Language Feature #1628: fix any incompatibilities or missing features of NO-ECHO support
- Greg Shah wrote:
> Evgeny: please follow this plan. Ask questions as needed.
Just want to clarify:
* For this tas... - 09:33 AM Base Language Feature #1628: fix any incompatibilities or missing features of NO-ECHO support
- > P2J works incorrect in the case when the frame is already visible, and a widget (which is already displayed) has a ...
- 05:30 AM Base Language Feature #1628: fix any incompatibilities or missing features of NO-ECHO support
- I don't think the problem is related to where the output is sent or if the unnamed output stream is redirected or not...
- 02:49 PM User Interface Feature #2252: implement GUI client support
- I also prepared tests _this*.p_ to investigate an impact of THIS-PROCEDURE:CURRENT-WINDOW setting on called procedure...
- 02:01 PM User Interface Feature #2252: implement GUI client support
- 1. Conflicting frame:parent.
I tried to found two conflicting statements with frame:parent set, but I didn't find any... - 11:17 AM Database Bug #2295: In Progress output parameters ignore decimal precision
- I don't think anything more is needed right now. Eric will make the call on this soon. We will probably have to fix...
- 11:08 AM Database Bug #2295: In Progress output parameters ignore decimal precision
- Hynek Cihlar wrote:
> If other storage systems are planned to be supported I think these should be tested as well. I ... - 09:42 AM User Interface Bug #2345: already visible frames will sometimes have their screen-buffer updated by changes to t...
- This bug was found in #1628 (see notes 21, 22 and 63)....
- 09:36 AM User Interface Bug #2345 (New): already visible frames will sometimes have their screen-buffer updated by change...
- 08:14 AM Database Bug #2337: trigger scanning defect
- After lots of failing tests I asked for Constantin's opinion and he confirmed that the update is safe for commit.
Lu...
07/24/2014
- 03:09 PM Base Language Feature #1628: fix any incompatibilities or missing features of NO-ECHO support
- testcase:...
- 09:30 AM Base Language Feature #1628: fix any incompatibilities or missing features of NO-ECHO support
- > what part from the case in note 21/22 is not working? I've tested with latest P2J and the code looks fine.
Evgen... - 02:45 PM User Interface Feature #1790: implement menu support
- Make sure you add cases for TOGGLE-BOX in a menu-item definition and MENUBAR in the DEFINE MENU.
I think it also m... - 02:34 PM User Interface Feature #1790: implement menu support
- Greg Shah wrote:
> Please check in your 4GL testcases into a testcases/uast/menu/ directory so I can get an idea of ... - 10:23 AM User Interface Feature #2308: remote client launch
- > If I want to put all in a new chapter this means to create a new odt file and add a link of the document to master....
- 10:06 AM User Interface Feature #2308: remote client launch
- OK. I did the checkout from bzr. I have a first question. If I want to put all in a new chapter this means to create ...
- 09:15 AM User Interface Feature #2308: remote client launch
- Before we close this task, it is important that the "P2J Runtime Installation, Configuration and Administration" book...
- 06:59 AM User Interface Feature #2308: remote client launch
- Passed regression tests. Committed revision 10580.
TODO:
1. Implements a JNI solution to determine the system load ... - 03:57 AM User Interface Feature #2308: remote client launch
- OK. I'm going to do some final tests on my network and than I will commit the changes and distribute to team members.
- 03:27 AM User Interface Feature #2308: remote client launch
- OK, the stacktrace comes from a code in ControlFlowOps recently added... so you can stop your testing, is not your pr...
- 03:15 AM User Interface Feature #2308: remote client launch
- Marius, I think the only issue here is that a log is created for the error. I checked my logs and the message relate...
- 02:55 AM User Interface Feature #2308: remote client launch
- I started regression tests during the night with a full Majic conversion. This time CTRL-C part passes the test witho...
- 08:23 AM Database Bug #2344: invalid scoping for dynamic buffers
- ...
- 08:14 AM Database Bug #2344: invalid scoping for dynamic buffers
- Dynamic buffers for permanent tables should have global scope....
- 07:45 AM Database Bug #2344 (Closed): invalid scoping for dynamic buffers
- 03:36 AM User Interface Feature #2252: implement GUI client support
- More tests for conflicting statements. Here are results.
1) Can you re parent a realized FRAME to a different window...
07/23/2014
- 04:43 PM Base Language Feature #1628: fix any incompatibilities or missing features of NO-ECHO support
- Some 4GL background first:
* in 4GL, application code uses statements to write or read data to/from streams
* these s... - 09:59 AM Base Language Feature #1628: fix any incompatibilities or missing features of NO-ECHO support
- > The deeper I dig, the more I think that if we merge the TerminalStream usage with the direct terminal, we will brea...
- 04:55 AM Base Language Feature #1628: fix any incompatibilities or missing features of NO-ECHO support
- Greg, looking at the logic where TerminalStream was previously opened by StreamDaemon, I think it was only this case:...
- 03:18 PM User Interface Feature #1790: implement menu support
- Please check in your 4GL testcases into a testcases/uast/menu/ directory so I can get an idea of the cases you have l...
- 03:11 PM User Interface Feature #1790 (WIP): implement menu support
- 03:11 PM User Interface Feature #1790: implement menu support
- After investigation and code review, I've found next things:
Conversion problem:
* define menu/sub-menu is not prop... - 02:09 PM User Interface Feature #2342 (Closed): fix cross-domain cookie for web client on remote launch
- 01:41 PM User Interface Feature #2342: fix cross-domain cookie for web client on remote launch
- no regression tests are mandatory for this changes.
committed revision 10579 - 01:30 PM User Interface Feature #2342: fix cross-domain cookie for web client on remote launch
- Yes this issue is done. I tested also using remote launch using brokers and works.
I have to do the commit, distribu... - 01:23 PM User Interface Feature #2342: fix cross-domain cookie for web client on remote launch
- Code Review 0723c
The change looks good. If I understand correctly, this work is done and is tested sufficiently.... - 01:06 PM User Interface Feature #2342: fix cross-domain cookie for web client on remote launch
- WebHandler, the public static members are placed before the private static members.
- 11:54 AM User Interface Feature #2342: fix cross-domain cookie for web client on remote launch
- 1. Yes the query parameter is cleared after form URL when the response is loaded.
2. I tested with Chrome, Firefox... - 11:08 AM User Interface Feature #2342: fix cross-domain cookie for web client on remote launch
- Code Review 0723b
The changes are fine except for one minor code standards issue. In @WebHandler@, the @public st... - 10:50 AM User Interface Feature #2342: fix cross-domain cookie for web client on remote launch
- Sorry by mistake I did the post here instead on #2308
- 10:45 AM User Interface Feature #2342: fix cross-domain cookie for web client on remote launch
- Here are the results of my regression test. CTRL-C test took 1 hour and 8 minutes and the errors are false negative.
... - 10:04 AM User Interface Feature #2342 (Review): fix cross-domain cookie for web client on remote launch
- When a HTTP redirection is done the GET method is used. A HTTP GET request contains HTTP headers and an URL. No body ...
- 01:50 AM User Interface Feature #2342 (WIP): fix cross-domain cookie for web client on remote launch
- 02:04 PM User Interface Feature #2308: remote client launch
- I fixed the problem regarding web server address by making a single change in WebClientBuilder.addClientOptions line ...
- 01:24 PM User Interface Feature #2308: remote client launch
- > make this a limitation, and allow a remote P2J client to be spawned only on windows or only on linux brokers.
Fo... - 01:16 PM User Interface Feature #2308: remote client launch
- I've fixed web server address for remote spawn. The solution is to not send this client:web:host=<web server address>...
- 12:58 PM User Interface Feature #2308: remote client launch
- When command is prepared on P2J server doesn't know which broker will be selected and on which platform is running.
- 12:55 PM User Interface Feature #2308: remote client launch
- Marius Gligor wrote:
> Another issue that I found. The user working directory
> [...]
> depends on platform Window... - 12:43 PM User Interface Feature #2308: remote client launch
- OK. But first of all I have to fix a bug related to web client remote spawn.
The parameter client:web:host=<web serv... - 12:15 PM User Interface Feature #2308: remote client launch
- Marius Gligor wrote:
> I started the tests from the beginning with a Majic conversion.
> Could be a conversion issu... - 10:49 AM User Interface Feature #2308: remote client launch
- Here are the results of my regression test. CTRL-C test took 1 hour and 8 minutes and the errors are false negative.
... - 03:59 AM User Interface Feature #2308: remote client launch
- Removed @author from javadoc.
- 03:51 AM User Interface Feature #2308: remote client launch
- I've fixed the header description line and I started the regression test on devsrv01.
- 03:30 AM User Interface Feature #2308: remote client launch
- PS: please remove the @author@ tag from the class javadoc - we don't use that.
- 03:24 AM User Interface Feature #2308: remote client launch
- Marius Gligor wrote:
> 1. I've fixed the issues reported on previous code review.
Please fix the header in the new ... - 08:57 AM Database Bug #2295: In Progress output parameters ignore decimal precision
- Constantin Asofiei wrote:
> Hynek Cihlar wrote:
> > Constantin Asofiei wrote:
> > * @display@ shows the decimal va... - 02:56 AM Database Bug #2295: In Progress output parameters ignore decimal precision
- Hynek Cihlar wrote:
> Constantin Asofiei wrote:
> * @display@ shows the decimal value according to field's format d...
07/22/2014
- 06:27 PM Database Bug #2295: In Progress output parameters ignore decimal precision
- Constantin Asofiei wrote:
> Please try to find where the field's DECIMALS clause is forced: assign operator, buffer-... - 03:04 PM Database Bug #2295: In Progress output parameters ignore decimal precision
- If other storage systems are planned to be supported I think these should be tested as well. I can imagine (and I act...
- 05:45 PM Base Language Feature #1628: fix any incompatibilities or missing features of NO-ECHO support
- Greg Shah wrote:
> My idea is to allow -1 to always be used to refer to the current terminal stream, even on the ser... - 12:09 PM Base Language Feature #1628: fix any incompatibilities or missing features of NO-ECHO support
- > wouldn't it be better to let the client-side be aware of only one terminal stream? Better said, are we sure it is O...
- 03:20 AM Base Language Feature #1628: fix any incompatibilities or missing features of NO-ECHO support
- Greg, I think we should double-check the @redir*.p@ tests from @testcases/uast@. More, the @ThinClient.currentStream...
- 03:32 PM User Interface Feature #2252: implement GUI client support
- I've added _precedence*_ tests. They confirm documented precedence order: IN WINDOW, THIS-PROCEDURE:CURRENT-WINDOW, C...
- 03:01 PM User Interface Feature #2252: implement GUI client support
- Good, I really like the approach. It leaves as much common as possible, while making it easy to access the more spec...
- 02:18 PM User Interface Feature #2252: implement GUI client support
- Greg Shah wrote:
> Do you mean that @AbstractWidget.screen()@ will return a generic like @<T extends OutputManager> ... - 01:57 PM User Interface Feature #2252: implement GUI client support
- Do you mean that @AbstractWidget.screen()@ will return a generic like @<T extends OutputManager> T screen(T type)@?
- 01:06 PM User Interface Feature #2252: implement GUI client support
- Currently I'm abstracting ScreenBitmap and OutputManager; a conclusion is that each implementation hierarchy (GUI and...
- 02:08 PM User Interface Feature #2343 (New): implements a native solution to get system load for remote launcher
- 02:06 PM User Interface Feature #2342 (Closed): fix cross-domain cookie for web client on remote launch
- 11:32 AM User Interface Feature #1793 (WIP): improve color support
- 11:03 AM User Interface Feature #2308 (Review): remote client launch
- 1. I've fixed the issues reported on previous code review.
2. I did a lot of improvements in code:
- Placehold... - 05:09 AM User Interface Feature #2308: remote client launch
- Marius Gligor wrote:
> The broker an server could be on different networks for example if server is behind a network... - 05:07 AM User Interface Feature #2308: remote client launch
- The broker an server could be on different networks for example if server is behind a network router.
I think that i... - 04:26 AM User Interface Feature #2308: remote client launch
- Marius Gligor wrote:
> When client is spawned locally I sow that localhost is used as host for server address but wh... - 03:47 AM User Interface Feature #2308: remote client launch
- When client is spawned locally I sow that localhost is used as host for server address but when the client is spawn r...
- 02:58 AM User Interface Feature #2308: remote client launch
- Review for 0721a:
# the header first line needs to have the Description text centered, as in note 56.
# @NativeSecu...
Also available in: Atom