Activity
From 01/24/2015 to 02/22/2015
02/22/2015
- 04:05 PM User Interface Feature #2479: DEFINE IMAGE and image phrase support for both button and image
- Greg Shah wrote:
> Yes, go ahead and commit it.
Committed in bzr as 10771. - 03:32 PM User Interface Feature #2479: DEFINE IMAGE and image phrase support for both button and image
- Yes, go ahead and commit it.
- 02:53 PM User Interface Feature #2479: DEFINE IMAGE and image phrase support for both button and image
- The conversion testing completed, generated codes are identical. No regressions.
So the update is ready to be comm... - 07:03 AM User Interface Feature #2479: DEFINE IMAGE and image phrase support for both button and image
- The update fixes the size/location regression for images used to draw the buttons. Plus slightly enhanced icon detect...
- 08:01 AM User Interface Feature #2498: implement ADD-LAST() method
- Attached detailed reports for failed tests.
- 05:44 AM User Interface Feature #2498: implement ADD-LAST() method
- There where 3 runs of the regression test.
The following test failed in in all 3 runs:
gso_tests
57 gso_187: fa...
02/20/2015
- 06:10 PM User Interface Feature #2513: implement GUI runtime support for TOGGLE-BOX
- Here is the next update containing basic GUI implementation.
Questions:
1. When I'm going between checkboxes I've... - 05:25 PM User Interface Feature #2523: implement GUI radio-set widget
- The core widget implementation for GUI must be created including drawing and event processing. Mouse support must wo...
- 05:23 PM User Interface Feature #2523 (Closed): implement GUI radio-set widget
- 05:22 PM User Interface Feature #2522: add attribute/method support for radio-set
- Implement conversion and runtime support for the following:
+Attributes+
NUM-BUTTONS
+Methods+
DISABLE()
... - 05:21 PM User Interface Feature #2522 (Closed): add attribute/method support for radio-set
- 05:21 PM User Interface Feature #2479: DEFINE IMAGE and image phrase support for both button and image
- >Please do fix both of these issues (character unit mismatches and the regression for IMAGE-SIZE options) as part of ...
- 05:00 PM User Interface Feature #2479: DEFINE IMAGE and image phrase support for both button and image
- Eugenie Lyzenko wrote:
> >Have you run your testcases in both windev01 and in P2J? Does our implementation match exa... - 04:59 PM User Interface Feature #2479: DEFINE IMAGE and image phrase support for both button and image
- > I've changed the rule file and want to make sure there will be no regression her. Is it OK?
Good point. Yes, c... - 04:57 PM User Interface Feature #2479: DEFINE IMAGE and image phrase support for both button and image
- >Have you run your testcases in both windev01 and in P2J? Does our implementation match exactly?
Yes, I'm comparin... - 04:41 PM User Interface Feature #2479: DEFINE IMAGE and image phrase support for both button and image
- >OK. I don't think this needs full runtime testing. The GUI stuff won't get loaded in MAJIC testing. Even the server-...
- 04:34 PM User Interface Feature #2479: DEFINE IMAGE and image phrase support for both button and image
- Have you run your testcases in both windev01 and in P2J? Does our implementation match exactly?
- 04:32 PM User Interface Feature #2479: DEFINE IMAGE and image phrase support for both button and image
- OK. I don't think this needs full runtime testing. The GUI stuff won't get loaded in MAJIC testing. Even the serve...
- 04:06 PM User Interface Feature #2479: DEFINE IMAGE and image phrase support for both button and image
- >1. In Convert3DColorsFilter, are the input colors to be converted really hard coded in the 4GL?
I think so, from ... - 03:52 PM User Interface Feature #2479: DEFINE IMAGE and image phrase support for both button and image
- Code Review evl_upd20150220a.zip
1. In @Convert3DColorsFilter@, are the input colors to be converted really hard c... - 03:40 PM User Interface Feature #2479: DEFINE IMAGE and image phrase support for both button and image
- This updates for review includes runtime implementation of the @CONVERT-3D-COLORS@ option for image and button widget...
- 02:22 PM User Interface Feature #2479: DEFINE IMAGE and image phrase support for both button and image
- Code Review evl_upd20150219a.zip
It is good. - 08:01 PM User Interface Feature #2479: DEFINE IMAGE and image phrase support for both button and image
- This update adds conversion rule change to support @RETAIN-SHAPE@ sub-option and runtime implementation for @STRETCH-...
- 05:20 PM User Interface Feature #2521 (Closed): enhance/implement radio-set for GUI
- 02:31 PM User Interface Feature #2508: test LIST-ITEMS support in P2J and confirm that it is complete, add or fix feature...
- Yes, I think you are right. Please test and fix any issues related to those.
Another thing: please test these bot... - 02:26 PM User Interface Feature #2508: test LIST-ITEMS support in P2J and confirm that it is complete, add or fix feature...
- I understand the LIST-ITEM-PAIRS and RADIO-BUTTONS attributes are in the scope of this task as well. Is that correct?
- 02:16 PM User Interface Feature #1790: implement menu support
- At this point are ChUI menus fully functional?
Is there any error handling, event or other missing functionality? ... - 01:56 PM User Interface Feature #1790: implement menu support
- Javadoc fix.
Remaining features needing to be implemented is empty at this moment. Probably some features will be ... - 01:22 PM User Interface Feature #1790: implement menu support
- Please post a list of the remaining features needing to be implemented, enhanced and/or bugs needing fixing. You can...
- 01:21 PM User Interface Feature #1790: implement menu support
- In your next update, please resolve these:...
- 01:02 PM User Interface Feature #1790: implement menu support
- Current update has passed full testing and committed to rev #10766.
- 12:26 PM User Interface Feature #1790: implement menu support
- OK, you can commit vig_upd20150220a.zip.
- 12:12 PM User Interface Feature #1790: implement menu support
- Here is merged current update with the latest revision.
- 12:06 PM User Interface Feature #1790: implement menu support
- > I suspect that this error is not related with my update. Don't you know why it happens?
We don't know for sure. ... - 11:02 AM User Interface Feature #1790: implement menu support
- I've ran regression testing 3rd time. And the test @tc_codes_employees_20@ has passed. So, we can assume that update ...
- 03:28 AM User Interface Feature #1790: implement menu support
- Current update has passed conversion testing. I ran regression testing twice. Only one test has failed during both ru...
- 02:00 PM User Interface Feature #2498: implement ADD-LAST() method
- Code Review ias_upd20150220c.zip
It looks good. - 01:50 PM User Interface Feature #2498: implement ADD-LAST() method
- Greg Shah wrote:
> There is about to be a check in from #1790. When that occurs, please merge up to the latest bzr ... - 12:47 PM User Interface Feature #2498: implement ADD-LAST() method
- There is about to be a check in from #1790. When that occurs, please merge up to the latest bzr revision and put tha...
- 12:42 PM User Interface Feature #2498: implement ADD-LAST() method
- The following tests failed in both runs:
57 gso_187 GSO 187 - Initial selection on Contact Master returns to main... - 12:00 PM User Interface Feature #2498: implement ADD-LAST() method
- Code Review ias_upd20150220a.zip
The @ScrollDirection@ constructor still needs Javadoc. Obviously, this doesn't i... - 11:57 AM User Interface Feature #2498: implement ADD-LAST() method
- > The ChuiOutputManager sets the value of the cursorInvalid in the at method and doesn't reset it in the append(Strin...
- 03:57 AM User Interface Feature #2498: implement ADD-LAST() method
- Greg Shah wrote:
> Igor: in regard to the scrolling problems, I'd like for you to finish the current task without ad... - 03:41 AM User Interface Feature #2498: implement ADD-LAST() method
- Constantin Asofiei wrote:
> Please add Keyboard.SE_NEXT_FRAME and Keyboard.SE_PREV_FRAME cases to AbstractWidget.ign... - 03:39 AM User Interface Feature #2498: implement ADD-LAST() method
- Greg Shah wrote:
> Code Review ias_upd20150219a.zip
>
> 1. In @RadioButtonImpl.draw()@, why iterate through chara... - 02:34 AM User Interface Feature #2498: implement ADD-LAST() method
- About the NPE in note 73 and the w3.p test. A widget can be determine as no longer alive (thus can be deleted) by bo...
- 02:20 AM User Interface Feature #2498: implement ADD-LAST() method
- Igor Skornyakov wrote:
> 3. After some recent changes (as far as I understand - introducing @manageSystemActions()@ ... - 07:39 PM User Interface Feature #2498: implement ADD-LAST() method
- Code Review ias_upd20150219a.zip
1. In @RadioButtonImpl.draw()@, why iterate through character by character instea... - 07:08 PM User Interface Feature #2498: implement ADD-LAST() method
- Igor: in regard to the scrolling problems, I'd like for you to finish the current task without adding more work to it...
- 07:03 PM User Interface Feature #2498: implement ADD-LAST() method
- Constantin: please comment on note 72 and item 3 in note 85.
- 01:47 PM User Interface Bug #2520: Dynamic list controls are not visible
- Greg Shah wrote:
> Is this still a problem on bzr rev 10766?
Yes, it is.
- 01:38 PM User Interface Bug #2520: Dynamic list controls are not visible
- Is this still a problem on bzr rev 10766?
- 01:37 PM User Interface Bug #2520: Dynamic list controls are not visible
- The dynamic RADIO-SET and COMBO-BOX are not visible, but are "working" - one can make a "blind" selection with the RA...
- 07:47 AM User Interface Bug #2520 (Closed): Dynamic list controls are not visible
- 01:40 PM User Interface Bug #2518: NPE on exit from testcase with mixed usage of static and dynamic widgets
- From CA:
About the NPE in note 73 and the w3.p test. A widget can be determine as no longer alive (thus can be del... - 01:40 PM User Interface Bug #2518: NPE on exit from testcase with mixed usage of static and dynamic widgets
- The attached sample after conversion throws NPE on exit:
[02/17/2015 19:25:51 MSK] (StandardServer.invoke:SEVERE) ... - 07:41 AM User Interface Bug #2518 (New): NPE on exit from testcase with mixed usage of static and dynamic widgets
- 01:39 PM User Interface Bug #2519: suspicious looking scrolling code
- 1. The @ScrollBar.scroll()@ method looks to contain a typo: in line 253 @limit.x@ seems to be instead of @limit.y@
2... - 07:43 AM User Interface Bug #2519 (New): suspicious looking scrolling code
- 01:36 PM User Interface Feature #2487: implement READ-FILE() and SAVE-FILE() methods in the editor widget
- Code Review evk_upd20150218a.zip
It is a good step.
1. @EditorWidget.read/saveFile(character)@ need @null@ and ... - 08:02 PM User Interface Feature #2487: implement READ-FILE() and SAVE-FILE() methods in the editor widget
- Added runtime support. I'm not finished testing at the moment, but common functionality is working.
- 11:25 AM User Interface Feature #2422: add features to BROWSE
- Technically that's not a browse problem, but because of record retrieval logic browse uses, an editable browse easily...
02/19/2015
- 03:04 PM Database Bug #2488: replace runtime compilation of dynamic queries
- Ovidiu Maxiniuc wrote:
> The generated code is unchanged for majic. The attached update passed the conversion test.
... - 12:01 PM Database Bug #2488: replace runtime compilation of dynamic queries
- The generated code is unchanged for majic. The attached update passed the conversion test.
- 09:44 AM Database Bug #2488: replace runtime compilation of dynamic queries
- Eric Faulhaber wrote:
> Where did the need to improve the predicate prep come from? What is the rationale behind the... - 11:18 AM User Interface Feature #2498: implement ADD-LAST() method
- I've finished with scrolling changes. My changes do not affect the @ComboBox@ behavior as this widget doesn't rely on...
- 09:45 AM User Interface Feature #2479: DEFINE IMAGE and image phrase support for both button and image
- Code Review evl_upd20150218a.zip
It looks good.
02/18/2015
- 06:06 PM User Interface Feature #2479: DEFINE IMAGE and image phrase support for both button and image
- This update for your review adds transparency runtime implementation for image widget. Also it prepares other boolean...
- 05:49 PM User Interface Feature #1790: implement menu support
- Code Review vig_upd20150219a.zip
I ma OK with the changes. Please get this update conversion and runtime regressi... - 05:37 PM User Interface Feature #1790: implement menu support
- The next update, containing remarks corrections and overrides bug fix
- 04:01 PM User Interface Feature #1790: implement menu support
- > Don't you remember where that conversion logic?
See the @process_frame@ function in @annotations/frame_scoping.r... - 03:46 PM User Interface Feature #1790: implement menu support
- Greg Shah wrote:
> > Wait a minute. It seems that it is a frames naming (class naming) problem.
>
> This makes se... - 02:52 PM User Interface Feature #1790: implement menu support
- > Wait a minute. It seems that it is a frames naming (class naming) problem.
This makes sense. Please put some pr... - 02:36 PM User Interface Feature #1790: implement menu support
- Greg Shah wrote:
> In the 4GL I suspect that your @DISPLAY@ statements in the triggers are targeting the the default... - 02:21 PM User Interface Feature #1790: implement menu support
- In the 4GL I suspect that your @DISPLAY@ statements in the triggers are targeting the the default "unnamed" frame. S...
- 02:00 PM User Interface Feature #1790: implement menu support
- I'm debugging difficult bug:...
- 05:41 PM User Interface Feature #2487: implement READ-FILE() and SAVE-FILE() methods in the editor widget
- Is there a bug in our implementation of the 4GL built-in function @SEARCH()@ that makes it work differently with file...
- 05:38 PM User Interface Feature #2487: implement READ-FILE() and SAVE-FILE() methods in the editor widget
- Greg Shah wrote:
> I don't think you need to do anything like that. The client-side code would call @FileSystemDaem... - 05:34 PM User Interface Feature #2487: implement READ-FILE() and SAVE-FILE() methods in the editor widget
- I don't think you need to do anything like that. The client-side code would call @FileSystemDaemon.searchPath()@, wh...
- 05:31 PM User Interface Feature #2487: implement READ-FILE() and SAVE-FILE() methods in the editor widget
- Can you suggest what is common "looking" directories in 4gl ? at least common work dir I can take from @Configuration...
- 03:40 PM Database Bug #2488: replace runtime compilation of dynamic queries
- Code review 0218a:
Where did the need to improve the predicate prep come from? What is the rationale behind the cu... - 02:40 PM Database Bug #2488: replace runtime compilation of dynamic queries
- Added support for @LogicalExpression@ anon c'tor.
Refactored some method names to better fit their implementation. - 02:41 PM Database Bug #2514: incorrect return values for get{First|Next|Last|Previous} methods
- This update should fix the return values for respective methods.
- 07:07 AM User Interface Feature #2498: implement ADD-LAST() method
- Hynek Cihlar wrote:
> I think it won't hurt if you start fixing the immediate pains - the unclear model of scroll ... - 07:04 AM User Interface Feature #2498: implement ADD-LAST() method
- Igor Skornyakov wrote:
> I'm not sure that I understand this completely. However it seems that it means that a widge... - 05:03 AM User Interface Feature #2498: implement ADD-LAST() method
- Hynek Cihlar wrote:
> Personally I would rather see the scroll event initiated by the widget receiving focus itsel...
02/17/2015
- 04:28 PM User Interface Feature #2498: implement ADD-LAST() method
- Greg Shah wrote:
> Igor Skornyakov wrote:
> > I see. May I make a suggestion?
> > First of all I think that it is ... - 04:12 PM User Interface Feature #2498: implement ADD-LAST() method
- Igor Skornyakov wrote:
> Greg Shah wrote:
>
> > Please provide more specifics about what needs to be different.
... - 04:07 PM User Interface Feature #2498: implement ADD-LAST() method
- Igor Skornyakov wrote:
> I see. May I make a suggestion?
> First of all I think that it is important for the scroll... - 02:29 PM User Interface Feature #2498: implement ADD-LAST() method
- I see. May I make a suggestion?
First of all I think that it is important for the scroll to be well-defined and idemp... - 02:03 PM User Interface Feature #2498: implement ADD-LAST() method
- Igor Skornyakov wrote:
> Greg Shah wrote:
>
> > Please provide more specifics about what needs to be different.
... - 12:59 PM User Interface Feature #2498: implement ADD-LAST() method
- Greg Shah wrote:
> Please provide more specifics about what needs to be different.
Well, first of all the whole... - 12:42 PM User Interface Feature #2498: implement ADD-LAST() method
- Greg Shah wrote:
> Generally, no it is not OK.
>
> I do see that @RadioButtonImpl.drawButton()@ does not honor th... - 12:40 PM User Interface Feature #2498: implement ADD-LAST() method
- Igor Skornyakov wrote:
> Another note. The look of the RadioSet widget at runtime is different in 4GL and Java: in 4... - 12:34 PM User Interface Feature #2498: implement ADD-LAST() method
- Igor Skornyakov wrote:
> It seems that the @ScrollContainer.ensureVisibility()@ method's implementation is not suita... - 12:33 PM User Interface Feature #2498: implement ADD-LAST() method
- In regard to the NPE, I don't understand why we would be pushing screen definitions to the client during the processi...
- 11:57 AM User Interface Feature #2498: implement ADD-LAST() method
- Another note. The look of the RadioSet widget at runtime is different in 4GL and Java: in 4GL the focused item is hig...
- 11:34 AM User Interface Feature #2498: implement ADD-LAST() method
- It seems that the @ScrollContainer.ensureVisibility()@ method's implementation is not suitable for at least a @RadioS...
- 11:29 AM User Interface Feature #2498: implement ADD-LAST() method
- The sample code is a result of my test evolution - I've added more code while investigating the widget behavior. Plea...
- 10:02 AM User Interface Feature #2498: implement ADD-LAST() method
- The code seems very complicated, with many more frames than I would have expected to be used or needed. Did you get ...
- 04:13 AM User Interface Feature #2498: implement ADD-LAST() method
- Greg Shah wrote:
> 3. About the NPE in @LogicalTerminal.pushScreenDefinition()@, can you show the 4GL code that can ... - 10:44 PM User Interface Feature #2498: implement ADD-LAST() method
- Code Review ias_upd20150216a.zip
1. The @RadioSetInterface@ header should be above the import and package statemen... - 03:34 PM Database Bug #2488: replace runtime compilation of dynamic queries
- Oops, I forgot the update. here it is.
- 03:33 PM Database Bug #2488: replace runtime compilation of dynamic queries
- Changes since 0210a:
* Improved @preparePredicate()@ for OPEN QUERY predicates to
- allow one level nested quotes
- a... - 10:21 PM Database Bug #2488: replace runtime compilation of dynamic queries
- Code review 0210a:
The version of @DynamicQueryHelper@ in the update shows no difference from the latest version i... - 08:55 AM User Interface Feature #2412: Implement widget browser
- Code Review hc_upd20150217b.zip
It looks good. Please check it in. - 04:54 AM User Interface Feature #2412: Implement widget browser
- Missing history entry added and converted tabs to spaces in the whole PropertyTable.java. build.xml removed as this s...
- 10:48 PM User Interface Feature #2412: Implement widget browser
- Code Review hc_upd20150217a.zip
1. @PropertyTable@ needs a history entry. It also needs all of its hard-tab chars... - 08:15 PM User Interface Feature #2412: Implement widget browser
- The attached update extends Widget browser with the possibility to copy widget properties to clipboard. This is usefu...
- 02:06 AM User Interface Feature #2422: add features to BROWSE
- > > But I can handle browsing part because BrowseColumnWidget.setDColor(Color) does the job.
>
> I don't understan... - 10:31 PM User Interface Feature #2422: add features to BROWSE
- > while BrowseColumnWidget.setDColor(NumberType) doesn't actually set a color because ColorSpec.convert() always retu...
02/16/2015
- 03:49 PM User Interface Feature #2498: implement ADD-LAST() method
- Added support for the HORIZONTAL and EXPAND attributes. Still need to fix scrolling behavior.
- 03:32 PM User Interface Feature #2422: add features to BROWSE
- FYI, Majic alters browse column "colors" in two places. E.g.:...
- 09:51 AM User Interface Feature #2479: DEFINE IMAGE and image phrase support for both button and image
- Committed in bzr as 10757.
- 09:38 AM User Interface Feature #2479: DEFINE IMAGE and image phrase support for both button and image
- Check it in.
- 08:51 AM User Interface Feature #2479: DEFINE IMAGE and image phrase support for both button and image
- The runtime testing completed without regressions(separate run for CTRL-C 3 way tests). The results are in @10754_5c9...
02/13/2015
- 02:32 PM Database Bug #2514: incorrect return values for get{First|Next|Last|Previous} methods
- Alternative working form for ...
- 07:46 AM Database Bug #2514: incorrect return values for get{First|Next|Last|Previous} methods
- The set of get{First|Next|Last|Previous} methods should return:
* @?@ (unknown) if the query object handle is invali... - 07:38 AM Database Bug #2514 (Closed): incorrect return values for get{First|Next|Last|Previous} methods
- 12:38 PM User Interface Feature #2479: DEFINE IMAGE and image phrase support for both button and image
- Greg Shah wrote:
> Code Review evl_upd20150212b.zip
>
> It looks good, get it both conversion and runtime regress... - 09:22 AM User Interface Feature #2479: DEFINE IMAGE and image phrase support for both button and image
- Code Review evl_upd20150212b.zip
It looks good, get it both conversion and runtime regression tested. - 10:53 AM User Interface Feature #1790: implement menu support
- Code Review vig_upd20150210a.zip
This is very close.
1. There is a build directory included in your update zip ... - 09:55 AM User Interface Feature #2498: implement ADD-LAST() method
- Code Review ias_upd20150212a.zip
It is very good. Some minor things:
1. Add @RadioSetInterface@ to @HandleComm...
02/12/2015
- 04:42 PM User Interface Feature #2479: DEFINE IMAGE and image phrase support for both button and image
- OK. This update for review changes row/column offsets to double and adjust client side to use new double data.
- 04:10 PM User Interface Feature #2479: DEFINE IMAGE and image phrase support for both button and image
- Eugenie Lyzenko wrote:
> >Instead of having 3 sets of setters, you could have 1 set and generate an enum value that ... - 12:02 PM User Interface Feature #2479: DEFINE IMAGE and image phrase support for both button and image
- >Instead of having 3 sets of setters, you could have 1 set and generate an enum value that distinguishes between @But...
- 07:24 AM User Interface Feature #2479: DEFINE IMAGE and image phrase support for both button and image
- Eugenie Lyzenko wrote:
> >Is there anything left to do for this task?
>
> The following options need to be implem... - 07:24 AM User Interface Feature #2479: DEFINE IMAGE and image phrase support for both button and image
- Code Review evl_upd20150212a.zip
1. All row/col values need to be decimal/double as well. I should have seen thi... - 07:17 AM User Interface Feature #2479: DEFINE IMAGE and image phrase support for both button and image
- Eugenie Lyzenko wrote:
> >2. Although it is probably OK, I find it confusing that the image phrase generates differe... - 07:00 AM User Interface Feature #2479: DEFINE IMAGE and image phrase support for both button and image
- >2. Although it is probably OK, I find it confusing that the image phrase generates different setters for the same op...
- 05:13 AM User Interface Feature #2479: DEFINE IMAGE and image phrase support for both button and image
- >Is there anything left to do for this task?
The following options need to be implemented:
CONVERT-3D-COLORS
STR... - 07:53 PM User Interface Feature #2479: DEFINE IMAGE and image phrase support for both button and image
- Code Review evl_upd20150211b.zip
This is really good.
1. I suspect the @IMAGE-SIZE@/@IMAGE-SIZE-CHARS@ should b... - 03:58 PM User Interface Feature #2513: implement GUI runtime support for TOGGLE-BOX
- That is probably the issue. Try it from the command line.
- 03:25 PM User Interface Feature #2513: implement GUI runtime support for TOGGLE-BOX
- Done. I've uploaded @vig_server_client.zip@ to @/home/vig@
I use Java configuration in Eclipse. - 02:51 PM User Interface Feature #2513: implement GUI runtime support for TOGGLE-BOX
- Please archive your testcases/simple/server, testcases/simple/client folders and upload them to devsrv01.
How do y... - 02:48 PM User Interface Feature #2513: implement GUI runtime support for TOGGLE-BOX
- Constantin Asofiei wrote:
> Vadim Gindin wrote:
> > Thanks. I tried it and got the error:
> > [...]
> Are you usi... - 02:43 PM User Interface Feature #2513: implement GUI runtime support for TOGGLE-BOX
- @display "This"@ behaves as the first test: window 1x1 in the left top corner.
- 02:43 PM User Interface Feature #2513: implement GUI runtime support for TOGGLE-BOX
- Vadim Gindin wrote:
> Thanks. I tried it and got the error:
> [...]
Are you using the latest P2J rev? Note that t... - 01:42 PM User Interface Feature #2513: implement GUI runtime support for TOGGLE-BOX
- Thanks. I tried it and got the error:...
- 08:44 AM User Interface Feature #2513: implement GUI runtime support for TOGGLE-BOX
- Vadim Gindin wrote:
> I didn't find any peculiarities. Here is the test:
>
> [...]
Have you added basic runtime ... - 06:58 AM User Interface Feature #2513: implement GUI runtime support for TOGGLE-BOX
- I faced with the following difficulty: running application window (GUI) has the size 1x1 and position in the first pi...
- 03:19 PM User Interface Feature #2498: implement ADD-LAST() method
- 1. fixed the issues you've mentioned by Greg.
2. Added server-side support for HORIZONTAL and EXPAND attributes. Cli... - 08:20 AM User Interface Feature #2498: implement ADD-LAST() method
- Code Review ias_upd20150211b.zip
1. This code in @CommonWidget@ is incorrect:... - 09:39 PM Base Language Feature #1628: fix any incompatibilities or missing features of NO-ECHO support
- Code Review evk_upd20150205a.zip
The changes look fine. You'll need to merge up to the latest level before the ne...
02/11/2015
- 04:40 PM User Interface Feature #2479: DEFINE IMAGE and image phrase support for both button and image
- The second update for today has small fixes for image widget bugs/regressions. I guess now if there are no objections...
- 01:15 PM User Interface Feature #2479: DEFINE IMAGE and image phrase support for both button and image
- The update for review includes candidate for image phrase handling for button widget. Need the tests to not getting r...
- 07:38 PM User Interface Feature #2479: DEFINE IMAGE and image phrase support for both button and image
- This drop includes merging with the recent code base and fix for handling case when requested image size is bigger th...
- 04:05 PM User Interface Feature #2498: implement ADD-LAST() method
- 1. The converted code with horizontal RADIO-SET behaves very different from the 4GL. In particular the EXPAND flag is...
- 07:14 AM User Interface Feature #2498: implement ADD-LAST() method
- Finished refactoring and adding new attributes/methods support. Now I should check the behavior of RADIO-SET runtime ...
- 12:41 PM User Interface Feature #2513: implement GUI runtime support for TOGGLE-BOX
- I didn't find any peculiarities. Here is the test:...
- 06:56 AM Database Bug #2488: replace runtime compilation of dynamic queries
- The problem reported in note-62 is fixed by adding the @methods_attributes.rules@ to runtime conversion. With this oc...
02/10/2015
- 06:20 PM User Interface Feature #2487: implement READ-FILE() and SAVE-FILE() methods in the editor widget
- Code Review evk_upd20150209a.zip
Looks good so far. - 06:18 PM User Interface Feature #2487: implement READ-FILE() and SAVE-FILE() methods in the editor widget
- > I planed to add in the LogicalTerminal new methods for read/save files.
That is OK. These should call down to a... - 05:59 PM User Interface Feature #2487: implement READ-FILE() and SAVE-FILE() methods in the editor widget
- Just want to clarify:
I planed to add in the @LogicalTerminal@ new methods for read/save files. Also I need to add s... - 12:22 PM User Interface Feature #2487: implement READ-FILE() and SAVE-FILE() methods in the editor widget
- Added conversion support for SAVE-FILE method
- 02:58 PM User Interface Feature #2498: implement ADD-LAST() method
- > The converted code runs w/o any complains
The 4GL docs state that @LIST-ITEM-PAIRS@ is valid for combo-box, sele... - 02:56 PM User Interface Feature #2498: implement ADD-LAST() method
- Constantin Asofiei wrote:
> Igor, as you are using a dynamic RADIO-SET and not a static RADIO-SET (created via the... - 02:49 PM User Interface Feature #2498: implement ADD-LAST() method
- Greg Shah wrote:
> Do you mean that the code will not EXECUTE in the 4GL? It fails at compilation?
It will com... - 02:46 PM User Interface Feature #2498: implement ADD-LAST() method
- Igor Skornyakov wrote:
> Greg Shah wrote:
> > This you can fix. Please post a simplified testcase (in @[...]@ tags... - 02:42 PM User Interface Feature #2498: implement ADD-LAST() method
- > which is illegal for 4GL
Do you mean that the code will not EXECUTE in the 4GL? It fails at compilation? - 02:36 PM User Interface Feature #2498: implement ADD-LAST() method
- Greg Shah wrote:
> This you can fix. Please post a simplified testcase (in @[...]@ tags) so that I can see what you... - 02:27 PM User Interface Feature #2498: implement ADD-LAST() method
- > I have the following in mind. As you know I've moved some methods from CommonWdget/GenericWidget to a separate inte...
- 02:23 PM User Interface Feature #2498: implement ADD-LAST() method
- Greg Shah wrote:
> We don't want to support any case where the code can never be valid or where we are mis-convertin... - 02:09 PM User Interface Feature #2498: implement ADD-LAST() method
- Igor Skornyakov wrote:
> One more question.
> I've noticed that in some cases an invalid attribute result in 4GL co... - 02:08 PM User Interface Feature #2498: implement ADD-LAST() method
- Igor Skornyakov wrote:
> The situation with invisible dynamic RADIO-SET widget is still unclear. It appears that dyn... - 12:49 PM User Interface Feature #2498: implement ADD-LAST() method
- One more question.
I've noticed that in some cases an invalid attribute result in 4GL compilation failure while in o... - 12:31 PM User Interface Feature #2498: implement ADD-LAST() method
- The situation with invisible dynamic RADIO-SET widget is still unclear. It appears that dynamic COMBO-BOX and SELECTI...
- 02:41 PM Database Bug #2488: replace runtime compilation of dynamic queries
- The attached update should handle the @WhereExpressions@.
There are a few other issues that must be solved first:
*... - 02:07 PM Database Bug #2488: replace runtime compilation of dynamic queries
- Eric Faulhaber wrote:
> At a glance, yes, that looks wrong. Have you converted the static form of the same query? Thi... - 01:57 PM Database Bug #2488: replace runtime compilation of dynamic queries
- At a glance, yes, that looks wrong. Have you converted the static form of the same query? This will tell you if the p...
- 01:52 PM Database Bug #2488: replace runtime compilation of dynamic queries
- Eric,
I almost finished implementing support for 'extending' and interpreting the client-side @WhereExpression@ but ... - 02:14 PM User Interface Feature #2513: implement GUI runtime support for TOGGLE-BOX
- Not exactly. What I meant is that I would like to see some specific findings about the drawing and event processing ...
- 02:12 PM User Interface Feature #2513: implement GUI runtime support for TOGGLE-BOX
- About my implementation plan. I just think that I'll firstly implement drawing and after that I'll be implementing ev...
- 09:22 AM User Interface Feature #2513: implement GUI runtime support for TOGGLE-BOX
- This widget is supported for ChUI runtime usage today. It's conversion should be pretty complete, but I haven't chec...
- 09:19 AM User Interface Feature #2513 (Closed): implement GUI runtime support for TOGGLE-BOX
- 03:16 AM User Interface Feature #1790: implement menu support
- Here is the current update.
It adds to following changes to previous:
* An implementation of find* methods,
* Se...
02/09/2015
- 04:00 PM User Interface Feature #2498: implement ADD-LAST() method
- Extracted list widgets-specific methods to a separate interface @com.goldencode.p2j.ui.CommonListWidget@
- 03:23 PM User Interface Feature #2498: implement ADD-LAST() method
- > Should I remove these methods from CommonWidget/GenericWidget?
Yes.
> Please note that in this case these met... - 03:16 PM User Interface Feature #2498: implement ADD-LAST() method
- I've extracted methods which are defines for lists widgets only to a separate interface. Should I remove these method...
- 12:21 PM User Interface Feature #2498: implement ADD-LAST() method
- Greg Shah wrote:
> This is easy to do, but it has the unwanted result of making the generated code much more verbose... - 12:10 PM User Interface Feature #2498: implement ADD-LAST() method
- > Don't you think that it is more practical to change the code generation? I mean that the code generator can validat...
- 11:47 AM User Interface Feature #2498: implement ADD-LAST() method
- > Just by marking the method as "Widget" in @methods_attributes.rules@ would work. It is not how we want it to work,...
- 11:46 AM User Interface Feature #2498: implement ADD-LAST() method
- Greg Shah wrote:
> Are you saying that you cannot write code like this: @my-widget:add-last(my-char-var, "Some Text"... - 11:03 AM User Interface Feature #2498: implement ADD-LAST() method
- Perhaps that interface would be called @ListManagement@.
>> 2. Don't we still need addLast(character, String)?
> ... - 11:00 AM User Interface Feature #2498: implement ADD-LAST() method
- > > 3. The change in @handle@ is incorrect. @ControlEntity@ is not an interface and MUST NOT be an unwrap target. A...
- 10:56 AM User Interface Feature #2498: implement ADD-LAST() method
- Greg Shah wrote:
> 1. Coding standard issues that remain:
>
> * @for(@ should be @for (@ - @ComboBoxModel@, @Radi... - 09:23 AM User Interface Feature #2498: implement ADD-LAST() method
- Code Review ias_upd20150209a.zip
1. Coding standard issues that remain:
* @for(@ should be @for (@ - @ComboBoxM... - 08:43 AM User Interface Feature #2498: implement ADD-LAST() method
- 1. Formatting issues are fixed (I hope)
2. The list widgets' behaviour updated according to recent findings.
- 07:32 AM User Interface Feature #2498: implement ADD-LAST() method
- > Please note however that if one tries to delete an item with label which doesn't exists in a case-sensitive way but...
- 07:21 AM User Interface Feature #2498: implement ADD-LAST() method
- A more thorough analysis revealed the following details about the list widgets' behaviour:
1. For COMBO-BOX: the @DE... - 02:16 PM Database Bug #2488: replace runtime compilation of dynamic queries
- Eric Faulhaber wrote:
> If we cannot come up with a single test case which would result in client-side where clause ... - 01:25 PM Database Bug #2488: replace runtime compilation of dynamic queries
- IIRC the point is that there can be multiple dynamic buffers with the same name in the same scope and some P2J struct...
- 01:13 PM Database Bug #2488: replace runtime compilation of dynamic queries
- Stanislav Lomany wrote:
> Eric, are you basically asking why suffixes are added to the names of dynamic buffers?
Ye... - 01:08 PM Database Bug #2488: replace runtime compilation of dynamic queries
- Eric, are you basically asking why suffixes are added to the names of dynamic buffers?
- 12:17 PM Database Bug #2488: replace runtime compilation of dynamic queries
- Stanislav, I don't fully understand the following comment, from @DynamicQueryHelper@:763:...
- 10:36 AM Database Bug #2488: replace runtime compilation of dynamic queries
- If we cannot come up with a single test case which would result in client-side where clause processing (all so far se...
- 09:24 AM Database Bug #2488: replace runtime compilation of dynamic queries
- Regarding the user-defined functions. I was thinking too ahead. At this moment the @ProgressParser@ cannot handle UDF...
- 08:25 AM Database Bug #2488: replace runtime compilation of dynamic queries
- Eric Faulhaber wrote:
> The result of this evaluation would be fed into an adapter subclass of the @WhereExpression@... - 04:15 AM Database Bug #2488: replace runtime compilation of dynamic queries
- Eric,
I tried such constructs on windev01.
*CAN-FIND*: P2J parses and successfully converts them in java code, ... - 11:22 AM User Interface Feature #2422: add features to BROWSE
- Addition to note 63. Another 4GL bug which I'm not going to reproduce. Applies to GUI only. Reproduction:
@down to 8... - 11:07 AM User Interface Feature #2422: add features to BROWSE
- It turns out that for ChUI behavior of Page Down differs for preselect and adaptive queries. For example the followin...
02/07/2015
- 11:38 PM Database Bug #2488: replace runtime compilation of dynamic queries
- Each OPEN QUERY in the following test case (@client-where-simple.p@) will force client-side where clause processing:
... - 07:03 PM Database Bug #2488: replace runtime compilation of dynamic queries
- The regression test was successful. Please commit and distribute the update.
02/06/2015
- 04:15 PM Database Bug #2488: replace runtime compilation of dynamic queries
- The conversion test was successful. There are no differences in the generated code with the attached update.
- 02:07 PM Database Bug #2488: replace runtime compilation of dynamic queries
- > The best alternative is to use your solution from note 43 and rename the new method to @putAnnotationObject()@ so t...
- 02:00 PM Database Bug #2488: replace runtime compilation of dynamic queries
- Eric,
The last updates fail to convert the majic sources. The reason is the @putAnnotation()@ method. Although I use... - 12:38 PM Database Bug #2488: replace runtime compilation of dynamic queries
- Thanks, Ovidiu. Please post your conversion results when that's done. I'll run my tests later today or overnight.
- 07:31 AM Database Bug #2488: replace runtime compilation of dynamic queries
- > * Why did you indent build.xml:265?
There were some TABs characters in that file that I replaced with plain spaces... - 11:03 PM Database Bug #2488: replace runtime compilation of dynamic queries
- Code review 0205a:
* Please put back the indent at @DynamicQueryHelper@:101.
* I think the logging levels used in... - 03:48 PM User Interface Feature #2479: DEFINE IMAGE and image phrase support for both button and image
- This update for review presents the approach for image-phrase implementation candidate. Needs to check and debug but ...
- 02:20 PM User Interface Feature #1790: implement menu support
- Vadim Gindin wrote:
> Will you also insist on using of @PaintEvent@? If yes could you help me to understand how it s... - 12:28 PM User Interface Feature #1790: implement menu support
- How to properly test static menus deletion?
- 02:13 PM User Interface Feature #2498: implement ADD-LAST() method
- >
> > 6. The item ID generator should not be in the @ControlSetConfig@ class. We are trying to eliminate all logi... - 01:46 PM User Interface Feature #2498: implement ADD-LAST() method
- Greg Shah wrote:
> 2. Is there any way to introduce problems in @ComboBoxModel.calcSelection()@ by relying upon the ... - 01:14 PM User Interface Feature #2498: implement ADD-LAST() method
- Code Review ias_upd20150205a.zip
I really like your nicely factored @ControlSetEntity@ @add*()@ implementation. I... - 12:27 PM User Interface Feature #2498: implement ADD-LAST() method
- Got it. Thank you.
- 12:24 PM User Interface Feature #2498: implement ADD-LAST() method
- > I've also notices that all handle.unwrapXXX() methods work with interfaces while ControlEntity is a class. I don't ...
- 12:04 PM User Interface Feature #2498: implement ADD-LAST() method
- Got it. Actually I've already stated to look at the conversion details.
I've added @unwrapConrolEntity()@ method to ... - 11:52 AM User Interface Feature #2498: implement ADD-LAST() method
- I will do the code review next. Sorry that I have been slow to respond. I've just been very busy.
In regard to t... - 10:26 AM User Interface Feature #2498: implement ADD-LAST() method
- Regression test performed twice.
The following steps failed identically in both runs:
4 ctrlc_11_session1 CTRL... - 08:47 PM Base Language Feature #1628: fix any incompatibilities or missing features of NO-ECHO support
- >Even the character type seems incorrect as the default format for character is x(8). It is not based on the length o...
02/05/2015
- 06:02 PM Base Language Bug #2499: DST portion of the timezone offset is always included when it should be conditional
- I agree. Well done.
- 06:00 PM Base Language Bug #2499: DST portion of the timezone offset is always included when it should be conditional
- I believe I have good news.
The testing of 0204a finished with following result:
gso_ctrlc_tests: 2 fails: once th... - 04:15 PM User Interface Feature #2478: button image support
- The update @evl_upd20150204a.zip@ has been committed in bzr as 10744.
- 04:08 PM User Interface Feature #2478: button image support
- The testing completed. Results: @10742_5c96d7c_20150205_evl.zip@. No regressions confirmed.
I've stopped the serve... - 10:53 AM User Interface Feature #2478: button image support
- I appreciate that you are taking extra care. Thanks.
- 10:36 AM User Interface Feature #2478: button image support
- The runtime testing almost completed. The only issue is the @GSO 269@ test. It failed with two main cycles but passed...
- 03:06 PM User Interface Feature #2498: implement ADD-LAST() method
- Just a notice. It seems that there are some problems with conversion.
1. Conversion of the attached @radio2.p@ progr... - 01:58 PM User Interface Feature #2498: implement ADD-LAST() method
- All done and is ready for the code review. I'm not sure however that frame overflow detection at @RadioSetWidget.addL...
- 03:05 PM Database Bug #2488: replace runtime compilation of dynamic queries
- Eric Faulhaber wrote:
> Before I write up the code review, I need a definitive answer on the client-side where claus... - 01:01 AM Database Bug #2488: replace runtime compilation of dynamic queries
- Before I write up the code review, I need a definitive answer on the client-side where clause processing question in ...
- 11:16 AM Database Feature #2134: configurable denormalization of extent fields into individual fields in schema con...
- Update that excludes temporary table fields from denormalization process. Committed to bzr revision 10743.
- 08:19 PM User Interface Feature #2479: DEFINE IMAGE and image phrase support for both button and image
- This update adds missing in previous update @ImageConfig@ class. Also it resolves the offset-size phrase issues found...
02/04/2015
- 05:09 PM User Interface Feature #2478: button image support
- The conversion testing completed. The generated code is identical. Continue with runtime testing.
- 02:20 PM User Interface Feature #2478: button image support
- > Please go ahead and do one more round of testing, using evl_upd20150204a.zip. If it passes, you can check it in.
... - 01:46 PM User Interface Feature #2478: button image support
- Please go ahead and do one more round of testing, using evl_upd20150204a.zip. If it passes, you can check it in.
- 11:16 AM User Interface Feature #2478: button image support
- Merged with 10741 code base.
- 02:45 PM Base Language Bug #2499: DST portion of the timezone offset is always included when it should be conditional
- Yes, exactly.
- 02:44 PM Base Language Bug #2499: DST portion of the timezone offset is always included when it should be conditional
- Greg Shah wrote:
> 2. Prepare a version of the fix that has the @date.java@ changes merged with the H063 version o... - 02:31 PM Base Language Bug #2499: DST portion of the timezone offset is always included when it should be conditional
- > 1. Check in and distribute om_upd20150203a.zip.
The update was committed to bzr renvo 10742 and distributed by m... - 01:31 PM Base Language Bug #2499: DST portion of the timezone offset is always included when it should be conditional
- Great!
Next steps:
1. Check in and distribute om_upd20150203a.zip.
2. Prepare a version of the fix that has ... - 01:13 PM Base Language Bug #2499: DST portion of the timezone offset is always included when it should be conditional
- Greg Shah wrote:
> I'm fine with the changes. If it passes testing, you can check it in.
The @main@ passed the reg... - 01:03 PM User Interface Feature #2498: implement ADD-LAST() method
- Fixed @SelectionListBody@ to correctly restore selection after list modification
- 10:54 AM User Interface Feature #2498: implement ADD-LAST() method
- Just noticed that ListSelectionModel implementation should be revised - currently it behaves incorrectly after ADD-FI...
- 10:43 AM User Interface Feature #2498: implement ADD-LAST() method
- SELECTION-LIST behaviour fixed to be compatible with 4GL (both in SINGLE and MULTIPLE selection modes).
RADIO-SET ... - 08:20 PM User Interface Feature #2479: DEFINE IMAGE and image phrase support for both button and image
- This update for review includes suggest for runtime implementation for image phrase for image widget. In general it w...
02/03/2015
- 03:22 PM User Interface Feature #2498: implement ADD-LAST() method
- Implemented @ADD-LAST()@ and fixed @ADD-FIRST()@ for RADIO-SET.
- 01:07 PM User Interface Feature #2498: implement ADD-LAST() method
- Yes, please fix it.
- 12:40 PM User Interface Feature #2498: implement ADD-LAST() method
- ADD-FIRST/ADD-LAST/DELETE functionality for SELECTION-LIST look OK.
However I've noticed that Java runtime doesn't a... - 09:27 AM User Interface Feature #2498: implement ADD-LAST() method
- An id field is added to ControlSetItem. Now the behaviour of COMBO-BOX widget after ADD-FIRST/ADD-LAST/DELETE operati...
- 02:14 PM User Interface Feature #1790: implement menu support
- Could you help me with initial focus setting. I'm trying to set focus on a first menu-item in a shown pop-up menu i.e...
- 12:45 PM Base Language Bug #2511: timestamp instance oddity when assigning to a datetime
- Consider the following P4GL code fragment executed on windev01, configured with timezone UTC+02:00 (only need to be o...
- 12:11 PM Base Language Bug #2511 (New): timestamp instance oddity when assigning to a datetime
- 11:21 AM Base Language Bug #2499: DST portion of the timezone offset is always included when it should be conditional
- The om_upd20150203a.zip update has:
* 3 fails in CTRL+C
* 2 fails in gc_tests
* 6 fails in tc_tests
Except for ... - 07:44 AM Base Language Bug #2499: DST portion of the timezone offset is always included when it should be conditional
- Code Review om_upd20150203a.zip
I'm fine with the changes. If it passes testing, you can check it in.
Please a...
02/02/2015
- 05:34 PM Base Language Bug #2499: DST portion of the timezone offset is always included when it should be conditional
- I am putting this update to test.
It passed my tests regarding the DST. Yet, there is an issue regarding the assign... - 03:55 PM User Interface Feature #2422: add features to BROWSE
- Addition to note 63. Another 4GL bug which I'm not going to reproduce. Applies to ChUI and GUI. If the number of rows...
- 02:50 PM User Interface Feature #2498: implement ADD-LAST() method
- Most of the above is implemented (for COMBO-BOX). However the issue with the value shown in the box after @ADD-FIRST@...
- 10:25 AM User Interface Feature #2478: button image support
- The @evl_upd20150202a.zip@ also merged with 10739.
- 09:15 AM User Interface Feature #2478: button image support
- Update merged with 10738 code base.
02/01/2015
- 03:52 PM User Interface Feature #2478: button image support
- Update merged with the 10736 code base.
- 11:02 PM User Interface Feature #2478: button image support
- Sorry, there are 2 updates in front of you right now. Hynek's is first and then Constantin has one. Thanks for your...
- 11:50 AM User Interface Feature #2498: implement ADD-LAST() method
- Good work in finding these issues.
> Should I start working on the issues mentioned above?
Yes, please do. - 11:15 AM User Interface Feature #2498: implement ADD-LAST() method
- It is easy to implement section 2 (e.g by adding @realValue@ field to @ControlSetItem@ in addition to @value@ - for @...
- 11:41 AM Base Language Bug #2510 (Closed): client-side context reset problem
- Let's not worry about this now. Your update is a good, safe movement forward.
- 11:36 AM Base Language Bug #2510: client-side context reset problem
- Greg Shah wrote:
> You can go ahead and check it in.
Released to rev 10734.
> My only question is whether the C... - 11:30 AM Base Language Bug #2510: client-side context reset problem
- You can go ahead and check it in.
- 11:30 AM Base Language Bug #2510: client-side context reset problem
- Code Review ca_upd20150131c.zip
It looks good. My only question is whether the @ContextLocal@ should also have it... - 10:37 AM Base Language Bug #2510 (Review): client-side context reset problem
- Attached update fixes the reset of client-side context data, when CTRL-C is pressed and ClientCore.start loop goes to...
- 10:36 AM Base Language Bug #2510 (Closed): client-side context reset problem
01/31/2015
- 05:36 PM User Interface Feature #2478: button image support
- Merged with recent code base. Is it time to start new round or there will be more updates?
- 02:38 PM User Interface Feature #1790: implement menu support
- I didn't find a way to get it work with posting @PaintEvent@. But I've fixed the bug adding @menu.requestSync()@ call...
01/30/2015
- 05:01 PM User Interface Feature #2478: button image support
- > Normally, the answer would be yes. But right now we are in the middle of a number of conflicting updates that have...
- 04:57 PM User Interface Feature #2478: button image support
- Normally, the answer would be yes. But right now we are in the middle of a number of conflicting updates that have @...
- 11:43 AM User Interface Feature #2478: button image support
- The @CTRL-C@ part completed without regression. 3-way tests was started in a separate session. The results file on sh...
- 07:56 AM User Interface Feature #2478: button image support
- Finally I have got the main part completed without regression. Starting the @CTRL-C@ tests.
- 04:51 PM User Interface Feature #2479: DEFINE IMAGE and image phrase support for both button and image
- This update for your review includes conversion support implementation candidate for @size-phrase@ and @image-phrase@...
- 05:35 AM User Interface Feature #2479: DEFINE IMAGE and image phrase support for both button and image
- Yes, please implement this.
- 05:25 AM User Interface Feature #2479: DEFINE IMAGE and image phrase support for both button and image
- Question. Do we need th support for @FROM {X n Y n} | {ROW n COLUMN n}@ clause of the @image phrase@?
This sets th... - 03:31 PM User Interface Feature #1790: implement menu support
- I did as you advised. I used @menu.setVisible(true)@ that calls @repaint()@ method, that in turn call @EventManager.p...
- 11:22 AM User Interface Feature #1790: implement menu support
- Greg Shah wrote:
> 1. I think your drawing issues are related to how you are directly calling @menu.draw()@ in @Thi... - 08:44 AM User Interface Feature #1790: implement menu support
- > but still got mbar.getSelf().readOnlyError("popup-only");.
You have to add the attribute into the writable attri... - 08:06 AM User Interface Feature #1790: implement menu support
- # I've added POPUP-ONLY to @load_descriptiors@ function along with other menu related attributes, created @MenuInterf...
- 03:27 PM User Interface Feature #2498: implement ADD-LAST() method
- Additional details about COMBO-BOX widget behaviour in presence of duplicated/"unknown" labels/values:
1. empty labe... - 08:41 AM User Interface Feature #2498: implement ADD-LAST() method
- > May be it makes sense to fix the implementation of ADD-FIRST as well (the current implementation also doesn't show ...
- 07:48 AM User Interface Feature #2498: implement ADD-LAST() method
- If "unknown value is specified for @ADD-LAST(items)@ method it is accepted but on the screen a blank line is shown (i...
- 12:40 PM Base Language Bug #2509 (Closed): problem converting INPUT x @ y constructs
- 12:27 PM Base Language Bug #2509: problem converting INPUT x @ y constructs
- P2J incorrectly resolves the frame of a @INPUT i@ expression, in a case like this:...
- 12:23 PM Base Language Bug #2509 (Closed): problem converting INPUT x @ y constructs
- 08:16 AM User Interface Bug #2497: ANY-PRINTABLE only works for specific widget triggers, but not frame or global anywhere
- LE: the trigger in note 22 was changed to be for the frame, not widget.
- 08:12 AM User Interface Bug #2497: ANY-PRINTABLE only works for specific widget triggers, but not frame or global anywhere
- I'm noting this here, but is a bug, not a regression; the following case doesn't work in P2J:...
- 06:56 AM User Interface Bug #2497: ANY-PRINTABLE only works for specific widget triggers, but not frame or global anywhere
- The changes are doing well in regression testing. I got timeout failures in tc_item_master_006, tc_item_master_104 a...
- 05:21 AM Base Language Bug #2507 (Closed): format validation with editing blocks
- 01:11 AM Base Language Bug #2507: format validation with editing blocks
- Greg Shah wrote:
> Code Review ca_upd20150129b.zip
>
> I'm fine with the changes.
Passed runtime testing, re...
01/29/2015
- 06:20 PM User Interface Feature #1790: implement menu support
- Code Review vig_upd20150130a.zip
I think it is moving in the right direction.
1. I think your drawing issues ar... - 03:54 PM User Interface Feature #1790: implement menu support
- The next update, containing the following changes.
# The first working (in testing mode) variant with popup-menu.
#... - 08:29 AM User Interface Feature #1790: implement menu support
- OK. Keep this in mind when you are working on getting the event processing to work properly.
- 05:38 AM User Interface Feature #1790: implement menu support
- Greg Shah wrote:
> Can you create a trigger on this event and use no-apply? Something like this:
>
> [...]
>... - 05:51 PM Base Language Bug #2499: DST portion of the timezone offset is always included when it should be conditional
- Code Review om_upd20150129b.zip
There are no changes in the @datetime.java@ that was in the update zip. Otherwise... - 02:44 PM Base Language Bug #2499: DST portion of the timezone offset is always included when it should be conditional
- This is most likely an RC.
I only done the 'theoretical' checking on @datetime@ and @datetimetz@. I am preparing no... - 05:31 PM User Interface Feature #2252: implement GUI client support
- Greg Shah wrote:
> Code Review hc_upd20150129b.zip
>
> My review of ZCL is not very very deep. But overall, I'm ... - 05:07 PM User Interface Feature #2252: implement GUI client support
- Code Review hc_upd20150129b.zip
My review of ZCL is not very very deep. But overall, I'm fine with the update. O... - 10:51 AM User Interface Feature #2252: implement GUI client support
- Constantin Asofiei wrote:
>
> After re-enabling this code for the case oldLbl is null, the NPE is no longer there.... - 05:43 AM User Interface Feature #2252: implement GUI client support
- Hynek Cihlar wrote:
> > > An update, the NPE is caused by my changes. I have changed the side-label management sligh... - 05:06 AM User Interface Feature #2252: implement GUI client support
- Constantin Asofiei wrote:
> Hynek Cihlar wrote:
> > Constantin Asofiei wrote:
> > > Hynek Cihlar wrote:
> > > > Const... - 04:52 AM User Interface Feature #2252: implement GUI client support
- Hynek Cihlar wrote:
> Constantin Asofiei wrote:
> > Hynek Cihlar wrote:
> > > Constantin, this also touches some o... - 04:18 AM User Interface Feature #2252: implement GUI client support
- Constantin Asofiei wrote:
> Hynek Cihlar wrote:
> > Constantin, this also touches some of your side-label changes, ... - 03:24 AM User Interface Feature #2252: implement GUI client support
- Hynek Cihlar wrote:
> Constantin, this also touches some of your side-label changes, please have a look too. Also no... - 02:44 AM User Interface Feature #2252: implement GUI client support
- Replacement for ca_upd20150123a.zip, side-labels in shared frames.
Passed runtime testing, released to rev 10725. - 08:51 PM User Interface Feature #2252: implement GUI client support
- The attached update adds support for moving frame widgets by setting col/row/x/y attributes from application code. Th...
- 04:37 PM User Interface Feature #2508: test LIST-ITEMS support in P2J and confirm that it is complete, add or fix feature...
- This attribute is available on selection list, combo-box and browse column. Please write use cases to test it, inclu...
- 04:33 PM User Interface Feature #2508 (Closed): test LIST-ITEMS support in P2J and confirm that it is complete, add or fi...
- 04:28 PM Base Language Bug #2507: format validation with editing blocks
- Code Review ca_upd20150129b.zip
I'm fine with the changes. - 03:57 PM Base Language Bug #2507: format validation with editing blocks
- > This is going through runtime testing now.
CTRL-C passed, MAIN part was killed and restarted, as after ~5 hours ... - 10:52 AM Base Language Bug #2507: format validation with editing blocks
- This is replacement of 0128a.zip. Enhances the support for character formats and is a good step forward, but there ar...
- 04:11 PM User Interface Bug #2497: ANY-PRINTABLE only works for specific widget triggers, but not frame or global anywhere
- > there are the testcases/uast/*focus*.p tests.
Good idea. I'll see if they can be used to test this out. - 04:09 PM User Interface Bug #2497: ANY-PRINTABLE only works for specific widget triggers, but not frame or global anywhere
- Greg Shah wrote:
> I wonder if it is worth testing my second approach with MAJIC.
Yes, I think this one is OK to te... - 03:57 PM User Interface Bug #2497: ANY-PRINTABLE only works for specific widget triggers, but not frame or global anywhere
- I've tried the following idea:...
- 03:54 PM User Interface Bug #2497: ANY-PRINTABLE only works for specific widget triggers, but not frame or global anywhere
- Greg Shah wrote:
> That is a strange result. I wouldn't have expected that without NO-APPLY. The entry/leave proce... - 03:37 PM User Interface Bug #2497: ANY-PRINTABLE only works for specific widget triggers, but not frame or global anywhere
- That is a strange result. I wouldn't have expected that without NO-APPLY. The entry/leave processing must be respon...
- 03:26 PM User Interface Bug #2497: ANY-PRINTABLE only works for specific widget triggers, but not frame or global anywhere
- @refocusTarget@ might have been used to solve a case like this:...
- 02:43 PM User Interface Bug #2497: ANY-PRINTABLE only works for specific widget triggers, but not frame or global anywhere
- The change to add @refocusTarget()@ came in rev 9907 (H649 on 20101015 by SIY). There is no indication of why this w...
- 02:26 PM User Interface Bug #2497: ANY-PRINTABLE only works for specific widget triggers, but not frame or global anywhere
- I stepped over that @refocusTarget()@ call because I knew the target widget was already in focus.
I don't fully un... - 01:25 PM User Interface Bug #2497: ANY-PRINTABLE only works for specific widget triggers, but not frame or global anywhere
- Greg Shah wrote:
> Part of the problem is that the screen refreshes are deferred so I can't see when the cursor move... - 01:02 PM User Interface Bug #2497: ANY-PRINTABLE only works for specific widget triggers, but not frame or global anywhere
- This update fixes the trigger recursion but the cursor is still always forced back to the first char position. I hav...
- 07:11 PM User Interface Bug #2497: ANY-PRINTABLE only works for specific widget triggers, but not frame or global anywhere
- Actually, we do have generic protection logic for trigger recursion. It is located in @LogicalTerminal.trigger()@:
... - 02:46 PM Database Bug #2488: replace runtime compilation of dynamic queries
- This update fixes the copy/paste bug revealed by issues #2500 and #2501.
- 02:36 PM User Interface Feature #2494 (Closed): DELETE() method runtime implementation
- 02:34 PM User Interface Feature #2494: DELETE() method runtime implementation
- Passed runtime regression testing and checked in as bzr rev 10727.
- 02:05 PM User Interface Feature #2494: DELETE() method runtime implementation
- You can check in the update and send the associated notification email.
Please make sure you have no other changes... - 01:48 PM User Interface Feature #2494: DELETE() method runtime implementation
- Igor Skornyakov wrote:
> Actually the is one test which failed in exactly the same way in both runs:
>
> failure ... - 01:44 PM User Interface Feature #2494: DELETE() method runtime implementation
- Actually the is one test which failed in exactly the same way in both runs:
failure in step 40: 'Unexpected EOF in... - 01:05 PM User Interface Feature #2494: DELETE() method runtime implementation
- Are there any specific tests that failed in both runs (even though the failure was at a different point)? The only w...
- 12:41 PM User Interface Feature #2494: DELETE() method runtime implementation
- Second run of the regression test failed:
2 gso_tests Specific GSO testcases to regression test. FAILED NONE gs... - 08:34 AM User Interface Feature #2494: DELETE() method runtime implementation
- Merged with recent changes
- 01:05 PM User Interface Feature #2498: implement ADD-LAST() method
- Yes and yes.
- 12:28 PM User Interface Feature #2498: implement ADD-LAST() method
- I have a question.
As far as I understand there is no "null" value in ABL - it has "unknown" (literal ?) instead. If... - 07:02 PM User Interface Feature #2478: button image support
- Conversion testing completed. The codes are identical. Starting the runtime testing.
01/28/2015
- 05:21 PM User Interface Feature #2494: DELETE() method runtime implementation
- 1 tests failed:
2 gso_tests Specific GSO testcases to regression test. FAILED NONE gso_tests 2314.617 ... - 11:16 AM User Interface Feature #2494: DELETE() method runtime implementation
- Greg Shah wrote:
> Code Review ias_upd20150128a.zip (which is really ias_upd20150128b.zip)
>
> I'm OK with the ch... - 11:09 AM User Interface Feature #2494: DELETE() method runtime implementation
- Code Review ias_upd20150128a.zip (which is really ias_upd20150128b.zip)
I'm OK with the changes. Please get them ... - 11:08 AM User Interface Feature #2494: DELETE() method runtime implementation
- Sorry, I wasn't looking carefully enough. I see that you defined your own interface to match the concept of the @Fun...
- 11:07 AM User Interface Feature #2494: DELETE() method runtime implementation
- Also, please don't upload modified updates as the same update zip file name. The update in note 80 is your second up...
- 11:05 AM User Interface Feature #2494: DELETE() method runtime implementation
- I don't understand. Isn't @Function@ a Java 8 thing or a Guava thing? Neither should be used in our code. Where in...
- 10:24 AM User Interface Feature #2494: DELETE() method runtime implementation
- Greg Shah wrote:
> 1. We do not yet support Java 8. We want to do so, but it takes some real planning because it re... - 09:55 AM User Interface Feature #2494: DELETE() method runtime implementation
- Code Review ias_upd20150128a.zip
1. We do not yet support Java 8. We want to do so, but it takes some real planni... - 06:27 AM User Interface Feature #2494: DELETE() method runtime implementation
- Java code updated: use value instead of label in the @DELETE(list-items)@ for COMBO-BOX and SELECTION-LIST widgets.
- 05:11 PM User Interface Feature #2498: implement ADD-LAST() method
- Do you have testcases for the errors and edge cases?
Please collect all of your testcases and check them into the ... - 04:57 PM User Interface Feature #2498: implement ADD-LAST() method
- Greg Shah wrote:
> Please check how this works with parameters that are unknown value and empty string.
>
> Pleas... - 04:48 PM User Interface Feature #2498: implement ADD-LAST() method
- Please check how this works with parameters that are unknown value and empty string.
Please also check how it work... - 03:36 PM User Interface Feature #2498: implement ADD-LAST() method
- Greg,
1. Can I start Java runtime implementation?
2. Should I try to implement the described "strange" behaviour if... - 03:16 PM User Interface Feature #2498: implement ADD-LAST() method
- Sample 4GL programs
- 01:55 PM User Interface Feature #2498: implement ADD-LAST() method
- The RADIO-SET widget has only @ADD-LAST(label, value)@ method.
It just adds the new label/value to the widget.
If AUT... - 10:42 AM User Interface Feature #2498: implement ADD-LAST() method
- For COMBO-BOX and SELECTION-LIST:
1. If LIST-ITEM-PAIRS is set then @ADD-LAST(items)@ is rejected with two warnings (... - 05:06 PM User Interface Feature #1790: implement menu support
- > Assume we have a button with popup-menu assigned. We must press ESC-U for CHUI or F4 for WINDOWS to call this menu ...
- 04:37 PM User Interface Feature #1790: implement menu support
- I also want to add, that I faced with conversion bug for frames during conversion of @chui_menu_2_purpose.p@. Extra f...
- 04:31 PM User Interface Feature #1790: implement menu support
- I need an advice. Assume we have a button with popup-menu assigned. We must press ESC-U for CHUI or F4 for WINDOWS to...
- 03:02 PM User Interface Feature #1790: implement menu support
- I'm working on showing POPUP-MENU for widgets. I'd like to add this too.
About @MenuElementConfig@. There is some ... - 12:56 PM User Interface Feature #1790: implement menu support
- I'd like to see this next set of functionality stabilized and put into testing. What is left to do?
- 12:55 PM User Interface Feature #1790: implement menu support
- Code Review vig_upd20150128a.zip
Overall, this is MUCH better than the previous approach. Well done.
1. Menus n... - 04:52 PM Base Language Bug #2499: DST portion of the timezone offset is always included when it should be conditional
- I'm good with this approach if you find the the @datetime@ and @datetimetz@ are OK too.
- 04:37 PM Base Language Bug #2499 (WIP): DST portion of the timezone offset is always included when it should be conditional
- Most likely, the code inside @getDefaultOffset@ should be fixed:...
- 04:21 PM Database Bug #2488 (WIP): replace runtime compilation of dynamic queries
- Added 'dumb' cache implementation and some additional fixes.
- 04:03 PM User Interface Bug #2497: ANY-PRINTABLE only works for specific widget triggers, but not frame or global anywhere
- This update (which does make ANY-PRINTABLE more widely functional), can also cause problems. This code that applies ...
- 03:01 PM User Interface Feature #2478: button image support
- >It looks good. Please do get it tested.
OK. Starting the conversion testing stage(we have the rule changed). - 02:56 PM User Interface Feature #2478: button image support
- Code Review evl_upd20150128a.zip
It looks good. Please do get it tested. - 02:50 PM User Interface Feature #2478: button image support
- Reworked image loading support.
- New interfaces added, reworked conversion rule for methods.
- bit change for imag... - 12:56 PM User Interface Feature #2478: button image support
- > So we can run testing now or postpone to the time the interface rework is ready. What do you think?
Do the rewor... - 12:25 PM User Interface Feature #2478: button image support
- >This update seems pretty close to something that can go into regression testing. Is there anything else needed excep...
- 12:13 PM User Interface Feature #2478 (WIP): button image support
- > Is it answering to your question?
Yes.
This update seems pretty close to something that can go into regressio... - 11:24 AM User Interface Feature #2478: button image support
- >1. There are no real changes in ButtonWidget, just a history entry. I think that can be removed safely. :)
OK. Done... - 11:01 AM User Interface Feature #2478: button image support
- Code Review evl_upd20150127a.zip
I like it.
1. There are no real changes in @ButtonWidget@, just a history entr... - 08:27 PM User Interface Feature #2478: button image support
- Small update to add method interfaces to support dynamic button/image widgets.
- 11:55 AM Base Language Bug #2507: format validation with editing blocks
- Greg Shah wrote:
> Code Review ca_upd20150128a.zip
>
> My only concern is with the use of @checkFormat()@ instead... - 08:31 AM Base Language Bug #2507: format validation with editing blocks
- Code Review ca_upd20150128a.zip
My only concern is with the use of @checkFormat()@ instead of @validateFormat()@ o... - 04:19 AM Base Language Bug #2507: format validation with editing blocks
- From what I see, the format validation is done when LEAVE is sent for the widget. More, when EDITING mode is enabled...
- 04:05 AM Base Language Bug #2507: format validation with editing blocks
- Constantin,
Consider this:... - 04:04 AM Base Language Bug #2507 (Closed): format validation with editing blocks
01/27/2015
- 03:46 PM User Interface Feature #2494: DELETE() method runtime implementation
- It appears that my understanding of the DELETE() method semantics was incorrect -the @DELETE(list-items)@ for COMBO-B...
- 08:47 AM User Interface Feature #2494: DELETE() method runtime implementation
- Code Review ias_upd20150127a.zip
The changes look good.
I agree that the testing failures are most likely not d... - 06:00 AM User Interface Feature #2494: DELETE() method runtime implementation
- Some regression tests failed:
1. 1. failure in step 13: 'timeout before the specific screen buffer became available ... - 02:31 PM User Interface Feature #1790: implement menu support
- 1) I've prepared the next update with separate menu description class. Does it preferable than previous updates with ...
- 04:26 AM User Interface Bug #2495: APPLY event TO handle does not work
- ca_upd20150127a.zip passed conversion testing and was released to bzr rev 10723
- 04:26 AM User Interface Bug #2495: APPLY event TO handle does not work
- Fixed some conversion issues related to APPLY TO handle.
Anything which has a frame-id needs to convert as a Gener... - 08:29 PM User Interface Feature #2478: button image support
- Had to modify @CommonWidget/GenericWidget@ classes to add @loadImage*()@ methods support to handle dynamically alloca...
01/26/2015
- 02:44 PM User Interface Feature #2494: DELETE() method runtime implementation
- Thank you.
- 02:24 PM User Interface Feature #2494: DELETE() method runtime implementation
- Igor Skornyakov wrote:
> I tried to run regression test, but it failed (runtime-regression).
The problem is with y... - 02:22 PM User Interface Feature #2494: DELETE() method runtime implementation
- Got it. Thank you for your patience. I've configured Eclipse to avoid specific explicit imports. BTW: what about stat...
- 01:37 PM User Interface Feature #2494: DELETE() method runtime implementation
- Code Review ias_upd20150124d.zip
Almost there. 5 small problems are remaining. Sorry that we are so specific in o... - 06:51 AM User Interface Feature #2494: DELETE() method runtime implementation
- I'm very sorry, but I've dropped the entire content of the repo by a stupid mistake. How this can be repaired?
- 06:08 AM User Interface Feature #2494: DELETE() method runtime implementation
- Something is wrong with your repo, see this like:...
- 06:03 AM User Interface Feature #2494: DELETE() method runtime implementation
- I've tried to run regression testing but the compilation failed. Please find the build logs attached. As I can see th...
- 02:42 PM Base Language Bug #2499: DST portion of the timezone offset is always included when it should be conditional
- Some ideas about automating the DST testing (in junits or date.main):
> Ovidiu Maxiniuc wrote:
Java 8 has some new A... - 12:35 PM Base Language Feature #1628: fix any incompatibilities or missing features of NO-ECHO support
- Evgeny Kiselev wrote:
> My changes in @Window@ class is issue for gso_276 test. Looking for approach.
Did you int... - 12:34 PM Base Language Feature #1628: fix any incompatibilities or missing features of NO-ECHO support
- Code Review evk_upd20150126a.zip
1. Please remove @import org.apache.commons.logging.*;@ from @Stream.java@.
2.... - 07:46 AM Base Language Feature #1628: fix any incompatibilities or missing features of NO-ECHO support
- My changes in @Window@ class is issue for gso_276 test. Looking for approach.
- 09:01 PM Base Language Feature #1628: fix any incompatibilities or missing features of NO-ECHO support
- Tests gso_17 and gso_488 has been fixed in @Stream@ class. Even if output is unformatted we still need to use formatt...
- 12:01 PM Runtime Infrastructure Feature #2506: provide support for substitution variables which can be inserted in PROPATH entrie...
- In the 4GL, the PROPATH is often specified in scripts which modify the environment before launching the Progress clie...
- 11:53 AM Runtime Infrastructure Feature #2506 (New): provide support for substitution variables which can be inserted in PROPATH ...
- 11:51 AM Base Language Feature #2505: SEARCH and loading of static resources from the server-side application jar
- Today our SEARCH and any file reading occurs exclusively on the client side. As part of #2476 we are implementing su...
- 11:47 AM Base Language Feature #2505 (New): SEARCH and loading of static resources from the server-side application jar
- 11:46 AM Base Language Feature #2504: real environment access for OS-GETENV
- Today we map OS-GETENV to the JVM @System.getProperty()@ which does not real from real environment variables, but ins...
- 11:40 AM Base Language Feature #2504 (Closed): real environment access for OS-GETENV
- 11:38 AM Conversion Tools Feature #2503: improve ConversionDriver.main() to provide back a return code and/or better handle...
- From a customer:
> Conversion failed last night (because we checked something in that we shouldn't have done - a c... - 11:37 AM Conversion Tools Feature #2503 (WIP): improve ConversionDriver.main() to provide back a return code and/or better ...
- 11:35 AM Conversion Tools Feature #2502: using a file list as input for the ConversionDriver fails if there is trailing space
- Even a single trailing space will cause the file to be silently not found, leading to unexpected results. I haven't ...
- 11:33 AM Conversion Tools Feature #2502 (New): using a file list as input for the ConversionDriver fails if there is traili...
- 03:14 AM Database Bug #2488: replace runtime compilation of dynamic queries
- Eric,
If you did not started the review, please find attached an update that adds the missing javadocs to @RuntimeJa...
01/24/2015
- 02:53 PM User Interface Bug #2497 (Closed): ANY-PRINTABLE only works for specific widget triggers, but not frame or globa...
- Passed regression testing and checked in as bzr rev 10720.
Also available in: Atom