FWD

09/16/2020

05:16 AM Database Support #4701: try to improve H2 transaction commit performance

Just rebased 4701a using 3821c. Adrian Lungu

03:36 AM Database Support #4701: try to improve H2 transaction commit performance

Eric Faulhaber wrote:
> Code review 4701a, rev 11624-11627:
>
> This review is for the private vs. shared temp-ta... Adrian Lungu

09/15/2020

07:24 PM Database Support #4701: try to improve H2 transaction commit performance

Code review 4701a, rev 11624-11627:
This review is for the private vs. shared temp-table database implementation. ... Eric Faulhaber

10:03 AM Runtime Infrastructure Feature #4026: ensure all objects transmitted over the DAP implement Externalizable

Constantin Asofiei wrote:
> Igor, DatasetWrapper was changed that a string is read via @readString@ instead of @read... Igor Skornyakov

09:52 AM Runtime Infrastructure Feature #4026: ensure all objects transmitted over the DAP implement Externalizable

Igor, DatasetWrapper was changed that a string is read via @readString@ instead of @readObject@, but there is a case ... Constantin Asofiei

02:59 AM Base Language Bug #4891 (New): Nested method calls ignore 'silent' (no-error) option.

It looks like when a method is calling another method the original 'no-error' option used is ignored and the error th... Marian Edu

09/14/2020

09:49 AM Runtime Infrastructure Feature #4026: ensure all objects transmitted over the DAP implement Externalizable

Greg Shah wrote:
> Code Review Task Branch 3821c Revision 11529
>
> The changes are quite good.
>
> 1. Please ... Igor Skornyakov

08:37 AM Runtime Infrastructure Feature #4026: ensure all objects transmitted over the DAP implement Externalizable

Code Review Task Branch 3821c Revision 11529
The changes are quite good.
1. Please revert the extra debug outpu... Greg Shah

08:18 AM Runtime Infrastructure Feature #4026: ensure all objects transmitted over the DAP implement Externalizable

Greg Shah wrote:
> Do these changes have any dependencies in the large customer project (which subclasses the tree c... Igor Skornyakov

08:14 AM Runtime Infrastructure Feature #4026: ensure all objects transmitted over the DAP implement Externalizable

Do these changes have any dependencies in the large customer project (which subclasses the tree control) that must al... Greg Shah

08:12 AM Runtime Infrastructure Feature #4026: ensure all objects transmitted over the DAP implement Externalizable

More (de)serialization changes committed to 3821c rev 11529.
This essentially finishes the re-work.
The commit also... Igor Skornyakov

08:30 AM Base Language Feature #4384: Builtin OO Implementation

Greg Shah wrote:
> Can you please give it a try? The database will need to be re-imported as well as reconverting e... Marian Edu

07:35 AM Base Language Feature #4384: Builtin OO Implementation

Sorry, I should have considered that. This version inlcudes the result of a 12-18 month effort to rewrite our persis... Greg Shah

07:05 AM Base Language Feature #4384: Builtin OO Implementation

Marian Edu wrote:
> It fails on 'primary', apparently because of missing 'ORM' settings... what should we have there... Marian Edu

07:00 AM Base Language Feature #4384: Builtin OO Implementation

Greg Shah wrote:
> I've merged all changes from 4384e revisions 11450 through 11472 into 3821c as revision 11523.
>... Marian Edu

05:53 AM Database Support #4701: try to improve H2 transaction commit performance

4701a is independent upon the H2 version. Adrian Lungu

05:51 AM Database Support #4701: try to improve H2 transaction commit performance

Does this depend upon a new version of H2? Greg Shah

05:07 AM Database Support #4701: try to improve H2 transaction commit performance

I find 4701a safe enough. The major change is the new private vs shared temporary database. Using a shared temporary ... Adrian Lungu

09/13/2020

06:03 PM Base Language Feature #4384: Builtin OO Implementation

I've merged all changes from 4384e revisions 11450 through 11472 into 3821c as revision 11523.
I've create a new 4... Greg Shah

11:13 AM Database Support #4701: try to improve H2 transaction commit performance

How risky is 4701a? Greg Shah

09/10/2020

10:32 AM Base Language Feature #1970: improve ControlFlowOps method resolution by reflection

There is already a @runSuper(Class<?>,...)@ which is emitted only for functions. I don't recall if @runSuper(String ... Constantin Asofiei

10:30 AM Base Language Feature #1970: improve ControlFlowOps method resolution by reflection

I'm planning to separate @RUN SUPER@ from @SUPER()@ (they both convert as @runSuper()@ today):... Greg Shah

05:58 AM Base Language Feature #3855: implement equivalent support for REST (classic appserver, PASOE REST and WEB trans...

Runtime for multiple .paar support for legacy REST services is in 3821c rev 11512 Constantin Asofiei

05:58 AM Database Feature #3574: finish implementation of temp-table XML support

Conversion and runtime stubs for @SERIALIZE-ROW()@ method are in 3821c rev 11512 Constantin Asofiei

09/09/2020

09:37 AM Database Feature #4011: database/persistence layer performance improvements

We don't want to move to 4.1 before we release 4.0. On the other hand, this is a very major change. Until 4.0 is re... Greg Shah

09:17 AM Database Feature #4011: database/persistence layer performance improvements

Eric Faulhaber wrote:
> 4011e was merged to trunk and committed as revision 11348.
Was there a FWD revision numbe... Roger Borrello

04:42 AM Database Support #4701 (Review): try to improve H2 transaction commit performance

This task in finished. Waiting to rebase 4701b and eventually merge to trunk/3821c. However, I suggest to keep #4843 ... Adrian Lungu

09/08/2020

06:23 PM Database Feature #4011: database/persistence layer performance improvements

Trunk revisions 11347.1.316 and 11347.1.318 implemented a mechanism to keep track of the versions of persistent DMOs ... Eric Faulhaber

06:16 PM Database Feature #4011: database/persistence layer performance improvements

4011e was merged to trunk and committed as revision 11348. Eric Faulhaber

05:14 PM Database Feature #2156 (Closed): datetime-tz and hibernate

Please make the change in 3821c. I'm going to close this task.
> I say probably because the new ORM has not yet b... Greg Shah

05:11 PM Database Feature #2156: datetime-tz and hibernate

Greg Shah wrote:
> @datetime-tz@ field persistence is fully supported now?
Yes, that was one of the aspects we bene... Ovidiu Maxiniuc

04:56 PM Database Feature #2156: datetime-tz and hibernate

@datetime-tz@ field persistence is fully supported now? Do we need to change anything in our gap marking? Greg Shah

04:48 PM Database Feature #2156: datetime-tz and hibernate

Yes.
It is rather obsolete as we have now a much simpler access to DTZ fields using the new ORM. Ovidiu Maxiniuc

04:44 PM Database Feature #2156: datetime-tz and hibernate

4011e was merged to trunk as rev 11348.
Eric/Ovidiu: Can we close this task? Greg Shah

03:35 PM Database Support #4701: try to improve H2 transaction commit performance

Is there anything more to work on in this task or do we just need to get it rebased for merge to trunk (or merge into... Greg Shah

09/07/2020

12:27 PM Runtime Infrastructure Feature #4026: ensure all objects transmitted over the DAP implement Externalizable

Fixed type parameters for Tree* classes
Committed to 3821c rev. 11501 and tree-derived widgets in @<customer_appli... Igor Skornyakov

09/04/2020

07:23 AM Runtime Infrastructure Feature #4026: ensure all objects transmitted over the DAP implement Externalizable

Fixed the @WidgetId@ instance (de)serialization when it is actually an instance of the @WidgetDownId@.
Committed t... Igor Skornyakov

09/03/2020

03:04 PM Base Language Feature #1970: improve ControlFlowOps method resolution by reflection

An addition note: a @RUN ... IN@ can target a remote procedure/port-handle - see this code in @ControlFlowOps.invokeI... Constantin Asofiei

01:52 PM Base Language Feature #1970: improve ControlFlowOps method resolution by reflection

Some issues I see:
# @RUN ON SERVER@ shouldn't be touched by this optimization - the resolution is done on the remot... Constantin Asofiei

12:12 PM Base Language Feature #1970: improve ControlFlowOps method resolution by reflection

Greg Shah wrote:
> By the way, it seems to me that in the case where the target name is unique across the project, t... Constantin Asofiei

12:04 PM Base Language Feature #1970: improve ControlFlowOps method resolution by reflection

By the way, it seems to me that in the case where the target name is unique across the project, that we could hard co... Greg Shah

12:02 PM Base Language Feature #1970: improve ControlFlowOps method resolution by reflection

> don't know why internalProcedure doesn't have the this reference and legacy name emitted as arguments (this would ... Greg Shah

09/02/2020

03:51 PM Base Language Feature #1970: improve ControlFlowOps method resolution by reflection

Greg Shah wrote:
> I suspect that we must be doing something expensive inside the @BlockManager.internalProcedure()@... Constantin Asofiei

03:13 PM Base Language Feature #1970: improve ControlFlowOps method resolution by reflection

I've been reviewing the CFS code and debugging through it with testcases to understand the implications of this idea.... Greg Shah

01:31 PM User Interface Bug #4842 (Closed): com-handle of CONTROL-FRAME validity

Greg Shah

11:33 AM User Interface Bug #4842: com-handle of CONTROL-FRAME validity

Code review 3821c revision 11487. The changes seem fine. Hynek Cihlar

10:09 AM Runtime Infrastructure Feature #4026: ensure all objects transmitted over the DAP implement Externalizable

Re-worked (de)serialization of all classes transmitted over DAP from @com.goldencode.p2j.ui package@ except @TreeCon... Igor Skornyakov

09/01/2020

11:43 AM User Interface Bug #4842: com-handle of CONTROL-FRAME validity

Vladimir Tsichevski wrote:
> Fixed in 3821c, rev. 11487.
The change seems OK.
Hynek: Please review. Greg Shah

08/31/2020

01:30 PM Conversion Tools Bug #4154: NPE in ENABLE ALL

Update: now (3821c rev. 11487) the stack trace looks a bit different:... Vladimir Tsichevski

12:22 PM Conversion Tools Bug #4867: Incremental conversion: change detection algorithm ignores .hints and .ext-hints files

Sorry, it was my fault this was in the wrong project. Greg Shah

12:19 PM Conversion Tools Bug #4867: Incremental conversion: change detection algorithm ignores .hints and .ext-hints files

The incremental compilation dependencies calculation procedure must detect changes in @.hints@ and @.ext-hints@ files. Vladimir Tsichevski

12:15 PM Conversion Tools Bug #4867 (Closed): Incremental conversion: change detection algorithm ignores .hints and .ext-hi...

Vladimir Tsichevski

09:33 AM User Interface Bug #4842 (Review): com-handle of CONTROL-FRAME validity

Fixed in 3821c, rev. 11487. Vladimir Tsichevski

09:14 AM User Interface Bug #4842 (WIP): com-handle of CONTROL-FRAME validity

Vladimir Tsichevski

08/25/2020

06:37 AM Runtime Infrastructure Feature #4026: ensure all objects transmitted over the DAP implement Externalizable

Re-worked (de)serialization of the @BaseConfig@ and its subclasses.
Tested with the Hotel GUI and a large customer a... Igor Skornyakov

08/24/2020

12:17 PM Base Language Bug #4682: modify FILE-INFO processing to honor searches for 4GL programs

No reason to make it low priority. It is just a feature that is not needed right now. Greg Shah

12:16 PM Base Language Bug #4682: modify FILE-INFO processing to honor searches for 4GL programs

Greg Shah wrote:
> We have no plans right now. Is it the cause of more problems in real customer apps?
None that... Roger Borrello

12:03 PM Base Language Bug #4682: modify FILE-INFO processing to honor searches for 4GL programs

We have no plans right now. Is it the cause of more problems in real customer apps? Greg Shah

11:59 AM Base Language Bug #4682: modify FILE-INFO processing to honor searches for 4GL programs

The updates I made in #4845-15 were specific to the use of @possenet/src/adm2/containr.p@ to enable the search for a ... Roger Borrello

08/21/2020

03:07 AM Database Feature #3814: more schema metadata

Greg Shah wrote:
> Good job. I think we should pause the work there. Is it safe to include in the branch pending t... Igor Skornyakov

09:03 PM Database Feature #3814: more schema metadata

Good job. I think we should pause the work there. Is it safe to include in the branch pending the final changes? Greg Shah

08:19 PM Base Language Feature #4828: rework ErrorManager to use the TransactionHelper design on the server and a sync'd...

3821c rev 11464 should resolve the @ClassCastException@. Greg Shah

08/20/2020

05:42 PM Database Feature #3814: more schema metadata

@UserTableStatUpdater@ core functionality implemented. The exposed public methods are:
* getTableStats(integer con... Igor Skornyakov

04:24 PM Base Language Feature #4828: rework ErrorManager to use the TransactionHelper design on the server and a sync'd...

Greg,
The rev @11460@ causes abend with @ClassCastException@ regression with current customer application:
<pre... Eugenie Lyzenko

12:08 PM Base Language Feature #4828 (Test): rework ErrorManager to use the TransactionHelper design on the server and a...

3821c revision 11460 greatly reduces the most common context-local lookups for ErrorManager on both the server and cl... Greg Shah