FWD

09/27/2020

04:09 PM Database Bug #4917: eliminate redundant ORDER BY elements in multi-table queries

This fix is intended only for the case where we have sort clauses for more than one table concatenated together, and ... Eric Faulhaber

03:52 PM Database Bug #4917: eliminate redundant ORDER BY elements in multi-table queries

Something to share about my investigations with H2 - if the chosen index didn't match the ORDER BY clause, then H2 wi... Constantin Asofiei

03:15 PM Database Bug #4917: eliminate redundant ORDER BY elements in multi-table queries

I initially thought there would be an @AbstractJoin@ object in the second query component we could use to analyze the... Eric Faulhaber

03:08 PM Database Bug #4917: eliminate redundant ORDER BY elements in multi-table queries

We have found that in certain cases (e.g., optimized @CompoundQuery@), multi-table queries are generated with ORDER B... Eric Faulhaber

02:55 PM Database Bug #4917 (New): eliminate redundant ORDER BY elements in multi-table queries

Eric Faulhaber

09/25/2020

07:09 AM Database Feature #4055: optimize temp-table output parameter copying

Adrian Lungu wrote:
> Unfortunately, almost every member of @RecordBuffer@ should be retrieved through getters in or... Constantin Asofiei

06:38 AM Database Feature #4055: optimize temp-table output parameter copying

Constantin, the testcases work now. Unfortunately, almost every member of @RecordBuffer@ should be retrieved through ... Adrian Lungu

09/24/2020

01:59 PM Database Feature #4055: optimize temp-table output parameter copying

Adrian, I've backed out my ArgumentBuffer change in 3821c rev 11577 - the solution was to use getters for RecordBuffe... Constantin Asofiei

08:24 AM Database Feature #4055: optimize temp-table output parameter copying

Ovidiu Maxiniuc wrote:
> Review of 3821c rev 11565.
>
> The code looks good to me. I cannot say I fully get all o... Constantin Asofiei

11:52 AM User Interface Feature #4912: move UI portions of the web client to the server-side

Greg, wouldn't it make more sense to think of this problem the other way around? Keep the client processes as they ar... Hynek Cihlar

11:06 AM User Interface Feature #4912: move UI portions of the web client to the server-side

When the original UI architecture of FWD was designed, there were 2 "near term" targets: ChUI and fat client GUI (Swi... Greg Shah

09:58 AM User Interface Feature #4912 (New): move UI portions of the web client to the server-side

Greg Shah

09/23/2020

07:48 PM Database Feature #4055: optimize temp-table output parameter copying

Review of 3821c rev 11565.
The code looks good to me. I cannot say I fully get all of it but I did a double pass o... Ovidiu Maxiniuc

06:36 AM Database Feature #4055: optimize temp-table output parameter copying

Adrian, thanks for the explanation. We can't make the @buffer()@ and @definition()@ methods non-final, as this will ... Constantin Asofiei

05:01 AM Database Feature #4055: optimize temp-table output parameter copying

Constantin, the @RecordBuffer$ArgumentBuffer@ seems to be broken - the use of parameter buffers in queries was result... Adrian Lungu

09/22/2020

06:33 PM Database Feature #4055: optimize temp-table output parameter copying

3821c rev 11565 contains another pass at improving the 'field-by-field' copy. @RecordBuffer$DatumAccess@ was enhance... Constantin Asofiei

08:37 AM Base Language Feature #4384: Builtin OO Implementation

Marian Edu wrote:
> Marian Edu wrote:
> >
> > Anyone recognize this behavior, something I need to do to fix it? :... Constantin Asofiei

05:36 AM Base Language Feature #4384: Builtin OO Implementation

Marian Edu wrote:
>
> Anyone recognize this behavior, something I need to do to fix it? :(
Args, the static con... Marian Edu

04:59 AM Base Language Feature #4384: Builtin OO Implementation

Hi guys, I'm banging my head over here for some time already so thought maybe someone could know the cause and hopefu... Marian Edu

09/21/2020

03:43 PM Database Feature #4055: optimize temp-table output parameter copying

There is a bug in dataset-handle parameter copy, when there is a before-table, too - the before-table DMO iface (back... Constantin Asofiei

01:51 PM Database Feature #4055: optimize temp-table output parameter copying

I have some changes which enhance @RecordBuffer$DatumAccess@ to provide more data (like the PropertyMeta, Method inst... Constantin Asofiei

09:36 AM Database Support #4701: try to improve H2 transaction commit performance

In @directory.xml@, the following empty container node should be added (usually right before the database specific co... Adrian Lungu

09/20/2020

03:51 PM Database Support #4701: try to improve H2 transaction commit performance

Adrian: Please document the configuration changes to enable the separate database mode. Greg Shah

09/19/2020

07:16 AM Database Support #4701: try to improve H2 transaction commit performance

Probably the branch was not bound. I did the commit now as revision 11553.
Adrian Lungu

09/18/2020

04:26 PM User Interface Bug #4907: Conversion bug with button triggers

The problem is most likely in @rules/annotations/triggers_phrase_rewrite.rules@. This code:... Greg Shah

03:58 PM User Interface Bug #4907: Conversion bug with button triggers

Greg Shah wrote:
> I guess this is related to the @TRIGGERS@ phrase which is not as commonly used as the @ON@ statem... Vladimir Tsichevski

03:43 PM User Interface Bug #4907: Conversion bug with button triggers

I guess this is related to the @TRIGGERS@ phrase which is not as commonly used as the @ON@ statement.
As a workaro... Greg Shah

03:29 PM User Interface Bug #4907: Conversion bug with button triggers

The trigger, associated with a button is *not* converted.
The 4gl:
@main.p@... Vladimir Tsichevski

03:24 PM User Interface Bug #4907 (New): Conversion bug with button triggers

Vladimir Tsichevski

02:33 PM Database Support #4701: try to improve H2 transaction commit performance

Adrian Lungu wrote:
> Done. Committed in 3821c as revision 11549.
Adrian, I don't see your commit in 3821c. 11549... Eric Faulhaber

07:14 AM Database Support #4701: try to improve H2 transaction commit performance

Done. Committed in 3821c as revision 11549. Adrian Lungu

09/17/2020

04:52 PM Database Feature #4011: database/persistence layer performance improvements

Roger Borrello wrote:
> Is this a safe setting to add into existing projects? In other words, is there a downside ... Eric Faulhaber

04:38 PM Database Feature #4011: database/persistence layer performance improvements

Eric Faulhaber wrote:
> It is *disabled* by default (meaning normal 4GL behavior: temp-tables are undoable unless de... Roger Borrello

03:58 PM Database Feature #4011: database/persistence layer performance improvements

The performance enhancement to force NO-UNDO mode for all temp-tables (regardless of how they were defined) is implem... Eric Faulhaber

02:50 PM Database Support #4701: try to improve H2 transaction commit performance

Adrian: Go ahead and merge into 3821c. If there are any special requirements for rebuilding/deployment, please notif... Greg Shah

01:36 PM Database Support #4701: try to improve H2 transaction commit performance

Adrian, thanks for the explanations. Greg, I am good with the update going into 3821c. Eric Faulhaber

11:31 AM Runtime Infrastructure Feature #4026: ensure all objects transmitted over the DAP implement Externalizable

Rolled back classes from #4026-32 in rev.11546. Igor Skornyakov

11:17 AM Runtime Infrastructure Feature #4026: ensure all objects transmitted over the DAP implement Externalizable

Igor Skornyakov wrote:
> I understand that the following classes should be left @Serializable@ to be accepted by Gwt... Hynek Cihlar

09:13 AM Runtime Infrastructure Feature #4026: ensure all objects transmitted over the DAP implement Externalizable

Greg Shah wrote:
> Hynek/Sergey: Please review #4026-30.
I understand that the following classes should be left @... Igor Skornyakov

09:00 AM Runtime Infrastructure Feature #4026: ensure all objects transmitted over the DAP implement Externalizable

Hynek/Sergey: Please review #4026-30. Greg Shah

08:54 AM Runtime Infrastructure Feature #4026: ensure all objects transmitted over the DAP implement Externalizable

Vladimir Tsichevski wrote:
> Not sure I am posting to the right place, but I am having troubles building FWD with @g... Igor Skornyakov

08:39 AM Runtime Infrastructure Feature #4026: ensure all objects transmitted over the DAP implement Externalizable

Not sure I am posting to the right place, but I am having troubles building FWD with @gradle all@ target in 3821c rev... Vladimir Tsichevski

07:59 AM Runtime Infrastructure Feature #4026 (Test): ensure all objects transmitted over the DAP implement Externalizable

Greg Shah

07:58 AM Runtime Infrastructure Feature #4026: ensure all objects transmitted over the DAP implement Externalizable

From Igor:
> As of 3821c rev. 11545 I've finished re-work of Serilazable to Externalizable in FWD classes. This sh... Greg Shah

07:48 AM Runtime Infrastructure Feature #4026: ensure all objects transmitted over the DAP implement Externalizable

Finished conversion from @Serializable@ to @Externalizable@.
Committed to 3821c rev.11545 Igor Skornyakov

09/16/2020

05:16 AM Database Support #4701: try to improve H2 transaction commit performance

Just rebased 4701a using 3821c. Adrian Lungu

03:36 AM Database Support #4701: try to improve H2 transaction commit performance

Eric Faulhaber wrote:
> Code review 4701a, rev 11624-11627:
>
> This review is for the private vs. shared temp-ta... Adrian Lungu

09/15/2020

07:24 PM Database Support #4701: try to improve H2 transaction commit performance

Code review 4701a, rev 11624-11627:
This review is for the private vs. shared temp-table database implementation. ... Eric Faulhaber

10:03 AM Runtime Infrastructure Feature #4026: ensure all objects transmitted over the DAP implement Externalizable

Constantin Asofiei wrote:
> Igor, DatasetWrapper was changed that a string is read via @readString@ instead of @read... Igor Skornyakov

09:52 AM Runtime Infrastructure Feature #4026: ensure all objects transmitted over the DAP implement Externalizable

Igor, DatasetWrapper was changed that a string is read via @readString@ instead of @readObject@, but there is a case ... Constantin Asofiei

02:59 AM Base Language Bug #4891 (New): Nested method calls ignore 'silent' (no-error) option.

It looks like when a method is calling another method the original 'no-error' option used is ignored and the error th... Marian Edu

09/14/2020

09:49 AM Runtime Infrastructure Feature #4026: ensure all objects transmitted over the DAP implement Externalizable

Greg Shah wrote:
> Code Review Task Branch 3821c Revision 11529
>
> The changes are quite good.
>
> 1. Please ... Igor Skornyakov

08:37 AM Runtime Infrastructure Feature #4026: ensure all objects transmitted over the DAP implement Externalizable

Code Review Task Branch 3821c Revision 11529
The changes are quite good.
1. Please revert the extra debug outpu... Greg Shah

08:18 AM Runtime Infrastructure Feature #4026: ensure all objects transmitted over the DAP implement Externalizable

Greg Shah wrote:
> Do these changes have any dependencies in the large customer project (which subclasses the tree c... Igor Skornyakov

08:14 AM Runtime Infrastructure Feature #4026: ensure all objects transmitted over the DAP implement Externalizable

Do these changes have any dependencies in the large customer project (which subclasses the tree control) that must al... Greg Shah

08:12 AM Runtime Infrastructure Feature #4026: ensure all objects transmitted over the DAP implement Externalizable

More (de)serialization changes committed to 3821c rev 11529.
This essentially finishes the re-work.
The commit also... Igor Skornyakov

08:30 AM Base Language Feature #4384: Builtin OO Implementation

Greg Shah wrote:
> Can you please give it a try? The database will need to be re-imported as well as reconverting e... Marian Edu

07:35 AM Base Language Feature #4384: Builtin OO Implementation

Sorry, I should have considered that. This version inlcudes the result of a 12-18 month effort to rewrite our persis... Greg Shah

07:05 AM Base Language Feature #4384: Builtin OO Implementation

Marian Edu wrote:
> It fails on 'primary', apparently because of missing 'ORM' settings... what should we have there... Marian Edu

07:00 AM Base Language Feature #4384: Builtin OO Implementation

Greg Shah wrote:
> I've merged all changes from 4384e revisions 11450 through 11472 into 3821c as revision 11523.
>... Marian Edu

05:53 AM Database Support #4701: try to improve H2 transaction commit performance

4701a is independent upon the H2 version. Adrian Lungu

05:51 AM Database Support #4701: try to improve H2 transaction commit performance

Does this depend upon a new version of H2? Greg Shah

05:07 AM Database Support #4701: try to improve H2 transaction commit performance

I find 4701a safe enough. The major change is the new private vs shared temporary database. Using a shared temporary ... Adrian Lungu

09/13/2020

06:03 PM Base Language Feature #4384: Builtin OO Implementation

I've merged all changes from 4384e revisions 11450 through 11472 into 3821c as revision 11523.
I've create a new 4... Greg Shah

11:13 AM Database Support #4701: try to improve H2 transaction commit performance

How risky is 4701a? Greg Shah

09/10/2020

10:32 AM Base Language Feature #1970: improve ControlFlowOps method resolution by reflection

There is already a @runSuper(Class<?>,...)@ which is emitted only for functions. I don't recall if @runSuper(String ... Constantin Asofiei

10:30 AM Base Language Feature #1970: improve ControlFlowOps method resolution by reflection

I'm planning to separate @RUN SUPER@ from @SUPER()@ (they both convert as @runSuper()@ today):... Greg Shah

05:58 AM Base Language Feature #3855: implement equivalent support for REST (classic appserver, PASOE REST and WEB trans...

Runtime for multiple .paar support for legacy REST services is in 3821c rev 11512 Constantin Asofiei

05:58 AM Database Feature #3574: finish implementation of temp-table XML support

Conversion and runtime stubs for @SERIALIZE-ROW()@ method are in 3821c rev 11512 Constantin Asofiei

09/09/2020

09:37 AM Database Feature #4011: database/persistence layer performance improvements

We don't want to move to 4.1 before we release 4.0. On the other hand, this is a very major change. Until 4.0 is re... Greg Shah

09:17 AM Database Feature #4011: database/persistence layer performance improvements

Eric Faulhaber wrote:
> 4011e was merged to trunk and committed as revision 11348.
Was there a FWD revision numbe... Roger Borrello

04:42 AM Database Support #4701 (Review): try to improve H2 transaction commit performance

This task in finished. Waiting to rebase 4701b and eventually merge to trunk/3821c. However, I suggest to keep #4843 ... Adrian Lungu

09/08/2020

06:23 PM Database Feature #4011: database/persistence layer performance improvements

Trunk revisions 11347.1.316 and 11347.1.318 implemented a mechanism to keep track of the versions of persistent DMOs ... Eric Faulhaber

06:16 PM Database Feature #4011: database/persistence layer performance improvements

4011e was merged to trunk and committed as revision 11348. Eric Faulhaber

05:14 PM Database Feature #2156 (Closed): datetime-tz and hibernate

Please make the change in 3821c. I'm going to close this task.
> I say probably because the new ORM has not yet b... Greg Shah

05:11 PM Database Feature #2156: datetime-tz and hibernate

Greg Shah wrote:
> @datetime-tz@ field persistence is fully supported now?
Yes, that was one of the aspects we bene... Ovidiu Maxiniuc

04:56 PM Database Feature #2156: datetime-tz and hibernate

@datetime-tz@ field persistence is fully supported now? Do we need to change anything in our gap marking? Greg Shah

04:48 PM Database Feature #2156: datetime-tz and hibernate

Yes.
It is rather obsolete as we have now a much simpler access to DTZ fields using the new ORM. Ovidiu Maxiniuc

04:44 PM Database Feature #2156: datetime-tz and hibernate

4011e was merged to trunk as rev 11348.
Eric/Ovidiu: Can we close this task? Greg Shah

03:35 PM Database Support #4701: try to improve H2 transaction commit performance

Is there anything more to work on in this task or do we just need to get it rebased for merge to trunk (or merge into... Greg Shah

09/07/2020

12:27 PM Runtime Infrastructure Feature #4026: ensure all objects transmitted over the DAP implement Externalizable

Fixed type parameters for Tree* classes
Committed to 3821c rev. 11501 and tree-derived widgets in @<customer_appli... Igor Skornyakov

09/04/2020

07:23 AM Runtime Infrastructure Feature #4026: ensure all objects transmitted over the DAP implement Externalizable

Fixed the @WidgetId@ instance (de)serialization when it is actually an instance of the @WidgetDownId@.
Committed t... Igor Skornyakov

09/03/2020

03:04 PM Base Language Feature #1970: improve ControlFlowOps method resolution by reflection

An addition note: a @RUN ... IN@ can target a remote procedure/port-handle - see this code in @ControlFlowOps.invokeI... Constantin Asofiei

01:52 PM Base Language Feature #1970: improve ControlFlowOps method resolution by reflection

Some issues I see:
# @RUN ON SERVER@ shouldn't be touched by this optimization - the resolution is done on the remot... Constantin Asofiei

12:12 PM Base Language Feature #1970: improve ControlFlowOps method resolution by reflection

Greg Shah wrote:
> By the way, it seems to me that in the case where the target name is unique across the project, t... Constantin Asofiei

12:04 PM Base Language Feature #1970: improve ControlFlowOps method resolution by reflection

By the way, it seems to me that in the case where the target name is unique across the project, that we could hard co... Greg Shah

12:02 PM Base Language Feature #1970: improve ControlFlowOps method resolution by reflection

> don't know why internalProcedure doesn't have the this reference and legacy name emitted as arguments (this would ... Greg Shah

09/02/2020

03:51 PM Base Language Feature #1970: improve ControlFlowOps method resolution by reflection

Greg Shah wrote:
> I suspect that we must be doing something expensive inside the @BlockManager.internalProcedure()@... Constantin Asofiei

03:13 PM Base Language Feature #1970: improve ControlFlowOps method resolution by reflection

I've been reviewing the CFS code and debugging through it with testcases to understand the implications of this idea.... Greg Shah

01:31 PM User Interface Bug #4842 (Closed): com-handle of CONTROL-FRAME validity

Greg Shah

11:33 AM User Interface Bug #4842: com-handle of CONTROL-FRAME validity

Code review 3821c revision 11487. The changes seem fine. Hynek Cihlar

10:09 AM Runtime Infrastructure Feature #4026: ensure all objects transmitted over the DAP implement Externalizable

Re-worked (de)serialization of all classes transmitted over DAP from @com.goldencode.p2j.ui package@ except @TreeCon... Igor Skornyakov

09/01/2020

11:43 AM User Interface Bug #4842: com-handle of CONTROL-FRAME validity

Vladimir Tsichevski wrote:
> Fixed in 3821c, rev. 11487.
The change seems OK.
Hynek: Please review. Greg Shah

08/31/2020

01:30 PM Conversion Tools Bug #4154: NPE in ENABLE ALL

Update: now (3821c rev. 11487) the stack trace looks a bit different:... Vladimir Tsichevski

12:22 PM Conversion Tools Bug #4867: Incremental conversion: change detection algorithm ignores .hints and .ext-hints files

Sorry, it was my fault this was in the wrong project. Greg Shah

12:19 PM Conversion Tools Bug #4867: Incremental conversion: change detection algorithm ignores .hints and .ext-hints files

The incremental compilation dependencies calculation procedure must detect changes in @.hints@ and @.ext-hints@ files. Vladimir Tsichevski

12:15 PM Conversion Tools Bug #4867 (Closed): Incremental conversion: change detection algorithm ignores .hints and .ext-hi...

Vladimir Tsichevski

09:33 AM User Interface Bug #4842 (Review): com-handle of CONTROL-FRAME validity

Fixed in 3821c, rev. 11487. Vladimir Tsichevski

09:14 AM User Interface Bug #4842 (WIP): com-handle of CONTROL-FRAME validity

Vladimir Tsichevski