FWD

04/03/2022

07:34 PM User Interface Support #6212: View frame display default value for fill-in for some data types

Yes, go ahead. Greg Shah

03:00 PM User Interface Support #6212: View frame display default value for fill-in for some data types

Hynek Cihlar wrote:
> Greg Shah wrote:
> > Hynek: Please review and merge to 3821c if it is OK.
>
> Marian, the ... Hynek Cihlar

11:34 AM Conversion Tools Feature #6203: create cvtpath and move conversion database into that directory

Greg Shah wrote:
> Code Review Task Branch 3821c Revision 13732
>
> Nice!
>
> 1. @Configuration.getConversionF... Constantin Asofiei

10:34 AM Conversion Tools Feature #6203: create cvtpath and move conversion database into that directory

Code Review Task Branch 3821c Revision 13732
Nice!
1. @Configuration.getConversionFolder()@ should have the @ex... Greg Shah

10:22 AM Conversion Tools Feature #6203: create cvtpath and move conversion database into that directory

Greg wrote:
> When do you think you can have this ready?
Constantin wrote (2 hours later):
> Added to 3821c/1373... Greg Shah

10:38 AM Conversion Tools Feature #6202: allow .df files to exist in a path that is not directly in data/

Please shift to use the @Configuration.getConversionFolder()@ instead of the @xmlFile@ approach. By default it shoul... Greg Shah

04/02/2022

02:31 PM User Interface Support #6212: View frame display default value for fill-in for some data types

Greg Shah wrote:
> > Normally this should not be called when data type or format is being set
>
> The @DISPLAY <e... Marian Edu

09:40 AM User Interface Support #6212: View frame display default value for fill-in for some data types

> Normally this should not be called when data type or format is being set
The @DISPLAY <expr> format "<fmt>" &#64... Greg Shah

08:35 AM User Interface Support #6212: View frame display default value for fill-in for some data types

Hynek Cihlar wrote:
> Marian, the change also affects other use cases than only @VIEW@ or visibility change. For exa... Marian Edu

12:29 PM Conversion Tools Feature #6203 (Review): create cvtpath and move conversion database into that directory

Added to 3821c/13732. Constantin Asofiei

09:57 AM Conversion Tools Feature #6203: create cvtpath and move conversion database into that directory

Constantin: When do you think you can have this ready? Greg Shah

09:57 AM Conversion Tools Feature #6202: allow .df files to exist in a path that is not directly in data/

> I have the changes ready to commit but
Are these changes to FWD or are they the project changes referenced in #... Greg Shah

09:33 PM Conversion Tools Feature #6202: allow .df files to exist in a path that is not directly in data/

I have the changes ready to commit but there are two issues.
* I only tested on PoC and hotel_gui projects. That is,... Ovidiu Maxiniuc

04/01/2022

02:07 PM Build and Source Control Bug #6208: cleanup build warnings

Greg Shah wrote:
> Hynek/Constantin: Please review the rest of the changes.
Beside missing history entries and TODO... Constantin Asofiei

12:08 PM User Interface Support #6212: View frame display default value for fill-in for some data types

Greg Shah wrote:
> Hynek: Please review and merge to 3821c if it is OK.
Marian, the change also affects other use... Hynek Cihlar

08:26 AM User Interface Support #6212: View frame display default value for fill-in for some data types

Hynek: Please review and merge to 3821c if it is OK. Greg Shah

06:41 AM User Interface Support #6212 (Review): View frame display default value for fill-in for some data types

Marian Edu

06:41 AM User Interface Support #6212 (WIP): View frame display default value for fill-in for some data types

Attached a quick patch to fix this and for whatever reason the screen width for datetime format only considered the d... Marian Edu

03/31/2022

07:38 PM Build and Source Control Bug #6208: cleanup build warnings

Greg Shah wrote:
> Ovidiu: Please review the persistence/database stats/database dump checker changes.
Partial re... Ovidiu Maxiniuc

12:42 PM Build and Source Control Bug #6208: cleanup build warnings

Sergey: Please review the admin client changes.
Ovidiu: Please review the persistence/database stats/database dump c... Greg Shah

12:25 PM Build and Source Control Bug #6208: cleanup build warnings

... Tomasz Domin

11:18 AM Build and Source Control Bug #6208: cleanup build warnings

... Tomasz Domin

07:19 AM Build and Source Control Bug #6208: cleanup build warnings

>>... Tomasz Domin

12:46 PM Runtime Infrastructure Bug #6227: AcmeClient - unsupported Challenge Type

Current AcmeClient implementation is using TlsSni01Challenge, which is unsupported since 2019.
It must to be migrate... Tomasz Domin

12:45 PM Runtime Infrastructure Bug #6227 (New): AcmeClient - unsupported Challenge Type

Tomasz Domin

10:18 AM Runtime Infrastructure Feature #5896: enhance legacy REST support to provide better pure Java development

> Also, what wiki should I use for the documentation?
See [[p2j:Java REST Services]] Greg Shah

03/30/2022

04:06 PM Runtime Infrastructure Feature #5896: enhance legacy REST support to provide better pure Java development

Constantin Asofiei wrote:
> Ovidiu: please take a look at @p2j.persist.Record@ and @p2j.rest.serializers.RecordSeria... Ovidiu Maxiniuc

03/29/2022

03:34 PM Conversion Tools Feature #1757: update ANTLR to latest version

ANTLR v3 is dead at this point and was replaced by ANTLR v4. Whether it makes sense or not to move to ANTLR v4 is no... Greg Shah

01:52 PM Runtime Infrastructure Feature #5896: enhance legacy REST support to provide better pure Java development

Greg, the support for the REST services implemented directly in Java is in 3821c/13714.
Please review. Also, what... Constantin Asofiei

11:55 AM Build and Source Control Bug #6208: cleanup build warnings

Greg Shah wrote:
> > Replaced with IOUtils.toInputStream(data,Charset.defaultCharset()), note that serialization of ... Ovidiu Maxiniuc

08:16 AM Build and Source Control Bug #6208: cleanup build warnings

> Remote GuiWebSocket.getTextWidth is deprecated for single text sample
I think we can just remove the deprecated ... Greg Shah

07:58 AM Build and Source Control Bug #6208: cleanup build warnings

> According to related TODO I presume this method's logic needs to be moved to separate class,
>> ... Greg Shah

05:39 AM Build and Source Control Bug #6208: cleanup build warnings

... Tomasz Domin

03:50 AM Build and Source Control Bug #6208: cleanup build warnings

... Tomasz Domin

10:02 AM Conversion Tools Feature #6202: allow .df files to exist in a path that is not directly in data/

I would be fine with those updates to that POC project. Roger Borrello

09:49 AM Conversion Tools Feature #6202: allow .df files to exist in a path that is not directly in data/

Greg,
I worked with latest POC (#6088, which Roger is maintaining) when adding these changes. I have chosen it bec... Ovidiu Maxiniuc

07:09 AM Conversion Tools Feature #6202: allow .df files to exist in a path that is not directly in data/

Overall, I'm good with the approach. When #6203 (@cvtpath@) is available, you should remove @xmlFile@ and use @cvtpa... Greg Shah

03/28/2022

03:36 PM Build and Source Control Bug #6208: cleanup build warnings

... Tomasz Domin

02:18 PM Build and Source Control Bug #6208: cleanup build warnings

... Tomasz Domin

09:12 AM Build and Source Control Bug #6208 (WIP): cleanup build warnings

Tomasz Domin

08:48 AM User Interface Support #6212: View frame display default value for fill-in for some data types

When calling @view@ on a frame, or change it's @visibility@ in FWD some of the fill-ins in the frame shows a default ... Marian Edu

08:45 AM User Interface Support #6212 (Closed): View frame display default value for fill-in for some data types

Marian Edu

08:36 AM User Interface Bug #6211: Display changes z-order

When a @display@ statement is used with a widgets list the FWD implementation changes the widgets z-order in frame by... Marian Edu

08:23 AM User Interface Bug #6211 (New): Display changes z-order

Marian Edu

06:53 AM Database Bug #3896: improve performance of the _lock metadata implementation

Sorry, forgot to add new classes to the .diff file. Igor Skornyakov

06:02 AM Database Bug #3896: improve performance of the _lock metadata implementation

Finished.
Please review.
Thank you. Igor Skornyakov

03/27/2022

03:21 PM Database Bug #3896: improve performance of the _lock metadata implementation

Added JMX instrumentation and cleanup logic to @LockTableUpdater@.
However, I have a strange problem with finding pe... Igor Skornyakov

03/26/2022

11:16 PM Conversion Tools Feature #6202 (WIP): allow .df files to exist in a path that is not directly in data/

As noted above I added a @dataFolder@ attribute in @namespace@. This specifies the location of @.d@ data files. Toget... Ovidiu Maxiniuc

03/25/2022

02:20 PM Build and Source Control Bug #6208: cleanup build warnings

Ovidiu Maxiniuc wrote:
> * The first half a dozen warnings are generated by @DatabaseStatistics@. It is "dangling"... Eric Faulhaber

01:36 PM Build and Source Control Bug #6208: cleanup build warnings

Some notes on warning related to persistence:
* The first half a dozen warnings are generated by @DatabaseStatistics... Ovidiu Maxiniuc

09:25 AM Build and Source Control Bug #6208: cleanup build warnings

On my system, @./gradlew core@ results in the following:... Greg Shah

09:12 AM Build and Source Control Bug #6208 (Closed): cleanup build warnings

Greg Shah

01:14 PM Conversion Tools Feature #6202: allow .df files to exist in a path that is not directly in data/

Greg Shah wrote:
> > I am now trying to fix the data_analyzer (optionally invoked using f2+m1+cb conversion profile)... Eric Faulhaber

06:00 AM Conversion Tools Feature #6202: allow .df files to exist in a path that is not directly in data/

> I am now trying to fix the data_analyzer (optionally invoked using f2+m1+cb conversion profile).
I think we have... Greg Shah

08:57 PM Conversion Tools Feature #6202: allow .df files to exist in a path that is not directly in data/

In #4105 I added flexibility for loading the @.df@ file from a configured place, but there were some issues with the ... Ovidiu Maxiniuc

01:13 PM Base Language Bug #5294 (Closed): parsing problems for assign-style statements with a OO chained lvalue

Code Review Task Branch 3821c Revision 13690
No objections. Greg Shah

12:51 PM Base Language Bug #5294 (Review): parsing problems for assign-style statements with a OO chained lvalue

Constantin Asofiei

12:51 PM Base Language Bug #5294 (WIP): parsing problems for assign-style statements with a OO chained lvalue

Thanks, the patch is in 3821c/13690.
Constantin Asofiei

12:36 PM Base Language Bug #5294: parsing problems for assign-style statements with a OO chained lvalue

There is no way to comment out the rule definition itself. You can use @/* */@ or @//@ comments inside a rule to rem... Greg Shah

10:47 AM Base Language Bug #5294: parsing problems for assign-style statements with a OO chained lvalue

Greg, how do I comment the rule in antlr? I can't neither with @/**/@ or with @//@.
These rules need to be commen... Constantin Asofiei

07:34 AM Database Bug #3896: improve performance of the _lock metadata implementation

Please note that the @_Lock@ VST cleanup in a separate thread should be a rare event. It will happen only if the lock... Igor Skornyakov

07:11 AM Database Bug #3896: improve performance of the _lock metadata implementation

Greg Shah wrote:
> I prefer to avoid executors or Java thread pools. It adds hidden logic to manage threads which m... Igor Skornyakov

06:49 AM Database Bug #3896: improve performance of the _lock metadata implementation

> I'm planning to use a @SingleThreadExecutor@ shared by all instances of the @LockTableUpdater@ for the background @... Greg Shah

05:07 AM Database Bug #3896: improve performance of the _lock metadata implementation

After fixing an obvious mistake with adding @final@ to the @Empty@ class declaration the smoke test of the large cust... Igor Skornyakov

06:27 AM Database Feature #6187: eliminate explicit buffer usage in can-find

In my opinion, the converted code will read better with @canFind(...)@ than @new FindQuery(...).hasAny()@. Greg Shah

06:23 AM Database Feature #6187: eliminate explicit buffer usage in can-find

We really should just implement a set of static @canFind()@ methods which have the @<dmo>.Buf.class@ as a parameter a... Greg Shah

04:30 AM Database Feature #6187: eliminate explicit buffer usage in can-find

This is still an issue. It can be see with this simple test:... Constantin Asofiei

03/24/2022

03:22 PM Database Bug #3896: improve performance of the _lock metadata implementation

@LockTableUpdater@ is re-worked in the same way as @UserTableStatUpdater@ was re-worked some time ago. No separated t... Igor Skornyakov

02:01 PM Conversion Tools Feature #6202: allow .df files to exist in a path that is not directly in data/

We aren't moving to a database in this task. Even in #5586, the database is only likely to hold non-artifacts. Some... Greg Shah

01:52 PM Conversion Tools Feature #6202: allow .df files to exist in a path that is not directly in data/

Greg Shah wrote:
> Eric: Do you have any comments or concerns?
We have to consider runtime use of these resourc... Eric Faulhaber

03/23/2022

09:09 AM Conversion Tools Feature #6203: create cvtpath and move conversion database into that directory

As noted in #6202 and #5586, we are going to be moving all intermediate conversion artifacts into a configurable dire... Greg Shah

09:05 AM Conversion Tools Feature #6203 (Closed): create cvtpath and move conversion database into that directory

Greg Shah

09:03 AM Conversion Tools Feature #6202: allow .df files to exist in a path that is not directly in data/

In #4105-52, Roger attempted to organize @.df@ files in subdirectories of @data/@. This worked for the front end sta... Greg Shah

08:38 AM Conversion Tools Feature #6202 (Closed): allow .df files to exist in a path that is not directly in data/

Greg Shah

03/22/2022

02:58 PM Base Language Bug #5288: Some date field character comparisons have runtime incompatibilities during runtime

The attached patch is a partial fix, which hasn't been checked in. I wanted to make sure it is kept with this task. Roger Borrello

03/21/2022

08:16 AM User Interface Bug #4993 (Closed): Overlay prevents input when modal dialog open in embedded mode in Chrome

Confirmed, this is fixed. Greg Shah

03/18/2022

01:47 PM Runtime Infrastructure Feature #5896: enhance legacy REST support to provide better pure Java development

Greg Shah wrote:
> Is it a good idea to have the client code calculate the PK? We have very specific requirements f... Ovidiu Maxiniuc

08:41 AM Runtime Infrastructure Feature #5896: enhance legacy REST support to provide better pure Java development

Is it a good idea to have the client code calculate the PK? We have very specific requirements for that value, norma... Greg Shah

01:27 AM Runtime Infrastructure Feature #5896: enhance legacy REST support to provide better pure Java development

Eric Faulhaber wrote:
> If we have a factory that can create concrete instances of @Book@, will that meet the need? ... Constantin Asofiei

08:38 PM Runtime Infrastructure Feature #5896: enhance legacy REST support to provide better pure Java development

If you have the DMO interface available @Class<T> clazz@, then all you need to do is:... Ovidiu Maxiniuc

08:26 AM Database Feature #6187: eliminate explicit buffer usage in can-find

It seems in 2015, this may already have been resolved (from @record_scoping_prep.rules@):... Greg Shah

03/17/2022

06:58 PM Runtime Infrastructure Feature #5896: enhance legacy REST support to provide better pure Java development

If we have a factory that can create concrete instances of @Book@, will that meet the need? The objects it creates wo... Eric Faulhaber

03:03 PM Runtime Infrastructure Feature #5896: enhance legacy REST support to provide better pure Java development

Eric, I have some issues with automatically serializing the DMOs. For OUTPUT, it is easy, just create the JSON.
B... Constantin Asofiei

12:38 PM Database Bug #3896: improve performance of the _lock metadata implementation

Does it make sense to move @LockTableUpdater.UpdateWorker.fileNums@ map to the @MetadataManager@ (as a value of the m... Igor Skornyakov

07:24 AM Database Feature #6187: eliminate explicit buffer usage in can-find

I don't recall why we require this extra buffer that is not actually a buffer in the 4GL. I do recall how painful th... Greg Shah

07:23 AM Database Feature #6187 (New): eliminate explicit buffer usage in can-find

Greg Shah

03/16/2022

11:53 AM Testing Feature #6183 (WIP): design and implement (as needed) the approach for writing automated 4GL comp...

Greg Shah

03/14/2022

01:39 PM User Interface Bug #6167: Mouse event processing refactoring/improvement

h4. The patch description
h5. Main ideas
# The mouse released event must be dispatched to the widget which is... Vladimir Tsichevski

01:35 PM User Interface Bug #6167: Mouse event processing refactoring/improvement

Another issue: in WEB, while no mouse buttons is pressed, all mouse events generated have @button=1@ instead of expec... Vladimir Tsichevski

01:33 PM User Interface Bug #6167: Mouse event processing refactoring/improvement

Another problem: in WEB, when the mouse enters a window area, the @MOUSE_ENTER@ event for the window is sent twice fr... Vladimir Tsichevski

01:28 PM User Interface Bug #6167: Mouse event processing refactoring/improvement

h4. WEB event slippage problem
I noticed the following problem with WEB mouse events synchronization:
h5. Situa... Vladimir Tsichevski

01:24 PM User Interface Bug #6167: Mouse event processing refactoring/improvement

This issue is created after #6013, all customer-specific material removed.
h4. The main issue.
In 4gl, the @MO... Vladimir Tsichevski

10:57 AM User Interface Bug #6167 (New): Mouse event processing refactoring/improvement

Vladimir Tsichevski

03/13/2022

04:47 AM Database Bug #3896 (WIP): improve performance of the _lock metadata implementation

Igor Skornyakov

03/11/2022

12:50 PM Base Language Feature #6161 (Closed): add support for DYNAMIC-PROPERTY() built-in function and DYNAMIC-PROPERTY...

Greg Shah

03/10/2022

01:51 PM User Interface Bug #6042 (Closed): Nested frame must not be made visible when empty and DISPLAY/ENABLE executed ...

Greg Shah

01:35 PM User Interface Bug #6042: Nested frame must not be made visible when empty and DISPLAY/ENABLE executed on the pa...

I can't replicate this either. Let's close it then. Hynek Cihlar

03/09/2022

06:57 AM User Interface Feature #6157: Missing widget properties

While writing testcases for widget realisation we've found a number of properties aren't supported in FWD (our curren... Marian Edu

06:55 AM User Interface Feature #6157 (New): Missing widget properties

Marian Edu

05:11 AM User Interface Bug #6042 (Feedback): Nested frame must not be made visible when empty and DISPLAY/ENABLE execute...

Hynek, are you sure about this? Running the test on my OE install does make the nested frame visible even if there ar... Marian Edu

04:20 AM Base Language Feature #4384: Builtin OO Implementation

Constantin Asofiei wrote:
> Marian, the root cause is that there is a @catch (Exception)@ in some p2j.oo code. This... Marian Edu

03/08/2022

11:48 AM User Interface Bug #6155: Possibly incorrect widget Z-order

In the following example two frames and one button are created. All three are overlapped.... Vladimir Tsichevski

11:43 AM User Interface Bug #6155 (New): Possibly incorrect widget Z-order

Vladimir Tsichevski

09:07 AM User Interface Feature #4837: Add javascript keyboard test application for the virtual desktop

Yes, it should not be part of the running web client, it just must be launched from the web client. Greg Shah

08:57 AM User Interface Feature #4837 (WIP): Add javascript keyboard test application for the virtual desktop

Adding new test keys application dialog proved that the web application listeners continue to send events to the web ... Sergey Ivanovskiy

08:30 AM Base Language Feature #4384: Builtin OO Implementation

Marian, the root cause is that there is a @catch (Exception)@ in some p2j.oo code. This will catch a ConditionExcept... Constantin Asofiei

06:33 AM Base Language Feature #4384: Builtin OO Implementation

Constantin Asofiei wrote:
> Please point me to a test which shows this.
oo/json/array/get_date.p
making @Leg... Marian Edu

06:23 AM Base Language Feature #4384: Builtin OO Implementation

Marian Edu wrote:
> Greg Shah wrote:
> > Marian: Please document the final status of this task in the format of #43... Constantin Asofiei

06:22 AM Base Language Feature #4384: Builtin OO Implementation

Greg Shah wrote:
> Marian: Please document the final status of this task in the format of #4384-462.
I'm having i... Marian Edu

03/07/2022

02:28 PM Base Language Feature #4384 (Closed): Builtin OO Implementation

Marian: Please document the final status of this task in the format of #4384-462. Greg Shah

12:08 PM Base Language Feature #4384: Builtin OO Implementation

The final changes for 4384m are in 3821c/13617 and the skeleton patch is in rev 103
All projects must be reconvert... Constantin Asofiei

03:07 AM Base Language Feature #4384: Builtin OO Implementation

I've committed the patch with the changes in #4384-598 to 3821c/13613.
Next I'll test the skeleton patch without t... Constantin Asofiei

02:26 AM Base Language Feature #4384: Builtin OO Implementation

Constantin Asofiei wrote:
> Some changes in ExpressionConversionWorker and ClassDefinition, which were explicitly ma... Marian Edu

07:55 PM User Interface Bug #6146: Browse abends if non-compatible query is assigned

Testcase attached. FWD abends, in 4GL all columns are deleted from the browse.... Stanislav Lomany

07:51 PM User Interface Bug #6146 (New): Browse abends if non-compatible query is assigned

Stanislav Lomany

03/06/2022

08:08 AM Base Language Feature #4384: Builtin OO Implementation

Some changes in ExpressionConversionWorker and ClassDefinition, which were explicitly marking 'invoke' methods as POL... Constantin Asofiei

03:47 AM Base Language Feature #4384: Builtin OO Implementation

There are some regressions in the patch:
* @invoke@ is emitted instead of @invokeStandalone@ - this is required as O... Constantin Asofiei