FWD

07/16/2022

05:49 PM Database Feature #6348 (WIP): implement support for MariaDB

Started adding support for the new database by implementation of the @MariaDbDialect.java@. On Monday I will continue... Ovidiu Maxiniuc

07/15/2022

03:35 PM Database Feature #6584: implement schema hint which generates a POJO in addition to a DMO interface

Constantin,
I know you worked with JSON probably more than any of us. Do you have an API which serialize a POJOs an... Ovidiu Maxiniuc

01:38 PM Database Feature #6584: implement schema hint which generates a POJO in addition to a DMO interface

I committed the (final ?) version of the POJO/DMO marshalling solution. Revision is 14075.
To summarize:
* the PO... Ovidiu Maxiniuc

09:13 AM Database Feature #6584: implement schema hint which generates a POJO in addition to a DMO interface

Constantin Asofiei wrote:
> I don't think is OK to be using the SQL types:
> * date/datetime/datetime-tz should all... Ovidiu Maxiniuc

01:50 PM User Interface Feature #6604: Complete support for list-items/list-item-pairs for combo-box as part of the brows...

Regarding implementation, read #6598-25. Stanislav Lomany

10:22 PM User Interface Feature #6604: Complete support for list-items/list-item-pairs for combo-box as part of the brows...

The attached testcase should be properly handled on conversion/runtime.
Note the difference between regular combo-... Eugenie Lyzenko

10:18 PM User Interface Feature #6604 (New): Complete support for list-items/list-item-pairs for combo-box as part of the...

Eugenie Lyzenko

08:40 AM User Interface Bug #6605: OCX property assignment conversion error

The following line assigns the @Selected@ property of an OCX object @node@:... Vladimir Tsichevski

08:32 AM User Interface Bug #6605 (New): OCX property assignment conversion error

Vladimir Tsichevski

12:14 AM Database Feature #6574 (Closed): auto-detect native UDFs at server startup and install them if missing

The changes in 3821c/14066 look good.
Note: to ensure missing native UDFs are installed, entries for @admin_userna... Eric Faulhaber

07/14/2022

07:23 PM Database Feature #6371: implement SAVE CACHE statement

Code review @6371.diff@:
The changes seem fine; looks like general code cleanup. Assuming they compile (I didn't a... Eric Faulhaber

03:59 PM Database Feature #6584: implement schema hint which generates a POJO in addition to a DMO interface

I already committed the same fix (r14069).
Notice that, for the moment, the POJOs are not supported for temp datab... Ovidiu Maxiniuc

03:55 PM Database Feature #6584: implement schema hint which generates a POJO in addition to a DMO interface

Eric Faulhaber wrote:
> Ovidiu, I'm running a customer application (unrelated to this task). I launched a program wh... Eric Faulhaber

03:09 PM Database Feature #6584: implement schema hint which generates a POJO in addition to a DMO interface

Eric Faulhaber wrote:
> Ovidiu Maxiniuc wrote:
>
> > Are there other concerns about the types or generally about ... Eric Faulhaber

03:06 PM Database Feature #6584: implement schema hint which generates a POJO in addition to a DMO interface

Ovidiu, I'm running a customer application (unrelated to this task). I launched a program which tries to register a t... Eric Faulhaber

02:05 PM Database Feature #6584: implement schema hint which generates a POJO in addition to a DMO interface

Ovidiu Maxiniuc wrote:
> Are there other concerns about the types or generally about the implementation itself?
... Eric Faulhaber

01:46 PM Database Feature #6584: implement schema hint which generates a POJO in addition to a DMO interface

This was my initial solution, where I tried to keep the same data types from FWD @Record@ (see #6584-15).
I will add... Ovidiu Maxiniuc

01:35 PM Database Feature #6584: implement schema hint which generates a POJO in addition to a DMO interface

I don't think is OK to be using the SQL types:
* date/datetime/datetime-tz should all map to @java.util.GregorianCal... Constantin Asofiei

01:23 PM Database Feature #6584: implement schema hint which generates a POJO in addition to a DMO interface

Constantin, here it is. First the @.df@ content: {{collapse("tm-all" table)... Ovidiu Maxiniuc

01:59 AM Database Feature #6584: implement schema hint which generates a POJO in addition to a DMO interface

Ovidiu, please post the POJO for a table which has extent fields, blob, clob, etc (all data types). Constantin Asofiei

09:46 PM Database Feature #6584: implement schema hint which generates a POJO in addition to a DMO interface

Support for converting to/from POJOs was committed as r14064.
There are no hints (for the moment). The only way to... Ovidiu Maxiniuc

11:53 AM Database Feature #6574: auto-detect native UDFs at server startup and install them if missing

BTW: I think that right way to re-work @ScriptRunner@ for more dialects is to create its dialect-specific versions in... Igor Skornyakov

11:39 AM Database Feature #6574: auto-detect native UDFs at server startup and install them if missing

Eric Faulhaber wrote:
> Right, so let's just go with the additional comments for now, to make that refactoring easie... Igor Skornyakov

11:05 AM Database Feature #6574 (Review): auto-detect native UDFs at server startup and install them if missing

Right, so let's just go with the additional comments for now, to make that refactoring easier as we add UDF support i... Eric Faulhaber

11:01 AM Database Feature #6574: auto-detect native UDFs at server startup and install them if missing

Eric Faulhaber wrote:
> Code review @missing-udf.diff@:
>
> It seems this should work.
>
> Please note we will... Igor Skornyakov

10:43 AM Database Feature #6574: auto-detect native UDFs at server startup and install them if missing

Code review @missing-udf.diff@:
It seems this should work.
Please note we will have to support this feature for... Eric Faulhaber

11:44 AM Runtime Infrastructure Bug #6084: NIO SSL performance is slower than standard Java SSL

Added total time in ns to the @NanoCounter.toStrng@.
Committed to 3821c/ 14067. Igor Skornyakov

07:10 AM Base Language Bug #6555 (Review): SECURITY-POLICY:SET-CLIENT fails with an imported CLIENT-PRINCIPAL

Fixed in 3821c/14065. Igor Skornyakov

07:02 AM Base Language Bug #6555 (WIP): SECURITY-POLICY:SET-CLIENT fails with an imported CLIENT-PRINCIPAL

Igor Skornyakov

06:16 AM Database Bug #6599: minimal mode conversion problem with DMO name collision

After the 6129a rebase, a table named "property" no longer converts as @property@ when @conversion="minimal"@ is set ... Constantin Asofiei

06:10 AM Database Bug #6599 (New): minimal mode conversion problem with DMO name collision

Constantin Asofiei

07/13/2022

03:44 PM Base Language Bug #6555: SECURITY-POLICY:SET-CLIENT fails with an imported CLIENT-PRINCIPAL

Fixed revealed incompatibility - the database should not be locked on @SET-CLIENT@.
Committed to 3821c/ 14060. Igor Skornyakov

03:14 PM Database Feature #6371 (WIP): implement SAVE CACHE statement

Boris Schegolev wrote (in email):
> My only question at the moment is how to simulate the desired state. I guess I... Eric Faulhaber

09:30 AM User Interface Feature #6594: TabSet Deviations

There are some deviations or missing features in the TabSet OCX replacement in FWD, we can use this task to track the... Marian Edu

09:24 AM User Interface Feature #6594 (New): TabSet Deviations

Marian Edu

08:53 AM User Interface Bug #6513 (Closed): Invalid key sequence response in FILL-IN widget inside Web client

Greg Shah

08:37 AM User Interface Bug #6513: Invalid key sequence response in FILL-IN widget inside Web client

Yes. Sergey Ivanovskiy

06:49 AM User Interface Bug #6513: Invalid key sequence response in FILL-IN widget inside Web client

Can we close it? Greg Shah

06:36 AM User Interface Bug #6513: Invalid key sequence response in FILL-IN widget inside Web client

Should we change the status of this task? Sergey Ivanovskiy

07/12/2022

04:47 PM User Interface Bug #6513: Invalid key sequence response in FILL-IN widget inside Web client

Sergey Ivanovskiy wrote:
> I cannot reproduce this issue with the current version rev. 14057 (3821c). Eugenie, could... Eugenie Lyzenko

02:24 PM User Interface Bug #6513: Invalid key sequence response in FILL-IN widget inside Web client

I cannot reproduce this issue with the current version rev. 14057 (3821c). Eugenie, could approve/validate that this ... Sergey Ivanovskiy

02:38 PM Database Bug #6591: DMO collisions with converted program/legacy class name or FWD classes

If not too late, I think we can slightly adjust the DMO name using hints. Ovidiu Maxiniuc

07:14 AM Database Bug #6591 (WIP): DMO collisions with converted program/legacy class name or FWD classes

The the DMO collisions with converted Java class name is already solved by appending the @Program@ suffix (although t... Constantin Asofiei

06:40 AM Database Bug #6591: DMO collisions with converted program/legacy class name or FWD classes

In 3821c, there was a change which solved a camel-case issue - legacy tables names like @SomeTableName@ were converte... Constantin Asofiei

06:29 AM Database Bug #6591 (WIP): DMO collisions with converted program/legacy class name or FWD classes

Constantin Asofiei

12:00 PM Database Feature #6574: auto-detect native UDFs at server startup and install them if missing

Done. Please review.
Thank you. Igor Skornyakov

09:54 AM Database Feature #6574: auto-detect native UDFs at server startup and install them if missing

> This makes sense. We could add an @admin_username@ and @admin_password@ in the @.../database/<database_name>/orm/co... Igor Skornyakov

09:53 AM Database Feature #6574: auto-detect native UDFs at server startup and install them if missing

Igor Skornyakov wrote:
> Another problem is with creation of the @udf@ schema. The @create schema if not exists udf@... Eric Faulhaber

09:49 AM Database Feature #6574: auto-detect native UDFs at server startup and install them if missing

Igor Skornyakov wrote:
> There is a problem with "on the fly" creation of native UDFs.
> Many of them a declared as... Eric Faulhaber

08:14 AM Database Feature #6574: auto-detect native UDFs at server startup and install them if missing

Another problem is with creation of the @udf@ schema. The @create schema if not exists udf@ statament also can be exe... Igor Skornyakov

07:48 AM Database Feature #6574: auto-detect native UDFs at server startup and install them if missing

There is a problem with "on the fly" creation of native UDFs.
Many of them a declared as "leakproof" but such UDFs c... Igor Skornyakov

11:05 AM Database Feature #6348: implement support for MariaDB

Ovidiu Maxiniuc wrote:
> It has a PL language somewhat similar to PSQL.
I followed the CREATE FUNCTION doc link y... Eric Faulhaber

10:51 AM Build and Source Control Feature #4645: Migrate Ant build logic into Gradle and use the standard Java plugin

Our unit tests are limited. We intend to add more, but the [[p2j:Testing Process]] for 4GL support is really more im... Greg Shah

09:58 AM Build and Source Control Feature #4645: Migrate Ant build logic into Gradle and use the standard Java plugin

OK, I see. What about the unit tests ? Shouldn't we integrate them into the build ? Marcin Jaskolski

09:12 AM Build and Source Control Feature #4645: Migrate Ant build logic into Gradle and use the standard Java plugin

Thanks for the thoughts, Guys. I agree that the project has a ways to go to integrate nicely into an IDE environment... Greg Shah

08:58 AM Build and Source Control Feature #4645: Migrate Ant build logic into Gradle and use the standard Java plugin

Marcin Jaskolski wrote:
> Tooling is familiar with standard structure.
>
> Take automated tests - the standard Ma... Hynek Cihlar

08:37 AM Build and Source Control Feature #4645: Migrate Ant build logic into Gradle and use the standard Java plugin

Hynek Cihlar wrote:
> I agree with Greg that if you don't work in an IDE, having the standard, more complex and deep... Marcin Jaskolski

07:49 AM Build and Source Control Feature #4645: Migrate Ant build logic into Gradle and use the standard Java plugin

Tooling is familiar with standard structure.
Take automated tests - the standard Maven way really boils down to "a... Marcin Jaskolski

07:41 AM Build and Source Control Feature #4645: Migrate Ant build logic into Gradle and use the standard Java plugin

I agree with Greg that if you don't work in an IDE, having the standard, more complex and deeper (Maven, Gradle, etc.... Hynek Cihlar

07:10 AM Build and Source Control Feature #4645: Migrate Ant build logic into Gradle and use the standard Java plugin

> The questions of build scripts and sources layout are rather philosophical, not sure if you are interested in discu... Greg Shah

06:39 AM Build and Source Control Feature #4645: Migrate Ant build logic into Gradle and use the standard Java plugin

If you do not plan any work on this task now, I do not have anything safe to deploy. It was exploratory.
The quest... Marcin Jaskolski

06:17 AM Build and Source Control Feature #4645: Migrate Ant build logic into Gradle and use the standard Java plugin

In regard to project import for an IDE, we have had good results in Eclipse by importing from the ant @build.xml@. I... Greg Shah

06:02 AM Build and Source Control Feature #4645: Migrate Ant build logic into Gradle and use the standard Java plugin

At this point I was attempting to move Ant tasks into Gradle to learn the build process, get familiar with code, this... Marcin Jaskolski

09:26 AM Database Feature #6582 (WIP): implement multi-table AdaptiveQuery

Eric Faulhaber wrote:
> Alexandru, please review the existing @AdaptiveQuery@ implementation and consider how we mig... Alexandru Lungu

09:24 AM Database Feature #6582: implement multi-table AdaptiveQuery

Alexandru, please review the existing @AdaptiveQuery@ implementation and consider how we might go about extending/rew... Eric Faulhaber

07:30 AM Base Language Feature #4350: method overload when they differ by a temp-table, dataset, buffer or object or ext...

Greg Shah wrote:
> Can we use @EnumSet@ to handle this requirement? I'm hoping the result will be cleaner than spli... Constantin Asofiei

07:28 AM Base Language Feature #4350: method overload when they differ by a temp-table, dataset, buffer or object or ext...

Can we use @EnumSet@ to handle this requirement? I'm hoping the result will be cleaner than splitting out the flag a... Greg Shah

07:16 AM Base Language Feature #4350: method overload when they differ by a temp-table, dataset, buffer or object or ext...

@DataSetParameter@ and @TableParameter@ now assume that only one option can be set at the parameter - this is incorre... Constantin Asofiei

07:16 AM Database Feature #6584: implement schema hint which generates a POJO in addition to a DMO interface

Even if we want to allow for only a subset of the DMOs to get POJOs, we should make it easy to generate POJOs for all... Greg Shah

11:28 PM Database Feature #6584: implement schema hint which generates a POJO in addition to a DMO interface

Eric Faulhaber wrote:
> I thought we had discussed not using reflection and instead having default implementations... Eric Faulhaber

11:24 PM Database Feature #6584: implement schema hint which generates a POJO in addition to a DMO interface

Ovidiu Maxiniuc wrote:
> I have implemented the marshalling methods between POJO and DMO. Here are the important hig... Eric Faulhaber

11:08 PM Database Feature #6584: implement schema hint which generates a POJO in addition to a DMO interface

Ovidiu Maxiniuc wrote:
> I added the setters and performed more class polishing, like the initialization of extent f... Eric Faulhaber

09:14 PM Database Feature #6584: implement schema hint which generates a POJO in addition to a DMO interface

I have implemented the marshalling methods between POJO and DMO. Here are the important highlights:
* the @Record@ h... Ovidiu Maxiniuc

06:42 AM Runtime Infrastructure Support #5221 (Closed): Initialization failure during server runtime

As far as I know, this is complete. We can reopen it if needed in the future. Greg Shah

06:41 AM Base Language Support #5120 (Closed): Date/Datetime - from iso

I think this is complete and the remaining work is deferred to #5201. Greg Shah

07/11/2022

12:54 PM Database Feature #6371: implement SAVE CACHE statement

Boris Schegolev wrote:
> As I was writing, Eric added the above specs, answering most of my questions :)
>
> A fe... Eric Faulhaber

12:06 PM Database Feature #6371: implement SAVE CACHE statement

As I was writing, Eric added the above specs, answering most of my questions :)
A few points from my side:
# Th... Boris Schegolev

11:50 AM Database Feature #6371: implement SAVE CACHE statement

This feature is only for use with specially designated databases, whose schemas are mutable. These are special purpos... Eric Faulhaber

12:02 PM Runtime Infrastructure Support #5567: move FWD to Java 11

A customer did some testing on Java 11. They ran branch 6129a which is a modified version of an older 3821c. This 6... Greg Shah

11:50 AM Runtime Infrastructure Support #5567: move FWD to Java 11

Tomasz Domin wrote:
> There is issue in @sheet:war@ target with @keikai@ jars and latest JDK 11 - latest @javac@ due... Hynek Cihlar

11:46 AM Runtime Infrastructure Support #5567: move FWD to Java 11

There is issue in @sheet:war@ target with @keikai@ jars and latest JDK 11 - latest @javac@ due to changes in jar/zip ... Tomasz Domin

06:24 AM Runtime Infrastructure Support #5567: move FWD to Java 11

Rebased to 3821c/14055, patched local version with fixes to #5739, #5737, #6523 and restarted ctrl-c tests with Java ... Tomasz Domin

11:42 AM Build and Source Control Feature #4645: Migrate Ant build logic into Gradle and use the standard Java plugin

Marcin has done some exploration on how to accomplish this migration.
Marcin: Please post a diff with any useful r... Greg Shah

08:33 AM Database Feature #6584: implement schema hint which generates a POJO in addition to a DMO interface

> I was thinking of a switch in p2j.cfg.xml for turning their generation on or off (as opposed to individual hints)
... Greg Shah

07/09/2022

08:01 PM Database Feature #6584: implement schema hint which generates a POJO in addition to a DMO interface

Added the change-set. Ovidiu Maxiniuc

07/08/2022

07:47 PM Database Feature #6584: implement schema hint which generates a POJO in addition to a DMO interface

I added the setters and performed more class polishing, like the initialization of extent fields as Java arrays of th... Ovidiu Maxiniuc

07:20 AM Database Feature #6584: implement schema hint which generates a POJO in addition to a DMO interface

That looks really good!
Perhaps we should consider generating these for every DMO. Is there a reason to limit it ... Greg Shah

08:41 PM Database Feature #6584 (WIP): implement schema hint which generates a POJO in addition to a DMO interface

I started the implementation using the bean approach. For the moment, the POJOs are always created - I will add the c... Ovidiu Maxiniuc

02:41 PM User Interface Feature #4837: Add javascript keyboard test application for the virtual desktop

It is a good idea. Greg Shah

02:23 PM User Interface Feature #4837: Add javascript keyboard test application for the virtual desktop

It seems that it makes sense
# to add new functionality to record keystrokes and to load recorded key events for re... Sergey Ivanovskiy

07/07/2022

02:49 PM Database Feature #6584: implement schema hint which generates a POJO in addition to a DMO interface

OK, let's go with the bean approach for the POJOs. They will just work with Jackson and they will not confuse develop... Eric Faulhaber

09:00 AM Database Feature #6584: implement schema hint which generates a POJO in addition to a DMO interface

Eric Faulhaber wrote:
> I do expect that Jackson will be a pretty common library for this kind of work. Constantin, ... Constantin Asofiei

02:29 PM Database Feature #6348: implement support for MariaDB

See [[p2j:Adding_Support_For_a_New_Database|Adding Support For a New Database]], but note it is unfinished at the tim... Eric Faulhaber

11:32 AM Database Feature #6348: implement support for MariaDB

The initial target character set / collation is UTF8MB4. We won't worry about getting an exact, backward compatible c... Eric Faulhaber

11:24 AM Database Feature #6348: implement support for MariaDB

Proposed data type mappings:
|_. 4GL |_. MariaDB |_. FWD |
| blob | blob | blob ... Eric Faulhaber

12:45 PM Database Bug #6502: DATASET:CREATE-LIKE copies temp-table options (like XML-NODE-NAME), while TEMP-TABLE:C...

@#6502+#6450_2.patch.zip@ was committed in revision 6129a/13955. Ovidiu Maxiniuc

11:23 AM Database Bug #6502: DATASET:CREATE-LIKE copies temp-table options (like XML-NODE-NAME), while TEMP-TABLE:C...

Ovidiu, good catch with @COMPILER:ERROR@, please commit the patch to 6129a. Constantin Asofiei

12:23 PM Database Bug #6586: parser/conversion bug when a database alias is used

@getLogicalDatabaseForTable@ was previously being used (before @findTableInfo@ was introduced), so yes, it makes sens... Constantin Asofiei

12:22 PM Database Bug #6586 (Test): parser/conversion bug when a database alias is used

Constantin Asofiei wrote:
> The fix is in 6129a/13954.
I'm assuming the premise is correct. The code changes look... Eric Faulhaber

11:06 AM Database Bug #6586 (Review): parser/conversion bug when a database alias is used

The fix is in 6129a/13954. Constantin Asofiei

12:05 PM User Interface Bug #5622: TREEVIEW widget issues

Vladimir Tsichevski wrote:
> I will fix this.
Great, I'll move on to another issue. I'll test the VMA bug after you... Tijs Wickardt

12:02 PM User Interface Bug #5622: TREEVIEW widget issues

Tijs Wickardt wrote:
> Vladimir Tsichevski wrote:
> > Unlike the @TREELIST@, the @Parent@ property applied to the t... Vladimir Tsichevski

12:01 PM User Interface Bug #5622: TREEVIEW widget issues

Vladimir Tsichevski wrote:
> Unlike the @TREELIST@, the @Parent@ property applied to the tree visible root, must ret... Tijs Wickardt

11:34 AM User Interface Bug #5622: TREEVIEW widget issues

Unlike the @TREELIST@, the @Parent@ property applied to the tree visible root, must return an invalid handle. Vladimir Tsichevski

06:24 AM User Interface Bug #5118: TREELIST widget issues

Vladimir Tsichevski wrote:
> In original OCX, an attempt to remove the hidden tree root (the node with index 0 and e... Vladimir Tsichevski

05:56 AM User Interface Bug #5118: TREELIST widget issues

In original OCX, an attempt to remove the hidden tree root (the node with index 0 and empty key) is silently ignored.... Vladimir Tsichevski

02:22 AM Database Bug #6579: QUERY-PREPARE validation

Ovidiu Maxiniuc wrote:
> The QUERY-PREPARE will process the 4GL code and create a complete in-memory class including... Marian Edu

08:29 PM Database Bug #6577 (WIP): move RecordBuffer.ooFields at the DMO meta

Multiple shared meta-knowledge about fields and properties of a record was collected in @DmoMeta@ to avoid duplicatin... Ovidiu Maxiniuc

07/06/2022

07:25 PM Database Feature #6584: implement schema hint which generates a POJO in addition to a DMO interface

Constantin Asofiei wrote:
> Eric/Ovidiu: on the client-side, jackson is used to serialize to JSON via ObjectMapper. ... Eric Faulhaber

05:10 PM Database Feature #6584: implement schema hint which generates a POJO in addition to a DMO interface

Eric/Ovidiu: on the client-side, jackson is used to serialize to JSON via ObjectMapper. This requires class fields a... Constantin Asofiei

03:59 PM Database Feature #6584: implement schema hint which generates a POJO in addition to a DMO interface

Constantin Asofiei wrote:
> Ovidiu, on FWD side, I'm using the declared fields to determine the getter/setter, in @P... Ovidiu Maxiniuc

12:48 AM Database Feature #6584: implement schema hint which generates a POJO in addition to a DMO interface

Ovidiu, on FWD side, I'm using the declared fields to determine the getter/setter, in @PojoSerializer@. If you are r... Constantin Asofiei

08:00 PM Database Feature #6584: implement schema hint which generates a POJO in addition to a DMO interface

A basic initial solution could be ready in 2-3 days. Ovidiu Maxiniuc

05:45 PM Runtime Infrastructure Support #5567: move FWD to Java 11

Not yet. 5567a has not been merged to 3821c. Greg Shah

05:35 PM Runtime Infrastructure Support #5567: move FWD to Java 11

What is the status of this task? Am I able to do devops image building like Ansible and Docker _without_ including Ja... Roger Borrello

05:29 PM Database Bug #6579: QUERY-PREPARE validation

The QUERY-PREPARE will process the 4GL code and create a complete in-memory class including a FQL for the 4GL code. A... Ovidiu Maxiniuc

03:08 PM Database Bug #6502: DATASET:CREATE-LIKE copies temp-table options (like XML-NODE-NAME), while TEMP-TABLE:C...

Constantin Asofiei wrote:
> Review for the #6502-15 patch:
> * @rules/convert/methods_attributes.rules@: why was th... Ovidiu Maxiniuc

06:39 AM Database Bug #6502: DATASET:CREATE-LIKE copies temp-table options (like XML-NODE-NAME), while TEMP-TABLE:C...

Review for the #6502-15 patch:
* @rules/convert/methods_attributes.rules@: why was this code removed?... Constantin Asofiei

02:17 PM Database Bug #6485 (Test): tracking-changes can be set if a temp-table has at least a buffer attached to a...

Constantin Asofiei

06:23 AM User Interface Feature #6583: Implement support for TOP-ONLY and ALWAYS-ON-TOP in Web GUI driver

Greg Shah wrote:
> Do we need to implement this now (current GUI apps use it) or can it be deferred?
I'm not awar... Hynek Cihlar

06:22 AM User Interface Feature #6583: Implement support for TOP-ONLY and ALWAYS-ON-TOP in Web GUI driver

Do we need to implement this now (current GUI apps use it) or can it be deferred? Greg Shah

06:13 AM Database Bug #6586: parser/conversion bug when a database alias is used

There is a bug when parsing/converting a program which uses a database alias:
* first program:... Constantin Asofiei

06:04 AM Database Bug #6586 (Test): parser/conversion bug when a database alias is used

Constantin Asofiei

12:28 AM Database Bug #6577: move RecordBuffer.ooFields at the DMO meta

Ovidiu Maxiniuc wrote:
> Where should the changes go to?
3821c Constantin Asofiei

07/05/2022

07:26 PM Database Feature #6584: implement schema hint which generates a POJO in addition to a DMO interface

All this sounds good. How long do you think it will take to implement? Eric Faulhaber

07:02 PM Database Feature #6584: implement schema hint which generates a POJO in addition to a DMO interface

Eric Faulhaber wrote:
> I don't think this necessarily is a requirement, but doing otherwise may be "unnatural" to d... Ovidiu Maxiniuc

05:14 PM Database Feature #6584: implement schema hint which generates a POJO in addition to a DMO interface

Ovidiu Maxiniuc wrote:
> Question: is it necessary for these POJOs that the private data to be independent fields?
... Eric Faulhaber

05:12 PM Database Feature #6584: implement schema hint which generates a POJO in addition to a DMO interface

I know of no limit in this area. An array should be fine. Greg Shah

04:48 PM Database Feature #6584: implement schema hint which generates a POJO in addition to a DMO interface

Question: is it necessary for these POJOs that the private data to be independent fields?
I think, if this is not ... Ovidiu Maxiniuc

03:06 PM Database Feature #6584: implement schema hint which generates a POJO in addition to a DMO interface

The idea is to generate a POJO equivalent of a DMO interface during schema conversion, with no binary dependencies on... Eric Faulhaber

02:45 PM Database Feature #6584 (Review): implement schema hint which generates a POJO in addition to a DMO interface

Eric Faulhaber

04:59 PM Database Bug #6577: move RecordBuffer.ooFields at the DMO meta

Where should the changes go to? Ovidiu Maxiniuc

05:51 AM Database Bug #6577: move RecordBuffer.ooFields at the DMO meta

The @RecordBuffer.ooFields@ is resolved via @getPojoGetterMap@, which iterates all getters - there can be DMOs with 1... Constantin Asofiei

05:48 AM Database Bug #6577 (Review): move RecordBuffer.ooFields at the DMO meta

Constantin Asofiei

02:37 PM Database Feature #6450 (Review): buffer/buffer-field features

The zipped patch was uploaded in #6502-15.
Constantin, please do the necessary review, when you have the time. Tha... Ovidiu Maxiniuc

01:40 AM Database Feature #6450: buffer/buffer-field features

Ovidiu, please upload #6502 and #6450 as a patch and I'll test conversion on my side.
Sorry, I thought I already m... Constantin Asofiei

02:35 PM Database Bug #6502: DATASET:CREATE-LIKE copies temp-table options (like XML-NODE-NAME), while TEMP-TABLE:C...

Please find attached the current patch for #6502 and #6450.
Ovidiu Maxiniuc

01:01 PM Database Feature #6582: implement multi-table AdaptiveQuery

@AdaptiveQuery@ currently is limited to a single table query, due primarily to the complexity of the state machine wh... Eric Faulhaber

12:46 PM Database Feature #6582 (WIP): implement multi-table AdaptiveQuery

Eric Faulhaber

12:59 PM User Interface Feature #6583: Implement support for TOP-ONLY and ALWAYS-ON-TOP in Web GUI driver

The @WINDOW@ widget attributes @TOP-ONLY@ and @ALWAYS-ON-TOP@ are currently not supported in the Web GUI driver.
W... Hynek Cihlar

12:55 PM User Interface Feature #6583 (Closed): Implement support for TOP-ONLY and ALWAYS-ON-TOP in Web GUI driver

Hynek Cihlar

08:26 AM Database Bug #6579: QUERY-PREPARE validation

In 4GL the query string is validated in @query-prepare@ method and if anything wrong with it an error is being thrown... Marian Edu

08:20 AM Database Bug #6579 (New): QUERY-PREPARE validation

Marian Edu

07:35 AM Database Feature #6507: cross-database joins

Is there a reason to implement this for a specific database backend? Greg Shah

07/04/2022

07:10 PM Database Feature #6450: buffer/buffer-field features

Thanks, Ovidiu. Please update the incorrect gap markings as part of your commit.
Constantin, it's been a few weeks... Eric Faulhaber

06:56 PM Database Feature #6450: buffer/buffer-field features

Eric Faulhaber wrote:
> What is blocking your changes from being committed?
I am waiting for Constantin's green lig... Ovidiu Maxiniuc

04:48 PM Database Feature #6450: buffer/buffer-field features

Ovidiu Maxiniuc wrote:
> I have implementation of some of the above attributes/methods as a pending changeset for 61... Eric Faulhaber

06:32 PM Database Feature #6574: auto-detect native UDFs at server startup and install them if missing

We have had many users stumble with the installation of the native UDFs. In the event the directory does not specify ... Eric Faulhaber

06:28 PM Database Feature #6574 (Closed): auto-detect native UDFs at server startup and install them if missing

Eric Faulhaber

05:25 PM Database Bug #5673: Additional support for INDEXED REPOSITION open query attribute

Alexandru Lungu wrote:
> The INDEXED REPOSITION 4GL optimization allows query reposition to records which were not... Eric Faulhaber

04:40 PM Database Feature #6507: cross-database joins

Initially, we need to support this for MariaDB, which essentially just means planning what database instances will lo... Eric Faulhaber

09:33 AM User Interface Bug #6053: Widget realisation

Greg Shah wrote:
> > There is no 'static widget' without a frame, a variable can only have one widget attached if pr... Marian Edu

09:21 AM User Interface Bug #6053: Widget realisation

Greg Shah wrote:
> I think this can only happen for dynamic widgets. Static widgets in a static frame (e.g. @DEF FR... Marian Edu

09:20 AM User Interface Bug #6053: Widget realisation

Greg Shah wrote:
> > There is no 'static widget' without a frame, a variable can only have one widget attached if pr... Hynek Cihlar

09:07 AM User Interface Bug #6053: Widget realisation

> There is no 'static widget' without a frame, a variable can only have one widget attached if present in a static fr... Greg Shah

08:58 AM User Interface Bug #6053: Widget realisation

Greg Shah wrote:
> > basically if the frame is set then the widget is fully 'realized' - the frame is really the on... Marian Edu

08:54 AM User Interface Bug #6053: Widget realisation

> Referencing a widget attribute or method on a variable or a field (without it being part of a frame) gives a compil... Greg Shah

08:50 AM User Interface Bug #6053: Widget realisation

Greg Shah wrote:
> > basically if the frame is set then the widget is fully 'realized' - the frame is really the on... Hynek Cihlar

08:42 AM User Interface Bug #6053: Widget realisation

> basically if the frame is set then the widget is fully 'realized' - the frame is really the only requirement here.... Greg Shah

07:13 AM User Interface Bug #6053: Widget realisation

Marian Edu wrote:
> So, basically if the @frame@ is set then the widget is fully 'realized' - the @frame@ is really ... Hynek Cihlar

05:45 AM User Interface Bug #6053: Widget realisation

Hynek Cihlar wrote:
> Actually currently the @realized@ config field is serialized only from client to server, but... Marian Edu

07/01/2022

03:04 AM Base Language Bug #6570: stale procedure leak when appservers are used

The implementation of stale procedures was done in #4187.
*The issue*: Multiple deletes on the same procedure wer... Alexandru Lungu

06/30/2022

11:16 AM Base Language Bug #6570: stale procedure leak when appservers are used

@DeferredDeletablesManager.registerAt@ is called with @blockDepth@ set to 0 in some cases. For a normal GUI/ChUI cli... Constantin Asofiei

11:02 AM Base Language Bug #6570 (Closed): stale procedure leak when appservers are used

Constantin Asofiei

06/28/2022

05:20 AM User Interface Bug #6562: Fix displaying of fonts applied to widgets through LOAD+USE or by changing the parent ...

The difficulties here:
# The changes should be performed for each widget type individually.
# Existing ways of widg... Stanislav Lomany

03:57 AM User Interface Bug #6562: Fix displaying of fonts applied to widgets through LOAD+USE or by changing the parent ...

> Is this describing the way it is supposed to work in the 4GL?
Yes. Stanislav Lomany

08:49 PM User Interface Bug #6562: Fix displaying of fonts applied to widgets through LOAD+USE or by changing the parent ...

Is this describing the way it is supposed to work in the 4GL? Greg Shah

06/27/2022

06:40 PM User Interface Bug #6562: Fix displaying of fonts applied to widgets through LOAD+USE or by changing the parent ...

There are three ways how fonts may be applied/changed:
# An .ini file can be loaded at startup by specifying the @in... Stanislav Lomany

03:19 PM User Interface Bug #6562 (New): Fix displaying of fonts applied to widgets through LOAD+USE or by changing the p...

Stanislav Lomany

11:08 AM Database Feature #6450 (WIP): buffer/buffer-field features

I have implementation of some of the above attributes/methods as a pending changeset for 6129a. Ovidiu Maxiniuc

03:10 AM Runtime Infrastructure Bug #6084: NIO SSL performance is slower than standard Java SSL

Constantin Asofiei wrote:
> Igor, in Eclipse I get a 'package not found' for this, in @SecureSocketsRegistrar@:
> [... Igor Skornyakov

02:34 AM Runtime Infrastructure Bug #6084: NIO SSL performance is slower than standard Java SSL

Igor, in Eclipse I get a 'package not found' for this, in @SecureSocketsRegistrar@:... Constantin Asofiei

06/26/2022

02:05 PM Runtime Infrastructure Bug #6084: NIO SSL performance is slower than standard Java SSL

Re-worked Conscrypt support based on the code review. Added JMC counters for @send@, @wrap@, and @unwrap@ operations ... Igor Skornyakov

06/25/2022

11:09 AM Conversion Tools Feature #6256: improved profile support

Our initial support for multi-profile conversion needs to be enhanced. FWD supports conversion of separate profiles,... Greg Shah

06/24/2022

02:37 PM Runtime Infrastructure Bug #6084: NIO SSL performance is slower than standard Java SSL

Greg Shah wrote:
> Please also implement any JMX instrumentation needed to help us measure the performance of the SS... Igor Skornyakov

02:37 PM Runtime Infrastructure Bug #6084: NIO SSL performance is slower than standard Java SSL

Greg Shah wrote:
> Code Review Task Branch 3821c Revision 14001
>
> 1. @BCProbe@ and @BouncyCastle@ should not be... Igor Skornyakov

02:34 PM Runtime Infrastructure Bug #6084: NIO SSL performance is slower than standard Java SSL

Please also implement any JMX instrumentation needed to help us measure the performance of the SSL processing. Greg Shah

02:33 PM Runtime Infrastructure Bug #6084: NIO SSL performance is slower than standard Java SSL

Code Review Task Branch 3821c Revision 14001
1. @BCProbe@ and @BouncyCastle@ should not be referenced in @Security... Greg Shah

12:19 PM Runtime Infrastructure Bug #6084 (Test): NIO SSL performance is slower than standard Java SSL

Hynek Cihlar wrote:
> Code review 6084-1.diff. The changes are good.
Thank you.
Committed to 3821c/14001. Igor Skornyakov

12:11 PM Runtime Infrastructure Bug #6084: NIO SSL performance is slower than standard Java SSL

Code review 6084-1.diff. The changes are good. Hynek Cihlar

11:09 AM Runtime Infrastructure Bug #6084: NIO SSL performance is slower than standard Java SSL

Hynek Cihlar wrote:
> If you remove the empty branch and add @provider != null@ to the last branch, then @null@ will... Igor Skornyakov

11:04 AM Runtime Infrastructure Bug #6084: NIO SSL performance is slower than standard Java SSL

Igor Skornyakov wrote:
> Hynek Cihlar wrote:
> > I see. In that case please remove the empty branch as it adds nois... Hynek Cihlar

10:58 AM Runtime Infrastructure Bug #6084: NIO SSL performance is slower than standard Java SSL

Hynek Cihlar wrote:
> I see. In that case please remove the empty branch as it adds noise to the code and do @else i... Igor Skornyakov

10:52 AM Runtime Infrastructure Bug #6084: NIO SSL performance is slower than standard Java SSL

Igor Skornyakov wrote:
> Hynek Cihlar wrote:
> > > > @null@ should be handled similarly as the invalid value case. ... Hynek Cihlar

09:58 AM Runtime Infrastructure Bug #6084: NIO SSL performance is slower than standard Java SSL

Hynek Cihlar wrote:
> > > @null@ should be handled similarly as the invalid value case. So that the condition is not... Igor Skornyakov

09:44 AM Runtime Infrastructure Bug #6084: NIO SSL performance is slower than standard Java SSL

Igor Skornyakov wrote:
> Hynek Cihlar wrote:
> > Code review @6084.diff@.
> >
> > In @ServerDriver.java@:
> >
... Hynek Cihlar

09:30 AM Runtime Infrastructure Bug #6084: NIO SSL performance is slower than standard Java SSL

Hynek Cihlar wrote:
> Code review @6084.diff@.
>
> In @ServerDriver.java@:
>
> [...]
>
> @null@ should be h... Igor Skornyakov

08:40 AM Runtime Infrastructure Bug #6084: NIO SSL performance is slower than standard Java SSL

Code review @6084.diff@.
In @ServerDriver.java@:... Hynek Cihlar

07:05 AM Runtime Infrastructure Bug #6084 (Review): NIO SSL performance is slower than standard Java SSL

Added support for the @Conscrypt@ SSL provider.
I've also changed the way for configuring non-default SSL providers.... Igor Skornyakov

11:40 AM Base Language Bug #6555: SECURITY-POLICY:SET-CLIENT fails with an imported CLIENT-PRINCIPAL

Constantin Asofiei wrote:
> Igor Skornyakov wrote:
> > OK. How urgent is this?
> > Thank you.
> If you can solve ... Igor Skornyakov

11:39 AM Base Language Bug #6555: SECURITY-POLICY:SET-CLIENT fails with an imported CLIENT-PRINCIPAL

Igor Skornyakov wrote:
> OK. How urgent is this?
> Thank you.
If you can solve it early next week, is good.
Constantin Asofiei

11:38 AM Base Language Bug #6555: SECURITY-POLICY:SET-CLIENT fails with an imported CLIENT-PRINCIPAL

Constantin Asofiei wrote:
> I don't have a standalone recreate, but in #6531 we have a scenario like this:
> * a @C... Igor Skornyakov

11:37 AM Base Language Bug #6555: SECURITY-POLICY:SET-CLIENT fails with an imported CLIENT-PRINCIPAL

I don't have a standalone recreate, but in #6531 we have a scenario like this:
* a @CLIENT-PRINCIPAL@ is created, va... Constantin Asofiei

11:33 AM Base Language Bug #6555 (Closed): SECURITY-POLICY:SET-CLIENT fails with an imported CLIENT-PRINCIPAL

Constantin Asofiei

09:25 AM Database Feature #6450: buffer/buffer-field features

When implementing the runtime support for @buffer-handle:PRIMARY@, consider supporting @temp-table-handle:PRIMARY@ if... Greg Shah

06/23/2022

05:23 PM Base Language Bug #6537: problems with ADD-INTERVAL

The a and d tests were failing because the computed interval @i@ was incorrect. The @add-interval@ seemed to work fin... Ovidiu Maxiniuc

02:25 AM Base Language Bug #6537: problems with ADD-INTERVAL

Ovidiu, @toLocalDateTime@ is wrong - you can't just adjust a datetimetz using the local timezone - what about DST?
... Constantin Asofiei

08:06 PM Base Language Bug #6537: problems with ADD-INTERVAL

Constantin Asofiei wrote:
> Ovidiu, the fix is in 6129a/13948 - please review.
I reviewed the changes and inserted ... Ovidiu Maxiniuc

10:27 AM Runtime Infrastructure Support #5567: move FWD to Java 11

> Greg, there are 2 clamscan processes still running on devsrv01... this usually affects ChUI regression testing.
... Greg Shah

10:23 AM Runtime Infrastructure Support #5567: move FWD to Java 11

Greg, there are 2 clamscan processes still running on devsrv01... this usually affects ChUI regression testing.
Constantin Asofiei

10:11 AM Runtime Infrastructure Support #5567: move FWD to Java 11

The main regression testing should complete in less than 4 hours. Anything more than that suggests many unexpected f... Greg Shah

04:58 AM Runtime Infrastructure Support #5567: move FWD to Java 11

For now I have baseline for ctrl-c tests.
I started main regression tests yesterday but they are still running after... Tomasz Domin

06/22/2022

10:36 AM Base Language Bug #6537: problems with ADD-INTERVAL

Ovidiu Maxiniuc wrote:
> Constantin Asofiei wrote:
> > Ovidiu, the fix is in 6129a/13948 - please review. The poin... Constantin Asofiei

10:16 AM Base Language Bug #6537: problems with ADD-INTERVAL

Constantin Asofiei wrote:
> Ovidiu, the fix is in 6129a/13948 - please review. The point with the @interval@ issue ... Ovidiu Maxiniuc

05:05 AM Base Language Bug #6537: problems with ADD-INTERVAL

Ovidiu, the fix is in 6129a/13948 - please review. The point with the @interval@ issue is to convert both instances ... Constantin Asofiei

09:35 PM Base Language Bug #6537 (WIP): problems with ADD-INTERVAL

Constantin,
I checked the code and did some tests. I think that those adjustments are fine. But there other issues w... Ovidiu Maxiniuc

06/21/2022

03:32 PM Base Language Bug #6537: problems with ADD-INTERVAL

There is a bug in ADD-INTERVAL: it overrides the timezone, when a datetimetz is used. See this:... Constantin Asofiei

03:26 PM Base Language Bug #6537 (WIP): problems with ADD-INTERVAL

Constantin Asofiei

06/20/2022

06:18 PM Database Bug #6485: tracking-changes can be set if a temp-table has at least a buffer attached to a dataset

I added the complete implementation of @DATA-SOURCE-ROWID(num/name)@ in revision 13947.
Ovidiu Maxiniuc

01:11 PM Base Language Bug #6533: dynamic equals operator

I have a fix for the above in 6129a/13946.
Greg: if we don't already have, I think we need to check all compare op... Constantin Asofiei

12:45 PM Base Language Bug #6533: dynamic equals operator

This test works fine in 4GL:... Constantin Asofiei

12:45 PM Base Language Bug #6533 (New): dynamic equals operator

Constantin Asofiei

10:24 AM Conversion Tools Bug #5489: Cleanup / reimplement merge DMO definitions

Have there been other changes that have rendered this moot? I was just reading through a Redmine, and wanted to follo... Roger Borrello

08:45 AM User Interface Feature #5742: improve web client startup time

Greg Shah wrote:
> At least the @TailScopedDictionary@ is not from Tomasz.
I'm sorry.. I combined them incorrectly. Roger Borrello

08:36 AM User Interface Feature #5742: improve web client startup time

At least the @TailScopedDictionary@ is not from Tomasz. Greg Shah

08:35 AM User Interface Feature #5742: improve web client startup time

Tomasz, there is a minor javadoc issues to correct:... Roger Borrello

04:53 AM User Interface Bug #6513: Invalid key sequence response in FILL-IN widget inside Web client

I don't understand now why this condition is not enough. It should return true only if a pressed key is SHIFT, ALT, C... Sergey Ivanovskiy

06/18/2022

02:21 AM Database Bug #6485: tracking-changes can be set if a temp-table has at least a buffer attached to a dataset

Ovidiu, thank you, it solves the issue I had in #6277. Constantin Asofiei

08:31 PM Database Bug #6485: tracking-changes can be set if a temp-table has at least a buffer attached to a dataset

Interesting. I added some more lines to that testcase. If the data-source is detached or replaced with another, the a... Ovidiu Maxiniuc

06/17/2022

04:35 PM User Interface Bug #6513: Invalid key sequence response in FILL-IN widget inside Web client

Sergey Ivanovskiy wrote:
> Eugenie Lyzenko wrote:
> > Sergey Ivanovskiy wrote:
> > > Eugenie Lyzenko wrote:
> > >... Eugenie Lyzenko

04:19 PM User Interface Bug #6513: Invalid key sequence response in FILL-IN widget inside Web client

Eugenie Lyzenko wrote:
> Sergey Ivanovskiy wrote:
> > Eugenie Lyzenko wrote:
> > > The @3821c@ updated for review ... Sergey Ivanovskiy

04:14 PM User Interface Bug #6513: Invalid key sequence response in FILL-IN widget inside Web client

Yes, I think you should not this new fix because last event was allocated if there is no such event in the events queue. Sergey Ivanovskiy

03:54 PM User Interface Bug #6513: Invalid key sequence response in FILL-IN widget inside Web client

The other possible fix version for @p2j.keyboard.js@ is:... Eugenie Lyzenko

11:04 AM User Interface Bug #6513: Invalid key sequence response in FILL-IN widget inside Web client

I have observed the possible alternatives for the fix and found we can not avoid the logic currently used in fix.
... Eugenie Lyzenko

02:29 PM Database Bug #6485: tracking-changes can be set if a temp-table has at least a buffer attached to a dataset

Constantin Asofiei wrote:
> I have a case where the disabled code in #6485-12 needs to be backed out,
I meant the c... Constantin Asofiei

02:23 PM Database Bug #6485: tracking-changes can be set if a temp-table has at least a buffer attached to a dataset

Ovidiu, please work on fixing #6485-7 issue. I have a case where the disabled code in #6485-12 needs to be backed out... Constantin Asofiei

10:35 AM Runtime Infrastructure Bug #6529: Incompatible uppercasing.

I've noticed the following incompatibility.
Consider the following code:... Igor Skornyakov

10:33 AM Runtime Infrastructure Bug #6529 (New): Incompatible uppercasing.

Igor Skornyakov

10:25 AM Database Feature #6444: dataset improvements

Ovidiu, could you please review the list above and indicate what the actual support is currently (and update gap mark... Eric Faulhaber

06:11 AM Database Bug #6524 (Test): BUFFER-COPY does not create a record in the before-table

Ovidiu, thank you, this solves the problem I was seeing.
Constantin Asofiei