Activity
From 04/01/2023 to 04/30/2023
04/29/2023
- 06:05 AM Base Language Bug #7193: READ-JSON is not supported for the "LONGCHAR" source type
- Igor Skornyakov wrote:
> Implemented DATA-SET:WRITE-XMLSCHEMA with SERIALIZE-HIDDEN = true.
> Committed to 7193a/1... - 04:02 AM Database Bug #7113: Problem with nested CAN-FIND conversion
- Ovidiu Maxiniuc wrote:
> Igor,
> I have fixed the extra closing parenthesis as part of another task. Please do not... - 08:34 PM Database Bug #7113: Problem with nested CAN-FIND conversion
- Igor,
I have fixed the extra closing parenthesis as part of another task. Please do not put additional effort in th... - 03:38 AM Database Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...
- Maciej Zieniuk wrote:
> The expectation is that the @for each ttOrderCustomer:@ will fail with @Progress.Lang.Error@... - 09:56 PM Database Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...
- Maciej Zieniuk wrote:
> The expectation is that the @for each ttOrderCustomer:@ will fail with @Progress.Lang.Error@...
04/28/2023
- 04:15 PM Database Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...
- I am not sure what to do with the @tests.dataset.parameter.input.TestDatasetBind@ class test @referenceOnlyNotValid@....
- 09:09 AM Database Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...
- Correct. ...
- 09:00 AM Database Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...
- Greg Shah wrote:
> > Aka, this doesn't convert because of the use of @no-error@:
>
> What is the error? Is it du... - 08:04 AM Database Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...
- > Aka, this doesn't convert because of the use of @no-error@:
What is the error? Is it during parsing or during l... - 04:18 AM Database Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...
- Pushed a few changes, the conversion issue with @create dataset/data-source@ was due to the fact that @no-error@ opti...
- 04:06 AM Database Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...
- Maciej Zieniuk wrote:
> You are right. I initially though this is about @dsInit@ being unknown, not initialized, b... - 02:27 AM Database Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...
- > This sounds good to me, but then why the handle is invalid? I would check the converted code, from what we've seen ...
- 01:49 AM Database Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...
- Maciej Zieniuk wrote:
> - @tests.dataset.parameter.inout.TestInputOutputDynamicDsInDynamicProc@ method @passDatase... - 04:11 PM Base Language Bug #7193: READ-JSON is not supported for the "LONGCHAR" source type
- Implemented DATA-SET:WRITE-XMLSCHEMA with SERIALIZE-HIDDEN = true.
Committed to 7193a/14566.
This provides the ... - 11:31 AM Base Language Bug #7299: resolution of the target OO method in chained calls with poly arguments
- > > I think this fix is needed urgently by one project. Should we merge this to trunk and 7156a now and then check t...
- 08:32 AM Base Language Feature #4065: server-side processing of client platform dependencies
- I think this discussion qualifies as defining the requirements for the "reduce package name text in stack trace outpu...
- 08:23 AM Base Language Feature #4065: server-side processing of client platform dependencies
- Greg Shah wrote:
> I would hope that we can integrate these changes together without moving all logging work to Hyne... - 07:52 AM Base Language Feature #4065: server-side processing of client platform dependencies
- It is not uncommon for us to implement small changes to unrelated areas in tasks that are otherwise addressing a diff...
- 03:15 AM Base Language Feature #4065: server-side processing of client platform dependencies
- Hynek Cihlar wrote:
> The code doesn't matter. It's important so that we keep the product good. If it means you need... - 03:03 AM Base Language Feature #4065: server-side processing of client platform dependencies
- Galya Bogdanova wrote:
> Hynek Cihlar wrote:
> > The changes are so minimal that I don't see how it can cause issue... - 02:46 AM Base Language Feature #4065: server-side processing of client platform dependencies
- Hynek Cihlar wrote:
> The changes are so minimal that I don't see how it can cause issues during merging with your w... - 02:34 AM Base Language Feature #4065: server-side processing of client platform dependencies
- Galya Bogdanova wrote:
> Hynek Cihlar wrote:
> > @Logger.getLogger@ replaced with @LogHelper@ in 4065a revision 145... - 01:18 AM Base Language Feature #4065: server-side processing of client platform dependencies
- Hynek Cihlar wrote:
> @Logger.getLogger@ replaced with @LogHelper@ in 4065a revision 14563. Galya, please review.
... - 08:04 AM Base Language Bug #7308: 4GL does not validate the extent index in a 'DEF VAR ... LIKE v1[100]' case, where v1 ...
- For function parameters, the LBRACKET is completely ignored. For procedure parameters, it works as a DEF VAR:...
- 07:38 AM Base Language Bug #7308: 4GL does not validate the extent index in a 'DEF VAR ... LIKE v1[100]' case, where v1 ...
- This test works fine in 4GL:...
- 07:38 AM Base Language Bug #7308 (Closed): 4GL does not validate the extent index in a 'DEF VAR ... LIKE v1[100]' case, ...
- 07:06 AM Base Language Feature #6422: implement auditing support including AUDIT-POLICY and AUDIT-CONTROL
- I think that the table @_aud-audit-data@ holds the records only for the @SET-APPL-CONTEXT@ command. In progress docum...
- 04:52 AM Base Language Feature #6422: implement auditing support including AUDIT-POLICY and AUDIT-CONTROL
- Theodoros Theodorou wrote:
> I found also some hidden tables regarding auditing: @_aud-*@. I tried to use @LOG-APP... - 04:12 AM Database Feature #7194: Avoid generating an ORDER-BY clause if not required
- Alexandru Lungu wrote:
> ** What if the uniquely found record is changed? The query should invalidate (or not?) and ... - 01:32 AM Runtime Infrastructure Feature #7279: Enhance CentralLogger to support configurable LogFormatter
- As requested in #4065-104 support optional (configurable) shorter versions of package names. Check how other logging ...
04/27/2023
- 04:17 PM Base Language Feature #6422: implement auditing support including AUDIT-POLICY and AUDIT-CONTROL
- Hello Marian, I am trying to find the exact usage of the commands @LOG-AUDIT-EVENT@, @CLEAR-APPL-CONTEXT@ and @SET-AP...
- 01:41 PM Base Language Bug #7250: PROMPT-FOR with a table field reference resolves to NO-REFERENCE in OpenEdge
- Code Review Task Branch 7250a Revision 14553
No objections. - 01:10 PM Base Language Bug #7250 (Review): PROMPT-FOR with a table field reference resolves to NO-REFERENCE in OpenEdge
- Branch 7250a was created trunk 14552.
The change in previous note is in rev 14553. - 07:46 AM Base Language Bug #7250: PROMPT-FOR with a table field reference resolves to NO-REFERENCE in OpenEdge
- There is another case related to PROMPT-FOR: when a record reference is used instead of individual fields. I'm testi...
- 01:40 PM Base Language Feature #4065: server-side processing of client platform dependencies
- @Logger.getLogger@ replaced with @LogHelper@ in 4065a revision 14563. Galya, please review.
- 01:37 PM Base Language Feature #4065: server-side processing of client platform dependencies
- Greg Shah wrote:
> The change related to the reduction of package names seems to be useful.
Wasn't a requirement ... - 01:35 PM Base Language Feature #4065: server-side processing of client platform dependencies
- The change related to the reduction of package names seems to be useful.
- 01:34 PM Base Language Feature #4065: server-side processing of client platform dependencies
- Galya Bogdanova wrote:
> Hynek, I will obviously have to resolve the conflicts caused by all the changes you do to l... - 01:33 PM Base Language Feature #4065: server-side processing of client platform dependencies
- Hynek Cihlar wrote:
> AFAIK Galya has successfully rebased with the logging changes. They are really minimal anyway ... - 01:32 PM Base Language Feature #4065: server-side processing of client platform dependencies
- Greg Shah wrote:
> Let's ensure that they don't cause conflicts with the upcoming merge of 5703a.
AFAIK Galya has... - 01:28 PM Base Language Feature #4065: server-side processing of client platform dependencies
- Hynek, I will obviously have to resolve the conflicts caused by all the changes you do to logging and then delete the...
- 01:26 PM Base Language Feature #4065: server-side processing of client platform dependencies
- Let's ensure that they don't cause conflicts with the upcoming merge of 5703a.
Also, we definitely should be using... - 01:23 PM Base Language Feature #4065: server-side processing of client platform dependencies
- Greg Shah wrote:
> Code Review Task branch 4065a Revisions 14560 through 14562
>
> No objections. Weren't the lo... - 10:45 AM Base Language Feature #4065: server-side processing of client platform dependencies
- Constantin Asofiei wrote:
> Review for 4065a rev 14527:
> * @HighLevelObject.LOG@ - we are replacing @java.util.log... - 10:33 AM Base Language Feature #4065: server-side processing of client platform dependencies
- Greg Shah wrote:
> Galya: Please review the logging changes in rev 14560.
The changes are indeed unexpected. - 10:21 AM Base Language Feature #4065: server-side processing of client platform dependencies
- Code Review Task branch 4065a Revisions 14560 through 14562
No objections. Weren't the logging changes removed on... - 07:54 AM Base Language Feature #4065: server-side processing of client platform dependencies
- The points raised during the reviews are resolved in 4065a revision 14561. File history entries added in revision 145...
- 04:32 AM Base Language Feature #4065: server-side processing of client platform dependencies
- I rebased 4065a against the latest trunk.
- 01:19 PM User Interface Feature #3931: single sign-on for virtual desktop mode
- Constantin, in @p2j.emain.js@ there is a function @me.login@ - I can't find how / where it's executed. There is @p2j....
- 12:28 PM Base Language Feature #6410: implement additional built-in OO classes/interfaces
- Branch 6410a has been branched from trunk 14552. I've pushed it to xfer (@/opt/fwd/6410a@).
- 12:03 PM Deployment Support #7306: standardize how our projects obtain/consume 4GL source code/schemata from customers
- The FWD conversion process (and analytics) require 4GL source code and schemata to be provided. To date, we have use...
- 11:47 AM Deployment Support #7306 (New): standardize how our projects obtain/consume 4GL source code/schemata from cu...
- 11:45 AM Build and Source Control Support #5167: using static linking to eliminate the need to patch the system-wide ncurses
- Please give this idea a try to see if it can work. You would patch a local version of the ncurses project and use it...
- 11:41 AM Build and Source Control Bug #6208 (Closed): cleanup build warnings
- 09:30 AM Database Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...
- Maciej: Please do fix all of these conversion issues. I don't want to leave behind any latent problems.
So we nee... - 09:19 AM Database Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...
- Maciej Zieniuk wrote:
> Marian, i don't think the @support/test/HandleFactory.cls@ is converting in newest testcases... - 07:49 AM Database Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...
- Marian, i don't think the @support/test/HandleFactory.cls@ is converting in newest testcases revision, because of the...
- 08:26 AM Runtime Infrastructure Feature #1848: make logging settings controllable dynamically at runtime
- > A note: With #5703 all levels can be changed dynamically. To not lose logs, when the level is lowered, @isLoggable(...
- 05:23 AM Runtime Infrastructure Feature #1848: make logging settings controllable dynamically at runtime
- A note: With #5703 all levels can be changed dynamically. To not lose logs, when the level is lowered, @isLoggable()@...
- 05:09 AM Runtime Infrastructure Feature #1848: make logging settings controllable dynamically at runtime
- A note: For dynamic levels to apply to all child packages and classes, all loggers should have fully qualified names ...
- 05:32 AM Database Feature #7076: make CAN-FIND avoid hydration
- I've tested both temporary and persistent tables with CAN-FIND and nested CAN-FIND. CAN-FIND no longer hydrates with ...
- 03:50 AM Database Feature #6630: optimize return of table parameter
- Danut, I recall I changed the @AdaptiveQuery@ from @TemporaryBuffer.loopDelete@ into a @PreselectQuery@. Basically, t...
- 03:45 AM Conversion Tools Feature #7180: create a centralized manager for the conversion list and per-file/project status a...
- Interface is @p2j.convert.ConversionStatus@. Applicable for packages (refs #5703#note-133):...
- 03:00 AM Database Bug #7235 (Review): Avoid selecting all fields for an CAN-FIND sub-select
- Added this patch to 7026c.
Tested this. I got a -0.24% performance improvement with a 7026c profile run.
Just rebas...
04/26/2023
- 05:04 PM Database Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...
- Thanks Marian, that helped.
Few findings:
- @tests.dataset.parameter.inout.TestInputOutputDynamicDsInDynamicProc@... - 02:09 AM Database Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...
- Maciej Zieniuk wrote:
> Oh i almost forgot, i have this weird issue, that i cannot run @ant dist@ on the testcases r... - 03:56 PM Base Language Bug #7301: pre-scan of a 'DEFINE BUFFER btt1 FOR btt1' from within a method
- Code Review Task Branch 7301a Revision 14552
It seems that this logic may be broken if the @recordName@ is a quali... - 02:58 PM Base Language Bug #7304: UN_MINUS resolves to int64 instead of integer in ExpressionConversionWorker
- Code Review Task Branch 7304a Revision 14552
No objections. - 08:02 AM Base Language Bug #7304 (Review): UN_MINUS resolves to int64 instead of integer in ExpressionConversionWorker
- 7304a rev 14552 contains the implementation for the idea in note #7304-2.
- 07:51 AM Base Language Bug #7304: UN_MINUS resolves to int64 instead of integer in ExpressionConversionWorker
- Created task branch 7304a from trunk rev 14551.
- 02:30 AM Base Language Bug #7304: UN_MINUS resolves to int64 instead of integer in ExpressionConversionWorker
- I think in OpenEdge there is a runtime check if an expression argument is int64 instead of the integer parameter set ...
- 01:27 AM Base Language Bug #7304 (Closed): UN_MINUS resolves to int64 instead of integer in ExpressionConversionWorker
- 12:04 PM Base Language Bug #7299: resolution of the target OO method in chained calls with poly arguments
- Marian: Please have your team review the documentation on method overloading in #3751-492 and look at the code in @oo...
- 10:21 AM Database Feature #7194 (WIP): Avoid generating an ORDER-BY clause if not required
- I will move this back to 50% to allow the handling of other ORDER BY clauses (from RandomAccessQuery especially).
- 10:18 AM Database Feature #7194 (Review): Avoid generating an ORDER-BY clause if not required
- Tested this. I got a -0.24% performance improvement with a 7026c profile run.
Just rebased 7026c with trunk.
Fu... - 10:06 AM Database Feature #7076 (WIP): make CAN-FIND avoid hydration
- Danut, please investigate this.
I am not sure if CAN-FIND still hydrates in the latest versions of FWD-H2 trunk (>1... - 09:16 AM Database Bug #7138: Short circuit fake-update (update with a new value eqaul to the old value) in H2
- I've tested #6928-3 and also made my own set of performance tests (results are measured in milliseconds). The results...
- 05:57 AM Database Bug #7138 (Review): Short circuit fake-update (update with a new value eqaul to the old value) in H2
- Fixed a regression in 7138a_h2 regarding updating indexed computed columns in inMemUpdate mode. If you have (f1, __if...
- 09:08 AM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- I've completed all that was on my mind with this task. Today I added some final touch-ups to the yesterday's changes ...
- 09:03 AM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Actually I was working on @SecurityManager@ two months ago #5703#note-28. I just want to double check.
* Its custom ... - 08:05 AM Database Bug #7185: H2 in-memory lazy hydration
- Merged 7185a_h2 into FWD-H2 trunk as rev. 17.
This doesn't require any FWD changes; it just optimizes the direct-ac... - 04:35 AM Database Bug #7185: H2 in-memory lazy hydration
- Review 7185a_h2. The changes are good to go, you can proceed with the merge.
- 07:52 AM Base Language Feature #4065: server-side processing of client platform dependencies
- > I agree this could be merged together under a file-system resource. Greg, what do you think?
Agreed. - 07:17 AM Base Language Feature #4065: server-side processing of client platform dependencies
- Constantin Asofiei wrote:
> Review for 4065a rev 14527:
> * @ConcurrentResource.resourceTypeName@ - the javadoc was... - 07:09 AM Base Language Feature #4065: server-side processing of client platform dependencies
- Review for 4065a rev 14527:
* @ConcurrentResource.resourceTypeName@ - the javadoc was indented right
* @HighLevelOb... - 05:14 AM Base Language Feature #4065: server-side processing of client platform dependencies
- Greg Shah wrote:
> Code Review Task Branch 4065a Revisions 14521 through 14527
>
> Overall this is a really nice ...
04/25/2023
- 06:36 PM Database Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...
- Oh i almost forgot, i have this weird issue, that i cannot run @ant dist@ on the testcases repo, because it fails wit...
- 06:26 PM Database Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...
- I wanted to make sure that the dataset testcases actually works fine in 4GL ABLUnit.
With 4GL 11.6 version i was abl... - 12:34 PM Database Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...
- Maciej Zieniuk wrote:
> > Running all tests in a suite seems to make some of those tests to fail even if ran individ... - 10:45 AM Database Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...
- > Running all tests in a suite seems to make some of those tests to fail even if ran individually they pass... curren...
- 07:41 AM Database Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...
- Maciej Zieniuk wrote:
> Yes by "push" i meant bound branch to a remote repo with bzr commit.
> I will have to reba... - 02:51 AM Database Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...
- Yes by "push" i meant bound branch to a remote repo with bzr commit.
I will have to rebase too once in a while, to ... - 04:05 PM Base Language Feature #4065: server-side processing of client platform dependencies
- Constantin: Please review.
- 04:04 PM Base Language Feature #4065: server-side processing of client platform dependencies
- Code Review Task Branch 4065a Revisions 14521 through 14527
Overall this is a really nice update! I think the app... - 02:38 PM Testing Support #6863 (WIP): implement CI/CD servers and the rules for each set of tests
- 02:37 PM Base Language Bug #7301: pre-scan of a 'DEFINE BUFFER btt1 FOR btt1' from within a method
- Created task branch 7301a from trunk rev 14551.
The patch in previous note is in rev 14552. - 09:51 AM Base Language Bug #7301: pre-scan of a 'DEFINE BUFFER btt1 FOR btt1' from within a method
- The previous patch is not correct, it regresses this case:...
- 07:14 AM Base Language Bug #7301: pre-scan of a 'DEFINE BUFFER btt1 FOR btt1' from within a method
- In pre-scan, no scope is pushed for top-level blocks (as we can't track them). This case fails to parse in pre-scan:...
- 07:06 AM Base Language Bug #7301 (Closed): pre-scan of a 'DEFINE BUFFER btt1 FOR btt1' from within a method
- 12:48 PM Base Language Bug #7299: resolution of the target OO method in chained calls with poly arguments
- We convert compilable code, which this is. hIt is used heavily in a customer project so we need to get it right.
- 12:36 PM Base Language Bug #7299: resolution of the target OO method in chained calls with poly arguments
- Constantin Asofiei wrote:
> Marian, we need more tests to determine how OE behaves in this case. The problem here i... - 12:27 PM Base Language Bug #7299: resolution of the target OO method in chained calls with poly arguments
- Greg Shah wrote:
> I think this fix is needed urgently by one project. Should we merge this to trunk and 7156a now ... - 12:24 PM Base Language Bug #7299: resolution of the target OO method in chained calls with poly arguments
- I think this fix is needed urgently by one project. Should we merge this to trunk and 7156a now and then check the t...
- 12:22 PM Base Language Bug #7299: resolution of the target OO method in chained calls with poly arguments
- Code Review Task Branch 7299a Revision 14551
No objections. - 07:19 AM Base Language Bug #7299: resolution of the target OO method in chained calls with poly arguments
- Created task branch 7299a from trunk rev 14550. The patch is in rev 14551. Greg, please review.
- 05:39 AM Base Language Bug #7299: resolution of the target OO method in chained calls with poly arguments
- Constantin, will do... as a side note, imho this should not have been allowed in 4GL, it completely break any strong ...
- 10:49 AM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Since the only security issue here is related to log file output, I think the danger is quite limited. Rather than h...
- 07:39 AM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- "Using Expressions in Access Rights":/artifacts/javadoc/latest/api/com/goldencode/p2j/security/package-summary.html#U...
- 02:25 AM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Can someone give me an example of @access rights expressions@ (refs com.goldencode.p2j.security.VariablePool)? @getRe...
- 10:34 AM Database Feature #7194: Avoid generating an ORDER-BY clause if not required
- My initial thought when I created #7194 was to optimize UNIQUE FIND/CAN-FIND for persistent databases. For temp datab...
- 10:20 AM Database Bug #7185: H2 in-memory lazy hydration
- I updated #7185-30 with the times regarding the FWD changes (lazy hydration). While the FWD-H2 changes provides a con...
- 09:44 AM Database Bug #7138: Short circuit fake-update (update with a new value eqaul to the old value) in H2
- I tested Hotel_GUI and found no problems, but I found a regression in a customer application which I didn't manage to...
- 05:51 AM Database Bug #7235: Avoid selecting all fields for an CAN-FIND sub-select
- Alexandru Lungu wrote:
> ... Please check that the SELECT keyword is placed correctly (as a left sibling of the num ... - 05:47 AM Database Bug #7108: Simulate upper/rtrim directly in H2 using case specific columns
- Branch 7108a_h2 has been merged to FWD-H2 trunk at revision 16.
- 05:47 AM Database Bug #7108: Simulate upper/rtrim directly in H2 using case specific columns
- Branch 7108a has been merged to trunk at revision 14550
- 05:11 AM Database Bug #7258: Optimize INDEX-INFORMATION with closed dynamic queries
- Branch 7258a has been merged to trunk at revision 14549.
04/24/2023
- 05:30 PM Database Feature #6371: implement SAVE CACHE statement
- Code review 6371d/14544:
One *very minor* change: please fix the open curly brace at @SchemaComparator.java@:149 t... - 06:50 AM Database Feature #6371: implement SAVE CACHE statement
- I was asked to test this statement. I will not be able to have a look at this soon, probably not even before summer v...
- 02:11 PM Base Language Bug #7299: resolution of the target OO method in chained calls with poly arguments
- Marian, we need more tests to determine how OE behaves in this case. The problem here is when there are multiple ove...
- 01:49 PM Base Language Bug #7299: resolution of the target OO method in chained calls with poly arguments
- In #7261, this test was found to not work properly:...
- 01:48 PM Base Language Bug #7299 (Test): resolution of the target OO method in chained calls with poly arguments
- 01:42 PM Database Bug #7258 (Test): Optimize INDEX-INFORMATION with closed dynamic queries
- @7258a.patch@ looks fine. The code in @DynamicQueryHelper@ looks much cleaner now. Good job!
- 04:25 AM Database Bug #7258: Optimize INDEX-INFORMATION with closed dynamic queries
- Ovidiu, I am planning to merge 7258a today. Move this to Test after you check #7158-7: these are the same changes as ...
- 01:10 PM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- In regard to the @AdminServerImpl@ use of @LOG.setLevel(Level.FINER);@, I think it should be deleted. There is no re...
- 10:01 AM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Good
- 09:59 AM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Also when server-side enabled I have to fix it to produce separate files by generating them dynamically based on some...
- 09:56 AM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- OK, may I then implement these requirements so:
* there is a directory.xml flag @logging/serverSide@ by default fals... - 09:46 AM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- > > When we are configured for server-side logging, it no longer makes sense for there to be a separate FWD client lo...
- 08:58 AM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Greg Shah wrote:
> When we are configured for server-side logging, it no longer makes sense for there to be a separa... - 08:48 AM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- > Why do we need to write client logs from the server for FWD logs - client logs are generated on the client and serv...
- 08:43 AM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Let's put LOG-MANAGER aside and discuss it in #7291.
Why do we need to write client logs from the server for FWD l... - 08:28 AM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- > > Permissions are always an issue in client scenarios, remote or local. The client must have proper permissions fo...
- 05:04 AM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Since there is no merging of client and server files in any of the supported cases, I want to present a well-rounded ...
- 04:49 AM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- May I be excused to have the audacity to summarize the requested changes as:
* the same number of files in compariso... - 04:23 AM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- I'm reading #4065 and the code. I believe the core concept is the only one relevant here. If I understand properly, c...
- 01:36 AM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Greg Shah wrote:
> Permissions are always an issue in client scenarios, remote or local. The client must have prope... - 12:57 PM Base Language Bug #7240: conversion problem related to ENTERED in a IF expr
- Another case somehow related to #7178 - @tt1.f1 [not] entered@ must not produce a buffer reference. A fix for this ...
- 10:45 AM Base Language Bug #5276: resolve issues with multi-byte character processing
- Status on this: I'm in the middle of converting @character.java@ to use @codePointAt@ instead of @charAt@ where appro...
- 09:00 AM Database Bug #7035: Extract query parameters from statically converted FQL
- I created the temporary *JMX* and added counters for meta, temp, dirty and persistent database hits/misses. The count...
- 06:46 AM Database Bug #7138: Short circuit fake-update (update with a new value eqaul to the old value) in H2
- *Review to 7138a_h2/rev.17* : I am OK with the changes.
Danut, please re-test 7138a_h2 (own test-cases, large cust... - 05:47 AM Database Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...
- > I have pushed that change to @~/secure/code/p2j_repo/p2j/active/4514a@. If i find anything i will push more to the ...
- 05:34 AM Database Feature #7194: Avoid generating an ORDER-BY clause if not required
- Radu, let the intended changes for #7194 reside in 7026c. I am thinking of merging 7026c independently from 7066a, as...
- 05:30 AM Database Bug #7235: Avoid selecting all fields for an CAN-FIND sub-select
- *Review of #7235 patch in #7235-3.*
* When you append the NUM_LITERAL, you also append SELECT (which is OK). You u...
04/22/2023
- 03:26 PM Conversion Tools Feature #6237: OEUnit support
- Greg Shah wrote:
> Please go ahead with the updates to the documentation.
Done: new sections added: OEUnit-relate... - 02:18 AM Database Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...
- I have pushed that change to @~/secure/code/p2j_repo/p2j/active/4514a@. If i find anything i will push more to the br...
04/21/2023
- 04:28 PM Database Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...
- Greg Shah wrote:
> > I am thinking about making a change to the FWD code, to something like:
> That seems reasonabl... - 08:00 AM Database Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...
- Greg Shah wrote:
> > I am thinking about making a change to the FWD code, to something like:
>
> That seems reaso... - 07:55 AM Database Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...
- > I am thinking about making a change to the FWD code, to something like:
That seems reasonable if the @unableToAs... - 07:23 AM Database Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...
- I've pushed a bunch of changes in @testcases@, we took out @tests@, @support@ from @PROPATH@ and added missing 'stand...
- 06:47 AM Database Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...
- The @TestNamespaceUri.cls@ method @TestSetInvalid@ is outdated and needs to be corrected.
Below procedure result i... - 11:26 AM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Galya Bogdanova wrote:
> I remember there was a mention of client permissions in the context of remote clients. What... - 10:50 AM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- I remember there was a mention of client permissions in the context of remote clients. What about local clients, isn'...
- 10:45 AM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- The two cases are exclusively server-side and only occur at the very initialization of the logger. The SM case is dr...
- 10:34 AM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Greg Shah wrote:
> Neither of these is dynamic. One is hard coded in the source and the other is read from the dire... - 10:28 AM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- > > Where is it used today?
> On trunk @AdminServerImpl -> LOG.setLevel(Level.FINER);@ and and @SecurityManager -> L... - 10:02 AM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- The question is do we keep it part of the interface of the logger.
- 10:01 AM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Tomorrow it might be used somewhere else, if not disabled.
- 10:01 AM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Greg Shah wrote:
> Where is it used today?
On trunk @AdminServerImpl -> LOG.setLevel(Level.FINER);@ and and @Securi... - 09:59 AM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Where is it used today?
- 09:39 AM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- I would recommend disabling @setLevel@ for now, if we're not clear how this should work out. It's messy even with one...
- 09:38 AM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Unexpected behavior - isn't it a definition of a bug. If it's not defined, it will be unexpected -> bug.
- 09:36 AM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Greg Shah wrote:
> Is there a reason to change it right now?
Yes, the logger is now distributed. I need to know wha... - 09:35 AM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Is there a reason to change it right now?
- 09:34 AM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Greg Shah wrote:
> > > What do you mean by dynamic logging levels?
> > @LOG.setLevel()@ called programmatically.
>... - 09:33 AM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- > And what do we do with the dynamic levels that can be set server-side and client-side in the code at any time?
W... - 09:33 AM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- > > What do you mean by dynamic logging levels?
> @LOG.setLevel()@ called programmatically.
Leave this alone unle... - 09:32 AM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- And what do we do with the dynamic levels that can be set server-side and client-side in the code at any time?
- 09:31 AM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- > > I don't know that we care about per-context logging levels EXCEPT for the @LOG-MANAGER@ stuff. In the FWD logging...
- 09:13 AM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Greg Shah wrote:
> I don't know that we care about per-context logging levels EXCEPT for the @LOG-MANAGER@ stuff. In... - 09:11 AM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Greg Shah wrote:
> What do you mean by dynamic logging levels?
@LOG.setLevel()@ called programmatically.
- 09:10 AM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Galya Bogdanova wrote:
> Greg Shah wrote:
> > > disable dynamic levels on the client
> >
> > No, I don't think w... - 09:10 AM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- At this time we assume that the same logging levels will apply to all contexts. Even in the future where we have imp...
- 09:07 AM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Greg Shah wrote:
> > disable dynamic levels on the client
>
> No, I don't think we need to do that.
So allow d... - 09:05 AM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Greg Shah wrote:
> > So any static initializers setting levels will work once for the lifespan of the server JVM and... - 08:58 AM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- > It's not the same, because you can set multiple logging levels in the client configs and then change them programma...
- 08:45 AM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- OK, so implement context-local CentralLogger, configured by directory.xml, but with initial overrides from client.xml...
- 08:36 AM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Greg Shah wrote:
> > The client.xml logging level configs will override the server ones? But the server ones are dyn... - 08:20 AM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- > > The idea is that there are 2 modes for logging: server-side and client-side.
>
> How do I know if the client i... - 08:07 AM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Actually if it was a new software (more web oriented) that was developed, I would suggest if customers want to use re...
- 08:00 AM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Galya Bogdanova wrote:
> Greg Shah wrote:
> > The idea is that there are 2 modes for logging: server-side and clien... - 07:52 AM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Greg Shah wrote:
> The idea is that there are 2 modes for logging: server-side and client-side.
How do I know if ... - 07:37 AM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- > Do I remove all client to server log writes?
No. The idea is that there are 2 modes for logging: server-side an... - 03:07 AM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Galya Bogdanova wrote:
> Since we just removed the client-side configurations for logging I guess I have to introduc... - 02:56 AM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Greg, I'll wait for your confirmation.
Constantin Asofiei wrote:
> Galya Bogdanova wrote:
> > I feel I still don... - 02:55 AM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Greg Shah wrote:
> Galya Bogdanova wrote:
> > The current design is that client and server logging levels are indep... - 02:28 AM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Galya Bogdanova wrote:
> I feel I still don't understand something:
>
> 1. What do I use state sync for, when the... - 01:51 AM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Greg Shah wrote:
> * server-side logging is configured
> ** this would be configured similar to the rest of #4065
... - 01:48 AM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- I feel I still don't understand something:
1. What do I use state sync for, when the client and server loggers are... - 10:37 AM Base Language Feature #4065: server-side processing of client platform dependencies
- Greg Shah wrote:
> The initial support was put in as branch 3821c revision 13885/13886.
Ah, I see... it should be... - 10:36 AM Base Language Feature #4065: server-side processing of client platform dependencies
- Constantin Asofiei wrote:
> When a 3821c revision is mentioned, that is a trunk revision. 3821c became trunk some ti... - 10:34 AM Base Language Feature #4065: server-side processing of client platform dependencies
- Galya Bogdanova wrote:
> Greg Shah wrote:
> > But you can look at the existing code for the model.
> If I don't kn... - 10:33 AM Base Language Feature #4065: server-side processing of client platform dependencies
- Greg Shah wrote:
> But you can look at the existing code for the model.
If I don't know the revision, how do I know... - 10:32 AM Base Language Feature #4065: server-side processing of client platform dependencies
- The initial support was put in as branch 3821c revision 13885/13886.
Additional support is written in 4065a but ha... - 10:30 AM Base Language Feature #4065: server-side processing of client platform dependencies
- Galya Bogdanova wrote:
> There is no email @merge notification for task branch 4065@ and no comment which revision i... - 10:25 AM Base Language Feature #4065: server-side processing of client platform dependencies
- There is no email @merge notification for task branch 4065@ and no comment which revision it was on trunk. How do I f...
- 09:20 AM Base Language Feature #4065: server-side processing of client platform dependencies
- Thank you for the help. I'll find the configs now on trunk.
- 09:02 AM Base Language Feature #4065: server-side processing of client platform dependencies
- Take a look at the library manager support (or memptr) in trunk.
- 08:38 AM Base Language Feature #4065: server-side processing of client platform dependencies
- When a client process accesses the server, how do you know if its a local client (on the same host) or a remote one w...
- 10:23 AM Database Bug #7185: H2 in-memory lazy hydration
- Rebased 7185a_h2 to trunk rev. 15. Not it is at rev. 20.
Committed 7185a_h2/rev. 21 including some extra optimizatio... - 08:15 AM Runtime Infrastructure Bug #7291: LOG-MANAGER to log on client-side
- Just document the file locking restriction for now.
- 07:57 AM Runtime Infrastructure Bug #7291: LOG-MANAGER to log on client-side
- Greg Shah wrote:
> Client side logging is much less likely to have more than one process writing to the same file. ... - 07:43 AM Runtime Infrastructure Bug #7291: LOG-MANAGER to log on client-side
- Create the minimum API which will be a new remote service exported from the client side. This will provide the remot...
- 02:39 AM Runtime Infrastructure Bug #7291: LOG-MANAGER to log on client-side
- *Initial state and facts on @LOG-MANAGER@ (@LegacyLogManagerImpl@):*
* lives server-side;
* receives some logs fr... - 01:57 AM Runtime Infrastructure Bug #7291 (Closed): LOG-MANAGER to log on client-side
04/20/2023
- 01:55 PM Base Language Bug #7193: READ-JSON is not supported for the "LONGCHAR" source type
- I've created a more complete test for inferring empty dynamic DATA-SET from JSON data w/o root element (#7193-27).
N... - 06:48 AM Base Language Bug #7193: READ-JSON is not supported for the "LONGCHAR" source type
- Ovidiu Maxiniuc wrote:
> Review of 7193a/14544.
> * @AbstractTempTable.java@: please set the number in H entry (21)... - 05:12 AM Base Language Bug #7193: READ-JSON is not supported for the "LONGCHAR" source type
- The task branch 7193a was rebased to the trunk/14543.
Pushed up to revision 14551. - 11:34 AM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Greg Shah wrote:
> > by default, FWD client logs to its own log files
>
> Do we ever need the client logs mixed i... - 11:32 AM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Please address these items before the code can be merged to trunk:
* Split client logging into its own log file in... - 11:29 AM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- In regard to all the communications noted in #5703-280, I never intended to have the client logging go into the serve...
- 11:21 AM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Greg, just to summarize, there are a few types of logging done in FWD:
# LOG-MANAGER logging
** this is the legacy ... - 10:28 AM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- *On 7th Feb*
1. #5703#note-23
Greg Shah said:
> 1. I don't think we want a separate client and server logging ... - 09:49 AM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Galya Bogdanova wrote:
> If I remember correctly the whole point of the task was to reduce the number of log files b... - 09:45 AM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- If I remember correctly the whole point of the task was to reduce the number of log files by merging them. I initiall...
- 09:45 AM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- > you wanted to have all client logs mixed in.
I don't recall wanting that. - 09:40 AM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Greg Shah wrote:
> Is it separate from the "server log"? If so, I think it is OK. This is the replacement for the ... - 09:35 AM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Is it separate from the "server log"? If so, I think it is OK. This is the replacement for the old @stderr@ output ...
- 09:23 AM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- This is what I mean. Actually the file name is misleading - it's client-side generated log, server-side saved to a file.
- 09:20 AM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- If you are talking about the output redirect, that would remain on the client side.
- 09:09 AM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Greg Shah wrote:
> Since this is related to @LOG-MANAGER@
What about FWD logging for these remote clients?
- 08:45 AM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Since this is related to @LOG-MANAGER@ and we just implemented support for @LOG-MANAGER@ to target a separate file, w...
- 08:43 AM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- The issue is related to @LOG-MANAGER@ where the 4GL code (or via command line) the customer can specify a client-side...
- 02:38 AM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- #5703#note-27
Greg Shah wrote:
> The equivalent system in OE is a single process. For this reason, we cannot caus... - 02:25 AM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- #5703#note-40
Greg Shah wrote:
> Whether it is recursion or deadlock, the state synch approach should work.
Fr... - 02:22 AM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- @Status report 01/13/2023@
Galya Bogdanova wrote:
> I'll need a few days to analyze what types of 4GL errors and ... - 01:54 AM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- (related to @LOG-MANAGER@) On 17th January I've sent you an email named @Status report 01/17/2023@ with an attachment...
- 01:38 AM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Greg Shah wrote:
> Galya Bogdanova wrote:
> > Greg, you make me worried extremely. Let me repeat what I've said (ho... - 07:42 AM Database Bug #7258 (Review): Optimize INDEX-INFORMATION with closed dynamic queries
- Committed fix to 7258a/rev. 14544. It is ready to merge.
I've run some regression tests and everything looks right.
... - 07:35 AM Database Bug #7252: Use direct-access to support for-each queries without WHERE and BY clauses
- Radu, can you please make a statistic in a dummy Java project for:
* 10,000 JDBC statements doing @select tt.* from ... - 07:14 AM Database Bug #7174 (Test): Resolve simple CAN-FIND statements faster
- This was merged in trunk as rev. 14523 and can be closed.
- 07:13 AM Database Bug #7165: Close multiplex scope using prepared statement
- This was merged in trunk as rev. 14523 and can be closed.
- 07:13 AM Database Bug #5306 (Test): AdaptiveQuery sets a found record into the buffer twice in dynamic mode
- This was merged in trunk as rev. 14523 and can be closed.
- 07:12 AM Database Feature #7060 (Test): Consider using wildcard selection to reduce SQL size
- This was merged in trunk as rev. 14523 and can be closed.
- 07:12 AM Database Feature #7062 (Test): Direct access to H2 internals to solve basic queries
- This was merged in trunk as rev. 14523 and can be closed.
- 04:56 AM Database Bug #7108: Simulate upper/rtrim directly in H2 using case specific columns
- Constantin Asofiei wrote:
> ETF testing is OK with 7108a rev 14543 and fwd-h2-1.20-7108a.jar
Good.
Greg, Eric:... - 04:35 AM Database Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...
- Maciej Zieniuk wrote:
> The @tests/dataset/TestXmlNodeType.cls@ have a line during the setup, which runs some other ...
04/19/2023
- 04:13 PM Base Language Bug #7193: READ-JSON is not supported for the "LONGCHAR" source type
- Igor Skornyakov wrote:
> As far as I understand the 7193a is not reabsed to lasterst trunk.
> > No, I've extracte... - 04:05 PM Base Language Bug #7193: READ-JSON is not supported for the "LONGCHAR" source type
- Vladimir Tsichevski wrote:
> Igor Skornyakov wrote:
>
> > The @{ "Customer": [ { "customerName": "John Smith", "... - 03:53 PM Base Language Bug #7193: READ-JSON is not supported for the "LONGCHAR" source type
- Igor Skornyakov wrote:
> The @{ "Customer": [ { "customerName": "John Smith", "customerNum": 10}, { "customerNam... - 03:48 PM Base Language Bug #7193: READ-JSON is not supported for the "LONGCHAR" source type
- Ovidiu Maxiniuc wrote:
> Review of 7193a/14544.
>
> Good job! A lot of code with adjustments for existing feature... - 03:36 PM Base Language Bug #7193: READ-JSON is not supported for the "LONGCHAR" source type
- Review of 7193a/14544.
Good job! A lot of code with adjustments for existing features. Here are some notes, most o... - 02:45 PM Base Language Bug #7193: READ-JSON is not supported for the "LONGCHAR" source type
- Vladimir Tsichevski wrote:
> I am running OEUnit fixture test class:
>
> [...]
>
> In this class a fixture is ... - 02:20 PM Base Language Bug #7193: READ-JSON is not supported for the "LONGCHAR" source type
- I am running OEUnit fixture test class:...
- 04:00 PM Database Bug #6812: fix FastFindCache to use a shared instance per persistent database
- Code review 6812a/14487:
Sorry for the delay in reviewing. A lot of changes have gone in to trunk in the meantime;... - 03:27 PM Database Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...
- Thanks Marian.
But I think i am doing something wrong.
The @tests/dataset/TestXmlNodeType.cls@ have a line during... - 06:27 AM Database Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...
- Marian Edu wrote:
> That one was moved in a different location under support folder only forgot to push the changes ... - 05:12 AM Database Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...
- Maciej Zieniuk wrote:
> I have few tests passing, but there are few which will definitively not run.
> As an exampl... - 02:04 PM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Galya Bogdanova wrote:
> Greg, you make me worried extremely. Let me repeat what I've said (hoping it's received on ... - 12:55 PM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Galya, @System.loadLibrary("p2j");@ in @ServerDriver.main@ will force any installation to require the p2j library add...
- 12:23 PM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- It's done and done in r14601. Please confirm it's done.
65 revisions later and 508 files updated, let's do it! - 11:48 AM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- -Constantin, what do I do with that last blocker:- Fixed it....
- 11:42 AM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Actually even before that, since it needs to be done only on the ServerDriver.
- 11:41 AM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Greg Shah wrote:
> If you have to implement the pid and it the library is not loaded, then do a late load of the nat... - 11:34 AM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Greg, you make me worried extremely. Let me repeat what I've said (hoping it's received on the other end many time al...
- 11:06 AM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Galya Bogdanova wrote:
> Greg, what do we do with the pid?
If you have to implement the pid and it the library is... - 11:03 AM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- > Also please understand that there is no @CentralLogerClient@ and @CentralLoggerServer@, but only @CentralLogger@. T...
- 10:13 AM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Greg, what do we do with the pid?
- 10:12 AM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Ok, r14598 removed workingDir from LOG-MANAGER as well. Now all is going to be dumped by default in the server launch...
- 10:09 AM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Galya Bogdanova wrote:
> What should be the default folder for @LegacyLogManager@?
If the logging directory is not ... - 10:07 AM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Galya Bogdanova wrote:
> The questions is how to know if in @CommonDriver#process@ on line 533 the library can be ac... - 09:59 AM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Constantin Asofiei wrote:
> Greg Shah wrote:
> > We might want to have an explicit step in the @StandardServer.boot... - 09:53 AM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Greg Shah wrote:
> We might want to have an explicit step in the @StandardServer.bootstrap()@ process.
>
> Hynek/... - 09:22 AM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- ...and appserver logs go to work dir, which is probably quite a server.
- 09:18 AM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Also please understand that there is no @CentralLogerClient@ and @CentralLoggerServer@, but only @CentralLogger@. The...
- 09:16 AM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Constantin Asofiei wrote:
> Galya Bogdanova wrote:
> > In OE logs go to work dir. In directory.xml you can configur... - 09:00 AM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Galya Bogdanova wrote:
> Greg Shah wrote:
> > > Where is @System.loadLibrary("p2j")@ called server-side, so that th... - 08:43 AM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Greg Shah wrote:
> > Where is @System.loadLibrary("p2j")@ called server-side, so that the native lib can be used to ... - 08:27 AM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- > Where is @System.loadLibrary("p2j")@ called server-side, so that the native lib can be used to access process id (r...
- 08:26 AM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- > If you think it's worth it to handle file writes and rotation manually for the sake of improved formatting of rotat...
- 08:16 AM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- *Changes in r14597:*
* Client @CentralLogger@ initialized after @LogicalTerminal#init()@ completion on the server an... - 05:57 AM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Any of above-mentioned specifiers will be available for customers to define in the name of the log file.
- 05:42 AM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Greg, if a formatted rotation number is needed for CentralLogger files, then a custom FileHandler (the core of the cu...
- 03:08 AM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Is it alright in general for @ThinClient.getChanges()@ to be executed before @LogicalTerminal.init()@? I mean do we n...
- 12:49 PM Database Bug #7108: Simulate upper/rtrim directly in H2 using case specific columns
- ETF testing is OK with 7108a rev 14543 and fwd-h2-1.20-7108a.jar
- 09:43 AM Database Bug #7138: Short circuit fake-update (update with a new value eqaul to the old value) in H2
- Alexandru Lungu wrote:
> Please address this review on *7138a_h2/rev.16* asap. Some of the points here are crucial f... - 07:09 AM Database Bug #7138: Short circuit fake-update (update with a new value eqaul to the old value) in H2
- Please address this review on *7138a_h2/rev.16* asap. Some of the points here are crucial for the performance tests t...
- 06:42 AM Conversion Tools Feature #6237 (Test): OEUnit support
- Please go ahead with the updates to the documentation.
- 05:54 AM Conversion Tools Feature #6237: OEUnit support
- Branch 6237a has been merged to trunk at revision 14541 and archived.
- 01:54 AM Conversion Tools Feature #6237: OEUnit support
- Vladimir Tsichevski wrote:
> Hynek Cihlar wrote:
> > Code review 6237a revisions 14602..14607. The changes look goo... - 06:41 AM Database Bug #7252 (WIP): Use direct-access to support for-each queries without WHERE and BY clauses
- 06:34 AM Database Feature #7066: Implement multi-table indexed query in H2
- I've committed to 7066a. rev. 14528 the following things:
* @use_index@ is now used only in multi-table scenarios an... - 05:22 AM Database Bug #7235: Avoid selecting all fields for an CAN-FIND sub-select
- I've attached a patch for the current issue.
When using the function *exists* and the first child is of type @SUBSEL...
04/18/2023
- 05:52 PM Base Language Feature #6422 (WIP): implement auditing support including AUDIT-POLICY and AUDIT-CONTROL
- 04:43 PM Database Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...
- I have few tests passing, but there are few which will definitively not run.
As an example, the @tests/dataset/TestA... - 03:55 PM Conversion Tools Feature #6237: OEUnit support
- Hynek Cihlar wrote:
> Code review 6237a revisions 14602..14607. The changes look good.
Just one minor fix in rev.... - 03:26 PM Conversion Tools Feature #6237: OEUnit support
- Code review 6237a revisions 14602..14607. The changes look good.
- 01:17 PM Conversion Tools Feature #6237: OEUnit support
- Greg Shah wrote:
> Do 2 and 3 have to be done before we merge?
Not necessary, the merge should not affect anythin... - 01:11 PM Conversion Tools Feature #6237: OEUnit support
- Do 2 and 3 have to be done before we merge?
- 12:54 PM Conversion Tools Feature #6237: OEUnit support
- Greg Shah wrote:
> What else is needed (review, testing, whatever) before this is ready for merge?
# Review the s... - 12:49 PM Conversion Tools Feature #6237 (Review): OEUnit support
- 6237a rebased to the latest trunk. Please, review.
- 12:31 PM Conversion Tools Feature #6237: OEUnit support
- What else is needed (review, testing, whatever) before this is ready for merge?
- 11:45 AM Conversion Tools Feature #6237: OEUnit support
- Vladimir Tsichevski wrote:
> The @prepareImpl@ calls:
>
> [...]
>
> the @cleanupImpl@ does the opposite:
>
... - 10:52 AM Conversion Tools Feature #6237: OEUnit support
- Hynek Cihlar wrote:
> > > @FWDEngineDescriptor@ doesn't pop the root transaction scope.
> You should call @Transa... - 01:50 AM Conversion Tools Feature #6237: OEUnit support
- Vladimir Tsichevski wrote:
> Hynek Cihlar wrote:
>
> > You should call @TransactionManager.popScope@ during the o... - 02:33 PM Conversion Tools Bug #7284 (Closed): undefined map var for standalone proxy generation
- 02:13 PM Conversion Tools Bug #7284: undefined map var for standalone proxy generation
- 7284a was merged to trunk 14539 and archived.
- 01:53 PM Conversion Tools Bug #7284: undefined map var for standalone proxy generation
- You can merge to trunk.
- 01:23 PM Conversion Tools Bug #7284: undefined map var for standalone proxy generation
- Greg Shah wrote:
> No objections. Please add a comment to explain that these maps are there to hide the ones in @an... - 12:30 PM Conversion Tools Bug #7284: undefined map var for standalone proxy generation
- Code Review Task Branch 7284a Revision 14539
No objections. Please add a comment to explain that these maps are t... - 11:59 AM Conversion Tools Bug #7284 (Review): undefined map var for standalone proxy generation
- 11:55 AM Conversion Tools Bug #7284: undefined map var for standalone proxy generation
- The @GenerateLegacyProxyOpenClient@ tool uses @annotations/legacy_services.xml@ to perform a minimal annotation of th...
- 11:48 AM Conversion Tools Bug #7284 (Closed): undefined map var for standalone proxy generation
- 11:31 AM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Nice! I stand corrected.
- 11:30 AM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Greg Shah wrote:
> I suspect your winner is not my winner. ;)
You underestimate my estimation. :) - 11:28 AM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- I suspect your winner is not my winner. ;)
Options 1 and 2 are performance killers so we cannot use them.
Optio... - 11:24 AM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- P.S. We'll also have to disable @setLevel()@ on clients.
- 11:21 AM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Greg,
I think we need to consider a few aspects with this global server-side logging level. With last minute chang... - 11:07 AM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Constantin, I reverted the loggers in the Json* classes to static, because I cannot reproduce the problem now, but I'...
- 11:04 AM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Galya Bogdanova wrote:
> Let's confirm: After @LogicalTerminal.init()@ is called *on the client*, then it's safe to ... - 10:54 AM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Greg Shah wrote:
> > Have you considered moving to another programming language - an event-driven, functional one - ... - 10:53 AM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- > Do you want separate levels for clients at all or one global level for all processes is enough?
A global level ... - 10:42 AM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Greg Shah wrote:
> This is similar to my listener idea. Design it with a static flag and then change the flag in th... - 10:37 AM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Or if I got it wrong and @LogicalTerminal.init()@ should be called on the server, then how do I push the init state t...
- 10:35 AM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Let's confirm: After @LogicalTerminal.init()@ is called *on the client*, then it's safe to send logs to be handled in...
- 10:30 AM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Another note, this code in @CentralLoggerClient@:...
- 10:26 AM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Galya Bogdanova wrote:
> Yes, I guess. There was no right synchronizer registered. The logs were not processed by @L... - 10:21 AM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- P.S. OE doesn't allow it (just by the way, again) - the freedom of deciding if you want and how you want a rotation n...
- 10:19 AM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Greg Shah wrote:
> I'm looking for the position in the filename to be controllable, not the number itself.
How will... - 10:15 AM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Galya Bogdanova wrote:
> I don't understand you. Do you want separate levels for clients at all or one global level ... - 10:14 AM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Greg Shah wrote:
> Galya Bogdanova wrote:
> > The current design is that client and server logging levels are indep... - 10:12 AM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Greg Shah wrote:
> What do you mean by "the separate spawner process"? I'm OK with implementing the flexible format... - 10:06 AM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Constantin Asofiei wrote:
> > 2. Constantin Asofiei wrote:
> > > @p2j.net.Protocol.applyChanges@ - this code:
> > ... - 09:37 AM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Galya Bogdanova wrote:
> The current design is that client and server logging levels are independent, so that the cl... - 09:34 AM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- > We can implement more flexible formatter for log records in a future task, when the separate spawner process is rem...
- 09:27 AM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- > why not calculate the real logging level (in a different field), cache it on the first isLoggable call, and invalid...
- 07:41 AM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Galya Bogdanova wrote:
1. Constantin Asofiei wrote:
> > p2j.main.StandardServer.boostrap - there is some commented ... - 06:24 AM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- *Changes in r14595:*
* JavaDoc added for @ClientCore.isNativeLayerInitialized@ and @NetResource.LOG@.
* Wrong log... - 05:12 AM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Constantin Asofiei wrote:
> So, why not calculate the real logging level (in a different field), cache it on the fir... - 04:09 AM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- @!IS_LOGGER_WORK_FINISHED.get()@ is a simple boolean check, while @isLoggable(level)@ is more complex method, no reas...
- 04:02 AM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Galya, I agree that string literals are kept on the constant pool, and do not pose a garbage-collection problem, but ...
- 04:01 AM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Constantin Asofiei wrote:
> You can add the client-specific code to @ClientDriver.start@ and leave here only this he... - 03:53 AM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Discussion from email:
On 4/18/23 10:37, Galya Bogdanova wrote:
> Constantin,
>
> I'm not asking about concaten... - 03:47 AM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Galya Bogdanova wrote:
> 2. Constantin Asofiei wrote:
> > @clientConfig/workingDir@ is for FWD clients. There is no... - 11:02 AM Base Language Bug #7247: Dataset:READ-XML does nothing
- Created task branch 7247a.
- 10:06 AM Database Bug #7185: H2 in-memory lazy hydration
- Committed 7185a_h2/rev. 19.
It includes optimization for @FWDDirectAccess.retrieveResponse@:
* If no record is ... - 09:58 AM Base Language Feature #6428: implement IS-LEAD-BYTE() built-in function
- Vladimir Tsichevski wrote:
> Greg Shah wrote:
> > > I think, the unit testing for the function can be done in the f... - 08:29 AM Base Language Feature #6428: implement IS-LEAD-BYTE() built-in function
- Greg Shah wrote:
> > I think, the unit testing for the function can be done in the form of JUnit5 Jupiter engine tes... - 08:25 AM Base Language Feature #6428: implement IS-LEAD-BYTE() built-in function
- > I think, the unit testing for the function can be done in the form of JUnit5 Jupiter engine tests at the Java level...
- 08:29 AM Database Bug #7108: Simulate upper/rtrim directly in H2 using case specific columns
- Constantin Asofiei wrote:
> Alexandru Lungu wrote:
> > Constantin, can you run the ETF tests with 7108a?
> OK, I'... - 07:20 AM Database Bug #7108: Simulate upper/rtrim directly in H2 using case specific columns
- Alexandru Lungu wrote:
> Constantin, can you run the ETF tests with 7108a?
OK, I'll do this. Is this for performa... - 06:51 AM Database Bug #7108: Simulate upper/rtrim directly in H2 using case specific columns
- Constantin, can you run the ETF tests with 7108a?
I rebased 7108a with trunk rev. 14537.
I rebased 7108a_h2 with F... - 07:36 AM Base Language Bug #7193: READ-JSON is not supported for the "LONGCHAR" source type
- Well, all tests passed.
Committed to 7193a/14544.
Please review.
Thank you. - 06:42 AM Base Language Bug #7193: READ-JSON is not supported for the "LONGCHAR" source type
- Igor Skornyakov wrote:
> Igor Skornyakov wrote:
> > However these additional testes reveal a strange problem with W... - 04:47 AM Base Language Bug #7193: READ-JSON is not supported for the "LONGCHAR" source type
- Igor Skornyakov wrote:
> However these additional testes reveal a strange problem with WRITE-XML for the PARENT-ID-R... - 04:51 AM Database Bug #7035 (WIP): Extract query parameters from statically converted FQL
- Eric Faulhaber wrote:
> Are we testing/profiling these changes only with H2, or with other database dialects as well...
04/17/2023
- 04:11 PM Base Language Feature #6428: implement IS-LEAD-BYTE() built-in function
- I think, the unit testing for the function can be done in the form of JUnit5 Jupiter engine tests at the Java level, ...
- 02:33 PM Conversion Tools Feature #6237: OEUnit support
- Hynek Cihlar wrote:
> You should call @TransactionManager.popScope@ during the opposite lifecycle phase of the cla... - 02:21 PM Conversion Tools Feature #6237: OEUnit support
- 6237a rebased to the latest trunk, #3827-275 and #3827-282 fixed in rev. 14603.
- 11:22 AM Base Language Bug #7193: READ-JSON is not supported for the "LONGCHAR" source type
- Fixed issues with READ-JSON for empty dynamic DATA-SET revealed by additional tests.
Committed to 7193a/14543.
Ho... - 03:32 AM Base Language Bug #7193: READ-JSON is not supported for the "LONGCHAR" source type
- Just noticed.
When running the attached test I see multiple message like this... - 10:43 AM Database Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...
- At this time we have a limitation in our conversion approach, such that we must list the entire referenced object gra...
- 10:31 AM Database Feature #4514 (WIP): run ProDataSet test suite in FWD and resolve any issues such that it works t...
- I have issues with conversion on @tests/dataset/@ and @dataset/@ - latest trunk on testcases and p2j repos.
The @fil... - 10:17 AM User Interface Bug #7280: Broken modality on HTML-BROWSER widget
- A modal window opened in the legacy handler of the OnWebMessageReceived sometimes doesn't show up as modal and the us...
- 10:17 AM User Interface Bug #7280 (New): Broken modality on HTML-BROWSER widget
- 09:55 AM Runtime Infrastructure Feature #7147: Make FWD log outputs consistent
- Galya Bogdanova wrote:
> Hynek Cihlar wrote:
> > Galya, I will appreciate if you can answer my question. Do you get... - 08:54 AM Runtime Infrastructure Feature #7147: Make FWD log outputs consistent
- Hynek Cihlar wrote:
> Galya, I will appreciate if you can answer my question. Do you get conflicts, which you can no... - 08:31 AM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- 5703a rebased on trunk r14536.
This is not a final response to all code review questions raised. Wait for more.
... - 04:15 AM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- The current design is that client and server logging levels are independent, so that the client doesn't have to read ...
- 08:07 AM Runtime Infrastructure Feature #7279: Enhance CentralLogger to support configurable LogFormatter
- Implement more flexible formatter for log records, configurable in directory.xml.
Currently one and the same forma... - 08:04 AM Runtime Infrastructure Feature #7279 (Closed): Enhance CentralLogger to support configurable LogFormatter
04/16/2023
- 02:35 AM Base Language Bug #7193: READ-JSON is not supported for the "LONGCHAR" source type
- Igor Skornyakov wrote:
> Added support for inferring empty dynamic DATA-SET from JSON data. Fixed support for PARENT...
04/15/2023
- 02:32 PM Base Language Bug #7247 (WIP): Dataset:READ-XML does nothing
- 02:31 PM Base Language Bug #7193 (Review): READ-JSON is not supported for the "LONGCHAR" source type
- Added support for inferring empty dynamic DATA-SET from JSON data. Fixed support for PARENT-ID-RELATION in WRITE-JSON...
- 12:19 PM Base Language Bug #7193: READ-JSON is not supported for the "LONGCHAR" source type
- I've encountered the following problem.
On inferring @DATA-SET@ from JSON data with @READ-JSON@ the @NESTED@ @DATA-R...
04/14/2023
- 01:02 PM Base Language Bug #7193: READ-JSON is not supported for the "LONGCHAR" source type
- Inferring empty dynamic DATA-SET from JSON data is mostly finished.
Committed to 7193a/14539.
The tables looks th... - 09:02 AM Base Language Feature #6422: implement auditing support including AUDIT-POLICY and AUDIT-CONTROL
- Please do the following:
* Review #6422 and the 4GL facilities it is intended to implement.
* Write testcases and... - 09:02 AM Base Language Feature #6420: implement the AUDIT-ENABLED() built-in function
- This is meant to report on whether the 4GL-compatible auditing support is activated. That means it is dependent upon...
- 07:24 AM Database Feature #4516: testing and completion of runtime compatibility for table/table-handle/dataset/dat...
- Marian: What work is needed to complete these tests? What is the status of the existing tests for table/table-handle...
- 07:21 AM Database Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...
- The tests are in [[p2j:Testcases]] under the @tests/dataset/@ directory (for the ones already migrated to ABLUnit) an...
04/13/2023
- 05:17 PM Base Language Feature #6420 (WIP): implement the AUDIT-ENABLED() built-in function
- 04:52 PM Base Language Feature #6420: implement the AUDIT-ENABLED() built-in function
- How should we implement this feature? Should we just add a flag into @directory/client.xml@ or should we replicate th...
- 12:26 PM Runtime Infrastructure Feature #7147: Make FWD log outputs consistent
- Hynek Cihlar wrote:
> Galya Bogdanova wrote:
> > Greg, did you allow Hynek to merge the changes to LogHelper? Hynek... - 03:58 AM Runtime Infrastructure Feature #7147: Make FWD log outputs consistent
- Hynek Cihlar wrote:
> Galya Bogdanova wrote:
> > Greg, did you allow Hynek to merge the changes to LogHelper? Hynek... - 03:57 AM Runtime Infrastructure Feature #7147: Make FWD log outputs consistent
- Galya Bogdanova wrote:
> Greg, did you allow Hynek to merge the changes to LogHelper? Hynek, please revert all chang... - 03:34 AM Runtime Infrastructure Feature #7147: Make FWD log outputs consistent
- Greg, did you allow Hynek to merge the changes to LogHelper? Hynek, please revert all changes related to logging.
- 11:54 AM Database Bug #7035: Extract query parameters from statically converted FQL
- Are we testing/profiling these changes only with H2, or with other database dialects as well? I am concerned that wha...
- 05:06 AM Database Bug #7035: Extract query parameters from statically converted FQL
- Alexandru Lungu wrote:
> Danut, please constrain the changes to target only a specific sub-set of query parameters f... - 11:00 AM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Constantin Asofiei wrote:
> Galya Bogdanova wrote:
> > First of all it's dynamic, because all logging is allowed be... - 08:58 AM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Hynek Cihlar wrote:
> We could provide an invalidation mechanism:
>
> [...]
>
> Is it worth the hassle? I'm no... - 08:57 AM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Constantin Asofiei wrote:
> When is pre-initialization finished? At FWD server startup (when "Server ready" is writt... - 08:47 AM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Galya, another question for review: FWD trunk has a @logging/loggers@ setting in directory.xml where you can specify ...
- 08:45 AM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- We could provide an invalidation mechanism:...
- 08:37 AM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Galya Bogdanova wrote:
> Everything happening on the system before the configs are read and applied to CentralLogger... - 08:36 AM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Constantin Asofiei wrote:
> But the code I'm referring to is not part of initialization; when @RuntimeJastInterprete... - 08:34 AM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Galya Bogdanova wrote:
> This is Java logger functionality and as I've said we're doing dynamic isLogging, because o... - 08:32 AM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- This is Java logger functionality and as I've said we're doing dynamic isLogging, because of the delayed initialization.
- 08:31 AM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Galya Bogdanova wrote:
> First of all it's dynamic, because all logging is allowed before initialization for the sak... - 08:29 AM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Constantin Asofiei wrote:
> p2j.main.ClientSpawner.spawn - there is CentralLoggerServer.logSpawnerStream after cb.lo... - 08:24 AM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Constantin Asofiei wrote:
> *Hynek*, please review the @ext/@ changes.
The changes are good.
- 08:23 AM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- First of all it's dynamic, because all logging is allowed before initialization for the sake of not loosing logs. The...
- 08:22 AM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- The flag cannot be cached and should not be cached, because it's dynamic.
- 08:21 AM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Galya Bogdanova wrote:
> @if (LOG.isLoggable(...))@ *should never be called any more* from performance stand point.
... - 08:20 AM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Lets take this code from @RuntimeJastInterpreter.buildTypedExpression@:...
- 08:15 AM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Let me repeat just to make sure I'm understood: @isLoggable@ is the first statement in the log methods.
- 08:13 AM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- I had to remove isLoggable actually, but it was too much work. For very heavy log messages use the method overload wi...
- 08:11 AM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- @if (LOG.isLoggable(...))@ *should never be called any more* from performance stand point. Only in cases of very comp...
- 07:55 AM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- This is a review of the full changes in 5703a/14583. What is noted in #5703-182 still stands. Galya, please read th...
- 10:38 AM User Interface Feature #3931: single sign-on for virtual desktop mode
- Galya Bogdanova wrote:
> Are these all the resources that are OS user specific:
> [...]
None of them relate to O... - 10:37 AM User Interface Feature #3931: single sign-on for virtual desktop mode
- > Can you give me pointers on what parts of the application are currently isolated by the OS users (maybe a few class...
- 10:33 AM User Interface Feature #3931: single sign-on for virtual desktop mode
- Virtual Desktop Mode:
!hotel_gui_add_reservation_virtual.png!
Notice how we create a kind of "desktop" in the b... - 07:34 AM User Interface Feature #3931: single sign-on for virtual desktop mode
- Are these all the resources that are OS user specific:...
- 06:02 AM User Interface Feature #3931: single sign-on for virtual desktop mode
- Can you give me pointers on what parts of the application are currently isolated by the OS users (maybe a few classes...
- 04:55 AM User Interface Feature #3931: single sign-on for virtual desktop mode
- Galya Bogdanova wrote:
> What is virtual desktop mode?
The FWD Web clients; in GUI mode, there is a virtual desktop... - 04:53 AM User Interface Feature #3931: single sign-on for virtual desktop mode
- What is virtual desktop mode?
- 08:23 AM Conversion Tools Feature #6237 (WIP): OEUnit support
- Hynek Cihlar wrote:
> You should call @TransactionManager.popScope@ during the opposite lifecycle phase of the cla... - 08:08 AM Conversion Tools Feature #6237: OEUnit support
- Vladimir Tsichevski wrote:
> Hynek Cihlar wrote:
> > Code review 6237a.
> >
> > @FWDEngineDescriptor@ doesn't po... - 07:18 AM Conversion Tools Feature #6237: OEUnit support
- Vladimir Tsichevski wrote:
> At the moment I cannot reproduce the situation with too many log messages though, so ... - 07:14 AM Conversion Tools Feature #6237: OEUnit support
- Hynek Cihlar wrote:
> Code review 6237a.
>
> @FWDEngineDescriptor@ doesn't pop the root transaction scope.
Pleas... - 06:08 AM Conversion Tools Feature #6237: OEUnit support
- Code review 6237a.
@FWDEngineDescriptor@ doesn't pop the root transaction scope.
In @UnitTestServer@ the @NoCla... - 08:00 AM Database Feature #7066: Implement multi-table indexed query in H2
- Alexandru Lungu wrote:
> * In @Select.queryFlat@, I think it is best to rename @nonReversedOrder@ to @reversedOrder@... - 06:49 AM Database Bug #7185: H2 in-memory lazy hydration
- Committed 7185a/rev. 14533:
* Optimized @TempRecord.fallback@ usage. Redone the profile and got to +0.25% performa...
04/12/2023
- 02:14 PM Base Language Bug #7272: RUN ... NO-ERROR must log the 'missing.p was not found' message, always.
- This bug already exists in trunk, it came up in a discussion when debugging a customer's application.
- 02:12 PM Base Language Bug #7272: RUN ... NO-ERROR must log the 'missing.p was not found' message, always.
- I mentioned 'log' in the title and previous entry, but this is also about displaying the error message to the user. ...
- 02:00 PM Base Language Bug #7272: RUN ... NO-ERROR must log the 'missing.p was not found' message, always.
- This program:...
- 01:53 PM Base Language Bug #7272 (Closed): RUN ... NO-ERROR must log the 'missing.p was not found' message, always.
- 11:01 AM Database Bug #7185 (WIP): H2 in-memory lazy hydration
- My profiling session shown a +0.7% performance decrease. This is bad.
* My first concern here is the @extractCurre... - 06:30 AM Database Bug #7185: H2 in-memory lazy hydration
- Alexandru Lungu wrote:
> Danut please review. I will start the profiling session asap. I would like to know the perf... - 05:56 AM Database Bug #7185 (Review): H2 in-memory lazy hydration
- *Fixed regressions in 7185a_h2/rev. 18 and 7185a/rev. 14532*
* In H2, the cursors were not properly initialized to... - 10:50 AM Conversion Tools Feature #6237: OEUnit support
- 6237a rebased to trunk rev. 14532, the revision is 14595. Please, review.
- 10:33 AM Database Bug #7035: Extract query parameters from statically converted FQL
- I am OK with the fix. However, my last profile session shown a +0.2% performance decrease with 7035a. I don't think i...
- 10:23 AM Database Feature #7066: Implement multi-table indexed query in H2
- Radu, please make an update on #7066. AFAIK, you are planning to integrate the #7194 changes into 7066a and deliver b...
- 09:58 AM Testing Feature #3704: enable automated testing for GUI (Swing and web clients)
- [[p2j:Automating GUI Testing]] is our guidance on how best best to write Sikiuli tests.
04/11/2023
- 01:36 PM Database Bug #7258: Optimize INDEX-INFORMATION with closed dynamic queries
- I have reviewed @fix_7258.patch@. I think it works exactly how was described in previous notes.
As an optimization... - 07:37 AM Database Bug #7258 (WIP): Optimize INDEX-INFORMATION with closed dynamic queries
- Attached the fix. I used a flag to mark that the query was executed already. This flag is reset on query close. Pleas...
- 11:10 AM Conversion Tools Feature #6237: OEUnit support
- Hynek Cihlar wrote:
> Vladimir, there are issues with 6237a.
> * It is based on old trunk revision.
May be so
> *... - 11:02 AM Conversion Tools Feature #6237: OEUnit support
- Vladimir, there are issues with 6237a.
* It is based on old trunk revision.
* It is based on 3827a.
* And it is ba... - 10:13 AM Database Bug #7185: H2 in-memory lazy hydration
- Alexandru Lungu wrote:
> Committed 7185a/rev. 14531: small fixes. Danut, please review.
> I am close to finding th... - 09:59 AM Database Bug #7185: H2 in-memory lazy hydration
- Committed 7185a/rev. 14531: small fixes. Danut, please review.
I am close to finding the regression we are chasing f... - 09:55 AM Database Bug #7108: Simulate upper/rtrim directly in H2 using case specific columns
- I am OK with the current implementation. This should be tested and merged into trunk.
- 08:10 AM Database Bug #7108: Simulate upper/rtrim directly in H2 using case specific columns
- Alexandru Lungu wrote:
> In @FQLPreprocessor@, please keep the @simplifyCiProperties@ guard. Otherwise, we risk a fu... - 04:40 AM Database Bug #7108: Simulate upper/rtrim directly in H2 using case specific columns
- *Review to 7108a/rev.14528*
The changes are good. Last note to address before attempting to do a full test round a... - 07:56 AM Database Bug #7267: CompoundQuery FOR FIRST, EACH only retrieves the first record found
- Constantin Asofiei wrote:
> Danut: the patch would be this, please test it, in CompoundQuery$Optimizer.isServerJoinP... - 07:43 AM Database Bug #7267: CompoundQuery FOR FIRST, EACH only retrieves the first record found
- Danut: the patch would be this, please test it, in @CompoundQuery$Optimizer.isServerJoinPossible@ - the point is, a N...
- 07:43 AM Database Bug #7267: CompoundQuery FOR FIRST, EACH only retrieves the first record found
- Eric: this looks like the same #7229 problem.
- 07:41 AM Database Bug #7267: CompoundQuery FOR FIRST, EACH only retrieves the first record found
- There is a problem with CompoundQuery where using FOR FIRST, EACH will only return the first record available, ignori...
- 07:30 AM Database Bug #7267 (Test): CompoundQuery FOR FIRST, EACH only retrieves the first record found
- 07:17 AM Database Bug #7138: Short circuit fake-update (update with a new value eqaul to the old value) in H2
- *Committed 7138a_h2/rev.16*. Made changes to should-circuit fake-updates. @TestCompatibility@ change is related to #7...
- 07:17 AM Database Feature #6444: dataset improvements
- Eric Faulhaber wrote:
> Code review 6444b/14528:
>
> Only the "old" @Persistence.scroll@ and @Persistence.list@ m... - 05:53 AM Database Feature #6444: dataset improvements
- Code review 6444b/14528:
Only the "old" @Persistence.scroll@ and @Persistence.list@ methods with the @public@ acce...
04/10/2023
- 10:53 AM Base Language Feature #7126: replace 'new unknown()' with 'unknown.INSTANCE' in FWD conversion and runtime
- This task isn't a priority right now.
- 10:49 AM Base Language Feature #7126: replace 'new unknown()' with 'unknown.INSTANCE' in FWD conversion and runtime
- Constantin Asofiei wrote:
> > # calling the @unknown.instantiateUnknown()@, this function just returns the @unknow... - 10:45 AM Base Language Feature #7126: replace 'new unknown()' with 'unknown.INSTANCE' in FWD conversion and runtime
- Vladimir Tsichevski wrote:
> I can take this task.
Greg?
> # calling @new unknown()@, we want to get rid of thi... - 10:02 AM Base Language Feature #7126: replace 'new unknown()' with 'unknown.INSTANCE' in FWD conversion and runtime
- I can take this task.
A question: currently there is 3 ways to obtain the @unknown@ value:
# calling @new unkno... - 09:43 AM Conversion Tools Feature #6237 (Review): OEUnit support
- Vladimir Tsichevski wrote:
> Fixture feature implemented.
>
> The branch is 6237a, revision 14583.
> What else... - 08:31 AM Database Feature #6444 (Review): dataset improvements
- Greg Shah wrote:
> The application Sergey is talking about has no datasets, no data relations. I would expect that ... - 07:09 AM Database Feature #6444: dataset improvements
- Greg Shah wrote:
> The application Sergey is talking about has no datasets, no data relations. I would expect that ... - 07:05 AM Database Feature #6444: dataset improvements
- The application Sergey is talking about has no datasets, no data relations. I would expect that usage of those APIs ...
- 07:03 AM Database Feature #6444: dataset improvements
- From Igor:
> An additional DataRelation parameter is used only for the second pass of the FILL operation. In all o... - 07:02 AM Database Feature #6444: dataset improvements
- From Sergey, in regard to the merged changes from 6444a:
> It seems @<customer_application_with_hand_coded_persist... - 08:24 AM Base Language Bug #7250 (Closed): PROMPT-FOR with a table field reference resolves to NO-REFERENCE in OpenEdge
- 07:55 AM Base Language Bug #7250: PROMPT-FOR with a table field reference resolves to NO-REFERENCE in OpenEdge
- 7199b/14533 was merged to trunk rev 14528 and archived.
- 08:23 AM Base Language Bug #7243 (Closed): collision between YEAR function and a perm table abbreviated name
- 07:55 AM Base Language Bug #7243: collision between YEAR function and a perm table abbreviated name
- 7199b/14533 was merged to trunk rev 14528 and archived.
- 08:23 AM Base Language Bug #7240 (Closed): conversion problem related to ENTERED in a IF expr
- 07:55 AM Base Language Bug #7240: conversion problem related to ENTERED in a IF expr
- 7199b/14533 was merged to trunk rev 14528 and archived.
04/07/2023
- 06:23 PM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- > Greg, I recall we wanted to keep the com.goldencode. packages as non-dependent on com.goldencode.p2j as possible. I...
- 12:58 PM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Constantin Asofiei wrote:
> [...]
> can call back to the server, determine the Session ID and the FWD User, and cac... - 11:49 AM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- This is a high-level review of 5703a/14578 - I have not gone through all the files. I'll go over all files in the ne...
- 10:49 AM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- How does disabling @LOG-MANAGER@ come into this discussion of the server log? If it can be disabled in 5 ways, that ...
- 10:31 AM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Greg, on my interview you said you're reproducing OE with the typos and all its flaws.
- 10:30 AM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Greg Shah wrote:
> I don't see why @LOG-MANAGER@ output would ever end up in the server log.
All System.err does ... - 10:26 AM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Greg Shah wrote:
> As far as "disabling" @LOG-MANAGER@, I guess you mean calling @CLOSE-LOG()@?
There are 5 differ... - 10:22 AM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- > So you're suggesting that we know what log is written to clientlog and not write it to server.log?
I don't know ... - 10:11 AM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- > Add the empty thread id
Why is it empty?
> Is this what needs to be done?
If this is the list of deviation... - 10:09 AM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Greg Shah wrote:
> > @clientlog@ lives its own 4GL life, let's not enhance it.
>
> You are suggesting that we imp... - 10:06 AM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Greg Shah wrote:
> > There is this dir config (logging:file:dir) you might have noticed that allows you to choose th... - 10:04 AM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Greg Shah wrote:
> ** Legacy spec for @LOG-MANAGER@ output which should be completely compatible with the 4GL spec. ... - 10:03 AM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- > @clientlog@ lives its own 4GL life, let's not enhance it.
You are suggesting that we implement a 2nd logfile for... - 10:01 AM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- > There is this dir config (logging:file:dir) you might have noticed that allows you to choose the location. The old ...
- 09:44 AM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Greg Shah wrote:
> If @clientLog@ is specified, then won't we output everything to that log?
>
> This points out ... - 09:38 AM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Greg Shah wrote:
> * Use the @Formatter@ conversions as much as possible and add consistent formatting options for s... - 09:30 AM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Greg Shah wrote:
> For example, people have very different ideas about how date and time values should be formatted.... - 09:20 AM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Greg Shah wrote:
> In the old internal logging approach in FWD, we could configure logging at any class or package l... - 09:00 AM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- > At the moment there are two base log levels to be configured - one for the spawner messages and one for everything ...
- 08:20 AM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Constantin Asofiei wrote:
> Does 5703a depend on any work from 5753d?
No - 08:20 AM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Does 5703a depend on any work from 5753d?
- 02:26 PM Database Bug #7258: Optimize INDEX-INFORMATION with closed dynamic queries
- Well, the listener was added exactly for this reason, to invoke the @execute()@ method later, asynchronously from pre...
- 04:12 AM Database Bug #7258: Optimize INDEX-INFORMATION with closed dynamic queries
- Ovidiu Maxiniuc wrote:
> Rather it seems to me that the @getDelegate().notifyQueryOpenListeners(false);@ is not call... - 09:58 PM Database Bug #7258: Optimize INDEX-INFORMATION with closed dynamic queries
- Alexandru Lungu wrote:
> Ovidiu, OFC, we can't mark the query as opened to avoid this. Can we at least short-circuit... - 08:39 AM Database Feature #7194 (WIP): Avoid generating an ORDER-BY clause if not required
- 02:10 AM Database Feature #6995 (Closed): possibly support NO-UNDO temporary tables directly in H2
04/06/2023
- 10:46 AM Base Language Feature #4065: server-side processing of client platform dependencies
- Greg/Hynek: for server-side memptrs, we still have the problem when the memory address is incoming from a OS library ...
- 10:22 AM Conversion Tools Support #7257: Should deploy.prepare delete all contents of deploy/lib/ before copying?
- I have been using some varieties of the below description in some applications' @server.sh@ and/or @client.sh@ such t...
- 07:05 AM Conversion Tools Support #7257: Should deploy.prepare delete all contents of deploy/lib/ before copying?
- Greg Shah wrote:
> I prefer the first option.
Yes, that is the cleaner way.
- 07:04 AM Conversion Tools Support #7257: Should deploy.prepare delete all contents of deploy/lib/ before copying?
- I think we need to handle customer libs more explicitly.
* Isolate them into their own static directory. OR
* Ad... - 06:54 AM Conversion Tools Support #7257: Should deploy.prepare delete all contents of deploy/lib/ before copying?
- Cleaning up the entire @deploy/lib@ at @deploy.prepare@ will remove any customer-specific jars (like for web apps run...
- 06:49 AM Conversion Tools Support #7257: Should deploy.prepare delete all contents of deploy/lib/ before copying?
- When we change jar files to move to new versions, we get into a scenario where a @deploy.prepare@ leaves multiple ver...
- 06:45 AM Conversion Tools Support #7257 (New): Should deploy.prepare delete all contents of deploy/lib/ before copying?
- 10:04 AM Runtime Infrastructure Bug #5703 (Review): rationalize, standardize and simplify the client-side log file name configura...
- Branch 5703a, r14578 based on trunk r14523. Review with @bzr diff -r-56@. More on how to test in #5703#note-161.
- 08:21 AM Conversion Tools Feature #6237: OEUnit support
- Fixture feature implemented.
The branch is 6237a, revision 14583.
This branch includes (and relies upon) unpubl... - 07:45 AM Runtime Infrastructure Bug #5701 (Closed): logfile names for -O outputToFile use the spawner pid instead of the Java (FW...
- 07:37 AM Database Feature #7194: Avoid generating an ORDER-BY clause if not required
- I've added in @PreselectQuery@ a function that checks if the query will retrieve a unique finding. If so, then no @OR...
- 07:34 AM Database Bug #7108: Simulate upper/rtrim directly in H2 using case specific columns
- *Committed 7108a/rev.14528*. Removed @isAutoRtrimAndCi@ and replaced it with @isAutoRtrim and isAutoCi@.
I think tha... - 03:23 AM Database Bug #7108: Simulate upper/rtrim directly in H2 using case specific columns
- Ovidiu Maxiniuc wrote:
> Historically speaking (in P2J/FWD terms), the @rtrim@ and @upper@ were handled together bec... - 08:45 PM Database Bug #7108: Simulate upper/rtrim directly in H2 using case specific columns
- Alexandru Lungu wrote:
> Ovidiu Maxiniuc wrote:
> > Dănuț Filimon wrote:
> > Note that, for the moment, only Maria... - 07:16 AM Database Bug #7258: Optimize INDEX-INFORMATION with closed dynamic queries
- I profiled the @INDEX-INFORMATION@ implementation in FWD on a POC that runs in ~10.000ms. ~10ms are spent inside @IND...
- 07:00 AM Database Bug #7258 (Closed): Optimize INDEX-INFORMATION with closed dynamic queries
- 04:36 AM Database Bug #7185: H2 in-memory lazy hydration
- Alexandru Lungu wrote:
> Radu, can you please check-out 7185a and test it against adaptive-scrolling/non-scrolling t...
04/05/2023
- 04:04 PM Base Language Bug #7250 (Test): PROMPT-FOR with a table field reference resolves to NO-REFERENCE in OpenEdge
- Code Review Task Branch 7199b Revision 14529
No objection. - 04:02 PM Base Language Bug #7243 (Test): collision between YEAR function and a perm table abbreviated name
- Code Review Task Branch 7199b Revision 14526
No objection. - 04:02 PM Database Feature #6444: dataset improvements
- The changes in @expressions.rules@ do not affect the code generated by the conversion.
- 04:00 PM Database Feature #6444: dataset improvements
- Igor Skornyakov wrote:
> Ovidiu Maxiniuc wrote:
> > Review of 6444a/14552.
> >
> > @expressions.rules@: please u... - 03:45 PM Database Feature #6444: dataset improvements
- Ovidiu Maxiniuc wrote:
> Review of 6444a/14552.
>
> @expressions.rules@: please update the gap status for @KW_SYN... - 03:29 PM Database Feature #6444: dataset improvements
- Review of 6444a/14552.
@expressions.rules@: please update the gap status for @KW_SYNCHRON@ ("synchronize"), @KW_F_... - 02:11 PM Database Feature #6444: dataset improvements
- Updated history entries.
Committed to 6444a/14552.
Changes to the @rules/gaps/expressions.rules@ are also committed. - 02:25 AM Database Feature #6444: dataset improvements
- Branch 6444a was rebased to the trunk rev. 14525.
Pushed up to revision 14551.
- 03:55 PM Base Language Bug #7240 (Test): conversion problem related to ENTERED in a IF expr
- 03:55 PM Base Language Bug #7240: conversion problem related to ENTERED in a IF expr
- Code Review Task Branch 7199b Revisions 14524, 14527 and 14528
No objections. - 03:46 PM Database Feature #6453: temp-table features
- Merged to the trunk rev. 14526.
- 03:42 PM Base Language Feature #4065: server-side processing of client platform dependencies
- In regard to the shell commands, I think it is OK if we require that the commands meet one of these criteria:
* It... - 02:51 PM Base Language Feature #6428: implement IS-LEAD-BYTE() built-in function
- In 4GL, the CPINTERNAL attribute is rather a constant than a variable. It is configured when the application is execu...
- 12:37 PM Base Language Feature #6428: implement IS-LEAD-BYTE() built-in function
- I think we have this same problem for all of our I18N tests, many of which still need to be written.
> Because it... - 10:57 AM Base Language Feature #6428: implement IS-LEAD-BYTE() built-in function
- I've hit a wall here, as I misunderstood some Progress behaviour. During my initial exploration on the OpenEdge syste...
- 01:41 PM Database Support #6455: XML feature(s) needing testing
- Igor,
The revision 14552 is NOT visible in @devsrv01:/opt/secure/code/p2j_repo/p2j/active/6444a@.
Is it possible ... - 08:51 AM Database Support #6455: XML feature(s) needing testing
- Eric Faulhaber wrote:
> As part of your final cleanup of #6444, please update the gap marking in @expressions.rules@... - 04:20 AM Database Support #6455 (Closed): XML feature(s) needing testing
- As part of your final cleanup of #6444, please update the gap marking in @expressions.rules@ in branch 6444a to full ...
- 04:13 AM Database Support #6455: XML feature(s) needing testing
- Eric Faulhaber wrote:
> Thank you, Igor. It does appear that runtime support for READ-XMLSCHEMA was updated from par... - 04:08 AM Database Support #6455: XML feature(s) needing testing
- Igor Skornyakov wrote:
> Eric,
> I believe that it was completely implemented in #6444. At least I've tested this f... - 04:07 AM Database Support #6455: XML feature(s) needing testing
- Thank you, Igor. It does appear that runtime support for READ-XMLSCHEMA was updated from partial to basic in @rules/g...
- 03:47 AM Database Support #6455: XML feature(s) needing testing
- Eric Faulhaber wrote:
> Igor, is this issue already covered by the work you have done for #6444? If so, how complete... - 03:42 AM Database Support #6455: XML feature(s) needing testing
- Igor, is this issue already covered by the work you have done for #6444? If so, how complete is the support now for t...
- 12:51 PM Base Language Feature #6431: implement support to allow CPINTERNAL set to UTF-8 and CP936
- We have a customer that needs to be able to set UTF-8 or CP963 as the @CPINTERNAL@. We may have some problems with d...
- 12:43 PM Base Language Bug #4766: fix CHR and ASC
- What is left to do in this task? Please note that in #6428 Joe is fixing an issue related to lead-byte processing in...
- 11:11 AM Database Bug #7235 (WIP): Avoid selecting all fields for an CAN-FIND sub-select
- 10:45 AM Database Bug #7185: H2 in-memory lazy hydration
- I have troubles testing 7185a. One customer application works flawlessly, while the other in hanging right at the sta...
- 09:13 AM Database Bug #7185: H2 in-memory lazy hydration
- Rebased 7185a with trunk (rev. 14525). 7185a is now at 14530.
- 10:17 AM Base Language Feature #6425: SESSION handle features
- I created some tests under @testcases/session/session_features.p@. Please review.
- 09:47 AM Conversion Tools Bug #7255: FWD resolves a OO file not included in conversion, if it exists on disk and on PROPATH
- For an application, you can have a @abl/src1/oo/Bar.cls@ and @abl/src2/oo/Bar.cls@. In conversion, you include only ...
- 09:43 AM Conversion Tools Bug #7255 (Test): FWD resolves a OO file not included in conversion, if it exists on disk and on ...
- 09:01 AM Database Feature #7066: Implement multi-table indexed query in H2
- Tested 7066a against a customer application: most of the tests pass, but I have one that provides an unexpected outpu...
- 06:27 AM Database Feature #7066: Implement multi-table indexed query in H2
- Rebased 7066a with trunk rev. 14525. 7066a is now at rev. 14526.
Radu, please update 7066a and notify me if somethin... - 05:43 AM Database Feature #7066: Implement multi-table indexed query in H2
- *Review for 7066a_h2/rev. 14*
Most of the changes for #7066 are conceptually inside H2. I see that there are a lot... - 07:47 AM Database Bug #7108: Simulate upper/rtrim directly in H2 using case specific columns
- Note that the changes require reconversion of the application (or at least regeneration of DDL - convert.middle and j...
- 05:00 AM Database Bug #7108 (Test): Simulate upper/rtrim directly in H2 using case specific columns
- Alexandru Lungu wrote:
> Danut, please address this issue and I will move this to test.
Never mind. This is not c... - 04:17 AM Database Bug #7108: Simulate upper/rtrim directly in H2 using case specific columns
- I tested several applications:
* customer application POC - no regressions
* 2 customer application regression test... - 07:01 AM Base Language Feature #6410: implement additional built-in OO classes/interfaces
- Greg Shah wrote:
> Marian: Please summarize the current level of conversion support for all of the classes #6410-1. ... - 05:47 AM Database Bug #6458: ensure that OO expressions resolve to query substitution parameters, like handle-based...
- I think the issue is that we don't emit as lambda the OO expression. Take this test:...
- 03:24 AM Database Bug #6458: ensure that OO expressions resolve to query substitution parameters, like handle-based...
- Constantin, Greg informed me that you were concerned about certain OO expressions embedded in WHERE clauses not conve...
- 03:03 AM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- The following System.err usages are related to #7180:
* cmd line args -err, -warn in com.goldencode.p2j.preproc.Prep... - 01:35 AM Database Bug #6887: improve performance of dataset/table[-handle] parameters
- We should profile and check how #6887-3 test behaves now with FWD first.
- 12:06 AM Database Bug #6887: improve performance of dataset/table[-handle] parameters
- Constantin Asofiei wrote:
> This is the entire JMX result for the large application:
> [...]
>
> The 3 cases fro...
04/04/2023
- 03:43 PM Base Language Feature #4065 (Review): server-side processing of client platform dependencies
- 03:42 PM Base Language Feature #4065: server-side processing of client platform dependencies
- The server-side shell execution will require more thought. For the file system it is straightforward to get a canonic...
- 03:38 PM Base Language Feature #4065: server-side processing of client platform dependencies
- 4065a revision 14527 implements server side file-system and file-based stream (based on @FileStream@ and @DirStream@)...
- 12:37 PM Base Language Feature #6428: implement IS-LEAD-BYTE() built-in function
- Greg Shah wrote:
> No, you haven't missed anything. See #3827. The related code in 3827a is close to merging to tr... - 11:50 AM Base Language Feature #6411 (Closed): LOB-DIR I/O option support
- 3821c replaced trunk in trunk revision 14472 (we copied over trunk with 3821c rev 14472).
- 11:28 AM Base Language Feature #6411: LOB-DIR I/O option support
- Greg Shah wrote:
> In what revision of trunk can these changes be found?
>
It was in last commit of the @3821c@... - 10:55 AM Base Language Feature #6411: LOB-DIR I/O option support
- In what revision of trunk can these changes be found?
Are there any open items? - 10:36 AM Base Language Feature #6411 (Review): LOB-DIR I/O option support
- 10:36 AM Base Language Feature #6411 (WIP): LOB-DIR I/O option support
- 10:24 AM Base Language Feature #6411: LOB-DIR I/O option support
- Greg Shah wrote:
> Didn't we implement this recently?
Yes, we did. - 10:19 AM Base Language Feature #6411: LOB-DIR I/O option support
- Didn't we implement this recently?
- 10:33 AM Base Language Feature #6410: implement additional built-in OO classes/interfaces
- Marian: Please summarize the current level of conversion support for all of the classes #6410-1. We need all of thes...
- 10:11 AM Database Bug #7252: Use direct-access to support for-each queries without WHERE and BY clauses
- *4GL code:*...
- 09:57 AM Database Bug #7252 (WIP): Use direct-access to support for-each queries without WHERE and BY clauses
- 10:08 AM Base Language Feature #6300 (Closed): class definitions with USE-WIDGET-POOL
- 10:01 AM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Branch 5703a, r14573 is ready for a pre-final code review. There are still no file headers and I need to go through a...
- 09:38 AM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- It should be though that it's not in use any more. I'll remove it.
- 09:37 AM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- I will run the dependency tree generation and confirm my statement that no class is explicitly imported, but I'm aski...
- 09:36 AM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Roger Borrello wrote:
> How about @./gradlew dependencies@?
Thanks, I see only root references for @+--- org.jboss.... - 09:33 AM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Constantin Asofiei wrote:
> Roger, I can't find the build dependency tree for all the jar libraries - is this somewh... - 07:16 AM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- @fwdspi.jar@ doesn't include the logging classes and @FwdCollatorProvider@ fails runtime. I'm not sure how/when the c...
- 06:50 AM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Galya Bogdanova wrote:
> Does someone know why is this dependency in build.gradle: @fwdConvertServer group: 'org.jbo... - 06:46 AM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Does someone know why is this dependency in build.gradle: @fwdConvertServer group: 'org.jboss.logging', name: 'jboss-...
- 06:44 AM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Constantin Asofiei wrote:
> There is a script named @gen_headers.py@ in @~/usrbin@, as part of the standard dev setu... - 09:56 AM Base Language Bug #7250 (Review): PROMPT-FOR with a table field reference resolves to NO-REFERENCE in OpenEdge
- I've fixed this in 7199b/14529
- 09:33 AM Base Language Bug #7250: PROMPT-FOR with a table field reference resolves to NO-REFERENCE in OpenEdge
- Greg Shah wrote:
> The warning is because the code as written is useless.
It's not entirely useless - the customer'... - 09:15 AM Base Language Bug #7250: PROMPT-FOR with a table field reference resolves to NO-REFERENCE in OpenEdge
- The warning is because the code as written is useless. The user will go into edit mode, make changes and then the cha...
- 09:04 AM Base Language Bug #7250: PROMPT-FOR with a table field reference resolves to NO-REFERENCE in OpenEdge
- There is a weird behavior in OpenEdge. This test:...
- 09:02 AM Base Language Bug #7250 (Closed): PROMPT-FOR with a table field reference resolves to NO-REFERENCE in OpenEdge
- 06:56 AM Base Language Feature #6425: SESSION handle features
- Theodoros Theodorou wrote:
> The task is ready for review. Should I also create a test in testcases?
Yes, please do. - 06:32 AM Database Bug #7108: Simulate upper/rtrim directly in H2 using case specific columns
- Ovidiu Maxiniuc wrote:
> Dănuț Filimon wrote:
> Note that, for the moment, only MariaDb support this kind of charac... - 04:59 AM Database Bug #7108: Simulate upper/rtrim directly in H2 using case specific columns
- Rebased 7108a with trunk (rev. 14523). 7108a is now at rev. 14527.
- 06:06 AM Database Bug #7035 (Review): Extract query parameters from statically converted FQL
- *Committed 7035a/rev.14526*. This is a fix for #7035-24.
I found a similar problem on a customer application after ... - 04:14 AM Database Bug #7035: Extract query parameters from statically converted FQL
- Constantin Asofiei wrote:
> There is another peculiarity at least with PostgreSQL - @select '1' = 1;@ will show 'tru... - 03:18 AM Base Language Bug #7240: conversion problem related to ENTERED in a IF expr
- Another issue is related to @frame f1 ... not entered@ version - the fix is in 7199b/14528.
04/03/2023
- 05:09 PM Base Language Feature #6425: SESSION handle features
- The task is ready for review. Should I also create a test in testcases?
- 05:06 PM Base Language Feature #6425 (Review): SESSION handle features
- 04:53 PM Base Language Bug #7193: READ-JSON is not supported for the "LONGCHAR" source type
- Vladimir Tsichevski wrote:
> Igor, would you take a look at #7247, please. I think, both issues are closely related.... - 04:43 PM Base Language Bug #7193: READ-JSON is not supported for the "LONGCHAR" source type
- Igor, would you take a look at #7247, please. I think, both issues are closely related.
- 04:50 PM Base Language Bug #7247: Dataset:READ-XML does nothing
- Vladimir Tsichevski wrote:
> The test case is:
> [...]
>
> The test compiles and runs OK. But in FWD the @READ-X... - 04:40 PM Base Language Bug #7247: Dataset:READ-XML does nothing
- The test case is:...
- 04:36 PM Base Language Bug #7247 (Closed): Dataset:READ-XML does nothing
- 04:22 PM Base Language Bug #7184: Incorrect conversion of concatenated string literals to a LONGCHAR
- Constantin Asofiei wrote:
> I think the solution would be in literals.rules on line 371:
> to add a @!(isNote("wrap... - 10:34 AM Base Language Bug #7184: Incorrect conversion of concatenated string literals to a LONGCHAR
- Constantin Asofiei wrote:
> It means they are added by the parser. I assume you see other @byrule-@ annotations i... - 09:34 AM Base Language Bug #7184: Incorrect conversion of concatenated string literals to a LONGCHAR
- Vladimir Tsichevski wrote:
> Constantin Asofiei wrote:
>
> > OTOH, we should find who sets the @wrap@ annotation ... - 09:31 AM Base Language Bug #7184: Incorrect conversion of concatenated string literals to a LONGCHAR
- Constantin Asofiei wrote:
> OTOH, we should find who sets the @wrap@ annotation for the literal - did you convert ... - 09:12 AM Base Language Bug #7184: Incorrect conversion of concatenated string literals to a LONGCHAR
- The repo 7184a was created for the fix, and the regression test task #7245.
- 02:45 PM Base Language Feature #6428: implement IS-LEAD-BYTE() built-in function
- No, you haven't missed anything. See #3827. The related code in 3827a is close to merging to trunk. Vladimir is wr...
- 02:39 PM Base Language Feature #6428: implement IS-LEAD-BYTE() built-in function
- I had misread the current docs, and didn't use ABLUnit for tests (instead writing standalone tests). I'm in the proce...
- 10:22 AM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Galya Bogdanova wrote:
> There are changes in 486 files and more to come. Am I expected to update all file headers?
... - 10:18 AM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- There are changes in 486 files and more to come. Am I expected to update all file headers?
- 09:47 AM Database Bug #7035: Extract query parameters from statically converted FQL
- The H2 supports implicit conversion of @1 = '1'@, @'true' = true@ and even @'1' = true@. MariaDb will also return ret...
- 05:07 AM Database Bug #7035 (WIP): Extract query parameters from statically converted FQL
- Constantin Asofiei wrote:
> There is another peculiarity at least with PostgreSQL - @select '1' = 1;@ will show 'tru... - 07:42 AM Database Bug #7108: Simulate upper/rtrim directly in H2 using case specific columns
- Ovidiu Maxiniuc wrote:
> ... Indeed, both dialects (actually the character type on SQL side) handle both of these la... - 06:11 AM Base Language Feature #3853: implement LOG-MANAGER runtime
- @LOG-ENTRY-TYPES@ and @LOGGING-LEVEL@ are @LOG-MANAGER@ attributes that can be changed in the internal procedure runn...
- 05:34 AM Base Language Feature #3853: implement LOG-MANAGER runtime
- Appservers have the following logging configs in OE Explorer:
* srvrLogFile - by default @{WorkPath}\%appservername%... - 03:47 AM Base Language Feature #3853: implement LOG-MANAGER runtime
- Answering to #5753#note-113 :
Constantin Asofiei wrote:
> From this, we know:
> * changing @LOGFILE-NAME@ does n... - 01:41 AM Base Language Bug #7240: conversion problem related to ENTERED in a IF expr
- The fix is in 7199b/14527
04/02/2023
- 03:41 PM Base Language Bug #7240: conversion problem related to ENTERED in a IF expr
- There is another issue related to INPUT/ENTERED - fields need to be treated the same way as vars in @input_functions....
04/01/2023
- 08:28 AM Database Bug #7035: Extract query parameters from statically converted FQL
- There is another peculiarity at least with PostgreSQL - @select '1' = 1;@ will show 'true'. The same for @select 'tr...
- 04:57 AM Database Bug #7035: Extract query parameters from statically converted FQL
- The root cause seems to be an FQL like @tt1.f1 <> 0@ where @f1@ is an integer field. In this case, @0@ is extracted ...
Also available in: Atom