Project

General

Profile

Activity

From 05/31/2023 to 06/29/2023

06/29/2023

12:08 PM User Interface Feature #3931: single sign-on for virtual desktop mode
Yes, if we go that route. Let's get everything described and agreed first. Greg Shah
11:31 AM User Interface Feature #3931: single sign-on for virtual desktop mode
I want to create 4GL attr @AUTH-BLOB@, do we add it to @SESSION@ as well? Galya B
11:25 AM User Interface Feature #3931: single sign-on for virtual desktop mode
> How are hooks provided? I don't think we have dependency injection or event system built-in.
A class implementin...
Greg Shah
11:24 AM User Interface Feature #3931: single sign-on for virtual desktop mode
> The auth logic, where DB queries are done, should be part of FWD server?
It would be Java code that is written b...
Greg Shah
11:05 AM User Interface Feature #3931: single sign-on for virtual desktop mode
How are hooks provided? I don't think we have dependency injection or event system built-in. Galya B
10:42 AM User Interface Feature #3931: single sign-on for virtual desktop mode
The auth logic, where DB queries are done, should be part of FWD server? Galya B
10:39 AM User Interface Feature #3931: single sign-on for virtual desktop mode
> FWD hits the customer's auth server and gets response success, the fwd user and some session specific data, blob
...
Greg Shah
10:35 AM User Interface Feature #3931: single sign-on for virtual desktop mode
The most simple flow would be:
1. SSO Login screen is open
2. User/pass entered
3. FWD hits the customer's auth se...
Galya B
10:30 AM User Interface Feature #3931: single sign-on for virtual desktop mode
Greg Shah wrote:
> I don't see this as a separate service.
I think we speak about different things here. It's not...
Galya B
10:25 AM User Interface Feature #3931: single sign-on for virtual desktop mode
> All customers requesting sso login will have to provide authentication server - 3rd party integration that we suppo... Greg Shah
10:17 AM User Interface Feature #3931: single sign-on for virtual desktop mode
Continue from #7465.
Greg Shah wrote:
> We cannot require OAuth2 as part of this interface. We are providing sup...
Galya B
11:09 AM User Interface Feature #4853: implement support for reporting a device-id which is meant to identify a unique cl...
It's on hold.. Just to mention what was wrong with my idea: WebRTC changed the specification and doesn't expose the l... Galya B
10:21 AM Database Bug #7412: PresortQuery ORDER BY has to many clauses
Done, I committed the changes on 7026e, revision 14605. Ștefan Roman
06:14 AM Database Bug #7412: PresortQuery ORDER BY has to many clauses
This can be optimized a bit further:
* Avoid using .size() in for - precompute it in another variable.
* Use @Sor...
Alexandru Lungu
08:43 AM User Interface Feature #4129: map web client users to OS accounts
> Is @config/auth-plugins/option@ the way of defining FWD user for the web process? Its value is @bogus@ in testcases... Greg Shah
08:39 AM User Interface Feature #4129: map web client users to OS accounts
Add/remove/edit users and groups is in the admin UI. ACL add/remove/edit is also in the admin UI. Groups are subjec... Greg Shah
08:23 AM User Interface Feature #4129: map web client users to OS accounts
Also the FWD user @bogus@ is listed in @subjects@ in multiple @security/acl@ resources and I don't see a way to updat... Galya B
08:17 AM User Interface Feature #4129: map web client users to OS accounts
Is @config/auth-plugins/option@ the way of defining FWD user for the web process? Its value is @bogus@ in testcases, ... Galya B
07:16 AM Database Bug #7389: Make fast-copy statements cachable
Alexandru Lungu wrote:
> The changes are good. However, I think this is quite related to #7404. Danut, please move 7...
Dănuț Filimon
06:24 AM Database Bug #7389: Make fast-copy statements cachable
The changes are good. However, I think this is quite related to #7404. Danut, please move 7389a changes to 7404a - I ... Alexandru Lungu
05:58 AM Conversion Tools Feature #6237 (Closed): OEUnit support
> > Is there any reason to leave this task open?
>
> If we are all decided not to do anything with name collision ...
Greg Shah
05:36 AM Base Language Feature #4855 (Review): add a 4GL extension SESSION:SESSION-ID attribute which returns a UUID whi...
4855a r14634 for review Galya B
04:21 AM Database Bug #7454: Make ValueStringIgnoreCase the default generated value for setString in FWD-H2
*Committed 7454a_h2/rev.24* which adds the @OPTIMIZE_IGNORE_CASE@ database property, it is *false* by default.
I c...
Dănuț Filimon
03:14 AM Database Feature #7323: Implement soft unique index in FWD-H2
> I think we will need a statistic here. Radu, please feel free to count how many such cases actually occur in a cust... Alexandru Lungu

06/28/2023

05:20 PM Conversion Tools Feature #6237: OEUnit support
Greg Shah wrote:
> Is there any reason to leave this task open?
If we are all decided not to do anything with nam...
Vladimir Tsichevski
11:04 AM Database Feature #7323: Implement soft unique index in FWD-H2
Alexandru Lungu wrote:
> I really wonder now how often this case actually occurs.
Yes, without some statistics, I...
Eric Faulhaber
10:46 AM Database Feature #7323: Implement soft unique index in FWD-H2
> The purpose of confirmUniqueConstraintViolation: consider that we are validating record A, which is in the FWD serv... Alexandru Lungu
10:57 AM Base Language Feature #4855: add a 4GL extension SESSION:SESSION-ID attribute which returns a UUID which unique...
In this case, since we already have a keyword and we even have an attribute with that name, there are no changes need... Greg Shah
09:44 AM Base Language Feature #4855: add a 4GL extension SESSION:SESSION-ID attribute which returns a UUID which unique...
I want to know what I'm doing, but I don't. Galya B
09:42 AM Base Language Feature #4855: add a 4GL extension SESSION:SESSION-ID attribute which returns a UUID which unique...
> I was going with a similar, but not exactly the same keyword, so I'll stick with it.
I don't want to add a keywo...
Greg Shah
09:37 AM Base Language Feature #4855: add a 4GL extension SESSION:SESSION-ID attribute which returns a UUID which unique...
I was going with a similar, but not exactly the same keyword, so I'll stick with it. Galya B
09:36 AM Base Language Feature #4855: add a 4GL extension SESSION:SESSION-ID attribute which returns a UUID which unique...
If we reuse this keyword, @SESSION-ID@ will need to be extracted to its own interface, specific @handle.unwrap@ added... Constantin Asofiei
09:35 AM Base Language Feature #4855: add a 4GL extension SESSION:SESSION-ID attribute which returns a UUID which unique...
I expect we would use the same keyword. There is nothing wrong with that. Greg Shah
09:34 AM Base Language Feature #4855: add a 4GL extension SESSION:SESSION-ID attribute which returns a UUID which unique...
Ok, thanks for the explanations, it's just that the new keyword will be quite similar to the old one. Galya B
09:33 AM Base Language Feature #4855: add a 4GL extension SESSION:SESSION-ID attribute which returns a UUID which unique...
The @client-principal@ is a kind of 4GL based security-related token that identifies an authenticated identity. It i... Greg Shah
09:33 AM Base Language Feature #4855: add a 4GL extension SESSION:SESSION-ID attribute which returns a UUID which unique...
Galya B wrote:
> What is @client-principal:session-id@ https://docs.progress.com/bundle/abl-reference/page/SESSION-I...
Constantin Asofiei
09:06 AM Base Language Feature #4855: add a 4GL extension SESSION:SESSION-ID attribute which returns a UUID which unique...
What is @client-principal:session-id@ https://docs.progress.com/bundle/abl-reference/page/SESSION-ID-attribute.html#S... Galya B
09:40 AM Runtime Infrastructure Bug #7425: Avoid directory usage in static blocks
Alexandru Lungu wrote:
> > Although there is a field called loggingEnabled in P2JQueryLogger, it is not actually use...
Radu Apetrii
09:24 AM Runtime Infrastructure Bug #7425: Avoid directory usage in static blocks
> Although there is a field called loggingEnabled in P2JQueryLogger, it is not actually used, because P2JQueryExecuto... Alexandru Lungu
08:58 AM Runtime Infrastructure Bug #7425: Avoid directory usage in static blocks
Alexandru Lungu wrote:
> Radu, please check @P2JQueryLogger@. I feel like I've mismatched something in it while reba...
Radu Apetrii
04:31 AM Runtime Infrastructure Bug #7425: Avoid directory usage in static blocks
Radu, please check @P2JQueryLogger@. I feel like I've mismatched something in it while rebasing. More specific, I am ... Alexandru Lungu
03:44 AM Runtime Infrastructure Bug #7425: Avoid directory usage in static blocks
I retested the customer application and found out that the @psCache@ is initialized before the @CacheManager@, which ... Dănuț Filimon
09:34 AM User Interface Feature #4853 (Hold): implement support for reporting a device-id which is meant to identify a un...
Greg Shah
09:31 AM User Interface Feature #4853: implement support for reporting a device-id which is meant to identify a unique cl...
I would love to indicate I'm pausing it. Unfortunately this is not an option in the Status field. Galya B
09:30 AM User Interface Feature #4853: implement support for reporting a device-id which is meant to identify a unique cl...
I appreciate it. Please pause work on this specific task. Greg Shah
09:12 AM User Interface Feature #4853: implement support for reporting a device-id which is meant to identify a unique cl...
Greg Shah wrote:
> Anything behind a NAT firewall will not expose the local IP at the TCP/IP level.
NAT is exactl...
Galya B
09:03 AM User Interface Feature #4853: implement support for reporting a device-id which is meant to identify a unique cl...
> so they definitely will know about the host ip in the local network as well
Actually, I'm not so sure that is th...
Greg Shah
08:49 AM User Interface Feature #4853: implement support for reporting a device-id which is meant to identify a unique cl...
@WebRTC@ is the only way to find more network details in the browser. If we don't rely on network details (host / ip)... Galya B
08:46 AM User Interface Feature #4853: implement support for reporting a device-id which is meant to identify a unique cl...
The problem is that I don't know enough about networks and network related code, so I'm not completely sure how the p... Galya B
08:40 AM User Interface Feature #4853: implement support for reporting a device-id which is meant to identify a unique cl...
The idea of a device-id is that it is stable and associated with the system on which the browser runs. The "local IP... Greg Shah
08:39 AM User Interface Feature #4853: implement support for reporting a device-id which is meant to identify a unique cl...
I was originally expecting the local IP to be the host IP and it probably is, when the protocol is used outside the b... Galya B
08:21 AM User Interface Feature #4853: implement support for reporting a device-id which is meant to identify a unique cl...
Greg Shah wrote:
> 2 tabs will have different "local IP" as will tabs in 2 different browser instances, correct?
...
Galya B
08:21 AM User Interface Feature #4853 (WIP): implement support for reporting a device-id which is meant to identify a uni...
Greg Shah
08:20 AM User Interface Feature #4853: implement support for reporting a device-id which is meant to identify a unique cl...
> Without WebRTC local IP we can't differentiate between web users behind a proxy using standard machines with the sa... Greg Shah
06:23 AM User Interface Feature #4853 (Review): implement support for reporting a device-id which is meant to identify a ...
Galya B
06:14 AM User Interface Feature #4853: implement support for reporting a device-id which is meant to identify a unique cl...
Without WebRTC local IP we can't differentiate between web users behind a proxy using standard machines with the same... Galya B
06:04 AM User Interface Feature #4853: implement support for reporting a device-id which is meant to identify a unique cl...
Client preferences will not be related to this id, but to the FWD user and will be applied after login / web client s... Galya B
04:15 AM Database Bug #7467: join on meta table
Ovidiu, so this means that this 'recid relation' is automatically applied only to meta or permanent tables. That is ... Constantin Asofiei
08:39 PM Database Bug #7467: join on meta table
I did some more research.
Indeed, in the case of TEMP-TABLES this @<parent>-recid@ lookup does not work. Here is t...
Ovidiu Maxiniuc

06/27/2023

04:58 PM Database Bug #7467: join on meta table
Constantin Asofiei wrote:
> Ovidiu, @_Index-Seq@ I think is the position of the field in the index definition. Als...
Ovidiu Maxiniuc
02:01 PM Database Bug #7467: join on meta table
Ovidiu Maxiniuc wrote:
> > I don't have a customer app standalone test for this issue yet.
> I thought you encounte...
Constantin Asofiei
01:44 PM Database Bug #7467: join on meta table
Constantin Asofiei wrote:
> Ovidiu, @_Index-Seq@ I think is the position of the field in the index definition.
A...
Ovidiu Maxiniuc
02:56 AM Database Bug #7467: join on meta table
Ovidiu, @_Index-Seq@ I think is the position of the field in the index definition. Also, we need to limit this fix ... Constantin Asofiei
09:05 PM Database Bug #7467 (WIP): join on meta table
Constantin, please try the following patch:... Ovidiu Maxiniuc
04:06 PM Conversion Tools Feature #6237: OEUnit support
Is there any reason to leave this task open? Greg Shah
03:14 PM Conversion Tools Feature #6237: OEUnit support
Greg Shah wrote:
> I don't want to go down this route right now. We have this problem generally and will address it...
Constantin Asofiei
02:58 PM Conversion Tools Feature #6237: OEUnit support
I don't want to go down this route right now. We have this problem generally and will address it in another way.
...
Greg Shah
10:26 AM Base Language Feature #4855 (WIP): add a 4GL extension SESSION:SESSION-ID attribute which returns a UUID which ...
Branch 4855a created. Galya B
10:23 AM Base Language Feature #4855: add a 4GL extension SESSION:SESSION-ID attribute which returns a UUID which unique...
> the unique conversation (with standalone gui/chui/batch processes);
Yes
> the unique connection to appserver ...
Greg Shah
10:18 AM Base Language Feature #4855: add a 4GL extension SESSION:SESSION-ID attribute which returns a UUID which unique...
OK, leaving @BaseSession@ aside. A session from 4GL perspective should be:
* the unique conversation (with standalon...
Galya B
10:17 AM Base Language Feature #4855: add a 4GL extension SESSION:SESSION-ID attribute which returns a UUID which unique...
> I'm just trying to figure out if there is any case where the id should be stable in different @BaseSession@ objects... Greg Shah
10:12 AM Base Language Feature #4855: add a 4GL extension SESSION:SESSION-ID attribute which returns a UUID which unique...
You can have a virtual session while in an active direct session. You cannot have a virtual session on its own, the ... Greg Shah
10:10 AM Base Language Feature #4855: add a 4GL extension SESSION:SESSION-ID attribute which returns a UUID which unique...
Actually obviously that's how appserver works. I'm just trying to figure out if there is any case where the id should... Galya B
10:08 AM Base Language Feature #4855: add a 4GL extension SESSION:SESSION-ID attribute which returns a UUID which unique...
Can we have multiple "connection" sessions (@DirectSession@ / @VirtualSession@) for one client (not necessarily simul... Galya B
08:51 AM Base Language Feature #4855: add a 4GL extension SESSION:SESSION-ID attribute which returns a UUID which unique...
Maybe, but it isn't hard to implement the cleanup of a record using Java code. The initial insertion can be done in ... Greg Shah
08:27 AM Base Language Feature #4855: add a 4GL extension SESSION:SESSION-ID attribute which returns a UUID which unique...
The hook seem to be in Java, while the customers want to implement it in 4GL. I think they will come back to us to as... Galya B
08:16 AM Base Language Feature #4855: add a 4GL extension SESSION:SESSION-ID attribute which returns a UUID which unique...
I expect that the customer will likely implement their own "licenses in use" table (see #4522) in which one field wil... Greg Shah
07:40 AM Base Language Feature #4855: add a 4GL extension SESSION:SESSION-ID attribute which returns a UUID which unique...
How will customers know when older sessions have been ended when implementing licensing rules?
Galya B
10:07 AM Runtime Infrastructure Bug #7425: Avoid directory usage in static blocks
*Committed 7388a/rev14637.*
* Removed the @DatabaseStatistics.get@ call in @StandardServer@
* This will be the stan...
Dănuț Filimon
04:31 AM Runtime Infrastructure Bug #7425: Avoid directory usage in static blocks
*Review of 7388a*
This also includes the review for #7388.
* In @StandardServer@, you no longer need @DatabaseSta...
Alexandru Lungu
03:53 AM Runtime Infrastructure Bug #7425: Avoid directory usage in static blocks
Rebased 7388a from trunk rev. 14633. 7388a is now at rev. 14636. Alexandru Lungu
09:56 AM Database Feature #7323: Implement soft unique index in FWD-H2
The purpose of @confirmUniqueConstraintViolation@: consider that we are validating record A, which is in the FWD serv... Eric Faulhaber
05:36 AM Database Feature #7323 (WIP): Implement soft unique index in FWD-H2
Radu, please check the following hypothesis from @Validation.validateUniqueByQuery@:... Alexandru Lungu
05:19 AM Database Feature #7323: Implement soft unique index in FWD-H2
Quite concerning, this runs slower by +0.5%. Only 2/5 profiling runs were faster than the baseline, but with just a b... Alexandru Lungu
09:18 AM Base Language Feature #6410: implement additional built-in OO classes/interfaces
We've discussed this POLY issue with extent in #5729. But I can't find if we made a dedicated task for making POLY w... Constantin Asofiei
08:53 AM Base Language Feature #6410: implement additional built-in OO classes/interfaces
What do you suggest? Greg Shah
08:41 AM Base Language Feature #6410: implement additional built-in OO classes/interfaces
Greg, I've taken a look at 6410a, and the main issue is changing the return type for i.e. @LegacyClass.invoke@, from ... Constantin Asofiei
08:19 AM Base Language Feature #6410: implement additional built-in OO classes/interfaces
Marian, please upload a skeleton patch using the latest skeleton project from xfer (rev 116). Constantin Asofiei
07:47 AM Base Language Feature #6410: implement additional built-in OO classes/interfaces
Constantin: Have you reviewed 6410a? I'd like to get it into trunk.
Marian: We urgently need the runtime for @Pro...
Greg Shah
09:03 AM Runtime Infrastructure Bug #7291 (Closed): LOG-MANAGER to log on client-side
The last issue was fixed in task branch 7415c which was merged to trunk as rev 14631. Greg Shah
09:00 AM Base Language Bug #7272 (Closed): RUN ... NO-ERROR must log the 'missing.p was not found' message, always.
Greg Shah
08:04 AM Database Bug #7059: FWD shouldn't raise errors for non-numeric extent indexes.
> I also tried to find out how @datetime@ and @datetime-tz@ and found that both types will always convert to the valu... Greg Shah
03:21 AM Database Bug #7059: FWD shouldn't raise errors for non-numeric extent indexes.
I ran a few tests using CALL and found out that there is aren't a lot of similarities between the conversion to the a... Dănuț Filimon
06:40 AM Database Bug #7452: Analyze memory of the value cache from FWD-H2 and eventually increase size
I will pend the effort here on analyzing cache size changes until #7454 is finished. Alexandru Lungu
05:39 AM Database Bug #7454 (WIP): Make ValueStringIgnoreCase the default generated value for setString in FWD-H2
Danut, I created 7454a_h2 for this task. The change is not complex, but confirming this is the right thing to do is h... Alexandru Lungu
04:33 AM Database Feature #7382: Check performance of delete from vs drop table in H2
This should be pending - #7459 may be a better way to fix this. Alexandru Lungu

06/26/2023

03:49 PM User Interface Feature #4129: map web client users to OS accounts
Greg Shah wrote:
> FWD doesn't know anything about @user_client.xml@. What are you referencing here?
True. But t...
Roger Borrello
03:37 PM User Interface Feature #4129: map web client users to OS accounts
FWD doesn't know anything about @user_client.xml@. What are you referencing here? Greg Shah
03:22 PM User Interface Feature #4129: map web client users to OS accounts
> 1. Should we implement a facility in our admin UI to create/delete and manage OS accounts? This probably includes ... Roger Borrello
01:29 PM User Interface Feature #4129: map web client users to OS accounts
> > The FWD user is unique enough.
> I can't imagine a customer who will create FWD users for each of their app / en...
Greg Shah
12:07 PM User Interface Feature #4129: map web client users to OS accounts
Greg Shah wrote:
> The FWD user is unique enough.
I can't imagine a customer who will create FWD users for each of ...
Galya B
11:31 AM User Interface Feature #4129: map web client users to OS accounts
> Just throwing a random idea here: If on successful login the app returns a unique id for the user instead of userna... Greg Shah
11:28 AM User Interface Feature #4129: map web client users to OS accounts
Galya B wrote:
> Greg Shah wrote:
> > If we assume that FWD really doesn't care about the app user
>
> > the ma...
Greg Shah
09:42 AM User Interface Feature #4129: map web client users to OS accounts
Adding a few more details to the random idea above: Instead of creating multiple fwd users in the admin panel with th... Galya B
09:23 AM User Interface Feature #4129: map web client users to OS accounts
Just throwing a random idea here: If on successful login the app returns a unique id for the user instead of username... Galya B
04:23 AM User Interface Feature #4129: map web client users to OS accounts
Greg Shah wrote:
> If we assume that FWD really doesn't care about the app user
> the mapping of a given FWD acc...
Galya B
03:06 PM Database Feature #7466: Using a different database connection to work around sequence specific issues
Yes. Here is the quote from the official OpenEdge manual ("Working with sequences":https://docs.progress.com/bundle/o... Ovidiu Maxiniuc
08:17 AM Database Feature #7466: Using a different database connection to work around sequence specific issues
You are saying that in the 4GL, all sequence usage is outside of a transaction and never will be rolled back if there... Greg Shah
02:22 PM Database Bug #7467: join on meta table
Ovidiu, this looks troublesome. 4GL may have some even more hidden fields to be able to join the meta tables, or som... Constantin Asofiei
01:58 PM Database Bug #7467: join on meta table
This seems like a problem with finding the inverse join index. In the case of these tables, the definitions are simil... Ovidiu Maxiniuc
02:08 PM Base Language Feature #6497: add equivalent support for the -T command line option
Please merge 6497a into 4938a. Add/rework support for @-T@ to the @STARTUP-PARAMETERS@. Greg Shah
02:04 PM Base Language Feature #6425: SESSION handle features
Did you have a branch 6425a? It is not listed in this task, so it is not clear. I know you have changes. Please me... Greg Shah
02:02 PM Base Language Feature #4391: enhance existing SESSION:STARTUP-PARAMETERS support to honor -H -db -S -ld -N values
Please use branch 4938a. Greg Shah
01:25 PM Base Language Feature #3853: implement LOG-MANAGER runtime
@QUERY:BASIC-LOGGING@ is already listed in #3853-1. Whether we implement a new set of logging instrumentation for it... Greg Shah
12:02 PM Base Language Feature #3853: implement LOG-MANAGER runtime
Greg Shah wrote:
> Galya B wrote:
> > Note: This task should include proper implementation of @basic-logging@ that ...
Galya B
11:25 AM Base Language Feature #3853: implement LOG-MANAGER runtime
Galya B wrote:
> Note: This task should include proper implementation of @basic-logging@ that is already supported i...
Greg Shah
11:03 AM Base Language Feature #3853: implement LOG-MANAGER runtime
Note: This task should include proper implementation of @basic-logging@ that is already supported in the 4GL syntax. Galya B
01:22 PM Runtime Infrastructure Bug #7443 (Closed): performance of CentralLogger
Greg Shah
12:52 PM Runtime Infrastructure Bug #7443 (Test): performance of CentralLogger
Galya B
12:29 PM Runtime Infrastructure Bug #7443: performance of CentralLogger
Task branch 7443a was merged to trunk as rev 14633 and archived. Galya B
10:56 AM Runtime Infrastructure Bug #7443: performance of CentralLogger
Please merge 7443a to trunk. Good work! Greg Shah
10:11 AM Runtime Infrastructure Bug #7443: performance of CentralLogger
Greg: I think we can merge this to trunk. Alexandru reported a 3.5% improvement for 7443a (from a 3.5% loss without ... Constantin Asofiei
06:12 AM Runtime Infrastructure Bug #7443: performance of CentralLogger
Compilation error fixed with r14637. Galya B
04:47 AM Runtime Infrastructure Bug #7443: performance of CentralLogger
Attempting to profile with rev. 14636. I've got:... Alexandru Lungu
03:35 AM Runtime Infrastructure Bug #7443: performance of CentralLogger
Constantin Asofiei wrote:
> Galya, one more small optimization, please: this test in @LoggingUtil.addLeadingSymbols@...
Galya B
03:32 AM Runtime Infrastructure Bug #7443: performance of CentralLogger
Galya, one more small optimization, please: this test in @LoggingUtil.addLeadingSymbols@ can be @leadingSymbolsCount ... Constantin Asofiei
03:13 AM Runtime Infrastructure Bug #7443: performance of CentralLogger
Constantin Asofiei wrote:
> we need to have only one history number per branch
You say that often, but when I add h...
Galya B
02:44 AM Runtime Infrastructure Bug #7443: performance of CentralLogger
Eugenie Lyzenko wrote:
> I see the log call used when process *started*, not stopped. So it is not clear for me why ...
Galya B
02:29 AM Runtime Infrastructure Bug #7443: performance of CentralLogger
Eugenie Lyzenko wrote:
> I see the log call used when process *started*, not stopped. So it is not clear for me why ...
Galya B
11:53 AM User Interface Feature #4856: web client session forking
> Opening manually multiple browser windows in the same browser instance should fulfill the requirement.
The resul...
Greg Shah
04:23 AM User Interface Feature #4856: web client session forking
Opening manually multiple browser windows in the same browser instance should fulfill the requirement. The identifier... Galya B
08:34 AM Conversion Tools Feature #6237: OEUnit support
As to the Java class name clash problem: I think, the only reliable solution would be as follows:
# conversion alw...
Vladimir Tsichevski
08:30 AM Database Feature #6763 (Rejected): implement configurable sizes (in the directory) for FastFindCache and O...
Greg Shah
04:33 AM Database Feature #6763: implement configurable sizes (in the directory) for FastFindCache and ORM Session ...
Just found out this issue. The same effort is already in-progress as part of #7388. This can be rejected. Alexandru Lungu
08:10 AM Database Bug #7403: Copy-temp-table with replace-mode should replace already inserted records
Ștefan, please investigate why the invalidation doesn't occur when you are actually validating / saving the new recor... Alexandru Lungu
07:58 AM Database Bug #7403: Copy-temp-table with replace-mode should replace already inserted records
The error is occurring due to invalidation of the cache. Invalidation takes place after all records have been inserte... Ștefan Roman
07:25 AM Database Bug #7334: Reclaim used sessions to improve performance
Alexandru Lungu wrote:
> Constantin Asofiei wrote:
>> Alexandru, about the concurrency issues:
> Danut, please do ...
Dănuț Filimon
04:33 AM User Interface Feature #4854: origin affinity
As discussed earlier client-side web storage can't be persistent, because @localStorage@ relies on the host name, whi... Galya B
03:13 AM Database Feature #7323: Implement soft unique index in FWD-H2
*Review of 7323a, rev. 14590*
* This is OK.
* My only concern is related to @validatedMode ?@. I think you should...
Alexandru Lungu

06/25/2023

07:00 AM Database Bug #7467: join on meta table
The customer's application has these errors:... Constantin Asofiei
06:58 AM Database Bug #7467: join on meta table
This test:... Constantin Asofiei
06:53 AM Database Bug #7467 (Test): join on meta table
Constantin Asofiei

06/24/2023

08:46 PM Database Feature #7466: Using a different database connection to work around sequence specific issues
This task is related to #7270 so that the approaches used for working around sequences issues can be discussed and do... Ovidiu Maxiniuc
08:21 PM Database Feature #7466 (WIP): Using a different database connection to work around sequence specific issues
Ovidiu Maxiniuc

06/23/2023

12:33 PM Runtime Infrastructure Bug #7443: performance of CentralLogger
Constantin Asofiei wrote:
> Eugenie: please review the native changes.
>
I have no objection for code itself. H...
Eugenie Lyzenko
11:52 AM Runtime Infrastructure Bug #7443: performance of CentralLogger
Constantin Asofiei wrote:
> Alexandru: please do another round of performance testing with 7156b + 7443a. Please no...
Constantin Asofiei
11:42 AM Runtime Infrastructure Bug #7443: performance of CentralLogger
Galya, this is a review for 7443a rev 14634:
* @CentraLogger@ - please leave only 006 number and remove 007 and 008 ...
Constantin Asofiei
10:26 AM Runtime Infrastructure Bug #7443 (Review): performance of CentralLogger
r14634: Fixed Java (@java.util.logging.LogRecord#needToInferCaller@ set with reflection to stop heavy checks unused b... Galya B
08:52 AM Runtime Infrastructure Bug #7443: performance of CentralLogger
If it's not a trouble, can we have a perf test running now, while I wonder what else to change.
P.S. with updated ...
Galya B
08:51 AM Runtime Infrastructure Bug #7443: performance of CentralLogger
r14633:
The appserver kept the spawner live, which kept the stderr parsing / logging loop on the server live. It p...
Galya B
05:14 AM Runtime Infrastructure Bug #7443: performance of CentralLogger
Please do a profiling and see what else stands out which can be improved. Constantin Asofiei
05:11 AM Runtime Infrastructure Bug #7443: performance of CentralLogger
r14632 16% improvement of the @+0.45%@ degradation by replacing @String.format@ in formatting logging context.
I a...
Galya B
02:56 AM Runtime Infrastructure Bug #7443: performance of CentralLogger
@CleanFormatter@ and the java logger init code is taken from an old trunk version.... Galya B
02:07 AM Runtime Infrastructure Bug #7443: performance of CentralLogger
Galya B wrote:
> If we blindly introduce "improvements" in iterations without any clearly expressed expectations, th...
Constantin Asofiei
02:04 AM Runtime Infrastructure Bug #7443: performance of CentralLogger
I'll test it in a unbiased way now, in FWD. Wait for results. Galya B
02:02 AM Runtime Infrastructure Bug #7443: performance of CentralLogger
Constantin Asofiei wrote:
> Galya, I think your tests are biased because they do not use the FWD runtime. My point ...
Galya B
01:53 AM Runtime Infrastructure Bug #7443: performance of CentralLogger
If we blindly introduce "improvements" in iterations without any clearly expressed expectations, this may not work as... Galya B
11:37 AM User Interface Feature #4129: map web client users to OS accounts
> I thought the task is to map app-users to os-users in directory.xml, so this is somewhat different from what I got.... Greg Shah
10:47 AM User Interface Feature #4129: map web client users to OS accounts
Greg Shah wrote:
> We don't need the app user. The hook can return the FWD user that corresponds to the app user th...
Galya B
10:39 AM User Interface Feature #4129: map web client users to OS accounts
> > We have no plan to store things in-memory.
>
> If there are any plans I don't know of, please share the direct...
Greg Shah
10:38 AM User Interface Feature #4129: map web client users to OS accounts
> > Not that I know of. We have no plan to store things in-memory.
> How do you find the mapping of the app user wh...
Greg Shah
10:30 AM User Interface Feature #4129: map web client users to OS accounts
Greg Shah wrote:
> We have no plan to store things in-memory.
If there are any plans I don't know of, please shar...
Galya B
10:08 AM User Interface Feature #4129: map web client users to OS accounts
Greg Shah wrote:
> Not that I know of. We have no plan to store things in-memory.
How do you find the mapping of t...
Galya B
10:05 AM User Interface Feature #4129: map web client users to OS accounts
> Is the argument about in-memory data structure not valid?
Not that I know of. We have no plan to store things i...
Greg Shah
10:02 AM User Interface Feature #4129: map web client users to OS accounts
Is the argument about in-memory data structure not valid? Galya B
06:19 AM User Interface Feature #4129: map web client users to OS accounts
> > Do we need to store information about the app users?
> No, nothing other than knowing what FWD user and OS user ...
Greg Shah
01:43 AM User Interface Feature #4129: map web client users to OS accounts
Greg Shah wrote:
> > If we cleanup after each user, do we really need 1:1?
>
> I'm not sure what you mean by cle...
Galya B
01:30 AM User Interface Feature #4129: map web client users to OS accounts
Greg Shah wrote:
> It would be a natural approach to store some amount of this mapping information in the FWD accoun...
Galya B
09:46 AM Database Feature #7323: Implement soft unique index in FWD-H2
I've implemented the logic for @insertValidateSql@ and tested with a customer application. The changes can be found o... Radu Apetrii
06:59 AM Database Feature #7323: Implement soft unique index in FWD-H2
The profiling results are quite interesting. The average improvement is only -0.2%. *However*, I've got a run with -2... Alexandru Lungu
06:00 AM Database Feature #7323: Implement soft unique index in FWD-H2
Alexandru Lungu wrote:
> * Please add some extra javadoc to @Persister.insert@ to better understand what @validateMo...
Radu Apetrii
03:48 AM Database Feature #7323 (Review): Implement soft unique index in FWD-H2
*Review of 7323a, rev. 14588*
* The changes are OK.
* Please add some extra javadoc to @Persister.insert@ to bett...
Alexandru Lungu
07:42 AM Database Bug #7334: Reclaim used sessions to improve performance
The agents in an appserver live for the lifetime of the FWD Server - so this Session can exist forever, if this LIFET... Constantin Asofiei
06:29 AM Database Bug #7334: Reclaim used sessions to improve performance
Constantin Asofiei wrote:
> if it executes on the @SessionCloseThread@. We need tests and make sure the @Conversati...
Alexandru Lungu
05:12 AM Database Bug #7334: Reclaim used sessions to improve performance
I'm not sure how we can solve this:... Constantin Asofiei
05:09 AM Database Bug #7334: Reclaim used sessions to improve performance
Constantin Asofiei wrote:
> Alexandru, about the concurrency issues:
Danut, please do the fixing.
> otherwise,...
Alexandru Lungu
05:05 AM Database Bug #7334: Reclaim used sessions to improve performance
Alexandru, about the concurrency issues:
* This code can execute on the @SessionCloseThread@. This is not an @Assoc...
Constantin Asofiei
04:35 AM Database Bug #7334: Reclaim used sessions to improve performance
> Alexandru, there are some concurrency issues
I will do a second check then. Please let me know if you already sp...
Alexandru Lungu
03:55 AM Database Bug #7334: Reclaim used sessions to improve performance
Alexandru, there are some concurrency issues, but my main concern is this:... Constantin Asofiei
03:19 AM Database Bug #7334: Reclaim used sessions to improve performance
*Eric, Constantin, Ovidiu*: can you provide a feedback here. The performance tests show real good results and the imp... Alexandru Lungu
07:31 AM Database Feature #7320: Extend H2 tester from Hotel GUI
The changes that I did to the H2 tester are :
* I removed the initial create;
* I removed the delete operation tha...
Ștefan Roman
03:12 AM Database Feature #6630 (Test): optimize return of table parameter
This can be closed now. #6630-2 is already solved and merged into trunk at some point. Alexandru Lungu
03:10 AM Database Feature #7404: Trasform replace-mode into append-mode when target table is empty
Please do some forensics on that issue you have with the customer application. Do some debugging - extract the tables... Alexandru Lungu
02:37 AM Base Language Feature #6410: implement additional built-in OO classes/interfaces
Constantin Asofiei wrote:
> Marian Edu wrote:
> > > Also, 6410a branch is on xfer - do you still have problems usin...
Marian Edu
01:23 AM Runtime Infrastructure Bug #7462: fix 'AS' instead of '4GL' in LOG-MANAGER log lines and add an incompatible FWD and FWD...
OK, sorry about that. I keep forgetting that LOG-MANAGER needs more work. Constantin Asofiei
01:01 AM Runtime Infrastructure Bug #7462: fix 'AS' instead of '4GL' in LOG-MANAGER log lines and add an incompatible FWD and FWD...
This is not a bug, this is a unimplemented feature. AS proper support was supposed to be worked under #3853. Galya B

06/22/2023

03:57 PM User Interface Feature #4129: map web client users to OS accounts
> If we cleanup after each user, do we really need 1:1?
I'm not sure what you mean by cleanup, but I suspect the ...
Greg Shah
03:44 PM Base Language Bug #7460: implement Progress.Lang.Class:getMethods
For this task, the priority is the runtime for @progress.lang.class:getMethods@. For current customers, we already h... Constantin Asofiei
03:42 PM Base Language Bug #7460: implement Progress.Lang.Class:getMethods
That is a big reason we really need to get 6410a merged into trunk. It at least provides conversion support for all ... Greg Shah
03:35 PM Base Language Bug #7460: implement Progress.Lang.Class:getMethods
Marian, can this be implemented 'standalone', without additional APIs from @progress.lang.classs@ (or others)? Constantin Asofiei
03:34 PM Base Language Bug #7460: implement Progress.Lang.Class:getMethods
> Greg: is progress.lang.class supposed to be fully implemented in some other task?
Yes, in #6410.
Greg Shah
09:57 AM Base Language Bug #7460: implement Progress.Lang.Class:getMethods
A customer project uses @progress.lang.class:getMethods@. We need to implement this.
Greg: is progress.lang.class...
Constantin Asofiei
09:56 AM Base Language Bug #7460 (Merge Pending): implement Progress.Lang.Class:getMethods
Constantin Asofiei
10:41 AM Runtime Infrastructure Bug #7462: fix 'AS' instead of '4GL' in LOG-MANAGER log lines and add an incompatible FWD and FWD...
When used on 4GL client, LOG-MANAGER outputs this:... Constantin Asofiei
10:35 AM Runtime Infrastructure Bug #7462 (New): fix 'AS' instead of '4GL' in LOG-MANAGER log lines and add an incompatible FWD a...
Constantin Asofiei
10:00 AM Database Feature #7404: Trasform replace-mode into append-mode when target table is empty
After letting simpleCopy be true when the explicit signatures matched, some custom small tests looked fine, but after... Ștefan Roman
07:52 AM Database Feature #7404: Trasform replace-mode into append-mode when target table is empty
With @7404a revision 14629@ it is slightly better, but we are still 1% behind. However, I had really high variance on... Alexandru Lungu
09:28 AM Database Feature #7459: Implement BucketIndex in FWD-H2 to support multiplex
This task is inside my head for a really long time. I had an attempt at some point to implement it, but I didn't had ... Alexandru Lungu
09:06 AM Database Feature #7459 (WIP): Implement BucketIndex in FWD-H2 to support multiplex
Alexandru Lungu
08:56 AM Runtime Infrastructure Support #5568: implement application-specific TERMINFO database overrides
With the completion of #5167, we now have the option of using a statically linked ncurses installation rather than th... Greg Shah
07:40 AM Database Bug #7059: FWD shouldn't raise errors for non-numeric extent indexes.
You can also try combinations like this, when using characters and octal representation:... Constantin Asofiei
07:35 AM Database Bug #7059: FWD shouldn't raise errors for non-numeric extent indexes.
Dănuț Filimon wrote:
> Constantin Asofiei:
> > If you are trying to find the binary representation of different dat...
Constantin Asofiei
07:34 AM Database Bug #7059: FWD shouldn't raise errors for non-numeric extent indexes.
Constantin Asofiei:
> If you are trying to find the binary representation of different data types, take a look @Call...
Dănuț Filimon
07:23 AM Database Bug #7059: FWD shouldn't raise errors for non-numeric extent indexes.
Constantin Asofiei wrote:
> As a side note, this @converTo@ method has some assumptions for i.e. int64 when the OUTP...
Constantin Asofiei
07:20 AM Database Bug #7059: FWD shouldn't raise errors for non-numeric extent indexes.
Danut, I think 4GL just reads the first two bytes from the memory address where this value is stored (as max extent s... Constantin Asofiei
07:19 AM Database Bug #7059: FWD shouldn't raise errors for non-numeric extent indexes.
*Committed 7059a/rev.14633*. I added deference operators to handle @character/longchar/logical/date@ types, I did not... Dănuț Filimon
06:05 AM Database Bug #7059: FWD shouldn't raise errors for non-numeric extent indexes.
Here's a decimal overview of the formulas used in each situation:
|_. Action |_. Decimal value type ...
Dănuț Filimon
04:45 AM Database Bug #7059: FWD shouldn't raise errors for non-numeric extent indexes.
Some related questions:
* empty character results in extent 0?
* negative decimal is any different? I guess that @+...
Alexandru Lungu
04:41 AM Database Bug #7059: FWD shouldn't raise errors for non-numeric extent indexes.
Danut, comparing to other 4GL data type, @decimal@ seems to have two values stored: @value@ and @scale@. You issue ma... Alexandru Lungu
03:13 AM Database Feature #7320 (WIP): Extend H2 tester from Hotel GUI
Stefan, please commit your extension to Hotel GUI.
AFAIK, you developed exclusively in 4GL for this task. Move you...
Alexandru Lungu

06/21/2023

11:00 AM Runtime Infrastructure Bug #7443 (WIP): performance of CentralLogger
We know we need proper logging because there are 4GL language features that depend upon it. In addition, we must pro... Greg Shah
09:15 AM Runtime Infrastructure Bug #7443: performance of CentralLogger
Another summary:
* @CentralLogger@ (used in new trunk) is 300% slower than @System.err@ redirected to file (used in ...
Galya B
09:02 AM Runtime Infrastructure Bug #7443: performance of CentralLogger
Here is the java logger to file with the new formatter. There is slight degradation of performance (+6.3%), because t... Galya B
08:48 AM Runtime Infrastructure Bug #7443: performance of CentralLogger
Constantin Asofiei wrote:
> For example, can @String.format@ be replaced with something else, which parses the forma...
Galya B
08:41 AM Runtime Infrastructure Bug #7443: performance of CentralLogger
Biased is a synonym for isolated? I have no idea what settings you use in your tests, while I shared my samples. Aren... Galya B
08:34 AM Runtime Infrastructure Bug #7443: performance of CentralLogger
Galya, I think your tests are biased because they do not use the FWD runtime. My point was to test from within the F... Constantin Asofiei
08:13 AM Runtime Infrastructure Bug #7443: performance of CentralLogger
What I'm implying is: Console writes seem quite expensive, so the java logger performed poorly before, but the day wa... Galya B
08:10 AM Runtime Infrastructure Bug #7443: performance of CentralLogger
Constantin Asofiei wrote:
> From your results, are you saying that Java logger is 33seconds and CentraLogger is 14se...
Galya B
08:09 AM Runtime Infrastructure Bug #7443: performance of CentralLogger
From your results, are you saying that Java logger is 33seconds and CentraLogger is 14seconds? Constantin Asofiei
08:07 AM Runtime Infrastructure Bug #7443: performance of CentralLogger
A little bit of history:
Once upon a time FWD used direct @System.err.print@ and @throwable.printStackTrace()@ sta...
Galya B
08:02 AM Runtime Infrastructure Bug #7443: performance of CentralLogger
Here it is, the groundbreaking reality (in src.com.galya.LoggingTest):... Galya B
07:58 AM Runtime Infrastructure Bug #7443: performance of CentralLogger
I don't understand what you mean by System.err. Previously, FWD was using @java.util.logging@ for logging support on... Constantin Asofiei
04:39 AM Runtime Infrastructure Bug #7443: performance of CentralLogger
Constantin Asofiei wrote:
> using what was before CentraLogger
You mean @System.err@? server.log was "generated" by...
Galya B
04:01 AM Runtime Infrastructure Bug #7443: performance of CentralLogger
Galya, please measure the following, for 1mm log lines:
* the LogTest modified program with CentralLogger and 7443a
...
Constantin Asofiei
03:14 AM Runtime Infrastructure Bug #7443: performance of CentralLogger
Let's set the requirements first before jumping into fixing. If I make @CentralLogger#describeContext@ (24,755%) and ... Galya B
02:50 AM Runtime Infrastructure Bug #7443: performance of CentralLogger
Alexandru Lungu wrote:
> I got a result that is a bit slower than my trunk base-line before @CentralLogger@ (only +0...
Galya B
02:42 AM Runtime Infrastructure Bug #7443: performance of CentralLogger
Alexandru, can you please try to run with the following configs:... Galya B
02:42 AM Runtime Infrastructure Bug #7443: performance of CentralLogger
> Alexandru, please commit this change to 7443a. I expect 7443a to be merged to trunk before 7026e.
Done! Committe...
Alexandru Lungu
01:41 AM Runtime Infrastructure Bug #7443: performance of CentralLogger
Alexandru Lungu wrote:
> Constantin Asofiei wrote:
> > Alexandru Lungu wrote:
> > > I commented an WARNING (that ...
Constantin Asofiei
08:27 AM Database Feature #7404: Trasform replace-mode into append-mode when target table is empty
I added the first change, and I will start working/testing the second change.
Committed to 7404a revision 14629.
Ștefan Roman
06:10 AM Database Feature #7404 (WIP): Trasform replace-mode into append-mode when target table is empty
My profiling still shows slow code here - even slower than before with +1.3%. In fact, this is because of the followi... Alexandru Lungu
07:49 AM Testing Support #6854 (WIP): base language tests
Marian Edu
06:31 AM User Interface Feature #4129: map web client users to OS accounts
Greg Shah wrote:
> I also don't see exactly how we would implement a one-to-one mapping, which is the most common ca...
Galya B
05:37 AM Database Bug #7059: FWD shouldn't raise errors for non-numeric extent indexes.
I've investigated the issue and found the following:
* for characters, the index is calculated using @(second char <...
Dănuț Filimon
01:53 AM Database Bug #7449 (Test): unqualified _File buffer must target the first database in the connection list
Branch 7449a was merged to trunk rev 14632 and archived. Constantin Asofiei

06/20/2023

05:02 PM User Interface Feature #4129: map web client users to OS accounts
> Before starting I need to have the directory.xml structure approved:
It is not fully clear the purpose of the @a...
Greg Shah
07:30 AM User Interface Feature #4129: map web client users to OS accounts
Before starting I need to have the directory.xml structure approved:... Galya B
04:41 PM Runtime Infrastructure Bug #7443: performance of CentralLogger
Galya, Alexandru I think is right, formatting the message is expensive. Please see how this can be improved. I've a... Constantin Asofiei
10:00 AM Runtime Infrastructure Bug #7443: performance of CentralLogger
Constantin Asofiei wrote:
> Alexandru Lungu wrote:
> > I commented an WARNING (that is already fixed on another br...
Alexandru Lungu
09:54 AM Runtime Infrastructure Bug #7443: performance of CentralLogger
Alexandru Lungu wrote:
> I commented an WARNING (that is already fixed on another branch)
Is this already in trunk...
Constantin Asofiei
09:42 AM Runtime Infrastructure Bug #7443: performance of CentralLogger
I've done one set of profiling tests and got a slight improvement comparing to the state before #7443 (which was +3.1... Alexandru Lungu
09:14 AM Runtime Infrastructure Bug #7443: performance of CentralLogger
Code Review Task Branch 7443a Revision 14630
The change is good. I like that the code is in @Utils@ instead of @C...
Greg Shah
08:48 AM Runtime Infrastructure Bug #7443: performance of CentralLogger
r14630 reverts @LogHelper#createThreadName@, requested in #7143-234. Galya B
04:23 AM Runtime Infrastructure Bug #7443: performance of CentralLogger
I pushed r14629 to fix the compilation error. I haven't rebuilt with @all@. Galya B
03:40 AM Runtime Infrastructure Bug #7443: performance of CentralLogger
7443a/rev. 14628 doesn't compile: ... Alexandru Lungu
01:47 AM Runtime Infrastructure Bug #7443: performance of CentralLogger
Constantin Asofiei wrote:
> Alexandru: please apply (locally) the 7443a changes to 7156b and run a new round of test...
Alexandru Lungu
03:51 PM Database Bug #7449: unqualified _File buffer must target the first database in the connection list
You can rebase and merge to trunk. Greg Shah
03:50 PM Database Bug #7449: unqualified _File buffer must target the first database in the connection list
Code Review Task Branch 7449a Revision 14631
No objections.
Greg Shah
09:16 AM Database Bug #7452: Analyze memory of the value cache from FWD-H2 and eventually increase size
> AFAIK, there are way more case-insensitive values than case-sensitive ones in customer applications.
Very true.
Greg Shah
06:06 AM Database Bug #7452: Analyze memory of the value cache from FWD-H2 and eventually increase size
This is a statistic on the value cache hit ratio depending on the cache size.
|_. Size |_. Hit |_. Miss |_. Rat...
Alexandru Lungu
04:14 AM Database Bug #7452 (WIP): Analyze memory of the value cache from FWD-H2 and eventually increase size
FWD-H2 has a @Value.softCache@ that stores the values used by H2. Every bit of information stored by H2 is wrapped by... Alexandru Lungu
03:59 AM Database Bug #7452 (WIP): Analyze memory of the value cache from FWD-H2 and eventually increase size
Alexandru Lungu
08:24 AM Database Feature #7416: Reiterate DatabaseStatistics and leverage to other database profling tools
Makes sense. However, I still feel there is some valuable logic behind @DatabaseStatistics@ that can be reused. Not n... Alexandru Lungu
07:42 AM Database Feature #7416: Reiterate DatabaseStatistics and leverage to other database profling tools
Ovidiu Maxiniuc wrote:
> the normal way of shutting down the server (and collect the database statistics) is to 'ask...
Radu Apetrii
01:36 AM Database Feature #7416: Reiterate DatabaseStatistics and leverage to other database profling tools
Ovidiu Maxiniuc wrote:
> The SIGINT (CTRL+C) is the alternative 'hard' way.
This may be an amateur question on my...
Alexandru Lungu
10:35 PM Database Feature #7416: Reiterate DatabaseStatistics and leverage to other database profling tools
the normal way of shutting down the server (and collect the database statistics) is to 'asked' it nicely, using the @... Ovidiu Maxiniuc
06:10 AM Database Bug #7454: Make ValueStringIgnoreCase the default generated value for setString in FWD-H2
This task is related to @setString@ parameter setting in FWD-H2. Most of the strings we are using with this option ar... Alexandru Lungu
06:07 AM Database Bug #7454 (Closed): Make ValueStringIgnoreCase the default generated value for setString in FWD-H2
Alexandru Lungu
05:33 AM Runtime Infrastructure Bug #7425: Avoid directory usage in static blocks
This bootstrap is triggered only on server start-up from @StandardServer@ hooks. Should we consider other FWD usages ... Alexandru Lungu
04:55 AM Runtime Infrastructure Bug #7425: Avoid directory usage in static blocks
There are a few classes that already have an @initialize@ method, so to avoid confusion I @bootstrap@ for the method ... Dănuț Filimon
04:27 AM Database Bug #7412: PresortQuery ORDER BY has to many clauses
I added all the changes.
Committed to 7026e revision 14604.
Ștefan Roman
02:42 AM Database Bug #7412: PresortQuery ORDER BY has to many clauses
*Review of 7026e, revision 14603*
* We can go the extra mile here for performance sake
** let @recIdsSet@ be @nul...
Alexandru Lungu
03:58 AM Database Feature #7363 (Test): Improve H2 Value caching, hashing and equals
Completely *tested* - everything looks right.
I tested a large customer application and I got:
* 425.568 cache hi...
Alexandru Lungu
02:20 AM Database Feature #7404: Trasform replace-mode into append-mode when target table is empty
I added the changes and committed again on 7404a revision 14628. Ștefan Roman
02:07 AM Database Feature #7404 (Review): Trasform replace-mode into append-mode when target table is empty
*Review of 7404a revision 14626*
* I am OK with the functional changes.
* Please add a comment before the fast-co...
Alexandru Lungu

06/19/2023

01:55 PM Database Bug #7449 (Review): unqualified _File buffer must target the first database in the connection list
Created task branch 7449a from trunk rev 14630.
The changes are in 7449a rev 14631.
Constantin Asofiei
01:44 PM Database Bug #7449: unqualified _File buffer must target the first database in the connection list
The assumptions in note #6129-28 and others, where it was found that the last connected database is used I think are ... Constantin Asofiei
11:33 AM Database Bug #7449: unqualified _File buffer must target the first database in the connection list
In OpenEdge, when running from command line, like this:... Constantin Asofiei
11:26 AM Database Bug #7449 (Test): unqualified _File buffer must target the first database in the connection list
Constantin Asofiei
11:50 AM Runtime Infrastructure Bug #7443: performance of CentralLogger
Galya B wrote:
> 7443a r14628 based on trunk r14627 tested and ready for review.
The changes look reasonable, but t...
Constantin Asofiei
10:40 AM Runtime Infrastructure Bug #7443 (Review): performance of CentralLogger
7443a r14628 based on trunk r14627 tested and ready for review. Galya B
04:19 AM Runtime Infrastructure Bug #7443 (WIP): performance of CentralLogger
7443a created. Galya B
09:40 AM Database Feature #7416: Reiterate DatabaseStatistics and leverage to other database profling tools
Alexandru Lungu wrote:
> @DatabaseStatistics@ is a good solution for query profiling on the FWD part.
I started to ...
Radu Apetrii
09:13 AM Database Feature #7363 (Review): Improve H2 Value caching, hashing and equals
*Review of 7363b_h2 revision 23*
I am OK with the changes.
Most of the testing doesn't show regressions. I am doi...
Alexandru Lungu
06:01 AM Database Feature #7363: Improve H2 Value caching, hashing and equals
Added the change and committed it to 7363b_h2 revision 23. Ștefan Roman
05:51 AM Database Feature #7363: Improve H2 Value caching, hashing and equals
*Review of 7363b_h2 revision 22*
* @ValueBytes@ is not using @instanceof@ to check @obj@ of type @byte[]@. *This i...
Alexandru Lungu
09:11 AM Database Bug #7448: Optimize FWD-H2 ValueTimestampTimeZone and maybe avoid caching
From #7363-19:... Alexandru Lungu
09:09 AM Database Bug #7448 (Rejected): Optimize FWD-H2 ValueTimestampTimeZone and maybe avoid caching
Alexandru Lungu
09:10 AM Database Feature #4516: testing and completion of runtime compatibility for table/table-handle/dataset/dat...
Greg Shah wrote:
> > Marian: What work is needed to complete these tests? What is the status of the existing tests ...
Marian Edu
08:18 AM Database Feature #7323: Implement soft unique index in FWD-H2
I've applied the changes suggested in #7323-12 for both 7323a and 7323a_h2.
I've also added tests in 7323a_h2 and fi...
Radu Apetrii
07:03 AM Runtime Infrastructure Bug #7425: Avoid directory usage in static blocks
Danut, try to make the initialization calls hierarchical. That is, do not list all initialization in @StandardServer@... Alexandru Lungu
07:01 AM Runtime Infrastructure Bug #7425: Avoid directory usage in static blocks
I found the following static initializers that use @directory.xml@:
* @TemporaryAccountPool@
* @WebHandler@: from t...
Dănuț Filimon
06:57 AM Database Feature #7447: Compare ValueString and ValueStringIgnoreCase faster in FWD-H2
There are several hits of @Value.compareTo@, where the operands are @ValueString@ and @ValueStringIgnoreCase@. This i... Alexandru Lungu
06:46 AM Database Feature #7447 (Closed): Compare ValueString and ValueStringIgnoreCase faster in FWD-H2
Alexandru Lungu
05:04 AM Database Bug #7420: Optimize Cursor for scrolling AdaptiveQuery
I retested the customer application using @MethodTraceAspect@ instead of @AdaptiveQueryTraceAspect@ and *8031* calls ... Dănuț Filimon
04:49 AM Database Bug #7059 (WIP): FWD shouldn't raise errors for non-numeric extent indexes.
Alexandru Lungu

06/16/2023

03:26 PM User Interface Feature #4517: optionally back the 4GL features for Registry access with the user-specific offlin...
Galya B wrote:
> What class implements the global 4GL methods accessing the Windows registry store?
To the conver...
Greg Shah
07:22 AM User Interface Feature #4517: optionally back the 4GL features for Registry access with the user-specific offlin...
!preferences.png! Galya B
06:24 AM User Interface Feature #4517: optionally back the 4GL features for Registry access with the user-specific offlin...
To sum it up: This FWD persistent storage should be used:
1. On non-Windows operating system for global environment ...
Galya B
05:38 AM User Interface Feature #4517: optionally back the 4GL features for Registry access with the user-specific offlin...
What class implements the global 4GL methods accessing the Windows registry store? Galya B
10:04 AM User Interface Feature #3931: single sign-on for virtual desktop mode
Sorry for asking multiple times. Just want to make sure the old comments are not related, since it's quite important.... Galya B
10:03 AM User Interface Feature #3931: single sign-on for virtual desktop mode
We would implement the login outselves and just call the hook which is non-interactive code implemented by the custom... Greg Shah
10:02 AM User Interface Feature #3931: single sign-on for virtual desktop mode
I agree that the new login code is NOT 4GL code. That is what I meant in #3931-46 when I said "This hook will not be... Greg Shah
09:50 AM User Interface Feature #3931: single sign-on for virtual desktop mode
Greg Shah wrote:
> > For #3770-81, the simplest way is to provide a directory-configured auth hook which checks the ...
Galya B
09:45 AM User Interface Feature #3931: single sign-on for virtual desktop mode
As part of moving to this approach, they will modify the application to bypass their normal 4GL login. We will only ... Greg Shah
09:33 AM User Interface Feature #3931: single sign-on for virtual desktop mode
Greg Shah wrote:
> This hook will not be 4GL code.
I mean their login page being 4GL will have to live a complete C...
Galya B
09:29 AM User Interface Feature #3931: single sign-on for virtual desktop mode
> If the login screen is 4GL app controlled by the customer, how do we manage different sessions? We'll need a dedica... Greg Shah
08:29 AM User Interface Feature #3931: single sign-on for virtual desktop mode
4GL app needs OS user. OS user is determined after app login. App login needs 4GL app. And we have an infinite loop. Galya B
08:26 AM User Interface Feature #3931: single sign-on for virtual desktop mode
If the login screen is 4GL app controlled by the customer, how do we manage different sessions? We'll need a dedicate... Galya B
09:22 AM User Interface Feature #4129: map web client users to OS accounts
> OS users will have their passwords in directory encrypted like for @admin@ user.
I'm not sure this is needed in...
Greg Shah
09:17 AM User Interface Feature #4129: map web client users to OS accounts
> What is FWD user? I understand the admin has access to the admin login and temp accounts are used for @NativeSecure... Greg Shah
08:38 AM User Interface Feature #4129: map web client users to OS accounts
OS users will have their passwords in directory encrypted like for @admin@ user. But I can't recall do we expect the ... Galya B
04:20 AM User Interface Feature #4129: map web client users to OS accounts
What is FWD user? I understand the admin has access to the admin login and temp accounts are used for @NativeSecureCo... Galya B
09:12 AM Database Feature #4516: testing and completion of runtime compatibility for table/table-handle/dataset/dat...
> Marian: What work is needed to complete these tests? What is the status of the existing tests for table/table-hand... Greg Shah
09:02 AM Runtime Infrastructure Bug #7443: performance of CentralLogger
Greg Shah wrote:
> What can't be slow or even as slow as a single map lookup is the @isLoggable()@.
Roger that. I...
Galya B
09:01 AM Runtime Infrastructure Bug #7443: performance of CentralLogger
Galya B wrote:
> When invalidating the levels in all instances that will be a performance bottleneck, because all lo...
Greg Shah
02:44 AM Runtime Infrastructure Bug #7443: performance of CentralLogger
When invalidating the levels in all instances that will be a performance bottleneck, because all loggers will need to... Galya B
07:16 AM Base Language Bug #7438: the label in the UNDO <lbl>, THROW is not validated or used in 4GL
Committed to 7300a rev 14626. ... Constantin Asofiei
06:52 AM User Interface Feature #4854: origin affinity
We can swap the actual implementation at any time if any inconvenience is found, still using the Java interface @java... Galya B
06:45 AM User Interface Feature #4854: origin affinity
I think @java.util.prefs.Preferences@ may be a good enough generic solution for all clients. I'll just have to figure... Galya B
06:41 AM User Interface Feature #4854: origin affinity
@UserKeyValueStorage@ is an abstract class that implements @KeyValueStorage@ interface and follows the idea to store ... Sergey Ivanovskiy
04:17 AM Database Feature #7416: Reiterate DatabaseStatistics and leverage to other database profling tools
Committed 7416a to trunk as rev. 14626. Alexandru Lungu
04:08 AM Database Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...
I have a potential fix for the remaining issues of the @TestWriteXmlFile.cls@, but are probably wrong:
- @BaseDataTy...
Maciej Zieniuk

06/15/2023

04:49 PM Database Feature #7416: Reiterate DatabaseStatistics and leverage to other database profling tools
Code Review Task Branch 7416a Revision 14626
No objections. You can merge to trunk.
Greg Shah
10:40 AM Database Feature #7416: Reiterate DatabaseStatistics and leverage to other database profling tools
Greg Shah wrote:
> > Add a sensible flag to the configuration.
>
> Please use @sensitive@ instead of @sensible@.
...
Alexandru Lungu
10:08 AM Database Feature #7416: Reiterate DatabaseStatistics and leverage to other database profling tools
This sounds good to me. There are cases in which a query from a stack trace is basically a dynamic query. Therefore, ... Alexandru Lungu
09:54 AM Database Feature #7416: Reiterate DatabaseStatistics and leverage to other database profling tools
I've done two more changes that can be found on 7416a, rev. 14633:
* I've increased the number of characters printed...
Radu Apetrii
07:44 AM Database Feature #7416: Reiterate DatabaseStatistics and leverage to other database profling tools
Greg Shah wrote:
> > Add a sensible flag to the configuration.
>
> Please use @sensitive@ instead of @sensible@.
...
Radu Apetrii
07:34 AM Database Feature #7416: Reiterate DatabaseStatistics and leverage to other database profling tools
> Add a sensible flag to the configuration.
Please use @sensitive@ instead of @sensible@.
Greg Shah
07:29 AM Database Feature #7416: Reiterate DatabaseStatistics and leverage to other database profling tools
Alexandru Lungu wrote:
> Add a @sensible@ flag to the configuration. If this is set, output only: @sql.substring(0, ...
Radu Apetrii
04:46 AM Database Feature #7416: Reiterate DatabaseStatistics and leverage to other database profling tools
Radu Apetrii wrote:
> If any ideas come to my mind, I will post updates.
I think we can adopt a naive way of cens...
Alexandru Lungu
04:41 AM Database Feature #7416: Reiterate DatabaseStatistics and leverage to other database profling tools
Radu, please make sure you don't miss out the dirty databases as part of the SQL logging / query logging. I think the... Alexandru Lungu
04:21 AM Database Feature #7416: Reiterate DatabaseStatistics and leverage to other database profling tools

Alexandru Lungu wrote:
> 1. For H2, we always proxy the statements through @TempTableDataSourceProvider@, so all...
Radu Apetrii
04:13 PM Base Language Bug #7438: the label in the UNDO <lbl>, THROW is not validated or used in 4GL
I'm OK with the approach. Go ahead and apply it. Greg Shah
12:50 PM Base Language Bug #7438: the label in the UNDO <lbl>, THROW is not validated or used in 4GL
The patch above does not drop the label, but instead 'forces it' even if it can't be resolved, to preserve the AST st... Constantin Asofiei
10:33 AM Base Language Bug #7438 (Review): the label in the UNDO <lbl>, THROW is not validated or used in 4GL
This patch solves the issue; I don't see a more elegant solution.... Constantin Asofiei
09:29 AM Base Language Bug #7438: the label in the UNDO <lbl>, THROW is not validated or used in 4GL
Greg Shah wrote:
> The label never has meaning?
Correct - it has no meaning, either for the 4GL compiler or the 4GL...
Constantin Asofiei
09:27 AM Base Language Bug #7438: the label in the UNDO <lbl>, THROW is not validated or used in 4GL
The label never has meaning? Greg Shah
09:23 AM Base Language Bug #7438: the label in the UNDO <lbl>, THROW is not validated or used in 4GL
Greg Shah wrote:
> > all behavior was the same in 4GL, until I tried with a 'bogus' label
>
> You mean this was t...
Constantin Asofiei
09:15 AM Base Language Bug #7438: the label in the UNDO <lbl>, THROW is not validated or used in 4GL
> all behavior was the same in 4GL, until I tried with a 'bogus' label
You mean this was the case after your chang...
Greg Shah
08:17 AM Base Language Bug #7438: the label in the UNDO <lbl>, THROW is not validated or used in 4GL
Greg Shah wrote:
> Is this really a parsing issue? Maybe @label_reference@ detects this as a @malformed_symbol@ but...
Constantin Asofiei
08:10 AM Base Language Bug #7438: the label in the UNDO <lbl>, THROW is not validated or used in 4GL
Is this really a parsing issue? Maybe @label_reference@ detects this as a @malformed_symbol@ but it isn't clear that... Greg Shah
12:39 PM Runtime Infrastructure Bug #7443: performance of CentralLogger
> Galya, beside the FWD server startup, what are the condition under which a logger's level can be changed? Here I m... Greg Shah
12:38 PM Runtime Infrastructure Bug #7443: performance of CentralLogger
> 1. Have you done performance testing on Java @isLoggable@ implementation? Think about it carefully.
All of our p...
Greg Shah
12:37 PM Runtime Infrastructure Bug #7443: performance of CentralLogger
Galya, beside the FWD server startup, what are the condition under which a logger's level can be changed? Here I mea... Constantin Asofiei
11:47 AM Runtime Infrastructure Bug #7443: performance of CentralLogger
I'm not sure if that got understood, but all loggers should listen to the change, this means a few hundred objects wr... Galya B
11:41 AM Runtime Infrastructure Bug #7443: performance of CentralLogger
What I'm trying to say is that listeners and more state are a bad idea. It should be implemented with @WeakReference@... Galya B
11:33 AM Runtime Infrastructure Bug #7443: performance of CentralLogger
Also Java logger has a tree :( I wanted to implement a tree as well, but didn't have the capacity of a Java team. Galya B
11:24 AM Runtime Infrastructure Bug #7443: performance of CentralLogger
I made an expensive mistake, that removed will improve things 3 times... Now @getLevel@ checks in 3 concurrent maps, ... Galya B
11:13 AM Runtime Infrastructure Bug #7443: performance of CentralLogger
Galya B wrote:
> Galya B wrote:
> > To me removing 50% of the calls sounds quite right. Or am I misreading your scr...
Constantin Asofiei
10:59 AM Runtime Infrastructure Bug #7443: performance of CentralLogger
Galya B wrote:
> To me removing 50% of the calls sounds quite right. Or am I misreading your screenshot?
I didn't s...
Galya B
10:58 AM Runtime Infrastructure Bug #7443: performance of CentralLogger
Also as I've said, I have a mistake to fix.
Galya B
10:57 AM Runtime Infrastructure Bug #7443: performance of CentralLogger
To me removing 50% of the calls sounds quite right. Or am I misreading your screenshot? Galya B
10:54 AM Runtime Infrastructure Bug #7443: performance of CentralLogger
Galya B wrote:
> Give me 1h to rework @TransactionManager@ to my liking and see if it fixes something.
Reworking co...
Constantin Asofiei
10:52 AM Runtime Infrastructure Bug #7443: performance of CentralLogger
Do we have a branch here? Galya B
10:51 AM Runtime Infrastructure Bug #7443: performance of CentralLogger
Give me 1h to rework @TransactionManager@ to my liking and see if it fixes something. Galya B
10:49 AM Runtime Infrastructure Bug #7443: performance of CentralLogger
Constantin, I started with a similar implementation, where the state also included the level, but there are other cav... Galya B
10:46 AM Runtime Infrastructure Bug #7443: performance of CentralLogger
@isLoggable@ is meant to be used when there is a cost with resolving the arguments passed to the @log@ method. That'... Constantin Asofiei
10:44 AM Runtime Infrastructure Bug #7443: performance of CentralLogger
Even if I bend due to pure pressure and implement it, I don't recommend using @isLoggable@ just for the sake of looki... Galya B
10:29 AM Runtime Infrastructure Bug #7443: performance of CentralLogger
Constantin Asofiei wrote:
> It doesn't matter if the same logger name is being used by multiple logger instances, th...
Galya B
10:20 AM Runtime Infrastructure Bug #7443: performance of CentralLogger
Greg Shah wrote:
> Bypassing everything but the logging level check has served us well. There is a performance reas...
Galya B
10:20 AM Runtime Infrastructure Bug #7443: performance of CentralLogger
Galya, the problem is not @isLoggable@ being called excessively. @canLog@ relies too on @isLoggable@, so getting rid ... Constantin Asofiei
10:14 AM Runtime Infrastructure Bug #7443: performance of CentralLogger
Bypassing everything but the logging level check has served us well. There is a performance reason those checks were... Greg Shah
10:13 AM Runtime Infrastructure Bug #7443: performance of CentralLogger
This is the entire @logging@ node. The @loggers@ levels is the same from before testing with @CentralLogger@.... Constantin Asofiei
10:08 AM Runtime Infrastructure Bug #7443: performance of CentralLogger
Constantin, what is the logging level you tested with on this screenshot? Galya B
09:50 AM Runtime Infrastructure Bug #7443: performance of CentralLogger
Also let's not forget that resource consumption is part of execution of applications and this feature was not existin... Galya B
09:44 AM Runtime Infrastructure Bug #7443: performance of CentralLogger
There is no free lunch, it's either the CPU or the RAM. If I need to work on this task, I'll remove @isLoggable@ from... Galya B
09:40 AM Runtime Infrastructure Bug #7443: performance of CentralLogger
And we know the complexity of accessing string keyed map. Do you think the concurrency of the map adds to the CPU usage? Galya B
09:39 AM Runtime Infrastructure Bug #7443: performance of CentralLogger
Actually the cache map should have been the first lookup in the method. This is my bad. Galya B
09:33 AM Runtime Infrastructure Bug #7443: performance of CentralLogger
Constantin Asofiei wrote:
> We need to remove the map lookup. The log level needs to be cached at the logger instan...
Galya B
09:32 AM Runtime Infrastructure Bug #7443: performance of CentralLogger
Galya B wrote:
> We can lower it to 1.8 million executions removing the unnecessary @if (LOG.isLoggable(Level.FINE))...
Constantin Asofiei
09:31 AM Runtime Infrastructure Bug #7443: performance of CentralLogger
~1% of resources for 3.6 million executions sounds great to me!
Jokes aside...
We can lower it to 1.8 million e...
Galya B
08:13 AM Runtime Infrastructure Bug #7443: performance of CentralLogger
@CentralLogger.isLoggable@ is called 3.6 million times when testing an application. In the profiler, this highlights... Constantin Asofiei
08:08 AM Runtime Infrastructure Bug #7443 (Closed): performance of CentralLogger
Constantin Asofiei
12:10 PM User Interface Feature #4854: origin affinity
> Actually if @UserKeyValueStorage@ is meant to be used only through 4GL methods, then its handling can happen on the... Greg Shah
10:11 AM User Interface Feature #4854: origin affinity
Actually if @UserKeyValueStorage@ is meant to be used only through 4GL methods, then its handling can happen on the F... Galya B
10:01 AM User Interface Feature #4854: origin affinity
Greg Shah wrote:
> * We have host + port affinity.
If in-app user is allocated port, this port can't be used for an...
Galya B
09:58 AM User Interface Feature #4854: origin affinity
Greg Shah wrote:
> * Port affinity doesn't work when multiple brokers are in use.
This will write off some deployme...
Galya B
09:54 AM User Interface Feature #4854: origin affinity
I'm having one ground breaking idea running in the background in my brain for a while... I'll try to flesh it out. Pe... Galya B
09:26 AM User Interface Feature #4854: origin affinity
> Originally the task intended to solve the problem of making ports stable for end-users. But there is another variab... Greg Shah
09:22 AM User Interface Feature #4854: origin affinity
Greg Shah wrote:
> * Increased points of failure.
> * Slower.
Well, having the client traffic go through an embedd...
Galya B
09:19 AM User Interface Feature #4854: origin affinity
Originally the task intended to solve the problem of making ports stable for end-users. But there is another variable... Galya B
09:13 AM User Interface Feature #4854: origin affinity
The complications that are added by reverse proxy:
* More complex configuration.
* Increased points of failure.
...
Greg Shah
09:09 AM User Interface Feature #4854: origin affinity
The problem with remote spawns is that it's probably the preferred deployment for some apps (the main way to spawn we... Galya B
07:17 AM User Interface Feature #4854: origin affinity
> @UserKeyValueStorage@ is not supposed to have 4GL interface, right?
Incorrect. See #4517.
> In FWD which one...
Greg Shah
07:12 AM User Interface Feature #4854: origin affinity
> did I get this right?
Yes. There is also the [[p2j:Reverse Proxy]] case which adds complications.
Greg Shah
07:04 AM User Interface Feature #4854: origin affinity
And a slightly unrelated question:
From @PreferencesFactory@ javadoc:
> @Preferences.userRoot()@ returns the user...
Galya B
06:03 AM User Interface Feature #4854: origin affinity
@UserKeyValueStorage@ is not supposed to have 4GL interface, right? Galya B
05:46 AM User Interface Feature #4854: origin affinity
Actually remote hosts (different IPs) are an issue for @localStorage@ in general. Galya B
05:07 AM User Interface Feature #4854: origin affinity
There is an important limitation to working with domains. You need to know beforehand what domain / subdomain is mapp... Galya B
11:24 AM Database Bug #7412: PresortQuery ORDER BY has to many clauses
Committed to 7026e, revision 14603. Ștefan Roman
10:52 AM Runtime Infrastructure Bug #7425 (WIP): Avoid directory usage in static blocks
Danut, this is close to your work on #7388. I will do the review on caches there asap.
Please extend your research...
Alexandru Lungu
10:44 AM Database Bug #7420: Optimize Cursor for scrolling AdaptiveQuery
I wonder if our LTW is spoiled somehow by the GC. I mean, for a simple @setScrolling@, it is hard to believe that 750... Alexandru Lungu
09:52 AM Database Bug #7420: Optimize Cursor for scrolling AdaptiveQuery
I tested a customer application using @AdaptiveQueryTraceAspect@. My results for @setScrolling@ were ~5.5k calls with... Dănuț Filimon
07:57 AM Database Bug #7420: Optimize Cursor for scrolling AdaptiveQuery
Danut, can you take a look into this one?
It is quite bad that @AdaptiveQuery.setScrolling()@ works that slow. Ple...
Alexandru Lungu
07:48 AM Database Bug #7421: Check only the indexes that were changed when using Validation.checkMaxIndexSize
I created a test using a temporary table with 50 fields, all being part of unique/non unique indexes. It consisted of... Dănuț Filimon
05:18 AM Database Bug #7421: Check only the indexes that were changed when using Validation.checkMaxIndexSize
Eric Faulhaber wrote:
> @BaseRecord.getDirtyIndices@ already is invoked in several places in @Validation@. Can we re...
Dănuț Filimon
05:29 AM Database Feature #7365: Avoid using reflection in generating BDT
I added in @BaseDataTypeFactory@ a function @instantiate@ that also takes as a parameter the initial value that is to... Radu Apetrii
03:03 AM Database Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...
Greg Shah wrote:
> Marian: Any idea why this reports as unserializable when the class itself is marked serializable?...
Marian Edu

06/14/2023

03:08 PM Base Language Bug #7438: the label in the UNDO <lbl>, THROW is not validated or used in 4GL
This simple line compiles and executes fine in 4GL:... Constantin Asofiei
03:06 PM Base Language Bug #7438 (Review): the label in the UNDO <lbl>, THROW is not validated or used in 4GL
Constantin Asofiei
02:44 PM Database Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...
@progress.lang.object@ fields are not serializable. This test:... Constantin Asofiei
02:21 PM Database Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...
> I have problems understanding the other failures in the @TestWriteXmlFile.cls@ method @writeFileInvalid@.
> This p...
Greg Shah
09:33 AM Database Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...
I have problems understanding the other failures in the @TestWriteXmlFile.cls@ method @writeFileInvalid@.
This porti...
Maciej Zieniuk
02:32 PM User Interface Feature #4854: origin affinity
> If the stored data is not considered privacy-sensitive or exposing information that needs authorization, then the s... Greg Shah
06:13 AM User Interface Feature #4854: origin affinity
That being said, I actually remember that @localStorage@ data is readable by everyone with access to the device, it's... Galya B
06:07 AM User Interface Feature #4854: origin affinity
But before going too far with this task, let me ask the most important question: What type of data do we expect to be... Galya B
06:02 AM User Interface Feature #4854: origin affinity
Greg Shah wrote:
> > Then User @gbb@ is always redirected to its dedicated subdomain @https://e83aed3ddf.users.websi...
Galya B
10:11 AM Database Feature #7363: Improve H2 Value caching, hashing and equals
I added the changes.
Committed to 7363b_h2 revision 22.
Ștefan Roman
08:02 AM Database Feature #7404: Trasform replace-mode into append-mode when target table is empty
Fixed an error and committed again on 7404a revision 14627. Ștefan Roman
05:48 AM Database Feature #7404: Trasform replace-mode into append-mode when target table is empty
Committed to 7404a revision 14626. Ștefan Roman
04:43 AM Database Feature #7404: Trasform replace-mode into append-mode when target table is empty
Created 7404a. Alexandru Lungu
06:08 AM Conversion Tools Feature #6237: OEUnit support
The "4GL_Unit_Testing":https://proj.goldencode.com/projects/p2j/wiki/4GL_Unit_Testing page was updated: the "Primer" ... Vladimir Tsichevski
04:52 AM Database Bug #7412: PresortQuery ORDER BY has to many clauses
The clause is added firstly at initialization which is correct since there can be multiple clauses that may need to b... Dănuț Filimon
04:24 AM Database Bug #7412: PresortQuery ORDER BY has to many clauses
-Danut, please prioritize this if you think it can be fixed by the end of this week. From my POV, there shouldn't be ... Alexandru Lungu
04:42 AM Database Bug #7403 (WIP): Copy-temp-table with replace-mode should replace already inserted records
Alexandru Lungu
04:36 AM Database Feature #7365: Avoid using reflection in generating BDT
Radu, if it doesn't take much time, please do a quick round-check of this issue and try to get this change in 7026e b... Alexandru Lungu

06/13/2023

01:04 PM Database Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...
Having this:... Constantin Asofiei
11:16 AM Database Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...
I have implemented the changes, under rev 14621 on 4514a branch. There are still some other errors that the @TestWrit... Maciej Zieniuk
08:33 AM User Interface Feature #4854: origin affinity
> > The number of users in these pools is going to be limited. The average pool side will be between 5 and 25 users.... Greg Shah
08:32 AM User Interface Feature #4854: origin affinity
> Enabling @*.users.website.com@ in the DNS to point to the FWD server's host.
Yes, with the proper Jetty config,...
Greg Shah
08:06 AM User Interface Feature #4854: origin affinity
Greg Shah wrote:
> The number of users in these pools is going to be limited. The average pool side will be between...
Galya B
08:03 AM User Interface Feature #4854: origin affinity
Greg Shah wrote:
> A DNS subdomain implies a dedicated IP address. Are you suggesting allocating an IP address and ...
Galya B
07:42 AM User Interface Feature #4854: origin affinity
> I think I saw somewhere a task that was about reworking the spawning of new web clients as separate Jetty instances... Greg Shah
07:41 AM User Interface Feature #4854: origin affinity
> The max range of ports can be 49152-65535 (~16k).
Are you talking about the port number for the browser's sessio...
Greg Shah
07:14 AM User Interface Feature #4854: origin affinity
I think I saw somewhere a task that was about reworking the spawning of new web clients as separate Jetty instances. ... Galya B
07:12 AM User Interface Feature #4854: origin affinity
The max range of ports can be 49152-65535 (~16k). This is the max number of concurrent sessions currently. When each ... Galya B
08:06 AM User Interface Feature #4853: implement support for reporting a device-id which is meant to identify a unique cl...
> Does it mean a browser instance at this point should be distinguishable?
Yes.
> If the UUID is unique for eac...
Greg Shah
05:31 AM User Interface Feature #4853: implement support for reporting a device-id which is meant to identify a unique cl...
> This would be unique across all browser instances that connect to the same FWD server.
Does it mean a @browser ...
Galya B
07:49 AM Database Bug #7421 (WIP): Check only the indexes that were changed when using Validation.checkMaxIndexSize
Alexandru Lungu
07:17 AM Database Feature #7416: Reiterate DatabaseStatistics and leverage to other database profling tools
Created 7416a. Alexandru Lungu
06:07 AM Database Feature #7416: Reiterate DatabaseStatistics and leverage to other database profling tools
I have two ideas here:
1. For H2, we always proxy the statements through @TempTableDataSourceProvider@, so all sta...
Alexandru Lungu
06:31 AM Database Bug #7388: Create server configuration container for cache sizes
*Committed 7388a.rev14619.* Added @CacheManager@ that reads the configuration cache sizes of classes and can be used ... Dănuț Filimon
06:14 AM Database Feature #7323: Implement soft unique index in FWD-H2
Radu, please focus on this after you finish the recent performance logging changes. I will like to give it a performa... Alexandru Lungu
03:13 AM Database Feature #7363: Improve H2 Value caching, hashing and equals
*Review of 7363b_h2 revision 21*
* @ValueByte.lowLevelEquals@ should use @((Byte) obj).byteValue()@ to stay consis...
Alexandru Lungu
02:15 AM Runtime Infrastructure Bug #7291: LOG-MANAGER to log on client-side
I'll merge it with 7415c when ready. Galya B

06/12/2023

05:32 PM Base Language Feature #6425 (WIP): SESSION handle features
Theodoros Theodorou
04:22 PM Conversion Tools Feature #6237: OEUnit support
Vladimir Tsichevski wrote:
> Greg Shah wrote:
> > > > As to the new instruction: shall I write a new Redmine page.....
Greg Shah
04:07 PM Conversion Tools Feature #6237: OEUnit support
Vladimir Tsichevski wrote:
> > Include examples how to specify package, regexp or other specs to identify and run...
Eric Faulhaber
03:56 PM Conversion Tools Feature #6237: OEUnit support
Greg Shah wrote:
> > > As to the new instruction: shall I write a new Redmine page...
> >
> > I already devised t...
Vladimir Tsichevski
02:46 PM Conversion Tools Feature #6237: OEUnit support
> > As to the new instruction: shall I write a new Redmine page...
>
> I already devised the new page name: *FWD A...
Greg Shah
01:19 PM Conversion Tools Feature #6237: OEUnit support
Vladimir Tsichevski wrote:
> As to the new instruction: shall I write a new Redmine page...
I already devised t...
Vladimir Tsichevski
01:16 PM Conversion Tools Feature #6237: OEUnit support
Vladimir Tsichevski wrote:
> Still I have to fix the docs page to reflect this change.
Done.
As to the new ins...
Vladimir Tsichevski
01:05 PM Conversion Tools Feature #6237: OEUnit support
A repo 3827c was created for new fixes.
I changed the @build.gradle@: @junit-platform-console@ JAR was added to the ...
Vladimir Tsichevski
12:31 PM Conversion Tools Feature #6237: OEUnit support
Constantin Asofiei wrote:
> Vladimir Tsichevski wrote:
> > About the instruction I have to write. Shall it be somet...
Vladimir Tsichevski
12:10 PM Conversion Tools Feature #6237: OEUnit support
Vladimir Tsichevski wrote:
> About the instruction I have to write. Shall it be something like "Writing Hello World ...
Constantin Asofiei
12:04 PM Conversion Tools Feature #6237: OEUnit support
Constantin Asofiei wrote:
> Please work on the wiki.
About the instruction I have to write. Shall it be somethi...
Vladimir Tsichevski
11:44 AM Conversion Tools Feature #6237: OEUnit support
Thanks, for that app, I can remove everything from oeunit except @oeunit.runners.oeunitrunner@ and @oeunit.runners.ru... Constantin Asofiei
10:39 AM Conversion Tools Feature #6237: OEUnit support
Constantin Asofiei wrote:
> Thanks for this question. Now I recall the original scenario. This app has these depen...
Vladimir Tsichevski
10:04 AM Conversion Tools Feature #6237: OEUnit support
Thanks for this question. Now I recall the original scenario. This app has these dependencies:... Constantin Asofiei
09:15 AM Conversion Tools Feature #6237: OEUnit support
Greg Shah wrote:
> Constantin found that a customer application which uses OEUnit has an issue with the @DataProvide...
Vladimir Tsichevski
08:38 AM Conversion Tools Feature #6237: OEUnit support
Vladimir Tsichevski wrote:
> Which one do you mean?
#6237-280
Constantin Asofiei
08:31 AM Conversion Tools Feature #6237: OEUnit support
This customer has this class in conversion:... Constantin Asofiei
08:30 AM Conversion Tools Feature #6237: OEUnit support
Vladimir Tsichevski wrote:
> Constantin Asofiei wrote:
> > Vladimir, did you manage to solve the @DataProvider@ iss...
Constantin Asofiei
08:28 AM Conversion Tools Feature #6237: OEUnit support
Constantin Asofiei wrote:
> Vladimir, did you manage to solve the @DataProvider@ issue mentioned previously? Because...
Vladimir Tsichevski
05:35 AM Conversion Tools Feature #6237: OEUnit support
Constantin Asofiei wrote:
> Vladimir, assume you are a 4GL developer who knows nothing about JUnit ...
We shouldn't...
Tijs Wickardt
05:17 AM Conversion Tools Feature #6237: OEUnit support
Vladimir, assume you are a 4GL developer who knows nothing about JUnit and just wants to run the converted OEUnit tes... Constantin Asofiei
05:09 AM Conversion Tools Feature #6237: OEUnit support
Constantin Asofiei wrote:
> Vladimir, we need 'start to finish' wiki steps to run the JUnit tests from converted cod...
Vladimir Tsichevski
02:20 PM Base Language Bug #7193 (Closed): READ-JSON is not supported for the "LONGCHAR" source type
Greg Shah
01:01 PM User Interface Feature #4853 (WIP): implement support for reporting a device-id which is meant to identify a uni...
Galya B
11:34 AM Database Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...
Good.
Maciej: Please move ahead on this basis.
Greg Shah
11:27 AM Database Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...
Greg Shah wrote:
> Rather than processing the error manager logging on the client, why not add the needed handling t...
Constantin Asofiei
11:03 AM Database Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...
Rather than processing the error manager logging on the client, why not add the needed handling to @DeferredLegacyErr... Greg Shah
10:56 AM Database Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...
@DeferredLegacyErrorException@ is missing the case for when is thrown from the FWD client. Originally this was meant... Constantin Asofiei
10:36 AM Database Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...
We already catch @DeferredLegacyErrorException@ in @BlockManager.processBody()@ and we call @BlockManager.processLega... Greg Shah
10:25 AM Database Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...
I am not exactly sure how to handle the @DeferredLegacyErrorException@ exception, when the client throws @302@ or @46... Maciej Zieniuk
10:17 AM Database Feature #7363: Improve H2 Value caching, hashing and equals
I added the changes.
Commited to 7363b_h2 revision 21.
Ștefan Roman
05:39 AM Database Feature #7363: Improve H2 Value caching, hashing and equals
*Review of 7363b_h2 revision 20.*
* Use space after @if@ keyword to separate from @(@ (according to H2 standard)
...
Alexandru Lungu
09:57 AM Database Bug #7389 (Review): Make fast-copy statements cachable
This is good. I am extracting your changes and add them to my profiling branch. I am curious of the improvement. Howe... Alexandru Lungu
09:53 AM Database Bug #7389: Make fast-copy statements cachable
Here is an update of the test from #7389-3:
|_. Type |_. Total |_. No append or loose mode |_. Append m...
Dănuț Filimon
08:53 AM Database Bug #7389: Make fast-copy statements cachable
*Committed 7389a.rev14594.* Fixed the problem mentioned in #7389-6. It was caused by missing records that were not co... Dănuț Filimon
06:03 AM Database Bug #7389: Make fast-copy statements cachable
*Review of 7389a.rev14593*
* I am OK with the changes.
* Please also consider @srcRecId@ when ruling our pk mapp...
Alexandru Lungu
09:41 AM Database Feature #6371 (Test): implement SAVE CACHE statement
Greg Shah
08:55 AM Base Language Bug #7247 (Closed): Dataset:READ-XML does nothing
Greg Shah
07:42 AM Base Language Bug #7247: Dataset:READ-XML does nothing
All related unit tests pass for reading dataset from XML. Vladimir Tsichevski
07:45 AM Database Feature #7416: Reiterate DatabaseStatistics and leverage to other database profling tools
Alexandru Lungu wrote:
> * *Ensure that no sensible data is logged (query parameters) in neither profiler*
I have b...
Radu Apetrii
04:38 AM Database Feature #7416: Reiterate DatabaseStatistics and leverage to other database profling tools
Radu, please make the documentation of #6970 sql profiler and #7416 query profiler (leveraging @DatabaseStatistics@) ... Alexandru Lungu
03:13 AM Database Bug #7388: Create server configuration container for cache sizes
Eric Faulhaber wrote:
> That being said, my experience with using @SoftReference@ is from several JVM generations ag...
Alexandru Lungu
02:32 AM Runtime Infrastructure Bug #7291: LOG-MANAGER to log on client-side
Constantin Asofiei wrote:
> Galya, I missed something. Appserver logging must not be forced on server-side.
Well, ...
Galya B

06/11/2023

06:17 AM Conversion Tools Feature #6237: OEUnit support
Vladimir, we need 'start to finish' wiki steps to run the JUnit tests from converted code. This must include:
* any...
Constantin Asofiei
05:59 AM Runtime Infrastructure Bug #7291: LOG-MANAGER to log on client-side
Galya, I missed something. Appserver logging must not be forced on server-side.... Constantin Asofiei

06/10/2023

01:43 AM Conversion Tools Feature #6237: OEUnit support
Vladimir, did you manage to solve the @DataProvider@ issue mentioned previously? Because we need this fixed ASAP. Constantin Asofiei

06/09/2023

02:58 PM Base Language Bug #7299: resolution of the target OO method in chained calls with poly arguments
Rebased 7299a/14613 from trunk rev 14623 - new rev 14625 . Constantin Asofiei
12:10 PM User Interface Feature #3931: single sign-on for virtual desktop mode
> Is mapping end-users to OS accounts in a manual way even possible? I guess the customer systems support sign-up and... Greg Shah
11:59 AM User Interface Feature #3931: single sign-on for virtual desktop mode
Another one to verify I got right: Are temp users used only to authenticate @NativeSecureConnection@ before the serve... Galya B
11:15 AM User Interface Feature #3931: single sign-on for virtual desktop mode
I'm not sure if I got this right: Is the spawner running as admin to allow spawning client processes with any other u... Galya B
11:11 AM User Interface Feature #3931: single sign-on for virtual desktop mode
Also is it an option to consider the possible implications of running multiple end-users with the same OS user or jus... Galya B
11:10 AM User Interface Feature #3931: single sign-on for virtual desktop mode
The question about the amount of end-users is also related to the OS user pooling implementation. If the pooling can'... Galya B
10:56 AM User Interface Feature #3931: single sign-on for virtual desktop mode
Is mapping end-users to OS accounts in a manual way even possible? I guess the customer systems support sign-up and d... Galya B
11:07 AM Database Bug #7388: Create server configuration container for cache sizes
There may be some specific use cases where they make sense, but in general, I am not a huge fan of soft references, f... Eric Faulhaber
10:48 AM Database Bug #7388: Create server configuration container for cache sizes
Eric Faulhaber wrote:
> I don't think *every* setting should be configurable. Generally speaking, the developer will...
Alexandru Lungu
10:15 AM Database Bug #7388: Create server configuration container for cache sizes
Alexandru Lungu wrote:
> I am thinking bigger than only setting the size :)
Thinking beyond the current problem...
Eric Faulhaber
02:55 AM Database Bug #7388: Create server configuration container for cache sizes
Eric Faulhaber wrote:
> Routing this through a factory seems messy
I think it is easier to convey that a @CacheMa...
Alexandru Lungu
10:52 AM Database Bug #7413: DUMP-NAME is not guaranteed to be unique in the .df
We could do something similar for the dump name during conversion, if there is a unique constraint violation, so conv... Eric Faulhaber
10:42 AM Database Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...
> Is this intended that server does not see any information about the error when the error is thrown in the client ?
...
Greg Shah
06:16 AM Database Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...
I have hard time implementing the @302@ and @463@ errors in FWD, as expected by 4GL in case of @tests/dataset/TestWri... Maciej Zieniuk
10:01 AM Database Feature #7363: Improve H2 Value caching, hashing and equals
Committed to 7363b_h2 revision 20. Ștefan Roman
06:58 AM Database Feature #7363: Improve H2 Value caching, hashing and equals
I made a profiler to test the new caching method.
I updated the table with the average time of 5 runs for each value...
Ștefan Roman
10:01 AM Runtime Infrastructure Bug #7291: LOG-MANAGER to log on client-side
> I can name it @merge notification for task 7291@ if there is no standard one.
That works.
Greg Shah
09:59 AM Runtime Infrastructure Bug #7291: LOG-MANAGER to log on client-side
Fix merged to trunk as rev 14621. Galya B
09:53 AM Runtime Infrastructure Bug #7291: LOG-MANAGER to log on client-side
I can name it @merge notification for task 7291@ if there is no standard one. Galya B
09:51 AM Runtime Infrastructure Bug #7291: LOG-MANAGER to log on client-side
Greg Shah wrote:
> In the future, when you post something like this that is expected to be committed immediately, pl...
Galya B
09:50 AM Runtime Infrastructure Bug #7291: LOG-MANAGER to log on client-side
In the future, when you post something like this that is expected to be committed immediately, please include history... Greg Shah
09:45 AM Runtime Infrastructure Bug #7291: LOG-MANAGER to log on client-side
Diff attached. Fixes two NPEs when configs not present. Galya B
09:27 AM Runtime Infrastructure Bug #7291: LOG-MANAGER to log on client-side
No, just post the full diff here for a quick review. Greg Shah
09:03 AM Runtime Infrastructure Bug #7291: LOG-MANAGER to log on client-side
Do I create a whole new branch just for a null check? Galya B
06:32 AM Runtime Infrastructure Bug #7291 (Test): LOG-MANAGER to log on client-side
Galya B
03:22 AM Runtime Infrastructure Bug #7291: LOG-MANAGER to log on client-side
Task branch 7291a was merged to trunk as rev 14620 and archived. Email sent. Galya B
09:11 AM Database Feature #5130 (Rejected): improve management of p2jpl.jar in deployment scripts
I'm closing this as unneeded. We are moving all customers to the native UDFs and PL/Java is deprecated at this time.... Greg Shah
09:06 AM Testing Feature #1886 (Closed): implement a unit testing framework
Greg Shah
08:49 AM Runtime Infrastructure Bug #5703 (Closed): rationalize, standardize and simplify the client-side log file name configura...
Greg Shah
04:35 AM Runtime Infrastructure Bug #7425: Avoid directory usage in static blocks
After discussing with Constantin, mostly in regard to #7398, there are several places in FWD where the directory is r... Alexandru Lungu
04:23 AM Runtime Infrastructure Bug #7425 (Test): Avoid directory usage in static blocks
Alexandru Lungu
03:31 AM Database Feature #7062: Direct access to H2 internals to solve basic queries
Merged 7062c_h2 into FWD-H2 trunk as rev. 21.
The fix will be available with the next FWD-H2 upgrade.
Alexandru Lungu

06/08/2023

02:53 PM Runtime Infrastructure Bug #7291: LOG-MANAGER to log on client-side
You can merge now. Greg Shah
11:40 AM Runtime Infrastructure Bug #7291: LOG-MANAGER to log on client-side
Pushed a tiny NPE fix in r14629. Tested with gui and chui.
When do I merge?
Galya B
10:37 AM Runtime Infrastructure Bug #7291: LOG-MANAGER to log on client-side
Constantin Asofiei wrote:
> * @Utils.pollAll@ needs to return null if there is no message, there is no reason to tra...
Galya B
09:46 AM Runtime Infrastructure Bug #7291: LOG-MANAGER to log on client-side
Constantin Asofiei wrote:
> I've looked through all the changes, I don't see anything else wrong. Did you test agai...
Galya B
09:45 AM Runtime Infrastructure Bug #7291: LOG-MANAGER to log on client-side
Galya B wrote:
> Constantin, please go ahead with reviewing the rest of the code, when you have time. I'll fix all, ...
Constantin Asofiei
07:54 AM Runtime Infrastructure Bug #7291: LOG-MANAGER to log on client-side
Constantin, please go ahead with reviewing the rest of the code, when you have time. I'll fix all, when you're done. Galya B
06:56 AM Runtime Infrastructure Bug #7291: LOG-MANAGER to log on client-side
> Greg, this is not documented in the coding standards, please correct me if I'm wrong.
I think this is correct. ...
Greg Shah
06:43 AM Runtime Infrastructure Bug #7291: LOG-MANAGER to log on client-side
Review for 7291a/14627:
* we don't usually use static imports except for interface constants. Without qualifying a ...
Constantin Asofiei
06:28 AM Runtime Infrastructure Bug #7291: LOG-MANAGER to log on client-side
7291a r14627 file headers. Galya B
02:11 PM Base Language Bug #7247: Dataset:READ-XML does nothing
Ovidiu Maxiniuc wrote:
> Igor,
> I have fixed some formatting issues and enhanced javadoc texts for some methods f...
Igor Skornyakov
01:40 PM Base Language Bug #7247: Dataset:READ-XML does nothing
Igor,
I have fixed some formatting issues and enhanced javadoc texts for some methods for you in r14623. If you agr...
Ovidiu Maxiniuc
06:37 AM Base Language Bug #7247: Dataset:READ-XML does nothing
Ovidiu: Is 7247a OK to merge? Greg Shah
05:05 AM Base Language Bug #7247: Dataset:READ-XML does nothing
Ovidiu Maxiniuc wrote:
> Review of 7247a/r14621.
>
> Fully unifying the de/serialization of XML and JSON is an am...
Igor Skornyakov
09:31 PM Base Language Bug #7247: Dataset:READ-XML does nothing
Review of 7247a/r14621.
Fully unifying the de/serialization of XML and JSON is an ambitious task I think of for so...
Ovidiu Maxiniuc
11:34 AM Database Bug #7388: Create server configuration container for cache sizes
Alexandru Lungu wrote:
> Constantin Asofiei wrote:
> > Yes, reading this at server startup will solve this.
> >
...
Eric Faulhaber
10:19 AM Database Bug #7388: Create server configuration container for cache sizes
Alexandru Lungu wrote:
> This is strange ...
A hard reload of the browser page before adding a task history entry...
Eric Faulhaber
06:58 AM Database Bug #7388: Create server configuration container for cache sizes
This is strange ... Alexandru Lungu
06:57 AM Database Bug #7388: Create server configuration container for cache sizes
Constantin Asofiei wrote:
> Yes, reading this at server startup will solve this.
>
> The problem is that director...
Alexandru Lungu
05:26 AM Database Bug #7388: Create server configuration container for cache sizes
I already committed 7388a.rev14618, but will make the changes to read the cache size values at runtime. Dănuț Filimon
04:55 AM Database Bug #7388: Create server configuration container for cache sizes
Yes, reading this at server startup will solve this.
The problem is that directory is being read while another cod...
Constantin Asofiei
04:26 AM Database Bug #7388: Create server configuration container for cache sizes
Constantin Asofiei wrote:
> Please see #7398 for issues we have with the admin console, related to these static cons...
Alexandru Lungu
04:02 AM Database Bug #7388: Create server configuration container for cache sizes
Please see #7398 for issues we have with the admin console, related to these static constructors which read from dire... Constantin Asofiei
03:47 AM Database Bug #7388 (WIP): Create server configuration container for cache sizes
I created 7388a. Please commit your changes there. If everything is alright, I will do the merge. Alexandru Lungu
03:44 AM Database Bug #7388: Create server configuration container for cache sizes
I did a few changes as you suggested:
* Changed the name of a few cache nodes;
* Simplified the directory-reading c...
Dănuț Filimon
11:12 AM Database Feature #7404: Trasform replace-mode into append-mode when target table is empty
Ștefan, I will put you up-to-date with the FWD implementation of @copy-temp-table@:
*4GL logic*
@copy-temp-table@...
Alexandru Lungu
08:01 AM Database Feature #7404 (WIP): Trasform replace-mode into append-mode when target table is empty
Alexandru Lungu
11:09 AM Database Bug #7421: Check only the indexes that were changed when using Validation.checkMaxIndexSize
Good idea. @BaseRecord.getDirtyIndices@ already is invoked in several places in @Validation@. Can we re-use the value... Eric Faulhaber
08:46 AM Database Bug #7421: Check only the indexes that were changed when using Validation.checkMaxIndexSize
@Validation.checkMaxIndexSize@ is checking all indexes to detect if the maximum size was exceeded. This happens only ... Alexandru Lungu
08:42 AM Database Bug #7421 (WIP): Check only the indexes that were changed when using Validation.checkMaxIndexSize
Alexandru Lungu
09:43 AM Database Feature #7363: Improve H2 Value caching, hashing and equals
Ștefan, please prepare a commit on 7363b_h2 with your latest changes. Make sure you update #7363-11 accordingly. Also... Alexandru Lungu
08:51 AM Base Language Feature #6420: implement the AUDIT-ENABLED() built-in function
The changes are in the p2j branch 6422a Theodoros Theodorou
08:50 AM Base Language Feature #6420 (Review): implement the AUDIT-ENABLED() built-in function
Theodoros Theodorou
08:40 AM Database Bug #7420 (WIP): Optimize Cursor for scrolling AdaptiveQuery
This is a task in regard to a hot-spot in @AdaptiveQuery.setScrolling()@. It is called 7506, but it takes 795ms own t... Alexandru Lungu
08:13 AM Database Bug #7420 (Closed): Optimize Cursor for scrolling AdaptiveQuery
Alexandru Lungu
08:19 AM Testing Support #6856: user interface tests
Additional items to discuss:
* Should we use ABLUnit for tests that also need Sikuli or the Harness to handle the ...
Greg Shah
08:09 AM Runtime Infrastructure Feature #7418: assess the security of the Jetty web server
And we need to differentiate between FWD server jetty and FWD client jetty. Greg Shah
08:04 AM Runtime Infrastructure Feature #7418: assess the security of the Jetty web server
I think we should also document the full stack for each exposed endpoint including versions. For example for Keikai t... Hynek Cihlar
07:59 AM Runtime Infrastructure Feature #7418: assess the security of the Jetty web server
Constantin Asofiei wrote:
> * Hynek, is sheet.war starting another web server? If so, what URL is it using?
No, ...
Hynek Cihlar
06:54 AM Runtime Infrastructure Feature #7418: assess the security of the Jetty web server
The main internet-exposed point of FWD is the Jetty web server. This includes the web server running on the FWD serv... Constantin Asofiei
06:45 AM Runtime Infrastructure Feature #7418 (New): assess the security of the Jetty web server
Constantin Asofiei
07:39 AM Build and Source Control Support #5167: using static linking to eliminate the need to patch the system-wide ncurses
Greg Shah wrote:
> Eugenie Lyzenko wrote:
> > Greg Shah wrote:
> > > I've renamed and made edits to the wiki page ...
Eugenie Lyzenko
05:02 AM Build and Source Control Support #5167: using static linking to eliminate the need to patch the system-wide ncurses
> Seems like we need to update Redmine download directory replacing @setup_ncurses6x.sh@ with recent one from Roger.
...
Greg Shah
04:57 AM Build and Source Control Support #5167: using static linking to eliminate the need to patch the system-wide ncurses
> > Then there's patching @terminfo@. Is that now a one-time occurrence, or does that need to stay in the @manage_ter... Greg Shah
04:54 AM Build and Source Control Support #5167: using static linking to eliminate the need to patch the system-wide ncurses
Eugenie Lyzenko wrote:
> Greg Shah wrote:
> > I've renamed and made edits to the wiki page ([[p2j:Patching NCURSES ...
Greg Shah
09:18 PM Build and Source Control Support #5167: using static linking to eliminate the need to patch the system-wide ncurses
Eugenie Lyzenko wrote:
> Please remove the previous problematic script file to ensure the correct one will be used.
...
Roger Borrello
06:36 AM Database Bug #7413: DUMP-NAME is not guaranteed to be unique in the .df
Greg Shah wrote:
> Why would the dump-name itself be the cause of a collision?
Well, the index is unique, and I ass...
Constantin Asofiei
06:32 AM Database Bug #7413: DUMP-NAME is not guaranteed to be unique in the .df
Why would the dump-name itself be the cause of a collision?
What happens in OE when this same @.df@ is processed?
Greg Shah
06:09 AM Database Bug #7413: DUMP-NAME is not guaranteed to be unique in the .df
There is an unique index on the @_field._dump-name@, in the meta schema:... Constantin Asofiei
06:07 AM Database Bug #7413: DUMP-NAME is not guaranteed to be unique in the .df
If the 4GL doesn't care that the @DUMP-NAME@ is unique, why do we care? It seems like there is no compatibility requ... Greg Shah
05:13 AM Database Support #4550 (Closed): eliminate the need to place the p2jspi.jar in the JVM extension directory
Greg Shah
05:08 AM Database Feature #7416: Reiterate DatabaseStatistics and leverage to other database profling tools
@DatabaseStatistics@ is a good solution for query profiling on the FWD part. This was implemented before Hibernate an... Alexandru Lungu
05:05 AM Database Feature #7416 (Closed): Reiterate DatabaseStatistics and leverage to other database profling tools
Alexandru Lungu
03:49 AM Database Bug #7412 (WIP): PresortQuery ORDER BY has to many clauses
Danut, please investigate. The change should go to 7026e when ready. Alexandru Lungu

06/07/2023

07:30 PM Build and Source Control Support #5167: using static linking to eliminate the need to patch the system-wide ncurses
Roger Borrello wrote:
> So sorry... I had posted the version with "cr*p" in it. The subsequent one that supports Red...
Eugenie Lyzenko
07:12 PM Build and Source Control Support #5167: using static linking to eliminate the need to patch the system-wide ncurses
So sorry... I had posted the version with "cr*p" in it. The subsequent one that supports Red Hat should work better.
...
Roger Borrello
07:09 PM Build and Source Control Support #5167: using static linking to eliminate the need to patch the system-wide ncurses
Roger Borrello wrote:
> Eugenie Lyzenko wrote:
> > Thanks for this question. I have updated the static ncurses inst...
Eugenie Lyzenko
07:07 PM Build and Source Control Support #5167: using static linking to eliminate the need to patch the system-wide ncurses
Actually this one attached I have made updates that should work on Red Hat. I based it off the @patch_ncurses6-centos... Roger Borrello
06:31 PM Build and Source Control Support #5167: using static linking to eliminate the need to patch the system-wide ncurses
Eugenie Lyzenko wrote:
> Thanks for this question. I have updated the static ncurses instruction section.
>
> Bot...
Roger Borrello
05:59 PM Build and Source Control Support #5167: using static linking to eliminate the need to patch the system-wide ncurses
Roger Borrello wrote:
> Thanks... one more docker-related question. The docker image contained some runtime support ...
Eugenie Lyzenko
03:26 PM Build and Source Control Support #5167: using static linking to eliminate the need to patch the system-wide ncurses
Thanks... one more docker-related question. The docker image contained some runtime support packages:
* libncurses5-...
Roger Borrello
02:03 PM Build and Source Control Support #5167: using static linking to eliminate the need to patch the system-wide ncurses
Roger Borrello wrote:
> Greg Shah wrote:
> > I think we just create a new patched ncurses every time we build FWD f...
Eugenie Lyzenko
12:51 PM Build and Source Control Support #5167: using static linking to eliminate the need to patch the system-wide ncurses
Greg Shah wrote:
> I think we just create a new patched ncurses every time we build FWD for Docker. It will always ...
Roger Borrello
12:38 PM Build and Source Control Support #5167: using static linking to eliminate the need to patch the system-wide ncurses
Greg Shah wrote:
> I've renamed and made edits to the wiki page ([[p2j:Patching NCURSES Using Static Linking]]. I'v...
Eugenie Lyzenko
10:16 AM Build and Source Control Support #5167 (Closed): using static linking to eliminate the need to patch the system-wide ncurses
I've renamed and made edits to the wiki page ([[p2j:Patching NCURSES Using Static Linking]]. I've also linked it int... Greg Shah
07:19 PM Runtime Infrastructure Bug #7291: LOG-MANAGER to log on client-side
> Do I add the file headers before or after the review?
Generally, before. It helps explain the changes which mak...
Greg Shah
02:21 PM Runtime Infrastructure Bug #7291: LOG-MANAGER to log on client-side
Galya B wrote:
> Galya B wrote:
> > How do I configure @OSResourceManager.getInstance().isServerSideFileSystem()@ i...
Greg Shah
09:34 AM Runtime Infrastructure Bug #7291: LOG-MANAGER to log on client-side
Do I add the file headers before or after the review? Galya B
09:33 AM Runtime Infrastructure Bug #7291 (Review): LOG-MANAGER to log on client-side
7291a rebased on trunk r14616.
7291a r14626 tested and ready for review.
Galya B
09:31 AM Runtime Infrastructure Bug #7291: LOG-MANAGER to log on client-side
Galya B wrote:
> How do I configure @OSResourceManager.getInstance().isServerSideFileSystem()@ in directory.xml?
...
Galya B
04:40 AM Runtime Infrastructure Bug #7291: LOG-MANAGER to log on client-side
How do I configure @OSResourceManager.getInstance().isServerSideFileSystem()@ in directory.xml? Galya B
06:01 PM Base Language Feature #6422: implement auditing support including AUDIT-POLICY and AUDIT-CONTROL
* Added "Session.PK" and made sql string as private static.
* I also wasn't sure about this and I made an easy solut...
Theodoros Theodorou
03:35 PM Database Bug #7388: Create server configuration container for cache sizes
Dănuț Filimon wrote:
> I found the following to be configurable:
> * @BufferManager.convertedNames@, size is 10000;...
Eric Faulhaber
09:07 AM Database Bug #7388: Create server configuration container for cache sizes
I found the following to be configurable:
* @BufferManager.convertedNames@, size is 10000;
* @DynamicTablesHelper.c...
Dănuț Filimon
03:13 AM Database Bug #7388: Create server configuration container for cache sizes
Danut, please take time to navigate through the persistence / orm package of FWD and search for any cache which can h... Alexandru Lungu
02:37 PM Database Bug #7413: DUMP-NAME is not guaranteed to be unique in the .df
Constantin Asofiei wrote:
> If two tables have the same DUMP-NAME in the .df, the FWD can not start, as it enforces ...
Eric Faulhaber
12:22 PM Database Bug #7413: DUMP-NAME is not guaranteed to be unique in the .df
If two tables have the same DUMP-NAME in the .df, the FWD can not start, as it enforces an unique index in the meta t... Constantin Asofiei
12:20 PM Database Bug #7413 (New): DUMP-NAME is not guaranteed to be unique in the .df
Constantin Asofiei
01:54 PM Base Language Bug #7247: Dataset:READ-XML does nothing
Ovidiu: Please review 7247a. Greg Shah
10:09 AM Testing Feature #3704: enable automated testing for GUI (Swing and web clients)
Does #3 really disqualify it as "running graphics inside the container"? Because Sikuli would, again, need to run on ... Roger Borrello
10:05 AM Testing Feature #3704: enable automated testing for GUI (Swing and web clients)
It would be advantageous to have a graphical environment in a Docker container, so that the variability of graphics c... Roger Borrello
09:35 AM Testing Support #6856: user interface tests
For details on using Sikuli, see [[p2j:Automating GUI Testing]].
Let's discuss the issues that the Acorn team has ...
Greg Shah
08:25 AM Database Feature #7365 (WIP): Avoid using reflection in generating BDT
Radu, please check @BufferFieldImpl.changeValue@. Consider extending @BaseDataTypeFactory@ with a new method to handl... Alexandru Lungu
08:24 AM Database Bug #7412: PresortQuery ORDER BY has to many clauses
I have the following SQL generated in H2 for a @PresortQuery@:... Alexandru Lungu
06:56 AM Database Bug #7412 (Closed): PresortQuery ORDER BY has to many clauses
Alexandru Lungu
08:24 AM Database Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...
The test failure @tests/dataset/TestTopNavQuery.cls@ method @TestSetInvalid@, throws 3 errors instead of 2.
The unex...
Maciej Zieniuk
04:04 AM Database Bug #7035 (Review): Extract query parameters from statically converted FQL
Considering the JMX results of hit/miss before/after static query parameter extraction, I think this effort can be dr... Alexandru Lungu

06/06/2023

06:36 PM Build and Source Control Support #5167: using static linking to eliminate the need to patch the system-wide ncurses
Branch @5167a@ was merged to trunk as revno @14616@ then it was archived.
This change will be on replica later tod...
Eugenie Lyzenko
05:46 PM Build and Source Control Support #5167: using static linking to eliminate the need to patch the system-wide ncurses
Greg Shah wrote:
> You can go ahead and merge to trunk. Please provide documentation on how to use it in the merge ...
Eugenie Lyzenko
05:39 PM Build and Source Control Support #5167: using static linking to eliminate the need to patch the system-wide ncurses
You can go ahead and merge to trunk. Please provide documentation on how to use it in the merge email. Greg Shah
05:29 PM Build and Source Control Support #5167: using static linking to eliminate the need to patch the system-wide ncurses
I think we just create a new patched ncurses every time we build FWD for Docker. It will always be the latest availa... Greg Shah
03:19 PM Build and Source Control Support #5167: using static linking to eliminate the need to patch the system-wide ncurses
Roger Borrello wrote:
> Eugenie Lyzenko wrote:
> > >Or is there an ongoing need to hook @apt@ still?
> >
> > I d...
Eugenie Lyzenko
02:23 PM Build and Source Control Support #5167: using static linking to eliminate the need to patch the system-wide ncurses
Eugenie Lyzenko wrote:
> >Or is there an ongoing need to hook @apt@ still?
>
> I do not know any such requirement...
Roger Borrello
02:04 PM Build and Source Control Support #5167: using static linking to eliminate the need to patch the system-wide ncurses
Roger Borrello wrote:
> The container project to build FWD Docker images will need to modify the "patching" process....
Eugenie Lyzenko
01:39 PM Build and Source Control Support #5167: using static linking to eliminate the need to patch the system-wide ncurses
The container project to build FWD Docker images will need to modify the "patching" process.
Currently it unzips t...
Roger Borrello
01:25 PM Build and Source Control Support #5167: using static linking to eliminate the need to patch the system-wide ncurses
Roger Borrello wrote:
> Greg Shah wrote:
> > > if we are planning that everyone would abandon the arduous ncurses ...
Eugenie Lyzenko
01:18 PM Build and Source Control Support #5167: using static linking to eliminate the need to patch the system-wide ncurses
Greg Shah wrote:
> > if we are planning that everyone would abandon the arduous ncurses patching
>
> To be clear...
Roger Borrello
01:03 PM Build and Source Control Support #5167: using static linking to eliminate the need to patch the system-wide ncurses
> if we are planning that everyone would abandon the arduous ncurses patching
To be clear, this doesn't avoid pat...
Greg Shah
11:51 AM Build and Source Control Support #5167: using static linking to eliminate the need to patch the system-wide ncurses
Yes, let's avoid the more complex naming. If everything is working, then we can move ahead with this branch. Greg Shah
11:34 AM Build and Source Control Support #5167: using static linking to eliminate the need to patch the system-wide ncurses
Greg Shah wrote:
> Roger: Please test 5167a with a real customer application using both static and non-static approa...
Roger Borrello
11:03 AM Build and Source Control Support #5167: using static linking to eliminate the need to patch the system-wide ncurses
Roger Borrello wrote:
> Eugenie Lyzenko wrote:
> > I think no need to have both libraries with different names. You...
Eugenie Lyzenko
10:46 AM Build and Source Control Support #5167: using static linking to eliminate the need to patch the system-wide ncurses
Eugenie Lyzenko wrote:
> I think no need to have both libraries with different names. You can identify the static ve...
Roger Borrello
10:22 AM Build and Source Control Support #5167: using static linking to eliminate the need to patch the system-wide ncurses
Roger Borrello wrote:
> Is the testing methodology to build FWD with/without:
> [...]
> in my environment, and uti...
Eugenie Lyzenko
10:13 AM Build and Source Control Support #5167: using static linking to eliminate the need to patch the system-wide ncurses
Is the testing methodology to build FWD with/without:... Roger Borrello
10:07 AM Build and Source Control Support #5167: using static linking to eliminate the need to patch the system-wide ncurses
Roger Borrello wrote:
> Greg Shah wrote:
> > Roger: Please test 5167a with a real customer application using both s...
Eugenie Lyzenko
10:05 AM Build and Source Control Support #5167: using static linking to eliminate the need to patch the system-wide ncurses
The @5167a@ rebased with trunk revision @14615@. The new revision is @14618@. Eugenie Lyzenko
09:57 AM Build and Source Control Support #5167: using static linking to eliminate the need to patch the system-wide ncurses
Greg Shah wrote:
> Roger: Please test 5167a with a real customer application using both static and non-static approa...
Roger Borrello
09:54 AM Build and Source Control Support #5167: using static linking to eliminate the need to patch the system-wide ncurses
Roger: Please test 5167a with a real customer application using both static and non-static approaches. Greg Shah
09:32 AM Build and Source Control Support #5167: using static linking to eliminate the need to patch the system-wide ncurses
The @5167a@ rebased with trunk revision @14614@. The new revision is @14617@. Eugenie Lyzenko
11:17 AM Database Feature #6628: port PostgreSQL native user defined functions to MariaDB
Eric Faulhaber wrote:
> Igor Skornyakov wrote:
> > I'm trying to re-test error handler suppoprt for MariaDB, but ca...
Igor Skornyakov
10:29 AM Database Feature #6628: port PostgreSQL native user defined functions to MariaDB
Igor Skornyakov wrote:
> I'm trying to re-test error handler suppoprt for MariaDB, but cannot create a database, get...
Eric Faulhaber
09:55 AM Database Feature #6628: port PostgreSQL native user defined functions to MariaDB
I'm trying to re-test error handler suppoprt for MariaDB, but cannot create a database, getting the following errors ... Igor Skornyakov
07:59 AM Database Feature #6628: port PostgreSQL native user defined functions to MariaDB
Greg Shah wrote:
> It still adds the cost of UUID generation to the query. This still seems costly. Why not use a ...
Igor Skornyakov
07:56 AM Database Feature #6628: port PostgreSQL native user defined functions to MariaDB
It still adds the cost of UUID generation to the query. This still seems costly. Why not use a sequence if you need... Greg Shah
07:45 AM Database Feature #6628: port PostgreSQL native user defined functions to MariaDB
Greg Shah wrote:
> Are you saying that every guarded UDF execution requires a UUID to be generated? That seems expe...
Igor Skornyakov
07:30 AM Database Feature #6628: port PostgreSQL native user defined functions to MariaDB
Are you saying that every guarded UDF execution requires a UUID to be generated? That seems expensive. Greg Shah
05:05 AM Database Feature #6628: port PostgreSQL native user defined functions to MariaDB
Eric Faulhaber wrote:
> Igor, as the Maria UDF implementation of the nested CAN-FIND error-handling is quite differe...
Igor Skornyakov
03:12 AM Database Feature #6628: port PostgreSQL native user defined functions to MariaDB
Rebased 6628a to the trunk rev.14613
Pushed up to revision 14614.
Igor Skornyakov
09:43 AM Database Bug #7035: Extract query parameters from statically converted FQL
I retested the changes on a customer application as you said and the results are almost the same.
|_. JMX ...
Dănuț Filimon
05:36 AM Database Bug #7035: Extract query parameters from statically converted FQL
I've redone the tests with your JMX. I get the following results in Cold/Warm runs on a customer application.
|_. ...
Alexandru Lungu
08:41 AM Database Feature #7323: Implement soft unique index in FWD-H2
*Review to 7323a, rev. 14587*
* I don't think we should always allow @soft_unique@ right from @Dialect@. Better exte...
Alexandru Lungu
07:55 AM Database Feature #7323: Implement soft unique index in FWD-H2
I am checking out this right now.
I will run some tests/profiling on my own and keep you updated.
Anyway, I fe...
Alexandru Lungu
07:57 AM Base Language Bug #7299: resolution of the target OO method in chained calls with poly arguments
Greg Shah wrote:
> > Marian: Please have your team review the documentation on method overloading in #3751-492 and l...
Marian Edu
05:39 AM Database Bug #7389: Make fast-copy statements cachable
*Committed 7389a.rev14593.* Added @FastCopyHelper.safeTableCopyNoMapping@ that doesn't use mapping.
At the moment, t...
Dănuț Filimon

06/05/2023

04:25 PM Build and Source Control Support #5167: using static linking to eliminate the need to patch the system-wide ncurses
The @5167a@ rebased with trunk revision @14612@. The new revision is @14615@. Eugenie Lyzenko
03:50 PM Database Feature #6628: port PostgreSQL native user defined functions to MariaDB
Eric Faulhaber wrote:
> Igor, as the Maria UDF implementation of the nested CAN-FIND error-handling is quite differe...
Igor Skornyakov
03:43 PM Database Feature #6628: port PostgreSQL native user defined functions to MariaDB
Igor, as the Maria UDF implementation of the nested CAN-FIND error-handling is quite different than the PostgreSQL im... Eric Faulhaber
03:18 PM Base Language Feature #6422: implement auditing support including AUDIT-POLICY and AUDIT-CONTROL
Code review 6422a/14552-14554:
I reviewed the code from the perspective of persistence and coding standards, but T...
Eric Faulhaber
01:20 PM Runtime Infrastructure Bug #7291: LOG-MANAGER to log on client-side
A few notes:
* Java file lock is respected by other Java processes on Windows and Linux and they will wait indefinit...
Galya B
01:12 PM Base Language Bug #7299: resolution of the target OO method in chained calls with poly arguments
> Marian: Please have your team review the documentation on method overloading in #3751-492 and look at the code in @... Greg Shah
11:58 AM Base Language Bug #7299: resolution of the target OO method in chained calls with poly arguments
Rebased 7299a/14551 from trunk rev 14612 - new rev 14613.
7299a rev 14614 replaces upPath with the token list vers...
Constantin Asofiei
11:36 AM Conversion Tools Feature #7390: replace DOM with StAX in XmlFilePlugin
I've used a 'sample profiler' when converting a very large application, and the DOM parsing does stand out (both heap... Constantin Asofiei
10:32 AM Base Language Bug #7301 (Closed): pre-scan of a 'DEFINE BUFFER btt1 FOR btt1' from within a method
Greg Shah
10:30 AM Base Language Bug #7301: pre-scan of a 'DEFINE BUFFER btt1 FOR btt1' from within a method
7199c was merged to trunk rev 14610 and archived Constantin Asofiei
10:32 AM Base Language Bug #7304 (Closed): UN_MINUS resolves to int64 instead of integer in ExpressionConversionWorker
Greg Shah
10:29 AM Base Language Bug #7304: UN_MINUS resolves to int64 instead of integer in ExpressionConversionWorker
7199c was merged to trunk rev 14610 and archived Constantin Asofiei
10:31 AM Base Language Bug #7250 (Closed): PROMPT-FOR with a table field reference resolves to NO-REFERENCE in OpenEdge
Greg Shah
10:29 AM Base Language Bug #7250: PROMPT-FOR with a table field reference resolves to NO-REFERENCE in OpenEdge
7199c was merged to trunk rev 14610 and archived Constantin Asofiei
10:31 AM Base Language Bug #7308 (Closed): 4GL does not validate the extent index in a 'DEF VAR ... LIKE v1[100]' case, ...
Greg Shah
10:29 AM Base Language Bug #7308: 4GL does not validate the extent index in a 'DEF VAR ... LIKE v1[100]' case, where v1 ...
7199c was merged to trunk rev 14610 and archived Constantin Asofiei
10:31 AM Base Language Bug #7310 (Closed): buffer scope in constructor/destructor is not computed correctly
Greg Shah
10:29 AM Base Language Bug #7310: buffer scope in constructor/destructor is not computed correctly
7199c was merged to trunk rev 14610 and archived Constantin Asofiei
10:31 AM Base Language Bug #7311 (Closed): abs(integer) must return int64
Greg Shah
10:29 AM Base Language Bug #7311: abs(integer) must return int64
7199c was merged to trunk rev 14610 and archived Constantin Asofiei
10:31 AM Base Language Bug #7312 (Closed): mtime(character) is allowed in 4GL
Greg Shah
10:29 AM Base Language Bug #7312: mtime(character) is allowed in 4GL
7199c was merged to trunk rev 14610 and archived Constantin Asofiei
10:30 AM Base Language Bug #7313 (Closed): regression in '<record-phrase> USING FRAME f field'
Greg Shah
10:29 AM Base Language Bug #7313: regression in '<record-phrase> USING FRAME f field'
7199c was merged to trunk rev 14610 and archived Constantin Asofiei
10:30 AM Base Language Bug #7314 (Closed): conversion issue for FIRST-OF(f1) when there is a collision between the field...
Greg Shah
10:28 AM Base Language Bug #7314: conversion issue for FIRST-OF(f1) when there is a collision between the field name and...
7199c was merged to trunk rev 14610 and archived Constantin Asofiei
10:30 AM Base Language Feature #6410: implement additional built-in OO classes/interfaces
Constantin Asofiei wrote:
> 7199c rev 14559 contains the implementation for @OpenEdge.Core.System.ArgumentError@. R...
Constantin Asofiei
10:30 AM Base Language Bug #7315 (Closed): unknown literal passed as an argument to a 'object' parameter
Greg Shah
10:28 AM Base Language Bug #7315: unknown literal passed as an argument to a 'object' parameter
7199c was merged to trunk rev 14610 and archived Constantin Asofiei
10:30 AM Base Language Bug #7240: conversion problem related to ENTERED in a IF expr
7199c was merged to trunk rev 14610 and archived Constantin Asofiei
10:29 AM Base Language Bug #7316 (Closed): regression in 'ACCUM ... extVar' expansion - subscript not emitted
Greg Shah
10:28 AM Base Language Bug #7316: regression in 'ACCUM ... extVar' expansion - subscript not emitted
7199c was merged to trunk rev 14610 and archived Constantin Asofiei
10:29 AM Base Language Bug #7317 (Closed): accumulator using another accumulator as expression
Greg Shah
10:28 AM Base Language Bug #7317: accumulator using another accumulator as expression
7199c was merged to trunk rev 14610 and archived Constantin Asofiei
10:28 AM Base Language Bug #7206: shared frame defined with the same name but different widgets
7199c was merged to trunk rev 14610 and archived. Constantin Asofiei
10:20 AM Base Language Bug #7198 (Test): conversion of empty UPDATE/SET/PROMPT-FOR statements
Greg Shah
10:15 AM Base Language Bug #7198: conversion of empty UPDATE/SET/PROMPT-FOR statements
Branch 7198a was merged to trunk rev 14609 and archived. Constantin Asofiei
08:10 AM Base Language Bug #7198: conversion of empty UPDATE/SET/PROMPT-FOR statements
You can merge 7198a to trunk after 7395d. Greg Shah
06:04 AM Base Language Feature #6649: improve the performance or SourceNameMapper runtime
Hynek Cihlar wrote:
> Joe Davis wrote:
> > The current status is that it's ready for review, but I'm trying to figu...
Hynek Cihlar

06/03/2023

05:23 PM Build and Source Control Support #5167: using static linking to eliminate the need to patch the system-wide ncurses
The @5167a@ rebased with trunk revision @14606@. The new revision is @14609@. Eugenie Lyzenko
08:16 PM Build and Source Control Support #5167: using static linking to eliminate the need to patch the system-wide ncurses
The @5167a@ rebased with trunk revision @14605@. The new revision is @14608@. Eugenie Lyzenko

06/02/2023

11:22 AM Base Language Bug #7198: conversion of empty UPDATE/SET/PROMPT-FOR statements
7198a rev 14507 was rebased from trunk rev 14604 - new rev 14605.
rev 14606 has an adjustment for new downPath(tok...
Constantin Asofiei
10:00 AM Base Language Bug #7198: conversion of empty UPDATE/SET/PROMPT-FOR statements
Greg Shah wrote:
> > There is more work for ENABLE and any other UI statements. Plus I don't know what happens if t...
Constantin Asofiei
09:57 AM Base Language Bug #7198: conversion of empty UPDATE/SET/PROMPT-FOR statements
> There is more work for ENABLE and any other UI statements. Plus I don't know what happens if there are @DO WITH FR... Greg Shah
10:25 AM Conversion Tools Bug #6738: incremental conversion when deleting program or class files
We have a customer (from #7106) who is having to run full reconversions often because of deleted files. The conversi... Greg Shah
04:21 AM Database Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...
Hi Ovidiu, yes that will work. Thanks Maciej Zieniuk
09:10 PM Build and Source Control Support #5167: using static linking to eliminate the need to patch the system-wide ncurses
The @5167a@ rebased with trunk revision @14599@. The new revision is @14602@. Eugenie Lyzenko

06/01/2023

06:12 PM Database Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...
What do you mean by _"we probably do not want to record the 14457 error at all?"_.
This is a normal error conditio...
Ovidiu Maxiniuc
05:03 AM Database Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...
For the @tests/dataset/TestSetCallback.cls@ test @wrongRoutineNameClass@ and @wrightRoutineNameButWrongMethodDefiniti... Maciej Zieniuk
03:39 PM Base Language Feature #6422 (Review): implement auditing support including AUDIT-POLICY and AUDIT-CONTROL
Theodoros Theodorou
12:35 PM Database Feature #6813: analyze and improve performance of dynamic conversion of temp-tables and queries
6813c was merged to trunk rev 14596 and archived. Constantin Asofiei
11:54 AM Database Feature #6813: analyze and improve performance of dynamic conversion of temp-tables and queries
You can merge to trunk. Greg Shah
09:46 AM Runtime Infrastructure Bug #7291: LOG-MANAGER to log on client-side
> Can we have clients running in the server JVM? Basically my question is if @ThinClient@ static fields will always b... Greg Shah
07:16 AM Runtime Infrastructure Bug #7291: LOG-MANAGER to log on client-side
Can we have clients running in the server JVM? Basically my question is if @ThinClient@ static fields will always be ... Galya B
09:12 AM Database Feature #7365: Avoid using reflection in generating BDT
I've added a check for @ObjectVar@ in @BaseDataTypeFactory@. The commit is on 7026e, rev. 14596. Radu Apetrii
08:30 AM Database Bug #7211: Several H2 connections for one single session
I might be wrong on this, but I am not seeing tens of messages any more.
I navigated a large customer application ...
Radu Apetrii
08:30 AM Database Feature #7404: Trasform replace-mode into append-mode when target table is empty
In FWD, @copy-temp-table@ append mode is faster as it can be resolved using fast-copy (INSERT INTO SELECT FROM).
T...
Alexandru Lungu
08:11 AM Database Feature #7404 (Closed): Trasform replace-mode into append-mode when target table is empty
Alexandru Lungu
08:10 AM Database Bug #7403: Copy-temp-table with replace-mode should replace already inserted records
This is quite a weird use-case:... Alexandru Lungu
07:38 AM Database Bug #7403 (Closed): Copy-temp-table with replace-mode should replace already inserted records
Alexandru Lungu
07:37 AM Database Bug #7389: Make fast-copy statements cachable
I have the following quite nice test-case. Please make sure the final answer is still @1 2@. -I am a bit surprised th... Alexandru Lungu
07:08 AM Database Feature #7323: Implement soft unique index in FWD-H2
*I've committed to 7323a, rev. 14587, and 7323a_h2, rev. 21.*
These changes target the addition of @VALIDATE@ and @S...
Radu Apetrii
04:47 AM Database Feature #7323: Implement soft unique index in FWD-H2
Radu, please commit this changes to 7323a. I would like to do a second test on a customer application. Also, please l... Alexandru Lungu
06:46 AM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Task branch 5703d was merged to trunk as rev 14595 and archived. Email sent. Galya B
06:29 AM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
> Can you confirm this change ?
Yes, confirmed. It is a matter of preference. Some will like the change, some wi...
Greg Shah
05:01 AM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Also most FWD devs trace issues on the console, while I do it using the files, so my opinion may differ based on that... Galya B
04:56 AM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Greg Shah wrote:
> In @LoggingUtil@ please set @SORTABLE_DATETIME_FORMAT@ to "%tY%tm%td_%tH%tM%tS". It just condens...
Galya B
04:45 AM Database Feature #6630 (Review): optimize return of table parameter
Usually, temp-tables won't hold 10.000 records from what I have seen. We should rely on the 100/1000 tests with 5/10 ... Alexandru Lungu
04:35 AM Database Bug #7334 (Review): Reclaim used sessions to improve performance
I am quite pleased with your results and my performance tests (-2.7%).
However, as this is quite a change on the s...
Alexandru Lungu
04:03 AM Database Bug #7334: Reclaim used sessions to improve performance
Alexandru Lungu wrote:
> Danut, please focus on finishing the tests here. I will like to do some last checks and mer...
Dănuț Filimon
08:34 PM Conversion Tools Feature #7390: replace DOM with StAX in XmlFilePlugin
Why recursion is a problem? We are serializing an AST, which is tree. There are no circular references between AST no... Ovidiu Maxiniuc

05/31/2023

04:16 PM Build and Source Control Support #5167: using static linking to eliminate the need to patch the system-wide ncurses
The @5167a@ rebased with trunk revision @14594@. The new revision is @14597@. Eugenie Lyzenko
03:41 PM Base Language Feature #4065: server-side processing of client platform dependencies
4065d rebased and merged to trunk as revision 14594. The branch was archived. Hynek Cihlar
03:30 PM Base Language Feature #4065: server-side processing of client platform dependencies
Code Review Task Branch 4065d Revision 14593
No objections. You can merge to trunk now.
Greg Shah
03:24 PM Base Language Feature #4065: server-side processing of client platform dependencies
The regression fix in #4065-150 was checked in 4065d and is ready to be merged to trunk once it passes review. Hynek Cihlar
01:15 PM Base Language Feature #4065: server-side processing of client platform dependencies
Greg Shah wrote:
> Is the fix for #4065-150 in a branch?
Not yet AFAIK. I will create task branch 4065d for this....
Hynek Cihlar
08:52 AM Base Language Feature #4065: server-side processing of client platform dependencies
Is the fix for #4065-150 in a branch? Greg Shah
03:24 PM Database Feature #7037 (Test): remove dirty share manager
Greg Shah
03:20 PM Database Feature #7037: remove dirty share manager
7037b has been merged into the trunk as bzr revision 14593. Stanislav Lomany
02:43 PM Database Feature #7037: remove dirty share manager
Rebased task branch 7037b from FWD trunk revision 14592. Stanislav Lomany
02:11 PM Database Feature #7037: remove dirty share manager
Go ahead and merge now. Greg Shah
02:08 PM Database Feature #7037: remove dirty share manager
From my point of view, yes. Eric Faulhaber
01:51 PM Database Feature #7037: remove dirty share manager
Should I rebase and commit? Stanislav Lomany
01:48 PM Database Feature #7037: remove dirty share manager
Greg Shah wrote:
> Eric: We are blocked on your code review.
How so? My code review was done in #7037-50. Everyth...
Eric Faulhaber
10:13 AM Database Feature #7037: remove dirty share manager
Eric: We are blocked on your code review. Greg Shah
03:00 PM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Code Review Task Branch 5703d Revisions 14593 and 14594
The changes are good.
In @LoggingUtil@ please set @SORT...
Greg Shah
02:09 PM Runtime Infrastructure Bug #7291: LOG-MANAGER to log on client-side
I'm fine with the plan. Greg Shah
12:25 PM Runtime Infrastructure Bug #7291: LOG-MANAGER to log on client-side
Then what about making the design as simple and and clear as possible.
* @LOG-MANAGER@ will live on the server and t...
Galya B
09:06 AM Runtime Infrastructure Bug #7291: LOG-MANAGER to log on client-side
We need to move ahead with this task. We cannot assume that all customers can use server-side logging for @LOG-MANAG... Greg Shah
12:38 PM Database Feature #7365: Avoid using reflection in generating BDT
I think a type is missing, I get this in a customer app:... Constantin Asofiei
11:57 AM Base Language Feature #3853: implement LOG-MANAGER runtime
Here are my startup args tests. Now with focus on error thrown or shown. The current impl will have to be revised.
...
Galya B
11:09 AM Database Bug #7334: Reclaim used sessions to improve performance
The changes are really good, providing a -2.7% performance increase. I didn't found any issues while testing.
Danut,...
Alexandru Lungu
03:53 AM Database Bug #7334: Reclaim used sessions to improve performance
Rebased 7334a to trunk / rev. 14592 7334a is now at rev. 14596
I am doing a test/profiling round with the current ...
Alexandru Lungu
10:37 AM Database Feature #7363: Improve H2 Value caching, hashing and equals
I updated the table according to the new changes.
I changed @get@ method in @ValueBytes@ and @ValueString@, @fromNan...
Ștefan Roman
08:59 AM Database Feature #7363: Improve H2 Value caching, hashing and equals
Some remarks:
* @Bytes@, @String@ and @Date@ as I understand are still WIP
* @Date@ has an interesting static AP...
Alexandru Lungu
07:12 AM Database Feature #7363: Improve H2 Value caching, hashing and equals
I started with the @ValueStringIgnoreCase@ and everything worked like you suggested. @Value.cache(int type, Object lo... Ștefan Roman
08:57 AM Base Language Bug #7247 (Review): Dataset:READ-XML does nothing
Finished.
Committed to 7247a/14597.
Please review.
Thank you.
Igor Skornyakov
08:36 AM Database Feature #6813: analyze and improve performance of dynamic conversion of temp-tables and queries
Greg Shah wrote:
> Are you still trying to get 6813c into trunk?
I've made the cleanup changes and rebased from tru...
Constantin Asofiei
07:27 AM Database Feature #7323: Implement soft unique index in FWD-H2
This looks OK to me, go ahead with the implementation.
Please do a second check for the @flush@ method. Is there any...
Alexandru Lungu
07:17 AM Database Feature #7323: Implement soft unique index in FWD-H2
I've added the @SOFT_UNIQUE@ and @VALIDATE@ keywords to both FWD and FWD-H2 without affecting the current behavior.
...
Radu Apetrii
07:26 AM Database Feature #7194: Avoid generating an ORDER-BY clause if not required

Alexandru Lungu wrote:
> Radu, please post your attempt on #7194-16 here (the test-case). AFAIK, you couldn't ge...
Radu Apetrii
02:47 AM Database Feature #7194: Avoid generating an ORDER-BY clause if not required
Radu, please post your attempt on #7194-16 here (the test-case). AFAIK, you couldn't generate two records with the sa... Alexandru Lungu
07:01 AM Database Feature #6630: optimize return of table parameter
I redesigned my test case and profiled both @AdaptiveQuery@ and @PreselectQuery@. I used a temp-table with 100 fields... Dănuț Filimon
06:48 AM Database Bug #7389 (WIP): Make fast-copy statements cachable
This basically means that we should focus on the append mode: this is the one that usually triggers @MASTER_PK_MAPPIN... Alexandru Lungu
05:22 AM Database Bug #7389: Make fast-copy statements cachable
I tested a large customer application (~30 minutes) and managed to gather the following data about the number and typ... Dănuț Filimon
03:17 AM Database Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...
override the @NAME@ attribute and you will see that it differs. I did this testing in 4GL and FWD code in the getter ... Maciej Zieniuk
 

Also available in: Atom