Project

General

Profile

Activity

From 10/22/2023 to 11/20/2023

11/21/2023

09:17 PM Database Feature #4722: data import should be able to run with only the converted application jar file (an...
Ovidiu... I must have really missed something for H2 regarding the use of DDL in the application jar file. I hadn't s... Roger Borrello
07:05 PM Database Feature #4722: data import should be able to run with only the converted application jar file (an...
Ovidiu, I am using this branch, and getting an error finding the ddl, when it is in the @hotel.jar@ file. When I unzi... Roger Borrello

11/20/2023

05:10 PM Database Feature #4722: data import should be able to run with only the converted application jar file (an...
I fixed the minor typo and checked in revision 14837. Roger Borrello
04:11 PM Database Feature #4722: data import should be able to run with only the converted application jar file (an...
Ovidiu Maxiniuc wrote:
> I committed my 4722b changes as r14836.
> Nothing fancy, just more verbose logs and allowe...
Roger Borrello
03:35 PM Database Feature #4722: data import should be able to run with only the converted application jar file (an...
I committed my 4722b changes as r14836.
Nothing fancy, just more verbose logs and allowed loading of FS resources if...
Ovidiu Maxiniuc
08:48 AM Database Feature #4722: data import should be able to run with only the converted application jar file (an...
Ovidiu: Do you still have changes to put into 4722b? Greg Shah
08:45 AM Database Feature #4722: data import should be able to run with only the converted application jar file (an...
Branch 4722b was rebased to trunk_14834 and is at revision 14835. Roger Borrello
10:08 AM Database Feature #7416: Reiterate DatabaseStatistics and leverage to other database profling tools
Okay then, please continue working on the review. Andrei, disregard my comment. Alexandru Lungu
09:49 AM Database Feature #7416: Reiterate DatabaseStatistics and leverage to other database profling tools
Alexandru Lungu wrote:
> As the review is quite detailed, Andrei [ai], can you manage clearing as many as the minor ...
Radu Apetrii
09:46 AM Database Feature #7416: Reiterate DatabaseStatistics and leverage to other database profling tools
As the review is quite detailed, Andrei [ai], can you manage clearing as many as the minor points above? If there are... Alexandru Lungu
07:21 AM Runtime Infrastructure Bug #8060: Admin Console login fails every first time (AdminServerImpl.setTargetLive)
Can you move it or I need to create a new one? Galya B
07:20 AM Runtime Infrastructure Bug #8060: Admin Console login fails every first time (AdminServerImpl.setTargetLive)
Greg Shah wrote:
> Does this need to be in the customer project? It seems like a generic issue.
My bad. It's gen...
Galya B
07:19 AM Runtime Infrastructure Bug #8060: Admin Console login fails every first time (AdminServerImpl.setTargetLive)
Does this need to be in the customer project? It seems like a generic issue. Greg Shah
05:16 AM Runtime Infrastructure Bug #8060: Admin Console login fails every first time (AdminServerImpl.setTargetLive)
On fresh server start the first attempt to login in the Admin Console with correct credentials always fails:
!admi...
Galya B
05:13 AM Runtime Infrastructure Bug #8060 (Test): Admin Console login fails every first time (AdminServerImpl.setTargetLive)
Galya B
06:03 AM Base Language Feature #6649: improve the performance or SourceNameMapper runtime
On a large POC, the total improvement of the changes in 6649b was of -0.3%. Alexandru Lungu
04:00 AM Base Language Feature #6649: improve the performance or SourceNameMapper runtime
Hynek Cihlar wrote:
> Do you mean 70 individual propath entries or 70 paths in a single propath?
One single long ...
Alexandru Lungu
02:34 AM Base Language Feature #6649: improve the performance or SourceNameMapper runtime
Alexandru Lungu wrote:
> I've done some tests, and there were no obvious problems. I am moving this to the profiler ...
Hynek Cihlar

11/18/2023

02:23 PM User Interface Bug #7515: FILL-IN: editing dates issues
Running MAJIC tests revealed at teast two regressions in ChUI in @7019a@:
# incorrect behavior of date @FILL-IN@ f...
Vladimir Tsichevski
07:33 PM Base Language Feature #6431: implement support to allow CPINTERNAL set to UTF-8 and CP936
Marian Edu wrote:
> Hi Theodoros, just pushed the i18n tests on testcases (rev#1514), we're still working one some c...
Theodoros Theodorou

11/17/2023

06:31 PM Database Bug #7999: FWD does not honor FIELDS/EXCEPT at dynamic queries
Review of 7999a, r14833.
Good job. The goal of the task was reached. But I have some things to note, mainly becaus...
Ovidiu Maxiniuc
12:49 PM Database Bug #7999: FWD does not honor FIELDS/EXCEPT at dynamic queries
Ovidiu: Please review. Greg Shah
12:43 PM Database Bug #7999 (Review): FWD does not honor FIELDS/EXCEPT at dynamic queries
Alexandru Lungu
10:05 AM Database Bug #7999: FWD does not honor FIELDS/EXCEPT at dynamic queries
Committed on 7999a, revision 14833.
- @DynamicQueryHelper@, added methods to traverse @fields@ and @except@ phrases...
Eduard Soltan
09:09 AM Database Bug #7454 (Test): Make ValueStringIgnoreCase the default generated value for setString in FWD-H2
Branch 7454a was merged into trunk as rev. 14833 and archived. Alexandru Lungu
08:17 AM Database Bug #7454: Make ValueStringIgnoreCase the default generated value for setString in FWD-H2
You can merge now. Greg Shah
07:51 AM Database Bug #7454: Make ValueStringIgnoreCase the default generated value for setString in FWD-H2
Regression tests passed successfully. *7454a can be merged - Greg, waiting for your call* Alexandru Lungu
08:47 AM Base Language Feature #6431: implement support to allow CPINTERNAL set to UTF-8 and CP936
Theodoros Theodorou wrote:
> Hello Marian. Greg asked me to coordinate with you that we do not do the same effort tw...
Marian Edu
07:41 AM Base Language Feature #6431: implement support to allow CPINTERNAL set to UTF-8 and CP936
Hello Marian. Greg asked me to coordinate with you that we do not do the same effort twice. Please have a look at @te... Theodoros Theodorou
07:11 AM Base Language Feature #6431: implement support to allow CPINTERNAL set to UTF-8 and CP936
Yes, it needs to be fixed. Such conversions should yield identical results. It seems likely that the cause is relat... Greg Shah
08:23 AM Base Language Feature #6649: improve the performance or SourceNameMapper runtime
Alexandru Lungu wrote:
> Mind that the search-path cache is not synchronized. Please add @synchronize@ to that acces...
Dănuț Filimon
08:13 AM Base Language Feature #6649: improve the performance or SourceNameMapper runtime
*Review of 6649b/rev.14808*
Mind that the search-path cache is not synchronized. Please add @synchronize@ to that ...
Alexandru Lungu
08:03 AM Base Language Feature #6649: improve the performance or SourceNameMapper runtime
Alexandru Lungu wrote:
> Some extra ideas:
>
> * Also, what about @convertedNames@? Can't it possible leak as we ...
Dănuț Filimon
07:33 AM Base Language Feature #6649: improve the performance or SourceNameMapper runtime
Alexandru Lungu wrote:
> Danut please fix #6649-131 - I am planning to start performance testing with 6649a as soon ...
Dănuț Filimon
07:08 AM Base Language Feature #6649: improve the performance or SourceNameMapper runtime
Some extra ideas:
* Also, what about @convertedNames@? Can't it possible leak as we are constantly adding to it th...
Alexandru Lungu
06:26 AM Base Language Feature #6649: improve the performance or SourceNameMapper runtime
I've done some tests, and there were no obvious problems. I am moving this to the profiler asap.
However, I want t...
Alexandru Lungu
04:04 AM Base Language Feature #6649: improve the performance or SourceNameMapper runtime
I converted a large application and generated a @name_map.xml@ with ~39k (~7k of OO classes) class-mappings and only ... Alexandru Lungu
07:50 AM Database Feature #6496: add equivalent support for -trig command line option
I have been working on this little by little between other high priority tasks. I intent to put more focus on this ta... Alexandru Donica
07:48 AM Database Feature #6496: add equivalent support for -trig command line option
Any progress here? Mind that we need a major performance drop for the upcoming week, and the addition of @-trig@ may ... Alexandru Lungu
07:18 AM User Interface Bug #7946 (Test): Default selection and current browse row color differs for different customers ...
Greg Shah
05:24 AM Database Feature #7382: Check performance of delete from vs drop table in H2
Alexandru Lungu wrote:
> Radu, please let me know if you managed to handle this to some extent. Otherwise, Eduard wi...
Radu Apetrii
05:23 AM Database Feature #7382: Check performance of delete from vs drop table in H2
Radu, please let me know if you managed to handle this to some extent. Otherwise, Eduard will continue working on this. Alexandru Lungu
04:05 AM Database Bug #8044 (Review): Fix "Failed direct-access due to Error direct accessing for finding record by...
*Committed 8044a/rev.14830* Normalized unknown value, date and datetime arguments. In the end, I used @dateValue()@ t... Dănuț Filimon

11/16/2023

06:03 PM Base Language Feature #6431: implement support to allow CPINTERNAL set to UTF-8 and CP936
Hello, I wrote a small test (chr_and_asc.p) which tests the conversion of a character from one code page to another (... Theodoros Theodorou
10:33 AM Database Bug #7454: Make ValueStringIgnoreCase the default generated value for setString in FWD-H2
Alexandru Lungu wrote:
> Profiled 7454a now and got -0.6% improvement. This was on-spot with the expectancy (or even...
Dănuț Filimon
09:36 AM Database Feature #4722: data import should be able to run with only the converted application jar file (an...
Greg Shah wrote:
> Does this branch only have the script change?
I believe Ovidiu had something for this branch:
...
Roger Borrello
05:37 AM Database Feature #4722: data import should be able to run with only the converted application jar file (an...
Does this branch only have the script change? Greg Shah
08:03 PM Database Feature #4722: data import should be able to run with only the converted application jar file (an...
Branch 4722b was rebased to trunk_14829 and is at revision 14830. Roger Borrello
06:04 AM Database Bug #8044: Fix "Failed direct-access due to Error direct accessing for finding record by unique i...
While I was testing a large application, there were not a lot of instances where the unknown value is normalized to n... Dănuț Filimon
04:34 AM Database Bug #8044: Fix "Failed direct-access due to Error direct accessing for finding record by unique i...
Please check the @DateType.setParameter@ function. It should do the same. Alexandru Lungu
04:32 AM Database Bug #8044: Fix "Failed direct-access due to Error direct accessing for finding record by unique i...
Alexandru Lungu wrote:
> Not quite; I was just seeing this pop up thousand of times.
>
> Please also mind handli...
Dănuț Filimon
04:21 AM Database Bug #8044: Fix "Failed direct-access due to Error direct accessing for finding record by unique i...
Not quite; I was just seeing this pop up thousand of times.
Please also mind handling:
* the unknown value as we...
Alexandru Lungu
03:53 AM Database Bug #8044: Fix "Failed direct-access due to Error direct accessing for finding record by unique i...
*Committed 8044a/rev.14829* Normalized @rowid@ and @longchar@ arguments.
Alexandru, can you provide a reproduction c...
Dănuț Filimon
12:40 AM Base Language Feature #6649: improve the performance or SourceNameMapper runtime
*Committed 6649b/rev.14807*. Fixed a NPE when there are no path-mapping nodes in name_map.xml. Dănuț Filimon

11/15/2023

09:51 AM Database Bug #7454 (Internal Test): Make ValueStringIgnoreCase the default generated value for setString i...
Profiled 7454a now and got -0.6% improvement. This was on-spot with the expectancy (or even quite better).
I will mo...
Alexandru Lungu
09:41 AM Database Bug #8044: Fix "Failed direct-access due to Error direct accessing for finding record by unique i...
I am still getting the same error but in a different process now, there is another object aside from @rowid@ that is ... Dănuț Filimon
09:21 AM Database Bug #8044: Fix "Failed direct-access due to Error direct accessing for finding record by unique i...
I have multiple warning where this direct access exception is logged in a customer application: @23/11/15 16:08:27.39... Dănuț Filimon
09:12 AM Database Bug #8044 (WIP): Fix "Failed direct-access due to Error direct accessing for finding record by un...
Alexandru Lungu
09:37 AM Database Bug #7731: performance improvements for FQLPreprocessor
Alexandru Lungu wrote:
> What internal tests should be done here, Danut? Are you able to do some smoke tests on larg...
Dănuț Filimon
09:32 AM Database Bug #7731: performance improvements for FQLPreprocessor
What internal tests should be done here, Danut? Are you able to do some smoke tests on large applications?
I can t...
Alexandru Lungu
08:23 AM Database Bug #7567: use Session.PK instead of DatabaseManager.PRIMARY_KEY wherever possible
If only we completed #7782, we could remove this useless @id@ workaround code. Problems like the above are just extr... Greg Shah
08:15 AM Database Bug #7567: use Session.PK instead of DatabaseManager.PRIMARY_KEY wherever possible
Here are the current scenarios that I tested with Hotel_GUI:
* 7567a without changes - @primaryKeyName="recid"@ and ...
Dănuț Filimon
05:18 AM Database Bug #7567: use Session.PK instead of DatabaseManager.PRIMARY_KEY wherever possible
It seems that the "recid" is hard coded in @SchemaConfig@ and is used by the meta database, this causes the server to... Dănuț Filimon
08:12 AM Base Language Feature #7045: re-implement "normal" (non-abend) stack unwinding to avoid throwing an exception
Understood. For such extensive changes to our control flow, it seems necessary. Greg Shah
08:09 AM Base Language Feature #7045: re-implement "normal" (non-abend) stack unwinding to avoid throwing an exception
Greg, I can do that for POC, but it will take me a day to have it converted. Also mind that I am already reconverting... Alexandru Lungu
07:31 AM Base Language Feature #7045: re-implement "normal" (non-abend) stack unwinding to avoid throwing an exception
If you think it is ready, let's get ChUI regression tests, ETF and the big POC tested. Greg Shah
03:40 AM Base Language Feature #7045: re-implement "normal" (non-abend) stack unwinding to avoid throwing an exception
Converted and setup a large customer application using 7045b branch, and used it for a bit. Did not noticed any major... Eduard Soltan
08:01 AM User Interface Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...
> It will hide the implementation details, which can be considered an improvement,
This isn't just an improvement...
Greg Shah
07:43 AM User Interface Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...
Greg Shah wrote:
> No, I don't think that is a likely approach. Those classes are tightly coupled to context, to th...
Galya B
07:41 AM User Interface Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...
No, I don't think that is a likely approach. Those classes are tightly coupled to context, to the legacy transaction... Greg Shah
07:36 AM User Interface Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...
OK, so then we agree to proceed with reworking the core FWD DB classes to work without context, so that the DB check ... Galya B
07:28 AM User Interface Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...
> > Indeed, the use of @setuserid@ is very common.
> As far as I understand @setuserid@ is a common DB authenticat...
Greg Shah
07:25 AM User Interface Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...
Galya B wrote:
> Greg Shah wrote:
> > Indeed, the use of @setuserid@ is very common.
> As far as I understand @s...
Galya B
07:23 AM User Interface Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...
Greg Shah wrote:
> Indeed, the use of @setuserid@ is very common.
As far as I understand @setuserid@ is a common ...
Galya B
07:23 AM User Interface Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...
> I need a definition of 'properly'.
Directly showing the replacement of the original 4GL authentication method, e...
Greg Shah
07:21 AM User Interface Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...
Galya wrote:
> Actually hotel gui works properly and exemplary now (tested with h2). The raised concern was that i...
Greg Shah
07:21 AM User Interface Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...
I need a definition of 'properly'. Galya B
07:19 AM User Interface Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...
We may want to work part of this task so that the Hotel GUI SSO is properly implemented as an example. Greg Shah
07:03 AM User Interface Feature #4856: web client session forking
> > Is 7813a involved in future headway on this task?
> Yes. It will use the same mechanism, started in a different ...
Greg Shah
01:49 AM User Interface Feature #4856: web client session forking
Greg Shah wrote:
> Is 7813a involved in future headway on this task?
Yes. It will use the same mechanism, started i...
Galya B
03:35 AM Database Bug #7999 (WIP): FWD does not honor FIELDS/EXCEPT at dynamic queries
Alexandru Lungu

11/14/2023

03:01 PM Database Feature #6414: ERROR attribute for buffer, dataset and temp-table
I think there are very few places in customer projects which are affected by the changes in this branch. The fwdtests... Ovidiu Maxiniuc
02:42 PM Database Feature #6414 (Internal Test): ERROR attribute for buffer, dataset and temp-table
Ovidiu Maxiniuc wrote:
> Branch 6414a updated, rebased and pushed as r14827.
Thanks for addressing the code revie...
Eric Faulhaber
02:13 PM User Interface Feature #4856: web client session forking
Is 7813a involved in future headway on this task? Greg Shah
08:02 AM Database Feature #7323: Implement soft unique index in FWD-H2
I have found only some points:
* Remove @hasDirectAccess@ entirely and let @startValidate@ and @stopValidate@ simply...
Alexandru Lungu
06:45 AM Database Feature #7323: Implement soft unique index in FWD-H2
Unfortunately, I still have the same results as in #7323-49 :/ We are adding to much overhead somewhere. Maybe after... Alexandru Lungu
04:39 AM Database Feature #7323: Implement soft unique index in FWD-H2
I committed to 7323a, rev. 14801 the following changes:
* Reverted @TempTableHelper@ to its original state.
* Repla...
Radu Apetrii
04:07 AM Database Feature #7323: Implement soft unique index in FWD-H2
Alexandru Lungu wrote:
> I will start testing in ~30mins. If you have time to get them committed, it is ideal. If no...
Radu Apetrii
03:39 AM Database Feature #7323: Implement soft unique index in FWD-H2
I will start testing in ~30mins. If you have time to get them committed, it is ideal. If not, the changes are minor a... Alexandru Lungu
02:18 AM Database Feature #7323: Implement soft unique index in FWD-H2
Is it OK to commit those changes now or will it interfere with your testing? Radu Apetrii
07:53 AM Database Feature #6815: configure all cache sizes in the directory, and create documentation for them
> OTOH, for this specific case, it may just be that the parsed predicate is 'one of a kind', in that it uses some uni... Alexandru Lungu
07:42 AM Database Feature #6815: configure all cache sizes in the directory, and create documentation for them
Alexandru Lungu wrote:
> Danut, please point out to the documentation in this task and mark it as Review when finish...
Dănuț Filimon
07:13 AM Database Bug #7924 (Review): add support for creating an empty database
I attached a patch that solves the issue. Ovidiu, can you retest MariaDB and tell me if there are any more problems w... Dănuț Filimon
06:23 AM Database Bug #7924: add support for creating an empty database
Ovidiu Maxiniuc wrote:
> As noted in my previous note, this is the cause of the failure: the indices attempts to use...
Dănuț Filimon
05:03 AM Database Bug #8044 (WIP): Fix "Failed direct-access due to Error direct accessing for finding record by un...
Alexandru Lungu
04:53 AM Database Bug #8030: unique index violation when creating a record in two sessions
I retested with *7156b/rev.14846* but I couldn't reproduce the error with this branch too. Dănuț Filimon
04:37 AM Database Bug #8030: unique index violation when creating a record in two sessions
Alexandru Lungu wrote:
> Danut, also make sure you use the right schema (having unique indexes on book-id / isbn).
...
Dănuț Filimon
04:35 AM Database Bug #8030: unique index violation when creating a record in two sessions
Danut, also make sure you use the right schema (having unique indexes on book-id / isbn). Alexandru Lungu
04:06 AM Database Bug #8030: unique index violation when creating a record in two sessions
Dănuț Filimon wrote:
> Constantin Asofiei wrote:
> > Don't use parallel clients, run the same client twice. Also y...
Constantin Asofiei
04:05 AM Database Bug #8030: unique index violation when creating a record in two sessions
Constantin Asofiei wrote:
> Don't use parallel clients, run the same client twice. Also you need to use MariaDB for...
Dănuț Filimon
04:02 AM Database Bug #8030: unique index violation when creating a record in two sessions
Dănuț Filimon wrote:
> I was not able to reproduce the scenario with *trunk/rev.14828*, especially make it to reach ...
Constantin Asofiei
04:00 AM Database Bug #8030: unique index violation when creating a record in two sessions
I was not able to reproduce the scenario with *trunk/rev.14828*, especially make it to reach the catch from @orm.Pers... Dănuț Filimon

11/13/2023

11:22 AM Database Feature #7323 (Internal Test): Implement soft unique index in FWD-H2
*Review of 7323a*
* I don't think the cast to @P2JH2Dialect@ is needed anymore in @TempTableHelper@. The methods a...
Alexandru Lungu
10:38 AM Database Bug #8030 (WIP): unique index violation when creating a record in two sessions
Constantin Asofiei wrote:
> The @java.sql.SQLIntegrityConstraintViolationException.cause@ field is null for MariaDB....
Alexandru Lungu
04:37 AM Database Bug #8030: unique index violation when creating a record in two sessions
The @java.sql.SQLIntegrityConstraintViolationException.cause@ field is null for MariaDB.
Constantin Asofiei
03:46 AM Database Bug #8030: unique index violation when creating a record in two sessions
I added Radu as a watcher; he is the author of 7323a. Alexandru Lungu
03:45 AM Database Bug #8030: unique index violation when creating a record in two sessions
Constantin, just a further notice on #8030-3. In H2, the first SQLException is an internal H2 exception that has anot... Alexandru Lungu
03:12 AM Database Bug #8030: unique index violation when creating a record in two sessions
Constantin Asofiei wrote:
> There is a case for #7669, which I don't have yet a complete standalone recreate; it loo...
Tomasz Domin
08:02 AM Database Bug #7567: use Session.PK instead of DatabaseManager.PRIMARY_KEY wherever possible
Alexandru Lungu wrote:
> Danut, please double check: @searchPath@ and @propath@ in directory.xml and propath in p2j....
Dănuț Filimon
07:55 AM Database Bug #7567: use Session.PK instead of DatabaseManager.PRIMARY_KEY wherever possible
Danut, please double check: @searchPath@ and @propath@ in directory.xml and propath in p2j.cfg.xml. Is smart.p at lea... Alexandru Lungu
07:53 AM Database Bug #7567: use Session.PK instead of DatabaseManager.PRIMARY_KEY wherever possible
I had to make a few small changes to @DirectAccessHelper@ to fit the changes made in H2. When I tried to test Hotel_G... Dănuț Filimon
05:43 AM Database Feature #6496 (WIP): add equivalent support for -trig command line option
Alexandru Lungu
05:42 AM Database Feature #6496: add equivalent support for -trig command line option
I am moving this to High priority as it may grant us some performance improvement that we really need now. Alexandru ... Alexandru Lungu
05:16 AM Base Language Feature #6649 (Internal Test): improve the performance or SourceNameMapper runtime
Dănuț Filimon
05:09 AM Base Language Feature #6649: improve the performance or SourceNameMapper runtime
I also tried to find out the cause of the incremental version where nodes are duplicated but after running a @./gradl... Dănuț Filimon
05:06 AM Base Language Feature #6649 (WIP): improve the performance or SourceNameMapper runtime
*Committed 6649b/rev.14805 and 6649b/rev.14806*:
* Made @sourceCache@ configurable through @CacheManager@. I previou...
Dănuț Filimon
04:06 AM Database Bug #8032 (WIP): Deleted records are returned by a preselect query
This is already handled in #5768. There are multiple attempts to fix this (the last one is 5768c). This will be fixed... Alexandru Lungu

11/12/2023

10:51 AM Database Bug #8032: Deleted records are returned by a preselect query
Here's a testcase. A record was preselected by a query and then deleted in the same session. It is still returned by ... Stanislav Lomany
08:08 AM Database Bug #8032 (Closed): Deleted records are returned by a preselect query
Stanislav Lomany
04:29 AM Base Language Feature #6649: improve the performance or SourceNameMapper runtime
Code review 6649b revision 14804.
@initializationPaths.size() == 0@ in @createSourceCacheEntry@ should be protecte...
Hynek Cihlar

11/11/2023

02:51 PM Database Bug #8030: unique index violation when creating a record in two sessions
OK, this message seems to be a red herring: is just logged when this test is executed twice in a row:... Constantin Asofiei
03:43 AM Database Bug #8030: unique index violation when creating a record in two sessions
There is a case for #7669, which I don't have yet a complete standalone recreate; it looks like this, ran from two cl... Constantin Asofiei
03:30 AM Database Bug #8030 (Closed): unique index violation when creating a record in two sessions
Constantin Asofiei

11/10/2023

11:38 AM Database Feature #6815: configure all cache sizes in the directory, and create documentation for them
Alexandru, in #7669, I start seeing @DynamicQueryHelper cache level #1 is full. Dumped 1 old entries@ - (some 750k m... Constantin Asofiei
10:57 AM Database Feature #6815 (WIP): configure all cache sizes in the directory, and create documentation for them
Danut, please point out to the documentation in this task and mark it as Review when finished. Alexandru Lungu
11:02 AM Database Bug #7167 (Internal Test): Associating records from opened buffers to new sessions is slow
With some slim analysis, I still see @BufferManager.activeBuffers@ in top 50 performance items (being called ~100 tim... Alexandru Lungu
10:37 AM Database Feature #6720: lazy hydration
I run some regression testing and they passed. I also got them a second round to extract some insights.
|_. JMX |_...
Alexandru Lungu
09:56 AM Base Language Feature #6819: refactor FWD proxy implementation to use ReflectASM instead of Java Method reflection
That code resolves the @MethodAccess@ target for a @java.lang.reflect.Method@. @Method@ instances are not singleton,... Constantin Asofiei
09:50 AM Base Language Feature #6819: refactor FWD proxy implementation to use ReflectASM instead of Java Method reflection
Constantin, I reached quite randomly in @Utils.invoke@ and saw the double map access on @METHOD_DATA@ and @methodAcce... Alexandru Lungu
09:37 AM Database Bug #8025: Persistence API improvements
Constantin Asofiei wrote:
> Eric, customers need to access the result set metadata for the @ ScrollableResults<?> re...
Alexandru Lungu
09:10 AM Database Bug #8025: Persistence API improvements
Another part which is requested by customers to be improved: @executeSQLBatch@ to return an @int[]@ array with the re... Constantin Asofiei
07:44 AM Database Bug #8025: Persistence API improvements
Eric, customers need to access the result set metadata for the @ ScrollableResults<?> resultSet = connection.executeS... Constantin Asofiei
07:43 AM Database Bug #8025 (New): Persistence API improvements
Constantin Asofiei
09:02 AM Base Language Feature #6649 (Review): improve the performance or SourceNameMapper runtime
*Committed 6649b/rev.14804*.
* After solving the path-mapping node duplication problem, I reverted the changes from ...
Dănuț Filimon
03:23 AM Base Language Feature #6410: implement additional built-in OO classes/interfaces
Marian, please remind me of your issues - I plan to look at them over the next week. Also, point me to any test repr... Constantin Asofiei

11/09/2023

03:39 PM User Interface Bug #7946: Default selection and current browse row color differs for different customers applica...
7946a has been merged into the trunk as bzr revision 14825.
app_C changes to the @directory.xml@ template have been ...
Stanislav Lomany
01:33 PM User Interface Bug #7946: Default selection and current browse row color differs for different customers applica...
@app_A@ actually uses Material theme and therefore it hasn't been regressed by the Windows 10 theme changes as I assu... Stanislav Lomany
11:38 AM User Interface Bug #7946: Default selection and current browse row color differs for different customers applica...
> should I commit?
Yes, you can merge to trunk now.
>I think that for @app_A@ we should set the new Windows 2...
Greg Shah
11:07 AM User Interface Bug #7946: Default selection and current browse row color differs for different customers applica...
Greg, I think that for @app_A@ we should set the new Windows 2012 theme, and for @app_C@ - enable the new @oldBrowseS... Stanislav Lomany
11:04 AM User Interface Bug #7946: Default selection and current browse row color differs for different customers applica...
> The assignment of @oldBrowseSelectionBar@ in @EBCM.isOldBrowseSelectionBar@ should be double-locked
Fixed in 794...
Stanislav Lomany
03:05 AM User Interface Bug #7946: Default selection and current browse row color differs for different customers applica...
Code review 7946a.
The assignment of @oldBrowseSelectionBar@ in @EBCM.isOldBrowseSelectionBar@ should be double-lo...
Hynek Cihlar
11:11 AM Database Feature #6720: lazy hydration
> If incremental processing of the properties in BitSet is not possible, the i_rs(k) can be computed at first access ... Alexandru Lungu
09:23 PM Database Feature #6720: lazy hydration
Alexandru Lungu wrote:
> Indeed! The "difficulty" here was that we can't compute the proper offset on random access ...
Ovidiu Maxiniuc
09:31 AM Base Language Feature #6649: improve the performance or SourceNameMapper runtime
> The number look good on the paper. The question is how will it perform in the actual customer scenario.
I can ta...
Alexandru Lungu
09:26 AM Base Language Feature #6649: improve the performance or SourceNameMapper runtime
Dănuț Filimon wrote:
> I retested the performance of the cache after saving the @fastConvertName@ results of program...
Hynek Cihlar
06:17 AM Base Language Feature #6649: improve the performance or SourceNameMapper runtime
I retested the performance of the cache after saving the @fastConvertName@ results of program names that are not foun... Dănuț Filimon
02:23 AM Base Language Feature #6649: improve the performance or SourceNameMapper runtime
Dănuț Filimon wrote:
> Got it, I went and deleted @checkSourceCache@ and integrated it's functionality in @fastConve...
Hynek Cihlar
01:01 AM Base Language Feature #6649: improve the performance or SourceNameMapper runtime
Got it, I went and deleted @checkSourceCache@ and integrated it's functionality in @fastConvertName@, this was the be... Dănuț Filimon
04:05 AM Database Bug #7454: Make ValueStringIgnoreCase the default generated value for setString in FWD-H2
Rebased 7454a to latest trunk. It is now at rev. 14825. Alexandru Lungu
03:32 AM Database Bug #7454: Make ValueStringIgnoreCase the default generated value for setString in FWD-H2
Yes! I was caught up with #6720 by now and I didn't want to spoil my profiling test with it. I will attempt to check ... Alexandru Lungu
01:44 AM Database Bug #7454: Make ValueStringIgnoreCase the default generated value for setString in FWD-H2
Eric Faulhaber wrote:
> Can this issue be closed?
7454a was not merged, but 7454a_h2 was. If I remember correctly, ...
Dănuț Filimon
03:59 AM Base Language Feature #7045: re-implement "normal" (non-abend) stack unwinding to avoid throwing an exception
I rebased 7045b to latest trunk. It is now at rev. 14833.
Eduard, please double-check: @RecordBuffer@ (especially @s...
Alexandru Lungu
03:58 AM Database Feature #7416: Reiterate DatabaseStatistics and leverage to other database profling tools
Radu, please address the review as soon as you have the chance. Alexandru Lungu

11/08/2023

12:12 PM Runtime Infrastructure Support #8020 (New): Remote Launcher for Dummies - Configuration/Utilization Help
Roger Borrello
10:50 AM Base Language Feature #6649: improve the performance or SourceNameMapper runtime
Dănuț Filimon wrote:
> The problem is that I can't differentiate between which case is executed. I am still thinking...
Hynek Cihlar
08:15 AM Base Language Feature #6649: improve the performance or SourceNameMapper runtime
Hynek Cihlar wrote:
> The cache should eliminate 100% of the heavy execution of @fastConvertName@ for all the encoun...
Dănuț Filimon
08:06 AM Base Language Feature #6649: improve the performance or SourceNameMapper runtime
Dănuț Filimon wrote:
> * The number of cache hits (when cache returned a value) was *21288* from the total *35971* @...
Hynek Cihlar
07:22 AM Base Language Feature #6649 (WIP): improve the performance or SourceNameMapper runtime
Dănuț Filimon
07:21 AM Base Language Feature #6649: improve the performance or SourceNameMapper runtime
Hynek Cihlar wrote:
> Code review 6649b revisions 14800..14803.
>
> Saving the RUN entries should be saved in a s...
Dănuț Filimon
04:03 AM Base Language Feature #6649: improve the performance or SourceNameMapper runtime
Hynek Cihlar wrote:
> Does it mean that the non-program files don't require the additional @fastConvertName@ logic (...
Dănuț Filimon
03:37 AM Base Language Feature #6649: improve the performance or SourceNameMapper runtime
Dănuț Filimon wrote:
> Hynek Cihlar wrote:
> > Dănuț Filimon wrote:
> > > In my opinion, adding images to @path-ma...
Hynek Cihlar
03:15 AM Base Language Feature #6649: improve the performance or SourceNameMapper runtime
Code review 6649b revisions 14800..14803.
Saving the RUN entries should be saved in a set rather than saving direc...
Hynek Cihlar
02:35 AM Base Language Feature #6649: improve the performance or SourceNameMapper runtime
Hynek Cihlar wrote:
> Dănuț Filimon wrote:
> > In my opinion, adding images to @path-mappings@ will just slow down ...
Dănuț Filimon
10:48 AM Database Feature #6720: lazy hydration
h4. Unique result
I improved the solution for unique result. It uses a LRUCache per session to "delay" the closing...
Alexandru Lungu
04:00 AM Database Feature #6720: lazy hydration
Ovidiu Maxiniuc wrote:
> The hydration works now by iterating the columns of the @ResultSet@. The @DataHandler@ s fr...
Alexandru Lungu
09:55 AM Base Language Feature #6410: implement additional built-in OO classes/interfaces
6410b rev 14794 was rebased from trunk rev 14824 - new rev 14828. Constantin Asofiei
09:52 AM Base Language Feature #6410: implement additional built-in OO classes/interfaces
Starting rebase now. Constantin Asofiei
08:55 AM Base Language Feature #6410: implement additional built-in OO classes/interfaces
Constantin Asofiei wrote:
> OK, let me know when it's done.
All done what I've could get 'proper' enough... rev #14...
Marian Edu
07:21 AM Base Language Feature #6410: implement additional built-in OO classes/interfaces
Marian Edu wrote:
> Constantin Asofiei wrote:
>
> > If you have nothing else to commit, I'll rebase.
> Give me 1...
Constantin Asofiei
07:18 AM Base Language Feature #6410: implement additional built-in OO classes/interfaces
Constantin Asofiei wrote:
> If you have nothing else to commit, I'll rebase.
Give me 10-15 mins please to commit ...
Marian Edu
07:14 AM Base Language Feature #6410: implement additional built-in OO classes/interfaces
I see these commits on xfer/6410b:... Constantin Asofiei
07:08 AM Base Language Feature #6410: implement additional built-in OO classes/interfaces
Constantin Asofiei wrote:
> Marian, see another patch - please integrate it also in 6410b.
>
Had to manually appl...
Marian Edu
09:25 AM Base Language Feature #7045: re-implement "normal" (non-abend) stack unwinding to avoid throwing an exception
Eduard, mind setting up some large customer applications and do some smoke tests. I will take the changes and do on s... Alexandru Lungu
08:05 AM User Interface Bug #7946: Default selection and current browse row color differs for different customers applica...
Hynek: Please review. Greg Shah
04:05 AM Database Feature #6895: improve performance of BufferReference methods buffer() and definition()
Eric / Constantin: this task is related to #6819, but it seems that it addresses a more particular scenario (@.buffer... Alexandru Lungu
03:51 AM Database Feature #5003 (WIP): Enhance performance of H2 sequences
In the past months, while heavenly profiling FWD-H2, I removed the flushing of sequences to disk for _temp database. ... Alexandru Lungu
03:46 AM Database Bug #7167: Associating records from opened buffers to new sessions is slow
Eric, in theory, this can be closed. However, I am waiting for some performance tests to check that @BufferManager.ac... Alexandru Lungu
03:30 AM Base Language Feature #6819: refactor FWD proxy implementation to use ReflectASM instead of Java Method reflection
For a while, I've been looking through videos, blog posts and other info I could get my hands on, related to lambdas.... Constantin Asofiei
12:56 AM User Interface Feature #4853: implement support for reporting a device-id which is meant to identify a unique cl...
Greg Shah wrote:
> The device id needs to be persistent across browser restarts and past the point where all FWD s...
Galya B
12:39 AM User Interface Feature #4853: implement support for reporting a device-id which is meant to identify a unique cl...
Greg Shah wrote:
> There should be no association (at the FWD level) between accounts and devices. I don't want to ...
Galya B

11/07/2023

05:27 PM Database Feature #7076 (Closed): make CAN-FIND avoid hydration
Eric Faulhaber
05:15 PM Database Feature #5003: Enhance performance of H2 sequences
What is the true "% Done" value of this task? It seems the improvements discussed in #5003-2 made it into trunk via 3... Eric Faulhaber
05:08 PM User Interface Bug #7946 (Review): Default selection and current browse row color differs for different customer...
The fix is in 7946a rev 14826. Please review. Stanislav Lomany
12:30 PM User Interface Bug #7946: Default selection and current browse row color differs for different customers applica...
Rebased task branch 7946a from FWD trunk revision 14824. Stanislav Lomany
05:06 PM Database Bug #7167: Associating records from opened buffers to new sessions is slow
Can this task be closed? Eric Faulhaber
04:58 PM Database Feature #6414: ERROR attribute for buffer, dataset and temp-table
Eric Faulhaber wrote:
> Code review 6414a/14806-7:
Thank you for the review. A second pair of eyes are always bette...
Ovidiu Maxiniuc
01:59 PM Database Feature #6720: lazy hydration
The hydration works now by iterating the columns of the @ResultSet@. The @DataHandler@ s from @com.goldencode.p2j.per... Ovidiu Maxiniuc
01:02 PM Database Feature #6720: lazy hydration
> I am not sure I understand why dtz are a problem for (partial|lazy) hydration. The name/type is available for each ... Alexandru Lungu
12:17 PM Database Feature #6720: lazy hydration
Alexandru Lungu wrote:
> *Fix datetime-tz and extent cases*
> Next on my list is to fix the the datetimze-tz and ex...
Ovidiu Maxiniuc
10:03 AM Database Feature #6720: lazy hydration
h4. Avoid lazily hydrating from H2
Tested and had only -0.8% time improvement comparing to baseline. This means th...
Alexandru Lungu
10:20 AM User Interface Feature #4853: implement support for reporting a device-id which is meant to identify a unique cl...
There should be no association (at the FWD level) between accounts and devices. I don't want to mix the two concepts... Greg Shah
09:36 AM User Interface Feature #4853: implement support for reporting a device-id which is meant to identify a unique cl...
A few aspects to be taken into consideration are: simultaneous logins; the fact that sessions in the same browser can... Galya B
09:22 AM User Interface Feature #4853: implement support for reporting a device-id which is meant to identify a unique cl...
The browser id will be changed the moment all sessions are closed. We can have server-side initiated checks for who l... Galya B
09:18 AM User Interface Feature #4853: implement support for reporting a device-id which is meant to identify a unique cl...
Greg Shah wrote:
> > It's doable to create a mechanism confirming which web sessions are in the same browser with Br...
Galya B
09:01 AM User Interface Feature #4853: implement support for reporting a device-id which is meant to identify a unique cl...
> It's doable to create a mechanism confirming which web sessions are in the same browser with Broadcast Channel comm... Greg Shah
08:19 AM User Interface Feature #4853: implement support for reporting a device-id which is meant to identify a unique cl...
Also obviously it doesn't depend on id that can be altered, but real time communication between the live sessions. Galya B
08:11 AM User Interface Feature #4853: implement support for reporting a device-id which is meant to identify a unique cl...
Galya B wrote:
> I have one blurred idea without clear form yet. It's doable to create a mechanism confirming which ...
Galya B
08:09 AM User Interface Feature #4853: implement support for reporting a device-id which is meant to identify a unique cl...
I have one blurred idea without clear form yet. It's doable to create a mechanism confirming which web sessions are i... Galya B
08:03 AM User Interface Feature #4853: implement support for reporting a device-id which is meant to identify a unique cl...
Since there is no good solution for fingerprinting or even for detecting the network configuration, I think we just i... Greg Shah
10:17 AM Base Language Feature #6649: improve the performance or SourceNameMapper runtime
Dănuț Filimon wrote:
> In my opinion, adding images to @path-mappings@ will just slow down the creation process.
...
Hynek Cihlar
09:49 AM Base Language Feature #6649 (Review): improve the performance or SourceNameMapper runtime
*Committed 6649b/rev.14803*.
* Used AssociatedThread to initialize caches for each new propath;
* Added missing doc...
Dănuț Filimon
08:15 AM Base Language Feature #6649: improve the performance or SourceNameMapper runtime
My mistake, I just wanted to make an edit on my previous post. Dănuț Filimon
04:37 AM Base Language Feature #6649: improve the performance or SourceNameMapper runtime
AFAIK about paths to images, @FileSystemOps.searchPath@ is used when searching any file and reaches @fastConvertName@... Dănuț Filimon
04:22 AM Base Language Feature #6649: improve the performance or SourceNameMapper runtime
Alexandru Lungu wrote:
> Danut, please check if the number of entries is right. I expected to have >10k (at least th...
Dănuț Filimon
04:11 AM Base Language Feature #6649: improve the performance or SourceNameMapper runtime
Danut, please check if the number of entries is right. I expected to have >10k (at least the number of files, but als... Alexandru Lungu
03:20 AM Base Language Feature #6649: improve the performance or SourceNameMapper runtime
I've finally got the results of the testing:
* The initial thread that firstly initializes the @sourceCache@ took *5...
Dănuț Filimon
08:05 AM User Interface Bug #8012 (WIP): Fix combo-box corner cases
There are quite a lot of corner cases regarding combo-boxes. While working on another task, I managed to identify a f... Radu Apetrii
06:49 AM User Interface Bug #8012 (Test): Fix combo-box corner cases
Radu Apetrii
07:55 AM Base Language Feature #6410: implement additional built-in OO classes/interfaces
Constantin Asofiei wrote:
> Marian Edu wrote:
> > ... because of the block added to @invoke@ this is 'polluting' th...
Marian Edu
06:33 AM Base Language Feature #6410: implement additional built-in OO classes/interfaces
Marian Edu wrote:
> ... because of the block added to @invoke@ this is 'polluting' the call-stack
Was this block ad...
Constantin Asofiei
05:10 AM Base Language Feature #6410: implement additional built-in OO classes/interfaces
Constantin Asofiei wrote:
> Hmm... this may mean that OpenEdge does not report the internal classes in the callsta...
Marian Edu
04:36 AM Base Language Feature #6410: implement additional built-in OO classes/interfaces
Marian, see another patch - please integrate it also in 6410b.
> I'm trying to fight a case when invalid parameter...
Constantin Asofiei
02:50 AM Base Language Feature #6410: implement additional built-in OO classes/interfaces
Constantin Asofiei wrote:
> Marian, I have this patch to properly report datasethandle/tablehandle vs dataset/table ...
Marian Edu
07:37 AM Runtime Infrastructure Bug #7498: allow a single Web client launch if the client presses ENTER key multiple times
With trunk r14783 (3931a merged) default login page has a 'Sign In' button, that gets disabled on the first click, un... Galya B
06:57 AM User Interface Feature #3931: single sign-on for virtual desktop mode
Galya B wrote:
> Guido Brandsen wrote:
> > Galya, today we saw a minor problem with client spawning.
> > The error...
Galya B
06:55 AM User Interface Feature #4517 (Test): optionally back the 4GL features for Registry access with the user-specific...
4854a was merged to trunk as rev. 14823 and archived.
It's important customers to get familiar with the table in #...
Galya B
06:51 AM User Interface Feature #4854 (Test): origin affinity
4854a was merged to trunk as rev. 14823 and archived. Galya B
06:31 AM User Interface Feature #4854: origin affinity
Galya, you can merge to trunk now. Greg Shah
06:27 AM User Interface Feature #4854: origin affinity
Greg Shah wrote:
> Galya: If Sergey is OK with the code, then we will queue this for merge.
The changes are OK for ...
Sergey Ivanovskiy
01:58 AM User Interface Feature #4854: origin affinity
Sergey Ivanovskiy wrote:
> Found minor issue related to
> [...]
Fixed in r14836.
Galya B
03:05 AM Database Bug #7535 (Test): Temporary tables require trailing recid component even for unique indexes
Alexandru Lungu
03:05 AM Database Bug #7535: Temporary tables require trailing recid component even for unique indexes
Yes, the changes in 7535c were included already in a separate task branch that was merged to trunk. Alexandru Lungu
08:21 PM Database Bug #7535: Temporary tables require trailing recid component even for unique indexes
Can this issue be closed? Eric Faulhaber
08:17 PM Database Bug #7454: Make ValueStringIgnoreCase the default generated value for setString in FWD-H2
Can this issue be closed? Eric Faulhaber

11/06/2023

03:25 PM User Interface Feature #4854: origin affinity
Found minor issue related to... Sergey Ivanovskiy
12:58 PM User Interface Feature #4854: origin affinity
Galya: If Sergey is OK with the code, then we will queue this for merge. Greg Shah
12:56 PM User Interface Feature #4854: origin affinity
Galya B wrote:
> Sergey,
>
> I've changed @UserPreferences.MAXIMAL_STRING_LENGTH@ to @6@ and saved the browse con...
Sergey Ivanovskiy
12:43 PM User Interface Feature #4854: origin affinity
Code review 4854a. The changes look good. Hynek Cihlar
12:05 PM User Interface Feature #4854: origin affinity
Just a note: If @webClient/useLocalStorage@ is @TRUE@ in Windows it applies only for enhanced browse configs, but not... Galya B
12:01 PM User Interface Feature #4854: origin affinity
I couldn't start web in Windows VM, there is a new issue with networking/ports I don't want to know about, but web cl... Galya B
12:00 PM User Interface Feature #4854: origin affinity
Stanislav Lomany wrote:
> The code looks good. I did some testing and it works fine. One minor thing: javadoc for @U...
Galya B
11:56 AM User Interface Feature #4854: origin affinity
Registry in Windows is working as before:
!windows-registry.png!
But doesn't look good in that place.
Galya B
11:50 AM User Interface Feature #4854: origin affinity
The code looks good. I did some testing and it works fine. One minor thing: javadoc for @UserPreferences()@ is missing. Stanislav Lomany
10:33 AM User Interface Feature #4854: origin affinity
Sergey/Hynek/Stanislav: Please review. Greg Shah
10:10 AM User Interface Feature #4854: origin affinity
r14834:
* Applies the change to @UserPreferences.delete@ as described in #4854-147;
* @com/goldencode@ as root node...
Galya B
09:24 AM User Interface Feature #4854: origin affinity
Sergey,
I've changed @UserPreferences.MAXIMAL_STRING_LENGTH@ to @6@ and saved the browse configs.
KEY @enhanced...
Galya B
09:02 AM User Interface Feature #4854: origin affinity
I still haven't tested registry in Windows. Galya B
09:02 AM User Interface Feature #4854: origin affinity
Is the only remaining known issue the "delete chunks" problem?
Is there any remaining testing to do?
Greg Shah
08:27 AM User Interface Feature #4854: origin affinity
r14833:
* fixes for @LOAD INI@. Tested with:...
Galya B
08:18 AM User Interface Feature #4854: origin affinity
I guess we'll need another stopper instead of root preferences. Maybe "chunks" node. I'll have to test chunks first t... Galya B
08:16 AM User Interface Feature #4854: origin affinity
Galya B wrote:
> I'm not sure how to test the chunks. Can you give me an example how it should be stored in the path...
Sergey Ivanovskiy
08:04 AM User Interface Feature #4854: origin affinity
Galya, I don't know how chunks work in details, I dealt only with higher level of abstraction which is @TC.setObject(... Stanislav Lomany
07:52 AM User Interface Feature #4854: origin affinity
I'm not sure how to test the chunks. Can you give me an example how it should be stored in the path? This @enhancedBr... Galya B
07:48 AM User Interface Feature #4854: origin affinity
The idea was to remove all chain of chunks because one chain stores key and value. I do not check if this logic is pr... Sergey Ivanovskiy
07:18 AM User Interface Feature #4854: origin affinity
Stanislav, I've encountered a behavior in enhanced browse:
1. Save @This Browse, Current User@;
2. Save @All Brow...
Galya B
04:51 AM User Interface Feature #4854: origin affinity
4854a re-based on latest trunk r14819. Galya B
02:23 PM Base Language Feature #6410: implement additional built-in OO classes/interfaces
I'd like to get the next phase of #6410 support into code review if it is far enough along. Greg Shah
01:22 PM Base Language Feature #6410: implement additional built-in OO classes/interfaces
Marian, I have this patch to properly report datasethandle/tablehandle vs dataset/table - please review. I plan to i... Constantin Asofiei
10:58 AM Database Feature #6628 (Internal Test): port PostgreSQL native user defined functions to MariaDB
Code review 6628a/14615:
The changes look good. I don't know whether Igor ever was able to test these changes, giv...
Eric Faulhaber
10:43 AM Database Feature #6414: ERROR attribute for buffer, dataset and temp-table
Code review 6414a/14806-7:
The changes to the @DataSet*@ classes look fine. I am not as familiar to the functional...
Eric Faulhaber
10:15 AM Database Feature #6720: lazy hydration
*Optimization 1: Refresh only fields that weren't hydrated already*
*Optimization 2: Discard the hydrator if we hydr...
Alexandru Lungu
09:10 AM Base Language Feature #7045: re-implement "normal" (non-abend) stack unwinding to avoid throwing an exception
Alexandru Lungu wrote:
> I've reviewed the changes. I intend to change several things, but I will list them here for...
Eduard Soltan
08:48 AM Base Language Bug #8008: read-json on a 1252 longchar should convert to utf-8 automatically before hydrating te...
Additional information:
# It is expected that @cpinternal iso-8859-15@ will show the same behavior with the (verbati...
Tijs Wickardt
08:33 AM Base Language Bug #8008: read-json on a 1252 longchar should convert to utf-8 automatically before hydrating te...
This task should be picked up *after* customer task #7944 is completed.
The customer task #7944 has a special condit...
Tijs Wickardt
08:32 AM Base Language Bug #8008 (New): read-json on a 1252 longchar should convert to utf-8 automatically before hydrat...

Tijs Wickardt
08:47 AM Base Language Feature #6649: improve the performance or SourceNameMapper runtime
> > The long init time could be brought down with splitting the entries processing on multiple threads.
>
> And by...
Greg Shah
07:28 AM Base Language Feature #6649: improve the performance or SourceNameMapper runtime
While testing, the cache is initialized with the default propath, but when a client is connecting, another propath is... Dănuț Filimon
06:23 AM Base Language Feature #6649: improve the performance or SourceNameMapper runtime
Hynek Cihlar wrote:
> The long init time could be brought down with splitting the entries processing on multiple thr...
Hynek Cihlar
04:51 AM Base Language Feature #6649: improve the performance or SourceNameMapper runtime
The long init time could be brought down with splitting the entries processing on multiple threads. But for now let's... Hynek Cihlar
04:39 AM Base Language Feature #6649: improve the performance or SourceNameMapper runtime
Alexandru Lungu wrote:
> Danut, can you script the duplicates out for now, so you don't have to wait too much? This ...
Dănuț Filimon
04:38 AM Base Language Feature #6649: improve the performance or SourceNameMapper runtime
Danut, can you script the duplicates out for now, so you don't have to wait too much? This is just for the performanc... Alexandru Lungu
04:28 AM Base Language Feature #6649: improve the performance or SourceNameMapper runtime
Hynek Cihlar wrote:
> Danut, any numbers on the actual runtime performance with the cache in place?
Not yet, I will...
Dănuț Filimon
04:22 AM Base Language Feature #6649: improve the performance or SourceNameMapper runtime
Danut, any numbers on the actual runtime performance with the cache in place? Hynek Cihlar
04:17 AM Base Language Feature #6649: improve the performance or SourceNameMapper runtime
It would be the best if we can have a working thread by using @ContextAwareThread@. Until the thread discussion is so... Dănuț Filimon
08:15 AM Database Feature #7382: Check performance of delete from vs drop table in H2
Constantin Asofiei wrote:
> Alexandru Lungu wrote:
> > The difference is that TRUNCATE is closing an open transacti...
Alexandru Lungu
07:49 AM Database Feature #7382: Check performance of delete from vs drop table in H2
Alexandru Lungu wrote:
> The difference is that TRUNCATE is closing an open transaction. But this can be solved by a...
Constantin Asofiei
07:46 AM Database Feature #7382: Check performance of delete from vs drop table in H2
I put myself up to date with the discussion here and I created 7382a. I'll start working on this now. Radu Apetrii
04:23 AM Testing Support #6855 (WIP): database/persistence tests
Marian Edu
02:19 AM Database Feature #7323 (Review): Implement soft unique index in FWD-H2
I've committed to 7323a rev. 14800 the following changes:
* Removed the @validateDriver@ caching.
* Moved @startVal...
Radu Apetrii

11/04/2023

08:00 PM Database Feature #4722: data import should be able to run with only the converted application jar file (an...
Branch 4722b was rebased to trunk_14819 and is at revision 14820. Roger Borrello

11/03/2023

12:54 PM Base Language Feature #6649: improve the performance or SourceNameMapper runtime
Dănuț Filimon wrote:
> Hynek Cihlar wrote:
> > You won't be able to access the security context from the worker thr...
Hynek Cihlar
09:13 AM Base Language Feature #6649: improve the performance or SourceNameMapper runtime
Hynek Cihlar wrote:
> You won't be able to access the security context from the worker thread, so you will have to p...
Dănuț Filimon
07:09 AM Base Language Feature #6649: improve the performance or SourceNameMapper runtime
Dănuț Filimon wrote:
> I've tried to use a thread to create a cache but I get the following error:
You won't be a...
Hynek Cihlar
05:43 AM Base Language Feature #6649: improve the performance or SourceNameMapper runtime
I've tried to use a thread to create a cache but I get the following error:... Dănuț Filimon
10:54 AM Database Feature #6720: lazy hydration
Committed 6720b/rev. 14769:
* Added JMX to do some tracking for lazy hydration. Hopefully they aren't slowing the pr...
Alexandru Lungu
07:42 AM Database Feature #6720: lazy hydration
Greg Shah wrote:
> > I applied lazy hydration only to tables where we know that the SQL number of columns matches th...
Alexandru Lungu
10:25 AM User Interface Feature #4854: origin affinity
. Galya B
09:52 AM User Interface Feature #4854: origin affinity
. Galya B
08:32 AM User Interface Feature #4854: origin affinity
> From SVL:
>
> Assuming that it's OK that we've moved from the in-browser storage to the file system (java prefs),...
Greg Shah
04:43 AM User Interface Feature #4854: origin affinity
Constantin Asofiei wrote:
> Found #4854-103, I got now what you and Greg meant. The change in #4854-135 is OK.
Than...
Galya B
04:41 AM User Interface Feature #4854: origin affinity
Galya B wrote:
> Constantin Asofiei wrote:
> > Thanks for bearing with me. Please add back the @catch (Exception@ t...
Constantin Asofiei
04:31 AM User Interface Feature #4854: origin affinity
Constantin Asofiei wrote:
> Thanks for bearing with me. Please add back the @catch (Exception@ to get any unexpected...
Galya B
04:28 AM User Interface Feature #4854: origin affinity
Thanks for bearing with me. Please add back the @catch (Exception@ to get any unexpected abends, and for these:
* th...
Constantin Asofiei
04:23 AM User Interface Feature #4854: origin affinity
Constantin Asofiei wrote:
> Galya, one more question, please: can you point where the ErrorConditionException is rai...
Galya B
04:17 AM User Interface Feature #4854: origin affinity
Galya, one more question, please: can you point where the ErrorConditionException is raised in 4854a, and caught by @... Constantin Asofiei
04:08 AM User Interface Feature #4854: origin affinity
The error is non-OE one, but had to be treated like OE errors, so I used @ErrorConditionException@ like similar expor... Galya B
03:54 AM User Interface Feature #4854: origin affinity
Galya B wrote:
> Constantin Asofiei wrote:
> > * we need to add a specific @catch (ErrorConditionException@ for the...
Constantin Asofiei
03:53 AM User Interface Feature #4854: origin affinity
Constantin Asofiei wrote:
> * we need to add a specific @catch (ErrorConditionException@ for these kind of errors. T...
Galya B
03:51 AM User Interface Feature #4854: origin affinity
The confusing part is the usage of @catch (Exception@. So, as the FWD client can throw @ErrorConditionException@, pl... Constantin Asofiei
03:45 AM User Interface Feature #4854: origin affinity
Constantin Asofiei wrote:
> Galya, @catch Exception@ will show a Java-style error message for things like abends and...
Galya B
03:38 AM User Interface Feature #4854: origin affinity
Galya, @catch (Exception@ will show a Java-style error message for things like abends and others. What kind of excep... Constantin Asofiei
03:35 AM User Interface Feature #4854: origin affinity
Hynek Cihlar wrote:
> Hynek Cihlar wrote:
> > Galya B wrote:
> > > Hynek Cihlar wrote:
> > > > No, it's not. You ...
Galya B
03:18 AM User Interface Feature #4854: origin affinity
Hynek Cihlar wrote:
> Galya B wrote:
> > Hynek Cihlar wrote:
> > > No, it's not. You only log the error message, b...
Hynek Cihlar
03:14 AM User Interface Feature #4854: origin affinity
Galya B wrote:
> Hynek Cihlar wrote:
> > No, it's not. You only log the error message, but not the call stack. We n...
Hynek Cihlar
02:58 AM User Interface Feature #4854: origin affinity
Hynek Cihlar wrote:
> Galya B wrote:
> > Hynek Cihlar wrote:
> > > The exception caught in @EnvironmentOps.setKeyV...
Galya B
02:55 AM User Interface Feature #4854: origin affinity
Galya B wrote:
> Hynek Cihlar wrote:
> > The exception caught in @EnvironmentOps.setKeyValue@ should be logged. Whi...
Hynek Cihlar
02:36 AM User Interface Feature #4854: origin affinity
Hynek Cihlar wrote:
> The exception caught in @EnvironmentOps.setKeyValue@ should be logged. While the message is sh...
Galya B
12:13 AM Database Feature #4722: data import should be able to run with only the converted application jar file (an...
Branch 4722b was rebased to trunk_14815 and is at revision 14816. Roger Borrello
10:52 PM Database Bug #7993: Create the fast-copy mapping tables (MASTER_PK_MAPPING and BEFORE_PK_MAPPING) only onc...
Eugenie reported in #7143-463 an issue related to 7993a.
There are three issues I can see:
* the DDL being executed...
Ovidiu Maxiniuc
10:32 PM Database Feature #7416: Reiterate DatabaseStatistics and leverage to other database profling tools

Wow, this a much larger change-set that I expected. Things seem more structured now. Good job.
Here are my notes:...
Ovidiu Maxiniuc

11/02/2023

04:59 PM Database Feature #6496: add equivalent support for -trig command line option
Eric Faulhaber wrote:
> In speaking with Greg about this, I also realized that I was not considering session trigger...
Ovidiu Maxiniuc
01:21 PM Database Feature #6496: add equivalent support for -trig command line option
Greg Shah wrote:
> The problem is that there are some customers who definitely will have *per client* (or likely *pe...
Theodoros Theodorou
10:49 AM Database Feature #6496: add equivalent support for -trig command line option
In speaking with Greg about this, I also realized that I was not considering session triggers during my review. The O... Eric Faulhaber
10:39 AM Database Feature #6496: add equivalent support for -trig command line option
BTW, it doesn't seem like this setting in OE has any relationship to a given schema or database instance. It is just... Greg Shah
10:34 AM Database Feature #6496: add equivalent support for -trig command line option
We definitely cannot set this *per database*. In most cases, customers have a single propath for all clients and wou... Greg Shah
10:14 AM Database Feature #6496: add equivalent support for -trig command line option
OK, so then other than fixing the typo/coding standard issues, the only thing left to decide is the scope we want to ... Eric Faulhaber
05:54 AM Database Feature #6496: add equivalent support for -trig command line option
Eric Faulhaber wrote:
> There are many changes to @SourceNameMapper@. Alexandru (Lungu) or Danut: can you please con...
Dănuț Filimon
01:23 AM Database Feature #6496: add equivalent support for -trig command line option
Code review 6496a/14743-14744:
The configuration is causing me some confusion, in that it can be specified for eac...
Eric Faulhaber
03:48 PM Database Bug #7999: FWD does not honor FIELDS/EXCEPT at dynamic queries
Consider this test:... Constantin Asofiei
03:44 PM Database Bug #7999 (Review): FWD does not honor FIELDS/EXCEPT at dynamic queries
Constantin Asofiei
03:36 PM Database Bug #7731 (Internal Test): performance improvements for FQLPreprocessor
Review of 7731a/14811-2.
A straightforward implementation. I am OK with the code. Good job!
Ovidiu Maxiniuc
12:12 PM Database Bug #7731: performance improvements for FQLPreprocessor
Ovidiu/Constantin: Please review. Greg Shah
11:33 AM Database Bug #7731 (Review): performance improvements for FQLPreprocessor
It seems Danut has stepped away from "events" and "triggers" for a while :) Alexandru Lungu
11:30 AM Database Bug #7731: performance improvements for FQLPreprocessor
Please set the status and %Done accordingly. That is the "event" that triggers a code review. Greg Shah
10:17 AM Database Bug #7731: performance improvements for FQLPreprocessor
Greg Shah wrote:
> Is this ready for review?
Yes.
Dănuț Filimon
09:46 AM Database Bug #7731: performance improvements for FQLPreprocessor
Is this ready for review? Greg Shah
12:17 PM User Interface Feature #4854: origin affinity
Code review 4854a revision 14804.
The exception caught in @EnvironmentOps.setKeyValue@ should be logged. While th...
Hynek Cihlar
10:10 AM User Interface Feature #4854: origin affinity
Hmm. The encryption point is a good one. We don't know how this will be used. Even for configuration data, this is... Greg Shah
09:28 AM User Interface Feature #4854: origin affinity
If they use the storage / registry for configurations, it won't matter much, otherwise the customers need to use thei... Galya B
09:26 AM User Interface Feature #4854: origin affinity
Hynek Cihlar wrote:
> * In @ClientStorageImpl.java@ the copyright message is broken, the line with GNU location is r...
Galya B
08:14 AM User Interface Feature #4854: origin affinity
Code review 4854a 14792..14803.
The changes look good. Just a couple of points below.
* In @ClientStorageImpl.j...
Hynek Cihlar
06:13 AM User Interface Feature #4854: origin affinity
Fix in r14803.
Testing methods:
Prerequisite for @localStorage@ as client storage is adding:...
Galya B
04:23 AM User Interface Feature #4854: origin affinity
I'll go over the major changes in the order they appear with diff:
* With 3931a the login page @web_landing.html@ ha...
Galya B
12:11 PM Database Feature #6720: lazy hydration
> I applied lazy hydration only to tables where we know that the SQL number of columns matches the number of properti... Greg Shah
11:33 AM Database Feature #6720: lazy hydration
Committed 6720b/rev. 14768:
* *FIX* Made @toString@ ignore the hydrator and simply show what is in the current @da...
Alexandru Lungu
11:34 AM Database Bug #7993 (Test): Create the fast-copy mapping tables (MASTER_PK_MAPPING and BEFORE_PK_MAPPING) o...
Branch 7993a was merged to trunk as rev. 14814 and archived. Alexandru Lungu
11:22 AM Database Bug #7993: Create the fast-copy mapping tables (MASTER_PK_MAPPING and BEFORE_PK_MAPPING) only onc...
You can merge to trunk. Greg Shah
09:19 AM Database Bug #7993: Create the fast-copy mapping tables (MASTER_PK_MAPPING and BEFORE_PK_MAPPING) only onc...
Wow! This is major :)
I tested with a large customer's regression testing suite and got no problems. I also did so...
Alexandru Lungu
08:55 AM Database Bug #7993 (Internal Test): Create the fast-copy mapping tables (MASTER_PK_MAPPING and BEFORE_PK_M...
Added. :) Greg Shah
08:36 AM Database Bug #7993 (WIP): Create the fast-copy mapping tables (MASTER_PK_MAPPING and BEFORE_PK_MAPPING) on...
We probably need a different status code for "internal testing before being released to customer". Anyway, let me kn... Greg Shah
11:07 PM Database Bug #7993 (Test): Create the fast-copy mapping tables (MASTER_PK_MAPPING and BEFORE_PK_MAPPING) o...
Review of c14813/7993a.
I am OK with the code. As described above, it should offer a bit of performance boost if t...
Ovidiu Maxiniuc
11:32 AM User Interface Feature #7997: Encryption for client storage data / registry
Yes, and we need to decide if we would use a server-wide key or if we would implement per-account level keys. Greg Shah
10:27 AM User Interface Feature #7997: Encryption for client storage data / registry
What encryption? It should be reversible. Galya B
10:26 AM User Interface Feature #7997: Encryption for client storage data / registry
Registry is accessed in 4GL via @GET-KEY-VALUE@ and @PUT-KEY-VALUE@ methods. In FWD registry is backed up by differen... Galya B
10:18 AM User Interface Feature #7997 (New): Encryption for client storage data / registry
Galya B
09:25 AM Build and Source Control Bug #7996: Ant 'archive' target in FWD project must depend on building all artefacts it archives
The target @archive@ fails for FWD trunk:... Vladimir Tsichevski
09:22 AM Build and Source Control Bug #7996 (New): Ant 'archive' target in FWD project must depend on building all artefacts it arc...
Vladimir Tsichevski
09:16 AM Base Language Feature #6649: improve the performance or SourceNameMapper runtime
*Committed 6649b/rev.14802*.
* Managed to write all the data to @name_map.xml@, avoided creating @path_map.txt@. I m...
Dănuț Filimon
08:42 AM Testing Support #7957: testcases project setup
Roger Borrello wrote:
> It's restricting to use the same variable in multiple places, even if it is generic, like @[...
Marian Edu
11:12 PM Testing Support #7957: testcases project setup
Greg Shah wrote:
> > Tijs, looking at the Wiki page and the @directory.xml.template@ I would like to change the @[cl...
Roger Borrello

11/01/2023

04:48 PM User Interface Feature #4854: origin affinity
Greg Shah wrote:
> Eugenie/Hynek/Sergey: Please review 4854a.
I have no objections in general(just because it is ...
Eugenie Lyzenko
02:48 PM User Interface Feature #4854: origin affinity
Eugenie/Hynek/Sergey: Please review 4854a. Greg Shah
11:28 AM User Interface Feature #4854 (Review): origin affinity
4854a r14802 ready for review. Based on trunk r14792. Changes solve #4854, #4517 and a few unrelated small issues, in... Galya B
08:26 AM User Interface Feature #4854: origin affinity
I'm fine with that so long as it all matches the 4GL behavior. Greg Shah
08:05 AM User Interface Feature #4854: origin affinity
Greg Shah wrote:
> Does @GET-KEY-VALUE@ support @NO-ERROR@ in the 4GL?
No, it seems. I don't know what kind of er...
Galya B
07:55 AM User Interface Feature #4854: origin affinity
Does @GET-KEY-VALUE@ support @NO-ERROR@ in the 4GL? Greg Shah
04:59 AM User Interface Feature #4854: origin affinity
How to suppress error from @GET-KEY-VALUE@? The following line produces @expecting DOT, found 'NO-ERROR'@:... Galya B
03:25 PM Database Bug #7731: performance improvements for FQLPreprocessor
Constantin Asofiei wrote:
> Is the cache configurable via directory.xml? I would leave it to 8192 as default and tu...
Dănuț Filimon
09:02 AM Database Bug #7731: performance improvements for FQLPreprocessor
Dănuț Filimon wrote:
> Constantin Asofiei wrote:
> > OK, please set the cache size to 512k, run the test, look via ...
Constantin Asofiei
08:58 AM Database Bug #7731: performance improvements for FQLPreprocessor
Constantin Asofiei wrote:
> OK, please set the cache size to 512k, run the test, look via the debugger and see what ...
Dănuț Filimon
07:43 AM Database Bug #7731: performance improvements for FQLPreprocessor
Rebased 7731a to latest trunk. It is now at rev. 14811. Alexandru Lungu
06:37 AM Database Bug #7731: performance improvements for FQLPreprocessor
OK, please set the cache size to 512k, run the test, look via the debugger and see what the actual cache size is afte... Constantin Asofiei
06:35 AM Database Bug #7731: performance improvements for FQLPreprocessor
Constantin Asofiei wrote:
> Constantin Asofiei wrote:
> > Dănuț Filimon wrote:
> > > So I should leave the cache s...
Dănuț Filimon
06:28 AM Database Bug #7731: performance improvements for FQLPreprocessor
Constantin Asofiei wrote:
> Dănuț Filimon wrote:
> > So I should leave the cache size to *512k* instead of *8192* a...
Constantin Asofiei
03:17 PM Base Language Feature #6431: implement support to allow CPINTERNAL set to UTF-8 and CP936
Marian, I am trying to run something like @asc(chr(i, 'CodePageA', 'CodePageB'))@. Which parameters should I change? ... Theodoros Theodorou
11:21 AM Base Language Feature #6431: implement support to allow CPINTERNAL set to UTF-8 and CP936
Marian Edu wrote:
> Since you're not using the @-ttwrdrul@ parameter anyway I would say this is exactly the case fro...
Theodoros Theodorou
04:06 AM Base Language Feature #6431: implement support to allow CPINTERNAL set to UTF-8 and CP936
Greg Shah wrote:
> From Theodoros:
>
> The program which creates the data in files looks like this:
Strings/ch...
Marian Edu
03:56 AM Base Language Feature #6431: implement support to allow CPINTERNAL set to UTF-8 and CP936
Theodoros Theodorou wrote:

> I think @-rcodein@ is required too.
Generally speaking all codepages used must be ...
Marian Edu
08:41 PM Base Language Feature #6431: implement support to allow CPINTERNAL set to UTF-8 and CP936
From Theodoros:
The program which creates the data in files looks like this:...
Greg Shah
08:26 PM Base Language Feature #6431: implement support to allow CPINTERNAL set to UTF-8 and CP936
I think the @-cpterm@ and @-cpstream@ options are purely to avoid an unexpected conversion when you output data to a ... Greg Shah
11:38 AM Database Bug #7993 (Review): Create the fast-copy mapping tables (MASTER_PK_MAPPING and BEFORE_PK_MAPPING)...
The fast-copy process uses two intermediary tables (BEFORE__PK__MAPPING and MASTER__PK__MAPPING) to fulfill more comp... Alexandru Lungu
11:01 AM Database Bug #7993 (Test): Create the fast-copy mapping tables (MASTER_PK_MAPPING and BEFORE_PK_MAPPING) o...
Alexandru Lungu
11:29 AM Database Bug #7420 (Test): Optimize Cursor for scrolling AdaptiveQuery
Alexandru Lungu
11:27 AM User Interface Feature #4517 (Review): optionally back the 4GL features for Registry access with the user-specif...
4854a r14802 ready for review. Based on trunk r14792. Changes solve #4854, #4517 and a few unrelated small issues, in... Galya B
07:46 AM User Interface Feature #4517: optionally back the 4GL features for Registry access with the user-specific offlin...
It is for consistency of the protocol and for performance. Greg Shah
03:21 AM User Interface Feature #4517: optionally back the 4GL features for Registry access with the user-specific offlin...
Why is WebSocket messaging using only byte arrays and no text messages? Is there a reason behind that decision or it ... Galya B
10:45 AM Database Feature #7382: Check performance of delete from vs drop table in H2
Constantin Asofiei wrote:
> Alexandru Lungu wrote:
> > Just found out @TRUNCATE TABLE tt@ in H2.
> Isn't this the ...
Alexandru Lungu
10:40 AM Database Feature #7382: Check performance of delete from vs drop table in H2
Alexandru Lungu wrote:
> Just found out @TRUNCATE TABLE tt@ in H2.
Isn't this the same as @DELETE FROM tt@ without ...
Constantin Asofiei
10:31 AM Database Feature #7382: Check performance of delete from vs drop table in H2
Just found out @TRUNCATE TABLE tt@ in H2. I was suspecting that such command should have existed, but now it is confi... Alexandru Lungu
08:53 AM Database Feature #7382: Check performance of delete from vs drop table in H2
With the new fwd-h2-1.33-trunk, FWD temp-tables have a special scan index that is able to distinguish between multipl... Alexandru Lungu
09:05 AM Base Language Feature #6649: improve the performance or SourceNameMapper runtime
Dănuț Filimon wrote:
> At this point I want to ask why does the propath need to be a member of @SourceNameMapperCach...
Hynek Cihlar
08:25 AM Base Language Feature #6649: improve the performance or SourceNameMapper runtime
As mentioned in #6649-83, please do not create the extra @path_map.txt@. Add the data into @name_map.xml@. Greg Shah
08:06 AM Base Language Feature #6649: improve the performance or SourceNameMapper runtime
Here's an update of the implementation progress:
# Managed to extract filenames from RUN statements and write them t...
Dănuț Filimon
08:20 AM Database Feature #7416: Reiterate DatabaseStatistics and leverage to other database profling tools
Profiled and the change has a reasonable time (it fits the time boundaries). It is neither faster nor slower.
*Eri...
Alexandru Lungu
07:48 AM Testing Support #7957: testcases project setup
> Tijs, looking at the Wiki page and the @directory.xml.template@ I would like to change the @[client-start-dir]@ pla... Greg Shah
05:59 AM Testing Support #7957: testcases project setup
Marian: I'm fine by all changes. Better to tackle them all in one go.
For the database full path (H2), perhaps chan...
Tijs Wickardt
03:45 AM Testing Support #7957: testcases project setup
And maybe we can add a placeholder for the database name just in case someone feels the urge to change that later on ;) Marian Edu
03:41 AM Testing Support #7957: testcases project setup
Tijs Wickardt wrote:
> Just try to inform me before you add placeholders to @directory.xml.template@, and I (or some...
Marian Edu
07:30 AM Base Language Feature #7045: re-implement "normal" (non-abend) stack unwinding to avoid throwing an exception
P.S. please look into @errorIfNull@ flag. This will save us from detecting cases where we need / we don't need to gen... Alexandru Lungu
07:29 AM Base Language Feature #7045: re-implement "normal" (non-abend) stack unwinding to avoid throwing an exception
I've reviewed the changes. I intend to change several things, but I will list them here for further advice:
* What...
Alexandru Lungu
06:19 AM Database Feature #7323: Implement soft unique index in FWD-H2
Alexandru Lungu wrote:
> Radu, please queue this task and mark it with higher priority.
On it. I also noticed some ...
Radu Apetrii
06:09 AM Base Language Bug #7299: resolution of the target OO method in chained calls with poly arguments
7299d was merged to trunk as revision 14809 and archived. Constantin Asofiei
01:30 AM Database Feature #6414 (Review): ERROR attribute for buffer, dataset and temp-table
Task branch was rebased to trunk/14805 updated to r14807.
The latest update contains the handling of ERROR attribute...
Ovidiu Maxiniuc

10/31/2023

06:20 PM Database Feature #4722: data import should be able to run with only the converted application jar file (an...
Branch 4722b was rebased to trunk_14805 and is at revision 14806. Roger Borrello
09:17 AM Database Feature #4722: data import should be able to run with only the converted application jar file (an...
Branch 4722b was rebased to trunk_14798 and is at revision 14799. Roger Borrello
08:17 PM Database Feature #4722: data import should be able to run with only the converted application jar file (an...
Ovidiu Maxiniuc wrote:
> Roger Borrello wrote:
> > Question... Is the @-Djava.system.class.loader=com.goldencode.as...
Roger Borrello
05:45 PM Base Language Feature #6431: implement support to allow CPINTERNAL set to UTF-8 and CP936
Marian Edu wrote:
> If it's a character mode client set the @-cpterm@ and maybe also @-cpstream@ to @cp936@ otherw...
Theodoros Theodorou
07:06 AM Base Language Feature #6431: implement support to allow CPINTERNAL set to UTF-8 and CP936
Greg Shah wrote:
> > I also wanted to ask how to run an application using @-cpinternal CP936@. I get the error messa...
Marian Edu
06:59 AM Base Language Feature #6431: implement support to allow CPINTERNAL set to UTF-8 and CP936
> I also wanted to ask how to run an application using @-cpinternal CP936@. I get the error message @Code page conver... Greg Shah
04:49 PM Database Feature #6347: change the name conversion to provide a configurable option to not emit "snake case"
Can this be closed? Is there something remaining to do? Greg Shah
01:57 PM Base Language Bug #7299: resolution of the target OO method in chained calls with poly arguments
7299d was rebased from trunk rev 14799 - new rev 14802. Constantin Asofiei
11:35 AM Base Language Bug #7299: resolution of the target OO method in chained calls with poly arguments
Greg Shah wrote:
> It can merge after 7650a.
I was wrong - I need to do a round of conversion testing with 7299d, I...
Constantin Asofiei
11:10 AM Base Language Bug #7299: resolution of the target OO method in chained calls with poly arguments
It can merge after 7650a. Greg Shah
10:57 AM Base Language Bug #7299: resolution of the target OO method in chained calls with poly arguments
Greg Shah wrote:
> Is any more testing needed before merge?
No, it can be queued for merge.
Constantin Asofiei
10:57 AM Base Language Bug #7299: resolution of the target OO method in chained calls with poly arguments
Is any more testing needed before merge? Greg Shah
10:57 AM Base Language Bug #7299: resolution of the target OO method in chained calls with poly arguments
Code Review Task Branch 7299d Revision 14794
No objections.
Greg Shah
05:41 AM Base Language Bug #7299: resolution of the target OO method in chained calls with poly arguments
Greg Shah wrote:
> In @oo_references.rules@ line 453, don't we need to remove the double quotes around the classname...
Constantin Asofiei
01:34 PM Base Language Bug #7990: investigate what can be improved after 7494a adds BlockDefinition instance to Scopeabl...
With #7494, @scopeStart@ knows the exact @BlockDefinition@ instance which is notified. The same can be added to @sco... Constantin Asofiei
01:32 PM Base Language Bug #7990 (New): investigate what can be improved after 7494a adds BlockDefinition instance to Sc...
Constantin Asofiei
12:49 PM Testing Support #7957: testcases project setup
Marian Edu wrote:
> we can continue to keep the client/unit_test configurations as-is in bazaar, I did not remove th...
Tijs Wickardt
12:12 PM Testing Support #7957: testcases project setup
Marian Edu wrote:
> Well, you did said you don't like them anyway :)
That's true :) But that's just my opinion. Gre...
Tijs Wickardt
12:05 PM Testing Support #7957: testcases project setup
Tijs Wickardt wrote:
> Marian, you've committed template placeholders again.
> So the customer has issues again.
>...
Marian Edu
11:35 AM Testing Support #7957: testcases project setup
Greg Shah wrote:
> Generally we are moving toward a more standardized project setup approach that will indeed have p...
Tijs Wickardt
11:24 AM Testing Support #7957: testcases project setup
It's a bit less serious than I thought.
At the customer docker scripts, @build.properties.template@ and @directory.x...
Tijs Wickardt
11:22 AM Testing Support #7957: testcases project setup
Generally we are moving toward a more standardized project setup approach that will indeed have placeholders in the d... Greg Shah
11:06 AM Testing Support #7957: testcases project setup
Marian, do you think this is the proper way forward?
I see you also added placeholders to server.xml.template, unit_...
Tijs Wickardt
10:47 AM Testing Support #7957: testcases project setup
Marian Edu wrote:
> Related to updating the Wiki, that one has no reference to template files ...
It instructs:
<p...
Tijs Wickardt
10:45 AM Testing Support #7957: testcases project setup
Marian, you've committed template placeholders again.
So the customer has issues again.
I'll have to redo part of m...
Tijs Wickardt
10:43 AM Testing Support #7957: testcases project setup
Tijs Wickardt wrote:
> Me personally, I don't like the placeholders in general.
> I'd rather have xpath expressions...
Marian Edu
10:29 AM Testing Support #7957: testcases project setup
Marian Edu wrote:
> Roger Borrello wrote:
>
> > Does that help?
> Yes, this is what I've thought as well... I'll...
Tijs Wickardt
10:25 AM Testing Support #7957: testcases project setup
Roger Borrello wrote:
> Does that help?
Yes, this is what I've thought as well... I'll update the templates to us...
Marian Edu
10:24 AM Testing Support #7957: testcases project setup
Marian Edu wrote:
> Tell the truth don't know if that is the port number on which the 'app_server' will listen or is...
Tijs Wickardt
10:22 AM Testing Support #7957: testcases project setup
Marian Edu wrote:
> Tell the truth don't know if that is the port number on which the 'app_server' will listen or is...
Roger Borrello
10:20 AM Testing Support #7957: testcases project setup
Marian Edu wrote:
> Tell the truth don't know if that is the port number on which the 'app_server' will listen or is...
Tijs Wickardt
10:18 AM Testing Support #7957: testcases project setup
Galya B wrote:
> Tijs, yes, this is obviously an issue.
Yes, thanks.
We should be more careful with the template...
Tijs Wickardt
10:13 AM Testing Support #7957: testcases project setup
Tijs Wickardt wrote:
> Also this fragment:
> [...]
> I left that as is, but Marian should update wiki: [[p2j:Testc...
Marian Edu
10:03 AM Testing Support #7957: testcases project setup
... Galya B
10:03 AM Testing Support #7957: testcases project setup
Tijs Wickardt wrote:
> Looks indeed suspicious.
> Marian, can you fix?
Yes, I saw that as well when trying to re...
Marian Edu
10:00 AM Testing Support #7957: testcases project setup
Roger Borrello wrote:
> Tijs Wickardt wrote:
> > Do you see anything wrong with the directory fragment?
>
> Is i...
Tijs Wickardt
09:54 AM Testing Support #7957: testcases project setup
Tijs Wickardt wrote:
> Do you see anything wrong with the directory fragment?
Is it that you have the "console" i...
Roger Borrello
09:50 AM Testing Support #7957: testcases project setup
Thank you Galya.
But you can see @rev 14790 >= r14534@ , and @grep '"logging"'@ gives only one hit.
Do you see anyt...
Tijs Wickardt
09:46 AM Testing Support #7957: testcases project setup
Also double check if there are no two "logging" containers or missing closing tags. Galya B
09:45 AM Testing Support #7957: testcases project setup
Tijs Wickardt wrote:
> For now I instruct the customer to delete this block "logging" completely, if they encounter ...
Galya B
09:31 AM Testing Support #7957: testcases project setup
Roger/Galya (because of logging):
OK, I've got testcases working again for the customer.
There is one issue left, w...
Tijs Wickardt
08:36 AM Testing Support #7957: testcases project setup
Greg Shah wrote:
> > (p2j-entry) FQN (not a legacy code reference), or are both supported?
> Both are supported.
N...
Tijs Wickardt
08:31 AM Testing Support #7957: testcases project setup
> FQN (not a legacy code reference), or are both supported?
Both are supported.
Greg Shah
07:32 AM Testing Support #7957: testcases project setup
I also committed an @enabled=FALSE@ for all auxilary services.
Reason:
@23/10/31 11:32:03.485+0100 | SEVERE | com....
Tijs Wickardt
05:50 AM Testing Support #7957: testcases project setup
Roger/Marian, I committed the following:... Tijs Wickardt
03:19 AM Testing Support #7957: testcases project setup
Ovidiu Maxiniuc wrote:
> Form the posted stacks, I _guess_ the executed classes were either:
> * not post-processe...
Marian Edu
11:08 AM Base Language Feature #6649: improve the performance or SourceNameMapper runtime
Rebased 6649b to latest trunk. It is now at rev. 14801. Alexandru Lungu
10:57 AM Base Language Feature #6649: improve the performance or SourceNameMapper runtime
Greg Shah wrote:
> > Both @deleteFile@ and @openStream@ result in the same error.
> > [...]
>
> The @outputFilen...
Dănuț Filimon
10:38 AM Base Language Feature #6649: improve the performance or SourceNameMapper runtime
> Both @deleteFile@ and @openStream@ result in the same error.
> [...]
The @outputFilename@ variable needs to be ...
Greg Shah
09:43 AM Base Language Feature #6649: improve the performance or SourceNameMapper runtime
> Consider that if you emit a separate/new artifact, that must now be documented and managed forever as an extra set ... Alexandru Lungu
09:02 AM Base Language Feature #6649: improve the performance or SourceNameMapper runtime
Greg Shah wrote:
> Consider that if you emit a separate/new artifact, that must now be documented and managed foreve...
Dănuț Filimon
08:45 AM Base Language Feature #6649: improve the performance or SourceNameMapper runtime
> I've analyzed how @name_map.xml@ is created and took in consideration writing to a @.txt@ file which should be simp... Greg Shah
08:34 AM Base Language Feature #6649: improve the performance or SourceNameMapper runtime
Hynek Cihlar wrote:
> Regarding @CACHE_SIZE@, why would you want to limit the number of entries?
This should be t...
Alexandru Lungu
08:14 AM Base Language Feature #6649: improve the performance or SourceNameMapper runtime
I've analyzed how @name_map.xml@ is created and took in consideration writing to a @.txt@ file which should be simple... Dănuț Filimon
04:41 AM Base Language Feature #6649: improve the performance or SourceNameMapper runtime
Perhaps also some at least basic runtime metrics should be gathered with our JMX infrastructure.
Hynek Cihlar
04:34 AM Base Language Feature #6649: improve the performance or SourceNameMapper runtime
Alexandru Lungu wrote:
> ** *Hynek*, in case the PROPATH changes, should we have @SourceNameMapperCache@ empty or po...
Hynek Cihlar
04:35 AM User Interface Feature #3931: single sign-on for virtual desktop mode
Guido Brandsen wrote:
> Galya, today we saw a minor problem with client spawning.
> The error shown in OS login was...
Galya B
04:30 AM User Interface Feature #3931: single sign-on for virtual desktop mode
Galya, today we saw a minor problem with client spawning.
The error shown in OS login was:...
Guido Brandsen
04:02 AM Base Language Bug #6570 (WIP): stale procedure leak when appservers are used
Alexandru Lungu

10/30/2023

07:25 PM Base Language Feature #6431: implement support to allow CPINTERNAL set to UTF-8 and CP936
Greg Shah wrote:
> Theodoros: Please document your findings so far. Help to ensure that the tests written by Daniel...
Theodoros Theodorou
07:30 AM Base Language Feature #6431: implement support to allow CPINTERNAL set to UTF-8 and CP936
If there is a reasonably small data set, then keeping it in the source code should be the standard approach. I agree... Greg Shah
06:54 AM Base Language Feature #6431: implement support to allow CPINTERNAL set to UTF-8 and CP936
BTW, Daniel is working on something more or less the same for the I18N part of the base language unit tests - not spe... Marian Edu
06:51 AM Base Language Feature #6431: implement support to allow CPINTERNAL set to UTF-8 and CP936
Theodoros Theodorou wrote:
> Greg Shah wrote:
> I prefer if that data is coded into the 4GL source, rather than as ...
Marian Edu
04:07 PM Testing Support #7957: testcases project setup
Form the posted stacks, I _guess_ the executed classes were either:
* not post-processed by AspectJ
* the wrong .c...
Ovidiu Maxiniuc
03:24 PM Testing Support #7957: testcases project setup
Please post the testcase. The results seem quite wrong (and unexpected for anything simple). Greg Shah
09:06 AM Testing Support #7957: testcases project setup
OK, the database connection issue is solved now - I've updated the configuration to use @tstcasesdb@ instead of mixin... Marian Edu
03:48 PM Base Language Bug #7299: resolution of the target OO method in chained calls with poly arguments
Code Review Task Branch 7299d Revisions 14792 and 14793
In @oo_references.rules@ line 453, don't we need to remove...
Greg Shah
03:04 PM Base Language Bug #7299: resolution of the target OO method in chained calls with poly arguments
The fixes for #7299-64 and #7976 are in 7299d rev 14793 - please review.
I'll need to go through conversion testin...
Constantin Asofiei
03:34 PM User Interface Feature #4517: optionally back the 4GL features for Registry access with the user-specific offlin...
I'd prefer if both act the same way (default to preferences). Greg Shah
11:28 AM User Interface Feature #4517: optionally back the 4GL features for Registry access with the user-specific offlin...
@Browse@ configs will continue to be saved only in @localStorage@, while registry will fallback to @Preferences@ by d... Galya B
02:48 PM Database Feature #4722: data import should be able to run with only the converted application jar file (an...
Roger Borrello wrote:
> Question... Is the @-Djava.system.class.loader=com.goldencode.asm.AsmClassLoader@ parameter ...
Ovidiu Maxiniuc
12:10 PM Database Feature #4722: data import should be able to run with only the converted application jar file (an...
Branch 4722b was rebased to trunk_14795 and is at revision 14796. Roger Borrello
11:48 AM Base Language Feature #6649: improve the performance or SourceNameMapper runtime
The first one is an expression, so a dynamic way to run a procedure. It can be disregarded for now. The following I t... Alexandru Lungu
10:24 AM Base Language Feature #6649: improve the performance or SourceNameMapper runtime
A few cases that I found while running a Hotel_GUI conversion and should be mentioned:
- @RUN VALUE(possiblePath) PE...
Dănuț Filimon
08:41 AM Base Language Feature #6649: improve the performance or SourceNameMapper runtime
Danut:
* Not only RUN statements should be analyzed. Also anything that is going to be a path (like Hynek stated, IM...
Alexandru Lungu
08:34 AM Base Language Feature #6649: improve the performance or SourceNameMapper runtime
A new @path_map.xml@ file should be created, similar to @name_map.xml@, with nodes that specify the paths for each RU... Dănuț Filimon
06:30 AM Base Language Feature #6649: improve the performance or SourceNameMapper runtime
Hynek Cihlar wrote:
> Unless I'm missing something using @RUN_CALL_SITE_*@ for the caching/precalculation isn't opti...
Alexandru Lungu
08:51 AM Database Bug #7667: Support OUTER-JOIN with PRESELECT at conversion
Has enough testing been done to confirm that 7667b is safe?
Are any other code reviews needed?
Greg Shah
07:22 AM Database Bug #7797 (Closed): FWD-H2 LAZY reverse index regression
Greg Shah
06:34 AM Database Bug #7797: FWD-H2 LAZY reverse index regression
This reached trunk in fwd-h2-1.33-trunk and can be closed. Alexandru Lungu
06:55 AM Database Bug #7567: use Session.PK instead of DatabaseManager.PRIMARY_KEY wherever possible
*7567a_h2* reached FWD-H2 trunk, which ultimately is delivered with the FWD trunk as fwd-h2-1.33-trunk.
I also rebas...
Alexandru Lungu

10/28/2023

12:32 AM Database Feature #4722: data import should be able to run with only the converted application jar file (an...
Ovidiu Maxiniuc wrote:
> Yes, Roger, I think you should fork a new branch, 4722b.
> I also have small updates relat...
Roger Borrello
09:57 PM Database Feature #6414 (WIP): ERROR attribute for buffer, dataset and temp-table
I created 6414a and committed the first part of the changes which include only for passing the ERROR attribute with t... Ovidiu Maxiniuc

10/27/2023

06:25 PM Database Feature #4722: data import should be able to run with only the converted application jar file (an...
Yes, Roger, I think you should fork a new branch, 4722b.
I also have small updates related to import, not dramatic, ...
Ovidiu Maxiniuc
05:18 PM Database Feature #4722: data import should be able to run with only the converted application jar file (an...
Roger Borrello wrote:
> I have an update to @import.sh@ which I need to get to trunk. I thought #7572 might be a goo...
Roger Borrello
05:08 PM Database Feature #4722: data import should be able to run with only the converted application jar file (an...
I have an update to @import.sh@ which I need to get to trunk. I thought #7572 might be a good task, since the fix in ... Roger Borrello
04:41 PM Database Feature #4722: data import should be able to run with only the converted application jar file (an...
Nevermind... my url did not include: @;MV_STORE=FALSE;LOG=0;CACHE_SIZE=65536;LOCK_MODE=0;UNDO_LOG=0@ Roger Borrello
04:38 PM Database Feature #4722: data import should be able to run with only the converted application jar file (an...
When configuring the database using @import.sh@, the H2 creation/import doesn't seem to be working properly. When I c... Roger Borrello
04:37 PM Base Language Feature #6431: implement support to allow CPINTERNAL set to UTF-8 and CP936
Greg Shah wrote:
I prefer if that data is coded into the 4GL source, rather than as a data file. Data file access a...
Theodoros Theodorou
03:31 PM User Interface Feature #4854: origin affinity
Hynek Cihlar wrote:
> With @waitForResult@ you will make @MSG_SET_KEY_VALUE@ effectively synchronous. So I suppose t...
Hynek Cihlar
03:28 PM User Interface Feature #4854: origin affinity
AFAIK every message deals with errors on its own, we don't have a common error handling mechanism. Look at @GuiWebSoc... Hynek Cihlar
03:24 PM User Interface Feature #4854: origin affinity
Galya B wrote:
> Is there any practice already in place for sending back errors from the front-end for WebSocket mes...
Sergey Ivanovskiy
03:12 PM User Interface Feature #4854: origin affinity
Galya B wrote:
> 5 mil chars is quite a lot for config storage. This @localStorage@ will be available to customers t...
Sergey Ivanovskiy
10:23 AM User Interface Feature #4854: origin affinity
Is there any practice already in place for sending back errors from the front-end for WebSocket messages? ... if some... Galya B
10:10 AM User Interface Feature #4854: origin affinity
> Currently @localStorage@ is used only for the enhanced @browse@ configs. There is no error handling in place. This ... Greg Shah
10:06 AM User Interface Feature #4854: origin affinity
Greg Shah wrote:
> I'm OK with storage limitations, so long as we have a consistent behavior that is exposed to the ...
Galya B
08:15 AM User Interface Feature #4854: origin affinity
I'm OK with storage limitations, so long as we have a consistent behavior that is exposed to the 4GL code as a legacy... Greg Shah
01:48 AM User Interface Feature #4854: origin affinity
5 mil chars is quite a lot for config storage. This @localStorage@ will be available to customers through the registr... Galya B
01:16 PM Database Bug #7924: add support for creating an empty database
Dănuț Filimon wrote:
> It seems that MariaDB has a problem that is not related to the changes made here. As you ment...
Ovidiu Maxiniuc
08:09 AM Database Bug #7924: add support for creating an empty database

> ... but I am still having issues when trying to connect to the database.
I overlooked the fact that I need to ch...
Dănuț Filimon
07:58 AM Database Bug #7924: add support for creating an empty database
Ovidiu Maxiniuc wrote:
> I tested the import using both ant script and fwd's @import.sh@.
>
> The @import.sh@ per...
Dănuț Filimon
09:22 PM Database Bug #7924: add support for creating an empty database
I tested the import using both ant script and fwd's @import.sh@.
The project's @build_db.xml@ needed some changes ...
Ovidiu Maxiniuc
11:10 AM Base Language Feature #7045: re-implement "normal" (non-abend) stack unwinding to avoid throwing an exception
The NPE is fixed now, but the regression tests I have still fail. Again, I don't have a replicate (just that the expe... Alexandru Lungu
10:27 AM User Interface Feature #4517: optionally back the 4GL features for Registry access with the user-specific offlin...
> It's doable, but then can we make localStorage the non-default, because it's more different?
Yes, that makes sense.
Greg Shah
10:15 AM User Interface Feature #4517: optionally back the 4GL features for Registry access with the user-specific offlin...
Greg Shah wrote:
> Review of #4517-13:
> > Do we want the web under linux to also store in @Preferences.userRoot@? ...
Galya B
10:08 AM User Interface Feature #4517: optionally back the 4GL features for Registry access with the user-specific offlin...
Review of #4517-13:
* Shouldn't the "Shared between" column for the @Win/other@ scenarios that use @LOAD BASE-KEY ...
Greg Shah
09:54 AM User Interface Feature #4517: optionally back the 4GL features for Registry access with the user-specific offlin...
I'm almost ready with the implementation. Can I have a review of the table? Galya B
09:17 AM User Interface Feature #4517: optionally back the 4GL features for Registry access with the user-specific offlin...
Greg Shah wrote:
> The table in #4517-13 is about FWD behavior (I think). Is this meant to document the current beh...
Galya B
09:16 AM User Interface Feature #4517: optionally back the 4GL features for Registry access with the user-specific offlin...
Do we want the web under linux to also store in @Preferences.userRoot@? It will be more consistent to everything else... Galya B
09:16 AM User Interface Feature #4517: optionally back the 4GL features for Registry access with the user-specific offlin...
The table in #4517-13 is about FWD behavior (I think). Is this meant to document the current behavior before any cha... Greg Shah
09:13 AM User Interface Feature #4517: optionally back the 4GL features for Registry access with the user-specific offlin...
> Do we want all web clients always to store registry in the browser for consistency?
No, some customers will want...
Greg Shah
09:11 AM User Interface Feature #4517: optionally back the 4GL features for Registry access with the user-specific offlin...
The client process for web is on the server if no brokers are configured. And brokers are reused by multiple clients. Galya B
09:11 AM User Interface Feature #4517: optionally back the 4GL features for Registry access with the user-specific offlin...
Do we want all web clients always to store registry in the browser for consistency? Galya B

10/26/2023

02:31 PM Base Language Bug #7299: resolution of the target OO method in chained calls with poly arguments
Created task branch 7299d from trunk rev 14791.
7299d rev 14792 contains a regression fix for static poly calls - ...
Constantin Asofiei
12:05 PM User Interface Feature #4854: origin affinity
I guess that solution can be using a local storage for a different origin that extends the common origin. Sergey Ivanovskiy
11:04 AM User Interface Feature #4854: origin affinity
It seems that there is an open question how to extent a storage for a user as there is the web storage limit for the ... Sergey Ivanovskiy
10:06 AM User Interface Feature #4854: origin affinity
OK. I checked this test for the Firefox, so it follows that the @locationStorage@ storage is used per origin but not ... Sergey Ivanovskiy
09:54 AM User Interface Feature #4854: origin affinity
Unfortunately Redmine struggles with the 5MB texts for each value, so if you're not able to copy it from here, copy i... Galya B
09:44 AM User Interface Feature #4854: origin affinity
OK, here is the test (inspired by https://arty.name/localstorage.html):
Key 'test' is successfully saved, 'test2' ...
Galya B
09:33 AM User Interface Feature #4854: origin affinity
I need to prove the Mozilla documentation? It's written in the link you shared https://developer.mozilla.org/en-US/do... Galya B
09:29 AM User Interface Feature #4854: origin affinity
I would agree if you proved it by the similar test that the storage is used per origin but not per a key. This test i... Sergey Ivanovskiy
09:11 AM User Interface Feature #4854: origin affinity
So do we agree on the change? Galya B
09:03 AM User Interface Feature #4854: origin affinity
Nice, I was about to write something. 5200000 chars max in my case. According to https://developer.mozilla.org/en-US/... Galya B
09:00 AM User Interface Feature #4854: origin affinity
You can use this test program https://arty.name/localstorage.html that checks... Sergey Ivanovskiy
08:21 AM User Interface Feature #4854: origin affinity
Galya B wrote:
> Sergey Ivanovskiy wrote:
> > Why @UserKeyValueStorage@ was removed? What is its substitution? @Use...
Sergey Ivanovskiy
04:24 AM User Interface Feature #4854: origin affinity
Sergey Ivanovskiy wrote:
> Why @UserKeyValueStorage@ was removed? What is its substitution? @UserKeyValueStorage@ wa...
Galya B
03:42 AM User Interface Feature #4854: origin affinity
Why @UserKeyValueStorage@ was removed? What is its substitution? @UserKeyValueStorage@ was needed to store large data... Sergey Ivanovskiy
10:15 AM Database Bug #7667: Support OUTER-JOIN with PRESELECT at conversion
I just checked-out 7667b and changes are OK (#7667-13).
I suggest getting this into trunk when possible; this was ...
Alexandru Lungu
05:39 AM Database Bug #7924: add support for creating an empty database
*Committed 7924a/rev.14792*. Fixed the additional @idx__@ and modified the import to always process the records of th... Dănuț Filimon
04:43 AM Database Bug #7924: add support for creating an empty database
Ovidiu Maxiniuc wrote:
> Please replace @data.formatWithEscapedParameter("idx__%s", text)@ with the simple @text@. H...
Dănuț Filimon
04:43 AM User Interface Feature #4517: optionally back the 4GL features for Registry access with the user-specific offlin...
The most obvious problem I see right away is with web users on Windows. All of them would share this "device id" the ... Galya B
03:19 AM User Interface Feature #4517: optionally back the 4GL features for Registry access with the user-specific offlin...
Storage for @GET-KEY-VALUE@ and @PUT-KEY-VALUE@:
|OS|@LOAD BASE-KEY "INI"@|Client Type|Storage|Storage lifespan|Sh...
Galya B
02:19 AM Database Feature #6414: ERROR attribute for buffer, dataset and temp-table
Eric Faulhaber wrote:
> Ovidiu Maxiniuc wrote:
> > Do we have tests in xfer test suite for this attribute?
>
> I...
Marian Edu

10/25/2023

04:55 PM Testing Support #7957: testcases project setup
The latest revision I checked in (1482) should work out of the box for the post-14783 revision of trunk, so this bran... Roger Borrello
01:26 PM Testing Support #7957: testcases project setup
Marian Edu wrote:
> Now, when I try `ant create.db` it doesn't give any error but it also doesn't seem to do anyth...
Ovidiu Maxiniuc
10:17 AM Testing Support #7957: testcases project setup
Roger Borrello wrote:
> Marian Edu wrote:
> > Thanks Roger, did update to that revision and gave it a try:
> > - I...
Roger Borrello
09:03 AM Testing Support #7957: testcases project setup
Marian Edu wrote:
> Thanks Roger, did update to that revision and gave it a try:
> - I presume the references to `t...
Roger Borrello
04:49 AM Testing Support #7957: testcases project setup
Roger Borrello wrote:
> See revision 1480 which revamps the @cfg/p2j.cfg.xml@, @build.xml@, and @build_db.xml@ to ut...
Marian Edu
03:01 AM Testing Support #7957: testcases project setup
Marian Edu wrote:
> Ovidiu Maxiniuc wrote:
> > From the description of this thread I understand that you have confi...
Tijs Wickardt
02:30 AM Testing Support #7957: testcases project setup
Greg Shah wrote:
> In regard to Java 11, see [[p2j:Switching Between Java 8 and Java 11]].
Yes, more or less what...
Marian Edu
02:28 AM Testing Support #7957: testcases project setup
Greg Shah wrote:
> Eric/Ovidiu can help with the persistence issue.
>
> About the GUI failure in native code, I t...
Marian Edu
02:27 AM Testing Support #7957: testcases project setup
Ovidiu Maxiniuc wrote:
> From the description of this thread I understand that you have configured PostgreSQL, initi...
Marian Edu
03:45 PM Database Bug #7924: add support for creating an empty database
Please replace @data.formatWithEscapedParameter("idx__%s", text)@ with the simple @text@. H2 and PostgreSQL will stil... Ovidiu Maxiniuc
08:32 AM Database Bug #7924: add support for creating an empty database
The additional @idx__@ is added when instantiating the index definition in @schema/import@ using @data.formatWithEsca... Dănuț Filimon
06:47 AM Database Bug #7924: add support for creating an empty database
Fixed a NPE at conversion time in *7924a/rev.14791*. Dănuț Filimon
05:49 AM Database Bug #7924: add support for creating an empty database
I extended @import.sh@ to support creation of an empty database. I've *committed 7924a/rev.14790*, the changes consis... Dănuț Filimon
02:25 PM Database Feature #6414: ERROR attribute for buffer, dataset and temp-table
Ovidiu Maxiniuc wrote:
> Do we have tests in xfer test suite for this attribute?
I am not aware of any. Marian, d...
Eric Faulhaber
12:47 PM Base Language Feature #6410: implement additional built-in OO classes/interfaces
6410b is now on trunk rev 14790 and was pushed to xfer. Constantin Asofiei
12:34 PM Base Language Feature #6410: implement additional built-in OO classes/interfaces
Constantin Asofiei wrote:
> Marian, please let me know when you have everything committed to 6410b, so I can get it ...
Marian Edu
10:13 AM Base Language Feature #6410: implement additional built-in OO classes/interfaces
Marian, please let me know when you have everything committed to 6410b, so I can get it from xfer, to rebase it. Constantin Asofiei
10:49 AM Database Support #7963: disable dirty share database and test existing customer applications
Test the existing #7037 features and any new #7964 features with each of our existing customer applications to see if... Greg Shah
10:39 AM Database Support #7963 (New): disable dirty share database and test existing customer applications
Greg Shah
10:48 AM Database Feature #7964: investigate the benefits of disabling cross-session features of the dirty share da...
When we removed Hibernate (#4011), we implemented the record nursery which was meant to be a more efficient way to ma... Greg Shah
10:42 AM Database Feature #7964 (New): investigate the benefits of disabling cross-session features of the dirty sh...
Greg Shah
10:05 AM Database Feature #7416: Reiterate DatabaseStatistics and leverage to other database profling tools
*Branch 7416b, rev. 14767-14772 summary:*
* Removed @DatabaseStatistics@ and its usages.
* In @P2JQueryStatistics@:...
Radu Apetrii
08:30 AM Database Feature #7416: Reiterate DatabaseStatistics and leverage to other database profling tools
*Review of 7416b, rev. 14772*
* I am OK with the changes. These are not functionally changing FWD, but are quite i...
Alexandru Lungu
07:16 AM Database Feature #7416: Reiterate DatabaseStatistics and leverage to other database profling tools
Alexandru Lungu wrote:
> * Add history numbers to @Validation@ (and all other classes that have changes on this bran...
Radu Apetrii
09:47 AM Base Language Feature #7045: re-implement "normal" (non-abend) stack unwinding to avoid throwing an exception
Eduard, I see you fixed this (#7045-62) in a new revision. I will need to recompile the project I use for test in ord... Alexandru Lungu
04:27 AM Base Language Feature #7045: re-implement "normal" (non-abend) stack unwinding to avoid throwing an exception
PS: good news, a large customer application converted (~17 hours) and compiled (~1 hour) correctly. Also, it passed s... Alexandru Lungu
04:26 AM Base Language Feature #7045 (WIP): re-implement "normal" (non-abend) stack unwinding to avoid throwing an excep...
Eduard, I am facing some regressions with @CompoundQuery.retrieveImpl@ (mostly NPE). I see there is a duplicate code ... Alexandru Lungu
08:13 AM User Interface Feature #4854: origin affinity
Stanislav is the expert in enhanced browse. Greg Shah
08:13 AM User Interface Feature #4854: origin affinity
Hotel GUI embedded mode has the enhanced browse activated, but virtual desktop mode doesn't (if I recall correctly). Greg Shah
08:06 AM User Interface Feature #4854: origin affinity
For the old @testcases@ project I have these settings ... Sergey Ivanovskiy
07:54 AM User Interface Feature #4854: origin affinity
Galya, see this wiki: [[p2j:Browse_Widget_Enhancements]]. Hotel GUI has the enhanced browse (if it doesn't, then thi... Constantin Asofiei
07:51 AM User Interface Feature #4854: origin affinity
Sergey, can you help me with an example in 4GL for enhanced @browse@. I don't seem to understand how to enable the ge... Galya B
07:50 AM User Interface Feature #4854 (WIP): origin affinity
Although 4854 is done, 4854a will also have the changes for #4517, because both tasks are related in the code. Movin... Galya B
07:54 AM Database Feature #7960: Allow query logs to be collected in a H2 database
Branch 7416b will be merged into trunk soon (good news). Those changes include the removal of @DatabaseStatistics@, m... Radu Apetrii
07:19 AM Database Feature #7960 (Closed): Allow query logs to be collected in a H2 database
Radu Apetrii
07:01 AM Database Feature #7323: Implement soft unique index in FWD-H2
Also:
* major: mind moving @stopValidating@ in a finally clause. Otherwise, an exception will miss the stopping of...
Alexandru Lungu
07:00 AM Database Feature #7323 (WIP): Implement soft unique index in FWD-H2
I attempted to profile 7323a and succeeded into actually running it, but the time is way off (+3-4%). After some revi... Alexandru Lungu
03:53 AM Database Feature #7323: Implement soft unique index in FWD-H2
Rebased 7323a to latest trunk. 7323a is now at rev. 14799. Alexandru Lungu

10/24/2023

04:44 PM Testing Support #7957: testcases project setup
Marian,
From the description of this thread I understand that you have configured PostgreSQL, initialized the/a cl...
Ovidiu Maxiniuc
04:03 PM Testing Support #7957: testcases project setup
Greg Shah wrote:
> Eric/Ovidiu can help with the persistence issue.
>
> About the GUI failure in native code, I t...
Roger Borrello
03:50 PM Testing Support #7957: testcases project setup
See revision 1480 which revamps the @cfg/p2j.cfg.xml@, @build.xml@, and @build_db.xml@ to utilize up-to-date standard... Roger Borrello
08:44 AM Testing Support #7957: testcases project setup
In regard to Java 11, see [[p2j:Switching Between Java 8 and Java 11]]. Greg Shah
08:42 AM Testing Support #7957: testcases project setup
Eric/Ovidiu can help with the persistence issue.
About the GUI failure in native code, I think that is the same GU...
Greg Shah
08:38 AM Testing Support #7957: testcases project setup
From Marian:
I know you've made a task for ABLUnit support, I did thought the issue is related to the custom JUnit...
Greg Shah
08:35 AM Testing Support #7957 (New): testcases project setup
Greg Shah
03:54 PM Database Feature #4722: data import should be able to run with only the converted application jar file (an...
I committed updates to the @testcases@ project which should work better. The changes bring it closer in line to hotel... Roger Borrello
09:33 AM Base Language Feature #7045: re-implement "normal" (non-abend) stack unwinding to avoid throwing an exception
> Eric: Please review.
The changes are quite extensive, so the review will take a bit :) I am converting a big app...
Alexandru Lungu
09:28 AM Base Language Feature #7045 (Review): re-implement "normal" (non-abend) stack unwinding to avoid throwing an ex...
Greg Shah
09:27 AM Base Language Feature #7045: re-implement "normal" (non-abend) stack unwinding to avoid throwing an exception
Eric: Please review. Greg Shah
03:20 AM Base Language Feature #7045: re-implement "normal" (non-abend) stack unwinding to avoid throwing an exception
Committed on 7045b, revision 14683.
Also tested changes to @forBlock@, @forEach@ blocks and also to @next@, @last@,...
Eduard Soltan
08:24 AM Database Bug #7924: add support for creating an empty database
It is better to augment @import.sh@ than to add a new script.
Most importantly: @import.sh@ is meant to be just a ...
Greg Shah
03:45 AM Database Bug #7924: add support for creating an empty database
I started working on this task, should the @import.sh@ added in trunk/rev.14773 be extended for this case or a new @c... Dănuț Filimon
12:33 AM User Interface Feature #3931: single sign-on for virtual desktop mode
Eugenie Lyzenko wrote:
> Galya,
>
> Should the following entries also be removed from @directory.xml@?
>
> [.....
Galya B

10/23/2023

04:09 PM Database Feature #6720: lazy hydration
I like this idea. Eric Faulhaber
11:16 AM Database Feature #6720: lazy hydration
*Committed 6720b/rev. 14767*:
* ported some changes from 7185a designed specially for private @BaseRecord.data@ ac...
Alexandru Lungu
03:36 PM User Interface Feature #3931: single sign-on for virtual desktop mode
Galya,
Should the following entries also be removed from @directory.xml@?...
Eugenie Lyzenko
11:56 AM User Interface Feature #3931: single sign-on for virtual desktop mode
3931a was merged to trunk as rev. 14783 and archived. Galya B
11:34 AM User Interface Feature #3931 (Test): single sign-on for virtual desktop mode
Galya B
03:07 PM Base Language Bug #7299: resolution of the target OO method in chained calls with poly arguments
7299c was merged to trunk as rev. 14787 and archived. Constantin Asofiei
03:02 PM Base Language Bug #7299: resolution of the target OO method in chained calls with poly arguments
Code Review Task Branch 7299c Revision 14787
No objection. This seems pretty safe. Do you think it can be merged...
Greg Shah
11:16 AM Base Language Bug #7299: resolution of the target OO method in chained calls with poly arguments
Created task branch 7299c from trunk rev 14786.
7299c rev 14787 fixed another regression in trunk rev 14770, for u...
Constantin Asofiei
01:10 PM User Interface Bug #7946 (WIP): Default selection and current browse row color differs for different customers a...
Created task branch 7946a from FWD trunk revision 14786. Stanislav Lomany
12:38 PM User Interface Bug #7946: Default selection and current browse row color differs for different customers applica...
Very nice work in figuring this out! Greg Shah
12:38 PM User Interface Bug #7946: Default selection and current browse row color differs for different customers applica...
Stanislav Lomany wrote:
> Should we add @oldBrowseSelectionBar@ parameter to the directory? E.g. in @server/default/...
Greg Shah
11:57 AM User Interface Feature #4129: map web client users to OS accounts
3931a was merged to trunk as rev. 14783 and archived. Galya B
11:34 AM User Interface Feature #4129 (Test): map web client users to OS accounts
Galya B
10:34 AM Database Bug #7788: NPE when assigning query to browse
I have returned to this issue. I tried modifying this piece of code:... Alexandru Donica
10:33 AM Database Bug #7924: add support for creating an empty database
Danut, mind that I will move this in High Priority. Even if it is part of the Database thread, it is also a feature r... Alexandru Lungu

10/22/2023

07:17 AM User Interface Feature #4856 (WIP): web client session forking
Galya B
 

Also available in: Atom