Activity
From 09/26/2022 to 10/25/2022
10/26/2022
- 09:27 PM Feature #6348: implement support for MariaDB
- Further information on sequences.
It seems that we cannot rely on @lastval()@ method at all to detect the current ...
10/25/2022
- 04:21 PM Feature #6371: implement SAVE CACHE statement
- Pushed point 2 from list above. See revision 6371a/14116.
Point 1 is still in progress. - 12:13 PM Feature #6453: temp-table features
- Marian,
Sorry for disturbing you, but I've stuck with the problem of running my test with the OE App. Server.
The t... - 11:53 AM Feature #4056: instrument FWD and supporting libraries to measure database performance
- Committed 6129b/rev. 14307 including the new support for the HTML presentation of the method tracing data. There are ...
- 10:16 AM Feature #4056: instrument FWD and supporting libraries to measure database performance
- Alexandru Lungu wrote:
> Eric Faulhaber wrote:
> > Please commit the same update to branch 6129b today. Thank you.
... - 04:03 AM Feature #4056: instrument FWD and supporting libraries to measure database performance
- Eric Faulhaber wrote:
> Please commit the same update to branch 6129b today. Thank you.
Done it in 6129b/rev. 143... - 02:10 AM Feature #4056: instrument FWD and supporting libraries to measure database performance
- Dănuț Filimon wrote:
> Committed 3821c/rev.14313. Added AspectJ on @com.goldencode.p2j.persist.orm@ subpackage while... - 08:41 PM Bug #6837 (WIP): prevent unnecessary upper/rtrim injection in queries if the data type doesn't re...
- Eric Faulhaber wrote:
> I agree that we don't want dialect-specific metadata in DMO annotations. OTOH, I think it ma...
10/24/2022
- 07:23 PM Bug #6837: prevent unnecessary upper/rtrim injection in queries if the data type doesn't require it
- I agree that we don't want dialect-specific metadata in DMO annotations. OTOH, I think it makes sense to store that m...
- 06:34 PM Bug #6837: prevent unnecessary upper/rtrim injection in queries if the data type doesn't require it
- The dropping of the @upper()@ / @rtrim()@ functions injected during conversion must be done anyway. Initially, it wil...
- 01:08 PM Bug #4071: FWD server stops allowing new web client logins after abend
- I'll also try to force the race condition Greg detected using a small sleep.
- 12:49 PM Bug #4071: FWD server stops allowing new web client logins after abend
- Okay. I'll try to hammer the system (testcases and/or <app>) concurrently, trying to overlap client shutdowns.
- 12:14 PM Bug #4071: FWD server stops allowing new web client logins after abend
- Unfortunately, I never found a reliable way to recreate this condition, else it probably would be fixed already.
- 11:39 AM Bug #4071: FWD server stops allowing new web client logins after abend
- Eric: Do you recall the details on how this problem can be recreated? Tijs is asking for guidance in #6787-70.
If... - 07:45 AM Feature #6830: find and fix all SQL SELECT statements with inlined literal arguments, and rewrite...
- Greg Shah wrote:
> > Greg, is this a good moment to add the patch to 3821c?
>
> How safe are the changes? Have w... - 07:25 AM Feature #6830: find and fix all SQL SELECT statements with inlined literal arguments, and rewrite...
- > Greg, is this a good moment to add the patch to 3821c?
How safe are the changes? Have we tested them in one of ... - 06:52 AM Feature #6830: find and fix all SQL SELECT statements with inlined literal arguments, and rewrite...
- I reviewed the @6830.patch@. Nice job!
A couple of notes related to affected code:
* in @FastCopyHelper.java@ I s... - 06:15 AM Feature #6830: find and fix all SQL SELECT statements with inlined literal arguments, and rewrite...
- Here's the patch you requested. It was built on 3821c, rev. 14307.
I also modified @ReportApi.persistSearchHistory@ ... - 07:05 AM Bug #6868: MariaDB Dialect can't properly check if a sequence exists
- Radu Apetrii wrote:
> As a side note, I noticed there was a slight difference in results when running the test from ... - 06:23 AM Bug #6868: MariaDB Dialect can't properly check if a sequence exists
- As a side note, I noticed there was a slight difference in results when running the test from #6868-1 in both Postgre...
10/21/2022
- 07:10 PM Feature #6371: implement SAVE CACHE statement
- I pushed an update that handles the properties of columns (types, nullable, default, etc.), provides null-safe readin...
- 09:39 AM Feature #4056: instrument FWD and supporting libraries to measure database performance
- Committed 3821c/rev.14313. Added AspectJ on @com.goldencode.p2j.persist.orm@ subpackage while keeping @com.goldencode...
- 03:43 AM Feature #6830: find and fix all SQL SELECT statements with inlined literal arguments, and rewrite...
- Radu, please post a patch here for review, and mention the branch and revision it was built on.
10/20/2022
- 11:55 AM Feature #6830: find and fix all SQL SELECT statements with inlined literal arguments, and rewrite...
- Radu Apetrii wrote:
> * I could not test @MariaDbDialect.getSequenceSetValString@ because I cannot access sequences ... - 06:57 AM Feature #6830: find and fix all SQL SELECT statements with inlined literal arguments, and rewrite...
- I have tested these prepared statements (from the last post) and I got the following results:
* Out of 16 modificati... - 11:41 AM Bug #6868 (Feedback): MariaDB Dialect can't properly check if a sequence exists
- I assume you use 3821c.
This is an issue which was addressed in another branch. To allow you advance until the merge... - 05:57 AM Bug #6868: MariaDB Dialect can't properly check if a sequence exists
- I tried executing with MariaDB (10.3.34) database this example:...
- 05:50 AM Bug #6868 (Feedback): MariaDB Dialect can't properly check if a sequence exists
- 09:13 AM Feature #6418: represent extent fields as arrays
- Greg Shah wrote:
> The above is my opinion. Eric makes the final decision here.
Any decision yet?
- 09:10 AM Feature #6695: Multi-table preselect query may underperform due to repetitive fetching
- There is already some work for #6720 which is close to this thread.
*I am planning to move my changes from 6582a to ... - 06:23 AM Feature #4056: instrument FWD and supporting libraries to measure database performance
- I got it now. It was a mistake from my part (I was not using @-a@ option on the target server to be traced, but on th...
- 05:17 AM Feature #4056: instrument FWD and supporting libraries to measure database performance
- > The queries (adaptive, preselect or compound) are not considered for "debug weaving" nor for "debug not weaving" (b...
- 12:24 AM Feature #4056: instrument FWD and supporting libraries to measure database performance
- Eric Faulhaber wrote:
> For reference, I am attaching another @trace.csv@ file that was generated after implementi...
10/19/2022
- 06:24 PM Feature #6720: lazy hydration
- Yes, that is what I calling partial record hydration.
- 03:18 PM Feature #6720: lazy hydration
- Greg, I think that #5731-399 doesn't implement lazy hydration. It just extends the usage of FWD Persistence API for e...
- 09:42 AM Feature #6720: lazy hydration
- Code posted in #5731-399 implements partial record hydration.
- 04:01 PM Feature #4056: instrument FWD and supporting libraries to measure database performance
- TBH, I've never fully understood the AspectJ weaving implementation, though back when I initially implemented this, I...
- 04:09 AM Feature #4056: instrument FWD and supporting libraries to measure database performance
- I could set-up this feature with 3821c/rev.14305 and Hotel GUI. I am starting a standard server and then I attach the...
- 09:41 AM Feature #2137: runtime support for FIELDS/EXCEPT record phrase options
- Code posted in #5731-399 implements partial record hydration.
- 09:07 AM Feature #6453: temp-table features
- Greg Shah wrote:
> We need to match the results exactly. No short cuts.
I see. So I definitely need to be able t... - 09:02 AM Feature #6453: temp-table features
- We need to match the results exactly. No short cuts.
- 08:56 AM Feature #6453: temp-table features
- Igor Skornyakov wrote:
> BTW: what can go wrong if we ignore @SCHEMA-MARSHAL@ and always send *all* schema attribu... - 08:51 AM Feature #6453: temp-table features
- Marian Edu wrote:
> If it's easier for you we can write the 4GL tests on our side and then you run those on FWD, e... - 08:06 AM Feature #6453: temp-table features
- Igor Skornyakov wrote:
> If I will be able to run at least one test from @testcases/appsrv@ with 4GL I believe I w... - 06:11 AM Feature #6453: temp-table features
- Marian Edu wrote:
> Igor Skornyakov wrote:
> > Marian,
> > I've finished (hopefully) with other substasks and star... - 05:54 AM Feature #6453: temp-table features
- Igor Skornyakov wrote:
> Marian,
> I've finished (hopefully) with other substasks and started working on testing @S... - 04:08 AM Feature #6453: temp-table features
- Marian Edu wrote:
> Greg Shah wrote:
> > Constantin/Marian: Can you please advise Igor on how he can test the behav... - 07:42 AM Support #6714: check if there is an optimization opportunity when copying temp-tables based on mu...
- I have created tests with the mentioned specifications and all passed (same results were obtained from the executed s...
10/18/2022
- 04:58 PM Feature #6371: implement SAVE CACHE statement
- I have successfully loaded a table / new DMO into my server runtime. Code is in 6371a/14114 revision.
- 11:22 AM Bug #6852: Problem with datetime-tz literal string conversion.
- The field definition...
- 11:21 AM Bug #6852 (New): Problem with datetime-tz literal string conversion.
- 11:16 AM Feature #6453: temp-table features
- Eric Faulhaber wrote:
> Yes, please do, and let's focus on the remaining core items of this task. What is left?
... - 11:13 AM Feature #6453: temp-table features
- Igor Skornyakov wrote:
> As far as I understand @relex()@ cannot properly and reliably detect the literal type since... - 08:21 AM Feature #6453: temp-table features
- As far as I understand @relex()@ cannot properly and reliably detect the literal type since it does not consider @vty...
- 06:58 AM Feature #6453: temp-table features
- Greg Shah wrote:
> Look at @initializer_constant@ in @progress.g@. There is a @relex()@ step that occurs when the l... - 06:57 AM Feature #6453: temp-table features
- Look at @initializer_constant@ in @progress.g@. There is a @relex()@ step that occurs when the literal is quoted tex...
- 06:49 AM Feature #6453: temp-table features
- Igor Skornyakov wrote:
> Igor Skornyakov wrote:
> > I've noticed the following conversion problem:
> > The field d... - 06:02 AM Feature #6453: temp-table features
- Fixed @COLUMN-CODEPAGE@ and @now@/@today@ @INITIAL@ attribute values for dynamic temp-tables.
Please review.
Thank ... - 05:08 AM Feature #6453: temp-table features
- Igor Skornyakov wrote:
> I've noticed the following conversion problem:
> The field definition
> [...]
> is conve... - 09:16 PM Bug #6301: incorrect initialization of date-related fields with today and now literals
- Eric Faulhaber wrote:
> A fix is committed to 3821c/14279. I have tested with the above test case.
>
> Ovidiu, pl...
10/17/2022
- 02:17 PM Bug #6301: incorrect initialization of date-related fields with today and now literals
- Fixed in 6129b/14302. Tested with this simple test case:...
- 02:01 PM Bug #6301 (Test): incorrect initialization of date-related fields with today and now literals
- Igor reported a regression for a table with two fields of type @datetime@ and @datetime-tz@, respectively, both with ...
- 02:13 PM Feature #6453: temp-table features
- I've noticed the following conversion problem:
The field definition... - 10:33 AM Feature #6457: finish COPY-LOB support
- > What are the values you're trying to use for the codepages/collation tables - for cpstream and cpinternal?
I wan... - 08:42 AM Feature #6457: finish COPY-LOB support
- Stanislav Lomany wrote:
> > @i18n/4gl/cp_collation.xml@ @i18n/4gl/cp_conversion.xml@ @i18n/4gl/chr_conversion.xml@ @...
10/16/2022
- 03:05 PM Feature #6457: finish COPY-LOB support
- > @i18n/4gl/cp_collation.xml@ @i18n/4gl/cp_conversion.xml@ @i18n/4gl/chr_conversion.xml@ @i18n/4gl/is_conversion.xml@...
10/15/2022
- 03:29 AM Feature #6348: implement support for MariaDB
- There is another issue in MariaDB - sequences and tables are in the same namespace. In OE, IIRC they are not in the ...
- 09:33 PM Feature #6348: implement support for MariaDB
- Constantin Asofiei wrote:
> 6129a/14487 contains some fixes related to sequences in MariaDB:
> * fixes related to s...
10/14/2022
- 05:04 PM Bug #6767: Possible name clashes in DMO classes
- Eric: Please review.
- 03:04 PM Bug #6715: BufferManager.validate throws IllegalStateException if a validation fails via a Valida...
- Tijs Wickardt wrote:
> Eric Faulhaber wrote:
> > Tijs, could you please check the files you committed related to th... - 11:19 AM Bug #6715: BufferManager.validate throws IllegalStateException if a validation fails via a Valida...
- Eric Faulhaber wrote:
> Tijs, could you please check the files you committed related to the @TailMap@ implementation... - 11:14 AM Bug #6715: BufferManager.validate throws IllegalStateException if a validation fails via a Valida...
- Constantin Asofiei wrote:
> In some cases, a ValidationException (which is from a bug) is wrapped in a ErrorConditio... - 11:07 AM Bug #6715: BufferManager.validate throws IllegalStateException if a validation fails via a Valida...
- In some cases, a ValidationException (which is from a bug) is wrapped in a ErrorConditionException, like this:...
- 11:02 AM Bug #6715: BufferManager.validate throws IllegalStateException if a validation fails via a Valida...
- Yes, @ErrorConditionException@ should be allowed through; it should not be wrapped in @IllegalStateException@. I thin...
- 12:51 PM Feature #6348: implement support for MariaDB
- Fun fact (nothing more): you can set NTFS to case sensitive in Windows.
That will OE classes in Windows to become ca... - 12:24 PM Feature #6348: implement support for MariaDB
- Constantin Asofiei wrote:
> Regarding case-sensitivity in MariaDB: this is OS-dependent, it will be case-insensitive... - 12:23 PM Feature #6348: implement support for MariaDB
- Regarding case-sensitivity in MariaDB: this is OS-dependent, it will be case-insensitive on Windows.
- 12:23 PM Feature #6348: implement support for MariaDB
- Ovidiu Maxiniuc wrote:
> How are you able to keep then in various casing?
Set @ conversion="minimal"@ in p2j.cfg.xm... - 12:17 PM Feature #6348: implement support for MariaDB
- Constantin Asofiei wrote:
> Ovidiu, the main issue is the case-sensitivity of sequence names (and tables, btw) in Ma... - 11:01 AM Feature #6348: implement support for MariaDB
- Ovidiu, with an app I'm seeing lots of @MISSING: MariaDbDialect.isQueryRangeParameterInlined()@ - is this a TODO rela...
- 06:22 AM Feature #6348: implement support for MariaDB
- 6129a/14487 contains some fixes related to sequences in MariaDB:
* fixes related to sequence management in MariaDB -... - 12:07 PM Feature #6453: temp-table features
- Eric Faulhaber wrote:
> Igor Skornyakov wrote:
>
> > Looking at 3821c I'm not sure that it contains the fix for t... - 11:27 AM Feature #6453: temp-table features
- Igor Skornyakov wrote:
> Looking at 3821c I'm not sure that it contains the fix for the problem.
We have some t... - 08:42 AM Feature #6453: temp-table features
- Fixed a number of issues with @WRITE-XML@ and @READ-XMLSCHEMA@.
Committed to 6129a/14488.
At this moment I see ... - 08:30 AM Feature #6453: temp-table features
- Greg Shah wrote:
> Are you saying that Eric's solution in 3821c revs 14279 and 14280 is not sufficient to resolve th... - 08:16 AM Feature #6453: temp-table features
- Are you saying that Eric's solution in 3821c revs 14279 and 14280 is not sufficient to resolve the issue you have found?
- 08:09 AM Feature #6453: temp-table features
- Greg Shah wrote:
> > In @TableMapper.loadFields@ for if @INITIAL@ is @NOW@ or @TODAY@ for date/datetime field we cal... - 08:05 AM Feature #6453: temp-table features
- > In @TableMapper.loadFields@ for if @INITIAL@ is @NOW@ or @TODAY@ for date/datetime field we calculate the value of ...
- 07:59 AM Feature #6453: temp-table features
- In @TableMapper.loadFields@ for if @INITIAL@ is @NOW@ or @TODAY@ for date/datetime field we calculate the value of co...
- 07:10 AM Bug #6829: H2 forces re-parse of all prepared statements when metadata is changed
- Constantin Asofiei wrote:
> Alex, there's something else I'd like to understand: I've increased the FWD's @psCache@ ...
10/13/2022
- 03:38 PM Bug #6829: H2 forces re-parse of all prepared statements when metadata is changed
- Alex, there's something else I'd like to understand: I've increased the FWD's @psCache@ to 65535 for a large customer...
- 08:53 AM Bug #6829: H2 forces re-parse of all prepared statements when metadata is changed
- Constantin Asofiei wrote:
> Alex, I was under the impression that a test like this, @dyntable.p@:
> [...]
>
> wh... - 07:45 AM Bug #6829: H2 forces re-parse of all prepared statements when metadata is changed
- Alex, I was under the impression that a test like this, @dyntable.p@:...
- 07:06 AM Bug #6829: H2 forces re-parse of all prepared statements when metadata is changed
- > In FWD, the FWD persistence session for the temporary database will get opened and closed depending on the applicat...
- 06:13 AM Bug #6829: H2 forces re-parse of all prepared statements when metadata is changed
- Alexandru Lungu wrote:
> > The FWD-level cache of prepared statements in TempTableDataSourceProvider's psCache will ... - 05:01 AM Bug #6829: H2 forces re-parse of all prepared statements when metadata is changed
- > But, there may be an issue: are dynamic temp-table names unique for the lifetime of a FWD server? Because a Prepare...
- 09:34 AM Feature #6830: find and fix all SQL SELECT statements with inlined literal arguments, and rewrite...
- Here's a report on how modifying went so far:
* Out of 26 possible spots, 16 were modified with no further problems.... - 03:26 AM Feature #6830: find and fix all SQL SELECT statements with inlined literal arguments, and rewrite...
- I have fixed the cases described previously by Constantin, apart from @FastCopyHelper.copyTable@, due to the fact tha...
- 08:46 AM Feature #6457: finish COPY-LOB support
- Greg Shah wrote:
> Please provide the list of codepages/scenarios which need testing (and which you cannot test).
>... - 04:37 AM Support #6714: check if there is an optimization opportunity when copying temp-tables based on mu...
- Danut, you can try using some of the following scenarios to have a comprehensive context of where such optimization m...
- 03:51 AM Feature #6453: temp-table features
- Igor Skornyakov wrote:
> Ovidiu Maxiniuc wrote:
> > The @serialize-hidden@ is a known issue which was fixed in a di... - 03:20 AM Feature #6453: temp-table features
- Greg Shah wrote:
> > For datetime the difference is only in case.
>
> Please analyze if this case difference matt... - 02:40 AM Feature #6453: temp-table features
- Ovidiu Maxiniuc wrote:
> The @serialize-hidden@ is a known issue which was fixed in a different branch. To fix it, o...
10/12/2022
- 06:30 PM Feature #6453: temp-table features
- The @serialize-hidden@ is a known issue which was fixed in a different branch. To fix it, open @DynamicTablesHelper.j...
- 11:53 AM Feature #6453: temp-table features
- Igor Skornyakov wrote:
> It looks that the problem with @WRITE-XMLSCHEMA@ for dynamic TEMP-TABLE in FWD is that for ... - 11:44 AM Feature #6453: temp-table features
- > For datetime the difference is only in case.
Please analyze if this case difference matters in our runtime. If ... - 10:55 AM Feature #6453: temp-table features
- Greg Shah wrote:
> > Should I fix defaultFormatString() methods to match defFormats?
>
> Probably not. I think th... - 10:31 AM Feature #6453: temp-table features
- > Should I fix defaultFormatString() methods to match defFormats?
Probably not. I think that may cause regressions... - 05:13 AM Feature #6453: temp-table features
- Marian Edu wrote:
> Greg Shah wrote:
> > Constantin/Marian: Can you please advise Igor on how he can test the behav... - 04:55 AM Feature #6453: temp-table features
- Greg Shah wrote:
> Constantin/Marian: Can you please advise Igor on how he can test the behavior of @SCHEMA-MARSHAL@... - 04:36 AM Feature #6453: temp-table features
- Marian Edu wrote:
> Igor Skornyakov wrote:
> > It looks that the problem with @WRITE-XMLSCHEMA@ for dynamic TEMP-TA... - 04:34 AM Feature #6453: temp-table features
- Igor Skornyakov wrote:
> It looks that the problem with @WRITE-XMLSCHEMA@ for dynamic TEMP-TABLE in FWD is that for ... - 04:25 AM Feature #6453: temp-table features
- It looks that the problem with @WRITE-XMLSCHEMA@ for dynamic TEMP-TABLE in FWD is that for all fields of such table @...
- 03:23 AM Feature #6453: temp-table features
- Igor Skornyakov wrote:
> Igor Skornyakov wrote:
> > I've noticed a strange thing.
> > For some field data types (e... - 04:24 PM Bug #6837: prevent unnecessary upper/rtrim injection in queries if the data type doesn't require it
- Eric Faulhaber wrote:
> The insertion of @upper@ occurs at least during conversion, possibly at runtime. The inserti... - 04:02 PM Bug #6837: prevent unnecessary upper/rtrim injection in queries if the data type doesn't require it
- In some cases, we are using @upper@ and/or @rtrim@ in WHERE and ORDER BY clauses to adjust textual columns that don't...
- 03:52 PM Bug #6837 (WIP): prevent unnecessary upper/rtrim injection in queries if the data type doesn't re...
- 10:12 AM Feature #6457: finish COPY-LOB support
- Please provide the list of codepages/scenarios which need testing (and which you cannot test).
Marian: I think we ... - 09:58 AM Feature #6457: finish COPY-LOB support
- > Is the testing issue caused by the virtual machine not having the needed codepages installed?
Some cases claim t... - 09:29 AM Feature #6457: finish COPY-LOB support
- > I cannot change -cpstream/-cpinternal parameters on a customer's VM either, so I cannot experiment with it.
Is ... - 09:16 AM Feature #6457: finish COPY-LOB support
- I cannot change @-cpstream@/@-cpinternal@ parameters on a customer's VM either, so I cannot experiment with it.
Mor...
10/11/2022
- 05:00 PM Feature #6371: implement SAVE CACHE statement
- Pushed revision 14113. Now it's going past @generateSchemaAst()@ call. I can't test further because of some misconfig...
- 03:45 PM Feature #6453: temp-table features
- Ovidiu Maxiniuc wrote:
> Igor Skornyakov wrote:
> > It looks that the value of the @SCHEMA-MARSHAL@ attribute has n... - 03:01 PM Feature #6453: temp-table features
- Igor Skornyakov wrote:
> I've noticed a strange thing.
> For some field data types (e.g. @datetime@, @recid@, @hand... - 11:18 AM Feature #6453: temp-table features
- Added COLUMN-CODEPAGE field attribute support (conversion and @WRITE-XMLSCHEMA@)
Committed to 6129a/14482. - 12:29 PM Bug #6829: H2 forces re-parse of all prepared statements when metadata is changed
- As a query can target multiple metadata (like tables, indexes, sequences), the cache needs to be notified to evict a...
- 08:51 AM Bug #6835: deferred work for #6257
- This task is meant to properly handle the root cause of #6257.
Eric/Ovidiu: Please document the issue and solution... - 08:50 AM Bug #6835 (New): deferred work for #6257
- 08:50 AM Bug #6834: RAQ navigation on records having NULL values on same index components
- This task is meant to properly handle the root cause of #6755.
Eric/Ovidiu: Please document the issue and solution... - 08:48 AM Bug #6834 (Closed): RAQ navigation on records having NULL values on same index components
- 08:28 AM Bug #6767: Possible name clashes in DMO classes
- Greg Shah wrote:
> Please post the final proposed patch.
Done @6767-full.diff@. - 08:16 AM Bug #6767: Possible name clashes in DMO classes
- Please post the final proposed patch.
- 08:07 AM Bug #6767 (Review): Possible name clashes in DMO classes
- Vladimir Tsichevski wrote:
> UPD: this patch is probably causes some regressions like @org.postgresql.util.PSQLExcep... - 08:05 AM Bug #6767: Possible name clashes in DMO classes
- Some more changes needed, since some TRPL properties do not exist anymore, and the method call must be used now inste...
10/10/2022
- 06:32 PM Bug #6767 (WIP): Possible name clashes in DMO classes
- UPD: this patch is probably causes some regressions like @org.postgresql.util.PSQLException: ERROR: column wfnregio__...
- 06:23 PM Bug #6767 (Review): Possible name clashes in DMO classes
- 06:23 PM Bug #6767 (WIP): Possible name clashes in DMO classes
- Attached is the patch for this issue (@6767.diff@).
After this patch is applied, you will need to re-convert all c... - 09:15 AM Bug #6767: Possible name clashes in DMO classes
- Eric Faulhaber wrote:
> DMO getters/setters can be of the form:
>
> [...]
So, the following methods from the... - 01:04 PM Feature #6453: temp-table features
- Ovidiu Maxiniuc wrote:
> I think @rules/schema/fixups.xml@. See the other attributes are processed around lines 690.... - 12:49 PM Feature #6453: temp-table features
- I think @rules/schema/fixups.xml@. See the other attributes are processed around lines 690.
- 10:47 AM Feature #6453: temp-table features
- I see that @KW_COL_CP@ AST (@COLUMN-CODEPAGE@) exists in .schema file but is missed in .p2o one.
What is the right p... - 12:34 PM Bug #6829: H2 forces re-parse of all prepared statements when metadata is changed
- The FWD-level cache of prepared statements in @TempTableDataSourceProvider@'s psCache will also keep statements relat...
- 09:01 AM Feature #6582: implement multi-table AdaptiveQuery
- I replaced H2 (fwd-h2/rev.6) with H2 PAGESTORE (fwd-h2/rev. 6) and H2 MVSTORE (2.1.214) in #6582-40. The previous res...
- 07:41 AM Feature #6695: Multi-table preselect query may underperform due to repetitive fetching
- I committed on 6582a, rev.14168. This change targets the improvement in performance regarding fetching for @Preselect...
- 05:44 AM Bug #6809 (Test): find current ... exclusive-lock no-wait. not working
- Eric Faulhaber wrote:
> Fixed in 6129a/14477. Constantin, please review and test with the original application, if y... - 02:24 AM Bug #6809 (Review): find current ... exclusive-lock no-wait. not working
- Fixed in 6129a/14477. Constantin, please review and test with the original application, if you have a recreate beyond...
- 05:30 AM Feature #6813: analyze and improve performance of dynamic conversion of temp-tables and queries
- Other changes are in 3821c/14281:
* Avoid reflection when creating a new instance, in AnnotatedAst - added 'newInsta... - 03:33 AM Feature #6830: find and fix all SQL SELECT statements with inlined literal arguments, and rewrite...
- The task title mentions SELECT, but all kind of queries need to be checked/fixed: INSERT, UPDATE, DELETE.
- 03:22 AM Feature #6830 (WIP): find and fix all SQL SELECT statements with inlined literal arguments, and r...
- 03:16 AM Bug #6301: incorrect initialization of date-related fields with today and now literals
- Eric Faulhaber wrote:
> Alexandru, please take a look at @FastCopyHelper.getInitialValue@. This method is affected b...
10/09/2022
- 04:26 PM Bug #6301: incorrect initialization of date-related fields with today and now literals
- Constantin Asofiei wrote:
> Eric, 3821c/14279 regresses some automated tests with this:
> [...]
Thanks for findi... - 08:16 AM Bug #6301: incorrect initialization of date-related fields with today and now literals
- Eric, 3821c/14279 regresses some automated tests with this:...
10/08/2022
- 06:29 PM Bug #6809 (WIP): find current ... exclusive-lock no-wait. not working
- 06:26 PM Bug #6812: fix FastFindCache to use a shared instance per persistent database
- Ovidiu Maxiniuc wrote:
> The factory makes sure the permanent databases use a commonly shared instance of @FastFindC... - 06:06 PM Bug #6301 (Review): incorrect initialization of date-related fields with today and now literals
- A fix is committed to 3821c/14279. I have tested with the above test case.
Ovidiu, please review.
Alexandru, pl...
10/07/2022
- 09:11 AM Support #6713: check if it is faster to use separate temp-table instances instead of multiplex id
- I made tests for bulk delete and copy temp-table.
* *copy-temp-table-multiplex-{n}*, *copy-temp-table-no-multiplex-{... - 07:13 AM Feature #6453: temp-table features
- Constantin Asofiei wrote:
> > Fixed in 6129a/14474.
> Igor, you still have @lfi.getSerializeOptions(null).getXmlDat... - 06:58 AM Feature #6453: temp-table features
- Igor Skornyakov wrote:
> Ovidiu Maxiniuc wrote:
> > * @TableMapper@: I have not studied the new signatures (which u... - 05:08 AM Feature #6453: temp-table features
- Ovidiu Maxiniuc wrote:
> * @TableMapper@: I have not studied the new signatures (which use the new @TempTable@ param... - 02:31 AM Feature #6453: temp-table features
- Ovidiu Maxiniuc wrote:
> Review of 6129a/14473.
> * @AbstractTempTable@: shouldn't the last parameter of the 3131 e... - 06:57 AM Feature #4011: database/persistence layer performance improvements
- Constantin Asofiei wrote:
> I'm editing #4011-5 again, I'll comment when I'm done.
I've finished editing.
- 04:26 AM Feature #4011: database/persistence layer performance improvements
- I'm editing #4011-5 again, I'll comment when I'm done.
- 04:34 AM Bug #6829: H2 forces re-parse of all prepared statements when metadata is changed
- As a side note: when executing some 60k H2 prepared statements, ~70% of the time is being spent in re-compiling the q...
- 04:22 AM Bug #6829: H2 forces re-parse of all prepared statements when metadata is changed
- In H2, there is this code in @org.h2.command.Prepared@:...
- 04:18 AM Bug #6829 (Closed): H2 forces re-parse of all prepared statements when metadata is changed
- 04:30 AM Feature #6830: find and fix all SQL SELECT statements with inlined literal arguments, and rewrite...
- This is mostly I think about multiplex ID being inlined instead of using an argument. The cases I found are:...
- 04:28 AM Feature #6830 (Closed): find and fix all SQL SELECT statements with inlined literal arguments, an...
- 03:25 AM Feature #6457: finish COPY-LOB support
- > Try setting the same value for all these cp parameters
Errors are the same for this case too.
10/06/2022
- 06:09 PM Feature #6453: temp-table features
- Review of 6129a/14473.
* @AbstractTempTable@: shouldn't the last parameter of the 3131 error message be @LegacyResou... - 02:48 PM Feature #6453: temp-table features
- * Fixed issues with @WRITE-XMLSCHEMA@/@READ-XMLSCHEMA@ described in #6453-11 except the issue with @WRITE-XMLSCHEMA@ ...
- 07:22 AM Feature #6453: temp-table features
- Constantin Asofiei wrote:
> Igor, regarding the change in 6129a/14418 - are you sure PRIMARY defaults to the first d... - 02:00 AM Feature #6453: temp-table features
- Ovidiu Maxiniuc wrote:
> Igor Skornyakov wrote:
> > I see. Sorry. Will change back.
> > Please note however, that ... - 04:49 PM Feature #6457: finish COPY-LOB support
- I know, I had the same problems :(.
Try setting the same value for all these cp parameters, unless having them diffe... - 03:51 PM Feature #6457: finish COPY-LOB support
- Guys, I've been trying to experiment with @-cpstream@ and @-cpinternal@ parameters and found that when it comes to se...
- 10:14 AM Support #6679: H2 general performance tuning
- Committed hotel_gui/rev.252. I added the H2 performance tests to the Hotel GUI application.
Added a window with a ... - 06:08 AM Feature #4011: database/persistence layer performance improvements
- Constantin Asofiei wrote:
> I'm editing note #4011-5 to add other tasks. I'll comment when I'm done.
I've finished ... - 02:12 AM Feature #4011: database/persistence layer performance improvements
- I'm editing note #4011-5 to add other tasks. I'll comment when I'm done.
- 05:23 AM Feature #6695: Multi-table preselect query may underperform due to repetitive fetching
- There was a mistake in explanation on my part in the last post. In order to make this more clear, I will describe thi...
- 04:27 AM Feature #6825: improve table meta runtime (TableMapper and other)
- Some changes are in 3821c/14272. Ovidiu, please review.
- 03:37 AM Feature #6825: improve table meta runtime (TableMapper and other)
- In TableMapper, because of some mutable state, a new LegacyTableInfo was being created for each buffer definition. T...
- 03:35 AM Feature #6825 (WIP): improve table meta runtime (TableMapper and other)
- 04:26 AM Feature #6813: analyze and improve performance of dynamic conversion of temp-tables and queries
- Some changes are in 3821c/14272. Greg, please review.
- 02:12 AM Feature #6813: analyze and improve performance of dynamic conversion of temp-tables and queries
- Parsing and TRPL rules are being executed for each dynamic query (at least the parsing/conversion of the query predic...
- 02:10 AM Feature #6813 (WIP): analyze and improve performance of dynamic conversion of temp-tables and que...
- 03:25 AM Feature #6823: improve TemporaryBuffer/RecordBuffer define and buffer delete
- For complex applications, with 1000s (or maybe 10k's) of buffer definitions in 100s of programs or legacy classes, th...
- 03:23 AM Feature #6823 (New): improve TemporaryBuffer/RecordBuffer define and buffer delete
- 02:36 AM Feature #6816: improve PreselectQuery.assembleHQL
- The code in PreselectQuery.assembleHQL appears in the profiler when testing very complex application APIs, in 6129a. ...
- 02:26 AM Feature #6816 (Internal Test): improve PreselectQuery.assembleHQL
- 02:25 AM Feature #6815: configure all cache sizes in the directory, and create documentation for them
- In 6129a, the prepared statement cache in TempTableDataSourceProvider is still configured to 100 - this was not enoug...
- 02:24 AM Feature #6815 (Review): configure all cache sizes in the directory, and create documentation for ...
- 02:13 AM Support #6714 (WIP): check if there is an optimization opportunity when copying temp-tables based...
- 01:32 AM Bug #6812: fix FastFindCache to use a shared instance per persistent database
- FastFindCache is now created for both temp-table and permanent databases. The problem is that for permanent (or meta,...
10/05/2022
- 07:22 PM Bug #6812: fix FastFindCache to use a shared instance per persistent database
- The factory makes sure the permanent databases use a commonly shared instance of @FastFindCache@ while for the temp-t...
- 06:36 PM Bug #6812: fix FastFindCache to use a shared instance per persistent database
- > FastFindCache looks like is only for temp-tables
It isn't used for permanent databases? - 04:11 PM Bug #6812: fix FastFindCache to use a shared instance per persistent database
- Constantin Asofiei wrote:
> Eric, the FastFindCache looks like is only for temp-tables, and not other databases (lik... - 04:09 PM Bug #6812: fix FastFindCache to use a shared instance per persistent database
- Eric, the FastFindCache looks like is only for temp-tables, and not other databases (like meta). So my assumption is ...
- 03:56 PM Bug #6812: fix FastFindCache to use a shared instance per persistent database
- Eric Faulhaber wrote:
> ... or to have a separate cache for each database?
Good point. It needs to be per database... - 03:07 PM Bug #6812: fix FastFindCache to use a shared instance per persistent database
- Does it make more sense to qualify the table name with database name, or to have a separate cache for each database?
- 02:59 PM Bug #6812: fix FastFindCache to use a shared instance per persistent database
- We use @RecordIdentifier@ in @FastFindCache@ having the table identifier a simple string with the record's implementa...
- 02:56 PM Bug #6812 (Internal Test): fix FastFindCache to use a shared instance per persistent database
- 07:16 PM Feature #6453: temp-table features
- Igor Skornyakov wrote:
> I see. Sorry. Will change back.
> Please note however, that in my test the previous versio... - 04:50 PM Feature #6453: temp-table features
- Ovidiu Maxiniuc wrote:
> Just noticed an issue in @ErrorManager@ 6129a/14418.
> You fixed error message for error 3... - 04:27 PM Feature #6453: temp-table features
- Just noticed an issue in @ErrorManager@ 6129a/14418.
You fixed error message for error 3131 wrongly. There are tens ... - 02:36 PM Feature #6453: temp-table features
- The @codePage@ attribute of the @Property@ annotation is not populated in the generated DMO interface for the static ...
- 12:52 PM Feature #6453: temp-table features
- Ovidiu Maxiniuc wrote:
> Igor,
> Please do the test in all cases: the table was prepared or not, the index was set ... - 12:49 PM Feature #6453: temp-table features
- I've noticed a strange thing.
For some field data types (e.g. @datetime@, @recid@, @handle@ and @com-hangle@) in the... - 12:45 PM Feature #6453: temp-table features
- Igor,
Please do the test in all cases: the table was prepared or not, the index was set as primary or not. I do not ... - 12:06 PM Feature #6453: temp-table features
- Constantin Asofiei wrote:
> Igor, regarding the change in 6129a/14418 - are you sure PRIMARY defaults to the first d... - 11:08 AM Feature #6453: temp-table features
- Igor, regarding the change in 6129a/14418 - are you sure PRIMARY defaults to the first defined index, and not the fir...
- 10:06 AM Feature #6453: temp-table features
- I see multiple incompatibilities between FWD and 4GL in the @WRITE-XMLSCHEMA@ output.
In particular some @element@ a... - 03:21 AM Feature #6453: temp-table features
- Constantin Asofiei wrote:
> Igor/Eric/Ovidiu: we use the WRITE-XML and READ-XML behavior to serialize the payload bo... - 02:45 AM Feature #6453: temp-table features
- Igor/Eric/Ovidiu: we use the WRITE-XML and READ-XML behavior to serialize the payload both for read and write, for XM...
- 02:21 PM Bug #6703: loading schema table DMO interface with no defined fields
- My point was that the records exited in the original table and we need to have a table in FWD/SQL with same (well, eq...
- 02:17 PM Bug #6703: loading schema table DMO interface with no defined fields
- Ovidiu, I tested loading a .d for a table with no fields in the Data Administration, in OpenEdge:
* created a no-fie... - 02:03 PM Bug #6703: loading schema table DMO interface with no defined fields
- Eric Faulhaber wrote:
> Ovidiu Maxiniuc wrote:
> > * @Persister.java@: to avoid @ArrayIndexOutOfBoundsException@ wh... - 11:08 AM Bug #6810 (Review): NPE in PreselectQuery.assembleFromClause
- This test:...
- 10:54 AM Bug #6810 (Review): NPE in PreselectQuery.assembleFromClause
- 09:48 AM Bug #6809: find current ... exclusive-lock no-wait. not working
- This needs to be fixed in 6129a
- 09:32 AM Bug #6809: find current ... exclusive-lock no-wait. not working
- The recreate is this, using to FWD clients:
* run first program @b1.p@ - do not press any key:... - 09:29 AM Bug #6809 (Test): find current ... exclusive-lock no-wait. not working
- 07:43 AM Feature #6582: implement multi-table AdaptiveQuery
- In my effort to seek optimizing methods for our in-memory H2, I took some time to analyze some in-memory (eventually ...
10/04/2022
- 04:29 PM Feature #6453: temp-table features
- Ovidiu Maxiniuc wrote:
> As a first observation, I agree with Eric's note #6453-24: FWD is quite a large project, it... - 04:25 PM Feature #6453: temp-table features
- As a first observation, I agree with Eric's note #6453-24: FWD is quite a large project, it has 200+ dependencies (ja...
- 04:00 PM Feature #6453: temp-table features
- Greg Shah wrote:
> Also note that sometimes it is harder to meet specific 4GL compatibility requirements using 3rd p... - 03:48 PM Feature #6453: temp-table features
- Also note that sometimes it is harder to meet specific 4GL compatibility requirements using 3rd party libraries that ...
- 02:21 PM Feature #6453: temp-table features
- Eric Faulhaber wrote:
> I agree with most of your points, except the performance assumption in your first point (and... - 02:13 PM Feature #6453: temp-table features
- Igor Skornyakov wrote:
> I undestand this. My points is
> * for this particular piece of functionality performan... - 01:52 PM Feature #6453: temp-table features
- Eric Faulhaber wrote:
> We are very careful about introducing new dependencies into the project and in fact we are s... - 01:36 PM Feature #6453: temp-table features
- We are very careful about introducing new dependencies into the project and in fact we are striving to simplify by re...
- 01:14 PM Feature #6453: temp-table features
- Igor Skornyakov wrote:
> Don't you think that instead of manual implementtation it makes sense to use some open-sour... - 12:05 PM Feature #6453: temp-table features
- It is easy to fix FWD to add index data to the @WRITE-XMLSCHEMA@ output. All we need is no comment @!this.isSchemaOnl...
- 02:38 PM Bug #6767: Possible name clashes in DMO classes
- Vladimir Tsichevski wrote:
> Eric Faulhaber wrote:
> > To clarify the task, we need to work through all superinterf... - 11:31 AM Feature #6347: change the name conversion to provide a configurable option to not emit "snake case"
- Eric Faulhaber wrote:
> Constantin Asofiei wrote:
> > Eric, I'm placing this back to WIP as this prevents 6129a to ... - 11:07 AM Feature #6347: change the name conversion to provide a configurable option to not emit "snake case"
- Constantin Asofiei wrote:
> Eric, I'm placing this back to WIP as this prevents 6129a to be tested with other projec... - 10:55 AM Feature #6695: Multi-table preselect query may underperform due to repetitive fetching
- Radu, please help me understand this better (perhaps it will make more sense to me when I review the update).
My c... - 05:26 AM Feature #6695: Multi-table preselect query may underperform due to repetitive fetching
- After some analysis, I have identified a spot in @PreselectQuery@ where things could be optimized. The problem was as...
10/03/2022
- 01:48 PM Feature #6453: temp-table features
- Ovidiu Maxiniuc wrote:
> I implemented this using the reference manual and tested on real customer application. The ... - 01:36 PM Feature #6453: temp-table features
- Igor Skornyakov wrote:
> It looks that the value of the @SCHEMA-MARSHAL@ attribute has no effect on the @WRITE-XMLSC... - 01:03 PM Feature #6453: temp-table features
- Igor Skornyakov wrote:
> Actually there are minor incompatibilities:
> # The initial value of th @PRIMARY@ attribut... - 11:53 AM Feature #6453: temp-table features
- Igor Skornyakov wrote:
> Ovidiu Maxiniuc wrote:
>
> > OTOH, the PRIMARY attribute lacks both both conversion and ... - 11:32 AM Feature #6453: temp-table features
- Ovidiu Maxiniuc wrote:
> OTOH, the PRIMARY attribute lacks both both conversion and runtime support. The good news... - 11:10 AM Feature #6453: temp-table features
- Igor Skornyakov wrote:
> It looks that the value of the @SCHEMA-MARSHAL@ attribute has no effect on the @WRITE-XMLSC... - 05:53 AM Feature #6453: temp-table features
- It looks that the value of the @SCHEMA-MARSHAL@ attribute has no effect on the @WRITE-XMLSCHEMA@ output (both for 4GL...
- 03:48 AM Feature #6453: temp-table features
- Eric Faulhaber wrote:
> Agreed, but adding missing functionality is highest priority; if fixing any of these items l... - 03:30 AM Feature #6453: temp-table features
- Agreed, but adding missing functionality is highest priority; if fixing any of these items looks to be particularly t...
- 03:33 AM Feature #6371: implement SAVE CACHE statement
- I have committed revision 14112, which fixes the NPE and refactors the code for this feature out of @DatabaseManager@...
10/02/2022
- 04:36 PM Feature #6453: temp-table features
- > As I've mentioned in #6453-10 the issues mentioned above formally do not related to the scope of this task. Should ...
- 12:21 PM Feature #6453: temp-table features
- I've re-worked the test program to use all possible data types and all possible TEMP-TABLE Field options, and noticed...
09/30/2022
- 04:23 PM Feature #6371: implement SAVE CACHE statement
- Eric Faulhaber wrote:
> One question: is @attribute@ always synonymous with a column?
I introduced constants to... - 10:57 AM Feature #6371: implement SAVE CACHE statement
- Thanks for the fixes in 14110. The last known state for my very simple database looks like this persisted:...
- 06:45 AM Feature #6371: implement SAVE CACHE statement
- I reverted all Class Loader modifications. We'll have to get back to that later.
Also, I reimplemented and tested ... - 02:16 AM Feature #6371: implement SAVE CACHE statement
- Boris Schegolev wrote:
> I pushed several fixes for the comments above:
>
> * SchemaComparator file access synchr... - 01:40 PM Feature #6453: temp-table features
- I've noticed a number of discrepancies between 4GL and FWD for @READ-XMLSCHEMA@/@WRITE-XMLSCHEMA@/@READ-XML@/@WRITE-X...
- 07:51 AM Support #6679: H2 general performance tuning
- I am currently working on integrating a 4GL code test into Hotel GUI project. The test consists of simple operations ...
- 04:42 AM Feature #6582: implement multi-table AdaptiveQuery
- Greg Shah wrote:
> Are all of the tests written for this in 4GL code? Can the testing be easily replicated by other...
09/29/2022
- 04:27 PM Feature #6371: implement SAVE CACHE statement
- I pushed several fixes for the comments above:
* SchemaComparator file access synchronization
* ClassLoader del... - 10:51 AM Feature #6371: implement SAVE CACHE statement
- Boris Schegolev wrote:
> BTW, what database are you connected to? MySQL, Postgres, ...?
So far, I've only tested ... - 06:37 AM Feature #6371: implement SAVE CACHE statement
- I pushed a fix for the NPE as revision 14108.
As for the flow, the intended use goes like this:
# @saveInitialS... - 04:28 AM Feature #6371: implement SAVE CACHE statement
- BTW, what database are you connected to? MySQL, Postgres, ...?
- 04:24 AM Feature #6371: implement SAVE CACHE statement
- Eric Faulhaber wrote:
> The problem is that we are trying to get all index info for all tables, but that API doesn... - 02:28 AM Feature #6371: implement SAVE CACHE statement
- I've made changes to @SchemaComparator@, mostly formatting to match our coding standards, and some functional to get ...
- 03:52 PM Feature #6720: lazy hydration
- > If we are to lazily hydrate records, any column data which was not loaded in the initial hydration pass will have t...
- 08:24 AM Feature #6582: implement multi-table AdaptiveQuery
- > either the conversion should generate multi-table AdaptiveQuery only for persistent tables
I think we should be... - 08:20 AM Feature #6582: implement multi-table AdaptiveQuery
- Are all of the tests written for this in 4GL code? Can the testing be easily replicated by others in the future? I'...
- 06:07 AM Feature #6582: implement multi-table AdaptiveQuery
- I've done some tests with H2 2.1.214 an there is no improvement with the query plan (especially for cross joins).
...
09/28/2022
- 05:53 PM Feature #6371: implement SAVE CACHE statement
- FYI, I am making major changes to @SchemaComparator@. Please do not modify this class until I check it in.
- 02:06 AM Feature #6371: implement SAVE CACHE statement
- I reverted rev 14106 locally because it breaks the singleton contract of @AsmClassLoader@ and thus breaks server star...
- 07:11 AM Feature #6582: implement multi-table AdaptiveQuery
|_\13. Iterate all records with NEXT |
|_\2. Test |_\2. 4GL temporary ...
09/27/2022
- 12:35 PM Feature #6628: port PostgreSQL native user defined functions to MariaDB
- Eric Faulhaber wrote:
> Igor, how did you ultimately deal with the error handler (@initError@, @checkError@, etc.)? ... - 11:17 AM Feature #6628: port PostgreSQL native user defined functions to MariaDB
- Igor, how did you ultimately deal with the error handler (@initError@, @checkError@, etc.)? Do any test cases in your...
- 09:45 AM Feature #6582: implement multi-table AdaptiveQuery
- I updated the table from #6582-33 with 8 new multi-table queries which are often used in large applications:
* *rang...
09/26/2022
- 03:03 PM Feature #6628: port PostgreSQL native user defined functions to MariaDB
- Testing MariaDB UDFs with UNKNOWN arguments/values, finished.
Committed to 6129a/14414 (except @where_clause_pre_p...
Also available in: Atom