Project

General

Profile

Activity

From 10/03/2022 to 11/01/2022

11/01/2022

04:10 PM Feature #6453: temp-table features
I'm working now on table parameter issues described in #6453-133 and #6453-134.
After that I plan to return to work ...
Igor Skornyakov
08:02 AM Feature #6453: temp-table features
One more problem with table parameter in remote call.
If the parameter is declared like this:...
Igor Skornyakov
06:52 AM Feature #6453: temp-table features
Added 4GL test for the @NONE@ value of the @SCHEMA-MARSHAL@.
FWD results are different from the 4GL ones
Igor Skornyakov
04:26 AM Feature #6453: temp-table features
Marian Edu wrote:
> [[https://docs.progress.com/bundle/openedge-develop-abl-applications-122/page/Using-a-temp-table...
Igor Skornyakov
03:57 AM Feature #6453: temp-table features
Igor Skornyakov wrote:
> Sorry for my ignorance. How the declaration of such parameter should look like?
[[https:...
Marian Edu
03:47 AM Feature #6453: temp-table features
Marian Edu wrote:
> Igor Skornyakov wrote:
>
> > Thank you Marian. But my question was about the situations when ...
Igor Skornyakov
03:42 AM Feature #6453: temp-table features
Igor Skornyakov wrote:
> Thank you Marian. But my question was about the situations when @NONE@ value of the @SCHE...
Marian Edu
03:34 AM Feature #6453: temp-table features
Constantin Asofiei wrote:
> Igor Skornyakov wrote:
> > At this moment we keep index data in the @TableParameter@ as...
Igor Skornyakov
03:26 AM Feature #6453: temp-table features
Igor Skornyakov wrote:
> At this moment we keep index data in the @TableParameter@ as a string created by @TableMapp...
Constantin Asofiei
11:11 AM Feature #6418: represent extent fields as arrays
Radu Apetrii wrote:
> Greg Shah wrote:
> > The above is my opinion. Eric makes the final decision here.
> Any dec...
Eric Faulhaber
09:29 AM Bug #6837: prevent unnecessary upper/rtrim injection in queries if the data type doesn't require it
Please ensure that the solution is built such that all dialects (not just MariaDB) can leverage this same approach. ... Greg Shah
09:33 PM Bug #6837: prevent unnecessary upper/rtrim injection in queries if the data type doesn't require it
I committed an intermediary solution. The occurrences of properties are no longer wrapped in @upper()@ and/or @rtrim(... Ovidiu Maxiniuc
08:33 AM Feature #6898: PostgreSQL schema improvements
We have multiple requests for changes to the default approach to some PostgreSQL schema. We have a small window righ... Greg Shah
08:05 AM Feature #6898 (New): PostgreSQL schema improvements
Greg Shah
08:32 AM Support #4058: consider denormalizing tables as the default approach
We've discussed offline this many times recently. I want to record some thoughts from those discussions:
* The cu...
Greg Shah

10/31/2022

06:14 PM Feature #6695: Multi-table preselect query may underperform due to repetitive fetching
Radu, in my last post I started right into the code review comments, but I want to note that I appreciate your recogn... Eric Faulhaber
05:38 PM Feature #6695: Multi-table preselect query may underperform due to repetitive fetching
Code review @6695.patch@:
Interesting solution. Why is it only applicable for NO-UNDO temp-tables?
The patch do...
Eric Faulhaber
07:16 AM Feature #6695: Multi-table preselect query may underperform due to repetitive fetching
I have attached a patch that includes the changes regarding preselect queries on temporary no-undo tables. They were ... Radu Apetrii
04:03 PM Feature #6453: temp-table features
Greg Shah wrote:
> > Sorry, I do not understand. I see both @commons-lang@ and @commons-lang3@.
> > Can I use them ...
Igor Skornyakov
04:02 PM Feature #6453: temp-table features
Igor Skornyakov wrote:
> Greg Shah wrote:
> > [[p2j::Dependency_Management#List-of-Supported-3rd-Party-Libraries|Li...
Greg Shah
03:21 PM Feature #6453: temp-table features
Greg Shah wrote:
> [[p2j::Dependency_Management#List-of-Supported-3rd-Party-Libraries|List of Supported 3rd Party Li...
Igor Skornyakov
02:46 PM Feature #6453: temp-table features
[[p2j::Dependency_Management#List-of-Supported-3rd-Party-Libraries|List of Supported 3rd Party Libraries]] Greg Shah
01:17 PM Feature #6453: temp-table features
Constantin Asofiei wrote:
> Igor, review for the #6453-117 patch:
> * @DynamicTablesHelper@ - please do not use @St...
Igor Skornyakov
12:49 PM Feature #6453: temp-table features
Igor, review for the #6453-117 patch:
* @DynamicTablesHelper@ - please do not use @StringUtils.isEmpty@ in apache co...
Constantin Asofiei
10:21 AM Feature #6453: temp-table features
At this moment we keep index data in the @TableParameter@ as a string created by @TableMapper.getLegacyIndexInfo@.
...
Igor Skornyakov
02:55 AM Feature #6453: temp-table features
Marian Edu wrote:
> Igor, sorry for being late on this one... it just slipped my mind I guess. The use for that erro...
Igor Skornyakov
02:49 AM Feature #6453: temp-table features
Igor Skornyakov wrote:
> The support for @SCHEMA-MARSHAL@ @NONE@ value is still missing (see #6453-116). In partic...
Marian Edu

10/29/2022

12:49 PM Feature #6453: temp-table features
Fixed (un)marshalling of fields and @NAMESPACE-URI@/@NAMESPACE-PREFIX@ for table parameter.
However, indexes are sti...
Igor Skornyakov

10/28/2022

06:06 PM Feature #6371: implement SAVE CACHE statement
Boris Schegolev wrote:
> I pushed support for indexes (revision 6371a/14117). There's an issue with detecting if the...
Eric Faulhaber
05:15 PM Feature #6371: implement SAVE CACHE statement
I pushed support for indexes (revision 6371a/14117). There's an issue with detecting if the index is primary - this i... Boris Schegolev
03:42 PM Bug #6812: fix FastFindCache to use a shared instance per persistent database
Changed the issue description to match the point made in #6812-3 and #6812-4. Eric Faulhaber
04:36 AM Feature #6895: improve performance of BufferReference methods buffer() and definition()
@RecordBuffer.buffer()@ and @RecordBuffer.define()@ (declared by the @BufferReference@ interface, and implemented by ... Eric Faulhaber
04:35 AM Feature #6895 (New): improve performance of BufferReference methods buffer() and definition()
Eric Faulhaber
03:21 AM Feature #6453: temp-table features
Marian Edu wrote:
> I wouldn't bother too much with MIN/FULL differences... the real use case here was the 'NONE' va...
Igor Skornyakov

10/27/2022

11:49 AM Feature #4056: instrument FWD and supporting libraries to measure database performance
I've fixed the issue with the wrong times - the thread-local must be static, for it to work as 'thread-local'. See 6... Constantin Asofiei
10:26 AM Feature #4056: instrument FWD and supporting libraries to measure database performance
Extended the method tracing with a new file: @summary_trace.csv@ including
* Summary table of scenarios: root, cou...
Alexandru Lungu
04:06 AM Feature #4056: instrument FWD and supporting libraries to measure database performance
The aggregate times per bucket are not displayed yet; working on it.
I will check how the sums are computed (and th...
Alexandru Lungu
02:55 AM Feature #4056: instrument FWD and supporting libraries to measure database performance
There are also some cases where a method's aggregate and own times are reported as >100% of the bucket total:
!405...
Eric Faulhaber
01:03 AM Feature #4056: instrument FWD and supporting libraries to measure database performance
Alexandru, I like the HTML UI, nice work! Is the Grand Totals by package breakdown somewhere in there?
For a large...
Eric Faulhaber
08:03 AM Support #6714: check if there is an optimization opportunity when copying temp-tables based on mu...
Ovidiu: Please review. Greg Shah
06:09 AM Support #6714: check if there is an optimization opportunity when copying temp-tables based on mu...
Apart from the tests mentioned in #6714-4, I have also made tests in which the called external procedure passes the t... Dănuț Filimon
06:48 AM Feature #6453: temp-table features
Greg Shah wrote:
> Now is the time to get all details exactly correct. I'm glad it is less likely to be an issue, b...
Igor Skornyakov
06:27 AM Feature #6453: temp-table features
Now is the time to get all details exactly correct. I'm glad it is less likely to be an issue, but please do impleme... Greg Shah
03:41 AM Feature #6453: temp-table features
Marian Edu wrote:
> I wouldn't bother too much with MIN/FULL differences... the real use case here was the 'NONE' va...
Igor Skornyakov
03:39 AM Feature #6453: temp-table features
It looks that when @SCHEMA-MARSHAL@ is @FULL@, 4GL serializes all field attributes of the table parameter of the remo... Igor Skornyakov
01:59 AM Feature #6453: temp-table features
Igor Skornyakov wrote:
> Ovidiu Maxiniuc wrote:
> > My surprise was to see the last htt-MIN.xsd and htt-FULL.xsd ar...
Marian Edu

10/26/2022

03:22 PM Feature #6348: implement support for MariaDB
I have an update which passes my (rather simple) testcase (unlike the current implementation from 6129 branches). I r... Ovidiu Maxiniuc
06:48 AM Feature #6348: implement support for MariaDB
It seems like sequences are not implemented in MariaDB for general usage. There must be some kind of use case that a... Greg Shah
09:27 PM Feature #6348: implement support for MariaDB
Further information on sequences.
It seems that we cannot rely on @lastval()@ method at all to detect the current ...
Ovidiu Maxiniuc
02:29 PM Feature #6453: temp-table features
Ovidiu Maxiniuc wrote:
> My surprise was to see the last htt-MIN.xsd and htt-FULL.xsd are pretty identical. Initiall...
Igor Skornyakov
02:26 PM Feature #6453: temp-table features
When I initially added this attribute I used a possible older manuals. It seems it is unchanged, though.
I think you...
Ovidiu Maxiniuc
01:39 PM Feature #6453: temp-table features
Ovidiu Maxiniuc wrote:
> A bit strange. The OE versions looks identical in both FULL and NONE case.
> https://docs....
Igor Skornyakov
01:24 PM Feature #6453: temp-table features
A bit strange. The OE versions looks identical in both FULL and NONE case.
https://docs.progress.com/ru-RU/bundle/op...
Ovidiu Maxiniuc
12:02 PM Feature #6453: temp-table features
Igor Skornyakov wrote:
> Constantin,
> If you have time can you please advise me how to run this test with FWD? I...
Igor Skornyakov
06:08 AM Feature #6453: temp-table features
Please find the final version of my test and its results attached.
It looks that currently we serialize less fields'...
Igor Skornyakov
05:59 AM Feature #6453: temp-table features
Marian Edu wrote:
> Igor Skornyakov wrote:
> > When running attached test with an application server, I see the fol...
Igor Skornyakov
05:41 AM Feature #6453: temp-table features
Igor Skornyakov wrote:
> When running attached test with an application server, I see the following in the server lo...
Marian Edu
05:36 AM Feature #6453: temp-table features
When running attached test with an application server, I see the following in the server log:... Igor Skornyakov
02:40 AM Feature #6453: temp-table features
Marian Edu wrote:
> Igor Skornyakov wrote:
> > Marian,
> > Sorry for disturbing you, but I've stuck with the probl...
Igor Skornyakov
02:02 AM Feature #6453: temp-table features
Igor Skornyakov wrote:
> Marian,
> Sorry for disturbing you, but I've stuck with the problem of running my test wit...
Marian Edu
01:06 PM Feature #6813: analyze and improve performance of dynamic conversion of temp-tables and queries
Ovidiu Maxiniuc wrote:
> OK, I understand now. If the ASTs are found in cache, the time _"was 40-50ms for dynamic ca...
Constantin Asofiei
12:59 PM Feature #6813: analyze and improve performance of dynamic conversion of temp-tables and queries
OK, I understand now. If the ASTs are found in cache, the time _"was 40-50ms for dynamic case"_ which is pretty close... Ovidiu Maxiniuc
12:47 PM Feature #6813: analyze and improve performance of dynamic conversion of temp-tables and queries
Ovidiu Maxiniuc wrote:
> That is correct.
> I see that there are 2 buffers involved so there is a bit of initializa...
Constantin Asofiei
12:46 PM Feature #6813: analyze and improve performance of dynamic conversion of temp-tables and queries
That is correct.
I see that there are 2 buffers involved so there is a bit of initialization and maybe some optimiza...
Ovidiu Maxiniuc
12:29 PM Feature #6813: analyze and improve performance of dynamic conversion of temp-tables and queries
Ovidiu Maxiniuc wrote:
> The engine for dynamic queries will replace the inlined values with parameters. So all @con...
Constantin Asofiei
12:07 PM Feature #6813: analyze and improve performance of dynamic conversion of temp-tables and queries
Constantin Asofiei wrote:
> The dynamic case is 3-6 times slower than OE, and the static case 2-5 times slower. I a...
Ovidiu Maxiniuc
11:56 AM Feature #6813: analyze and improve performance of dynamic conversion of temp-tables and queries
> I am thinking of a specialized AST (JavaAst) with runtime annotations as members instead. No more access using Map ... Greg Shah
11:48 AM Feature #6813: analyze and improve performance of dynamic conversion of temp-tables and queries
Ovidiu, the problem is when the query predicate for the dynamic query is really unique (think a UUID is used as an op... Constantin Asofiei
11:35 AM Feature #6813: analyze and improve performance of dynamic conversion of temp-tables and queries
Constantin Asofiei wrote:
> Ovidiu, I don't see any calls originating from @interpret@, into the application (via Co...
Ovidiu Maxiniuc
11:17 AM Feature #6813: analyze and improve performance of dynamic conversion of temp-tables and queries
Constantin Asofiei wrote:
> Improvements need to be made to dynamic query interpreter, too. It takes ~280ms for 650...
Ovidiu Maxiniuc
11:16 AM Feature #6813: analyze and improve performance of dynamic conversion of temp-tables and queries
Ovidiu, I don't see any calls originating from @interpret@, into the application (via ControlFlowOps). Most of the t... Constantin Asofiei
11:04 AM Feature #6813: analyze and improve performance of dynamic conversion of temp-tables and queries
Do you have a statistic of where is the most time consumed?
Usually the AST tree is simple enough and there are on...
Ovidiu Maxiniuc
09:56 AM Feature #6813: analyze and improve performance of dynamic conversion of temp-tables and queries
Improvements need to be made to dynamic query interpreter, too. It takes ~280ms for 6500 'interpret' calls. Constantin Asofiei
10:55 AM Bug #6887: improve performance of dataset/table[-handle] parameters
In a large application, there is this JMX reported times (count/millis/nanos):... Constantin Asofiei
10:48 AM Bug #6887 (Review): improve performance of dataset/table[-handle] parameters
Constantin Asofiei
08:38 AM Feature #6582: implement multi-table AdaptiveQuery
This is the latest comparison of the scenarios in the context of the new H2 feature: incremental indexed sorting (658... Alexandru Lungu
07:09 AM Support #6708: track/report at runtime when AdaptiveQuery shifts into dynamic mode
As I recently got time to work with our LTW engine, I suggest extending it to cover the run-time tracking / reporting... Alexandru Lungu
06:28 AM Bug #5306: AdaptiveQuery sets a found record into the buffer twice in dynamic mode
The same issue I encountered when implemented #6582. When @AdaptiveQuery@ was in dynamic mode, the record was fetched... Alexandru Lungu
05:53 AM Feature #6815: configure all cache sizes in the directory, and create documentation for them
This includes the @query_cache_size=1024@ for temp-tables in @H2Helper.setCommonInMemoryProperties@. Constantin Asofiei
05:01 AM Feature #6830: find and fix all SQL SELECT statements with inlined literal arguments, and rewrite...
I have applied the changes you suggested. Also, I have tested all of them against a large customer application and th... Radu Apetrii

10/25/2022

04:21 PM Feature #6371: implement SAVE CACHE statement
Pushed point 2 from list above. See revision 6371a/14116.
Point 1 is still in progress.
Boris Schegolev
12:13 PM Feature #6453: temp-table features
Marian,
Sorry for disturbing you, but I've stuck with the problem of running my test with the OE App. Server.
The t...
Igor Skornyakov
11:53 AM Feature #4056: instrument FWD and supporting libraries to measure database performance
Committed 6129b/rev. 14307 including the new support for the HTML presentation of the method tracing data. There are ... Alexandru Lungu
10:16 AM Feature #4056: instrument FWD and supporting libraries to measure database performance
Alexandru Lungu wrote:
> Eric Faulhaber wrote:
> > Please commit the same update to branch 6129b today. Thank you.
...
Eric Faulhaber
04:03 AM Feature #4056: instrument FWD and supporting libraries to measure database performance
Eric Faulhaber wrote:
> Please commit the same update to branch 6129b today. Thank you.
Done it in 6129b/rev. 143...
Alexandru Lungu
02:10 AM Feature #4056: instrument FWD and supporting libraries to measure database performance
Dănuț Filimon wrote:
> Committed 3821c/rev.14313. Added AspectJ on @com.goldencode.p2j.persist.orm@ subpackage while...
Eric Faulhaber
08:41 PM Bug #6837 (WIP): prevent unnecessary upper/rtrim injection in queries if the data type doesn't re...
Eric Faulhaber wrote:
> I agree that we don't want dialect-specific metadata in DMO annotations. OTOH, I think it ma...
Ovidiu Maxiniuc

10/24/2022

07:23 PM Bug #6837: prevent unnecessary upper/rtrim injection in queries if the data type doesn't require it
I agree that we don't want dialect-specific metadata in DMO annotations. OTOH, I think it makes sense to store that m... Eric Faulhaber
06:34 PM Bug #6837: prevent unnecessary upper/rtrim injection in queries if the data type doesn't require it
The dropping of the @upper()@ / @rtrim()@ functions injected during conversion must be done anyway. Initially, it wil... Ovidiu Maxiniuc
01:08 PM Bug #4071: FWD server stops allowing new web client logins after abend
I'll also try to force the race condition Greg detected using a small sleep. Tijs Wickardt
12:49 PM Bug #4071: FWD server stops allowing new web client logins after abend
Okay. I'll try to hammer the system (testcases and/or <app>) concurrently, trying to overlap client shutdowns. Tijs Wickardt
12:14 PM Bug #4071: FWD server stops allowing new web client logins after abend
Unfortunately, I never found a reliable way to recreate this condition, else it probably would be fixed already. Eric Faulhaber
11:39 AM Bug #4071: FWD server stops allowing new web client logins after abend
Eric: Do you recall the details on how this problem can be recreated? Tijs is asking for guidance in #6787-70.
If...
Greg Shah
07:45 AM Feature #6830: find and fix all SQL SELECT statements with inlined literal arguments, and rewrite...
Greg Shah wrote:
> > Greg, is this a good moment to add the patch to 3821c?
>
> How safe are the changes? Have w...
Radu Apetrii
07:25 AM Feature #6830: find and fix all SQL SELECT statements with inlined literal arguments, and rewrite...
> Greg, is this a good moment to add the patch to 3821c?
How safe are the changes? Have we tested them in one of ...
Greg Shah
06:52 AM Feature #6830: find and fix all SQL SELECT statements with inlined literal arguments, and rewrite...
I reviewed the @6830.patch@. Nice job!
A couple of notes related to affected code:
* in @FastCopyHelper.java@ I s...
Ovidiu Maxiniuc
06:15 AM Feature #6830: find and fix all SQL SELECT statements with inlined literal arguments, and rewrite...
Here's the patch you requested. It was built on 3821c, rev. 14307.
I also modified @ReportApi.persistSearchHistory@ ...
Radu Apetrii
07:05 AM Bug #6868: MariaDB Dialect can't properly check if a sequence exists
Radu Apetrii wrote:
> As a side note, I noticed there was a slight difference in results when running the test from ...
Ovidiu Maxiniuc
06:23 AM Bug #6868: MariaDB Dialect can't properly check if a sequence exists
As a side note, I noticed there was a slight difference in results when running the test from #6868-1 in both Postgre... Radu Apetrii

10/21/2022

07:10 PM Feature #6371: implement SAVE CACHE statement
I pushed an update that handles the properties of columns (types, nullable, default, etc.), provides null-safe readin... Boris Schegolev
09:39 AM Feature #4056: instrument FWD and supporting libraries to measure database performance
Committed 3821c/rev.14313. Added AspectJ on @com.goldencode.p2j.persist.orm@ subpackage while keeping @com.goldencode... Dănuț Filimon
03:43 AM Feature #6830: find and fix all SQL SELECT statements with inlined literal arguments, and rewrite...
Radu, please post a patch here for review, and mention the branch and revision it was built on. Constantin Asofiei

10/20/2022

11:55 AM Feature #6830: find and fix all SQL SELECT statements with inlined literal arguments, and rewrite...
Radu Apetrii wrote:
> * I could not test @MariaDbDialect.getSequenceSetValString@ because I cannot access sequences ...
Ovidiu Maxiniuc
06:57 AM Feature #6830: find and fix all SQL SELECT statements with inlined literal arguments, and rewrite...
I have tested these prepared statements (from the last post) and I got the following results:
* Out of 16 modificati...
Radu Apetrii
11:41 AM Bug #6868 (Feedback): MariaDB Dialect can't properly check if a sequence exists
I assume you use 3821c.
This is an issue which was addressed in another branch. To allow you advance until the merge...
Ovidiu Maxiniuc
05:57 AM Bug #6868: MariaDB Dialect can't properly check if a sequence exists
I tried executing with MariaDB (10.3.34) database this example:... Radu Apetrii
05:50 AM Bug #6868 (Feedback): MariaDB Dialect can't properly check if a sequence exists
Radu Apetrii
09:13 AM Feature #6418: represent extent fields as arrays
Greg Shah wrote:
> The above is my opinion. Eric makes the final decision here.
Any decision yet?
Radu Apetrii
09:10 AM Feature #6695: Multi-table preselect query may underperform due to repetitive fetching
There is already some work for #6720 which is close to this thread.
*I am planning to move my changes from 6582a to ...
Radu Apetrii
06:23 AM Feature #4056: instrument FWD and supporting libraries to measure database performance
I got it now. It was a mistake from my part (I was not using @-a@ option on the target server to be traced, but on th... Alexandru Lungu
05:17 AM Feature #4056: instrument FWD and supporting libraries to measure database performance
> The queries (adaptive, preselect or compound) are not considered for "debug weaving" nor for "debug not weaving" (b... Greg Shah
12:24 AM Feature #4056: instrument FWD and supporting libraries to measure database performance
Eric Faulhaber wrote:
> For reference, I am attaching another @trace.csv@ file that was generated after implementi...
Eric Faulhaber

10/19/2022

06:24 PM Feature #6720: lazy hydration
Yes, that is what I calling partial record hydration. Greg Shah
03:18 PM Feature #6720: lazy hydration
Greg, I think that #5731-399 doesn't implement lazy hydration. It just extends the usage of FWD Persistence API for e... Sergey Ivanovskiy
09:42 AM Feature #6720: lazy hydration
Code posted in #5731-399 implements partial record hydration. Greg Shah
04:01 PM Feature #4056: instrument FWD and supporting libraries to measure database performance
TBH, I've never fully understood the AspectJ weaving implementation, though back when I initially implemented this, I... Eric Faulhaber
04:09 AM Feature #4056: instrument FWD and supporting libraries to measure database performance
I could set-up this feature with 3821c/rev.14305 and Hotel GUI. I am starting a standard server and then I attach the... Alexandru Lungu
09:41 AM Feature #2137: runtime support for FIELDS/EXCEPT record phrase options
Code posted in #5731-399 implements partial record hydration. Greg Shah
09:07 AM Feature #6453: temp-table features
Greg Shah wrote:
> We need to match the results exactly. No short cuts.
I see. So I definitely need to be able t...
Igor Skornyakov
09:02 AM Feature #6453: temp-table features
We need to match the results exactly. No short cuts. Greg Shah
08:56 AM Feature #6453: temp-table features
Igor Skornyakov wrote:
> BTW: what can go wrong if we ignore @SCHEMA-MARSHAL@ and always send *all* schema attribu...
Marian Edu
08:51 AM Feature #6453: temp-table features
Marian Edu wrote:
> If it's easier for you we can write the 4GL tests on our side and then you run those on FWD, e...
Igor Skornyakov
08:06 AM Feature #6453: temp-table features
Igor Skornyakov wrote:
> If I will be able to run at least one test from @testcases/appsrv@ with 4GL I believe I w...
Marian Edu
06:11 AM Feature #6453: temp-table features
Marian Edu wrote:
> Igor Skornyakov wrote:
> > Marian,
> > I've finished (hopefully) with other substasks and star...
Igor Skornyakov
05:54 AM Feature #6453: temp-table features
Igor Skornyakov wrote:
> Marian,
> I've finished (hopefully) with other substasks and started working on testing @S...
Marian Edu
04:08 AM Feature #6453: temp-table features
Marian Edu wrote:
> Greg Shah wrote:
> > Constantin/Marian: Can you please advise Igor on how he can test the behav...
Igor Skornyakov
07:42 AM Support #6714: check if there is an optimization opportunity when copying temp-tables based on mu...
I have created tests with the mentioned specifications and all passed (same results were obtained from the executed s... Dănuț Filimon

10/18/2022

04:58 PM Feature #6371: implement SAVE CACHE statement
I have successfully loaded a table / new DMO into my server runtime. Code is in 6371a/14114 revision. Boris Schegolev
11:22 AM Bug #6852: Problem with datetime-tz literal string conversion.
The field definition... Igor Skornyakov
11:21 AM Bug #6852 (New): Problem with datetime-tz literal string conversion.
Igor Skornyakov
11:16 AM Feature #6453: temp-table features
Eric Faulhaber wrote:
> Yes, please do, and let's focus on the remaining core items of this task. What is left?
...
Igor Skornyakov
11:13 AM Feature #6453: temp-table features
Igor Skornyakov wrote:
> As far as I understand @relex()@ cannot properly and reliably detect the literal type since...
Eric Faulhaber
08:21 AM Feature #6453: temp-table features
As far as I understand @relex()@ cannot properly and reliably detect the literal type since it does not consider @vty... Igor Skornyakov
06:58 AM Feature #6453: temp-table features
Greg Shah wrote:
> Look at @initializer_constant@ in @progress.g@. There is a @relex()@ step that occurs when the l...
Igor Skornyakov
06:57 AM Feature #6453: temp-table features
Look at @initializer_constant@ in @progress.g@. There is a @relex()@ step that occurs when the literal is quoted tex... Greg Shah
06:49 AM Feature #6453: temp-table features
Igor Skornyakov wrote:
> Igor Skornyakov wrote:
> > I've noticed the following conversion problem:
> > The field d...
Igor Skornyakov
06:02 AM Feature #6453: temp-table features
Fixed @COLUMN-CODEPAGE@ and @now@/@today@ @INITIAL@ attribute values for dynamic temp-tables.
Please review.
Thank ...
Igor Skornyakov
05:08 AM Feature #6453: temp-table features
Igor Skornyakov wrote:
> I've noticed the following conversion problem:
> The field definition
> [...]
> is conve...
Igor Skornyakov
09:16 PM Bug #6301: incorrect initialization of date-related fields with today and now literals
Eric Faulhaber wrote:
> A fix is committed to 3821c/14279. I have tested with the above test case.
>
> Ovidiu, pl...
Ovidiu Maxiniuc

10/17/2022

02:17 PM Bug #6301: incorrect initialization of date-related fields with today and now literals
Fixed in 6129b/14302. Tested with this simple test case:... Eric Faulhaber
02:01 PM Bug #6301 (Test): incorrect initialization of date-related fields with today and now literals
Igor reported a regression for a table with two fields of type @datetime@ and @datetime-tz@, respectively, both with ... Eric Faulhaber
02:13 PM Feature #6453: temp-table features
I've noticed the following conversion problem:
The field definition...
Igor Skornyakov
10:33 AM Feature #6457: finish COPY-LOB support
> What are the values you're trying to use for the codepages/collation tables - for cpstream and cpinternal?
I wan...
Stanislav Lomany
08:42 AM Feature #6457: finish COPY-LOB support
Stanislav Lomany wrote:
> > @i18n/4gl/cp_collation.xml@ @i18n/4gl/cp_conversion.xml@ @i18n/4gl/chr_conversion.xml@ @...
Marian Edu

10/16/2022

03:05 PM Feature #6457: finish COPY-LOB support
> @i18n/4gl/cp_collation.xml@ @i18n/4gl/cp_conversion.xml@ @i18n/4gl/chr_conversion.xml@ @i18n/4gl/is_conversion.xml@... Stanislav Lomany

10/15/2022

03:29 AM Feature #6348: implement support for MariaDB
There is another issue in MariaDB - sequences and tables are in the same namespace. In OE, IIRC they are not in the ... Constantin Asofiei
09:33 PM Feature #6348: implement support for MariaDB
Constantin Asofiei wrote:
> 6129a/14487 contains some fixes related to sequences in MariaDB:
> * fixes related to s...
Ovidiu Maxiniuc

10/14/2022

05:04 PM Bug #6767: Possible name clashes in DMO classes
Eric: Please review. Greg Shah
03:04 PM Bug #6715: BufferManager.validate throws IllegalStateException if a validation fails via a Valida...
Tijs Wickardt wrote:
> Eric Faulhaber wrote:
> > Tijs, could you please check the files you committed related to th...
Tijs Wickardt
11:19 AM Bug #6715: BufferManager.validate throws IllegalStateException if a validation fails via a Valida...
Eric Faulhaber wrote:
> Tijs, could you please check the files you committed related to the @TailMap@ implementation...
Tijs Wickardt
11:14 AM Bug #6715: BufferManager.validate throws IllegalStateException if a validation fails via a Valida...
Constantin Asofiei wrote:
> In some cases, a ValidationException (which is from a bug) is wrapped in a ErrorConditio...
Eric Faulhaber
11:07 AM Bug #6715: BufferManager.validate throws IllegalStateException if a validation fails via a Valida...
In some cases, a ValidationException (which is from a bug) is wrapped in a ErrorConditionException, like this:... Constantin Asofiei
11:02 AM Bug #6715: BufferManager.validate throws IllegalStateException if a validation fails via a Valida...
Yes, @ErrorConditionException@ should be allowed through; it should not be wrapped in @IllegalStateException@. I thin... Eric Faulhaber
12:51 PM Feature #6348: implement support for MariaDB
Fun fact (nothing more): you can set NTFS to case sensitive in Windows.
That will OE classes in Windows to become ca...
Tijs Wickardt
12:24 PM Feature #6348: implement support for MariaDB
Constantin Asofiei wrote:
> Regarding case-sensitivity in MariaDB: this is OS-dependent, it will be case-insensitive...
Ovidiu Maxiniuc
12:23 PM Feature #6348: implement support for MariaDB
Regarding case-sensitivity in MariaDB: this is OS-dependent, it will be case-insensitive on Windows. Constantin Asofiei
12:23 PM Feature #6348: implement support for MariaDB
Ovidiu Maxiniuc wrote:
> How are you able to keep then in various casing?
Set @ conversion="minimal"@ in p2j.cfg.xm...
Constantin Asofiei
12:17 PM Feature #6348: implement support for MariaDB
Constantin Asofiei wrote:
> Ovidiu, the main issue is the case-sensitivity of sequence names (and tables, btw) in Ma...
Ovidiu Maxiniuc
11:01 AM Feature #6348: implement support for MariaDB
Ovidiu, with an app I'm seeing lots of @MISSING: MariaDbDialect.isQueryRangeParameterInlined()@ - is this a TODO rela... Constantin Asofiei
06:22 AM Feature #6348: implement support for MariaDB
6129a/14487 contains some fixes related to sequences in MariaDB:
* fixes related to sequence management in MariaDB -...
Constantin Asofiei
12:07 PM Feature #6453: temp-table features
Eric Faulhaber wrote:
> Igor Skornyakov wrote:
>
> > Looking at 3821c I'm not sure that it contains the fix for t...
Igor Skornyakov
11:27 AM Feature #6453: temp-table features
Igor Skornyakov wrote:
> Looking at 3821c I'm not sure that it contains the fix for the problem.
We have some t...
Eric Faulhaber
08:42 AM Feature #6453: temp-table features
Fixed a number of issues with @WRITE-XML@ and @READ-XMLSCHEMA@.
Committed to 6129a/14488.
At this moment I see ...
Igor Skornyakov
08:30 AM Feature #6453: temp-table features
Greg Shah wrote:
> Are you saying that Eric's solution in 3821c revs 14279 and 14280 is not sufficient to resolve th...
Igor Skornyakov
08:16 AM Feature #6453: temp-table features
Are you saying that Eric's solution in 3821c revs 14279 and 14280 is not sufficient to resolve the issue you have found? Greg Shah
08:09 AM Feature #6453: temp-table features
Greg Shah wrote:
> > In @TableMapper.loadFields@ for if @INITIAL@ is @NOW@ or @TODAY@ for date/datetime field we cal...
Igor Skornyakov
08:05 AM Feature #6453: temp-table features
> In @TableMapper.loadFields@ for if @INITIAL@ is @NOW@ or @TODAY@ for date/datetime field we calculate the value of ... Greg Shah
07:59 AM Feature #6453: temp-table features
In @TableMapper.loadFields@ for if @INITIAL@ is @NOW@ or @TODAY@ for date/datetime field we calculate the value of co... Igor Skornyakov
07:10 AM Bug #6829: H2 forces re-parse of all prepared statements when metadata is changed
Constantin Asofiei wrote:
> Alex, there's something else I'd like to understand: I've increased the FWD's @psCache@ ...
Alexandru Lungu

10/13/2022

03:38 PM Bug #6829: H2 forces re-parse of all prepared statements when metadata is changed
Alex, there's something else I'd like to understand: I've increased the FWD's @psCache@ to 65535 for a large customer... Constantin Asofiei
08:53 AM Bug #6829: H2 forces re-parse of all prepared statements when metadata is changed
Constantin Asofiei wrote:
> Alex, I was under the impression that a test like this, @dyntable.p@:
> [...]
>
> wh...
Alexandru Lungu
07:45 AM Bug #6829: H2 forces re-parse of all prepared statements when metadata is changed
Alex, I was under the impression that a test like this, @dyntable.p@:... Constantin Asofiei
07:06 AM Bug #6829: H2 forces re-parse of all prepared statements when metadata is changed
> In FWD, the FWD persistence session for the temporary database will get opened and closed depending on the applicat... Alexandru Lungu
06:13 AM Bug #6829: H2 forces re-parse of all prepared statements when metadata is changed
Alexandru Lungu wrote:
> > The FWD-level cache of prepared statements in TempTableDataSourceProvider's psCache will ...
Constantin Asofiei
05:01 AM Bug #6829: H2 forces re-parse of all prepared statements when metadata is changed
> But, there may be an issue: are dynamic temp-table names unique for the lifetime of a FWD server? Because a Prepare... Alexandru Lungu
09:34 AM Feature #6830: find and fix all SQL SELECT statements with inlined literal arguments, and rewrite...
Here's a report on how modifying went so far:
* Out of 26 possible spots, 16 were modified with no further problems....
Radu Apetrii
03:26 AM Feature #6830: find and fix all SQL SELECT statements with inlined literal arguments, and rewrite...
I have fixed the cases described previously by Constantin, apart from @FastCopyHelper.copyTable@, due to the fact tha... Radu Apetrii
08:46 AM Feature #6457: finish COPY-LOB support
Greg Shah wrote:
> Please provide the list of codepages/scenarios which need testing (and which you cannot test).
>...
Marian Edu
04:37 AM Support #6714: check if there is an optimization opportunity when copying temp-tables based on mu...
Danut, you can try using some of the following scenarios to have a comprehensive context of where such optimization m... Alexandru Lungu
03:51 AM Feature #6453: temp-table features
Igor Skornyakov wrote:
> Ovidiu Maxiniuc wrote:
> > The @serialize-hidden@ is a known issue which was fixed in a di...
Igor Skornyakov
03:20 AM Feature #6453: temp-table features
Greg Shah wrote:
> > For datetime the difference is only in case.
>
> Please analyze if this case difference matt...
Igor Skornyakov
02:40 AM Feature #6453: temp-table features
Ovidiu Maxiniuc wrote:
> The @serialize-hidden@ is a known issue which was fixed in a different branch. To fix it, o...
Igor Skornyakov

10/12/2022

06:30 PM Feature #6453: temp-table features
The @serialize-hidden@ is a known issue which was fixed in a different branch. To fix it, open @DynamicTablesHelper.j... Ovidiu Maxiniuc
11:53 AM Feature #6453: temp-table features
Igor Skornyakov wrote:
> It looks that the problem with @WRITE-XMLSCHEMA@ for dynamic TEMP-TABLE in FWD is that for ...
Igor Skornyakov
11:44 AM Feature #6453: temp-table features
> For datetime the difference is only in case.
Please analyze if this case difference matters in our runtime. If ...
Greg Shah
10:55 AM Feature #6453: temp-table features
Greg Shah wrote:
> > Should I fix defaultFormatString() methods to match defFormats?
>
> Probably not. I think th...
Igor Skornyakov
10:31 AM Feature #6453: temp-table features
> Should I fix defaultFormatString() methods to match defFormats?
Probably not. I think that may cause regressions...
Greg Shah
05:13 AM Feature #6453: temp-table features
Marian Edu wrote:
> Greg Shah wrote:
> > Constantin/Marian: Can you please advise Igor on how he can test the behav...
Igor Skornyakov
04:55 AM Feature #6453: temp-table features
Greg Shah wrote:
> Constantin/Marian: Can you please advise Igor on how he can test the behavior of @SCHEMA-MARSHAL@...
Marian Edu
04:36 AM Feature #6453: temp-table features
Marian Edu wrote:
> Igor Skornyakov wrote:
> > It looks that the problem with @WRITE-XMLSCHEMA@ for dynamic TEMP-TA...
Igor Skornyakov
04:34 AM Feature #6453: temp-table features
Igor Skornyakov wrote:
> It looks that the problem with @WRITE-XMLSCHEMA@ for dynamic TEMP-TABLE in FWD is that for ...
Marian Edu
04:25 AM Feature #6453: temp-table features
It looks that the problem with @WRITE-XMLSCHEMA@ for dynamic TEMP-TABLE in FWD is that for all fields of such table @... Igor Skornyakov
03:23 AM Feature #6453: temp-table features
Igor Skornyakov wrote:
> Igor Skornyakov wrote:
> > I've noticed a strange thing.
> > For some field data types (e...
Igor Skornyakov
04:24 PM Bug #6837: prevent unnecessary upper/rtrim injection in queries if the data type doesn't require it
Eric Faulhaber wrote:
> The insertion of @upper@ occurs at least during conversion, possibly at runtime. The inserti...
Ovidiu Maxiniuc
04:02 PM Bug #6837: prevent unnecessary upper/rtrim injection in queries if the data type doesn't require it
In some cases, we are using @upper@ and/or @rtrim@ in WHERE and ORDER BY clauses to adjust textual columns that don't... Eric Faulhaber
03:52 PM Bug #6837 (WIP): prevent unnecessary upper/rtrim injection in queries if the data type doesn't re...
Eric Faulhaber
10:12 AM Feature #6457: finish COPY-LOB support
Please provide the list of codepages/scenarios which need testing (and which you cannot test).
Marian: I think we ...
Greg Shah
09:58 AM Feature #6457: finish COPY-LOB support
> Is the testing issue caused by the virtual machine not having the needed codepages installed?
Some cases claim t...
Stanislav Lomany
09:29 AM Feature #6457: finish COPY-LOB support
> I cannot change -cpstream/-cpinternal parameters on a customer's VM either, so I cannot experiment with it.
Is ...
Greg Shah
09:16 AM Feature #6457: finish COPY-LOB support
I cannot change @-cpstream@/@-cpinternal@ parameters on a customer's VM either, so I cannot experiment with it.
Mor...
Stanislav Lomany

10/11/2022

05:00 PM Feature #6371: implement SAVE CACHE statement
Pushed revision 14113. Now it's going past @generateSchemaAst()@ call. I can't test further because of some misconfig... Boris Schegolev
03:45 PM Feature #6453: temp-table features
Ovidiu Maxiniuc wrote:
> Igor Skornyakov wrote:
> > It looks that the value of the @SCHEMA-MARSHAL@ attribute has n...
Greg Shah
03:01 PM Feature #6453: temp-table features
Igor Skornyakov wrote:
> I've noticed a strange thing.
> For some field data types (e.g. @datetime@, @recid@, @hand...
Igor Skornyakov
11:18 AM Feature #6453: temp-table features
Added COLUMN-CODEPAGE field attribute support (conversion and @WRITE-XMLSCHEMA@)
Committed to 6129a/14482.
Igor Skornyakov
12:29 PM Bug #6829: H2 forces re-parse of all prepared statements when metadata is changed
As a query can target multiple metadata (like tables, indexes, sequences), the cache needs to be notified to evict a... Constantin Asofiei
08:51 AM Bug #6835: deferred work for #6257
This task is meant to properly handle the root cause of #6257.
Eric/Ovidiu: Please document the issue and solution...
Greg Shah
08:50 AM Bug #6835 (New): deferred work for #6257
Greg Shah
08:50 AM Bug #6834: RAQ navigation on records having NULL values on same index components
This task is meant to properly handle the root cause of #6755.
Eric/Ovidiu: Please document the issue and solution...
Greg Shah
08:48 AM Bug #6834 (Closed): RAQ navigation on records having NULL values on same index components
Greg Shah
08:28 AM Bug #6767: Possible name clashes in DMO classes
Greg Shah wrote:
> Please post the final proposed patch.
Done @6767-full.diff@.
Vladimir Tsichevski
08:16 AM Bug #6767: Possible name clashes in DMO classes
Please post the final proposed patch. Greg Shah
08:07 AM Bug #6767 (Review): Possible name clashes in DMO classes
Vladimir Tsichevski wrote:
> UPD: this patch is probably causes some regressions like @org.postgresql.util.PSQLExcep...
Vladimir Tsichevski
08:05 AM Bug #6767: Possible name clashes in DMO classes
Some more changes needed, since some TRPL properties do not exist anymore, and the method call must be used now inste... Vladimir Tsichevski

10/10/2022

06:32 PM Bug #6767 (WIP): Possible name clashes in DMO classes
UPD: this patch is probably causes some regressions like @org.postgresql.util.PSQLException: ERROR: column wfnregio__... Vladimir Tsichevski
06:23 PM Bug #6767 (Review): Possible name clashes in DMO classes
Vladimir Tsichevski
06:23 PM Bug #6767 (WIP): Possible name clashes in DMO classes
Attached is the patch for this issue (@6767.diff@).
After this patch is applied, you will need to re-convert all c...
Vladimir Tsichevski
09:15 AM Bug #6767: Possible name clashes in DMO classes
Eric Faulhaber wrote:
> DMO getters/setters can be of the form:
>
> [...]
So, the following methods from the...
Vladimir Tsichevski
01:04 PM Feature #6453: temp-table features
Ovidiu Maxiniuc wrote:
> I think @rules/schema/fixups.xml@. See the other attributes are processed around lines 690....
Igor Skornyakov
12:49 PM Feature #6453: temp-table features
I think @rules/schema/fixups.xml@. See the other attributes are processed around lines 690. Ovidiu Maxiniuc
10:47 AM Feature #6453: temp-table features
I see that @KW_COL_CP@ AST (@COLUMN-CODEPAGE@) exists in .schema file but is missed in .p2o one.
What is the right p...
Igor Skornyakov
12:34 PM Bug #6829: H2 forces re-parse of all prepared statements when metadata is changed
The FWD-level cache of prepared statements in @TempTableDataSourceProvider@'s psCache will also keep statements relat... Constantin Asofiei
09:01 AM Feature #6582: implement multi-table AdaptiveQuery
I replaced H2 (fwd-h2/rev.6) with H2 PAGESTORE (fwd-h2/rev. 6) and H2 MVSTORE (2.1.214) in #6582-40. The previous res... Alexandru Lungu
07:41 AM Feature #6695: Multi-table preselect query may underperform due to repetitive fetching
I committed on 6582a, rev.14168. This change targets the improvement in performance regarding fetching for @Preselect... Radu Apetrii
05:44 AM Bug #6809 (Test): find current ... exclusive-lock no-wait. not working
Eric Faulhaber wrote:
> Fixed in 6129a/14477. Constantin, please review and test with the original application, if y...
Constantin Asofiei
02:24 AM Bug #6809 (Review): find current ... exclusive-lock no-wait. not working
Fixed in 6129a/14477. Constantin, please review and test with the original application, if you have a recreate beyond... Eric Faulhaber
05:30 AM Feature #6813: analyze and improve performance of dynamic conversion of temp-tables and queries
Other changes are in 3821c/14281:
* Avoid reflection when creating a new instance, in AnnotatedAst - added 'newInsta...
Constantin Asofiei
03:33 AM Feature #6830: find and fix all SQL SELECT statements with inlined literal arguments, and rewrite...
The task title mentions SELECT, but all kind of queries need to be checked/fixed: INSERT, UPDATE, DELETE. Constantin Asofiei
03:22 AM Feature #6830 (WIP): find and fix all SQL SELECT statements with inlined literal arguments, and r...
Alexandru Lungu
03:16 AM Bug #6301: incorrect initialization of date-related fields with today and now literals
Eric Faulhaber wrote:
> Alexandru, please take a look at @FastCopyHelper.getInitialValue@. This method is affected b...
Alexandru Lungu

10/09/2022

04:26 PM Bug #6301: incorrect initialization of date-related fields with today and now literals
Constantin Asofiei wrote:
> Eric, 3821c/14279 regresses some automated tests with this:
> [...]
Thanks for findi...
Eric Faulhaber
08:16 AM Bug #6301: incorrect initialization of date-related fields with today and now literals
Eric, 3821c/14279 regresses some automated tests with this:... Constantin Asofiei

10/08/2022

06:29 PM Bug #6809 (WIP): find current ... exclusive-lock no-wait. not working
Eric Faulhaber
06:26 PM Bug #6812: fix FastFindCache to use a shared instance per persistent database
Ovidiu Maxiniuc wrote:
> The factory makes sure the permanent databases use a commonly shared instance of @FastFindC...
Eric Faulhaber
06:06 PM Bug #6301 (Review): incorrect initialization of date-related fields with today and now literals
A fix is committed to 3821c/14279. I have tested with the above test case.
Ovidiu, please review.
Alexandru, pl...
Eric Faulhaber

10/07/2022

09:11 AM Support #6713: check if it is faster to use separate temp-table instances instead of multiplex id
I made tests for bulk delete and copy temp-table.
* *copy-temp-table-multiplex-{n}*, *copy-temp-table-no-multiplex-{...
Dănuț Filimon
07:13 AM Feature #6453: temp-table features
Constantin Asofiei wrote:
> > Fixed in 6129a/14474.
> Igor, you still have @lfi.getSerializeOptions(null).getXmlDat...
Igor Skornyakov
06:58 AM Feature #6453: temp-table features
Igor Skornyakov wrote:
> Ovidiu Maxiniuc wrote:
> > * @TableMapper@: I have not studied the new signatures (which u...
Constantin Asofiei
05:08 AM Feature #6453: temp-table features
Ovidiu Maxiniuc wrote:
> * @TableMapper@: I have not studied the new signatures (which use the new @TempTable@ param...
Igor Skornyakov
02:31 AM Feature #6453: temp-table features
Ovidiu Maxiniuc wrote:
> Review of 6129a/14473.
> * @AbstractTempTable@: shouldn't the last parameter of the 3131 e...
Igor Skornyakov
06:57 AM Feature #4011: database/persistence layer performance improvements
Constantin Asofiei wrote:
> I'm editing #4011-5 again, I'll comment when I'm done.
I've finished editing.
Constantin Asofiei
04:26 AM Feature #4011: database/persistence layer performance improvements
I'm editing #4011-5 again, I'll comment when I'm done. Constantin Asofiei
04:34 AM Bug #6829: H2 forces re-parse of all prepared statements when metadata is changed
As a side note: when executing some 60k H2 prepared statements, ~70% of the time is being spent in re-compiling the q... Constantin Asofiei
04:22 AM Bug #6829: H2 forces re-parse of all prepared statements when metadata is changed
In H2, there is this code in @org.h2.command.Prepared@:... Constantin Asofiei
04:18 AM Bug #6829 (Closed): H2 forces re-parse of all prepared statements when metadata is changed
Constantin Asofiei
04:30 AM Feature #6830: find and fix all SQL SELECT statements with inlined literal arguments, and rewrite...
This is mostly I think about multiplex ID being inlined instead of using an argument. The cases I found are:... Constantin Asofiei
04:28 AM Feature #6830 (Closed): find and fix all SQL SELECT statements with inlined literal arguments, an...
Constantin Asofiei
03:25 AM Feature #6457: finish COPY-LOB support
> Try setting the same value for all these cp parameters
Errors are the same for this case too.
Stanislav Lomany

10/06/2022

06:09 PM Feature #6453: temp-table features
Review of 6129a/14473.
* @AbstractTempTable@: shouldn't the last parameter of the 3131 error message be @LegacyResou...
Ovidiu Maxiniuc
02:48 PM Feature #6453: temp-table features
* Fixed issues with @WRITE-XMLSCHEMA@/@READ-XMLSCHEMA@ described in #6453-11 except the issue with @WRITE-XMLSCHEMA@ ... Igor Skornyakov
07:22 AM Feature #6453: temp-table features
Constantin Asofiei wrote:
> Igor, regarding the change in 6129a/14418 - are you sure PRIMARY defaults to the first d...
Igor Skornyakov
02:00 AM Feature #6453: temp-table features
Ovidiu Maxiniuc wrote:
> Igor Skornyakov wrote:
> > I see. Sorry. Will change back.
> > Please note however, that ...
Igor Skornyakov
04:49 PM Feature #6457: finish COPY-LOB support
I know, I had the same problems :(.
Try setting the same value for all these cp parameters, unless having them diffe...
Ovidiu Maxiniuc
03:51 PM Feature #6457: finish COPY-LOB support
Guys, I've been trying to experiment with @-cpstream@ and @-cpinternal@ parameters and found that when it comes to se... Stanislav Lomany
10:14 AM Support #6679: H2 general performance tuning
Committed hotel_gui/rev.252. I added the H2 performance tests to the Hotel GUI application.
Added a window with a ...
Dănuț Filimon
06:08 AM Feature #4011: database/persistence layer performance improvements
Constantin Asofiei wrote:
> I'm editing note #4011-5 to add other tasks. I'll comment when I'm done.
I've finished ...
Constantin Asofiei
02:12 AM Feature #4011: database/persistence layer performance improvements
I'm editing note #4011-5 to add other tasks. I'll comment when I'm done. Constantin Asofiei
05:23 AM Feature #6695: Multi-table preselect query may underperform due to repetitive fetching
There was a mistake in explanation on my part in the last post. In order to make this more clear, I will describe thi... Radu Apetrii
04:27 AM Feature #6825: improve table meta runtime (TableMapper and other)
Some changes are in 3821c/14272. Ovidiu, please review. Constantin Asofiei
03:37 AM Feature #6825: improve table meta runtime (TableMapper and other)
In TableMapper, because of some mutable state, a new LegacyTableInfo was being created for each buffer definition. T... Constantin Asofiei
03:35 AM Feature #6825 (WIP): improve table meta runtime (TableMapper and other)
Constantin Asofiei
04:26 AM Feature #6813: analyze and improve performance of dynamic conversion of temp-tables and queries
Some changes are in 3821c/14272. Greg, please review. Constantin Asofiei
02:12 AM Feature #6813: analyze and improve performance of dynamic conversion of temp-tables and queries
Parsing and TRPL rules are being executed for each dynamic query (at least the parsing/conversion of the query predic... Constantin Asofiei
02:10 AM Feature #6813 (WIP): analyze and improve performance of dynamic conversion of temp-tables and que...
Constantin Asofiei
03:25 AM Feature #6823: improve TemporaryBuffer/RecordBuffer define and buffer delete
For complex applications, with 1000s (or maybe 10k's) of buffer definitions in 100s of programs or legacy classes, th... Constantin Asofiei
03:23 AM Feature #6823 (New): improve TemporaryBuffer/RecordBuffer define and buffer delete
Constantin Asofiei
02:36 AM Feature #6816: improve PreselectQuery.assembleHQL
The code in PreselectQuery.assembleHQL appears in the profiler when testing very complex application APIs, in 6129a. ... Constantin Asofiei
02:26 AM Feature #6816 (Internal Test): improve PreselectQuery.assembleHQL
Constantin Asofiei
02:25 AM Feature #6815: configure all cache sizes in the directory, and create documentation for them
In 6129a, the prepared statement cache in TempTableDataSourceProvider is still configured to 100 - this was not enoug... Constantin Asofiei
02:24 AM Feature #6815 (Review): configure all cache sizes in the directory, and create documentation for ...
Constantin Asofiei
02:13 AM Support #6714 (WIP): check if there is an optimization opportunity when copying temp-tables based...
Alexandru Lungu
01:32 AM Bug #6812: fix FastFindCache to use a shared instance per persistent database
FastFindCache is now created for both temp-table and permanent databases. The problem is that for permanent (or meta,... Constantin Asofiei

10/05/2022

07:22 PM Bug #6812: fix FastFindCache to use a shared instance per persistent database
The factory makes sure the permanent databases use a commonly shared instance of @FastFindCache@ while for the temp-t... Ovidiu Maxiniuc
06:36 PM Bug #6812: fix FastFindCache to use a shared instance per persistent database
> FastFindCache looks like is only for temp-tables
It isn't used for permanent databases?
Greg Shah
04:11 PM Bug #6812: fix FastFindCache to use a shared instance per persistent database
Constantin Asofiei wrote:
> Eric, the FastFindCache looks like is only for temp-tables, and not other databases (lik...
Constantin Asofiei
04:09 PM Bug #6812: fix FastFindCache to use a shared instance per persistent database
Eric, the FastFindCache looks like is only for temp-tables, and not other databases (like meta). So my assumption is ... Constantin Asofiei
03:56 PM Bug #6812: fix FastFindCache to use a shared instance per persistent database
Eric Faulhaber wrote:
> ... or to have a separate cache for each database?
Good point. It needs to be per database...
Constantin Asofiei
03:07 PM Bug #6812: fix FastFindCache to use a shared instance per persistent database
Does it make more sense to qualify the table name with database name, or to have a separate cache for each database? Eric Faulhaber
02:59 PM Bug #6812: fix FastFindCache to use a shared instance per persistent database
We use @RecordIdentifier@ in @FastFindCache@ having the table identifier a simple string with the record's implementa... Constantin Asofiei
02:56 PM Bug #6812 (Internal Test): fix FastFindCache to use a shared instance per persistent database
Constantin Asofiei
07:16 PM Feature #6453: temp-table features
Igor Skornyakov wrote:
> I see. Sorry. Will change back.
> Please note however, that in my test the previous versio...
Ovidiu Maxiniuc
04:50 PM Feature #6453: temp-table features
Ovidiu Maxiniuc wrote:
> Just noticed an issue in @ErrorManager@ 6129a/14418.
> You fixed error message for error 3...
Igor Skornyakov
04:27 PM Feature #6453: temp-table features
Just noticed an issue in @ErrorManager@ 6129a/14418.
You fixed error message for error 3131 wrongly. There are tens ...
Ovidiu Maxiniuc
02:36 PM Feature #6453: temp-table features
The @codePage@ attribute of the @Property@ annotation is not populated in the generated DMO interface for the static ... Igor Skornyakov
12:52 PM Feature #6453: temp-table features
Ovidiu Maxiniuc wrote:
> Igor,
> Please do the test in all cases: the table was prepared or not, the index was set ...
Igor Skornyakov
12:49 PM Feature #6453: temp-table features
I've noticed a strange thing.
For some field data types (e.g. @datetime@, @recid@, @handle@ and @com-hangle@) in the...
Igor Skornyakov
12:45 PM Feature #6453: temp-table features
Igor,
Please do the test in all cases: the table was prepared or not, the index was set as primary or not. I do not ...
Ovidiu Maxiniuc
12:06 PM Feature #6453: temp-table features
Constantin Asofiei wrote:
> Igor, regarding the change in 6129a/14418 - are you sure PRIMARY defaults to the first d...
Igor Skornyakov
11:08 AM Feature #6453: temp-table features
Igor, regarding the change in 6129a/14418 - are you sure PRIMARY defaults to the first defined index, and not the fir... Constantin Asofiei
10:06 AM Feature #6453: temp-table features
I see multiple incompatibilities between FWD and 4GL in the @WRITE-XMLSCHEMA@ output.
In particular some @element@ a...
Igor Skornyakov
03:21 AM Feature #6453: temp-table features
Constantin Asofiei wrote:
> Igor/Eric/Ovidiu: we use the WRITE-XML and READ-XML behavior to serialize the payload bo...
Igor Skornyakov
02:45 AM Feature #6453: temp-table features
Igor/Eric/Ovidiu: we use the WRITE-XML and READ-XML behavior to serialize the payload both for read and write, for XM... Constantin Asofiei
02:21 PM Bug #6703: loading schema table DMO interface with no defined fields
My point was that the records exited in the original table and we need to have a table in FWD/SQL with same (well, eq... Ovidiu Maxiniuc
02:17 PM Bug #6703: loading schema table DMO interface with no defined fields
Ovidiu, I tested loading a .d for a table with no fields in the Data Administration, in OpenEdge:
* created a no-fie...
Constantin Asofiei
02:03 PM Bug #6703: loading schema table DMO interface with no defined fields
Eric Faulhaber wrote:
> Ovidiu Maxiniuc wrote:
> > * @Persister.java@: to avoid @ArrayIndexOutOfBoundsException@ wh...
Ovidiu Maxiniuc
11:08 AM Bug #6810 (Review): NPE in PreselectQuery.assembleFromClause
This test:... Constantin Asofiei
10:54 AM Bug #6810 (Review): NPE in PreselectQuery.assembleFromClause
Constantin Asofiei
09:48 AM Bug #6809: find current ... exclusive-lock no-wait. not working
This needs to be fixed in 6129a Constantin Asofiei
09:32 AM Bug #6809: find current ... exclusive-lock no-wait. not working
The recreate is this, using to FWD clients:
* run first program @b1.p@ - do not press any key:...
Constantin Asofiei
09:29 AM Bug #6809 (Test): find current ... exclusive-lock no-wait. not working
Constantin Asofiei
07:43 AM Feature #6582: implement multi-table AdaptiveQuery
In my effort to seek optimizing methods for our in-memory H2, I took some time to analyze some in-memory (eventually ... Alexandru Lungu

10/04/2022

04:29 PM Feature #6453: temp-table features
Ovidiu Maxiniuc wrote:
> As a first observation, I agree with Eric's note #6453-24: FWD is quite a large project, it...
Igor Skornyakov
04:25 PM Feature #6453: temp-table features
As a first observation, I agree with Eric's note #6453-24: FWD is quite a large project, it has 200+ dependencies (ja... Ovidiu Maxiniuc
04:00 PM Feature #6453: temp-table features
Greg Shah wrote:
> Also note that sometimes it is harder to meet specific 4GL compatibility requirements using 3rd p...
Igor Skornyakov
03:48 PM Feature #6453: temp-table features
Also note that sometimes it is harder to meet specific 4GL compatibility requirements using 3rd party libraries that ... Greg Shah
02:21 PM Feature #6453: temp-table features
Eric Faulhaber wrote:
> I agree with most of your points, except the performance assumption in your first point (and...
Igor Skornyakov
02:13 PM Feature #6453: temp-table features
Igor Skornyakov wrote:
> I undestand this. My points is
> * for this particular piece of functionality performan...
Eric Faulhaber
01:52 PM Feature #6453: temp-table features
Eric Faulhaber wrote:
> We are very careful about introducing new dependencies into the project and in fact we are s...
Igor Skornyakov
01:36 PM Feature #6453: temp-table features
We are very careful about introducing new dependencies into the project and in fact we are striving to simplify by re... Eric Faulhaber
01:14 PM Feature #6453: temp-table features
Igor Skornyakov wrote:
> Don't you think that instead of manual implementtation it makes sense to use some open-sour...
Igor Skornyakov
12:05 PM Feature #6453: temp-table features
It is easy to fix FWD to add index data to the @WRITE-XMLSCHEMA@ output. All we need is no comment @!this.isSchemaOnl... Igor Skornyakov
02:38 PM Bug #6767: Possible name clashes in DMO classes
Vladimir Tsichevski wrote:
> Eric Faulhaber wrote:
> > To clarify the task, we need to work through all superinterf...
Eric Faulhaber
11:31 AM Feature #6347: change the name conversion to provide a configurable option to not emit "snake case"
Eric Faulhaber wrote:
> Constantin Asofiei wrote:
> > Eric, I'm placing this back to WIP as this prevents 6129a to ...
Constantin Asofiei
11:07 AM Feature #6347: change the name conversion to provide a configurable option to not emit "snake case"
Constantin Asofiei wrote:
> Eric, I'm placing this back to WIP as this prevents 6129a to be tested with other projec...
Eric Faulhaber
10:55 AM Feature #6695: Multi-table preselect query may underperform due to repetitive fetching
Radu, please help me understand this better (perhaps it will make more sense to me when I review the update).
My c...
Eric Faulhaber
05:26 AM Feature #6695: Multi-table preselect query may underperform due to repetitive fetching
After some analysis, I have identified a spot in @PreselectQuery@ where things could be optimized. The problem was as... Radu Apetrii

10/03/2022

01:48 PM Feature #6453: temp-table features
Ovidiu Maxiniuc wrote:
> I implemented this using the reference manual and tested on real customer application. The ...
Igor Skornyakov
01:36 PM Feature #6453: temp-table features
Igor Skornyakov wrote:
> It looks that the value of the @SCHEMA-MARSHAL@ attribute has no effect on the @WRITE-XMLSC...
Ovidiu Maxiniuc
01:03 PM Feature #6453: temp-table features
Igor Skornyakov wrote:
> Actually there are minor incompatibilities:
> # The initial value of th @PRIMARY@ attribut...
Igor Skornyakov
11:53 AM Feature #6453: temp-table features
Igor Skornyakov wrote:
> Ovidiu Maxiniuc wrote:
>
> > OTOH, the PRIMARY attribute lacks both both conversion and ...
Igor Skornyakov
11:32 AM Feature #6453: temp-table features
Ovidiu Maxiniuc wrote:
> OTOH, the PRIMARY attribute lacks both both conversion and runtime support. The good news...
Igor Skornyakov
11:10 AM Feature #6453: temp-table features
Igor Skornyakov wrote:
> It looks that the value of the @SCHEMA-MARSHAL@ attribute has no effect on the @WRITE-XMLSC...
Igor Skornyakov
05:53 AM Feature #6453: temp-table features
It looks that the value of the @SCHEMA-MARSHAL@ attribute has no effect on the @WRITE-XMLSCHEMA@ output (both for 4GL... Igor Skornyakov
03:48 AM Feature #6453: temp-table features
Eric Faulhaber wrote:
> Agreed, but adding missing functionality is highest priority; if fixing any of these items l...
Igor Skornyakov
03:30 AM Feature #6453: temp-table features
Agreed, but adding missing functionality is highest priority; if fixing any of these items looks to be particularly t... Eric Faulhaber
03:33 AM Feature #6371: implement SAVE CACHE statement
I have committed revision 14112, which fixes the NPE and refactors the code for this feature out of @DatabaseManager@... Eric Faulhaber
 

Also available in: Atom