FWD » Core Development » Conversion Tools

07/01/2025

06:00 PM Bug #10215 (Internal Test): ant rpt fails when running only conversion.front

Greg Shah

06:00 PM Bug #10215: ant rpt fails when running only conversion.front

Is #6490-29 still fixed with the 10125a? If so, this seems pretty low risk to merge. Greg Shah

10:09 AM Bug #10215: ant rpt fails when running only conversion.front

Tested @ant rpt@ with and without #5586 on top of 10215a on hotel_gui and both passed.
Also looked through analytics... Stefan Vieru

08:37 AM Bug #10215: ant rpt fails when running only conversion.front

Committed rev. 16014 on branch 10125a that introduces the fix made by Constantin above:... Paul Bodale

07:35 AM Bug #10215: ant rpt fails when running only conversion.front

Paul, previously @is_extent_lvalue_ref@ was not matching on fields (the @descedent(prog.lbracket, 1)@ was wrong, firs... Constantin Asofiei

05:56 PM Feature #10190 (Internal Test): Prototype the changes to the build to add ANTLR v4

Greg Shah

05:56 PM Feature #10190: Prototype the changes to the build to add ANTLR v4

Code Review Task Branch 10190a Revision 16001
The changes are good. Greg Shah

11:10 AM Feature #10190 (Review): Prototype the changes to the build to add ANTLR v4

Greg Shah wrote:
> Code Review Task Branch 10190a Revisions 15999 and 16000
>
> The @registerGrammarTask()@ isn't... Florin Eugen Rotaru

08:57 AM Feature #10190 (WIP): Prototype the changes to the build to add ANTLR v4

Code Review Task Branch 10190a Revisions 15999 and 16000
The @registerGrammarTask()@ isn't quite right. Not all g... Greg Shah

09:36 AM Bug #10237: keepTildes is keeping tilde when preprocessor directive contains tilde and curly brace

Having the following testcase:... Stefan Vieru

09:29 AM Bug #10237 (New): keepTildes is keeping tilde when preprocessor directive contains tilde and curl...

Stefan Vieru

09:12 AM Feature #7180 (WIP): create a centralized manager for the conversion list and per-file/project st...

I'll put this into WIP until 5586a (#5586) is merged, the purpose is to get 7180a rebased to latest trunk which conta... Dănuț Filimon

08:21 AM Feature #6256: improved profile support

Anything at the global level should be assumed to be present for all profiles. Anything in a profile should be *adde... Greg Shah

08:04 AM Feature #6256: improved profile support

The issue with the database is actually related to how the default profile in SchemaCOnfig is set, the root cause is ... Dănuț Filimon

06:05 AM Feature #6256: improved profile support

The global schema should be used by a profile only when none of the active profiles have a schema defined, this is th... Dănuț Filimon

02:43 AM Feature #6256 (WIP): improved profile support

Dănuț Filimon

02:43 AM Feature #6256: improved profile support

Dănuț Filimon wrote:
> Greg Shah wrote:
> > If a profile contains any schema at all, then the top-level namespaces ... Dănuț Filimon

05:22 AM Bug #10235: Wrong variable used on CATCH block

There is a issue when there are multiple @CATCH@ blocks. On FWD, the variable reference for the first block is from t... Teodor Gorghe

05:14 AM Bug #10235 (Test): Wrong variable used on CATCH block

Teodor Gorghe

06/30/2025

03:15 PM Support #10231: Document the code style guidelines for ANTLR grammars, based on progress.g

The core rules have these forms:... Greg Shah

10:08 AM Support #10231: Document the code style guidelines for ANTLR grammars, based on progress.g

The wiki is the [[p2j:ANTLR Grammar Coding Standards]]. Florin Eugen Rotaru

10:07 AM Support #10231 (WIP): Document the code style guidelines for ANTLR grammars, based on progress.g

Florin Eugen Rotaru

10:26 AM Bug #10215: ant rpt fails when running only conversion.front

Why not just put some protection code in @describe_extent_lvalue@? Better yet, make sure that @describe_extent_lvalu... Greg Shah

03:28 AM Bug #10215 (Review): ant rpt fails when running only conversion.front

The problem comes from one modified function located in @rules/include/common-progress.rules@, precisely the *is_exte... Paul Bodale

03:26 AM Bug #10215 (WIP): ant rpt fails when running only conversion.front

Paul Bodale

09:12 AM Bug #10208: do not convert the schema in incremental mode if it hasn't changed

Dănuț Filimon wrote:
> Greg, the skipDBSchema is quite old. I suggest removing it and using the @schema@ flag to do ... Greg Shah

07:29 AM Bug #10208: do not convert the schema in incremental mode if it hasn't changed

Greg, the skipDBSchema is quite old. I suggest removing it and using the @schema@ flag to do the job. Dănuț Filimon

06:24 AM Bug #10208: do not convert the schema in incremental mode if it hasn't changed

#10208-13 can be achieved by correctly setting CvtRunMode.skipDBSchema, I made it protected and did the following for... Dănuț Filimon

05:34 AM Bug #10208: do not convert the schema in incremental mode if it hasn't changed

I created *10208a* from *trunk/16005* and committed an initial version in *10208a/16006*. The changes are for #10208-9. Dănuț Filimon

03:54 AM Bug #10208: do not convert the schema in incremental mode if it hasn't changed

I've made a few changes as mentioned in #10208-9, but I am wondering if there are any other conversion steps I should... Dănuț Filimon

09:09 AM Feature #10190: Prototype the changes to the build to add ANTLR v4

OK, I made the two changes and committed to *10190a/16000*. Florin Eugen Rotaru

07:47 AM Feature #10190: Prototype the changes to the build to add ANTLR v4

Florin Eugen Rotaru wrote:
> Greg Shah wrote:
> > Code Review Task Branch 10190a Revisions 15996 through 15998
> >... Greg Shah

03:17 AM Feature #10190: Prototype the changes to the build to add ANTLR v4

Greg Shah wrote:
> Code Review Task Branch 10190a Revisions 15996 through 15998
>
> The overall approach looks go... Florin Eugen Rotaru

02:14 AM Feature #6256: improved profile support

Greg Shah wrote:
> If a profile contains any schema at all, then the top-level namespaces are ignored. I think that... Dănuț Filimon

06/27/2025

01:32 PM Feature #6256: improved profile support

Code Review Task Branch 6256a Revisions 15944 and 15945
If a profile contains any schema at all, then the top-leve... Greg Shah

12:29 PM Feature #10190: Prototype the changes to the build to add ANTLR v4

Code Review Task Branch 10190a Revisions 15996 through 15998
The overall approach looks good.
1. We will have s... Greg Shah

10:04 AM Feature #10190 (Review): Prototype the changes to the build to add ANTLR v4

I have committed the changes to *10190/15998*. I added the @antlr4All@ registered in @gradle@ into the @ant-antrl@ ta... Florin Eugen Rotaru

09:56 AM Bug #10208: do not convert the schema in incremental mode if it hasn't changed

Greg Shah wrote:
> Constantin: Do we already detect that UAST @.hints@ file changes are a cause to reconvert the ass... Constantin Asofiei

09:47 AM Bug #10208: do not convert the schema in incremental mode if it hasn't changed

The approach seems correct to me.
> I am not sure if there are any hint files for schema?
Yes, there are schema... Greg Shah

09:12 AM Bug #10208 (WIP): do not convert the schema in incremental mode if it hasn't changed

Dănuț Filimon

09:12 AM Bug #10208: do not convert the schema in incremental mode if it hasn't changed

My current implementation works like this:
# @SchemaLoader.importSchema()@ should call @ConversionData.saveFileHash(... Dănuț Filimon

03:29 AM Bug #10208: do not convert the schema in incremental mode if it hasn't changed

Greg Shah wrote:
> I don't object, but can we just add the schemata to the FILE_SIGNATURE table?
Yes, I will do t... Dănuț Filimon

09:37 AM Feature #3971: add support for unicode escape sequences in the preprocessor

Octavian, is #8027 fixing already this task? Alexandru Lungu

05:56 AM Bug #10185: ADE conversion and runtime

Committed revision *15998* on task branch *10185a*:
- history entry fix on NameConverter.java, java_templates.tpl, B... Teodor Gorghe

06/26/2025

11:40 AM Feature #10190: Prototype the changes to the build to add ANTLR v4

> Instead of using the bundled AntlrTask from gradle(which was introducing the dependency conflict), we can manually ... Greg Shah

10:51 AM Feature #10190: Prototype the changes to the build to add ANTLR v4

Florin Eugen Rotaru wrote:
> * Added logic to exclude @org.ow2.asm@ dependency when running antlr4All.
>
> * Im... Florin Eugen Rotaru

10:09 AM Bug #10208: do not convert the schema in incremental mode if it hasn't changed

I don't object, but can we just add the schemata to the FILE_SIGNATURE table? Greg Shah

09:06 AM Bug #10208: do not convert the schema in incremental mode if it hasn't changed

As far as I can tell, there doesn't seem to be any information (e.g. hash) for the schema file in the cvtdb database.... Dănuț Filimon

07:23 AM Bug #10215: ant rpt fails when running only conversion.front

While testing @rpt@ I've found the following behavior: (clean hotel and clean trunk r16001)
* @ant rpt@ fails
* @an... Stefan Vieru

07:22 AM Bug #10215: ant rpt fails when running only conversion.front

Regression when running @ant rpt@:
Tested with trunk 15918, no issues here.
With trunk 15960 and onward the followi... Stefan Vieru

07:21 AM Bug #10215 (Test): ant rpt fails when running only conversion.front

Stefan Vieru

02:12 AM Bug #10185: ADE conversion and runtime

Committed revision *15997* on task branch *10185a*:
- Fixed compilation issues of @BROWSE:NO-EMPTY-SPACE@. The inter... Teodor Gorghe

06/25/2025

10:44 AM Feature #10190: Prototype the changes to the build to add ANTLR v4

Made an initial commit to *10190/15996*:
* Defined new antlr4 configuration for Antlr-related JARs.
* Added log... Florin Eugen Rotaru

08:17 AM Feature #10190: Prototype the changes to the build to add ANTLR v4

Florin Eugen Rotaru wrote:
> Tomasz Domin wrote:
> > Did you/Can you try upgrading ow2.asm instead of removing it ?... Tomasz Domin

08:15 AM Feature #10190: Prototype the changes to the build to add ANTLR v4

Tomasz Domin wrote:
> Florin Eugen Rotaru wrote:
Most likely, I don't see other cause for that dependency conflic... Florin Eugen Rotaru

07:39 AM Feature #10190: Prototype the changes to the build to add ANTLR v4

Florin Eugen Rotaru wrote:
> So it is probably a conflict (@ow2.asm@?).
Is @ow2.asm@ direct or indirect @antlr4@ de... Tomasz Domin

07:23 AM Feature #10190: Prototype the changes to the build to add ANTLR v4

Florin Eugen Rotaru wrote:
> I think the next steps are
>
> * Solve this conflict
I have managed to get the t... Florin Eugen Rotaru

10:17 AM Bug #10208: do not convert the schema in incremental mode if it hasn't changed

> Disabling M0 will need to be done only for the main db, and not the temp schemas.
Before #6083, we could imple... Greg Shah

10:00 AM Bug #10208: do not convert the schema in incremental mode if it hasn't changed

Greg Shah wrote:
> Can we just disable M0 in incremental mode?
The problem with is that for #9457 app, front-end sc... Constantin Asofiei

09:48 AM Bug #10208: do not convert the schema in incremental mode if it hasn't changed

Customers have reported that we always convert the schema in incremental mode (see #10175-26). For large projects, t... Greg Shah

09:00 AM Bug #10208 (Closed): do not convert the schema in incremental mode if it hasn't changed

Greg Shah

10:16 AM Feature #6083: schema (.df) changes in incremental conversion mode should only reconvert those pr...

In addition to calculating the non-schema dependencies for incremental mode, whatever changes to the schemata have be... Greg Shah

07:45 AM Bug #10185 (Review): ADE conversion and runtime

Committed revision *15995* on task branch *10185a*:
- Added a partial implementation of @WIDGET:UNIQUE-MATCH@.
- Ad... Teodor Gorghe

01:52 AM Bug #10185: ADE conversion and runtime

Committed revision *15994* on task branch *10185a*:
- Added conversion support for BUFFER:IS-PARTITIONED (currently ... Teodor Gorghe

06/24/2025

10:06 AM Feature #10190 (WIP): Prototype the changes to the build to add ANTLR v4

I have added the dependency for @antlr4@ in the *build.gradle*:... Florin Eugen Rotaru

06:52 AM Feature #5586: move all conversion artifacts/outputs into the cvtdb or into a dedicated directory...

I had to update a small part of the @getPathToConversionFolder@ method:... Stefan Vieru

05:13 AM Bug #10185: ADE conversion and runtime

I have added @adm2/query.p@ and it seems that we have:
@Unsupported method or attribute KW_IS_PART.@
I am investiga... Teodor Gorghe

04:32 AM Bug #10185: ADE conversion and runtime

With my initial conversion include files, it seems that there are no longer conversion issues. I will update this tas... Teodor Gorghe

02:17 AM Bug #10185: ADE conversion and runtime

Committed revision *15993* of task branch *10185a*:
- added runtime and conversion support for @BUFFER:HAS-LOBS@.
... Teodor Gorghe

03:37 AM Feature #6256 (Review): improved profile support

I've tested hotel with 2-4 profiles and found no other issues. Greg/Constantin, please review.
#6256-47 is already... Dănuț Filimon

06/23/2025

09:08 AM Feature #10190 (Closed): Prototype the changes to the build to add ANTLR v4

Florin Eugen Rotaru

08:23 AM Bug #10099 (Review): Tilde consumes the octals/follow-up characters, when in OE this doesn't happen

Greg, could you please take a look at my changes? Let me know if I should do anything else here. Stefan Vieru

08:21 AM Bug #10099: Tilde consumes the octals/follow-up characters, when in OE this doesn't happen

I've created r15995.
The change covers all the cases from above except:
* \
* ~
These characters are trickier t... Stefan Vieru

07:59 AM Feature #5586: move all conversion artifacts/outputs into the cvtdb or into a dedicated directory...

Stefan Vieru wrote:
> Greg, please let me know if I need to do anything else on this issue and if it's ready to be m... Greg Shah

07:23 AM Feature #5586: move all conversion artifacts/outputs into the cvtdb or into a dedicated directory...

Greg, please let me know if I need to do anything else on this issue and if it's ready to be merged. Stefan Vieru

03:13 AM Feature #5586: move all conversion artifacts/outputs into the cvtdb or into a dedicated directory...

Taking as an example @hotel_gui@ build.xml, we have to make changes to the following:
* @rpt-no-front@ - this ant co... Stefan Vieru

07:52 AM Bug #10185 (WIP): ADE conversion and runtime

On FWD, HAS-LOBS attribute is supported?
This is the cause of the second conversion problem on ADE.
@Unsupported me... Teodor Gorghe

04:14 AM Bug #10185: ADE conversion and runtime

I am attaching the conversion results for:
* {{Collapse(DATASET-HANDLE)
ABL:... Teodor Gorghe

02:58 AM Bug #10185: ADE conversion and runtime

Please check also:
* @DATASET-HANDLE@ argument type
* the handle array is an instance or static var in a .cls (not ... Constantin Asofiei

02:36 AM Bug #10185 (Review): ADE conversion and runtime

Teodor Gorghe

02:36 AM Bug #10185: ADE conversion and runtime

Committed revision *15992* on task branch *10185a*:
- Fixed @subscript@ wrapper on @new TableParameter()@ Teodor Gorghe

02:35 AM Bug #10185 (WIP): ADE conversion and runtime

Created task branch *10185a*. Teodor Gorghe

07:47 AM Bug #9918 (Review): tilde doesn't duplicate semicolon in alternative codings

Greg, if you could please review the changes and let me know if I can make some improvements. Right now with the test... Stefan Vieru

07:46 AM Bug #9918: tilde doesn't duplicate semicolon in alternative codings

I've created r15902 with the addition of @tildeOffset@ variable to environment.
The behavior would be the following:... Stefan Vieru

06/20/2025

02:12 PM Feature #4076: remove empty triggers during conversion

OK. I agree. Ovidiu Maxiniuc

07:49 AM Feature #4076: remove empty triggers during conversion

Ovidiu Maxiniuc wrote:
> After some thoughts, I think we can drop the empty triggers. If the 4GL programmer +really+... Greg Shah

06:10 AM Feature #4076: remove empty triggers during conversion

After some thoughts, I think we can drop the empty triggers. If the 4GL programmer +really+ wants to disable a normal... Ovidiu Maxiniuc

04:59 AM Feature #4076: remove empty triggers during conversion

The dangerous case here is when there are more than one trigger that exists with the same filename (and operating on ... Greg Shah

11:00 AM Feature #5586: move all conversion artifacts/outputs into the cvtdb or into a dedicated directory...

Start here and we will see where we move it. Greg Shah

10:52 AM Feature #5586: move all conversion artifacts/outputs into the cvtdb or into a dedicated directory...

Where will this documentation be? In this issue or on a different page?
I will look into which @ant@ commands are im... Stefan Vieru

08:44 AM Feature #5586: move all conversion artifacts/outputs into the cvtdb or into a dedicated directory...

Since we must provide guidance to customers on this shift, it is important that we prepare documentation and examples... Greg Shah

08:33 AM Feature #5586: move all conversion artifacts/outputs into the cvtdb or into a dedicated directory...

Greg Shah wrote:
> But don't we need to change the project-level @build.xml@ to process things like @clean@ in a dif... Stefan Vieru

08:26 AM Feature #5586: move all conversion artifacts/outputs into the cvtdb or into a dedicated directory...

But don't we need to change the project-level @build.xml@ to process things like @clean@ in a different location? Greg Shah

08:04 AM Feature #5586: move all conversion artifacts/outputs into the cvtdb or into a dedicated directory...

From what I remember no, in @p2j.cfg@ the cvtpath can be configured, but by default it has @cvt@.
Stefan Vieru

07:46 AM Feature #5586: move all conversion artifacts/outputs into the cvtdb or into a dedicated directory...

Please remind me: is there any requirement for scripting or configuration changes in the project cfg? Greg Shah

04:09 AM Feature #5586: move all conversion artifacts/outputs into the cvtdb or into a dedicated directory...

Greg, all regression testing passed. 5586a can be merged. Dănuț Filimon

07:16 AM Bug #10185: ADE conversion and runtime

When passing a value from extent to a procedure, with OUTPUT TEMP-HANDLE, on compilation we have this issue:... Teodor Gorghe

07:02 AM Bug #10185 (Test): ADE conversion and runtime

Teodor Gorghe

06/19/2025

05:58 AM Bug #9863: Fileset eXclude broken on native Windows

I added a comment in *9863a/15984*. Dănuț Filimon

05:37 AM Bug #9863 (Internal Test): Fileset eXclude broken on native Windows

> > It handles the @!filter.endsWith("/")@ case but don't we also need to handle the @filter.endsWith("/")@ case?
> ... Greg Shah

04:34 AM Bug #9863: Fileset eXclude broken on native Windows

I committed *9863a/15983*. Moved normalizeFilePath() to Utils, removed the unnecessary endsWith() call. Dănuț Filimon

02:00 AM Bug #9863: Fileset eXclude broken on native Windows

Greg Shah wrote:
> Code Review Task Branch 9863a Revisions 15980 through 15982
>
> The changes are good.
>
> 1... Dănuț Filimon

06/18/2025

03:27 PM Bug #9863: Fileset eXclude broken on native Windows

Code Review Task Branch 9863a Revisions 15980 through 15982
The changes are good.
1. I wonder if @FLF.normalize... Greg Shah

12:59 PM Bug #9917 (Internal Test): Fileset not ignoring case

OK, good. Greg Shah

09:18 AM Bug #9917: Fileset not ignoring case

Greg Shah wrote:
> Code Review Task Branch 9917a Revisions 15969 through 15971
>
> Overall, the changes seem reas... Dănuț Filimon

08:38 AM Bug #9917: Fileset not ignoring case

Code Review Task Branch 9917a Revisions 15969 through 15971
Overall, the changes seem reasonable.
My only quest... Greg Shah

02:47 AM Bug #9917: Fileset not ignoring case

Dănuț Filimon wrote:
> I will be running a conversion today with the same customer application that failed previousl... Dănuț Filimon

09:50 AM Feature #6256: improved profile support

Committed *6256a/15945*. Fixed the two issues I found when converting hotel using multiple profiles. Dănuț Filimon

06/17/2025

08:35 AM Feature #6256: improved profile support

I fixed the problem by removing the bit of code that checks for @isMultiProfile()@, this was added in:... Dănuț Filimon

06:01 AM Feature #6256: improved profile support

The issue is related to @TransformDriver.createDatabaseList()@ where the "standard" namespace is not taken into consi... Dănuț Filimon

04:44 AM Bug #10099 (WIP): Tilde consumes the octals/follow-up characters, when in OE this doesn't happen

Stefan Vieru

02:54 AM Bug #9917: Fileset not ignoring case

I will be running a conversion today with the same customer application that failed previously. Dănuț Filimon

02:36 AM Feature #5586: move all conversion artifacts/outputs into the cvtdb or into a dedicated directory...

The project was converted and built successfully. Dănuț Filimon

06/16/2025

06:24 AM Feature #6256: improved profile support

The issue is that there are three profiles and the two profiles that do not define a namespace for the hotel, do not ... Dănuț Filimon

06:20 AM Feature #5586: move all conversion artifacts/outputs into the cvtdb or into a dedicated directory...

You can start, I have nothing to add for now. Stefan Vieru

06:18 AM Feature #5586: move all conversion artifacts/outputs into the cvtdb or into a dedicated directory...

Stefan, is there anything else you need to add to the branch? I want to pick this up and run a customer conversion. Dănuț Filimon

04:37 AM Bug #9863 (Review): Fileset eXclude broken on native Windows

I created a @FileListFactory.normalizeFilePath()@ method and tested the following:
# @D ./abl/tmp/ *.p@ => @abl/tmp@... Dănuț Filimon

06/13/2025

09:12 AM Bug #9863: Fileset eXclude broken on native Windows

We still need to canonicalize the result. Please write a version of the processing that can handle it. Greg Shah

08:08 AM Bug #9863: Fileset eXclude broken on native Windows

Greg Shah wrote:
> > I'm also wondering if we should account for @..@ in the filters?
>
> Canonicalization whould... Dănuț Filimon

08:06 AM Bug #9863: Fileset eXclude broken on native Windows

> I'm also wondering if we should account for @..@ in the filters?
Canonicalization whould deal with things like @... Greg Shah

07:57 AM Bug #9863: Fileset eXclude broken on native Windows

Dănuț Filimon wrote:
> Some cases I tested/will test:
> # @D ./abl/tmp/@ : at row 1 in file zfile_set.txt is malfor... Dănuț Filimon

07:56 AM Bug #9863: Fileset eXclude broken on native Windows

Committed *9863a/15981*. Summary of the changes:
* Paths should replace "\\" with "/" before any processing is done,... Dănuț Filimon

06:51 AM Bug #9863: Fileset eXclude broken on native Windows

Greg Shah wrote:
> > Currently @X ./abl/tmp/@ does nothing. It will not exclude any files from the specified folder ... Dănuț Filimon

06:41 AM Bug #9863: Fileset eXclude broken on native Windows

> Currently @X ./abl/tmp/@ does nothing. It will not exclude any files from the specified folder since the pattern wi... Greg Shah

06:08 AM Bug #9863: Fileset eXclude broken on native Windows

Currently @X ./abl/tmp/@ does nothing. It will not exclude any files from the specified folder since the pattern will... Dănuț Filimon

06:07 AM Bug #9863: Fileset eXclude broken on native Windows

Greg Shah wrote:
> Dănuț Filimon wrote:
> > Greg Shah wrote:
> > > > I am sure we do not want to add a feature whi... Dănuț Filimon

06:06 AM Bug #9863: Fileset eXclude broken on native Windows

Dănuț Filimon wrote:
> Greg Shah wrote:
> > > I am sure we do not want to add a feature which didn't exist before.
... Greg Shah

06:02 AM Bug #9863: Fileset eXclude broken on native Windows

Greg Shah wrote:
> > I am sure we do not want to add a feature which didn't exist before.
>
> Is it a new feature... Dănuț Filimon

05:59 AM Bug #9863: Fileset eXclude broken on native Windows

> I am sure we do not want to add a feature which didn't exist before.
Is it a new feature? Or is it just making ... Greg Shah

03:27 AM Bug #9863: Fileset eXclude broken on native Windows

Dănuț Filimon wrote:
> Additional note for #9863-43, @Utils.canonicalizePath()@ doesn't work for @.//abl//tmp//*@ bu... Dănuț Filimon

06:10 AM Feature #6256: improved profile support

Greg Shah wrote:
> > I don't think two profiles should have the same namespace defined (with the same name).
>
> ... Dănuț Filimon

06:02 AM Feature #6256: improved profile support

> I don't think two profiles should have the same namespace defined (with the same name).
Correct. Such a thing i... Greg Shah

05:47 AM Feature #6256: improved profile support

Greg, the issue with #6256-84 is that I've defined the following namespace for both profiles:... Dănuț Filimon

04:38 AM Feature #6256: improved profile support

Committed *6256a/15944*. Added PROFILE mode.
Currently looking into the error from #6256-84. Dănuț Filimon

02:29 AM Feature #6256: improved profile support

Greg Shah wrote:
> > There is a problem when the 'exclude' filter is used to not add files to conversion. During pr... Constantin Asofiei

06/12/2025

09:26 AM Bug #9863: Fileset eXclude broken on native Windows

Greg Shah wrote:
> > If I replace the '\\' with '/', the only problem will be the pattern because the files in Windo... Dănuț Filimon

09:01 AM Bug #9863: Fileset eXclude broken on native Windows

Greg Shah wrote:
> Normally, we use things like @Utils.canonicalizePath()@ to eliminate the excess nonsense like @so... Dănuț Filimon

09:00 AM Bug #9863: Fileset eXclude broken on native Windows

Greg Shah wrote:
> > If I replace the '\\' with '/', the only problem will be the pattern because the files in Windo... Dănuț Filimon

08:56 AM Bug #9863: Fileset eXclude broken on native Windows

Dănuț Filimon wrote:
> Greg, is the scenario [...] something that should be supported? Using a single \ instead of \... Greg Shah

08:52 AM Bug #9863: Fileset eXclude broken on native Windows

> If I replace the '\\' with '/', the only problem will be the pattern because the files in Windows will be using '\'... Greg Shah

08:29 AM Bug #9863: Fileset eXclude broken on native Windows

Dănuț Filimon wrote:
> Greg, is the scenario [...] something that should be supported? Using a single \ instead of \... Dănuț Filimon

07:58 AM Bug #9863: Fileset eXclude broken on native Windows

Greg, is the scenario ... Dănuț Filimon

07:03 AM Bug #9863: Fileset eXclude broken on native Windows

If I replace the '\\' with '/', the only problem will be the pattern because the files in Windows will be using '\' a... Dănuț Filimon

03:04 AM Bug #9863 (WIP): Fileset eXclude broken on native Windows

I'll work on #9863-33 to #9863-35. Dănuț Filimon

08:41 AM Bug #6308: post string literal alternative coding quirk in 4GL preprocessor

OK, good. Greg Shah

02:24 AM Bug #6308: post string literal alternative coding quirk in 4GL preprocessor

Greg Shah wrote:
> > The cause is that after the @&THEN@ of the first @&IF@, we set @InStatement@ on false.
> > Rem... Stefan Vieru

03:03 AM Feature #6256 (WIP): improved profile support

Greg Shah wrote:
> > These profiles can only be used in the default @ConversionDriver@ mode which is @ListType.CMD_L... Dănuț Filimon

06/11/2025

02:58 PM Bug #6308: post string literal alternative coding quirk in 4GL preprocessor

> The cause is that after the @&THEN@ of the first @&IF@, we set @InStatement@ on false.
> Removing this fixed the i... Greg Shah

04:42 AM Bug #6308: post string literal alternative coding quirk in 4GL preprocessor

The changes in the current version include the following, after @ASTMT@... Stefan Vieru

02:42 PM Bug #9863: Fileset eXclude broken on native Windows

Code Review Task Branch 9863a Revision 15979
The change @filter = filter.replace('/', File.separatorChar);@ seems ... Greg Shah

01:26 PM Bug #9863: Fileset eXclude broken on native Windows

> Let me know if I should work on supporting the @X ./abl/folder1/@ filter in this task, I will adjust the %Done if s... Greg Shah

11:34 AM Bug #9863: Fileset eXclude broken on native Windows

Dănuț Filimon wrote:
> Roger/Greg, please review.
I won't be able to really test until I get back to my Windows lap... Roger Borrello

03:45 AM Bug #9863 (Review): Fileset eXclude broken on native Windows

Created *9863a* from latest *trunk/15978* and committed *9863a/15979*. The commit contains the fix for fileset eXclud... Dănuț Filimon

02:23 PM Feature #6256: improved profile support

> These profiles can only be used in the default @ConversionDriver@ mode which is @ListType.CMD_LINE@. For any of th... Greg Shah

01:48 PM Feature #6256: improved profile support

> There is a problem when the 'exclude' filter is used to not add files to conversion. During pre-scan phase, the fi... Greg Shah

06/10/2025

08:55 AM Bug #9863: Fileset eXclude broken on native Windows

We've been canonicalizing filenames to use @/@ on Windows in the past and had not found this limitation. Greg Shah

08:47 AM Bug #9863: Fileset eXclude broken on native Windows

On Windows, even if the path is ./abl/, it will make it into @.\abl@ when calling @new File(path)@, disregarding the ... Dănuț Filimon

07:05 AM Bug #9863: Fileset eXclude broken on native Windows

Greg Shah wrote:
> The patterns should not be file-system specific. In fact, we should only support the @/@ as the ... Dănuț Filimon

07:01 AM Bug #9863: Fileset eXclude broken on native Windows

The patterns should not be file-system specific. In fact, we should only support the @/@ as the path separator. The... Greg Shah

05:54 AM Bug #9863: Fileset eXclude broken on native Windows

Replacing the "/" with the file separator in step 2 will make the filter match the ".\" (@./abl/fwd-embedded-driver.p... Dănuț Filimon

05:18 AM Bug #9863: Fileset eXclude broken on native Windows

I used the following zset:... Dănuț Filimon

07:06 AM Feature #5586: move all conversion artifacts/outputs into the cvtdb or into a dedicated directory...

I have updated: r15976 Stefan Vieru

06:52 AM Feature #5586: move all conversion artifacts/outputs into the cvtdb or into a dedicated directory...

Got it, will remove this logging and will retain the null checks that have been found until now. I will create a comm... Stefan Vieru

06:50 AM Feature #5586: move all conversion artifacts/outputs into the cvtdb or into a dedicated directory...

Returning @null@ will likely result in an NPE and we will see the stack trace already. Greg Shah

06:48 AM Feature #5586: move all conversion artifacts/outputs into the cvtdb or into a dedicated directory...

Or maybe enable this logging when in @p2j.cfg.xml@ there is a "debugging" parameter set on true. Stefan Vieru

03:44 AM Feature #5586: move all conversion artifacts/outputs into the cvtdb or into a dedicated directory...

Okay, will check for null calls and make sure these are bypassed. I kept the null checks in @visitAst@ which have bee... Stefan Vieru

06/09/2025

10:39 AM Feature #5630 (Closed): add missing classes referenced during parsing to the conversion list in f...

Greg Shah

10:39 AM Bug #6082 (Closed): automatically add to conversion list all non-skeleton .cls dependencies

Greg Shah

06/06/2025

11:24 AM Feature #5586: move all conversion artifacts/outputs into the cvtdb or into a dedicated directory...

In those cases, we should not call @getPathToConversionFolder()@. Just bypass it when the input is @null@. In other... Greg Shah

09:49 AM Feature #5586: move all conversion artifacts/outputs into the cvtdb or into a dedicated directory...

The functions in #5586-77, the @visitAst@ methods.
In the case of @com.goldencode.p2j.uast.SymbolResolver#loadClass... Stefan Vieru

09:37 AM Feature #5586: move all conversion artifacts/outputs into the cvtdb or into a dedicated directory...

> I have found that there are many places that might call getPathToConversionFolder with a null filename
This seem... Greg Shah

08:59 AM Feature #5586: move all conversion artifacts/outputs into the cvtdb or into a dedicated directory...

While testing the latest revision I have found that there are many places that might call @getPathToConversionFolder@... Stefan Vieru

10:17 AM Feature #6319: IntelliJ plugin

I see that the IntelliJ LSP support isn't maintained anymore. Also, according to "jetbrains":https://plugins.jetbrain... Florin Eugen Rotaru

07:15 AM Bug #9863: Fileset eXclude broken on native Windows

I managed to setup the w11 vm and reproduce the issue. Currently investigating. Dănuț Filimon

04:54 AM Bug #9863: Fileset eXclude broken on native Windows

Șerban Bursuc wrote:
> Dănuț Filimon wrote:
> > Roger, is there a minimal requirement for the w11 vm? I've made min... Dănuț Filimon

04:53 AM Bug #9863: Fileset eXclude broken on native Windows

Dănuț Filimon wrote:
> Roger, is there a minimal requirement for the w11 vm? I've made mine with 4gb base memory and... Șerban Bursuc

04:45 AM Bug #9863: Fileset eXclude broken on native Windows

Roger, is there a minimal requirement for the w11 vm? I've made mine with 4gb base memory and 2 processors and it han... Dănuț Filimon

02:49 AM Bug #9863: Fileset eXclude broken on native Windows

Roger Borrello wrote:
> Dănuț Filimon wrote:
> > Hi Roger, I am trying to setup a Windows11 instance to start worki... Dănuț Filimon

06/05/2025

11:35 AM Bug #9863: Fileset eXclude broken on native Windows

Dănuț Filimon wrote:
> Hi Roger, I am trying to setup a Windows11 instance to start working on this issue and have b... Roger Borrello

06:17 AM Bug #9863: Fileset eXclude broken on native Windows

Hi Roger, I am trying to setup a Windows11 instance to start working on this issue and have been meeting with some is... Dănuț Filimon

10:09 AM Feature #5586: move all conversion artifacts/outputs into the cvtdb or into a dedicated directory...

> Created r15974 with the following changes:
Please add comments to these code locations to explain that @// these... Greg Shah

08:26 AM Feature #5586: move all conversion artifacts/outputs into the cvtdb or into a dedicated directory...

Stefan, I mentioned in our weekly meeting that I plan to run a conversion on a customer project. At the moment, the i... Dănuț Filimon

08:25 AM Feature #5586: move all conversion artifacts/outputs into the cvtdb or into a dedicated directory...

Also added r15975 which removes a redundant null check from @getPathToConversionFolder@. This check has been moved in... Stefan Vieru

06:46 AM Feature #5586: move all conversion artifacts/outputs into the cvtdb or into a dedicated directory...

Created r15974 with the following changes:... Stefan Vieru

02:28 AM Feature #5586: move all conversion artifacts/outputs into the cvtdb or into a dedicated directory...

Ovidiu Maxiniuc wrote:
> I think you should simply ignore these locations. These "in-mem" files are volatile resourc... Stefan Vieru

08:45 AM Bug #10099: Tilde consumes the octals/follow-up characters, when in OE this doesn't happen

When preprocessing the following test: (same behavior is present with @~@ directly)... Stefan Vieru

08:39 AM Bug #10099 (Internal Test): Tilde consumes the octals/follow-up characters, when in OE this doesn...

Stefan Vieru

08:40 AM Bug #9917 (Review): Fileset not ignoring case

Committed *9917a/14971*. Use Set instead of List for listImpl() and sortFiles() + a few small changes. Dănuț Filimon

08:00 AM Bug #9917: Fileset not ignoring case

I rebased *9917a* to latest *trunk/15967*, the branch is now at revision *15970*.
I plan to commit the change for... Dănuț Filimon

04:22 AM Bug #9917: Fileset not ignoring case

I committed *9917a/15947*. This only contains changes for the frame and menu issue, the idea is that in @convertSourc... Dănuț Filimon

06/04/2025

05:20 PM Feature #5586: move all conversion artifacts/outputs into the cvtdb or into a dedicated directory...

I think you should simply ignore these locations. These "in-mem" files are volatile resources, not related to static ... Ovidiu Maxiniuc

08:05 AM Feature #5586: move all conversion artifacts/outputs into the cvtdb or into a dedicated directory...

Ovidiu Maxiniuc wrote:
> I have looked at +5586a / r15973+.
>
> While I agree with using the constant suffixes fo... Stefan Vieru

02:48 PM Bug #6082: automatically add to conversion list all non-skeleton .cls dependencies

Greg Shah wrote:
> What other related features are still not complete? The intention here is to resolve the problem... Eduard Soltan

02:03 PM Bug #6082: automatically add to conversion list all non-skeleton .cls dependencies

What other related features are still not complete? The intention here is to resolve the problem that explciitly or ... Greg Shah

02:06 PM Feature #5630: add missing classes referenced during parsing to the conversion list in file list ...

For now, that approach does resolve this issue. In the future, we would also want to be able to use the annotations ... Greg Shah

11:56 AM Bug #9917: Fileset not ignoring case

> I'd expect the right start.p to be selected here. What do you think Greg?
Yes. On a case-insensitive approach, ... Greg Shah

09:34 AM Bug #9917: Fileset not ignoring case

Dănuț Filimon wrote:
> [...]
>
> This fixes the issue, but I've just found an issue.
>
> Scenarios:
> # zfile... Roger Borrello

09:30 AM Bug #9917: Fileset not ignoring case

... Dănuț Filimon

08:10 AM Bug #9917 (WIP): Fileset not ignoring case

Dănuț Filimon wrote:
> I think the naming convention for frames should be changed. When handling a frame with the na... Dănuț Filimon

03:59 AM Bug #9917: Fileset not ignoring case

I think the naming convention for frames should be changed. When handling a frame with the name @test-form@, the name... Dănuț Filimon

03:33 AM Bug #9917: Fileset not ignoring case

I ran a conversion for a customer application that uses case-sensitive = false and it failed.
The scenario:
* 715... Dănuț Filimon

06/03/2025

02:30 PM Feature #5630: add missing classes referenced during parsing to the conversion list in file list ...

Greg Shah wrote:
> We probably also should implement this even in blacklist mode. In other words: what should we do ... Eduard Soltan

08:15 AM Feature #5630: add missing classes referenced during parsing to the conversion list in file list ...

Does trunk rev 15852 (changes from #7255) resolve this task? Greg Shah

02:24 PM Bug #6082: automatically add to conversion list all non-skeleton .cls dependencies

Greg Shah wrote:
> Does trunk rev 15852 (changes from #7255) resolve this task?
If the scope of this task is stri... Eduard Soltan

08:15 AM Bug #6082: automatically add to conversion list all non-skeleton .cls dependencies

Does trunk rev 15852 (changes from #7255) resolve this task? Greg Shah

01:36 PM Feature #5586: move all conversion artifacts/outputs into the cvtdb or into a dedicated directory...

I have looked at +5586a / r15973+.
While I agree with using the constant suffixes for file types, I do not think w... Ovidiu Maxiniuc

08:56 AM Feature #6256: improved profile support

Greg Shah wrote:
> Are you sure that the requirements of #6256-47 and #6256-50 are already handled? I didn't think ... Dănuț Filimon

08:41 AM Feature #6256: improved profile support

Code Review Task Branch 6256a Revisions 15942 and 15943
The change is good.
Are you sure that the requirements ... Greg Shah

07:53 AM Feature #6256 (Review): improved profile support

Indeed, BarTest.cls is added during the @Scanning Progress Source (preprocessor, lexer, parser, persist ASTs)@ step.
... Dănuț Filimon

05:06 AM Feature #6256: improved profile support

Constantin Asofiei wrote:
> No, @X@ directive works only with @./abl/@ paths - there can't be relative paths.
>
>... Eduard Soltan

03:23 AM Feature #6256: improved profile support

A breakdown of the remaining parameters:
* includeRemap: #6256-76 is really helpful, I also found that the tag is no... Dănuț Filimon

06/02/2025

11:25 AM Feature #6256: improved profile support

I don't remember that code. It isn't currently used in the project associated with #4069.
Still, if it was needed... Greg Shah

10:53 AM Feature #6256: improved profile support

@includeRemap@ is from:... Constantin Asofiei

10:43 AM Feature #6256: improved profile support

> > I updated https://proj.goldencode.com/projects/p2j/wiki/Chapter_6_Project_Setup#Profiles, but I am not sure how t... Greg Shah

09:46 AM Feature #6256: improved profile support

Constantin Asofiei wrote:
> > * paths: ?
This is the PROPATH for the profile.
Constantin Asofiei

09:45 AM Feature #6256: improved profile support

Dănuț Filimon wrote:
> I updated https://proj.goldencode.com/projects/p2j/wiki/Chapter_6_Project_Setup#Profiles, but... Constantin Asofiei

09:37 AM Feature #6256: improved profile support

Dănuț Filimon wrote:
> Dănuț Filimon wrote:
> > I also want to add the following scenario:
> > * When there is a *... Constantin Asofiei

09:34 AM Feature #6256: improved profile support

Dănuț Filimon wrote:
> I also want to add the following scenario:
> * When there is a *default* profile defined, bu... Dănuț Filimon

07:55 AM Feature #6256: improved profile support

I updated https://proj.goldencode.com/projects/p2j/wiki/Chapter_6_Project_Setup#Profiles, but I am not sure how to de... Dănuț Filimon

06:43 AM Feature #6256: improved profile support

Constantin Asofiei wrote:
> If profiles are used, then:
> * if the profile has a fileset, then that is used
> * if... Dănuț Filimon

06:12 AM Feature #6256: improved profile support

I committed *6256a/15492*. Ignore the -z fileset, but only when there's a profile fileset specified. Dănuț Filimon